remove unneeded includes; ok miod@

Make ifq and ifiq interface MP safe.

Rename ifq_set_maxlen() to ifq_init_maxlen(). This function neither
uses WRITE_ONCE() nor a mutex and is called before the ifq mutex
is initialized. The new name expresses that it should be used only
during interface attach when there is no concurrency.

Protect ifq_len(), ifq_empty(), ifiq_len(), and ifiq_empty() with
READ_ONCE(). They can be used without lock as they only read a
single integer.

OK dlg@

Constify struct cfattach.

spelling
feedback and ok tb@ jmc@ ok ratchov@

Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.

ok dlg@ tobhe@

Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the
"new" API.

ok dlg@ tobhe@

consistently uppercase pci product defines

ok mpi@

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

G/C IFQ_SET_READY().

replace IFF_OACTIVE manipulation with mpsafe operations.

there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.

IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.

instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.

this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.

ok kettenis@ mpi@ jmatthew@ deraadt@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

rework vge_start to avoid IFQ_POLL

firstly, this checks for space in the tx ring before looking at the
send queue. if there's no space, then IFF_OACTIVE is set and break.

if there's space use IFQ_DEQUEUE to pull a packet off. if we fail
to encapsulate it, it gets dropped.

encap has been changed so the dmamaps the mbufs are loaded into are
created with 7 segments instead of 32. this means we detect when
the packet would overflow the tx descriptor at dmamap load time,
rather than after we've looped over the segments writing them into
the descriptor. we now use m_defrag to defrag the mbuf instead of
allocating a new one and using m_copydata.

now if we have any encap error on the first mbuf, we no longer set
IFF_OACTIVE and wait for an interrupt that never comes to clear it.

testing and (excellent) code review by richard proctor

Do not include <net/if_vlan_var.h> when it's not necessary.

Because of the VLAN hacks in mpw(4) this file still contains the definition
of "struct ifvlan" which depends on <sys/refcnt.h> which in turns pull
<sys/atomic.h>...

arp_ifinit() is no longer needed.

Make room for media types of the future. Extend the ifmedia word to 64 bits.
This changes numbers of the SIOCSIFMEDIA and SIOCGIFMEDIA ioctls and
grows struct ifmediareq.

Old ifconfig and dhclient binaries can still assign addresses, however
the 'media' subcommand stops working. Recompiling ifconfig and dhclient
with new headers before a reboot should not be necessary unless in very
special circumstances where non-default media settings must be used to
get link and console access is not available.

There may be some MD fallout but that will be cleared up later.

ok deraadt miod
with help and suggestions from several sharks attending l2k15

Increment if_ipackets in if_input().

Note that pseudo-drivers not using if_input() are not affected by this
conversion.

ok mikeb@, kettenis@, claudio@, dlg@

Now that if_input() set the receiving interface pointer on mbufs for us
there's no need to do it in m_devget(9).

Stop passing an ``ifp'' will help for upcoming interface pointer -> index
conversion.

While here remove unused ``ifp'' argument from m_clget(9) and kill two
birds^W layer violations in one commit.

ok henning@

Convert to if_input().

ok dlg@

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

unifdef INET

Fewer <netinet/in_systm.h>

get rid of the copy argument in m_devget that let you provide an
alternative to bcopy since noone uses it.

while there use memcpy instead of bcopy because we know the memory cannot
overlap.

ok henning@ matthew@ mikeb@ deraadt@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Rewrite receive filter handling and ioctl bits.

ok sthen@

Add some missing bits for flow control support and enable it.

Tested with PCI and PCIe vge(4).

ok sthen@

Remove setting an initial assumed baudrate upon driver attach which is not
necessarily correct, there might not even be a link when attaching.

ok mikeb@ reyk@

set ifp->if_baudrate with IF_Gbps() / IF_Mbps().

OK reyk@ sthen@

kill a few more casts that aren't helpful. ok krw miod

mechanic rename M_{TCP|UDP}V4_CSUM_OUT -> M_{TCP|UDP}_CSUM_OUT
ok claudio krw

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

remove the unused if_init callback in struct ifnet
ok deraadt@ henning@ claudio@

Don't print "EEPROM reload timed out" message. Devices that don't have an
EEPROM exist (RouterBOARD RB600A) and reloading default values from the
EEPROM will fail on those decives.

ok deraadt@

Make vge(4) detachable.

ok jsg@, deraadt@

Make sure the MAC address is correct on big-endian platforms if it isn't read
from the EEPROM.

ok miod@

- consistify cfdriver for the ethernet drivers (0 -> NULL)

ok dlg@

Eliminate the redundant bits of code for MTU and multicast handling
from the individual drivers now that ether_ioctl() handles this.

Shrinks the i386 kernels by..
RAMDISK - 2176 bytes
RAMDISKB - 1504 bytes
RAMDISKC - 736 bytes

Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users.
Build tested on almost all archs by todd@/brad@

ok naddy@

Introduce bpf_mtap_ether(), which for the benefit of bpf listeners
creates the VLAN encapsulation from the tag stored in the mbuf
header. Idea from FreeBSD, input from claudio@ and canacar@.

Switch all hardware VLAN enabled drivers to the new function.

ok claudio@

Re-add support TX VLAN tag insertion and RX VLAN tag stripping.

Tested by Dawe <dawedawe at gmx dot de>

Change m_devget()'s outdated and unused "offset" argument: It is
now the offset into the first mbuf of the target chain before copying
the source data over. From FreeBSD.

Convert drivers' use of m_devget(). Mostly from thib@.

Update mbuf(9) man page.

ok claudio@, thib@

First step towards cleaning up the Ethernet driver ioctl handling.
Move calling ether_ioctl() from the top of the ioctl function, which
at the moment does absolutely nothing, to the default switch case.
Thus allowing drivers to define their own ioctl handlers and then
falling back on ether_ioctl(). The only functional change this results
in at the moment is having all Ethernet drivers returning the proper
errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown
ioctl's.

Shrinks the i386 kernels by..
RAMDISK - 1024 bytes
RAMDISKB - 1120 bytes
RAMDISKC - 832 bytes

Tested by martin@/jsing@/todd@/brad@
Build tested on almost all archs by todd@/brad@

ok jsing@

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

More timeout(9) usage cleaned up.

ok claudio

Since Ethernet links can only be full duplex or half duplex the link
state reporting code in the MII layer / em(4) and vge(4) will never
fall back to the point of only reporting the link as being UP without
the duplex setting being reported, so simplify the code a bit here.

ok dlg@

- Remove disabled and unusable HW VLAN tagging code.
- Remove setup of the HW VLAN stripping.

Issue reported by and fix tested by henric@

ok dlg@

Fix some obviously bogus code in vge_newbuf(). Should fix PR 5582.

ok claudio@

Missing braces in vge_tick(). Fixes link state announcements.
ok reyk@

report full/half duplex state for non-MII interfaces

ok brad@

OpenBSD-ify the HW VLAN tag insertion code.

don't always leave the mbuf on the if_snd queue if vge_encap() fails.
if the mbuf is coalesced in vge_encap(), the mbuf reference is no
longer valid. drop the mbuf in this case.

bug introduced in r1.28
tested by Frank Denis
fixes kernel/5291

"go for it" deraadt@

s/Mhz/MHz/ in comments and printf() strings

ok jsg@

don't use IF_PREPEND() on altq's.
use IFQ_POLL()/IFQ_DEQUEUE() logic instead as described in altq(4).

tested by jolan@ on macppc
"diffs look ok" brad@

do not bother playing tag with the PCI_COMMAND_STATUS_REG

tested by jolan@, ok brad@

add sys/timeout.h

rev 1.13 fixed the MTU ioctl handler to allow adjusting the MTU
but it seems Jumbo support is broken, so disable Jumbos for now.

issue reported by jolan@

- remove ETHER_MAX_LEN_JUMBO and ETHERMTU_JUMBO.
- use if_hardmtu for MTU ioctl handlers.

ok reyk@

unknown ioctl is ENOTTY not EINVAL

remove IFCAP_JUMBO_MTU interface capabilities flag and set if_hardmtu in a few
more drivers.

ok reyk@

set if_jumbo_mtu and the IFCAP_JUMBO_MTU capabilities flag where
appropriate.

ok reyk@

allow bpf(4) to ignore packets based on their direction (inbound or
outbound), using a new BIOCSDIRFILT ioctl;
guidance, feedback and ok canacar@

de-register.

- splimp -> splnet
- remove spl's from attach
- removing redundant checks before pci_mapreg_map()
- fix dmesg printing
- de-allocate resources on failure to attach
- remove unused VLAN input code from vge(4)

Some fixes for vge(4)'s multicast handling, including..

- Fix IFF_ALLMULTI handling
- Stop endless loop in multicast hash table filter mode

From christos NetBSD

ok pvalchev@

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

enable use of the hardware 64 entry CAM table for perfect multicast
filtering otherwise fallback on the multicast hash table if trying to
filter on more than 64 addresses or if we're trying to flip on ALLMULTI.

enable HW transmit checksum offload

ok pvalchev@

- Add missing break for SIOCSIFADDR
- Allow setting the MTU

ok pvalchev@

- Correct the if_link_state_change() logic.
- Reading the EEPROM to learn the station address doesn't seem to work
on boards with VIA gigE controllers that are embedded in VIA chipsets.
Presumably, they don't have an external EEPROM and store the MAC
address somewhere else. To get around this, read the station
address from the RX filter registers instead. This has been tested
to work on both embedded and standalone controllers.

From FreeBSD

ok pvalchev@

csum -> csum_flags

ok krw@ canacar@

fix parenthesis

- enable reception of VLAN sized frames
- enable HW receive checksum offload

ok pvlachev@

make use of if_link_state_change().

From FreeBSD

ok pvalchev@

use IFQ_ rather than IF_ macro here too, maybe helps altq; ok henning

make sure interface is in RUNNING state before touching the multicast filters

From NetBSD

NetBSD PR 27678 for details

ok mcbride@

remove useless debugging leftover

Bounce the mbuf to the BPF listener before committing it to the wire
in the TX case, fixes rare problems associated with accessing already
free'd memory if the encap routine bails out (panic in PROMISC mode).
ok deraadt

htole32 and friends to get this working on big endian (macppc)

a hack to read MAC address correctly on big endian; ok drahn
however a correct clean way to do this should be found

VIA VT612x PCI Gigabit Ethernet adapter support, ok deraadt
from FreeBSD

Make ifq and ifiq interface MP safe.

Rename ifq_set_maxlen() to ifq_init_maxlen(). This function neither
uses WRITE_ONCE() nor a mutex and is called before the ifq mutex
is initialized. The new name expresses that it should be used only
during interface attach when there is no concurrency.

Protect ifq_len(), ifq_empty(), ifiq_len(), and ifiq_empty() with
READ_ONCE(). They can be used without lock as they only read a
single integer.

OK dlg@

Constify struct cfattach.

spelling
feedback and ok tb@ jmc@ ok ratchov@

Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.

ok dlg@ tobhe@

Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the
"new" API.

ok dlg@ tobhe@

consistently uppercase pci product defines

ok mpi@

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

G/C IFQ_SET_READY().

replace IFF_OACTIVE manipulation with mpsafe operations.

there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.

IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.

instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.

this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.

ok kettenis@ mpi@ jmatthew@ deraadt@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

rework vge_start to avoid IFQ_POLL

firstly, this checks for space in the tx ring before looking at the
send queue. if there's no space, then IFF_OACTIVE is set and break.

if there's space use IFQ_DEQUEUE to pull a packet off. if we fail
to encapsulate it, it gets dropped.

encap has been changed so the dmamaps the mbufs are loaded into are
created with 7 segments instead of 32. this means we detect when
the packet would overflow the tx descriptor at dmamap load time,
rather than after we've looped over the segments writing them into
the descriptor. we now use m_defrag to defrag the mbuf instead of
allocating a new one and using m_copydata.

now if we have any encap error on the first mbuf, we no longer set
IFF_OACTIVE and wait for an interrupt that never comes to clear it.

testing and (excellent) code review by richard proctor

Do not include <net/if_vlan_var.h> when it's not necessary.

Because of the VLAN hacks in mpw(4) this file still contains the definition
of "struct ifvlan" which depends on <sys/refcnt.h> which in turns pull
<sys/atomic.h>...

arp_ifinit() is no longer needed.

Make room for media types of the future. Extend the ifmedia word to 64 bits.
This changes numbers of the SIOCSIFMEDIA and SIOCGIFMEDIA ioctls and
grows struct ifmediareq.

Old ifconfig and dhclient binaries can still assign addresses, however
the 'media' subcommand stops working. Recompiling ifconfig and dhclient
with new headers before a reboot should not be necessary unless in very
special circumstances where non-default media settings must be used to
get link and console access is not available.

There may be some MD fallout but that will be cleared up later.

ok deraadt miod
with help and suggestions from several sharks attending l2k15

Increment if_ipackets in if_input().

Note that pseudo-drivers not using if_input() are not affected by this
conversion.

ok mikeb@, kettenis@, claudio@, dlg@

Now that if_input() set the receiving interface pointer on mbufs for us
there's no need to do it in m_devget(9).

Stop passing an ``ifp'' will help for upcoming interface pointer -> index
conversion.

While here remove unused ``ifp'' argument from m_clget(9) and kill two
birds^W layer violations in one commit.

ok henning@

Convert to if_input().

ok dlg@

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

unifdef INET

Fewer <netinet/in_systm.h>

get rid of the copy argument in m_devget that let you provide an
alternative to bcopy since noone uses it.

while there use memcpy instead of bcopy because we know the memory cannot
overlap.

ok henning@ matthew@ mikeb@ deraadt@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Rewrite receive filter handling and ioctl bits.

ok sthen@

Add some missing bits for flow control support and enable it.

Tested with PCI and PCIe vge(4).

ok sthen@

Remove setting an initial assumed baudrate upon driver attach which is not
necessarily correct, there might not even be a link when attaching.

ok mikeb@ reyk@

set ifp->if_baudrate with IF_Gbps() / IF_Mbps().

OK reyk@ sthen@

kill a few more casts that aren't helpful. ok krw miod

mechanic rename M_{TCP|UDP}V4_CSUM_OUT -> M_{TCP|UDP}_CSUM_OUT
ok claudio krw

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

remove the unused if_init callback in struct ifnet
ok deraadt@ henning@ claudio@

Don't print "EEPROM reload timed out" message. Devices that don't have an
EEPROM exist (RouterBOARD RB600A) and reloading default values from the
EEPROM will fail on those decives.

ok deraadt@

Make vge(4) detachable.

ok jsg@, deraadt@

Make sure the MAC address is correct on big-endian platforms if it isn't read
from the EEPROM.

ok miod@

- consistify cfdriver for the ethernet drivers (0 -> NULL)

ok dlg@

Eliminate the redundant bits of code for MTU and multicast handling
from the individual drivers now that ether_ioctl() handles this.

Shrinks the i386 kernels by..
RAMDISK - 2176 bytes
RAMDISKB - 1504 bytes
RAMDISKC - 736 bytes

Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users.
Build tested on almost all archs by todd@/brad@

ok naddy@

Introduce bpf_mtap_ether(), which for the benefit of bpf listeners
creates the VLAN encapsulation from the tag stored in the mbuf
header. Idea from FreeBSD, input from claudio@ and canacar@.

Switch all hardware VLAN enabled drivers to the new function.

ok claudio@

Re-add support TX VLAN tag insertion and RX VLAN tag stripping.

Tested by Dawe <dawedawe at gmx dot de>

Change m_devget()'s outdated and unused "offset" argument: It is
now the offset into the first mbuf of the target chain before copying
the source data over. From FreeBSD.

Convert drivers' use of m_devget(). Mostly from thib@.

Update mbuf(9) man page.

ok claudio@, thib@

First step towards cleaning up the Ethernet driver ioctl handling.
Move calling ether_ioctl() from the top of the ioctl function, which
at the moment does absolutely nothing, to the default switch case.
Thus allowing drivers to define their own ioctl handlers and then
falling back on ether_ioctl(). The only functional change this results
in at the moment is having all Ethernet drivers returning the proper
errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown
ioctl's.

Shrinks the i386 kernels by..
RAMDISK - 1024 bytes
RAMDISKB - 1120 bytes
RAMDISKC - 832 bytes

Tested by martin@/jsing@/todd@/brad@
Build tested on almost all archs by todd@/brad@

ok jsing@

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

More timeout(9) usage cleaned up.

ok claudio

Since Ethernet links can only be full duplex or half duplex the link
state reporting code in the MII layer / em(4) and vge(4) will never
fall back to the point of only reporting the link as being UP without
the duplex setting being reported, so simplify the code a bit here.

ok dlg@

- Remove disabled and unusable HW VLAN tagging code.
- Remove setup of the HW VLAN stripping.

Issue reported by and fix tested by henric@

ok dlg@

Fix some obviously bogus code in vge_newbuf(). Should fix PR 5582.

ok claudio@

Missing braces in vge_tick(). Fixes link state announcements.
ok reyk@

report full/half duplex state for non-MII interfaces

ok brad@

OpenBSD-ify the HW VLAN tag insertion code.

don't always leave the mbuf on the if_snd queue if vge_encap() fails.
if the mbuf is coalesced in vge_encap(), the mbuf reference is no
longer valid. drop the mbuf in this case.

bug introduced in r1.28
tested by Frank Denis
fixes kernel/5291

"go for it" deraadt@

s/Mhz/MHz/ in comments and printf() strings

ok jsg@

don't use IF_PREPEND() on altq's.
use IFQ_POLL()/IFQ_DEQUEUE() logic instead as described in altq(4).

tested by jolan@ on macppc
"diffs look ok" brad@

do not bother playing tag with the PCI_COMMAND_STATUS_REG

tested by jolan@, ok brad@

add sys/timeout.h

rev 1.13 fixed the MTU ioctl handler to allow adjusting the MTU
but it seems Jumbo support is broken, so disable Jumbos for now.

issue reported by jolan@

- remove ETHER_MAX_LEN_JUMBO and ETHERMTU_JUMBO.
- use if_hardmtu for MTU ioctl handlers.

ok reyk@

unknown ioctl is ENOTTY not EINVAL

remove IFCAP_JUMBO_MTU interface capabilities flag and set if_hardmtu in a few
more drivers.

ok reyk@

set if_jumbo_mtu and the IFCAP_JUMBO_MTU capabilities flag where
appropriate.

ok reyk@

allow bpf(4) to ignore packets based on their direction (inbound or
outbound), using a new BIOCSDIRFILT ioctl;
guidance, feedback and ok canacar@

de-register.

- splimp -> splnet
- remove spl's from attach
- removing redundant checks before pci_mapreg_map()
- fix dmesg printing
- de-allocate resources on failure to attach
- remove unused VLAN input code from vge(4)

Some fixes for vge(4)'s multicast handling, including..

- Fix IFF_ALLMULTI handling
- Stop endless loop in multicast hash table filter mode

From christos NetBSD

ok pvalchev@

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

enable use of the hardware 64 entry CAM table for perfect multicast
filtering otherwise fallback on the multicast hash table if trying to
filter on more than 64 addresses or if we're trying to flip on ALLMULTI.

enable HW transmit checksum offload

ok pvalchev@

- Add missing break for SIOCSIFADDR
- Allow setting the MTU

ok pvalchev@

- Correct the if_link_state_change() logic.
- Reading the EEPROM to learn the station address doesn't seem to work
on boards with VIA gigE controllers that are embedded in VIA chipsets.
Presumably, they don't have an external EEPROM and store the MAC
address somewhere else. To get around this, read the station
address from the RX filter registers instead. This has been tested
to work on both embedded and standalone controllers.

From FreeBSD

ok pvalchev@

csum -> csum_flags

ok krw@ canacar@

fix parenthesis

- enable reception of VLAN sized frames
- enable HW receive checksum offload

ok pvlachev@

make use of if_link_state_change().

From FreeBSD

ok pvalchev@

use IFQ_ rather than IF_ macro here too, maybe helps altq; ok henning

make sure interface is in RUNNING state before touching the multicast filters

From NetBSD

NetBSD PR 27678 for details

ok mcbride@

remove useless debugging leftover

Bounce the mbuf to the BPF listener before committing it to the wire
in the TX case, fixes rare problems associated with accessing already
free'd memory if the encap routine bails out (panic in PROMISC mode).
ok deraadt

htole32 and friends to get this working on big endian (macppc)

a hack to read MAC address correctly on big endian; ok drahn
however a correct clean way to do this should be found

VIA VT612x PCI Gigabit Ethernet adapter support, ok deraadt
from FreeBSD

Constify struct cfattach.

spelling
feedback and ok tb@ jmc@ ok ratchov@

Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.

ok dlg@ tobhe@

Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the
"new" API.

ok dlg@ tobhe@

consistently uppercase pci product defines

ok mpi@

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

G/C IFQ_SET_READY().

replace IFF_OACTIVE manipulation with mpsafe operations.

there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.

IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.

instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.

this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.

ok kettenis@ mpi@ jmatthew@ deraadt@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

rework vge_start to avoid IFQ_POLL

firstly, this checks for space in the tx ring before looking at the
send queue. if there's no space, then IFF_OACTIVE is set and break.

if there's space use IFQ_DEQUEUE to pull a packet off. if we fail
to encapsulate it, it gets dropped.

encap has been changed so the dmamaps the mbufs are loaded into are
created with 7 segments instead of 32. this means we detect when
the packet would overflow the tx descriptor at dmamap load time,
rather than after we've looped over the segments writing them into
the descriptor. we now use m_defrag to defrag the mbuf instead of
allocating a new one and using m_copydata.

now if we have any encap error on the first mbuf, we no longer set
IFF_OACTIVE and wait for an interrupt that never comes to clear it.

testing and (excellent) code review by richard proctor

Do not include <net/if_vlan_var.h> when it's not necessary.

Because of the VLAN hacks in mpw(4) this file still contains the definition
of "struct ifvlan" which depends on <sys/refcnt.h> which in turns pull
<sys/atomic.h>...

arp_ifinit() is no longer needed.

Make room for media types of the future. Extend the ifmedia word to 64 bits.
This changes numbers of the SIOCSIFMEDIA and SIOCGIFMEDIA ioctls and
grows struct ifmediareq.

Old ifconfig and dhclient binaries can still assign addresses, however
the 'media' subcommand stops working. Recompiling ifconfig and dhclient
with new headers before a reboot should not be necessary unless in very
special circumstances where non-default media settings must be used to
get link and console access is not available.

There may be some MD fallout but that will be cleared up later.

ok deraadt miod
with help and suggestions from several sharks attending l2k15

Increment if_ipackets in if_input().

Note that pseudo-drivers not using if_input() are not affected by this
conversion.

ok mikeb@, kettenis@, claudio@, dlg@

Now that if_input() set the receiving interface pointer on mbufs for us
there's no need to do it in m_devget(9).

Stop passing an ``ifp'' will help for upcoming interface pointer -> index
conversion.

While here remove unused ``ifp'' argument from m_clget(9) and kill two
birds^W layer violations in one commit.

ok henning@

Convert to if_input().

ok dlg@

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

unifdef INET

Fewer <netinet/in_systm.h>

get rid of the copy argument in m_devget that let you provide an
alternative to bcopy since noone uses it.

while there use memcpy instead of bcopy because we know the memory cannot
overlap.

ok henning@ matthew@ mikeb@ deraadt@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Rewrite receive filter handling and ioctl bits.

ok sthen@

Add some missing bits for flow control support and enable it.

Tested with PCI and PCIe vge(4).

ok sthen@

Remove setting an initial assumed baudrate upon driver attach which is not
necessarily correct, there might not even be a link when attaching.

ok mikeb@ reyk@

set ifp->if_baudrate with IF_Gbps() / IF_Mbps().

OK reyk@ sthen@

kill a few more casts that aren't helpful. ok krw miod

mechanic rename M_{TCP|UDP}V4_CSUM_OUT -> M_{TCP|UDP}_CSUM_OUT
ok claudio krw

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

remove the unused if_init callback in struct ifnet
ok deraadt@ henning@ claudio@

Don't print "EEPROM reload timed out" message. Devices that don't have an
EEPROM exist (RouterBOARD RB600A) and reloading default values from the
EEPROM will fail on those decives.

ok deraadt@

Make vge(4) detachable.

ok jsg@, deraadt@

Make sure the MAC address is correct on big-endian platforms if it isn't read
from the EEPROM.

ok miod@

- consistify cfdriver for the ethernet drivers (0 -> NULL)

ok dlg@

Eliminate the redundant bits of code for MTU and multicast handling
from the individual drivers now that ether_ioctl() handles this.

Shrinks the i386 kernels by..
RAMDISK - 2176 bytes
RAMDISKB - 1504 bytes
RAMDISKC - 736 bytes

Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users.
Build tested on almost all archs by todd@/brad@

ok naddy@

Introduce bpf_mtap_ether(), which for the benefit of bpf listeners
creates the VLAN encapsulation from the tag stored in the mbuf
header. Idea from FreeBSD, input from claudio@ and canacar@.

Switch all hardware VLAN enabled drivers to the new function.

ok claudio@

Re-add support TX VLAN tag insertion and RX VLAN tag stripping.

Tested by Dawe <dawedawe at gmx dot de>

Change m_devget()'s outdated and unused "offset" argument: It is
now the offset into the first mbuf of the target chain before copying
the source data over. From FreeBSD.

Convert drivers' use of m_devget(). Mostly from thib@.

Update mbuf(9) man page.

ok claudio@, thib@

First step towards cleaning up the Ethernet driver ioctl handling.
Move calling ether_ioctl() from the top of the ioctl function, which
at the moment does absolutely nothing, to the default switch case.
Thus allowing drivers to define their own ioctl handlers and then
falling back on ether_ioctl(). The only functional change this results
in at the moment is having all Ethernet drivers returning the proper
errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown
ioctl's.

Shrinks the i386 kernels by..
RAMDISK - 1024 bytes
RAMDISKB - 1120 bytes
RAMDISKC - 832 bytes

Tested by martin@/jsing@/todd@/brad@
Build tested on almost all archs by todd@/brad@

ok jsing@

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

More timeout(9) usage cleaned up.

ok claudio

Since Ethernet links can only be full duplex or half duplex the link
state reporting code in the MII layer / em(4) and vge(4) will never
fall back to the point of only reporting the link as being UP without
the duplex setting being reported, so simplify the code a bit here.

ok dlg@

- Remove disabled and unusable HW VLAN tagging code.
- Remove setup of the HW VLAN stripping.

Issue reported by and fix tested by henric@

ok dlg@

Fix some obviously bogus code in vge_newbuf(). Should fix PR 5582.

ok claudio@

Missing braces in vge_tick(). Fixes link state announcements.
ok reyk@

report full/half duplex state for non-MII interfaces

ok brad@

OpenBSD-ify the HW VLAN tag insertion code.

don't always leave the mbuf on the if_snd queue if vge_encap() fails.
if the mbuf is coalesced in vge_encap(), the mbuf reference is no
longer valid. drop the mbuf in this case.

bug introduced in r1.28
tested by Frank Denis
fixes kernel/5291

"go for it" deraadt@

s/Mhz/MHz/ in comments and printf() strings

ok jsg@

don't use IF_PREPEND() on altq's.
use IFQ_POLL()/IFQ_DEQUEUE() logic instead as described in altq(4).

tested by jolan@ on macppc
"diffs look ok" brad@

do not bother playing tag with the PCI_COMMAND_STATUS_REG

tested by jolan@, ok brad@

add sys/timeout.h

rev 1.13 fixed the MTU ioctl handler to allow adjusting the MTU
but it seems Jumbo support is broken, so disable Jumbos for now.

issue reported by jolan@

- remove ETHER_MAX_LEN_JUMBO and ETHERMTU_JUMBO.
- use if_hardmtu for MTU ioctl handlers.

ok reyk@

unknown ioctl is ENOTTY not EINVAL

remove IFCAP_JUMBO_MTU interface capabilities flag and set if_hardmtu in a few
more drivers.

ok reyk@

set if_jumbo_mtu and the IFCAP_JUMBO_MTU capabilities flag where
appropriate.

ok reyk@

allow bpf(4) to ignore packets based on their direction (inbound or
outbound), using a new BIOCSDIRFILT ioctl;
guidance, feedback and ok canacar@

de-register.

- splimp -> splnet
- remove spl's from attach
- removing redundant checks before pci_mapreg_map()
- fix dmesg printing
- de-allocate resources on failure to attach
- remove unused VLAN input code from vge(4)

Some fixes for vge(4)'s multicast handling, including..

- Fix IFF_ALLMULTI handling
- Stop endless loop in multicast hash table filter mode

From christos NetBSD

ok pvalchev@

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

enable use of the hardware 64 entry CAM table for perfect multicast
filtering otherwise fallback on the multicast hash table if trying to
filter on more than 64 addresses or if we're trying to flip on ALLMULTI.

enable HW transmit checksum offload

ok pvalchev@

- Add missing break for SIOCSIFADDR
- Allow setting the MTU

ok pvalchev@

- Correct the if_link_state_change() logic.
- Reading the EEPROM to learn the station address doesn't seem to work
on boards with VIA gigE controllers that are embedded in VIA chipsets.
Presumably, they don't have an external EEPROM and store the MAC
address somewhere else. To get around this, read the station
address from the RX filter registers instead. This has been tested
to work on both embedded and standalone controllers.

From FreeBSD

ok pvalchev@

csum -> csum_flags

ok krw@ canacar@

fix parenthesis

- enable reception of VLAN sized frames
- enable HW receive checksum offload

ok pvlachev@

make use of if_link_state_change().

From FreeBSD

ok pvalchev@

use IFQ_ rather than IF_ macro here too, maybe helps altq; ok henning

make sure interface is in RUNNING state before touching the multicast filters

From NetBSD

NetBSD PR 27678 for details

ok mcbride@

remove useless debugging leftover

Bounce the mbuf to the BPF listener before committing it to the wire
in the TX case, fixes rare problems associated with accessing already
free'd memory if the encap routine bails out (panic in PROMISC mode).
ok deraadt

htole32 and friends to get this working on big endian (macppc)

a hack to read MAC address correctly on big endian; ok drahn
however a correct clean way to do this should be found

VIA VT612x PCI Gigabit Ethernet adapter support, ok deraadt
from FreeBSD

spelling
feedback and ok tb@ jmc@ ok ratchov@

Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.

ok dlg@ tobhe@

Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the
"new" API.

ok dlg@ tobhe@

consistently uppercase pci product defines

ok mpi@

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

G/C IFQ_SET_READY().

replace IFF_OACTIVE manipulation with mpsafe operations.

there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.

IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.

instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.

this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.

ok kettenis@ mpi@ jmatthew@ deraadt@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

rework vge_start to avoid IFQ_POLL

firstly, this checks for space in the tx ring before looking at the
send queue. if there's no space, then IFF_OACTIVE is set and break.

if there's space use IFQ_DEQUEUE to pull a packet off. if we fail
to encapsulate it, it gets dropped.

encap has been changed so the dmamaps the mbufs are loaded into are
created with 7 segments instead of 32. this means we detect when
the packet would overflow the tx descriptor at dmamap load time,
rather than after we've looped over the segments writing them into
the descriptor. we now use m_defrag to defrag the mbuf instead of
allocating a new one and using m_copydata.

now if we have any encap error on the first mbuf, we no longer set
IFF_OACTIVE and wait for an interrupt that never comes to clear it.

testing and (excellent) code review by richard proctor

Do not include <net/if_vlan_var.h> when it's not necessary.

Because of the VLAN hacks in mpw(4) this file still contains the definition
of "struct ifvlan" which depends on <sys/refcnt.h> which in turns pull
<sys/atomic.h>...

arp_ifinit() is no longer needed.

Make room for media types of the future. Extend the ifmedia word to 64 bits.
This changes numbers of the SIOCSIFMEDIA and SIOCGIFMEDIA ioctls and
grows struct ifmediareq.

Old ifconfig and dhclient binaries can still assign addresses, however
the 'media' subcommand stops working. Recompiling ifconfig and dhclient
with new headers before a reboot should not be necessary unless in very
special circumstances where non-default media settings must be used to
get link and console access is not available.

There may be some MD fallout but that will be cleared up later.

ok deraadt miod
with help and suggestions from several sharks attending l2k15

Increment if_ipackets in if_input().

Note that pseudo-drivers not using if_input() are not affected by this
conversion.

ok mikeb@, kettenis@, claudio@, dlg@

Now that if_input() set the receiving interface pointer on mbufs for us
there's no need to do it in m_devget(9).

Stop passing an ``ifp'' will help for upcoming interface pointer -> index
conversion.

While here remove unused ``ifp'' argument from m_clget(9) and kill two
birds^W layer violations in one commit.

ok henning@

Convert to if_input().

ok dlg@

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

unifdef INET

Fewer <netinet/in_systm.h>

get rid of the copy argument in m_devget that let you provide an
alternative to bcopy since noone uses it.

while there use memcpy instead of bcopy because we know the memory cannot
overlap.

ok henning@ matthew@ mikeb@ deraadt@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Rewrite receive filter handling and ioctl bits.

ok sthen@

Add some missing bits for flow control support and enable it.

Tested with PCI and PCIe vge(4).

ok sthen@

Remove setting an initial assumed baudrate upon driver attach which is not
necessarily correct, there might not even be a link when attaching.

ok mikeb@ reyk@

set ifp->if_baudrate with IF_Gbps() / IF_Mbps().

OK reyk@ sthen@

kill a few more casts that aren't helpful. ok krw miod

mechanic rename M_{TCP|UDP}V4_CSUM_OUT -> M_{TCP|UDP}_CSUM_OUT
ok claudio krw

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

remove the unused if_init callback in struct ifnet
ok deraadt@ henning@ claudio@

Don't print "EEPROM reload timed out" message. Devices that don't have an
EEPROM exist (RouterBOARD RB600A) and reloading default values from the
EEPROM will fail on those decives.

ok deraadt@

Make vge(4) detachable.

ok jsg@, deraadt@

Make sure the MAC address is correct on big-endian platforms if it isn't read
from the EEPROM.

ok miod@

- consistify cfdriver for the ethernet drivers (0 -> NULL)

ok dlg@

Eliminate the redundant bits of code for MTU and multicast handling
from the individual drivers now that ether_ioctl() handles this.

Shrinks the i386 kernels by..
RAMDISK - 2176 bytes
RAMDISKB - 1504 bytes
RAMDISKC - 736 bytes

Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users.
Build tested on almost all archs by todd@/brad@

ok naddy@

Introduce bpf_mtap_ether(), which for the benefit of bpf listeners
creates the VLAN encapsulation from the tag stored in the mbuf
header. Idea from FreeBSD, input from claudio@ and canacar@.

Switch all hardware VLAN enabled drivers to the new function.

ok claudio@

Re-add support TX VLAN tag insertion and RX VLAN tag stripping.

Tested by Dawe <dawedawe at gmx dot de>

Change m_devget()'s outdated and unused "offset" argument: It is
now the offset into the first mbuf of the target chain before copying
the source data over. From FreeBSD.

Convert drivers' use of m_devget(). Mostly from thib@.

Update mbuf(9) man page.

ok claudio@, thib@

First step towards cleaning up the Ethernet driver ioctl handling.
Move calling ether_ioctl() from the top of the ioctl function, which
at the moment does absolutely nothing, to the default switch case.
Thus allowing drivers to define their own ioctl handlers and then
falling back on ether_ioctl(). The only functional change this results
in at the moment is having all Ethernet drivers returning the proper
errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown
ioctl's.

Shrinks the i386 kernels by..
RAMDISK - 1024 bytes
RAMDISKB - 1120 bytes
RAMDISKC - 832 bytes

Tested by martin@/jsing@/todd@/brad@
Build tested on almost all archs by todd@/brad@

ok jsing@

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

More timeout(9) usage cleaned up.

ok claudio

Since Ethernet links can only be full duplex or half duplex the link
state reporting code in the MII layer / em(4) and vge(4) will never
fall back to the point of only reporting the link as being UP without
the duplex setting being reported, so simplify the code a bit here.

ok dlg@

- Remove disabled and unusable HW VLAN tagging code.
- Remove setup of the HW VLAN stripping.

Issue reported by and fix tested by henric@

ok dlg@

Fix some obviously bogus code in vge_newbuf(). Should fix PR 5582.

ok claudio@

Missing braces in vge_tick(). Fixes link state announcements.
ok reyk@

report full/half duplex state for non-MII interfaces

ok brad@

OpenBSD-ify the HW VLAN tag insertion code.

don't always leave the mbuf on the if_snd queue if vge_encap() fails.
if the mbuf is coalesced in vge_encap(), the mbuf reference is no
longer valid. drop the mbuf in this case.

bug introduced in r1.28
tested by Frank Denis
fixes kernel/5291

"go for it" deraadt@

s/Mhz/MHz/ in comments and printf() strings

ok jsg@

don't use IF_PREPEND() on altq's.
use IFQ_POLL()/IFQ_DEQUEUE() logic instead as described in altq(4).

tested by jolan@ on macppc
"diffs look ok" brad@

do not bother playing tag with the PCI_COMMAND_STATUS_REG

tested by jolan@, ok brad@

add sys/timeout.h

rev 1.13 fixed the MTU ioctl handler to allow adjusting the MTU
but it seems Jumbo support is broken, so disable Jumbos for now.

issue reported by jolan@

- remove ETHER_MAX_LEN_JUMBO and ETHERMTU_JUMBO.
- use if_hardmtu for MTU ioctl handlers.

ok reyk@

unknown ioctl is ENOTTY not EINVAL

remove IFCAP_JUMBO_MTU interface capabilities flag and set if_hardmtu in a few
more drivers.

ok reyk@

set if_jumbo_mtu and the IFCAP_JUMBO_MTU capabilities flag where
appropriate.

ok reyk@

allow bpf(4) to ignore packets based on their direction (inbound or
outbound), using a new BIOCSDIRFILT ioctl;
guidance, feedback and ok canacar@

de-register.

- splimp -> splnet
- remove spl's from attach
- removing redundant checks before pci_mapreg_map()
- fix dmesg printing
- de-allocate resources on failure to attach
- remove unused VLAN input code from vge(4)

Some fixes for vge(4)'s multicast handling, including..

- Fix IFF_ALLMULTI handling
- Stop endless loop in multicast hash table filter mode

From christos NetBSD

ok pvalchev@

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

enable use of the hardware 64 entry CAM table for perfect multicast
filtering otherwise fallback on the multicast hash table if trying to
filter on more than 64 addresses or if we're trying to flip on ALLMULTI.

enable HW transmit checksum offload

ok pvalchev@

- Add missing break for SIOCSIFADDR
- Allow setting the MTU

ok pvalchev@

- Correct the if_link_state_change() logic.
- Reading the EEPROM to learn the station address doesn't seem to work
on boards with VIA gigE controllers that are embedded in VIA chipsets.
Presumably, they don't have an external EEPROM and store the MAC
address somewhere else. To get around this, read the station
address from the RX filter registers instead. This has been tested
to work on both embedded and standalone controllers.

From FreeBSD

ok pvalchev@

csum -> csum_flags

ok krw@ canacar@

fix parenthesis

- enable reception of VLAN sized frames
- enable HW receive checksum offload

ok pvlachev@

make use of if_link_state_change().

From FreeBSD

ok pvalchev@

use IFQ_ rather than IF_ macro here too, maybe helps altq; ok henning

make sure interface is in RUNNING state before touching the multicast filters

From NetBSD

NetBSD PR 27678 for details

ok mcbride@

remove useless debugging leftover

Bounce the mbuf to the BPF listener before committing it to the wire
in the TX case, fixes rare problems associated with accessing already
free'd memory if the encap routine bails out (panic in PROMISC mode).
ok deraadt

htole32 and friends to get this working on big endian (macppc)

a hack to read MAC address correctly on big endian; ok drahn
however a correct clean way to do this should be found

VIA VT612x PCI Gigabit Ethernet adapter support, ok deraadt
from FreeBSD

Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.

ok dlg@ tobhe@

Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the
"new" API.

ok dlg@ tobhe@

consistently uppercase pci product defines

ok mpi@

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

G/C IFQ_SET_READY().

replace IFF_OACTIVE manipulation with mpsafe operations.

there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.

IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.

instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.

this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.

ok kettenis@ mpi@ jmatthew@ deraadt@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

rework vge_start to avoid IFQ_POLL

firstly, this checks for space in the tx ring before looking at the
send queue. if there's no space, then IFF_OACTIVE is set and break.

if there's space use IFQ_DEQUEUE to pull a packet off. if we fail
to encapsulate it, it gets dropped.

encap has been changed so the dmamaps the mbufs are loaded into are
created with 7 segments instead of 32. this means we detect when
the packet would overflow the tx descriptor at dmamap load time,
rather than after we've looped over the segments writing them into
the descriptor. we now use m_defrag to defrag the mbuf instead of
allocating a new one and using m_copydata.

now if we have any encap error on the first mbuf, we no longer set
IFF_OACTIVE and wait for an interrupt that never comes to clear it.

testing and (excellent) code review by richard proctor

Do not include <net/if_vlan_var.h> when it's not necessary.

Because of the VLAN hacks in mpw(4) this file still contains the definition
of "struct ifvlan" which depends on <sys/refcnt.h> which in turns pull
<sys/atomic.h>...

arp_ifinit() is no longer needed.

Make room for media types of the future. Extend the ifmedia word to 64 bits.
This changes numbers of the SIOCSIFMEDIA and SIOCGIFMEDIA ioctls and
grows struct ifmediareq.

Old ifconfig and dhclient binaries can still assign addresses, however
the 'media' subcommand stops working. Recompiling ifconfig and dhclient
with new headers before a reboot should not be necessary unless in very
special circumstances where non-default media settings must be used to
get link and console access is not available.

There may be some MD fallout but that will be cleared up later.

ok deraadt miod
with help and suggestions from several sharks attending l2k15

Increment if_ipackets in if_input().

Note that pseudo-drivers not using if_input() are not affected by this
conversion.

ok mikeb@, kettenis@, claudio@, dlg@

Now that if_input() set the receiving interface pointer on mbufs for us
there's no need to do it in m_devget(9).

Stop passing an ``ifp'' will help for upcoming interface pointer -> index
conversion.

While here remove unused ``ifp'' argument from m_clget(9) and kill two
birds^W layer violations in one commit.

ok henning@

Convert to if_input().

ok dlg@

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

unifdef INET

Fewer <netinet/in_systm.h>

get rid of the copy argument in m_devget that let you provide an
alternative to bcopy since noone uses it.

while there use memcpy instead of bcopy because we know the memory cannot
overlap.

ok henning@ matthew@ mikeb@ deraadt@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Rewrite receive filter handling and ioctl bits.

ok sthen@

Add some missing bits for flow control support and enable it.

Tested with PCI and PCIe vge(4).

ok sthen@

Remove setting an initial assumed baudrate upon driver attach which is not
necessarily correct, there might not even be a link when attaching.

ok mikeb@ reyk@

set ifp->if_baudrate with IF_Gbps() / IF_Mbps().

OK reyk@ sthen@

kill a few more casts that aren't helpful. ok krw miod

mechanic rename M_{TCP|UDP}V4_CSUM_OUT -> M_{TCP|UDP}_CSUM_OUT
ok claudio krw

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

remove the unused if_init callback in struct ifnet
ok deraadt@ henning@ claudio@

Don't print "EEPROM reload timed out" message. Devices that don't have an
EEPROM exist (RouterBOARD RB600A) and reloading default values from the
EEPROM will fail on those decives.

ok deraadt@

Make vge(4) detachable.

ok jsg@, deraadt@

Make sure the MAC address is correct on big-endian platforms if it isn't read
from the EEPROM.

ok miod@

- consistify cfdriver for the ethernet drivers (0 -> NULL)

ok dlg@

Eliminate the redundant bits of code for MTU and multicast handling
from the individual drivers now that ether_ioctl() handles this.

Shrinks the i386 kernels by..
RAMDISK - 2176 bytes
RAMDISKB - 1504 bytes
RAMDISKC - 736 bytes

Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users.
Build tested on almost all archs by todd@/brad@

ok naddy@

Introduce bpf_mtap_ether(), which for the benefit of bpf listeners
creates the VLAN encapsulation from the tag stored in the mbuf
header. Idea from FreeBSD, input from claudio@ and canacar@.

Switch all hardware VLAN enabled drivers to the new function.

ok claudio@

Re-add support TX VLAN tag insertion and RX VLAN tag stripping.

Tested by Dawe <dawedawe at gmx dot de>

Change m_devget()'s outdated and unused "offset" argument: It is
now the offset into the first mbuf of the target chain before copying
the source data over. From FreeBSD.

Convert drivers' use of m_devget(). Mostly from thib@.

Update mbuf(9) man page.

ok claudio@, thib@

First step towards cleaning up the Ethernet driver ioctl handling.
Move calling ether_ioctl() from the top of the ioctl function, which
at the moment does absolutely nothing, to the default switch case.
Thus allowing drivers to define their own ioctl handlers and then
falling back on ether_ioctl(). The only functional change this results
in at the moment is having all Ethernet drivers returning the proper
errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown
ioctl's.

Shrinks the i386 kernels by..
RAMDISK - 1024 bytes
RAMDISKB - 1120 bytes
RAMDISKC - 832 bytes

Tested by martin@/jsing@/todd@/brad@
Build tested on almost all archs by todd@/brad@

ok jsing@

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

More timeout(9) usage cleaned up.

ok claudio

Since Ethernet links can only be full duplex or half duplex the link
state reporting code in the MII layer / em(4) and vge(4) will never
fall back to the point of only reporting the link as being UP without
the duplex setting being reported, so simplify the code a bit here.

ok dlg@

- Remove disabled and unusable HW VLAN tagging code.
- Remove setup of the HW VLAN stripping.

Issue reported by and fix tested by henric@

ok dlg@

Fix some obviously bogus code in vge_newbuf(). Should fix PR 5582.

ok claudio@

Missing braces in vge_tick(). Fixes link state announcements.
ok reyk@

report full/half duplex state for non-MII interfaces

ok brad@

OpenBSD-ify the HW VLAN tag insertion code.

don't always leave the mbuf on the if_snd queue if vge_encap() fails.
if the mbuf is coalesced in vge_encap(), the mbuf reference is no
longer valid. drop the mbuf in this case.

bug introduced in r1.28
tested by Frank Denis
fixes kernel/5291

"go for it" deraadt@

s/Mhz/MHz/ in comments and printf() strings

ok jsg@

don't use IF_PREPEND() on altq's.
use IFQ_POLL()/IFQ_DEQUEUE() logic instead as described in altq(4).

tested by jolan@ on macppc
"diffs look ok" brad@

do not bother playing tag with the PCI_COMMAND_STATUS_REG

tested by jolan@, ok brad@

add sys/timeout.h

rev 1.13 fixed the MTU ioctl handler to allow adjusting the MTU
but it seems Jumbo support is broken, so disable Jumbos for now.

issue reported by jolan@

- remove ETHER_MAX_LEN_JUMBO and ETHERMTU_JUMBO.
- use if_hardmtu for MTU ioctl handlers.

ok reyk@

unknown ioctl is ENOTTY not EINVAL

remove IFCAP_JUMBO_MTU interface capabilities flag and set if_hardmtu in a few
more drivers.

ok reyk@

set if_jumbo_mtu and the IFCAP_JUMBO_MTU capabilities flag where
appropriate.

ok reyk@

allow bpf(4) to ignore packets based on their direction (inbound or
outbound), using a new BIOCSDIRFILT ioctl;
guidance, feedback and ok canacar@

de-register.

- splimp -> splnet
- remove spl's from attach
- removing redundant checks before pci_mapreg_map()
- fix dmesg printing
- de-allocate resources on failure to attach
- remove unused VLAN input code from vge(4)

Some fixes for vge(4)'s multicast handling, including..

- Fix IFF_ALLMULTI handling
- Stop endless loop in multicast hash table filter mode

From christos NetBSD

ok pvalchev@

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

enable use of the hardware 64 entry CAM table for perfect multicast
filtering otherwise fallback on the multicast hash table if trying to
filter on more than 64 addresses or if we're trying to flip on ALLMULTI.

enable HW transmit checksum offload

ok pvalchev@

- Add missing break for SIOCSIFADDR
- Allow setting the MTU

ok pvalchev@

- Correct the if_link_state_change() logic.
- Reading the EEPROM to learn the station address doesn't seem to work
on boards with VIA gigE controllers that are embedded in VIA chipsets.
Presumably, they don't have an external EEPROM and store the MAC
address somewhere else. To get around this, read the station
address from the RX filter registers instead. This has been tested
to work on both embedded and standalone controllers.

From FreeBSD

ok pvalchev@

csum -> csum_flags

ok krw@ canacar@

fix parenthesis

- enable reception of VLAN sized frames
- enable HW receive checksum offload

ok pvlachev@

make use of if_link_state_change().

From FreeBSD

ok pvalchev@

use IFQ_ rather than IF_ macro here too, maybe helps altq; ok henning

make sure interface is in RUNNING state before touching the multicast filters

From NetBSD

NetBSD PR 27678 for details

ok mcbride@

remove useless debugging leftover

Bounce the mbuf to the BPF listener before committing it to the wire
in the TX case, fixes rare problems associated with accessing already
free'd memory if the encap routine bails out (panic in PROMISC mode).
ok deraadt

htole32 and friends to get this working on big endian (macppc)

a hack to read MAC address correctly on big endian; ok drahn
however a correct clean way to do this should be found

VIA VT612x PCI Gigabit Ethernet adapter support, ok deraadt
from FreeBSD

consistently uppercase pci product defines

ok mpi@

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

G/C IFQ_SET_READY().

replace IFF_OACTIVE manipulation with mpsafe operations.

there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.

IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.

instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.

this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.

ok kettenis@ mpi@ jmatthew@ deraadt@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

rework vge_start to avoid IFQ_POLL

firstly, this checks for space in the tx ring before looking at the
send queue. if there's no space, then IFF_OACTIVE is set and break.

if there's space use IFQ_DEQUEUE to pull a packet off. if we fail
to encapsulate it, it gets dropped.

encap has been changed so the dmamaps the mbufs are loaded into are
created with 7 segments instead of 32. this means we detect when
the packet would overflow the tx descriptor at dmamap load time,
rather than after we've looped over the segments writing them into
the descriptor. we now use m_defrag to defrag the mbuf instead of
allocating a new one and using m_copydata.

now if we have any encap error on the first mbuf, we no longer set
IFF_OACTIVE and wait for an interrupt that never comes to clear it.

testing and (excellent) code review by richard proctor

Do not include <net/if_vlan_var.h> when it's not necessary.

Because of the VLAN hacks in mpw(4) this file still contains the definition
of "struct ifvlan" which depends on <sys/refcnt.h> which in turns pull
<sys/atomic.h>...

arp_ifinit() is no longer needed.

Make room for media types of the future. Extend the ifmedia word to 64 bits.
This changes numbers of the SIOCSIFMEDIA and SIOCGIFMEDIA ioctls and
grows struct ifmediareq.

Old ifconfig and dhclient binaries can still assign addresses, however
the 'media' subcommand stops working. Recompiling ifconfig and dhclient
with new headers before a reboot should not be necessary unless in very
special circumstances where non-default media settings must be used to
get link and console access is not available.

There may be some MD fallout but that will be cleared up later.

ok deraadt miod
with help and suggestions from several sharks attending l2k15

Increment if_ipackets in if_input().

Note that pseudo-drivers not using if_input() are not affected by this
conversion.

ok mikeb@, kettenis@, claudio@, dlg@

Now that if_input() set the receiving interface pointer on mbufs for us
there's no need to do it in m_devget(9).

Stop passing an ``ifp'' will help for upcoming interface pointer -> index
conversion.

While here remove unused ``ifp'' argument from m_clget(9) and kill two
birds^W layer violations in one commit.

ok henning@

Convert to if_input().

ok dlg@

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

unifdef INET

Fewer <netinet/in_systm.h>

get rid of the copy argument in m_devget that let you provide an
alternative to bcopy since noone uses it.

while there use memcpy instead of bcopy because we know the memory cannot
overlap.

ok henning@ matthew@ mikeb@ deraadt@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Rewrite receive filter handling and ioctl bits.

ok sthen@