8182047: javac compile error on type-parameter-exceptions in lambda expressions
Reviewed-by: mcimadamore

8058408: Compiler should emit a clearer message for invalid parenthesized expression
Reviewed-by: sadayapalam
Contributed-by: priya.lakshmi.muthuswamy@oracle.com

8181911: Lambda Analyzer causes compile-time error
Summary: When copying Env<AttrContext> for Analyzer, detach returnResult from the outer context.
Reviewed-by: mcimadamore

8170326: Inconsistencies between code, compiler.properties and comments
Summary: Converting uses of Log and JCDiagnostic.Factory methods to use CompilerProperties instead of plain Strings, fixing inconsistencies, adding crules analyzer to ensure CompilerProperties are used whenever possible.
Reviewed-by: mcimadamore

8177933: Stackoverflow during compilation, starting jdk-9+163
Summary: Avoid extra method call in Attr.attribTree
Reviewed-by: vromero

8176714: javac is wrongly assuming that field JCMemberReference.overloadKind has been assigned to
Reviewed-by: mcimadamore

8177097: Generic method reference returning wildcard parameterized type does not compile
Summary: Captured cache should not be used during 'fake' attr checks
Reviewed-by: vromero, jjg

8175198: Javac incorrectly allows receiver parameters in annotation methods
Reviewed-by: mcimadamore

8175317: javac does not issue unchecked warnings when checking method reference return types
Summary: Missing Warner object on method reference return type check
Reviewed-by: vromero

8175790: field JCVariableDecl.vartype can't be null after post attribution analysis
Reviewed-by: mcimadamore

8174249: Regression in generic method unchecked calls
Summary: Erasure for unchecked call occurs too early after JDK-8078093
Reviewed-by: vromero

8173456: com.sun.tools.javac.util.Assert.error during code compilation
Reviewed-by: mcimadamore

8169197: Improve error reporting for compiling against unexported package
Summary: When a type cannot be found, look into other modules, search for possible viable types, and report them conveniently to the user.
Reviewed-by: mcimadamore, jjg

8171371: Remove redundant type-arguments from generic method calls
Reviewed-by: jjg, rfield, mchung

8181370: Convert anonymous inner classes into lambdas/method references
Reviewed-by: jjg, rfield, mchung

8170987: Module system implementation refresh (12/2016)
Reviewed-by: mcimadamore
Contributed-by: jonathan.gibbons@oracle.com, jan.lahoda@oracle.com, srikanth.adayapalam@oracle.com, alan.bateman@oracle.com, mandy.chung@oracle.com

8170410: inference: javac doesn't implement 18.2.5 correctly
Summary: javac does not generate constraints of the kind 'throws alpha' as described in the spec
Reviewed-by: vromero, dlsmith

8169069: Module system implementation refresh (11/2016)
Reviewed-by: mcimadamore, jjg, mchung, anazarov
Contributed-by: jonathan.gibbons@oracle.com, jan.lahoda@oracle.com, alan.bateman@oracle.com, mandy.chung@oracle.com, bhavesh.x.patel@oracle.com, andrey.x.nazarov@oracle.com

8169074: Build is failing after JDK-8166538
Summary: Reverting d3dde3f775b8
Reviewed-by: darcy

8166538: Improve error reporting for compiling against unexported package
Summary: When a type cannot be found, look into other modules, search for possible viable types, and report them conveniently to the user.
Reviewed-by: mcimadamore, jjg

8026721: Enhance Lambda serialization
Reviewed-by: jjg, briangoetz

8153362: Add javac -Xlint warning to list exposed types which are not accessible
Summary: Adding implementation to -Xlint:exports, to warn about exposing inaccessible types in API
Reviewed-by: jjg

8163027: AssertionError while compiling a program that uses try with resources.
Reviewed-by: vromero

8166108: VerifyError passing anonymous inner class to supertype constructor
Summary: Anonymous classes instantitated in explicit constructor calls cannot have enclosing instance
Reviewed-by: vromero

8078561: Error message should be generated once when -source 6 is specified
Summary: Code to avoid duplicated errors about features not supported in the current source level moved to Log
Reviewed-by: jjg

8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
Reviewed-by: mcimadamore, ksrini

8161708: javac, consider a different way to handle access code for operators
Reviewed-by: mcimadamore

8161985: Spurious override of Object.getClass leads to NPE
Summary: Attr.adjustMethodReturnType() tweaks return types w/o checking what method is being patched
Reviewed-by: vromero

8145489: NPE while compiling annotations with qualified names in package-info.java
Summary: Spurious method reference check in Attr.visitSelect is causing NPE
Reviewed-by: vromero

8154052: Java compiler error displays line from the wrong file
Summary: Compiler should update the diagnostic source properly.
Reviewed-by: mcimadamore

8157149: Inference: weird propagation of thrown inference variables
Summary: Overhaul of treatment of thrown inference variables
Reviewed-by: vromero

8153884: Expression lambda erroneously compatible with void-returning descriptor
Summary: Fix lambda compatibility check for void returning expressions
Reviewed-by: vromero

7152104: javac should not warn about missing serialVersionUID for anonymous inner classes
Summary: Javac no longer issues warnings for missing serialVersionUID in anonymous classes.
Reviewed-by: jlahoda

8027999: Poorly worded error message when attempting to assign to this
Summary: Changed the error message when trying to assign to this.
Reviewed-by: jjg

8142968: Module System implementation
Summary: Initial integration of JEP 200, JEP 260, JEP 261, and JEP 282
Reviewed-by: jjg, jlahoda, vromero, mcimadamore, bpatel, ksrini, darcy, anazarov, dfuchs
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, jan.lahoda@oracle.com, vicente.romero@oracle.com, andreas.lundblad@oracle.com, andrey.x.nazarov@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, kumar.x.srinivasan@oracle.com, sundararajan.athijegannathan@oracle.com

8149600: javac, remove unused options, step 2
Reviewed-by: jjg, mcimadamore

8148213: Regression: nested unchecked call does not trigger erasure of return type
Summary: FreeTypeListener was deferred too much and caused loss of unchecked warning while in the middle of overload
Reviewed-by: vromero

8147546: regression when type-checking generic calls inside nested declarations occurring in method context
Summary: Attr.visitClassDef should set a temporary ArgumentAttr cache when in speculative mode
Reviewed-by: vromero

8147493: regression when type-checking unchecked method calls
Summary: Shared warner in Attr.checkMethod leads to spurious inference errors
Reviewed-by: vromero

8073616: Duplicate error message: cannot inherit from final (class) F
Summary: Ensure that the compiler does not emit duplicate errors at slightly different source positions.
Reviewed-by: mcimadamore

8141613: Compiler fails to infer generic type
Summary: Repeated capture of same expression leads to erroneous inference constraints
Reviewed-by: vromero

8087349: Test tools/sjavac/IncCompInheritance.java is failing
Summary: Refactoring of Dependencies framework.
Reviewed-by: mcimadamore

8139836: Can't use super::x method reference when x is protected
Summary: Javac incorrectly diasllows reference to a protected method from a super class in method reference expressions.
Reviewed-by: mcimadamore

8065219: Deprecated warning in method reference are missing in some cases.
Reviewed-by: mcimadamore

8133135: Compiler internall error (NPE) on anonymous class defined by qualified instance creation expression with diamond
Reviewed-by: mcimadamore

8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
Summary: Add infrastructure to avoid combinatorial explosion of method argument attributions
Reviewed-by: jlahoda, vromero, dlsmith

8053906: javac is accepting a self-referencing variable initializer inside a lambda expression
Reviewed-by: jlahoda

8132215: class InferenceContext should live in a separate file
Reviewed-by: mcimadamore, jlahoda

8080880: some docs cleanup for langtools
Summary: minor cleanup for docs
Reviewed-by: jjg

8130745: Revert fix pushed for JDK-8074346
Reviewed-by: jlahoda

8074346: Type annotation on a qualified type causes spurious 'cannot find symbol' errors
Summary: Issue clear diagostic when package names in a qualified type name are illegally annotated
Reviewed-by: mcimadamore, jlahoda

8081521: Compiler has trouble compiling nested diamond allocation constructs involving anonymous classes.
Reviewed-by: mcimadamore

8080726: Redundant error message on private abstract interface method with body.
Reviewed-by: mcimadamore

8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
Summary: Internal cleanup to Attr.check to make use of a new abstraction CheckMode
Reviewed-by: mcimadamore

8077605: Initializing static fields causes unbounded recursion in javac
Summary: Improving detection of potential constant variable initializers; preventing infinite recursion on exception during Attr.visitLambda.
Reviewed-by: mcimadamore, vromero

8073534: Confusing / incorrect error message regarding annotations on non-declarations
Summary: Adjusted error message for annotations on non-declarations.
Reviewed-by: jlahoda, dlsmith

8031744: Annotations on many Language Model elements are not returned
Reviewed-by: jfranck, mcimadamore, emc, jlahoda, jjg
Contributed-by: joel.franck@oracle.com, maurizio.cimadamore@oracle.com

8062373: Project Coin: diamond and anonymous classes
Summary: Allow diamond inference in combination with anonymous class instance creation
Reviewed-by: mcimadamore, vromero
Contributed-by: srikanth.adayapalam@oracle.com, maurizio.cimadamore@oracle.com

8075184: javac is mistakenly considering an missing enclosing instance error as an overload error
Reviewed-by: mcimadamore

8074100: Turn Type.Mapping into a true visitor
Summary: replace Type.Mapping with a true visitor in Types
Reviewed-by: jlahoda, vromero

8074381: java.lang.AssertionError during compiling
Summary: Add extra functional interface check to prevent crash during code generation
Reviewed-by: vromero

8074148: Attr.visitBinary flags error at wrong position
Reviewed-by: vromero

8050021: Improper "duplicate case label" error
Reviewed-by: jlahoda

8073842: Invalid method reference when referencing a method on a wildcard type
Summary: Method rteference lookup logic doesn't skip type-variables as required by javac.
Reviewed-by: jlahoda

8071291: Compiler crashes trying to cast UnionType to IntersectionClassType
Summary: Compiler tests for .isCompound but then cast to a more specific Type subclass, resulting in CCE
Reviewed-by: vromero, jlahoda

8071241: Investigate alternate strategy for type-checking operators
Summary: Separat operator lookup logic from overload resolution.
Reviewed-by: jjg, jlahoda, sadayapalam

8046977: ClassCastException: typing information needed for method reference bridging not preserved
Reviewed-by: mcimadamore
Contributed-by: srikanth.adayapalam@oracle.com

8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
Summary: Making sure enum's abstractness is resolved before writing InnerClasses entry about it.
Reviewed-by: mcimadamore

8068995: Cleanup method reference lookup code
Summary: Simplify method reference code lookup and generate better/more uniform diagnostics
Reviewed-by: vromero

8066871: java.lang.VerifyError: Bad local variable type - local final String
Summary: baseType() erroneously called on MethodResultInfo causes lack of constant type info
Reviewed-by: jlahoda, mcimadamore
Contributed-by: srikanth.adayapalam@oracle.com

8066974: Compiler doesn't infer method's generic type information in lambda body
Summary: Add loghic to avoid post-inference triggers on temporarty AST types
Reviewed-by: jlahoda, vromero

8064365: Better support for finder capabilities in target-typing context
Summary: Add new framework to allow for easy creation of finder-like capabilities.
Reviewed-by: jjg, jlahoda

7101822: Compiling depends on order of imports
7177813: Static import to local nested class fails
Summary: MemberEnter overhaul - TypeEnter is split out of MemberEnter; the TypeEnter consists of several Phases which ensure actions are done in the correct order.
Reviewed-by: mcimadamore, jfranck, aeremeev
Contributed-by: jan.lahoda@oracle.com, maurizio.cimadamore@oracle.com

8065986: Compiler fails to NullPointerException when calling super with Object<>()
Summary: Missing POLY kind selector on recursive constructor calls with poly arguments
Reviewed-by: vromero

8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
Reviewed-by: jlahoda, vromero

8059921: Missing compile error in Java 8 mode for Interface.super.field access
Reviewed-by: mcimadamore, jlahoda

7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
Summary: Allowing final variables as operands to try-with-resources; also reviewed by Sergei Pikalev.
Reviewed-by: darcy, mcimadamore, vromero

8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
Summary: When calling dupUnshared on a shared scope, make sure the result does not contain Symbols that don't belong to the scope that is being dupUnshared.
Reviewed-by: mcimadamore

8064464: regression with type inference of conditional expression
Summary: Bad classification of conditional leads to spurious error
Reviewed-by: jlahoda

8054448: (ann) Cannot reference field of inner class in an anonymous class
Reviewed-by: jlahoda, mcimadamore

8054457: Refactor Symbol kinds from small ints to an enum
Summary: Replace bitmap logic in symbol.kind and pkind with an enum-based API
Reviewed-by: mcimadamore, jjg

8056258: Analysis of public API does not take super classes into account
8048609: simplify sjavac dependence on javac dependency gathering
Summary: Replaces Attr-/ResolveWithDeps with TaskListeners
Reviewed-by: jfranck, ohrstrom

8048614: Add TypeMetadata to contain type annotations and other type information
Summary: Implement general framework for metadata on types
Reviewed-by: mcimadamore

8057794: Compiler Error when obtaining .class property
Summary: Ensuring a non-null type and sym for illegal T.class to prevent downstream errors.
Reviewed-by: mcimadamore

8056021: checkin for JDK-8027262 breaks Checker Framework
Reviewed-by: jjg, mcimadamore

8056061: Mark implementations of public interfaces with an annotation
Summary: Adding @DefinedBy annotation to mark methods that implement public API methods; annotating the methods; adding a coding rules analyzer to enforce all such methods are annotated.
Reviewed-by: jjg, mcimadamore, jfranck
Contributed-by: jan.lahoda@oracle.com, jonathan.gibbons@oracle.com

Merge

8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com