remove unneeded includes; ok miod@

consolidate pci and cardbus detach code, and have it detach kstats.

this solves one probably with an re(4) going away.

Constify struct cfattach.

match on Realtek RTL8168H ids for Killer E2500V2 and E2600

checked against linux and windows drivers

match on another Realtek RTL8168 id

reported and tested by John Batteen on a TP-Link TG-3468

Remove the bus specific sc_ih (interrup handle) variable and use the common
sc_ih value of struct rl_softc. This fixes a crash in re(4) because
intr_barrier(9) is called with the rl_softc sc_ih which was NULL.
OK kettenis@

Some (probably newer) re(4) cards don't have the 32-bit memory BAR that
we try to map first. Instead there's a 64-bit memory BAR in the follow-
ing BAR. Since on the MACCHIATObin we currently do not support the IO
space, we have to use the 64-bit memory BAR. Thus, try to map the 64-
bit BAR before falling back to the 32-bit BAR and the IO bar.

ok deraadt@ kettenis@

From FreeBSD (r227593, r307982):
More and more RealTek controllers started to implement EEE feature.
Vendor driver seems to load a kind of firmware for EEE with
additional PHY fixups. It is known that the EEE feature may need
ASPM support. Unfortunately there is no documentation for EEE of
the controller so enabling ASPM may cause more problems.

The Realtek vendor drivers for FreeBSD and Linux also disable ASPM and
clock request. While here, add a define for the ECPM (Enable Clock Power
Management) bit.

Tested by stsp@ and myself.
ok stsp@

Rework re_start and re_txeof to only check the producer/consumer ring
positions when deciding how much work to do, and to adjust rl_tx_free with
atomic operations; split the flag that indicates whether we're using
timer based interrupts or not out into a separate field so it can be
changed from interrupt context without needing a lock; take the kernel
lock when calling re_init and re_start from interrupt context; add an
interrupt barrier in re_stop; and finally mark the interrupt handler
as mpsafe.

started by Jim Smith a while ago, mostly finished up at n2k15
tested by dlg@, chris@ and Dimitris Papastamos on various hardware
ok dlg@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Revert patch responsible for locking up machines with
"Realtek 8168" rev 0x01: RTL8168 2 (0x3800).
You will never guess who commited it without OK ;)

ok deraadt



revision 1.45
date: 2015/01/26 09:58:47; author: brad; state: Exp; lines: +22 -2; commitid: AppNYocFYbD7Hqgj;
Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

revision 1.46
date: 2015/02/19 04:58:34; author: dlg; state: Exp; lines: +2 -2; commitid: GSWXECXQW0LeGFmq;
when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

unifdef INET

Always put controller into known state before device intialization.

From FreeBSD

ok sthen@ chris@

Various changes to the re(4) feature flags..

Changed RL_FLAG_MACLDPS to RL_FLAG_MACRESET.
Removed RL_FLAG_INVMAR and RL_FLAG_NOJUMBO.
Added RL_FLAG_FASTETHER, RL_FLAG_CMDSTOP_WAIT_TXQ, RL_FLAG_JUMBOV2, RL_FLAG_WOL_MANLINK,
RL_FLAG_WAIT_TXPOLL, RL_FLAG_WOLRXENB.

Also set in the softc the maximum MTU for the various generations of chips.

Input from and Ok jsg@

Fewer <netinet/in_systm.h>

Enable MSI on the remaining chipsets.

ok naddy@ sthen@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Enable MSI on RT810xE.

ok jsg@

Sort the PCI ids.

ok dtucker@ jsing@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

add D-Link DGE-530T to re(4), update re(4) manpage
tested on i386, ok brad@ sthen@ phessler@

Backout MSI change. People are seeing watchdog timeouts, which must be caused
by missed interrupts. Commits to the FreeBSD driver suggest that the hardware
has issues. Having MSI for this driver isn't terribly important anyway.

Add MSI support.

ok dlg@, oga@

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

Wake On LAN support for re(4).
ok deraadt

remove the powerhook code. All architectures now use the ca_activate tree
traversal code to suspend/resume
ok oga kettenis blambert

spacing; ok deraadt@

Make sure we stop DMA before we suspend. Remove unused argument to re_stop()
to avoid the dilemma what meaningless value to pass.

ok deraadt@

Only re-initialise interfaces on suspend if they were IFF_RUNNING.

ok deraadt@, claudio@

Reset the chip an re-initialise the interface after reset. Resetting the
PHY doesn't seem to be necessary on re(4) so don't descend further for now.

Based on a diff from mlarkin@

ok deraadt@

More cases of shutdown hooks not needed after card is already stopped. In
these cases the xxstop function is a bit more complicated and has a flag of
some sort, but the use of that flag does not matter; DMA is already ceased
ok dlg

Make re(4) at pci(4) detachable.

ok jsg@, miod@

If re_attach() fails at any point make sure to disestablish various
resources setup by the bus front ends, especially the shutdown hook.
Found while testing some other changes with a CardBus adapter and
re_attach() was failing early before the interface pointer was
assigned. Then the system was rebooted, the shutdown hook was called
and *boom* in re_stop().

Detect if the adapter is a PCIe adapter and set the RL_FLAG_PCIE flag
if so.

Remove unused flags.

ok dlg@

Simplify the hw revision handling by removing the use of the
rl_type softc field and only relying on the sc_hwrev softc
field thoughout the driver.

Tested by a number of users from tech@

ok dlg@

move printing of the interrupt string into re_attach().

noone needs to know about the D0 state change; ok miod

Fix some "is is"s. ok otto@.

fix message printing when resetting the power state.

(fxp/re)_attach_common -> (fxp/re)_attach

do not bother playing tag with the PCI_COMMAND_STATUS_REG

add new RealTek PCI ids.

de-register, ANSI functions and a little cleaning.

add sys/timeout.h

identify 8139's in C+ mode with RL_8139CPLUS instead of RL_8139; no functional change.

rename the Realtek RT8111B entry to RT8168.

according to the Linux 8139cp driver the TTTech MC322 adapter uses
the 8139C+ chipset, so attach with re(4) instead of rl(4).

ok dlg@

attach 8139's capable of C+ mode to the re(4) driver, instead of the rl(4)
driver.

revert a small part of the last commit that wasn't supposed to go in.

add the Realtek RT8111B PCI Express Gigabit MAC.

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

add Linksys EG1032 rev 3

add D-Link DGE-528T and US Robotics USR997902

From: NetBSD

split re(4) into bus-independent code (ic/re.c) and PCI front-end
(pci/if_re_pci.c) for soon-to-come cardbus support; ok deraadt

consolidate pci and cardbus detach code, and have it detach kstats.

this solves one probably with an re(4) going away.

Constify struct cfattach.

match on Realtek RTL8168H ids for Killer E2500V2 and E2600

checked against linux and windows drivers

match on another Realtek RTL8168 id

reported and tested by John Batteen on a TP-Link TG-3468

Remove the bus specific sc_ih (interrup handle) variable and use the common
sc_ih value of struct rl_softc. This fixes a crash in re(4) because
intr_barrier(9) is called with the rl_softc sc_ih which was NULL.
OK kettenis@

Some (probably newer) re(4) cards don't have the 32-bit memory BAR that
we try to map first. Instead there's a 64-bit memory BAR in the follow-
ing BAR. Since on the MACCHIATObin we currently do not support the IO
space, we have to use the 64-bit memory BAR. Thus, try to map the 64-
bit BAR before falling back to the 32-bit BAR and the IO bar.

ok deraadt@ kettenis@

From FreeBSD (r227593, r307982):
More and more RealTek controllers started to implement EEE feature.
Vendor driver seems to load a kind of firmware for EEE with
additional PHY fixups. It is known that the EEE feature may need
ASPM support. Unfortunately there is no documentation for EEE of
the controller so enabling ASPM may cause more problems.

The Realtek vendor drivers for FreeBSD and Linux also disable ASPM and
clock request. While here, add a define for the ECPM (Enable Clock Power
Management) bit.

Tested by stsp@ and myself.
ok stsp@

Rework re_start and re_txeof to only check the producer/consumer ring
positions when deciding how much work to do, and to adjust rl_tx_free with
atomic operations; split the flag that indicates whether we're using
timer based interrupts or not out into a separate field so it can be
changed from interrupt context without needing a lock; take the kernel
lock when calling re_init and re_start from interrupt context; add an
interrupt barrier in re_stop; and finally mark the interrupt handler
as mpsafe.

started by Jim Smith a while ago, mostly finished up at n2k15
tested by dlg@, chris@ and Dimitris Papastamos on various hardware
ok dlg@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Revert patch responsible for locking up machines with
"Realtek 8168" rev 0x01: RTL8168 2 (0x3800).
You will never guess who commited it without OK ;)

ok deraadt



revision 1.45
date: 2015/01/26 09:58:47; author: brad; state: Exp; lines: +22 -2; commitid: AppNYocFYbD7Hqgj;
Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

revision 1.46
date: 2015/02/19 04:58:34; author: dlg; state: Exp; lines: +2 -2; commitid: GSWXECXQW0LeGFmq;
when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

unifdef INET

Always put controller into known state before device intialization.

From FreeBSD

ok sthen@ chris@

Various changes to the re(4) feature flags..

Changed RL_FLAG_MACLDPS to RL_FLAG_MACRESET.
Removed RL_FLAG_INVMAR and RL_FLAG_NOJUMBO.
Added RL_FLAG_FASTETHER, RL_FLAG_CMDSTOP_WAIT_TXQ, RL_FLAG_JUMBOV2, RL_FLAG_WOL_MANLINK,
RL_FLAG_WAIT_TXPOLL, RL_FLAG_WOLRXENB.

Also set in the softc the maximum MTU for the various generations of chips.

Input from and Ok jsg@

Fewer <netinet/in_systm.h>

Enable MSI on the remaining chipsets.

ok naddy@ sthen@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Enable MSI on RT810xE.

ok jsg@

Sort the PCI ids.

ok dtucker@ jsing@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

add D-Link DGE-530T to re(4), update re(4) manpage
tested on i386, ok brad@ sthen@ phessler@

Backout MSI change. People are seeing watchdog timeouts, which must be caused
by missed interrupts. Commits to the FreeBSD driver suggest that the hardware
has issues. Having MSI for this driver isn't terribly important anyway.

Add MSI support.

ok dlg@, oga@

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

Wake On LAN support for re(4).
ok deraadt

remove the powerhook code. All architectures now use the ca_activate tree
traversal code to suspend/resume
ok oga kettenis blambert

spacing; ok deraadt@

Make sure we stop DMA before we suspend. Remove unused argument to re_stop()
to avoid the dilemma what meaningless value to pass.

ok deraadt@

Only re-initialise interfaces on suspend if they were IFF_RUNNING.

ok deraadt@, claudio@

Reset the chip an re-initialise the interface after reset. Resetting the
PHY doesn't seem to be necessary on re(4) so don't descend further for now.

Based on a diff from mlarkin@

ok deraadt@

More cases of shutdown hooks not needed after card is already stopped. In
these cases the xxstop function is a bit more complicated and has a flag of
some sort, but the use of that flag does not matter; DMA is already ceased
ok dlg

Make re(4) at pci(4) detachable.

ok jsg@, miod@

If re_attach() fails at any point make sure to disestablish various
resources setup by the bus front ends, especially the shutdown hook.
Found while testing some other changes with a CardBus adapter and
re_attach() was failing early before the interface pointer was
assigned. Then the system was rebooted, the shutdown hook was called
and *boom* in re_stop().

Detect if the adapter is a PCIe adapter and set the RL_FLAG_PCIE flag
if so.

Remove unused flags.

ok dlg@

Simplify the hw revision handling by removing the use of the
rl_type softc field and only relying on the sc_hwrev softc
field thoughout the driver.

Tested by a number of users from tech@

ok dlg@

move printing of the interrupt string into re_attach().

noone needs to know about the D0 state change; ok miod

Fix some "is is"s. ok otto@.

fix message printing when resetting the power state.

(fxp/re)_attach_common -> (fxp/re)_attach

do not bother playing tag with the PCI_COMMAND_STATUS_REG

add new RealTek PCI ids.

de-register, ANSI functions and a little cleaning.

add sys/timeout.h

identify 8139's in C+ mode with RL_8139CPLUS instead of RL_8139; no functional change.

rename the Realtek RT8111B entry to RT8168.

according to the Linux 8139cp driver the TTTech MC322 adapter uses
the 8139C+ chipset, so attach with re(4) instead of rl(4).

ok dlg@

attach 8139's capable of C+ mode to the re(4) driver, instead of the rl(4)
driver.

revert a small part of the last commit that wasn't supposed to go in.

add the Realtek RT8111B PCI Express Gigabit MAC.

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

add Linksys EG1032 rev 3

add D-Link DGE-528T and US Robotics USR997902

From: NetBSD

split re(4) into bus-independent code (ic/re.c) and PCI front-end
(pci/if_re_pci.c) for soon-to-come cardbus support; ok deraadt

Constify struct cfattach.

match on Realtek RTL8168H ids for Killer E2500V2 and E2600

checked against linux and windows drivers

match on another Realtek RTL8168 id

reported and tested by John Batteen on a TP-Link TG-3468

Remove the bus specific sc_ih (interrup handle) variable and use the common
sc_ih value of struct rl_softc. This fixes a crash in re(4) because
intr_barrier(9) is called with the rl_softc sc_ih which was NULL.
OK kettenis@

Some (probably newer) re(4) cards don't have the 32-bit memory BAR that
we try to map first. Instead there's a 64-bit memory BAR in the follow-
ing BAR. Since on the MACCHIATObin we currently do not support the IO
space, we have to use the 64-bit memory BAR. Thus, try to map the 64-
bit BAR before falling back to the 32-bit BAR and the IO bar.

ok deraadt@ kettenis@

From FreeBSD (r227593, r307982):
More and more RealTek controllers started to implement EEE feature.
Vendor driver seems to load a kind of firmware for EEE with
additional PHY fixups. It is known that the EEE feature may need
ASPM support. Unfortunately there is no documentation for EEE of
the controller so enabling ASPM may cause more problems.

The Realtek vendor drivers for FreeBSD and Linux also disable ASPM and
clock request. While here, add a define for the ECPM (Enable Clock Power
Management) bit.

Tested by stsp@ and myself.
ok stsp@

Rework re_start and re_txeof to only check the producer/consumer ring
positions when deciding how much work to do, and to adjust rl_tx_free with
atomic operations; split the flag that indicates whether we're using
timer based interrupts or not out into a separate field so it can be
changed from interrupt context without needing a lock; take the kernel
lock when calling re_init and re_start from interrupt context; add an
interrupt barrier in re_stop; and finally mark the interrupt handler
as mpsafe.

started by Jim Smith a while ago, mostly finished up at n2k15
tested by dlg@, chris@ and Dimitris Papastamos on various hardware
ok dlg@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Revert patch responsible for locking up machines with
"Realtek 8168" rev 0x01: RTL8168 2 (0x3800).
You will never guess who commited it without OK ;)

ok deraadt



revision 1.45
date: 2015/01/26 09:58:47; author: brad; state: Exp; lines: +22 -2; commitid: AppNYocFYbD7Hqgj;
Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

revision 1.46
date: 2015/02/19 04:58:34; author: dlg; state: Exp; lines: +2 -2; commitid: GSWXECXQW0LeGFmq;
when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

unifdef INET

Always put controller into known state before device intialization.

From FreeBSD

ok sthen@ chris@

Various changes to the re(4) feature flags..

Changed RL_FLAG_MACLDPS to RL_FLAG_MACRESET.
Removed RL_FLAG_INVMAR and RL_FLAG_NOJUMBO.
Added RL_FLAG_FASTETHER, RL_FLAG_CMDSTOP_WAIT_TXQ, RL_FLAG_JUMBOV2, RL_FLAG_WOL_MANLINK,
RL_FLAG_WAIT_TXPOLL, RL_FLAG_WOLRXENB.

Also set in the softc the maximum MTU for the various generations of chips.

Input from and Ok jsg@

Fewer <netinet/in_systm.h>

Enable MSI on the remaining chipsets.

ok naddy@ sthen@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Enable MSI on RT810xE.

ok jsg@

Sort the PCI ids.

ok dtucker@ jsing@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

add D-Link DGE-530T to re(4), update re(4) manpage
tested on i386, ok brad@ sthen@ phessler@

Backout MSI change. People are seeing watchdog timeouts, which must be caused
by missed interrupts. Commits to the FreeBSD driver suggest that the hardware
has issues. Having MSI for this driver isn't terribly important anyway.

Add MSI support.

ok dlg@, oga@

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

Wake On LAN support for re(4).
ok deraadt

remove the powerhook code. All architectures now use the ca_activate tree
traversal code to suspend/resume
ok oga kettenis blambert

spacing; ok deraadt@

Make sure we stop DMA before we suspend. Remove unused argument to re_stop()
to avoid the dilemma what meaningless value to pass.

ok deraadt@

Only re-initialise interfaces on suspend if they were IFF_RUNNING.

ok deraadt@, claudio@

Reset the chip an re-initialise the interface after reset. Resetting the
PHY doesn't seem to be necessary on re(4) so don't descend further for now.

Based on a diff from mlarkin@

ok deraadt@

More cases of shutdown hooks not needed after card is already stopped. In
these cases the xxstop function is a bit more complicated and has a flag of
some sort, but the use of that flag does not matter; DMA is already ceased
ok dlg

Make re(4) at pci(4) detachable.

ok jsg@, miod@

If re_attach() fails at any point make sure to disestablish various
resources setup by the bus front ends, especially the shutdown hook.
Found while testing some other changes with a CardBus adapter and
re_attach() was failing early before the interface pointer was
assigned. Then the system was rebooted, the shutdown hook was called
and *boom* in re_stop().

Detect if the adapter is a PCIe adapter and set the RL_FLAG_PCIE flag
if so.

Remove unused flags.

ok dlg@

Simplify the hw revision handling by removing the use of the
rl_type softc field and only relying on the sc_hwrev softc
field thoughout the driver.

Tested by a number of users from tech@

ok dlg@

move printing of the interrupt string into re_attach().

noone needs to know about the D0 state change; ok miod

Fix some "is is"s. ok otto@.

fix message printing when resetting the power state.

(fxp/re)_attach_common -> (fxp/re)_attach

do not bother playing tag with the PCI_COMMAND_STATUS_REG

add new RealTek PCI ids.

de-register, ANSI functions and a little cleaning.

add sys/timeout.h

identify 8139's in C+ mode with RL_8139CPLUS instead of RL_8139; no functional change.

rename the Realtek RT8111B entry to RT8168.

according to the Linux 8139cp driver the TTTech MC322 adapter uses
the 8139C+ chipset, so attach with re(4) instead of rl(4).

ok dlg@

attach 8139's capable of C+ mode to the re(4) driver, instead of the rl(4)
driver.

revert a small part of the last commit that wasn't supposed to go in.

add the Realtek RT8111B PCI Express Gigabit MAC.

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

add Linksys EG1032 rev 3

add D-Link DGE-528T and US Robotics USR997902

From: NetBSD

split re(4) into bus-independent code (ic/re.c) and PCI front-end
(pci/if_re_pci.c) for soon-to-come cardbus support; ok deraadt

match on Realtek RTL8168H ids for Killer E2500V2 and E2600

checked against linux and windows drivers

match on another Realtek RTL8168 id

reported and tested by John Batteen on a TP-Link TG-3468

Remove the bus specific sc_ih (interrup handle) variable and use the common
sc_ih value of struct rl_softc. This fixes a crash in re(4) because
intr_barrier(9) is called with the rl_softc sc_ih which was NULL.
OK kettenis@

Some (probably newer) re(4) cards don't have the 32-bit memory BAR that
we try to map first. Instead there's a 64-bit memory BAR in the follow-
ing BAR. Since on the MACCHIATObin we currently do not support the IO
space, we have to use the 64-bit memory BAR. Thus, try to map the 64-
bit BAR before falling back to the 32-bit BAR and the IO bar.

ok deraadt@ kettenis@

From FreeBSD (r227593, r307982):
More and more RealTek controllers started to implement EEE feature.
Vendor driver seems to load a kind of firmware for EEE with
additional PHY fixups. It is known that the EEE feature may need
ASPM support. Unfortunately there is no documentation for EEE of
the controller so enabling ASPM may cause more problems.

The Realtek vendor drivers for FreeBSD and Linux also disable ASPM and
clock request. While here, add a define for the ECPM (Enable Clock Power
Management) bit.

Tested by stsp@ and myself.
ok stsp@

Rework re_start and re_txeof to only check the producer/consumer ring
positions when deciding how much work to do, and to adjust rl_tx_free with
atomic operations; split the flag that indicates whether we're using
timer based interrupts or not out into a separate field so it can be
changed from interrupt context without needing a lock; take the kernel
lock when calling re_init and re_start from interrupt context; add an
interrupt barrier in re_stop; and finally mark the interrupt handler
as mpsafe.

started by Jim Smith a while ago, mostly finished up at n2k15
tested by dlg@, chris@ and Dimitris Papastamos on various hardware
ok dlg@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Revert patch responsible for locking up machines with
"Realtek 8168" rev 0x01: RTL8168 2 (0x3800).
You will never guess who commited it without OK ;)

ok deraadt



revision 1.45
date: 2015/01/26 09:58:47; author: brad; state: Exp; lines: +22 -2; commitid: AppNYocFYbD7Hqgj;
Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

revision 1.46
date: 2015/02/19 04:58:34; author: dlg; state: Exp; lines: +2 -2; commitid: GSWXECXQW0LeGFmq;
when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

unifdef INET

Always put controller into known state before device intialization.

From FreeBSD

ok sthen@ chris@

Various changes to the re(4) feature flags..

Changed RL_FLAG_MACLDPS to RL_FLAG_MACRESET.
Removed RL_FLAG_INVMAR and RL_FLAG_NOJUMBO.
Added RL_FLAG_FASTETHER, RL_FLAG_CMDSTOP_WAIT_TXQ, RL_FLAG_JUMBOV2, RL_FLAG_WOL_MANLINK,
RL_FLAG_WAIT_TXPOLL, RL_FLAG_WOLRXENB.

Also set in the softc the maximum MTU for the various generations of chips.

Input from and Ok jsg@

Fewer <netinet/in_systm.h>

Enable MSI on the remaining chipsets.

ok naddy@ sthen@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Enable MSI on RT810xE.

ok jsg@

Sort the PCI ids.

ok dtucker@ jsing@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

add D-Link DGE-530T to re(4), update re(4) manpage
tested on i386, ok brad@ sthen@ phessler@

Backout MSI change. People are seeing watchdog timeouts, which must be caused
by missed interrupts. Commits to the FreeBSD driver suggest that the hardware
has issues. Having MSI for this driver isn't terribly important anyway.

Add MSI support.

ok dlg@, oga@

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

Wake On LAN support for re(4).
ok deraadt

remove the powerhook code. All architectures now use the ca_activate tree
traversal code to suspend/resume
ok oga kettenis blambert

spacing; ok deraadt@

Make sure we stop DMA before we suspend. Remove unused argument to re_stop()
to avoid the dilemma what meaningless value to pass.

ok deraadt@

Only re-initialise interfaces on suspend if they were IFF_RUNNING.

ok deraadt@, claudio@

Reset the chip an re-initialise the interface after reset. Resetting the
PHY doesn't seem to be necessary on re(4) so don't descend further for now.

Based on a diff from mlarkin@

ok deraadt@

More cases of shutdown hooks not needed after card is already stopped. In
these cases the xxstop function is a bit more complicated and has a flag of
some sort, but the use of that flag does not matter; DMA is already ceased
ok dlg

Make re(4) at pci(4) detachable.

ok jsg@, miod@

If re_attach() fails at any point make sure to disestablish various
resources setup by the bus front ends, especially the shutdown hook.
Found while testing some other changes with a CardBus adapter and
re_attach() was failing early before the interface pointer was
assigned. Then the system was rebooted, the shutdown hook was called
and *boom* in re_stop().

Detect if the adapter is a PCIe adapter and set the RL_FLAG_PCIE flag
if so.

Remove unused flags.

ok dlg@

Simplify the hw revision handling by removing the use of the
rl_type softc field and only relying on the sc_hwrev softc
field thoughout the driver.

Tested by a number of users from tech@

ok dlg@

move printing of the interrupt string into re_attach().

noone needs to know about the D0 state change; ok miod

Fix some "is is"s. ok otto@.

fix message printing when resetting the power state.

(fxp/re)_attach_common -> (fxp/re)_attach

do not bother playing tag with the PCI_COMMAND_STATUS_REG

add new RealTek PCI ids.

de-register, ANSI functions and a little cleaning.

add sys/timeout.h

identify 8139's in C+ mode with RL_8139CPLUS instead of RL_8139; no functional change.

rename the Realtek RT8111B entry to RT8168.

according to the Linux 8139cp driver the TTTech MC322 adapter uses
the 8139C+ chipset, so attach with re(4) instead of rl(4).

ok dlg@

attach 8139's capable of C+ mode to the re(4) driver, instead of the rl(4)
driver.

revert a small part of the last commit that wasn't supposed to go in.

add the Realtek RT8111B PCI Express Gigabit MAC.

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

add Linksys EG1032 rev 3

add D-Link DGE-528T and US Robotics USR997902

From: NetBSD

split re(4) into bus-independent code (ic/re.c) and PCI front-end
(pci/if_re_pci.c) for soon-to-come cardbus support; ok deraadt

Remove the bus specific sc_ih (interrup handle) variable and use the common
sc_ih value of struct rl_softc. This fixes a crash in re(4) because
intr_barrier(9) is called with the rl_softc sc_ih which was NULL.
OK kettenis@

Some (probably newer) re(4) cards don't have the 32-bit memory BAR that
we try to map first. Instead there's a 64-bit memory BAR in the follow-
ing BAR. Since on the MACCHIATObin we currently do not support the IO
space, we have to use the 64-bit memory BAR. Thus, try to map the 64-
bit BAR before falling back to the 32-bit BAR and the IO bar.

ok deraadt@ kettenis@

From FreeBSD (r227593, r307982):
More and more RealTek controllers started to implement EEE feature.
Vendor driver seems to load a kind of firmware for EEE with
additional PHY fixups. It is known that the EEE feature may need
ASPM support. Unfortunately there is no documentation for EEE of
the controller so enabling ASPM may cause more problems.

The Realtek vendor drivers for FreeBSD and Linux also disable ASPM and
clock request. While here, add a define for the ECPM (Enable Clock Power
Management) bit.

Tested by stsp@ and myself.
ok stsp@

Rework re_start and re_txeof to only check the producer/consumer ring
positions when deciding how much work to do, and to adjust rl_tx_free with
atomic operations; split the flag that indicates whether we're using
timer based interrupts or not out into a separate field so it can be
changed from interrupt context without needing a lock; take the kernel
lock when calling re_init and re_start from interrupt context; add an
interrupt barrier in re_stop; and finally mark the interrupt handler
as mpsafe.

started by Jim Smith a while ago, mostly finished up at n2k15
tested by dlg@, chris@ and Dimitris Papastamos on various hardware
ok dlg@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Revert patch responsible for locking up machines with
"Realtek 8168" rev 0x01: RTL8168 2 (0x3800).
You will never guess who commited it without OK ;)

ok deraadt



revision 1.45
date: 2015/01/26 09:58:47; author: brad; state: Exp; lines: +22 -2; commitid: AppNYocFYbD7Hqgj;
Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

revision 1.46
date: 2015/02/19 04:58:34; author: dlg; state: Exp; lines: +2 -2; commitid: GSWXECXQW0LeGFmq;
when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

unifdef INET

Always put controller into known state before device intialization.

From FreeBSD

ok sthen@ chris@

Various changes to the re(4) feature flags..

Changed RL_FLAG_MACLDPS to RL_FLAG_MACRESET.
Removed RL_FLAG_INVMAR and RL_FLAG_NOJUMBO.
Added RL_FLAG_FASTETHER, RL_FLAG_CMDSTOP_WAIT_TXQ, RL_FLAG_JUMBOV2, RL_FLAG_WOL_MANLINK,
RL_FLAG_WAIT_TXPOLL, RL_FLAG_WOLRXENB.

Also set in the softc the maximum MTU for the various generations of chips.

Input from and Ok jsg@

Fewer <netinet/in_systm.h>

Enable MSI on the remaining chipsets.

ok naddy@ sthen@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Enable MSI on RT810xE.

ok jsg@

Sort the PCI ids.

ok dtucker@ jsing@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

add D-Link DGE-530T to re(4), update re(4) manpage
tested on i386, ok brad@ sthen@ phessler@

Backout MSI change. People are seeing watchdog timeouts, which must be caused
by missed interrupts. Commits to the FreeBSD driver suggest that the hardware
has issues. Having MSI for this driver isn't terribly important anyway.

Add MSI support.

ok dlg@, oga@

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

Wake On LAN support for re(4).
ok deraadt

remove the powerhook code. All architectures now use the ca_activate tree
traversal code to suspend/resume
ok oga kettenis blambert

spacing; ok deraadt@

Make sure we stop DMA before we suspend. Remove unused argument to re_stop()
to avoid the dilemma what meaningless value to pass.

ok deraadt@

Only re-initialise interfaces on suspend if they were IFF_RUNNING.

ok deraadt@, claudio@

Reset the chip an re-initialise the interface after reset. Resetting the
PHY doesn't seem to be necessary on re(4) so don't descend further for now.

Based on a diff from mlarkin@

ok deraadt@

More cases of shutdown hooks not needed after card is already stopped. In
these cases the xxstop function is a bit more complicated and has a flag of
some sort, but the use of that flag does not matter; DMA is already ceased
ok dlg

Make re(4) at pci(4) detachable.

ok jsg@, miod@

If re_attach() fails at any point make sure to disestablish various
resources setup by the bus front ends, especially the shutdown hook.
Found while testing some other changes with a CardBus adapter and
re_attach() was failing early before the interface pointer was
assigned. Then the system was rebooted, the shutdown hook was called
and *boom* in re_stop().

Detect if the adapter is a PCIe adapter and set the RL_FLAG_PCIE flag
if so.

Remove unused flags.

ok dlg@

Simplify the hw revision handling by removing the use of the
rl_type softc field and only relying on the sc_hwrev softc
field thoughout the driver.

Tested by a number of users from tech@

ok dlg@

move printing of the interrupt string into re_attach().

noone needs to know about the D0 state change; ok miod

Fix some "is is"s. ok otto@.

fix message printing when resetting the power state.

(fxp/re)_attach_common -> (fxp/re)_attach

do not bother playing tag with the PCI_COMMAND_STATUS_REG

add new RealTek PCI ids.

de-register, ANSI functions and a little cleaning.

add sys/timeout.h

identify 8139's in C+ mode with RL_8139CPLUS instead of RL_8139; no functional change.

rename the Realtek RT8111B entry to RT8168.

according to the Linux 8139cp driver the TTTech MC322 adapter uses
the 8139C+ chipset, so attach with re(4) instead of rl(4).

ok dlg@

attach 8139's capable of C+ mode to the re(4) driver, instead of the rl(4)
driver.

revert a small part of the last commit that wasn't supposed to go in.

add the Realtek RT8111B PCI Express Gigabit MAC.

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

add Linksys EG1032 rev 3

add D-Link DGE-528T and US Robotics USR997902

From: NetBSD

split re(4) into bus-independent code (ic/re.c) and PCI front-end
(pci/if_re_pci.c) for soon-to-come cardbus support; ok deraadt

Some (probably newer) re(4) cards don't have the 32-bit memory BAR that
we try to map first. Instead there's a 64-bit memory BAR in the follow-
ing BAR. Since on the MACCHIATObin we currently do not support the IO
space, we have to use the 64-bit memory BAR. Thus, try to map the 64-
bit BAR before falling back to the 32-bit BAR and the IO bar.

ok deraadt@ kettenis@

From FreeBSD (r227593, r307982):
More and more RealTek controllers started to implement EEE feature.
Vendor driver seems to load a kind of firmware for EEE with
additional PHY fixups. It is known that the EEE feature may need
ASPM support. Unfortunately there is no documentation for EEE of
the controller so enabling ASPM may cause more problems.

The Realtek vendor drivers for FreeBSD and Linux also disable ASPM and
clock request. While here, add a define for the ECPM (Enable Clock Power
Management) bit.

Tested by stsp@ and myself.
ok stsp@

Rework re_start and re_txeof to only check the producer/consumer ring
positions when deciding how much work to do, and to adjust rl_tx_free with
atomic operations; split the flag that indicates whether we're using
timer based interrupts or not out into a separate field so it can be
changed from interrupt context without needing a lock; take the kernel
lock when calling re_init and re_start from interrupt context; add an
interrupt barrier in re_stop; and finally mark the interrupt handler
as mpsafe.

started by Jim Smith a while ago, mostly finished up at n2k15
tested by dlg@, chris@ and Dimitris Papastamos on various hardware
ok dlg@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Revert patch responsible for locking up machines with
"Realtek 8168" rev 0x01: RTL8168 2 (0x3800).
You will never guess who commited it without OK ;)

ok deraadt



revision 1.45
date: 2015/01/26 09:58:47; author: brad; state: Exp; lines: +22 -2; commitid: AppNYocFYbD7Hqgj;
Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

revision 1.46
date: 2015/02/19 04:58:34; author: dlg; state: Exp; lines: +2 -2; commitid: GSWXECXQW0LeGFmq;
when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

unifdef INET

Always put controller into known state before device intialization.

From FreeBSD

ok sthen@ chris@

Various changes to the re(4) feature flags..

Changed RL_FLAG_MACLDPS to RL_FLAG_MACRESET.
Removed RL_FLAG_INVMAR and RL_FLAG_NOJUMBO.
Added RL_FLAG_FASTETHER, RL_FLAG_CMDSTOP_WAIT_TXQ, RL_FLAG_JUMBOV2, RL_FLAG_WOL_MANLINK,
RL_FLAG_WAIT_TXPOLL, RL_FLAG_WOLRXENB.

Also set in the softc the maximum MTU for the various generations of chips.

Input from and Ok jsg@

Fewer <netinet/in_systm.h>

Enable MSI on the remaining chipsets.

ok naddy@ sthen@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Enable MSI on RT810xE.

ok jsg@

Sort the PCI ids.

ok dtucker@ jsing@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

add D-Link DGE-530T to re(4), update re(4) manpage
tested on i386, ok brad@ sthen@ phessler@

Backout MSI change. People are seeing watchdog timeouts, which must be caused
by missed interrupts. Commits to the FreeBSD driver suggest that the hardware
has issues. Having MSI for this driver isn't terribly important anyway.

Add MSI support.

ok dlg@, oga@

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

Wake On LAN support for re(4).
ok deraadt

remove the powerhook code. All architectures now use the ca_activate tree
traversal code to suspend/resume
ok oga kettenis blambert

spacing; ok deraadt@

Make sure we stop DMA before we suspend. Remove unused argument to re_stop()
to avoid the dilemma what meaningless value to pass.

ok deraadt@

Only re-initialise interfaces on suspend if they were IFF_RUNNING.

ok deraadt@, claudio@

Reset the chip an re-initialise the interface after reset. Resetting the
PHY doesn't seem to be necessary on re(4) so don't descend further for now.

Based on a diff from mlarkin@

ok deraadt@

More cases of shutdown hooks not needed after card is already stopped. In
these cases the xxstop function is a bit more complicated and has a flag of
some sort, but the use of that flag does not matter; DMA is already ceased
ok dlg

Make re(4) at pci(4) detachable.

ok jsg@, miod@

If re_attach() fails at any point make sure to disestablish various
resources setup by the bus front ends, especially the shutdown hook.
Found while testing some other changes with a CardBus adapter and
re_attach() was failing early before the interface pointer was
assigned. Then the system was rebooted, the shutdown hook was called
and *boom* in re_stop().

Detect if the adapter is a PCIe adapter and set the RL_FLAG_PCIE flag
if so.

Remove unused flags.

ok dlg@

Simplify the hw revision handling by removing the use of the
rl_type softc field and only relying on the sc_hwrev softc
field thoughout the driver.

Tested by a number of users from tech@

ok dlg@

move printing of the interrupt string into re_attach().

noone needs to know about the D0 state change; ok miod

Fix some "is is"s. ok otto@.

fix message printing when resetting the power state.

(fxp/re)_attach_common -> (fxp/re)_attach

do not bother playing tag with the PCI_COMMAND_STATUS_REG

add new RealTek PCI ids.

de-register, ANSI functions and a little cleaning.

add sys/timeout.h

identify 8139's in C+ mode with RL_8139CPLUS instead of RL_8139; no functional change.

rename the Realtek RT8111B entry to RT8168.

according to the Linux 8139cp driver the TTTech MC322 adapter uses
the 8139C+ chipset, so attach with re(4) instead of rl(4).

ok dlg@

attach 8139's capable of C+ mode to the re(4) driver, instead of the rl(4)
driver.

revert a small part of the last commit that wasn't supposed to go in.

add the Realtek RT8111B PCI Express Gigabit MAC.

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

add Linksys EG1032 rev 3

add D-Link DGE-528T and US Robotics USR997902

From: NetBSD

split re(4) into bus-independent code (ic/re.c) and PCI front-end
(pci/if_re_pci.c) for soon-to-come cardbus support; ok deraadt

From FreeBSD (r227593, r307982):
More and more RealTek controllers started to implement EEE feature.
Vendor driver seems to load a kind of firmware for EEE with
additional PHY fixups. It is known that the EEE feature may need
ASPM support. Unfortunately there is no documentation for EEE of
the controller so enabling ASPM may cause more problems.

The Realtek vendor drivers for FreeBSD and Linux also disable ASPM and
clock request. While here, add a define for the ECPM (Enable Clock Power
Management) bit.

Tested by stsp@ and myself.
ok stsp@

Rework re_start and re_txeof to only check the producer/consumer ring
positions when deciding how much work to do, and to adjust rl_tx_free with
atomic operations; split the flag that indicates whether we're using
timer based interrupts or not out into a separate field so it can be
changed from interrupt context without needing a lock; take the kernel
lock when calling re_init and re_start from interrupt context; add an
interrupt barrier in re_stop; and finally mark the interrupt handler
as mpsafe.

started by Jim Smith a while ago, mostly finished up at n2k15
tested by dlg@, chris@ and Dimitris Papastamos on various hardware
ok dlg@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Revert patch responsible for locking up machines with
"Realtek 8168" rev 0x01: RTL8168 2 (0x3800).
You will never guess who commited it without OK ;)

ok deraadt



revision 1.45
date: 2015/01/26 09:58:47; author: brad; state: Exp; lines: +22 -2; commitid: AppNYocFYbD7Hqgj;
Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

revision 1.46
date: 2015/02/19 04:58:34; author: dlg; state: Exp; lines: +2 -2; commitid: GSWXECXQW0LeGFmq;
when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

when reading the max packet size in the pcie device config and
status register, correctly mask things so we're left with the mps
field instead of everything but the mps field.

tested by bcallah@ and jim smith

Set PCIe max read request size to 2K to help with TX performance.

From FreeBSD

Tested with 8168C, 8168D and 8168G.

unifdef INET

Always put controller into known state before device intialization.

From FreeBSD

ok sthen@ chris@

Various changes to the re(4) feature flags..

Changed RL_FLAG_MACLDPS to RL_FLAG_MACRESET.
Removed RL_FLAG_INVMAR and RL_FLAG_NOJUMBO.
Added RL_FLAG_FASTETHER, RL_FLAG_CMDSTOP_WAIT_TXQ, RL_FLAG_JUMBOV2, RL_FLAG_WOL_MANLINK,
RL_FLAG_WAIT_TXPOLL, RL_FLAG_WOLRXENB.

Also set in the softc the maximum MTU for the various generations of chips.

Input from and Ok jsg@

Fewer <netinet/in_systm.h>

Enable MSI on the remaining chipsets.

ok naddy@ sthen@

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

Enable MSI on RT810xE.

ok jsg@

Sort the PCI ids.

ok dtucker@ jsing@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

add D-Link DGE-530T to re(4), update re(4) manpage
tested on i386, ok brad@ sthen@ phessler@

Backout MSI change. People are seeing watchdog timeouts, which must be caused
by missed interrupts. Commits to the FreeBSD driver suggest that the hardware
has issues. Having MSI for this driver isn't terribly important anyway.

Add MSI support.

ok dlg@, oga@

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

Wake On LAN support for re(4).
ok deraadt

remove the powerhook code. All architectures now use the ca_activate tree
traversal code to suspend/resume
ok oga kettenis blambert

spacing; ok deraadt@

Make sure we stop DMA before we suspend. Remove unused argument to re_stop()
to avoid the dilemma what meaningless value to pass.

ok deraadt@

Only re-initialise interfaces on suspend if they were IFF_RUNNING.

ok deraadt@, claudio@

Reset the chip an re-initialise the interface after reset. Resetting the
PHY doesn't seem to be necessary on re(4) so don't descend further for now.

Based on a diff from mlarkin@

ok deraadt@

More cases of shutdown hooks not needed after card is already stopped. In
these cases the xxstop function is a bit more complicated and has a flag of
some sort, but the use of that flag does not matter; DMA is already ceased
ok dlg

Make re(4) at pci(4) detachable.

ok jsg@, miod@

If re_attach() fails at any point make sure to disestablish various
resources setup by the bus front ends, especially the shutdown hook.
Found while testing some other changes with a CardBus adapter and
re_attach() was failing early before the interface pointer was
assigned. Then the system was rebooted, the shutdown hook was called
and *boom* in re_stop().

Detect if the adapter is a PCIe adapter and set the RL_FLAG_PCIE flag
if so.

Remove unused flags.

ok dlg@

Simplify the hw revision handling by removing the use of the
rl_type softc field and only relying on the sc_hwrev softc
field thoughout the driver.

Tested by a number of users from tech@

ok dlg@

move printing of the interrupt string into re_attach().

noone needs to know about the D0 state change; ok miod

Fix some "is is"s. ok otto@.

fix message printing when resetting the power state.

(fxp/re)_attach_common -> (fxp/re)_attach

do not bother playing tag with the PCI_COMMAND_STATUS_REG

add new RealTek PCI ids.

de-register, ANSI functions and a little cleaning.

add sys/timeout.h

identify 8139's in C+ mode with RL_8139CPLUS instead of RL_8139; no functional change.

rename the Realtek RT8111B entry to RT8168.

according to the Linux 8139cp driver the TTTech MC322 adapter uses
the 8139C+ chipset, so attach with re(4) instead of rl(4).

ok dlg@

attach 8139's capable of C+ mode to the re(4) driver, instead of the rl(4)
driver.

revert a small part of the last commit that wasn't supposed to go in.

add the Realtek RT8111B PCI Express Gigabit MAC.

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

add Linksys EG1032 rev 3

add D-Link DGE-528T and US Robotics USR997902

From: NetBSD

split re(4) into bus-independent code (ic/re.c) and PCI front-end
(pci/if_re_pci.c) for soon-to-come cardbus support; ok deraadt