MFC r337500:
Use the right variable when updating interface routes.

PR: 229807

Revert r330897:

This was intended to be a non-functional change. It wasn't. The commit
message was thus wrong. In addition it broke arm, and merged crypto
related code.

Revert with prejudice.

This revert skips files touched in r316370 since that commit was since
MFCed. This revert also skips files that require $FreeBSD$ property
changes.

Thank you to those who helped me get out of this mess including but not
limited to gonzo, kevans, rgrimes.

Requested by: gjb (re)

Partial merge of the SPDX changes

These changes are incomplete but are making it difficult
to determine what other changes can/should be merged.

No objections from: pfg

MFC r311572, r311895, r311928, r311985, r312395, r312417

r311572:
Fix file descriptor leaks in cmp(1)

Also, add a few test cases

Reported by: Coverity
CID: 271624 275338
Reviewed by: ngie
MFC after: 4 weeks
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D9074

r311895:
Fix memory leaks during "tail -r" of an irregular file

* Rewrite r_buf to use standard tail queues instead of a hand-rolled
circular linked list. Free dynamic allocations when done.
* Remove an optimization for the case where the file is a multiple of 128KB
in size and there is a scarcity of memory.
* Add ATF tests for "tail -r" and its variants.

Reported by: Valgrind
Reviewed by: ngie
MFC after: 4 weeks
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D9067

r311928:
Fix build of usr.bin/tail with GCC

Submitted by: pluknet
Reported by: pluknet
MFC after: 27 days
X-MFC-with: 311895
Sponsored by: Spectra Logic Corp

r311985:
Fix uninitialized variable CIDs in route6d

The variables in question are actually return arguments, but it's still good
form to initialize them.

Reported by: Coverity
CID: 979679 979680
MFC after: 4 weeks
Sponsored by: Spectra Logic Corp

r312395:
Fix several Coverity CIDs in devd

CID 1362055, 1362054: File descriptor leaks during shutdown
CID 1362013: Potential null-termination fail with long network device names
CID 1362097: Uncaught exception during memory pressure
CID 1362017, 1362016: Unchecked errors, possibly resulting in weird behavior
if two devd instances start at the same time.
CID 1362015: Unchecked error that will probably never fail

Reported by: Coverity
CID: 1362055 1362054 1362013 1362097 1362017 1362016 1362015
MFC after: 4 weeks
Sponsored by: Spectra Logic Corp

r312417:
Fix build of devd with GCC 4.2

Reported by: olivier
Pointy-hat-to: asomers
MFC after: 27 days
X-MFC-with: 312395
Sponsored by: Spectra Logic Corp

MFC r311711,r311712,r311713:

r311711:

Clean up trailing whitespace

r311712:

Sort #includes

r311713:

Use nitems(mib) instead of hardcoding mib's length

Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle.
Prune svn:mergeinfo from the new branch, as nothing has been merged
here.

Additional commits post-branch will follow.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Use strlcpy() instead of strncpy() when copying ifname to ensure
that it is NUL terminated. Additional NUL padding is not required
for short names.

Reported by: Coverity
CID: 1009974
MFC after: 1 week

route6d(8): Fix potential double-free

In the case that the subsequent sysctl(3) call failed, 'buf' could be free(3)ed
repeatedly. It isn't clear to me that that case is possible, but be clear and
do the right thing in case it is.

Reported by: Coverity
CID: 272537
Sponsored by: EMC / Isilon Storage Division

Stop including if_var.h from userland.

Sponsored by: Nginx, Inc.

Recover sin6_scope_id of gateway addresses in riprecv() by using the if_index
where a RIP packet was received. This fixes a bug which prevented gateway
addresses in fe80::/64 from being added.

Remove unneeded fake _KERNEL definition.

Garbage collect long time obsoleted (or never used) stuff from routing API.

Axe IFF_SMART. Fortunately this layering violating flag was never used,
it was just declared.

- Increase the number of retry for NET_RT_DUMP from 5 to 15.
- Use 2001:db8:: as an example instead of deprecated 3ffe:: address block.
- Add check for connected routes.
- Add support of RTM_IFANNOUNCE for dyanmically-added/removed interfaces.
- Add support of *, ?, and [ in the interface list.
- Add -P number to specify route flag which will never expire.
- Add -Q number to specify route flag which route6d will add to routes via RIP.
- Add -p pidfile to specify the process ID file.

Overhaul of route6d(8):

- Use queue(3) for linked-list.
- Use a consistent naming scheme for struct members.
- Use ANSI C style function declaration.
- Add check of RTM_VERSION mismatch.

There is no functional change.

Use sin6_scope_id instead of KAME-specific embedded scope id.

Spelling fixes for usr.sbin/

In usr.sbin/route6d/route6d.c, use the correct printf length modifier
for an ssize_t.

MFC after: 1 week

This main goals of this project are:
1. separating L2 tables (ARP, NDP) from the L3 routing tables
2. removing as much locking dependencies among these layers as
possible to allow for some parallelism in the search operations
3. simplify the logic in the routing code,

The most notable end result is the obsolescent of the route
cloning (RTF_CLONING) concept, which translated into code reduction
in both IPv4 ARP and IPv6 NDP related modules, and size reduction in
struct rtentry{}. The change in design obsoletes the semantics of
RTF_CLONING, RTF_WASCLONE and RTF_LLINFO routing flags. The userland
applications such as "arp" and "ndp" have been modified to reflect
those changes. The output from "netstat -r" shows only the routing
entries.

Quite a few developers have contributed to this project in the
past: Glebius Smirnoff, Luigi Rizzo, Alessandro Cerri, and
Andre Oppermann. And most recently:

- Kip Macy revised the locking code completely, thus completing
the last piece of the puzzle, Kip has also been conducting
active functional testing
- Sam Leffler has helped me improving/refactoring the code, and
provided valuable reviews
- Julian Elischer setup the perforce tree for me and has helped
me maintaining that branch before the svn conversion

Cleanup of userland __P use

implemented more validation checks about incoming responses per RFC2080, and one additional heuristic check for safer operation.

Obtained from: KAME
MFC after: 1 week

- need_trigger/idx should be u_int, not ssize_t.
- realloc pedant.
- set sin6_scope_id before sending (link-local/multicast) packets
- removed an incorrect comment
- don't age non-gateway host routes.
- not remove global addresses on loopback interface from routing table
by route aging.

Obtained from: KAME

fixe remote panic on short packet

Obtained from: KAME

remove unused variable

Supported by: FreeBSD Foundation

rtm_seq is int, so seq/myseq should be int.

Obtained from: KAME
MFC after: 1 week

suppress outpt on dump request if -q is specified.

Obtained from: KAME
MFC after: 1 week

atoi -> strtoul

Obtained from: KAME
MFC after: 1 week

- port numbers are unsigned. use %u.
- %d is not 10 chars, but 12 chars.

Obtained from: KAME
MFC after: 1 week

explicitly specify IPPROTO_UDP when calling getaddrinfo().

Obtained from: KAME
MFC after: 1 week

remove a variable that is never used.

Obtained from: KAME
MFC after: 1 week

support poll(2).

Obtained from: KAME
MFC after: 1 week

- don't select with FD_SETSIZE.
- avoid fd_set overrun.

Obtained from: KAME
MFC after: 1 week

- don't print strerror() if errno == 0 on fatal().
- va_start/end audit.
- can't use vfprintf() twice. need va_start/end pair every time.

Obtained from: KAME
MFC after: 1 week

- do not SEGV on IFF_UP.
- recover rrt_gw setting for non-p2p case. otherwise, we will not
be able to recover interface route on interface down -> up
transition.
- clarify loop exit condition

Obtained from: KAME
MFC after: 1 week

do not send dump request on -N

Obtained from: KAME
MFC after: 1 week

macro pedant

Obtained from: KAME
MFC after: 1 week

minor cleanup; no need for extra variable here

Obtained from: KAME
MFC after: 1 week

use strchr(3).

Obtained from: KAME
MFC after: 1 week

daemon() has to be called prior to file descriptor setups
(otherwise file descriptors could be closed mistakenly)

Obtained from: KAME
MFC after: 1 week

knf, typo, space.

Obtained from: KAME
MFC after: 1 week

set IPV6_V6ONLY.

Obtained from: KAME
MFC after: 1 week

- die if malloc fails.
- use strlcpy.

Obtained from: KAME
MFC after: 1 week

use strncpy

Obtained from: KAME
MFC after: 1 week

"sin" is a reserved C library function name. use sin6

Obtained from: KAME
MFC after: 1 week

Add missing srand() (sranddev() for FreeBSD)

Correct typos, mostly s/ a / an / where appropriate. Some whitespace cleanup,
especially in troff files.

Sync with recent KAME.
This work was based on kame-20010528-freebsd43-snap.tgz and some
critical problem after the snap was out were fixed.
There are many many changes since last KAME merge.

TODO:
- The definitions of SADB_* in sys/net/pfkeyv2.h are still different
from RFC2407/IANA assignment because of binary compatibility
issue. It should be fixed under 5-CURRENT.
- ip6po_m member of struct ip6_pktopts is no longer used. But, it
is still there because of binary compatibility issue. It should
be removed under 5-CURRENT.

Reviewed by: itojun
Obtained from: KAME
MFC after: 3 weeks

- do not check/advertise cloned routes, nor dynamic routes
- cast size_t on printing (be friendly with alpha)

Obtained from: KAME

Sync with KAME. Format string auditing and manpage cleanups.

Obtained from: KAME
Submitted by: Bill Sommerfeld <sommerfeld@netbsd.org>

fix LP64 issue in routing socket manipulation.
make behavior of -A safer.
(sync with kame)

removed 'ifndef ADVAPI' parts

Obtained from: KAME

sync with latest kame tree. more stable, p2p advert is corrected

When unexpected rtmsg was received, route6d was dying.
So change it just to log it.
(Merge from recent KAME bug fix.)

Submitted by: itojun
Obtained from: KAME project

remove redundant ifdef's.

some part is specified by: phantom

Getaddrinfo(), getnameinfo(), and etc support in libc/net.
Several udp and raw apps IPv6 support.

Reviewed by: freebsd-arch, cvs-committers
Obtained from: KAME project