Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

pr.1: note that -p is unsupported
pr.c: spelling fix

from andras farkas

delete wasteful ;;
ok tedu

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

As we only use the .tv_sec field, simplify gettimeofday(2) -> time(3).

ok tb@ jca@

Kill bogus use of LC_TIME

Diff from Jan Stary, ok kettenis@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

Change all tame callers to namechange to pledge(2).

tame "stdio rpath"

Do not cast result of malloc/calloc/realloc* if stdlib.h is in scope
ok krw millert

in getopt() blocks, stop incrementing flag variable which are supposed
to just be 0/1
ok miod florian

- get the spacing right for -e, -i, -n, and -s
- macro cleanup

ok millert sobrado

unsigned char casts for ctype
ok krw

Correct format string mismatches turned up by -Wformat=2

suggestions and ok millert@

struct timezone is so 1980

fix potential use of uninitialized variable.

reported by gcc.

ok jasper@

several fixes from netbsd:
Coverity CID 1660: Plug memory leaks.
Coverity CID 2989: Use the error path to return.
Coverity CID 3212: Don't return, goto out in all cases so that cleanup happens.

ok otto@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

malloc(n * m) -> calloc(n, m);

ok ray@ moritz@

If memory allocation fails during error message buffering, print all hold
back messages and exit.

ok millert

last commit broke the tree because of missing parentheses.

ok henning@

sizeof char is 1; ok djm

- make synopsis and usage() match the order of the options list
- kill a raft of unneeded .Bk/.Ek

mostly from Igor Sobrado

Some cleanup including:

- use sig_atomic_t signal handler flag
- atoi() -> strtonum() conversion
- remove vararg without matching fmt string
- some more lint/gcc silencing

ok millert@ ray@

dont compare int with NULL, compare to 0 instead, otto@ ok

Typos in comments from Jared Yanovich <jjy2+ at pitt dot edu>

protos

de-register and ansification; millert ok

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

arguement -> argument

make sure that va_start() has matching va_end()

millert@ help&ok

kill more registers

millert@ ok

guess what! more signal race fixes...

use _exit() in signal handler

Don't convert a single space before a tab stop into a tab when the -i
option is passed, as stated in the manual page.
From NetBSD PR 5797 fix.
millert@ ok

please binutils in the absence of perfect weak symbols

seperate -> separate, okay aaron@

the -s option was broken; spotted by tstromberg@rtci.com on freebsd-audit, but i have not seen them fix any of the bugs

make private version of getopt() return -1, not EOF

revised to handle form feeds, bugs fixed etc

getopt(3) returns -1 when out of args, not EOF, whee!

pr -F would sometimes fail to properly use formfeeds.

rcsid

branches: 1.1.1;
Initial revision

pr.1: note that -p is unsupported
pr.c: spelling fix

from andras farkas

delete wasteful ;;
ok tedu

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

As we only use the .tv_sec field, simplify gettimeofday(2) -> time(3).

ok tb@ jca@

Kill bogus use of LC_TIME

Diff from Jan Stary, ok kettenis@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

Change all tame callers to namechange to pledge(2).

tame "stdio rpath"

Do not cast result of malloc/calloc/realloc* if stdlib.h is in scope
ok krw millert

in getopt() blocks, stop incrementing flag variable which are supposed
to just be 0/1
ok miod florian

- get the spacing right for -e, -i, -n, and -s
- macro cleanup

ok millert sobrado

unsigned char casts for ctype
ok krw

Correct format string mismatches turned up by -Wformat=2

suggestions and ok millert@

struct timezone is so 1980

fix potential use of uninitialized variable.

reported by gcc.

ok jasper@

several fixes from netbsd:
Coverity CID 1660: Plug memory leaks.
Coverity CID 2989: Use the error path to return.
Coverity CID 3212: Don't return, goto out in all cases so that cleanup happens.

ok otto@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

malloc(n * m) -> calloc(n, m);

ok ray@ moritz@

If memory allocation fails during error message buffering, print all hold
back messages and exit.

ok millert

last commit broke the tree because of missing parentheses.

ok henning@

sizeof char is 1; ok djm

- make synopsis and usage() match the order of the options list
- kill a raft of unneeded .Bk/.Ek

mostly from Igor Sobrado

Some cleanup including:

- use sig_atomic_t signal handler flag
- atoi() -> strtonum() conversion
- remove vararg without matching fmt string
- some more lint/gcc silencing

ok millert@ ray@

dont compare int with NULL, compare to 0 instead, otto@ ok

Typos in comments from Jared Yanovich <jjy2+ at pitt dot edu>

protos

de-register and ansification; millert ok

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

arguement -> argument

make sure that va_start() has matching va_end()

millert@ help&ok

kill more registers

millert@ ok

guess what! more signal race fixes...

use _exit() in signal handler

Don't convert a single space before a tab stop into a tab when the -i
option is passed, as stated in the manual page.
From NetBSD PR 5797 fix.
millert@ ok

please binutils in the absence of perfect weak symbols

seperate -> separate, okay aaron@

the -s option was broken; spotted by tstromberg@rtci.com on freebsd-audit, but i have not seen them fix any of the bugs

make private version of getopt() return -1, not EOF

revised to handle form feeds, bugs fixed etc

getopt(3) returns -1 when out of args, not EOF, whee!

pr -F would sometimes fail to properly use formfeeds.

rcsid

branches: 1.1.1;
Initial revision

delete wasteful ;;
ok tedu

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

As we only use the .tv_sec field, simplify gettimeofday(2) -> time(3).

ok tb@ jca@

Kill bogus use of LC_TIME

Diff from Jan Stary, ok kettenis@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

Change all tame callers to namechange to pledge(2).

tame "stdio rpath"

Do not cast result of malloc/calloc/realloc* if stdlib.h is in scope
ok krw millert

in getopt() blocks, stop incrementing flag variable which are supposed
to just be 0/1
ok miod florian

- get the spacing right for -e, -i, -n, and -s
- macro cleanup

ok millert sobrado

unsigned char casts for ctype
ok krw

Correct format string mismatches turned up by -Wformat=2

suggestions and ok millert@

struct timezone is so 1980

fix potential use of uninitialized variable.

reported by gcc.

ok jasper@

several fixes from netbsd:
Coverity CID 1660: Plug memory leaks.
Coverity CID 2989: Use the error path to return.
Coverity CID 3212: Don't return, goto out in all cases so that cleanup happens.

ok otto@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

malloc(n * m) -> calloc(n, m);

ok ray@ moritz@

If memory allocation fails during error message buffering, print all hold
back messages and exit.

ok millert

last commit broke the tree because of missing parentheses.

ok henning@

sizeof char is 1; ok djm

- make synopsis and usage() match the order of the options list
- kill a raft of unneeded .Bk/.Ek

mostly from Igor Sobrado

Some cleanup including:

- use sig_atomic_t signal handler flag
- atoi() -> strtonum() conversion
- remove vararg without matching fmt string
- some more lint/gcc silencing

ok millert@ ray@

dont compare int with NULL, compare to 0 instead, otto@ ok

Typos in comments from Jared Yanovich <jjy2+ at pitt dot edu>

protos

de-register and ansification; millert ok

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

arguement -> argument

make sure that va_start() has matching va_end()

millert@ help&ok

kill more registers

millert@ ok

guess what! more signal race fixes...

use _exit() in signal handler

Don't convert a single space before a tab stop into a tab when the -i
option is passed, as stated in the manual page.
From NetBSD PR 5797 fix.
millert@ ok

please binutils in the absence of perfect weak symbols

seperate -> separate, okay aaron@

the -s option was broken; spotted by tstromberg@rtci.com on freebsd-audit, but i have not seen them fix any of the bugs

make private version of getopt() return -1, not EOF

revised to handle form feeds, bugs fixed etc

getopt(3) returns -1 when out of args, not EOF, whee!

pr -F would sometimes fail to properly use formfeeds.

rcsid

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

As we only use the .tv_sec field, simplify gettimeofday(2) -> time(3).

ok tb@ jca@

Kill bogus use of LC_TIME

Diff from Jan Stary, ok kettenis@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

Change all tame callers to namechange to pledge(2).

tame "stdio rpath"

Do not cast result of malloc/calloc/realloc* if stdlib.h is in scope
ok krw millert

in getopt() blocks, stop incrementing flag variable which are supposed
to just be 0/1
ok miod florian

- get the spacing right for -e, -i, -n, and -s
- macro cleanup

ok millert sobrado

unsigned char casts for ctype
ok krw

Correct format string mismatches turned up by -Wformat=2

suggestions and ok millert@

struct timezone is so 1980

fix potential use of uninitialized variable.

reported by gcc.

ok jasper@

several fixes from netbsd:
Coverity CID 1660: Plug memory leaks.
Coverity CID 2989: Use the error path to return.
Coverity CID 3212: Don't return, goto out in all cases so that cleanup happens.

ok otto@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

malloc(n * m) -> calloc(n, m);

ok ray@ moritz@

If memory allocation fails during error message buffering, print all hold
back messages and exit.

ok millert

last commit broke the tree because of missing parentheses.

ok henning@

sizeof char is 1; ok djm

- make synopsis and usage() match the order of the options list
- kill a raft of unneeded .Bk/.Ek

mostly from Igor Sobrado

Some cleanup including:

- use sig_atomic_t signal handler flag
- atoi() -> strtonum() conversion
- remove vararg without matching fmt string
- some more lint/gcc silencing

ok millert@ ray@

dont compare int with NULL, compare to 0 instead, otto@ ok

Typos in comments from Jared Yanovich <jjy2+ at pitt dot edu>

protos

de-register and ansification; millert ok

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

arguement -> argument

make sure that va_start() has matching va_end()

millert@ help&ok

kill more registers

millert@ ok

guess what! more signal race fixes...

use _exit() in signal handler

Don't convert a single space before a tab stop into a tab when the -i
option is passed, as stated in the manual page.
From NetBSD PR 5797 fix.
millert@ ok

please binutils in the absence of perfect weak symbols

seperate -> separate, okay aaron@

the -s option was broken; spotted by tstromberg@rtci.com on freebsd-audit, but i have not seen them fix any of the bugs

make private version of getopt() return -1, not EOF

revised to handle form feeds, bugs fixed etc

getopt(3) returns -1 when out of args, not EOF, whee!

pr -F would sometimes fail to properly use formfeeds.

rcsid

branches: 1.1.1;
Initial revision

As we only use the .tv_sec field, simplify gettimeofday(2) -> time(3).

ok tb@ jca@

Kill bogus use of LC_TIME

Diff from Jan Stary, ok kettenis@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

Change all tame callers to namechange to pledge(2).

tame "stdio rpath"

Do not cast result of malloc/calloc/realloc* if stdlib.h is in scope
ok krw millert

in getopt() blocks, stop incrementing flag variable which are supposed
to just be 0/1
ok miod florian

- get the spacing right for -e, -i, -n, and -s
- macro cleanup

ok millert sobrado

unsigned char casts for ctype
ok krw

Correct format string mismatches turned up by -Wformat=2

suggestions and ok millert@

struct timezone is so 1980

fix potential use of uninitialized variable.

reported by gcc.

ok jasper@

several fixes from netbsd:
Coverity CID 1660: Plug memory leaks.
Coverity CID 2989: Use the error path to return.
Coverity CID 3212: Don't return, goto out in all cases so that cleanup happens.

ok otto@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

malloc(n * m) -> calloc(n, m);

ok ray@ moritz@

If memory allocation fails during error message buffering, print all hold
back messages and exit.

ok millert

last commit broke the tree because of missing parentheses.

ok henning@

sizeof char is 1; ok djm

- make synopsis and usage() match the order of the options list
- kill a raft of unneeded .Bk/.Ek

mostly from Igor Sobrado

Some cleanup including:

- use sig_atomic_t signal handler flag
- atoi() -> strtonum() conversion
- remove vararg without matching fmt string
- some more lint/gcc silencing

ok millert@ ray@

dont compare int with NULL, compare to 0 instead, otto@ ok

Typos in comments from Jared Yanovich <jjy2+ at pitt dot edu>

protos

de-register and ansification; millert ok

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

arguement -> argument

make sure that va_start() has matching va_end()

millert@ help&ok

kill more registers

millert@ ok

guess what! more signal race fixes...

use _exit() in signal handler

Don't convert a single space before a tab stop into a tab when the -i
option is passed, as stated in the manual page.
From NetBSD PR 5797 fix.
millert@ ok

please binutils in the absence of perfect weak symbols

seperate -> separate, okay aaron@

the -s option was broken; spotted by tstromberg@rtci.com on freebsd-audit, but i have not seen them fix any of the bugs

make private version of getopt() return -1, not EOF

revised to handle form feeds, bugs fixed etc

getopt(3) returns -1 when out of args, not EOF, whee!

pr -F would sometimes fail to properly use formfeeds.

rcsid

branches: 1.1.1;
Initial revision