correct indentation; no functional change
ok tb@

Remove Softdep.

Softdep has been a no-op for some time now, this removes it to get
it out of the way.

Flensing mostly done in Talinn, with some help from krw@

ok deraadt@

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

With filesystem having many cylinder groups and many inodes per cg the
ncg * ipg calcualtion can overflow if signed types are used. Move
to uint32_t for the relevant values. Aligned with FreeBSD changes.
Also make sure newfs refuses to create an fs with more that 2^32-1
inodes. ok millert@

snprintf/vsnprintf return < 0 on error, rather than -1.

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Give growfs a chance to error out with ENOTTY before pledging disklabel.
Fixes pledge crash due to ioctl DIOCGDINFO with an inappropriate file.

looks good to deraadt

Switch (non-curses, non-ksh) programs that use COLUMNS to a single idiom.

Previously behaviors were all over the map. This changes them to
use COLUMNS first, and either terminal width or a hardcoded value
(typically 80) as appropriate.

ok deraadt@; man bits ok jmc@

Therefor -> Therefore (where appropriate)

from ray@, ok jmc@

hoist TIOCGWINSZ code upwards, and pledge "stdio disklabel" at the
right place.
tested by mmcc

spaces

Remove the debugging infrastructure, which was ~1/3 of the code. Makes
pledging easier, and it was excessive complicated stuff.

"Good." deraadt@

De-justify more comments. From FreeBSD.

Monospace comments are not meant to be justified. From FreeBSD.

Remove some weird comments containing only the name of the next function.

Don't bother casting memset() argument to void*. No binary change.

calloc((size_t)1, ...) -> calloc(1, ...)
No binary change (for real this time).

<stdlib.h> is included, so do not need to cast result from
malloc, calloc, realloc*
ok krw millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Adjust <sys/param.h> comments regarding use of use of MAXFRAG, or
delete <sys/param.h> if now possible
ok guenther

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

- typo in comment
- memset() is not needed after a calloc()
- add missing DBG_ENTER;
- use SEEK_SET instead of 0 in an lseek() call

ok krw@

"new file systemsize is" -> "new filesystem size is".

From David Vasek.

Write last disk sector, not last 512-byte block, when testing validity
of new partition limit.

Fixes growfs on 4K-sector disks.

Reported by and fix tested by David Vasek via misc@.

Don't use p_size as if it was the full partition size, and don't
assume the disk sector size is 512-bytes. Use DL_GETPSIZE() to get
correct partition sizes and DL_SECTOBLK() to turn disk sector values
into 512-byte-block values.

Replace (int) = (size_t)(long) with (long long) = (long long) by replacing
atol() with strtonum() and storing value of 's' parameter in long long
variable instead of an int.

final removal of daddr64_t. daddr_t has been 64 bit for a long enough
test period; i think 3 years ago the last bugs fell out.
ok otto beck others

handle large ino_t; ok tedu

dont let sys/ioctl.h imply that you get the ioctls in dkio.h. this
gets rid of #include <sys/dkio.h> in sys/ioctl.h and adds #include
<sys/dkio.h> to the places that actually want and use the disk
ioctls.

this became an issue when krw@'s X build failed when he was testing
a change to dkio.h.
tested by krw@
help from and ok miod@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Don't be picky about character case when checking response.
ok deraadt@

fox format string; ok tedu@

Make growfs refuse to run on a dirty filesystem, and set the filesystem to
dirty on the way out so that users are forced to run fsck afterwards. The
manpage politely suggested that the filesystem be checked after growing it;
change it to say that fsck is required.

Index: src/sbin/growfs/growfs.c

Remove Softdep.

Softdep has been a no-op for some time now, this removes it to get
it out of the way.

Flensing mostly done in Talinn, with some help from krw@

ok deraadt@

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

With filesystem having many cylinder groups and many inodes per cg the
ncg * ipg calcualtion can overflow if signed types are used. Move
to uint32_t for the relevant values. Aligned with FreeBSD changes.
Also make sure newfs refuses to create an fs with more that 2^32-1
inodes. ok millert@

snprintf/vsnprintf return < 0 on error, rather than -1.

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Give growfs a chance to error out with ENOTTY before pledging disklabel.
Fixes pledge crash due to ioctl DIOCGDINFO with an inappropriate file.

looks good to deraadt

Switch (non-curses, non-ksh) programs that use COLUMNS to a single idiom.

Previously behaviors were all over the map. This changes them to
use COLUMNS first, and either terminal width or a hardcoded value
(typically 80) as appropriate.

ok deraadt@; man bits ok jmc@

Therefor -> Therefore (where appropriate)

from ray@, ok jmc@

hoist TIOCGWINSZ code upwards, and pledge "stdio disklabel" at the
right place.
tested by mmcc

spaces

Remove the debugging infrastructure, which was ~1/3 of the code. Makes
pledging easier, and it was excessive complicated stuff.

"Good." deraadt@

De-justify more comments. From FreeBSD.

Monospace comments are not meant to be justified. From FreeBSD.

Remove some weird comments containing only the name of the next function.

Don't bother casting memset() argument to void*. No binary change.

calloc((size_t)1, ...) -> calloc(1, ...)
No binary change (for real this time).

<stdlib.h> is included, so do not need to cast result from
malloc, calloc, realloc*
ok krw millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Adjust <sys/param.h> comments regarding use of use of MAXFRAG, or
delete <sys/param.h> if now possible
ok guenther

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

- typo in comment
- memset() is not needed after a calloc()
- add missing DBG_ENTER;
- use SEEK_SET instead of 0 in an lseek() call

ok krw@

"new file systemsize is" -> "new filesystem size is".

From David Vasek.

Write last disk sector, not last 512-byte block, when testing validity
of new partition limit.

Fixes growfs on 4K-sector disks.

Reported by and fix tested by David Vasek via misc@.

Don't use p_size as if it was the full partition size, and don't
assume the disk sector size is 512-bytes. Use DL_GETPSIZE() to get
correct partition sizes and DL_SECTOBLK() to turn disk sector values
into 512-byte-block values.

Replace (int) = (size_t)(long) with (long long) = (long long) by replacing
atol() with strtonum() and storing value of 's' parameter in long long
variable instead of an int.

final removal of daddr64_t. daddr_t has been 64 bit for a long enough
test period; i think 3 years ago the last bugs fell out.
ok otto beck others

handle large ino_t; ok tedu

dont let sys/ioctl.h imply that you get the ioctls in dkio.h. this
gets rid of #include <sys/dkio.h> in sys/ioctl.h and adds #include
<sys/dkio.h> to the places that actually want and use the disk
ioctls.

this became an issue when krw@'s X build failed when he was testing
a change to dkio.h.
tested by krw@
help from and ok miod@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Don't be picky about character case when checking response.
ok deraadt@

fox format string; ok tedu@

Make growfs refuse to run on a dirty filesystem, and set the filesystem to
dirty on the way out so that users are forced to run fsck afterwards. The
manpage politely suggested that the filesystem be checked after growing it;
change it to say that fsck is required.

Index: src/sbin/growfs/growfs.c

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

With filesystem having many cylinder groups and many inodes per cg the
ncg * ipg calcualtion can overflow if signed types are used. Move
to uint32_t for the relevant values. Aligned with FreeBSD changes.
Also make sure newfs refuses to create an fs with more that 2^32-1
inodes. ok millert@

snprintf/vsnprintf return < 0 on error, rather than -1.

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Give growfs a chance to error out with ENOTTY before pledging disklabel.
Fixes pledge crash due to ioctl DIOCGDINFO with an inappropriate file.

looks good to deraadt

Switch (non-curses, non-ksh) programs that use COLUMNS to a single idiom.

Previously behaviors were all over the map. This changes them to
use COLUMNS first, and either terminal width or a hardcoded value
(typically 80) as appropriate.

ok deraadt@; man bits ok jmc@

Therefor -> Therefore (where appropriate)

from ray@, ok jmc@

hoist TIOCGWINSZ code upwards, and pledge "stdio disklabel" at the
right place.
tested by mmcc

spaces

Remove the debugging infrastructure, which was ~1/3 of the code. Makes
pledging easier, and it was excessive complicated stuff.

"Good." deraadt@

De-justify more comments. From FreeBSD.

Monospace comments are not meant to be justified. From FreeBSD.

Remove some weird comments containing only the name of the next function.

Don't bother casting memset() argument to void*. No binary change.

calloc((size_t)1, ...) -> calloc(1, ...)
No binary change (for real this time).

<stdlib.h> is included, so do not need to cast result from
malloc, calloc, realloc*
ok krw millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Adjust <sys/param.h> comments regarding use of use of MAXFRAG, or
delete <sys/param.h> if now possible
ok guenther

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

- typo in comment
- memset() is not needed after a calloc()
- add missing DBG_ENTER;
- use SEEK_SET instead of 0 in an lseek() call

ok krw@

"new file systemsize is" -> "new filesystem size is".

From David Vasek.

Write last disk sector, not last 512-byte block, when testing validity
of new partition limit.

Fixes growfs on 4K-sector disks.

Reported by and fix tested by David Vasek via misc@.

Don't use p_size as if it was the full partition size, and don't
assume the disk sector size is 512-bytes. Use DL_GETPSIZE() to get
correct partition sizes and DL_SECTOBLK() to turn disk sector values
into 512-byte-block values.

Replace (int) = (size_t)(long) with (long long) = (long long) by replacing
atol() with strtonum() and storing value of 's' parameter in long long
variable instead of an int.

final removal of daddr64_t. daddr_t has been 64 bit for a long enough
test period; i think 3 years ago the last bugs fell out.
ok otto beck others

handle large ino_t; ok tedu

dont let sys/ioctl.h imply that you get the ioctls in dkio.h. this
gets rid of #include <sys/dkio.h> in sys/ioctl.h and adds #include
<sys/dkio.h> to the places that actually want and use the disk
ioctls.

this became an issue when krw@'s X build failed when he was testing
a change to dkio.h.
tested by krw@
help from and ok miod@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Don't be picky about character case when checking response.
ok deraadt@

fox format string; ok tedu@

Make growfs refuse to run on a dirty filesystem, and set the filesystem to
dirty on the way out so that users are forced to run fsck afterwards. The
manpage politely suggested that the filesystem be checked after growing it;
change it to say that fsck is required.

Index: src/sbin/growfs/growfs.c

With filesystem having many cylinder groups and many inodes per cg the
ncg * ipg calcualtion can overflow if signed types are used. Move
to uint32_t for the relevant values. Aligned with FreeBSD changes.
Also make sure newfs refuses to create an fs with more that 2^32-1
inodes. ok millert@

snprintf/vsnprintf return < 0 on error, rather than -1.

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Give growfs a chance to error out with ENOTTY before pledging disklabel.
Fixes pledge crash due to ioctl DIOCGDINFO with an inappropriate file.

looks good to deraadt

Switch (non-curses, non-ksh) programs that use COLUMNS to a single idiom.

Previously behaviors were all over the map. This changes them to
use COLUMNS first, and either terminal width or a hardcoded value
(typically 80) as appropriate.

ok deraadt@; man bits ok jmc@

Therefor -> Therefore (where appropriate)

from ray@, ok jmc@

hoist TIOCGWINSZ code upwards, and pledge "stdio disklabel" at the
right place.
tested by mmcc

spaces

Remove the debugging infrastructure, which was ~1/3 of the code. Makes
pledging easier, and it was excessive complicated stuff.

"Good." deraadt@

De-justify more comments. From FreeBSD.

Monospace comments are not meant to be justified. From FreeBSD.

Remove some weird comments containing only the name of the next function.

Don't bother casting memset() argument to void*. No binary change.

calloc((size_t)1, ...) -> calloc(1, ...)
No binary change (for real this time).

<stdlib.h> is included, so do not need to cast result from
malloc, calloc, realloc*
ok krw millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Adjust <sys/param.h> comments regarding use of use of MAXFRAG, or
delete <sys/param.h> if now possible
ok guenther

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

- typo in comment
- memset() is not needed after a calloc()
- add missing DBG_ENTER;
- use SEEK_SET instead of 0 in an lseek() call

ok krw@

"new file systemsize is" -> "new filesystem size is".

From David Vasek.

Write last disk sector, not last 512-byte block, when testing validity
of new partition limit.

Fixes growfs on 4K-sector disks.

Reported by and fix tested by David Vasek via misc@.

Don't use p_size as if it was the full partition size, and don't
assume the disk sector size is 512-bytes. Use DL_GETPSIZE() to get
correct partition sizes and DL_SECTOBLK() to turn disk sector values
into 512-byte-block values.

Replace (int) = (size_t)(long) with (long long) = (long long) by replacing
atol() with strtonum() and storing value of 's' parameter in long long
variable instead of an int.

final removal of daddr64_t. daddr_t has been 64 bit for a long enough
test period; i think 3 years ago the last bugs fell out.
ok otto beck others

handle large ino_t; ok tedu

dont let sys/ioctl.h imply that you get the ioctls in dkio.h. this
gets rid of #include <sys/dkio.h> in sys/ioctl.h and adds #include
<sys/dkio.h> to the places that actually want and use the disk
ioctls.

this became an issue when krw@'s X build failed when he was testing
a change to dkio.h.
tested by krw@
help from and ok miod@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Don't be picky about character case when checking response.
ok deraadt@

fox format string; ok tedu@

Make growfs refuse to run on a dirty filesystem, and set the filesystem to
dirty on the way out so that users are forced to run fsck afterwards. The
manpage politely suggested that the filesystem be checked after growing it;
change it to say that fsck is required.

Index: src/sbin/growfs/growfs.c

snprintf/vsnprintf return < 0 on error, rather than -1.

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Give growfs a chance to error out with ENOTTY before pledging disklabel.
Fixes pledge crash due to ioctl DIOCGDINFO with an inappropriate file.

looks good to deraadt

Switch (non-curses, non-ksh) programs that use COLUMNS to a single idiom.

Previously behaviors were all over the map. This changes them to
use COLUMNS first, and either terminal width or a hardcoded value
(typically 80) as appropriate.

ok deraadt@; man bits ok jmc@

Therefor -> Therefore (where appropriate)

from ray@, ok jmc@

hoist TIOCGWINSZ code upwards, and pledge "stdio disklabel" at the
right place.
tested by mmcc

spaces

Remove the debugging infrastructure, which was ~1/3 of the code. Makes
pledging easier, and it was excessive complicated stuff.

"Good." deraadt@

De-justify more comments. From FreeBSD.

Monospace comments are not meant to be justified. From FreeBSD.

Remove some weird comments containing only the name of the next function.

Don't bother casting memset() argument to void*. No binary change.

calloc((size_t)1, ...) -> calloc(1, ...)
No binary change (for real this time).

<stdlib.h> is included, so do not need to cast result from
malloc, calloc, realloc*
ok krw millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Adjust <sys/param.h> comments regarding use of use of MAXFRAG, or
delete <sys/param.h> if now possible
ok guenther

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

- typo in comment
- memset() is not needed after a calloc()
- add missing DBG_ENTER;
- use SEEK_SET instead of 0 in an lseek() call

ok krw@

"new file systemsize is" -> "new filesystem size is".

From David Vasek.

Write last disk sector, not last 512-byte block, when testing validity
of new partition limit.

Fixes growfs on 4K-sector disks.

Reported by and fix tested by David Vasek via misc@.

Don't use p_size as if it was the full partition size, and don't
assume the disk sector size is 512-bytes. Use DL_GETPSIZE() to get
correct partition sizes and DL_SECTOBLK() to turn disk sector values
into 512-byte-block values.

Replace (int) = (size_t)(long) with (long long) = (long long) by replacing
atol() with strtonum() and storing value of 's' parameter in long long
variable instead of an int.

final removal of daddr64_t. daddr_t has been 64 bit for a long enough
test period; i think 3 years ago the last bugs fell out.
ok otto beck others

handle large ino_t; ok tedu

dont let sys/ioctl.h imply that you get the ioctls in dkio.h. this
gets rid of #include <sys/dkio.h> in sys/ioctl.h and adds #include
<sys/dkio.h> to the places that actually want and use the disk
ioctls.

this became an issue when krw@'s X build failed when he was testing
a change to dkio.h.
tested by krw@
help from and ok miod@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Don't be picky about character case when checking response.
ok deraadt@

fox format string; ok tedu@

Make growfs refuse to run on a dirty filesystem, and set the filesystem to
dirty on the way out so that users are forced to run fsck afterwards. The
manpage politely suggested that the filesystem be checked after growing it;
change it to say that fsck is required.

Index: src/sbin/growfs/growfs.c

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Give growfs a chance to error out with ENOTTY before pledging disklabel.
Fixes pledge crash due to ioctl DIOCGDINFO with an inappropriate file.

looks good to deraadt

Switch (non-curses, non-ksh) programs that use COLUMNS to a single idiom.

Previously behaviors were all over the map. This changes them to
use COLUMNS first, and either terminal width or a hardcoded value
(typically 80) as appropriate.

ok deraadt@; man bits ok jmc@

Therefor -> Therefore (where appropriate)

from ray@, ok jmc@

hoist TIOCGWINSZ code upwards, and pledge "stdio disklabel" at the
right place.
tested by mmcc

spaces

Remove the debugging infrastructure, which was ~1/3 of the code. Makes
pledging easier, and it was excessive complicated stuff.

"Good." deraadt@

De-justify more comments. From FreeBSD.

Monospace comments are not meant to be justified. From FreeBSD.

Remove some weird comments containing only the name of the next function.

Don't bother casting memset() argument to void*. No binary change.

calloc((size_t)1, ...) -> calloc(1, ...)
No binary change (for real this time).

<stdlib.h> is included, so do not need to cast result from
malloc, calloc, realloc*
ok krw millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Adjust <sys/param.h> comments regarding use of use of MAXFRAG, or
delete <sys/param.h> if now possible
ok guenther

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

- typo in comment
- memset() is not needed after a calloc()
- add missing DBG_ENTER;
- use SEEK_SET instead of 0 in an lseek() call

ok krw@

"new file systemsize is" -> "new filesystem size is".

From David Vasek.

Write last disk sector, not last 512-byte block, when testing validity
of new partition limit.

Fixes growfs on 4K-sector disks.

Reported by and fix tested by David Vasek via misc@.

Don't use p_size as if it was the full partition size, and don't
assume the disk sector size is 512-bytes. Use DL_GETPSIZE() to get
correct partition sizes and DL_SECTOBLK() to turn disk sector values
into 512-byte-block values.

Replace (int) = (size_t)(long) with (long long) = (long long) by replacing
atol() with strtonum() and storing value of 's' parameter in long long
variable instead of an int.

final removal of daddr64_t. daddr_t has been 64 bit for a long enough
test period; i think 3 years ago the last bugs fell out.
ok otto beck others

handle large ino_t; ok tedu

dont let sys/ioctl.h imply that you get the ioctls in dkio.h. this
gets rid of #include <sys/dkio.h> in sys/ioctl.h and adds #include
<sys/dkio.h> to the places that actually want and use the disk
ioctls.

this became an issue when krw@'s X build failed when he was testing
a change to dkio.h.
tested by krw@
help from and ok miod@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Don't be picky about character case when checking response.
ok deraadt@

fox format string; ok tedu@

Make growfs refuse to run on a dirty filesystem, and set the filesystem to
dirty on the way out so that users are forced to run fsck afterwards. The
manpage politely suggested that the filesystem be checked after growing it;
change it to say that fsck is required.

Index: src/sbin/growfs/growfs.c

Give growfs a chance to error out with ENOTTY before pledging disklabel.
Fixes pledge crash due to ioctl DIOCGDINFO with an inappropriate file.

looks good to deraadt

Switch (non-curses, non-ksh) programs that use COLUMNS to a single idiom.

Previously behaviors were all over the map. This changes them to
use COLUMNS first, and either terminal width or a hardcoded value
(typically 80) as appropriate.

ok deraadt@; man bits ok jmc@

Therefor -> Therefore (where appropriate)

from ray@, ok jmc@

hoist TIOCGWINSZ code upwards, and pledge "stdio disklabel" at the
right place.
tested by mmcc

spaces

Remove the debugging infrastructure, which was ~1/3 of the code. Makes
pledging easier, and it was excessive complicated stuff.

"Good." deraadt@

De-justify more comments. From FreeBSD.

Monospace comments are not meant to be justified. From FreeBSD.

Remove some weird comments containing only the name of the next function.

Don't bother casting memset() argument to void*. No binary change.

calloc((size_t)1, ...) -> calloc(1, ...)
No binary change (for real this time).

<stdlib.h> is included, so do not need to cast result from
malloc, calloc, realloc*
ok krw millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Adjust <sys/param.h> comments regarding use of use of MAXFRAG, or
delete <sys/param.h> if now possible
ok guenther

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

- typo in comment
- memset() is not needed after a calloc()
- add missing DBG_ENTER;
- use SEEK_SET instead of 0 in an lseek() call

ok krw@

"new file systemsize is" -> "new filesystem size is".

From David Vasek.

Write last disk sector, not last 512-byte block, when testing validity
of new partition limit.

Fixes growfs on 4K-sector disks.

Reported by and fix tested by David Vasek via misc@.

Don't use p_size as if it was the full partition size, and don't
assume the disk sector size is 512-bytes. Use DL_GETPSIZE() to get
correct partition sizes and DL_SECTOBLK() to turn disk sector values
into 512-byte-block values.

Replace (int) = (size_t)(long) with (long long) = (long long) by replacing
atol() with strtonum() and storing value of 's' parameter in long long
variable instead of an int.

final removal of daddr64_t. daddr_t has been 64 bit for a long enough
test period; i think 3 years ago the last bugs fell out.
ok otto beck others

handle large ino_t; ok tedu

dont let sys/ioctl.h imply that you get the ioctls in dkio.h. this
gets rid of #include <sys/dkio.h> in sys/ioctl.h and adds #include
<sys/dkio.h> to the places that actually want and use the disk
ioctls.

this became an issue when krw@'s X build failed when he was testing
a change to dkio.h.
tested by krw@
help from and ok miod@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Don't be picky about character case when checking response.
ok deraadt@

fox format string; ok tedu@

Make growfs refuse to run on a dirty filesystem, and set the filesystem to
dirty on the way out so that users are forced to run fsck afterwards. The
manpage politely suggested that the filesystem be checked after growing it;
change it to say that fsck is required.

Index: src/sbin/growfs/growfs.c