lib: remove CONSTCOND comment

Since 2021-01-31, lint doesn't need it anymore for the common pattern of
'do ... while (0)'.

reallocarr returns errno. preserve it.

fts(3): Use reallocarr instead of realloc(x * y), eliminate a temporary
variable.

Use calloc(1, ...) instead of malloc(...) followed immediately by memset()

Addresses PR lib/46818

Fix double free in fts_read()/fts_close()

When fts_read() gets an error on fchdir(), it exited with sp->fts_cur
set to a freed structure. fts_close() would later attempt to free it
again, crashing the program.

make more descriptors that we open as close-on-exec

Fix in comment.

remove dubious cast

branches: 1.44.2;
rename the macros ftsent_ since they apply to the ftsent struct not the
fts one.

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.42.2;
default O_CLOEXEC to 0 for systems that don't define it, like, say, netbsd-5.

close on exec fixes:
- open + fcntl -> open O_CLOEXEC
- configuration database file descriptors that can stay open are now opened
fopen(db, "re")

Make sure fts_statp is NULL when FTS_NOSTAT is set

Version fts one more time! This is the most versioned API ever... Bump
fts_level from short to int to avoid a potential DoS.
From Maksymilian Arciemowicz

Avoid possible integer overflow and subsequent collateral damage.
Received from OpenBSD via US-CERT as VU #590371.

Original OpenBSD commit log:

> revision 1.42
> date: 2009/02/11 13:24:05; author: otto; state: Exp; lines: +9 -1
> Avoid level going negative on deep (i mean really deep) dirs. Reported
> by Maksymilian Arciemowicz. ok kettenis@ millert@

branches: 1.37.2;
fix sign-compare issue

merge christos-time_t

Ensure fts_close() doesn't spuriously close fd 0,
by testing FTS_SYMFOLLOW in fts_flags instead of fts_options.
Fix provided by Ben Harris in PR 40319

branches: 1.34.4; 1.34.6;
fix unused variable if !defined(FTS_ALLOC_ALIGNED)

Add fts_free() to complement fts_alloc(), and use instead of free().
Should avoid a memory leak on systems without ALIGNBYTES.

Style tweaks:
* test defined(HAVE_foo) not just HAVE_foo
* replace u_foo with unsigned foo
* the whitespace change whose name we dare not mention

branches: 1.31.4; 1.31.10; 1.31.14; 1.31.16;
PR/33163: Auster Vl.: fts: cant allocate memory | filename too long
Change the ftp_pathlen and fts_namelen to u_int from u_short so that
pathnames > 32K work.

Coverity CID 17: Free parent if it was not used.

Restore the compatibility versions of fts not to do path mangling (i.e.
remove double slashes). Also make sure we free sp in all cases. From yamt,
many thanks!

ANSI prototypes and function declarations. No functional change.

1. minimize code diffs with FreeBSD
2. return ENAMETOOLONG instead of ENOMEM if name is too long to fit.
3. only decrement cp if we are pointing to the end of the string.
[this fixes the cp truncation of the last char problem reported]

Instead of special-casing root, special case paths that end with a /, so
that find foo/ does not print foo//bar. From FreeBSD.

compat core reorg.

64 bit inode changes

netbsd.org -> NetBSD.org
NetBSD.ORG -> NetBSD.org

Now src/lib is done.

Allow the old-name functions to be compiled from the same source file as
the renamed functions, and add some #error directives to force the
issue with weak symbols for renamed functions when we support weak
symbols in the C library.

New hacks to make libc work painlessly without bumping the major number:
use type func(arg1s) asm("emitted_name") gcc mechanism.
Suggested by Bill Sommerfeld.

branches: 1.20.2;
Hacks to enable libc to work without bumping the major.

Revert all slash removing changes; it is not worth it...
The latest one broke "ls foo.c/". Sync with Lite-2.

Restore the NAPPEND macro, as it existed until revision 1.13, that deals
with roots consisting of a single slash. This special case of special
cases cannot be dealt with in fts_open() by simply chopping of a
trailing slash.

All this to avoid the occasional doubling of slashes. Oh well..

In fts_alloc() copy the trailing 0 character explicitly, instead of
relying on the passed input string having a 0 character at the right spot.
Takes care of PR#4234.

The change in revision 1.13 to avoid doubling slashes in path names
messes up the internal administrations of the fts engine.

Do this differently by simply stripping one trailing slash (if any)
from root paths passed to fts_open().

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Add missing prototypes.
Fix rest of gcc warnings.

Fix it so fts_* never adds a / to a path name when there is
already a trailing /. Fixes PR 1495.

branches: 1.12.4;
merge with Lite, keeping local changes. Also use new Id format.

branches: 1.11.2;
Mostly sync with CSRG.

Avoid extra stat()s if a link count of 1 is returned for directories but the
d_type field is filled in.

POSIXification and bostic's official fix for the missing relative path problem

re-POSIXIFICATION. should have been punted back to bostic...

oops, restore bug fix that wasn't fed back to bostic...

minor fixes

Fix obscure bug where the working directory would not be restored to its
proper place (occurs if one of fts_open()'s arguments is a relative path
to a empty directory).

Change C library functions to use strchr() and strrchr() instead of index()
and rindex(). This will allow (strict {ANSI, POSIX, XOPEN}) applications
to redefine index() and rindex() without effecting the library internals.

Declare rcsid strings so they are stored in text segment.

Latest versions from uunet.

branches: 1.1.1;
Initial revision

reallocarr returns errno. preserve it.

fts(3): Use reallocarr instead of realloc(x * y), eliminate a temporary
variable.

Use calloc(1, ...) instead of malloc(...) followed immediately by memset()

Addresses PR lib/46818

Fix double free in fts_read()/fts_close()

When fts_read() gets an error on fchdir(), it exited with sp->fts_cur
set to a freed structure. fts_close() would later attempt to free it
again, crashing the program.

make more descriptors that we open as close-on-exec

Fix in comment.

remove dubious cast

branches: 1.44.2;
rename the macros ftsent_ since they apply to the ftsent struct not the
fts one.

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.42.2;
default O_CLOEXEC to 0 for systems that don't define it, like, say, netbsd-5.

close on exec fixes:
- open + fcntl -> open O_CLOEXEC
- configuration database file descriptors that can stay open are now opened
fopen(db, "re")

Make sure fts_statp is NULL when FTS_NOSTAT is set

Version fts one more time! This is the most versioned API ever... Bump
fts_level from short to int to avoid a potential DoS.
From Maksymilian Arciemowicz

Avoid possible integer overflow and subsequent collateral damage.
Received from OpenBSD via US-CERT as VU #590371.

Original OpenBSD commit log:

> revision 1.42
> date: 2009/02/11 13:24:05; author: otto; state: Exp; lines: +9 -1
> Avoid level going negative on deep (i mean really deep) dirs. Reported
> by Maksymilian Arciemowicz. ok kettenis@ millert@

branches: 1.37.2;
fix sign-compare issue

merge christos-time_t

Ensure fts_close() doesn't spuriously close fd 0,
by testing FTS_SYMFOLLOW in fts_flags instead of fts_options.
Fix provided by Ben Harris in PR 40319

branches: 1.34.4; 1.34.6;
fix unused variable if !defined(FTS_ALLOC_ALIGNED)

Add fts_free() to complement fts_alloc(), and use instead of free().
Should avoid a memory leak on systems without ALIGNBYTES.

Style tweaks:
* test defined(HAVE_foo) not just HAVE_foo
* replace u_foo with unsigned foo
* the whitespace change whose name we dare not mention

branches: 1.31.4; 1.31.10; 1.31.14; 1.31.16;
PR/33163: Auster Vl.: fts: cant allocate memory | filename too long
Change the ftp_pathlen and fts_namelen to u_int from u_short so that
pathnames > 32K work.

Coverity CID 17: Free parent if it was not used.

Restore the compatibility versions of fts not to do path mangling (i.e.
remove double slashes). Also make sure we free sp in all cases. From yamt,
many thanks!

ANSI prototypes and function declarations. No functional change.

1. minimize code diffs with FreeBSD
2. return ENAMETOOLONG instead of ENOMEM if name is too long to fit.
3. only decrement cp if we are pointing to the end of the string.
[this fixes the cp truncation of the last char problem reported]

Instead of special-casing root, special case paths that end with a /, so
that find foo/ does not print foo//bar. From FreeBSD.

compat core reorg.

64 bit inode changes

netbsd.org -> NetBSD.org
NetBSD.ORG -> NetBSD.org

Now src/lib is done.

Allow the old-name functions to be compiled from the same source file as
the renamed functions, and add some #error directives to force the
issue with weak symbols for renamed functions when we support weak
symbols in the C library.

New hacks to make libc work painlessly without bumping the major number:
use type func(arg1s) asm("emitted_name") gcc mechanism.
Suggested by Bill Sommerfeld.

branches: 1.20.2;
Hacks to enable libc to work without bumping the major.

Revert all slash removing changes; it is not worth it...
The latest one broke "ls foo.c/". Sync with Lite-2.

Restore the NAPPEND macro, as it existed until revision 1.13, that deals
with roots consisting of a single slash. This special case of special
cases cannot be dealt with in fts_open() by simply chopping of a
trailing slash.

All this to avoid the occasional doubling of slashes. Oh well..

In fts_alloc() copy the trailing 0 character explicitly, instead of
relying on the passed input string having a 0 character at the right spot.
Takes care of PR#4234.

The change in revision 1.13 to avoid doubling slashes in path names
messes up the internal administrations of the fts engine.

Do this differently by simply stripping one trailing slash (if any)
from root paths passed to fts_open().

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Add missing prototypes.
Fix rest of gcc warnings.

Fix it so fts_* never adds a / to a path name when there is
already a trailing /. Fixes PR 1495.

branches: 1.12.4;
merge with Lite, keeping local changes. Also use new Id format.

branches: 1.11.2;
Mostly sync with CSRG.

Avoid extra stat()s if a link count of 1 is returned for directories but the
d_type field is filled in.

POSIXification and bostic's official fix for the missing relative path problem

re-POSIXIFICATION. should have been punted back to bostic...

oops, restore bug fix that wasn't fed back to bostic...

minor fixes

Fix obscure bug where the working directory would not be restored to its
proper place (occurs if one of fts_open()'s arguments is a relative path
to a empty directory).

Change C library functions to use strchr() and strrchr() instead of index()
and rindex(). This will allow (strict {ANSI, POSIX, XOPEN}) applications
to redefine index() and rindex() without effecting the library internals.

Declare rcsid strings so they are stored in text segment.

Latest versions from uunet.

branches: 1.1.1;
Initial revision

fts(3): Use reallocarr instead of realloc(x * y), eliminate a temporary
variable.

Use calloc(1, ...) instead of malloc(...) followed immediately by memset()

Addresses PR lib/46818

Fix double free in fts_read()/fts_close()

When fts_read() gets an error on fchdir(), it exited with sp->fts_cur
set to a freed structure. fts_close() would later attempt to free it
again, crashing the program.

make more descriptors that we open as close-on-exec

Fix in comment.

remove dubious cast

branches: 1.44.2;
rename the macros ftsent_ since they apply to the ftsent struct not the
fts one.

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.42.2;
default O_CLOEXEC to 0 for systems that don't define it, like, say, netbsd-5.

close on exec fixes:
- open + fcntl -> open O_CLOEXEC
- configuration database file descriptors that can stay open are now opened
fopen(db, "re")

Make sure fts_statp is NULL when FTS_NOSTAT is set

Version fts one more time! This is the most versioned API ever... Bump
fts_level from short to int to avoid a potential DoS.
From Maksymilian Arciemowicz

Avoid possible integer overflow and subsequent collateral damage.
Received from OpenBSD via US-CERT as VU #590371.

Original OpenBSD commit log:

> revision 1.42
> date: 2009/02/11 13:24:05; author: otto; state: Exp; lines: +9 -1
> Avoid level going negative on deep (i mean really deep) dirs. Reported
> by Maksymilian Arciemowicz. ok kettenis@ millert@

branches: 1.37.2;
fix sign-compare issue

merge christos-time_t

Ensure fts_close() doesn't spuriously close fd 0,
by testing FTS_SYMFOLLOW in fts_flags instead of fts_options.
Fix provided by Ben Harris in PR 40319

branches: 1.34.4; 1.34.6;
fix unused variable if !defined(FTS_ALLOC_ALIGNED)

Add fts_free() to complement fts_alloc(), and use instead of free().
Should avoid a memory leak on systems without ALIGNBYTES.

Style tweaks:
* test defined(HAVE_foo) not just HAVE_foo
* replace u_foo with unsigned foo
* the whitespace change whose name we dare not mention

branches: 1.31.4; 1.31.10; 1.31.14; 1.31.16;
PR/33163: Auster Vl.: fts: cant allocate memory | filename too long
Change the ftp_pathlen and fts_namelen to u_int from u_short so that
pathnames > 32K work.

Coverity CID 17: Free parent if it was not used.

Restore the compatibility versions of fts not to do path mangling (i.e.
remove double slashes). Also make sure we free sp in all cases. From yamt,
many thanks!

ANSI prototypes and function declarations. No functional change.

1. minimize code diffs with FreeBSD
2. return ENAMETOOLONG instead of ENOMEM if name is too long to fit.
3. only decrement cp if we are pointing to the end of the string.
[this fixes the cp truncation of the last char problem reported]

Instead of special-casing root, special case paths that end with a /, so
that find foo/ does not print foo//bar. From FreeBSD.

compat core reorg.

64 bit inode changes

netbsd.org -> NetBSD.org
NetBSD.ORG -> NetBSD.org

Now src/lib is done.

Allow the old-name functions to be compiled from the same source file as
the renamed functions, and add some #error directives to force the
issue with weak symbols for renamed functions when we support weak
symbols in the C library.

New hacks to make libc work painlessly without bumping the major number:
use type func(arg1s) asm("emitted_name") gcc mechanism.
Suggested by Bill Sommerfeld.

branches: 1.20.2;
Hacks to enable libc to work without bumping the major.

Revert all slash removing changes; it is not worth it...
The latest one broke "ls foo.c/". Sync with Lite-2.

Restore the NAPPEND macro, as it existed until revision 1.13, that deals
with roots consisting of a single slash. This special case of special
cases cannot be dealt with in fts_open() by simply chopping of a
trailing slash.

All this to avoid the occasional doubling of slashes. Oh well..

In fts_alloc() copy the trailing 0 character explicitly, instead of
relying on the passed input string having a 0 character at the right spot.
Takes care of PR#4234.

The change in revision 1.13 to avoid doubling slashes in path names
messes up the internal administrations of the fts engine.

Do this differently by simply stripping one trailing slash (if any)
from root paths passed to fts_open().

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Add missing prototypes.
Fix rest of gcc warnings.

Fix it so fts_* never adds a / to a path name when there is
already a trailing /. Fixes PR 1495.

branches: 1.12.4;
merge with Lite, keeping local changes. Also use new Id format.

branches: 1.11.2;
Mostly sync with CSRG.

Avoid extra stat()s if a link count of 1 is returned for directories but the
d_type field is filled in.

POSIXification and bostic's official fix for the missing relative path problem

re-POSIXIFICATION. should have been punted back to bostic...

oops, restore bug fix that wasn't fed back to bostic...

minor fixes

Fix obscure bug where the working directory would not be restored to its
proper place (occurs if one of fts_open()'s arguments is a relative path
to a empty directory).

Change C library functions to use strchr() and strrchr() instead of index()
and rindex(). This will allow (strict {ANSI, POSIX, XOPEN}) applications
to redefine index() and rindex() without effecting the library internals.

Declare rcsid strings so they are stored in text segment.

Latest versions from uunet.

branches: 1.1.1;
Initial revision

Use calloc(1, ...) instead of malloc(...) followed immediately by memset()

Addresses PR lib/46818

Fix double free in fts_read()/fts_close()

When fts_read() gets an error on fchdir(), it exited with sp->fts_cur
set to a freed structure. fts_close() would later attempt to free it
again, crashing the program.

make more descriptors that we open as close-on-exec

Fix in comment.

remove dubious cast

branches: 1.44.2;
rename the macros ftsent_ since they apply to the ftsent struct not the
fts one.

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.42.2;
default O_CLOEXEC to 0 for systems that don't define it, like, say, netbsd-5.

close on exec fixes:
- open + fcntl -> open O_CLOEXEC
- configuration database file descriptors that can stay open are now opened
fopen(db, "re")

Make sure fts_statp is NULL when FTS_NOSTAT is set

Version fts one more time! This is the most versioned API ever... Bump
fts_level from short to int to avoid a potential DoS.
From Maksymilian Arciemowicz

Avoid possible integer overflow and subsequent collateral damage.
Received from OpenBSD via US-CERT as VU #590371.

Original OpenBSD commit log:

> revision 1.42
> date: 2009/02/11 13:24:05; author: otto; state: Exp; lines: +9 -1
> Avoid level going negative on deep (i mean really deep) dirs. Reported
> by Maksymilian Arciemowicz. ok kettenis@ millert@

branches: 1.37.2;
fix sign-compare issue

merge christos-time_t

Ensure fts_close() doesn't spuriously close fd 0,
by testing FTS_SYMFOLLOW in fts_flags instead of fts_options.
Fix provided by Ben Harris in PR 40319

branches: 1.34.4; 1.34.6;
fix unused variable if !defined(FTS_ALLOC_ALIGNED)

Add fts_free() to complement fts_alloc(), and use instead of free().
Should avoid a memory leak on systems without ALIGNBYTES.

Style tweaks:
* test defined(HAVE_foo) not just HAVE_foo
* replace u_foo with unsigned foo
* the whitespace change whose name we dare not mention

branches: 1.31.4; 1.31.10; 1.31.14; 1.31.16;
PR/33163: Auster Vl.: fts: cant allocate memory | filename too long
Change the ftp_pathlen and fts_namelen to u_int from u_short so that
pathnames > 32K work.

Coverity CID 17: Free parent if it was not used.

Restore the compatibility versions of fts not to do path mangling (i.e.
remove double slashes). Also make sure we free sp in all cases. From yamt,
many thanks!

ANSI prototypes and function declarations. No functional change.

1. minimize code diffs with FreeBSD
2. return ENAMETOOLONG instead of ENOMEM if name is too long to fit.
3. only decrement cp if we are pointing to the end of the string.
[this fixes the cp truncation of the last char problem reported]

Instead of special-casing root, special case paths that end with a /, so
that find foo/ does not print foo//bar. From FreeBSD.

compat core reorg.

64 bit inode changes

netbsd.org -> NetBSD.org
NetBSD.ORG -> NetBSD.org

Now src/lib is done.

Allow the old-name functions to be compiled from the same source file as
the renamed functions, and add some #error directives to force the
issue with weak symbols for renamed functions when we support weak
symbols in the C library.

New hacks to make libc work painlessly without bumping the major number:
use type func(arg1s) asm("emitted_name") gcc mechanism.
Suggested by Bill Sommerfeld.

branches: 1.20.2;
Hacks to enable libc to work without bumping the major.

Revert all slash removing changes; it is not worth it...
The latest one broke "ls foo.c/". Sync with Lite-2.

Restore the NAPPEND macro, as it existed until revision 1.13, that deals
with roots consisting of a single slash. This special case of special
cases cannot be dealt with in fts_open() by simply chopping of a
trailing slash.

All this to avoid the occasional doubling of slashes. Oh well..

In fts_alloc() copy the trailing 0 character explicitly, instead of
relying on the passed input string having a 0 character at the right spot.
Takes care of PR#4234.

The change in revision 1.13 to avoid doubling slashes in path names
messes up the internal administrations of the fts engine.

Do this differently by simply stripping one trailing slash (if any)
from root paths passed to fts_open().

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Add missing prototypes.
Fix rest of gcc warnings.

Fix it so fts_* never adds a / to a path name when there is
already a trailing /. Fixes PR 1495.

branches: 1.12.4;
merge with Lite, keeping local changes. Also use new Id format.

branches: 1.11.2;
Mostly sync with CSRG.

Avoid extra stat()s if a link count of 1 is returned for directories but the
d_type field is filled in.

POSIXification and bostic's official fix for the missing relative path problem

re-POSIXIFICATION. should have been punted back to bostic...

oops, restore bug fix that wasn't fed back to bostic...

minor fixes

Fix obscure bug where the working directory would not be restored to its
proper place (occurs if one of fts_open()'s arguments is a relative path
to a empty directory).

Change C library functions to use strchr() and strrchr() instead of index()
and rindex(). This will allow (strict {ANSI, POSIX, XOPEN}) applications
to redefine index() and rindex() without effecting the library internals.

Declare rcsid strings so they are stored in text segment.

Latest versions from uunet.

branches: 1.1.1;
Initial revision