pax: don't overwrite destination if -r -w copy fails

Add more error handling to pax -r -w so that any failure
during the copy to the temporary file (including a failed flush)
prevents any existing destination file from being replaced
with the partial (including possibly empty) temporary file.
The partial temporary file is removed. pax still exists non-zero.

Thanks to Michael van Elst (mlelstv@) for the analysis
of the problem in the PR.

Should fix PR misc/33753.

fix various typos, mainly in comments.

branches: 1.29.2;
s/copy copy/copy/ in comment.

branches: 1.28.76;
fix typos

Change all the 'return(x)' to 'return c'.
Makes some other searches I want to do a bit easier.

PR/20228: Simon Burge: pax has problems reading a particular cpio archive
The problem here is that the archive is too short (< 512 bytes). The
buffer routines, try to read at least 512 bytes, even when we try to determine
what format file we have, which is wrong.

fd can be -1 or -2 for the gnu long name/link hack. So check for >= 0
instead of -1 if we need to flush.

do the special symlink treatment with all negative fd's.

branches: 1.23.2;
Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/compat/config.h versus "standard autoconf" config.h

* Consistently move the inclusion of nbtool_config.h to before
<sys/cdefs.h> so that the former can provide __RCSID() (et al),
and there's no need to protect those macros any more.

These changes should make it easier to "tool-ify" a program by adding:
#if HAVE_NBTOOL_CONFIG_H
#include "nbtool_config.h"
#endif
to the top of the source files (for the general case).

Move Keith Muller's code from a 4-clause to a 3-clause licence by removing
the advertising clause. Diffs provided in PR 22397 by Joel Baker, confirmed
to the board by Keith Muller.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22249, verified by myself.

When writing (-w) or copying (-rw), and using -M (stdin file list is
mtree(8) specfile), compare the "post write/copy" mtime against the
actual "pre write/copy" mtime instead of the mtime from the specfile.

This prevents warnings such as:
pax: File ./foo was modified during copy to archive
if the file's mtime in the file system is different to what's in the specfile.
(The resultant file will still get the specfile mtime ...)

cosmetic error condition improvements.
- sprinkle some fflush() to print filenames correctly.
- print a \n to stdout to fix formatting.
- English, consistently use "Cannot" in error messages.

some whitespace cleanup.

Fix various spelling, grammar, and punctuation problems in comments, from Sergey Svishchev in PR 20164.

branches: 1.17.2;
Protect __RCSID and __COPYRIGHT from being invoked if not defined.

- ansi KNF (just remove all the #ifndef __STDC__ prototype junk,
leaving the ansi stuff)
- use longlong_t instead of quad_t (etc), and rename *uqd*() -> *ull*()
- clean up the NET2_STAT stuff similar to ftpd; provide #defines and
macros which select which cast to use, etc
- clean up the NET2_FTS and NET2_REGEX #define use

Fix typo.

Spell 'occurred' with two 'r's.

Cleanup and fix typos.
Partially from FreeBSD.

Fix SIGINFO botch (PR #8868).
Continue partial write(2) on signals (xwrite()).
Partial read(2) at a few places are also continued (xread()).

Add {read,write}_with_restart() hooks for porting on systems
which don't restart interrupted read()/write() calls.

Reviewed and discussed in tech-kern and tech-userlevel lists.

support ././@LongLink extraction, as created by GNU tar.

remove some old cruft.

branches: 1.9.4;
Deal with GCC warnings.

#if __GNUC__, work around bogus initialization warning that occurs on
at least the m68k-based ports.

- Rename local warn so tty_warn that we can include <err.h> since this program
uses err() and errx().
- Fix printf format strings.
- Added WARNS=1; note
- Added missing prototypes.
- Split overloaded trail function into trail() and subtrail().

kill 'register'

convert to new RCS id conventions.

Eliminate uses of some obsolete functions.

Fix up RCS ids.

Add RCS ID's

branches: 1.1.1;
Initial revision

fix various typos, mainly in comments.

branches: 1.29.2;
s/copy copy/copy/ in comment.

branches: 1.28.76;
fix typos

Change all the 'return(x)' to 'return c'.
Makes some other searches I want to do a bit easier.

PR/20228: Simon Burge: pax has problems reading a particular cpio archive
The problem here is that the archive is too short (< 512 bytes). The
buffer routines, try to read at least 512 bytes, even when we try to determine
what format file we have, which is wrong.

fd can be -1 or -2 for the gnu long name/link hack. So check for >= 0
instead of -1 if we need to flush.

do the special symlink treatment with all negative fd's.

branches: 1.23.2;
Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/compat/config.h versus "standard autoconf" config.h

* Consistently move the inclusion of nbtool_config.h to before
<sys/cdefs.h> so that the former can provide __RCSID() (et al),
and there's no need to protect those macros any more.

These changes should make it easier to "tool-ify" a program by adding:
#if HAVE_NBTOOL_CONFIG_H
#include "nbtool_config.h"
#endif
to the top of the source files (for the general case).

Move Keith Muller's code from a 4-clause to a 3-clause licence by removing
the advertising clause. Diffs provided in PR 22397 by Joel Baker, confirmed
to the board by Keith Muller.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22249, verified by myself.

When writing (-w) or copying (-rw), and using -M (stdin file list is
mtree(8) specfile), compare the "post write/copy" mtime against the
actual "pre write/copy" mtime instead of the mtime from the specfile.

This prevents warnings such as:
pax: File ./foo was modified during copy to archive
if the file's mtime in the file system is different to what's in the specfile.
(The resultant file will still get the specfile mtime ...)

cosmetic error condition improvements.
- sprinkle some fflush() to print filenames correctly.
- print a \n to stdout to fix formatting.
- English, consistently use "Cannot" in error messages.

some whitespace cleanup.

Fix various spelling, grammar, and punctuation problems in comments, from Sergey Svishchev in PR 20164.

branches: 1.17.2;
Protect __RCSID and __COPYRIGHT from being invoked if not defined.

- ansi KNF (just remove all the #ifndef __STDC__ prototype junk,
leaving the ansi stuff)
- use longlong_t instead of quad_t (etc), and rename *uqd*() -> *ull*()
- clean up the NET2_STAT stuff similar to ftpd; provide #defines and
macros which select which cast to use, etc
- clean up the NET2_FTS and NET2_REGEX #define use

Fix typo.

Spell 'occurred' with two 'r's.

Cleanup and fix typos.
Partially from FreeBSD.

Fix SIGINFO botch (PR #8868).
Continue partial write(2) on signals (xwrite()).
Partial read(2) at a few places are also continued (xread()).

Add {read,write}_with_restart() hooks for porting on systems
which don't restart interrupted read()/write() calls.

Reviewed and discussed in tech-kern and tech-userlevel lists.

support ././@LongLink extraction, as created by GNU tar.

remove some old cruft.

branches: 1.9.4;
Deal with GCC warnings.

#if __GNUC__, work around bogus initialization warning that occurs on
at least the m68k-based ports.

- Rename local warn so tty_warn that we can include <err.h> since this program
uses err() and errx().
- Fix printf format strings.
- Added WARNS=1; note
- Added missing prototypes.
- Split overloaded trail function into trail() and subtrail().

kill 'register'

convert to new RCS id conventions.

Eliminate uses of some obsolete functions.

Fix up RCS ids.

Add RCS ID's

branches: 1.1.1;
Initial revision

s/copy copy/copy/ in comment.

branches: 1.28.76;
fix typos

Change all the 'return(x)' to 'return c'.
Makes some other searches I want to do a bit easier.

PR/20228: Simon Burge: pax has problems reading a particular cpio archive
The problem here is that the archive is too short (< 512 bytes). The
buffer routines, try to read at least 512 bytes, even when we try to determine
what format file we have, which is wrong.

fd can be -1 or -2 for the gnu long name/link hack. So check for >= 0
instead of -1 if we need to flush.

do the special symlink treatment with all negative fd's.

branches: 1.23.2;
Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/compat/config.h versus "standard autoconf" config.h

* Consistently move the inclusion of nbtool_config.h to before
<sys/cdefs.h> so that the former can provide __RCSID() (et al),
and there's no need to protect those macros any more.

These changes should make it easier to "tool-ify" a program by adding:
#if HAVE_NBTOOL_CONFIG_H
#include "nbtool_config.h"
#endif
to the top of the source files (for the general case).

Move Keith Muller's code from a 4-clause to a 3-clause licence by removing
the advertising clause. Diffs provided in PR 22397 by Joel Baker, confirmed
to the board by Keith Muller.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22249, verified by myself.

When writing (-w) or copying (-rw), and using -M (stdin file list is
mtree(8) specfile), compare the "post write/copy" mtime against the
actual "pre write/copy" mtime instead of the mtime from the specfile.

This prevents warnings such as:
pax: File ./foo was modified during copy to archive
if the file's mtime in the file system is different to what's in the specfile.
(The resultant file will still get the specfile mtime ...)

cosmetic error condition improvements.
- sprinkle some fflush() to print filenames correctly.
- print a \n to stdout to fix formatting.
- English, consistently use "Cannot" in error messages.

some whitespace cleanup.

Fix various spelling, grammar, and punctuation problems in comments, from Sergey Svishchev in PR 20164.

branches: 1.17.2;
Protect __RCSID and __COPYRIGHT from being invoked if not defined.

- ansi KNF (just remove all the #ifndef __STDC__ prototype junk,
leaving the ansi stuff)
- use longlong_t instead of quad_t (etc), and rename *uqd*() -> *ull*()
- clean up the NET2_STAT stuff similar to ftpd; provide #defines and
macros which select which cast to use, etc
- clean up the NET2_FTS and NET2_REGEX #define use

Fix typo.

Spell 'occurred' with two 'r's.

Cleanup and fix typos.
Partially from FreeBSD.

Fix SIGINFO botch (PR #8868).
Continue partial write(2) on signals (xwrite()).
Partial read(2) at a few places are also continued (xread()).

Add {read,write}_with_restart() hooks for porting on systems
which don't restart interrupted read()/write() calls.

Reviewed and discussed in tech-kern and tech-userlevel lists.

support ././@LongLink extraction, as created by GNU tar.

remove some old cruft.

branches: 1.9.4;
Deal with GCC warnings.

#if __GNUC__, work around bogus initialization warning that occurs on
at least the m68k-based ports.

- Rename local warn so tty_warn that we can include <err.h> since this program
uses err() and errx().
- Fix printf format strings.
- Added WARNS=1; note
- Added missing prototypes.
- Split overloaded trail function into trail() and subtrail().

kill 'register'

convert to new RCS id conventions.

Eliminate uses of some obsolete functions.

Fix up RCS ids.

Add RCS ID's

branches: 1.1.1;
Initial revision

fix typos

Change all the 'return(x)' to 'return c'.
Makes some other searches I want to do a bit easier.

PR/20228: Simon Burge: pax has problems reading a particular cpio archive
The problem here is that the archive is too short (< 512 bytes). The
buffer routines, try to read at least 512 bytes, even when we try to determine
what format file we have, which is wrong.

fd can be -1 or -2 for the gnu long name/link hack. So check for >= 0
instead of -1 if we need to flush.

do the special symlink treatment with all negative fd's.

branches: 1.23.2;
Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/compat/config.h versus "standard autoconf" config.h

* Consistently move the inclusion of nbtool_config.h to before
<sys/cdefs.h> so that the former can provide __RCSID() (et al),
and there's no need to protect those macros any more.

These changes should make it easier to "tool-ify" a program by adding:
#if HAVE_NBTOOL_CONFIG_H
#include "nbtool_config.h"
#endif
to the top of the source files (for the general case).

Move Keith Muller's code from a 4-clause to a 3-clause licence by removing
the advertising clause. Diffs provided in PR 22397 by Joel Baker, confirmed
to the board by Keith Muller.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22249, verified by myself.

When writing (-w) or copying (-rw), and using -M (stdin file list is
mtree(8) specfile), compare the "post write/copy" mtime against the
actual "pre write/copy" mtime instead of the mtime from the specfile.

This prevents warnings such as:
pax: File ./foo was modified during copy to archive
if the file's mtime in the file system is different to what's in the specfile.
(The resultant file will still get the specfile mtime ...)

cosmetic error condition improvements.
- sprinkle some fflush() to print filenames correctly.
- print a \n to stdout to fix formatting.
- English, consistently use "Cannot" in error messages.

some whitespace cleanup.

Fix various spelling, grammar, and punctuation problems in comments, from Sergey Svishchev in PR 20164.

branches: 1.17.2;
Protect __RCSID and __COPYRIGHT from being invoked if not defined.

- ansi KNF (just remove all the #ifndef __STDC__ prototype junk,
leaving the ansi stuff)
- use longlong_t instead of quad_t (etc), and rename *uqd*() -> *ull*()
- clean up the NET2_STAT stuff similar to ftpd; provide #defines and
macros which select which cast to use, etc
- clean up the NET2_FTS and NET2_REGEX #define use

Fix typo.

Spell 'occurred' with two 'r's.

Cleanup and fix typos.
Partially from FreeBSD.

Fix SIGINFO botch (PR #8868).
Continue partial write(2) on signals (xwrite()).
Partial read(2) at a few places are also continued (xread()).

Add {read,write}_with_restart() hooks for porting on systems
which don't restart interrupted read()/write() calls.

Reviewed and discussed in tech-kern and tech-userlevel lists.

support ././@LongLink extraction, as created by GNU tar.

remove some old cruft.

branches: 1.9.4;
Deal with GCC warnings.

#if __GNUC__, work around bogus initialization warning that occurs on
at least the m68k-based ports.

- Rename local warn so tty_warn that we can include <err.h> since this program
uses err() and errx().
- Fix printf format strings.
- Added WARNS=1; note
- Added missing prototypes.
- Split overloaded trail function into trail() and subtrail().

kill 'register'

convert to new RCS id conventions.

Eliminate uses of some obsolete functions.

Fix up RCS ids.

Add RCS ID's

branches: 1.1.1;
Initial revision

From 4.4 lite

Pull up to last week's -current.

Pull up revision 1.24 (requested by cube in ticket #1733):
Do the special symlink treatment with all negative fd's.

fix botched pullup from ticket #1021 and make sure this compiles on
non-NetBSD hosts again. Also fixes PR#24481

Pullup rev 1.18-1.23 (requested by rafal in ticket #1021)

Pullup pax to current version on trunk. Includes many fixes.

branches: 1.23.2.2.2;
Pullup rev 1.25 (requested by christos in ticket #922)

fd can be -1 or -2 for the gnu long name/link hack. So check for >= 0
instead of -1 if we need to flush.

Pull up revision 1.24 (requested by dillo in ticket #507):
do the special symlink treatment with all negative fd's.

Apply patch (requested by riz in ticket #5512):
Sync pax with HEAD of 2005-07-22.