Copy stable/9 to releng/9.3 as part of the 9.3-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Copy head to stable/9 as part of 9.0-RELEASE release cycle.

Approved by: re (implicit)

Use the RFC2606 domain example.com in examples.

Make sysinstall WARNS=2 clean.

Approved by: cperciva (mentor)
MFC after: 1 month

Fix uninitialized variables that cause a crash when the network is
initialized and sysinstall is not running as init.

Submitted by: Nick Mills
Approved by: cperciva (mentor)
MFC after: 3 days

Fix bug introduced in r198317: Don't leak a file descriptor after scanning for network devices.

Approved by: cperciva (mentor)
MFC after: 1 week (original commit + bugfix)

Introduce 'netDev=ANY' support for scripted (install.cfg) installs, which results in the first ethernet interface with physical link being selected.

While here, fix a minor typo causing an 'if' to be missed.

Submitted by: randi

Allow a comma-separated list of network interfaces to be specified via the
netDev option in install.cfg.

Submitted by: randi
MFC after: 1 week

Remove vestiges of OLDCARD PC Card support. We haven't needed/used
this since 5.x.

Tighten IP address check, prevent '..' from being passed
from the check.

Submitted by: Ren Zhen <bg1tpt gmail com>
MFC after: 2 weeks

Fix numerous warnings. Aside from menu items in system.c and menu.c
this now compiles on i386 with WARNS?= 3. Most of the fixes included
adding missing 'static' keywords to internal functions, using fully-defined
terminators in statically defined arrays of structs, and various
signed vs unsigned mismatches. Also G/C'd unused configSecurity()
function.

s/lp/plip/ for PLIP interfaces.

Approved by: jhb
MFC after: 1 week

Attempt to fix DHCP address acquisition which was broken by rev. 1.133.

MFC After: 3 days

Preserve any additional arguments to ifconfig that were specified in the
DHCP case too.

PR: bin/74406
Approved by: jhb (proxy mentor)
MFC after: 3 days

Adapt sysinstall to the new dhclient. This includes explicitely telling
it about the lease file location and not invoking it with the (non-existant)
'-r' option. Releasing leases works vastly different now, so this isn't
needed.

Submitted by: sam
Approved by: re

Unremoved a used variable in the PCCARD_ARCH case.

Reported by: tinderbox

Remove unused variables.

Fixed assorted misuses of NULL in integer context.

Make a message less scary (based on user feedback)

Add a new variable `noInet6', which if set disables IPv6 configuration
dialog for network interfaces.

MFC after: 20 days

Explicitly release a existing lease before we start dhclient (again).
If we already have a lease and restart sysinstall (or something with
the net configuration goes wrong), we would have to reboot just
because there is a dhclient hanging around.

Reviewed by: murray (re)
MFC after: 5 days

debugMsg() should end with "\n".

If 'netInteractive' is set to true in an installation script, then
temporarily turn off the nonInteractive variable around the DHCP and IPv6
Yes/No questions in a network device setup so that those questions are
asked.

Only build and link the pccard module on architectures that support it (and
that have room for pccardd on mfsroot.flp).

Provide a more specific help line for PLIP installs, reminding the
user that they must provide the peer's IP address in the 'extra
options to ifconfig' box.

PR: misc/21273

Silence warnings.

Rework the RTSOL logic from previous patch (it was wrong)

PR: 26187 && 24136
Submitted by: Glenn Trewitt <trewitt@trewitt.org>

Allow network device name to be given on the command line in the
interactive case. This already works for non-interactive installs,
but at least one user thinks it would be useful and it certainly seems
more correct to allow it here as well.

So, this will now work :

# sysinstall netDev=fxp0 tcpMenuSelect

PR: bin/30229
Submitted by: Mikhail Teterin <mi@aldan.algebra.com>

Whoops, forgot a hunk on the previous patch. Fix RTSOL variable handling
AND DHCP handling.

PR: 26187
Submitted by: Glenn Trewitt <glenn@trewitt.org>

Fix IP address checking, now we allow addresses like 172.17.0.0/23 as
a host address

PR: misc/27799
Reviewed by: jkh
Approved by: jkh
MFC after: 1 month

Mark relevant functions __printflike()/__printf0like() and silence some of
the non-constant format string warnings.

MFC after: 1 week

Introduce DEVICE_INIT, DEVICE_GET, and DEVICE_SHUTDOWN macros. As the
names suggest, they perform methods on Device's. In addition, they
check that the pointer passed to them is valid; if it isn't, they
pretend that the action failed. This fixes some crashes due to NULL
dereferences (e.g., PR 26509).

Approved by: jkh (some time ago)

Ack! I finally got annoyed enough to actually kill this. There is no
need to manually force the network_interfaces variable in /etc/rc.conf,
and it only ever gets in the way. rc.network and rc.network6 DTRT with
the default of 'auto'. This should have died over a year ago.

Add better IP, netmask and gateway checks.

- IP addresses are verified as being correct dotted quad format.
- Netmasks are verified as being in correct dotted quad or 0x* format,
and being consecutive 1 bits followed by consecutive 0 bits.
- The gateway is verified as being correct dotted quad format and
being reachable through the configured IP address and netmask.

Adapt sysinstall to use the new msgNoYes() function which assumes
no as a default. Sysinstall should be both less dangerous and less
annoying as a result of this change, though that's just my opinion
(since they're the defaults which annoy ME the least :).

Wait DAD complete after ifconfig up.

Popup IPv6 dialog, again.

Correct variable check for VAR_TRY_DHCP.

This allows you to script sysinstall to say "NO" to DHCP and IPv6.
Previously, you could only script these features if you said YES.

Oops. Accidentally commited to releng_4 first.

PR: 20334
Approved by: jkh

Restore the screen after possibly spamming it.

Reported by: Brian J. McGovern <mcgovern@spoon.beta.com>

IPv6 support.
IPv6 configuration is only done by rtsol. Does someone really
need manual configuration? :-)
You can specify IPv6 DNS server as well.
We have only one server ftp7.jp.freebsd.org that speaks IPv6
in this time. ftp7.jp speaks IPv4 as well and also listed as
Japan #7.

Approved by: jkh

Fixed minor annoyance with sysinstall being redundant / braindead in
the network -> interfaces menu.

Approved by: jkh

Now I remember why I didn't write out the gateway in the DHCP case;
it was a feature.

OK, I admit defeat - allow the user to override hostname and gateway
values set by dhcp.

Set pccard_ifconfig in /etc/rc.conf automatically.

In retrospect, msgNotify() should leave its contents on the screen
longer to give the user something to look at while things are happening.
Change it to do so and insert the appropriate screen saves elsewhere.

Completely rip-out and redesign sysinstall's refresh model as well
as redoing all the menus to have proper, or at least non-hallucinogenic,
keyboard accelerators.

This requires my recent update to libdialog to work properly and will
probably also exhibit some other "interesting" behavior while the last
few missing screen clears are found (which is why I'm not going to MFC
immediately). At least now, however, sysinstall does not gratuitously
redraw random screens at the drop of a hat and drive serial console
installers out of their minds.

I shouldn't have incremented PART_OFF; it was wrong and broke label
display to boot. Also fix some various warning fluff while I'm in
here cleaning up.

Defensive coding to prevent a potential segfault.

PR: 14706
Submitted by: ru

Really fix the auto keyword botch correctly by just letting it
do its job and not override it when set.

Submitted by: Ruslan Ermilov <ru@FreeBSD.org>

Sigh, too many late nights!

Oh bollocks, I really screwed up the "auto" check here. Time
to crack the K&R; I must have forgotten the C language. :)

Embarrassingly noticed by: Howard Gutch <logix@foobar.franken.de>

Deal with new "auto" setting for network_interfaces.

Only do dhclient once; it has its own internal retry which is more than
long enough (and doing it multiple times results in a dialog which waits
AGES to complete).

Oh crud, did I ever screw the pooch! Rather than sync this with -stable,
I backed-out the changes in -current and didn't touch stable at all (I
thought I had my patch order reversed, not what actually happened).
AIEEE! I can't even blame the crack for this one since I broke my
crack pipe a few weeks ago. I think sleep deprivation gets the blame
for this one.

Medal for noticing this one goes to: Jim Bloom <bloom@acm.org>

MFC: Catch 3.2-stable sysinstall up to 4.0-current level functionality,
bringing in DHCP support. The only thing I left out were Poul-Henning's
newfs changes since I'm not sure if he's brought the rest of that support
into -stable yet. If it turns out that this is the case, I'll MFC those
changes too.

$Id$ -> $FreeBSD$

Quiet some overly chatty debug output, do some minor cleanups to
the DHCP support code.

Re-enable play-nice-with-DHCP option now that bpf is the default
in GENERIC. Now a dhcp-configured system will both install and boot
initially with proper interface configuration.

Intentionally do the wrong thing in using the initial DHCP values for
ifconfig, essentially stealing the lease until the user goes and changes
it. The alternative, sadly, is total dysfunction since bpf isn't in
GENERIC and network connectivity would otherwise fail completely on first
bootup when DHCP configuration was attempted again.

The ultimate answer here is to make either bpf a loadable kernel module
(which security conscious admins will be able to simply remove from /modules)
or come up with a lighter weight mechanism just for dhcp and other apps that
need to see broadcast packets but not otherwise sniff the wire in full
bpf glory.

Wait for dhclient in a far saner fashion.

Submitted by: obrien

cleanup pass over new stuff.

Another batch of fixes for dhcp support in sysinstall, now dragging
in some code from C. Stone to parse the lease information. This is still
a WIP and this commit is largely intended to allow others to sync up; the
dhclient code still only works when doing dhcp configuration post-install
and requires a bit more work on the boot floppy before it will truly
work in the minimal bootstrapping role.

Some additional optimizations for using DHCP.

Miscellaneous fixes for dhcp client support.

Re-enable DHCP client support again (but optional and turned off by default
for the time being) for debugging purposes.

Fix bug in options selection.

Erm, correct mighty braino in previous "don't annoy me" change.

Commit a more general version of the last patch; don't do any back-filling
of values more than once. User might want to override them.

Argh, those last two commits snuck in with the other one by mistake.
Disable the non-working dhcp client code I just committed by mistake.

Fix includes; I had a slightly different Makefile than everyone else
which is why I didn't see this. :)

Noted by: Maxim Sobolev <sobomax@altavista.net>

Totally change the way variables are accounted for in sysinstall.
Now we know which variables are internal and which need to be
backed to /etc/rc.conf.site. rc.conf is not touched now.

Also kget kernel change information back properly and set up a loader.rc
file to use it.

o Break fixups into binary fixups and XFree86 based fixups.
o Move fixups into extraction routine so all consumers don't have to duplicate
the right behavior.
o Make some things more orthogonal (just for asthetics sake)
o Add option to go back and do it again if XF86Setup fails (possibly with
a different setup - this one has always annoyed me).

Accept gateway value of NO

Put all variables in VAR_ #define's to force a single location for all
of these magic knobs. This is purely cosmetic and a documentation issue
so we don't have to glop through the source code looking for gems.

Add a new netInteractive variable so that the interactiveness of the TCP
setup dialog from scripts is more controllable. No more biasing off of
hostname (which is now non-optional in the non-netInteractive case).
Requested by: pst

Make upgrade potentially a little less interactive.
Add and document new loadConfig function (sort of like a script #include).
Make TCP/IP setup far less chatty when it doesn't need to be.

1. Add a noWarn flag so that scripts can turn warnings off.
2. If hostname not set from script, bring up interactive dialog anyway.

YAMF22

YAMF22

1. Make it possible to set up all the TCP/IP values from a script.

2. Update to XFree86 3.3

Add a registration screen so we can finally start counting our little user
puppies.

Revert $FreeBSD$ to $Id$

Properly check status of menu return.

Finally DTRT with tcpOpenDialog(); it should have never diddled
mediaDevice directly.

o Try to be more aggressive about reading in old configuration data
so that we're more useful in multi-user mode. This is still not
100%, but it pulls in a lot more than it used to. Some of the "composite"
variables in /etc/sysconfig are going to take more work.

o Always write /etc/resolv.conf and /etc/hosts if it makes sense to do
so.

o Reset media properly when reselecting. Longstanding bogon.

o Pull SIGPIPE handling out of package.c; I'm actually hoping to handle
this differently shortly.

o Fix bug where cancel in TCP setup dialog still checked data fields.
I think this closes a PR, but I will have to go look.

Don't unilaterally decide to skip network configuration if running multi-user;
ask politely.

Now that I know which parts of the installation really need it (since
there's no menu display bug to work around now), be far more selective
in my use of DITEM_RECREATE (which is slow and involves much screen I/O).

Use a better dialog for flagging field validation errors.

Pointed-Out-By: msmith

Keep our serial ports distinct so that first device is not found for
all (closes PR#2296).
Print better FTP failure diagnostics
Do better media failure checking in install.

Set defaults more rationally through the item selection loop.

Make the long-awaited change from $Id$ to $FreeBSD$

This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore. This update would have been
insane otherwise.

Do something I've wanted to do for quite some time - collapse all the
common layout code into some work functions and make all the layout-using
routine adopt them. Also reorganize includes and generally clean up.

Now that I've got my source tree sorted out, bring all the things
I've been committing into 2.2 directly all this time.

Fix trunctation of domainname.

As Paul has just pointed out, much of my strncpy() usage was either
bogus or overly complex and really needed to be done more consistently
and sanely throughout - no question about it. Done.

Suggested-By: Paul Traina <pst@Shockwave.COM>

Eliminate great evil in the networking code. That's all I'm gonna say.

Joerg's changes to add screen font and screenmap setting.
Some changes of my own to make screen saver configuration a little
more sane, and also make it easier to get to the keyboard/screen
setup from the options menu.

Make the save_userconfig() stuff conditional and turned off by default
(for now - still a few more wrinkles here). Add more debugging code
and some cosmetic tweaks.

Correct check for ensuring that the network configuration isn't fiddled with
when running multi-user.

Simplify some dialogs on the basis of my changes to ui_objects.c in libdialog.
Also update copyright notices.

Try to make screen update more efficient (less flickering) by more
judicious use of dialog_clear_norefresh().

Fix even more lurking bogons - why do I never find these until the last
possible minute? :-)

Make it plainer how to exit.

ack - left in a typo. Time for bed!

Uh, this is what I was really thinking when I made the device registration
changes - honest! :-)

Dispense with the special case handling of cuaa* devices by synthesizing
separate entries for sl0 and ppp0 on each device.

Remove a particularly annoying confirmation dialog.

Clear the screen before putting up tcpip dialog.

Bump snapshot release date - looks like I was off by a couple
of days!

More display fixes to sysinstall and assorted tweaking.

Bring this into sync.

I still have a _very very annoying_ display bug which occurs when a menu
item causes a submenu to be displayed - the screen repaints for the original
menu (which is restored upon return from the submenu) are off by about 4
characters. I've tried restoring the screen, the cursor position, you name
it - same deal. Grrrr! This commit is my first step in trying to get someone
else to help me look into this one since I'm just tearing my hair out at this
point!

1. Update all the copyrights to delete useless clauses 3 and 4.
2. Change more of the menu code over to new system.
3. Streamline label editor.

Major surgery.

1. Use new dialog menu hacks (no strings, just arrays of dialogMenuItem structs)
so that I can create composite menus with radio/checkbox/... items in them,
removing some long-standing UI bogons in various menus. This work isn't
finished yet, but will be done in two phases. This is phase one.

2. Remove all the script installation stuff. I never got time to document it,
it was arcane and it just complicated much of the code. There are better
ways of doing this if I want to do auto-driven installations later.

3. Remove much dead code and otherwise attempt to remove as much historical
grot as possible so that this code is easier to hack on. This is also
a two-stage process, phase one of which is now complete.

Miscellaneous cleanup before big round of menu restructuring (to use new
libdialog features).

Update the -current sources from the 2.1 branch.

Approved (in spirit) by: jkh

This mega-commit brings in Jordan's latest sysinstall version..
This looks like it was developed offline, and is being spammed over the
top of the existing. "That's fine by me! I dont really care how you do
it, just get it in there..." said Jordan in a conversation a short while
ago...

Merge RELENG_2_0_5 into HEAD

Remove trailing whitespace.

A small tweak to layout.

Sync up my work for the night. This should implement ALL possible
installation methods and provide a fairly robust set of menu options.
This should also fix a few more bugs on Poul-Henning's latest gripe
list.

Add various missing seat belts.

Sync up with Poul.

Humanize Poul-Henning's code. Status values should be properly
respected now.

1. Make this compile again after Poul's changes to the get() strategy
routine.

2. Improve the tcpip menu slightly.

Major cleanup. Mediaroutines now get asked about a file. All the
multi part stuff centralized.
The final check is backwards or something so it always said it failed,
even it it didn't.
Fixed tcpip address check to not be stupid, 10.0.255.1 is legal.

Netmask is unused now - we can delete it.

Don't add the default route in ppp - we'll only add it again later.

Fix a few bogons.

Ask name of "other" ftp site in correct place.
Make TIOCCONS redirection for console messages work properly; we no longer
open /dev/console for all I/O - we use the VTYs directly.

Clean up the configuration stuff a bit more - we should now populate
/etc with good things(tm).

Fire off ppp with all the proper initial options set.

Tighten up the TCP/IP dialog a little.
Simply install procedure a bit.

Totally revamp the TCP/IP dialog; now network selection makes a bit more sense.

Root floppy (which actually may be able to go completely away at some point
soon!) is now loadable from ftp/nfs/dos as well as CDROM and (of course)
floppy.

Fix more problems on Poul's Gripe List.

Bring in all my fixes to Poul's gripe list as of last night.

Cleanup.

Add a final configuration menu and the beginnings of the backing code
for it. The ftp installation method is working well enough to test.
Many more bug fixes, says Gary.

Add my first cut at TCP/IP device configuration. If this works, the
ftp installation method should now function. We'll know as soon as my
make release builds the floppies. I'm just committing this out of my
release tree now so that it doesn't get clobbered again.

1. Start syncing up the network strategy code so that folks like Poul and
Justin can see it.

2. Attempt to fix the redisplay problems in label.c some more. Not clearing
the screen each time is certainly faster, but it's causing all sorts of
problems.

Dispose of old, #if 0'd, out code which has been proved to be no longer needed.

Correct a conditional which could cause a off-by-one error in certain
circumstances.

1. Add serial devices to list of possible network device candidates.
2. Rework tcpip.c a bit so that devices which have been configured also
have the enabled flag set.

1. Primitive bad144 support (I believe an additional command is needed, but
won't know until Poul wakes up again).
2. Make vsystem() put its output on the debugging fd.
3. DTRT with root filesystem placement - now I see how this has to work
(thanks, Poul).
4. Many miscellaneous spelling errors fixed and general cleanup.

Commit my latest so that Gary can sync up - this version should also
be the grounds for our first round of testing in the release I'm rolling.
It doesn't load the distributions yet, but it should do everything else.

Hopefully the last version of this file. Add a lot more comments, and
actually give the data back to sysinstall in a coherent fashion now.

Oops - Jordan managed to grab my ``work in progress file'' which
doesn't even come close to compiling. This file compiles, and should
work.

This will now compile and even scribble helpfully on your disks.
It remains to be seen how successfully. The distribution loading code
is still not here yet, but the partition/newfs/mount/cpio-extract cycle
is as complete as it's ever going to get, modulo possible bug fixes.
The TCP/IP setup screen is also sort of here, albeit in a highly-changing
state due to the fact that per-interface information isn't being kept
right now but is being added (thanks, Gary!).

This does _not yet compile_; I'm simply bringing in my changes from
this weekend in order to more easily sync with my CVS tree at home.
Another commit relative to these changes will follow shortly.