History log of /freebsd-10-stable/sys/dev/pms/freebsd/driver/ini/
Revision Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
315813 23-Mar-2017 mav

MFC r311305 (by asomers):
Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name)

The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are
fixed-length strings. AFAICT the only place they're read is in
sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated.
However, the kernel doesn't null-terminate them. A bunch of copy-pasted code
uses strncpy to write them, and doesn't guarantee null-termination. For at
least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually
overflows. You can see the result by doing "camcontrol negotiate da0 -v".

This change null-terminates those fields everywhere they're set in the
kernel. It also shortens a few strings to ensure they'll fit within the
16-character field.

PR: 215474
Reported by: Coverity
CID: 1009997 1010000 1010001 1010002 1010003 1010004 1010005
CID: 1331519 1010006 1215097 1010007 1288967 1010008 1306000
CID: 1211924 1010009 1010010 1010011 1010012 1010013 1010014
CID: 1147190 1010017 1010016 1010018 1216435 1010020 1010021
CID: 1010022 1009666 1018185 1010023 1010025 1010026 1010027
CID: 1010028 1010029 1010030 1010031 1010033 1018186 1018187
CID: 1010035 1010036 1010042 1010041 1010040 1010039


/freebsd-10-stable/sys/cam/cam_xpt.c
/freebsd-10-stable/sys/cam/ctl/ctl_frontend_cam_sim.c
/freebsd-10-stable/sys/cam/scsi/scsi_low.c
/freebsd-10-stable/sys/dev/aac/aac_cam.c
/freebsd-10-stable/sys/dev/aacraid/aacraid_cam.c
/freebsd-10-stable/sys/dev/advansys/advansys.c
/freebsd-10-stable/sys/dev/advansys/adwcam.c
/freebsd-10-stable/sys/dev/aha/aha.c
/freebsd-10-stable/sys/dev/ahb/ahb.c
/freebsd-10-stable/sys/dev/ahci/ahci.c
/freebsd-10-stable/sys/dev/ahci/ahciem.c
/freebsd-10-stable/sys/dev/aic/aic.c
/freebsd-10-stable/sys/dev/aic7xxx/aic79xx_osm.c
/freebsd-10-stable/sys/dev/aic7xxx/aic7xxx_osm.c
/freebsd-10-stable/sys/dev/amr/amr_cam.c
/freebsd-10-stable/sys/dev/arcmsr/arcmsr.c
/freebsd-10-stable/sys/dev/ata/ata-all.c
/freebsd-10-stable/sys/dev/buslogic/bt.c
/freebsd-10-stable/sys/dev/ciss/ciss.c
/freebsd-10-stable/sys/dev/dpt/dpt_scsi.c
/freebsd-10-stable/sys/dev/esp/ncr53c9x.c
/freebsd-10-stable/sys/dev/firewire/sbp.c
/freebsd-10-stable/sys/dev/firewire/sbp_targ.c
/freebsd-10-stable/sys/dev/hpt27xx/hpt27xx_osm_bsd.c
/freebsd-10-stable/sys/dev/hptiop/hptiop.c
/freebsd-10-stable/sys/dev/hptmv/entry.c
/freebsd-10-stable/sys/dev/hptnr/hptnr_osm_bsd.c
/freebsd-10-stable/sys/dev/hptrr/hptrr_osm_bsd.c
/freebsd-10-stable/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
/freebsd-10-stable/sys/dev/iir/iir.c
/freebsd-10-stable/sys/dev/isci/isci_controller.c
/freebsd-10-stable/sys/dev/iscsi_initiator/isc_cam.c
/freebsd-10-stable/sys/dev/isp/isp_freebsd.c
/freebsd-10-stable/sys/dev/mfi/mfi_cam.c
/freebsd-10-stable/sys/dev/mly/mly.c
/freebsd-10-stable/sys/dev/mpr/mpr_sas.c
/freebsd-10-stable/sys/dev/mps/mps_sas.c
/freebsd-10-stable/sys/dev/mpt/mpt_cam.c
/freebsd-10-stable/sys/dev/mrsas/mrsas_cam.c
/freebsd-10-stable/sys/dev/mvs/mvs.c
src/agtiapi.c
/freebsd-10-stable/sys/dev/ppbus/vpo.c
/freebsd-10-stable/sys/dev/siis/siis.c
/freebsd-10-stable/sys/dev/sym/sym_hipd.c
/freebsd-10-stable/sys/dev/trm/trm.c
/freebsd-10-stable/sys/dev/twa/tw_osl_cam.c
/freebsd-10-stable/sys/dev/tws/tws_cam.c
/freebsd-10-stable/sys/dev/virtio/scsi/virtio_scsi.c
/freebsd-10-stable/sys/powerpc/ps3/ps3cdrom.c
/freebsd-10-stable/sys/powerpc/pseries/phyp_vscsi.c
296459 07-Mar-2016 pfg

MFC r295861:

ostiInitiatorIOCompleted(): wrong sizeof() argument.

Detected by: PVS Static Analysis
CID: 1331601, 1331523

286263 03-Aug-2015 imp

MFC r286208:

Only match devices that belong to this driver.

285809 23-Jul-2015 scottl

Merge driver for PMC Sierra's range of SAS/SATA HBAs.

Submitted by: Achim Leubner <Achim.Leubner@pmcs.com>
Approved by: re


/freebsd-10-stable/sys/amd64/conf/GENERIC
/freebsd-10-stable/sys/amd64/conf/NOTES
/freebsd-10-stable/sys/conf/files
/freebsd-10-stable/sys/dev/pms
/freebsd-10-stable/sys/dev/pms/RefTisa
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/api
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/api/dm.h
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/api/dmapi.h
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/api/tddmapi.h
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/dm
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/dm/dmdefs.h
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/dm/dmdisc.c
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/dm/dminit.c
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/dm/dmlist.h
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/dm/dmmisc.c
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/dm/dmport.c
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/dm/dmproto.h
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/dm/dmsmp.c
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/dm/dmtimer.c
/freebsd-10-stable/sys/dev/pms/RefTisa/discovery/dm/dmtypes.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/api
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/api/sa.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/api/sa_err.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/api/sa_spec.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/api/saapi.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/api/saosapi.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/hda
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/hda/64k
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/hda/64k/aap18008.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/hda/64k/aap1img.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/hda/64k/ila8008.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/hda/64k/ila8070.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/hda/64k/ilaimg.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/hda/64k/iop8008.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/hda/64k/iop8070.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/hda/64k/iopimg.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/hda/64k/istrimg.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/hda/64k/raae8070.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/mpi.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/mpi.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/mpidebug.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/mpidebug.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sadefs.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sadisc.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/saframe.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/saglobal.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sahw.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sahwreg.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sainit.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/saint.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/saioctlcmd.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sallist.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/samacro.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sampicmd.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sampidefs.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/saphy.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/saport.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/saproto.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sasata.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sasmp.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sassp.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/satimer.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/satypes.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/sautil.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sallsdk/spc/spcdefs.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sat
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/api
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/api/sm.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/api/smapi.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/api/tdsmapi.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/src
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/src/smdefs.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/src/sminit.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/src/smlist.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/src/smmisc.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/src/smproto.h
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/src/smsat.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/src/smsatcb.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/src/smsathw.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/src/smtimer.c
/freebsd-10-stable/sys/dev/pms/RefTisa/sat/src/smtypes.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/api
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/api/ostiapi.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/api/tiapi.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/api/tidefs.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/api/tiglobal.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/api/tiscsi.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/api/titypes.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/ossa.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/ossacmnapi.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tddefs.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tddmcmnapi.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdesgl.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdhw.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdinit.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdint.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdioctl.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdioctl.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdlist.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdmisc.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdport.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdproto.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdsatypes.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdsmcmnapi.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdtimers.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/tdutil.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/common/wcs.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/common
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/common/tdtypes.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/ini
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdcb.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itddefs.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itddisc.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdglobl.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdinit.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdtypes.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/tgt
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/tgt/ttdcb.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/tgt/ttdglobl.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/tgt/ttdinit.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/tgt/ttdio.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/tgt/ttdreset.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/tgt/ttdsmp.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/tgt/ttdtimer.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/tgt/ttdtxchg.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sas/tgt/ttdtypes.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sata
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sata/host
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sata/host/ossasat.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sata/host/sat.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sata/host/sat.h
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sata/host/sathw.c
/freebsd-10-stable/sys/dev/pms/RefTisa/tisa/sassata/sata/host/satproto.h
/freebsd-10-stable/sys/dev/pms/config.h
/freebsd-10-stable/sys/dev/pms/freebsd
/freebsd-10-stable/sys/dev/pms/freebsd/driver
/freebsd-10-stable/sys/dev/pms/freebsd/driver/common
/freebsd-10-stable/sys/dev/pms/freebsd/driver/common/encrypt_ioctl.h
/freebsd-10-stable/sys/dev/pms/freebsd/driver/common/lxcommon.h
/freebsd-10-stable/sys/dev/pms/freebsd/driver/common/lxencrypt.c
/freebsd-10-stable/sys/dev/pms/freebsd/driver/common/lxencrypt.h
/freebsd-10-stable/sys/dev/pms/freebsd/driver/common/lxosapi.c
/freebsd-10-stable/sys/dev/pms/freebsd/driver/common/lxproto.h
/freebsd-10-stable/sys/dev/pms/freebsd/driver/common/lxutil.c
/freebsd-10-stable/sys/dev/pms/freebsd/driver/common/osdebug.h
/freebsd-10-stable/sys/dev/pms/freebsd/driver/common/osenv.h
/freebsd-10-stable/sys/dev/pms/freebsd/driver/common/osstring.h
/freebsd-10-stable/sys/dev/pms/freebsd/driver/common/ostypes.h
/freebsd-10-stable/sys/dev/pms/freebsd/driver/ini
src
src/Readme.freebsd.txt
src/agdef.h
src/agtiapi.c
src/agtiapi.h
src/agtiproto.h
src/osapi.c
/freebsd-10-stable/sys/i386/conf/GENERIC
/freebsd-10-stable/sys/i386/conf/NOTES
/freebsd-10-stable/sys/modules/Makefile
/freebsd-10-stable/sys/modules/pms
/freebsd-10-stable/sys/modules/pms/Makefile
/freebsd-10-stable/sys/modules/pms/Makefile.inc