12012-10-02 Anders Carlsson <andersca@apple.com> 2 3 Build fixes. 4 5 * Plugins/Hosted/NetscapePluginHostManager.mm: 6 (WebKit::NetscapePluginHostManager::spawnPluginHost): 7 (WebKit::NetscapePluginHostManager::didCreateWindow): 8 * Plugins/Hosted/NetscapePluginHostProxy.h: 9 (NetscapePluginHostProxy): 10 * Plugins/Hosted/NetscapePluginHostProxy.mm: 11 (WebKit::NetscapePluginHostProxy::didEnterFullscreen): 12 (WebKit::NetscapePluginHostProxy::didExitFullscreen): 13 (WebKit::NetscapePluginHostProxy::applicationDidBecomeActive): 14 (WebKit::NetscapePluginHostProxy::endModal): 15 (WebKit): 16 (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess): 17 (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess): 18 (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess): 19 202012-10-01 Brady Eidson <beidson@apple.com> 21 22 Remove the Safari 2 -> Safari 3 icon database import code. 23 https://bugs.webkit.org/show_bug.cgi?id=98113 24 25 Reviewed by Maciej Stachowiak. 26 27 Nuke the performImport() IconDatabaseClient method, as well as the supporting methods. 28 29 * Misc/WebIconDatabase.mm: 30 * Misc/WebIconDatabaseInternal.h: 31 * Misc/WebIconDatabasePrivate.h: 32 * WebCoreSupport/WebIconDatabaseClient.h: 33 * WebCoreSupport/WebIconDatabaseClient.mm: 34 * WebKit.exp: 35 362012-09-28 Anders Carlsson <andersca@apple.com> 37 38 Remove support for method overloading from bridge code 39 https://bugs.webkit.org/show_bug.cgi?id=97959 40 41 Reviewed by Dan Bernstein. 42 43 Update for WebCore changes; MethodList has been replaced with a single Method* everywhere. 44 45 * Plugins/Hosted/ProxyInstance.h: 46 (ProxyInstance): 47 * Plugins/Hosted/ProxyInstance.mm: 48 (ProxyClass): 49 (WebKit::ProxyClass::methodNamed): 50 (WebKit::ProxyRuntimeMethod::create): 51 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod): 52 (WebKit::ProxyInstance::getMethod): 53 (WebKit::ProxyInstance::invokeMethod): 54 (WebKit::ProxyInstance::methodNamed): 55 562012-09-28 Anders Carlsson <andersca@apple.com> 57 58 Remove Java bridge 59 https://bugs.webkit.org/show_bug.cgi?id=97954 60 61 Reviewed by Sam Weinig. 62 63 The Java bridge is not used by any port; Mac now has a NPAPI Java plug-in. 64 65 * WebCoreSupport/WebFrameLoaderClient.h: 66 * WebCoreSupport/WebFrameLoaderClient.mm: 67 Make sure that we try to load the NPAPI Java plug-in. 68 692012-09-27 Anders Carlsson <andersca@apple.com> 70 71 Get rid of more unused WK1 plug-in code 72 https://bugs.webkit.org/show_bug.cgi?id=97835 73 74 Reviewed by Mark Rowe. 75 76 * Plugins/WebBasePluginPackage.mm: 77 Remove JavaCFMPluginFilename #define. 78 79 (-[WebBasePluginPackage initWithPath:]): 80 #ifndef __ppc__ is always true now. 81 82 (-[WebBasePluginPackage isJavaPlugIn]): 83 Remove JavaCFMPluginFilename. 84 85 * Plugins/WebNetscapeDeprecatedFunctions.c: Removed. 86 * Plugins/WebNetscapeDeprecatedFunctions.h: Removed. 87 Remove functions that nobody calls anymore. 88 89 * Plugins/WebNetscapePluginPackage.mm: 90 Remove +initialize call, the earliest version of Shockwave we now support doesn't 91 require us to have a valid CurApRefNum file anymore. 92 93 (-[WebNetscapePluginPackage _tryLoad]): 94 Remove more unused code. 95 96 * Plugins/WebPluginDatabase.h: 97 Remove CFM from a comment. 98 992012-09-27 Anders Carlsson <andersca@apple.com> 100 101 Fix 32-bit build. 102 103 * Plugins/WebNetscapePluginPackage.mm: 104 (-[WebNetscapePluginPackage _initWithPath:]): 105 Add back the architecture check that i accidentally. 106 1072012-09-27 Anders Carlsson <andersca@apple.com> 108 109 Remove support for CFM plug-ins in WebKit1 110 https://bugs.webkit.org/show_bug.cgi?id=97822 111 112 Reviewed by Mark Rowe. 113 114 I'm pretty sure that CFM style plug-ins haven't been used for the last ten years or so, 115 so it's safe to remove them (especially since they're PPC only). 116 117 * Plugins/WebNetscapePluginPackage.h: 118 * Plugins/WebNetscapePluginPackage.mm: 119 (-[WebNetscapePluginPackage openResourceFile]): 120 (-[WebNetscapePluginPackage closeResourceFile:]): 121 (-[WebNetscapePluginPackage _initWithPath:]): 122 (-[WebNetscapePluginPackage _tryLoad]): 123 (-[WebNetscapePluginPackage _unloadWithShutdown:]): 124 * Plugins/WebPluginDatabase.mm: 125 (PluginPackageCandidates::PluginPackageCandidates): 126 (PluginPackageCandidates::update): 127 (PluginPackageCandidates::bestCandidate): 128 (PluginPackageCandidates): 129 1302012-09-26 Anders Carlsson <andersca@apple.com> 131 132 Stop using kCFURLHFSPathStyle 133 https://bugs.webkit.org/show_bug.cgi?id=97731 134 <rdar://problem/12378980> 135 136 Reviewed by Tim Horton. 137 138 Stop passing Carbon style paths to the plug-in. Both WebKitPluginHost, WebKit2 and Firefox 139 pass POSIX style paths which makes more sense. 140 141 * Plugins/WebNetscapePluginStream.mm: 142 (WebNetscapePluginStream::destroyStream): 143 1442012-09-25 Dan Bernstein <mitz@apple.com> 145 146 WebKit/mac part of <rdar://problem/11455228> [mac] Stop using screen fonts 147 https://bugs.webkit.org/show_bug.cgi?id=97620 148 149 Reviewed by John Sullivan. 150 151 * WebView/WebPreferences.mm: 152 (+[WebPreferences initialize]): Changed the default value of the screenFontSubstitutionEnabled 153 preference to NO. 154 * WebView/WebView.mm: 155 (-[WebView _preferencesChanged:]): Changed to enable screen font substitution also if 156 the value of the NSFontDefaultScreenFontSubstitutionEnabled user defaults key is YES. 157 1582012-09-21 Jeffrey Pfau <jpfau@apple.com> 159 160 Add WebKit1 SPI for storage blocking preference 161 https://bugs.webkit.org/show_bug.cgi?id=97356 162 163 Reviewed by Brady Eidson. 164 165 * WebView/WebPreferenceKeysPrivate.h: 166 * WebView/WebPreferences.mm: 167 (+[WebPreferences initialize]): 168 (-[WebPreferences setStorageBlockingPolicy:]): 169 (-[WebPreferences storageBlockingPolicy]): 170 * WebView/WebPreferencesPrivate.h: 171 * WebView/WebView.mm: 172 (-[WebView _preferencesChanged:]): 173 1742012-09-24 Simon Fraser <simon.fraser@apple.com> 175 176 <rdar://problem/12351906> Have DumpRenderTree and WebKitTestRunner crash logs show which test crashed 177 178 Reviewed by Mark Rowe. 179 180 Use a new WebKitSytemInterface function to add data to crash logs about which 181 test was running when the crash happened. 182 183 * WebCoreSupport/WebSystemInterface.mm: 184 (InitWebCoreSystemInterface): Hook up the function pointer for [wk|WK]SetCrashReportApplicationSpecificInformation. 185 1862012-09-25 Beth Dakin <bdakin@apple.com> 187 188 https://bugs.webkit.org/show_bug.cgi?id=95397 189 Need to merge didFirstVisuallyNonEmptyLayout and 190 didNewFirstVisuallyNonEmptyLayout 191 -and corresponding- 192 <rdar://problem/10791680> 193 194 Reviewed by Sam Weinig. 195 196 The new API has two parts. First, the client has to opt into which 197 layout milestones they are interested in hearing about using 198 [WebView _layoutMilestones]. Then, WebKit will call 199 the WebFrameLoader delegate's didLayout(WebLayoutMilestones) 200 callback when the specified layout milestones have fired. 201 didLayout takes the WebLayoutMilestones bit mask, which will 202 indicate which milestones have fired since it is possible for two 203 to fire at the same time. 204 205 Remove dispatchDidFirstLayout, 206 dispatchDidFirstVisuallyNonEmptyLayout, and 207 dispatchDidNewFirstVisuallyNonEmptyLayout. They are now replaced 208 by dispatchDidLayout(LayoutMilestones) 209 * WebCoreSupport/WebFrameLoaderClient.h: 210 (WebFrameLoaderClient): 211 * WebCoreSupport/WebFrameLoaderClient.mm: 212 (WebFrameLoaderClient::dispatchDidLayout): 213 214 Add new function to the delegate for didLayout. 215 * WebView/WebDelegateImplementationCaching.h: 216 (WebFrameLoadDelegateImplementationCache): 217 218 We need a delegate template that takes an NSUInteger. 219 * WebView/WebDelegateImplementationCaching.mm: 220 (CallDelegate): 221 (CallFrameLoadDelegate): 222 223 Convert between WebCore and WebKit versions of the bit mask. 224 * WebView/WebView.mm: 225 (coreLayoutMilestones): 226 (kitLayoutMilestones): 227 228 Add new delegate, and set the appropriate layout milestones in 229 WebCore based on old delegates having implementations. 230 (-[WebView _cacheFrameLoadDelegateImplementations]): 231 232 Call into WebCore. 233 (-[WebView _listenForLayoutMilestones:]): 234 (-[WebView _layoutMilestones]): 235 * WebView/WebViewInternal.h: 236 * WebView/WebViewPrivate.h: 237 2382012-09-24 Benjamin Poulain <bpoulain@apple.com> 239 240 Fix Geolocation error reporting in the test support 241 https://bugs.webkit.org/show_bug.cgi?id=97386 242 243 Reviewed by Sam Weinig. 244 245 * WebView/WebView.mm: 246 (-[WebView _geolocationDidFailWithMessage:]): 247 * WebView/WebViewPrivate.h: 248 2492012-09-24 Ryosuke Niwa <rniwa@webkit.org> 250 251 suspend/resumeWidgetHierarchyUpdates should be a RAII object 252 https://bugs.webkit.org/show_bug.cgi?id=96706 253 254 Reviewed by Simon Fraser. 255 256 * WebView/WebHTMLView.mm: 257 (-[WebHTMLView _invalidateGStatesForTree]): 258 2592012-09-21 Chris Rogers <crogers@google.com> 260 261 Add Web Audio support for deprecated/legacy APIs 262 https://bugs.webkit.org/show_bug.cgi?id=97050 263 264 Reviewed by Eric Carlson. 265 266 * Configurations/FeatureDefines.xcconfig: 267 2682012-09-19 Dan Bernstein <mitz@apple.com> 269 270 WebKit/mac part of adding a setting and API for disabling screen font substitution 271 https://bugs.webkit.org/show_bug.cgi?id=97168 272 273 Reviewed by Tim Horton. 274 275 * WebView/WebPreferenceKeysPrivate.h: Defined WebKitScreenFontSubstitutionEnabledKey. 276 * WebView/WebPreferences.mm: 277 (+[WebPreferences initialize]): Added a default value of YES for the new preference key. 278 (-[WebPreferences setScreenFontSubstitutionEnabled:]): Added this setter. 279 * WebView/WebPreferencesPrivate.h: 280 * WebView/WebView.mm: 281 (-[WebView _preferencesChanged:]): Added a call to Settings::setScreenFontSubstitutionEnabled 282 to push the preference down to Settings. 283 2842012-09-17 Dan Bernstein <mitz@apple.com> 285 286 <rdar://problem/12316935> [mac WebKit1]: -[WebView _setPaginationBehavesLikeColumns:] is a no-op 287 https://bugs.webkit.org/show_bug.cgi?id=96971 288 289 Reviewed by Sam Weinig. 290 291 * WebView/WebView.mm: 292 (-[WebView _setPaginationBehavesLikeColumns:]): Added a call to setPagination(). 293 2942012-09-14 Adam Barth <abarth@webkit.org> 295 296 Remove webkitPostMessage 297 https://bugs.webkit.org/show_bug.cgi?id=96577 298 299 Reviewed by Ojan Vafai. 300 301 Add ENABLE_LEGACY_VENDOR_PREFIXES flag. 302 303 * Configurations/FeatureDefines.xcconfig: 304 3052012-09-14 Beth Dakin <bdakin@apple.com> 306 307 https://bugs.webkit.org/show_bug.cgi?id=96688 308 Put position:fixed elements in their own layers and allow them to 309 create a stacking context 310 -and corresponding- 311 <rdar://problem/11467961> 312 313 Reviewed by Simon Fraser. 314 315 Enable these settings in WK1 too for consistency. 316 * WebView/WebView.mm: 317 (-[WebView _preferencesChanged:]): 318 3192012-09-13 Sheriff Bot <webkit.review.bot@gmail.com> 320 321 Unreviewed, rolling out r128552. 322 http://trac.webkit.org/changeset/128552 323 https://bugs.webkit.org/show_bug.cgi?id=96729 324 325 Still breaks the test on chromium linux debug. It's quite 326 annoying. (Requested by rniwa on #webkit). 327 328 * WebView/WebHTMLView.mm: 329 (-[WebHTMLView _invalidateGStatesForTree]): 330 3312012-09-13 Ryosuke Niwa <rniwa@webkit.org> 332 333 suspend/resumeWidgetHierarchyUpdates should be a RAII object 334 https://bugs.webkit.org/show_bug.cgi?id=96706 335 336 Reviewed by Simon Fraser. 337 338 * WebView/WebHTMLView.mm: 339 (-[WebHTMLView _invalidateGStatesForTree]): 340 3412012-09-13 Sheriff Bot <webkit.review.bot@gmail.com> 342 343 Unreviewed, rolling out r128531. 344 http://trac.webkit.org/changeset/128531 345 https://bugs.webkit.org/show_bug.cgi?id=96719 346 347 plugins/document-open.html crash on Chromium-Linux (Requested 348 by tkent1 on #webkit). 349 350 * WebView/WebHTMLView.mm: 351 (-[WebHTMLView _invalidateGStatesForTree]): 352 3532012-09-13 Benjamin Poulain <bpoulain@apple.com> 354 355 Improve the SourceProvider hierarchy 356 https://bugs.webkit.org/show_bug.cgi?id=95635 357 358 Reviewed by Geoffrey Garen. 359 360 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Fix a #include abuse. 361 * WebView/WebScriptDebugger.mm: 362 (toNSString): We can now use the (faster) implicit conversion 363 from String to NSString. 364 3652012-09-13 Ryosuke Niwa <rniwa@webkit.org> 366 367 suspend/resumeWidgetHierarchyUpdates should be a RAII object 368 https://bugs.webkit.org/show_bug.cgi?id=96706 369 370 Reviewed by Simon Fraser. 371 372 * WebView/WebHTMLView.mm: 373 (-[WebHTMLView _invalidateGStatesForTree]): 374 3752012-09-12 Sheriff Bot <webkit.review.bot@gmail.com> 376 377 Unreviewed, rolling out r127876. 378 http://trac.webkit.org/changeset/127876 379 https://bugs.webkit.org/show_bug.cgi?id=96600 380 381 mouse click doesn't work for spin button if spin button in 382 iframe (Requested by yosin on #webkit). 383 384 * WebCoreSupport/WebFrameLoaderClient.mm: 385 (WebFrameLoaderClient::actionDictionary): 386 * WebView/WebHTMLView.mm: 387 (-[WebHTMLView elementAtPoint:allowShadowContent:]): 388 3892012-09-11 Geoffrey Garen <ggaren@apple.com> 390 391 Mac build fix: Commit a file I forgot. 392 393 * WebView/WebScriptDebugDelegate.mm: 394 (-[WebScriptCallFrame functionName]): 395 3962012-09-11 Michael Saboff <msaboff@apple.com> 397 398 Build fixed for http://trac.webkit.org/changeset/128243 399 400 Rubber stamped by Stephanie Lewis. 401 402 Added missing include file needed by 96422. 403 404 * icu/unicode/unorm2.h: Added. 405 4062012-09-11 Michael Saboff <msaboff@apple.com> 407 408 Build fixed for http://trac.webkit.org/changeset/128243 409 410 Rubber stamped by Stephanie Lewis. 411 412 Added missing include file needed by 96422. 413 414 * icu/unicode/ptypes.h: Added. 415 4162012-09-11 Michael Saboff <msaboff@apple.com> 417 418 Update ICU header files to more recent version 419 https://bugs.webkit.org/show_bug.cgi?id=96422 420 421 Reviewed by Geoff Garen. 422 423 Updated ICU header files to 4.6.1. Modifications made as part of the merge are: 424 platform.h - Changed ifndef / define / endif for U_HAVE_UINT8_T, U_HAVE_UINT16_T, U_HAVE_UINT32_T, 425 U_HAVE_UINT64_T, U_IS_BIG_ENDIAN and U_ENABLE_TRACING to match the existing platform.h 426 putil.h (line 132) - Changes defined(U_WINDOWS) to defined(WIN32) || defined(OS2) to match existing putil.h 427 ustring.h (line 945) - Wrapped macro argument cs with { (const UChar *)cs } to match existing ustring.h 428 utypes.h (line 545) - Changed defined(U_WINDOWS) to defined(WIN32) to match existing utypes.h 429 430 * icu/unicode/localpointer.h: Added. 431 * icu/unicode/parseerr.h: 432 * icu/unicode/platform.h: 433 * icu/unicode/putil.h: 434 * icu/unicode/uchar.h: 435 * icu/unicode/uconfig.h: 436 * icu/unicode/uidna.h: 437 * icu/unicode/uiter.h: 438 * icu/unicode/umachine.h: 439 * icu/unicode/unorm.h: 440 * icu/unicode/urename.h: 441 * icu/unicode/uscript.h: 442 * icu/unicode/ustring.h: 443 * icu/unicode/utf.h: 444 * icu/unicode/utf16.h: 445 * icu/unicode/utf8.h: 446 * icu/unicode/utypes.h: 447 * icu/unicode/uvernum.h: Added. 448 * icu/unicode/uversion.h: 449 4502012-09-11 Matt Lilek <mrl@apple.com> 451 452 OS X port should compile with newer versions of clang 453 https://bugs.webkit.org/show_bug.cgi?id=96434 454 455 m_isTerminated is unused in the Hosted flavor of NetscapePluginStream. 456 457 Reviewed by Anders Carlsson. 458 459 * Plugins/Hosted/HostedNetscapePluginStream.h: 460 (HostedNetscapePluginStream): 461 * Plugins/Hosted/HostedNetscapePluginStream.mm: 462 (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream): 463 4642012-09-10 Jer Noble <jer.noble@apple.com> 465 466 Unreviewed; rolling out r128081. 467 http://trac.webkit.org/changeset/128081 468 https://bugs.webkit.org/show_bug.cgi?id=96134 469 470 New test http/tests/media/video-donottrack.html fails to run on Apple test bots. 471 472 * WebCoreSupport/WebFrameLoaderClient.h: 473 * WebCoreSupport/WebFrameLoaderClient.mm: 474 * WebView/WebDelegateImplementationCaching.h: 475 (WebFrameLoadDelegateImplementationCache): 476 * WebView/WebDelegateImplementationCaching.mm: 477 * WebView/WebView.mm: 478 (-[WebView _cacheFrameLoadDelegateImplementations]): 479 4802012-09-07 Jon Lee <jonlee@apple.com> 481 482 Update notifications to latest spec 483 https://bugs.webkit.org/show_bug.cgi?id=91726 484 <rdar://problem/11910451> 485 486 Reviewed by Alexey Proskuryakov. 487 488 Expose lang and dir. 489 490 * WebView/WebNotification.h: 491 * WebView/WebNotification.mm: 492 (-[WebNotification lang]): 493 (-[WebNotification dir]): 494 4952012-09-10 Jer Noble <jer.noble@apple.com> 496 497 NSInvalidArgumentException in WebFrameLoaderClient::shouldSendDoNotTrackHTTPHeader() 498 https://bugs.webkit.org/show_bug.cgi?id=96320 499 500 Reviewed by Geoffrey Garen. 501 502 Client was being cached as the FrameLoaderClient, but requests were sent to the ResourceLoadClient. 503 504 * WebCoreSupport/WebFrameLoaderClient.mm: 505 (WebFrameLoaderClient::shouldSendDoNotTrackHTTPHeader): Send the request to the FrameLoadDelegate. 506 * WebView/WebDelegateImplementationCaching.h: 507 * WebView/WebDelegateImplementationCaching.mm: 508 (CallFrameLoadDelegateReturningBoolean): Added. 509 5102012-09-07 Jer Noble <jer.noble@apple.com> 511 512 <audio> and <video> should send Do Not Track when appropriate 513 https://bugs.webkit.org/show_bug.cgi?id=96134 514 515 Reviewed by Eric Carlson. 516 517 Add support for the shouldSendDoNotTrackHTTPHeader by passing the request 518 on to the WebFrameLoadDelegate. 519 520 * WebCoreSupport/WebFrameLoaderClient.h: 521 * WebCoreSupport/WebFrameLoaderClient.mm: 522 (WebFrameLoaderClient::shouldSendDoNotTrackHeader): 523 Pass the question on to the WebFrameLoadDelegate. 524 * WebView/WebDelegateImplementationCaching.h: 525 (WebFrameLoadDelegateImplementationCache): 526 Add an entry for the delegate's webViewShouldSendDoNotTrackHeader method. 527 * WebView/WebDelegateImplementationCaching.mm: 528 (CallResourceLoadDelegateReturningBoolean): Added a 0-parameter overloaded function. 529 * WebView/WebView.mm: 530 (-[WebView _cacheFrameLoadDelegateImplementations]): initialize the 531 cached value for shouldSendDoNotTrackHeaderFunc. 532 5332012-09-07 Benjamin Poulain <bpoulain@apple.com> 534 535 Rename the ustring() accessor to string() 536 https://bugs.webkit.org/show_bug.cgi?id=95919 537 538 Reviewed by Geoffrey Garen. 539 540 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 541 (WebKit::NetscapePluginInstanceProxy::enumerate): 542 5432012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com> 544 545 Simplify hitTestResultAtPoint and nodesFromRect APIs 546 https://bugs.webkit.org/show_bug.cgi?id=95720 547 548 Reviewed by Antonio Gomes. 549 550 Update calls to new API. 551 552 * WebCoreSupport/WebFrameLoaderClient.mm: 553 (WebFrameLoaderClient::actionDictionary): 554 * WebView/WebHTMLView.mm: 555 (-[WebHTMLView elementAtPoint:allowShadowContent:]): 556 5572012-09-05 Sam Weinig <sam@webkit.org> 558 559 Part 2 of removing PlatformString.h, remove PlatformString.h 560 https://bugs.webkit.org/show_bug.cgi?id=95931 561 562 Reviewed by Adam Barth. 563 564 Remove PlatformString.h 565 566 * History/WebHistoryItem.mm: 567 * Misc/WebStringTruncator.mm: 568 * Plugins/Hosted/NetscapePluginHostManager.h: 569 (NetscapePluginHostManager): 570 * Plugins/WebPluginController.mm: 571 * Storage/WebStorageTrackerClient.mm: 572 * WebCoreSupport/WebChromeClient.mm: 573 * WebCoreSupport/WebEditorClient.mm: 574 * WebCoreSupport/WebFrameLoaderClient.mm: 575 * WebCoreSupport/WebIconDatabaseClient.mm: 576 * WebCoreSupport/WebInspectorClient.h: 577 (WebInspectorClient): 578 (WebInspectorFrontendClient): 579 * WebView/WebRenderLayer.mm: 580 * WebView/WebViewData.h: 581 5822012-09-05 Benjamin Poulain <bpoulain@apple.com> 583 584 More fixes for String::operator+=() on Mac 585 https://bugs.webkit.org/show_bug.cgi?id=95880 586 587 Reviewed by Adam Barth. 588 589 * WebView/WebRenderLayer.mm: 590 (+[WebRenderLayer nameForLayer:]): Use StringBuilder to concatenate the class names 591 efficiently. 592 * WebView/WebView.mm: 593 (+[WebView _decodeData:]): This is a legitimate use of String::append(), there 594 is no other concatenation done on that string. 595 5962012-09-01 Mark Lam <mark.lam@apple.com> 597 598 Added #include <JavaScriptCore/Identifier.h>. 599 https://bugs.webkit.org/show_bug.cgi?id=95641. 600 601 Reviewed by Dan Bernstein. 602 603 The code references JSC::Indentifier but was previously depending on 604 someone else to #include it. This results in build problems when 605 building for the llint C loop configuration. 606 607 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 608 6092012-08-31 Tony Chang <tony@chromium.org> 610 611 Remove ENABLE_CSS3_FLEXBOX compile time flag 612 https://bugs.webkit.org/show_bug.cgi?id=95382 613 614 Reviewed by Ojan Vafai. 615 616 Everyone is already enabling this by default and the spec has stablized. 617 618 * Configurations/FeatureDefines.xcconfig: 619 6202012-08-31 Pratik Solanki <psolanki@apple.com> 621 622 objc_msgSend and IMP should be cast appropriately before using 623 https://bugs.webkit.org/show_bug.cgi?id=95242 624 625 Reviewed by Benjamin Poulain. 626 627 Fix for older compilers. Pass id as the return type to the template 628 instead of relying on default type. 629 630 * WebView/WebDelegateImplementationCaching.mm: 631 (CallDelegate): 632 (CallFormDelegate): 633 * WebView/WebHTMLView.mm: 634 (setCursor): 635 (setNeedsDisplayInRect): 636 6372012-08-30 Geoffrey Garen <ggaren@apple.com> 638 639 Use one object instead of two for closures, eliminating ScopeChainNode 640 https://bugs.webkit.org/show_bug.cgi?id=95501 641 642 Reviewed by Filip Pizlo. 643 644 Mechanical change to update for JSC interface change. 645 6462012-08-30 Sheriff Bot <webkit.review.bot@gmail.com> 647 648 Unreviewed, rolling out r127171. 649 http://trac.webkit.org/changeset/127171 650 https://bugs.webkit.org/show_bug.cgi?id=95505 651 652 testRunner does not need dumpWebNotificationCallbacks(). 653 (Requested by jonlee on #webkit). 654 655 * WebKit.exp: 656 6572012-08-30 Pratik Solanki <psolanki@apple.com> 658 659 objc_msgSend and IMP should be cast appropriately before using 660 https://bugs.webkit.org/show_bug.cgi?id=95242 661 662 Reviewed by Benjamin Poulain. 663 664 Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts 665 to a function pointer with right types when calling objc_msgSend and an 666 IMP method directly. 667 668 * WebCoreSupport/WebCachedFramePlatformData.h: 669 (WebCachedFramePlatformData::clear): 670 * WebCoreSupport/WebDeviceOrientationClient.mm: 671 (WebDeviceOrientationClient::getProvider): 672 * WebView/WebDelegateImplementationCaching.mm: 673 (CallDelegate): 674 (CallDelegateReturningBoolean): 675 (CallResourceLoadDelegateReturningBoolean): 676 (CallFormDelegate): 677 (CallFormDelegateReturningBoolean): 678 * WebView/WebHTMLView.mm: 679 (setCursor): 680 (setNeedsDisplayInRect): 681 6822012-08-30 Benjamin Poulain <bpoulain@apple.com> 683 684 Replace JSC::UString by WTF::String 685 https://bugs.webkit.org/show_bug.cgi?id=95271 686 687 Reviewed by Geoffrey Garen. 688 689 Get rid of UString, replace it by String, and simplify the code when possible. 690 691 On x86_64, this reduces the binary size by 7kb. 692 693 * Plugins/Hosted/NetscapePluginHostProxy.mm: 694 (identifierFromIdentifierRep): 695 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 696 (WebKit::NetscapePluginInstanceProxy::addValueToArray): 697 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState): 698 * Plugins/Hosted/ProxyInstance.mm: 699 (WebKit::ProxyRuntimeMethod::create): 700 (WebKit::ProxyRuntimeMethod::finishCreation): 701 (WebKit::ProxyInstance::getPropertyNames): 702 (WebKit::ProxyInstance::methodsNamed): 703 (WebKit::ProxyInstance::fieldNamed): 704 * WebView/WebFrame.mm: 705 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): 706 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): 707 * WebView/WebScriptDebugDelegate.mm: 708 (-[WebScriptCallFrame functionName]): 709 (-[WebScriptCallFrame evaluateWebScript:]): 710 * WebView/WebScriptDebugger.h: 711 (WTF): 712 (JSC): 713 (WebScriptDebugger): 714 * WebView/WebScriptDebugger.mm: 715 (toNSURL): 716 (WebScriptDebugger::sourceParsed): 717 * WebView/WebView.mm: 718 (aeDescFromJSValue): 719 7202012-08-30 Jon Lee <jonlee@apple.com> 721 722 [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT 723 https://bugs.webkit.org/show_bug.cgi?id=95232 724 <rdar://problem/12190776> 725 726 Reviewed by Alexey Proskuryakov. 727 728 * WebKit.exp: Export WebNotification class. 729 7302012-08-30 Jon Lee <jonlee@apple.com> 731 732 [Mac] Registering web views for notifications is unbalanced 733 https://bugs.webkit.org/show_bug.cgi?id=95465 734 <rdar://problem/12206765> 735 736 Reviewed by Darin Adler. 737 738 Setting the notification provider for a WK1 WebView registers that web view to the 739 provider. When the WebView is closed, WebCore is essentially responsible for 740 unregistering the web view. This leads to an imbalance on Lion since notifications are 741 not supported, and the NotificationController responsible for making the unregistration 742 call doesn't exist. 743 744 Instead, the unregisterWebView method should be called when the web view is closed. 745 746 * WebView/WebViewPrivate.h: Remove _notificationControllerDestroyed, since it is 747 unneeded. 748 749 * WebCoreSupport/WebNotificationClient.mm: 750 (WebNotificationClient::notificationControllerDestroyed): 751 * WebView/WebView.mm: 752 (-[WebView _close]): Unregister the web view from the assigned provider here. 753 (-[WebView _setNotificationProvider:]): Only allow setting the provider once, to avoid 754 registering the web view to multiple providers. 755 7562012-08-29 Jon Lee <jonlee@apple.com> 757 758 [Mac] Add iconURL to WebNotification 759 https://bugs.webkit.org/show_bug.cgi?id=95249 760 <rdar://problem/12192060> 761 762 Reviewed by Jessie Berlin. 763 764 * WebView/WebNotification.h: Expose iconURL. 765 * WebView/WebNotification.mm: Remove unnecessary ASSERTs. 766 (-[WebNotification title]): 767 (-[WebNotification body]): 768 (-[WebNotification tag]): 769 (-[WebNotification iconURL]): Added. 770 (-[WebNotification origin]): 771 (-[WebNotification notificationID]): 772 (-[WebNotification dispatchShowEvent]): 773 (-[WebNotification dispatchCloseEvent]): 774 (-[WebNotification dispatchClickEvent]): 775 (-[WebNotification dispatchErrorEvent]): 776 7772012-08-28 Geoffrey Garen <ggaren@apple.com> 778 779 Added JSScope::objectInScope(), and refactored callers to use it 780 https://bugs.webkit.org/show_bug.cgi?id=95281 781 782 Reviewed by Gavin Barraclough. 783 784 * WebView/WebScriptDebugDelegate.mm: 785 (-[WebScriptCallFrame scopeChain]): 786 7872012-08-28 Sheriff Bot <webkit.review.bot@gmail.com> 788 789 Unreviewed, rolling out r126914. 790 http://trac.webkit.org/changeset/126914 791 https://bugs.webkit.org/show_bug.cgi?id=95239 792 793 it breaks everything and fixes nothing (Requested by pizlo on 794 #webkit). 795 796 * History/WebHistory.mm: 797 (-[WebHistoryPrivate removeItemFromDateCaches:]): 798 (-[WebHistoryPrivate orderedLastVisitedDays]): 799 (WebHistoryWriter::WebHistoryWriter): 800 * Misc/WebCoreStatistics.mm: 801 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): 802 (+[WebCoreStatistics javaScriptObjectTypeCounts]): 803 * Plugins/Hosted/NetscapePluginHostManager.mm: 804 (WebKit::NetscapePluginHostManager::hostForPlugin): 805 (WebKit::NetscapePluginHostManager::pluginHostDied): 806 (WebKit::NetscapePluginHostManager::didCreateWindow): 807 * Plugins/Hosted/NetscapePluginHostProxy.mm: 808 (WebKit::NetscapePluginHostProxy::pluginHostDied): 809 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 810 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): 811 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain): 812 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release): 813 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): 814 (WebKit::NetscapePluginInstanceProxy::destroy): 815 (WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason): 816 (WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL): 817 * Plugins/Hosted/ProxyInstance.mm: 818 (WebKit::ProxyInstance::methodsNamed): 819 (WebKit::ProxyInstance::fieldNamed): 820 * Plugins/WebNetscapePluginView.mm: 821 (-[WebNetscapePluginView stopTimers]): 822 (-[WebNetscapePluginView startTimers]): 823 * WebCoreSupport/WebNotificationClient.mm: 824 (WebNotificationClient::show): 825 (WebNotificationClient::clearNotifications): 826 (WebNotificationClient::notificationObjectDestroyed): 827 * WebView/WebHTMLView.mm: 828 (commandNameForSelector): 829 8302012-08-28 Jon Lee <jonlee@apple.com> 831 832 Second build fix to r126909. 833 834 Added needed #else clause. 835 836 * WebView/WebView.mm: 837 (-[WebView _notificationIDForTesting:]): 838 8392012-08-28 Jon Lee <jonlee@apple.com> 840 841 Build fix to r126909. 842 843 Needed ENABLE(NOTIFICATIONS) guards. 844 845 * WebView/WebView.mm: 846 (-[WebView _notificationIDForTesting:]): 847 8482012-08-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> 849 850 Rename first/second to key/value in HashMap iterators 851 https://bugs.webkit.org/show_bug.cgi?id=82784 852 853 Reviewed by Eric Seidel. 854 855 * History/WebHistory.mm: 856 (-[WebHistoryPrivate removeItemFromDateCaches:]): 857 (-[WebHistoryPrivate orderedLastVisitedDays]): 858 (WebHistoryWriter::WebHistoryWriter): 859 * Misc/WebCoreStatistics.mm: 860 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): 861 (+[WebCoreStatistics javaScriptObjectTypeCounts]): 862 * Plugins/Hosted/NetscapePluginHostManager.mm: 863 (WebKit::NetscapePluginHostManager::hostForPlugin): 864 (WebKit::NetscapePluginHostManager::pluginHostDied): 865 (WebKit::NetscapePluginHostManager::didCreateWindow): 866 * Plugins/Hosted/NetscapePluginHostProxy.mm: 867 (WebKit::NetscapePluginHostProxy::pluginHostDied): 868 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 869 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): 870 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain): 871 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release): 872 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): 873 (WebKit::NetscapePluginInstanceProxy::destroy): 874 (WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason): 875 (WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL): 876 * Plugins/Hosted/ProxyInstance.mm: 877 (WebKit::ProxyInstance::methodsNamed): 878 (WebKit::ProxyInstance::fieldNamed): 879 * Plugins/WebNetscapePluginView.mm: 880 (-[WebNetscapePluginView stopTimers]): 881 (-[WebNetscapePluginView startTimers]): 882 * WebCoreSupport/WebNotificationClient.mm: 883 (WebNotificationClient::show): 884 (WebNotificationClient::clearNotifications): 885 (WebNotificationClient::notificationObjectDestroyed): 886 * WebView/WebHTMLView.mm: 887 (commandNameForSelector): 888 8892012-08-28 Jon Lee <jonlee@apple.com> 890 891 [Mac] Add SPI to WK1 to retrieve internal IDs for web notifications 892 https://bugs.webkit.org/show_bug.cgi?id=95099 893 <rdar://problem/12180186> 894 895 Reviewed by Jessie Berlin. 896 897 This is work toward providing Mac support for web notifications in DRT and WTR (77969). 898 899 Add function to retrieve the internal ID for a notification. This is needed by layout tests to support simulating 900 a user click on a notification. 901 902 * WebCoreSupport/WebNotificationClient.h: 903 (WebNotificationClient): 904 * WebCoreSupport/WebNotificationClient.mm: 905 (WebNotificationClient::notificationIDForTesting): Converts the JS notification to a WebCore notification, and passes 906 that to [WebView _notificationIDForTesting:]. 907 * WebView/WebView.mm: 908 (-[WebView _notificationIDForTesting:]): Retrieves the notification ID based on the WebCore notification instance. 909 * WebView/WebViewPrivate.h: 910 9112012-08-27 Sheriff Bot <webkit.review.bot@gmail.com> 912 913 Unreviewed, rolling out r126836. 914 http://trac.webkit.org/changeset/126836 915 https://bugs.webkit.org/show_bug.cgi?id=95163 916 917 Broke all Apple ports, EFL, and Qt. (Requested by tkent on 918 #webkit). 919 920 * History/WebHistory.mm: 921 (-[WebHistoryPrivate removeItemFromDateCaches:]): 922 (-[WebHistoryPrivate orderedLastVisitedDays]): 923 (WebHistoryWriter::WebHistoryWriter): 924 * Misc/WebCoreStatistics.mm: 925 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): 926 (+[WebCoreStatistics javaScriptObjectTypeCounts]): 927 * Plugins/Hosted/NetscapePluginHostManager.mm: 928 (WebKit::NetscapePluginHostManager::hostForPlugin): 929 (WebKit::NetscapePluginHostManager::pluginHostDied): 930 (WebKit::NetscapePluginHostManager::didCreateWindow): 931 * Plugins/Hosted/NetscapePluginHostProxy.mm: 932 (WebKit::NetscapePluginHostProxy::pluginHostDied): 933 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 934 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): 935 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain): 936 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release): 937 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): 938 (WebKit::NetscapePluginInstanceProxy::destroy): 939 (WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason): 940 (WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL): 941 * Plugins/Hosted/ProxyInstance.mm: 942 (WebKit::ProxyInstance::methodsNamed): 943 (WebKit::ProxyInstance::fieldNamed): 944 * Plugins/WebNetscapePluginView.mm: 945 (-[WebNetscapePluginView stopTimers]): 946 (-[WebNetscapePluginView startTimers]): 947 * WebCoreSupport/WebNotificationClient.mm: 948 (WebNotificationClient::show): 949 (WebNotificationClient::clearNotifications): 950 (WebNotificationClient::notificationObjectDestroyed): 951 * WebView/WebHTMLView.mm: 952 (commandNameForSelector): 953 9542012-08-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> 955 956 Rename first/second to key/value in HashMap iterators 957 https://bugs.webkit.org/show_bug.cgi?id=82784 958 959 Reviewed by Eric Seidel. 960 961 * History/WebHistory.mm: 962 (-[WebHistoryPrivate removeItemFromDateCaches:]): 963 (-[WebHistoryPrivate orderedLastVisitedDays]): 964 (WebHistoryWriter::WebHistoryWriter): 965 * Misc/WebCoreStatistics.mm: 966 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): 967 (+[WebCoreStatistics javaScriptObjectTypeCounts]): 968 * Plugins/Hosted/NetscapePluginHostManager.mm: 969 (WebKit::NetscapePluginHostManager::hostForPlugin): 970 (WebKit::NetscapePluginHostManager::pluginHostDied): 971 (WebKit::NetscapePluginHostManager::didCreateWindow): 972 * Plugins/Hosted/NetscapePluginHostProxy.mm: 973 (WebKit::NetscapePluginHostProxy::pluginHostDied): 974 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 975 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): 976 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain): 977 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release): 978 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): 979 (WebKit::NetscapePluginInstanceProxy::destroy): 980 (WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason): 981 (WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL): 982 * Plugins/Hosted/ProxyInstance.mm: 983 (WebKit::ProxyInstance::methodsNamed): 984 (WebKit::ProxyInstance::fieldNamed): 985 * Plugins/WebNetscapePluginView.mm: 986 (-[WebNetscapePluginView stopTimers]): 987 (-[WebNetscapePluginView startTimers]): 988 * WebCoreSupport/WebNotificationClient.mm: 989 (WebNotificationClient::show): 990 (WebNotificationClient::clearNotifications): 991 (WebNotificationClient::notificationObjectDestroyed): 992 * WebView/WebHTMLView.mm: 993 (commandNameForSelector): 994 9952012-08-27 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> 996 997 Rename RegisterProtocolHandler API to NavigatorContentUtils 998 https://bugs.webkit.org/show_bug.cgi?id=94920 999 1000 Reviewed by Adam Barth. 1001 1002 ENABLE_REGISTER_PROTOCOL_HANDLER is renamed to ENABLE_NAVIGATOR_CONTENT_UTILS. 1003 1004 * Configurations/FeatureDefines.xcconfig: 1005 10062012-08-24 Pratik Solanki <psolanki@apple.com> 1007 1008 Don't create a new ResourceRequest if delegate returns the same NSURLRequest we passed it 1009 https://bugs.webkit.org/show_bug.cgi?id=94962 1010 1011 Reviewed by Geoffrey Garen. 1012 1013 If the NSURLRequest returned from the delegate callback is the same as the one we passed to 1014 it, then avoid creating a new ResourceRequest object. This reduces the number of calls to 1015 ResourceRequest::doUpdateResourceRequest(). 1016 1017 * WebCoreSupport/WebFrameLoaderClient.mm: 1018 (WebFrameLoaderClient::dispatchWillSendRequest): 1019 10202012-08-23 Mark Hahnenberg <mhahnenberg@apple.com> 1021 1022 Change behavior of MasqueradesAsUndefined to better accommodate DFG changes 1023 https://bugs.webkit.org/show_bug.cgi?id=93884 1024 1025 Reviewed by Filip Pizlo. 1026 1027 With some upcoming changes to the DFG to remove uses of ClassInfo, we will be changing the behavior of 1028 MasqueradesAsUndefined. In order to make this change consistent across all of our execution engines, 1029 we will make this change to MasqueradesAsUndefined as a separate patch. After this patch, MasqueradesAsUndefined 1030 objects will only masquerade as undefined in their original context (i.e. their original JSGlobalObject). 1031 For example, if an object that masquerades as undefined in frame A is passed to frame B, it will not 1032 masquerade as undefined within frame B, but it will continue to masquerade in frame A. 1033 1034 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 1035 (WebKit::NetscapePluginInstanceProxy::addValueToArray): Passing ExecState to toBoolean call. 1036 10372012-08-22 Beth Dakin <bdakin@apple.com> 1038 1039 https://bugs.webkit.org/show_bug.cgi?id=94401 1040 Add support for making a web site become paginated using overflow: 1041 paged-x | paged-y 1042 -and corresponding- 1043 <rdar://problem/11831783> 1044 1045 Reviewed by Dave Hyatt. 1046 1047 WebCore::Page::Pagination is now just WebCore::Pagination. 1048 * WebView/WebView.mm: 1049 (-[WebView _setPaginationMode:]): 1050 (-[WebView _paginationMode]): 1051 (-[WebView _setPaginationBehavesLikeColumns:]): 1052 (-[WebView _setPageLength:]): 1053 (-[WebView _setGapBetweenPages:]): 1054 10552012-08-15 Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> 1056 1057 [css3-text] Add CSS3 Text decoration compile flag 1058 https://bugs.webkit.org/show_bug.cgi?id=93863 1059 1060 Reviewed by Julien Chaffraix. 1061 1062 This patch handles the compile flag implementation, which will come disabled by 1063 default, thus not exposing the CSS3 text decoration features to the web, unless 1064 when explicitly enabling it with "--css3-text-decoration" build parameter. 1065 1066 * Configurations/FeatureDefines.xcconfig: 1067 10682012-08-15 Sheriff Bot <webkit.review.bot@gmail.com> 1069 1070 Unreviewed, rolling out r125687. 1071 http://trac.webkit.org/changeset/125687 1072 https://bugs.webkit.org/show_bug.cgi?id=94147 1073 1074 It broke the whole world (Requested by Ossy_night on #webkit). 1075 1076 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 1077 (WebKit::NetscapePluginInstanceProxy::addValueToArray): 1078 10792012-08-14 Mark Hahnenberg <mhahnenberg@apple.com> 1080 1081 Change behavior of MasqueradesAsUndefined to better accommodate DFG changes 1082 https://bugs.webkit.org/show_bug.cgi?id=93884 1083 1084 Reviewed by Geoffrey Garen. 1085 1086 With some upcoming changes to the DFG to remove uses of ClassInfo, we will be changing the behavior of 1087 MasqueradesAsUndefined. In order to make this change consistent across all of our execution engines, 1088 we will make this change to MasqueradesAsUndefined as a separate patch. After this patch, MasqueradesAsUndefined 1089 objects will only masquerade as undefined in their original context (i.e. their original JSGlobalObject). 1090 For example, if an object that masquerades as undefined in frame A is passed to frame B, it will not 1091 masquerade as undefined within frame B, but it will continue to masquerade in frame A. 1092 1093 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 1094 (WebKit::NetscapePluginInstanceProxy::addValueToArray): Passing ExecState to toBoolean call. 1095 10962012-08-14 Adam Barth <abarth@webkit.org> 1097 1098 Delete Frame::domWindow() and Frame::existingDOMWindow() 1099 https://bugs.webkit.org/show_bug.cgi?id=93990 1100 1101 Reviewed by Eric Seidel. 1102 1103 * WebView/WebFrame.mm: 1104 (-[WebFrame _pendingFrameUnloadEventCount]): 1105 (-[WebFrame _cacheabilityDictionary]): 1106 11072012-08-14 Tom Sepez <tsepez@chromium.org> 1108 1109 REGRESSION r125500: 7 tests crashing on Mac bots 1110 https://bugs.webkit.org/show_bug.cgi?id=93970 1111 1112 Reviewed by Eric Seidel. 1113 1114 Make WebFrameLoaderClient::redirectDataToPlugin expect the now real possibility 1115 of a NULL pluginWidget argument. 1116 1117 * WebCoreSupport/WebFrameLoaderClient.mm: 1118 (WebFrameLoaderClient::redirectDataToPlugin) 1119 11202012-08-09 Kinuko Yasuda <kinuko@chromium.org> 1121 1122 http/tests/security/mixedContent/blob-url-in-iframe.html fails on Mac 1123 https://bugs.webkit.org/show_bug.cgi?id=88736 1124 1125 Reviewed by Alexey Proskuryakov. 1126 1127 WebView::_canHandleRequest should return true for "blob:" URL so that it can be shown in iframe. 1128 1129 * WebView/WebView.mm: 1130 (+[WebView _canHandleRequest:forMainFrame:]): 1131 11322012-08-08 Shane Stephens <shanestephens@google.com> 1133 1134 Compile flag for CSS Hierarchies 1135 https://bugs.webkit.org/show_bug.cgi?id=92433 1136 1137 Reviewed by Tony Chang. 1138 1139 * Configurations/FeatureDefines.xcconfig: 1140 11412012-08-05 Peter Wang <peter.wang@torchmobile.com.cn> 1142 1143 Web Inspector: [JSC] implement setting breakpoints by line:column 1144 https://bugs.webkit.org/show_bug.cgi?id=53003 1145 1146 Unreviewed, just changed the interface according the changes of base class JSC::Debugger. 1147 1148 No JSC can provide the column info of current JS statement, mac porting can use it to support 1149 "Pretty Print" debug mode. 1150 1151 * WebView/WebScriptDebugger.h: 1152 (WebScriptDebugger): 1153 * WebView/WebScriptDebugger.mm: 1154 (WebScriptDebugger::callEvent): 1155 (WebScriptDebugger::atStatement): 1156 (WebScriptDebugger::returnEvent): 1157 (WebScriptDebugger::exception): 1158 (WebScriptDebugger::willExecuteProgram): 1159 (WebScriptDebugger::didExecuteProgram): 1160 (WebScriptDebugger::didReachBreakpoint): 1161 11622012-08-01 Jian Li <jianli@chromium.org> 1163 1164 Add new CSS property "-webkit-widget-region" to expose dashboard region support for other port 1165 https://bugs.webkit.org/show_bug.cgi?id=90298 1166 1167 Reviewed by Adam Barth. 1168 1169 * Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define. 1170 11712012-08-01 Antti Koivisto <antti@apple.com> 1172 1173 Assertion failure in inspector/profiler/heap-snapshot-containment-show-all.html on Lion bot 1174 https://bugs.webkit.org/show_bug.cgi?id=92888 1175 1176 Reviewed by Andreas Kling. 1177 1178 Protect the WebInspectorWindowController so it doesn't get destroyed during [WebView close] and cause 1179 unsafe [WebView dealloc]. 1180 1181 * WebCoreSupport/WebInspectorClient.mm: 1182 (-[WebInspectorWindowController destroyInspectorView:]): 1183 11842012-07-29 Rik Cabanier <cabanier@adobe.com> 1185 1186 Add ENABLE_CSS_COMPOSITING flag 1187 https://bugs.webkit.org/show_bug.cgi?id=92553 1188 1189 Reviewed by Dirk Schulze. 1190 1191 Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html 1192 1193 * Configurations/FeatureDefines.xcconfig: 1194 11952012-07-27 Anders Carlsson <andersca@apple.com> 1196 1197 Show the unavailable plug-in indicator for Java applets as well 1198 https://bugs.webkit.org/show_bug.cgi?id=92521 1199 1200 Reviewed by Sam Weinig. 1201 1202 Check if the Java plug-in is blocked before trying to instantiate it. 1203 1204 * WebCoreSupport/WebFrameLoaderClient.mm: 1205 12062012-07-25 Jer Noble <jer.noble@apple.com> 1207 1208 Add setting to enable and disable diagnostic logging. 1209 https://bugs.webkit.org/show_bug.cgi?id=92337 1210 1211 Reviewed by Anders Carlsson. 1212 1213 Add a WebKit WebPreferences API to set set the WebCore diagnosticLoggingEnabled setting. 1214 1215 * WebView/WebPreferenceKeysPrivate.h: 1216 * WebView/WebPreferences.mm: 1217 (+[WebPreferences initialize]): Register the default value to false. 1218 (-[WebPreferences diagnosticLoggingEnabled]): Simple userDefaults accessor. 1219 (-[WebPreferences setDiagnosticLoggingEnabled:]): Ditto. 1220 * WebView/WebPreferencesPrivate.h: 1221 * WebView/WebView.mm: 1222 (-[WebView _preferencesChanged:]): Ensure this preference is propagated to Settings 1223 whenever the preferences change. 1224 12252012-07-25 Pratik Solanki <psolanki@apple.com> 1226 1227 Remove catchesDelegateExceptions from WebViewData and related accessor methods 1228 https://bugs.webkit.org/show_bug.cgi?id=90898 1229 1230 Reviewed by Darin Adler. 1231 1232 Remove catchesDelegateException ivar from WebViewData and all its accesor methods from 1233 WebView. All uses of this flag in WebKit set it to YES and no one calls 1234 _setCatchesDelegateExceptions with NO. 1235 1236 * WebCoreSupport/WebDragClient.mm: 1237 (WebDragClient::startDrag): 1238 * WebView/WebDelegateImplementationCaching.mm: 1239 (CallDelegate): 1240 (CallDelegateReturningFloat): 1241 (CallDelegateReturningBoolean): 1242 (CallResourceLoadDelegateReturningBoolean): 1243 (CallFormDelegate): 1244 (CallFormDelegateReturningBoolean): 1245 * WebView/WebView.mm: 1246 (-[WebView _commonInitializationWithFrameName:groupName:]): 1247 (-[WebView _policyDelegateForwarder]): 1248 (-[WebView _UIDelegateForwarder]): 1249 (-[WebView _editingDelegateForwarder]): 1250 (-[_WebSafeForwarder initWithTarget:defaultTarget:]): 1251 (-[_WebSafeForwarder forwardInvocation:]): 1252 * WebView/WebViewData.h: 1253 * WebView/WebViewPrivate.h: 1254 12552012-07-23 Simon Fraser <simon.fraser@apple.com> 1256 1257 Part 2 of: Implement sticky positioning 1258 https://bugs.webkit.org/show_bug.cgi?id=90046 1259 1260 Reviewed by Ojan Vafai. 1261 1262 Turn on ENABLE_CSS_STICKY_POSITION. 1263 1264 * Configurations/FeatureDefines.xcconfig: 1265 12662012-07-23 Pierre Rossi <pierre.rossi@gmail.com> 1267 1268 Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client 1269 https://bugs.webkit.org/show_bug.cgi?id=91006 1270 1271 Reviewed by Ryosuke Niwa. 1272 1273 Remove numTouchEventHandlersChanged stub. 1274 1275 * WebCoreSupport/WebChromeClient.h: 1276 12772012-07-23 Simon Fraser <simon.fraser@apple.com> 1278 1279 Part 1 of: Implement sticky positioning 1280 https://bugs.webkit.org/show_bug.cgi?id=90046 1281 1282 Reviewed by Ojan Vafai. 1283 1284 Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially. 1285 1286 Sort the ENABLE_CSS lines in the file. Make sure all the flags 1287 are in FEATURE_DEFINES. 1288 1289 * Configurations/FeatureDefines.xcconfig: 1290 12912012-07-23 Kent Tamura <tkent@chromium.org> 1292 1293 Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively 1294 https://bugs.webkit.org/show_bug.cgi?id=91941 1295 1296 Reviewed by Kentaro Hara. 1297 1298 A flag name for an elmement should be ENABLE_*_ELEMENT. 1299 1300 * Configurations/FeatureDefines.xcconfig: 1301 13022012-07-22 Kent Tamura <tkent@chromium.org> 1303 1304 Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT 1305 https://bugs.webkit.org/show_bug.cgi?id=91928 1306 1307 Reviewed by Kentaro Hara. 1308 1309 A flag name for an elmement should be ENABLE_*_ELEMENT. 1310 1311 * Configurations/FeatureDefines.xcconfig: 1312 13132012-07-20 Kent Tamura <tkent@chromium.org> 1314 1315 Rename ENABLE_DATALIST to ENABLE_DATALIST_ELEMENT 1316 https://bugs.webkit.org/show_bug.cgi?id=91846 1317 1318 Reviewed by Kentaro Hara. 1319 1320 A flag name for an elmement should be ENABLE_*_ELEMENT. 1321 1322 * Configurations/FeatureDefines.xcconfig: 1323 13242012-07-18 Benjamin Poulain <bpoulain@apple.com> 1325 1326 [Mac] Make WebDataSourcePrivate lighter 1327 https://bugs.webkit.org/show_bug.cgi?id=91511 1328 1329 Reviewed by Anders Carlsson. 1330 1331 Make WebDataSourcePrivate a simple C++ class and use smart pointers for memory management. 1332 1333 Since the "loader" attribute is only set on initialization, all the assertions spread in 1334 various function are removed in favor of assertions on initialization. 1335 1336 * WebView/WebDataSource.h: 1337 * WebView/WebDataSource.mm: 1338 (WebDataSourcePrivate): 1339 (WebDataSourcePrivate::WebDataSourcePrivate): 1340 (WebDataSourcePrivate::~WebDataSourcePrivate): 1341 Use a class instead of a Objective-C object for WebDataSourcePrivate. 1342 Use smart pointers instead of ref counting manually. 1343 1344 (-[WebDataSource _setRepresentation:]): 1345 (-[WebDataSource _addSubframeArchives:]): 1346 (-[WebDataSource _transferApplicationCache:]): 1347 (-[WebDataSource _setDeferMainResourceDataLoad:]): 1348 (-[WebDataSource _documentFragmentWithArchive:]): 1349 (-[WebDataSource _initWithDocumentLoader:]): 1350 1351 (+[WebDataSource initialize]): 1352 (-[WebDataSource dealloc]): 1353 (-[WebDataSource finalize]): 1354 WebDataSource takes the special initialization and destruction that was done in WebDataSourcePrivate. 1355 1356 (-[WebDataSource representation]): 1357 13582012-07-17 Vivek Galatage <vivekgalatage@gmail.com> 1359 1360 Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel. 1361 https://bugs.webkit.org/show_bug.cgi?id=91196 1362 1363 Reviewed by Pavel Feldman. 1364 1365 Refactoring InspectorClients. InspectorClient::openInspectorFrontend 1366 now returning the InspectorFrontendChannel. 1367 1368 * WebCoreSupport/WebInspectorClient.h: 1369 (WebInspectorClient): 1370 * WebCoreSupport/WebInspectorClient.mm: 1371 (WebInspectorClient::openInspectorFrontend): 1372 13732012-07-17 David Barr <davidbarr@chromium.org> 1374 1375 Introduce ENABLE_CSS_IMAGE_ORIENTATION compile flag 1376 https://bugs.webkit.org/show_bug.cgi?id=89055 1377 1378 Reviewed by Kent Tamura. 1379 1380 The css3-images module is at candidate recommendation. 1381 http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation 1382 1383 Add a configuration option for CSS image-orientation support, disabling it by default. 1384 1385 * Configurations/FeatureDefines.xcconfig: 1386 13872012-07-15 Joseph Pecoraro <pecoraro@apple.com> 1388 1389 Fix case sensitive build issue. 1390 1391 Unreviewed build fix. 1392 1393 * WebView/WebPreferences.mm: 1394 13952012-07-15 Benjamin Poulain <benjamin@webkit.org> 1396 1397 Make WebPreferencesPrivate a simple struct 1398 https://bugs.webkit.org/show_bug.cgi?id=91330 1399 1400 Reviewed by Filip Pizlo. 1401 1402 To avoid taking time creating a new Objective-C object for WebPreferencesPrivate, we can just make 1403 it a simple struct. 1404 1405 * WebView/WebPreferences.h: 1406 * WebView/WebPreferences.mm: 1407 (WebPreferencesPrivate): 1408 (WebPreferencesPrivate::WebPreferencesPrivate): 1409 Replace the Objective-C WebPreferencesPrivate by a struct. 1410 Remove IBCreatorID from the object as it is unused. 1411 Use RetainPtr for the Objective-C attribute to avoid tracking their memory manually. 1412 1413 (-[WebPreferences initWithIdentifier:]): 1414 Change the order of the initialization to avoid allocating anyting if a WebPreferences exists 1415 for the identifier. 1416 Both [NSObject init] and WebPreferencesPrivate allocation are moved after the fast path. 1417 1418 (-[WebPreferences initWithCoder:]): 1419 (-[WebPreferences encodeWithCoder:]): 1420 (-[WebPreferences dealloc]): 1421 (-[WebPreferences identifier]): 1422 (-[WebPreferences _valueForKey:]): 1423 (-[WebPreferences _setStringValue:forKey:]): 1424 (-[WebPreferences _setIntegerValue:forKey:]): 1425 (-[WebPreferences _setFloatValue:forKey:]): 1426 (-[WebPreferences _setBoolValue:forKey:]): 1427 (-[WebPreferences _setLongLongValue:forKey:]): 1428 (-[WebPreferences _setUnsignedLongLongValue:forKey:]): 1429 14302012-07-14 Benjamin Poulain <bpoulain@apple.com> 1431 1432 [Mac] Do not try to update the cache model for every WebPreferences change 1433 https://bugs.webkit.org/show_bug.cgi?id=91302 1434 1435 Reviewed by Joseph Pecoraro. 1436 1437 WebView was listening to any change on any WebPreferences in order to update the cache model. This is unneeded in most cases, 1438 we can just listen to updates of the CacheModel property. 1439 1440 * WebView/WebPreferences.mm: 1441 (-[WebPreferences initWithIdentifier:]): 1442 (-[WebPreferences _postCacheModelChangedNotification]): 1443 (-[WebPreferences setCacheModel:]): 1444 * WebView/WebPreferencesPrivate.h: 1445 * WebView/WebView.mm: 1446 (+[WebView initialize]): 1447 (+[WebView _cacheModelChangedNotification:]): 1448 14492012-07-14 Sheriff Bot <webkit.review.bot@gmail.com> 1450 1451 Unreviewed, rolling out r122665. 1452 http://trac.webkit.org/changeset/122665 1453 https://bugs.webkit.org/show_bug.cgi?id=91321 1454 1455 Broke Mac builds (Requested by rniwa on #webkit). 1456 1457 * WebView/WebPreferences.mm: 1458 (-[WebPreferences initWithIdentifier:]): 1459 (-[WebPreferences setCacheModel:]): 1460 * WebView/WebPreferencesPrivate.h: 1461 * WebView/WebView.mm: 1462 (+[WebView initialize]): 1463 (+[WebView _preferencesChangedNotification:]): 1464 14652012-07-13 Benjamin Poulain <bpoulain@apple.com> 1466 1467 [Mac] Do not try to update the cache model for every WebPreferences change 1468 https://bugs.webkit.org/show_bug.cgi?id=91302 1469 1470 Reviewed by Joseph Pecoraro. 1471 1472 WebView was listening to any change on any WebPreferences in order to update the cache model. This is unneeded in most cases, 1473 we can just listen to updates of the CacheModel property. 1474 1475 * WebView/WebPreferences.mm: 1476 (-[WebPreferences initWithIdentifier:]): 1477 (-[WebPreferences _postCacheModelChangedNotification]): 1478 (-[WebPreferences setCacheModel:]): 1479 * WebView/WebPreferencesPrivate.h: 1480 * WebView/WebView.mm: 1481 (+[WebView initialize]): 1482 (+[WebView _cacheModelChangedNotification:]): 1483 14842012-07-11 Mark Rowe <mrowe@apple.com> 1485 1486 Fix a logic error in the #if so that the correct code is compiled on Snow Leopard. 1487 1488 I introduced this in r122403 when I inverted the sense of the #if. 1489 1490 * WebView/WebFullScreenController.mm: 1491 14922012-07-11 Mark Rowe <mrowe@apple.com> 1493 1494 <http://webkit.org/b/91024> Build against the latest SDK when targeting older OS X versions. 1495 1496 Reviewed by Dan Bernstein. 1497 1498 The deployment target is already set to the version that we're targeting, and it's that setting 1499 which determines which functionality from the SDK is available to us. 1500 1501 * Configurations/Base.xcconfig: 1502 15032012-07-11 Mark Rowe <mrowe@apple.com> 1504 1505 <http://webkit.org/b/91022> WebFullScreenController and WKFullScreenWindowController shouldn't add unprefixed methods to AppKit classes 1506 1507 Reviewed by Dan Bernstein. 1508 1509 * WebView/WebFullScreenController.mm: 1510 (convertRectToScreen): Add a static helper method that calls through to -[NSWindow convertRectToScreen:] on OS versions where it exists 1511 but otherwise provides a compatibility implementation of it. 1512 (-[WebFullScreenController enterFullScreen:]): Call our new helper. 1513 15142012-07-11 Mark Rowe <mrowe@apple.com> 1515 1516 <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros 1517 1518 This removal was handled by a script that translates the relevant macros in to the equivalent checks 1519 using the system availability macros. 1520 1521 Reviewed by Filip Pizlo. 1522 1523 * DefaultDelegates/WebDefaultContextMenuDelegate.mm: 1524 * Misc/WebKitErrors.m: 1525 * Misc/WebNSControlExtras.m: 1526 * Misc/WebNSFileManagerExtras.mm: 1527 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 1528 * Plugins/WebBaseNetscapePluginView.mm: 1529 * Plugins/WebNetscapePluginView.mm: 1530 * WebCoreSupport/WebChromeClient.mm: 1531 * WebCoreSupport/WebEditorClient.mm: 1532 * WebCoreSupport/WebFrameLoaderClient.mm: 1533 * WebCoreSupport/WebSystemInterface.mm: 1534 * WebView/WebClipView.mm: 1535 * WebView/WebDynamicScrollBarsView.mm: 1536 * WebView/WebFrameView.mm: 1537 * WebView/WebFullScreenController.mm: 1538 * WebView/WebHTMLView.mm: 1539 * WebView/WebHTMLViewInternal.h: 1540 * WebView/WebPDFDocumentExtras.mm: 1541 * WebView/WebPreferences.mm: 1542 * WebView/WebResourceInternal.h: 1543 * WebView/WebScriptDebugDelegate.h: 1544 * WebView/WebView.mm: 1545 * WebView/WebViewPrivate.h: 1546 15472012-07-11 Anders Carlsson <andersca@apple.com> 1548 1549 Add -Wtautological-compare and -Wsign-compare warning flags 1550 https://bugs.webkit.org/show_bug.cgi?id=90994 1551 1552 Reviewed by Mark Rowe. 1553 1554 * Configurations/Base.xcconfig: 1555 15562012-07-11 Mark Rowe <mrowe@apple.com> 1557 1558 Add a Mountain Lion version of libWebKitSystemInterface.a. 1559 1560 Reviewed by John Sullivan. 1561 1562 * Configurations/DebugRelease.xcconfig: Look for the library under its expected name. 1563 15642012-07-10 Adam Barth <abarth@webkit.org> 1565 1566 WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed 1567 https://bugs.webkit.org/show_bug.cgi?id=90910 1568 1569 Reviewed by Eric Seidel. 1570 1571 * WebView/WebPreferences.mm: 1572 (+[WebPreferences initialize]): 1573 (-[WebPreferences setHixie76WebSocketProtocolEnabled:]): 1574 (-[WebPreferences isHixie76WebSocketProtocolEnabled]): 1575 * WebView/WebView.mm: 1576 (-[WebView _preferencesChanged:]): 1577 15782012-07-09 Matt Falkenhagen <falken@chromium.org> 1579 1580 Add ENABLE_DIALOG_ELEMENT and skeleton files 1581 https://bugs.webkit.org/show_bug.cgi?id=90521 1582 1583 Reviewed by Kent Tamura. 1584 1585 * Configurations/FeatureDefines.xcconfig: 1586 15872012-07-09 Yongjun Zhang <yongjun_zhang@apple.com> 1588 1589 Consider closing unused localStorage database after a timeout. 1590 https://bugs.webkit.org/show_bug.cgi?id=90713 1591 1592 For a localStorage, if there is no active document referencing to it for certain amount of time (300 seconds), 1593 we can close the underlying sqlite database. 1594 1595 Reviewed by Brady Eidson. 1596 1597 * Storage/WebStorageManager.mm: 1598 (+[WebStorageManager setStorageDatabaseIdleInterval:]): add a new method for DumpRenderTree to set the timeout 1599 that we will wait before closing database. 1600 (initializeLocalStoragePath): 1601 * Storage/WebStorageManagerPrivate.h: 1602 16032012-07-09 Sheriff Bot <webkit.review.bot@gmail.com> 1604 1605 Unreviewed, rolling out r122107. 1606 http://trac.webkit.org/changeset/122107 1607 https://bugs.webkit.org/show_bug.cgi?id=90794 1608 1609 Build failure on Mac debug bots (Requested by falken_ on 1610 #webkit). 1611 1612 * Configurations/FeatureDefines.xcconfig: 1613 16142012-07-09 Matt Falkenhagen <falken@chromium.org> 1615 1616 Add ENABLE_DIALOG_ELEMENT and skeleton files 1617 https://bugs.webkit.org/show_bug.cgi?id=90521 1618 1619 Reviewed by Kent Tamura. 1620 1621 * Configurations/FeatureDefines.xcconfig: 1622 16232012-07-04 John Mellor <johnme@chromium.org> 1624 1625 Text Autosizing: Add compile flag and runtime setting 1626 https://bugs.webkit.org/show_bug.cgi?id=87394 1627 1628 This patch renames Font Boosting to Text Autosizing. 1629 1630 Reviewed by Adam Barth. 1631 1632 * Configurations/FeatureDefines.xcconfig: 1633 16342012-07-02 Benjamin Poulain <bpoulain@apple.com> 1635 1636 Do not do any logging initialization when logging is disabled 1637 https://bugs.webkit.org/show_bug.cgi?id=90228 1638 1639 Reviewed by Simon Fraser. 1640 1641 * Misc/WebIconDatabase.mm: 1642 (-[WebIconDatabase _scaleIcon:toSize:]): 1643 * Misc/WebKitLogging.h: 1644 * Misc/WebKitLogging.m: 1645 * WebView/WebHTMLView.mm: 1646 (-[WebHTMLView _attributeStringFromDOMRange:]): 1647 * WebView/WebView.mm: 1648 (-[WebView _commonInitializationWithFrameName:groupName:]): 1649 16502012-07-01 Timothy Hatcher <timothy@apple.com> 1651 1652 Make the "Inspect Element" context menu item appear in nightly builds again. 1653 1654 rdar://problem/11702613 1655 https://webkit.org/b/89323 1656 1657 Reviewed by Dan Bernstein. 1658 1659 * WebView/WebUIDelegatePrivate.h: 1660 Add missing enums that were added in ContextMenuItem.h but left out here. 1661 16622012-06-29 Sheriff Bot <webkit.review.bot@gmail.com> 1663 1664 Unreviewed, rolling out r121529. 1665 http://trac.webkit.org/changeset/121529 1666 https://bugs.webkit.org/show_bug.cgi?id=90260 1667 1668 Failed to compile on Chromium WebKitMacBuilder (Requested by 1669 keishi on #webkit). 1670 1671 * DefaultDelegates/WebDefaultContextMenuDelegate.mm: 1672 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): 1673 * Misc/WebNSControlExtras.m: 1674 (-[NSControl sizeToFitAndAdjustWindowHeight]): 1675 * WebCoreSupport/WebEditorClient.mm: 1676 (WebEditorClient::shouldEraseMarkersAfterChangeSelection): 1677 (WebEditorClient::getGuessesForWord): 1678 * WebCoreSupport/WebFrameLoaderClient.mm: 1679 (WebFrameLoaderClient::dispatchDidFirstLayout): 1680 (WebFrameLoaderClient::provisionalLoadStarted): 1681 * WebCoreSupport/WebSystemInterface.mm: 1682 (InitWebCoreSystemInterface): 1683 * WebView/WebDynamicScrollBarsView.mm: 1684 (-[WebDynamicScrollBarsView scrollWheel:]): 1685 * WebView/WebFullScreenController.mm: 1686 (-[WebFullScreenController finishedEnterFullScreenAnimation:]): 1687 (-[WebFullScreenController exitFullScreen]): 1688 * WebView/WebHTMLView.mm: 1689 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): 1690 * WebView/WebView.mm: 1691 (+[WebView initialize]): 1692 (-[WebView _deviceScaleFactor]): 1693 16942012-06-29 Eric Seidel <eric@webkit.org> 1695 1696 Remove more BUILDING_ON_LEOPARD branches now that no port builds on Leopard 1697 https://bugs.webkit.org/show_bug.cgi?id=90252 1698 1699 Reviewed by Ryosuke Niwa. 1700 1701 * DefaultDelegates/WebDefaultContextMenuDelegate.mm: 1702 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): 1703 * Misc/WebNSControlExtras.m: 1704 (-[NSControl sizeToFitAndAdjustWindowHeight]): 1705 * WebCoreSupport/WebEditorClient.mm: 1706 (WebEditorClient::shouldEraseMarkersAfterChangeSelection): 1707 (WebEditorClient::getGuessesForWord): 1708 * WebCoreSupport/WebFrameLoaderClient.mm: 1709 (WebFrameLoaderClient::dispatchDidFirstLayout): 1710 (WebFrameLoaderClient::provisionalLoadStarted): 1711 * WebCoreSupport/WebSystemInterface.mm: 1712 (InitWebCoreSystemInterface): 1713 * WebView/WebDynamicScrollBarsView.mm: 1714 (-[WebDynamicScrollBarsView scrollWheel:]): 1715 * WebView/WebFullScreenController.mm: 1716 (-[WebFullScreenController finishedEnterFullScreenAnimation:]): 1717 (-[WebFullScreenController exitFullScreen]): 1718 * WebView/WebHTMLView.mm: 1719 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): 1720 * WebView/WebView.mm: 1721 (+[WebView initialize]): 1722 (-[WebView _deviceScaleFactor]): 1723 17242012-06-25 Mark Hahnenberg <mhahnenberg@apple.com> 1725 1726 JSLock should be per-JSGlobalData 1727 https://bugs.webkit.org/show_bug.cgi?id=89123 1728 1729 Reviewed by Geoffrey Garen. 1730 1731 Changed all sites that used JSLock to instead use the new JSLockHolder 1732 and pass in the correct JS context that the code is about to interact with that 1733 needs protection. Also added a couple JSLocks to places that didn't already 1734 have it that needed it. 1735 1736 * DOM/WebDOMOperations.mm: 1737 (JSC): 1738 * Misc/WebCoreStatistics.mm: 1739 (+[WebCoreStatistics javaScriptObjectsCount]): 1740 (+[WebCoreStatistics javaScriptGlobalObjectsCount]): 1741 (+[WebCoreStatistics javaScriptProtectedObjectsCount]): 1742 (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]): 1743 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): 1744 (+[WebCoreStatistics javaScriptObjectTypeCounts]): 1745 (+[WebCoreStatistics shouldPrintExceptions]): 1746 (+[WebCoreStatistics setShouldPrintExceptions:]): 1747 (+[WebCoreStatistics memoryStatistics]): 1748 (+[WebCoreStatistics javaScriptReferencedObjectsCount]): 1749 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 1750 (WebKit::NetscapePluginInstanceProxy::evaluate): 1751 (WebKit::NetscapePluginInstanceProxy::invoke): 1752 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 1753 (WebKit::NetscapePluginInstanceProxy::construct): 1754 (WebKit::NetscapePluginInstanceProxy::getProperty): 1755 (WebKit::NetscapePluginInstanceProxy::setProperty): 1756 (WebKit::NetscapePluginInstanceProxy::removeProperty): 1757 (WebKit::NetscapePluginInstanceProxy::hasMethod): 1758 (WebKit::NetscapePluginInstanceProxy::enumerate): 1759 (WebKit::NetscapePluginInstanceProxy::addValueToArray): 1760 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState): 1761 * Plugins/WebNetscapePluginStream.mm: 1762 (WebNetscapePluginStream::wantsAllStreams): 1763 * Plugins/WebNetscapePluginView.mm: 1764 (-[WebNetscapePluginView sendEvent:isDrawRect:]): 1765 (-[WebNetscapePluginView privateBrowsingModeDidChange]): 1766 (-[WebNetscapePluginView setWindowIfNecessary]): 1767 (-[WebNetscapePluginView createPluginScriptableObject]): 1768 (-[WebNetscapePluginView getFormValue:]): 1769 (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): 1770 (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): 1771 (-[WebNetscapePluginView loadPluginRequest:]): 1772 (-[WebNetscapePluginView _printedPluginBitmap]): 1773 * Plugins/WebPluginController.mm: 1774 (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): 1775 (-[WebPluginController stopOnePlugin:]): 1776 (-[WebPluginController destroyOnePlugin:]): 1777 (-[WebPluginController startAllPlugins]): 1778 (-[WebPluginController addPlugin:]): 1779 * WebView/WebFrame.mm: 1780 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): 1781 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): 1782 * WebView/WebScriptDebugDelegate.mm: 1783 (-[WebScriptCallFrame scopeChain]): 1784 (-[WebScriptCallFrame evaluateWebScript:]): 1785 * WebView/WebView.mm: 1786 (+[WebView _reportException:inContext:]): 1787 (-[WebView aeDescByEvaluatingJavaScriptFromString:]): 1788 (-[WebView _computedStyleIncludingVisitedInfo:forElement:]): 1789 17902012-06-23 Sheriff Bot <webkit.review.bot@gmail.com> 1791 1792 Unreviewed, rolling out r121058. 1793 http://trac.webkit.org/changeset/121058 1794 https://bugs.webkit.org/show_bug.cgi?id=89809 1795 1796 Patch causes plugins tests to crash in GTK debug builds 1797 (Requested by zdobersek on #webkit). 1798 1799 * DOM/WebDOMOperations.mm: 1800 (JSC): 1801 * Misc/WebCoreStatistics.mm: 1802 (+[WebCoreStatistics javaScriptObjectsCount]): 1803 (+[WebCoreStatistics javaScriptGlobalObjectsCount]): 1804 (+[WebCoreStatistics javaScriptProtectedObjectsCount]): 1805 (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]): 1806 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): 1807 (+[WebCoreStatistics javaScriptObjectTypeCounts]): 1808 (+[WebCoreStatistics shouldPrintExceptions]): 1809 (+[WebCoreStatistics setShouldPrintExceptions:]): 1810 (+[WebCoreStatistics memoryStatistics]): 1811 (+[WebCoreStatistics javaScriptReferencedObjectsCount]): 1812 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 1813 (WebKit::NetscapePluginInstanceProxy::evaluate): 1814 (WebKit::NetscapePluginInstanceProxy::invoke): 1815 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 1816 (WebKit::NetscapePluginInstanceProxy::construct): 1817 (WebKit::NetscapePluginInstanceProxy::getProperty): 1818 (WebKit::NetscapePluginInstanceProxy::setProperty): 1819 (WebKit::NetscapePluginInstanceProxy::removeProperty): 1820 (WebKit::NetscapePluginInstanceProxy::hasMethod): 1821 (WebKit::NetscapePluginInstanceProxy::enumerate): 1822 (WebKit::NetscapePluginInstanceProxy::addValueToArray): 1823 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState): 1824 * Plugins/WebNetscapePluginStream.mm: 1825 (WebNetscapePluginStream::wantsAllStreams): 1826 * Plugins/WebNetscapePluginView.mm: 1827 (-[WebNetscapePluginView sendEvent:isDrawRect:]): 1828 (-[WebNetscapePluginView privateBrowsingModeDidChange]): 1829 (-[WebNetscapePluginView setWindowIfNecessary]): 1830 (-[WebNetscapePluginView createPluginScriptableObject]): 1831 (-[WebNetscapePluginView getFormValue:]): 1832 (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): 1833 (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): 1834 (-[WebNetscapePluginView loadPluginRequest:]): 1835 (-[WebNetscapePluginView _printedPluginBitmap]): 1836 * Plugins/WebPluginController.mm: 1837 (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): 1838 (-[WebPluginController stopOnePlugin:]): 1839 (-[WebPluginController destroyOnePlugin:]): 1840 (-[WebPluginController startAllPlugins]): 1841 (-[WebPluginController addPlugin:]): 1842 * WebView/WebFrame.mm: 1843 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): 1844 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): 1845 * WebView/WebScriptDebugDelegate.mm: 1846 (-[WebScriptCallFrame scopeChain]): 1847 (-[WebScriptCallFrame evaluateWebScript:]): 1848 * WebView/WebView.mm: 1849 (+[WebView _reportException:inContext:]): 1850 (-[WebView aeDescByEvaluatingJavaScriptFromString:]): 1851 (-[WebView _computedStyleIncludingVisitedInfo:forElement:]): 1852 18532012-06-22 Alexandru Chiculita <achicu@adobe.com> 1854 1855 [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac 1856 https://bugs.webkit.org/show_bug.cgi?id=89781 1857 1858 Reviewed by Dean Jackson. 1859 1860 Added ENABLE_CSS_SHADERS flag as enabled by default on Safari for Mac. 1861 1862 * Configurations/FeatureDefines.xcconfig: 1863 18642012-06-20 Mark Hahnenberg <mhahnenberg@apple.com> 1865 1866 JSLock should be per-JSGlobalData 1867 https://bugs.webkit.org/show_bug.cgi?id=89123 1868 1869 Reviewed by Gavin Barraclough. 1870 1871 Changed all sites that used JSLock to instead use the new JSLockHolder 1872 and pass in the correct JS context that the code is about to interact with that 1873 needs protection. 1874 1875 * DOM/WebDOMOperations.mm: 1876 (JSC): 1877 * Misc/WebCoreStatistics.mm: 1878 (+[WebCoreStatistics javaScriptObjectsCount]): 1879 (+[WebCoreStatistics javaScriptGlobalObjectsCount]): 1880 (+[WebCoreStatistics javaScriptProtectedObjectsCount]): 1881 (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]): 1882 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): 1883 (+[WebCoreStatistics javaScriptObjectTypeCounts]): 1884 (+[WebCoreStatistics shouldPrintExceptions]): 1885 (+[WebCoreStatistics setShouldPrintExceptions:]): 1886 (+[WebCoreStatistics memoryStatistics]): 1887 (+[WebCoreStatistics javaScriptReferencedObjectsCount]): 1888 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 1889 (WebKit::NetscapePluginInstanceProxy::evaluate): 1890 (WebKit::NetscapePluginInstanceProxy::invoke): 1891 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 1892 (WebKit::NetscapePluginInstanceProxy::construct): 1893 (WebKit::NetscapePluginInstanceProxy::getProperty): 1894 (WebKit::NetscapePluginInstanceProxy::setProperty): 1895 (WebKit::NetscapePluginInstanceProxy::removeProperty): 1896 (WebKit::NetscapePluginInstanceProxy::hasMethod): 1897 (WebKit::NetscapePluginInstanceProxy::enumerate): 1898 (WebKit::NetscapePluginInstanceProxy::addValueToArray): 1899 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState): 1900 * Plugins/WebNetscapePluginStream.mm: 1901 (WebNetscapePluginStream::wantsAllStreams): 1902 * Plugins/WebNetscapePluginView.mm: 1903 (-[WebNetscapePluginView sendEvent:isDrawRect:]): 1904 (-[WebNetscapePluginView privateBrowsingModeDidChange]): 1905 (-[WebNetscapePluginView setWindowIfNecessary]): 1906 (-[WebNetscapePluginView createPluginScriptableObject]): 1907 (-[WebNetscapePluginView getFormValue:]): 1908 (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): 1909 (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): 1910 (-[WebNetscapePluginView loadPluginRequest:]): 1911 (-[WebNetscapePluginView _printedPluginBitmap]): 1912 * Plugins/WebPluginController.mm: 1913 (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): 1914 (-[WebPluginController stopOnePlugin:]): 1915 (-[WebPluginController destroyOnePlugin:]): 1916 (-[WebPluginController startAllPlugins]): 1917 (-[WebPluginController addPlugin:]): 1918 * WebView/WebFrame.mm: 1919 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): 1920 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): 1921 * WebView/WebScriptDebugDelegate.mm: 1922 (-[WebScriptCallFrame scopeChain]): 1923 (-[WebScriptCallFrame evaluateWebScript:]): 1924 * WebView/WebView.mm: 1925 (+[WebView _reportException:inContext:]): 1926 (-[WebView aeDescByEvaluatingJavaScriptFromString:]): 1927 (-[WebView _computedStyleIncludingVisitedInfo:forElement:]): 1928 19292012-06-22 Amy Ousterhout <aousterh@chromium.org> 1930 1931 Renamed DeviceOrientation to DeviceOrientationData 1932 https://bugs.webkit.org/show_bug.cgi?id=88663 1933 1934 Reviewed by Steve Block. 1935 1936 Updated files to use the renamed DeviceOrientationData instead of DeviceOrientation. 1937 This change makes DeviceOrientationData consistent with DeviceMotionData. 1938 * WebCoreSupport/WebDeviceOrientationClient.h: 1939 (WebDeviceOrientationClient): 1940 * WebCoreSupport/WebDeviceOrientationClient.mm: 1941 (WebDeviceOrientationClient::lastOrientation): 1942 * WebView/WebDeviceOrientation.mm: 1943 * WebView/WebDeviceOrientationInternal.h: 1944 19452012-06-20 Garret Kelly <gdk@chromium.org> 1946 1947 Moving cookieEnabled/setCookieEnabled from Page to Settings. 1948 https://bugs.webkit.org/show_bug.cgi?id=89545 1949 1950 Reviewed by Adam Barth. 1951 1952 * WebView/WebView.mm: 1953 (-[WebView _cookieEnabled]): 1954 (-[WebView _setCookieEnabled:]): 1955 19562012-06-19 Dan Bernstein <mitz@apple.com> 1957 1958 WebKit/mac part of: Paginated display API doesn’t allow setting the page progression direction 1959 https://bugs.webkit.org/show_bug.cgi?id=89394 1960 1961 Reviewed by Darin Adler. 1962 1963 * WebView/WebView.mm: 1964 (-[WebView _setPaginationMode:]): Changed to map new WebPaginationMode values to new 1965 Pagination::Mode values. 1966 (-[WebView _paginationMode]): Similarly, in the opposite direction. 1967 * WebView/WebViewPrivate.h: Replaced WebPaginationMode values with ones that specify an 1968 axis and a direction along that axis. 1969 19702012-06-18 Andy Estes <aestes@apple.com> 1971 1972 [Mac] -[WebPDFView _menuItemsFromPDFKitForEvent:] leaks NSMenuItems 1973 https://bugs.webkit.org/show_bug.cgi?id=89434 1974 1975 Reviewed by Darin Adler. 1976 1977 * WebView/WebPDFView.mm: 1978 (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Release copied 1979 NSMenuItems once they're stored in copiedItems. 1980 19812012-06-19 Mike West <mkwst@chromium.org> 1982 1983 Introduce ENABLE_CSP_NEXT configuration flag. 1984 https://bugs.webkit.org/show_bug.cgi?id=89300 1985 1986 Reviewed by Adam Barth. 1987 1988 The 1.0 draft of the Content Security Policy spec is just about to 1989 move to Last Call. We'll hide work on the upcoming 1.1 spec behind 1990 this ENABLE flag, disabled by default. 1991 1992 Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html 1993 1994 * Configurations/FeatureDefines.xcconfig: 1995 19962012-06-14 Jia Pu <jpu@apple.com> 1997 1998 Mark text with text alternative with blue underline. 1999 https://bugs.webkit.org/show_bug.cgi?id=83047 2000 2001 Reviewed by Enrica Casucci. 2002 2003 Changes in WebKit include implementation of new functions declared in AlternativeTextClient, 2004 and logic for calling Editor::insertDictatedText() instead of Editor::insertText() when there's 2005 alternatives attached to the input string. 2006 2007 * WebCoreSupport/CorrectionPanel.mm: 2008 (correctionIndicatorType): 2009 (CorrectionPanel::handleAcceptedReplacement): 2010 * WebCoreSupport/WebAlternativeTextClient.h: 2011 (WebAlternativeTextClient): 2012 * WebCoreSupport/WebAlternativeTextClient.mm: 2013 (WebAlternativeTextClient::showCorrectionAlternative): 2014 (WebAlternativeTextClient::dismissAlternative): 2015 (WebAlternativeTextClient::dismissAlternativeSoon): 2016 (WebAlternativeTextClient::recordAutocorrectionResponse): 2017 (WebAlternativeTextClient::removeDictationAlternatives): 2018 (WebAlternativeTextClient::showDictationAlternativeUI): 2019 (WebAlternativeTextClient::dismissDictationAlternativeUI): 2020 (WebAlternativeTextClient::dictationAlternatives): 2021 * WebView/WebHTMLView.mm: 2022 (-[WebHTMLView validAttributesForMarkedText]): 2023 (-[WebHTMLView insertText:]): 2024 * WebView/WebView.mm: 2025 (-[WebView handleAcceptedAlternativeText:]): 2026 (-[WebView _getWebCoreDictationAlternatives:fromTextAlternatives:]): 2027 (-[WebView _showDictationAlternativeUI:WebCore::forDictationContext:]): 2028 (-[WebView _dismissDictationAlternativeUI]): 2029 (-[WebView _removeDictationAlternatives:]): 2030 (-[WebView _dictationAlternatives:]): 2031 * WebView/WebViewData.h: 2032 * WebView/WebViewData.mm: 2033 (-[WebViewPrivate init]): 2034 * WebView/WebViewInternal.h: 2035 * WebView/WebViewPrivate.h: 2036 20372012-06-11 Alexis Menard <alexis.menard@openbossa.org> 2038 2039 [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag. 2040 https://bugs.webkit.org/show_bug.cgi?id=88804 2041 2042 Reviewed by Tony Chang. 2043 2044 Protect box-decoration-break behind a feature flag enabled by default. 2045 2046 * Configurations/FeatureDefines.xcconfig: 2047 20482012-06-11 Sam Weinig <sam@webkit.org> 2049 2050 Remove support for disconnected/excluded from search frames, they are not used by Safari anymore 2051 https://bugs.webkit.org/show_bug.cgi?id=88723 2052 2053 Reviewed by Dan Bernstein. 2054 2055 * WebView/WebFrame.mm: 2056 * WebView/WebFramePrivate.h: 2057 Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:] 2058 20592012-06-10 Sheriff Bot <webkit.review.bot@gmail.com> 2060 2061 Unreviewed, rolling out r119955. 2062 http://trac.webkit.org/changeset/119955 2063 https://bugs.webkit.org/show_bug.cgi?id=88758 2064 2065 Breaks Chromium compile - Chromium depends on removed API 2066 (Requested by dominicc on #webkit). 2067 2068 * WebView/WebFrame.mm: 2069 (-[WebFrame _setIsDisconnected:]): 2070 (-[WebFrame _setExcludeFromTextSearch:]): 2071 * WebView/WebFramePrivate.h: 2072 20732012-06-10 Sam Weinig <sam@webkit.org> 2074 2075 Remove support for disconnected/excluded from search frames, they are not used by Safari anymore 2076 https://bugs.webkit.org/show_bug.cgi?id=88723 2077 2078 Reviewed by Dan Bernstein. 2079 2080 * WebView/WebFrame.mm: 2081 * WebView/WebFramePrivate.h: 2082 Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:] 2083 20842012-06-09 Sukolsak Sakshuwong <sukolsak@google.com> 2085 2086 Add UNDO_MANAGER flag 2087 https://bugs.webkit.org/show_bug.cgi?id=87908 2088 2089 Reviewed by Tony Chang. 2090 2091 * Configurations/FeatureDefines.xcconfig: 2092 20932012-06-07 Kentaro Hara <haraken@chromium.org> 2094 2095 Reduce Node object size from 72 byte to 64 byte 2096 https://bugs.webkit.org/show_bug.cgi?id=88528 2097 2098 Reviewed by Ryosuke Niwa. 2099 2100 Added a symbol for callRemovedLastRef(). 2101 2102 * WebKit.order: 2103 21042012-06-06 Andy Estes <aestes@apple.com> 2105 2106 Wrap uppercaseWord, lowercaseWord, and capitalizeWord with USE(APPKIT) 2107 https://bugs.webkit.org/show_bug.cgi?id=88504 2108 2109 Reviewed by Dan Bernstein. 2110 2111 uppercaseWord, lowercaseWord, and capitalizeWord are methods declared 2112 by NSResponder that subclasses are expected to implement. WebKit should 2113 only support these implementations on platforms that use AppKit. 2114 2115 * WebCoreSupport/WebEditorClient.h: 2116 * WebCoreSupport/WebEditorClient.mm: 2117 21182012-06-05 Anders Carlsson <andersca@apple.com> 2119 2120 Build fix. 2121 2122 * WebCoreSupport/WebFrameLoaderClient.mm: 2123 (WebFrameLoaderClient::createPlugin): 2124 The error constant has been renamed. 2125 21262012-06-05 Anders Carlsson <andersca@apple.com> 2127 2128 Rename a plug-in loading error constant 2129 https://bugs.webkit.org/show_bug.cgi?id=88381 2130 <rdar://problem/11602601> 2131 2132 Reviewed by Sam Weinig. 2133 2134 * Misc/WebKitErrors.h: 2135 21362012-06-05 Dongwoo Im <dw.im@samsung.com> 2137 2138 Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'. 2139 https://bugs.webkit.org/show_bug.cgi?id=73176 2140 2141 Reviewed by Adam Barth. 2142 2143 Two more APIs are added in Custom Scheme Handler specification. 2144 http://dev.w3.org/html5/spec/Overview.html#custom-handlers 2145 One is 'isProtocolHandlerRegistered' to query whether the specific URL 2146 is registered or not. 2147 The other is 'unregisterProtocolHandler' to remove the registered URL. 2148 2149 * Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'. 2150 21512012-06-04 David Kilzer <ddkilzer@apple.com> 2152 2153 BUILD FIX: FeatureDefines.xcconfig should match across projects 2154 2155 * Configurations/FeatureDefines.xcconfig: 2156 - Fix sort order of ENABLE_CSS3_FLEXBOX. 2157 - Fix typo in ENABLE_FONT_BOOSTING. 2158 - Add missing ENABLE_LEGACY_CSS_VENDOR_PREFIXES. 2159 21602012-06-02 Yongjun Zhang <yongjun_zhang@apple.com> 2161 2162 loadRequest should check for empty URLs. 2163 https://bugs.webkit.org/show_bug.cgi?id=88154 2164 2165 In [WebFrame loadRequest], if the url is invalid and not nil, we transform it to file: url. 2166 However, WebKit client could send down an empty URL that makes us transform it to file: url 2167 as well. We should skip that as we did for nil URLs. 2168 2169 Reviewed by Brady Eidson. 2170 2171 * WebView/WebFrame.mm: 2172 (-[WebFrame loadRequest:]): 2173 21742012-06-01 Michael Saboff <msaboff@apple.com> 2175 2176 WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string 2177 https://bugs.webkit.org/show_bug.cgi?id=88109 2178 2179 Reviewed by Geoffrey Garen. 2180 2181 Added short circuit return when the NSString to evaluate is nil. 2182 2183 * WebView/WebFrame.mm: 2184 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): 2185 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): 2186 21872012-05-31 Hajime Morrita <morrita@chromium.org> 2188 2189 REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac 2190 https://bugs.webkit.org/show_bug.cgi?id=86859 2191 2192 Reviewed by Ryosuke Niwa. 2193 2194 * WebCoreSupport/WebEditorClient.h: 2195 * WebCoreSupport/WebEditorClient.mm: 2196 (-[WebEditorSpellCheckResponder initWithClient:sequence:results:]): 2197 (-[WebEditorSpellCheckResponder perform]): 2198 (WebEditorClient::didCheckSucceeded): 2199 (WebEditorClient::requestCheckingOfString): 2200 22012012-05-31 Andy Estes <aestes@apple.com> 2202 2203 Disentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that which merely relies on PLATFORM(MAC) 2204 https://bugs.webkit.org/show_bug.cgi?id=87933 2205 2206 Reviewed by Dan Bernstein. 2207 2208 * WebCoreSupport/WebEditorClient.h: 2209 * WebCoreSupport/WebEditorClient.mm: 2210 22112012-05-29 David Barr <davidbarr@chromium.org> 2212 2213 Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag 2214 https://bugs.webkit.org/show_bug.cgi?id=87685 2215 2216 Reviewed by Eric Seidel. 2217 2218 Add a configuration option for CSS image-resolution support, disabling it by default. 2219 2220 * Configurations/FeatureDefines.xcconfig: 2221 22222012-05-29 Nikolas Zimmermann <nzimmermann@rim.com> 2223 2224 SVGViewSpec DOM bindings aka SVGSVGElement.currentView is unimplemented 2225 https://bugs.webkit.org/show_bug.cgi?id=15495 2226 2227 Reviewed by Rob Buis. 2228 2229 * MigrateHeaders.make: Copy DOMSVGViewSpec*.h headers. 2230 22312012-05-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 2232 2233 WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled 2234 https://bugs.webkit.org/show_bug.cgi?id=42328 2235 2236 Reviewed by Eric Seidel. 2237 2238 * WebInspector/WebInspector.mm: 2239 (-[WebInspector setJavaScriptProfilingEnabled:]): 2240 22412012-05-24 Tim Horton <timothy_horton@apple.com> 2242 2243 Add feature defines for web-facing parts of CSS Regions and Exclusions 2244 https://bugs.webkit.org/show_bug.cgi?id=87442 2245 <rdar://problem/10887709> 2246 2247 Reviewed by Dan Bernstein. 2248 2249 * Configurations/FeatureDefines.xcconfig: 2250 22512012-05-24 John Mellor <johnme@chromium.org> 2252 2253 Font Boosting: Add compile flag and runtime setting 2254 https://bugs.webkit.org/show_bug.cgi?id=87394 2255 2256 Reviewed by Adam Barth. 2257 2258 Add ENABLE_FONT_BOOSTING. 2259 2260 * Configurations/FeatureDefines.xcconfig: 2261 22622012-05-23 Ojan Vafai <ojan@chromium.org> 2263 2264 add back the ability to disable flexbox 2265 https://bugs.webkit.org/show_bug.cgi?id=87147 2266 2267 Reviewed by Tony Chang. 2268 2269 * Configurations/FeatureDefines.xcconfig: 2270 22712012-05-22 Tim Horton <timothy_horton@apple.com> 2272 2273 Add a quirk for applications that depend on the relative ordering of progressCompleted/didFinishLoad 2274 https://bugs.webkit.org/show_bug.cgi?id=87178 2275 <rdar://problem/11468434> 2276 2277 Reviewed by Maciej Stachowiak. 2278 2279 Add plumbing for the quirk to flip the relative ordering of progressCompleted/didFinishLoad back 2280 to the behavior before http://trac.webkit.org/changeset/94105. Make it apply to any Mail.app linked 2281 against WebKit before that revision. 2282 2283 * Misc/WebKitVersionChecks.h: 2284 * WebView/WebView.mm: 2285 (-[WebView _needsDidFinishLoadOrderQuirk]): 2286 (-[WebView _preferencesChanged:]): 2287 22882012-05-21 Gavin Barraclough <barraclough@apple.com> 2289 2290 Disable private names by default in WebCore 2291 https://bugs.webkit.org/show_bug.cgi?id=87088 2292 2293 Reviewed by Geoff Garen. 2294 2295 r117859 introduced a preliminary implementation of ES6-like private name objects to JSC. 2296 These are probably not yet ready to be web-facing, so disabling by default in WebCore. 2297 Opting-in for JSC & DumpRenderTree so that we can still run the fast/js/names.html test. 2298 2299 * WebView/WebPreferenceKeysPrivate.h: 2300 * WebView/WebPreferences.mm: 2301 (+[WebPreferences initialize]): 2302 (-[WebPreferences setJavaScriptExperimentsEnabled:]): 2303 (-[WebPreferences javaScriptExperimentsEnabled]): 2304 * WebView/WebPreferencesPrivate.h: 2305 * WebView/WebView.mm: 2306 (-[WebView _preferencesChanged:]): 2307 - Added JavaScriptExperimentsEnabled to WebPreferences. 2308 23092012-05-15 Gavin Barraclough <barraclough@apple.com> 2310 2311 Add support for private names 2312 https://bugs.webkit.org/show_bug.cgi?id=86509 2313 2314 Reviewed by Oliver Hunt. 2315 2316 The spec isn't final, but we can start adding support to allow property maps 2317 to contain keys that aren't identifiers. 2318 2319 * Plugins/Hosted/ProxyInstance.mm: 2320 (WebKit::ProxyClass::methodsNamed): 2321 (WebKit::ProxyClass::fieldNamed): 2322 (WebKit::ProxyInstance::getMethod): 2323 (WebKit::ProxyInstance::methodsNamed): 2324 (WebKit::ProxyInstance::fieldNamed): 2325 - Removed PropertyName::impl(), call publicName() to get the string associated with a name. 2326 23272012-05-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> 2328 2329 Move setEditingBehavior() from layoutTestController to window.internals 2330 https://bugs.webkit.org/show_bug.cgi?id=42689 2331 2332 Reviewed by Hajime Morita and Kenneth Rohde Christiansen. 2333 2334 Remove Mac private API to get/set the editing behavior, since it was only there 2335 for the DRT. 2336 2337 * WebKit.order: 2338 * WebView/WebFrame.mm: 2339 * WebView/WebFrameInternal.h: 2340 * WebView/WebPreferenceKeysPrivate.h: 2341 * WebView/WebPreferences.mm: 2342 (+[WebPreferences initialize]): 2343 * WebView/WebPreferencesPrivate.h: 2344 * WebView/WebView.mm: 2345 (-[WebView _preferencesChanged:]): 2346 23472012-05-20 Ryosuke Niwa <rniwa@webkit.org> 2348 2349 Using createContextualFragment to insert a <script> does not cause the script to execute 2350 https://bugs.webkit.org/show_bug.cgi?id=12234 2351 2352 Reviewed by Adam Barth. 2353 2354 Renamed FragmentScriptingNotAllowed to DisallowScriptingContent. 2355 2356 * WebView/WebFrame.mm: 2357 (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): 2358 23592012-05-19 Andy Estes <aestes@apple.com> 2360 2361 Fix build errors found when disabling ENABLE_DRAG_SUPPORT 2362 https://bugs.webkit.org/show_bug.cgi?id=86947 2363 2364 Reviewed by Jon Honeycutt. 2365 2366 * WebCoreSupport/WebDragClient.h: 2367 * WebCoreSupport/WebDragClient.mm: 2368 * WebView/WebFrame.mm: 2369 * WebView/WebFrameInternal.h: 2370 * WebView/WebFrameView.mm: 2371 (-[WebFrameView _setDocumentView:]): 2372 * WebView/WebHTMLView.mm: 2373 (-[WebHTMLView acceptsFirstMouse:]): 2374 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): 2375 (matchesExtensionOrEquivalent): 2376 * WebView/WebView.mm: 2377 (-[WebView _commonInitializationWithFrameName:groupName:]): 2378 (-[WebView moveDragCaretToPoint:]): 2379 (-[WebView removeDragCaret]): 2380 23812012-04-27 Filip Pizlo <fpizlo@apple.com> 2382 2383 DFG should have control flow graph simplification 2384 https://bugs.webkit.org/show_bug.cgi?id=84553 2385 2386 Reviewed by Oliver Hunt. 2387 2388 Merged r115512 from dfgopt. 2389 2390 JSValue::toBoolean(ExecState*) -> JSValue::toBoolean() 2391 2392 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 2393 (WebKit::NetscapePluginInstanceProxy::addValueToArray): 2394 23952012-05-18 Tony Chang <tony@chromium.org> 2396 2397 remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off 2398 https://bugs.webkit.org/show_bug.cgi?id=86767 2399 2400 Reviewed by Ojan Vafai. 2401 2402 * Configurations/FeatureDefines.xcconfig: 2403 * WebView/WebPreferenceKeysPrivate.h: 2404 * WebView/WebPreferences.mm: 2405 (+[WebPreferences initialize]): 2406 (-[WebPreferences cssGridLayoutEnabled]): 2407 (-[WebPreferences setCSSGridLayoutEnabled:]): 2408 * WebView/WebPreferencesPrivate.h: 2409 * WebView/WebView.mm: 2410 (-[WebView _preferencesChanged:]): 2411 24122012-05-18 MORITA Hajime <morrita@google.com> 2413 2414 Another unreviewed attempt to fix build breakage on r117572. 2415 2416 * WebCoreSupport/WebEditorClient.h: 2417 24182012-05-18 MORITA Hajime <morrita@google.com> 2419 2420 https://bugs.webkit.org/show_bug.cgi?id=85515 2421 Stale frame in WebCore::SpellChecker::didCheckSucceeded 2422 2423 Reviewed by Ryosuke Niwa. 2424 2425 * WebCoreSupport/WebEditorClient.h: 2426 24272012-05-17 Andy Estes <aestes@apple.com> 2428 2429 Don't let -[CALayer renderInContext:] try to render WebView's root layer 2430 https://bugs.webkit.org/show_bug.cgi?id=86773 2431 <rdar://problem/10950075> 2432 2433 Reviewed by Dan Bernstein. 2434 2435 -[CALayer renderInContext:] doesn't correctly render our layer tree, so 2436 don't let it try. Calling drawRect: with a bitmap context will already 2437 do the right thing for WebViews. 2438 2439 * WebView/WebHTMLView.mm: Create a subclass of CALayer called WebLayerHostingLayer. 2440 (-[WebLayerHostingLayer renderInContext:]): override renderInContext: to be a NOOP. 2441 (-[WebHTMLView attachRootLayer:]): Create a WebLayerHostingLayer rather than a CALayer. 2442 24432012-05-17 Hironori Bono <hbono@chromium.org> 2444 2445 [Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer 2446 https://bugs.webkit.org/show_bug.cgi?id=86591 2447 2448 Reviewed by Ryosuke Niwa. 2449 2450 This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection 2451 function to remove platform-specific code from Editor::respondToChangedSelection 2452 function. 2453 2454 No new tests, no change in behavior. 2455 2456 * WebCoreSupport/WebEditorClient.h: 2457 * WebCoreSupport/WebEditorClient.mm: 2458 (WebEditorClient::shouldEraseMarkersAfterChangeSelection): 2459 24602012-05-17 Dan Bernstein <mitz@apple.com> 2461 2462 REGRESSION (r117428): WebKit API/SPI was removed 2463 https://bugs.webkit.org/show_bug.cgi?id=86748 2464 2465 Reverted r117428. 2466 2467 * WebKit.order: 2468 * WebView/WebView.mm: 2469 (+[WebView _setDomainRelaxationForbidden:forURLScheme:]): 2470 * WebView/WebViewPrivate.h: 2471 24722012-05-17 Gyuyoung Kim <gyuyoung.kim@samsung.com> 2473 2474 Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface 2475 https://bugs.webkit.org/show_bug.cgi?id=86704 2476 2477 Reviewed by Eric Seidel. 2478 2479 Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the 2480 cross-port way through the InternalSettings interface. 2481 2482 * WebKit.order: 2483 * WebView/WebView.mm: 2484 * WebView/WebViewPrivate.h: 2485 24862012-05-15 Anders Carlsson <andersca@apple.com> 2487 2488 Use unaccelerated scrolling deltas when rubber-banding 2489 https://bugs.webkit.org/show_bug.cgi?id=86503 2490 <rdar://problem/11378742> 2491 2492 Reviewed by Sam Weinig. 2493 2494 * WebCoreSupport/WebSystemInterface.mm: 2495 (InitWebCoreSystemInterface): 2496 Init new WKSI functions. 2497 24982012-05-14 Luke Macpherson <macpherson@chromium.org> 2499 2500 Introduce ENABLE_CSS_VARIABLES compile flag. 2501 https://bugs.webkit.org/show_bug.cgi?id=86338 2502 2503 Reviewed by Dimitri Glazkov. 2504 2505 Add a configuration option for CSS Variables support, disabling it by default. 2506 2507 * Configurations/FeatureDefines.xcconfig: 2508 25092012-05-14 Michael Saboff <msaboff@apple.com> 2510 2511 Enh: Add the Ability to Disable / Enable JavaScript GC Timer 2512 https://bugs.webkit.org/show_bug.cgi?id=86382 2513 2514 Reviewed by Darin Adler. 2515 2516 Plumbing to set / clear JS GC activity timer enable flag. 2517 2518 * Misc/WebCoreStatistics.h: 2519 * Misc/WebCoreStatistics.mm: 2520 (+[WebCoreStatistics setJavaScriptGarbageCollectorTimerEnabled:]): 2521 25222012-05-11 Gavin Barraclough <barraclough@apple.com> 2523 2524 Introduce PropertyName class 2525 https://bugs.webkit.org/show_bug.cgi?id=86241 2526 2527 Reviewed by Geoff Garen. 2528 2529 Replace 'const Identifier&' arguments to functions accessing object properties with a new 'PropertyName' type. 2530 This change paves the way to allow for properties keyed by values that are not Identifiers. 2531 2532 This change is largely a mechanical find & replace. 2533 It also changes JSFunction's constructor to take a UString& instead of an Identifier& 2534 (since in some cases we can no longer guarantee that we'lll have an Identifier), and 2535 unifies Identifier's methods to obtain array indices onto PropertyName. 2536 2537 The new PropertyName class retains the ability to support .impl() and .ustring(), but 2538 in a future patch we may need to rework this, since not all PropertyNames should be 2539 equal based on their string representation. 2540 2541 * Plugins/Hosted/ProxyInstance.h: 2542 (ProxyInstance): 2543 * Plugins/Hosted/ProxyInstance.mm: 2544 (ProxyClass): 2545 (WebKit::ProxyClass::methodsNamed): 2546 (WebKit::ProxyClass::fieldNamed): 2547 (WebKit::ProxyRuntimeMethod::create): 2548 (WebKit::ProxyRuntimeMethod::finishCreation): 2549 (WebKit::ProxyInstance::getMethod): 2550 (WebKit::ProxyInstance::methodsNamed): 2551 (WebKit::ProxyInstance::fieldNamed): 2552 25532012-05-11 Brady Eidson <beidson@apple.com> 2554 2555 <rdar://problem/11361907> and https://bugs.webkit.org/show_bug.cgi?id=86265 2556 REGRESSION(r104885): Images missing from printed YummySoup! recipes 2557 2558 We thought clients were passing paths as URLs. 2559 It turns out it was more likely they were passing file: URLs with the file: scheme removed. 2560 And that jives perfectly with the behavior change caused by r104885. 2561 2562 Reviewed by Alexey Proskuryakov. 2563 2564 Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrSchemelessFileURL, and change it 2565 to create the new URL simply by appending "file:": 2566 * Misc/WebNSURLExtras.h: 2567 * Misc/WebNSURLExtras.mm: 2568 (-[NSURL _webkit_URLFromURLOrSchemelessFileURL]): 2569 2570 * WebView/WebFrame.mm: 2571 (-[WebFrame loadRequest:]): Create the fixed url simply by appending "file:" to the 2572 existing URL string. 2573 (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): 2574 (-[WebFrame loadHTMLString:baseURL:]): 2575 (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): 2576 25772012-05-10 Gyuyoung Kim <gyuyoung.kim@samsung.com> 2578 2579 Move resumeAnimations to use Internals interface 2580 https://bugs.webkit.org/show_bug.cgi?id=86063 2581 2582 Reviewed by Alexey Proskuryakov. 2583 2584 Remove resumeAnimations functions, because it is able to work in the 2585 cross-port way through the Internals interface. 2586 2587 * WebKit.order: 2588 * WebView/WebFrame.mm: 2589 * WebView/WebFramePrivate.h: 2590 25912012-05-10 Anders Carlsson <andersca@apple.com> 2592 2593 WebKit1: Add a way to blacklist specific plug-ins/plug-in versions 2594 https://bugs.webkit.org/show_bug.cgi?id=86150 2595 <rdar://problem/9551196> 2596 2597 Reviewed by Sam Weinig. 2598 2599 * Misc/WebKitErrors.h: 2600 Add WebKitErrorInsecurePlugInVersion enum. 2601 2602 * Plugins/WebBasePluginPackage.h: 2603 * Plugins/WebBasePluginPackage.mm: 2604 (-[WebBasePluginPackage bundleIdentifier]): 2605 (-[WebBasePluginPackage bundleVersion]): 2606 Add bundleIdentifier and bundleVersion getters. 2607 2608 * WebCoreSupport/WebFrameLoaderClient.mm: 2609 (WebFrameLoaderClient::createPlugin): 2610 Check if the plug-in is blocked. If it is, set the unavailability reason and the error code. 2611 26122012-05-10 Anders Carlsson <andersca@apple.com> 2613 2614 Rename the missing plug-in indicator to the unavailable plug-in indicator 2615 https://bugs.webkit.org/show_bug.cgi?id=86136 2616 2617 Reviewed by Sam Weinig. 2618 2619 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 2620 (-[WebHostedNetscapePluginView pluginHostDied]): 2621 * WebCoreSupport/WebChromeClient.h: 2622 * WebCoreSupport/WebChromeClient.mm: 2623 (WebChromeClient::shouldUnavailablePluginMessageBeButton): 2624 (WebChromeClient::unavailablePluginButtonClicked): 2625 26262012-05-09 Gyuyoung Kim <gyuyoung.kim@samsung.com> 2627 2628 Move suspendAnimations to use Internals interface. 2629 https://bugs.webkit.org/show_bug.cgi?id=85986 2630 2631 Reviewed by Ryosuke Niwa. 2632 2633 Remove suspendAnimations functions, because it is able to work in the 2634 cross-port way through the Internals interface. 2635 2636 * WebKit.order: 2637 * WebView/WebFrame.mm: 2638 * WebView/WebFramePrivate.h: 2639 26402012-05-08 Kent Tamura <tkent@chromium.org> 2641 2642 Fixe Chromium build, and add a FIXME comment about a layering violation. 2643 2644 * WebCoreSupport/WebSystemInterface.mm: 2645 (InitWebCoreSystemInterface): 2646 26472012-05-08 Jon Lee <jonlee@apple.com> 2648 2649 Safari warns that it needs to resend the form in an iFrame when going back 2650 https://bugs.webkit.org/show_bug.cgi?id=82658 2651 <rdar://problem/11292558> 2652 2653 Reviewed by Darin Adler. 2654 2655 * WebCoreSupport/WebSystemInterface.mm: 2656 (InitWebCoreSystemInterface): Add wkCFURLRequestAllowAllPostCaching. 2657 26582012-05-08 Timothy Hatcher <timothy@apple.com> 2659 2660 Fix the SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL macro so it passes the full path to dlopen. 2661 2662 <rdar://problem/11406517> 2663 2664 Reviewed by Mark Rowe. 2665 2666 * WebCoreSupport/WebInspectorClient.mm: Pass A to SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL for the version. 2667 26682012-05-07 Andy Estes <aestes@apple.com> 2669 2670 ENABLE_IFRAME_SEAMLESS should be part of FEATURE_DEFINES. 2671 2672 * Configurations/FeatureDefines.xcconfig: 2673 26742012-05-07 Eric Seidel <eric@webkit.org> 2675 2676 Add ENABLE_IFRAME_SEAMLESS so Apple can turn off SEAMLESS if needed 2677 https://bugs.webkit.org/show_bug.cgi?id=85822 2678 2679 Reviewed by Adam Barth. 2680 2681 * Configurations/FeatureDefines.xcconfig: 2682 26832012-05-05 Dean Jackson <dino@apple.com> 2684 2685 Add new Setting/Preference to disable requestAnimationFrame 2686 https://bugs.webkit.org/show_bug.cgi?id=85693 2687 2688 Reviewed by Simon Fraser. 2689 2690 Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled. 2691 The default value is true. The majority of applications will leave 2692 it this way. 2693 2694 * WebView/WebPreferenceKeysPrivate.h: 2695 * WebView/WebPreferences.mm: 2696 (+[WebPreferences initialize]): 2697 (-[WebPreferences requestAnimationFrameEnabled]): 2698 (-[WebPreferences setRequestAnimationFrameEnabled:]): 2699 * WebView/WebPreferencesPrivate.h: 2700 * WebView/WebView.mm: 2701 (-[WebView _preferencesChanged:]): 2702 27032012-05-04 Jer Noble <jer.noble@apple.com> 2704 2705 REGRESSION (r116127-r116165): 6 tests failing on Lion Debug (Tests) 2706 https://bugs.webkit.org/show_bug.cgi?id=85674 2707 2708 Reviewed by Oliver Hunt. 2709 2710 Null check the results of core([frame DOMDocument]). 2711 2712 * WebView/WebView.mm: 2713 (-[WebView _didStartProvisionalLoadForFrame:]): 2714 27152012-05-02 Jer Noble <jer.noble@apple.com> 2716 2717 Taking a visibility:hidden element full screen causes full screen window to disappear. 2718 https://bugs.webkit.org/show_bug.cgi?id=85432 2719 2720 Reviewed by Maciej Stachowiak. 2721 2722 When given an initial or final frame with a zero width or height, return a rect representing 2723 the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will 2724 confuse the window server when it's instructed to scale the full screen window to that size. 2725 2726 * WebView/WebFullScreenController.mm: 2727 (windowFrameFromApparentFrames): 2728 27292012-05-04 Jer Noble <jer.noble@apple.com> 2730 2731 Full screen will exit during a provisional load of a non-ancestor iframe. 2732 https://bugs.webkit.org/show_bug.cgi?id=85230 2733 2734 Reviewed by Maciej Stachowiak . 2735 2736 Only exit full screen mode if the frame being loaded contains the full 2737 screen element. 2738 2739 * WebView/WebView.mm: 2740 (-[WebView _didStartProvisionalLoadForFrame:]): Give the UIDelegate a first crack at handling the 2741 request to close the full screen window when a provisional load occurs. 2742 27432012-05-04 Jer Noble <jer.noble@apple.com> 2744 2745 Move WebKitFullScreenListener into its own file. 2746 https://bugs.webkit.org/show_bug.cgi?id=85640 2747 2748 Reviewed by Maciej Stachowiak. 2749 2750 Move WebKitFullScreenListener into its own file, so it can be used by multiple classes. 2751 2752 * WebCoreSupport/WebKitFullScreenListener.h: Added. 2753 * WebCoreSupport/WebKitFullScreenListener.mm: Added. 2754 (-[WebKitFullScreenListener webkitWillEnterFullScreen]): 2755 (-[WebKitFullScreenListener webkitDidEnterFullScreen]): 2756 (-[WebKitFullScreenListener webkitWillExitFullScreen]): 2757 (-[WebKitFullScreenListener webkitDidExitFullScreen]): 2758 * WebCoreSupport/WebChromeClient.mm: 2759 27602012-05-04 Brady Eidson <beidson@apple.com> 2761 2762 <rdar://problem/11312853> and https://bugs.webkit.org/show_bug.cgi?id=85635 2763 Exception in [WebFrame loadRequest:] breaks some WebKit apps 2764 2765 Reviewed by Alexey Proskuryakov. 2766 2767 Some API clients pass in nil requests or requests with nil URLs. 2768 In r112571 we started rewriting these URLs resulting in an exception. 2769 Since we've supported nil requests until now, we should not try to rewrite these URLs. 2770 2771 * WebView/WebFrame.mm: 2772 (-[WebFrame loadRequest:]): Don't try to rewrite invalid URLs if they are also null. 2773 27742012-05-04 Nate Chapin <japhet@chromium.org> 2775 2776 Don't require FrameLoaderClient to manufacture a commitData() call for empty documents. 2777 https://bugs.webkit.org/show_bug.cgi?id=85533 2778 2779 Reviewed by Alexey Proskuryakov. 2780 2781 * WebView/WebHTMLRepresentation.mm: 2782 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Calling commitData when finishing is no longer necessary, 2783 as WebCore will take care of simulating the receipt of data and ensuring the requisite work gets done in the blank document case. 2784 27852012-05-03 Anders Carlsson <andersca@apple.com> 2786 2787 useWebKitWebInspector should be more robust against missing files 2788 https://bugs.webkit.org/show_bug.cgi?id=85563 2789 <rdar://problem/11373948> 2790 2791 Reviewed by Dan Bernstein. 2792 2793 * WebCoreSupport/WebInspectorClient.mm: 2794 (useWebKitWebInspector): 2795 27962012-05-03 Tobias Netzel <tobias.netzel@googlemail.com> 2797 2798 Bugs in WebFullScreenController 2799 https://bugs.webkit.org/show_bug.cgi?id=85388 2800 2801 Reviewed by Alexey Proskuryakov. 2802 2803 Leopard specific fixes: 2804 NSWindow doesn't respond to isOnActiveSpace so find out first. 2805 Values passed to SetSystemUIMode were swapped. 2806 2807 * WebView/WebFullScreenController.mm: 2808 (-[WebFullScreenController exitFullScreen]): 2809 (-[WebFullScreenController _updateMenuAndDockForFullScreen]): 2810 28112012-05-02 Jon Lee <jonlee@apple.com> 2812 2813 Migrate permission functions to Notification from NotificationCenter 2814 https://bugs.webkit.org/show_bug.cgi?id=80485 2815 <rdar://problem/10965458> 2816 2817 Reviewed by Jian Li. 2818 2819 * WebCoreSupport/WebNotificationClient.h: * 2820 WebCoreSupport/WebNotificationClient.mm: Add a separate callback 2821 variable depending on the notifications API enabled. 2822 (WebNotificationClient::requestPermission): Add 2823 NotificationPermissionCallback version of the same 2824 function. And refactor common code into private function. 2825 (-[WebNotificationPolicyListener initWithCallback:]): Refactor to 2826 take the NotificationPermissionCallback as a parameter. 2827 (-[WebNotificationPolicyListener initWithVoidCallback:]): Add new 2828 init method to handle legacy API. 2829 (-[WebNotificationPolicyListener allow]): Invoke the callback for 2830 both variables. If only one of the APIs is enabled, we are 2831 guaranteed that the relevant callback variable exists. If both 2832 APIs are supported, it is possible that _voidCallback will be nil 2833 if the callback is NotificationPermissionCallback, so we need the 2834 extra pointer check. 2835 (-[WebNotificationPolicyListener deny]): Ditto. 2836 28372012-05-02 Eric Seidel <eric@webkit.org> 2838 2839 Sort ENABLE_ defines in FeatureDefines.xcconfig files to make them easier to compare with one another (and easier to autogenerate) 2840 https://bugs.webkit.org/show_bug.cgi?id=85433 2841 2842 Reviewed by Adam Barth. 2843 2844 I have a script which can autogenerate these xcconfig files as well as the 2845 vsprops files (and soon the Chromium, cmake, gnumake and qmake) feature lists 2846 from a central feature list file. 2847 In preparation for posting such a tool, I'm re-sorting these xcconfig files to be 2848 alphabetically ordered (currently they're close, but not quite). 2849 There is also at least one inconsistency between these files (CSS_LEGACY_PREFIXES) which 2850 I will fix in a second pass. I will also sort the FEATURE_DEFINES = line in a follow-up patch. 2851 2852 * Configurations/FeatureDefines.xcconfig: 2853 28542012-04-18 Jon Honeycutt <jhoneycutt@apple.com> 2855 2856 FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more 2857 information about the form being submitted 2858 https://bugs.webkit.org/show_bug.cgi?id=84297 2859 2860 Reviewed by Andy Estes. 2861 2862 * WebCoreSupport/WebFrameLoaderClient.h: 2863 Updated method declaration. 2864 28652012-05-01 Jon Honeycutt <jhoneycutt@apple.com> 2866 2867 Make Page::setDefersLoading() have a call count so that each time 2868 loading is deferred, it must be balanced with a call to resume. 2869 https://bugs.webkit.org/show_bug.cgi?id=84522 2870 2871 Reviewed by Andy Estes. 2872 2873 * WebView/WebPreferenceKeysPrivate.h: 2874 Declare a new key for this preference. 2875 2876 * WebView/WebPreferences.mm: 2877 (+[WebPreferences initialize]): 2878 Initialize new preference to NO. 2879 (-[WebPreferences setWantsBalancedSetDefersLoadingBehavior:]): 2880 Setter. 2881 (-[WebPreferences wantsBalancedSetDefersLoadingBehavior]): 2882 Getter. 2883 2884 * WebView/WebPreferencesPrivate.h: 2885 Declare setter and getter. 2886 2887 * WebView/WebView.mm: 2888 (-[WebView _preferencesChanged:]): 2889 Set the setting from the WebPreferences object's value. 2890 28912012-05-01 Jeffrey Pfau <jpfau@apple.com> 2892 2893 <rdar://problem/10422318> Support for web content filter delegate for filtering https content 2894 https://bugs.webkit.org/show_bug.cgi?id=85300 2895 2896 Reviewed by Alexey Proskuryakov. 2897 2898 * WebCoreSupport/WebSystemInterface.mm: 2899 (InitWebCoreSystemInterface): 2900 29012012-05-01 Ryosuke Niwa <rniwa@webkit.org> 2902 2903 *Command.h files shouldn't be exported to WebKit layer 2904 https://bugs.webkit.org/show_bug.cgi?id=74778 2905 2906 Reviewed by Eric Seidel. 2907 2908 * WebView/WebFrame.mm: 2909 (-[WebFrame _insertParagraphSeparatorInQuotedContent]): 2910 29112012-04-28 Geoffrey Garen <ggaren@apple.com> 2912 2913 Clarified JSGlobalData (JavaScript VM) lifetime 2914 https://bugs.webkit.org/show_bug.cgi?id=85142 2915 2916 Reviewed by Anders Carlsson. 2917 2918 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 2919 (WebKit::NetscapePluginInstanceProxy::invoke): 2920 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 2921 (WebKit::NetscapePluginInstanceProxy::construct): 2922 29232012-04-27 Gavin Peters <gavinp@chromium.org> 2924 2925 Add new ENABLE_LINK_PRERENDER define to control the Prerendering API 2926 https://bugs.webkit.org/show_bug.cgi?id=84871 2927 2928 Reviewed by Adam Barth. 2929 2930 Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering 2931 API separates it from prefetching. Having separate include guards lets ports enable prefetching, 2932 a relatively easy change, without needing to build the infrastructure for prerendering, which 2933 is considerably more complicated. 2934 29352012-04-26 Jon Lee <jonlee@apple.com> 2936 2937 [WK2] AlternativeTextClient leaks when the page is destroyed 2938 https://bugs.webkit.org/show_bug.cgi?id=84307 2939 <rdar://problem/11328431> 2940 2941 Reviewed by Enrica Casucci. 2942 2943 * WebCoreSupport/WebAlternativeTextClient.h: Implement pageDestroyed(), as in EditorClient. 2944 (WebAlternativeTextClient): 2945 * WebCoreSupport/WebAlternativeTextClient.mm: 2946 (WebAlternativeTextClient::pageDestroyed): Deletes itself. 2947 29482012-04-26 Jer Noble <jer.noble@apple.com> 2949 2950 Full Screen mode does not preserve CALayer ordering after exiting. 2951 https://bugs.webkit.org/show_bug.cgi?id=83931 2952 2953 Reviewed by Eric Carlson. 2954 2955 Further corrections to r114567. When swapping view for otherView, give the correct 2956 relative view to -[NSView addSubview:positioned:relativeTo:]. 2957 2958 * WebView/WebFullScreenController.mm: 2959 (-[WebFullScreenController _swapView:with:]): 2960 29612012-04-25 Jer Noble <jer.noble@apple.com> 2962 2963 Placeholder view is immediately removed from hosting window upon entering full screen. 2964 https://bugs.webkit.org/show_bug.cgi?id=84916 2965 2966 Reviewed by Darin Adler. 2967 2968 Correct a mistake added in r114567. When swapping view for otherView, add otherView and 2969 remove view (rather than adding otherView and removing otherView). 2970 2971 * WebView/WebFullScreenController.mm: 2972 (-[WebFullScreenController _swapView:with:]): 2973 29742012-04-25 Beth Dakin <bdakin@apple.com> 2975 2976 https://bugs.webkit.org/show_bug.cgi?id=84913 2977 WebKit 1: Initialize deviceScaleFactor on creation of the WebView 2978 -and corresponding- 2979 <rdar://problem/11322716> 2980 2981 Reviewed by Darin Adler. 2982 2983 Before this patch, we weren't setting the deviceScaleFactor until 2984 viewDidMoveToWindow which is quite late for background tabs. setHostWindow will 2985 happen early on though. For applications that don't use host windows, also set it 2986 from _initWithFrame. 2987 * WebView/WebView.mm: 2988 (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): 2989 (-[WebView setHostWindow:]): 2990 (-[WebView _deviceScaleFactor]): 2991 29922012-04-24 Alexis Menard <alexis.menard@openbossa.org> 2993 2994 Replace occurences of style selector from variables and methods names by style resolver. 2995 https://bugs.webkit.org/show_bug.cgi?id=84765 2996 2997 Reviewed by Andreas Kling. 2998 2999 Rename methods and variables to follow the new name StyleResolver. It requires to update the 3000 local variables, methods parameters, and function names to match the new name and to remove 3001 the concept of "selector" to avoid clashing with the CSS concept. The next and last patch 3002 will be to rename CSSStyleSelector file and update the includes. 3003 3004 * WebView/WebHTMLView.mm: 3005 (-[WebHTMLView reapplyStyles]): 3006 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): 3007 30082012-04-23 Andy Estes <aestes@apple.com> 3009 3010 Incremental rendering should be unsuppressed after the load event or a configurable timeout, whichever occurs first. 3011 https://bugs.webkit.org/show_bug.cgi?id=84583 3012 3013 Add a private WebPreference for setting the incremental rendering suppression timeout. 3014 3015 Reviewed by Anders Carlsson. 3016 3017 * WebView/WebPreferenceKeysPrivate.h: 3018 * WebView/WebPreferences.mm: 3019 (-[WebPreferences setIncrementalRenderingSuppressionTimeoutInSeconds:]): 3020 (-[WebPreferences incrementalRenderingSuppressionTimeoutInSeconds]): 3021 * WebView/WebPreferencesPrivate.h: 3022 * WebView/WebView.mm: 3023 (-[WebView _preferencesChanged:]): 3024 30252012-04-23 Julien Chaffraix <jchaffraix@webkit.org> 3026 3027 Cut dependency on RenderLayer::scrollRectToVisible outside rendering 3028 https://bugs.webkit.org/show_bug.cgi?id=84607 3029 3030 Reviewed by Simon Fraser. 3031 3032 * WebView/WebFrame.mm: 3033 (-[WebFrame _scrollDOMRangeToVisible:]): 3034 Updated to use RenderObject::scrollRectToVisible and not depend on RenderLayer. 3035 30362012-04-22 Jon Lee <jonlee@apple.com> 3037 3038 Remove notifications support on Mac Lion. 3039 https://bugs.webkit.org/show_bug.cgi?id=84554 3040 <rdar://problem/11297128> 3041 3042 Reviewed by Sam Weinig. 3043 3044 * Configurations/FeatureDefines.xcconfig: 3045 30462012-04-20 Jon Lee <jonlee@apple.com> 3047 3048 Add Notification constructor 3049 https://bugs.webkit.org/show_bug.cgi?id=80477 3050 <rdar://problem/10912431> 3051 3052 Reviewed by Jian Li. 3053 3054 * WebCoreSupport/WebNotificationClient.mm: 3055 (WebNotificationClient::clearNotifications): When clearing notifications, finalize 3056 them so that they can be cleaned up by the GC. 3057 30582012-04-20 Timothy Hatcher <timothy@apple.com> 3059 3060 Make the Web Inspector be the first responder when opening docked. 3061 3062 <rdar://problem/11294217> 3063 3064 Reviewed by Brian Weinstein. 3065 3066 * WebCoreSupport/WebInspectorClient.mm: 3067 (-[WebInspectorWindowController showWindow:]): Call makeFirstResponder: on 3068 the window and pass the Inspector's WebView. 3069 30702012-04-18 Hironori Bono <hbono@chromium.org> 3071 3072 Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled() 3073 https://bugs.webkit.org/show_bug.cgi?id=83748 3074 3075 Reviewed by Ryosuke Niwa. 3076 3077 This change replaces a call for SpellChecker::didCheck() with one for 3078 SpellChecker::didCheckSucceeded() because didCheck has been split into 3079 didCheckSucceeded(0 and didCheckCanceled(). 3080 3081 * WebCoreSupport/WebEditorClient.mm: 3082 (-[WebEditorSpellCheckResponder perform]): Replaced didCheck with didCheckSucceeded. 3083 30842012-04-18 Jer Noble <jer.noble@apple.com> 3085 3086 Full Screen mode does not preserve CALayer ordering after exiting. 3087 https://bugs.webkit.org/show_bug.cgi?id=83931 3088 3089 Reviewed by Eric Carlson. 3090 3091 When swapping the placeholder and web views, use -[NSView addSubview:positioned:relativeTo:] 3092 instead of -[NSView replaceSubview:with:], as the latter does not preserve the relative order 3093 of the view's backing CALayers. 3094 3095 * WebView/WebFullScreenController.mm: 3096 (-[WebFullScreenController _swapView:with:]): 3097 30982012-04-18 Alexey Proskuryakov <ap@apple.com> 3099 3100 [WK2] Sandbox violations prevent attaching files to gmail messages 3101 https://bugs.webkit.org/show_bug.cgi?id=84263 3102 <rdar://problem/11248260> 3103 3104 Reviewed by Oliver Hunt. 3105 3106 * WebCoreSupport/WebDragClient.mm: (WebDragClient::willPerformDragDestinationAction): 3107 DragDestinationActionUpload no longer exists, so we don't need a special case for it. 3108 31092012-04-17 Jer Noble <jer.noble@apple.com> 3110 3111 Exiting full screen video brings the wrong Safari window to the foreground 3112 https://bugs.webkit.org/show_bug.cgi?id=83936 3113 3114 Reviewed by Adele Peterson. 3115 3116 Tell the original webView's window to makeKeyAndOrderFront once the exit 3117 animation completes. 3118 3119 * WebView/WebFullScreenController.mm: 3120 (-[WebFullScreenController finishedExitFullScreenAnimation:]): 3121 31222012-04-16 Anders Carlsson <andersca@apple.com> 3123 3124 Use a MIG call when creating a plug-in property list file 3125 https://bugs.webkit.org/show_bug.cgi?id=84084 3126 <rdar://problem/11197341> 3127 3128 Reviewed by Sam Weinig. 3129 3130 * Plugins/Hosted/NetscapePluginHostManager.mm: 3131 (WebKit::NetscapePluginHostManager::createPropertyListFile): 3132 Get a plug-in host and call _WKPHCreatePluginMIMETypesPreferences instead. 3133 3134 * Plugins/Hosted/WebKitPluginHost.defs: 3135 Add PHCreatePluginMIMETypesPreferences. 3136 3137 * Plugins/WebNetscapePluginPackage.mm: 3138 (-[WebNetscapePluginPackage createPropertyListFile]): 3139 NetscapePluginHostManager::createPropertyListFile is no longer a static member function. 3140 31412012-04-12 Andy Estes <aestes@apple.com> 3142 3143 REGRESSION (r102262): iAd Producer relies on CSSStyleDeclaration property setters respecting '!important' 3144 https://bugs.webkit.org/show_bug.cgi?id=83832 3145 3146 Reviewed by Alexey Proskuryakov. 3147 3148 * Misc/WebKitVersionChecks.h: Indicate that 535.13.0 was the first 3149 version of WebKit.framework to ignore '!important' in 3150 CSSStyleDeclaration property setters. 3151 * WebView/WebView.mm: 3152 (shouldRespectPriorityInCSSAttributeSetters): 3153 (-[WebView _commonInitializationWithFrameName:groupName:]): Enable a 3154 quirk to restore pre-r102262 behavior if the application is iAd Producer 3155 and was linked against a version of WebKit.framework that had the old behavior. 3156 31572012-04-12 Andy Estes <aestes@apple.com> 3158 3159 Remove unused WebKit1 SPI for suppressing incremental rendering. 3160 https://bugs.webkit.org/show_bug.cgi?id=83801 3161 3162 Reviewed by Simon Fraser. 3163 3164 This SPI is unused and has been replaced by API ([setS|s]uppressesIncrementalRendering). 3165 3166 * WebView/WebPreferences.mm: 3167 * WebView/WebPreferencesPrivate.h: 3168 31692012-04-08 Dan Bernstein <mitz@apple.com> 3170 3171 [mac] REGRESSION (r113467): Some canvas tests are failing in WebKit1 when run after compositing/tiled-layers-hidpi.html 3172 https://bugs.webkit.org/show_bug.cgi?id=83453 3173 3174 Reviewed by Sam Weinig. 3175 3176 * WebView/WebView.mm: 3177 (-[WebView _setCustomBackingScaleFactor:]): When the scale factor parameter was 0, meaning 3178 no custom scale factor, this method was setting the Page scale factor to 0, and that value 3179 was used by canvas. Changed it to correctly set the Page scale factor back to the device 3180 scale factor. 3181 31822012-04-06 Alexey Proskuryakov <ap@apple.com> 3183 3184 [Mac] Adopt a different method of telling AppKit when inline input isn't supported 3185 https://bugs.webkit.org/show_bug.cgi?id=83408 3186 <rdar://problem/9205734> 3187 3188 Reviewed by Adele Peterson. 3189 3190 * Plugins/Hosted/WebTextInputWindowController.m: 3191 (-[WebTextInputView validAttributesForMarkedText]): 3192 (-[WebTextInputPanel init]): 3193 (-[WebTextInputPanel _interpretKeyEvent:string:]): Added a comment about old approach. 3194 31952012-04-06 Enrica Casucci <enrica@apple.com> 3196 3197 Provide Obj-C private API to simplify markup. 3198 https://bugs.webkit.org/show_bug.cgi?id=83334 3199 <rdar://problem/11033861> 3200 3201 Reviewed by Sam Weinig. 3202 3203 * WebView/WebView.mm: 3204 (-[WebView _simplifyMarkup:endNode:]): Added. 3205 * WebView/WebViewPrivate.h: 3206 32072012-04-06 Tim Horton <timothy_horton@apple.com> 3208 3209 Add autodetection of image orientation from EXIF information 3210 https://bugs.webkit.org/show_bug.cgi?id=19688 3211 <rdar://problem/4126979> and <rdar://problem/11091578> 3212 3213 Original patch by David Carson and Eric Seidel. 3214 3215 Reviewed by Simon Fraser. 3216 3217 Add a preference, ShouldRespectImageOrientation, which will cause WebCore to respect EXIF orientation in all images. 3218 3219 * WebView/WebPreferenceKeysPrivate.h: 3220 * WebView/WebPreferences.mm: 3221 (+[WebPreferences initialize]): 3222 (-[WebPreferences setShouldRespectImageOrientation:]): 3223 (-[WebPreferences shouldRespectImageOrientation]): 3224 * WebView/WebPreferencesPrivate.h: 3225 * WebView/WebView.mm: 3226 (-[WebView _preferencesChanged:]): 3227 32282012-04-06 Dan Bernstein <mitz@apple.com> 3229 3230 <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access 3231 3232 Reviewed by Sam Weinig. 3233 3234 * Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS. 3235 32362012-04-05 Jia Pu <jpu@apple.com> 3237 3238 Move correction panel related functions from EditorClient into separated AlternativeTextClient class. 3239 https://bugs.webkit.org/show_bug.cgi?id=82970 3240 3241 Reviewed by Enrica Casucci. 3242 3243 Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient. 3244 See WebCore/ChangeLog for details. 3245 3246 * WebCoreSupport/CorrectionPanel.h: 3247 * WebCoreSupport/CorrectionPanel.mm: 3248 * WebCoreSupport/WebAlternativeTextClient.h: Added. 3249 (WebAlternativeTextClient): 3250 * WebCoreSupport/WebAlternativeTextClient.mm: Added. 3251 (WebAlternativeTextClient::WebAlternativeTextClient): 3252 (WebAlternativeTextClient::~WebAlternativeTextClient): 3253 (WebAlternativeTextClient::showCorrectionAlternative): 3254 (WebAlternativeTextClient::dismissAlternative): 3255 (WebAlternativeTextClient::dismissAlternativeSoon): 3256 (WebAlternativeTextClient::recordAutocorrectionResponse): 3257 * WebCoreSupport/WebEditorClient.h: 3258 * WebCoreSupport/WebEditorClient.mm: 3259 (WebEditorClient::~WebEditorClient): 3260 * WebView/WebView.mm: 3261 (-[WebView _commonInitializationWithFrameName:groupName:]): 3262 32632012-03-15 Jer Noble <jer.noble@apple.com> 3264 3265 Full Screen mode should cancel before navigation. 3266 https://bugs.webkit.org/show_bug.cgi?id=81295 3267 3268 Reviewed by Anders Carlsson. 3269 3270 When a provisional load is started, if the page is currently in full screen mode, instruct 3271 the full screen controller to close the full screen window immediately. 3272 3273 * WebView/WebFullScreenController.h: 3274 * WebView/WebFullScreenController.mm: 3275 (-[WebFullScreenController isFullScreen]): Added. 3276 * WebView/WebView.mm: 3277 (-[WebView _didStartProvisionalLoadForFrame:]): Close the full screen window controller, if 3278 present and in full screen mode. 3279 32802012-04-03 Keishi Hattori <keishi@webkit.org> 3281 3282 Disable ENABLE_DATALIST for now 3283 https://bugs.webkit.org/show_bug.cgi?id=82871 3284 3285 Reviewed by Kent Tamura. 3286 3287 * Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST. 3288 32892012-04-03 Anders Carlsson <andersca@apple.com> 3290 3291 Add audit token to PHCheckInWithPluginHost 3292 https://bugs.webkit.org/show_bug.cgi?id=83102 3293 3294 Reviewed by Sam Weinig. 3295 3296 * Plugins/Hosted/WebKitPluginHost.defs: 3297 32982012-04-02 Jia Pu <jpu@apple.com> 3299 3300 Rename SpellingCorrectionController to AlternativeTextController. 3301 https://bugs.webkit.org/show_bug.cgi?id=82942 3302 3303 Reviewed by Enrica Casucci. 3304 3305 These changes are simply adopting new class names. 3306 3307 * WebCoreSupport/CorrectionPanel.h: 3308 (CorrectionPanel): 3309 * WebCoreSupport/CorrectionPanel.mm: 3310 (correctionIndicatorType): 3311 (CorrectionPanel::CorrectionPanel): 3312 (CorrectionPanel::~CorrectionPanel): 3313 (CorrectionPanel::show): 3314 (CorrectionPanel::dismiss): 3315 (CorrectionPanel::dismissInternal): 3316 (CorrectionPanel::handleAcceptedReplacement): 3317 * WebCoreSupport/WebEditorClient.h: 3318 * WebCoreSupport/WebEditorClient.mm: 3319 (WebEditorClient::~WebEditorClient): 3320 (WebEditorClient::showCorrectionPanel): 3321 (WebEditorClient::dismissCorrectionPanel): 3322 (WebEditorClient::dismissCorrectionPanelSoon): 3323 * WebView/WebView.mm: 3324 (-[WebView handleCorrectionPanelResult:]): 3325 33262012-04-03 Jer Noble <jer.noble@apple.com> 3327 3328 ESC key in full screen does not result in webkitFullScreenChange event. 3329 https://bugs.webkit.org/show_bug.cgi?id=82755 3330 <rdar://problem/11093513> 3331 3332 Reviewed by Eric Carlson. 3333 3334 Instead of exiting full screen directly, ask the document to initiate exiting full screen. This ensures 3335 that the entire full screen element stack is cleared and that webkitFullScreenChange events are sent 3336 out correctly. 3337 3338 * WebView/WebFullScreenController.mm: 3339 (-[WebFullScreenController cancelOperation:]): 3340 (-[WebFullScreenController requestExitFullScreen]): 3341 33422012-04-01 Jon Lee <jonlee@apple.com> 3343 3344 Rename notification properties and functions 3345 https://bugs.webkit.org/show_bug.cgi?id=80482 3346 <rdar://problem/10912432> 3347 3348 Reviewed by Kentaro Hara. 3349 3350 * WebView/WebNotification.h: Rename replaceID to tag. 3351 * WebView/WebNotification.mm: 3352 (-[WebNotification tag]): 3353 33542012-03-31 Timothy Hatcher <timothy@apple.com> 3355 3356 Prevent opening external URLs in the Web Inspector's WebView. 3357 3358 All URLs not handled by the Inspector's JavaScript are now opened in the inspected WebView. 3359 3360 https://webkit.org/b/82812 3361 rdar://problem/9488558 3362 3363 Reviewed by Joseph Pecoraro. 3364 3365 * WebCoreSupport/WebInspectorClient.mm: 3366 (-[WebInspectorWindowController init]): Factored the URL code out of here into inspectorPagePath. 3367 (-[WebInspectorWindowController inspectorPagePath]): Added. 3368 (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Added. 3369 Only allow non-main frame and the inspector page. All other URLs will be opened in the inspected page. 3370 33712012-03-30 Emil A Eklund <eae@chromium.org> 3372 3373 Change WebKit/WebKit2 platform code to use pixel snapped values 3374 https://bugs.webkit.org/show_bug.cgi?id=82549 3375 3376 Change WebKit and WebKit2 platform code to use rounded locations and 3377 pixel snapped rects and sizes. This largely avoids having to expose the 3378 fractional layout types to the platform code. 3379 3380 Reviewed by Eric Seidel. 3381 3382 * DOM/WebDOMOperations.mm: 3383 (-[DOMNode _renderRect:]): 3384 33852012-03-30 Mark Pilgrim <pilgrim@chromium.org> 3386 3387 GEOLOCATION should be implemented as Page Supplement 3388 https://bugs.webkit.org/show_bug.cgi?id=82228 3389 3390 Reviewed by Adam Barth. 3391 3392 Geolocation is now a Supplement in Page so the interface 3393 has changed for setting up the page's geolocation client 3394 initially and accessing the controller later. 3395 3396 * WebView/WebView.mm: 3397 (-[WebView _commonInitializationWithFrameName:groupName:]): 3398 (-[WebView _geolocationDidChangePosition:]): 3399 (-[WebView _geolocationDidFailWithError:]): 3400 34012012-03-30 Keishi Hattori <keishi@webkit.org> 3402 3403 Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium 3404 https://bugs.webkit.org/show_bug.cgi?id=80972 3405 3406 Reviewed by Kent Tamura. 3407 3408 * Configurations/FeatureDefines.xcconfig: 3409 34102012-03-28 Alexey Proskuryakov <ap@apple.com> 3411 3412 [Mac] REGRESSION: Removing translation of local paths in KURL constructor broke some applications 3413 https://bugs.webkit.org/show_bug.cgi?id=82548 3414 <rdar://problem/11125355> 3415 <rdar://problem/11142152> 3416 3417 Reviewed by Brady Eidson. 3418 3419 * WebView/WebFrame.mm: 3420 (-[WebFrame loadRequest:]): Fixed this bug. 3421 (-[WebFrame loadHTMLString:baseURL:]): Also added translation to another API, so that I don't 3422 have to come back again. 3423 (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto. 3424 3425 * WebView/WebView.mm: (-[WebView setMainFrameURL:]): Changed another place where clients used 3426 to pass file paths instead of URLs. 3427 34282012-03-29 Sheriff Bot <webkit.review.bot@gmail.com> 3429 3430 Unreviewed, rolling out r112553. 3431 http://trac.webkit.org/changeset/112553 3432 https://bugs.webkit.org/show_bug.cgi?id=82638 3433 3434 It made all tests crash on Qt WK2 (Requested by Ossy_away on 3435 #webkit). 3436 3437 * WebView/WebView.mm: 3438 (-[WebView _commonInitializationWithFrameName:groupName:]): 3439 (-[WebView _geolocationDidChangePosition:]): 3440 (-[WebView _geolocationDidFailWithError:]): 3441 34422012-03-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> 3443 3444 HashMap<>::add should return a more descriptive object 3445 https://bugs.webkit.org/show_bug.cgi?id=71063 3446 3447 Reviewed by Ryosuke Niwa. 3448 3449 Update code to use AddResult instead of a pair. 3450 3451 * Plugins/Hosted/NetscapePluginHostManager.mm: 3452 (WebKit::NetscapePluginHostManager::hostForPlugin): 3453 * Plugins/Hosted/ProxyInstance.mm: 3454 (WebKit::ProxyInstance::methodsNamed): 3455 (WebKit::ProxyInstance::fieldNamed): 3456 * WebCoreSupport/WebNotificationClient.mm: 3457 (WebNotificationClient::show): 3458 34592012-03-29 Mark Pilgrim <pilgrim@chromium.org> 3460 3461 GEOLOCATION should be implemented as Page Supplement 3462 https://bugs.webkit.org/show_bug.cgi?id=82228 3463 3464 Reviewed by Adam Barth. 3465 3466 Geolocation is now a Supplement in Page so the interface 3467 has changed for setting up the page's geolocation client 3468 initially and accessing the controller later. 3469 3470 * WebView/WebView.mm: 3471 (-[WebView _commonInitializationWithFrameName:groupName:]): 3472 (-[WebView _geolocationDidChangePosition:]): 3473 (-[WebView _geolocationDidFailWithError:]): 3474 34752012-03-28 Nate Chapin <japhet@chromium.org> 3476 3477 Remove dispatchDidLoadMainResource callback, since no 3478 port implements it. 3479 https://bugs.webkit.org/show_bug.cgi?id=82539 3480 3481 Reviewed by Alexey Proskuryakov. 3482 3483 * WebCoreSupport/WebFrameLoaderClient.h: 3484 * WebCoreSupport/WebFrameLoaderClient.mm: 3485 * WebKit.order: 3486 34872012-03-28 Joseph Pecoraro <pecoraro@apple.com> 3488 3489 <http://webkit.org/b/82419> Web Inspector: Create -[DOMNode inspect] from IDL 3490 3491 Reviewed by Timothy Hatcher. 3492 3493 * MigrateHeaders.make: Copy DOMNodePrivate.h to PrivateHeaders. 3494 34952012-03-27 Timothy Hatcher <timothy@apple.com> 3496 3497 Make WebKit properly load a staged framework when soft linking. 3498 3499 https://webkit.org/b/82371 3500 rdar://problem/11125989 3501 3502 Reviewed by Dan Bernstein. 3503 3504 * WebCoreSupport/WebInspectorClient.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly 3505 load the WebInspector framework. 3506 35072012-03-26 Adam Barth <abarth@webkit.org> 3508 3509 FrameLoader::shouldAllowNavigation uses Frame for context rather than Document 3510 https://bugs.webkit.org/show_bug.cgi?id=81020 3511 3512 Reviewed by Eric Seidel. 3513 3514 Update call site to new function name. 3515 3516 * WebCoreSupport/WebFrameLoaderClient.mm: 3517 (WebFrameLoaderClient::dispatchWillSubmitForm): 3518 35192012-03-23 Alexey Proskuryakov <ap@apple.com> 3520 3521 [Mac] No need for platform-specific ENABLE_BLOB values 3522 https://bugs.webkit.org/show_bug.cgi?id=82102 3523 3524 Reviewed by David Kilzer. 3525 3526 * Configurations/FeatureDefines.xcconfig: 3527 35282012-03-23 Dean Jackson <dino@apple.com> 3529 3530 Disable CSS_SHADERS in Apple builds 3531 https://bugs.webkit.org/show_bug.cgi?id=81996 3532 3533 Reviewed by Simon Fraser. 3534 3535 Remove ENABLE_CSS_SHADERS from FeatureDefines. It's now in Platform.h. 3536 3537 * Configurations/FeatureDefines.xcconfig: 3538 35392012-03-22 Gyuyoung Kim <gyuyoung.kim@samsung.com> 3540 3541 Convert hasGrammarMarker to use Internals interface 3542 https://bugs.webkit.org/show_bug.cgi?id=82004 3543 3544 Reviewed by Ryosuke Niwa. 3545 3546 Remove hasGrammarMarker support, since it can support in the cross-port way 3547 through the Internals interface. 3548 3549 * WebKit.order: 3550 * WebView/WebFrame.mm: 3551 * WebView/WebFramePrivate.h: 3552 35532012-03-22 Benjamin Poulain <bpoulain@apple.com> 3554 3555 Build fix for WebHistory is busted after changing time zone 3556 https://bugs.webkit.org/show_bug.cgi?id=81849 3557 3558 Unreviewed build fix. 3559 3560 When generating warning for undefined message signature, rebuildHistoryByDayIfNeeded 3561 fail to compile due to addItemToDateCaches: being undefined. 3562 3563 Move the definition to the right place in the file to use the private method. 3564 3565 * History/WebHistory.mm: 3566 (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]): 3567 35682012-03-22 Benjamin Poulain <bpoulain@apple.com> 3569 3570 WebHistory is busted after changing time zone 3571 https://bugs.webkit.org/show_bug.cgi?id=81849 3572 3573 Reviewed by Brady Eidson. 3574 3575 The date used for choosing the bucket of a new entry is computed 3576 with the system TimeZone. 3577 3578 When the Time Zone change, or the daylight saving time change, all the dates 3579 in _entriesByDate are offset from the new entries. 3580 3581 This patch solves the issue by re-distributing the WebHistoryItems if the time zone 3582 changes. 3583 The clients of WebHistory are notified of this change through the regular Notifications. 3584 3585 * History/WebHistory.mm: 3586 (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]): 3587 (-[WebHistoryPrivate init]): 3588 (-[WebHistory timeZoneChanged:]): 3589 (-[WebHistory init]): 3590 (-[WebHistory dealloc]): 3591 (-[WebHistory finalize]): 3592 35932012-03-21 Tim Horton <timothy_horton@apple.com> 3594 3595 Make use of CG rounded-rect primitives 3596 https://bugs.webkit.org/show_bug.cgi?id=79932 3597 <rdar://problem/9274953> 3598 3599 Reviewed by Simon Fraser. 3600 3601 Portions of patch by Nikolas Zimmermann and Mustafizur Rahaman. 3602 3603 Add wkCGPathAddRoundedRect. 3604 3605 * WebCoreSupport/WebSystemInterface.mm: 3606 (InitWebCoreSystemInterface): 3607 36082012-03-20 Gyuyoung Kim <gyuyoung.kim@samsung.com> 3609 3610 Convert hasSpellingMarker to use Internals interface. 3611 https://bugs.webkit.org/show_bug.cgi?id=81300 3612 3613 Reviewed by Ryosuke Niwa. 3614 3615 Remove hasSpellingMarker support, since it can support in the cross-port way 3616 through the Internals interface. 3617 3618 * WebKit.order: 3619 * WebView/WebFrame.mm: 3620 * WebView/WebFramePrivate.h: 3621 36222012-03-19 Adam Barth <abarth@webkit.org> 3623 3624 Remove support for "magic" iframe 3625 https://bugs.webkit.org/show_bug.cgi?id=81590 3626 3627 Reviewed by Eric Seidel. 3628 3629 Remove FrameLoaderClient methods that no longer exist. 3630 3631 * WebCoreSupport/WebFrameLoaderClient.h: 3632 * WebCoreSupport/WebFrameLoaderClient.mm: 3633 36342012-03-19 Enrica Casucci <enrica@apple.com> 3635 3636 WebKit2: create sandbox extensions for files that are dropped in an input control. 3637 https://bugs.webkit.org/show_bug.cgi?id=81153 3638 <rdar://problem/11031207> 3639 3640 Reviewed by Alexey Proskuryakov. 3641 3642 * WebCoreSupport/WebDragClient.mm: 3643 (WebDragClient::willPerformDragDestinationAction): Avoid calling the delegate with the new drag action. 3644 We want to avoid any unwanted side effects for the WebKit clients. 3645 36462012-03-19 Emil A Eklund <eae@chromium.org> 3647 3648 [mac/chromium] Change platform code to use pixelSnappedRect methods 3649 https://bugs.webkit.org/show_bug.cgi?id=81016 3650 3651 Reviewed by Eric Seidel. 3652 3653 * Plugins/WebBaseNetscapePluginView.mm: 3654 (-[WebBaseNetscapePluginView actualVisibleRectInWindow]): 3655 * WebView/WebFrame.mm: 3656 (-[WebFrame _getVisibleRect:]): 3657 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): 3658 * WebView/WebView.mm: 3659 (-[WebView _dashboardRegions]): 3660 (-[WebView trackedRepaintRects]): 3661 36622012-03-16 Brady Eidson <beidson@apple.com> 3663 3664 <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412 3665 REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted 3666 3667 Reviewed by Geoff Garen. 3668 3669 * WebCoreSupport/WebEditorClient.mm: 3670 (WebEditorClient::setInsertionPasteboard): 3671 * WebCoreSupport/WebPlatformStrategies.h: 3672 (WebPlatformStrategies): 3673 * WebCoreSupport/WebPlatformStrategies.mm: 3674 (WebPlatformStrategies::url): 3675 36762012-03-08 Jer Noble <jer.noble@apple.com> 3677 3678 Support W3C Full Screen API proposal 3679 https://bugs.webkit.org/show_bug.cgi?id=80660 3680 3681 Reviewed by Alexey Proskuryakov. 3682 3683 Allow full screen elements to access the keyboard. 3684 3685 * WebView/WebView.mm: 3686 (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]): 3687 36882012-03-07 Jon Lee <jonlee@apple.com> 3689 3690 Move NotificationContents into Notification 3691 https://bugs.webkit.org/show_bug.cgi?id=80487 3692 <rdar://problem/10965519> 3693 3694 Reviewed by Jian Li. 3695 3696 * WebView/WebNotification.mm: Refactor to use accessor methods on Notification. 3697 (-[WebNotification title]): 3698 (-[WebNotification body]): 3699 37002012-03-15 David Hyatt <hyatt@apple.com> 3701 3702 https://bugs.webkit.org/show_bug.cgi?id=81258 3703 3704 Add a preference for enabling the new multi-column layout code that will be based on regions. 3705 3706 Reviewed by Beth Dakin. 3707 3708 * WebView/WebPreferenceKeysPrivate.h: 3709 * WebView/WebPreferences.mm: 3710 (+[WebPreferences initialize]): 3711 (-[WebPreferences setRegionBasedColumnsEnabled:]): 3712 (-[WebPreferences regionBasedColumnsEnabled]): 3713 * WebView/WebPreferencesPrivate.h: 3714 * WebView/WebView.mm: 3715 (-[WebView _preferencesChanged:]): 3716 37172012-03-15 Brady Eidson <beidson@apple.com> 3718 3719 <rdar://problem/11036900> and https://bugs.webkit.org/show_bug.cgi?id=81079 3720 REGRESSION(r107844): Clipboard API only remembers most recent data set on clipboard 3721 3722 Reviewed by Sam Weinig. 3723 3724 Add the non-destructive "addTypes" to supplement the destructive "setTypes" 3725 * WebCoreSupport/WebPlatformStrategies.h: 3726 * WebCoreSupport/WebPlatformStrategies.mm: 3727 (WebPlatformStrategies::addTypes): 3728 37292012-03-14 Anders Carlsson <andersca@apple.com> 3730 3731 java/java-and-plugins.html test failing 3732 https://bugs.webkit.org/show_bug.cgi?id=81188 3733 <rdar://problem/11048657> 3734 3735 Reviewed by Sam Weinig. 3736 3737 When we're marshaling JSObjects that wrap plug-in objects, make sure to check that the 3738 current plug-in instance is the same as the plug-in instance the object came from and don't 3739 pass the unwrapped object ID if that is the case. 3740 3741 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 3742 (WebKit::getObjectID): 3743 (WebKit::NetscapePluginInstanceProxy::addValueToArray): 3744 (WebKit::NetscapePluginInstanceProxy::marshalValues): 3745 * Plugins/Hosted/ProxyInstance.h: 3746 (ProxyInstance): 3747 (WebKit::ProxyInstance::instanceProxy): 3748 37492012-03-14 Michael Saboff <msaboff@apple.com> 3750 3751 REGRESSION(r110383): ASSERTION failures in JSCell::finishCreation causing multiple tests to "crash" on the Lion Intel Debug Bots 3752 https://bugs.webkit.org/show_bug.cgi?id=80993 3753 3754 Reviewed by Mark Rowe. 3755 3756 Moved $(BUILT_PRODUCTS_DIR)/usr/local/include to the front of HEADER_SEARCH_PATH 3757 to fix builds given the wtf move. 3758 3759 * Configurations/WebKit.xcconfig: 3760 37612012-03-13 Jon Lee <jonlee@apple.com> 3762 3763 Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS 3764 https://bugs.webkit.org/show_bug.cgi?id=80922 3765 <rdar://problem/11035082> 3766 3767 Reviewed by Jian Li. 3768 3769 You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API. 3770 LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the 3771 new API. Therefore, APIs that are common between the two will have: 3772 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) 3773 3774 This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to 3775 the new API, the defines will begin to split. This allows ports to decide which set of APIs to include. 3776 3777 Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) 3778 * WebCoreSupport/WebNotificationClient.h: 3779 * WebCoreSupport/WebNotificationClient.mm: 3780 (WebNotificationClient::show): 3781 (WebNotificationClient::cancel): 3782 (WebNotificationClient::clearNotifications): 3783 (WebNotificationClient::notificationObjectDestroyed): 3784 (WebNotificationClient::notificationControllerDestroyed): 3785 (WebNotificationClient::requestPermission): 3786 (WebNotificationClient::checkPermission): 3787 * WebView/WebNotification.mm: 3788 (-[WebNotification title]): 3789 (-[WebNotification body]): 3790 (-[WebNotification replaceID]): 3791 (-[WebNotification origin]): 3792 (-[WebNotification notificationID]): 3793 (-[WebNotification dispatchShowEvent]): 3794 (-[WebNotification dispatchCloseEvent]): 3795 (-[WebNotification dispatchClickEvent]): 3796 (-[WebNotification dispatchErrorEvent]): 3797 * WebView/WebNotificationInternal.h: 3798 * WebView/WebView.mm: 3799 (-[WebView _commonInitializationWithFrameName:groupName:]): 3800 38012012-03-13 Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com> 3802 3803 Always enable ENABLE(CLIENT_BASED_GEOLOCATION) 3804 https://bugs.webkit.org/show_bug.cgi?id=78853 3805 3806 Reviewed by Adam Barth. 3807 3808 * Configurations/FeatureDefines.xcconfig: 3809 * WebCoreSupport/WebChromeClient.h: 3810 (WebChromeClient): 3811 * WebCoreSupport/WebGeolocationClient.mm: 3812 (WebGeolocationClient::lastPosition): 3813 * WebView/WebGeolocationPosition.mm: 3814 (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]): 3815 (core): 3816 (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]): 3817 * WebView/WebGeolocationPositionInternal.h: 3818 * WebView/WebView.mm: 3819 (-[WebView _commonInitializationWithFrameName:groupName:]): 3820 (-[WebView _geolocationDidChangePosition:]): 3821 (-[WebView _geolocationDidFailWithError:]): 3822 38232012-03-12 Antonio Gomes <agomes@rim.com> 3824 3825 Convert nodesFromRect tests to use Internals interface 3826 https://bugs.webkit.org/show_bug.cgi?id=80886 3827 3828 Reviewed by Ryosuke Niwa. 3829 3830 Removed mac specific support for nodesFromRect for testing purposes only, 3831 since it can work in a cross-port way through the Internals interface. 3832 3833 * WebKit.order: 3834 * WebView/WebView.mm: 3835 * WebView/WebViewPrivate.h: 3836 38372012-03-13 Anders Carlsson <andersca@apple.com> 3838 3839 Remove a nonexistent WebUIDelegate method from WebUIDelegatePrivate.h 3840 https://bugs.webkit.org/show_bug.cgi?id=81014 3841 3842 Reviewed by Sam Weinig. 3843 3844 Remove a plug-in halter related WebUIDelegate method. 3845 3846 * WebView/WebUIDelegatePrivate.h: 3847 38482012-03-13 Shinya Kawanaka <shinyak@chromium.org> 3849 3850 REGRESSION: Spellcheck tests hit assertions on Mac. 3851 https://bugs.webkit.org/show_bug.cgi?id=80883 3852 3853 Reviewed by Ryosuke Niwa. 3854 3855 The bug was caused by the closure object created in requestCheckingOfString accessing 3856 request's member variables even though the request object is not an NSObject or allocated 3857 in stack. This resulted in the closure not being able to access those variables when invoked. 3858 3859 Fixed the bug by making local copies of those member variables. 3860 3861 * WebCoreSupport/WebEditorClient.mm: 3862 (WebEditorClient::requestCheckingOfString): 3863 38642012-03-11 Timothy Hatcher <timothy@apple.com> 3865 3866 Update how the Web Inspector resources are loaded. 3867 3868 https://bugs.webkit.org/show_bug.cgi?id=80798 3869 rdar://problem/10359959 3870 3871 Reviewed by Brian Weinstein. 3872 3873 * WebCoreSupport/WebInspectorClient.mm: 3874 (useWebKitWebInspector): Return if we are using the WebCore resources for compatibility 3875 with local and nightly builds. 3876 (WebInspectorFrontendClient::localizedStringsURL): Decide what path to use. 3877 (-[WebInspectorWindowController init]): Ditto. 3878 (-[WebInspectorWindowController window]): Decide if the window is textured or not. 3879 38802012-03-09 Jon Lee <jonlee@apple.com> 3881 3882 Rename NotificationPresenter to NotificationClient 3883 https://bugs.webkit.org/show_bug.cgi?id=80488 3884 <rdar://problem/10965558> 3885 3886 Reviewed by Kentaro Hara. 3887 3888 Refactor to use renamed WebCore::NotificationClient. 3889 * WebCoreSupport/WebNotificationClient.h: 3890 * WebCoreSupport/WebNotificationClient.mm: 3891 (WebNotificationClient::checkPermission): 3892 * WebView/WebViewPrivate.h: 3893 38942012-03-09 Enrica Casucci <enrica@apple.com> 3895 3896 Move WebNSURLExtras code down to WebCore. 3897 https://bugs.webkit.org/show_bug.cgi?id=80611 3898 3899 Reviewed by Alexey Proskuryakov. 3900 3901 Changed the implementation to use newly moved WebCore functions. 3902 3903 * Misc/WebKitNSStringExtras.mm: 3904 (-[NSString _webkit_hasCaseInsensitivePrefix:]): 3905 * Misc/WebNSURLExtras.mm: 3906 (+[NSURL _web_URLWithUserTypedString:]): 3907 (+[NSURL _web_URLWithDataAsString:relativeToURL:]): 3908 (+[NSURL _web_URLWithData:]): 3909 (+[NSURL _web_URLWithData:relativeToURL:]): 3910 (-[NSURL _web_originalData]): 3911 (-[NSURL _web_originalDataAsString]): 3912 (-[NSURL _web_userVisibleString]): 3913 (-[NSURL _web_isEmpty]): 3914 (-[NSURL _web_URLCString]): 3915 (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): 3916 (-[NSURL _webkit_URLByRemovingFragment]): 3917 (-[NSURL _webkit_URLByRemovingResourceSpecifier]): 3918 (-[NSURL _web_URLByRemovingUserInfo]): 3919 (-[NSURL _web_dataForURLComponentType:]): 3920 (-[NSURL _web_schemeData]): 3921 (-[NSURL _web_hostData]): 3922 (-[NSString _web_isUserVisibleURL]): 3923 (-[NSString _web_hostNameNeedsDecodingWithRange:]): 3924 (-[NSString _web_hostNameNeedsEncodingWithRange:]): 3925 (-[NSString _web_decodeHostNameWithRange:]): 3926 (-[NSString _web_encodeHostNameWithRange:]): 3927 (-[NSString _web_decodeHostName]): 3928 (-[NSString _web_encodeHostName]): 3929 * WebCoreSupport/WebSystemInterface.mm: 3930 (InitWebCoreSystemInterface): 3931 39322012-03-09 Emil A Eklund <eae@chromium.org> 3933 3934 Add roundedPoint to HitTestResult and change platform code to use it 3935 https://bugs.webkit.org/show_bug.cgi?id=80715 3936 3937 Reviewed by James Robinson. 3938 3939 Change ports to use roundedPoint to avoid exposing subpixel types to 3940 platform code. 3941 3942 * WebCoreSupport/WebContextMenuClient.mm: 3943 (WebContextMenuClient::showContextMenu): 3944 39452012-03-09 Jon Lee <jonlee@apple.com> 3946 3947 Add support for ENABLE(LEGACY_NOTIFICATIONS) 3948 https://bugs.webkit.org/show_bug.cgi?id=80497 3949 3950 Reviewed by Adam Barth. 3951 3952 Prep for b80472: Update API for Web Notifications 3953 * Configurations/FeatureDefines.xcconfig: 3954 39552012-03-08 Ryosuke Niwa <rniwa@webkit.org> 3956 3957 Mac build fix for micro data API. 3958 3959 * Configurations/FeatureDefines.xcconfig: 3960 39612012-03-08 Jer Noble <jer.noble@apple.com> 3962 3963 Unreviewed Snow Leopard build fix. 3964 3965 On Leopard and Snow Leopard, provide an implementation for -[NSWindow convertRectToScreen:]. 3966 3967 * WebView/WebFullScreenController.mm: 3968 (-[NSWindow convertRectToScreen:]): 3969 39702012-02-20 Jer Noble <jer.noble@apple.com> 3971 3972 Full Screen Refactor Part 4: Animate into Full Screen mode using new animation classes, WebKit edition. 3973 https://bugs.webkit.org/show_bug.cgi?id=78930 3974 3975 Reviewed by Anders Carlsson. 3976 3977 Revise WebFullScreenController to have the same general functionality and code path as WKFullScreenWindowController 3978 in WebKit2. As such, the following functions are copies of their equivalents in WKFullScreenWindowController: 3979 * WebView/WebFullScreenController.mm: 3980 (-[WebFullScreenController init]): 3981 (-[WebFullScreenController dealloc]): 3982 (-[WebFullScreenController windowDidLoad]): 3983 (-[WebFullScreenController cancelOperation:]): 3984 (-[WebFullScreenController applicationDidResignActive:]): 3985 (-[WebFullScreenController applicationDidChangeScreenParameters:]): 3986 (-[WebFullScreenController finishedEnterFullScreenAnimation:]): 3987 (-[WebFullScreenController finishedExitFullScreenAnimation:]): 3988 (-[WebFullScreenController close]): 3989 (-[WebFullScreenController animationDidEnd:]): 3990 (-[WebFullScreenController _updateMenuAndDockForFullScreen]): 3991 (-[WebFullScreenController _swapView:with:]): 3992 (createBackgroundFullscreenWindow): 3993 (windowFrameFromApparentFrames): 3994 (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): 3995 (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): 3996 3997 The following is a copy of the equivalent function in WebFullScreenManager: 3998 * WebView/WebFullScreenController.mm: 3999 (screenRectOfContents): 4000 4001 * WebCoreSupport/WebChromeClient.mm: 4002 (WebChromeClient::fullScreenRendererChanged): No longer tell the WebView the renderer changed (as it doesn't care.) 4003 * WebView/WebFullScreenController.h: 4004 * WebView/WebFullScreenController.mm: 4005 (-[WebFullScreenController setElement:]): No need to add event listeners to the media element. 4006 (-[WebFullScreenController enterFullScreen:]): Same as WKFullScreenWindowController, but not asynchronous. 4007 (-[WebFullScreenController exitFullScreen]): Ditto. 4008 * WebView/WebView.mm: 4009 (-[WebView _enterFullScreenForElement:WebCore::]): Fullscreen -> FullScreen. 4010 (-[WebView _exitFullScreenForElement:WebCore::]): Ditto. 4011 40122012-03-08 Matt Lilek <mrl@apple.com> 4013 4014 Don't enable VIDEO_TRACK on all OS X platforms 4015 https://bugs.webkit.org/show_bug.cgi?id=80635 4016 4017 Reviewed by Eric Carlson. 4018 4019 * Configurations/FeatureDefines.xcconfig: 4020 40212012-03-07 Joseph Pecoraro <pecoraro@apple.com> 4022 4023 <http://webkit.org/b/80510> Web Inspector crash (iCab) 4024 4025 Reviewed by Timothy Hatcher. 4026 4027 * WebCoreSupport/WebInspectorClient.mm: 4028 (WebInspectorClient::didResizeMainFrame): 4029 40302012-03-06 Benjamin Poulain <bpoulain@apple.com> 4031 4032 [Mac] Update the configuration files for iOS 4033 https://bugs.webkit.org/show_bug.cgi?id=80435 4034 4035 Reviewed by David Kilzer. 4036 4037 * Configurations/WebKit.xcconfig: 4038 40392012-03-06 Eric Seidel <eric@webkit.org> 4040 4041 Make WTF public headers use fully-qualified include paths and remove ForwardingHeaders/wtf 4042 https://bugs.webkit.org/show_bug.cgi?id=80363 4043 4044 Reviewed by Mark Rowe. 4045 4046 ForwardingHeaders/wtf is no longer necessary (or functional) now that JavaScriptCore 4047 no longer includes the WTF headers as private headers. 4048 4049 * ForwardingHeaders/wtf/ASCIICType.h: Removed. 4050 * ForwardingHeaders/wtf/AlwaysInline.h: Removed. 4051 * ForwardingHeaders/wtf/Assertions.h: Removed. 4052 * ForwardingHeaders/wtf/Deque.h: Removed. 4053 * ForwardingHeaders/wtf/DisallowCType.h: Removed. 4054 * ForwardingHeaders/wtf/FastMalloc.h: Removed. 4055 * ForwardingHeaders/wtf/Forward.h: Removed. 4056 * ForwardingHeaders/wtf/GetPtr.h: Removed. 4057 * ForwardingHeaders/wtf/HashCountedSet.h: Removed. 4058 * ForwardingHeaders/wtf/HashMap.h: Removed. 4059 * ForwardingHeaders/wtf/HashSet.h: Removed. 4060 * ForwardingHeaders/wtf/HashTraits.h: Removed. 4061 * ForwardingHeaders/wtf/ListHashSet.h: Removed. 4062 * ForwardingHeaders/wtf/ListRefPtr.h: Removed. 4063 * ForwardingHeaders/wtf/Locker.h: Removed. 4064 * ForwardingHeaders/wtf/MathExtras.h: Removed. 4065 * ForwardingHeaders/wtf/Noncopyable.h: Removed. 4066 * ForwardingHeaders/wtf/OwnArrayPtr.h: Removed. 4067 * ForwardingHeaders/wtf/OwnPtr.h: Removed. 4068 * ForwardingHeaders/wtf/OwnPtrCommon.h: Removed. 4069 * ForwardingHeaders/wtf/PassOwnPtr.h: Removed. 4070 * ForwardingHeaders/wtf/PassRefPtr.h: Removed. 4071 * ForwardingHeaders/wtf/Platform.h: Removed. 4072 * ForwardingHeaders/wtf/RefCounted.h: Removed. 4073 * ForwardingHeaders/wtf/RefCountedLeakCounter.h: Removed. 4074 * ForwardingHeaders/wtf/RefPtr.h: Removed. 4075 * ForwardingHeaders/wtf/RetainPtr.h: Removed. 4076 * ForwardingHeaders/wtf/StdLibExtras.h: Removed. 4077 * ForwardingHeaders/wtf/TemporaryChange.h: Removed. 4078 * ForwardingHeaders/wtf/Threading.h: Removed. 4079 * ForwardingHeaders/wtf/UnusedParam.h: Removed. 4080 * ForwardingHeaders/wtf/VMTags.h: Removed. 4081 * ForwardingHeaders/wtf/ValueCheck.h: Removed. 4082 * ForwardingHeaders/wtf/Vector.h: Removed. 4083 * ForwardingHeaders/wtf/VectorTraits.h: Removed. 4084 * ForwardingHeaders/wtf/unicode/Unicode.h: Removed. 4085 * ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h: Removed. 4086 40872012-03-05 Joseph Pecoraro <pecoraro@apple.com> 4088 4089 Web Inspector: Hide dock button when not allowed to dock 4090 https://bugs.webkit.org/show_bug.cgi?id=78575 4091 4092 Reviewed by Pavel Feldman. 4093 4094 * WebCoreSupport/WebInspectorClient.h: 4095 (WebCore): 4096 (WebInspectorClient): 4097 * WebCoreSupport/WebInspectorClient.mm: 4098 (WebInspectorClient::didResizeMainFrame): 4099 41002012-03-05 Gavin Barraclough <barraclough@apple.com> 4101 4102 putByIndex should throw in strict mode 4103 https://bugs.webkit.org/show_bug.cgi?id=80335 4104 4105 Reviewed by Filip Pizlo. 4106 4107 Make the MethodTable PutByIndex trap take a boolean 'shouldThrow' parameter. 4108 4109 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 4110 (WebKit::NetscapePluginInstanceProxy::setProperty): 4111 41122012-03-05 Joseph Pecoraro <pecoraro@apple.com> 4113 4114 Unreviewed rollout of r109858 for restructuring. 4115 41162012-03-05 Joseph Pecoraro <pecoraro@apple.com> 4117 4118 <http://webkit.org/b/78575> Web Inspector: Hide dock button when not allowed to dock 4119 4120 Reviewed by Timothy Hatcher. 4121 4122 * WebCoreSupport/WebInspectorClient.h: 4123 (WebInspectorClient): 4124 * WebCoreSupport/WebInspectorClient.mm: 4125 (WebInspectorClient::updateDockingAvailability): 4126 41272012-03-02 Jon Lee <jonlee@apple.com> 4128 4129 Add support for notification replaceId in Mac WebKit and WK2 4130 https://bugs.webkit.org/show_bug.cgi?id=80206 4131 <rdar://problem/10965574> 4132 4133 Reviewed by Sam Weinig. 4134 4135 * WebView/WebNotification.h: Add replaceID method. 4136 * WebView/WebNotification.mm: 4137 (-[WebNotification replaceID]): 4138 41392012-03-05 Adam Barth <abarth@webkit.org> 4140 4141 Geolocation should use a ScriptExecutionContext as its context object 4142 https://bugs.webkit.org/show_bug.cgi?id=80248 4143 4144 Reviewed by Kentaro Hara. 4145 4146 * WebView/WebFrame.mm: 4147 (-[WebFrame _cacheabilityDictionary]): 4148 - We no longer special-case Geolocation. 4149 41502012-03-03 Benjamin Poulain <benjamin@webkit.org> 4151 4152 Remove the redundant method KURL::protocolInHTTPFamily() 4153 https://bugs.webkit.org/show_bug.cgi?id=80216 4154 4155 Reviewed by Anders Carlsson. 4156 4157 * WebCoreSupport/WebFrameLoaderClient.mm: 4158 (WebFrameLoaderClient::createPlugin): 4159 41602012-03-03 Hans Wennborg <hans@chromium.org> 4161 4162 Implement Speech JavaScript API 4163 https://bugs.webkit.org/show_bug.cgi?id=80019 4164 4165 Reviewed by Adam Barth. 4166 4167 Add ENABLE_SCRIPTED_SPEECH. 4168 4169 * Configurations/FeatureDefines.xcconfig: 4170 41712012-03-03 Anders Carlsson <andersca@apple.com> 4172 4173 Fix build with newer versions of clang. 4174 4175 * Panels/WebAuthenticationPanel.m: 4176 (-[WebAuthenticationPanel setUpForChallenge:]): 4177 Use %ld and cast to long. 4178 4179 * Plugins/WebNetscapePluginView.mm: 4180 (-[WebNetscapePluginView getVariable:value:]): 4181 Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type. 4182 41832012-03-01 Nikolas Zimmermann <nzimmermann@rim.com> 4184 4185 Unreviewed, rolling out r109255. 4186 http://trac.webkit.org/changeset/109255 4187 https://bugs.webkit.org/show_bug.cgi?id=79932 4188 4189 Breaks rounded rects with dashed strokes in SVG 4190 4191 * WebCoreSupport/WebSystemInterface.mm: 4192 (InitWebCoreSystemInterface): 4193 41942012-02-29 Adam Barth <abarth@webkit.org> 4195 4196 ScriptExecutionContext has too many ifdef ENABLE(SQL_DATABASE) 4197 https://bugs.webkit.org/show_bug.cgi?id=79633 4198 4199 Reviewed by Eric Seidel. 4200 4201 * WebView/WebFrame.mm: 4202 (-[WebFrame _cacheabilityDictionary]): 4203 42042012-02-29 Tim Horton <timothy_horton@apple.com> 4205 4206 Make use of CG rounded-rect primitives 4207 https://bugs.webkit.org/show_bug.cgi?id=79932 4208 <rdar://problem/9274953> 4209 4210 Reviewed by Simon Fraser. 4211 4212 Add wkCGPathAddRoundedRect. 4213 4214 * WebCoreSupport/WebSystemInterface.mm: 4215 (InitWebCoreSystemInterface): 4216 42172012-02-29 Enrica Casucci <enrica@apple.com> 4218 4219 Crash at -[WebFrame(WebInternal) _setTypingStyle:withUndoAction:] 4220 https://bugs.webkit.org/show_bug.cgi?id=79937 4221 <rdar://problem/10942936> 4222 4223 Reviewed by Dan Bernstein. 4224 4225 * WebView/WebFrame.mm: 4226 (-[WebFrame _setTypingStyle:withUndoAction:]): Adding a null check. 4227 42282012-02-28 Simon Fraser <simon.fraser@apple.com> 4229 4230 Update WebKitSystemInterface. 4231 4232 Reviewed by Sam Weinig. 4233 4234 * WebCoreSupport/WebSystemInterface.mm: 4235 (InitWebCoreSystemInterface): 4236 42372012-02-28 Enrica Casucci <enrica@apple.com> 4238 4239 More Pasteboard code cleanup. 4240 https://bugs.webkit.org/show_bug.cgi?id=79816 4241 4242 Removing the last references to NSPasteboard. 4243 4244 Reviewed by Alexey Proskuryakov. 4245 4246 * WebCoreSupport/WebEditorClient.h: 4247 * WebCoreSupport/WebEditorClient.mm: 4248 (WebEditorClient::setInsertionPasteboard): 4249 42502012-02-26 Hajime Morrita <morrita@chromium.org> 4251 4252 Move ChromeClient::showContextMenu() to ContextMenuClient 4253 https://bugs.webkit.org/show_bug.cgi?id=79427 4254 4255 Reviewed by Adam Barth. 4256 4257 * WebCoreSupport/WebContextMenuClient.h: 4258 (WebContextMenuClient): 4259 * WebCoreSupport/WebContextMenuClient.mm: 4260 (WebContextMenuClient::showContextMenu): Moved from WebChromeClient 4261 * WebCoreSupport/WebChromeClient.h: 4262 * WebCoreSupport/WebChromeClient.mm: 4263 42642012-02-25 Sam Weinig <sam@webkit.org> 4265 4266 QuickLook events don't make it to WebKit plugins. 4267 <rdar://problem/10931721> 4268 4269 Reviewed by Anders Carlsson. 4270 4271 * WebView/WebHTMLView.mm: 4272 (isQuickLookEvent): 4273 (-[WebHTMLView hitTest:]): 4274 Allow QuickLook events to hit test down to subviews. 4275 42762012-02-24 Brady Eidson <beidson@apple.com> 4277 4278 <rdar://problem/10805709> and https://bugs.webkit.org/show_bug.cgi?id=79421 4279 Need a WK1 Mac API to filter which subframes go into WebArchives as they are created 4280 4281 Reviewed by Sam Weinig (with additional comments by Adam Roben) 4282 4283 Add webArchiveByFilteringSubframes: which takes a callback block: 4284 * DOM/WebDOMOperationsPrivate.h: 4285 4286 Add FrameFilter that adapts the block, and use it to implement the new SPI: 4287 * DOM/WebDOMOperations.mm: 4288 (WebFrameFilter): 4289 (WebFrameFilter::WebFrameFilter): 4290 (WebFrameFilter::~WebFrameFilter): 4291 (WebFrameFilter::shouldIncludeSubframe): 4292 (-[DOMNode webArchiveByFilteringSubframes:]): 4293 42942012-02-24 Shinya Kawanaka <shinyak@chromium.org> 4295 4296 SpellCheckRequest needs to know the context where the spellcheck happened. 4297 https://bugs.webkit.org/show_bug.cgi?id=79320 4298 4299 Reviewed by Hajime Morita. 4300 4301 * WebCoreSupport/WebEditorClient.h: 4302 * WebCoreSupport/WebEditorClient.mm: 4303 (WebEditorClient::requestCheckingOfString): 4304 43052012-02-23 Andy Estes <aestes@apple.com> 4306 4307 Rename [setS|s]uppressIncrementalRendering to [setS|s]uppressesIncrementalRendering and make it WebPreferences API. 4308 https://bugs.webkit.org/show_bug.cgi?id=79433 4309 4310 Reviewed by Dan Bernstein. 4311 4312 * WebCoreSupport/WebInspectorClient.mm: 4313 (-[WebInspectorWindowController init]): 4314 * WebView/WebPreferenceKeysPrivate.h: 4315 * WebView/WebPreferences.h: 4316 * WebView/WebPreferences.mm: 4317 (+[WebPreferences initialize]): 4318 (-[WebPreferences setSuppressesIncrementalRendering:]): 4319 (-[WebPreferences suppressesIncrementalRendering]): 4320 (-[WebPreferences setSuppressIncrementalRendering:]): 4321 (-[WebPreferences suppressIncrementalRendering]): 4322 * WebView/WebView.mm: 4323 (-[WebView _preferencesChanged:]): 4324 43252012-02-22 Hajime Morrita <morrita@chromium.org> 4326 4327 NOTIFICATIONS should be implemented as PageSupplement 4328 https://bugs.webkit.org/show_bug.cgi?id=79052 4329 4330 Reviewed by Adam Barth. 4331 4332 * WebView/WebView.mm: 4333 (-[WebView _commonInitializationWithFrameName:groupName:]): 4334 43352012-02-21 Ryosuke Niwa <rniwa@webkit.org> 4336 4337 Remove the remaining uses of CSSStyleDeclaration in Editor 4338 https://bugs.webkit.org/show_bug.cgi?id=78939 4339 4340 Reviewed by Enrica Casucci. 4341 4342 * WebCoreSupport/WebEditorClient.h: 4343 (WebEditorClient): 4344 * WebCoreSupport/WebEditorClient.mm: 4345 (WebEditorClient::shouldApplyStyle): 4346 * WebView/WebFrame.mm: 4347 (-[WebFrame _setTypingStyle:withUndoAction:]): 4348 * WebView/WebHTMLView.mm: 4349 (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): 4350 (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]): 4351 * WebView/WebView.mm: 4352 (-[WebView applyStyle:]): 4353 43542012-02-22 Ryosuke Niwa <rniwa@webkit.org> 4355 4356 Remove the remaining uses of CSSStyleDeclaration in Editor 4357 https://bugs.webkit.org/show_bug.cgi?id=78939 4358 4359 Reviewed by Enrica Casucci. 4360 4361 * WebCoreSupport/WebEditorClient.h: 4362 (WebEditorClient): 4363 * WebCoreSupport/WebEditorClient.mm: 4364 (WebEditorClient::shouldApplyStyle): 4365 * WebView/WebFrame.mm: 4366 (-[WebFrame _setTypingStyle:withUndoAction:]): 4367 * WebView/WebHTMLView.mm: 4368 (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): 4369 (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]): 4370 * WebView/WebView.mm: 4371 (-[WebView applyStyle:]): 4372 43732012-02-22 Jon Lee <jonlee@apple.com> 4374 4375 Part of r108409 was incorrect, and incorporated an older version of a sub-patch. 4376 This is the actual sub-patch that should have been submitted. 4377 4378 * WebCoreSupport/WebNotificationClient.h: 4379 * WebCoreSupport/WebNotificationClient.mm: 4380 (WebNotificationClient::show): 4381 (WebNotificationClient::cancel): 4382 (WebNotificationClient::clearNotifications): 4383 (WebNotificationClient::notificationObjectDestroyed): 4384 (WebNotificationClient::notificationControllerDestroyed): 4385 43862012-02-21 Jon Lee <jonlee@apple.com> 4387 4388 Build fix. Push ENABLE_NOTIFICATIONS into .mm file. 4389 4390 * WebCoreSupport/WebNotificationClient.h: 4391 * WebView/WebNotification.h: 4392 * WebView/WebNotification.mm: 4393 (-[WebNotification title]): 4394 (-[WebNotification body]): 4395 (-[WebNotification origin]): 4396 (-[WebNotification notificationID]): 4397 (-[WebNotification dispatchShowEvent]): 4398 (-[WebNotification dispatchCloseEvent]): 4399 (-[WebNotification dispatchClickEvent]): 4400 (-[WebNotification dispatchErrorEvent]): 4401 44022012-02-21 John Sullivan <sullivan@apple.com> 4403 4404 Build fix. 4405 4406 * WebView/WebUIDelegatePrivate.h: 4407 Added @class declarations for DOMNode and DOMElement. 4408 44092012-02-21 Jon Lee <jonlee@apple.com> 4410 4411 Build fix for r108409. 4412 4413 * WebCoreSupport/WebNotificationClient.h: 4414 (WebCore): 4415 * WebCoreSupport/WebNotificationClient.mm: 4416 * WebView/WebNotification.h: 4417 (WebSecurityOrigin): 4418 * WebView/WebNotification.mm: 4419 (core): 4420 (-[WebNotification initWithCoreNotification:notificationID:]): 4421 44222012-02-21 Jon Lee <jonlee@apple.com> 4423 4424 Bring notifications support to WK1 mac: permission requests 4425 https://bugs.webkit.org/show_bug.cgi?id=78783 4426 <rdar://problem/10610578> 4427 4428 Reviewed by Anders Carlsson. 4429 4430 * WebCoreSupport/WebNotificationClient.h: 4431 * WebCoreSupport/WebNotificationClient.mm: Create policy listener, which conforms to the 4432 WebAllowDenyPolicyListener protocol, similar to geolocation. 4433 (WebNotificationClient::requestPermission): 4434 (WebNotificationClient::checkPermission): 4435 (-[WebNotificationPolicyListener initWithCallback:]): 4436 (-[WebNotificationPolicyListener allow]): Call the callback. 4437 (-[WebNotificationPolicyListener deny]): Call the callback. 4438 * WebView/WebUIDelegatePrivate.h: Define new UI delegate method to ask the user to decide a 4439 policy for navigations. 4440 4441 ==== 4442 Bring notifications support to WK1 mac: showing, canceling, removing notifications 4443 4444 Create a WebKit wrapper object for WebCore::Notification, which also keeps track of an assigned 4445 ID. 4446 * WebView/WebNotification.h: Added. 4447 (WebSecurityOrigin): 4448 * WebView/WebNotification.mm: Added. 4449 (core): 4450 (-[WebNotification initWithCoreNotification:notificationID:]): 4451 (-[WebNotification init]): 4452 (-[WebNotification dealloc]): 4453 (-[WebNotification title]): 4454 (-[WebNotification body]): 4455 (-[WebNotification origin]): 4456 (-[WebNotification notificationID]): 4457 (-[WebNotification dispatchShowEvent]): 4458 (-[WebNotification dispatchCloseEvent]): 4459 (-[WebNotification dispatchClickEvent]): 4460 (-[WebNotification dispatchErrorEvent]): 4461 * WebView/WebNotificationInternal.h: Added. 4462 (WebCore): Internal category to allow creating instances with WebCore objects. 4463 4464 Extend WebView to include a WebNotificationProvider, which clients implement. 4465 * WebView/WebViewData.h: Add a private member for the provider. 4466 * WebView/WebViewPrivate.h: 4467 * Define an enum WebNotificationPermission that mirrors WebCore::NotificationPresenter::Permission 4468 that client which implement the provider can use to return policy decisions. 4469 * Define WebNotificationProvider. 4470 * Category WebViewNotification extends WebView with methods that set and manager the 4471 notification provider, and handle events from the platform notifications. 4472 * WebView/WebView.mm: 4473 (-[WebView _setNotificationProvider:]): Sets the provider when initializing the WebView. 4474 (-[WebView _notificationControllerDestroyed]): 4475 (-[WebView _notificationProvider]): 4476 (-[WebView _notificationDidShow:]): 4477 (-[WebView _notificationDidClick:]): 4478 (-[WebView _notificationsDidClose:]): 4479 4480 * WebCoreSupport/WebNotificationClient.h: Add variables that map between WebCore::Notification 4481 instances, their assigned IDs, their contexts, and corresponding WebKit wrapper objects. 4482 * WebCoreSupport/WebNotificationClient.mm: 4483 (generateNotificationID): Created unique IDs for each shown notification. 4484 (WebNotificationClient::show): Create wrapper object for notification, assign ID, cache the 4485 mappings between the objects, and forward it to the provider. 4486 (WebNotificationClient::cancel): 4487 (WebNotificationClient::clearNotifications): Clear all notifications associated with the 4488 provided context. 4489 (WebNotificationClient::notificationObjectDestroyed): Remove the notification from the maps. 4490 (WebNotificationClient::notificationControllerDestroyed): If the controller is destroyed, tell 4491 the provider to clear of the notifications related to this web view. 4492 4493 ==== 4494 (Prep work for) Bring notifications support to WK1 mac 4495 4496 Rename WebGeolocationPolicyListener. The interface is generic enough to be reused for 4497 notification requests. To avoid having to create a new listener type, instead rename it 4498 to WebAllowDenyPolicyListener. 4499 * WebView/WebUIDelegatePrivate.h: Rename the protocol. 4500 * WebCoreSupport/WebGeolocationClient.mm: Refactor geolocation request listener to use 4501 new name. 4502 4503 Add preference to keep track of whether notifications are enabled in general. 4504 * WebView/WebPreferenceKeysPrivate.h: Add WebNotificationsEnabledKey for storing the 4505 preference. 4506 * WebView/WebPreferences.mm: 4507 (+[WebPreferences initialize]): By default have them enabled. 4508 (-[WebPreferences setNotificationsEnabled:]): 4509 (-[WebPreferences notificationsEnabled]): 4510 * WebView/WebPreferencesPrivate.h: 4511 4512 Add a stringValue method that exposes WebCore::SecurityOrigin::toString() for storing the 4513 notification policy for a given origin. 4514 * WebCoreSupport/WebSecurityOrigin.mm: 4515 (-[WebSecurityOrigin stringValue]): 4516 * WebCoreSupport/WebSecurityOriginPrivate.h: 4517 45182012-02-21 Sam Weinig <sam@webkit.org> 4519 4520 Attempt to fix the Snow Leopard build. 4521 4522 * Configurations/Base.xcconfig: 4523 45242012-02-21 Sam Weinig <sam@webkit.org> 4525 4526 Use libc++ when building with Clang on Mac 4527 https://bugs.webkit.org/show_bug.cgi?id=78981 4528 4529 Reviewed by Dan Bernstein. 4530 4531 * Configurations/Base.xcconfig: 4532 45332012-02-17 Mihnea Ovidenie <mihnea@adobe.com> 4534 4535 CSS regions enabled by default 4536 https://bugs.webkit.org/show_bug.cgi?id=78525 4537 4538 Reviewed by David Hyatt. 4539 4540 Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled). 4541 CSSRegions are still enabled by default. 4542 In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality. 4543 4544 * WebView/WebPreferenceKeysPrivate.h: 4545 * WebView/WebPreferences.mm: 4546 (+[WebPreferences initialize]): 4547 (-[WebPreferences cssRegionsEnabled]): 4548 (-[WebPreferences setCSSRegionsEnabled:]): 4549 * WebView/WebPreferencesPrivate.h: 4550 * WebView/WebView.mm: 4551 (-[WebView _preferencesChanged:]): 4552 45532012-02-17 Enrica Casucci <enrica@apple.com> 4554 4555 Refactor DragData class to use PlatformStrategies in the Mac implementation. 4556 https://bugs.webkit.org/show_bug.cgi?id=78768 4557 4558 Reviewed by Darin Adler. 4559 4560 * WebCoreSupport/WebPlatformStrategies.h: Added color() method. 4561 * WebCoreSupport/WebPlatformStrategies.mm: 4562 (WebPlatformStrategies::color): 4563 45642012-02-16 Brady Eidson <beidson@apple.com> 4565 4566 <rdar://problem/10616280> and https://bugs.webkit.org/show_bug.cgi?id=78767 4567 REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages 4568 4569 Reviewed by Sam Weinig. 4570 4571 * WebView/WebView.mm: 4572 (-[WebView _needsIsLoadingInAPISenseQuirk]): 4573 (-[WebView _preferencesChanged:]): 4574 45752012-02-15 Enrica Casucci <enrica@apple.com> 4576 4577 Refactor ClipboardMac class to use PlatformStrategies. 4578 https://bugs.webkit.org/show_bug.cgi?id=78554 4579 4580 Reviewed by Anders Carlsson. 4581 4582 * WebCoreSupport/WebDragClient.h: Changed methods signature to use name based pasteboard. 4583 * WebCoreSupport/WebDragClient.mm: Ditto. 4584 (WebDragClient::willPerformDragSourceAction): 4585 (WebDragClient::startDrag): 4586 (WebDragClient::declareAndWriteDragImage): 4587 * WebCoreSupport/WebPlatformStrategies.h: Added new methods. 4588 * WebCoreSupport/WebPlatformStrategies.mm: 4589 (WebPlatformStrategies::changeCount): 4590 (WebPlatformStrategies::uniqueName): 4591 45922012-02-15 Sadrul Habib Chowdhury <sadrul@chromium.org> 4593 4594 Notify ChromeClient when touch-event handlers are installed/removed. 4595 https://bugs.webkit.org/show_bug.cgi?id=77440 4596 4597 Reviewed by Darin Fisher and Ryosuke Niwa. 4598 4599 * WebCoreSupport/WebChromeClient.h: 4600 46012012-02-14 Matt Lilek <mrl@apple.com> 4602 4603 Don't ENABLE_DASHBOARD_SUPPORT unconditionally on all Mac platforms 4604 https://bugs.webkit.org/show_bug.cgi?id=78629 4605 4606 Reviewed by David Kilzer. 4607 4608 * Configurations/FeatureDefines.xcconfig: 4609 46102012-02-14 Alexey Proskuryakov <ap@apple.com> 4611 4612 [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets 4613 https://bugs.webkit.org/show_bug.cgi?id=78541 4614 <rdar://problem/10036695> 4615 4616 Reviewed by Kent Tamura. 4617 4618 * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default value of the 4619 preference. 4620 46212012-02-11 Nikolas Zimmermann <nzimmermann@rim.com> 4622 4623 Convert svg/animations to use SMIL methods for driving the timeline 4624 https://bugs.webkit.org/show_bug.cgi?id=78422 4625 4626 Reviewed by Dirk Schulze. 4627 4628 Remove SVG animation sampling functionality provided for DRT, which no longer uses it. 4629 Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime. 4630 4631 * WebKit.order: 4632 * WebView/WebFrame.mm: 4633 * WebView/WebFramePrivate.h: 4634 46352012-02-13 Enrica Casucci <enrica@apple.com> 4636 4637 Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies. 4638 https://bugs.webkit.org/show_bug.cgi?id=78282 4639 4640 This patch removes any accesss to the NSPasteboard object from the Pasteboard class which 4641 now makes use of a new pasteboardStrategy object that is implemented both in WebKit and 4642 WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard 4643 class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy 4644 interface but this one more step in the direction of removing access to NSPasteboard from 4645 the WebProcess. 4646 As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes. 4647 4648 Reviewed by Anders Carlsson. 4649 4650 * WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy. 4651 * WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface. 4652 (WebPlatformStrategies::createPasteboardStrategy): 4653 (WebPlatformStrategies::getTypes): 4654 (WebPlatformStrategies::bufferForType): 4655 (WebPlatformStrategies::getPathnamesForType): 4656 (WebPlatformStrategies::stringForType): 4657 (WebPlatformStrategies::copy): 4658 (WebPlatformStrategies::setTypes): 4659 (WebPlatformStrategies::setBufferForType): 4660 (WebPlatformStrategies::setPathnamesForType): 4661 (WebPlatformStrategies::setStringForType): 4662 46632012-02-12 Hajime Morrita <morrita@chromium.org> 4664 4665 Page should have less intrusive way to associate API implementation objects. 4666 https://bugs.webkit.org/show_bug.cgi?id=78085 4667 4668 Reviewed by Adam Barth. 4669 4670 * WebView/WebView.mm: 4671 (-[WebView _commonInitializationWithFrameName:groupName:]): 4672 46732012-02-11 Sheriff Bot <webkit.review.bot@gmail.com> 4674 4675 Unreviewed, rolling out r107435. 4676 http://trac.webkit.org/changeset/107435 4677 https://bugs.webkit.org/show_bug.cgi?id=78410 4678 4679 It broke the Qt build (Requested by Ossy on #webkit). 4680 4681 * WebCoreSupport/WebPlatformStrategies.h: 4682 (WebPlatformStrategies): 4683 * WebCoreSupport/WebPlatformStrategies.mm: 4684 (WebPlatformStrategies::addVisitedLink): 4685 46862012-02-10 Adam Klein <adamk@chromium.org> 4687 4688 Enable MUTATION_OBSERVERS by default on all platforms 4689 https://bugs.webkit.org/show_bug.cgi?id=78196 4690 4691 Reviewed by Ojan Vafai. 4692 4693 * Configurations/FeatureDefines.xcconfig: 4694 46952012-02-10 Enrica Casucci <enrica@apple.com> 4696 4697 Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies. 4698 https://bugs.webkit.org/show_bug.cgi?id=78282 4699 4700 This patch removes any accesss to the NSPasteboard object from the Pasteboard class which 4701 now makes use of a new pasteboardStrategy object that is implemented both in WebKit and 4702 WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard 4703 class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy 4704 interface but this one more step in the direction of removing access to NSPasteboard from 4705 the WebProcess. 4706 As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes. 4707 4708 Reviewed by Anders Carlsson. 4709 4710 * WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy. 4711 * WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface. 4712 (WebPlatformStrategies::createPasteboardStrategy): 4713 (WebPlatformStrategies::getTypes): 4714 (WebPlatformStrategies::bufferForType): 4715 (WebPlatformStrategies::getPathnamesForType): 4716 (WebPlatformStrategies::stringForType): 4717 (WebPlatformStrategies::copy): 4718 (WebPlatformStrategies::setTypes): 4719 (WebPlatformStrategies::setBufferForType): 4720 (WebPlatformStrategies::setPathnamesForType): 4721 (WebPlatformStrategies::setStringForType): 4722 47232012-02-10 Benjamin Poulain <bpoulain@apple.com> 4724 4725 [Mac] DYLIB_INSTALL_NAME_BASE should not be prefixed by the SDKROOT 4726 https://bugs.webkit.org/show_bug.cgi?id=78320 4727 4728 Reviewed by Joseph Pecoraro. 4729 4730 <rdar://problem/10839750> 4731 4732 * Configurations/WebKit.xcconfig: 4733 47342012-02-09 Alexey Proskuryakov <ap@apple.com> 4735 4736 REGRESSION (r104885): Articles not displayed in Vienna RSS reader 4737 https://bugs.webkit.org/show_bug.cgi?id=78280 4738 <rdar://problem/10762545> 4739 4740 Reviewed by Oliver Hunt. 4741 4742 * Misc/WebNSURLExtras.h: 4743 * Misc/WebNSURLExtras.mm: (-[NSURL _webkit_URLFromURLOrPath]): 4744 Added a method to create a URL from a path, similarly to what KURL used to do. 4745 4746 * WebView/WebFrame.mm: (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): 4747 Use it in an API where a known regression occurred. 4748 47492012-02-07 Antti Koivisto <antti@apple.com> 4750 4751 REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle] 4752 https://bugs.webkit.org/show_bug.cgi?id=78080 4753 4754 Reviewed by Reviewed by Andreas Kling, Darin Adler and Dan Bernstein. 4755 4756 * WebView/WebFrame.mm: 4757 (-[WebFrame _typingStyle]): 4758 47592012-02-07 Tony Chang <tony@chromium.org> 4760 4761 merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in 4762 https://bugs.webkit.org/show_bug.cgi?id=78036 4763 4764 Reviewed by Darin Adler. 4765 4766 * Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES. 4767 47682012-02-06 Anders Carlsson <andersca@apple.com> 4769 4770 Overlay scrollbars flash when window is simply activated 4771 https://bugs.webkit.org/show_bug.cgi?id=77911 4772 <rdar://problem/10211995> 4773 4774 Reviewed by Kenneth Russell. 4775 4776 * WebView/WebView.mm: 4777 (-[WebView _windowWillOrderOnScreen:]): 4778 (-[WebView _windowWillOrderOffScreen:]): 4779 Call FocusController::setContainingWindowIsVisible. 4780 4781 47822012-02-06 Matthew Delaney <mdelaney@apple.com> 4783 4784 toDataURL() uses stale data after putImageData() 4785 https://bugs.webkit.org/show_bug.cgi?id=65767 4786 4787 Reviewed by Chris Marrin. 4788 4789 * WebCoreSupport/WebSystemInterface.mm: 4790 47912012-02-03 Antti Koivisto <antti@apple.com> 4792 4793 Rename CSSMutableStyleDeclaration.h/.cpp to StylePropertySet.h/.cpp 4794 https://bugs.webkit.org/show_bug.cgi?id=77779 4795 4796 Reviewed by Darin Adler. 4797 4798 * WebView/WebHTMLView.mm: 4799 48002012-02-03 Antti Koivisto <antti@apple.com> 4801 4802 https://bugs.webkit.org/show_bug.cgi?id=77740 4803 Split CSSMutableStyleDeclaration into separate internal and CSSOM types 4804 4805 Reviewed by Andreas Kling and Darin Adler. 4806 4807 * WebView/WebFrame.mm: 4808 (-[WebFrame _typingStyle]): 4809 48102012-02-03 Beth Dakin <bdakin@apple.com> 4811 4812 https://bugs.webkit.org/show_bug.cgi?id=77691 4813 Fix PlatformScreen layering violation and PlatformScreenMac's incorrect use 4814 of device scale 4815 4816 Reviewed by Andy Estes. 4817 4818 toUserSpace() and toDeviceSpace() don't need to take device scale. Also 4819 restore a comment that I needlessly removed. 4820 * WebCoreSupport/WebChromeClient.mm: 4821 (WebChromeClient::setWindowRect): 4822 (WebChromeClient::windowRect): 4823 48242012-02-01 Dan Bernstein <mitz@apple.com> 4825 4826 WebKit/mac part of <rdar://problem/10442663> Paginated display does not respect page-break-{before,after} 4827 https://bugs.webkit.org/show_bug.cgi?id=77505 4828 4829 Reviewed by Darin Adler. 4830 4831 * WebView/WebView.mm: 4832 (-[WebView _setPaginationBehavesLikeColumns:]): Added this setter. 4833 (-[WebView _paginationBehavesLikeColumns]): Added this getter. 4834 * WebView/WebViewPrivate.h: 4835 48362012-01-25 Eric Seidel <eric@webkit.org> 4837 4838 HTMLIsIndexElement should not expose HTMLInputElement properties 4839 https://bugs.webkit.org/show_bug.cgi?id=76095 4840 4841 Reviewed by Adam Barth. 4842 4843 * MigrateHeaders.make: 4844 48452012-01-31 Pablo Flouret <pablof@motorola.com> 4846 4847 Fix compilation errors on build-webkit --debug --no-workers on mac. 4848 https://bugs.webkit.org/show_bug.cgi?id=75869 4849 4850 Reviewed by Adam Barth. 4851 4852 * Workers/WebWorkersPrivate.mm: 4853 (+[WebWorkersPrivate workerThreadCount]): 4854 48552012-01-30 Beth Dakin <bdakin@apple.com> 4856 4857 https://bugs.webkit.org/show_bug.cgi?id=77263 4858 PlatformScreenMac should not rely on NSWindow for important bits of data 4859 4860 Reviewed by Geoff Garen. 4861 4862 toUserSpace() and toDeviceSpace() now take a parameter for the 4863 deviceScaleFactor. 4864 * WebCoreSupport/WebChromeClient.mm: 4865 (windowScaleFactor): 4866 (WebChromeClient::setWindowRect): 4867 (WebChromeClient::windowRect): 4868 48692012-01-25 Mark Rowe <mrowe@apple.com> 4870 4871 Build in to an alternate location when USE_STAGING_INSTALL_PATH is set. 4872 4873 <rdar://problem/10609417> Adopt USE_STAGING_INSTALL_PATH 4874 4875 Reviewed by David Kilzer. 4876 4877 * Configurations/WebKit.xcconfig: Define NORMAL_WEBKIT_FRAMEWORKS_DIR, which contains 4878 the path where WebKit is normally installed. Update WEBKIT_FRAMEWORKS_DIR to point to 4879 the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Define 4880 NORMAL_PRODUCTION_FRAMEWORKS_DIR, which contains the path where our public frameworks 4881 are normally installed. Update PRODUCTION_FRAMEWORKS_DIR to point to the staged frameworks 4882 directory when USE_STAGING_INSTALL_PATH is set. Always set the framework's install name 4883 based on the normal framework location. This prevents an incorrect install name from being 4884 used when installing in to the staged frameworks directory. Look for our other frameworks 4885 in the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Update 4886 WEBCORE_PRIVATE_HEADERS_DIR to find WebCore at the top level of the staged frameworks 4887 directory when USE_STAGING_INSTALL_PATH is set, rather than finding it embedded inside of 4888 WebKit.framework. 4889 48902012-01-25 Eric Seidel <eric@webkit.org> 4891 4892 HTMLIsIndexElement should not expose HTMLInputElement properties 4893 https://bugs.webkit.org/show_bug.cgi?id=76095 4894 4895 Reviewed by Adam Barth. 4896 4897 * MigrateHeaders.make: 4898 48992012-01-25 Hajime Morita <morrita@google.com> 4900 4901 ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom 4902 https://bugs.webkit.org/show_bug.cgi?id=76863 4903 4904 Reviewed by Dimitri Glazkov. 4905 4906 Added a feature flag. 4907 4908 * Configurations/FeatureDefines.xcconfig: 4909 49102012-01-25 Enrica Casucci <enrica@apple.com> 4911 4912 WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail. 4913 https://bugs.webkit.org/show_bug.cgi?id=76951 4914 <rdar://problem/9325158> 4915 4916 Reviewed by Alexey Proskuryakov. 4917 4918 * WebView/WebHTMLView.mm: Removed typingAttributes implementation. 4919 * WebView/WebView.mm: 4920 (-[WebView typingAttributes]): Added. 4921 49222012-01-24 Enrica Casucci <enrica@apple.com> 4923 4924 WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail. 4925 https://bugs.webkit.org/show_bug.cgi?id=76951 4926 <rdar://problem/9325158> 4927 4928 The Inspector bar calls the typingAttributes methods on the clients that support it 4929 to retrieve the set of attributes representing the style at the selection and uses 4930 this information to update the state of the B, I and U buttons. 4931 If this method is not supported, it defaults to the attributes of the previous 4932 character position, reporting an incorrect state. 4933 This occurs only when we have a caret selection. 4934 4935 Reviewed by Alexey Proskuryakov. 4936 4937 * WebView/WebHTMLView.mm: 4938 (-[WebHTMLView _styleForAttributeChange:]): Removed dead code. 4939 (-[WebHTMLView _updateFontPanel]): Removed comment that doesn't apply anymore. 4940 (-[WebHTMLView typingAttributes]): Added. 4941 49422012-01-24 Benjamin Poulain <bpoulain@apple.com> 4943 4944 pageCacheSupportsPlugins should default to true on WebKit1 4945 https://bugs.webkit.org/show_bug.cgi?id=76891 4946 4947 Reviewed by Joseph Pecoraro. 4948 4949 The default was left out of r102619 by accident. 4950 4951 * WebView/WebPreferences.mm: 4952 (+[WebPreferences initialize]): 4953 49542012-01-23 Geoffrey Garen <ggaren@apple.com> 4955 4956 JSValue::toString() should return a JSString* instead of a UString 4957 https://bugs.webkit.org/show_bug.cgi?id=76861 4958 4959 Reviewed by Gavin Barraclough. 4960 4961 Mechanical changes to call value() after calling toString(), to 4962 convert from "JS string" (JSString*) to "C++ string" (UString), since 4963 toString() no longer returns a "C++ string". 4964 4965 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 4966 (WebKit::NetscapePluginInstanceProxy::addValueToArray): 4967 * WebView/WebFrame.mm: 4968 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): 4969 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): 4970 49712012-01-20 Sam Weinig <sam@webkit.org> 4972 4973 Make WebCore RunLoop work for WebKit1 4974 https://bugs.webkit.org/show_bug.cgi?id=76739 4975 4976 Reviewed by Anders Carlsson. 4977 4978 * Carbon/CarbonWindowAdapter.mm: 4979 (+[CarbonWindowAdapter initialize]): 4980 * History/WebBackForwardList.mm: 4981 (+[WebBackForwardList initialize]): 4982 * History/WebHistoryItem.mm: 4983 (+[WebHistoryItem initialize]): 4984 * Misc/WebElementDictionary.mm: 4985 (+[WebElementDictionary initialize]): 4986 * Misc/WebIconDatabase.mm: 4987 (+[WebIconDatabase initialize]): 4988 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 4989 (+[WebHostedNetscapePluginView initialize]): 4990 * Plugins/WebBaseNetscapePluginView.mm: 4991 * Plugins/WebBasePluginPackage.mm: 4992 * Plugins/WebNetscapePluginView.mm: 4993 (+[WebNetscapePluginView initialize]): 4994 * WebCoreSupport/WebEditorClient.mm: 4995 (+[WebUndoStep initialize]): 4996 * WebCoreSupport/WebFrameLoaderClient.mm: 4997 * WebView/WebArchive.mm: 4998 (+[WebArchivePrivate initialize]): 4999 * WebView/WebDataSource.mm: 5000 (+[WebDataSourcePrivate initialize]): 5001 * WebView/WebHTMLView.mm: 5002 (+[WebHTMLViewPrivate initialize]): 5003 (+[WebHTMLView initialize]): 5004 * WebView/WebResource.mm: 5005 (+[WebResourcePrivate initialize]): 5006 * WebView/WebTextIterator.mm: 5007 (+[WebTextIteratorPrivate initialize]): 5008 * WebView/WebView.mm: 5009 (+[WebView initialize]): 5010 * WebView/WebViewData.mm: 5011 (+[WebViewPrivate initialize]): 5012 Initialized the main run loop in addition to other initialization. 5013 50142012-01-20 Simon Fraser <simon.fraser@apple.com> 5015 5016 https://bugs.webkit.org/show_bug.cgi?id=76444 5017 5018 #if ENABLE(CSS_SHADERS) cannot appear in framework headers. 5019 This breaks builds. 5020 5021 * WebView/WebPreferences.mm: 5022 * WebView/WebPreferencesPrivate.h: 5023 50242012-01-20 Alexandru Chiculita <achicu@adobe.com> 5025 5026 CSS Shaders: Add a Settings flag to enable/disable CSS Shaders at runtime 5027 https://bugs.webkit.org/show_bug.cgi?id=76444 5028 5029 Added private WebPreference property called "WebKitCSSCustomFilterEnabled". 5030 5031 Reviewed by Nikolas Zimmermann. 5032 5033 * WebView/WebPreferenceKeysPrivate.h: 5034 * WebView/WebPreferences.mm: 5035 (+[WebPreferences initialize]): 5036 (-[WebPreferences cssCustomFilterEnabled]): 5037 (-[WebPreferences setCSSCustomFilterEnabled:]): 5038 * WebView/WebPreferencesPrivate.h: 5039 * WebView/WebView.mm: 5040 (-[WebView _preferencesChanged:]): 5041 50422012-01-17 Enrica Casucci <enrica@apple.com> 5043 5044 Missing NSForegroundColorAttributeName should be treated as black instead of transparent. 5045 https://bugs.webkit.org/show_bug.cgi?id=76490 5046 <rdar://problem/9460733> 5047 5048 Starting with Lion, there is no more NSForegroundColor attribute in the dictionary 5049 if the color matches the default (solid black). 5050 The fix consists in treating the lack of color as solid black instead of transparent as 5051 we did before. 5052 5053 Added a TestWebKitAPI test. 5054 5055 Reviewed by Darin Adler and Dan Bernstein. 5056 5057 * WebView/WebHTMLView.mm: 5058 (-[WebHTMLView _styleForAttributeChange:]): 5059 50602012-01-17 Matthew Delaney <mdelaney@apple.com> 5061 5062 On post-Lion releases, preserve the Lion behavior where WebKit explicitly calls -setGeometryFlipped on the hosting layer for applications that were linked on Lion or earlier. 5063 <rdar://problem/10692025> 5064 5065 Reviewed by Simon Fraser. 5066 5067 * WebCoreSupport/WebSystemInterface.mm: Init newly added function. 5068 * WebView/WebHTMLView.mm: Added case for post-Lion builds that calls -setGeometryFlipped if the app is linked on or before Lion. 5069 50702012-01-17 Enrica Casucci <enrica@apple.com> 5071 5072 REGRESSION (r101413): Correction panel overlaps misspelled text. 5073 https://bugs.webkit.org/show_bug.cgi?id=74589 5074 <rdar://problem/10585115> 5075 5076 When converting the rectangle from the root view, we need 5077 to take into account the height of the rectangle. 5078 5079 Reviewed by Anders Carlsson. 5080 5081 * WebView/WebView.mm: 5082 (-[WebView _convertRectFromRootView:]): 5083 50842012-01-16 Simon Fraser <simon.fraser@apple.com> 5085 5086 <rdar://problem/10703228> ASSERTION FAILED: Uncaught exception - Cannot lock focus on image <NSImage 0x1206572a0 Size={0, 0} Reps=( )>, because it is size zero loading techcrunch.com 5087 5088 Reviewed by Anders Carlsson. 5089 5090 Avoid trying to create image snapshots for zero-sized plugins, because 5091 it causes -[NSView lockFocus] to throw an exception. 5092 5093 * Plugins/WebBaseNetscapePluginView.mm: 5094 (-[WebBaseNetscapePluginView cacheSnapshot]): 5095 50962012-01-16 Alexey Proskuryakov <ap@apple.com> 5097 5098 A follow-up fix for: 5099 A warning is logged to console when typing a bare "/" in Safari address bar 5100 https://bugs.webkit.org/show_bug.cgi?id=76236 5101 5102 <rdar://problem/10702986> 5103 5104 Reviewed by John Sullivan. 5105 5106 * Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): It's OK to have a 5107 path when there is a base URL. 5108 51092012-01-16 Jon Lee <jonlee@apple.com> 5110 5111 Build fix for r105086. 5112 5113 * Configurations/FeatureDefines.xcconfig: 5114 51152012-01-12 Alexey Proskuryakov <ap@apple.com> 5116 5117 A warning is logged to console when typing a bare "/" in Safari address bar 5118 https://bugs.webkit.org/show_bug.cgi?id=76236 5119 5120 Reviewed by John Sullivan. 5121 5122 * Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): Bail out early for paths. 5123 51242012-01-16 Pablo Flouret <pablof@motorola.com> 5125 5126 Fix compilation errors on build-webkit --debug --no-svg --no-svg-fonts --no-svg-dom-objc-bindings on mac. 5127 https://bugs.webkit.org/show_bug.cgi?id=75865 5128 5129 Reviewed by Hajime Morita. 5130 5131 * WebView/WebFrame.mm: 5132 (-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]): 5133 51342012-01-15 Pablo Flouret <pablof@motorola.com> 5135 5136 Fix compilation errors on build-webkit --debug --no-video on mac. 5137 https://bugs.webkit.org/show_bug.cgi?id=75867 5138 5139 Reviewed by Philippe Normand. 5140 5141 - WebChromeClient::fullScreenRendererChanged() declaration wrongly guarded 5142 by VIDEO feature instead of FULLSCREEN_API. 5143 - _isAnyMoviePlaying implementation depends on VIDEO. 5144 5145 * WebCoreSupport/WebChromeClient.h: 5146 * WebView/WebFullScreenController.mm: 5147 (-[WebFullScreenController _isAnyMoviePlaying]): 5148 51492012-01-11 Beth Dakin <bdakin@apple.com> 5150 5151 https://bugs.webkit.org/show_bug.cgi?id=75904 5152 WebKit 1: Scrollbar uiStateTransitionProgress requires tracking the mouse all 5153 the time 5154 -and corresponding- 5155 <rdar://problem/10498816> 5156 5157 Reviewed by Darin Adler. 5158 5159 New ivar trackingAreaForNonKeyWindow stores our NSTrackingArea whenever we 5160 have one. 5161 * WebView/WebHTMLView.mm: 5162 (-[WebHTMLViewPrivate dealloc]): 5163 (-[WebHTMLViewPrivate clear]): 5164 5165 When we know that mouse movements won't affect anything other than 5166 scrollbars, call our new function passMouseMovedEventToScrollbars(), 5167 otherwise we'll call the old mouseMoved(). 5168 (mouseEventIsPartOfClickOrDrag): 5169 (-[WebHTMLView _updateMouseoverWithEvent:]): 5170 5171 Make sure not to remove the mouse observer when there are legacy scrollbars. 5172 (-[WebHTMLView removeMouseMovedObserver]): 5173 5174 Set up a tracking area when the window is not key to ensure that the WebView 5175 gets the relevant events. Remove it when the window is key again so that we 5176 rely on the existing mechanism. 5177 (-[WebHTMLView windowDidBecomeKey:]): 5178 (-[WebHTMLView windowDidResignKey:]): 5179 51802012-01-10 Dan Bernstein <mitz@apple.com> 5181 5182 Made -[WebHistoryItem copyWithZone:] allocate an object of the same class as the receiver. 5183 5184 Reviewed by Mark Rowe. 5185 5186 * History/WebHistoryItem.mm: 5187 (-[WebHistoryItem copyWithZone:]): 5188 51892012-01-10 Chris Marrin <cmarrin@apple.com> 5190 5191 Wrapped allowedCompositingTriggers in ACCELERATED_COMPOSITING ifdef to make non-accelerated builds work 5192 5193 Unreviewed. 5194 5195 * WebCoreSupport/WebChromeClient.h: 5196 51972012-01-10 Chris Marrin <cmarrin@apple.com> 5198 5199 Turn off the FilterTrigger in WebKit and WebKit2 5200 https://bugs.webkit.org/show_bug.cgi?id=75914 5201 5202 Reviewed by Simon Fraser. 5203 5204 Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger. 5205 5206 * WebCoreSupport/WebChromeClient.h: 5207 (WebChromeClient::allowedCompositingTriggers): 5208 52092012-01-10 Dan Bernstein <mitz@apple.com> 5210 5211 Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject() 5212 https://bugs.webkit.org/show_bug.cgi?id=75980 5213 5214 Reviewed by Mark Rowe. 5215 5216 * History/WebHistoryItem.mm: 5217 (-[WebHistoryItem copyWithZone:]): Replaced NSCopyObject() with 5218 -alloc, -initWithWebCoreHistoryItem:. 5219 52202012-01-06 Simon Fraser <simon.fraser@apple.com> 5221 5222 Mitigate scrollbar differences when running pixel tests 5223 https://bugs.webkit.org/show_bug.cgi?id=67217 5224 5225 Reviewed by Dan Bernstein. 5226 5227 Make it possible to register a custom NSScroller class, which 5228 the WebDynamicScrollBarsView will use when mock scrollbars are enabled. 5229 5230 Also ensure that the WebPreferences mock scrollbars preference is 5231 migrated into Settings. 5232 5233 * WebView/WebDynamicScrollBarsView.h: 5234 * WebView/WebDynamicScrollBarsView.mm: 5235 (+[WebDynamicScrollBarsView _horizontalScrollerClass]): 5236 (+[WebDynamicScrollBarsView _verticalScrollerClass]): 5237 (+[WebDynamicScrollBarsView setCustomScrollerClass:]): 5238 * WebView/WebView.mm: 5239 (-[WebView _preferencesChanged:]): 5240 52412012-01-05 Dan Bernstein <mitz@apple.com> 5242 5243 <rdar://problem/10633760> Update copyright strings 5244 5245 Reviewed by Mark Rowe. 5246 5247 * Info.plist: 5248 52492012-01-05 Pratik Solanki <psolanki@apple.com> 5250 5251 WebFrameLoaderClient::userAgent does unnecessary NSString/NSURL conversions 5252 https://bugs.webkit.org/show_bug.cgi?id=75586 5253 5254 Reviewed by Alexey Proskuryakov. 5255 5256 We do unnecessary KURL->NSURL* and String<->NSString* when calling [WebView 5257 userAgentForURL:] from WebFrameLoaderClient::userAgent. Instead we add a separate function, 5258 _userAgentString that returns a WTF::String to make this call faster. 5259 5260 * WebCoreSupport/WebFrameLoaderClient.mm: 5261 (WebFrameLoaderClient::userAgent): 5262 * WebView/WebView.mm: 5263 (-[WebView _userAgentString]): 5264 (-[WebView userAgentForURL:]): 5265 * WebView/WebViewInternal.h: 5266 52672012-01-04 Anders Carlsson <andersca@apple.com> 5268 5269 Ambiguous if-then-else in Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm 5270 https://bugs.webkit.org/show_bug.cgi?id=75447 5271 5272 Reviewed by Brian Weinstein. 5273 5274 Resolve the ambiguity. 5275 5276 * Misc/WebNSPasteboardExtras.mm: 5277 (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): 5278 52792012-01-04 Mihnea Ovidenie <mihnea@adobe.com> 5280 5281 [Mac]Fix build after changeset 103997 5282 https://bugs.webkit.org/show_bug.cgi?id=75530 5283 5284 Reviewed by Andreas Kling. 5285 5286 * WebView/WebFrame.mm: 5287 * WebView/WebHTMLView.mm: 5288 * WebView/WebPDFView.mm: 5289 * WebView/WebView.mm: 5290 52912012-01-03 Jon Lee <jonlee@apple.com> 5292 5293 Leak of WebNotificationClient when page is destroyed 5294 https://bugs.webkit.org/show_bug.cgi?id=74980 5295 <rdar://problem/10611231> 5296 5297 Reviewed by Mark Rowe. 5298 5299 * WebCoreSupport/WebNotificationClient.h: 5300 * WebCoreSupport/WebNotificationClient.mm: 5301 (WebNotificationClient::notificationControllerDestroyed): Remove the instance. 5302 53032012-01-02 Dan Bernstein <mitz@apple.com> 5304 5305 [mac] Remove -[WebView setHoverFeedbackSuspended:] 5306 https://bugs.webkit.org/show_bug.cgi?id=75406 5307 5308 Reviewed by Tim Hatcher. 5309 5310 * WebView/WebHTMLView.mm: 5311 (-[WebHTMLView _updateMouseoverWithEvent:]): Removed check for suspended hover updates. 5312 * WebView/WebHTMLViewInternal.h: Removed -_hoverFeedbackSuspendedChanged. 5313 * WebView/WebView.mm: 5314 (-[WebView setHoverFeedbackSuspended:]): Left empty implementation to support versions of 5315 Safari that call this. 5316 (-[WebView isHoverFeedbackSuspended]): Left implementation that always returns NO to support 5317 versions of Safari that call this. 5318 * WebView/WebViewData.h: Removed hoverFeedbackSuspended ivar. 5319 * WebView/WebViewPrivate.h: Removed method definitions. 5320 53212011-12-31 Dan Bernstein <mitz@apple.com> 5322 5323 WebKit/mac changes for: REGRESSION (WebKit2): Cursor, hover states not updated when page scrolls under stationary mouse pointer 5324 https://bugs.webkit.org/show_bug.cgi?id=75405 5325 5326 Reviewed by Anders Carlsson. 5327 5328 Removed the WebKit/mac mechanism for dispatching fake mouse moved events 5329 when an HTML frame scrolls, since FrameView now does this. 5330 5331 * WebView/WebHTMLView.mm: 5332 (-[WebHTMLViewPrivate dealloc]): Removed an assertion about a removed ivar. 5333 (-[WebHTMLView _updateMouseoverWithFakeEvent]): Removed call to 5334 -_cancelUpdateMouseoverTimer. 5335 (-[WebHTMLView _frameOrBoundsChanged]): Removed code to schedule a timer 5336 for dispatching a mouse moved event on scroll. 5337 (-[WebHTMLView close]): Removed call to _cancelUpdateMouseoverTimer. 5338 (-[WebHTMLView viewWillMoveToWindow:]): Ditto. 5339 (-[WebHTMLView mouseDown:]): Ditto. 5340 53412011-12-23 Ryosuke Niwa <rniwa@webkit.org> 5342 5343 Chromium Mac build fix. 5344 5345 * WebCoreSupport/WebSystemInterface.mm: 5346 (InitWebCoreSystemInterface): 5347 53482011-12-21 Sam Weinig <sam@webkit.org> 5349 5350 Start extracting platform specific bits out of PlatformEvents 5351 https://bugs.webkit.org/show_bug.cgi?id=75063 5352 5353 Reviewed by Anders Carlsson. 5354 5355 * WebCoreSupport/WebSystemInterface.mm: 5356 (InitWebCoreSystemInterface): 5357 * WebView/WebFrame.mm: 5358 * WebView/WebHTMLView.mm: 5359 (-[WebHTMLView menuForEvent:]): 5360 (-[WebHTMLView acceptsFirstMouse:]): 5361 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): 5362 (currentKeyboardEvent): 5363 (-[WebHTMLView flagsChanged:]): 5364 * WebView/WebPDFView.mm: 5365 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): 5366 * WebView/WebView.mm: 5367 53682011-12-21 Timothy Hatcher <timothy@apple.com> 5369 5370 Web Inspector: suppress incremental rendering and use application chrome mode 5371 5372 https://webkit.org/b/75026 5373 5374 Reviewed by Joseph Pecoraro. 5375 5376 * WebCoreSupport/WebInspectorClient.mm: 5377 (-[WebInspectorWindowController init]): Sort the preferences, remove the Leopard font family setting, 5378 set suppress incremental rendering and use application chrome mode. 5379 53802011-12-20 Pavel Feldman <pavel.feldman@gmail.com> 5381 5382 Web Inspector: reproducible crash after closing web inspector and browser window (iCab) 5383 https://bugs.webkit.org/show_bug.cgi?id=74255 5384 5385 Reviewed by Yury Semikhatsky. 5386 5387 * WebCoreSupport/WebInspectorClient.h: 5388 * WebCoreSupport/WebInspectorClient.mm: 5389 (WebInspectorClient::bringFrontendToFront): 5390 (-[WebInspectorWindowController destroyInspectorView:]): 5391 53922011-12-19 Eric Carlson <eric.carlson@apple.com> 5393 5394 Enable <track> for Mac build 5395 https://bugs.webkit.org/show_bug.cgi?id=74838 5396 5397 Reviewed by Darin Adler. 5398 5399 * Configurations/FeatureDefines.xcconfig: 5400 54012011-12-16 Ryosuke Niwa <rniwa@webkit.org> 5402 5403 Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step 5404 https://bugs.webkit.org/show_bug.cgi?id=74748 5405 5406 Reviewed by Eric Seidel. 5407 5408 * WebCoreSupport/WebEditorClient.h: 5409 * WebCoreSupport/WebEditorClient.mm: 5410 (WebEditorClient::registerUndoOrRedoStep): 5411 (WebEditorClient::registerUndoStep): 5412 (WebEditorClient::registerRedoStep): 5413 54142011-12-16 Sam Weinig <sam@webkit.org> 5415 5416 Give PlatformEvents a base class 5417 https://bugs.webkit.org/show_bug.cgi?id=74685 5418 5419 Reviewed by Anders Carlsson. 5420 5421 Add a base class for PlatformMouseEvent, PlatformKeyboardEvent, PlatformWheelEvent 5422 and PlatformGestureEvent and move Type enumeration and modifiers down to it. 5423 5424 * WebView/WebFrame.mm: 5425 (-[WebFrame _dragSourceEndedAt:operation:]): 5426 * WebView/WebHTMLView.mm: 5427 (currentKeyboardEvent): 5428 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): 5429 * WebView/WebPDFView.mm: 5430 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): 5431 54322011-12-16 Simon Fraser <simon.fraser@apple.com> 5433 5434 Fix a #elsif fumble in my earlier commit. 5435 5436 * WebView/WebHTMLView.mm: 5437 (-[WebHTMLView attachRootLayer:]): 5438 54392011-12-16 Ryosuke Niwa <rniwa@webkit.org> 5440 5441 Only EditCommandComposition should implement unapply and reapply 5442 https://bugs.webkit.org/show_bug.cgi?id=74490 5443 5444 Reviewed by Eric Seidel. 5445 5446 * WebCoreSupport/WebEditorClient.h: 5447 * WebCoreSupport/WebEditorClient.mm: 5448 (-[WebUndoStep initWithUndoStep:]): 5449 (-[WebUndoStep dealloc]): 5450 (+[WebUndoStep stepWithUndoStep:]): 5451 (-[WebUndoStep step]): 5452 (-[WebEditorUndoTarget undoEditing:]): 5453 (-[WebEditorUndoTarget redoEditing:]): 5454 (WebEditorClient::registerCommandForUndoOrRedo): 5455 (WebEditorClient::registerCommandForUndo): 5456 (WebEditorClient::registerCommandForRedo): 5457 54582011-12-16 Simon Fraser <simon.fraser@apple.com> 5459 5460 <rdar://problem/10589427> Avoid calling -setGeometryFlipped ourselves on the layer hosting view's layer 5461 5462 Reviewed by Sam Weinig. 5463 5464 Now that we're using a flipped view to host the compositing layers, 5465 we should not set geometryFlipped on the root layer ourselves. 5466 5467 * WebView/WebHTMLView.mm: 5468 (-[WebHTMLView attachRootLayer:]): 5469 54702011-12-16 Mark Hahnenberg <mhahnenberg@apple.com> 5471 5472 De-virtualize destructors 5473 https://bugs.webkit.org/show_bug.cgi?id=74331 5474 5475 Reviewed by Geoffrey Garen. 5476 5477 * Plugins/Hosted/ProxyRuntimeObject.h: Remove empty virtual destructor. 5478 * Plugins/Hosted/ProxyRuntimeObject.mm: 5479 54802011-12-14 Ryosuke Niwa <rniwa@webkit.org> 5481 5482 Mac build fix after r102874. 5483 5484 * WebCoreSupport/WebChromeClient.mm: 5485 54862011-12-14 Jing Zhao <jingzhao@chromium.org> 5487 5488 Opening two popup menus by dispatchEvent() makes problems. 5489 https://bugs.webkit.org/show_bug.cgi?id=73304 5490 5491 Reviewed by Kent Tamura. 5492 5493 * WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup(). 5494 * WebCoreSupport/WebChromeClient.mm: 5495 (WebChromeClient::hasOpenedPopup): Not implemented. 5496 54972011-12-14 Michael Saboff <msaboff@apple.com> 5498 5499 Mac WebScriptDebugger crashes beneath sourceParsed() 5500 https://bugs.webkit.org/show_bug.cgi?id=74564 5501 5502 Reviewed by Gavin Barraclough. 5503 5504 * WebView/WebScriptDebugger.mm: 5505 (toNSString): Change to use ->characters() method to 5506 actually get characters for string conversion. 5507 55082011-12-14 Hajime Morrita <morrita@chromium.org> 5509 5510 JS_INLINE and WTF_INLINE should be visible from WebCore 5511 https://bugs.webkit.org/show_bug.cgi?id=73191 5512 5513 Reviewed by Kevin Ollivier. 5514 5515 Removed macro definitions which is now provided by Platform.h 5516 5517 * WebKitPrefix.h: 5518 55192011-12-13 Jon Lee <jonlee@apple.com> 5520 5521 Enable notifications on Mac. 5522 5523 Reviewed by Sam Weinig. 5524 5525 * Configurations/FeatureDefines.xcconfig: 5526 55272011-12-12 Ryosuke Niwa <rniwa@webkit.org> 5528 5529 WebKit code shouldn't be calling applyCommand directly 5530 https://bugs.webkit.org/show_bug.cgi?id=74337 5531 5532 Reviewed by Darin Adler. 5533 5534 * WebView/WebFrame.mm: 5535 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): 5536 55372011-12-12 Brady Eidson <beidson@apple.com> 5538 5539 Page cache should support pages with plugins. 5540 <rdar://problem/5190122> and https://bugs.webkit.org/show_bug.cgi?id=13634 5541 5542 Expose a WebKit preference for the page cache supporting plugins (on by default). 5543 5544 Reviewed by Anders Carlsson. 5545 5546 * WebView/WebPreferenceKeysPrivate.h: 5547 5548 * WebView/WebPreferences.mm: 5549 (-[WebPreferences pageCacheSupportsPlugins]): 5550 (-[WebPreferences setPageCacheSupportsPlugins:]): 5551 * WebView/WebPreferencesPrivate.h: 5552 5553 * WebView/WebView.mm: 5554 (-[WebView _preferencesChanged:]): 5555 55562011-12-12 Dan Bernstein <mitz@apple.com> 5557 5558 <rdar://problem/10328474> Text highlight changes to gray selection color when menu extra is shown 5559 5560 Reviewed by John Sullivan. 5561 5562 * WebView/WebView.mm: 5563 (-[WebView _updateActiveState]): Changed to use -[NSWindow _hasKeyAppearance] instead 5564 of -isKeyWindow. The former also returns YES when a menu extra is open. 5565 (-[WebView addWindowObserversForWindow:]): Removed code to observe 5566 NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification. 5567 (-[WebView removeWindowObservers]): Removed code to stop observing the above. 5568 (-[WebView _windowChangedKeyState]): Overridden this to call _updateActiveState. 5569 This is called when the result of -_hasKeyAppearance changes. 5570 (-[WebView _windowWillOrderOnScreen:]): Removed call to _updateActiveState, 5571 previously needed for popovers, because _windowChangedKeyState is invoked 5572 at the right time for them. 5573 (-[WebView _windowWillOrderOffScreen:]): Ditto. 5574 55752011-12-07 Mark Rowe <mrowe@apple.com> 5576 5577 Fix the 32-bit build. 5578 5579 Ignore some warnings that only occur in 32-bit. 5580 5581 * Plugins/WebNetscapePluginPackage.mm: 5582 55832011-12-07 Mary Wu <mary.wu@torchmobile.com.cn> 5584 5585 Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline 5586 https://bugs.webkit.org/show_bug.cgi?id=73986 5587 5588 Reviewed by Kenneth Rohde Christiansen. 5589 5590 * WebView/WebView.mm: 5591 (-[WebView _commonInitializationWithFrameName:groupName:]): 5592 55932011-12-06 Alexey Proskuryakov <ap@apple.com> 5594 5595 REGRESSION (WebKit2): Kill ring is not cleared when selection changes 5596 https://bugs.webkit.org/show_bug.cgi?id=73888 5597 <rdar://problem/10532310> 5598 5599 Reviewed by Mark Rowe. 5600 5601 * WebView/WebHTMLView.mm: 5602 (-[WebHTMLView becomeFirstResponder]): Added a FIXME comment. 5603 (-[WebHTMLView _selectionChanged]): Moved the code to clear kill ring to WebCore. The rest 5604 of kill ring implementation is there, so it makes no sense to have this call in WebKits. 5605 56062011-12-05 Anders Carlsson <andersca@apple.com> 5607 5608 Make LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful or not 5609 https://bugs.webkit.org/show_bug.cgi?id=73862 5610 5611 Reviewed by Andy Estes. 5612 5613 Remove the call to LayerFlushScheduler::invalidate and return true instead. Return false for the cases 5614 where we don't want the layer flush scheduler to be invalidated. 5615 5616 * WebView/WebView.mm: 5617 (LayerFlushController::flushLayers): 5618 * WebView/WebViewData.h: 5619 56202011-12-05 Eric Carlson <eric.carlson@apple.com> 5621 5622 Add WebKit preferences for text track settings 5623 https://bugs.webkit.org/show_bug.cgi?id=73721 5624 5625 Reviewed by John Sullivan. 5626 5627 * WebView/WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions, 5628 and shouldDisplayTextDescriptions properties. 5629 5630 * WebView/WebPreferences.mm: 5631 (+[WebPreferences initialize]): Initialize new preferences to NO. 5632 (-[WebPreferences setShouldDisplaySubtitles:]): Added. 5633 (-[WebPreferences shouldDisplaySubtitles]): Ditto. 5634 (-[WebPreferences setShouldDisplayCaptions:]): Ditto. 5635 (-[WebPreferences shouldDisplayCaptions]): Ditto. 5636 (-[WebPreferences setShouldDisplayTextDescriptions:]): Ditto. 5637 (-[WebPreferences shouldDisplayTextDescriptions]): Ditto. 5638 * WebView/WebPreferencesPrivate.h: 5639 5640 * WebView/WebView.mm: 5641 (-[WebView _preferencesChanged:]): Updates WebCore settings from WebKit prefs. 5642 56432011-12-03 Dan Bernstein <mitz@apple.com> 5644 5645 <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources 5646 Reviewed by Darin Adler. 5647 5648 * WebView/WebView.mm: 5649 (-[WebView _removeObjectForIdentifier:]): Changed the CFRelease(self) into 5650 a WebCFAutorelease(self). This prevents re-entry into this method due to 5651 the WebView closing and canceling all subresource loads, including the 5652 one we have just removed. 5653 56542011-12-02 David Levin <levin@chromium.org> 5655 5656 Rename WTF class from TemporarilyChange to TemporaryChange. 5657 https://bugs.webkit.org/show_bug.cgi?id=73479 5658 5659 Reviewed by Eric Seidel. 5660 5661 * ForwardingHeaders/wtf/TemporarilyChange.h: Removed. 5662 * ForwardingHeaders/wtf/TemporaryChange.h: Added. 5663 56642011-12-02 Simon Fraser <simon.fraser@apple.com> 5665 5666 <rdar://problem/10423627> Layers are flipped in WebKit1 views 5667 5668 Reviewed by Sam Weinig. 5669 5670 Host the compositing layers in an NSView which is flipped, which helps AppKit 5671 get the geometry right in some situations. 5672 5673 * WebView/WebHTMLView.mm: 5674 (-[WebLayerHostingFlippedView isFlipped]): 5675 (-[WebHTMLView attachRootLayer:]): 5676 56772011-12-02 Hajime Morrita <morrita@chromium.org> 5678 5679 Unreviewed, rolling out r101751 and r101775. 5680 http://trac.webkit.org/changeset/101751 5681 http://trac.webkit.org/changeset/101775 5682 https://bugs.webkit.org/show_bug.cgi?id=73191 5683 5684 breaks Windows build 5685 5686 * WebKitPrefix.h: 5687 56882011-12-01 Hajime Morrita <morrita@chromium.org> 5689 5690 JS_INLINE and WTF_INLINE should be visible from WebCore 5691 https://bugs.webkit.org/show_bug.cgi?id=73191 5692 5693 Reviewed by Kevin Ollivier. 5694 5695 Removed macro definitions which is now provided by Platform.h 5696 5697 * WebKitPrefix.h: 5698 56992011-11-30 Alexey Proskuryakov <ap@apple.com> 5700 5701 Remove an unneeded argument from FrameLoaderClient::download 5702 https://bugs.webkit.org/show_bug.cgi?id=73486 5703 5704 Reviewed by Andreas Kling. 5705 5706 * WebCoreSupport/WebFrameLoaderClient.h: 5707 * WebCoreSupport/WebFrameLoaderClient.mm: 5708 (WebFrameLoaderClient::download): 5709 Updated for the change. 5710 57112011-11-30 Dan Bernstein <mitz@apple.com> 5712 5713 WebKit/mac part of: Allow the length of a page along the pagination axis to differ from the length of the view 5714 https://bugs.webkit.org/show_bug.cgi?id=73476 5715 5716 Reviewed by Anders Carlsson. 5717 5718 * WebView/WebView.mm: 5719 (-[WebView _setPageLength:]): Added this accessor. 5720 (-[WebView _pageLength]): Ditto. 5721 * WebView/WebViewPrivate.h: 5722 57232011-11-30 Alexey Proskuryakov <ap@apple.com> 5724 5725 Download page URL should be set by WebCore 5726 https://bugs.webkit.org/show_bug.cgi?id=73358 5727 5728 Reviewed by Darin Adler. 5729 5730 * WebCoreSupport/WebFrameLoaderClient.h: Removed setOriginalURLForDownload, which is now 5731 in WebCore. 5732 5733 * WebCoreSupport/WebFrameLoaderClient.mm: 5734 (WebFrameLoaderClient::download): There is no need to set original URL post factum any more. 5735 (WebFrameLoaderClient::startDownload): Ditto. 5736 57372011-11-29 David Levin <levin@chromium.org> 5738 5739 Add a way to revert a variable to its previous value after leaving a scope. 5740 https://bugs.webkit.org/show_bug.cgi?id=73371 5741 5742 Reviewed by Adam Barth. 5743 5744 * ForwardingHeaders/wtf/TemporarilyChange.h: Added. 5745 57462011-11-29 Jessie Berlin <jberlin@apple.com> 5747 5748 WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins 5749 the first time it is called. 5750 https://bugs.webkit.org/show_bug.cgi?id=73374 (<rdar://problem/10196057>) 5751 5752 Reviewed by Brady Eidson. 5753 5754 * Storage/WebStorageTrackerClient.h: 5755 * Storage/WebStorageTrackerClient.mm: 5756 (WebStorageTrackerClient::didFinishLoadingOrigins): 5757 57582011-11-15 Anders Carlsson <andersca@apple.com> 5759 5760 DragClient::dragSourceActionMaskForPoint should use root view coordinates 5761 https://bugs.webkit.org/show_bug.cgi?id=72409 5762 5763 Reviewed by Sam Weinig. 5764 5765 * WebCoreSupport/WebDragClient.mm: 5766 (WebDragClient::dragSourceActionMaskForPoint): 5767 Use -[WebView _convertPointFromRootView:] to convert the point to the web view coordinate system. 5768 57692011-11-15 Anders Carlsson <andersca@apple.com> 5770 5771 EditorClient::showCorrectionPanel should pass the string bounding box in root view coordinates 5772 https://bugs.webkit.org/show_bug.cgi?id=72408 5773 5774 Reviewed by Sam Weinig. 5775 5776 * WebCoreSupport/CorrectionPanel.mm: 5777 (CorrectionPanel::show): 5778 Convert the bounding rect to web view coordinates. 5779 5780 * WebView/WebView.mm: 5781 (-[WebView _convertPointFromRootView:]): 5782 (-[WebView _convertRectFromRootView:]): 5783 * WebView/WebViewInternal.h: 5784 Add helper methods for converting from root view coordinates to web view coordinates. 5785 57862011-11-29 Roland Steiner <rolandsteiner@chromium.org> 5787 5788 <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit 5789 https://bugs.webkit.org/show_bug.cgi?id=72848 5790 5791 Reviewed by Dimitri Glazkov. 5792 5793 * Configurations/FeatureDefines.xcconfig: 5794 57952011-11-28 Jon Lee <jonlee@apple.com> 5796 5797 Create skeleton framework for notifications support in WK2 5798 https://bugs.webkit.org/show_bug.cgi?id=73253 5799 <rdar://problem/10356943> 5800 5801 Reviewed by Sam Weinig. 5802 5803 * Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform. 5804 5805 * WebCoreSupport/WebNotificationClient.h: Added. 5806 (WebNotificationClient::webView): 5807 * WebCoreSupport/WebNotificationClient.mm: Added. Implemented as stubs for now. 5808 (WebNotificationClient::WebNotificationClient): 5809 (WebNotificationClient::show): 5810 (WebNotificationClient::cancel): 5811 (WebNotificationClient::notificationObjectDestroyed): 5812 (WebNotificationClient::requestPermission): 5813 (WebNotificationClient::cancelRequestsForPermission): 5814 (WebNotificationClient::checkPermission): 5815 * WebView/WebView.mm: Set PageClient's notification client to an instance of this stubbed class. 5816 58172011-11-28 Adam Roben <aroben@apple.com> 5818 5819 Properly retain the OS X version string 5820 5821 Fixes <http://webkit.org/b/73214> REGRESSION (r101215): Crash on launch beneath +[WebView 5822 _standardUserAgentWithApplicationName:] 5823 5824 Reviewed by Antti Koivisto. 5825 5826 * WebView/WebView.mm: 5827 (createMacOSXVersionString): Retain the string we're returning, since this function is 5828 supposed to return an owning reference to the caller. 5829 58302011-11-28 Hayato Ito <hayato@chromium.org> 5831 5832 Fix chromium canary build after r101215. 5833 Unreviewed. Build fix. 5834 5835 * WebCoreSupport/WebSystemInterface.mm: 5836 (InitWebCoreSystemInterface): 5837 58382011-11-27 Mark Rowe <mrowe@apple.com> 5839 5840 <http://webkit.org/b/72665> Switch to a more modern approach to retrieving the OS marketing version 5841 5842 Reviewed by Dan Bernstein. 5843 5844 * WebCoreSupport/WebSystemInterface.mm: 5845 (InitWebCoreSystemInterface): Set up wkGetMacOSXVersionString. 5846 * WebView/WebView.mm: 5847 (createMacOSXVersionString): Use WKGetMacOSXVersionString. 5848 58492011-11-26 Pavel Feldman <pfeldman@google.com> 5850 5851 Web Inspector: remove disconnectFromBackend from the protocol. 5852 https://bugs.webkit.org/show_bug.cgi?id=73127 5853 5854 Reviewed by Yury Semikhatsky. 5855 5856 * WebCoreSupport/WebInspectorClient.h: 5857 * WebCoreSupport/WebInspectorClient.mm: 5858 (WebInspectorClient::inspectorDestroyed): 5859 (WebInspectorClient::closeInspectorFrontend): 5860 58612011-11-26 Sheriff Bot <webkit.review.bot@gmail.com> 5862 5863 Unreviewed, rolling out r101193. 5864 http://trac.webkit.org/changeset/101193 5865 https://bugs.webkit.org/show_bug.cgi?id=73158 5866 5867 Breaks Windows and Qt minimal. (Requested by pfeldman on 5868 #webkit). 5869 5870 * WebCoreSupport/WebInspectorClient.h: 5871 * WebCoreSupport/WebInspectorClient.mm: 5872 (WebInspectorClient::inspectorDestroyed): 5873 58742011-11-26 Pavel Feldman <pfeldman@google.com> 5875 5876 Web Inspector: remove disconnectFromBackend from the protocol. 5877 https://bugs.webkit.org/show_bug.cgi?id=73127 5878 5879 Reviewed by Yury Semikhatsky. 5880 5881 * WebCoreSupport/WebInspectorClient.h: 5882 * WebCoreSupport/WebInspectorClient.mm: 5883 (WebInspectorClient::inspectorDestroyed): 5884 (WebInspectorClient::closeInspectorFrontend): 5885 58862011-11-22 Pavel Feldman <pfeldman@google.com> 5887 5888 Web Inspector: remove Inspector::bringToFront from the protocol. 5889 https://bugs.webkit.org/show_bug.cgi?id=72937 5890 5891 Reviewed by Yury Semikhatsky. 5892 5893 * WebCoreSupport/WebInspectorClient.h: 5894 * WebCoreSupport/WebInspectorClient.mm: 5895 (WebInspectorClient::openInspectorFrontend): 5896 (WebInspectorClient::bringFrontendToFront): 5897 58982011-11-21 Mark Rowe <mrowe@apple.com> 5899 5900 Fix the SnowLeopard build. 5901 5902 * Misc/WebNSFileManagerExtras.mm: Forward-declare DADiskCreateFromVolumePath on SnowLeopard as it was 5903 not yet declared in a public header. 5904 59052011-11-20 Mark Rowe <mrowe@apple.com> 5906 5907 <http://webkit.org/b/72661> Switch to a more modern approach to retrieving the startup volume name 5908 5909 Use the DiskArbitration framework to retrieve the name of the startup volume rather than using Carbon 5910 File Manager APIs. 5911 5912 Reviewed by Dan Bernstein. 5913 5914 * Misc/WebNSFileManagerExtras.mm: 5915 (-[NSFileManager _webkit_startupVolumeName]): Retrieve a DADiskRef for the startup volume and copy 5916 the volume name from its description dictionary. 5917 59182011-06-20 Pavel Feldman <pfeldman@chromium.org> 5919 5920 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu. 5921 https://bugs.webkit.org/show_bug.cgi?id=62985 5922 5923 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary 5924 methods for plumbing the menu action handlers through the WebKit and WebCore. 5925 I intend to remove this menu support from the protocol and WebCore/InspectorController API. 5926 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port. 5927 WebKit/win and WebKit2 to follow. 5928 5929 Reviewed by Yury Semikhatsky. 5930 5931 * WebCoreSupport/WebInspectorClient.mm: 5932 (-[WebInspectorWindowController destroyInspectorView:]): 5933 * WebInspector/WebInspector.mm: 5934 (-[WebInspector showWindow]): 5935 (-[WebInspector show:]): 5936 (-[WebInspector showConsole:]): 5937 (-[WebInspector isDebuggingJavaScript]): 5938 (-[WebInspector toggleDebuggingJavaScript:]): 5939 (-[WebInspector startDebuggingJavaScript:]): 5940 (-[WebInspector stopDebuggingJavaScript:]): 5941 (-[WebInspector isProfilingJavaScript]): 5942 (-[WebInspector toggleProfilingJavaScript:]): 5943 (-[WebInspector startProfilingJavaScript:]): 5944 (-[WebInspector stopProfilingJavaScript:]): 5945 (-[WebInspector isJavaScriptProfilingEnabled]): 5946 (-[WebInspector setJavaScriptProfilingEnabled:]): 5947 (-[WebInspector isTimelineProfilingEnabled]): 5948 (-[WebInspector setTimelineProfilingEnabled:]): 5949 (-[WebInspector setFrontend:]): 5950 (-[WebInspector releaseFrontend]): 5951 (-[WebInspector showWindow:]): 5952 * WebInspector/WebInspectorFrontend.h: 5953 * WebInspector/WebInspectorFrontend.mm: 5954 (-[WebInspectorFrontend isDebuggingEnabled]): 5955 (-[WebInspectorFrontend setDebuggingEnabled:]): 5956 (-[WebInspectorFrontend isProfilingJavaScript]): 5957 (-[WebInspectorFrontend startProfilingJavaScript]): 5958 (-[WebInspectorFrontend stopProfilingJavaScript]): 5959 (-[WebInspectorFrontend isJavaScriptProfilingEnabled]): 5960 (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]): 5961 (-[WebInspectorFrontend isTimelineProfilingEnabled]): 5962 (-[WebInspectorFrontend setTimelineProfilingEnabled:]): 5963 * WebInspector/WebInspectorPrivate.h: 5964 59652011-11-21 Jochen Eisinger <jochen@chromium.org> 5966 5967 Implement Meta referrer 5968 https://bugs.webkit.org/show_bug.cgi?id=72674 5969 5970 Reviewed by Adam Barth. 5971 5972 * Plugins/Hosted/HostedNetscapePluginStream.mm: 5973 (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream): 5974 * Plugins/WebNetscapePluginStream.mm: 5975 (WebNetscapePluginStream::WebNetscapePluginStream): 5976 59772011-10-17 Antonio Gomes <agomes@rim.com> 5978 5979 Pass a Frame* parameter in EditorClient::respondToChangedSelection 5980 https://bugs.webkit.org/show_bug.cgi?id=70248 5981 5982 Reviewed by Ryosuke Niwa. 5983 5984 * WebCoreSupport/WebEditorClient.h: 5985 * WebCoreSupport/WebEditorClient.mm: Make use of the newly added Frame* parameter. 5986 (WebEditorClient::respondToChangedSelection): 5987 59882011-11-17 Mark Rowe <mrowe@apple.com> 5989 5990 <http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily 5991 switch away from the deprecated APIs. 5992 5993 Reviewed by Sam Weinig. 5994 5995 * Plugins/WebBasePluginPackage.mm: 5996 * Plugins/WebNetscapePluginPackage.mm: 5997 (-[WebNetscapePluginPackage _tryLoad]): 5998 59992011-11-18 Anton D'Auria <adauria@apple.com> 6000 6001 bool WebChromeClient::shouldInterruptJavaScript casts pointer to bool and always returns true 6002 https://bugs.webkit.org/show_bug.cgi?id=72568 6003 6004 Reviewed by David Kilzer. 6005 6006 WebChromeClient::shouldInterruptJavaScript called CallUIDelegate, which used an id 6007 as the return value, which was then cast to a bool and always returned true. This 6008 patch uses CallUIDelegateReturningBoolean instead of CallUIDelegate, with the default 6009 return value of NO. 6010 6011 * WebCoreSupport/WebChromeClient.mm: 6012 (WebChromeClient::shouldInterruptJavaScript): 6013 60142011-11-16 Dan Bernstein <mitz@apple.com> 6015 6016 WebKit/mac part of <rdar://problem/10262242> Add API for paginated display 6017 https://bugs.webkit.org/show_bug.cgi?id=72537 6018 6019 Reviewed by Anders Carlsson. 6020 6021 * WebView/WebView.mm: 6022 (-[WebView _setPaginationMode:]): Added this accessor. 6023 (-[WebView _paginationMode]): Ditto. 6024 (-[WebView _setGapBetweenPages:]): Ditto. 6025 (-[WebView _gapBetweenPages]): Ditto. 6026 (-[WebView _pageCount]): Ditto. 6027 * WebView/WebViewPrivate.h: Defined WebPaginationMode enum and values. 6028 60292011-11-15 Andy Estes <aestes@apple.com> 6030 6031 Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation 6032 https://bugs.webkit.org/show_bug.cgi?id=72106 6033 6034 Reviewed by Anders Carlsson. 6035 6036 Remove code that schedules layer flushes and use LayerFlushScheduler instead. 6037 6038 * WebView/WebView.mm: 6039 (-[WebView _close]): Invalidate the run loop observer and destroy the 6040 LayerFlushController. 6041 (LayerFlushController::flushLayers): Perform the work that 6042 layerSyncRunLoopObserverCallBack used to do. 6043 (-[WebView _scheduleCompositingLayerSync]): If layerFlushController has 6044 yet to be created, create it, then schedule a layer flush. 6045 * WebView/WebViewData.h: 6046 (LayerFlushController::create): Create a LayerFlushController that 6047 implements the LayerFlushSchedulerClient interface and contains a 6048 LayerFlushScheduler with itself as the client. 6049 * WebView/WebViewData.mm: 6050 (LayerFlushController::scheduleLayerFlush): 6051 (LayerFlushController::invalidateObserver): 6052 (LayerFlushController::LayerFlushController): 6053 60542011-11-15 Jochen Eisinger <jochen@chromium.org> 6055 6056 Rename ReferrerPolicy to clarify its meaning 6057 https://bugs.webkit.org/show_bug.cgi?id=72420 6058 6059 Reviewed by Nate Chapin. 6060 6061 * WebView/WebPDFView.mm: 6062 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): 6063 60642011-11-15 Anders Carlsson <andersca@apple.com> 6065 6066 HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen 6067 https://bugs.webkit.org/show_bug.cgi?id=72397 6068 6069 Reviewed by Dan Bernstein. 6070 6071 * WebCoreSupport/WebChromeClient.h: 6072 * WebCoreSupport/WebChromeClient.mm: 6073 (WebChromeClient::screenToRootView): 6074 (WebChromeClient::rootViewToScreen): 6075 60762011-11-14 Anders Carlsson <andersca@apple.com> 6077 6078 HostWindow invalidation functions should use root view coordinates 6079 https://bugs.webkit.org/show_bug.cgi?id=72338 6080 6081 Reviewed by Dan Bernstein. 6082 6083 * WebCoreSupport/WebChromeClient.h: 6084 * WebCoreSupport/WebChromeClient.mm: 6085 (WebChromeClient::invalidateRootView): 6086 (WebChromeClient::invalidateContentsAndRootView): 6087 (WebChromeClient::invalidateContentsForSlowScroll): 6088 60892011-11-14 Julien Chaffraix <jchaffraix@webkit.org> 6090 6091 Add --css-grid-layout to build-webkit and the build systems 6092 https://bugs.webkit.org/show_bug.cgi?id=72320 6093 6094 Reviewed by Ojan Vafai. 6095 6096 * Configurations/FeatureDefines.xcconfig: 6097 60982011-11-14 Tony Chang <tony@chromium.org> 6099 6100 Remove the CSS3_FLEXBOX compile time flag and enable on all ports 6101 https://bugs.webkit.org/show_bug.cgi?id=72196 6102 6103 Reviewed by Ojan Vafai. 6104 6105 * Configurations/FeatureDefines.xcconfig: 6106 61072011-11-07 Adam Barth <abarth@webkit.org> 6108 6109 Move static "policy" state from SecurityOrigin.cpp to SecurityPolicy.cpp 6110 https://bugs.webkit.org/show_bug.cgi?id=71755 6111 6112 Reviewed by Eric Seidel. 6113 6114 * Plugins/Hosted/HostedNetscapePluginStream.mm: 6115 (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream): 6116 * Plugins/WebNetscapePluginStream.mm: 6117 (WebNetscapePluginStream::WebNetscapePluginStream): 6118 * WebView/WebView.mm: 6119 (-[WebView _commonInitializationWithFrameName:groupName:]): 6120 (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]): 6121 (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]): 6122 (+[WebView _resetOriginAccessWhitelists]): 6123 61242011-11-08 Joseph Pecoraro <pecoraro@apple.com> 6125 6126 Move NSRange / DOMRange functions back to WebFrameInternal 6127 https://bugs.webkit.org/show_bug.cgi?id=71844 6128 6129 Reviewed by Alexey Proskuryakov. 6130 6131 * WebView/WebFrame.mm: 6132 (-[WebFrame _convertNSRangeToDOMRange:]): 6133 (-[WebFrame _convertDOMRangeToNSRange:]): 6134 * WebView/WebFrameInternal.h: 6135 * WebView/WebFramePrivate.h: 6136 61372011-11-08 Michael Saboff <msaboff@apple.com> 6138 6139 Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type 6140 https://bugs.webkit.org/show_bug.cgi?id=71761 6141 6142 Changed WKPCEvaluate() to use emptyString() when the source is 6143 zero length. 6144 6145 Reviewed by Gavin Barraclough. 6146 6147 * Plugins/Hosted/NetscapePluginHostProxy.mm: 6148 (WKPCEvaluate): 6149 61502011-11-08 Beth Dakin <bdakin@apple.com> 6151 6152 https://bugs.webkit.org/show_bug.cgi?id=71856 6153 WebKit should use new NSWindowDidChangeBackingPropertiesNotification instead of 6154 old NSWindowDidChangeResolutionNotification 6155 -and corresponding- 6156 <rdar://problem/10317253> 6157 6158 Reviewed by Tim Hatcher. 6159 6160 * WebView/WebView.mm: 6161 (-[WebView addWindowObserversForWindow:]): 6162 (-[WebView removeWindowObservers]): 6163 6164 We have to check that the backing scale factor actually changed since this 6165 notification can also be used to signify other changes. 6166 (-[WebView _windowDidChangeBackingProperties:]): 6167 61682011-11-07 Adam Barth <abarth@webkit.org> 6169 6170 Move DomainRelaxationForbidden scheme registry to SchemeRegistry 6171 https://bugs.webkit.org/show_bug.cgi?id=71750 6172 6173 Reviewed by Eric Seidel. 6174 6175 * WebView/WebView.mm: 6176 (+[WebView _setDomainRelaxationForbidden:forURLScheme:]): 6177 61782011-11-07 Jessie Berlin <jberlin@apple.com> 6179 6180 Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is 6181 enabled. 6182 https://bugs.webkit.org/show_bug.cgi?id=71631 6183 6184 Reviewed by Jon Honeycutt. 6185 6186 Add WebKit1 API to register a scheme as ignoring Private Browsing for Local Storage and 6187 Databases. 6188 6189 * WebView/WebView.mm: 6190 (+[WebView _registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing:]): 6191 Call through to the SchemeRegistry function. 6192 (+[WebView _registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing:]): 6193 Ditto. 6194 * WebView/WebViewPrivate.h: 6195 61962011-11-03 Mark Hahnenberg <mhahnenberg@apple.com> 6197 6198 De-virtualize JSObject::getPropertyNames 6199 https://bugs.webkit.org/show_bug.cgi?id=71306 6200 6201 Reviewed by Darin Adler. 6202 6203 Added getPropertyNames to the MethodTable, changed all the virtual 6204 implementations of getPropertyNames to static ones, and replaced 6205 all call sites with corresponding lookups in the MethodTable. 6206 6207 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6208 (WebKit::NetscapePluginInstanceProxy::enumerate): 6209 62102011-11-02 Darin Adler <darin@apple.com> 6211 6212 Change remaining callers of releaseRef to call leakRef 6213 https://bugs.webkit.org/show_bug.cgi?id=71422 6214 6215 Reviewed by Darin Fisher. 6216 6217 * History/WebBackForwardList.mm: 6218 (-[WebBackForwardList initWithBackForwardList:]): 6219 * History/WebHistoryItem.mm: 6220 (-[WebHistoryItem copyWithZone:]): 6221 (-[WebHistoryItem initWithWebCoreHistoryItem:]): 6222 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 6223 (-[WebHostedNetscapePluginView createPlugin]): 6224 * Plugins/WebNetscapePluginView.mm: 6225 (-[WebNetscapePluginView createPlugin]): 6226 * WebCoreSupport/WebOpenPanelResultListener.mm: 6227 * WebView/WebDataSource.mm: 6228 (-[WebDataSource _initWithDocumentLoader:]): 6229 * WebView/WebResource.mm: 6230 (-[WebResourcePrivate initWithCoreResource:]): 6231 Use leakRef. 6232 62332011-11-02 Joseph Pecoraro <pecoraro@apple.com> 6234 6235 Move NSRange / DOMRange conversion functions to WebFramePrivate 6236 https://bugs.webkit.org/show_bug.cgi?id=71435 6237 6238 Reviewed by Sam Weinig. 6239 6240 Move conversion functions to WebFramePrivate, 6241 and remove the no longer used versions. 6242 6243 * WebView/WebFrame.mm: 6244 (-[WebFrame _convertNSRangeToDOMRange:]): 6245 (-[WebFrame _convertDOMRangeToNSRange:]): 6246 * WebView/WebFrameInternal.h: 6247 * WebView/WebFramePrivate.h: 6248 62492011-11-02 Dean Jackson <dino@apple.com> 6250 6251 Add ENABLE_CSS_SHADERS flag 6252 https://bugs.webkit.org/show_bug.cgi?id=71394 6253 6254 Reviewed by Sam Weinig. 6255 6256 * Configurations/FeatureDefines.xcconfig: 6257 62582011-11-02 Jon Lee <jonlee@apple.com> 6259 6260 Expand DragController to provide more information about the dragging session 6261 https://bugs.webkit.org/show_bug.cgi?id=71324 6262 <rdar://problem/10379175> 6263 6264 Reviewed by Darin Adler. 6265 6266 * WebView/WebView.mm: 6267 (-[WebView draggingEntered:]): DragOperation is now inside the DragSession struct. 6268 (-[WebView draggingUpdated:]): 6269 62702011-11-02 Tom Sepez <tsepez@chromium.org> 6271 6272 XSSAuditor is silent 6273 https://bugs.webkit.org/show_bug.cgi?id=70973 6274 6275 Reviewed by Adam Barth. 6276 6277 * WebCoreSupport/WebFrameLoaderClient.h: 6278 * WebCoreSupport/WebFrameLoaderClient.mm: 6279 (WebFrameLoaderClient::didRunInsecureContent): 6280 (WebFrameLoaderClient::didDetectXSS): 6281 * WebView/WebDelegateImplementationCaching.h: 6282 * WebView/WebFrameLoadDelegatePrivate.h: 6283 * WebView/WebView.mm: 6284 (-[WebView _cacheFrameLoadDelegateImplementations]): 6285 62862011-11-01 Darin Adler <darin@apple.com> 6287 6288 Crash in PDF code when script has illegal UTF-8 or UTF-16 sequences 6289 https://bugs.webkit.org/show_bug.cgi?id=71289 6290 6291 Reviewed by Dan Bernstein. 6292 6293 Just adding a null check. I don't have access to an actual PDF with 6294 this problem but crashes from the field indicate they exist. 6295 6296 * WebView/WebPDFDocumentExtras.mm: 6297 (allScriptsInPDFDocument): Skip the code to add the script text 6298 to an array when the script is null. 6299 63002011-10-28 John Sullivan <sullivan@apple.com> 6301 6302 WebKit part of: 6303 https://bugs.webkit.org/show_bug.cgi?id=71142 6304 Whether backspace goes Back should be configurable 6305 6306 Reviewed by Sam Weinig. 6307 6308 * WebView/WebFrameView.mm: 6309 (-[WebFrameView keyDown:]): 6310 Honor the new preference. 6311 6312 * WebView/WebPreferenceKeysPrivate.h: 6313 Added #define for WebKitBackspaceKeyNavigationEnabledKey 6314 6315 * WebView/WebPreferences.mm: 6316 (+[WebPreferences initialize]): 6317 Initialize new pref to YES, to match current behavior. 6318 (-[WebPreferences setBackspaceKeyNavigationEnabled:]): 6319 New method, standard prefs setter. 6320 (-[WebPreferences backspaceKeyNavigationEnabled]): 6321 New method, standard prefs getter. 6322 6323 * WebView/WebPreferencesPrivate.h: 6324 Declared new methods. 6325 6326 * WebView/WebView.mm: 6327 (-[WebView _preferencesChanged:]): 6328 Updates WebCore settings from WebKit prefs. 6329 63302011-10-28 Jochen Eisinger <jochen@chromium.org> 6331 6332 Rename a number of methods mentioning JavaScript to just Script instead 6333 https://bugs.webkit.org/show_bug.cgi?id=71105 6334 6335 Reviewed by Adam Barth. 6336 6337 * WebView/WebView.mm: 6338 (-[WebView _preferencesChanged:]): 6339 63402011-10-27 Joseph Pecoraro <pecoraro@apple.com> 6341 6342 Reviewed by David Kilzer. 6343 6344 Make FeatureDefines Identical Across OS X Projects 6345 https://bugs.webkit.org/show_bug.cgi?id=71051 6346 6347 * Configurations/FeatureDefines.xcconfig: 6348 63492011-10-27 Mark Hahnenberg <mhahnenberg@apple.com> 6350 6351 De-virtualize JSCell::toThisObject 6352 https://bugs.webkit.org/show_bug.cgi?id=70958 6353 6354 Reviewed by Geoffrey Garen. 6355 6356 Converted all instances of toThisObject to static functions, 6357 added toThisObject to the MethodTable, and replaced all call sites 6358 with a corresponding lookup in the MethodTable. 6359 6360 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6361 (WebKit::NetscapePluginInstanceProxy::invoke): 6362 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 6363 63642011-10-25 Mark Hahnenberg <mhahnenberg@apple.com> 6365 6366 Remove deletePropertyVirtual 6367 https://bugs.webkit.org/show_bug.cgi?id=70738 6368 6369 Reviewed by Geoffrey Garen. 6370 6371 Removed all declarations and definitions of deletePropertyVirtual. 6372 Also replaced all call sites to deletePropertyVirtual with a 6373 corresponding lookup in the MethodTable. 6374 6375 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6376 (WebKit::NetscapePluginInstanceProxy::removeProperty): 6377 63782011-10-25 Mark Hahnenberg <mhahnenberg@apple.com> 6379 6380 Remove putVirtual 6381 https://bugs.webkit.org/show_bug.cgi?id=70740 6382 6383 Reviewed by Geoffrey Garen. 6384 6385 Removed all declarations and definitions of putVirtual. 6386 Also replaced all call sites to putVirtual with a 6387 corresponding lookup in the MethodTable. 6388 6389 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6390 (WebKit::NetscapePluginInstanceProxy::setProperty): 6391 63922011-10-24 Geoffrey Garen <ggaren@apple.com> 6393 6394 Removed SharedUChar and tightened language around its previous uses 6395 https://bugs.webkit.org/show_bug.cgi?id=70698 6396 6397 Reviewed by David Levin. 6398 6399 - Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because 6400 the former names gave the dangerous misimpression that the resulting object 6401 was thread-safe, which is not true. 6402 6403 * Storage/WebDatabaseTrackerClient.mm: 6404 (DidModifyOriginData::dispatchToMainThread): 6405 64062011-10-24 Michael Saboff <msaboff@apple.com> 6407 6408 WebKit doesn't build with recent changes to libdispatch 6409 https://bugs.webkit.org/show_bug.cgi?id=70737 6410 6411 Added initialization for new WebKitSystemInterface function 6412 CreateVMPressureDispatchOnMainQueue. 6413 6414 Reviewed by Geoffrey Garen. 6415 6416 * WebCoreSupport/WebSystemInterface.mm: 6417 (InitWebCoreSystemInterface): 6418 64192011-10-23 Mark Hahnenberg <mhahnenberg@apple.com> 6420 6421 Remove getConstructDataVirtual 6422 https://bugs.webkit.org/show_bug.cgi?id=70638 6423 6424 Reviewed by Darin Adler. 6425 6426 Removed all declarations and definitions of getConstructDataVirtual. 6427 Also replaced all call sites to getConstructDataVirtual with a 6428 corresponding lookup in the MethodTable. 6429 6430 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6431 (WebKit::NetscapePluginInstanceProxy::construct): 6432 64332011-10-20 Ian Henderson <ianh@apple.com> 6434 6435 https://bugs.webkit.org/show_bug.cgi?id=70541 6436 There are two WebFrameLoadDelegatePrivate categories on NSObject 6437 6438 Reviewed by David Kilzer. 6439 6440 * WebView/WebViewPrivate.h: Rename the private delegate categories in 6441 WebViewPrivate.h with a "WebView" prefix to avoid collision. 6442 64432011-10-20 Alexey Proskuryakov <ap@apple.com> 6444 6445 REGRESSION (r96823): Contextual menu closes immediately when control-clicking in Flash plug-in 6446 https://bugs.webkit.org/show_bug.cgi?id=70534 6447 <rdar://problem/10308827> 6448 6449 Reviewed by Darin Adler. 6450 6451 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Return true 6452 for contextmenu event, so that plug-ins won't get a default WebKit context menu. We can't 6453 know if the plug-in is handling mousedown (or even mouseup) by displaying a menu. 6454 64552011-10-19 Beth Dakin <bdakin@apple.com> 6456 6457 https://bugs.webkit.org/show_bug.cgi?id=70396 6458 Focus rings are too thin in HiDPI in WebKit2 6459 -and corresponding- 6460 <rdar://problem/10086876> 6461 6462 Reviewed by Dan Bernstein. 6463 6464 Rename wkSetPatternBaseCTM to wkSetBaseCTM 6465 * WebCoreSupport/WebSystemInterface.mm: 6466 (InitWebCoreSystemInterface): 6467 6468 To create a HiDPI context in DRT, we have to set the base CTM, which currently 6469 requires CG SPI, so we have to do it through WebKitSystemInterface. 6470 * WebView/WebView.mm: 6471 (-[WebView _setBaseCTM:forContext:]): 6472 * WebView/WebViewPrivate.h: 6473 64742011-10-18 Adam Barth <abarth@webkit.org> 6475 6476 Always enable ENABLE(XPATH) 6477 https://bugs.webkit.org/show_bug.cgi?id=70217 6478 6479 Reviewed by Eric Seidel. 6480 6481 * Configurations/FeatureDefines.xcconfig: 6482 64832011-10-14 Chris Marrin <cmarrin@apple.com> 6484 6485 Throttle rate of requestAnimationFrame when page is not visible 6486 https://bugs.webkit.org/show_bug.cgi?id=67873 6487 6488 Reviewed by Anders Carlsson. 6489 6490 Plumb through notification when the window is hidden/shown or 6491 minimized/unminimized 6492 6493 * WebView/WebView.mm: 6494 (-[WebView _windowWillOrderOnScreen:]): 6495 (-[WebView _windowWillOrderOffScreen:]): 6496 64972011-10-16 Adam Barth <abarth@webkit.org> 6498 6499 Always enable ENABLE(DOM_STORAGE) 6500 https://bugs.webkit.org/show_bug.cgi?id=70189 6501 6502 Reviewed by Eric Seidel. 6503 6504 * Configurations/FeatureDefines.xcconfig: 6505 * Storage/WebStorageManager.mm: 6506 * Storage/WebStorageManagerInternal.h: 6507 * Storage/WebStorageTrackerClient.h: 6508 * Storage/WebStorageTrackerClient.mm: 6509 (WebStorageTrackerClient::dispatchDidModifyOrigin): 6510 * WebView/WebView.mm: 6511 (-[WebView _commonInitializationWithFrameName:groupName:]): 6512 65132011-10-14 David Kilzer <ddkilzer@apple.com> 6514 6515 <http://webkit.org/b/70158> Fix clang compiler warnings 6516 6517 Reviewed by Darin Adler. 6518 6519 The following two methods in WebDelegateImplementationCaching.h 6520 are ambiguous in WebChromeClient::runJavaScriptPrompt() because 6521 the compiler can't decide how to convert the WTF::String 6522 defaultText argument: 6523 6524 id CallUIDelegate(WebView *, SEL, id, id); 6525 id CallUIDelegate(WebView *, SEL, id, BOOL); 6526 6527 The fix is to perform the conversion explicitly. 6528 6529 * WebCoreSupport/WebChromeClient.mm: 6530 (WebChromeClient::runJavaScriptPrompt): Extract a defaultString 6531 variable to convert the WTF::String to an NSString*, then 6532 use defaultString in place of defaultText. 6533 65342011-10-14 Mark Hahnenberg <mhahnenberg@apple.com> 6535 6536 Rename virtual put to putVirtual 6537 https://bugs.webkit.org/show_bug.cgi?id=69851 6538 6539 Reviewed by Darin Adler. 6540 6541 Renamed virtual versions of put to putVirtual in prepration for 6542 adding the static put to the MethodTable in ClassInfo since the 6543 compiler gets mad if the virtual and static versions have the same 6544 name. 6545 6546 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6547 (WebKit::NetscapePluginInstanceProxy::setProperty): 6548 65492011-10-14 Mark Hahnenberg <mhahnenberg@apple.com> 6550 6551 Rename virtual deleteProperty to deletePropertyVirtual 6552 https://bugs.webkit.org/show_bug.cgi?id=69884 6553 6554 Reviewed by Darin Adler. 6555 6556 Renamed virtual versions of deleteProperty to deletePropertyVirtual in prepration for 6557 adding the static deleteProperty to the MethodTable in ClassInfo since the 6558 compiler gets mad if the virtual and static versions have the same name. 6559 6560 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6561 (WebKit::NetscapePluginInstanceProxy::removeProperty): 6562 65632011-10-12 Ryosuke Niwa <rniwa@webkit.org> 6564 6565 Make the interface of locationAndLengthFromRange and rangeFromLocationAndLength consistent 6566 https://bugs.webkit.org/show_bug.cgi?id=69964 6567 6568 Reviewed by Enrica Casucci. 6569 6570 * WebView/WebFrame.mm: 6571 (-[WebFrame _convertToNSRange:]): 6572 (-[WebFrame _convertToDOMRange:]): 6573 65742011-10-13 Mark Hahnenberg <mhahnenberg@apple.com> 6575 6576 Rename virtual getConstructData to getConstructDataVirtual 6577 https://bugs.webkit.org/show_bug.cgi?id=69872 6578 6579 Reviewed by Geoffrey Garen. 6580 6581 Renamed virtual getConstructData functions to getConstructDataVirtual to 6582 avoid conflicts when we add static getConstructData to the MethodTable. 6583 6584 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6585 (WebKit::NetscapePluginInstanceProxy::construct): 6586 65872011-10-13 Beth Dakin <bdakin@apple.com> 6588 6589 https://bugs.webkit.org/show_bug.cgi?id=70050 6590 DRT and WRT should have HiDPI testing capabilities 6591 6592 Reviewed by Darin Adler. 6593 6594 New method _backingScaleFactor matches SPI of a similar name that I added 6595 recently to WKPage in WebKit2. Equivalent functionality is needed for 6596 DumpRenderTree's HiDPI support. 6597 * WebView/WebView.mm: 6598 (-[WebView _backingScaleFactor]): 6599 * WebView/WebViewPrivate.h: 6600 66012011-10-12 Chris Marrin <cmarrin@apple.com> 6602 6603 Sync requestAnimationFrame callback to CVDisplayLink on Mac 6604 https://bugs.webkit.org/show_bug.cgi?id=68911 6605 6606 Reviewed by Simon Fraser. 6607 6608 Add windowDidChangeScreen function which listens for the window changing 6609 screens and passes the new displayID along to WebCore::Page. It also sends 6610 one on windowWillOrderOnScreen, so the Page has a fresh displayID after it's 6611 created. 6612 6613 * WebView/WebView.mm: 6614 (-[WebView addWindowObserversForWindow:]): 6615 (-[WebView removeWindowObservers]): 6616 (-[WebView _windowDidChangeScreen:]): 6617 (-[WebView _windowWillOrderOnScreen:]): 6618 66192011-10-12 Adam Barth <abarth@webkit.org> 6620 6621 Remove ENABLE(XHTMLMP) and associated code 6622 https://bugs.webkit.org/show_bug.cgi?id=69729 6623 6624 Reviewed by David Levin. 6625 6626 * Configurations/FeatureDefines.xcconfig: 6627 66282011-10-10 Nate Chapin <japhet@chromium.org> 6629 6630 Use a CachedImageClient instead of CachedResourceClient 6631 in WebHTMLView. 6632 https://bugs.webkit.org/show_bug.cgi?id=69790 6633 6634 Reviewed by Adam Barth. 6635 6636 * WebView/WebHTMLView.mm: 6637 (promisedDataClient): 6638 66392011-10-10 Mark Hahnenberg <mhahnenberg@apple.com> 6640 6641 Remove getCallDataVirtual methods 6642 https://bugs.webkit.org/show_bug.cgi?id=69186 6643 6644 Reviewed by Geoffrey Garen. 6645 6646 Removed all getCallDataVirtual methods and replaced their call sites 6647 with an explicit lookup in the MethodTable. 6648 6649 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6650 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 6651 66522011-10-10 Joseph Pecoraro <joepeck@webkit.org> 6653 6654 Extract WebOpenPanelResultListener out into its own file 6655 https://bugs.webkit.org/show_bug.cgi?id=69575 6656 6657 Reviewed by David Kilzer. 6658 6659 Extract the WebOpenPanelResultListener class out into 6660 its own file. No functional change. 6661 6662 * WebCoreSupport/WebChromeClient.mm: 6663 * WebCoreSupport/WebOpenPanelResultListener.h: Added. 6664 * WebCoreSupport/WebOpenPanelResultListener.mm: Added. 6665 (-[WebOpenPanelResultListener dealloc]): 6666 (-[WebOpenPanelResultListener finalize]): 6667 (-[WebOpenPanelResultListener cancel]): 6668 (-[WebOpenPanelResultListener chooseFilename:]): 6669 (-[WebOpenPanelResultListener chooseFilenames:]): 6670 * WebView/WebUIDelegate.h: 6671 66722011-10-08 Sheriff Bot <webkit.review.bot@gmail.com> 6673 6674 Unreviewed, rolling out r96996. 6675 http://trac.webkit.org/changeset/96996 6676 https://bugs.webkit.org/show_bug.cgi?id=69697 6677 6678 It broke all tests on the Qt bot (Requested by Ossy_night on 6679 #webkit). 6680 6681 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6682 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 6683 66842011-10-07 Mark Hahnenberg <mhahnenberg@apple.com> 6685 6686 Remove getCallDataVirtual methods 6687 https://bugs.webkit.org/show_bug.cgi?id=69186 6688 6689 Reviewed by Geoffrey Garen. 6690 6691 Removed all getCallDataVirtual methods and replaced their call sites 6692 with an explicit lookup in the MethodTable. 6693 6694 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6695 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 6696 66972011-10-06 Anders Carlsson <andersca@apple.com> 6698 6699 When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors 6700 https://bugs.webkit.org/show_bug.cgi?id=69586 6701 6702 Reviewed by Darin Adler. 6703 6704 * Configurations/Base.xcconfig: 6705 Add -Wglobal-constructors and -Wexit-time-destructors when building with clang. 6706 67072011-10-06 Anders Carlsson <andersca@apple.com> 6708 6709 Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds 6710 https://bugs.webkit.org/show_bug.cgi?id=69584 6711 6712 Reviewed by Darin Adler. 6713 6714 Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro. 6715 6716 * Plugins/Hosted/HostedNetscapePluginStream.mm: 6717 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6718 67192011-10-03 Andy Estes <aestes@apple.com> 6720 6721 Add an option to suppress rendering until the document's load event fires. 6722 https://bugs.webkit.org/show_bug.cgi?id=69298 6723 6724 Reviewed by Simon Fraser. 6725 6726 Add a new private WebPreference. 6727 6728 * WebView/WebPreferenceKeysPrivate.h: 6729 * WebView/WebPreferences.mm: 6730 (+[WebPreferences initialize]): 6731 (-[WebPreferences setSuppressRenderingWhileInitiallyLoading:]): 6732 (-[WebPreferences suppressRenderingWhileInitiallyLoading]): 6733 * WebView/WebPreferencesPrivate.h: 6734 * WebView/WebView.mm: 6735 (-[WebView _preferencesChanged:]): 6736 67372011-10-05 Jer Noble <jer.noble@apple.com> 6738 6739 Enable WEB_AUDIO by default in the WebKit/mac port. 6740 https://bugs.webkit.org/show_bug.cgi?id=68587 6741 6742 Reviewed by Simon Fraser. 6743 6744 * Configurations/FeatureDefines.xcconfig: 6745 67462011-10-05 David Kilzer <ddkilzer@apple.com> 6747 6748 <http://webkit.org/b/69386> REGRESSION: Curious Location of StorageTracker.db 6749 6750 Reviewed by Alexey Proskuryakov. 6751 6752 * Storage/WebStorageManager.mm: 6753 (+[WebStorageManager _storageDirectoryPath]): Restore call to 6754 -[NSString stringByStandardizingPath]. Also fix over-release of 6755 sLocalStoragePath if the initial -objectForKey: call returned an 6756 NSString object. Use pthread_once to be thread-safe. 6757 67582011-10-04 Kent Tamura <tkent@chromium.org> 6759 6760 Introduce feature flags for incomplete input types 6761 https://bugs.webkit.org/show_bug.cgi?id=68971 6762 6763 Reviewed by Hajime Morita. 6764 6765 * Configurations/FeatureDefines.xcconfig: 6766 Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS. 6767 67682011-10-03 Geoffrey Garen <ggaren@apple.com> 6769 6770 Some JSValue cleanup 6771 https://bugs.webkit.org/show_bug.cgi?id=69320 6772 6773 Reviewed by Darin Adler. 6774 6775 * WebView/WebView.mm: 6776 (aeDescFromJSValue): Updated for JSC changes. 6777 67782011-10-04 Scott Graham <scottmg@chromium.org> 6779 6780 Add GAMEPAD feature flag 6781 https://bugs.webkit.org/show_bug.cgi?id=66859 6782 6783 Reviewed by Darin Fisher. 6784 6785 * Configurations/FeatureDefines.xcconfig: 6786 67872011-10-03 Jer Noble <jer.noble@apple.com> 6788 6789 Unreviewed, rolling out r96526. 6790 http://trac.webkit.org/changeset/96526 6791 https://bugs.webkit.org/show_bug.cgi?id=68587 6792 6793 WEB_AUDIO has numerous 64->32 bit casting warnings, causing 6794 build breakages where -Wall is enabled. 6795 6796 * Configurations/FeatureDefines.xcconfig: 6797 67982011-10-03 Jer Noble <jer.noble@apple.com> 6799 6800 Enable WEB_AUDIO by default in the WebKit/mac port. 6801 https://bugs.webkit.org/show_bug.cgi?id=68587 6802 6803 Reviewed by Simon Fraser. 6804 6805 * Configurations/FeatureDefines.xcconfig: 6806 68072011-10-02 Sam Weinig <sam@webkit.org> 6808 6809 Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers 6810 https://bugs.webkit.org/show_bug.cgi?id=69230 6811 6812 Reviewed by Anders Carlsson. 6813 6814 * WebView/WebHTMLRepresentation.mm: 6815 (regExpForLabels): 6816 (searchForLabelsBeforeElement): 6817 (matchLabelsAgainstString): 6818 (matchLabelsAgainstElement): 6819 (-[WebHTMLRepresentation searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]): 6820 (-[WebHTMLRepresentation matchLabels:againstElement:]): 6821 68222011-10-02 Alexey Proskuryakov <ap@apple.com> 6823 6824 REGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode 6825 https://bugs.webkit.org/show_bug.cgi?id=68542 6826 6827 Reviewed by Mark Rowe. 6828 6829 * WebView/WebView.mm: (-[WebView _usesDocumentViews]): Re-add this method for now. 6830 68312011-10-01 Geoffrey Garen <ggaren@apple.com> 6832 6833 Leopard build fix: Updated for Strong<T> changes. 6834 6835 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6836 * WebView/WebScriptDebugger.mm: 6837 68382011-09-28 Joseph Pecoraro <joepeck@webkit.org> 6839 6840 ASSERT if WebView's UIDelegate does not implement webView:runOpenPanel 6841 https://bugs.webkit.org/show_bug.cgi?id=69037 6842 6843 Reviewed by Alexey Proskuryakov. 6844 6845 * WebCoreSupport/WebChromeClient.mm: 6846 (WebChromeClient::runOpenPanel): 6847 If no delegate is implemented, dismiss the listener 6848 with a cancel. It expects some action. 6849 68502011-09-28 Anton D'Auria <adauria@apple.com> 6851 6852 Expose +[WebStorageManager _storageDirectoryPath] as SPI 6853 https://bugs.webkit.org/show_bug.cgi?id=68951 6854 6855 Reviewed by Brady Eidson. 6856 6857 This patch exposes +[WebStorageManager _storageDirectoryPath], which 6858 pulls the path from NSUserDefaults if the preference is set. Otherwise, 6859 it falls back on the default path. 6860 6861 * Storage/WebStorageManager.mm: 6862 (+[WebStorageManager _storageDirectoryPath]): Adding static variable 6863 so that we don't reread user defaults repeatedly. 6864 (WebKitInitializeStorageIfNecessary): 6865 * Storage/WebStorageManagerPrivate.h: 6866 68672011-09-27 Andy Estes <aestes@apple.com> 6868 6869 WebKitLinkedOnOrAfter() check is ineffective for Solar Walk app-specific hack. 6870 https://bugs.webkit.org/show_bug.cgi?id=68863 6871 6872 Reviewed by Darin Adler. 6873 6874 The SolarWalk binary does not link against WebKit.framework directly, 6875 so calling NSVersionOfLinkTimeLibrary() will not return the version of 6876 WebKit against which SolarWalk was linked. Since Solar Walk has 6877 released an update that addresses the issue for which this app-specific 6878 hack was originally added, we should just remove the hack. 6879 6880 * Misc/SolarWalkQuirksUserScript.js: Removed. 6881 * WebView/WebView.mm: Removed needsSolarWalkQuirksScript(), 6882 leakSolarWalkQuirksUserScriptContents(), and 6883 -[WebView _injectSolarWalkQuirksScript]. 6884 (-[WebView _commonInitializationWithFrameName:groupName:]): Do not 6885 inject the Solar Walk quirks script. 6886 68872011-09-27 Mark Hahnenberg <mhahnenberg@apple.com> 6888 6889 Add static version of JSCell::getCallData 6890 https://bugs.webkit.org/show_bug.cgi?id=68741 6891 6892 Reviewed by Darin Adler. 6893 6894 In this patch we just extract the bodies of the virtual getCallData methods 6895 throughout the JSCell inheritance hierarchy out into static methods, which are 6896 now called from the virtual methods. This is an intermediate step in trying to 6897 move the virtual-ness of getCallData into our own method table stored in 6898 ClassInfo. We need to convert the methods to static methods because static methods 6899 can be represented as function pointers rather than pointers to member functions, and 6900 function pointers are smaller and faster to call than pointers to member functions. 6901 6902 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 6903 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 6904 69052011-09-23 Simon Fraser <simon.fraser@apple.com> 6906 6907 Repaint tests don't work in WebKit2 6908 https://bugs.webkit.org/show_bug.cgi?id=68453 6909 6910 Reviewed by Sam Weinig. 6911 6912 Have FrameView keep track of repaint rects when asked to, and 6913 expose this set of repaint rects via private WebKit API for later 6914 use by DumpRenderTree. 6915 6916 * WebView/WebView.mm: 6917 (-[WebView setTracksRepaints:]): 6918 (-[WebView isTrackingRepaints]): 6919 (-[WebView resetTrackedRepaints]): 6920 (-[WebView trackedRepaintRects]): 6921 * WebView/WebViewPrivate.h: 6922 69232011-09-25 Mark Hahnenberg <mhahnenberg@apple.com> 6924 6925 Add custom vtable struct to ClassInfo struct 6926 https://bugs.webkit.org/show_bug.cgi?id=68567 6927 6928 Reviewed by Oliver Hunt. 6929 6930 Added CREATE_METHOD_TABLE macro to generate the custom vtable for the 6931 specified class in its ClassInfo. Also added to it the first function to use 6932 this macro, visitChildren. This is part of the process of getting rid of all 6933 C++ virtual methods in JSCell. Eventually all virtual functions in JSCell 6934 that can't easily be converted to non-virtual functions will be put into 6935 this custom vtable structure. 6936 6937 * Plugins/Hosted/ProxyInstance.mm: 6938 * Plugins/Hosted/ProxyRuntimeObject.mm: 6939 69402011-09-24 Adam Barth <abarth@webkit.org> 6941 6942 Always enable ENABLE(OFFLINE_WEB_APPLICATIONS) 6943 https://bugs.webkit.org/show_bug.cgi?id=68767 6944 6945 Reviewed by Eric Seidel. 6946 6947 * Configurations/FeatureDefines.xcconfig: 6948 * Misc/WebCache.mm: 6949 (+[WebCache empty]): 6950 * WebCoreSupport/WebApplicationCache.mm: 6951 * WebCoreSupport/WebApplicationCacheQuotaManager.mm: 6952 (-[WebApplicationCacheQuotaManager usage]): 6953 (-[WebApplicationCacheQuotaManager quota]): 6954 (-[WebApplicationCacheQuotaManager setQuota:]): 6955 * WebCoreSupport/WebChromeClient.h: 6956 * WebCoreSupport/WebChromeClient.mm: 6957 * WebView/WebDataSource.mm: 6958 (-[WebDataSource _transferApplicationCache:]): 6959 * WebView/WebFrame.mm: 6960 (-[WebFrame _cacheabilityDictionary]): 6961 * WebView/WebView.mm: 6962 (WebKitInitializeApplicationCachePathIfNecessary): 6963 69642011-09-23 Adam Klein <adamk@chromium.org> 6965 6966 Add ENABLE_MUTATION_OBSERVERS feature flag 6967 https://bugs.webkit.org/show_bug.cgi?id=68732 6968 6969 Reviewed by Ojan Vafai. 6970 6971 This flag will guard an implementation of the "Mutation Observers" proposed in 6972 http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html 6973 6974 * Configurations/FeatureDefines.xcconfig: 6975 69762011-09-23 Anders Carlsson <andersca@apple.com> 6977 6978 Axe WebImageRendererFactory 6979 https://bugs.webkit.org/show_bug.cgi?id=68715 6980 6981 Reviewed by Darin Adler. 6982 6983 Remove WebImageRendererFactory, it was used by Safari 3, many a moon ago. 6984 6985 * WebCoreSupport/WebImageRendererFactory.m: Removed. 6986 69872011-09-23 Anders Carlsson <andersca@apple.com> 6988 6989 Add OVERRIDE to a bunch of virtual member functions on clients 6990 https://bugs.webkit.org/show_bug.cgi?id=68712 6991 6992 Reviewed by Sam Weinig. 6993 6994 * Configurations/Base.xcconfig: 6995 * WebCoreSupport/WebChromeClient.h: 6996 * WebCoreSupport/WebContextMenuClient.h: 6997 * WebCoreSupport/WebDeviceOrientationClient.h: 6998 * WebCoreSupport/WebDragClient.h: 6999 * WebCoreSupport/WebEditorClient.h: 7000 * WebCoreSupport/WebFrameLoaderClient.h: 7001 * WebCoreSupport/WebFrameNetworkingContext.h: 7002 * WebCoreSupport/WebGeolocationClient.h: 7003 * WebCoreSupport/WebIconDatabaseClient.h: 7004 * WebCoreSupport/WebInspectorClient.h: 7005 * WebCoreSupport/WebPlatformStrategies.h: 7006 70072011-09-22 Dean Jackson <dino@apple.com> 7008 7009 Add ENABLE_CSS_FILTERS 7010 https://bugs.webkit.org/show_bug.cgi?id=68652 7011 7012 Reviewed by Simon Fraser. 7013 7014 * Configurations/FeatureDefines.xcconfig: 7015 70162011-09-22 Anders Carlsson <andersca@apple.com> 7017 7018 Get rid of Widget::setBoundsSize 7019 https://bugs.webkit.org/show_bug.cgi?id=68491 7020 7021 Reviewed by Sam Weinig. 7022 7023 This basically reverts http://trac.webkit.org/changeset/79167 and http://trac.webkit.org/changeset/75897 7024 which were added to make zoom gestures work with WebKit1, but since we don't support zoom gestures in WebKit1 7025 anymore, it's better for code cleanliness to get rid of Widget::setBoundsSize and the associated code. While this 7026 will unfortunately break transformed iframes in WebKit1, but Simon says that it's an acceptable tradeoff. 7027 7028 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 7029 (-[WebHostedNetscapePluginView updateAndSetWindow]): 7030 * WebView/WebFrameView.mm: 7031 70322011-09-19 Jer Noble <jer.noble@apple.com> 7033 7034 Add settings to control the availability of the Web Audio API to WebKit and WebKit2. 7035 https://bugs.webkit.org/show_bug.cgi?id=68382 7036 7037 Reviewed by Darin Adler. 7038 7039 Initialize the webAudioEnabled preference to NO by default. 7040 7041 * WebView/WebPreferences.mm: 7042 (+[WebPreferences initialize]): 7043 70442011-09-21 Anders Carlsson <andersca@apple.com> 7045 7046 Remove checks for Leopard-only Objective-C APIs 7047 https://bugs.webkit.org/show_bug.cgi?id=68579 7048 7049 Reviewed by Sam Weinig. 7050 7051 We can always assume that OBJC_API_VERSION is at least 2, it's been 2 since Leopard. 7052 7053 * Misc/WebNSObjectExtras.h: 7054 70552011-09-21 Andras Becsi <andras.becsi@nokia.com> 7056 7057 [Qt] Remove Qt specific code from css/SelectorChecker.cpp 7058 https://bugs.webkit.org/show_bug.cgi?id=67702 7059 7060 Reviewed by Csaba Osztrogonác. 7061 7062 * WebCoreSupport/WebPlatformStrategies.h: 7063 * WebCoreSupport/WebPlatformStrategies.mm: 7064 (WebPlatformStrategies::isLinkVisited): 7065 70662011-09-20 Anders Carlsson <andersca@apple.com> 7067 7068 Remove ScrollView::platformContentsSize 7069 https://bugs.webkit.org/show_bug.cgi?id=68188 7070 7071 Reviewed by Darin Adler. 7072 7073 When creating the document view, make sure it's zero sized which matches the initial size 7074 of the ScrollView. This is fine to do early since DocumentWriter::begin sets the contents 7075 size to a zero size anyway. 7076 7077 * WebView/WebFrameView.mm: 7078 (-[WebFrameView _makeDocumentViewForDataSource:]): 7079 70802011-09-19 Pavel Feldman <pfeldman@google.com> 7081 7082 Web Inspector: streamline Console's MessageType and MessageSource semantics. 7083 https://bugs.webkit.org/show_bug.cgi?id=68342 7084 7085 This change fixes semantics of the MessageSource and MessageType: 7086 MessageSource is now the source of the message (be it Network, HTML 7087 parser or Console API). MessageType is only defined for the Console API 7088 messages and contains the name of the API call (log, dir, dirxml, etc.). 7089 Subsequent https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType 7090 private to the inspector. 7091 7092 Reviewed by Tony Gentilcore. 7093 7094 * WebCoreSupport/WebChromeClient.mm: 7095 (stringForMessageSource): 7096 (stringForMessageType): 7097 * WebView/WebUIDelegatePrivate.h: 7098 70992011-09-19 Timothy Hatcher <timothy@apple.com> 7100 7101 Make WebViews in NSPopovers render as they would in active windows. 7102 7103 The NSWindowDid{Become,Resign}KeyNotifications are not fired when NSPopovers 7104 are shown or hidden since they share key with the parent window. So WebView 7105 and WebHTMLView need to also observe the will order on/off screen notifications. 7106 7107 https://webkit.org/b/68402 7108 rdar://problem/9754099 7109 7110 Reviewed by John Sullivan. 7111 7112 * WebView/WebHTMLView.mm: 7113 (-[WebHTMLView _removeWindowObservers]): Remove order on/off screen notification obversers. 7114 (-[WebHTMLView addWindowObservers]): Add order on/off screen notification obversers. 7115 (-[WebHTMLView windowWillOrderOnScreen:]): Check if the window is already a key window, 7116 which can be the case for NSPopovers. 7117 (-[WebHTMLView windowWillOrderOffScreen:]): Remove the mouse moved observer. 7118 * WebView/WebView.mm: 7119 (-[WebView addWindowObserversForWindow:]): Add order off screen notification obverser. 7120 (-[WebView removeWindowObservers]): Remove order off screen notification obverser. 7121 (-[WebView _windowWillOrderOnScreen:]): Call _updateActiveState. 7122 (-[WebView _windowWillOrderOffScreen:]): Ditto. 7123 71242011-09-19 Mark Rowe <mrowe@apple.com> 7125 7126 <http://webkit.org/b/68421> Stop calling UpdateSystemActivity in places where we hold power assertions that achieve the same effect 7127 7128 On SnowLeopard and newer it's not necessary to call UpdateSystemActivity to prevent the screensaver from kicking 7129 in as the NoDisplaySleep assertion now has that effect. It's also not necessary to hold both a NoDisplaySleep and 7130 a NoIdleSleep assertion as the latter is implied by the former. 7131 7132 Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WebFullScreenController. 7133 7134 Reviewed by Dan Bernstein. 7135 7136 * WebView/WebFullScreenController.h: 7137 * WebView/WebFullScreenController.mm: 7138 (-[WebFullScreenController dealloc]): 7139 (-[WebFullScreenController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting 7140 display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any 7141 disabler that we own. 7142 71432011-09-19 Adam Barth <abarth@webkit.org> 7144 7145 Always enable ENABLE(EVENTSOURCE) 7146 https://bugs.webkit.org/show_bug.cgi?id=68414 7147 7148 Reviewed by Eric Seidel. 7149 7150 * Configurations/FeatureDefines.xcconfig: 7151 71522011-09-19 Anders Carlsson <andersca@apple.com> 7153 7154 Fix crashes when running WebKit1 tests. 7155 7156 -[WebView _mustDrawUnionedRect:singleRects:count:] was removed, so just put back the 7157 equivalent code directly into -[WebHTMLView drawRect:]. 7158 7159 * WebView/WebHTMLView.mm: 7160 (-[WebHTMLView drawRect:]): 7161 * WebView/WebViewInternal.h: 7162 71632011-09-19 Anders Carlsson <andersca@apple.com> 7164 7165 Remove the last remains of viewless WebKit1 7166 https://bugs.webkit.org/show_bug.cgi?id=68388 7167 7168 Reviewed by Darin Adler. 7169 7170 * WebCoreSupport/WebFrameLoaderClient.mm: 7171 (WebFrameLoaderClient::forceLayoutForNonHTML): 7172 Remove null check. 7173 7174 * WebView/WebView.mm: 7175 (-[WebView _commonInitializationWithFrameName:groupName:]): 7176 Remove usesDocumentViews parameter and checks. 7177 7178 (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): 7179 Add an assertion that usesDocumentViews is always true. 7180 7181 (-[WebView _isUsingAcceleratedCompositing]): 7182 Remove usesDocumentViews check. 7183 7184 (-[WebView _isSoftwareRenderable]): 7185 Remove usesDocumentViews check. 7186 7187 (-[WebView initWithFrame:frameName:groupName:]): 7188 Remove usesDocumentViews parameter and always pass YES to the _initWithFrame method. 7189 7190 (-[WebView initWithCoder:]): 7191 Remove usesDocumentViews parameter. 7192 7193 (-[WebView _frameViewAtWindowPoint:]): 7194 Remove usesDocumentViews check. 7195 7196 * WebView/WebViewData.h: 7197 Remove usesDocumentViews ivar. 7198 7199 * WebView/WebViewPrivate.h: 7200 Remove usesDocumentViews parameters. 7201 72022011-09-19 Anders Carlsson <andersca@apple.com> 7203 7204 Remove WebViewEventHandling.mm 7205 https://bugs.webkit.org/show_bug.cgi?id=68387 7206 7207 Reviewed by Adam Roben. 7208 7209 WebViewEventHandling.mm was all about event handling in viewless WebKit, so rip it out since 7210 we're getting rid of viewless WebKit1. 7211 7212 * WebView/WebView.mm: 7213 (-[WebView _close]): 7214 * WebView/WebViewData.h: 7215 * WebView/WebViewEventHandling.mm: Removed. 7216 * WebView/WebViewInternal.h: 7217 72182011-09-19 Anders Carlsson <andersca@apple.com> 7219 7220 Remove -[WebView _selectionChanged] and -[WebView _setTooltip:] 7221 https://bugs.webkit.org/show_bug.cgi?id=68385 7222 7223 Reviewed by Adam Roben. 7224 7225 Move these functions back into the respective clients and remove usesDocumentViews checks. 7226 7227 * WebCoreSupport/WebChromeClient.mm: 7228 (WebChromeClient::setToolTip): 7229 * WebCoreSupport/WebEditorClient.mm: 7230 (WebEditorClient::respondToChangedSelection): 7231 * WebView/WebView.mm: 7232 * WebView/WebViewEventHandling.mm: 7233 * WebView/WebViewInternal.h: 7234 72352011-09-19 Anders Carlsson <andersca@apple.com> 7236 7237 Begin removing -[WebView _usesDocumentCalls] from WebView.mm 7238 https://bugs.webkit.org/show_bug.cgi?id=68383 7239 7240 Reviewed by Adam Roben. 7241 7242 Remove checks and begin assuming that -[WebView _usesDocumentViews] always 7243 returns true, since viewless WebKit1 has been abandoned. 7244 7245 * WebView/WebView.mm: 7246 (-[WebView selectedFrame]): 7247 (-[WebView setHostWindow:]): 7248 (-[WebView acceptsFirstResponder]): 7249 (-[WebView becomeFirstResponder]): 7250 (-[WebView _webcore_effectiveFirstResponder]): 7251 (-[WebView setNextKeyView:]): 7252 (-[WebView setHoverFeedbackSuspended:]): 7253 72542011-09-19 Anders Carlsson <andersca@apple.com> 7255 7256 Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm 7257 https://bugs.webkit.org/show_bug.cgi?id=68379 7258 7259 Reviewed by Adam Roben. 7260 7261 Remove checks and begin assuming that -[WebView _usesDocumentViews] always 7262 returns true, since viewless WebKit1 has been abandoned. 7263 7264 * WebCoreSupport/WebFrameLoaderClient.mm: 7265 (WebFrameLoaderClient::hasHTMLView): 7266 (WebFrameLoaderClient::dispatchDidCommitLoad): 7267 (WebFrameLoaderClient::transitionToCommittedForNewPage): 7268 (WebFrameLoaderClient::createFrame): 7269 * WebView/WebFrame.mm: 7270 (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): 7271 (-[WebFrame _hasSelection]): 7272 (-[WebFrame _clearSelection]): 7273 (-[WebFrame _shouldFlattenCompositingLayers:]): 7274 (-[WebFrame _dragSourceEndedAt:operation:]): 7275 (-[WebFrame frameView]): 7276 72772011-09-19 Anders Carlsson <andersca@apple.com> 7278 7279 Remove calls to -[WebView _usesDocumentViews] 7280 https://bugs.webkit.org/show_bug.cgi?id=68377 7281 7282 Reviewed by Adam Roben. 7283 7284 Remove checks and begin assuming that -[WebView _usesDocumentViews] always 7285 returns true, since viewless WebKit1 has been abandoned. 7286 7287 * WebCoreSupport/WebChromeClient.mm: 7288 (WebChromeClient::windowResizerRect): 7289 (WebChromeClient::invalidateContentsAndWindow): 7290 (WebChromeClient::screenToWindow): 7291 (WebChromeClient::windowToScreen): 7292 (WebChromeClient::platformPageClient): 7293 (WebChromeClient::scrollRectIntoView): 7294 (WebChromeClient::print): 7295 * WebView/WebDataSource.mm: 7296 (-[WebDataSource _receivedData:]): 7297 72982011-09-19 Dan Bernstein <mitz@apple.com> 7299 7300 WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes 7301 https://bugs.webkit.org/show_bug.cgi?id=68323 7302 7303 Reviewed by Sam Weinig. 7304 7305 Renamed NonBlockingPanel to WebNonBlockingPanel. 7306 Renamed ThreadEnabler to WebCocoaThreadingEnabler. 7307 Renamed PDFPrefUpdatingProxy to WebPDFPrefUpdatingProxy. 7308 7309 * Misc/WebIconDatabase.mm: 7310 (+[WebCocoaThreadingEnabler enableThreading]): 7311 (importToWebCoreFormat): 7312 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: 7313 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: 7314 * Panels/WebAuthenticationPanel.h: 7315 * Panels/WebAuthenticationPanel.m: Renamed NonBlockingPanel to 7316 WebNonBlockingPanel. Because Safari 5.1 uses NonBlockingPanel, this will 7317 cause nightly builds to log an error message when showing the Safari 7318 HTTP authentication sheet and disable the Quit command while the sheet 7319 is disaplyed. 7320 * WebView/WebPDFView.mm: 7321 (-[WebPDFView initWithFrame:]): 7322 (-[WebPDFView _updatePreferencesSoon]): 7323 73242011-09-17 Mihai Parparita <mihaip@chromium.org> 7325 7326 FrameLoaderClient BackForwardList-related methods are unsued 7327 https://bugs.webkit.org/show_bug.cgi?id=68293 7328 7329 Reviewed by Darin Adler. 7330 7331 Remove FrameLoaderClient methods that were added by r51629, since only 7332 the old (since-deleted) Android port needed them. 7333 7334 * WebCoreSupport/WebFrameLoaderClient.h: 7335 * WebCoreSupport/WebFrameLoaderClient.mm: 7336 * WebKit.order: 7337 73382011-09-16 Simon Fraser <simon.fraser@apple.com> 7339 7340 Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms 7341 https://bugs.webkit.org/show_bug.cgi?id=68134 7342 7343 Reviewed by Sam Weinig. 7344 7345 Hook up a private preference that enables the mock scrollbar theme. 7346 7347 * WebView/WebPreferenceKeysPrivate.h: 7348 * WebView/WebPreferences.mm: 7349 (-[WebPreferences mockScrollbarsEnabled]): 7350 (-[WebPreferences setMockScrollbarsEnabled:]): 7351 * WebView/WebPreferencesPrivate.h: 7352 73532011-09-15 Adam Barth <abarth@webkit.org> 7354 7355 Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE) 7356 https://bugs.webkit.org/show_bug.cgi?id=68205 7357 7358 Reviewed by Eric Seidel. 7359 7360 * Storage/WebDatabaseManager.mm: 7361 * Storage/WebDatabaseManagerInternal.h: 7362 * Storage/WebDatabaseManagerPrivate.h: 7363 * Storage/WebDatabaseQuotaManager.mm: 7364 (-[WebDatabaseQuotaManager usage]): 7365 (-[WebDatabaseQuotaManager quota]): 7366 (-[WebDatabaseQuotaManager setQuota:]): 7367 * Storage/WebDatabaseTrackerClient.h: 7368 * Storage/WebDatabaseTrackerClient.mm: 7369 * WebCoreSupport/WebChromeClient.h: 7370 * WebCoreSupport/WebChromeClient.mm: 7371 * WebCoreSupport/WebSecurityOrigin.mm: 7372 (-[WebSecurityOrigin usage]): 7373 (-[WebSecurityOrigin quota]): 7374 (-[WebSecurityOrigin setQuota:]): 7375 * WebView/WebFrame.mm: 7376 (-[WebFrame _cacheabilityDictionary]): 7377 * WebView/WebView.mm: 7378 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 7379 (-[WebView _preferencesChanged:]): 7380 73812011-09-15 Mark Hahnenberg <mhahnenberg@apple.com> 7382 7383 Unzip initialization lists and constructors in JSCell hierarchy (7/7) 7384 https://bugs.webkit.org/show_bug.cgi?id=68122 7385 7386 Reviewed by Geoffrey Garen. 7387 7388 Completed the seventh and final level of the refactoring to add finishCreation() 7389 methods to all classes within the JSCell hierarchy with non-trivial 7390 constructor bodies. 7391 7392 * Plugins/Hosted/ProxyInstance.mm: 7393 (WebKit::ProxyRuntimeMethod::create): 7394 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod): 7395 * Plugins/Hosted/ProxyRuntimeObject.h: 7396 (WebKit::ProxyRuntimeObject::create): 7397 * Plugins/Hosted/ProxyRuntimeObject.mm: 7398 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject): 7399 74002011-09-15 Kentaro Hara <haraken@google.com> 7401 7402 A single line must not be split into two pages. 7403 https://bugs.webkit.org/show_bug.cgi?id=65005 7404 7405 Reviewed by David Hyatt. 7406 7407 When the document width of a page is overflowed, the last line of the page can be 7408 split into the next page. This is the regression caused by r88737. r88737 tried to 7409 fix rounding errors in rendering calculations by expanding and shrinking a page 7410 using one common method, resizePageRectsKeepingRatio(), but overlooked the case where 7411 a document width gets overflowed. 7412 7413 Test: printing/single-line-must-not-be-split-into-two-pages.html 7414 7415 * WebView/WebHTMLView.mm: 7416 (-[WebHTMLView _web_setPrintingModeRecursive]): Passes an original page size to setPrinting(). 7417 (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto. 7418 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto. 7419 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Ditto. 7420 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Ditto. 7421 (-[WebHTMLView _endPrintMode]): Ditto. 7422 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): Ditto. 7423 (-[WebHTMLView _endScreenPaginationMode]): Ditto. 7424 (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]): Ditto. 7425 (-[WebHTMLView layout]): Ditto. 7426 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): Ditto. 7427 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto. 7428 (-[WebHTMLView setPageWidthForPrinting:]): Ditto. 7429 74302011-09-15 Eric Seidel <eric@webkit.org> 7431 7432 Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default 7433 https://bugs.webkit.org/show_bug.cgi?id=68182 7434 7435 Reviewed by Adam Barth. 7436 7437 * Configurations/FeatureDefines.xcconfig: 7438 74392011-09-15 Eric Seidel <eric@webkit.org> 7440 7441 Remove ENABLE_SVG_ANIMATION as all major ports have it on by default 7442 https://bugs.webkit.org/show_bug.cgi?id=68022 7443 7444 Reviewed by Ryosuke Niwa. 7445 7446 * Configurations/FeatureDefines.xcconfig: 7447 74482011-09-14 Anders Carlsson <andersca@apple.com> 7449 7450 Get rid of WebCoreViewFactory and its WebViewFactory subclass 7451 https://bugs.webkit.org/show_bug.cgi?id=68124 7452 7453 Reviewed by Sam Weinig. 7454 7455 * WebCoreSupport/WebContextMenuClient.mm: 7456 * WebCoreSupport/WebViewFactory.h: Removed. 7457 * WebCoreSupport/WebViewFactory.mm: Removed. 7458 * WebView/WebFrameView.mm: 7459 (-[WebFrameView initWithFrame:]): 7460 74612011-09-14 Mark Hahnenberg <mhahnenberg@apple.com> 7462 7463 Unzip initialization lists and constructors in JSCell hierarchy (6/7) 7464 https://bugs.webkit.org/show_bug.cgi?id=67692 7465 7466 Reviewed by Geoffrey Garen. 7467 7468 Completed the sixth level of the refactoring to add finishCreation() 7469 methods to all classes within the JSCell hierarchy with non-trivial 7470 constructor bodies. 7471 7472 This primarily consists of pushing the calls to finishCreation() down 7473 into the constructors of the subclasses of the fifth level of the hierarchy 7474 as well as pulling the finishCreation() calls out into the class's corresponding 7475 create() method if it has one. Doing both simultaneously allows us to 7476 maintain the invariant that the finishCreation() method chain is called exactly 7477 once during the creation of an object, since calling it any other number of 7478 times (0, 2, or more) will cause an assertion failure. 7479 7480 * Plugins/Hosted/ProxyInstance.mm: 7481 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod): 7482 (WebKit::ProxyRuntimeMethod::finishCreation): 7483 74842011-09-13 Eric Seidel <eric@webkit.org> 7485 7486 Remove ENABLE_SVG_USE as <use> is required by HTML5 7487 https://bugs.webkit.org/show_bug.cgi?id=68019 7488 7489 Reviewed by Ryosuke Niwa. 7490 7491 * Configurations/FeatureDefines.xcconfig: 7492 74932011-09-13 Anders Carlsson <andersca@apple.com> 7494 7495 Disable C++ exceptions when building with clang 7496 https://bugs.webkit.org/show_bug.cgi?id=68031 7497 <rdar://problem/9556880> 7498 7499 Reviewed by Mark Rowe. 7500 7501 * Configurations/Base.xcconfig: 7502 75032011-09-13 Eric Seidel <eric@webkit.org> 7504 7505 Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5 7506 https://bugs.webkit.org/show_bug.cgi?id=68018 7507 7508 Reviewed by Ryosuke Niwa. 7509 7510 * Configurations/FeatureDefines.xcconfig: 7511 75122011-09-09 Oliver Hunt <oliver@apple.com> 7513 7514 Remove support for anonymous storage from jsobjects 7515 https://bugs.webkit.org/show_bug.cgi?id=67881 7516 7517 Reviewed by Sam Weinig. 7518 7519 Remove the use of AnonymousSlotCount 7520 7521 * Plugins/Hosted/ProxyInstance.mm: 7522 (WebKit::ProxyRuntimeMethod::createStructure): 7523 * Plugins/Hosted/ProxyRuntimeObject.h: 7524 (WebKit::ProxyRuntimeObject::createStructure): 7525 75262011-09-09 Chris Marrin <cmarrin@apple.com> 7527 7528 requestAnimationFrame doesn't throttle on Mac 7529 https://bugs.webkit.org/show_bug.cgi?id=67171 7530 7531 Reviewed by Simon Fraser. 7532 7533 Removed runLoopObserver for requestAnimationFrame. It's now 7534 done by a Timer in ScriptedAnimationController in WebCore. 7535 7536 * WebCoreSupport/WebChromeClient.h: 7537 * WebCoreSupport/WebChromeClient.mm: 7538 * WebView/WebView.mm: 7539 (-[WebView _close]): 7540 * WebView/WebViewData.h: 7541 * WebView/WebViewInternal.h: 7542 75432011-09-09 Fady Samuel <fsamuel@chromium.org> 7544 7545 Move pageScaleFactor code from Frame.{h|cpp} to Page.{h|cpp} 7546 https://bugs.webkit.org/show_bug.cgi?id=67250 7547 7548 Reviewed by Simon Fraser. 7549 7550 * WebView/WebView.mm: 7551 (-[WebView _scaleWebView:atOrigin:]): 7552 (-[WebView _viewScaleFactor]): 7553 75542011-09-09 Mark Hahnenberg <mhahnenberg@apple.com> 7555 7556 Unzip initialization lists and constructors in JSCell hierarchy (5/7) 7557 https://bugs.webkit.org/show_bug.cgi?id=67420 7558 7559 Reviewed by Geoffrey Garen. 7560 7561 Completed the fifth level of the refactoring to add finishCreation() 7562 methods to all classes within the JSCell hierarchy with non-trivial 7563 constructor bodies. 7564 7565 This primarily consists of pushing the calls to finishCreation() down 7566 into the constructors of the subclasses of the second level of the hierarchy 7567 as well as pulling the finishCreation() calls out into the class's corresponding 7568 create() method if it has one. Doing both simultaneously allows us to 7569 maintain the invariant that the finishCreation() method chain is called exactly 7570 once during the creation of an object, since calling it any other number of 7571 times (0, 2, or more) will cause an assertion failure. 7572 7573 * Plugins/Hosted/ProxyRuntimeObject.h: 7574 * Plugins/Hosted/ProxyRuntimeObject.mm: 7575 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject): 7576 (WebKit::ProxyRuntimeObject::finishCreation): 7577 75782011-09-08 Sam Weinig <sam@webkit.org> 7579 7580 Remove the Completion object from JSC, I have never liked it 7581 https://bugs.webkit.org/show_bug.cgi?id=67755 7582 7583 Reviewed by Gavin Barraclough. 7584 7585 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 7586 (WebKit::NetscapePluginInstanceProxy::evaluate): 7587 75882011-09-07 Sheriff Bot <webkit.review.bot@gmail.com> 7589 7590 Unreviewed, rolling out r94627 and r94632. 7591 http://trac.webkit.org/changeset/94627 7592 http://trac.webkit.org/changeset/94632 7593 https://bugs.webkit.org/show_bug.cgi?id=67698 7594 7595 It broke tests on GTK and Qt (Requested by Ossy on #webkit). 7596 7597 * Plugins/Hosted/ProxyRuntimeObject.h: 7598 * Plugins/Hosted/ProxyRuntimeObject.mm: 7599 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject): 7600 76012011-09-06 Mark Hahnenberg <mhahnenberg@apple.com> 7602 7603 Unzip initialization lists and constructors in JSCell hierarchy (5/7) 7604 https://bugs.webkit.org/show_bug.cgi?id=67420 7605 7606 Reviewed by Geoffrey Garen. 7607 7608 Completed the fifth level of the refactoring to add finishCreation() 7609 methods to all classes within the JSCell hierarchy with non-trivial 7610 constructor bodies. 7611 7612 This primarily consists of pushing the calls to finishCreation() down 7613 into the constructors of the subclasses of the second level of the hierarchy 7614 as well as pulling the finishCreation() calls out into the class's corresponding 7615 create() method if it has one. Doing both simultaneously allows us to 7616 maintain the invariant that the finishCreation() method chain is called exactly 7617 once during the creation of an object, since calling it any other number of 7618 times (0, 2, or more) will cause an assertion failure. 7619 7620 * Plugins/Hosted/ProxyRuntimeObject.h: 7621 * Plugins/Hosted/ProxyRuntimeObject.mm: 7622 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject): 7623 (WebKit::ProxyRuntimeObject::finishCreation): 7624 76252011-09-06 Ryosuke Niwa <rniwa@webkit.org> 7626 7627 Rename confirmCompositionWithoutDisturbingSelection to cancelComposition 7628 https://bugs.webkit.org/show_bug.cgi?id=67569 7629 7630 Reviewed by Antonio Gomes. 7631 7632 * WebView/WebHTMLView.mm: 7633 (-[WebHTMLView _updateSelectionForInputManager]): 7634 76352011-09-05 Oliver Hunt <oliver@apple.com> 7636 7637 An object's structure should reference the global object responsible for its creation 7638 https://bugs.webkit.org/show_bug.cgi?id=67624 7639 7640 Reviewed by Gavin Barraclough. 7641 7642 Update for new Structure::create() globalObject parameter. 7643 7644 * Plugins/Hosted/ProxyInstance.mm: 7645 (WebKit::ProxyRuntimeMethod::createStructure): 7646 * Plugins/Hosted/ProxyRuntimeObject.h: 7647 (WebKit::ProxyRuntimeObject::createStructure): 7648 76492011-09-01 Mark Rowe <mrowe@apple.com> 7650 7651 Fix the build by adding some more missing return types. 7652 7653 * WebView/WebDashboardRegion.h: 7654 * WebView/WebDashboardRegion.mm: 7655 (-[WebDashboardRegion initWithRect:clip:type:]): 7656 76572011-09-01 Tim Horton <timothy_horton@apple.com> 7658 7659 REGRESSION: Rendering artifacts on a rotated, pattern filled shape 7660 https://bugs.webkit.org/show_bug.cgi?id=53055 7661 <rdar://problem/8910917> 7662 7663 Reviewed by Simon Fraser. 7664 7665 Introduce wkCGPatternCreateWithImageAndTransform. 7666 7667 * WebCoreSupport/WebSystemInterface.mm: 7668 (InitWebCoreSystemInterface): 7669 76702011-08-31 Beth Dakin <bdakin@apple.com> 7671 7672 https://bugs.webkit.org/show_bug.cgi?id=67322 7673 Re-name overrideBackingScaleFactor 7674 7675 Reviewed by John Sullivan. 7676 7677 _setOverrideBackingScaleFactor is now _setCustomBackingScaleFactor 7678 * WebView/WebView.mm: 7679 (-[WebView _setCustomBackingScaleFactor:]): 7680 (-[WebView _deviceScaleFactor]): 7681 * WebView/WebViewData.h: 7682 * WebView/WebViewPrivate.h: 7683 76842011-08-30 Dan Bernstein <mitz@apple.com> 7685 7686 <rdar://problem/9281695> Add text search API for getting the DOM range of a text match 7687 https://bugs.webkit.org/show_bug.cgi?id=67230 7688 7689 Reviewed by Darin Adler. 7690 7691 * WebView/WebHTMLView.mm: 7692 * WebView/WebView.mm: 7693 (coreOptions): Moved this function from WebHTMLView.mm to here and made 7694 it accessible from both this file and WebHTMLView.mm. 7695 (-[WebView DOMRangeOfString:relativeTo:options:]): Added this new API. 7696 * WebView/WebViewInternal.h: 7697 * WebView/WebViewPrivate.h: 7698 76992011-08-30 Beth Dakin <bdakin@apple.com> 7700 7701 https://bugs.webkit.org/show_bug.cgi?id=67150 7702 Would like API to use a custom device scale factor for a particular WebView/WKView 7703 -and corresponding- 7704 <rdar://problem/10041016> 7705 7706 Reviewed by Darin Adler. 7707 7708 New API is _setOverrideBackingScaleFactor:(CGFloat) 7709 * WebView/WebView.mm: 7710 (-[WebView _setOverrideBackingScaleFactor:]): 7711 (-[WebView _deviceScaleFactor]): 7712 * WebView/WebViewData.h: 7713 * WebView/WebViewPrivate.h: 7714 77152011-08-30 Aaron Colwell <acolwell@chromium.org> 7716 7717 Add MediaSource API to HTMLMediaElement 7718 https://bugs.webkit.org/show_bug.cgi?id=64731 7719 7720 Reviewed by Eric Carlson. 7721 7722 * Configurations/FeatureDefines.xcconfig: 7723 77242011-08-29 Alexey Proskuryakov <ap@apple.com> 7725 7726 DumpRenderTree should begin each test with an empty cookie store 7727 https://bugs.webkit.org/show_bug.cgi?id=63545 7728 <rdar://problem/5666907> 7729 7730 Reviewed by Darin Adler. 7731 7732 * WebView/WebPreferences.mm: 7733 (+[WebPreferences initialize]): 7734 (+[WebPreferences _switchNetworkLoaderToNewTestingSession]): 7735 (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]): 7736 * WebView/WebPreferencesPrivate.h: 7737 Exposed an SPI to use a private default session. It's separate from private browsing, 7738 because some tests enable the latter, and we don't want to mix them up. 7739 Also exposed an SPI to set cookie accept policy regardless of what session we are currently 7740 using. 7741 7742 * WebView/WebView.mm: (-[WebView _cachedResponseForURL:]): Updated to use currentStorageSession() 7743 instead of privateBrowsingStorageSession(). 7744 77452011-08-30 Kaustubh Atrawalkar <kaustubh@motorola.com> 7746 7747 The unused ScrollView* argument can and should be removed from 7748 scrollRectIntoView. 7749 https://bugs.webkit.org/show_bug.cgi?id=67117 7750 7751 Reviewed by Darin Adler. 7752 7753 * WebCoreSupport/WebChromeClient.h: 7754 * WebCoreSupport/WebChromeClient.mm: 7755 (WebChromeClient::scrollRectIntoView): 7756 77572011-08-29 Sheriff Bot <webkit.review.bot@gmail.com> 7758 7759 Unreviewed, rolling out r93987, r93992, r93995, r93998, and 7760 r93999. 7761 http://trac.webkit.org/changeset/93987 7762 http://trac.webkit.org/changeset/93992 7763 http://trac.webkit.org/changeset/93995 7764 http://trac.webkit.org/changeset/93998 7765 http://trac.webkit.org/changeset/93999 7766 https://bugs.webkit.org/show_bug.cgi?id=67147 7767 7768 Many failing tests (Requested by ap on #webkit). 7769 7770 * WebView/WebPreferences.mm: 7771 (+[WebPreferences initialize]): 7772 * WebView/WebPreferencesPrivate.h: 7773 77742011-08-26 Alexey Proskuryakov <ap@apple.com> 7775 7776 DumpRenderTree should begin each test with an empty cookie store 7777 https://bugs.webkit.org/show_bug.cgi?id=63545 7778 <rdar://problem/5666907> 7779 7780 Reviewed by Darin Adler. 7781 7782 * WebView/WebPreferences.mm: 7783 (+[WebPreferences initialize]): 7784 (+[WebPreferences _usePrivateSessionForNetworkLoading]): 7785 * WebView/WebPreferencesPrivate.h: 7786 Exposed an SPI to use a private default session. It's separate from private browsing, 7787 because some tests enable the latter, and we don't want to mix them up. 7788 77892011-08-23 Chris Marrin <cmarrin@apple.com> 7790 7791 [mac] requestAnimationFrame support for mac port 7792 https://bugs.webkit.org/show_bug.cgi?id=59146 7793 7794 Reviewed by Simon Fraser. 7795 7796 Implement requestAnimationFrame for WebKit. Add a 7797 CFRunLoopObserver to WebView, which runs just before 7798 the syncCompositingState RLO and calls into the 7799 ScriptedAnimationController if scheduleAnimation() has 7800 been called. 7801 7802 * Configurations/FeatureDefines.xcconfig: 7803 * WebCoreSupport/WebChromeClient.h: 7804 * WebCoreSupport/WebChromeClient.mm: 7805 (WebChromeClient::scheduleAnimation): 7806 * WebView/WebView.mm: 7807 (-[WebView _close]): 7808 (-[WebView _unscheduleAnimation]): 7809 (-[WebView _scheduleCompositingLayerSync]): 7810 (requestAnimationFrameRunLoopObserverCallback): 7811 (-[WebView _scheduleAnimation]): 7812 * WebView/WebViewData.h: 7813 * WebView/WebViewInternal.h: 7814 78152011-08-24 Alexey Proskuryakov <ap@apple.com> 7816 7817 Plug-in tests are flaky on Mac 7818 https://bugs.webkit.org/show_bug.cgi?id=66822 7819 7820 Reviewed by Anders Carlsson. 7821 7822 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 7823 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): 7824 Protect objects that can be removed by a script. 7825 7826 * WebView/WebFrame.mm: 7827 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto. 7828 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Ditto. 7829 Also fixed some nonsense code. 7830 78312011-08-23 Mark Hahnenberg <mhahnenberg@apple.com> 7832 7833 Add checks to ensure allocation does not take place during initialization of GC-managed objects 7834 https://bugs.webkit.org/show_bug.cgi?id=65288 7835 7836 Reviewed by Darin Adler. 7837 7838 Adding the new validation functionality. In its current state, it will performs checks, 7839 but they don't fail unless you do allocation in the arguments to the parent constructor in the 7840 initialization list of a class. The allocateCell() method turns on the global flag disallowing any new 7841 allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still 7842 allowed in constructor bodies while other refactoring efforts continue. 7843 7844 * Plugins/Hosted/ProxyRuntimeObject.h: 7845 (WebKit::ProxyRuntimeObject::create): 7846 * Plugins/Hosted/ProxyRuntimeObject.mm: 7847 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject): 7848 78492011-08-18 Beth Dakin <bdakin@apple.com> 7850 7851 Reviewed by Sam Weinig. 7852 7853 https://bugs.webkit.org/show_bug.cgi?id=66495 7854 Lion-specific scroller SPIs can use forward declaration instead of 7855 WebKitSystemInterface 7856 7857 * WebCoreSupport/WebSystemInterface.mm: 7858 (InitWebCoreSystemInterface): 7859 78602011-08-18 Anders Carlsson <andersca@apple.com> 7861 7862 More C++0x libc++ build fixes 7863 https://bugs.webkit.org/show_bug.cgi?id=66476 7864 7865 Reviewed by Adam Roben. 7866 7867 * Plugins/Hosted/NetscapePluginHostProxy.mm: 7868 (WKPCSetException): 7869 Use a WTF String here instead of an STL string. 7870 7871 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 7872 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): 7873 std::make_pair now takes rvalue references, so get rid of the template arguments and let 7874 the compiler deduce them instead. 7875 78762011-08-18 Adam Roben <aroben@apple.com> 7877 7878 Update the device scale factor when the WebView's window changes 7879 7880 Fixes <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a 7881 WebView is moved between windows with different backing scale factors 7882 7883 Reviewed by Anders Carlsson. 7884 7885 * WebView/WebView.mm: 7886 (-[WebView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no 7887 window at all) might have a different backing scale factor than the previous one. 7888 (-[WebView _deviceScaleFactor]): Moved to the WebFileInternal category. 7889 78902011-08-17 Adam Roben <aroben@apple.com> 7891 7892 Make WebCore keep track of the current device scale factor 7893 7894 Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the 7895 device scale factor 7896 7897 Reviewed by Darin Adler. 7898 7899 * WebCoreSupport/WebChromeClient.h: 7900 * WebCoreSupport/WebChromeClient.mm: 7901 Moved code to calculate the device scale factor from here... 7902 7903 * WebView/WebView.mm: 7904 (-[WebView _deviceScaleFactor]): 7905 ...to here. 7906 7907 (-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor. 7908 79092011-08-17 Dan Bernstein <mitz@apple.com> 7910 7911 Removed some code that is not needed when building for Leopard or later. 7912 7913 Reviewed by Anders Carlsson. 7914 7915 * WebCoreSupport/WebContextMenuClient.mm: 7916 (fixMenusToSendToOldClients): Removed check for Tiger Mail. 7917 * WebCoreSupport/WebFrameLoaderClient.mm: 7918 (WebFrameLoaderClient::objectContentType): 7919 * WebView/WebView.mm: 7920 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 7921 (-[WebView _preferencesChanged:]): 7922 79232011-08-17 Dan Bernstein <mitz@apple.com> 7924 7925 Eliminate the WebCGFloat compatibility definition that was needed for Tiger. 7926 7927 Rubber-stamped by Anders Carlsson. 7928 7929 * WebView/WebHTMLViewPrivate.h: 7930 79312011-08-17 Dan Bernstein <mitz@apple.com> 7932 7933 Eliminate the WebNSInteger and WebNSUInteger compatibility definitions that were 7934 needed for Tiger. 7935 7936 Reviewed by Darin Adler. 7937 7938 * History/WebBackForwardList.h: 7939 * WebView/WebDocumentInternal.h: 7940 * WebView/WebHTMLRepresentation.h: 7941 * WebView/WebPreferences.h: 7942 * WebView/WebResourceLoadDelegate.h: 7943 * WebView/WebResourceLoadDelegatePrivate.h: 7944 * WebView/WebScriptDebugDelegate.h: 7945 * WebView/WebTextIterator.h: 7946 * WebView/WebUIDelegate.h: 7947 * WebView/WebView.h: 7948 * WebView/WebViewPrivate.h: 7949 79502011-08-15 Dmitry Titov <dimich@chromium.org> 7951 7952 FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters 7953 https://bugs.webkit.org/show_bug.cgi?id=66165 7954 7955 Reviewed by Darin Fisher. 7956 7957 * WebCoreSupport/WebFrameLoaderClient.h: 7958 * WebCoreSupport/WebFrameLoaderClient.mm: 7959 (WebFrameLoaderClient::transferLoadingResourceFromPage): 7960 79612011-08-15 Mark Hahnenberg <mhahnenberg@apple.com> 7962 7963 Refactor JS objects to allocate in static create methods rather than constructors 7964 https://bugs.webkit.org/show_bug.cgi?id=65347 7965 7966 Reviewed by Geoffrey Garen. 7967 7968 Removed all calls to deprecatedGetDOMObject from initialization lists as part of a 7969 larger refactoring to get rid of all allocation during initialization. 7970 7971 * Plugins/Hosted/ProxyInstance.mm: 7972 (WebKit::ProxyRuntimeMethod::create): 7973 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod): 7974 79752011-08-15 Adam Roben <aroben@apple.com> 7976 7977 Update pages' style and content scale when the window's backing scale factor changes 7978 7979 Unfortunately, I couldn't think of a way to test this in an automated fashion. 7980 7981 Fixes <http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device 7982 scale factor changes 7983 7984 Reviewed by Simon Fraser. 7985 7986 * WebView/WebView.mm: 7987 (-[WebView addWindowObserversForWindow:]): 7988 (-[WebView removeWindowObservers]): 7989 Listen for the notification that tells us the window's backing scale has changed. 7990 7991 (-[WebView _windowDidChangeResolution:]): Tell the page about the change to the device scale 7992 factor so that, e.g., scale-factor-dependent media queries will be reevaluated. 7993 79942011-08-10 Adam Roben <aroben@apple.com> 7995 7996 Clear up scale factor terminology 7997 7998 WebKit by and large deals with two scale factors: one intrinsic to the device on which the 7999 software is running, and one that is per-Page and can be controlled via API calls. This 8000 patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the 8001 code use those names. It should introduce no behavior changes. 8002 8003 Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the 8004 device scale factor 8005 8006 Reviewed by Simon Fraser. 8007 8008 * Misc/WebNSControlExtras.m: 8009 (-[NSControl sizeToFitAndAdjustWindowHeight]): Updated this function to use more modern 8010 AppKit scale factor terminology. (This is unrelated to the rest of the patch.) 8011 8012 * WebCoreSupport/WebChromeClient.h: 8013 * WebCoreSupport/WebChromeClient.mm: 8014 80152011-08-13 Dan Bernstein <mitz@apple.com> 8016 8017 Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else. 8018 8019 Reviewed by Joseph Pecoraro. 8020 8021 * WebView/WebPreferenceKeysPrivate.h: 8022 80232011-08-13 Sam Weinig <sam@webkit.org> 8024 8025 Remove unused variables from WebView/WebFullScreenController.h 8026 https://bugs.webkit.org/show_bug.cgi?id=66194 8027 8028 Reviewed by Dan Bernstein. 8029 8030 * WebView/WebFullScreenController.h: 8031 Remove a few variables which were not used. 8032 80332011-08-12 Dan Bernstein <mitz@apple.com> 8034 8035 Add an option to automatically show tooltips (with the full text) over truncated text 8036 https://bugs.webkit.org/show_bug.cgi?id=66178 8037 8038 Reviewed by Simon Fraser. 8039 8040 * WebView/WebPreferenceKeysPrivate.h: Defined a preference key. 8041 * WebView/WebPreferences.mm: 8042 (+[WebPreferences initialize]): Added a default value of NO for the 8043 ShowsToolTipOverTruncatedText preference. 8044 (-[WebPreferences showsToolTipOverTruncatedText]): Added this getter. 8045 (-[WebPreferences setShowsToolTipOverTruncatedText:]): Added this setter. 8046 * WebView/WebPreferencesPrivate.h: 8047 * WebView/WebView.mm: 8048 (-[WebView _preferencesChanged:]): Added call to Settings::setShowsToolTipOverTruncatedText(). 8049 80502011-08-12 Sam Weinig <sam@webkit.org> 8051 8052 Use __builtin_trap() for CRASH when building with clang 8053 https://bugs.webkit.org/show_bug.cgi?id=66152 8054 8055 Reviewed by Anders Carlsson. 8056 8057 * Plugins/WebBaseNetscapePluginView.mm: 8058 (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]): 8059 (-[WebBaseNetscapePluginView handleMouseMoved:]): 8060 (-[WebBaseNetscapePluginView handleMouseEntered:]): 8061 (-[WebBaseNetscapePluginView handleMouseExited:]): 8062 (-[WebBaseNetscapePluginView focusChanged]): 8063 (-[WebBaseNetscapePluginView windowFocusChanged:]): 8064 (-[WebBaseNetscapePluginView createPlugin]): 8065 (-[WebBaseNetscapePluginView loadStream]): 8066 (-[WebBaseNetscapePluginView shouldStop]): 8067 (-[WebBaseNetscapePluginView destroyPlugin]): 8068 (-[WebBaseNetscapePluginView updateAndSetWindow]): 8069 (-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]): 8070 (-[WebBaseNetscapePluginView pluginLayer]): 8071 (-[WebBaseNetscapePluginView getFormValue:]): 8072 Remove the ASSERT_NOT_REACHED from the base class methods. They were not 8073 adding much value and were getting in the way of making the static analyzer 8074 work. A better way to do this would be to use a formal protocol. 8075 80762011-08-12 Mark Rowe <mrowe@apple.com> 8077 8078 Be more forward-looking in the choice of compiler. 8079 8080 Rubber-stamped by Jon Honeycutt. 8081 8082 * Configurations/CompilerVersion.xcconfig: 8083 80842011-08-10 David Hyatt <hyatt@apple.com> 8085 8086 https://bugs.webkit.org/show_bug.cgi?id=66004 8087 8088 Removing the CSS Regions and Exclusions ifdefs. 8089 8090 Reviewed by Adam Roben. 8091 8092 * Configurations/FeatureDefines.xcconfig: 8093 80942011-08-09 Mark Hahnenberg <mhahnenberg@apple.com> 8095 8096 Add ParentClass typedef in all JSC classes 8097 https://bugs.webkit.org/show_bug.cgi?id=65731 8098 8099 Reviewed by Oliver Hunt. 8100 8101 Just added the Base typedefs in all the classes that are a subclass of JSCell 8102 to point at their parent classes. This is a change to support future changes to the way 8103 constructors and destructors are implemented in JS objects, among other things. 8104 8105 * Plugins/Hosted/ProxyInstance.mm: 8106 * Plugins/Hosted/ProxyRuntimeObject.h: 8107 81082011-08-08 Chris Marrin <cmarrin@apple.com> 8109 8110 Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState 8111 https://bugs.webkit.org/show_bug.cgi?id=65708 8112 8113 Supply initial display rects for the full-screen case 8114 8115 Reviewed by Simon Fraser. 8116 8117 * WebView/WebFullScreenController.mm: 8118 (-[WebFullScreenController enterFullscreen:]): 8119 (-[WebFullScreenController exitFullscreen]): 8120 81212011-08-06 Joseph Pecoraro <joepeck@webkit.org> 8122 8123 Potential Leaks - RetainPtr<> over retaining Create'd objects 8124 https://bugs.webkit.org/show_bug.cgi?id=65806 8125 8126 Reviewed by Darin Adler. 8127 8128 Fix a possible leak by adopting an allocation instead of retaining it. 8129 8130 * WebView/WebView.mm: 8131 (-[WebView previousValidKeyView]): 8132 81332011-08-05 Anders Carlsson <andersca@apple.com> 8134 8135 Remove PluginHalter 8136 https://bugs.webkit.org/show_bug.cgi?id=65729 8137 8138 Reviewed by Darin Adler. 8139 8140 Remove plug-in halter and associated classes. 8141 8142 * Plugins/WebBaseNetscapePluginView.h: 8143 * Plugins/WebBaseNetscapePluginView.mm: 8144 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): 8145 (-[WebBaseNetscapePluginView start]): 8146 (-[WebBaseNetscapePluginView stop]): 8147 * WebCoreSupport/WebPluginHalterClient.h: Removed. 8148 * WebCoreSupport/WebPluginHalterClient.mm: Removed. 8149 * WebView/WebPreferenceKeysPrivate.h: 8150 * WebView/WebPreferences.mm: 8151 (+[WebPreferences initialize]): 8152 * WebView/WebPreferencesPrivate.h: 8153 * WebView/WebView.mm: 8154 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 8155 (-[WebView _preferencesChanged:]): 8156 * WebView/WebViewPrivate.h: 8157 81582011-08-04 Mark Rowe <mrowe@apple.com> 8159 8160 Future-proof Xcode configuration settings. 8161 8162 * Configurations/Base.xcconfig: 8163 * Configurations/DebugRelease.xcconfig: 8164 * Configurations/Version.xcconfig: 8165 * Configurations/WebKit.xcconfig: 8166 81672011-08-03 Kent Tamura <tkent@chromium.org> 8168 8169 Fix incorrect checks for HTMLMediaElement 8170 https://bugs.webkit.org/show_bug.cgi?id=65590 8171 8172 Reviewed by Dimitri Glazkov. 8173 8174 <video> and <audio> can be an HTMLElement instance instead of 8175 HTMLMediaElement if MediaPlayer::isAvailable() returns false or 8176 the media feature is disabled at runtime. 8177 8178 * WebView/WebFullScreenController.mm: 8179 (-[WebFullScreenController _isAnyMoviePlaying]): 8180 81812011-08-03 Mark Rowe <mrowe@apple.com> 8182 8183 Bring some order to FeatureDefines.xcconfig to make it easier to follow. 8184 8185 Reviewed by Sam Weinig. 8186 8187 * Configurations/FeatureDefines.xcconfig: 8188 81892011-08-03 Mark Rowe <mrowe@apple.com> 8190 8191 Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings 8192 8193 Reviewed by Dave Kilzer. 8194 8195 * Configurations/FeatureDefines.xcconfig: 8196 81972011-08-03 Joseph Pecoraro <joepeck@webkit.org> 8198 8199 Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting 8200 https://bugs.webkit.org/show_bug.cgi?id=65582 8201 8202 Reviewed by Pavel Feldman. 8203 8204 * WebCoreSupport/WebInspectorClient.h: 8205 * WebCoreSupport/WebInspectorClient.mm: 8206 82072011-08-03 Pavel Feldman <pfeldman@google.com> 8208 8209 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area. 8210 https://bugs.webkit.org/show_bug.cgi?id=65510 8211 8212 Reviewed by Yury Semikhatsky. 8213 8214 * WebInspector/WebNodeHighlightView.mm: 8215 (-[WebNodeHighlightView drawRect:]): 8216 82172011-08-03 Pavel Feldman <pfeldman@chromium.org> 8218 8219 Web Inspector: remove Node parameter from the InspectorClient::highlight 8220 https://bugs.webkit.org/show_bug.cgi?id=65549 8221 8222 Reviewed by Yury Semikhatsky. 8223 8224 * WebCoreSupport/WebInspectorClient.h: 8225 * WebCoreSupport/WebInspectorClient.mm: 8226 (WebInspectorClient::highlight): 8227 * WebInspector/WebNodeHighlighter.h: 8228 * WebInspector/WebNodeHighlighter.mm: 8229 (-[WebNodeHighlighter highlight]): 8230 82312011-07-30 Patrick Gansterer <paroga@webkit.org> 8232 8233 Remove inclusion of MainThread.h from Threading.h 8234 https://bugs.webkit.org/show_bug.cgi?id=65081 8235 8236 Reviewed by Darin Adler. 8237 8238 Add missing include statements for MainThread. 8239 8240 * Carbon/CarbonWindowAdapter.mm: 8241 * History/WebBackForwardList.mm: 8242 * History/WebHistoryItem.mm: 8243 * Misc/WebElementDictionary.mm: 8244 * Misc/WebIconDatabase.mm: 8245 * Misc/WebLocalizableStrings.mm: 8246 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 8247 * Plugins/WebBaseNetscapePluginView.mm: 8248 * Plugins/WebBasePluginPackage.mm: 8249 * Plugins/WebNetscapePluginView.mm: 8250 * WebCoreSupport/WebEditorClient.mm: 8251 * WebCoreSupport/WebFrameLoaderClient.mm: 8252 * WebView/WebArchive.mm: 8253 * WebView/WebDataSource.mm: 8254 * WebView/WebHTMLView.mm: 8255 * WebView/WebResource.mm: 8256 * WebView/WebTextIterator.mm: 8257 * WebView/WebView.mm: 8258 * WebView/WebViewData.mm: 8259 82602011-07-28 Dan Bernstein <mitz@apple.com> 8261 8262 <rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds 8263 8264 Reviewed by Darin Adler. 8265 8266 * WebCoreSupport/WebSystemInterface.mm: 8267 (InitWebCoreSystemInterface): Initialize wkGetVerticalGlyphsForCharacters. 8268 82692011-07-28 Brady Eidson <beidson@apple.com> 8270 8271 <rdar://problem/9714337> and https://bugs.webkit.org/show_bug.cgi?id=65306 8272 WebKitInitializeStorageIfNecessary() can take awhile performing i/o, isn't necessary for every WebView 8273 8274 Reviewed by Maciej Stachowiak. 8275 8276 * Storage/WebStorageManager.mm: 8277 (WebKitInitializeStorageIfNecessary): Pass the client along in initializeTracker(). 8278 82792011-07-27 Mark Hahnenberg <mhahnenberg@apple.com> 8280 8281 Remove operator new from JSCell 8282 https://bugs.webkit.org/show_bug.cgi?id=64999 8283 8284 Reviewed by Oliver Hunt. 8285 8286 Removed the implementation of operator new in JSCell, so any further uses 8287 will not successfully link. Also removed any remaining uses of operator new. 8288 8289 * Plugins/Hosted/ProxyInstance.mm: 8290 (WebKit::ProxyInstance::newRuntimeObject): 8291 (WebKit::ProxyRuntimeMethod::create): 8292 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod): 8293 (WebKit::ProxyInstance::getMethod): 8294 * Plugins/Hosted/ProxyRuntimeObject.h: 8295 (WebKit::ProxyRuntimeObject::create): 8296 * WebView/WebScriptDebugDelegate.mm: 8297 (-[WebScriptCallFrame scopeChain]): 8298 82992011-07-26 Dan Bernstein <mitz@apple.com> 8300 8301 <rdar://problem/9842889> Add a generic pictograph font family 8302 https://bugs.webkit.org/show_bug.cgi?id=65197 8303 8304 Reviewed by Anders Carlsson. 8305 8306 * WebView/WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey. 8307 * WebView/WebPreferences.mm: 8308 (+[WebPreferences initialize]): Set the default pictograph font family to 8309 "Apple Color Emoji". 8310 (-[WebPreferences pictographFontFamily]): Added this getter. 8311 (-[WebPreferences setPictographFontFamily:]): Added this setter. 8312 * WebView/WebPreferencesPrivate.h: 8313 * WebView/WebView.mm: 8314 (-[WebView _preferencesChanged:]): Pass the preference through to WebCore. 8315 83162011-07-25 Ian Henderson <ianh@apple.com> 8317 8318 WebFrame should have a method to determine its visual emptiness 8319 https://bugs.webkit.org/show_bug.cgi?id=64223 8320 8321 Reviewed by Dan Bernstein. 8322 8323 * WebView/WebFrame.mm: 8324 (-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method 8325 through WebKit. 8326 * WebView/WebFramePrivate.h: 8327 83282011-07-19 Leo Yang <leoyang.webkit@gmail.com> 8329 8330 SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and <glyphRef> 8331 https://bugs.webkit.org/show_bug.cgi?id=60850 8332 8333 Reviewed by Nikolas Zimmermann. 8334 8335 SVG spec: http://www.w3.org/TR/SVG/text.html#AlternateGlyphDefinitions. 8336 This patch is to implement SVG <altGlyphDef>, <altGlyphItem> and <glyphRef> 8337 elements for alternative glyph features. 8338 8339 * MigrateHeaders.make: 8340 83412011-07-18 Andy Estes <aestes@apple.com> 8342 8343 Solar Walk app-specific hack accidentally strips stylesheets from the document. 8344 https://bugs.webkit.org/show_bug.cgi?id=64777 8345 8346 Reviewed by Adam Barth. 8347 8348 Solar Walk uses a self-closed title tag in its documents ("<title />"). 8349 The HTML5 parser does not recognize this as a valid self-closing tag, 8350 so it treats the remainder of the document as title text. 8351 8352 We work around this in WebKit by injecting a script that calls 8353 document.write() on the contents of document.title, thereby restoring 8354 the contents of the document. Unfortunately this overwrote several 8355 <style> tags that existed before the <title>, thereby causing the 8356 document to not have the intended styling. 8357 8358 Fix this by having the injected script concatenate document.title to 8359 the document instead of overwriting it during document.write(). We can 8360 also take the opportunity to remove document.title since it does not 8361 contain useful information. 8362 8363 * Misc/SolarWalkQuirksUserScript.js: 8364 83652011-07-18 Dean Jackson <dino@apple.com> 8366 8367 https://bugs.webkit.org/show_bug.cgi?id=64742 8368 Expose WebPreferences for media playback requiring user gestures and inline playback 8369 8370 Reviewed by Simon Fraser. 8371 8372 Two new WebPreferences: MediaPlaybackRequiresUserGesture and 8373 MediaPlaybackAllowsInline. 8374 8375 * WebView/WebPreferenceKeysPrivate.h: 8376 * WebView/WebPreferences.mm: 8377 (+[WebPreferences initialize]): 8378 (-[WebPreferences mediaPlaybackRequiresUserGesture]): 8379 (-[WebPreferences setMediaPlaybackRequiresUserGesture:]): 8380 (-[WebPreferences mediaPlaybackAllowsInline]): 8381 (-[WebPreferences setMediaPlaybackAllowsInline:]): 8382 * WebView/WebPreferencesPrivate.h: 8383 * WebView/WebView.mm: 8384 (-[WebView _preferencesChanged:]): 8385 83862011-07-18 Pratik Solanki <psolanki@apple.com> 8387 8388 Part of https://bugs.webkit.org/show_bug.cgi?id=63674 8389 Get webkit to compile with USE(CFNETWORK) enabled on Mac 8390 8391 Reviewed by David Kilzer. 8392 8393 Create an NSURLDownload from the CF objects that we have. 8394 8395 * Misc/WebDownload.mm: 8396 (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): 8397 * Misc/WebDownloadInternal.h: 8398 * WebCoreSupport/WebFrameLoaderClient.mm: 8399 (WebFrameLoaderClient::download): 8400 84012011-07-15 Pratik Solanki <psolanki@apple.com> 8402 8403 Part of https://bugs.webkit.org/show_bug.cgi?id=63674 8404 Get webkit to compile with USE(CFNETWORK) enabled on Mac 8405 8406 Reviewed by David Kilzer. 8407 8408 New WebKitSystemInterface functions for CFNetwork-based loader. 8409 8410 * WebCoreSupport/WebSystemInterface.mm: 8411 (InitWebCoreSystemInterface): 8412 84132011-07-15 Tim Horton <timothy_horton@apple.com> 8414 8415 Overlay scrollbars in overflow areas no longer pulse when revealed 8416 https://bugs.webkit.org/show_bug.cgi?id=64606 8417 <rdar://problem/9390674> 8418 8419 Reviewed by Simon Fraser. 8420 8421 Ensure that the state of the scrollbar implementation is kept in sync 8422 with WebCore's internal representation. Previously, we synchronized them 8423 at paint time, causing pulsing to be skipped due to the scrollbars being 8424 disabled. 8425 8426 * WebCoreSupport/WebSystemInterface.mm: 8427 (InitWebCoreSystemInterface): 8428 84292011-07-15 Andy Estes <aestes@apple.com> 8430 8431 Rename applicationIsSolarWalk() to applicationIsSolarWalkMac(). 8432 https://bugs.webkit.org/show_bug.cgi?id=64641 8433 8434 Reviewed by Brian Weinstein. 8435 8436 * WebView/WebView.mm: 8437 (needsSolarWalkQuirksScript): Call applicationIsSolarWalkMac(). 8438 84392011-07-15 Dan Bernstein <mitz@apple.com> 8440 8441 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides 8442 https://bugs.webkit.org/show_bug.cgi?id=64615 8443 8444 Reviewed by Anders Carlsson. 8445 8446 * WebCoreSupport/WebChromeClient.h: 8447 * WebCoreSupport/WebChromeClient.mm: 8448 (WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls 8449 +[NSCursor setHiddenUntilMouseMoves:]. 8450 84512011-07-14 Gavin Barraclough <barraclough@apple.com> 8452 8453 https://bugs.webkit.org/show_bug.cgi?id=64250 8454 Global strict mode function leaking global object as "this". 8455 8456 Reviewed by Oliver Hunt. 8457 8458 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 8459 (WebKit::NetscapePluginInstanceProxy::invoke): 8460 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 8461 - Change call to pass DOM Window shell, instead of the global varaible object. 8462 84632011-07-13 Joseph Pecoraro <joepeck@webkit.org> 8464 8465 Improve names of some ApplicationCacheStorage accessor methods 8466 https://bugs.webkit.org/show_bug.cgi?id=64433 8467 8468 Reviewed by Alexey Proskuryakov. 8469 8470 * WebCoreSupport/WebApplicationCacheQuotaManager.mm: 8471 (-[WebApplicationCacheQuotaManager usage]): 8472 (-[WebApplicationCacheQuotaManager quota]): 8473 Renamed methods. 8474 84752011-07-12 Joseph Pecoraro <joepeck@webkit.org> 8476 8477 ApplicationCache update should not immediately fail when reaching per-origin quota 8478 https://bugs.webkit.org/show_bug.cgi?id=64177 8479 8480 Reviewed by Alexey Proskuryakov. 8481 8482 * WebView/WebUIDelegatePrivate.h: 8483 * DefaultDelegates/WebDefaultUIDelegate.m: 8484 (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]): 8485 Update the delegate to include a space needed parameter. 8486 8487 * WebCoreSupport/WebChromeClient.h: 8488 * WebCoreSupport/WebChromeClient.mm: 8489 (WebChromeClient::reachedApplicationCacheOriginQuota): 8490 Call the delegate with the new space needed information. 8491 84922011-07-12 Adam Roben <aroben@apple.com> 8493 8494 Delete some redundant code in WebHTMLView 8495 8496 This code had no user-visible effect, as we were just duplicating work that AppKit would do 8497 for us at a slightly different time. 8498 8499 Fixes <http://webkit.org/b/64390> WebHTMLView sets its root layer's transform unnecessarily 8500 8501 Reviewed by Simon Fraser. 8502 8503 * WebView/WebHTMLView.mm: 8504 (-[WebHTMLView viewDidMoveToWindow]): 8505 (-[WebHTMLView attachRootLayer:]): 8506 Don't bother setting the root layer's transform to account for the scale factor. AppKit 8507 takes care of this for us nowadays. 8508 85092011-07-10 Kenichi Ishibashi <bashi@chromium.org> 8510 8511 Let plugins participate in form submission 8512 https://bugs.webkit.org/show_bug.cgi?id=13061 8513 8514 Adds methods to get form value from NPAPI plugins. 8515 8516 Reviewed by Anders Carlsson. 8517 8518 * Plugins/Hosted/WebHostedNetscapePluginView.h: 8519 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 8520 (-[WebHostedNetscapePluginView getFormValue:]): Added. 8521 * Plugins/WebBaseNetscapePluginView.h: 8522 * Plugins/WebBaseNetscapePluginView.mm: 8523 (-[WebBaseNetscapePluginView getFormValue:]): Added. 8524 * Plugins/WebNetscapePluginPackage.h: 8525 * Plugins/WebNetscapePluginPackage.mm: 8526 (-[WebNetscapePluginPackage browserFuncs]): Added. 8527 * Plugins/WebNetscapePluginView.h: 8528 * Plugins/WebNetscapePluginView.mm: 8529 (-[WebNetscapePluginView getFormValue:]): Added. 8530 * WebCoreSupport/WebFrameLoaderClient.mm: 8531 (NetscapePluginWidget::getFormValue): Added. 8532 85332011-07-04 Dan Bernstein <mitz@apple.com> 8534 8535 Moved handling of frame size changes into its own method. 8536 8537 Reviewed by Oliver Hunt. 8538 8539 * WebView/WebFrameView.mm: 8540 (-[WebFrameView _frameSizeChanged]): Added. Moved code here... 8541 (-[WebFrameView setFrameSize:]): ...from here. 8542 * WebView/WebFrameViewInternal.h: 8543 85442011-07-01 Adele Peterson <adele@apple.com> 8545 8546 Reviewed by Darin Adler. 8547 8548 WebKit part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851 8549 <rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body 8550 8551 * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): 8552 Only call applyEditingStyleToBodyElement for the main frame. There's no need to apply break-word, 8553 space, and after-white-space properties to subframes in the editable document. 8554 85552011-07-01 Andy Estes <aestes@apple.com> 8556 8557 Reviewed by Mark Rowe. 8558 8559 Simplify MailQuirksUserScript.js 8560 https://bugs.webkit.org/show_bug.cgi?id=63800 8561 8562 MailQuirksUserScript.js is injected into WebViews in Mail.app on 8563 Leopard to resolve an incompatibility between it and the HTML5 parser. 8564 It did so by taking all nodes in the document between <html> and <body> 8565 and moving them to be children of <body>. This maintains Mail.app's 8566 assumption that document.firstChild.firstChild == document.body. 8567 8568 While this script fixed a specific issue with the Signature panel in 8569 Mail.app, it caused regressions in other WebViews. Since the issue with 8570 the Signature panel is with the empty <head> node implicitly created by 8571 the parser, we can simplify this script by removing this implicit 8572 <head> in the case it has no attributes and no children. This fixes the 8573 Signature panel without affecting other WebViews that have non-trivial 8574 <head> nodes. 8575 8576 * Misc/MailQuirksUserScript.js: If <head> exists but has no attributes 8577 and no children, remove it. 8578 85792011-06-30 Dan Bernstein <mitz@apple.com> 8580 8581 Reviewed by Adele Peterson. 8582 8583 Add +[WebView _allowsRoundingHacks] 8584 https://bugs.webkit.org/show_bug.cgi?id=63734 8585 8586 * WebView/WebView.mm: 8587 (+[WebView _allowsRoundingHacks]): Added this accessor. 8588 * WebView/WebViewPrivate.h: 8589 85902011-06-29 Darin Adler <darin@apple.com> 8591 8592 Reviewed by Dan Bernstein. 8593 8594 [Mac] Use system cursors instead of custom bitmaps where possible 8595 https://bugs.webkit.org/show_bug.cgi?id=63679 8596 8597 * WebCoreSupport/WebSystemInterface.mm: 8598 (InitWebCoreSystemInterface): Added WKCursor. 8599 86002011-06-28 Ilya Sherman <isherman@chromium.org> 8601 8602 Reviewed by Adam Barth. 8603 8604 form.autocomplete="off" does not work 8605 https://bugs.webkit.org/show_bug.cgi?id=35823 8606 8607 * WebView/WebHTMLRepresentation.mm: 8608 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Update callsite. 8609 86102011-06-26 Mark Rowe <mrowe@apple.com> 8611 8612 Reviewed by Dan Bernstein. 8613 8614 Use a separate file name for Lion's WebKitSystemInterface. 8615 8616 * Configurations/DebugRelease.xcconfig: 8617 86182011-06-24 Dan Bernstein <mitz@apple.com> 8619 8620 Reviewed by Anders Carlsson. 8621 8622 Add an option to enable legacy rounding hacks 8623 https://bugs.webkit.org/show_bug.cgi?id=63363 8624 8625 * Misc/WebKitNSStringExtras.mm: 8626 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): 8627 Disabled rounding hacks. 8628 (-[NSString _web_widthWithFont:]): Ditto. 8629 * WebView/WebView.mm: 8630 (+[WebView _setAllowsRoundingHacks:]): Added this setter. 8631 * WebView/WebViewPrivate.h: 8632 86332011-06-24 Dominic Cooney <dominicc@chromium.org> 8634 8635 Reviewed by Dimitri Glazkov. 8636 8637 Convert shadow DOM-related tests to use window.internals 8638 https://bugs.webkit.org/show_bug.cgi?id=61671 8639 8640 Remove shadow DOM-related methods from Mac API. These are not 8641 required any more. 8642 8643 * DOM/WebDOMOperations.mm: 8644 * DOM/WebDOMOperationsPrivate.h: 8645 86462011-06-24 Yuta Kitamura <yutak@chromium.org> 8647 8648 Reviewed by Adam Barth. 8649 8650 WebSocket: Add run-time flag for new HyBi protocol 8651 https://bugs.webkit.org/show_bug.cgi?id=60348 8652 8653 Make a new flag (Setting::m_useHixie76WebSocketProtocol) 8654 switchable from WebView and WebPreferences. 8655 8656 * WebView/WebPreferenceKeysPrivate.h: 8657 * WebView/WebPreferences.mm: 8658 (+[WebPreferences initialize]): 8659 (-[WebPreferences setHixie76WebSocketProtocolEnabled:]): 8660 (-[WebPreferences isHixie76WebSocketProtocolEnabled]): 8661 * WebView/WebPreferencesPrivate.h: 8662 * WebView/WebView.mm: 8663 (-[WebView _preferencesChanged:]): 8664 86652011-06-22 Sam Weinig <sam@webkit.org> 8666 8667 Roll out r89469 (Add preference for setting the html parser depth limit) 8668 8669 The preference is not needed at this time, so there is no reason to expose it. 8670 8671 * WebView/WebPreferenceKeysPrivate.h: 8672 * WebView/WebPreferences.mm: 8673 (+[WebPreferences initialize]): 8674 * WebView/WebPreferencesPrivate.h: 8675 * WebView/WebView.mm: 8676 (-[WebView _preferencesChanged:]): 8677 86782011-06-22 Sam Weinig <sam@webkit.org> 8679 8680 Reviewed by Adam Barth. 8681 8682 Add preference for setting the html parser depth limit 8683 https://bugs.webkit.org/show_bug.cgi?id=63163 8684 8685 * WebView/WebPreferenceKeysPrivate.h: 8686 * WebView/WebPreferences.mm: 8687 (+[WebPreferences initialize]): 8688 (-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]): 8689 (-[WebPreferences maximumHTMLParserDOMTreeDepth]): 8690 * WebView/WebPreferencesPrivate.h: 8691 * WebView/WebView.mm: 8692 (-[WebView _preferencesChanged:]): 8693 Add private preference for setting the parser depth limit. 8694 86952011-06-22 Ryosuke Niwa <rniwa@webkit.org> 8696 8697 Reviewed by Darin Adler. 8698 8699 Make instantiation of legacy editing position more explicit 8700 https://bugs.webkit.org/show_bug.cgi?id=63037 8701 8702 Create new positions since we can't create a legacy editing position outside of WebCore anymore. 8703 8704 * WebView/WebFrame.mm: 8705 (-[WebFrame _smartDeleteRangeForProposedRange:]): Calls createLegacyEditingPosition. 8706 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto. 8707 87082011-06-20 Dimitri Glazkov <dglazkov@chromium.org> 8709 8710 Reviewed by Kent Tamura. 8711 8712 FileChooser should be only created when we need to choose files. 8713 https://bugs.webkit.org/show_bug.cgi?id=63039 8714 8715 * WebCoreSupport/WebChromeClient.mm: 8716 (WebChromeClient::runOpenPanel): Changed to use settings. 8717 87182011-06-21 MORITA Hajime <morrita@google.com> 8719 8720 Unreviewed, rolling out r89401 and r89403. 8721 http://trac.webkit.org/changeset/89401 8722 http://trac.webkit.org/changeset/89403 8723 https://bugs.webkit.org/show_bug.cgi?id=62970 8724 8725 Breaks mac build and mistakenly enables the spellcheck API 8726 8727 * Configurations/FeatureDefines.xcconfig: 8728 87292011-06-20 MORITA Hajime <morrita@google.com> 8730 8731 Reviewed by Kent Tamura. 8732 8733 Spellcheck API should be build-able. 8734 https://bugs.webkit.org/show_bug.cgi?id=62970 8735 8736 No new tests, changing only build related files 8737 8738 * Configurations/FeatureDefines.xcconfig: 8739 87402011-06-21 Sheriff Bot <webkit.review.bot@gmail.com> 8741 8742 Unreviewed, rolling out r89354. 8743 http://trac.webkit.org/changeset/89354 8744 https://bugs.webkit.org/show_bug.cgi?id=63099 8745 8746 Broke tests on Mac (Requested by rniwa on #webkit). 8747 8748 * WebCoreSupport/WebInspectorClient.mm: 8749 (-[WebInspectorWindowController destroyInspectorView:]): 8750 * WebInspector/WebInspector.mm: 8751 (-[WebInspector show:]): 8752 (-[WebInspector showConsole:]): 8753 (-[WebInspector isDebuggingJavaScript]): 8754 (-[WebInspector toggleDebuggingJavaScript:]): 8755 (-[WebInspector startDebuggingJavaScript:]): 8756 (-[WebInspector stopDebuggingJavaScript:]): 8757 (-[WebInspector isProfilingJavaScript]): 8758 (-[WebInspector toggleProfilingJavaScript:]): 8759 (-[WebInspector startProfilingJavaScript:]): 8760 (-[WebInspector stopProfilingJavaScript:]): 8761 (-[WebInspector isJavaScriptProfilingEnabled]): 8762 (-[WebInspector setJavaScriptProfilingEnabled:]): 8763 (-[WebInspector isTimelineProfilingEnabled]): 8764 (-[WebInspector setTimelineProfilingEnabled:]): 8765 (-[WebInspector setFrontend:]): 8766 (-[WebInspector showWindow:]): 8767 * WebInspector/WebInspectorFrontend.h: 8768 * WebInspector/WebInspectorFrontend.mm: 8769 * WebInspector/WebInspectorPrivate.h: 8770 87712011-06-20 Pavel Feldman <pfeldman@chromium.org> 8772 8773 Reviewed by Yury Semikhatsky. 8774 8775 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu. 8776 https://bugs.webkit.org/show_bug.cgi?id=62985 8777 8778 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary 8779 methods for plumbing the menu action handlers through the WebKit and WebCore. 8780 I intend to remove this menu support from the protocol and WebCore/InspectorController API. 8781 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port. 8782 WebKit/win and WebKit2 to follow. 8783 8784 * WebCoreSupport/WebInspectorClient.mm: 8785 (-[WebInspectorWindowController destroyInspectorView:]): 8786 * WebInspector/WebInspector.mm: 8787 (-[WebInspector showWindow]): 8788 (-[WebInspector show:]): 8789 (-[WebInspector showConsole:]): 8790 (-[WebInspector isDebuggingJavaScript]): 8791 (-[WebInspector toggleDebuggingJavaScript:]): 8792 (-[WebInspector startDebuggingJavaScript:]): 8793 (-[WebInspector stopDebuggingJavaScript:]): 8794 (-[WebInspector isProfilingJavaScript]): 8795 (-[WebInspector toggleProfilingJavaScript:]): 8796 (-[WebInspector startProfilingJavaScript:]): 8797 (-[WebInspector stopProfilingJavaScript:]): 8798 (-[WebInspector isJavaScriptProfilingEnabled]): 8799 (-[WebInspector setJavaScriptProfilingEnabled:]): 8800 (-[WebInspector isTimelineProfilingEnabled]): 8801 (-[WebInspector setTimelineProfilingEnabled:]): 8802 (-[WebInspector setFrontend:]): 8803 (-[WebInspector releaseFrontend]): 8804 (-[WebInspector showWindow:]): 8805 * WebInspector/WebInspectorFrontend.h: 8806 * WebInspector/WebInspectorFrontend.mm: 8807 (-[WebInspectorFrontend isDebuggingEnabled]): 8808 (-[WebInspectorFrontend setDebuggingEnabled:]): 8809 (-[WebInspectorFrontend isProfilingJavaScript]): 8810 (-[WebInspectorFrontend startProfilingJavaScript]): 8811 (-[WebInspectorFrontend stopProfilingJavaScript]): 8812 (-[WebInspectorFrontend isJavaScriptProfilingEnabled]): 8813 (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]): 8814 (-[WebInspectorFrontend isTimelineProfilingEnabled]): 8815 (-[WebInspectorFrontend setTimelineProfilingEnabled:]): 8816 * WebInspector/WebInspectorPrivate.h: 8817 88182011-06-01 Jer Noble <jer.noble@apple.com> 8819 8820 Reviewed by Eric Carlson. 8821 8822 Move Full Screen Controllers into WebCore. 8823 8824 Remove dependency on QTKit from wekitExitFullscreen() 8825 https://bugs.webkit.org/show_bug.cgi?id=61843 8826 8827 WebVideoFullscreenController, WebVideoFullscreenHUDController, and WebWindowAnimation 8828 have been moved into WebCore. 8829 8830 * WebCoreSupport/WebSystemInterface.mm: 8831 (InitWebCoreSystemInterface): Add support for four WKSI functions in WCSI. 8832 * WebView/WebFullScreenController.mm: Remove unused #include. 8833 * WebView/WebView.mm: Change the include location of 8834 WebVideoFullscreenController.h 8835 88362011-06-18 Dimitri Glazkov <dglazkov@chromium.org> 8837 8838 Reviewed by Darin Adler. 8839 8840 Separate concerns of loading file icons and choosing files. 8841 https://bugs.webkit.org/show_bug.cgi?id=62931 8842 8843 * WebCoreSupport/WebChromeClient.h: 8844 * WebCoreSupport/WebChromeClient.mm: 8845 (WebChromeClient::loadIconForFiles): Renamed. 8846 88472011-06-18 Andrew Wellington <andrew@webkit.org> 8848 8849 Reviewed by Alexey Proskuryakov. 8850 8851 https://bugs.webkit.org/show_bug.cgi?id=62843 8852 WebKit Mac API calls didReceiveAuthenticationChallenge instead of 8853 didCancelAuthenticationChallenge 8854 8855 * WebView/WebView.mm: 8856 (-[WebView _cacheResourceLoadDelegateImplementations]): 8857 88582011-06-16 Sheriff Bot <webkit.review.bot@gmail.com> 8859 8860 Unreviewed, rolling out r89026. 8861 http://trac.webkit.org/changeset/89026 8862 https://bugs.webkit.org/show_bug.cgi?id=62804 8863 8864 These patches were likely correct. I'll investigate the 8865 browser_test failures. (Requested by abarth on #webkit). 8866 8867 * WebView/WebVideoFullscreenHUDWindowController.mm: 8868 (-[WebVideoFullscreenHUDWindowController setPlaying:]): 8869 88702011-06-16 Vitaly Repeshko <vitalyr@chromium.org> 8871 8872 Unreviewed. 8873 8874 Revert Adam's user gesture patch series r89002, r89005, r89007, r89018 8875 https://bugs.webkit.org/show_bug.cgi?id=62796 8876 8877 The patches broke chromium browser tests. 8878 8879 * WebView/WebVideoFullscreenHUDWindowController.mm: 8880 (-[WebVideoFullscreenHUDWindowController setPlaying:]): 8881 88822011-06-16 Adam Barth <abarth@webkit.org> 8883 8884 Reviewed by Eric Seidel. 8885 8886 Remove HTMLVideoElement::processingUserGesture 8887 https://bugs.webkit.org/show_bug.cgi?id=62784 8888 8889 * WebView/WebVideoFullscreenHUDWindowController.mm: 8890 (-[WebVideoFullscreenHUDWindowController setPlaying:]): 8891 88922011-06-15 Adam Barth <abarth@webkit.org> 8893 8894 Reviewed by Eric Seidel. 8895 8896 Remove ScriptController::setAllowPopupsFromPlugin 8897 https://bugs.webkit.org/show_bug.cgi?id=62706 8898 8899 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 8900 (WebKit::NetscapePluginInstanceProxy::evaluate): 8901 * Plugins/WebNetscapePluginView.mm: 8902 (-[WebNetscapePluginView sendEvent:isDrawRect:]): 8903 89042011-06-15 David Kilzer <ddkilzer@apple.com> 8905 8906 <http://webkit.org/b/62745> Convert WebNSFileManagerExtras.m to Objective-C++ 8907 8908 Reviewed by Joseph Pecoraro. 8909 8910 * Misc/WebNSFileManagerExtras.mm: Renamed from Source/WebKit/mac/Misc/WebNSFileManagerExtras.m. 8911 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): 8912 Added static_cast<MetaDataInfo *>. 8913 89142011-06-14 Stephanie Lewis <slewis@apple.com> 8915 8916 Rubber stamped by Oliver Hunt. 8917 8918 <rdar://problem/9511169> 8919 Update order files. 8920 8921 * WebKit.order: 8922 89232011-06-13 Kentaro Hara <haraken@google.com> 8924 8925 Reviewed by Alexey Proskuryakov. 8926 8927 Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page 8928 https://bugs.webkit.org/show_bug.cgi?id=61256 8929 8930 In order to prevent rounding error caused by expanding/shrinking a page 8931 using different calculation here and there, I added a common calculation 8932 method, resizePageRectsKeepingRatio(), which expands/shrinks a page, 8933 keeping the ratio of width and height of the original page. 8934 [WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:] 8935 and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:] 8936 use resizePageRectsKeepingRatio() to expand/shrink a page. 8937 8938 Test: printing/page-count-with-one-word.html 8939 8940 * WebView/WebHTMLView.mm: 8941 (-[WebHTMLView _web_setPrintingModeRecursive]): 8942 (-[WebHTMLView _web_clearPrintingModeRecursive]): 8943 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): 8944 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]): 8945 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): 8946 (-[WebHTMLView _endPrintMode]): 8947 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): 8948 (-[WebHTMLView _endScreenPaginationMode]): 8949 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]): 8950 (-[WebHTMLView layout]): 8951 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): 8952 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): 8953 (-[WebHTMLView setPageWidthForPrinting:]): 8954 89552011-06-13 Tony Chang <tony@chromium.org> 8956 8957 Reviewed by Dimitri Glazkov. 8958 8959 rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX 8960 https://bugs.webkit.org/show_bug.cgi?id=62578 8961 8962 * Configurations/FeatureDefines.xcconfig: 8963 89642011-06-13 Tony Chang <tony@chromium.org> 8965 8966 Reviewed by Adam Barth. 8967 8968 rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX 8969 https://bugs.webkit.org/show_bug.cgi?id=62545 8970 8971 * Configurations/FeatureDefines.xcconfig: 8972 89732011-06-12 Adam Barth <abarth@webkit.org> 8974 8975 Reviewed by Alexey Proskuryakov. 8976 8977 Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense 8978 https://bugs.webkit.org/show_bug.cgi?id=62516 8979 8980 * WebCoreSupport/WebFrameLoaderClient.h: 8981 * WebCoreSupport/WebFrameLoaderClient.mm: 8982 (WebFrameLoaderClient::interruptedForPolicyChangeError): 8983 89842011-06-12 Adam Barth <abarth@webkit.org> 8985 8986 Reviewed by Eric Seidel. 8987 8988 Remove FrameLoader::isProcessingUserGesture 8989 https://bugs.webkit.org/show_bug.cgi?id=62519 8990 8991 * WebView/WebView.mm: 8992 (-[WebView _isProcessingUserGesture]): 8993 89942011-06-12 Adam Barth <abarth@webkit.org> 8995 8996 Reviewed by Alexey Proskuryakov. 8997 8998 Remove trival "forward-to-client" member functions from FrameLoader 8999 https://bugs.webkit.org/show_bug.cgi?id=62510 9000 9001 * WebCoreSupport/WebFrameNetworkingContext.mm: 9002 (WebFrameNetworkingContext::blockedError): 9003 90042011-06-10 Tony Chang <tony@chromium.org> 9005 9006 Reviewed by Ojan Vafai. 9007 9008 add a compile guard ENABLE(FLEXBOX) 9009 https://bugs.webkit.org/show_bug.cgi?id=62049 9010 9011 * Configurations/FeatureDefines.xcconfig: 9012 90132011-06-06 Michael Saboff <msaboff@apple.com> 9014 9015 Reviewed by Geoffrey Garen. 9016 9017 Fonts returned by FontCache::getFontDataForCharacters() are never released 9018 https://bugs.webkit.org/show_bug.cgi?id=61875 9019 9020 This change allows fonts allocated as system fallback fonts to be 9021 released. Previously, the reference counts for these fonts grew 9022 without bound. This is implemented as an auto release class that wraps 9023 accesses to the cache for system fallback fonts. All such accesses are 9024 via the method FontCache::getFontDataForCharacters. The new class is 9025 called FontCachePurgePreventer. When such an object exists, it protects 9026 these fonts from deletion. 9027 9028 See more comments for this defect in Source/WebCore/ChangeLog. 9029 9030 * Misc/WebKitNSStringExtras.mm: 9031 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): 9032 (-[NSString _web_widthWithFont:]): 9033 Wrapped code accessing fallback fonts with local 9034 FontCachePurgePreventer in these methods. 9035 9036 * Misc/WebStringTruncator.mm: 9037 (+[WebStringTruncator centerTruncateString:toWidth:]): 9038 (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): 9039 (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): 9040 (+[WebStringTruncator widthOfString:font:]): 9041 Wrapped code accessing fallback fonts with local 9042 FontCachePurgePreventer in these methods. 9043 90442011-06-06 Peter Kasting <pkasting@google.com> 9045 9046 Reviewed by Antonio Gomes. 9047 9048 Remove unnecessary args from scroll functions. 9049 https://bugs.webkit.org/show_bug.cgi?id=61648 9050 9051 * WebView/WebFrame.mm: 9052 (-[WebFrame _scrollDOMRangeToVisible:]): 9053 90542011-06-06 Alexandru Chiculita <achicu@adobe.com> 9055 9056 Reviewed by Kent Tamura. 9057 9058 Add ENABLE_CSS_EXCLUSIONS support for build-webkit script 9059 https://bugs.webkit.org/show_bug.cgi?id=61628 9060 9061 * Configurations/FeatureDefines.xcconfig: 9062 90632011-06-06 Mihnea Ovidenie <mihnea@adobe.com> 9064 9065 Reviewed by Kent Tamura. 9066 9067 Add ENABLE(CSS_REGIONS) guard for CSS Regions support 9068 https://bugs.webkit.org/show_bug.cgi?id=61631 9069 9070 * Configurations/FeatureDefines.xcconfig: 9071 90722011-06-02 Anders Carlsson <andersca@apple.com> 9073 9074 Reviewed by Sam Weinig. 9075 9076 Need a way to install the memory pressure handler without initializing WebKit1 9077 https://bugs.webkit.org/show_bug.cgi?id=61975 9078 9079 Add a WebInstallMemoryPressureHandler function which will install the memory pressure handler. 9080 -[WebView WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:] will do this, 9081 but we'd like to be able to install a memory pressure handler without creating a WebView or even 9082 calling any WebView method since that will call +[WebView initialize]. 9083 9084 * WebKit.exp: 9085 * WebView/WebView.mm: 9086 (WebInstallMemoryPressureHandler): 9087 * WebView/WebViewPrivate.h: 9088 90892011-05-27 Stephanie Lewis <slewis@apple.com> 9090 9091 Unreviewed. 9092 9093 Fix a typo in the order_file flag. 9094 9095 * Configurations/Base.xcconfig: 9096 90972011-05-27 Stephanie Lewis <slewis@apple.com> 9098 9099 Rubber Stamped by Adam Roben. 9100 9101 Update Order Files. Use -order_file flag since it can order more of the binary. 9102 9103 * Configurations/Base.xcconfig: 9104 * WebKit.order: 9105 91062011-05-25 Stephanie Lewis <slewis@apple.com> 9107 9108 Reviewed by Brady Eidson. 9109 9110 https://bugs.webkit.org/show_bug.cgi?id=61407 9111 part of <rdar://problem/8675177> 9112 Remove Quicklook pref. Moving it enirely down into WebCore so it can 9113 be calculated only on reloads. 9114 9115 * WebView/WebPreferenceKeysPrivate.h: 9116 * WebView/WebPreferences.mm: 9117 (+[WebPreferences initialize]): 9118 * WebView/WebPreferencesPrivate.h: 9119 * WebView/WebView.mm: 9120 (-[WebView _preferencesChanged:]): 9121 91222011-05-24 Jer Noble <jer.noble@apple.com> 9123 9124 Reviewed by Darin Adler. 9125 9126 Video fails to play on Vimeo 9127 https://bugs.webkit.org/show_bug.cgi?id=61403 9128 9129 * WebCoreSupport/WebSystemInterface.mm: 9130 (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and 9131 wkQTMovieResolvedURL. 9132 91332011-05-24 Keishi Hattori <keishi@webkit.org> 9134 9135 Reviewed by Kent Tamura. 9136 9137 Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer. 9138 https://bugs.webkit.org/show_bug.cgi?id=61273 9139 9140 * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag. 9141 91422011-05-24 Adam Barth <abarth@webkit.org> 9143 9144 Reviewed by Eric Seidel. 9145 9146 Add FIXME comments about removing FrameLoader::isProcessingUserGesture 9147 https://bugs.webkit.org/show_bug.cgi?id=61395 9148 9149 * WebView/WebView.mm: 9150 (-[WebView _isProcessingUserGesture]): 9151 91522011-05-24 Michael Saboff <msaboff@apple.com> 9153 9154 Reviewed by Geoffrey Garen. 9155 9156 Improve handling in WebCore of low memory situations 9157 https://bugs.webkit.org/show_bug.cgi?id=61222 9158 9159 Added call to enable memory pressure handling. 9160 9161 * WebView/WebView.mm: 9162 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 9163 * WebView/WebViewInternal.h: 9164 91652011-05-24 Jay Civelli <jcivelli@chromium.org> 9166 9167 Rubberstamped by David Kilzer. 9168 9169 Updated some files that I forgot in my previous MHTML CL. 9170 9171 * Configurations/FeatureDefines.xcconfig: 9172 91732011-05-20 Jeremy Noble <jer.noble@apple.com> 9174 9175 Reviewed by Simon Fraser. 9176 9177 Stack overflow in WebFullScreenController when built on Leopard and run on SnowLeopard. 9178 https://bugs.webkit.org/show_bug.cgi?id=61224 9179 9180 Remove the CATransaction(SnowLeopardConvenience) functions, and replace them with the Leopard 9181 versions of same. 9182 9183 * WebView/WebFullScreenController.mm: 9184 (-[WebFullScreenController windowDidEnterFullscreen:]): 9185 (-[WebFullScreenController enterFullscreen:]): 9186 (-[WebFullScreenController exitFullscreen]): 9187 (-[WebFullscreenWindow setRendererLayer:]): 9188 91892011-05-20 Andy Estes <aestes@apple.com> 9190 9191 Reviewed by Darin Adler. 9192 9193 WebView loses firstResponder status when entering full-screen mode. 9194 https://bugs.webkit.org/show_bug.cgi?id=61153 9195 9196 * Misc/WebNSWindowExtras.h: 9197 * Misc/WebNSWindowExtras.m: 9198 (-[NSWindow makeResponder:firstResponderIfDescendantOfView:]): Add a 9199 convenience method to NSWindow that makes the given NSResponder first 9200 responder only if it is a descendant of the given view. 9201 * WebView/WebFullScreenController.mm: 9202 (-[WebFullScreenController windowDidEnterFullscreen:]): If the WebView 9203 was a descendant of the browser window's first responder when entering 9204 full-screen mode, set the full-screen window's first responder to that 9205 same NSResponder. 9206 (-[WebFullScreenController exitFullscreen]): Do the reverse of what is 9207 done in windowDidEnterFullscreen:. 9208 92092011-05-20 Enrica Casucci <enrica@apple.com> 9210 9211 Reviewed by David Kilzer. 9212 9213 Add delegate methods about focus and blur to all elements. 9214 https://bugs.webkit.org/show_bug.cgi?id=61218 9215 9216 We want to have delegates for these events for all the elements, not only the form elements. 9217 The patch changes the name of the methods in a way that is not form element specific. 9218 9219 * WebCoreSupport/WebChromeClient.h: 9220 * WebCoreSupport/WebChromeClient.mm: 9221 (WebChromeClient::elementDidFocus): 9222 (WebChromeClient::elementDidBlur): 9223 * WebView/WebUIDelegatePrivate.h: 9224 92252011-05-20 Simon Fraser <simon.fraser@apple.com> 9226 9227 Reviewed by Sam Weinig. 9228 9229 numberOfActiveAnimations() can include animations from documents in the page cache 9230 https://bugs.webkit.org/show_bug.cgi?id=53641 9231 9232 Pass the Frame's document as the one to count animations on. 9233 9234 * WebView/WebFrame.mm: 9235 (-[WebFrame _numberOfActiveAnimations]): 9236 92372011-05-17 Timothy Hatcher <timothy@apple.com> 9238 9239 Update the the context menu to reflect the system search provider on Mac. 9240 9241 <rdar://problem/9198419> 9242 9243 Reviewed by Sam Weinig. 9244 9245 * DefaultDelegates/WebDefaultContextMenuDelegate.mm: 9246 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to 9247 create the web search context menu title. 9248 * WebCoreSupport/WebSystemInterface.mm: 9249 (InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName. 9250 92512011-05-16 Emil A Eklund <eae@chromium.org> 9252 9253 Reviewed by Eric Seidel. 9254 9255 Replace docTop/Right/Bottom/Left/Width/Height with documentRect 9256 https://bugs.webkit.org/show_bug.cgi?id=60743 9257 9258 Replace uses of docWidth/Height with documentRect. 9259 9260 * WebView/WebFrame.mm: 9261 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): 9262 92632011-05-16 Yuzo Fujishima <yuzo@google.com> 9264 9265 Reviewed by Antti Koivisto. 9266 9267 Fix for Bug 43704 - Web font is printed as blank if it is not cached 9268 https://bugs.webkit.org/show_bug.cgi?id=43704 9269 9270 * WebView/WebHTMLView.mm: 9271 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing. 9272 92732011-05-16 David Kilzer <ddkilzer@apple.com> 9274 9275 <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2 9276 <rdar://problem/9446430> 9277 9278 Reviewed by Mark Rowe. 9279 9280 * Configurations/Base.xcconfig: Fixed typo. 9281 92822011-05-13 Jon Lee <jonlee@apple.com> 9283 9284 Reviewed by Simon Fraser. 9285 9286 Can't horizontally scroll iframes and overflow because wheel events are always accepted 9287 https://bugs.webkit.org/show_bug.cgi?id=60779 9288 9289 * WebCoreSupport/WebChromeClient.h: 9290 (WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method 9291 (WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method 9292 92932011-05-13 Sam Weinig <sam@webkit.org> 9294 9295 Reviewed by Anders Carlsson. 9296 9297 Prune #includes from FrameView.h (Part 2) 9298 https://bugs.webkit.org/show_bug.cgi?id=60748 9299 9300 - Update files that were depending on FrameView.h #including Frame.h or 9301 Page.h. 9302 9303 * WebView/WebClipView.mm: 9304 * WebView/WebHTMLView.mm: 9305 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]): 9306 93072011-05-12 Pratik Solanki <psolanki@apple.com> 9308 9309 Reviewed by Antti Koivisto. 9310 9311 Part of WebCore should use CFNetwork-based loader on Mac 9312 https://bugs.webkit.org/show_bug.cgi?id=51836 9313 9314 Use CFRunLoop when using CFNetwork. 9315 9316 * WebView/WebView.mm: 9317 (-[WebView scheduleInRunLoop:forMode:]): 9318 (-[WebView unscheduleFromRunLoop:forMode:]): 9319 93202011-05-12 Pratik Solanki <psolanki@apple.com> 9321 9322 Reviewed by Antti Koivisto. 9323 9324 Part of WebCore should use CFNetwork-based loader on Mac 9325 https://bugs.webkit.org/show_bug.cgi?id=51836 9326 9327 Include AuthenticationCF.h header file. 9328 9329 * Misc/WebDownload.mm: 9330 * Plugins/WebBaseNetscapePluginView.mm: 9331 * WebCoreSupport/WebFrameLoaderClient.mm: 9332 93332011-05-12 Adele Peterson <adele@apple.com> 9334 9335 Reviewed by Darin Adler and Adam Barth. 9336 9337 Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser) 9338 https://bugs.webkit.org/show_bug.cgi?id=60685 9339 9340 Solar Walk uses a self closing title tag, so to match the behavior of the old parser, 9341 we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed. 9342 9343 * Misc/SolarWalkQuirksUserScript.js: Added. 9344 * WebView/WebView.mm: 9345 (needsSolarWalkQuirksScript): 9346 (leakSolarWalkQuirksUserScriptContents): 9347 (-[WebView _injectSolarWalkQuirksScript]): 9348 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 9349 93502011-05-12 Jia Pu <jpu@apple.com> 9351 9352 Reviewed by Darin Adler. 9353 9354 Regression caused by changeset 86281 9355 https://bugs.webkit.org/show_bug.cgi?id=60712 9356 <rdar://problem/9427970> 9357 9358 Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking. 9359 So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal() 9360 returns. So we don't need to use the condition to coordinate between these two function. In fact, 9361 all callbacks are delivered on main thread. We don't really need any locking here. 9362 9363 Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has 9364 been removed. 9365 9366 * WebCoreSupport/CorrectionPanel.h: 9367 * WebCoreSupport/CorrectionPanel.mm: 9368 (CorrectionPanel::CorrectionPanel): 9369 (CorrectionPanel::show): 9370 (CorrectionPanel::dismiss): 9371 (CorrectionPanel::dismissInternal): 9372 (CorrectionPanel::handleAcceptedReplacement): 9373 * WebCoreSupport/WebEditorClient.mm: 9374 (WebEditorClient::dismissCorrectionPanelSoon): 9375 93762011-05-12 Patrick Gansterer <paroga@webkit.org> 9377 9378 Reviewed by Adam Barth. 9379 9380 Enable OwnPtr strict mode in PluginHalter 9381 https://bugs.webkit.org/show_bug.cgi?id=60681 9382 9383 * WebView/WebView.mm: 9384 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 9385 93862011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> 9387 9388 Reviewed by Darin Adler. 9389 9390 String operator+ reallocates unnecessarily when concatting > 2 strings 9391 https://bugs.webkit.org/show_bug.cgi?id=58420 9392 9393 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details. 9394 9395 * WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked. 9396 (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): 9397 93982011-05-10 Tony Gentilcore <tonyg@chromium.org> 9399 9400 Reviewed by Darin Adler. 9401 9402 Perform some forward declarations suggested by include-what-you-use 9403 https://bugs.webkit.org/show_bug.cgi?id=60545 9404 9405 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 9406 * WebView/WebFrame.mm: 9407 94082011-05-11 Jia Pu <jpu@apple.com> 9409 9410 Reviewed by Darin Adler. 9411 9412 CorrectionPanel sometimes hangs in dismissSoon(). 9413 https://bugs.webkit.org/show_bug.cgi?id=60599 9414 <rdar://problem/9313628> 9415 9416 Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal 9417 to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal, 9418 for condition checking. 9419 9420 * WebCoreSupport/CorrectionPanel.h: 9421 * WebCoreSupport/CorrectionPanel.mm: 9422 (CorrectionPanel::CorrectionPanel): 9423 (CorrectionPanel::show): 9424 (CorrectionPanel::dismissSoon): 9425 (CorrectionPanel::dismissInternal): 9426 (CorrectionPanel::handleAcceptedReplacement): 9427 94282011-05-10 Anton D'Auria <adauria@apple.com> 9429 9430 Reviewed by David Levin. 9431 9432 Add ApplicationCache API to get disk usage per origin 9433 https://bugs.webkit.org/show_bug.cgi?id=57127 9434 9435 Added Mac port API. 9436 9437 * WebCoreSupport/WebApplicationCache.h: 9438 * WebCoreSupport/WebApplicationCache.mm: 9439 (+[WebApplicationCache diskUsageForOrigin:]): 9440 94412011-05-10 Anton D'Auria <adauria@apple.com> 9442 9443 Reviewed by Alexey Proskuryakov. 9444 9445 Add ApplicationCache API to get disk usage per origin 9446 https://bugs.webkit.org/show_bug.cgi?id=57127 9447 9448 Added Mac port API. 9449 9450 * WebCoreSupport/WebApplicationCache.h: 9451 * WebCoreSupport/WebApplicationCache.mm: 9452 (+[WebApplicationCache diskUsageForOrigin:]): 9453 94542011-05-10 Beth Dakin <bdakin@apple.com> 9455 9456 Reviewed by Darin Adler. 9457 9458 https://bugs.webkit.org/show_bug.cgi?id=60582 9459 Crash switching overlay/non-overlay scrollbar preference still possible 9460 -and corresponding- 9461 <rdar://problem/9323983> 9462 9463 * WebCoreSupport/WebSystemInterface.mm: 9464 (InitWebCoreSystemInterface): 9465 94662011-05-09 Jeremy Noble <jer.noble@apple.com> 9467 9468 Reviewed by Darin Adler. 9469 9470 Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash 9471 https://bugs.webkit.org/show_bug.cgi?id=60496 9472 9473 When animating into and out of full screen, order out and back in the original webView window, 9474 disabling animations when necessary. The exitFullscreen method was targeting the wrong window, 9475 as the webView is hosted in the full screen window when we ask for it's parent window. 9476 9477 * WebView/WebFullScreenController.mm: 9478 (-[WebFullScreenController windowDidEnterFullscreen:]): 9479 (-[WebFullScreenController exitFullscreen]): 9480 94812011-05-04 Philippe Normand <pnormand@igalia.com> 9482 9483 Reviewed by Dimitri Glazkov. 9484 9485 Implement LayoutTestController::pseudoShadowId() 9486 https://bugs.webkit.org/show_bug.cgi?id=60034 9487 9488 * DOM/WebDOMOperations.mm: 9489 (-[DOMElement _shadowPseudoId]): 9490 * DOM/WebDOMOperationsPrivate.h: 9491 94922011-05-05 Dan Bernstein <mitz@apple.com> 9493 9494 Reviewed by Simon Fraser. 9495 9496 WebKit part of <rdar://problem/9155590> Broken animation in iAd producer 9497 9498 * WebCoreSupport/WebSystemInterface.mm: 9499 (InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard. 9500 95012011-05-05 Ryosuke Niwa <rniwa@webkit.org> 9502 9503 Reviewed by Eric Seidel. 9504 9505 Rename SelectionController to FrameSelection 9506 https://bugs.webkit.org/show_bug.cgi?id=60234 9507 9508 * WebView/WebFrame.mm: 9509 (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]): 9510 * WebView/WebFrameInternal.h: 9511 * WebView/WebHTMLView.mm: 9512 * WebView/WebTextCompletionController.mm: 9513 (-[WebTextCompletionController doCompletion]): 9514 * WebView/WebView.mm: 9515 95162011-05-04 Cris Neckar <cdn@chromium.org> 9517 9518 Reviewed by Adam Barth. 9519 9520 Expose WebView directly through ChromeClient. 9521 https://bugs.webkit.org/show_bug.cgi?id=49902 9522 9523 * WebCoreSupport/WebChromeClient.h: 9524 (WebChromeClient::webView): 9525 * WebView/WebFrame.mm: 9526 (kit): 9527 95282011-05-04 Tao Bai <michaelbai@chromium.org> 9529 9530 Reviewed by David Kilzer. 9531 9532 Populate touch-icon url to FrameLoaderClient 9533 https://bugs.webkit.org/show_bug.cgi?id=59143 9534 9535 Respect the interface change in FrameLoaderClient. 9536 9537 * Configurations/FeatureDefines.xcconfig: 9538 * WebCoreSupport/WebFrameLoaderClient.h: 9539 * WebCoreSupport/WebFrameLoaderClient.mm: 9540 (WebFrameLoaderClient::dispatchDidChangeIcons): 9541 95422011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org> 9543 9544 Reviewed by Dimitri Glazkov. 9545 9546 Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot* 9547 https://bugs.webkit.org/show_bug.cgi?id=58703 9548 9549 * DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h. 9550 95512011-05-02 Adam Roben <aroben@apple.com> 9552 9553 Take advantage of implicit conversion from nullptr_t to PassOwnPtr 9554 9555 Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr 9556 doesn't work, but should 9557 9558 Reviewed by Adam Barth. 9559 9560 * History/WebHistory.mm: 9561 * Plugins/WebNetscapePluginEventHandler.mm: 9562 * WebView/WebView.mm: 9563 95642011-05-02 Brady Eidson <beidson@apple.com> 9565 9566 Reviewed by Anders Carlsson. 9567 9568 <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973 9569 In Aperture, a WebView might be dealloc'ed before it finishes loading. 9570 9571 * WebView/WebView.mm: 9572 (needsSelfRetainWhileLoadingQuirk): 9573 (-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self. 9574 (-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay. 9575 (-[WebView _didFailLoadWithError:forFrame:]): Ditto. 9576 (-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto. 9577 95782011-05-02 Adam Barth <abarth@webkit.org> 9579 9580 Reviewed by David Levin. 9581 9582 PLATFORM(MAC) should (almost!) build with strict PassOwnPtr 9583 https://bugs.webkit.org/show_bug.cgi?id=59924 9584 9585 * History/WebHistory.mm: 9586 (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]): 9587 * Plugins/WebBaseNetscapePluginView.mm: 9588 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): 9589 * WebCoreSupport/WebFrameLoaderClient.mm: 9590 (WebFrameLoaderClient::savePlatformDataToCachedFrame): 9591 * WebView/WebView.mm: 9592 (-[WebView _injectMailQuirksScript]): 9593 (-[WebView _injectOutlookQuirksScript]): 9594 (toStringVector): 9595 95962011-05-02 Sam Weinig <sam@webkit.org> 9597 9598 Reviewed by Adam Barth. 9599 9600 Prune some #includes from DOMWindow.h 9601 https://bugs.webkit.org/show_bug.cgi?id=59907 9602 9603 * Plugins/WebBaseNetscapePluginView.mm: 9604 * WebView/WebFrame.mm: 9605 Add now missing SecurityOrigin.h #includes. 9606 96072011-05-01 Ryosuke Niwa <rniwa@webkit.org> 9608 9609 Reviewed by Eric Seidel. 9610 9611 Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent 9612 https://bugs.webkit.org/show_bug.cgi?id=59837 9613 9614 Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent. 9615 9616 * WebView/WebHTMLView.mm: 9617 (-[WebHTMLView menuForEvent:]): 9618 (-[WebHTMLView acceptsFirstMouse:]): 9619 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): 9620 96212011-05-01 Ryosuke Niwa <rniwa@webkit.org> 9622 9623 Reviewed by Eric Seidel. 9624 9625 Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm 9626 https://bugs.webkit.org/show_bug.cgi?id=59835 9627 9628 Moved currentKeyboardEvent. 9629 9630 * WebView/WebHTMLView.mm: 9631 (currentKeyboardEvent): 9632 (-[WebHTMLView becomeFirstResponder]): 9633 96342011-04-29 Dean Jackson <dino@apple.com> 9635 9636 Reviewed by Simon Fraser. 9637 9638 Add ENABLE macro for WebKitAnimation 9639 https://bugs.webkit.org/show_bug.cgi?id=59729 9640 9641 Add new feature to toggle WebKit Animation API. 9642 9643 * Configurations/FeatureDefines.xcconfig: 9644 96452011-04-28 David Kilzer <ddkilzer@apple.com> 9646 9647 <http://webkit.org/b/59758> Fix static analyzer warnings for missing assignment to 'self' in -init methods 9648 9649 Reviewed by Anders Carlsson. 9650 9651 * History/WebHistory.mm: 9652 (-[WebHistoryPrivate init]): 9653 * Misc/WebElementDictionary.mm: 9654 (-[WebElementDictionary initWithHitTestResult:]): 9655 * Misc/WebIconDatabase.mm: 9656 (-[WebIconDatabase init]): 9657 * Plugins/WebPluginController.mm: 9658 (-[WebPluginController initWithDocumentView:]): 9659 * Plugins/WebPluginRequest.m: 9660 (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]): 9661 * WebCoreSupport/WebEditorClient.mm: 9662 (-[WebEditCommand initWithEditCommand:]): 9663 * WebCoreSupport/WebJavaScriptTextInputPanel.m: 9664 (-[WebJavaScriptTextInputPanel initWithPrompt:text:]): 9665 * WebView/WebNavigationData.mm: 9666 (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]): 9667 96682011-04-28 David Levin <levin@chromium.org> 9669 9670 Reviewed by Adam Barth. 9671 9672 Remove IMAGE_RESIZER related code. 9673 https://bugs.webkit.org/show_bug.cgi?id=59735 9674 9675 * Configurations/FeatureDefines.xcconfig: 9676 96772011-04-28 Adam Barth <abarth@webkit.org> 9678 9679 Reviewed by Eric Seidel. 9680 9681 Remove WML 9682 https://bugs.webkit.org/show_bug.cgi?id=59678 9683 9684 Remove WML-related configuration options and private APIs. 9685 9686 * Configurations/FeatureDefines.xcconfig: 9687 * WebCoreSupport/WebChromeClient.mm: 9688 (stringForMessageSource): 9689 * WebView/WebFramePrivate.h: 9690 * WebView/WebUIDelegatePrivate.h: 9691 96922011-04-28 Brian Weinstein <bweinstein@apple.com> 9693 9694 Reviewed by Timothy Hatcher. 9695 9696 Web Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is frontmost window 9697 https://bugs.webkit.org/show_bug.cgi?id=59747 9698 9699 Restore functions that were removed in r85051. They were needed when the inspector is the frontmost window. 9700 Also update them to call _inspectedWebView.get() - since it's a RetainPtr now. 9701 9702 * WebCoreSupport/WebInspectorClient.mm: 9703 (-[WebInspectorWindowController showWebInspector:]): 9704 (-[WebInspectorWindowController showErrorConsole:]): 9705 (-[WebInspectorWindowController toggleDebuggingJavaScript:]): 9706 (-[WebInspectorWindowController toggleProfilingJavaScript:]): 9707 (-[WebInspectorWindowController validateUserInterfaceItem:]): 9708 97092011-04-28 David Kilzer <ddkilzer@apple.com> 9710 9711 <http://webkit.org/b/59725> -[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:] leaks a CALayer 9712 9713 Reviewed by Dan Bernstein. 9714 9715 * WebView/WebFullScreenController.mm: 9716 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]): 9717 Use a RetainPtr to hold the CALayer and to fix the leak. 9718 97192011-04-28 David Kilzer <ddkilzer@apple.com> 9720 9721 Follow-up fix: <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects 9722 9723 Addresses review comment from Darin Adler. 9724 9725 * WebView/WebPDFView.mm: 9726 (-[WebPDFView menuForEvent:]): Use a local variable and -release 9727 instead of -autorelease. 9728 97292011-04-28 Anders Carlsson <andersca@apple.com> 9730 9731 Fix a thinko - separateRealmLabel is not an NSImageView. 9732 9733 * Panels/WebAuthenticationPanel.h: 9734 97352011-04-28 David Kilzer <ddkilzer@apple.com> 9736 9737 <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects 9738 9739 Reviewed by Dan Bernstein. 9740 9741 * WebView/WebPDFView.mm: 9742 (-[WebPDFView menuForEvent:]): Call -autorelease after copying 9743 each NSMenuItem. Regressed in r9566 for Bug 3711. 9744 97452011-04-28 Enrica Casucci <enrica@apple.com> 9746 9747 Reviewed by Beth Dakin. 9748 9749 Momentum scroll tweak for WebKit. 9750 https://bugs.webkit.org/show_bug.cgi?id=59723 9751 <rdar://problem/9259933> 9752 9753 * WebView/WebDynamicScrollBarsView.mm: 9754 (-[WebDynamicScrollBarsView scrollWheel:]): Changed constant. 9755 97562011-04-27 Anders Carlsson <andersca@apple.com> 9757 9758 Follow-up Leopard build fix. 9759 9760 * Carbon/HIViewAdapter.m: 9761 (_webkit_NSView_setNeedsDisplayInRect): 9762 97632011-04-27 Anders Carlsson <andersca@apple.com> 9764 9765 More clang++ 32-bit build fixes. 9766 9767 * Carbon/CarbonWindowAdapter.mm: 9768 (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]): 9769 (-[CarbonWindowAdapter setContentView:]): 9770 (-[CarbonWindowAdapter _handleContentBoundsChanged]): 9771 * Carbon/HIViewAdapter.m: 9772 (_webkit_NSView_setNeedsDisplayInRect): 9773 * Panels/WebAuthenticationPanel.h: 9774 * Plugins/WebBaseNetscapePluginView.mm: 9775 (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]): 9776 * Plugins/WebNetscapePluginEventHandlerCarbon.mm: 9777 (getCarbonEvent): 9778 * WebCoreSupport/WebChromeClient.mm: 9779 (WebChromeClient::scrollRectIntoView): 9780 * WebCoreSupport/WebViewFactory.mm: 9781 (-[WebViewFactory accessibilityConvertScreenRect:]): 9782 * WebView/WebFrameView.mm: 9783 (-[WebFrameView _scrollToBeginningOfDocument]): 9784 (-[WebFrameView _scrollToEndOfDocument]): 9785 * WebView/WebFullScreenController.mm: 9786 (-[WebFullScreenController windowDidEnterFullscreen:]): 9787 * WebView/WebHTMLView.mm: 9788 (-[WebHTMLView _hitViewForEvent:]): 9789 (coreGraphicsScreenPointForAppKitScreenPoint): 9790 * WebView/WebPDFView.mm: 9791 (-[WebPDFView setScrollPoint:]): 9792 97932011-04-27 Yury Semikhatsky <yurys@chromium.org> 9794 9795 Reviewed by Pavel Feldman. 9796 9797 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector 9798 https://bugs.webkit.org/show_bug.cgi?id=44230 9799 9800 Use RetainPtr access inspected view from the inspector one to avoid inspected view being deleted before 9801 inspector is closed. 9802 9803 * WebCoreSupport/WebInspectorClient.mm: store reference to inspected view in RetainPtr. Despite the removed 9804 comment in initWithInspectedWebView this doesn't introduce cyclic reference since there are no retaining 9805 pointers to the WebInspectorWindowController from the inspected page or from the WebInspectorClient. 9806 There is only one reference to it from WebInspectorFrontendClient which is held by the inspector 9807 front-end page. 9808 9809 Drive-by fix: removed several unused methods which are currently implemented in mac/WebInspector/WebInspector.mm 9810 (-[WebInspectorWindowController initWithInspectedWebView:]): 9811 (-[WebInspectorWindowController close]): 9812 (-[WebInspectorWindowController showWindow:]): 9813 (-[WebInspectorWindowController setAttachedWindowHeight:]): 9814 (-[WebInspectorWindowController destroyInspectorView:]): 9815 98162011-04-26 Sam Weinig <sam@webkit.org> 9817 9818 Reviewed by David Hyatt. 9819 9820 Remove Datagrid from the tree 9821 https://bugs.webkit.org/show_bug.cgi?id=59543 9822 9823 * Configurations/FeatureDefines.xcconfig: 9824 Remove feature. 9825 98262011-04-26 Dan Bernstein <mitz@apple.com> 9827 9828 Reviewed by Mark Rowe. 9829 9830 Choose the compiler based on the Xcode version for Snow Leopard debug builds. 9831 9832 * Configurations/Base.xcconfig: 9833 * Configurations/CompilerVersion.xcconfig: Added. 9834 98352011-04-25 Adam Barth <abarth@webkit.org> 9836 9837 Reviewed by David Levin. 9838 9839 WebKit2 should play nice with strict OwnPtrs 9840 https://bugs.webkit.org/show_bug.cgi?id=59426 9841 9842 Fix include ordering. 9843 9844 * WebView/WebDeviceOrientationProviderMock.mm: 9845 98462011-04-25 Adam Barth <abarth@webkit.org> 9847 9848 Reviewed by David Levin. 9849 9850 WebKit1 should build cleanly with strict OwnPtrs 9851 https://bugs.webkit.org/show_bug.cgi?id=59424 9852 9853 * History/WebHistoryItem.mm: 9854 (-[WebHistoryItem initFromDictionaryRepresentation:]): 9855 * Plugins/WebNetscapePluginEventHandler.h: 9856 * Plugins/WebNetscapePluginEventHandler.mm: 9857 (WebNetscapePluginEventHandler::create): 9858 * Plugins/WebNetscapePluginView.mm: 9859 (-[WebNetscapePluginView createPlugin]): 9860 * WebView/WebDeviceOrientationProviderMock.mm: 9861 * WebView/WebTextIterator.mm: 9862 (-[WebTextIterator initWithRange:]): 9863 98642011-04-25 Jon Lee <jonlee@apple.com> 9865 9866 Reviewed by Maciej Stachowiak. 9867 9868 Overlay scroller hard to see on pages with dark background (59183) 9869 https://bugs.webkit.org/show_bug.cgi?id=59183 9870 <rdar://problem/8975367> 9871 9872 * WebCoreSupport/WebSystemInterface.mm: 9873 (InitWebCoreSystemInterface): adding method to allow changing style 9874 98752011-04-23 Sheriff Bot <webkit.review.bot@gmail.com> 9876 9877 Unreviewed, rolling out r84740. 9878 http://trac.webkit.org/changeset/84740 9879 https://bugs.webkit.org/show_bug.cgi?id=59290 9880 9881 change breaks apple internal builds and is incorrect 9882 (Requested by smfr on #webkit). 9883 9884 * WebCoreSupport/WebSystemInterface.mm: 9885 (InitWebCoreSystemInterface): 9886 98872011-04-22 Jon Lee <jonlee@apple.com> 9888 9889 Reviewed by Beth Dakin. 9890 9891 Overlay scroller hard to see on pages with dark background (59183) 9892 https://bugs.webkit.org/show_bug.cgi?id=59183 9893 <rdar://problem/8975367> 9894 9895 * WebCoreSupport/WebSystemInterface.mm: 9896 (InitWebCoreSystemInterface): adding method to allow changing style 9897 98982011-04-19 Jer Noble <jer.noble@apple.com> 9899 9900 Reviewed by Daniel Bates. 9901 9902 Full Screen from within an <iframe> does not cause <iframe> to resize. 9903 https://bugs.webkit.org/show_bug.cgi?id=58638 9904 9905 Tests: fullscreen/full-screen-frameset-allowed.html 9906 fullscreen/full-screen-frameset-not-allowed.html 9907 9908 Return the _element's document instead of the WKView's document, which 9909 will be different in the case of elements within <iframe>s. 9910 9911 * WebView/WebFullScreenController.mm: 9912 (-[WebFullScreenController _document]): 9913 99142011-04-22 Jer Noble <jer.noble@apple.com> 9915 9916 Reviewed by Maciej Stachowiak. 9917 9918 Disable MediaPlayerPrivateAVFoundation when using old full screen mode. 9919 https://bugs.webkit.org/show_bug.cgi?id=59147 9920 9921 Add a new user default preference, and plumb that preference down to WebCore 9922 Settings. Allow the fullScreenEnabled preference to override the new 9923 isAVFoundationEnabled preference, so that clients of the legacy full screen 9924 mode will continue to use that mode normally. 9925 9926 * WebView/WebPreferenceKeysPrivate.h: Add new preference key. 9927 * WebView/WebPreferences.mm: 9928 (+[WebPreferences initialize]): Set the default value of new 9929 preference. 9930 (-[WebPreferences setAVFoundationEnabled:]): Added. 9931 (-[WebPreferences isAVFoundationEnabled]): Added. 9932 * WebView/WebPreferencesPrivate.h: 9933 * WebView/WebView.mm: 9934 (-[WebView _preferencesChanged:]): Update the WebCore settings with the 9935 new values from WebPreferences. 9936 99372011-04-22 Sam Weinig <sam@webkit.org> 9938 9939 Reviewed by Gavin Barraclough. 9940 9941 Remove remaining uses of deprecated version of toJS 9942 https://bugs.webkit.org/show_bug.cgi?id=59170 9943 9944 * DOM/WebDOMOperations.mm: 9945 (-[DOMElement _shadowRoot:]): 9946 (-[DOMElement _ensureShadowRoot:]): 9947 Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype. 9948 99492011-04-21 Maciej Stachowiak <mjs@apple.com> 9950 9951 Reviewed by Adam Roben. 9952 9953 Add a feature define to allow <details> and <summary> to be disabled 9954 https://bugs.webkit.org/show_bug.cgi?id=59118 9955 <rdar://problem/9257045> 9956 9957 * Configurations/FeatureDefines.xcconfig: 9958 99592011-04-21 Ryosuke Niwa <rniwa@webkit.org> 9960 9961 Reviewed by Sam Weinig. 9962 9963 Add Frame* to the argument lists of canCopyCut and canPaste 9964 https://bugs.webkit.org/show_bug.cgi?id=59153 9965 9966 * WebCoreSupport/WebEditorClient.h: 9967 * WebCoreSupport/WebEditorClient.mm: 9968 (WebEditorClient::canCopyCut): 9969 (WebEditorClient::canPaste): 9970 99712011-04-21 Sheriff Bot <webkit.review.bot@gmail.com> 9972 9973 Unreviewed, rolling out r82052. 9974 http://trac.webkit.org/changeset/82052 9975 https://bugs.webkit.org/show_bug.cgi?id=59135 9976 9977 New full screen api should be opt-in, not opt-out. (Requested 9978 by jernoble on #webkit). 9979 9980 * WebView/WebPreferences.mm: 9981 (+[WebPreferences initialize]): 9982 99832011-04-21 Beth Dakin <bdakin@apple.com> 9984 9985 Reviewed by Dan Bernstein. 9986 9987 https://bugs.webkit.org/show_bug.cgi?id=59048 9988 Need to track whether overlay scrollbar is currently visible and in lower- 9989 righthand corner 9990 -and corresponding- 9991 <rdar://problem/9211232> 9992 9993 A new WebSystemInterface is needed for this. 9994 * WebCoreSupport/WebSystemInterface.mm: 9995 (InitWebCoreSystemInterface): 9996 99972011-04-21 Dirk Schulze <krit@webkit.org> 9998 9999 Reviewed by Nikolas Zimmermann. 10000 10001 SVG feDropShadow implementation of SVG Filters 1.2 10002 https://bugs.webkit.org/show_bug.cgi?id=52513 10003 10004 * MigrateHeaders.make: 10005 100062011-04-20 Dominic Cooney <dominicc@chromium.org> 10007 10008 Reviewed by Dimitri Glazkov. 10009 10010 layoutTestController can create and destroy shadow DOM 10011 https://bugs.webkit.org/show_bug.cgi?id=59058 10012 10013 Support for new methods in Mac DRT. 10014 10015 * DOM/WebDOMOperations.mm: 10016 (-[DOMElement _ensureShadowRoot:]): 10017 (-[DOMElement _removeShadowRoot]): 10018 * DOM/WebDOMOperationsPrivate.h: 10019 100202011-04-20 Eric Carlson <eric.carlson@apple.com> 10021 10022 Reviewed by Dan Bernstein. 10023 10024 Adopt QTKit API for listing and deleting file in its media cache. 10025 <rdar://problem/9130029> 10026 10027 * WebCoreSupport/WebSystemInterface.mm: 10028 (InitWebCoreSystemInterface): Initialize new functions. 10029 100302011-04-19 Matthew Delaney <mdelaney@apple.com> 10031 10032 Reviewed by Simon Fraser. 10033 10034 WebPreferences in WebKit1 should have CanvasUsesAcceleratedDrawing set to NO by default 10035 https://bugs.webkit.org/show_bug.cgi?id=58936 10036 10037 * WebView/WebPreferences.mm: 10038 (+[WebPreferences initialize]): 10039 100402011-04-19 Vsevolod Vlasov <vsevik@chromium.org> 10041 10042 Reviewed by Pavel Feldman. 10043 10044 Web Inspector: Rename lengthReceived to encodedDataLength/dataLength 10045 https://bugs.webkit.org/show_bug.cgi?id=58883 10046 10047 * WebCoreSupport/WebFrameLoaderClient.h: 10048 * WebCoreSupport/WebFrameLoaderClient.mm: 10049 (WebFrameLoaderClient::dispatchDidReceiveContentLength): 10050 100512011-04-18 Jia Pu <jpu@apple.com> 10052 10053 Reviewed by Mark Rowe. 10054 10055 WebKit needs to stop importing <AppKit/NSTextChecker.h> 10056 https://bugs.webkit.org/show_bug.cgi?id=58798 10057 <rdar://problem/9294938> 10058 10059 Use public header <AppKit/NSSpellChecker.h> instead. 10060 10061 * WebCoreSupport/CorrectionPanel.h: 10062 * WebCoreSupport/CorrectionPanel.mm: 10063 (correctionIndicatorType): 10064 (CorrectionPanel::show): 10065 (CorrectionPanel::dismissInternal): 10066 (CorrectionPanel::handleAcceptedReplacement): 10067 * WebCoreSupport/WebEditorClient.mm: 10068 * WebView/WebView.mm: 10069 100702011-04-17 Cameron Zwarich <zwarich@apple.com> 10071 10072 Reviewed by Timothy Hatcher. 10073 10074 Stop using -[NSString initWithContentsOfFile:] 10075 https://bugs.webkit.org/show_bug.cgi?id=58763 10076 10077 -[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it. 10078 10079 * WebView/WebView.mm: 10080 (leakMailQuirksUserScriptContents): 10081 (leakOutlookQuirksUserScriptContents): 10082 100832011-04-17 David Kilzer <ddkilzer@apple.com> 10084 10085 <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting 10086 <rdar://problem/9268729> 10087 10088 Reviewed by Dan Bernstein. 10089 10090 This replaces support for the WebKitEnableHTTPPipelining user 10091 default with methods on the WebCore::ResourceRequest class in 10092 WebCore, the WebView class in WebKit1, and the WebContext class 10093 in WebKit2. It also removes support for the 10094 WebKitForceHTTPPipeliningPriorityHigh user default which was not 10095 needed. 10096 10097 * WebView/WebView.mm: 10098 (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added. 10099 (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added. 10100 * WebView/WebViewPrivate.h: 10101 (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration. 10102 (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration. 10103 101042011-04-17 Joseph Pecoraro <joepeck@webkit.org> 10105 10106 Reviewed by Dan Bernstein. 10107 10108 Assign to self in WebInspectorWindowController constructors 10109 https://bugs.webkit.org/show_bug.cgi?id=58749 10110 10111 * WebCoreSupport/WebInspectorClient.mm: 10112 (-[WebInspectorWindowController init]): 10113 (-[WebInspectorWindowController initWithInspectedWebView:]): 10114 101152011-04-17 Joseph Pecoraro <joepeck@webkit.org> 10116 10117 Reviewed by Timothy Hatcher. 10118 10119 Move WebNodeHighlighter into its own file 10120 https://bugs.webkit.org/show_bug.cgi?id=58746 10121 10122 Extract this class into its own file alongside the 10123 other WebNodeHighlight files. In doing so do some 10124 cleanup on WebInspectorClient removing some methods 10125 that were never called. 10126 10127 * WebCoreSupport/WebInspectorClient.mm: 10128 (WebInspectorClient::WebInspectorClient): style fix. 10129 * WebInspector/WebNodeHighlighter.h: Added. 10130 * WebInspector/WebNodeHighlighter.mm: Added. 10131 (-[WebNodeHighlighter initWithInspectedWebView:]): call super init. 10132 (-[WebNodeHighlighter dealloc]): 10133 (-[WebNodeHighlighter highlightNode:]): 10134 (-[WebNodeHighlighter hideHighlight]): 10135 (-[WebNodeHighlighter didAttachWebNodeHighlight:]): 10136 (-[WebNodeHighlighter willDetachWebNodeHighlight:]): 10137 101382011-04-15 Jia Pu <jpu@apple.com> 10139 10140 Reviewed by Dan Bernstein. 10141 10142 [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate. 10143 https://bugs.webkit.org/show_bug.cgi?id=58717 10144 10145 Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel. 10146 10147 * WebCoreSupport/CorrectionPanel.mm: 10148 (CorrectionPanel::show): 10149 101502011-04-15 Shishir Agrawal <shishir@chromium.org> 10151 10152 Reviewed by James Robinson. 10153 10154 Add a flag to guard Page Visibility API changes. 10155 https://bugs.webkit.org/show_bug.cgi?id=58464 10156 10157 * Configurations/FeatureDefines.xcconfig: 10158 101592011-04-15 Oliver Hunt <oliver@apple.com> 10160 10161 GC allocate Structure 10162 https://bugs.webkit.org/show_bug.cgi?id=58483 10163 10164 Rolling r83894 r83827 r83810 r83809 r83808 back in with 10165 a workaround for the gcc bug seen by the gtk bots 10166 10167 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 10168 * Plugins/Hosted/ProxyInstance.mm: 10169 (WebKit::ProxyRuntimeMethod::createStructure): 10170 * Plugins/Hosted/ProxyRuntimeObject.h: 10171 (WebKit::ProxyRuntimeObject::createStructure): 10172 101732011-04-14 Alexey Proskuryakov <ap@apple.com> 10174 10175 Reviewed by Dan Bernstein. 10176 10177 WebKit2: Password field input does not switch to ASCII-compatible source 10178 https://bugs.webkit.org/show_bug.cgi?id=58583 10179 <rdar://problem/9059651> 10180 10181 Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the 10182 necessary logic, needed to return a nil text input context when in password fields. 10183 10184 * WebView/WebHTMLView.mm: 10185 (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop. 10186 (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState. 10187 (-[WebHTMLView windowDidResignKey:]): Ditto. 10188 (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky 10189 because the first responder is still different an this point, so set a boolean variable to 10190 let _updateSecureInputState know what's going on. 10191 (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on. 10192 (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and 10193 allowed input sources accorsing to current selection. 10194 (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState. 10195 101962011-04-15 Sam Weinig <sam@webkit.org> 10197 10198 Reviewed by Maciej Stachowiak. 10199 10200 Make mac WebKit1 use the default localization strategy 10201 https://bugs.webkit.org/show_bug.cgi?id=58628 10202 10203 * WebCoreSupport/WebPlatformStrategies.h: 10204 * WebCoreSupport/WebPlatformStrategies.mm: 10205 Remove the localization strategy code. The equivalent is now 10206 in WebCore/platform/DefaultLocalizationStrategy.cpp. 10207 102082011-04-15 Anna Cavender <annacc@chromium.org> 10209 10210 Reviewed by Eric Carlson. 10211 10212 Renaming TRACK feature define to VIDEO_TRACK 10213 https://bugs.webkit.org/show_bug.cgi?id=53556 10214 10215 * Configurations/FeatureDefines.xcconfig: 10216 102172011-04-14 Pratik Solanki <psolanki@apple.com> 10218 10219 Reviewed by David Kilzer. 10220 10221 Set minimum priority for fast lane connections 10222 https://bugs.webkit.org/show_bug.cgi?id=58353 10223 10224 * WebCoreSupport/WebSystemInterface.mm: 10225 (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority. 10226 102272011-04-13 Sam Weinig <sam@webkit.org> 10228 10229 Reviewed by Gavin Barraclough. 10230 10231 WebKit2 doesn't keep overlay scrollers shown while scroll gesture held 10232 <rdar://problem/9260518> 10233 10234 * WebCoreSupport/WebSystemInterface.mm: 10235 (InitWebCoreSystemInterface): 10236 Initialize new WKSI functions. 10237 102382011-04-13 David Kilzer <ddkilzer@apple.com> 10239 10240 <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm 10241 10242 Reviewed by Anders Carlsson. 10243 10244 Fixes the following warning with -Wcast-align enabled: 10245 10246 Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3] 10247 archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header)); 10248 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 10249 10250 * Plugins/WebBasePluginPackage.mm: 10251 (-[WebBasePluginPackage isNativeLibraryData:]): Added 10252 COMPILE_ASSERT() to make sure our pointer math is valid. 10253 Removed cast to (uint8_t*) and divide sizeof(struct fat_header) 10254 by sizeof(uint32_t) to fix the pointer math. Replaced C-style 10255 casts with reinterpret_cast. 10256 102572011-04-12 Enrica Casucci <enrica@apple.com> 10258 10259 Reviewed by Alexey Proskuryakov. 10260 10261 Infinite recursion in WebHTMLView executeSavedKeypressCommands. 10262 https://bugs.webkit.org/show_bug.cgi?id=58382 10263 <rdar://problem/9239370> 10264 10265 Execution of some editing commands could trigger a call to selectedRange that 10266 internally calls executeSavedKeypressCommands creating an infinite recursion. 10267 10268 * WebView/WebHTMLView.mm: 10269 (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion. 10270 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization. 10271 102722011-04-12 Alice Liu <alice.liu@apple.com> 10273 10274 Reviewed by Sam Weinig. 10275 10276 https://bugs.webkit.org/show_bug.cgi?id=58292 10277 Provide new setting to allow site icon loading despite disabling automatic image loading in general. 10278 10279 * WebView/WebPreferenceKeysPrivate.h: Add preference key. 10280 * WebView/WebPreferences.mm: 10281 (+[WebPreferences initialize]): Initialize to false. 10282 (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added. 10283 (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added. 10284 * WebView/WebPreferencesPrivate.h: Add setter/getter definitions. 10285 * WebView/WebView.mm: 10286 (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes. 10287 102882011-04-11 Alexey Proskuryakov <ap@apple.com> 10289 10290 Reviewed by Maciej Stachowiak. 10291 10292 WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts 10293 https://bugs.webkit.org/show_bug.cgi?id=58175 10294 <rdar://problem/9060555> 10295 10296 * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this 10297 should be changed to match WebKit2. 10298 102992011-04-06 Timothy Hatcher <timothy@apple.com> 10300 10301 Fix a bug where the context menu does not show in PDF documents if there is no 10302 UI delegate or the UI delegate does not respond to the context menu selector. 10303 10304 https://webkit.org/b/57958 10305 10306 Reviewed by Darin Adler. 10307 10308 * WebView/WebView.mm: 10309 (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil 10310 if UIDelegate is nil or doesn't respond to the selector. So check that 10311 here to distinguish between using defaultMenuItems or the delegate 10312 really returning nil to say "no context menu". 10313 103142011-04-11 Jer Noble <jer.noble@apple.com> 10315 10316 Unreviewed; roll out unintentional change to WebFullScreenController.mm. 10317 10318 * WebView/WebFullScreenController.mm: 10319 (-[WebFullScreenController enterFullscreen:]): 10320 103212011-04-08 Geoffrey Garen <ggaren@apple.com> 10322 10323 Reviewed by Oliver Hunt. 10324 10325 A few heap-related renames and file moves. 10326 10327 WeakGCPtr<T> => Weak<T> 10328 Global<T> => Strong<T> 10329 collector/ => heap/ 10330 collector/* => heap/* 10331 runtime/WeakGCPtr.h => heap/Weak.h 10332 10333 (Eventually, even more files should move into the heap directory. Like 10334 Heap.h and Heap.cpp, for example.) 10335 10336 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 10337 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 10338 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): 10339 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): 10340 (WebKit::NetscapePluginInstanceProxy::evaluate): 10341 * WebView/WebScriptDebugger.h: 10342 103432011-04-08 Alexey Proskuryakov <ap@apple.com> 10344 10345 Reviewed by Darin Adler. 10346 10347 WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts 10348 https://bugs.webkit.org/show_bug.cgi?id=58175 10349 <rdar://problem/9060555> 10350 10351 * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this 10352 should be changed to match WebKit2. 10353 103542011-04-08 Alpha Lam <hclam@chromium.org> 10355 10356 Unreviewed, rolling out r83335. 10357 http://trac.webkit.org/changeset/83335 10358 https://bugs.webkit.org/show_bug.cgi?id=53556 10359 10360 GTK and QT bots are broken 10361 10362 * Configurations/FeatureDefines.xcconfig: 10363 103642011-04-07 Anna Cavender <annacc@chromium.org> 10365 10366 Reviewed by Eric Carlson. 10367 10368 Setup ENABLE(TRACK) feature define 10369 https://bugs.webkit.org/show_bug.cgi?id=53556 10370 10371 * Configurations/FeatureDefines.xcconfig: 10372 103732011-04-08 Maciej Stachowiak <mjs@apple.com> 10374 10375 Reviewed by Darin Adler. 10376 10377 -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once 10378 https://bugs.webkit.org/show_bug.cgi?id=58128 10379 <rdar://problem/9244553> 10380 10381 The root of the problem here was an O(N^2) issue - each WebView, 10382 upon having its preferences initialized, would broadcast a 10383 notification that was listened to by all other WebViews sharing 10384 its preferences. 10385 10386 To maintain the API contract, I split the notification into two, 10387 one that is for public API consumption, and the other which is for 10388 internal use only. Changes that don't need to be picked up by 10389 other WebViews broadcast the public notification only. And we 10390 avoid WebView broadcasting a notification just to get itself to 10391 update. 10392 10393 * Misc/WebIconDatabase.mm: 10394 (-[WebIconDatabase _startUpIconDatabase]): 10395 (-[WebIconDatabase _shutDownIconDatabase]): 10396 * Plugins/WebBaseNetscapePluginView.mm: 10397 (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): 10398 (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]): 10399 (-[WebBaseNetscapePluginView viewDidMoveToWindow]): 10400 (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]): 10401 * WebView/WebPreferences.mm: 10402 (-[WebPreferences initWithIdentifier:]): 10403 (-[WebPreferences _setStringValue:forKey:]): 10404 (-[WebPreferences _setIntegerValue:forKey:]): 10405 (-[WebPreferences _setFloatValue:forKey:]): 10406 (-[WebPreferences _setBoolValue:forKey:]): 10407 (-[WebPreferences _setLongLongValue:forKey:]): 10408 (-[WebPreferences _setUnsignedLongLongValue:forKey:]): 10409 (-[WebPreferences _postPreferencesChangedNotification]): 10410 (-[WebPreferences _postPreferencesChangedAPINotification]): 10411 * WebView/WebPreferencesPrivate.h: 10412 * WebView/WebView.mm: 10413 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 10414 (-[WebView _preferencesChangedNotification:]): 10415 (-[WebView _preferencesChanged:]): 10416 (-[WebView setUsesPageCache:]): 10417 (+[WebView initialize]): 10418 (-[WebView setPreferences:]): 10419 (-[WebView _keyboardUIMode]): 10420 * WebView/WebViewInternal.h: 10421 104222011-04-07 Andrew Scherkus <scherkus@chromium.org> 10423 10424 Revert ENABLE_TRACK patch due to compile failures. 10425 10426 * Configurations/FeatureDefines.xcconfig: 10427 104282011-04-07 Alexey Proskuryakov <ap@apple.com> 10429 10430 Reviewed by Anders Carlsson. 10431 10432 REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri 10433 https://bugs.webkit.org/show_bug.cgi?id=58066 10434 <rdar://problem/8965302> 10435 10436 * WebView/WebHTMLRepresentation.mm: 10437 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]): 10438 * WebView/WebHTMLView.mm: 10439 (-[WebHTMLView attributedSubstringFromRange:]): 10440 (-[WebHTMLView attributedString]): 10441 (-[WebHTMLView selectedAttributedString]): 10442 Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange. 10443 104442011-04-07 Andy Estes <aestes@apple.com> 10445 10446 Reviewed by Darin Adler. 10447 10448 REGRESSION (r64712): Microsoft Outlook 2011: original message contents 10449 not included when replying to an email. 10450 https://bugs.webkit.org/show_bug.cgi?id=57794 10451 10452 Outlook populates a reply message by creating an empty WebView and 10453 using DOM API to populate the WebView's empty document with content 10454 from the original message. It expects the initial empty document to 10455 simply be "<html></html>", and it proceeds to dynamically create and 10456 append a BODY node and add the original message content as a child of 10457 that node. Outlook then takes the innerHTML of the frame's first body 10458 element and copies it into a *new* document that is displayed and 10459 edited in the reply message window. 10460 10461 Due to implementing the HTML5 tree building algorithm in r64712, 10462 initial empty documents went from being "<html></html>" to being 10463 "<html><head></head><body></body></html>". Outlook still dynamically 10464 creates a BODY node to parent the original message content, but this 10465 BODY node duplicates the one created by the tree builder. When Outlook 10466 then takes the innerHTML of the first body element to populate the 10467 reply message window it gets the empty body element created by the 10468 parser, not the one it created with the original message content. 10469 10470 Fix this by injecting a user script into the initial empty document 10471 that removes the HEAD and BODY nodes created by the parser. This 10472 ensures that the BODY created by Outlook is the only BODY in the 10473 document. 10474 10475 * Misc/OutlookQuirksUserScript.js: Added. 10476 * WebView/WebView.mm: 10477 (leakMailQuirksUserScriptContents): 10478 (-[WebView _injectMailQuirksScript]): 10479 (needsOutlookQuirksScript): 10480 (leakOutlookQuirksUserScriptContents): 10481 (-[WebView _injectOutlookQuirksScript]): 10482 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 10483 104842011-04-06 Dai Mikurube <dmikurube@chromium.org> 10485 10486 Reviewed by David Levin. 10487 10488 Add QUOTA build flag for unified quota API 10489 https://bugs.webkit.org/show_bug.cgi?id=57918 10490 10491 * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag 10492 104932011-04-06 Robert Sesek <rsesek@chromium.org> 10494 10495 Reviewed by Alexey Proskuryakov. 10496 10497 Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too 10498 https://bugs.webkit.org/show_bug.cgi?id=54969 10499 10500 * WebView/WebFrame.mm: 10501 (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore 10502 (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore 10503 105042011-04-05 Alexey Proskuryakov <ap@apple.com> 10505 10506 Reviewed by Darin Adler. 10507 10508 Move attributedStringFromRange down to WebCore 10509 https://bugs.webkit.org/show_bug.cgi?id=57905 10510 10511 * Misc/WebNSAttributedStringExtras.h: Removed. 10512 * Misc/WebNSAttributedStringExtras.mm: Removed. 10513 * WebView/WebHTMLRepresentation.mm: 10514 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]): 10515 * WebView/WebHTMLView.mm: 10516 (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]): 10517 (-[WebHTMLView attributedSubstringFromRange:]): 10518 (-[WebHTMLView attributedString]): 10519 (-[WebHTMLView selectedAttributedString]): 10520 * WebView/WebPDFView.mm: 10521 (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]): 10522 105232011-04-04 MORITA Hajime <morrita@google.com> 10524 10525 Reviewed by Ryosuke Niwa. 10526 10527 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult 10528 https://bugs.webkit.org/show_bug.cgi?id=56085 10529 10530 Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted 10531 NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method. 10532 for requestCheckingOfString method. 10533 10534 * WebCoreSupport/WebEditorClient.h: 10535 * WebCoreSupport/WebEditorClient.mm: 10536 (toCoreTextCheckingResults): 10537 (WebEditorClient::checkTextOfParagraph): 10538 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]): 10539 (-[WebEditorSpellCheckResponder perform]): 10540 (WebEditorClient::requestCheckingOfString): 10541 * WebView/WebFrame.mm: 10542 (-[WebFrame markersForSelectionStartAsText]): 10543 * WebView/WebFramePrivate.h: 10544 105452011-04-05 Anders Carlsson <andersca@apple.com> 10546 10547 Didn't mean to land this. 10548 10549 * Plugins/WebNetscapePluginView.mm: 10550 (-[WebNetscapePluginView getVariable:value:]): 10551 105522011-04-04 David Kilzer <ddkilzer@apple.com> 10553 10554 <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match 10555 10556 Reviewed by Alexey Proskuryakov. 10557 10558 * WebCoreSupport/WebSystemInterface.mm: 10559 (InitWebCoreSystemInterface): Added initialization for 10560 wkSetHTTPPipeliningMaximumPriority(). 10561 105622011-04-04 Alexey Proskuryakov <ap@apple.com> 10563 10564 Reviewed by Dan Bernstein. 10565 10566 REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2 10567 https://bugs.webkit.org/show_bug.cgi?id=51230 10568 <rdar://problem/8780989> 10569 10570 * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from 10571 WebKits to WebCore, because WebKit shouldn't be smart. 10572 105732011-04-01 Alexey Proskuryakov <ap@apple.com> 10574 10575 Reviewed by Darin Adler. 10576 10577 REGRESSION: Assertion failure when executing a complex custom key binding 10578 https://bugs.webkit.org/show_bug.cgi?id=57681 10579 10580 * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved 10581 commands when they can't possibly change the result. 10582 105832011-04-01 Anders Carlsson <andersca@apple.com> 10584 10585 Reviewed by Sam Weinig. 10586 10587 Shockwave plug-in doesn't accept mouse events 10588 https://bugs.webkit.org/show_bug.cgi?id=57653 10589 <rdar://problem/8483273> 10590 10591 Fix an unrelated bug found by the added test. 10592 10593 * Plugins/WebBaseNetscapePluginView.mm: 10594 (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]): 10595 Make sure to always set destX and destY. 10596 105972011-04-01 Alexey Proskuryakov <ap@apple.com> 10598 10599 Reviewed by Darin Adler. 10600 10601 Make WebKit2 text input handling more like WebKit1 10602 https://bugs.webkit.org/show_bug.cgi?id=57649 10603 10604 * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView. 10605 * WebView/WebHTMLView.mm: 10606 (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands. 10607 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands. 10608 (-[WebHTMLView characterIndexForPoint:]): Ditto. 10609 (-[WebHTMLView firstRectForCharacterRange:]): Ditto. 10610 (-[WebHTMLView selectedRange]): Ditto. 10611 (-[WebHTMLView markedRange]): Ditto. 10612 (-[WebHTMLView attributedSubstringFromRange:]): Ditto. 10613 (-[WebHTMLView hasMarkedText]): Ditto. 10614 (-[WebHTMLView unmarkText]): Ditto. 10615 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument 10616 type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't 10617 be able to call text input protocol methods from here (and we didn't even reset it back on 10618 return). Changed to retrieve all data before starting to apply actions to better match WK2 code. 10619 (-[WebHTMLView insertText:]): Ditto. 10620 106212011-04-01 Timothy Hatcher <timothy@apple.com> 10622 10623 Make momentum scroll event latching work in WebKit2 on Mac. 10624 10625 <rdar://problem/8751861> 10626 10627 Reviewed by Darin Adler. 10628 10629 * WebCoreSupport/WebSystemInterface.mm: 10630 (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase. 10631 * WebView/WebDynamicScrollBarsView.mm: 10632 (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent. 10633 106342011-03-31 Darin Adler <darin@apple.com> 10635 10636 Reviewed by Anders Carlsson. 10637 10638 Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:] 10639 https://bugs.webkit.org/show_bug.cgi?id=26667 10640 10641 * WebView/WebHTMLView.mm: 10642 (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is 10643 nil rather than asserting that it is non-nil. One case where WebView will be nil 10644 is when the frame is closed, but in any case where it is nil, the correct thing 10645 to do is to not try to handle the style key. 10646 106472011-03-31 Alexey Proskuryakov <ap@apple.com> 10648 10649 Patch by John Harvey, reviewed and tweaked by me. 10650 10651 <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text. 10652 10653 * Plugins/Hosted/WebTextInputWindowController.m: 10654 (-[WebTextInputPanel _interpretKeyEvent:string:]): 10655 106562011-03-31 Evan Martin <evan@chromium.org> 10657 10658 Reviewed by Eric Seidel. 10659 10660 <title> should support dir attribute 10661 https://bugs.webkit.org/show_bug.cgi?id=50961 10662 10663 Update to new FrameLoaderClient interface. 10664 10665 * WebCoreSupport/WebFrameLoaderClient.h: 10666 * WebCoreSupport/WebFrameLoaderClient.mm: 10667 (WebFrameLoaderClient::dispatchDidReceiveTitle): 10668 (WebFrameLoaderClient::setTitle): 10669 106702011-03-30 Dominic Cooney <dominicc@google.com> 10671 10672 Reviewed by Dimitri Glazkov. 10673 10674 Adds layoutTestController.shadowRoot accessor to Mac DRT. 10675 https://bugs.webkit.org/show_bug.cgi?id=57415 10676 10677 * DOM/WebDOMOperations.mm: 10678 (-[DOMElement _shadowRoot:]): 10679 * DOM/WebDOMOperationsPrivate.h: 10680 106812011-03-30 Alexey Proskuryakov <ap@apple.com> 10682 10683 Reviewed by Darin Adler. 10684 10685 WebHTMLView shouldn't resend noop: commands 10686 https://bugs.webkit.org/show_bug.cgi?id=57504 10687 <rdar://problem/9209390> 10688 10689 * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs, 10690 which we get e.g. when handling Cmd-key combos. 10691 106922011-03-30 Alexey Proskuryakov <ap@apple.com> 10693 10694 Reviewed by Darin Adler. 10695 10696 REGRESSION (r82320): Spacebar no longer pages down 10697 https://bugs.webkit.org/show_bug.cgi?id=57423 10698 <rdar://problem/9207702> 10699 10700 Also includes some unrelated cleanup that I had in my tree. 10701 10702 * WebView/WebHTMLView.mm: 10703 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is 10704 being dispatched to the right frame. 10705 (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL. 10706 (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=". 10707 Even if this specific command hasn't been handled, that doesn't nullify side effects from 10708 previous commands. 10709 (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the 10710 bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for 10711 another WebHTMLView NSTextInput method to be called from within insertText:, so no one is 10712 going to look at it. 10713 107142011-03-30 Sam Weinig <sam@webkit.org> 10715 10716 Reviewed by Brady Eidson. 10717 10718 WebKit2: Attempting to view css file from url causes it to download 10719 <rdar://problem/9102611> 10720 https://bugs.webkit.org/show_bug.cgi?id=57501 10721 10722 * WebView/WebHTMLRepresentation.h: 10723 * WebView/WebHTMLRepresentation.mm: 10724 (+[WebHTMLRepresentation unsupportedTextMIMETypes]): 10725 * WebView/WebHTMLView.mm: 10726 (+[WebHTMLView unsupportedTextMIMETypes]): 10727 Re-factor unsupportedTextMIMETypes to pull from WebCore's 10728 MIMETypeRegistry, so that the list can be shared with WebKit2. 10729 107302011-03-29 Beth Dakin <bdakin@apple.com> 10731 10732 Reviewed by Maciej Stachowiak. 10733 10734 Fix for https://bugs.webkit.org/show_bug.cgi?id=57408 10735 webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard 10736 -and corresponding- 10737 <rdar://problem/8665411> 10738 10739 * Misc/WebNSControlExtras.m: 10740 (-[NSControl sizeToFitAndAdjustWindowHeight]): 10741 * WebCoreSupport/WebChromeClient.mm: 10742 (WebChromeClient::scaleFactor): 10743 * WebView/WebHTMLView.mm: 10744 (-[WebHTMLView viewDidMoveToWindow]): 10745 (-[WebHTMLView attachRootLayer:]): 10746 107472011-03-29 Kent Tamura <tkent@chromium.org> 10748 10749 Reviewed by Dimitri Glazkov. 10750 10751 Make validation message bubble testable 10752 https://bugs.webkit.org/show_bug.cgi?id=57290 10753 10754 * WebView/WebView.mm: 10755 (-[WebView _preferencesChangedNotification:]): Copy the private value of 10756 the timer magnification to WebCore::Settings. 10757 (-[WebView validationMessageTimerMagnification]): Added. 10758 (-[WebView setValidationMessageTimerMagnification:]): Added. 10759 * WebView/WebViewData.h: Declare a member for the timer magnification. 10760 * WebView/WebViewData.mm: 10761 (-[WebViewPrivate init]): Initialize the timer magnification. 10762 * WebView/WebViewPrivate.h: 10763 Declare a setter and a getter for the timer magnification. 10764 107652011-03-29 Kent Tamura <tkent@chromium.org> 10766 10767 Reviewed by Dimitri Glazkov. 10768 10769 [Mac] Enable interactive-validation tests on Mac DRT 10770 https://bugs.webkit.org/show_bug.cgi?id=57308 10771 10772 * WebView/WebView.mm: 10773 (-[WebView _preferencesChangedNotification:]): 10774 Convey a WebView flag for interactive validation to WebCore::Settings. 10775 (-[WebView interactiveFormValidationEnabled]): Added. 10776 (-[WebView setInteractiveFormValidationEnabled:]): Added. 10777 * WebView/WebViewData.h: Add interactiveFormValidationEnabled. 10778 * WebView/WebViewData.mm: 10779 (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled. 10780 * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled. 10781 107822011-03-29 Timothy Hatcher <timothy@apple.com> 10783 10784 Update the order of the context menu to better match AppKit on Mac. 10785 10786 <rdar://problem/9054893> 10787 10788 Reviewed by John Sullivan. 10789 10790 * DefaultDelegates/WebDefaultContextMenuDelegate.mm: 10791 (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items. 10792 * WebCoreSupport/WebPlatformStrategies.h: 10793 * WebCoreSupport/WebPlatformStrategies.mm: 10794 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string. 10795 107962011-03-29 Alexey Proskuryakov <ap@apple.com> 10797 10798 Reviewed by Darin Adler. 10799 10800 https://bugs.webkit.org/show_bug.cgi?id=57379 10801 Clean up WK1 key event handling logic 10802 10803 No bugs knowingly fixed, but this makes the code more consistent. 10804 10805 * WebView/WebHTMLView.mm: 10806 (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to 10807 eventInterpretationHadSideEffects, because "handled" doesn't really mean much. 10808 (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use 10809 from other functions. We need to execute saved commands when an input method asks for current 10810 state, because providing stale state could confuse it. 10811 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other 10812 changes. 10813 (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise, 10814 the answer would be stale. 10815 (-[WebHTMLView firstRectForCharacterRange:]): Ditto. 10816 (-[WebHTMLView selectedRange]): Ditto. 10817 (-[WebHTMLView markedRange]): Ditto. 10818 (-[WebHTMLView attributedSubstringFromRange:]): Ditto. 10819 (-[WebHTMLView hasMarkedText]): Ditto. 10820 (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be 10821 operating on stale data. Also, updated for eventWasHandled renaming. 10822 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. 10823 (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that 10824 it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also 10825 fragile, because there is no guarantee about when noop: is sent (also, a custom key binding 10826 could have a noop: as one of its commands, although that's hardly practical). 10827 Added the same "from input method" logic that we have in insertText: - I don't know of any 10828 IMs that call this method, but we clearly need to execute it as part of IM processing when 10829 there is marked text. 10830 (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set 10831 eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times 10832 if current selection isn't editable. This is different from doCommandBySelector:, where we 10833 need to give super class a chance to handle the event if our processing fails. 10834 Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the 10835 return value of _interpretKeyEvent is computed differently. 10836 108372011-03-28 Adele Peterson <adele@apple.com> 10838 10839 Reviewed by Eric Seidel. 10840 10841 Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type 10842 https://bugs.webkit.org/show_bug.cgi?id=57173 10843 10844 * WebView/WebFrame.mm: 10845 (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor. 10846 (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method. 10847 * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested. 10848 108492011-03-28 Alexey Proskuryakov <ap@apple.com> 10850 10851 Reviewed by Darin Adler. 10852 10853 https://bugs.webkit.org/show_bug.cgi?id=57260 10854 Clean up text input code a little 10855 10856 * WebCoreSupport/WebEditorClient.mm: 10857 (WebEditorClient::handleKeyboardEvent): 10858 (WebEditorClient::handleInputMethodKeydown): 10859 * WebView/WebHTMLViewInternal.h: 10860 Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept 10861 anything. It's just a version it interpretKeyEvents: that tells us whether it was handled, 10862 and also possibly saves resulting commands for later execution. 10863 10864 * WebView/WebHTMLView.mm: 10865 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed 10866 return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from 10867 WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event 10868 handling state, like the other booleans there. Don't call interpretKeyEvents: again simply 10869 because the first call resulted in no saved commands, becasue it's confusing and apparently 10870 useless (I couldn't find any broken behavior). 10871 (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants. 10872 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. 10873 (-[WebHTMLView doCommandBySelector:]): Ditto. 10874 (-[WebHTMLView insertText:]): Ditto. 10875 10876 * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand: 10877 method on WebView. 10878 108792011-03-27 Jer Noble <jer.noble@apple.com> 10880 10881 Reviewed by Maciej Stachowiak. 10882 10883 Full Screen: disable keyboard access by default 10884 https://bugs.webkit.org/show_bug.cgi?id=56684 10885 10886 Take into account whether keyboard access was requested when deciding whether full 10887 screen mode is supported. 10888 10889 * WebCoreSupport/WebChromeClient.h: 10890 * WebCoreSupport/WebChromeClient.mm: 10891 (WebChromeClient::supportsFullScreenForElement): 10892 * WebView/WebView.mm: 10893 (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]): 10894 * WebView/WebViewInternal.h: 10895 108962011-03-26 Jer Noble <jer.noble@apple.com> 10897 10898 Reviewed by Eric Carlson. 10899 10900 Enable the Full Screen API by default in WebKit/mac and WebKit2 10901 https://bugs.webkit.org/show_bug.cgi?id=56956 10902 10903 * WebView/WebPreferences.mm: 10904 (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true. 10905 109062011-03-25 Andy Estes <aestes@apple.com> 10907 10908 Reviewed by Adele Peterson. 10909 10910 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js 10911 https://bugs.webkit.org/show_bug.cgi?id=49016 10912 10913 Update objectContentType() implementation to handle the 10914 shouldPreferPlugInsForImages flag. 10915 10916 * WebCoreSupport/WebFrameLoaderClient.h: 10917 * WebCoreSupport/WebFrameLoaderClient.mm: 10918 (WebFrameLoaderClient::objectContentType): 10919 109202011-03-24 Sheriff Bot <webkit.review.bot@gmail.com> 10921 10922 Unreviewed, rolling out r81939. 10923 http://trac.webkit.org/changeset/81939 10924 https://bugs.webkit.org/show_bug.cgi?id=57084 10925 10926 Rolling out 81939, as it's causing a number of app cache test 10927 failures. (Requested by jernoble on #webkit). 10928 10929 * WebView/WebView.mm: 10930 (-[WebView _preferencesChangedNotification:]): 10931 109322011-03-23 Jer Noble <jer.noble@apple.com> 10933 10934 Reviewed by Maciej Stachowiak. 10935 10936 Application Cache should save audio/ and video/ mime types as flat files 10937 https://bugs.webkit.org/show_bug.cgi?id=53784 10938 <rdar://problem/8932473> 10939 10940 No new tests. 10941 10942 Initialize the AppCache Total size quotas with the values for WebKitPreferences 10943 upon startup. 10944 10945 * WebView/WebView.mm: 10946 (-[WebView _preferencesChangedNotification:]): 10947 109482011-03-24 Sheriff Bot <webkit.review.bot@gmail.com> 10949 10950 Unreviewed, rolling out r81916 and r81917. 10951 http://trac.webkit.org/changeset/81916 10952 http://trac.webkit.org/changeset/81917 10953 https://bugs.webkit.org/show_bug.cgi?id=57071 10954 10955 broke a test on platforms that do not have QuickTime installed 10956 (Requested by estes on #webkit). 10957 10958 * WebCoreSupport/WebFrameLoaderClient.h: 10959 * WebCoreSupport/WebFrameLoaderClient.mm: 10960 (WebFrameLoaderClient::objectContentType): 10961 109622011-03-24 Andy Estes <aestes@apple.com> 10963 10964 Reviewed by Darin Adler. 10965 10966 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js 10967 https://bugs.webkit.org/show_bug.cgi?id=49016 10968 10969 Update objectContentType() implementation to handle the 10970 shouldPreferPlugInsForImages flag. 10971 10972 * WebCoreSupport/WebFrameLoaderClient.h: 10973 * WebCoreSupport/WebFrameLoaderClient.mm: 10974 (WebFrameLoaderClient::objectContentType): 10975 109762011-03-24 Geoffrey Garen <ggaren@apple.com> 10977 10978 Reviewed by Oliver Hunt. 10979 10980 Ensure that all compilation takes place within a dynamic global object scope 10981 https://bugs.webkit.org/show_bug.cgi?id=57054 10982 10983 * WebView/WebScriptDebugDelegate.mm: 10984 (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change. 10985 109862011-03-24 Jia Pu <jpu@apple.com> 10987 10988 Reviewed by Darin Adler. 10989 10990 Dismissed reversion suggestion is incorrectly learned. 10991 https://bugs.webkit.org/show_bug.cgi?id=57039 10992 10993 CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView]. 10994 [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel 10995 is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes 10996 incorrect automatic learning. 10997 10998 * WebCoreSupport/CorrectionPanel.mm: 10999 (CorrectionPanel::dismissInternal): 11000 110012011-03-24 David Kilzer <ddkilzer@apple.com> 11002 11003 <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X 11004 11005 Reviewed by Joseph Pecoraro. 11006 11007 * Plugins/WebPluginContainerPrivate.h: Changed value of 11008 ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0. 11009 110102011-03-23 Jia Pu <jpu@apple.com> 11011 11012 Reviewed by Darin Adler. 11013 11014 Hook up new AppKit autocorrection UI with WK2. 11015 https://bugs.webkit.org/show_bug.cgi?id=56055 11016 <rdar://problem/8947463> 11017 11018 Please see WebCore/ChangeLog for detail. 11019 11020 * WebCoreSupport/CorrectionPanel.h: Added. 11021 (CorrectionPanel::isShowing): 11022 * WebCoreSupport/CorrectionPanel.mm: Added. 11023 (correctionBubbleType): 11024 (CorrectionPanel::CorrectionPanel): 11025 (CorrectionPanel::~CorrectionPanel): 11026 (CorrectionPanel::show): 11027 (CorrectionPanel::dismiss): 11028 (CorrectionPanel::dismissSoon): 11029 (CorrectionPanel::dismissInternal): 11030 (CorrectionPanel::recordAutocorrectionResponse): 11031 * WebCoreSupport/WebEditorClient.h: 11032 * WebCoreSupport/WebEditorClient.mm: 11033 (WebEditorClient::WebEditorClient): 11034 (WebEditorClient::showCorrectionPanel): 11035 (WebEditorClient::dismissCorrectionPanel): 11036 (WebEditorClient::dismissCorrectionPanelSoon): 11037 (WebEditorClient::recordAutocorrectionResponse): 11038 * WebView/WebView.mm: 11039 (-[WebView handleCorrectionPanelResult:]): 11040 * WebView/WebViewPrivate.h: 11041 110422011-03-23 Enrica Casucci <enrica@apple.com> 11043 11044 Reviewed by Alexey Proskuryakov. 11045 11046 Services menu item to convert selected Simplified/Traditional Chinese Text is not working. 11047 https://bugs.webkit.org/show_bug.cgi?id=56974 11048 <rdar://problem/8284642> 11049 11050 This fixes a regression introduced by http://trac.webkit.org/changeset/61794 11051 where readSelectionFromPasteboard was accidentally removed. 11052 This method and writeSelectionToPasteboard are needed to support Mac OS X 11053 services. 11054 11055 * WebView/WebHTMLView.mm: 11056 (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added. 11057 (-[WebHTMLView readSelectionFromPasteboard:]): Added. 11058 110592011-03-23 Brady Eidson <beidson@apple.com> 11060 11061 Reviewed by Sam Weinig. 11062 11063 Change IconDatabase opening to allow for arbitrary filenames 11064 https://bugs.webkit.org/show_bug.cgi?id=56977 11065 11066 * Misc/WebIconDatabase.mm: 11067 (-[WebIconDatabase _startUpIconDatabase]): 11068 110692011-03-22 Anton D'Auria <adauria@apple.com> 11070 11071 Reviewed by Alexey Proskuryakov. 11072 11073 Add +[WebApplicationCache getOriginsWithCache] 11074 https://bugs.webkit.org/show_bug.cgi?id=56722 11075 11076 Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API. 11077 11078 * WebCoreSupport/WebApplicationCache.h: 11079 * WebCoreSupport/WebApplicationCache.mm: 11080 (+[WebApplicationCache originsWithCache]): 11081 110822011-03-22 Anders Carlsson <andersca@apple.com> 11083 11084 Reviewed by Sam Weinig. 11085 11086 OBJECT element with DivX source is always downloaded 11087 https://bugs.webkit.org/show_bug.cgi?id=56879 11088 11089 * Plugins/WebBasePluginPackage.mm: 11090 (-[WebBasePluginPackage getPluginInfoFromPLists]): 11091 Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in 11092 specifies multiple file extensions in a single element. 11093 110942011-03-22 Brady Eidson <beidson@apple.com> 11095 11096 Reviewed by Sam Weinig. 11097 11098 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876 11099 WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread 11100 11101 Note that while the new client calls always come through on the main thread, our mechanisms to 11102 route dispatches to the main thread are still valid and will still work. 11103 11104 Update to the new IconDatabaseClient interface: 11105 * WebCoreSupport/WebIconDatabaseClient.h: 11106 * WebCoreSupport/WebIconDatabaseClient.mm: 11107 (WebIconDatabaseClient::didRemoveAllIcons): 11108 (WebIconDatabaseClient::didImportIconURLForPageURL): 11109 (WebIconDatabaseClient::didImportIconDataForPageURL): 11110 (WebIconDatabaseClient::didChangeIconForPageURL): 11111 (WebIconDatabaseClient::didFinishURLImport): 11112 111132011-03-22 Matthew Delaney <mdelaney@apple.com> 11114 11115 Reviewed by Simon Fraser. 11116 11117 Have WebKit push acceleratedDrawing preferences to settings 11118 https://bugs.webkit.org/show_bug.cgi?id=56792 11119 11120 * WebView/WebView.mm: 11121 111222011-03-21 Nate Chapin <japhet@chromium.org> 11123 11124 Reviewed by Brady Eidson. 11125 11126 Expose a preference to use caching quirks for QuickLook, 11127 and use it if the QuickLook framework is loaded. 11128 11129 https://bugs.webkit.org/show_bug.cgi?id=38690 11130 11131 * WebView/WebPreferenceKeysPrivate.h: 11132 * WebView/WebPreferences.mm: 11133 (useQuickLookQuirks): 11134 (+[WebPreferences initialize]): 11135 (-[WebPreferences useQuickLookResourceCachingQuirks]): 11136 * WebView/WebPreferencesPrivate.h: 11137 * WebView/WebView.mm: 11138 (-[WebView _preferencesChangedNotification:]): 11139 111402011-03-21 Chris Fleizach <cfleizach@apple.com> 11141 11142 Reviewed by Darin Adler. 11143 11144 AX: showContextMenu not working in WK2 11145 https://bugs.webkit.org/show_bug.cgi?id=56734 11146 11147 Implement showContextMenu() so accessibility related code can call this 11148 independent of whether WK1 or WK2 is running. 11149 11150 * WebCoreSupport/WebChromeClient.h: 11151 * WebCoreSupport/WebChromeClient.mm: 11152 (WebChromeClient::showContextMenu): 11153 111542011-03-21 Chang Shu <cshu@webkit.org> 11155 11156 Reviewed by Alexey Proskuryakov. 11157 11158 REGRESSION (r79953): Can't type in MS Outlook 2011 11159 https://bugs.webkit.org/show_bug.cgi?id=56665 11160 11161 r79953 removed the WebView level editablity which is persistent no matter whether 11162 underlying document itself is changed and editability gets lost. The resolution is to 11163 set this WebView editable value to WebCore. This avoids the callback from WebCore to 11164 WebKit which was the main goal in r79953 to improve performance. 11165 11166 * WebView/WebView.mm: 11167 (-[WebView setEditable:]): 11168 (-[WebView isEditable]): 11169 111702011-03-19 Anton D'Auria <adauria@apple.com> 11171 11172 Reviewed by Alexey Proskuryakov. 11173 11174 ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin 11175 https://bugs.webkit.org/show_bug.cgi?id=56415 11176 11177 Use new ApplicationCache API to delete all cache for an origin. 11178 11179 * WebCoreSupport/WebApplicationCache.h: 11180 * WebCoreSupport/WebApplicationCache.mm: 11181 (+[WebApplicationCache deleteOrigin:]): 11182 111832011-03-17 Brady Eidson <beidson@apple.com> 11184 11185 Reviewed by Sam Weinig. 11186 11187 https://bugs.webkit.org/show_bug.cgi?id=56425 11188 More groundwork for WebKit2 IconDatabase 11189 11190 Update already-used function names: 11191 * Misc/WebIconDatabase.mm: 11192 (-[WebIconDatabase iconForURL:withSize:cache:]): 11193 (-[WebIconDatabase iconURLForURL:]): 11194 * WebView/WebView.mm: 11195 (-[WebView _dispatchDidReceiveIconFromWebFrame:]): 11196 111972011-03-18 Pavel Podivilov <podivilov@chromium.org> 11198 11199 Reviewed by Yury Semikhatsky. 11200 11201 Web Inspector: implement inspector session storage. 11202 https://bugs.webkit.org/show_bug.cgi?id=56643 11203 11204 * WebCoreSupport/WebInspectorClient.h: 11205 * WebCoreSupport/WebInspectorClient.mm: 11206 (WebInspectorClient::saveSessionSetting): 11207 (WebInspectorClient::loadSessionSetting): 11208 (WebInspectorFrontendClient::saveSessionSetting): 11209 (WebInspectorFrontendClient::loadSessionSetting): 11210 (-[WebInspectorWindowController inspectorClient]): 11211 112122011-03-17 Geoffrey Garen <ggaren@apple.com> 11213 11214 Reviewed by Oliver Hunt. 11215 11216 Fixed a leak seen on the buildbot. 11217 11218 * WebCoreSupport/WebInspectorClient.mm: 11219 (WebInspectorClient::openInspectorFrontend): Smart pointers are smart. 11220 112212011-03-16 Jeff Johnson <github@lapcatsoftware.com> 11222 11223 Reviewed by Alexey Proskuryakov. 11224 11225 Logic error in -[WebHTMLView close] 11226 https://bugs.webkit.org/show_bug.cgi?id=56445 11227 11228 Page is always nil at this point, because [self _webView] is nil, 11229 so the conditional code is never run. 11230 11231 * WebView/WebHTMLView.mm: 11232 (-[WebHTMLView close]): 11233 112342011-03-16 Chris Fleizach <cfleizach@apple.com> 11235 11236 Reviewed by Darin Adler. 11237 11238 WK2: Need to propagate enhanced accessibility flag from UI -> web process 11239 https://bugs.webkit.org/show_bug.cgi?id=56379 11240 11241 * WebView/WebFrame.mm: 11242 (-[WebFrame accessibilityRoot]): 11243 112442011-03-15 Oliver Hunt <oliver@apple.com> 11245 11246 Reviewed by Geoffrey Garen. 11247 11248 Make Structure creation require a JSGlobalData 11249 https://bugs.webkit.org/show_bug.cgi?id=56438 11250 11251 Mechanical change to make all Structure creation use a JSGlobalData& 11252 11253 * Plugins/Hosted/ProxyInstance.mm: 11254 (WebKit::ProxyRuntimeMethod::createStructure): 11255 * Plugins/Hosted/ProxyRuntimeObject.h: 11256 (WebKit::ProxyRuntimeObject::createStructure): 11257 112582011-03-15 Alexey Proskuryakov <ap@apple.com> 11259 11260 Forgot to save a modification to this file when committing. 11261 11262 * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header. 11263 112642011-03-15 Alexey Proskuryakov <ap@apple.com> 11265 11266 Reviewed by Darin Adler. 11267 11268 REGRESSION (WebKit2): keygen element doesn't work 11269 https://bugs.webkit.org/show_bug.cgi?id=56402 11270 <rdar://problem/9006545> 11271 11272 * WebCoreSupport/WebKeyGenerator.h: 11273 * WebCoreSupport/WebKeyGenerator.m: Removed. 11274 * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m. 11275 (+[WebKeyGenerator sharedGenerator]): 11276 (toWebCertificateParseResult): 11277 WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping 11278 this misnamed and misplaced code for now. 11279 11280 * WebCoreSupport/WebPlatformStrategies.h: 11281 * WebCoreSupport/WebPlatformStrategies.mm: 11282 (WebPlatformStrategies::keygenMenuItem512): 11283 (WebPlatformStrategies::keygenMenuItem1024): 11284 (WebPlatformStrategies::keygenMenuItem2048): 11285 (WebPlatformStrategies::keygenKeychainItemName): 11286 Added strings used by keygen. 11287 11288 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore 11289 pointer to a function used by keygen. 11290 11291 * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily 11292 initialized now. 11293 112942011-03-15 Beth Dakin <bdakin@apple.com> 11295 11296 Reviewed by Simon Fraser. 11297 11298 WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6% 11299 11300 New WebKitystemInterface function to force the scrollbars to flash 11301 * WebCoreSupport/WebSystemInterface.mm: 11302 (InitWebCoreSystemInterface): 11303 113042011-03-15 Ilya Sherman <isherman@chromium.org> 11305 11306 Reviewed by Tony Chang. 11307 11308 Autofilled form elements are assigned fixed background color but not text color 11309 https://bugs.webkit.org/show_bug.cgi?id=48382 11310 11311 * DOM/WebDOMOperations.mm: 11312 (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper). 11313 * DOM/WebDOMOperationsPrivate.h: 11314 113152011-03-15 Adam Roben <aroben@apple.com> 11316 11317 Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin 11318 11319 Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in 11320 WebStorageTrackerClient::dispatchDidModifyOrigin 11321 11322 Reviewed by Antti Koivisto. 11323 11324 * Storage/WebStorageTrackerClient.mm: 11325 (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed 11326 to us by dispatchDidModifyOrigin. 11327 (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an 11328 unnecessary cast. 11329 113302011-03-15 Kevin Ollivier <kevino@theolliviers.com> 11331 11332 Reviewed by Darin Adler. 11333 11334 Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export 11335 info into the headers rather than in export symbol definition files, but disable it on 11336 all platforms initially so we can deal with port build issues one port at a time. 11337 11338 https://bugs.webkit.org/show_bug.cgi?id=27551 11339 11340 * WebKitPrefix.h: 11341 113422011-03-14 Brady Eidson <beidson@apple.com> 11343 11344 Reviewed by Anders Carlsson. 11345 11346 https://bugs.webkit.org/show_bug.cgi?id=56320 11347 Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()" 11348 11349 * History/WebHistoryItem.mm: 11350 (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant. 11351 113522011-03-13 Pratik Solanki <psolanki@apple.com> 11353 11354 Reviewed by Brady Eidson. 11355 11356 Make adjustMIMETypeIfNecessary use CFNetwork directly 11357 https://bugs.webkit.org/show_bug.cgi?id=55912 11358 11359 * WebCoreSupport/WebSystemInterface.mm: 11360 (InitWebCoreSystemInterface): Support for new WKSI functions. 11361 113622011-03-12 Mark Rowe <mrowe@apple.com> 11363 11364 Fix the 32-bit build. 11365 11366 * Carbon/CarbonWindowAdapter.mm: 11367 (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier. 11368 (-[CarbonWindowAdapter _carbonWindowClass]): Ditto. 11369 113702011-03-11 Brady Eidson <beidson@apple.com> 11371 11372 Reviewed by Anders Carlsson 11373 11374 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216 11375 Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation. 11376 11377 * Misc/WebIconDatabase.mm: 11378 (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase(). 11379 (-[WebIconDatabase _startUpIconDatabase]): Ditto. 11380 (importToWebCoreFormat): 11381 113822011-03-11 Anton D'Auria <adauria@apple.com> 11383 11384 Reviewed and landed by Brady Eidson. 11385 11386 https://bugs.webkit.org/show_bug.cgi?id=51878 11387 Add WebKit1 API to view and delete local storage 11388 11389 * Storage/WebStorageManager.mm: Added. 11390 (+[WebStorageManager sharedWebStorageManager]): 11391 (-[WebStorageManager origins]): 11392 (-[WebStorageManager deleteAllOrigins]): 11393 (-[WebStorageManager deleteOrigin:]): 11394 (-[WebStorageManager syncLocalStorage]): 11395 (-[WebStorageManager syncFileSystemAndTrackerDatabase]): 11396 (storageDirectoryPath): 11397 (WebKitInitializeStorageIfNecessary): 11398 * Storage/WebStorageManagerInternal.h: Added. 11399 * Storage/WebStorageManagerPrivate.h: Added. 11400 * Storage/WebStorageTrackerClient.h: Added. 11401 * Storage/WebStorageTrackerClient.mm: Added. 11402 (WebStorageTrackerClient::sharedWebStorageTrackerClient): 11403 (WebStorageTrackerClient::WebStorageTrackerClient): 11404 (WebStorageTrackerClient::~WebStorageTrackerClient): 11405 (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): 11406 (WebStorageTrackerClient::dispatchDidModifyOrigin): 11407 * WebCoreSupport/WebSecurityOrigin.mm: 11408 (-[WebSecurityOrigin protocol]): 11409 (-[WebSecurityOrigin host]): 11410 (-[WebSecurityOrigin databaseIdentifier]): 11411 (-[WebSecurityOrigin domain]): 11412 (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]): 11413 * WebCoreSupport/WebSecurityOriginPrivate.h: 11414 * WebKit.exp: 11415 * WebView/WebView.mm: 11416 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 11417 114182011-03-10 Anders Carlsson <andersca@apple.com> 11419 11420 Reviewed by Sam Weinig. 11421 11422 <rdar://problem/9117047> 11423 Don't paint more than 60 times per second even when scrolling 11424 11425 * WebView/WebClipView.mm: 11426 (-[WebClipView _immediateScrollToPoint:]): 11427 114282011-03-09 Matthew Delaney <mdelaney@apple.com> 11429 11430 Reviewed by Simon Fraser. 11431 11432 Plumb through settings for accelerated drawing for canvas 11433 https://bugs.webkit.org/show_bug.cgi?id=56039 11434 11435 * WebView/WebPreferenceKeysPrivate.h: 11436 * WebView/WebPreferences.mm: 11437 * WebView/WebPreferencesPrivate.h: 11438 114392011-03-10 Ryosuke Niwa <rniwa@webkit.org> 11440 11441 Reviewed by Tony Chang. 11442 11443 VisiblePosition's next and previous should take an enum instead of a boolean 11444 https://bugs.webkit.org/show_bug.cgi?id=56135 11445 11446 SelectionController::isAll now takes EditingBoundaryCrossingRule instead of 11447 StayInEditableContent. 11448 11449 * WebView/WebView.mm: 11450 (-[WebView _selectionIsAll]): 11451 114522011-03-09 Jessie Berlin <jberlin@apple.com> 11453 11454 Reviewed by Adam Roben. 11455 11456 Use the Cookie Storage from the Private Browsing Storage Session directly 11457 https://bugs.webkit.org/show_bug.cgi?id=55986 11458 11459 * WebCoreSupport/WebSystemInterface.mm: 11460 (InitWebCoreSystemInterface): 11461 114622011-03-08 Darin Adler <darin@apple.com> 11463 11464 Reviewed by Timothy Hatcher. 11465 11466 Promote a method used outside WebKit from internal to private 11467 https://bugs.webkit.org/show_bug.cgi?id=55949 11468 11469 * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration. 11470 Minor tweak, not directly related to the rest of this patch. 11471 11472 * WebView/WebFrame.mm: 11473 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved 11474 this method from the internal category into the private category. 11475 Streamlined the code a bit. 11476 11477 * WebView/WebFrameInternal.h: Removed _computePageRects method. 11478 * WebView/WebFramePrivate.h: Added _computePageRects method. 11479 114802011-03-07 Ryosuke Niwa <rniwa@webkit.org> 11481 11482 Reviewed by Darin Adler. 11483 11484 selectionHasStyle and selectionStartHasStyle should use EditingStyle 11485 https://bugs.webkit.org/show_bug.cgi?id=55902 11486 11487 selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration. 11488 11489 * WebView/WebHTMLView.mm: Removed unused selectionHasStyle. 11490 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle. 11491 114922011-03-07 Dan Bernstein <mitz@apple.com> 11493 11494 LLVM Compiler build fix. 11495 11496 * WebCoreSupport/WebEditorClient.mm: 11497 (WebEditorClient::checkGrammarOfString): 11498 114992011-03-07 Chris Fleizach <cfleizach@apple.com> 11500 11501 Reviewed by Beth Dakin. 11502 11503 AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not 11504 https://bugs.webkit.org/show_bug.cgi?id=55706 11505 11506 Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object 11507 returns the scroll bar objects). 11508 Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView 11509 will expect that as its child, instead of the WebCore ScrollView object. 11510 11511 * WebView/WebDynamicScrollBarsView.mm: 11512 (-[WebDynamicScrollBarsView accessibilityIsIgnored]): 11513 * WebView/WebFrame.mm: 11514 (-[WebFrame accessibilityRoot]): 11515 115162011-03-07 Sam Weinig <sam@webkit.org> 11517 11518 Reviewed by Anders Carlsson. 11519 11520 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse 11521 https://bugs.webkit.org/show_bug.cgi?id=55827 11522 11523 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse 11524 and pass the entire response, instead of just the MIMEType. 11525 11526 * WebCoreSupport/WebFrameLoaderClient.h: 11527 * WebCoreSupport/WebFrameLoaderClient.mm: 11528 (WebFrameLoaderClient::dispatchDecidePolicyForResponse): 11529 115302011-03-06 Dan Bernstein <mitz@apple.com> 11531 11532 LLVM Compiler build fix. 11533 11534 * DOM/WebDOMOperations.mm: 11535 (-[DOMHTMLInputElement _setValueForUser:]): 11536 115372011-03-06 Jessie Berlin <jberlin@apple.com> 11538 11539 Reviewed by Sam Weinig. 11540 11541 WebKit2: Use CFNetwork Sessions API. 11542 https://bugs.webkit.org/show_bug.cgi?id=55435. 11543 11544 When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the 11545 Private Browsing Storage Session. 11546 11547 * WebCoreSupport/WebSystemInterface.mm: 11548 (InitWebCoreSystemInterface): 11549 Add support for using the new WKSI functions in WebCore. 11550 115512011-03-05 Ilya Sherman <isherman@chromium.org> 11552 11553 Reviewed by Darin Adler. 11554 11555 HTMLInputElement::setValue() should schedule change event when the element is focused 11556 In service of https://code.google.com/p/chromium/issues/detail?id=42716 11557 https://bugs.webkit.org/show_bug.cgi?id=53160 11558 11559 * DOM/WebDOMOperations.mm: 11560 (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests 11561 * DOM/WebDOMOperationsPrivate.h: 11562 * WebView/WebViewInternal.h: 11563 115642011-03-04 Jia Pu <jpu@apple.com> 11565 11566 Reviewed by Darin Adler. 11567 11568 On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe. 11569 https://bugs.webkit.org/show_bug.cgi?id=55717 11570 <rdar://problem/9018127> 11571 11572 With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel() 11573 is already in window coordinate. We don't need to do further conversion anymore. 11574 11575 * WebCoreSupport/WebEditorClient.mm: 11576 (WebEditorClient::showCorrectionPanel): 11577 115782011-03-04 Jessie Berlin <jberlin@apple.com> 11579 11580 Reviewed by Maciej Stachowiak. 11581 11582 WebKit2: Use CFNetwork Sessions API. 11583 https://bugs.webkit.org/show_bug.cgi?id=55435. 11584 11585 When Private Browsing is enabled, get the cached url response from the cache associated with 11586 the Private Browsing Storage Session. 11587 11588 * WebView/WebView.mm: 11589 (-[WebView _cachedResponseForURL:]): 11590 115912011-03-03 Anders Carlsson <andersca@apple.com> 11592 11593 Reviewed by Sam Weinig. 11594 11595 Get rid of Page::globalHistoryItem 11596 https://bugs.webkit.org/show_bug.cgi?id=55738 11597 11598 * WebCoreSupport/WebFrameLoaderClient.h: 11599 * WebCoreSupport/WebFrameLoaderClient.mm: 11600 (WebFrameLoaderClient::updateGlobalHistoryItemForPage): 11601 Get the current history item and update it using -[WebView _setGlobalHistoryItem:]. 11602 11603 * WebView/WebView.mm: 11604 (-[WebView _globalHistoryItem]): 11605 (-[WebView _setGlobalHistoryItem:]): 11606 Set _globalHistoryItem ivar. 11607 11608 * WebView/WebViewData.h: 11609 * WebView/WebViewData.mm: 11610 Add _globalHistoryItem ivar. 11611 116122011-03-03 Brady Eidson <beidson@apple.com> 11613 11614 Reviewed by Darin Adler. 11615 11616 https://bugs.webkit.org/show_bug.cgi?id=55721 11617 Global IconDatabase should be returned by reference, not as a pointer 11618 11619 * Misc/WebCoreStatistics.mm: 11620 (+[WebCoreStatistics iconPageURLMappingCount]): 11621 (+[WebCoreStatistics iconRetainedPageURLCount]): 11622 (+[WebCoreStatistics iconRecordCount]): 11623 (+[WebCoreStatistics iconsWithDataCount]): 11624 * Misc/WebIconDatabase.mm: 11625 (-[WebIconDatabase init]): 11626 (-[WebIconDatabase iconForURL:withSize:cache:]): 11627 (-[WebIconDatabase iconURLForURL:]): 11628 (-[WebIconDatabase defaultIconWithSize:]): 11629 (-[WebIconDatabase retainIconForURL:]): 11630 (-[WebIconDatabase releaseIconForURL:]): 11631 (-[WebIconDatabase isEnabled]): 11632 (-[WebIconDatabase setEnabled:]): 11633 (-[WebIconDatabase removeAllIcons]): 11634 (+[WebIconDatabase _checkIntegrityBeforeOpening]): 11635 (-[WebIconDatabase _startUpIconDatabase]): 11636 (-[WebIconDatabase _applicationWillTerminate:]): 11637 (-[WebIconDatabase _resetCachedWebPreferences:]): 11638 (importToWebCoreFormat): 11639 * WebView/WebView.mm: 11640 (-[WebView _dispatchDidReceiveIconFromWebFrame:]): 11641 116422011-03-03 Jessie Berlin <jberlin@apple.com> 11643 11644 Reviewed by Adam Roben. 11645 11646 WebKit2: Use CFNetwork Sessions API. 11647 https://bugs.webkit.org/show_bug.cgi?id=55435. 11648 11649 Set the Private Browsing Storage Session on requests when Private Browsing is enabled. 11650 11651 * WebCoreSupport/WebSystemInterface.mm: 11652 (InitWebCoreSystemInterface): 11653 Support using WKCopyRequestWithStorageSession in WebCore. 11654 116552011-03-02 Alexey Proskuryakov <ap@apple.com> 11656 11657 Reviewed by Darin Adler. 11658 11659 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access 11660 https://bugs.webkit.org/show_bug.cgi?id=55633 11661 <rdar://problem/8963023> 11662 11663 * WebCoreSupport/WebChromeClient.h: 11664 * WebCoreSupport/WebChromeClient.mm: 11665 Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode(). 11666 11667 * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]): 11668 Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't 11669 require both bits to be set. The rest of the comment might be wrong too, but I'm not sure, 11670 so I've preserved it. 11671 116722011-03-02 Jessie Berlin <jberlin@apple.com> 11673 11674 Rubber-stamped by Dan Bernstein. 11675 11676 Fix crashes in private browsing tests in WK1 on Snow Leopard. 11677 11678 * WebCoreSupport/WebSystemInterface.mm: 11679 (InitWebCoreSystemInterface): 11680 Put the INIT call for wkCreatePrivateStorageSession outside of the 11681 #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD) 11682 guards. 11683 116842011-03-02 Jessie Berlin <jberlin@apple.com> 11685 11686 Reviewed by Adam Roben. 11687 11688 WebKit2: Use CFNetwork Sessions API. 11689 https://bugs.webkit.org/show_bug.cgi?id=55435. 11690 11691 Add the ability to create a Private Browsing Storage Session. 11692 11693 * WebCoreSupport/WebSystemInterface.mm: 11694 (InitWebCoreSystemInterface): 11695 Support calling wkCreatePrivateStorageSession from WebCore. 11696 116972011-03-02 Daniel Cheng <dcheng@chromium.org> 11698 11699 Reviewed by David Levin. 11700 11701 Add feature define for data transfer items 11702 https://bugs.webkit.org/show_bug.cgi?id=55510 11703 11704 * Configurations/FeatureDefines.xcconfig: 11705 117062011-03-02 Sam Weinig <sam@webkit.org> 11707 11708 Reviewed by Anders Carlsson. 11709 11710 Fix remaining localization issues by piping all localized strings through WebCore's 11711 localization bottleneck. 11712 <rdar://problem/8728860> 11713 11714 * DefaultDelegates/WebDefaultContextMenuDelegate.mm: 11715 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): 11716 * Misc/WebKitErrors.m: 11717 * Misc/WebLocalizableStringsInternal.h: Added. 11718 * Misc/WebLocalizableStringsInternal.mm: Added. 11719 (WebLocalizedStringInternal): 11720 * Panels/WebAuthenticationPanel.m: 11721 (-[WebAuthenticationPanel setUpForChallenge:]): 11722 * Plugins/Hosted/NetscapePluginHostManager.mm: 11723 (WebKit::NetscapePluginHostManager::spawnPluginHost): 11724 * WebCoreSupport/WebEditorClient.mm: 11725 (undoNameForEditAction): 11726 * WebCoreSupport/WebInspectorClient.mm: 11727 (WebInspectorFrontendClient::updateWindowTitle): 11728 (-[WebInspectorWindowController validateUserInterfaceItem:]): 11729 * WebCoreSupport/WebKeyGenerator.m: 11730 (-[WebKeyGenerator strengthMenuItemTitles]): 11731 (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): 11732 * WebCoreSupport/WebPlatformStrategies.mm: 11733 * WebView/WebHTMLView.mm: 11734 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): 11735 * WebView/WebPDFView.mm: 11736 (-[WebPDFView menuForEvent:]): 11737 117382011-03-01 Brian Weinstein <bweinstein@apple.com> 11739 11740 Reviewed by Adam Roben. 11741 11742 Part of WebKit2: Need a way to send notifications to client when cookies change 11743 https://bugs.webkit.org/show_bug.cgi?id=55427 11744 <rdar://problem/9056027> 11745 11746 Add stubs for CookiesStrategy on Mac WebKit1. 11747 11748 * WebCoreSupport/WebPlatformStrategies.h: 11749 * WebCoreSupport/WebPlatformStrategies.mm: 11750 (WebPlatformStrategies::createCookiesStrategy): 11751 (WebPlatformStrategies::notifyCookiesChanged): 11752 117532011-03-01 Philippe Normand <pnormand@igalia.com> 11754 11755 Reviewed by Eric Carlson. 11756 11757 [GStreamer] support in mac video fullscreen controller 11758 https://bugs.webkit.org/show_bug.cgi?id=52280 11759 11760 Factored the code to configure the video overlay in a new private 11761 method of the controller and added GStreamer support to it. 11762 11763 * WebView/WebVideoFullscreenController.h: 11764 * WebView/WebVideoFullscreenController.mm: 11765 (-[WebVideoFullscreenController setupVideoOverlay:]): 11766 (-[WebVideoFullscreenController windowDidLoad]): 11767 (-[WebVideoFullscreenController setMediaElement:WebCore::]): 11768 (-[WebVideoFullscreenController windowDidExitFullscreen]): 11769 117702011-02-23 Joseph Pecoraro <joepeck@webkit.org> 11771 11772 Reviewed by Timothy Hatcher. 11773 11774 All Console Messages should be passed to ChromeClients. 11775 https://bugs.webkit.org/show_bug.cgi?id=54926 11776 11777 Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:, 11778 which supersedes -webView:addMessageToConsole if it exists. The new delegate 11779 does not filter to only JavaScript originated console messages. The old 11780 delegate is left around for clients that expect filtered messages, like 11781 DashCode and older versions of Safari. 11782 11783 The dictionary message passed to the delegate now includes more information 11784 about the message source, type, and level. 11785 11786 * WebCoreSupport/WebChromeClient.mm: 11787 (stringForMessageSource): 11788 (stringForMessageType): 11789 (stringForMessageLevel): 11790 (WebChromeClient::addMessageToConsole): 11791 * WebView/WebUIDelegatePrivate.h: 11792 117932011-03-01 Levi Weintraub <leviw@chromium.org> 11794 11795 Reviewed by Ryosuke Niwa. 11796 11797 Stop instantiating legacy editing Positions in VisiblePosition 11798 https://bugs.webkit.org/show_bug.cgi?id=52919 11799 11800 Changing usage of legacy VisiblePosition constructor. Since we were dealing 11801 with positions from DOM Ranges, we're guaranteed a parent-anchored position. 11802 11803 * WebView/WebFrame.mm: 11804 (-[WebFrame _caretRectAtPosition:affinity:]): 11805 * WebView/WebFrameInternal.h: 11806 * WebView/WebTextCompletionController.mm: 11807 (-[WebTextCompletionController doCompletion]): 11808 118092011-03-01 Sam Weinig <sam@webkit.org> 11810 11811 Reviewed by Timothy Hatcher. 11812 11813 WebKit2 needs to be made localizable 11814 https://bugs.webkit.org/show_bug.cgi?id=55483 11815 11816 * WebCoreSupport/WebPlatformStrategies.mm: 11817 Use WebCore's localizedString function instead of WebLocalizableStrings 11818 since WebCore is now responsible for localization. 11819 118202011-02-25 Steve Block <steveblock@google.com> 11821 11822 Reviewed by Jeremy Orlow. 11823 11824 Bridge.h should not include BridgeJSC.h 11825 https://bugs.webkit.org/show_bug.cgi?id=55212 11826 11827 Include BridgeJSC.h directly instead. 11828 11829 * Plugins/Hosted/ProxyInstance.h: 11830 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 11831 118322011-02-28 Chang Shu <cshu@webkit.org> 11833 11834 Reviewed by Ryosuke Niwa. 11835 11836 Remove the support of Frame::isContentEditable and its dependencies. 11837 https://bugs.webkit.org/show_bug.cgi?id=54292 11838 11839 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode. 11840 11841 * WebCoreSupport/WebEditorClient.h: 11842 * WebCoreSupport/WebEditorClient.mm: 11843 * WebView/WebView.mm: 11844 (-[WebView setEditable:]): 11845 (-[WebView isEditable]): 11846 * WebView/WebViewData.h: 11847 118482011-02-28 Oliver Hunt <oliver@apple.com> 11849 11850 Reviewed by Gavin Barraclough. 11851 11852 Make ScopeChainNode GC allocated 11853 https://bugs.webkit.org/show_bug.cgi?id=55283 11854 11855 More updates for the absence of the ScopeChain class 11856 11857 * WebView/WebScriptDebugDelegate.mm: 11858 (-[WebScriptCallFrame scopeChain]): 11859 118602011-02-26 Vsevolod Vlasov <vsevik@chromium.org> 11861 11862 Reviewed by Pavel Feldman. 11863 11864 DumpRenderTree should reset frame opener between tests. 11865 https://bugs.webkit.org/show_bug.cgi?id=54874 11866 11867 Added clearOpener method to WebFramePrivate. 11868 11869 * WebView/WebFrame.mm: 11870 (-[WebFrame _clearOpener]): 11871 * WebView/WebFramePrivate.h: 11872 118732011-02-26 Sheriff Bot <webkit.review.bot@gmail.com> 11874 11875 Unreviewed, rolling out r79764. 11876 http://trac.webkit.org/changeset/79764 11877 https://bugs.webkit.org/show_bug.cgi?id=55295 11878 11879 "broke Chromium builds" (Requested by rniwa on #webkit). 11880 11881 * WebView/WebFrame.mm: 11882 * WebView/WebFramePrivate.h: 11883 118842011-02-26 Yongjun Zhang <yongjun_zhang@apple.com> 11885 11886 Reviewed by David Kilzer. 11887 11888 https://bugs.webkit.org/show_bug.cgi?id=48781 11889 11890 Add a resource load delegate method to query if WebCore should paint the default broken image for failed images. 11891 11892 Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore 11893 should paint the default broken image when an image fails to load or decode. The method also passes the 11894 URL of the failed image. 11895 11896 * WebCoreSupport/WebFrameLoaderClient.h: 11897 * WebCoreSupport/WebFrameLoaderClient.mm: 11898 (WebFrameLoaderClient::shouldPaintBrokenImage): 11899 * WebView/WebDelegateImplementationCaching.h: 11900 * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object. 11901 (CallResourceLoadDelegateReturningBoolean): 11902 * WebView/WebResourceLoadDelegatePrivate.h: 11903 * WebView/WebView.mm: 11904 (-[WebView _cacheResourceLoadDelegateImplementations]): 11905 119062011-02-26 Vsevolod Vlasov <vsevik@chromium.org> 11907 11908 Reviewed by Pavel Feldman. 11909 11910 DumpRenderTree should reset frame opener between tests. 11911 https://bugs.webkit.org/show_bug.cgi?id=54874 11912 11913 Added clearOpener method to WebFramePrivate. 11914 11915 * WebView/WebFrame.mm: 11916 (-[WebFrame _clearOpener]): 11917 * WebView/WebFramePrivate.h: 11918 119192011-02-25 Mark Rowe <mrowe@apple.com> 11920 11921 <rdar://problem/8902546> Build fix. 11922 11923 * Misc/QuickDrawCompatibility.h: 11924 119252011-02-24 Anders Carlsson <andersca@apple.com> 11926 11927 Fix clang build. 11928 11929 * WebCoreSupport/WebKeyGenerator.m: 11930 (toWebCertificateParseResult): 11931 (-[WebKeyGenerator addCertificatesToKeychainFromData:]): 11932 * WebView/WebTextCompletionController.mm: 11933 119342011-02-24 Peter Kasting <pkasting@google.com> 11935 11936 Reviewed by Eric Seidel. 11937 11938 Drop the "U; " encryption level from the User Agent string. 11939 https://bugs.webkit.org/show_bug.cgi?id=54566 11940 11941 * WebView/WebView.mm: 11942 (+[WebView _standardUserAgentWithApplicationName:]): 11943 119442011-02-24 Andrew Wilson <atwilson@chromium.org> 11945 11946 Unreviewed, rolling out r79570. 11947 http://trac.webkit.org/changeset/79570 11948 https://bugs.webkit.org/show_bug.cgi?id=54874 11949 11950 Breaks chromium build because glue/mocks/mock_web_frame.h/cc 11951 was not updated 11952 11953 * WebView/WebFrame.mm: 11954 * WebView/WebFramePrivate.h: 11955 119562011-02-24 Vsevolod Vlasov <vsevik@chromium.org> 11957 11958 Reviewed by Alexey Proskuryakov. 11959 11960 DumpRenderTree should reset frame opener between tests. 11961 https://bugs.webkit.org/show_bug.cgi?id=54874 11962 11963 Added clearOpener method to WebFramePrivate. 11964 11965 * WebView/WebFrame.mm: 11966 (-[WebFrame _clearOpener]): 11967 * WebView/WebFramePrivate.h: 11968 119692011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com> 11970 11971 Reviewed by Alexey Proskuryakov. 11972 11973 Drop the language tag part from the User Agent string 11974 https://bugs.webkit.org/show_bug.cgi?id=54560 11975 11976 * WebView/WebView.mm: 11977 (+[WebView _standardUserAgentWithApplicationName:]): Drop the 11978 language tag part. 11979 119802011-02-22 Brady Eidson <beidson@apple.com> 11981 11982 Reviewed by Anders Carlsson. 11983 11984 Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514 11985 API to view and delete Application Cache data by origin. 11986 11987 * WebCoreSupport/WebApplicationCache.mm: 11988 (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself. 11989 119902011-02-17 Ryosuke Niwa <rniwa@webkit.org> 11991 11992 Reviewed by Kent Tamura. 11993 11994 Rename Position::node() to Position::deprecatedNode() 11995 https://bugs.webkit.org/show_bug.cgi?id=54622 11996 11997 * WebView/WebFrame.mm: 11998 (-[WebFrame _smartDeleteRangeForProposedRange:]): 11999 120002011-02-17 Ryosuke Niwa <rniwa@webkit.org> 12001 12002 Reviewed by Kent Tamura. 12003 12004 Rename Position::node() to Position::deprecatedNode() 12005 https://bugs.webkit.org/show_bug.cgi?id=54622 12006 12007 Done the rename. 12008 12009 * WebView/WebFrame.mm: 12010 (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored, 12011 use containerNode() and offsetInContainerNode() instead of deprecated member functions. 12012 120132011-02-18 Gavin Barraclough <barraclough@apple.com> 12014 12015 Reviewed by Sam Weinig. 12016 12017 Bug 54786 - Devirtualize JSCell::classInfo() 12018 12019 Instead of making a virtual function call, add a pointer to the ClassInfo 12020 onto Structure. 12021 12022 This removes a virtual function call, and paves the way towards removing all 12023 the createStructure methods, and StructureFlags/AnonymousSlotCount properties 12024 (these should be able to move onto ClassInfo). 12025 12026 Calls to Structure::create must now pass a pointer to the ClassInfo for the 12027 structure. All objects now have a ClassInfo pointer, non-object cell types 12028 still do not. 12029 12030 Changes are most mechanical, involving three steps: 12031 * Remove virtual classInfo() methods. 12032 * Add &s_info parameter to calls to Structure::create. 12033 * Rename ClassInfo static members on classes from 'info' to 's_info', 12034 for consistency. 12035 12036 * Plugins/Hosted/ProxyInstance.mm: 12037 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod): 12038 (WebKit::ProxyRuntimeMethod::createStructure): 12039 * Plugins/Hosted/ProxyRuntimeObject.h: 12040 (WebKit::ProxyRuntimeObject::createStructure): 12041 * Plugins/Hosted/ProxyRuntimeObject.mm: 12042 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject): 12043 * WebView/WebView.mm: 12044 (aeDescFromJSValue): 12045 120462011-02-19 Brian Ryner <bryner@chromium.org> 12047 12048 Reviewed by Adam Barth. 12049 12050 Add missing #include of DocumentLoader.h, needed since the transitive 12051 include through Document.h is removed. 12052 https://bugs.webkit.org/show_bug.cgi?id=50489 12053 12054 * WebView/WebFrame.mm: 12055 120562011-02-19 Charlie Reis <creis@chromium.org> 12057 12058 Reviewed by Mihai Parparita. 12059 12060 Ensure loading has stopped in HistoryController::goToItem 12061 https://bugs.webkit.org/show_bug.cgi?id=54517 12062 12063 Add a FrameLoaderClient callback for whether to stop loading before goToItem. 12064 12065 Test: http/tests/navigation/forward-to-fragment-fires-onload.html 12066 12067 * WebCoreSupport/WebFrameLoaderClient.mm: 12068 (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added. 12069 * WebCoreSupport/WebFrameLoaderClient.h: 12070 120712011-02-16 David Hyatt <hyatt@apple.com> 12072 12073 Reviewed by Dan Bernstein. 12074 12075 https://bugs.webkit.org/show_bug.cgi?id=54244 12076 12077 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding 12078 hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats. 12079 12080 The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have 12081 been changed as well. 12082 12083 In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height). 12084 12085 Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting. 12086 12087 Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes 12088 still have a precise floating point position. 12089 12090 Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already 12091 be rounding justification spacing in their font code. 12092 12093 Many layout test results change on Mac, since rounding hacks were used there and are now gone. 12094 12095 * Misc/WebKitNSStringExtras.mm: 12096 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): 12097 (-[NSString _web_widthWithFont:]): 12098 120992011-02-10 Luiz Agostini <luiz.agostini@openbossa.org> 12100 12101 Reviewed by Adam Roben. 12102 12103 HTML5 <details> and <summary>: localized text 12104 https://bugs.webkit.org/show_bug.cgi?id=54260 12105 12106 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to 12107 provide the default label to be used by a <details> tag that has no <summary> child. 12108 12109 * WebCoreSupport/WebPlatformStrategies.h: 12110 * WebCoreSupport/WebPlatformStrategies.mm: 12111 (WebPlatformStrategies::defaultDetailsSummaryText): 12112 121132011-02-16 Matthew Delaney <mdelaney@apple.com> 12114 12115 Reviewed by Simon Fraser. 12116 12117 Allow acceleratesDrawing for WebKit2 12118 https://bugs.webkit.org/show_bug.cgi?id=54511 12119 12120 Plumb through preference for accelerated drawing. 12121 12122 * WebView/WebPreferenceKeysPrivate.h: 12123 * WebView/WebPreferences.mm: 12124 (+[WebPreferences initialize]): 12125 (-[WebPreferences acceleratedDrawingEnabled]): 12126 (-[WebPreferences setAcceleratedDrawingEnabled:]): 12127 * WebView/WebPreferencesPrivate.h: 12128 121292011-02-15 David Kilzer <ddkilzer@apple.com> 12130 12131 <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h 12132 12133 Reviewed by Darin Adler. 12134 12135 * WebView/WebDynamicScrollBarsView.h: 12136 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed 12137 declaration. 12138 * WebView/WebDynamicScrollBarsView.mm: 12139 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved 12140 implementation into correct category. 12141 * WebView/WebDynamicScrollBarsViewInternal.h: 12142 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added 12143 declaration. 12144 * WebView/WebHTMLView.mm: Included 12145 WebDynamicScrollBarsViewInternal.h instead of 12146 WebDynamicScrollBarsView.h. 12147 121482011-02-14 Oliver Hunt <oliver@apple.com> 12149 12150 Reviewed by Gavin Barraclough and Geoff Garen. 12151 12152 Refactor handles and weak pointers to become nicer and more automatic 12153 https://bugs.webkit.org/show_bug.cgi?id=54415 12154 12155 Update to use Global<> instead of ProtectedPtr, and refactored slightly 12156 to get global data to places it's needed for when we're assigning to 12157 Global<>s 12158 12159 * ForwardingHeaders/collector/handles/Global.h: Added. 12160 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 12161 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 12162 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): 12163 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): 12164 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): 12165 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): 12166 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject): 12167 (WebKit::NetscapePluginInstanceProxy::evaluate): 12168 (WebKit::NetscapePluginInstanceProxy::invoke): 12169 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 12170 (WebKit::NetscapePluginInstanceProxy::construct): 12171 (WebKit::NetscapePluginInstanceProxy::addValueToArray): 12172 * WebView/WebScriptDebugger.h: 12173 * WebView/WebScriptDebugger.mm: 12174 (WebScriptDebugger::WebScriptDebugger): 12175 121762011-02-15 Jia Pu <jpu@apple.com> 12177 12178 Reviewed by Darin Adler. 12179 12180 Autocorrection should respect undo. 12181 https://bugs.webkit.org/show_bug.cgi?id=52221 12182 <rdar://problem/8663399> 12183 12184 Please see WebCore/ChangeLog for detailed description. 12185 12186 * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient. 12187 12188 * WebCoreSupport/WebEditorClient.mm: 12189 (WebEditorClient::recordAutocorrectionResponse): Ditto. 12190 12191 * WebView/WebFrame.mm: 12192 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): 12193 Adopted new signature of ReplaceSelectionCommand::create(). 12194 121952011-02-15 David Kilzer <ddkilzer@apple.com> 12196 12197 <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll 12198 12199 Reviewed by Darin Adler. 12200 12201 * WebView/WebDynamicScrollBarsView.h: 12202 * WebView/WebDynamicScrollBarsView.mm: 12203 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from 12204 -inProgramaticScroll. 12205 * WebView/WebHTMLView.mm: 12206 (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name. 12207 122082011-02-15 Kenneth Russell <kbr@google.com> 12209 12210 Reviewed by Darin Fisher. 12211 12212 Allow controlling minimum DOMTimer interval on a per-page basis 12213 https://bugs.webkit.org/show_bug.cgi?id=54312 12214 12215 Added needed methods to implement LayoutTestController's new 12216 setMinimumTimerInterval method. 12217 12218 * WebView/WebView.mm: 12219 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 12220 (+[WebView _defaultMinimumTimerInterval]): 12221 (-[WebView _setMinimumTimerInterval:]): 12222 * WebView/WebViewPrivate.h: 12223 122242011-02-11 Geoffrey Garen <ggaren@apple.com> 12225 12226 Reviewed by Oliver Hunt. 12227 12228 A little more encapsulation for the heap: Removed CollectorHeapIterator 12229 https://bugs.webkit.org/show_bug.cgi?id=54298 12230 12231 * Misc/WebCoreStatistics.mm: 12232 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): 12233 (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef. 12234 122352011-02-10 Nate Chapin <japhet@chromium.org> 12236 12237 Reviewed by Adam Barth. 12238 12239 Update calls to DocumentWriter. 12240 https://bugs.webkit.org/show_bug.cgi?id=50489 12241 12242 * WebView/WebFrame.mm: 12243 (-[WebFrame _canProvideDocumentSource]): 12244 122452011-02-10 Chris Fleizach <cfleizach@apple.com> 12246 12247 Reviewed by Anders Carlsson. 12248 12249 AX: AX needs to stop using WebCoreViewFactory 12250 https://bugs.webkit.org/show_bug.cgi?id=54153 12251 12252 * WebCoreSupport/WebSystemInterface.mm: 12253 (InitWebCoreSystemInterface): 12254 122552011-02-10 Peter Varga <pvarga@webkit.org> 12256 12257 Reviewed by Csaba Osztrogonác. 12258 12259 Remove PCRE source from trunk 12260 https://bugs.webkit.org/show_bug.cgi?id=54188 12261 12262 * ForwardingHeaders/pcre/pcre.h: Removed. 12263 122642011-02-09 Pavel Feldman <pfeldman@chromium.org> 12265 12266 Reviewed by Yury Semikhatsky. 12267 12268 Web Inspector: follow up on InspectorAgent split - 12269 removing unnecessary methods from InspectorController. 12270 https://bugs.webkit.org/show_bug.cgi?id=54093 12271 12272 * WebInspector/WebInspector.mm: 12273 (-[WebInspector showConsole:]): 12274 (-[WebInspector stopProfilingJavaScript:]): 12275 122762011-02-08 Dan Bernstein <mitz@apple.com> 12277 12278 Reviewed by Jon Honeycutt and Maciej Stachowiak. 12279 12280 <rdar://problem/8959420> Find in Mail no longer cycles around 12281 12282 * WebView/WebHTMLView.mm: 12283 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set 12284 the wrap option according to the flag. 12285 122862011-02-08 Sheriff Bot <webkit.review.bot@gmail.com> 12287 12288 Unreviewed, rolling out r77980. 12289 http://trac.webkit.org/changeset/77980 12290 https://bugs.webkit.org/show_bug.cgi?id=54043 12291 12292 "Crashes on Windows and Linux..." (Requested by leviw on 12293 #webkit). 12294 12295 * WebView/WebFrame.mm: 12296 (-[WebFrame _caretRectAtNode:offset:affinity:]): 12297 * WebView/WebFrameInternal.h: 12298 * WebView/WebTextCompletionController.mm: 12299 (-[WebTextCompletionController doCompletion]): 12300 123012011-02-08 Levi Weintraub <leviw@chromium.org> 12302 12303 Reviewed by Ryosuke Niwa. 12304 12305 Stop instantiating legacy editing Positions in VisiblePosition 12306 https://bugs.webkit.org/show_bug.cgi?id=52919 12307 12308 Changing usage of legacy VisiblePosition constructor. Since we were dealing 12309 with positions from DOM Ranges, we're guaranteed a parent-anchored position. 12310 12311 * WebView/WebFrame.mm: 12312 (-[WebFrame _caretRectAtPosition:affinity:]): 12313 * WebView/WebFrameInternal.h: 12314 * WebView/WebTextCompletionController.mm: 12315 (-[WebTextCompletionController doCompletion]): 12316 123172011-02-08 Adam Barth <abarth@webkit.org> 12318 12319 Reviewed by Eric Seidel. 12320 12321 Remove orphan code from old parser 12322 https://bugs.webkit.org/show_bug.cgi?id=53984 12323 12324 * WebCoreSupport/WebChromeClient.h: 12325 123262011-02-02 Ilya Tikhonovsky <loislo@chromium.org> 12327 12328 Reviewed by Yury Semikhatsky. 12329 12330 Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController. 12331 12332 https://bugs.webkit.org/show_bug.cgi?id=53169 12333 12334 Minor change enforced by major changes in WebCore/inspector/InspectorController. 12335 12336 * WebInspector/WebInspector.mm: 12337 (-[WebInspector isTimelineProfilingEnabled]): 12338 123392011-02-07 Enrica Casucci <enrica@apple.com> 12340 12341 Reviewed Adam Roben and Darin Adler. 12342 12343 WebKit2: drag and drop support on Windows. 12344 https://bugs.webkit.org/show_bug.cgi?id=52775 12345 12346 Removed createDragImageForLink from DragClient. 12347 12348 * WebCoreSupport/WebDragClient.h: 12349 * WebCoreSupport/WebDragClient.mm: 12350 (WebDragClient::startDrag): 12351 123522011-02-03 Yury Semikhatsky <yurys@chromium.org> 12353 12354 Reviewed by Pavel Feldman. 12355 12356 Web Inspector: remove settings related methods from InspectorClient 12357 https://bugs.webkit.org/show_bug.cgi?id=53686 12358 12359 * WebCoreSupport/WebInspectorClient.h: 12360 * WebCoreSupport/WebInspectorClient.mm: 12361 (WebInspectorClient::openInspectorFrontend): 12362 (WebInspectorFrontendClient::WebInspectorFrontendClient): 12363 123642011-02-03 James Kozianski <koz@chromium.org> 12365 12366 Reviewed by Dimitri Glazkov. 12367 12368 Add navigator.registerProtocolHandler behind a flag. 12369 https://bugs.webkit.org/show_bug.cgi?id=52609 12370 12371 * Configurations/FeatureDefines.xcconfig: 12372 123732011-02-03 Adam Langley <agl@chromium.org> 12374 12375 Reviewed by Adam Barth. 12376 12377 Plumb mixed script URL to FrameLoaderClient 12378 https://bugs.webkit.org/show_bug.cgi?id=52384 12379 12380 Regressions covered by http/tests/security/mixedContent/* 12381 12382 * WebCoreSupport/WebFrameLoaderClient.h: 12383 * WebCoreSupport/WebFrameLoaderClient.mm: 12384 (WebFrameLoaderClient::didRunInsecureContent): 12385 123862011-02-03 Beth Dakin <bdakin@apple.com> 12387 12388 Reviewed by Sam Weinig. 12389 12390 Fix for <rdar://problem/8944544> Ability to animate track 12391 for WKPainter scrollers 12392 12393 * WebCoreSupport/WebSystemInterface.mm: 12394 (InitWebCoreSystemInterface): 12395 123962011-02-02 Mark Rowe <mrowe@apple.com> 12397 12398 Reviewed by Beth Dakin. 12399 12400 <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer(). 12401 12402 * WebCoreSupport/WebSystemInterface.mm: 12403 (InitWebCoreSystemInterface): Add some missing initializers. 12404 124052011-02-02 Steve Lacey <sjl@chromium.org> 12406 12407 Reviewed by Eric Carlson. 12408 12409 Implement basic media statistics on media elements. 12410 https://bugs.webkit.org/show_bug.cgi?id=53322 12411 12412 * Configurations/FeatureDefines.xcconfig: 12413 124142011-02-01 Sam Weinig <sam@webkit.org> 12415 12416 Reviewed by Beth Dakin. 12417 12418 Part 2 for <rdar://problem/8492788> 12419 Adopt WKScrollbarPainterController 12420 12421 Use header detection to define scrollbar painting controller #define. 12422 12423 * WebCoreSupport/WebSystemInterface.mm: 12424 (InitWebCoreSystemInterface): 12425 124262011-02-01 David Hyatt <hyatt@apple.com> 12427 12428 Reviewed by Oliver Hunt. 12429 12430 https://bugs.webkit.org/show_bug.cgi?id=53520 12431 12432 Remove the physical terminology from IntRect and FloatRect. 12433 12434 Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes, 12435 we need to update our terminology to be more accurate. 12436 12437 I'm borrowing a page from AppKit here (which also supports flipped NSViews) and 12438 renaming right() and bottom() to maxX() and maxY(). These terms remain accurate 12439 even for flipped rectangles. 12440 12441 * WebView/WebHTMLView.mm: 12442 (setNeedsDisplayInRect): 12443 124442011-02-01 Beth Dakin <bdakin@apple.com> 12445 12446 Reviewed by Sam Weinig. 12447 12448 Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController 12449 12450 * WebCoreSupport/WebSystemInterface.mm: 12451 (InitWebCoreSystemInterface): 12452 124532011-02-01 Dave Hyatt <hyatt@apple.com> 12454 12455 Reviewed by Darin Adler. 12456 12457 https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work 12458 with vertical text. 12459 12460 Change printing functions to check writing-mode and properly swap width and height 12461 as needed. 12462 12463 * WebView/WebDynamicScrollBarsView.mm: 12464 (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]): 12465 * WebView/WebFrame.mm: 12466 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): 12467 * WebView/WebFrameInternal.h: 12468 * WebView/WebHTMLView.mm: 12469 (-[WebHTMLView _web_setPrintingModeRecursive]): 12470 (-[WebHTMLView _web_clearPrintingModeRecursive]): 12471 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): 12472 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): 12473 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): 12474 (-[WebHTMLView _endPrintMode]): 12475 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): 12476 (-[WebHTMLView _endScreenPaginationMode]): 12477 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]): 12478 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]): 12479 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): 12480 (-[WebHTMLView _scaleFactorForPrintOperation:]): 12481 (-[WebHTMLView setPageWidthForPrinting:]): 12482 (-[WebHTMLView knowsPageRange:]): 12483 124842011-01-31 Oliver Hunt <oliver@apple.com> 12485 12486 Convert markstack to a slot visitor API 12487 https://bugs.webkit.org/show_bug.cgi?id=53219 12488 12489 rolling r77098, r77099, r77100, r77109, and 12490 r77111 back in, along with a few more Qt fix attempts. 12491 12492 * WebView/WebScriptDebugDelegate.mm: 12493 (-[WebScriptCallFrame scopeChain]): 12494 124952011-01-30 Csaba Osztrogonác <ossy@webkit.org> 12496 12497 Unreviewed, rolling out r77098, r77099, r77100, r77109, and 12498 r77111. 12499 http://trac.webkit.org/changeset/77098 12500 http://trac.webkit.org/changeset/77099 12501 http://trac.webkit.org/changeset/77100 12502 http://trac.webkit.org/changeset/77109 12503 http://trac.webkit.org/changeset/77111 12504 https://bugs.webkit.org/show_bug.cgi?id=53219 12505 12506 Qt build is broken 12507 12508 * WebView/WebScriptDebugDelegate.mm: 12509 (-[WebScriptCallFrame scopeChain]): 12510 125112011-01-30 Oliver Hunt <oliver@apple.com> 12512 12513 Convert markstack to a slot visitor API 12514 https://bugs.webkit.org/show_bug.cgi?id=53219 12515 12516 rolling r77006 and r77020 back in. 12517 12518 * WebView/WebScriptDebugDelegate.mm: 12519 (-[WebScriptCallFrame scopeChain]): 12520 125212011-01-28 Geoffrey Garen <ggaren@apple.com> 12522 12523 Reviewed by Maciej Stachowiak. 12524 12525 Some more Heap cleanup. 12526 https://bugs.webkit.org/show_bug.cgi?id=53357 12527 12528 Updated for JavaScriptCore changes. 12529 12530 * Misc/WebCoreStatistics.mm: 12531 (+[WebCoreStatistics memoryStatistics]): 12532 125332011-01-28 Sheriff Bot <webkit.review.bot@gmail.com> 12534 12535 Unreviewed, rolling out r77006 and r77020. 12536 http://trac.webkit.org/changeset/77006 12537 http://trac.webkit.org/changeset/77020 12538 https://bugs.webkit.org/show_bug.cgi?id=53360 12539 12540 "Broke Windows tests" (Requested by rniwa on #webkit). 12541 12542 * WebView/WebScriptDebugDelegate.mm: 12543 (-[WebScriptCallFrame scopeChain]): 12544 125452011-01-27 Oliver Hunt <oliver@apple.com> 12546 12547 Reviewed by Geoffrey Garen. 12548 12549 Convert markstack to a slot visitor API 12550 https://bugs.webkit.org/show_bug.cgi?id=53219 12551 12552 Update to new marking api 12553 12554 * WebView/WebScriptDebugDelegate.mm: 12555 (-[WebScriptCallFrame scopeChain]): 12556 125572011-01-28 Dan Bernstein <mitz@apple.com> 12558 12559 Reviewed by Sam Weinig. 12560 12561 <select> can't display right-to-left (rtl) languages 12562 https://bugs.webkit.org/show_bug.cgi?id=19785 12563 12564 * WebCoreSupport/WebChromeClient.h: 12565 * WebCoreSupport/WebChromeClient.mm: 12566 (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false. 12567 (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true. 12568 125692011-01-27 Sheriff Bot <webkit.review.bot@gmail.com> 12570 12571 Unreviewed, rolling out r76891. 12572 http://trac.webkit.org/changeset/76891 12573 https://bugs.webkit.org/show_bug.cgi?id=53280 12574 12575 Makes every layout test crash (Requested by othermaciej on 12576 #webkit). 12577 12578 * Misc/WebIconDatabase.mm: 12579 (-[ThreadEnabler threadEnablingSelector:]): 12580 (importToWebCoreFormat): 12581 125822011-01-27 Nate Chapin <japhet@chromium.org> 12583 12584 Reviewed by Adam Barth. 12585 12586 Use Document::url() instead of FrameLoader::url(). 12587 https://bugs.webkit.org/show_bug.cgi?id=41165 12588 12589 * WebView/WebView.mm: 12590 (-[WebView _dispatchDidReceiveIconFromWebFrame:]): 12591 125922011-01-27 Dan Bernstein <mitz@apple.com> 12593 12594 Rubber-stamped by Anders Carlsson. 12595 12596 Reverted an accidental change in r76561. 12597 12598 * WebView/WebHTMLView.mm: 12599 126002011-01-26 David Kilzer <ddkilzer@apple.com> 12601 12602 <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork 12603 <rdar://problem/8821760> 12604 12605 Reviewed by Antti Koivisto. 12606 12607 * WebCoreSupport/WebSystemInterface.mm: 12608 (InitWebCoreSystemInterface): Added initialization for 12609 GetHTTPPipeliningPriority and SetHTTPPipeliningPriority. 12610 126112011-01-26 Beth Dakin <bdakin@apple.com> 12612 12613 Reviewed by Darin Adler. 12614 12615 Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics 12616 when using WKScrollbars. 12617 12618 * WebCoreSupport/WebSystemInterface.mm: 12619 (InitWebCoreSystemInterface): 12620 126212011-01-25 Darin Adler <darin@apple.com> 12622 12623 Reviewed by Anders Carlsson. 12624 12625 WebKit is using CSBackupSetItemExcluded incorrectly 12626 https://bugs.webkit.org/show_bug.cgi?id=53095 12627 rdar://problem/8790540 12628 12629 * Misc/WebIconDatabase.mm: 12630 (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded. 12631 It was incorrect, and this responsibility has been moved to WebCore. 12632 126332011-01-24 Chris Marrin <cmarrin@apple.com> 12634 12635 Reviewed by Eric Seidel. 12636 12637 Change ENABLE_3D_CANVAS to ENABLE_WEBGL 12638 https://bugs.webkit.org/show_bug.cgi?id=53041 12639 12640 * Configurations/FeatureDefines.xcconfig: 12641 126422011-01-25 Yury Semikhatsky <yurys@chromium.org> 12643 12644 Reviewed by Pavel Feldman. 12645 12646 Web Inspector: remove "attached" state related methods from InspectorAgent 12647 https://bugs.webkit.org/show_bug.cgi?id=53086 12648 12649 * WebCoreSupport/WebInspectorClient.h: 12650 * WebCoreSupport/WebInspectorClient.mm: 12651 (-[WebInspectorWindowController showWindow:]): 12652 (-[WebInspectorWindowController attach]): 12653 (-[WebInspectorWindowController detach]): 12654 126552011-01-23 Dan Bernstein <mitz@apple.com> 12656 12657 Reviewed by John Sullivan. 12658 12659 <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter 12660 12661 * WebCoreSupport/WebChromeClient.mm: 12662 (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it. 12663 126642011-01-22 Alexey Proskuryakov <ap@apple.com> 12665 12666 Reviewed by Darin Adler. 12667 12668 https://bugs.webkit.org/show_bug.cgi?id=52473 12669 Auto-scaling to avoid orphans is broken, remove dysfunctional code 12670 12671 * WebView/WebHTMLView.mm: 12672 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): 12673 (-[WebHTMLView _scaleFactorForPrintOperation:]): 12674 (-[WebHTMLView knowsPageRange:]): 12675 126762011-01-21 Mark Rowe <mrowe@apple.com> 12677 12678 Rubber-stamped by Jon Honeycutt. 12679 12680 Fix the build when using Clang by removing some unused variables. 12681 12682 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 12683 (-[WebHostedNetscapePluginView updateAndSetWindow]): 12684 * WebView/WebFullScreenController.mm: 12685 (-[WebFullScreenController enterFullscreen:]): 12686 (-[WebFullScreenController exitFullscreen]): 12687 126882011-01-21 Chris Rogers <crogers@google.com> 12689 12690 Reviewed by Darin Fisher. 12691 12692 Add run-time enable support for the web audio API 12693 https://bugs.webkit.org/show_bug.cgi?id=52741 12694 12695 * WebView/WebPreferenceKeysPrivate.h: 12696 * WebView/WebPreferences.mm: 12697 (-[WebPreferences webAudioEnabled]): 12698 (-[WebPreferences setWebAudioEnabled:]): 12699 * WebView/WebPreferencesPrivate.h: 12700 * WebView/WebView.mm: 12701 (-[WebView _preferencesChangedNotification:]): 12702 127032011-01-20 John Sullivan <sullivan@apple.com> 12704 12705 Reviewed by Mark Rowe. 12706 12707 Shift-tab doesn't cycle through fields in http authentication panel 12708 https://bugs.webkit.org/show_bug.cgi?id=52850 12709 12710 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: 12711 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: 12712 Re-wired the key loop so that there aren't two views with the same nextKeyView. 12713 127142011-01-20 Beth Dakin <bdakin@apple.com> 12715 12716 Reviewed by Geoffrey Garen. 12717 12718 Fix for <rdar://problem/8890255> 12719 12720 Allow WebKitSystemInterface to draw scrollbars 12721 when appropriate. 12722 * WebCoreSupport/WebSystemInterface.mm: 12723 (InitWebCoreSystemInterface): 12724 127252011-01-19 Simon Fraser <simon.fraser@apple.com> 12726 12727 Reviewed by Sam Weinig. 12728 12729 GraphicsLayers in subframes can get sync'd multiple times 12730 https://bugs.webkit.org/show_bug.cgi?id=52489 12731 12732 * WebView/WebView.mm: 12733 (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive() 12734 was renamed to syncCompositingStateIncludingSubframes(). 12735 127362011-01-19 Darin Adler <darin@apple.com> 12737 12738 Reviewed by Sam Weinig. 12739 12740 Would like script debugging protocol method to differentiate between caught and uncaught exceptions 12741 https://bugs.webkit.org/show_bug.cgi?id=52104 12742 rdar://problem/8704226 12743 12744 * WebView/WebDelegateImplementationCaching.h: 12745 Fix type of second integer in CallScriptDebugDelegate function overload 12746 to be int to match the actual Objective-C method. Added a new overload 12747 that includes a BOOL in the right place. Added a boolean named 12748 exceptionWasRaisedExpectsHasHandlerFlag. 12749 12750 * WebView/WebDelegateImplementationCaching.mm: 12751 (CallDelegate): Added overloads as above. 12752 (CallScriptDebugDelegate): Ditto. 12753 12754 * WebView/WebScriptDebugDelegate.h: Added new method with the additional 12755 boolean argument. Marked the old method informally deprecated. 12756 12757 * WebView/WebScriptDebugger.mm: 12758 (WebScriptDebugger::exception): Added code to call with or without the 12759 boolean depending on exceptionWasRaisedExpectsHasHandlerFlag. 12760 12761 * WebView/WebView.mm: 12762 (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the 12763 exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not 12764 guaranteed to set didParseSourceExpectsBaseLineNumber to NO. 12765 127662011-01-19 Tony Gentilcore <tonyg@chromium.org> 12767 12768 Reviewed by Mihai Parparita. 12769 12770 Perform some forward declaration 12771 https://bugs.webkit.org/show_bug.cgi?id=52522 12772 12773 * Misc/WebKitNSStringExtras.mm: 12774 127752011-01-19 Pavel Podivilov <podivilov@chromium.org> 12776 12777 Reviewed by Yury Semikhatsky. 12778 12779 Web Inspector: [JSC] scripts have incorrect starting line (always 1). 12780 https://bugs.webkit.org/show_bug.cgi?id=52721 12781 12782 * WebView/WebScriptDebugger.h: 12783 * WebView/WebScriptDebugger.mm: 12784 (toNSString): 12785 (WebScriptDebugger::sourceParsed): 12786 127872011-01-19 Levi Weintraub <leviw@google.com> 12788 12789 Reviewed by Ryosuke Niwa. 12790 12791 Updating to use Position::parentAnchoredEquivalent instead of 12792 the old htmlediting rangeCompliantEquivalent. 12793 12794 remove rangeCompliantEquivalent and replace it with Position methods 12795 https://bugs.webkit.org/show_bug.cgi?id=25057 12796 12797 * WebView/WebFrame.mm: 12798 (-[WebFrame _smartDeleteRangeForProposedRange:]): 12799 128002011-01-18 Chris Fleizach <cfleizach@apple.com> 12801 12802 Reviewed by Darin Adler. 12803 12804 REGRESSION: A problem with Voiceover and finding links 12805 https://bugs.webkit.org/show_bug.cgi?id=52324 12806 12807 * WebView/WebDynamicScrollBarsView.mm: 12808 (-[WebDynamicScrollBarsView accessibilityIsIgnored]): 12809 128102011-01-17 David Kilzer <ddkilzer@apple.com> 12811 12812 <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project 12813 12814 Reviewed by Dan Bernstein. 12815 12816 * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and 12817 DOMDocumentPrivate.h to the PrivateHeaders directory. 12818 128192011-01-17 Enrica Casucci <enrica@apple.com> 12820 12821 Reviewed by Alexey Proskuryakov. 12822 12823 Drag and drop support: refactoring of image from link and image from selection 12824 https://bugs.webkit.org/show_bug.cgi?id=52496 12825 12826 This work cleans up the Mac code and makes it more similar to the Windows implementation, 12827 avoiding the use of an NSView when the FrameView can be used. 12828 The refactoring is a necessary step towards the complete support of drag and drop 12829 in WebKit2. 12830 12831 * WebCoreSupport/WebDragClient.mm: 12832 (WebDragClient::createDragImageForLink): Added. 12833 * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL. 12834 * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL. 12835 128362011-01-17 Pavel Feldman <pfeldman@chromium.org> 12837 12838 Reviewed by Yury Semikhatsky. 12839 12840 Web Inspector: simplify debugger enabling routine. 12841 https://bugs.webkit.org/show_bug.cgi?id=52472 12842 12843 * WebInspector/WebInspector.mm: 12844 (-[WebInspector startDebuggingJavaScript:]): 12845 128462011-01-16 Dan Bernstein <mitz@apple.com> 12847 12848 Reviewed by Simon Fraser. 12849 12850 Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html 12851 https://bugs.webkit.org/show_bug.cgi?id=52550 12852 12853 * Plugins/WebNetscapePluginView.mm: 12854 (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure 12855 that inSetWindow remains YES until we exit the top-level setWindowIfNecessary. 12856 128572011-01-16 Simon Fraser <simon.fraser@apple.com> 12858 12859 Reviewed by Dan Bernstein. 12860 12861 Issues with iframes and plugins when the WebView is scaled. 12862 <rdar://problem/6213380> 12863 12864 When _scaleWebView has been called on a WebView, iframes 12865 in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up. 12866 This is caused by AppKit NSViews not playing nicely with the scale 12867 applied through style. 12868 12869 Work around most of these issues by adjusting the bounds size 12870 of widgets to allow iframe contents to paint with the correct scale, 12871 and fix various places in the code where we relied on coordinate 12872 transforms via NSViews (which ignore CSS transforms). 12873 12874 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 12875 (-[WebHostedNetscapePluginView updateAndSetWindow]): 12876 * WebView/WebFrameView.mm: 12877 (-[WebFrameView setBoundsSize:]): 12878 128792011-01-16 Beth Dakin <bdakin@apple.com> 12880 12881 Reviewed by Kevin Decker. 12882 12883 Fix for <rdar://problem/8871204> 12884 12885 Don't try to save elasticity state. Just rely on 12886 NSScrollElasticityAutomatic to restore the correct state. 12887 * WebCoreSupport/WebFrameLoaderClient.h: 12888 * WebCoreSupport/WebFrameLoaderClient.mm: 12889 (WebFrameLoaderClient::WebFrameLoaderClient): 12890 (WebFrameLoaderClient::dispatchDidFirstLayout): 12891 (WebFrameLoaderClient::provisionalLoadStarted): 12892 128932011-01-14 Simon Fraser <simon.fraser@apple.com> 12894 12895 Reviewed by Dan Bernstein. 12896 12897 Plugins render incorrectly with transformed ancestors 12898 https://bugs.webkit.org/show_bug.cgi?id=52507 12899 12900 -[NSView visibleRect] gives the wrong answer if there are CSS transforms 12901 in the ancestor chain of a plugin. 12902 12903 So use of this method with calls to -actualVisibleRectInWindow, which 12904 maps rects through the render tree to compute the correct rect, 12905 clipping via windowClipRect() if necessary. 12906 12907 Not testable, because doing so relies on the behavior of some 12908 plugins, which stop rendering if setWindow passes an empty rect. 12909 12910 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 12911 (-[WebHostedNetscapePluginView updateAndSetWindow]): 12912 * Plugins/WebBaseNetscapePluginView.h: 12913 * Plugins/WebBaseNetscapePluginView.mm: 12914 (-[WebBaseNetscapePluginView actualVisibleRectInWindow]): 12915 * Plugins/WebNetscapePluginView.mm: 12916 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): 12917 129182011-01-14 Yuzo Fujishima <yuzo@google.com> 12919 12920 Reviewed by Antti Koivisto. 12921 12922 Rename cache() to memoryCache() 12923 https://bugs.webkit.org/show_bug.cgi?id=52433 12924 12925 * Misc/WebCache.mm: 12926 (+[WebCache statistics]): 12927 (+[WebCache setDisabled:]): 12928 (+[WebCache isDisabled]): 12929 * WebView/WebView.mm: 12930 (+[WebView _setCacheModel:]): 12931 129322011-01-13 Geoffrey Garen <ggaren@apple.com> 12933 12934 Reviewed by Oliver Hunt. 12935 12936 Split out a MarkedSpace strategy object from Heap. 12937 https://bugs.webkit.org/show_bug.cgi?id=52421 12938 12939 * Misc/WebCoreStatistics.mm: 12940 (+[WebCoreStatistics memoryStatistics]): Updated for class move. 12941 129422011-01-14 Dan Bernstein <mitz@apple.com> 12943 12944 Reviewed by Simon Fraser. 12945 12946 WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree] 12947 12948 * WebView/WebHTMLView.mm: 12949 (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call 12950 to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures 12951 that the NSView tree doesn’t change from under AppKit as it traverses it. 12952 129532011-01-14 Beth Dakin <bdakin@apple.com> 12954 12955 Reviewed by Mark Rowe. 12956 12957 Fix for <rdar://problem/7793902> Artifacts when scrolling 12958 page in Safari while page is loading 12959 12960 Call setDrawsBackground:YES on the scrollView in 12961 dispatchDidFirstLayout() rather than waiting until 12962 frameLoadCompleted(). Also suspend scrolling elasticity 12963 between provisionalLoadStarted() and dispatchDidFirstLayout() 12964 * WebCoreSupport/WebFrameLoaderClient.h: 12965 * WebCoreSupport/WebFrameLoaderClient.mm: 12966 (WebFrameLoaderClient::WebFrameLoaderClient): 12967 (WebFrameLoaderClient::dispatchDidFirstLayout): 12968 (WebFrameLoaderClient::provisionalLoadStarted): 12969 129702011-01-12 Enrica Casucci <enrica@apple.com> 12971 12972 Reviewed by Darin Adler. 12973 12974 WebKit2: Add support for drag and drop 12975 https://bugs.webkit.org/show_bug.cgi?id=52343 12976 <rdar://problem/7660558> 12977 12978 The DragData class has been extended to provide 12979 additional context from the application (keyboard state, modal windows, etc.) 12980 as well as information of the drag pasteboard being used. 12981 These are the changes to align the behavior for WebKit. 12982 12983 * WebView/WebView.mm: 12984 (-[WebView applicationFlags:]): Added. 12985 (-[WebView draggingEntered:]): Added parameter to the DragData constructor. 12986 (-[WebView draggingUpdated:]): Added parameter to the DragData constructor. 12987 (-[WebView draggingExited:]): Added parameter to the DragData constructor. 12988 (-[WebView performDragOperation:]): Added parameter to the DragData constructor. 12989 129902011-01-12 Beth Dakin <bdakin@apple.com> 12991 12992 Reviewed by Anders Carlsson. 12993 12994 Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309 12995 Expose fixed layout through WebKit SPI 12996 -and corresponding- 12997 <rdar://problem/8844464> 12998 12999 And now with getters! 13000 * WebView/WebView.mm: 13001 (-[WebView _useFixedLayout]): 13002 (-[WebView _fixedLayoutSize]): 13003 * WebView/WebViewPrivate.h: 13004 130052011-01-12 Beth Dakin <bdakin@apple.com> 13006 13007 Reviewed by Anders Carlsson. 13008 13009 Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose 13010 fixed layout through WebKit SPI 13011 -and corresponding- 13012 <rdar://problem/8844464> 13013 13014 * WebView/WebView.mm: 13015 (-[WebView _setUseFixedLayout:]): 13016 (-[WebView _setFixedLayoutSize:]): 13017 * WebView/WebViewPrivate.h: 13018 130192011-01-07 Enrica Casucci <enrica@apple.com> 13020 13021 Reviewed by Alexey Proskuryakov. 13022 13023 Paste and drag and drop use different code paths to interact with the pasteboard. 13024 https://bugs.webkit.org/show_bug.cgi?id=52093 13025 The change consists in a refactoring of the code to have only one class that 13026 deals with the pasteboard on Mac. 13027 13028 * WebCoreSupport/WebEditorClient.h: 13029 * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality 13030 exposed by NSURLExtras. 13031 (WebEditorClient::canonicalizeURL): 13032 (WebEditorClient::canonicalizeURLString): 13033 * WebCoreSupport/WebPasteboardHelper.h: Removed. 13034 * WebCoreSupport/WebPasteboardHelper.mm: Removed. 13035 * WebView/WebHTMLView.mm: Removed comment. 13036 * WebView/WebView.mm: The following methods have been changed to use the new DragData 13037 constructor that doesn't use the WebPasteboardHelper reference. 13038 (-[WebView draggingEntered:]): 13039 (-[WebView draggingUpdated:]): 13040 (-[WebView draggingExited:]): 13041 (-[WebView performDragOperation:]): 13042 130432011-01-09 Tony Gentilcore <tonyg@chromium.org> 13044 13045 Reviewed by Alexey Proskuryakov. 13046 13047 Forward declare some headers where possible 13048 https://bugs.webkit.org/show_bug.cgi?id=52133 13049 13050 * WebView/WebFrame.mm: 13051 130522011-01-09 Xianzhu Wang <phnixwxz@gmail.com> 13053 13054 Reviewed by Darin Fisher. 13055 13056 https://bugs.webkit.org/show_bug.cgi?id=41441 13057 createWindow method should only do window-creating without URL navigation 13058 13059 * WebCoreSupport/WebChromeClient.mm: 13060 (WebChromeClient::createWindow): 13061 130622011-01-08 Dan Bernstein <mitz@apple.com> 13063 13064 Try to fix the Leopard build. 13065 13066 * WebView/WebFullScreenController.mm: 13067 130682011-01-07 Jer Noble <jer.noble@apple.com> 13069 13070 Yet another Leopard build fix: NSRect and CGRect are not inter- 13071 changable in 32-bit. 13072 13073 * WebView/WebFullScreenController.mm: 13074 (-[WebFullScreenController exitFullscreen]): 13075 130762011-01-07 Jer Noble <jer.noble@apple.com> 13077 13078 Fix the Leopard build: Replace CoreAnimation SL-only functions 13079 with Leopard equivalents. 13080 13081 * WebView/WebFullScreenController.mm: 13082 (+[CATransaction setDisableActions:]): 13083 (+[CATransaction setAnimationDuration:]): 13084 (-[WebFullScreenController _animationDuration]): 13085 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]): 13086 130872010-12-21 Jer Noble <jer.noble@apple.com> 13088 13089 Reviewed by Simon Fraser. 13090 13091 Implement WebKit Full Screen support. 13092 https://bugs.webkit.org/show_bug.cgi?id=49481 13093 rdar://problem/8247444 13094 13095 Support the new fullscreen Chrome client requests. WebView will pass 13096 through these requests to a WebFullscreenController. 13097 13098 * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged(). 13099 * WebView/WebView.mm: 13100 (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled. 13101 (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController. 13102 (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen. 13103 (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed. 13104 * WebView/WebViewData.h: Add ivar newFullscreenController. 13105 131062010-12-17 Jer Noble <jer@kokode.apple.com> 13107 13108 Reviewed by Simon Fraser. 13109 13110 Implement WebKit Full Screen support. 13111 https://bugs.webkit.org/show_bug.cgi?id=49481 13112 rdar://problem/8247444 13113 13114 This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new 13115 Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen 13116 window, and a custom CAAnimation animates that layer between the initial screen rect of the 13117 full screen element, to its final value. WebFullscreenController will swap the WebView out of 13118 its original window, and into the fullscreen window. The controller will replace the WebView 13119 with a placeholder view, so that if the placeholder moves or resized while the WebView is 13120 absent, the WebView will move back to the correct location when exiting fullscreen. 13121 13122 * WebView/WebFullscreenController.h: Added. 13123 * WebView/WebFullscreenController.mm: Added. 13124 (-[WebFullscreenController windowDidExitFullscreen:]): Close the fullscreen window. 13125 (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window. 13126 (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate. 13127 (-[WebFullscreenController applicationDidResignActive:]): 13128 (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match 13129 the new screen parameters. 13130 (-[WebFullscreenController enterFullscreen:]): Set up the animation that will take the fullscreen element 13131 from its original screen rect into fullscreen. 13132 (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window. 13133 Set up the animation that will take the fullscreen element back into its original screen 13134 rect. 13135 (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine 13136 whether to disable screensaver and sleep. 13137 (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element 13138 looking for HTMLVideoElements; returns whether any are found to be playing. 13139 (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control 13140 and shift keys. 13141 (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key. 13142 (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key. 13143 (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen. 13144 (-[WebFullscreenWindow rendererLayer]): Convenience accessor. 13145 (-[WebFullscreenWindow setRendererLayer:]): Ditto. 13146 (-[WebFullscreenWindow backgroundLayer]): Ditto. 13147 (-[WebFullscreenWindow animationView]): Ditto. 13148 (MediaEventListener::MediaEventListener): Implements the EventListener protocol. 13149 (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions. 13150 131512011-01-07 James Robinson <jamesr@chromium.org> 13152 13153 Revert "Implement mozilla's animationTime property" 13154 https://bugs.webkit.org/show_bug.cgi?id=51952 13155 13156 This approach isn't quite right. 13157 13158 * WebView/WebHTMLView.mm: 13159 (-[WebHTMLView drawRect:]): 13160 * WebView/WebView.mm: 13161 (layerSyncRunLoopObserverCallBack): 13162 131632011-01-06 Gavin Barraclough <barraclough@apple.com> 13164 13165 Reviewed by Geoff Garen. 13166 13167 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe 13168 13169 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's 13170 destructor early, in order to release wrappers once we know we no longer intend to use them. 13171 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to 13172 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData. 13173 A sequence of events that triggers the bug would look like this: 13174 13175 (1) Create a DOMWrapperWorld. 13176 (2) Register a timer in the world. 13177 (3) Call unregisterWorld() on the world. 13178 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document. 13179 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've 13180 called forgetWorld() none exists. 13181 (6) Attempt to add a wrapper to a NULL map. 13182 13183 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away. 13184 13185 * WebView/WebScriptWorld.mm: 13186 (-[WebScriptWorld unregisterWorld]): 13187 131882011-01-04 Chris Fleizach <cfleizach@apple.com> 13189 13190 Reviewed by Sam Weinig. 13191 13192 WK2: Support Accessibility 13193 https://bugs.webkit.org/show_bug.cgi?id=51859 13194 13195 Use rootObject() method to get top of AX tree. 13196 13197 * WebCoreSupport/WebFrameLoaderClient.h: 13198 (WebFrameLoaderClient::accessibilityRemoteObject): 13199 * WebView/WebFrame.mm: 13200 (-[WebFrame setAccessibleName:]): 13201 (-[WebFrame accessibilityRoot]): 13202 * WebView/WebFrameInternal.h: 13203 * WebView/WebFramePrivate.h: 13204 * WebView/WebHTMLView.mm: 13205 (-[WebHTMLView accessibilityAttributeValue:]): 13206 (-[WebHTMLView accessibilityFocusedUIElement]): 13207 (-[WebHTMLView accessibilityHitTest:]): 13208 (-[WebHTMLView _accessibilityParentForSubview:]): 13209 132102011-01-04 David Kilzer <ddkilzer@apple.com> 13211 13212 <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name 13213 13214 Reviewed by Eric Carlson. 13215 13216 This originally broke in r61581. It is inside an 13217 ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac 13218 build then. 13219 13220 * WebCoreSupport/WebFrameLoaderClient.mm: Call 13221 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to 13222 use WebCore::PluginInfo.name instead of 13223 -[WebBasePluginPackage name]. 13224 132252011-01-02 Dan Bernstein <mitz@apple.com> 13226 13227 Rubber-stamped by Simon Fraser. 13228 13229 <rdar://problem/8812159> Update copyright strings 13230 13231 * Info.plist: 13232 132332010-12-29 Dan Bernstein <mitz@apple.com> 13234 13235 Reviewed by Ada Chan. 13236 13237 <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict 13238 https://bugs.webkit.org/show_bug.cgi?id=51717 13239 13240 Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching 13241 protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines. 13242 13243 * WebView/WebDocumentInternal.h: 13244 * WebView/WebHTMLView.mm: 13245 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): 13246 (-[WebHTMLView _findString:options:]): 13247 * WebView/WebView.mm: 13248 (findString): 13249 132502010-12-28 Daniel Bates <dbates@rim.com> 13251 13252 Reviewed by Sam Weinig. 13253 13254 Substitute // MARK: for compiler-specific #pragma mark 13255 https://bugs.webkit.org/show_bug.cgi?id=51657 13256 13257 For consistency, we should substitute "// MARK:" for compiler- 13258 specific "#pragma mark" in the source files for the Mac port. 13259 13260 * History/WebHistory.mm: 13261 * Plugins/WebBaseNetscapePluginView.mm: 13262 * Plugins/WebNetscapePluginView.mm: 13263 * WebCoreSupport/WebInspectorClient.mm: 13264 * WebCoreSupport/WebSecurityOrigin.mm: 13265 * WebView/WebPDFView.mm: 13266 * WebView/WebVideoFullscreenController.mm: 13267 * WebView/WebVideoFullscreenHUDWindowController.mm: 13268 132692010-12-23 Yongjun Zhang <yongjun_zhang@apple.com> 13270 13271 Reviewed by Darin Adler. 13272 13273 WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe. 13274 https://bugs.webkit.org/show_bug.cgi?id=38535 13275 13276 WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram. As a result, 13277 if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and 13278 WebScriptDebugger's callframe stack is wrong from this point. That could cause crash if we trying to access the top 13279 call frame from this stack when an exception throws because the saved top frame could be invalid. 13280 13281 To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in 13282 callEvent and returnEvent. 13283 13284 * WebView/WebScriptDebugger.mm: 13285 (WebScriptDebugger::willExecuteProgram): 13286 (WebScriptDebugger::didExecuteProgram): 13287 132882010-12-22 Sam Weinig <sam@webkit.org> 13289 13290 Reviewed by Darin Adler. 13291 13292 WebKit2 needs to mirror the frame tree in the UIProcess 13293 https://bugs.webkit.org/show_bug.cgi?id=51546 13294 13295 - Add client functions to notify that a frame has been added or 13296 removed from the page cache. 13297 13298 * WebCoreSupport/WebFrameLoaderClient.h: 13299 * WebCoreSupport/WebFrameLoaderClient.mm: 13300 (WebFrameLoaderClient::didSaveToPageCache): 13301 (WebFrameLoaderClient::didRestoreFromPageCache): 13302 133032010-12-22 Ryosuke Niwa <rniwa@webkit.org> 13304 13305 Reviewed by Eric Seidel. 13306 13307 Editor.h doesn't need to include SelectionController.h 13308 https://bugs.webkit.org/show_bug.cgi?id=51441 13309 13310 Renamed SelectionController::EDirection to SelectionDirection. 13311 13312 * WebView/WebFrame.mm: 13313 (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]): 13314 Takes SelectionDirection instead of SelectionController::EDirection. 13315 * WebView/WebFrameInternal.h: 13316 * WebView/WebTextCompletionController.mm: 13317 (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController. 13318 133192010-12-22 Simon Fraser <simon.fraser@apple.com> 13320 13321 Reviewed by Darin Adler. 13322 13323 Cache snapshots of plug-ins before painting, to avoid script running during painting 13324 https://bugs.webkit.org/show_bug.cgi?id=51493 13325 13326 When FrameView is asked to do a flattening paint (e.g. when Safari snapshots, 13327 or when printing), plug-ins which otherwise use the CA rendering model 13328 are sent a paint event. Some plug-ins may run script while handling this event, 13329 or out of process plug-ins may process queued requests at this time. Running 13330 script while inside layout or painting can have bad consequences, because it 13331 can result in arbitrary changes to the render tree. 13332 13333 This patch avoids sending plug-ins paint events inside of painting. Instead, 13334 we ask the plug-ins to cache a snapshot before we paint, and then the software 13335 paint simply draws that snapshot. 13336 13337 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 13338 (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot, 13339 draw it. Also only send the snapshot message to the plugin proxy if we 13340 know we're snapshotting, since even if creating the snapshot image failed, 13341 we still don't want to call to the plug-in. 13342 13343 * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot. 13344 * Plugins/WebBaseNetscapePluginView.mm: 13345 (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it. 13346 (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot. 13347 13348 * Plugins/WebNetscapePluginView.mm: 13349 (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it. 13350 * WebCoreSupport/WebFrameLoaderClient.mm: 13351 (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it 13352 to cache and clear the snapshots. 13353 133542010-12-21 Cameron Zwarich <zwarich@apple.com> 13355 13356 Reviewed by Darin Adler. 13357 13358 -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data 13359 https://bugs.webkit.org/show_bug.cgi?id=51431 13360 <rdar://problem/8791757> 13361 13362 * Plugins/WebBasePluginPackage.mm: 13363 (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so 13364 it doesn't underflow. 13365 133662010-12-16 Ryosuke Niwa <rniwa@webkit.org> 13367 13368 Reviewed by Cameron Zwarich. 13369 13370 REGRESSION(r74172): 125 java tests fail on Mac 13371 https://bugs.webkit.org/show_bug.cgi?id=51214 13372 13373 The regression was caused by an incorrectly adding sizeof(struct fat_header) 13374 to a pointer for uint32_t as supposed to uint8_t. 13375 13376 Fixed the bug by explicitly casting it to uint8_t* before the addition. 13377 13378 * Plugins/WebBasePluginPackage.mm: 13379 (-[WebBasePluginPackage isNativeLibraryData:]): 13380 133812010-12-15 Cameron Zwarich <zwarich@apple.com> 13382 13383 Reviewed by Darin Adler. 13384 13385 Clang -Wcast-align gives an error in WebBasePluginPackage.mm 13386 https://bugs.webkit.org/show_bug.cgi?id=51144 13387 13388 Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but 13389 we were calling it on a byte array 32 bits at a time. While this is okay in practice, 13390 since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's 13391 inline storage is at the beginning of the Vector, it is still better to fix this 13392 and silence the warning. 13393 13394 * Plugins/WebBasePluginPackage.mm: 13395 (swapIntsInHeader): 13396 (-[WebBasePluginPackage isNativeLibraryData:]): 13397 133982010-12-14 Mark Rowe <mrowe@apple.com> 13399 13400 Reviewed by Sam Weinig. 13401 13402 <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video> 13403 13404 * History/WebHistoryItem.mm: 13405 (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly 13406 always including the target in the output. 13407 134082010-12-13 Alexey Proskuryakov <ap@apple.com> 13409 13410 Reviewed by Adam Barth. 13411 13412 https://bugs.webkit.org/show_bug.cgi?id=50953 13413 DNS Prefetch should be an opt-in feature 13414 13415 * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false. 13416 134172010-12-13 Mike Thole <mthole@apple.com> 13418 13419 Rubber-stamped by John Sullivan. 13420 13421 https://bugs.webkit.org/show_bug.cgi?id=50956 13422 WebAuthenticationPanel.nib appears to have a cut-off sentence 13423 13424 Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text. 13425 The contents of this text field are updated dynamically before the sheet is displayed. 13426 13427 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: 13428 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: 13429 134302010-12-13 Antti Koivisto <antti@apple.com> 13431 13432 Reviewed by Alexey Proskuryakov. 13433 13434 https://bugs.webkit.org/show_bug.cgi?id=50758 13435 <rdar://problem/8722094> 13436 Defer loading print stylesheets 13437 13438 Expose SPI for DRT for making resources load serially. This is useful for testing resource load order. 13439 13440 * WebView/WebView.mm: 13441 (+[WebView _setLoadResourcesSerially:forHost:]): 13442 * WebView/WebViewPrivate.h: 13443 134442010-12-09 Matthew Delaney <mdelaney@apple.com> 13445 13446 Reviewed by Simon Fraser. 13447 13448 Adopt new CG API for canvas 13449 https://bugs.webkit.org/show_bug.cgi?id=50591 13450 13451 * WebCoreSupport/WebSystemInterface.mm: 13452 134532010-10-28 MORITA Hajime <morrita@google.com> 13454 13455 Reviewed by Ojan Vafai. 13456 13457 spellcheck does not check pasted text 13458 https://bugs.webkit.org/show_bug.cgi?id=40092 13459 13460 Added asynchronous spell checking API to WebEditorClient using 13461 -[NSSpellChecker requestCheckingOfString]. 13462 Note that WebEditorSpellCheckResponder is a small class to receive 13463 requested spell-checking result. Note that this feature is 13464 disabled at default. 13465 13466 Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to 13467 enable the feature from LayoutTestController. 13468 13469 * WebCoreSupport/WebEditorClient.h: 13470 * WebCoreSupport/WebEditorClient.mm: 13471 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]): 13472 (-[WebEditorSpellCheckResponder perform]): 13473 (toCoreSpellingResult): 13474 (-[WebEditorSpellCheckResponder WTF::WebCore::]): 13475 (WebEditorClient::requestCheckingOfString): 13476 * WebView/WebPreferenceKeysPrivate.h: 13477 * WebView/WebPreferences.mm: 13478 (+[WebPreferences initialize]): 13479 (-[WebPreferences setAsynchronousSpellCheckingEnabled:]): 13480 (-[WebPreferences asynchronousSpellCheckingEnabled]): 13481 * WebView/WebPreferencesPrivate.h: 13482 * WebView/WebView.mm: 13483 (-[WebView _preferencesChangedNotification:]): 13484 134852010-12-09 Anders Carlsson <andersca@apple.com> 13486 13487 Fix a bug uncovered by clang++. 13488 13489 * WebView/WebHTMLView.mm: 13490 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): 13491 134922010-12-09 Anders Carlsson <andersca@apple.com> 13493 13494 Clang++ build fixes. 13495 13496 Silence a couple of warnings. 13497 13498 * WebView/WebFrame.mm: 13499 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): 13500 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): 13501 * WebView/WebTextCompletionController.mm: 13502 (-[WebTextCompletionController filterKeyDown:]): 13503 135042010-12-09 David Hyatt <hyatt@apple.com> 13505 13506 Reviewed by Dan Bernstein. 13507 13508 https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect 13509 writing-mode. This first part of the patch just patches Mac WebKit 1 views. 13510 13511 * WebView/WebFrameView.mm: 13512 (-[WebFrameView _isVerticalDocument]): 13513 (-[WebFrameView _isFlippedDocument]): 13514 (-[WebFrameView _scrollToEndOfDocument]): 13515 (-[WebFrameView _pageInBlockProgressionDirection:]): 13516 (-[WebFrameView scrollPageUp:]): 13517 (-[WebFrameView scrollPageDown:]): 13518 135192010-12-08 Andy Estes <aestes@apple.com> 13520 13521 Reviewed by Darin Adler. 13522 13523 Enable pre-HTML5 parser quirks for Apple Mail.app 13524 https://bugs.webkit.org/show_bug.cgi?id=50727 13525 13526 * WebView/WebView.mm: 13527 (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding 13528 application is Mail.app. 13529 135302010-12-08 Brian Weinstein <bweinstein@apple.com> 13531 13532 Reviewed by John Sullivan. 13533 13534 REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab 13535 https://bugs.webkit.org/show_bug.cgi?id=50683 13536 13537 If our context menu item already has an action, don't overwrite the action with the context menu 13538 forwarder. 13539 13540 * WebView/WebHTMLView.mm: 13541 (setMenuItemTarget): 13542 135432010-12-08 Anders Carlsson <andersca@apple.com> 13544 13545 Remove an unused variable. 13546 13547 * WebView/WebDynamicScrollBarsView.mm: 13548 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]): 13549 135502010-12-07 Brian Weinstein <bweinstein@apple.com> 13551 13552 Reviewed by John Sullivan. 13553 13554 Layering Violation in ContextMenu - member variable of type HitTestResult 13555 https://bugs.webkit.org/show_bug.cgi?id=50586 13556 13557 Update users of ContextMenu and ContextMenuController to match where the new functions 13558 are located. 13559 13560 * WebCoreSupport/WebContextMenuClient.mm: 13561 (WebContextMenuClient::getCustomMenuFromDefaultItems): 13562 (WebContextMenuClient::contextMenuItemSelected): 13563 * WebView/WebHTMLView.mm: 13564 (-[WebMenuTarget validateMenuItem:]): 13565 135662010-12-07 Brian Weinstein <bweinstein@apple.com> 13567 13568 Reviewed by John Sullivan. 13569 13570 Part of Layering Violation in ContextMenu 13571 https://bugs.webkit.org/show_bug.cgi?id=50586 13572 13573 Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac 13574 was a layering violation. Also, make sure we set the menu item targets for all menu 13575 items before showing them, because the ContextMenu constructor doesn't do that anymore. 13576 13577 * WebView/WebHTMLView.mm: 13578 (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm. 13579 (-[WebMenuTarget WebCore::]): Ditto. 13580 (-[WebMenuTarget setMenuController:WebCore::]): Ditto. 13581 (-[WebMenuTarget forwardContextMenuAction:]): Ditto. 13582 (-[WebMenuTarget validateMenuItem:]): Ditto. 13583 13584 (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget. 13585 (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including 13586 submenus), and calls setMenuItemTarget on them. 13587 (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding 13588 them to the menu. 13589 135902010-12-06 Darin Adler <darin@apple.com> 13591 13592 Reviewed by Sam Weinig. 13593 13594 Pass security origin to make local file decision correctly 13595 https://bugs.webkit.org/show_bug.cgi?id=48603 13596 13597 * WebView/WebPDFView.mm: 13598 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin. 13599 136002010-12-07 Martin Robinson <mrobinson@igalia.com> 13601 13602 Unreviewed, rolling out r73392. 13603 http://trac.webkit.org/changeset/73392 13604 https://bugs.webkit.org/show_bug.cgi?id=50489 13605 13606 This commit caused crashes on the GTK+ bots 13607 13608 * WebView/WebFrame.mm: 13609 (-[WebFrame _canProvideDocumentSource]): 13610 136112010-12-07 Kenichi Ishibashi <bashi@google.com> 13612 13613 Reviewed by Kent Tamura. 13614 13615 Let HTMLObjectElement be a form associated element 13616 https://bugs.webkit.org/show_bug.cgi?id=48821 13617 13618 Modified to use FormAssociatedElement instead of HTMLFormControlElement. 13619 13620 * WebView/WebHTMLRepresentation.mm: 13621 (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use 13622 FormAssociatedElement instead of HTMLFormControlElement. 13623 (-[WebHTMLRepresentation controlsInForm:]): Ditto. 13624 136252010-12-06 Nate Chapin <japhet@chromium.org> 13626 13627 Reviewed by Adam Barth. 13628 13629 Update calls to DocumentWriter. 13630 https://bugs.webkit.org/show_bug.cgi?id=50489 13631 13632 * WebView/WebFrame.mm: 13633 (-[WebFrame _canProvideDocumentSource]): 13634 136352010-12-06 Chris Marrin <cmarrin@apple.com> 13636 13637 Reviewed by Simon Fraser. 13638 13639 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations 13640 https://bugs.webkit.org/show_bug.cgi?id=49388 13641 13642 Got rid of GraphicsLayer::nativeLayer() call, replacing it with 13643 GraphicsLayer::platformLayer(). 13644 13645 * WebCoreSupport/WebChromeClient.mm: 13646 (WebChromeClient::attachRootGraphicsLayer): 13647 136482010-12-04 Dan Bernstein <mitz@apple.com> 13649 13650 Reviewed by Sam Weinig. 13651 13652 WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range 13653 https://bugs.webkit.org/show_bug.cgi?id=50530 13654 13655 * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches: 13656 * WebView/WebHTMLView.mm: 13657 (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter, 13658 which is passed through to WebCore. 13659 * WebView/WebPDFView.mm: 13660 (isFrameInRange): Added this helper function. 13661 (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and 13662 a check if the frame is in the range. 13663 * WebView/WebView.mm: 13664 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version. 13665 (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange 13666 parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:. 13667 * WebView/WebViewPrivate.h: 13668 136692010-12-03 Sam Weinig <sam@webkit.org> 13670 13671 Reviewed by Maciej Stachowiak. 13672 13673 Enable <a ping> for Mac/Windows/WebKit2 builds 13674 <rdar://problem/8504473> 13675 https://bugs.webkit.org/show_bug.cgi?id=50488 13676 13677 * WebView/WebPreferences.mm: 13678 (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default. 13679 136802010-12-03 Jia Pu <jpu@apple.com> 13681 13682 Reviewed by Darin Adler. 13683 13684 Need to move all code that applies correction into correction panel callback. 13685 https://bugs.webkit.org/show_bug.cgi?id=50426 13686 <rdar://problem/8720832> 13687 13688 * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel. 13689 13690 * WebCoreSupport/WebEditorClient.mm: 13691 (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel. 13692 (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code. 13693 (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel. 13694 136952010-12-02 Simon Fraser <simon.fraser@apple.com> 13696 13697 Revert r73217 and r73227 because of continued bustage. 13698 13699 * WebCoreSupport/WebChromeClient.mm: 13700 (WebChromeClient::attachRootGraphicsLayer): 13701 137022010-12-02 Chris Marrin <cmarrin@apple.com> 13703 13704 Reviewed by Simon Fraser. 13705 13706 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations 13707 https://bugs.webkit.org/show_bug.cgi?id=49388 13708 13709 Got rid of GraphicsLayer::nativeLayer() call, replacing it with 13710 GraphicsLayer::platformLayer(). 13711 13712 * WebCoreSupport/WebChromeClient.mm: 13713 (WebChromeClient::attachRootGraphicsLayer): 13714 137152010-12-02 Mark Rowe <mrowe@apple.com> 13716 13717 Reviewed by Beth Dakin. 13718 13719 <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool 13720 13721 * Misc/WebNSFileManagerExtras.m: 13722 (setMetaData): Create an autorelease pool for the duration of the thread body. 13723 137242010-12-02 John Knottenbelt <jknotten@chromium.org> 13725 13726 Reviewed by Steve Block. 13727 13728 Move requestGeolocationPermissionForFrame to GeolocationClient 13729 https://bugs.webkit.org/show_bug.cgi?id=50061 13730 13731 This change facilitates client-based geolocation implementation by 13732 bringing together permission control into the geolocation client 13733 interface. 13734 13735 Move method ChromeClient::requestGeolocationPermissionForFrame to 13736 GeolocationClient::requestPermission, and supporting class 13737 WebGeolocationPolicyListener. The moved code is unchanged except 13738 that requestPermission now takes only one argument (Geolocation*) 13739 and the Frame parameter is retrieved from the Geolocation object. 13740 13741 * WebCoreSupport/WebChromeClient.h: 13742 * WebCoreSupport/WebChromeClient.mm: 13743 * WebCoreSupport/WebGeolocationClient.h: 13744 (WebGeolocationClient::cancelPermissionRequest): 13745 * WebCoreSupport/WebGeolocationClient.mm: 13746 (WebGeolocationClient::requestPermission): 13747 (-[WebGeolocationPolicyListener initWithGeolocation:]): 13748 (-[WebGeolocationPolicyListener allow]): 13749 (-[WebGeolocationPolicyListener deny]): 13750 137512010-12-02 Joseph Pecoraro <joepeck@webkit.org> 13752 13753 Reviewed by Eric Carlson. 13754 13755 Style Fixes in WebPluginController 13756 https://bugs.webkit.org/show_bug.cgi?id=50397 13757 13758 * Plugins/WebPluginController.mm: 13759 (-[WebPluginController startAllPlugins]): 13760 (-[WebPluginController stopAllPlugins]): 13761 137622010-12-02 John Sullivan <sullivan@apple.com> 13763 13764 Reviewed by Adam Roben. 13765 13766 Slightly speculative fix for: 13767 13768 <rdar://problem/8712674> 13769 <https://bugs.webkit.org/show_bug.cgi?id=50393> 13770 setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge] 13771 13772 * Panels/WebAuthenticationPanel.m: 13773 (-[WebAuthenticationPanel setUpForChallenge:]): 13774 If the realm is nil, use @"" instead. 13775 137762010-12-01 Jia Pu <jpu@apple.com> 13777 13778 Reviewed by Darin Adler. 13779 13780 Support multiple correction candidates panel for misspelled word on Mac OS X. 13781 https://bugs.webkit.org/show_bug.cgi?id=50137 13782 <rdar://problem/8568059> 13783 13784 This patch is for supporting multiple correction suggestion panel on Mac OS X. 13785 The behavior and implementation is similar to that of reversion candiate panel. 13786 13787 * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class. 13788 13789 * WebCoreSupport/WebEditorClient.mm: Adopted new signatures defined in base class. 13790 Added code to handle new multiple suggestion canidate panel type. 13791 (WebEditorClient::showCorrectionPanel): 13792 (WebEditorClient::getGuessesForWord): 13793 137942010-12-01 David Hyatt <hyatt@apple.com> 13795 13796 Reviewed by Darin Adler. 13797 13798 https://bugs.webkit.org/show_bug.cgi?id=46645 13799 13800 Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept 13801 recently added for horizontal RTL documents and applies it to writing modes as well. Now the 13802 scrollOrigin is a point, since you can start off locked to the bottom or locked to the right. 13803 13804 This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and 13805 makes them behave the same as the cross-platform code (allowing for cross-platform results to be 13806 landed). 13807 13808 * WebView/WebDynamicScrollBarsView.mm: 13809 (-[WebDynamicScrollBarsView adjustForScrollOriginChange]): 13810 (-[WebDynamicScrollBarsView updateScrollers]): 13811 (-[WebDynamicScrollBarsView reflectScrolledClipView:]): 13812 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]): 13813 (-[WebDynamicScrollBarsView scrollOrigin]): 13814 * WebView/WebFrameView.mm: 13815 (-[WebFrameView _scrollToBeginningOfDocument]): 13816 (-[WebFrameView _scrollToEndOfDocument]): 13817 138182010-11-29 Dan Bernstein <mitz@apple.com> 13819 13820 Reviewed by Darin Adler. 13821 13822 WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API. 13823 https://bugs.webkit.org/show_bug.cgi?id=50038 13824 Based on a patch from Darin Adler. 13825 13826 * WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and 13827 replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based 13828 method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options: 13829 method. Made WebHTMLView conform to the new protocol. 13830 * WebView/WebHTMLView.mm: 13831 (coreOptions): Added. Converts WebFindOptions to WebCore FindOptions. 13832 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use 13833 -findString:options:. 13834 (-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions. 13835 (-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString(). 13836 * WebView/WebPDFView.mm: 13837 (-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions. 13838 * WebView/WebView.mm: 13839 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to 13840 -countMatchesForText:options:highlight:limit:markMatches. 13841 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto. 13842 (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to 13843 -findString:options:. 13844 (incrementFrame): Changed to use WebFindOptions. 13845 (findString): Added this helper method that performs the search using the best supported 13846 method for the document view. 13847 (-[WebView findString:options:]): Changed -searchFor::::: into this. 13848 (-[WebView canMarkAllTextMatches]): 13849 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use 13850 WebFindOptions. 13851 (-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame. 13852 (-[WebView rectsForTextMatches]): Ditto. 13853 * WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version 13854 of countMatchesForText:. 13855 138562010-11-29 Jeremy Moskovich <jeremy@chromium.org> 13857 13858 Reviewed by David Hyatt. 13859 13860 Right-to-left pages should be scrollable to reveal left overflow. 13861 https://bugs.webkit.org/show_bug.cgi?id=23556 13862 13863 Set and get the original x-axis scroll position and reset scroll position on HOME/END key press. 13864 Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for 13865 pages with a left overflow. 13866 13867 * WebView/WebDynamicScrollBarsView.h: 13868 * WebView/WebDynamicScrollBarsView.mm: 13869 (-[WebDynamicScrollBarsView inProgramaticScroll]): 13870 (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]): 13871 (-[WebDynamicScrollBarsView updateScrollers]): 13872 (-[WebDynamicScrollBarsView reflectScrolledClipView:]): 13873 (-[WebDynamicScrollBarsView setScrollOriginX:]): 13874 (-[WebDynamicScrollBarsView scrollOriginX]): 13875 * WebView/WebFrameView.mm: 13876 (-[WebFrameView _scrollToBeginningOfDocument]): 13877 (-[WebFrameView _scrollToEndOfDocument]): 13878 * WebView/WebHTMLView.mm: 13879 (-[WebHTMLView _frameOrBoundsChanged]): 13880 138812010-11-22 Ryosuke Niwa <rniwa@webkit.org> 13882 13883 Reviewed by Tony Chang. 13884 13885 SelectionController::typingStyle() should return EditingStyle* 13886 https://bugs.webkit.org/show_bug.cgi?id=49813 13887 13888 Changed the return value of SelectionController::typingStyle() to EditingStyle*. 13889 Also added SelectionController::copyTypingStyle() to copy the typing style 13890 as an instance of CSSMutableStyleDeclaration. 13891 13892 No tests are added since this is no behavioral change. 13893 13894 * WebView/WebFrame.mm: 13895 (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle() 13896 138972010-11-19 Michael Saboff <msaboff@apple.com> 13898 13899 Reviewed by Sam Weinig 13900 13901 Remove DOMSVGAnimatedPathData.h from all: target to fix build. 13902 13903 * MigrateHeaders.make: 13904 139052010-11-19 Nikolas Zimmermann <nzimmermann@rim.com> 13906 13907 Reviewed by Dirk Schulze. 13908 13909 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept 13910 https://bugs.webkit.org/show_bug.cgi?id=49580 13911 13912 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include. 13913 139142010-11-18 Mark Rowe <mrowe@apple.com> 13915 13916 Rubber-stamped by Adam Roben. 13917 13918 <rdar://problem/8602509&8602717&8602724> Enable compaction support. 13919 13920 * Configurations/WebKit.xcconfig: 13921 139222010-11-18 Sheriff Bot <webkit.review.bot@gmail.com> 13923 13924 Unreviewed, rolling out r72288. 13925 http://trac.webkit.org/changeset/72288 13926 https://bugs.webkit.org/show_bug.cgi?id=49730 13927 13928 'krit attempted to do that, but revert got stuck' (Requested 13929 by antonm on #webkit). 13930 13931 * WebView/WebRenderLayer.mm: 13932 139332010-11-17 Nikolas Zimmermann <nzimmermann@rim.com> 13934 13935 Reviewed by Dirk Schulze. 13936 13937 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept 13938 https://bugs.webkit.org/show_bug.cgi?id=49580 13939 13940 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include. 13941 139422010-11-16 Stephanie Lewis <slewis@apple.com> 13943 13944 Reviewed by Geoff Garen. 13945 13946 <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests 13947 13948 Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for 13949 every WebView, and the WebKit API doesn't support that ownership model. 13950 13951 * WebView/WebDeviceOrientationProviderMock.h: 13952 * WebView/WebDeviceOrientationProviderMock.mm: 13953 (+[WebDeviceOrientationProviderMock shared]): 13954 139552010-11-16 Dave Hyatt <hyatt@apple.com> 13956 13957 Reviewed by Dan Bernstein. 13958 13959 https://bugs.webkit.org/show_bug.cgi?id=11004 13960 13961 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector. 13962 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size, 13963 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version 13964 of the constructor rather than using [NSFont pointSize]. 13965 13966 https://bugs.webkit.org/show_bug.cgi?id=49582 13967 13968 Negative leading is not handled correctly. There are two bugs here. The first is that 13969 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have 13970 set them before so that we can allow them to be < 0. 13971 13972 The second issue is that we should understand where fonts will end up relative to 13973 our baseline (excluding line height), and only allow those boxes to impact ascent and 13974 descent if the actual font box (without factoring in line height) is above or below the 13975 root line box baseline. 13976 13977 Added fast/css/negative-leading.html 13978 13979 These two bug fixes have to land together to keep the Acid 3 test rendering correctly. 13980 13981 * Misc/WebKitNSStringExtras.mm: 13982 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): 13983 (-[NSString _web_widthWithFont:]): 13984 * Misc/WebStringTruncator.mm: 13985 (fontFromNSFont): 13986 * WebView/WebPreferences.mm: 13987 (+[WebPreferences initialize]): 13988 139892010-11-16 Anders Carlsson <andersca@apple.com> 13990 13991 Fix clang++ build. 13992 13993 * WebCoreSupport/WebFrameLoaderClient.mm: 13994 139952010-11-14 Kent Tamura <tkent@chromium.org> 13996 13997 Reviewed by Andreas Kling. 13998 13999 KeyboardEvent::keyIdentifier() should return "const String&" 14000 https://bugs.webkit.org/show_bug.cgi?id=49426 14001 14002 * WebCoreSupport/WebEditorClient.mm: 14003 (selectorForKeyEvent): 14004 Change the type of a variable to have keyIdentifier(); String -> const String& 14005 140062010-11-12 John Knottenbelt <jknotten@chromium.org> 14007 14008 Reviewed by Steve Block. 14009 14010 Rename GeolocationControllerClient to GeolocationClient. 14011 https://bugs.webkit.org/show_bug.cgi?id=49259 14012 14013 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h. 14014 (WebGeolocationClient::webView): 14015 (WebGeolocationClient::setEnableHighAccuracy): 14016 * WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm. 14017 (WebGeolocationClient::WebGeolocationClient): 14018 (WebGeolocationClient::geolocationDestroyed): 14019 (WebGeolocationClient::startUpdating): 14020 (WebGeolocationClient::stopUpdating): 14021 (WebGeolocationClient::lastPosition): 14022 * WebKit.order: 14023 * WebView/WebView.mm: 14024 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 14025 140262010-11-10 Beth Dakin <bdakin@apple.com> 14027 14028 Reviewed by Simon Fraser. 14029 14030 Fix for https://bugs.webkit.org/show_bug.cgi?id=49356 14031 -[WebView _scaleWebView:] should take and origin and scroll the 14032 document 14033 -and corresponding- 14034 <rdar://problem/8643921> 14035 14036 * WebView/WebView.mm: 14037 (-[WebView _scaleWebView:atOrigin:]): 14038 * WebView/WebViewPrivate.h: 14039 140402010-11-10 Csaba Osztrogonác <ossy@webkit.org> 14041 14042 Reviewed by David Hyatt. 14043 14044 HTML5 Ruby support should be mandatory feature 14045 https://bugs.webkit.org/show_bug.cgi?id=49272 14046 14047 Remove Ruby as optional feature. 14048 14049 * Configurations/FeatureDefines.xcconfig: 14050 140512010-11-08 Ned Holbrook <nholbrook@apple.com> 14052 14053 Reviewed by Adam Barth. 14054 14055 Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI. 14056 https://bugs.webkit.org/show_bug.cgi?id=48886 14057 14058 * WebCoreSupport/WebSystemInterface.mm: 14059 (InitWebCoreSystemInterface): 14060 140612010-11-08 Nate Chapin <japhet@chromium.org> 14062 14063 Unreviewed, build fix. 14064 14065 Clumsy typo in r71562. 14066 14067 * Plugins/Hosted/HostedNetscapePluginStream.mm: 14068 (WebKit::HostedNetscapePluginStream::start): 14069 140702010-11-08 Nate Chapin <japhet@chromium.org> 14071 14072 Reviewed by Alexey Proskuryakov. 14073 14074 Interface changes in https://bugs.webkit.org/show_bug.cgi?id=27165 14075 14076 * Plugins/Hosted/HostedNetscapePluginStream.mm: 14077 (WebKit::HostedNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader 14078 * Plugins/WebNetscapePluginStream.mm: 14079 (WebNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader 14080 * WebView/WebView.mm: 14081 (-[WebView _dispatchPendingLoadRequests]): Use resourceLoadScheduler() instead of cache()->loader(). 14082 140832010-11-08 Anders Carlsson <andersca@apple.com> 14084 14085 Reviewed by Dan Bernstein. 14086 14087 Plug-in views should not assume that plugins are RenderEmbeddedObjects 14088 https://bugs.webkit.org/show_bug.cgi?id=49196 14089 <rdar://problem/8638467> 14090 14091 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 14092 (-[WebHostedNetscapePluginView pluginHostDied]): 14093 140942010-11-08 Alexey Proskuryakov <ap@apple.com> 14095 14096 Reviewed by Darin Adler. 14097 14098 https://bugs.webkit.org/show_bug.cgi?id=48685 14099 Notify UI process about focused frame 14100 14101 Added an empty implementation of the new ChromeClient method. 14102 14103 * WebCoreSupport/WebChromeClient.h: 14104 * WebCoreSupport/WebChromeClient.mm: 14105 (WebChromeClient::focusedFrameChanged): 14106 141072010-11-08 Anders Carlsson <andersca@apple.com> 14108 14109 Build fix. 14110 14111 * MigrateHeaders.make: 14112 141132010-11-08 Anders Carlsson <andersca@apple.com> 14114 14115 Reviewed by Adam Roben. 14116 14117 Remove use of HIGetScaleFactor 14118 https://bugs.webkit.org/show_bug.cgi?id=49186 14119 <rdar://problem/8618410> 14120 14121 Scale factors can vary on a display-by-display basis and it doesn't make sense 14122 to compute scale factor event coordinates like this. 14123 14124 * Plugins/WebNetscapePluginEventHandlerCarbon.mm: 14125 (getCarbonEvent): 14126 141272010-11-08 Simon Fraser <simon.fraser@apple.com> 14128 14129 Reviewed by Sam Weinig. 14130 14131 Allow applets to participate in accelerated compositing 14132 https://bugs.webkit.org/show_bug.cgi?id=49117 14133 <rdar://problem/8625819> 14134 14135 If Java is being loaded via the Netscape Plugin API, create a 14136 NetscapePluginWidget so that it has an implementation of platformLayer(). 14137 14138 Also clean up by using early returns. 14139 14140 * WebCoreSupport/WebFrameLoaderClient.mm: 14141 141422010-11-07 Adam Barth <abarth@webkit.org> 14143 14144 Reviewed by Eric Seidel. 14145 14146 Rename Cache to MemoryCache 14147 https://bugs.webkit.org/show_bug.cgi?id=49159 14148 14149 * Misc/WebCache.mm: 14150 (+[WebCache statistics]): 14151 * WebCoreSupport/WebDeviceOrientationClient.mm: 14152 (WebDeviceOrientationClient::setController): 14153 * WebView/WebView.mm: 14154 141552010-11-05 Alexey Proskuryakov <ap@apple.com> 14156 14157 Reviewed by Darin Adler. 14158 14159 https://bugs.webkit.org/show_bug.cgi?id=49100 14160 ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers] 14161 14162 * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]): 14163 Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive 14164 (see bug comments), and there seems to be no harm in executing this function in that case. 14165 141662010-11-05 Chris Marrin <cmarrin@apple.com> 14167 14168 Reviewed by Simon Fraser. 14169 14170 Move resumeAnimations/suspendAnimations from Frame to AnimationController. 14171 https://bugs.webkit.org/show_bug.cgi?id=49073 14172 14173 * WebView/WebFrame.mm: 14174 (-[WebFrame _suspendAnimations]): 14175 (-[WebFrame _resumeAnimations]): 14176 141772010-11-04 Alexey Proskuryakov <ap@apple.com> 14178 14179 Reviewed by Darin Adler. 14180 14181 https://bugs.webkit.org/show_bug.cgi?id=49008 14182 <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp 14183 14184 Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during 14185 the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be 14186 deleted during wait: 14187 - plugin crashed; 14188 - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in 14189 while waiting). 14190 14191 We didn't recognize the latter. 14192 14193 * Plugins/Hosted/NetscapePluginHostProxy.mm: 14194 (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer): 14195 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 14196 (WebKit::NetscapePluginInstanceProxy::waitForReply): 14197 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 14198 (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction): 14199 142002010-11-05 Chris Marrin <cmarrin@apple.com> 14201 14202 Reviewed by Simon Fraser. 14203 14204 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state 14205 https://bugs.webkit.org/show_bug.cgi?id=46945 14206 14207 * WebView/WebFrame.mm: 14208 (-[WebFrame _suspendAnimations]): 14209 (-[WebFrame _resumeAnimations]): 14210 142112010-11-04 Jia Pu <jpu@apple.com> 14212 14213 Reviewed by Dan Bernstein. 14214 14215 reversion bubble in WebViews 14216 https://bugs.webkit.org/show_bug.cgi?id=47630 14217 <rdar://problem/8530960> 14218 14219 This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail. 14220 14221 * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method. 14222 * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code 14223 change to use new reversion API in AppKit. 14224 (WebEditorClient::WebEditorClient): 14225 (WebEditorClient::~WebEditorClient): 14226 (WebEditorClient::respondToChangedSelection): 14227 (WebEditorClient::showCorrectionPanel): 14228 (WebEditorClient::dismissCorrectionPanel): 14229 (WebEditorClient::isShowingCorrectionPanel): 14230 142312010-11-04 Mike Thole <mthole@apple.com> 14232 14233 Reviewed by Dan Bernstein. 14234 14235 Title for images should use localized numerals 14236 https://bugs.webkit.org/show_bug.cgi?id=49017 14237 14238 * WebCoreSupport/WebPlatformStrategies.mm: 14239 (WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer. 14240 142412010-11-02 Daniel Bates <dbates@rim.com> 14242 14243 Reviewed by Adam Barth. 14244 14245 For unnamed frames, window.name returns a generated name 14246 https://bugs.webkit.org/show_bug.cgi?id=6751 14247 14248 Part 1 of 2. 14249 14250 Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port. 14251 14252 * WebView/WebFrame.mm: 14253 (-[WebFrame name]): 14254 142552010-11-01 Brady Eidson <beidson@apple.com> 14256 14257 Reviewed by Anders Carlsson. 14258 14259 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699 14260 Context menu support for WebKit 2. 14261 14262 * WebCoreSupport/WebChromeClient.h: 14263 (WebChromeClient::showContextMenu): 14264 142652010-10-29 Daniel Bates <dbates@rim.com> 14266 14267 No review, rolling out 70971. 14268 http://trac.webkit.org/changeset/70971 14269 https://bugs.webkit.org/show_bug.cgi?id=6751 14270 14271 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since 14272 it caused layout test failures on all bots. In particular, the 14273 child count in a generated frame name differs after this patch. We need 14274 to look into this further. 14275 14276 * WebView/WebFrame.mm: 14277 (-[WebFrame name]): 14278 142792010-10-28 Antonio Gomes <agomes@rim.com> 14280 14281 Reviewed by Ojan Vafai. 14282 14283 Needs a "LinuxEditingBehavior", perhaps with a better name 14284 https://bugs.webkit.org/show_bug.cgi?id=36627 14285 14286 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior. 14287 14288 * WebView/WebFrame.mm: 14289 (core): 14290 * WebView/WebPreferencesPrivate.h: 14291 142922010-10-29 Daniel Bates <dbates@rim.com> 14293 14294 Reviewed by Adam Barth. 14295 14296 For unnamed frames, window.name returns a generated name 14297 https://bugs.webkit.org/show_bug.cgi?id=6751 14298 14299 Modified Mac-port to use FrameTree::uniqueName(). 14300 14301 * WebView/WebFrame.mm: 14302 (-[WebFrame name]): 14303 143042010-10-29 Darin Adler <darin@apple.com> 14305 14306 Reviewed by Sam Weinig. 14307 14308 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring 14309 https://bugs.webkit.org/show_bug.cgi?id=48574 14310 14311 * History/WebBackForwardList.mm: 14312 Use BackForwardListImpl. 14313 143142010-10-29 Alexey Proskuryakov <ap@apple.com> 14315 14316 Rubber-stamped by Sam Weinig. 14317 14318 Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do 14319 create views for subframes. 14320 14321 * WebView/WebViewData.h: Double negation is better than a lie. 14322 143232010-10-27 Jer Noble <jer.noble@apple.com> 14324 14325 Reviewed by Darin Adler. 14326 14327 Full screen video in Safari (still) exits full-screen if you switch to another 14328 app on a multi-display system. 14329 https://bugs.webkit.org/show_bug.cgi?id=47364 14330 <rdar://problem/8382299> 14331 14332 The FullScreen window does not technically close when it deactivates, but the 14333 two NSWindows that make up the FullScreen feature should not hide when deactivated. 14334 14335 * WebView/WebVideoFullscreenController.mm: 14336 (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate. 14337 (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto. 14338 * WebView/WebVideoFullscreenHUDWindowController.mm: 14339 (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto. 14340 143412010-10-29 Alexey Proskuryakov <ap@apple.com> 14342 14343 Reviewed by Darin Adler. 14344 14345 https://bugs.webkit.org/show_bug.cgi?id=48576 14346 Let WebKit2 client know when a frame is a frameset 14347 14348 Added a blank implementation of the new FrameLoaderClient method. 14349 14350 * WebCoreSupport/WebFrameLoaderClient.h: 14351 * WebCoreSupport/WebFrameLoaderClient.mm: 14352 (WebFrameLoaderClient::dispatchDidBecomeFrameset): 14353 143542010-10-29 Csaba Osztrogonác <ossy@webkit.org> 14355 14356 Reviewed by Adam Roben and David Kilzer. 14357 14358 Fix and cleanup of build systems 14359 https://bugs.webkit.org/show_bug.cgi?id=48342 14360 14361 * Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX. 14362 143632010-10-28 Dan Bernstein <mitz@apple.com> 14364 14365 Reviewed by Mark Rowe. 14366 14367 LLVM compiler build fix 14368 14369 * Misc/WebDownload.mm: 14370 (-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to 14371 id<NSURLDownloadDelegate> to match the method signature in NSURLDownload. 14372 143732010-10-28 Ivan Krstić <ike@apple.com> 14374 14375 Reviewed by Mark Rowe. 14376 14377 Remove unused experimental proxied panel interface. 14378 <rdar://problem/7237059> 14379 14380 * Plugins/Hosted/NetscapePluginHostManager.h: 14381 * Plugins/Hosted/NetscapePluginHostManager.mm: 14382 (WebKit::NetscapePluginHostManager::hostForPlugin): 14383 (WebKit::NetscapePluginHostManager::spawnPluginHost): 14384 (WebKit::NetscapePluginHostManager::instantiatePlugin): 14385 * Plugins/Hosted/NetscapePluginHostProxy.mm: 14386 * Plugins/Hosted/WebKitPluginClient.defs: 14387 * Plugins/Hosted/WebKitPluginHost.defs: 14388 * WebCoreSupport/WebSystemInterface.mm: 14389 (InitWebCoreSystemInterface): 14390 * WebView/WebPreferenceKeysPrivate.h: 14391 * WebView/WebPreferences.mm: 14392 (+[WebPreferences initialize]): 14393 * WebView/WebPreferencesPrivate.h: 14394 143952010-10-27 Pratik Solanki <psolanki@apple.com> 14396 14397 Reviewed by Darin Adler. 14398 14399 Improve memSize calculation in [WebView _setCacheModel] 14400 https://bugs.webkit.org/show_bug.cgi?id=48484 14401 14402 * WebView/WebView.mm: 14403 (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2. 14404 (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next 14405 bigger power of 2. Also update WebCore cache settings. 14406 144072010-10-26 Darin Adler <darin@apple.com> 14408 14409 Reviewed by Sam Weinig. 14410 14411 WebKitTestRunner needs to support layoutTestController.dumpBackForwardList 14412 https://bugs.webkit.org/show_bug.cgi?id=42322 14413 rdar://problem/8193631 14414 14415 WebKitTestRunner needs to support layoutTestController.clearBackForwardList 14416 https://bugs.webkit.org/show_bug.cgi?id=42333 14417 rdar://problem/8193643 14418 14419 * History/WebBackForwardList.mm: 14420 (core): Return BackForwardListImpl. 14421 (kit): Take BackForwardListImpl. 14422 (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl. 14423 (-[WebBackForwardList dealloc]): Ditto. 14424 (-[WebBackForwardList finalize]): Ditto. 14425 (-[WebBackForwardList description]): Ditto. 14426 (-[WebBackForwardList setPageCacheSize:]): Ditto. 14427 (-[WebBackForwardList pageCacheSize]): Ditto. 14428 * History/WebBackForwardListInternal.h: Ditto. 14429 * WebView/WebFrameView.mm: 14430 (-[WebFrameView keyDown:]): Ditto. 14431 * WebView/WebView.mm: 14432 (-[WebView initWithCoder:]): Ditto. 14433 (-[WebView encodeWithCoder:]): Ditto. 14434 (-[WebView backForwardList]): Ditto. 14435 (-[WebView setMaintainsBackForwardList:]): Ditto. 14436 144372010-10-27 Chris Rogers <crogers@google.com> 14438 14439 Reviewed by Chris Marrin. 14440 14441 Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit 14442 https://bugs.webkit.org/show_bug.cgi?id=48279 14443 14444 * Configurations/FeatureDefines.xcconfig: 14445 144462010-10-27 Beth Dakin <bdakin@apple.com> 14447 14448 Reviewed by Darin Adler. 14449 14450 Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit 14451 SPI to scale a WebView 14452 -and corresponding- 14453 <rdar://problem/8107667> 14454 14455 This patch adds SPI to Mac WebKit that scales the page by the given 14456 scale factor. 14457 14458 * WebView/WebView.mm: 14459 (-[WebView _scaleWebView:]): 14460 (-[WebView _viewScaleFactor]): 14461 * WebView/WebViewPrivate.h: 14462 144632010-10-27 Dan Bernstein <mitz@apple.com> 14464 14465 Reviewed by Darin Adler. 14466 14467 REGRESSION (r70335): Incorrect article layout in Safari Reader 14468 https://bugs.webkit.org/show_bug.cgi?id=48436 14469 14470 * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS. 14471 * WebView/WebView.mm: 14472 (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against 14473 versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules(). 14474 (-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled() 14475 based on the above. 14476 144772010-10-18 Jer Noble <jer.noble@apple.com> 14478 14479 Reviewed by Eric Carlson. 14480 14481 Safari fullscreen media element tickles when it should not. 14482 14483 https://bugs.webkit.org/show_bug.cgi?id=47861 14484 14485 * WebView/WebVideoFullscreenController.mm: 14486 (-[WebVideoFullscreenController updatePowerAssertions]): 14487 144882010-10-26 Jenn Braithwaite <jennb@chromium.org> 14489 14490 Reviewed by Dmitry Titov. 14491 14492 Resource tracking failure when trying to move a frame between documents 14493 https://bugs.webkit.org/show_bug.cgi?id=44713 14494 14495 * WebCoreSupport/WebFrameLoaderClient.h: 14496 * WebCoreSupport/WebFrameLoaderClient.mm: 14497 (WebFrameLoaderClient::didTransferChildFrameToNewDocument): 14498 Empty method. 14499 (WebFrameLoaderClient::transferLoadingResourceFromPage): 14500 Update resource tracking for a resource load that has been transferred 14501 to a new page. 14502 145032010-10-25 Oliver Hunt <oliver@apple.com> 14504 14505 Reviewed by Gavin Barraclough. 14506 14507 Remove exec and globalData arguments from jsNumber 14508 https://bugs.webkit.org/show_bug.cgi?id=48270 14509 14510 Mechanical removal of exec parameter to jsNumber 14511 14512 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 14513 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): 14514 * Plugins/Hosted/ProxyInstance.mm: 14515 (WebKit::ProxyInstance::numberValue): 14516 145172010-10-24 Dan Bernstein <mitz@apple.com> 14518 14519 Reviewed by Anders Carlsson. 14520 14521 Expose HitTestResult::absoluteMediaURL() via WebKit API 14522 https://bugs.webkit.org/show_bug.cgi?id=48219 14523 14524 * Misc/WebElementDictionary.mm: 14525 (+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to 14526 _absoluteMediaURL. 14527 (-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL(). 14528 * WebKit.exp: Export WebElementMediaURLKey. 14529 * WebView/WebView.mm: Define WebElementMediaURLKey. 14530 * WebView/WebViewPrivate.h: Declare WebElementMediaURLKey. 14531 145322010-10-24 Dan Bernstein <mitz@apple.com> 14533 14534 Reviewed by Simon Fraser. 14535 14536 Removed deprecated methods from the WebHTMLHighlighter private protocol. 14537 14538 * WebCoreSupport/WebChromeClient.mm: 14539 (WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode: 14540 unconditionally. 14541 (WebChromeClient::paintCustomHighlight): Call 14542 -paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally. 14543 * WebView/WebHTMLViewPrivate.h: 14544 145452010-10-23 Xan Lopez <xlopez@igalia.com> 14546 14547 Reviewed by Sam Weinig. 14548 14549 Unify globalData APIs 14550 https://bugs.webkit.org/show_bug.cgi?id=47969 14551 14552 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 14553 (WebKit::NetscapePluginInstanceProxy::evaluate): 14554 (WebKit::NetscapePluginInstanceProxy::invoke): 14555 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 14556 (WebKit::NetscapePluginInstanceProxy::construct): 14557 * WebView/WebScriptDebugDelegate.mm: 14558 (-[WebScriptCallFrame evaluateWebScript:]): 14559 145602010-10-23 David Kilzer <ddkilzer@apple.com> 14561 14562 <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header 14563 14564 Reviewed by Sam Weinig. 14565 14566 The only method defined in WebHTMLRepresentationInternal.h is 14567 also defined in WebHTMLRepresentation.h, so use that instead. 14568 14569 * WebView/WebHTMLRepresentationInternal.h: Removed. 14570 145712010-10-23 Alexey Proskuryakov <ap@apple.com> 14572 14573 Reviewed by Anders Carlsson. 14574 14575 https://bugs.webkit.org/show_bug.cgi?id=48083 14576 <rdar://problem/8489082> Need WebKit2 API for private browsing (48083) 14577 14578 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize the new method. 14579 145802010-10-22 Sam Weinig <sam@webkit.org> 14581 14582 Reviewed by Anders Carlsson. 14583 14584 WebKit2 needs to pass the current event modifier flags when requesting a new window 14585 https://bugs.webkit.org/show_bug.cgi?id=48140 14586 14587 * WebCoreSupport/WebChromeClient.h: 14588 * WebCoreSupport/WebChromeClient.mm: 14589 (WebChromeClient::createWindow): 14590 * WebCoreSupport/WebFrameLoaderClient.h: 14591 * WebCoreSupport/WebFrameLoaderClient.mm: 14592 (WebFrameLoaderClient::dispatchCreatePage): 14593 Add NavigationAction parameter. 14594 145952010-10-21 Andy Estes <aestes@apple.com> 14596 14597 Reviewed by Eric Carlson. 14598 14599 WebKit shouldn't load a plug-in based on file extension if a MIME type 14600 is specified. 14601 https://bugs.webkit.org/show_bug.cgi?id=48046 14602 14603 If a MIME type is specified in an object or embed element, and that MIME 14604 type isn't supported by an installed plug-in, WebKit shouldn't attempt 14605 to find a plug-in based on the file extension of the url attribute. 14606 Doing so can lead to cases where a plug-in is loaded that can't handle 14607 resources of the MIME type specified by the author. 14608 14609 * WebCoreSupport/WebFrameLoaderClient.mm: 14610 (WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by 14611 extension if MIME type is the empty string. 14612 146132010-10-20 Simon Fraser <simon.fraser@apple.com> 14614 14615 Reviewed by Dan Bernstein. 14616 14617 Composited elements drawn twice when WebView is layer-backed 14618 https://bugs.webkit.org/show_bug.cgi?id=48024 14619 <rdar://problem/7916580> 14620 14621 When drawing content in a layer-backed WebView, WebFrame's test 14622 for drawing to a bitmap succeeded, causing us to paint flattened 14623 compositing layers into the view. They would also be rendered 14624 by the normal compositing path, resulting in double rendering. 14625 14626 Fix this by detecting when the WebHTMLView is being drawn into 14627 a layer, and avoiding flattening in that case. 14628 14629 * WebView/WebFrame.mm: 14630 (-[WebFrame _showFlattenedCompositingLayers:]): 14631 (-[WebFrame _drawRect:contentsOnly:]): 14632 * WebView/WebHTMLView.mm: 14633 (-[WebHTMLView drawLayer:inContext:]): 14634 (-[WebHTMLView _web_isDrawingIntoLayer]): 14635 * WebView/WebHTMLViewInternal.h: 14636 146372010-10-20 Dumitru Daniliuc <dumi@chromium.org> 14638 14639 Reviewed by David Levin. 14640 14641 Repost the DatabaseTracker notifications to the main thread, if needed. 14642 https://bugs.webkit.org/show_bug.cgi?id=40655 14643 14644 * Storage/WebDatabaseTrackerClient.mm: 14645 (DidModifyOriginData::dispatchToMainThread): 14646 (DidModifyOriginData::DidModifyOriginData): 14647 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread): 14648 (WebDatabaseTrackerClient::dispatchDidModifyOrigin): 14649 (WebDatabaseTrackerClient::dispatchDidModifyDatabase): 14650 146512010-10-20 Simon Fraser <simon.fraser@apple.com> 14652 14653 Reviewed by Darin Adler. 14654 14655 REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard 14656 https://bugs.webkit.org/show_bug.cgi?id=47369 14657 14658 r46947 added code that limits the size of the layer-backed view on Leopard when 14659 the page height exceeds 4096px (later adjusted to 2048px in r48401). 14660 14661 Later, r67576 altered the geometry flipping behavior to push the geometry flipping 14662 down into WebKit. However, the code that adjusts the hosting layer's sublayer transform 14663 to account for layer-backed view size-limiting was not fixed at the same time. 14664 This change corrects that. 14665 14666 * WebView/WebHTMLView.mm: 14667 (-[WebHTMLView _updateLayerHostingViewPosition]): 14668 146692010-10-19 Simon Fraser <simon.fraser@apple.com> 14670 14671 Reviewed by Dan Bernstein. 14672 14673 <rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews 14674 14675 AppKit has some special code to prevent it meddling with view's layers 14676 under layer-backed WebViews. When a layer-backed WebView became composited, 14677 this caused our layer to remain zero-sized. Fix this by manually 14678 setting the geometry for our layer, if the WebHTMLView has a layer. 14679 14680 This does not seem to be a problem if the WebView becomes layer-backed, or 14681 stops being layer-backed after the WebView starts using compositing. 14682 14683 * WebView/WebHTMLView.mm: 14684 (-[WebHTMLView attachRootLayer:]): 14685 146862010-10-20 Dirk Schulze <krit@webkit.org> 14687 14688 Reviewed by Nikolas Zimmermann. 14689 14690 Merge ColorSpace and ImageColorSpace enums 14691 https://bugs.webkit.org/show_bug.cgi?id=47922 14692 14693 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB 14694 to follow webkit style rules. 14695 14696 * Misc/WebKitNSStringExtras.mm: 14697 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): 14698 146992010-10-19 Alexey Proskuryakov <ap@apple.com> 14700 14701 Reviewed by Anders Carlsson. 14702 14703 https://bugs.webkit.org/show_bug.cgi?id=47933 14704 <rdar://problem/8494337> navigator.language doesn't work in WebKit2 14705 14706 * Misc/WebNSUserDefaultsExtras.mm: Moved code for computing default language to WebCore. 14707 We need to keep _webkit_preferredLanguageCode for Safari. 14708 14709 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 14710 Initialize wkCopyCFLocalizationPreferredName. 14711 14712 * WebCoreSupport/WebViewFactory.mm: Removed defaultLanguage. WebCore was the only caller. 14713 147142010-10-18 Alexey Proskuryakov <ap@apple.com> 14715 14716 Reviewed by David Kilzer. 14717 14718 https://bugs.webkit.org/show_bug.cgi?id=47864 14719 Convert WebNSUserDefaultsExtras.m to .mm 14720 14721 Also, fixed some issues in the process: 14722 - removed locking, which was only necessary when this code was in Foundation; 14723 - fixed notification center observer to actually work (previously, it picked up changes 14724 when application preferences changed, not when system language did); 14725 - removed unused NSString category; 14726 - updated style. 14727 14728 * Misc/WebNSUserDefaultsExtras.m: Removed. 14729 * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m. 14730 (createHTTPStyleLanguageCode): 14731 (+[NSUserDefaults _webkit_defaultsDidChange]): 14732 (addLanguageChangeObserver): 14733 (+[NSUserDefaults _webkit_preferredLanguageCode]): 14734 147352010-10-18 Stuart Morgan <stuartmorgan@chromium.org> 14736 14737 Reviewed by Eric Seidel. 14738 14739 Switch to using the new Carbon NPAPI event declarations, and remove 14740 the old ones. 14741 14742 https://bugs.webkit.org/show_bug.cgi?id=40784 14743 14744 * Plugins/WebNetscapePluginEventHandlerCarbon.mm: 14745 (WebNetscapePluginEventHandlerCarbon::mouseEntered): 14746 (WebNetscapePluginEventHandlerCarbon::mouseExited): 14747 (WebNetscapePluginEventHandlerCarbon::mouseMoved): 14748 (WebNetscapePluginEventHandlerCarbon::focusChanged): 14749 147502010-10-18 Pavel Podivilov <podivilov@chromium.org> 14751 14752 Reviewed by Timothy Hatcher. 14753 14754 Web Inspector: disable private browsing for inspector 14755 https://bugs.webkit.org/show_bug.cgi?id=47827 14756 14757 * WebCoreSupport/WebInspectorClient.mm: 14758 (-[WebInspectorWindowController init]): 14759 147602010-10-14 Ilya Tikhonovsky <loislo@chromium.org> 14761 14762 Reviewed by Pavel Feldman. 14763 14764 Web Inspector: inspector settings/properties/states management 14765 should be extracted into separate class. 14766 14767 We have a lot of flags/values in InspectorController. 14768 Some flags are persisting into profile. 14769 Others are part of inspector state for frontend. 14770 All these flags should keep their values after navigation. 14771 It'd be better to extract these flags/values into separate 14772 class which will care about theirs lifetime. 14773 14774 https://bugs.webkit.org/show_bug.cgi?id=47275 14775 14776 * WebCoreSupport/WebInspectorClient.mm: 14777 (-[WebInspectorWindowController showWindow:]): 14778 (-[WebInspectorWindowController attach]): 14779 (-[WebInspectorWindowController detach]): 14780 147812010-10-13 Gavin Barraclough <barraclough@apple.com> 14782 14783 Reviewed by Oliver Hunt. 14784 14785 https://bugs.webkit.org/show_bug.cgi?id=43987 14786 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder 14787 to construct their internal result string. Remove ScriptString (this is now 14788 redundant). 14789 14790 * WebCoreSupport/WebFrameLoaderClient.mm: 14791 147922010-10-12 Andy Estes <aestes@apple.com> 14793 14794 Rubber-stamped by Darin Adler. 14795 14796 Check in some cleanup from the previous commit. 14797 14798 * WebView/WebView.mm: 14799 (leakMailQuirksUserScriptPath): Renamed to indicate that this function 14800 leaks an NSString. 14801 (-[WebView _injectMailQuirksScript]): Moved a static initialization from 14802 a separate class method into the only method that used it and removed 14803 the now-unnecessary class method. 14804 148052010-10-12 Eric Seidel <eric@webkit.org> 14806 14807 Reviewed by Darin Adler. 14808 14809 REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone 14810 https://bugs.webkit.org/show_bug.cgi?id=45693 14811 14812 Re-implement this former WebCore parser quirk as a 14813 Mac-only userscript-based quirk. As far as I can tell 14814 from Darin's description this should satisfy Mail's needs. 14815 14816 * Misc/MailQuirksUserScript.js: Added. 14817 * WebView/WebView.mm: 14818 (+[WebView _mailQuirksUserScript]): 14819 (-[WebView _injectMailQuirksScript]): 14820 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 14821 148222010-10-12 Simon Fraser <simon.fraser@apple.com> 14823 14824 Reviewed by Sam Weinig. 14825 14826 Add 'didDraw' callback for framerate tracking 14827 https://bugs.webkit.org/show_bug.cgi?id=47478 14828 14829 Add a callback at the end of -[WebHTMLView drawRect:] so 14830 a delegate can get notified when a draw happens. 14831 14832 * WebView/WebHTMLView.mm: 14833 (-[WebHTMLView drawRect:]): 14834 * WebView/WebUIDelegatePrivate.h: 14835 148362010-10-11 Anders Carlsson <andersca@apple.com> 14837 14838 Reviewed by Darin Adler. 14839 14840 Remove WebIconFetcher from WebKit and IconFetcher from WebCore 14841 https://bugs.webkit.org/show_bug.cgi?id=47523 14842 14843 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses. 14844 14845 * Misc/WebIconFetcher.h: Removed. 14846 * Misc/WebIconFetcher.mm: Removed. 14847 * Misc/WebIconFetcherInternal.h: Removed. 14848 * WebView/WebFrame.mm: 14849 * WebView/WebFramePrivate.h: 14850 148512010-10-11 Jessie Berlin <jberlin@apple.com> 14852 14853 Reviewed by Darin Adler. 14854 14855 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal 14856 representation of a WebKit1 WebSerializedJSValue. 14857 https://bugs.webkit.org/show_bug.cgi?id=47439 14858 14859 * WebView/WebSerializedJSValue.mm: 14860 (-[WebSerializedJSValue internalRepresentation]): 14861 * WebView/WebSerializedJSValuePrivate.h: 14862 148632010-10-07 Jessie Berlin <jberlin@apple.com> 14864 14865 Reviewed by Sam Weinig. 14866 14867 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal 14868 representation of a WebKit2 WebSerializedScriptValue. 14869 https://bugs.webkit.org/show_bug.cgi?id=47390 14870 14871 * WebView/WebSerializedJSValue.mm: 14872 (-[WebSerializedJSValue initWithInternalRepresentation:]): 14873 Set the WebSerializedJSValuePrivate's WebCore::SerializedScriptValue to be the passed in 14874 internal representation. 14875 * WebView/WebSerializedJSValuePrivate.h: Added. 14876 148772010-10-07 Antonio Gomes <agomes@rim.com> 14878 14879 Reviewed by Simon Fraser. 14880 14881 [Mac] [DRT] implement setSpatialNavigationEnabled 14882 https://bugs.webkit.org/show_bug.cgi?id=47291 14883 14884 Added the needed bits to make it possible to enabled spatial navigation 14885 for the Mac port. For now it is being only used by DRT. 14886 14887 * WebView/WebPreferenceKeysPrivate.h: 14888 * WebView/WebPreferences.mm: 14889 (+[WebPreferences initialize]): 14890 (-[WebPreferences isSpatialNavigationEnabled]): 14891 (-[WebPreferences setSpatialNavigationEnabled:]): 14892 * WebView/WebPreferencesPrivate.h: 14893 * WebView/WebView.mm: 14894 (-[WebView _preferencesChangedNotification:]): 14895 148962010-10-07 Jer Noble <jer.noble@apple.com> 14897 14898 Fix the Leopard 64-bit build. 14899 14900 * Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the 14901 framework search path. 14902 * WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>. 14903 149042010-10-06 Jer Noble <jer.noble@apple.com> 14905 14906 Reviewed by Darin Adler. 14907 14908 Screensaver starts while watching fullscreen playback. 14909 https://bugs.webkit.org/show_bug.cgi?id=47299 14910 <rdar://problem/8478956> 14911 14912 To disable the Screen Saver, we need to periodically call UpdateSystemActivity(). 14913 14914 * WebView/WebVideoFullscreenController.h: Added _tickleTimer. 14915 * WebView/WebVideoFullscreenController.mm: 14916 (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer. 14917 (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer. 14918 (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer. 14919 (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity(). 14920 (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer 14921 or _disableTickleTimer. 14922 149232010-10-05 Philippe Normand <pnormand@igalia.com> 14924 14925 Reviewed by Martin Robinson. 14926 14927 check for ENABLE(GLIB_SUPPORT) in WebView 14928 https://bugs.webkit.org/show_bug.cgi?id=46788 14929 14930 Use ENABLE(GLIB_SUPPORT) in WebView to guard the glib runloop observer. 14931 14932 * WebView/WebView.mm: 14933 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 14934 (-[WebView _close]): 14935 * WebView/WebViewData.h: 14936 * WebView/WebViewInternal.h: 14937 149382010-10-01 Anders Carlsson <andersca@apple.com> 14939 14940 Fix Snow Leopard build. 14941 14942 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 14943 (WebKit::NetscapePluginInstanceProxy::getProxy): 14944 149452010-10-01 Anders Carlsson <andersca@apple.com> 14946 14947 Reviewed by Dan Bernstein. 14948 14949 Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it 14950 https://bugs.webkit.org/show_bug.cgi?id=47022 14951 <rdar://problem/8504712> 14952 14953 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 14954 (WebKit::NetscapePluginInstanceProxy::getProxy): 14955 * Plugins/WebBaseNetscapePluginView.h: 14956 * Plugins/WebBaseNetscapePluginView.mm: 14957 * Plugins/WebNetscapePluginView.mm: 14958 (-[WebNetscapePluginView getVariable:forURL:value:length:]): 14959 149602010-09-30 Darin Adler <darin@apple.com> 14961 14962 Reviewed by Sam Weinig. 14963 14964 Remove remaining calls to deprecatedParseURL 14965 https://bugs.webkit.org/show_bug.cgi?id=26599 14966 14967 * DOM/WebDOMOperations.mm: 14968 (-[DOMDocument URLWithAttributeString:]): 14969 * WebCoreSupport/WebFrameLoaderClient.mm: 14970 (WebFrameLoaderClient::createPlugin): 14971 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL. 14972 149732010-09-30 Anders Carlsson <andersca@apple.com> 14974 14975 Reviewed by Darin Adler. 14976 14977 -[DOMDocument _documentRange] throws an exception if there is no document element 14978 https://bugs.webkit.org/show_bug.cgi?id=46934 14979 <rdar://problem/8169260> 14980 14981 If there is no document element, just return an empty range. Otherwise we'll try to call 14982 Range::selectNode with a null Node which will throw a NOT_FOUND exception. 14983 14984 * DOM/WebDOMOperations.mm: 14985 (-[DOMDocument _documentRange]): 14986 149872010-09-30 Chris Marrin <cmarrin@apple.com> 14988 14989 Reviewed by Simon Fraser. 14990 14991 Make 2D accelerated canvas rendering build on Mac 14992 https://bugs.webkit.org/show_bug.cgi?id=46007 14993 14994 Added ACCELERATED_2D_CANVAS to FeatureDefines 14995 14996 * Configurations/FeatureDefines.xcconfig: 14997 149982010-09-30 Dan Bernstein <mitz@apple.com> 14999 15000 Reviewed by John Sullivan. 15001 15002 Add printing SPI allowing full control over shrink-to-fit 15003 https://bugs.webkit.org/show_bug.cgi?id=46877 15004 15005 * WebView/WebHTMLView.mm: 15006 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added. 15007 * WebView/WebHTMLViewPrivate.h: 15008 150092010-09-28 Johnny Ding <jnd@chromium.org> 15010 15011 Reviewed by Adam Barth. 15012 15013 https://bugs.webkit.org/show_bug.cgi?id=41292 15014 Some windowed plugins did not handle events through EventHandler, so we 15015 never set right gesture state for those events. 15016 This change is to set right allowPopupsFromPlugin flag to current 15017 execution frame, so WeKit can always get right gesture state on Mac. 15018 From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app" 15019 process, that process passes the allowPopupsFromPlugin flag to 15020 WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in 15021 NetscapePluginInstanceProxy::evaluate. 15022 15023 * Plugins/WebNetscapePluginView.mm: 15024 (-[WebNetscapePluginView sendEvent:isDrawRect:]): 15025 150262010-09-28 Jenn Braithwaite <jennb@chromium.org> 15027 15028 Reviewed by Dmitry Titov. 15029 15030 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument. 15031 https://bugs.webkit.org/show_bug.cgi?id=46663 15032 15033 * WebCoreSupport/WebFrameLoaderClient.h: 15034 * WebCoreSupport/WebFrameLoaderClient.mm: 15035 (WebFrameLoaderClient::didTransferChildFrameToNewDocument): 15036 150372010-09-26 Antonio Gomes <agomes@rim.com> 15038 15039 Reviewed by Kenneth Rohde Christiansen. 15040 15041 DRT/Mac nodesFromRect support 15042 15043 [Mac][DRT] Implement LayoutTestController::nodesFromRect 15044 https://bugs.webkit.org/show_bug.cgi?id=46580 15045 15046 Implement nodesFromRect as a private method to access non-exposed Document 15047 methods, similarly to computedStyleIncludingVisitedInfo. 15048 15049 * WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list. 15050 These headers makes it possible to: 15051 1) Get a Document off of a JSDocument; 15052 2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList> 15053 gotten from Document::nodesFromRect to JS bindings. 15054 (-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]): 15055 * WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the 15056 Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo. 15057 150582010-09-24 Jia Pu <jpu@apple.com> 15059 15060 Reviewed by Dan Bernstein. 15061 15062 automaticSpellingCorrectionEnabled isn't updated. 15063 https://bugs.webkit.org/show_bug.cgi?id=46486 15064 <rdar://problem/8475212> 15065 15066 * WebView/WebView.mm: 15067 (+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled" 15068 instead of "automaticTextReplacementEnabled". 15069 150702010-09-23 Alexey Proskuryakov <ap@apple.com> 15071 15072 Reviewed by Darin Adler. 15073 15074 https://bugs.webkit.org/show_bug.cgi?id=46380 15075 REGRESSION: Crash when downloading a file 15076 15077 Downloading cannot be tested in DRT. 15078 15079 * Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): 15080 Don't copy null strings. 15081 150822010-09-24 Ilya Tikhonovsky <loislo@chromium.org> 15083 15084 Reviewed by Yury Semikhatsky. 15085 15086 Web Inspector: CRASH at node highlight on MAC Safari. 15087 1) run-safari --debug 15088 2) open inspector 15089 3) open elements panel 15090 4) hover mouse over elements panel items multiple times 15091 5) CRASH 15092 Looks like it is a race condition. WebNodeHighlightView doesn't check 15093 the pointer to WebNodeHighligh object and it can be nil. 15094 15095 https://bugs.webkit.org/show_bug.cgi?id=46261 15096 15097 * WebInspector/WebNodeHighlightView.mm: 15098 (-[WebNodeHighlightView drawRect:]): 15099 151002010-09-23 Andy Estes <aestes@apple.com> 15101 15102 Reviewed by Darin Adler. 15103 15104 REGRESSION (r61285): some Dashboard widgets are always invisible due to 15105 HTML parser changes. 15106 https://bugs.webkit.org/show_bug.cgi?id=46435 15107 15108 Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility 15109 mode. 15110 15111 * WebView/WebView.mm: 15112 (-[WebView _needsPreHTML5ParserQuirks]): Renamed from 15113 shouldUsePreHTML5ParserQuirks(). Return true if 15114 WebCore::Settings::usesDashboardCompatibilityMode() is true. 15115 (-[WebView _preferencesChangedNotification:]): 15116 (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks 15117 if Dashboard behavior is set to backward compatibility mode. 15118 151192010-09-23 Matthew Delaney <mdelaney@apple.com> 15120 15121 Reviewed by Simon Fraser. 15122 15123 Reduce minimum DOMTimer interval 15124 https://bugs.webkit.org/show_bug.cgi?id=45362 15125 15126 * WebView/WebView.mm: 15127 Updating set interval call to use Settings' static version inside 15128 one time init block. 15129 151302010-09-22 Andy Estes <aestes@apple.com> 15131 15132 Reviewed by Darin Adler. 15133 15134 REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window 15135 https://bugs.webkit.org/show_bug.cgi?id=46334 15136 15137 Microsoft My Day loads scripts using self-closing script tags, markup 15138 which is incompatible with the HTML5 parser. Enable parser quirks for 15139 this application. 15140 15141 * WebView/WebView.mm: 15142 (shouldUsePreHTML5ParserQuirks): Return true if the application is 15143 Microsoft My Day and was linked against a version of WebKit prior to the 15144 introduction of the HTML5 parser. 15145 151462010-09-23 Nate Chapin <japhet@chromium.org> 15147 15148 Reviewed by Darin Fisher. 15149 15150 Add hyperlink auditing settings (i.e., <a ping>). 15151 https://bugs.webkit.org/show_bug.cgi?id=30458 15152 15153 * WebView/WebPreferenceKeysPrivate.h: 15154 * WebView/WebPreferences.mm: 15155 (+[WebPreferences initialize]): 15156 (-[WebPreferences setMemoryInfoEnabled:]): 15157 (-[WebPreferences hyperlinkAuditingEnabled]): 15158 (-[WebPreferences setHyperlinkAuditingEnabled:]): 15159 * WebView/WebPreferencesPrivate.h: 15160 * WebView/WebView.mm: 15161 (-[WebView _preferencesChangedNotification:]): 15162 151632010-09-22 Alexey Proskuryakov <ap@apple.com> 15164 15165 Reviewed by Anders Carlsson. 15166 15167 https://bugs.webkit.org/show_bug.cgi?id=43667 15168 ASSERT failure in NetscapePluginInstanceProxy::disconnectStream 15169 15170 Test: plugins/get-javascript-url.html 15171 15172 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 15173 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just 15174 like any other one. 15175 151762010-09-21 Darin Adler <darin@apple.com> 15177 15178 Reviewed by Anders Carlsson. 15179 15180 Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release 15181 https://bugs.webkit.org/show_bug.cgi?id=46220 15182 15183 * Misc/WebNSFileManagerExtras.m: 15184 (setMetaData): Use CFRelease instead of HardRelease. 15185 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Use CFStringCreateCopy 15186 instead of -[NSObject copy] combined with HardRetainWithNSRelease. 15187 151882010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu> 15189 15190 Reviewed by Kenneth Rohde Christiansen. 15191 15192 PluginStrategy should satisfy the needs of Qt 15193 https://bugs.webkit.org/show_bug.cgi?id=45857 15194 No new functionality so no new tests. 15195 15196 * WebCoreSupport/WebPlatformStrategies.h: 15197 * WebCoreSupport/WebPlatformStrategies.mm: 15198 (WebPlatformStrategies::getPluginInfo): 15199 152002010-09-22 Paul Knight <pknight@apple.com> 15201 15202 Reviewed by Simon Fraser. 15203 15204 -[WebView _scheduleCompositingLayerSync] should wake the run loop 15205 https://bugs.webkit.org/show_bug.cgi?id=46226 15206 15207 Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting. 15208 15209 * WebView/WebView.mm: 15210 (-[WebView _scheduleCompositingLayerSync]): 15211 152122010-09-21 Andy Estes <aestes@apple.com> 15213 15214 Reviewed by Darin Adler. 15215 15216 REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen 15217 https://bugs.webkit.org/show_bug.cgi?id=46134 15218 15219 AIM clients linked against versions of WebKit prior to the introduction 15220 of the HTML5 parser contain markup incompatible with the new parser. 15221 Enable parser quirks in this case to remain compatible with these 15222 clients. 15223 15224 * WebView/WebView.mm: 15225 (shouldUsePreHTML5ParserQuirks): Returns true if the embedding 15226 application is AIM and was linked against a version of WebKit prior to 15227 the introduction of the HTML5 parser, or if the 15228 WebKitPreHTML5ParserQuirks WebPreference is enabled. 15229 (-[WebView _preferencesChangedNotification:]): Call 15230 WebCore::Settings::setUsePreHTML5ParserQuirks(). 15231 152322010-09-21 Steve Block <steveblock@google.com> 15233 15234 Reviewed by Jeremy Orlow. 15235 15236 DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods 15237 https://bugs.webkit.org/show_bug.cgi?id=45891 15238 15239 Implements WebDeviceOrientationClient::deviceOrientationControllerDestroyed to delete the client. 15240 15241 * WebCoreSupport/WebDeviceOrientationClient.h: 15242 * WebCoreSupport/WebDeviceOrientationClient.mm: 15243 (WebDeviceOrientationClient::deviceOrientationControllerDestroyed): 15244 152452010-09-20 Philippe Normand <pnormand@igalia.com> 15246 15247 Reviewed by Eric Carlson. 15248 15249 [GTK] enhanced context menu for media elements 15250 https://bugs.webkit.org/show_bug.cgi?id=45021 15251 15252 New localized strings for the media element context-menu. 15253 15254 * WebCoreSupport/WebPlatformStrategies.h: 15255 * WebCoreSupport/WebPlatformStrategies.mm: 15256 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): 15257 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): 15258 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): 15259 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): 15260 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls): 15261 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): 15262 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): 15263 (WebPlatformStrategies::contextMenuItemTagMediaPlay): 15264 (WebPlatformStrategies::contextMenuItemTagMediaPause): 15265 (WebPlatformStrategies::contextMenuItemTagMediaMute): 15266 152672010-09-20 Andy Estes <aestes@apple.com> 15268 15269 Reviewed by Adam Barth. 15270 15271 REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes 15272 https://bugs.webkit.org/show_bug.cgi?id=40961 15273 15274 Implement WebKitUsePreHTML5ParserQuirks preference. 15275 15276 * WebView/WebPreferenceKeysPrivate.h: 15277 * WebView/WebPreferences.mm: 15278 (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to 15279 false. 15280 (-[WebPreferences usePreHTML5ParserQuirks]): 15281 (-[WebPreferences setUsePreHTML5ParserQuirks:]): 15282 * WebView/WebPreferencesPrivate.h: 15283 * WebView/WebView.mm: 15284 (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings 15285 with the value of WebKitUsePreHTML5ParserQuirks when a preference 15286 changes. 15287 152882010-09-20 Enrica Casucci <enrica@apple.com> 15289 15290 Reviewed by Sam Weinig. 15291 15292 Pasteboard doesn't work in WebKit2. 15293 https://bugs.webkit.org/show_bug.cgi?id=42317 15294 <rdar://problem/7660537> 15295 15296 Some changes to fix style inconsistencies. 15297 Added OBJC 2.0 style enumeration. 15298 15299 * WebCoreSupport/WebEditorClient.h: 15300 * WebCoreSupport/WebEditorClient.mm: 15301 (WebEditorClient::userVisibleString): 15302 (createExcludedElementsForAttributedStringConversion): 15303 (WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be 15304 a Vector of RefPtr. 15305 (WebEditorClient::setInsertionPasteboard): 15306 (WebEditorClient::pasteboardTypesForSelection): 15307 153082010-09-17 David Hyatt <hyatt@apple.com> 15309 15310 Reviewed by Simon Fraser. 15311 15312 https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model. 15313 15314 Make printing store the page height in the RenderView and push that into the layout state to 15315 use the new pagination model. The old pagination model is retained because it is still used 15316 for embedded WebViews. 15317 15318 * WebView/WebHTMLView.mm: 15319 (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): 15320 153212010-09-17 Darin Adler <darin@apple.com> 15322 15323 Reviewed by Sam Weinig. 15324 15325 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload 15326 https://bugs.webkit.org/show_bug.cgi?id=42863 15327 15328 * WebView/WebView.mm: 15329 (-[WebView _setZoomMultiplier:isTextOnly:]): 15330 Call functions on Frame instead of FrameView. 15331 153322010-09-17 Matthew Delaney <mdelaney@apple.com> 15333 15334 Reviewed by Simon Fraser. 15335 15336 Reduce minimum DOMTimer interval 15337 https://bugs.webkit.org/show_bug.cgi?id=45362 15338 15339 * WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms. 15340 153412010-09-17 Chris Marrin <cmarrin@apple.com> 15342 15343 Reviewed by Simon Fraser. 15344 15345 Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac 15346 https://bugs.webkit.org/show_bug.cgi?id=45911 15347 15348 * WebView/WebPreferenceKeysPrivate.h: 15349 * WebView/WebPreferences.mm: 15350 (+[WebPreferences initialize]): 15351 (-[WebPreferences accelerated2dCanvasEnabled]): 15352 (-[WebPreferences setAccelerated2dCanvasEnabled:]): 15353 * WebView/WebPreferencesPrivate.h: 15354 * WebView/WebView.mm: 15355 (-[WebView _preferencesChangedNotification:]): 15356 153572010-09-17 Jia Pu <jpu@apple.com> 15358 15359 Reviewed by Dan Bernstein. 15360 15361 WebKit should use system wide spell checking preference when application specific one isn't set. 15362 https://bugs.webkit.org/show_bug.cgi?id=45789 15363 <rdar://problem/8416041> 15364 15365 * WebView/WebView.mm: 15366 (+[WebView initialize]): Use system wide autocorrection and text substitution preferences 15367 when the application level preferences are not set. 15368 153692010-09-16 John Sullivan <sullivan@apple.com> 15370 15371 Reviewed by Darin Adler. 15372 15373 <rdar://problem/8395558> 15374 https://bugs.webkit.org/show_bug.cgi?id=45938 15375 _web_makePluginViewsPerformSelector:: mutates subviews array while iterating it 15376 15377 * WebView/WebHTMLView.mm: 15378 (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): 15379 Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method 15380 was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into 15381 this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews] 15382 before enumerating it, to ensure that the selector can't mutate the array being enumerated. 15383 (-[WebHTMLView viewWillMoveToHostWindow:]): 15384 Updated for _web_makePluginSubviewsPerformSelector:: signature change. 15385 (-[WebHTMLView viewDidMoveToHostWindow]): 15386 Ditto. 15387 153882010-09-16 Darin Adler <darin@apple.com> 15389 15390 Reviewed by Andreas Kling. 15391 15392 Reduce use of HTMLInputElement::inputType so we can remove it later 15393 https://bugs.webkit.org/show_bug.cgi?id=45903 15394 15395 * WebView/WebHTMLRepresentation.mm: 15396 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField. 15397 (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField. 15398 153992010-09-16 Patrick Gansterer <paroga@paroga.com> 15400 15401 Reviewed by Darin Adler. 15402 15403 Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey. 15404 https://bugs.webkit.org/show_bug.cgi?id=41510 15405 15406 This prevents usage of nil value, which would cause an uncaught exception. 15407 15408 * WebView/WebPreferences.mm: 15409 (-[WebPreferences setUserStyleSheetLocation:]): 15410 154112010-09-16 Dan Bernstein <mitz@apple.com> 15412 15413 Reverted the previous change because r67628 has been reverted. 15414 15415 * WebCoreSupport/WebPlatformStrategies.h: 15416 * WebCoreSupport/WebPlatformStrategies.mm: 15417 154182010-09-16 Dan Bernstein <mitz@apple.com> 15419 15420 Build fix after r67628. Added context menu item localizable strings for the items 15421 added in r67628, following equivalent menu items in Mac OS X when possible. However, 15422 this set of menu items does not make much sense for Mac OS X, and this should be 15423 addressed separately. 15424 15425 * WebCoreSupport/WebPlatformStrategies.h: 15426 * WebCoreSupport/WebPlatformStrategies.mm: 15427 (WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow): 15428 (WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard): 15429 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls): 15430 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): 15431 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): 15432 (WebPlatformStrategies::contextMenuItemTagMediaPlay): 15433 (WebPlatformStrategies::contextMenuItemTagMediaPause): 15434 (WebPlatformStrategies::contextMenuItemTagMediaMute): 15435 (WebPlatformStrategies::contextMenuItemTagMediaUnMute): 15436 154372010-09-16 Eric Uhrhane <ericu@chromium.org> 15438 15439 Reviewed by Jian Li. 15440 15441 Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM. 15442 https://bugs.webkit.org/show_bug.cgi?id=45798 15443 15444 * Configurations/FeatureDefines.xcconfig: 15445 154462010-09-15 Simon Fraser <simon.fraser@apple.com> 15447 15448 Reviewed by Adam Roben. 15449 15450 https://bugs.webkit.org/show_bug.cgi?id=44715 15451 maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac 15452 15453 Move geometry flipping to platform-specific code. 15454 15455 * WebView/WebHTMLView.mm: 15456 (-[WebHTMLView attachRootLayer:]): 15457 154582010-09-14 Jia Pu <jpu@apple.com> 15459 15460 Reviewed by Dan Bernstein. 15461 15462 Only intercept ESC key press when autocorrection UI is visible. 15463 https://bugs.webkit.org/show_bug.cgi?id=45071 15464 15465 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(), 15466 which provides an inteface to query whether autocorrection panel is shown. 15467 15468 * WebCoreSupport/WebEditorClient.mm: 15469 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag, 15470 for invalid correction panel tag. Replaced -1 with this constant. 15471 (WebEditorClient::dismissCorrectionPanel): Ditto 15472 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown. 15473 154742010-09-14 Mark Rowe <mrowe@apple.com> 15475 15476 Reviewed by John Sullivan. 15477 15478 Part of <rdar://problem/8420003>. Make it possible to override the version number used in linked-in-or-after checks. 15479 15480 * Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version. 15481 * Misc/WebKitVersionChecks.m: 15482 (WebKitLinkedOnOrAfter): 15483 (setWebKitLinkTimeVersion): Set the overridden version. 15484 (WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing. 15485 * WebView/WebPreferences.mm: 15486 (+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version. 15487 * WebView/WebPreferencesPrivate.h: 15488 154892010-09-14 Eric Seidel <eric@webkit.org> 15490 15491 Unreviewed, reverting changes r67451 and r67451. 15492 Broke lots of builders. 15493 15494 Only intercept ESC key press when autocorrection UI is visible. 15495 https://bugs.webkit.org/show_bug.cgi?id=45071 15496 15497 * WebCoreSupport/WebEditorClient.h: 15498 * WebCoreSupport/WebEditorClient.mm: 15499 (WebEditorClient::WebEditorClient): 15500 (WebEditorClient::dismissCorrectionPanel): 15501 155022010-09-14 Jia Pu <jpu@apple.com> 15503 15504 Reviewed by Dan Bernstein. 15505 15506 Only intercept ESC key press when autocorrection UI is visible. 15507 https://bugs.webkit.org/show_bug.cgi?id=45071 15508 15509 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(), 15510 which provides an inteface to query whether autocorrection panel is shown. 15511 15512 * WebCoreSupport/WebEditorClient.mm: 15513 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag, 15514 for invalid correction panel tag. Replaced -1 with this constant. 15515 (WebEditorClient::dismissCorrectionPanel): Ditto 15516 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown. 15517 155182010-09-13 Darin Adler <darin@apple.com> 15519 15520 Reviewed by Adam Barth. 15521 15522 Preparation for eliminating deprecatedParseURL 15523 https://bugs.webkit.org/show_bug.cgi?id=45695 15524 15525 * DOM/WebDOMOperations.mm: 15526 (-[DOMDocument webFrame]): Get rid of unneeded local variable. 15527 (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment. 15528 155292010-09-13 Enrica Casucci <enrica@apple.com> 15530 15531 Reviewed by Sam Weinig. 15532 15533 Paste should be implemented in WebCore like Copy and Cut for Mac also. 15534 https://bugs.webkit.org/show_bug.cgi?id=45494 15535 <rdar://problem/7660537> 15536 15537 On the Mac platform, the implementation of the paste operation is all done 15538 at the WebKit level. In order to support it on WebKit2 it is necessary to 15539 refactor the code and move this functionality at the level of WebCore like 15540 we already have on Windows. 15541 The original code relies on some in AppKit functions that call back into 15542 WebKit causing problems in WebKit2. All this functionality has been moved 15543 at the level of the editor client where it can be dealt with appropriately. 15544 15545 * WebCoreSupport/WebEditorClient.h: 15546 * WebCoreSupport/WebEditorClient.mm: 15547 (excludedElementsForAttributedStringConversion): 15548 (WebEditorClient::documentFragmentFromAttributedString): Added. 15549 (WebEditorClient::setInsertionPasteboard): 15550 * WebCoreSupport/WebFrameLoaderClient.h: 15551 * WebCoreSupport/WebFrameLoaderClient.mm: 15552 (WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level 15553 of the editor client. 15554 * WebView/WebHTMLView.mm: Removed paste method. 15555 155562010-09-13 John Sullivan <sullivan@apple.com> 15557 15558 Reviewed by Adam Roben. 15559 15560 https://bugs.webkit.org/show_bug.cgi?id=45677 15561 [WebView canMarkAllTextMatches] can crash if called after [WebView close] 15562 15563 <rdar://problem/8404890> 15564 15565 * WebView/WebView.mm: 15566 (-[WebView canMarkAllTextMatches]): 15567 Return NO immediately if the webview has already been closed. This was an overlooked 15568 case from the fix for 45175. 15569 155702010-09-10 MORITA Hajime <morrita@google.com> 15571 15572 Reviewed by Tony Chang. 15573 15574 [Chromium] Implement textInputController.hasSpellingMarker() for Chromium 15575 https://bugs.webkit.org/show_bug.cgi?id=45441 15576 15577 Moved the actual logic of hasSpellingMarker into WebCore to share 15578 it with other ports. 15579 15580 * WebView/WebFrame.mm: 15581 (-[WebFrame hasSpellingMarker:length:]): 15582 155832010-09-11 Adam Barth <abarth@webkit.org> 15584 15585 Reviewed by Sam Weinig. 15586 15587 Make SecurityOrigin::canDisplay an instance function 15588 https://bugs.webkit.org/show_bug.cgi?id=45219 15589 15590 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 15591 (WebKit::NetscapePluginInstanceProxy::loadRequest): 15592 * Plugins/WebNetscapePluginStream.mm: 15593 (WebNetscapePluginStream::WebNetscapePluginStream): 15594 * Plugins/WebNetscapePluginView.mm: 15595 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): 15596 * Plugins/WebPluginContainerCheck.mm: 15597 (-[WebPluginContainerCheck _isForbiddenFileLoad]): 15598 * WebView/WebFrame.mm: 15599 (-[WebFrame _allowsFollowingLink:]): 15600 156012010-09-10 Sam Weinig <sam@webkit.org> 15602 15603 Reviewed by Darin Adler. 15604 15605 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom. 15606 Precursor to <rdar://problem/7660657> 15607 https://bugs.webkit.org/show_bug.cgi?id=45522 15608 15609 * WebView/WebView.mm: 15610 (-[WebView _preferencesChangedNotification:]): 15611 (-[WebView _setZoomMultiplier:isTextOnly:]): 15612 (-[WebView _realZoomMultiplierIsTextOnly]): 15613 * WebView/WebViewData.h: 15614 * WebView/WebViewData.mm: 15615 (-[WebViewPrivate init]): 15616 Move tracking of text only zoom here from WebCore. 15617 156182010-09-10 Stephanie Lewis <slewis@apple.com> 15619 15620 Reviewed by Alexey Proskuryakov. 15621 15622 Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and 15623 other implementation details of JavaScriptCore. Necessary to fix PPC build. 15624 15625 https://bugs.webkit.org/show_bug.cgi?id=45528 15626 15627 * Misc/WebCoreStatistics.mm: 15628 (+[WebCoreStatistics memoryStatistics]): 15629 156302010-09-10 Darin Adler <darin@apple.com> 15631 15632 Reviewed by Sam Weinig. 15633 15634 Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup 15635 https://bugs.webkit.org/show_bug.cgi?id=45582 15636 15637 * MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy. 15638 15639 * WebCoreSupport/WebChromeClient.mm: 15640 (WebChromeClient::dashboardRegionsChanged): Changed this to call 15641 -[WebView _dashboardRegions] so we don't have two copies of that code. 15642 15643 * WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h. 15644 * WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m. 15645 15646 * WebView/WebView.mm: 15647 (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here. 15648 156492010-09-10 Adam Barth <abarth@webkit.org> 15650 15651 Reviewed by Darin Fisher. 15652 15653 Move code from WebKit-layer to DocumentLoader 15654 https://bugs.webkit.org/show_bug.cgi?id=45569 15655 15656 This code is the most confused, but now should be a bit cleaner. 15657 There's still a magical fake-setting for creating renderers that needs 15658 to be cleaned up, but we can do that in a separate patch. 15659 15660 * WebView/WebFrame.mm: 15661 (-[WebFrame _commitData:]): 15662 * WebView/WebFrameInternal.h: 15663 * WebView/WebHTMLRepresentation.mm: 15664 (-[WebHTMLRepresentation receivedData:withDataSource:]): 15665 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): 15666 156672010-09-09 Darin Adler <darin@apple.com> 15668 15669 Reviewed by Adam Barth. 15670 15671 Move functions from Frame to SelectionController as planned 15672 https://bugs.webkit.org/show_bug.cgi?id=45508 15673 15674 * WebView/WebFrame.mm: 15675 (-[WebFrame _selectionGranularity]): 15676 (-[WebFrame _insertParagraphSeparatorInQuotedContent]): 15677 (-[WebFrame _typingStyle]): 15678 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): 15679 * WebView/WebHTMLRepresentation.mm: 15680 (-[WebHTMLRepresentation currentForm]): 15681 * WebView/WebHTMLView.mm: 15682 (-[WebHTMLView jumpToSelection:]): 15683 (-[WebHTMLView centerSelectionInVisibleArea:]): 15684 (-[WebHTMLView _canSmartCopyOrDelete]): 15685 (-[WebHTMLView _lookUpInDictionaryFromMenu:]): 15686 (-[WebHTMLView selectionRect]): 15687 (-[WebHTMLView selectionTextRects]): 15688 (-[WebHTMLView selectionImageRect]): 15689 * WebView/WebView.mm: 15690 (-[WebView setEditable:]): 15691 Call functions on selection(). 15692 156932010-09-10 Adam Barth <abarth@webkit.org> 15694 15695 Reviewed by Eric Seidel. 15696 15697 Main resource bytes shouldn't bounce through FrameLoader 15698 https://bugs.webkit.org/show_bug.cgi?id=45496 15699 15700 Now return the bytes to the DocumentLoader. 15701 15702 Previously, we were checking the document for null. However, Frame can 15703 never have a null document, so this check is no longer needed. 15704 15705 * WebView/WebFrame.mm: 15706 (-[WebFrame _addData:]): 15707 157082010-09-09 John Therrell <jtherrell@apple.com> 15709 15710 Reviewed by Alexey Proskuryakov. 15711 15712 Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes 15713 https://bugs.webkit.org/show_bug.cgi?id=45134 15714 15715 Added ability to enable new JavaScriptCore statistics sampling and reporting for RegisterFile 15716 and ExecutableAllocator classes. Added reporting of JavaScriptCore's stack committed memory 15717 and JIT code committed memory statistics to WebCoreStatistics memoryStatistics. 15718 15719 * Misc/WebCoreStatistics.mm: 15720 (+[WebCoreStatistics memoryStatistics]): 15721 Added statistics reporting for JSC RegisterFile and ExecutableAllocator. 15722 157232010-09-09 Jer Noble <jer.noble@apple.com> 15724 15725 Reviewed by Mark Rowe. 15726 15727 Use of ENABLE macro in WebUIDelegatePrivate.h breaks use from outside WebKit 15728 <rdar://problem/8412657> 15729 15730 * WebView/WebUIDelegatePrivate.h: Use ENABLE_FULLSCREEN_API instead of ENABLE(FULLSCREEN_API) 15731 157322010-09-08 Darin Adler <darin@apple.com> 15733 15734 Reviewed by Adam Barth. 15735 15736 Move functions from Frame to Editor as planned 15737 https://bugs.webkit.org/show_bug.cgi?id=45218 15738 15739 * WebView/WebFrame.mm: 15740 (-[WebFrame _selectedString]): 15741 (-[WebFrame _firstRectForDOMRange:]): 15742 (-[WebFrame _markDOMRange]): 15743 (-[WebFrame _setTypingStyle:withUndoAction:]): 15744 * WebView/WebHTMLRepresentation.mm: 15745 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): 15746 * WebView/WebHTMLView.mm: 15747 (-[WebHTMLView _selectionStartFontAttributesAsRTF]): 15748 (-[WebHTMLView toggleBaseWritingDirection:]): 15749 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): 15750 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]): 15751 (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): 15752 (-[WebHTMLView markedTextMatchesAreHighlighted]): 15753 * WebView/WebView.mm: 15754 (-[WebView setEditable:]): 15755 Changed call sites to use editor(). 15756 157572010-09-08 MORITA Hajime <morrita@google.com> 15758 15759 Reviewed by Ojan Vafai. 15760 15761 spellcheck does not check pasted text 15762 https://bugs.webkit.org/show_bug.cgi?id=40092 15763 15764 Implemented async spell-check APIs on WebEditorClient. 15765 The implementations are using [NSSpellChecker requestCheckingOfString] 15766 which is available only on Mac OS 10.6 or later. 15767 15768 Note that [NSSpellChecker requestCheckingOfString] could invoke 15769 the callback block on on of their worker thread, so we need to 15770 return the result to the main thread where WebCore is running. 15771 For that purpose, we made WebEditorSpellCheckResponder class. 15772 15773 Test: editing/spelling/spellcheck-pasted-text-001.html 15774 15775 * WebCoreSupport/WebEditorClient.h: 15776 * WebCoreSupport/WebEditorClient.mm: 15777 (WebEditorClient::isAsynchronousSpellCheckingEnabled): Added. 15778 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]): Added. 15779 (-[WebEditorSpellCheckResponder perform]): Added. 15780 (WebEditorClient::requestCheckingOfString): Added. 15781 * WebView/WebFramePrivate.h: 15782 157832010-09-08 MORITA Hajime <morrita@google.com> 15784 15785 Reviewed by Tony Chang. 15786 15787 spelling underline gets lost on backspace 15788 https://bugs.webkit.org/show_bug.cgi?id=41423 15789 15790 Switched to use a anchorNode of the selection instead of a focused 15791 node for finer control of node selection in spellingNode(): 15792 With the focused node, we cannot select other nodes but the first 15793 child of that node. In some case, we need to inspect these. 15794 15795 The API is only for LayoutTests, and the change is compatible for 15796 existing test cases. 15797 15798 * WebView/WebFrame.mm: 15799 (spellingNode): 15800 158012010-09-08 Adam Barth <abarth@webkit.org> 15802 15803 Rubber-stamped by Eric Seidel. 15804 15805 Rename DocLoader to CachedResourceLoader because that's what it does. 15806 15807 * WebView/WebFrame.mm: 15808 158092010-09-07 Anders Carlsson <andersca@apple.com> 15810 15811 Reviewed by Oliver Hunt. 15812 15813 Fix clang++ build. 15814 15815 * Misc/WebLocalizableStrings.h: 15816 Fix a struct/tag mismatch. 15817 15818 * WebView/WebDeviceOrientationProviderMock.mm: 15819 (-[WebDeviceOrientationProviderMock init]): 15820 Remove stray semicolon. 15821 15822 * WebView/WebViewData.h: 15823 Remove unused class forward declaration. 15824 158252010-09-07 Anders Carlsson <andersca@apple.com> 15826 15827 Reviewed by Darin Adler. 15828 15829 <rdar://problem/8381749> -Wcast-align warning emitted when building with clang 15830 15831 Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc. 15832 15833 * Configurations/Base.xcconfig: 15834 158352010-09-06 Adam Barth <abarth@webkit.org> 15836 15837 Reviewed by Darin Adler. 15838 15839 Rename SecurityOrigin::canLoad to canDisplay 15840 https://bugs.webkit.org/show_bug.cgi?id=45214 15841 15842 Propagate name change. 15843 15844 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 15845 (WebKit::NetscapePluginInstanceProxy::loadRequest): 15846 * Plugins/WebNetscapePluginStream.mm: 15847 (WebNetscapePluginStream::WebNetscapePluginStream): 15848 * Plugins/WebNetscapePluginView.mm: 15849 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): 15850 * Plugins/WebPluginContainerCheck.mm: 15851 (-[WebPluginContainerCheck _isForbiddenFileLoad]): 15852 * WebView/WebFrame.mm: 15853 (-[WebFrame _allowsFollowingLink:]): 15854 158552010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 15856 15857 Reviewed by Darin Adler. 15858 15859 Add NetworkingContext to avoid layer violations 15860 https://bugs.webkit.org/show_bug.cgi?id=42292 15861 15862 Add Mac's specific implementation of FrameNetworkingContext. 15863 15864 * WebCoreSupport/WebFrameLoaderClient.h: 15865 * WebCoreSupport/WebFrameLoaderClient.mm: 15866 * WebCoreSupport/WebFrameNetworkingContext.mm: 15867 (WebFrameNetworkingContext::needsSiteSpecificQuirks): 15868 (WebFrameNetworkingContext::localFileContentSniffingEnabled): 15869 (WebFrameNetworkingContext::scheduledRunLoopPairs): 15870 (WebFrameNetworkingContext::blockedError): 15871 158722010-09-03 John Sullivan <sullivan@apple.com> 15873 15874 Reviewed by Dan Bernstein. 15875 15876 https://bugs.webkit.org/show_bug.cgi?id=45175 15877 [WebView unmarkAllTextMatches] will crash if the webview is already closed 15878 15879 Made this and related methods robust against being called when the WebView is closed. 15880 15881 * WebView/WebView.mm: 15882 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): 15883 Bail out if the WebView is closed. 15884 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): 15885 Ditto. 15886 (-[WebView unmarkAllTextMatches]): 15887 Ditto. 15888 (-[WebView rectsForTextMatches]): 15889 Ditto. 15890 158912010-09-03 Hironori Bono <hbono@chromium.org> 15892 15893 Reviewed by Kent Tamura. 15894 15895 Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests 15896 and implements it for Mac. 15897 https://bugs.webkit.org/show_bug.cgi?id=41832 15898 15899 * WebView/WebFrame.mm: Implemented [WebFrame hasSpellingMarker:length:]. 15900 (spellingNode): 15901 (-[WebFrame hasSpellingMarker:length:]): 15902 * WebView/WebFramePrivate.h: Added [WebFrame hasSpellingMarker:length:] so TextInputController can use it. 15903 159042010-09-02 Yury Semikhatsky <yurys@chromium.org> 15905 15906 Reviewed by Pavel Feldman. 15907 15908 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector 15909 https://bugs.webkit.org/show_bug.cgi?id=44230 15910 15911 * WebCoreSupport/WebInspectorClient.h: 15912 * WebCoreSupport/WebInspectorClient.mm: 15913 (WebInspectorFrontendClient::closeWindow): 15914 (WebInspectorFrontendClient::disconnectFromBackend): 15915 (-[WebInspectorWindowController windowShouldClose:]): 15916 (-[WebInspectorWindowController destroyInspectorView:]): 15917 159182010-09-02 Steve Block <steveblock@google.com> 15919 15920 Reviewed by Adam Barth. 15921 15922 Hook up LayoutTestController.setMockDeviceOrientation() on Mac. 15923 https://bugs.webkit.org/show_bug.cgi?id=43181 15924 15925 This patch hooks up the mock device orientation client on Mac for use 15926 in DumpRenderTree. 15927 15928 The patch adds a new WebDeviceOrientationClient for Mac. This client acts 15929 as a proxy to either a real or mock device orientation provider, both of 15930 which implement a new WebDeviceOrientationProvider interface. 15931 15932 The provider is created by the embedder and passed to the WebView, from 15933 where WebDeviceOrientationClient can access it. 15934 15935 The mock provider, WebDeviceOrientationProviderMock, is a wrapper around 15936 the existing WebCore mock. 15937 15938 * WebCoreSupport/WebDeviceOrientationClient.h: Added. 15939 * WebCoreSupport/WebDeviceOrientationClient.mm: Added. 15940 (WebDeviceOrientationClient::WebDeviceOrientationClient): 15941 (WebDeviceOrientationClient::setController): 15942 (WebDeviceOrientationClient::startUpdating): 15943 (WebDeviceOrientationClient::stopUpdating): 15944 (WebDeviceOrientationClient::lastOrientation): 15945 * WebKit.exp: 15946 * WebView/WebDeviceOrientation.h: Added. 15947 * WebView/WebDeviceOrientation.mm: Added. 15948 (-[WebDeviceOrientation initWithCoreDeviceOrientation:WebCore::]): 15949 (core): 15950 (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]): 15951 (-[WebDeviceOrientation dealloc]): 15952 * WebView/WebDeviceOrientationInternal.h: Added. 15953 * WebView/WebDeviceOrientationProvider.h: Added. 15954 * WebView/WebDeviceOrientationProviderMock.h: Added. 15955 * WebView/WebDeviceOrientationProviderMock.mm: Added. 15956 (-[WebDeviceOrientationProviderMockInternal setOrientation:]): 15957 (-[WebDeviceOrientationProviderMockInternal setController:]): 15958 (-[WebDeviceOrientationProviderMockInternal startUpdating]): 15959 (-[WebDeviceOrientationProviderMockInternal stopUpdating]): 15960 (-[WebDeviceOrientationProviderMockInternal lastOrientation]): 15961 (-[WebDeviceOrientationProviderMock init]): 15962 (-[WebDeviceOrientationProviderMock dealloc]): 15963 (-[WebDeviceOrientationProviderMock setOrientation:]): 15964 (-[WebDeviceOrientationProviderMock setController:]): 15965 (-[WebDeviceOrientationProviderMock startUpdating]): 15966 (-[WebDeviceOrientationProviderMock stopUpdating]): 15967 (-[WebDeviceOrientationProviderMock lastOrientation]): 15968 * WebView/WebDeviceOrientationProviderMockInternal.h: Added. 15969 * WebView/WebView.mm: 15970 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 15971 (-[WebView _setDeviceOrientationProvider:]): 15972 (-[WebView _deviceOrientationProvider]): 15973 * WebView/WebViewData.h: 15974 * WebView/WebViewPrivate.h: 15975 159762010-09-01 Jia Pu <jpu@apple.com> 15977 15978 Reviewed by Dan Bernstein. 15979 15980 Add support for autocorrection UI on Mac OS X. 15981 https://bugs.webkit.org/show_bug.cgi?id=44958 15982 <rdar://problem/7326847> 15983 15984 See detailed high level description in WebCore/ChangeLog. 15985 15986 * WebCoreSupport/WebEditorClient.h: Added new member methods declared in 15987 EditorClient. Added m_correctionPanelTag to store the ID of current autocorrection UI object. 15988 15989 * WebCoreSupport/WebEditorClient.mm: 15990 (WebEditorClient::WebEditorClient): Initialize m_correctionPanelTag. 15991 (WebEditorClient::~WebEditorClient): Make sure the autocorrection UI is 15992 dismissed before destroying the object. 15993 (WebEditorClient::respondToChangedSelection): Dismiss autocorrection UI whenever the selection changes. 15994 (WebEditorClient::showCorrectionPanel): Show autocorrection UI. 15995 (WebEditorClient::dismissCorrectionPanel): Dismiss autocorrection UI. 15996 159972010-09-01 Mark Rowe <mrowe@apple.com> 15998 15999 Reviewed by Adam Roben. 16000 16001 <rdar://problem/8374711> WebKit needs to compile without access to QuickDraw private headers. 16002 16003 * Carbon/HIViewAdapter.m: 16004 * Carbon/HIWebView.mm: 16005 * Misc/QuickDrawCompatibility.h: Added. 16006 * Plugins/WebNetscapePluginView.mm: 16007 160082010-08-31 Dave Hyatt <hyatt@apple.com> 16009 16010 Reviewed by Sam Weinig. 16011 16012 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that 16013 the former can occur in more places without having to do the latter. 16014 16015 Eliminate Mac-specific code for style re-application and recursive layout/style updating in 16016 favor of the cross-platform code that all the other ports use. 16017 16018 * Carbon/HIWebView.mm: 16019 (Draw): 16020 * WebCoreSupport/WebFrameLoaderClient.mm: 16021 (WebFrameLoaderClient::forceLayout): 16022 * WebView/WebHTMLView.mm: 16023 (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]): 16024 (-[WebHTMLView viewWillDraw]): 16025 (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): 16026 (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): 16027 (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): 16028 (-[WebHTMLView reapplyStyles]): 16029 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]): 16030 (-[WebHTMLView setNeedsToApplyStyles:]): 16031 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): 16032 (-[WebHTMLView _layoutIfNeeded]): 16033 (-[WebHTMLView _web_updateLayoutAndStyleIfNeededRecursive]): 16034 * WebView/WebHTMLViewInternal.h: 16035 * WebView/WebView.mm: 16036 (-[WebView _viewWillDrawInternal]): 16037 160382010-08-31 Sam Weinig <sam@webkit.org> 16039 16040 Reviewed by Darin Adler. 16041 16042 Add ability to count text matches without marking 16043 https://bugs.webkit.org/show_bug.cgi?id=43996 16044 16045 Safari needs to be able to count text matches without triggering lots of repainting. 16046 Rename markAllMatchesForText: to countMatchesForText: and add a markMatches: 16047 parameter. For backwards compatibility markAllMatchesForText: calls 16048 countMatchesForText: and passes YES for markMatches:. 16049 16050 * WebView/WebDocumentInternal.h: 16051 * WebView/WebHTMLView.mm: 16052 (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): 16053 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]): 16054 * WebView/WebPDFView.mm: 16055 (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]): 16056 (-[WebPDFView countMatchesForText:caseSensitive:limit:markMatches:]): 16057 * WebView/WebView.mm: 16058 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): 16059 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): 16060 * WebView/WebViewPrivate.h: 16061 160622010-08-31 Darin Adler <darin@apple.com> 16063 16064 Reviewed by Anders Carlsson. 16065 16066 * WebInspector/WebInspectorFrontend.mm: 16067 (-[WebInspectorFrontend initWithFrontendClient:]): Remove a stray semicolon. 16068 160692010-08-30 Mark Rowe <mrowe@apple.com> 16070 16071 Reviewed by Darin Adler. 16072 16073 <rdar://problem/8369736> WebKit build fails. 16074 16075 Temporarily add some extra includes in order to get things building again until <rdar://problem/8374711> is addressed. 16076 16077 * Carbon/HIViewAdapter.m: 16078 * Carbon/HIWebView.mm: 16079 * Plugins/WebNetscapePluginView.mm: 16080 160812010-08-30 Andy Estes <aestes@apple.com> 16082 16083 Reviewed by Darin Adler. 16084 16085 REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in. 16086 https://bugs.webkit.org/show_bug.cgi?id=44865 16087 16088 After http://trac.webkit.org/changeset/66156, sites using the AppleConnect plug-in 16089 for authentication fail to log in. This is due to a bug in AppleConnect that r66156 16090 exposed, but since this will have a significant impact on users of WebKit nightly 16091 builds, a plugin-specific hack should be added while the underlying issue is being 16092 addressed. 16093 16094 * WebCoreSupport/WebFrameLoaderClient.mm: 16095 (WebFrameLoaderClient::createPlugin): Convert plug-in parameter names to lowercase 16096 if the plugin is of type 'application/x-snkp'. 16097 160982010-08-27 Jer Noble <jer.noble@apple.com> 16099 16100 Reviewed by Eric Carlson. 16101 16102 text/plain non-video files cause <video> to hang (while reading them?) 16103 https://bugs.webkit.org/show_bug.cgi?id=44212 16104 16105 Add the new WebKitSystemInterface function WKQTMovieDisableComponent to 16106 the initialization routine. 16107 16108 * WebCoreSupport/WebSystemInterface.mm: 16109 (InitWebCoreSystemInterface): Initialize WKQTMovieDisableComponent. 16110 161112010-08-30 Sheriff Bot <webkit.review.bot@gmail.com> 16112 16113 Unreviewed, rolling out r66198. 16114 http://trac.webkit.org/changeset/66198 16115 https://bugs.webkit.org/show_bug.cgi?id=44856 16116 16117 It made tests crash on Qt bot (Requested by Ossy_ on #webkit). 16118 16119 * WebCoreSupport/WebInspectorClient.h: 16120 * WebCoreSupport/WebInspectorClient.mm: 16121 (WebInspectorFrontendClient::closeWindow): 16122 (-[WebInspectorWindowController windowShouldClose:]): 16123 (-[WebInspectorWindowController destroyInspectorView]): 16124 161252010-08-28 Darin Adler <darin@apple.com> 16126 16127 Reviewed by Sam Weinig. 16128 16129 Make an internal method used by Apple Mail into SPI 16130 https://bugs.webkit.org/show_bug.cgi?id=44832 16131 rdar://problem/5748951 16132 16133 * WebView/WebFrame.mm: 16134 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Moved this method 16135 from the internal section to the private section. 16136 * WebView/WebFrameInternal.h: Moved the method declaration out of here. 16137 * WebView/WebFramePrivate.h: Moved the method declaration in here. 16138 161392010-08-27 Jer Noble <jer.noble@apple.com> 16140 16141 Reviewed by Eric Carlson. 16142 16143 Add JavaScript API to allow a page to go fullscreen. 16144 rdar://problem/6867795 16145 16146 Added chrome client overrides which support entering and exiting full screen. A new preference has 16147 been added (setFullScreenEnabled:) to control at runtime whether full screen support is enabled 16148 (defaults to disabled). Added a new WebKitFullScreenListener callback object which notifies WebCore 16149 when the chrome has started/finished its full screen animation. 16150 16151 * Configurations/FeatureDefines.xcconfig: 16152 * WebCoreSupport/WebChromeClient.h: 16153 * WebCoreSupport/WebChromeClient.mm: 16154 (WebChromeClient::supportsFullscreenForElement): 16155 (WebChromeClient::enterFullscreenForElement): 16156 (WebChromeClient::exitFullscreenForElement): 16157 (-[WebKitFullScreenListener initWithElement:]): 16158 (-[WebKitFullScreenListener webkitWillEnterFullScreen]): 16159 (-[WebKitFullScreenListener webkitDidEnterFullScreen]): 16160 (-[WebKitFullScreenListener webkitWillExitFullScreen]): 16161 (-[WebKitFullScreenListener webkitDidExitFullScreen]): 16162 * WebView/WebPreferenceKeysPrivate.h: 16163 * WebView/WebPreferences.h: 16164 * WebView/WebPreferences.mm: 16165 (+[WebPreferences initialize]): 16166 (-[WebPreferences setFullScreenEnabled:]): 16167 (-[WebPreferences fullScreenEnabled]): 16168 * WebView/WebUIDelegatePrivate.h: 16169 * WebView/WebView.mm: 16170 (-[WebView _preferencesChangedNotification:]): 16171 161722010-08-27 David Hyatt <hyatt@apple.com> 16173 16174 Reviewed by Simon Fraser. 16175 16176 https://bugs.webkit.org/show_bug.cgi?id=44788, implement HTML5-compliant doctype switching. 16177 16178 Rename the various modes to match the HTML5 specification: 16179 ParseMode -> CompatibilityMode 16180 CompatMode -> QuirksMode 16181 AlmostStrictMode -> LimitedQuirksMode 16182 StrictMode -> NoQuirksMode 16183 16184 Remove the htmlHacks() accessor from RenderStyle and make rendering code just go to the document 16185 instead. This makes switching modes avoid forcing all RenderStyles to detect as changed. 16186 16187 Clean up user stylesheets to minimize style recalculation when the mode is switched. 16188 16189 Fix bugs with the propagation of correct modes in the HTML5 parser. Make sure the 16190 dummy document created for fragment parsing properly inherits the real document's CompatibilityMode. 16191 Make sure the tree builder properly changes the insertion mode to "BeforeHTML" after handling 16192 a doctype token. 16193 16194 determineParseMode -> setCompatibilityModeFromDoctype, and it now implements the HTML5 algorithm 16195 precisely. 16196 16197 * WebView/WebView.mm: 16198 (-[WebView _preferencesChangedNotification:]): 16199 162002010-08-27 Yury Semikhatsky <yurys@chromium.org> 16201 16202 Reviewed by Pavel Feldman. 16203 16204 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector 16205 https://bugs.webkit.org/show_bug.cgi?id=44230 16206 16207 * WebCoreSupport/WebInspectorClient.h: 16208 * WebCoreSupport/WebInspectorClient.mm: 16209 (WebInspectorFrontendClient::closeWindow): 16210 (WebInspectorFrontendClient::disconnectFromBackend): 16211 (-[WebInspectorWindowController windowShouldClose:]): 16212 (-[WebInspectorWindowController destroyInspectorView:]): 16213 162142010-08-26 Yury Semikhatsky <yurys@chromium.org> 16215 16216 Unreviewed. Revert r66103 since Qt tests are failing. 16217 16218 * WebCoreSupport/WebInspectorClient.h: 16219 * WebCoreSupport/WebInspectorClient.mm: 16220 (WebInspectorFrontendClient::closeWindow): 16221 (-[WebInspectorWindowController windowShouldClose:]): 16222 (-[WebInspectorWindowController destroyInspectorView]): 16223 162242010-08-26 Yury Semikhatsky <yurys@chromium.org> 16225 16226 Reviewed by Pavel Feldman. 16227 16228 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector 16229 https://bugs.webkit.org/show_bug.cgi?id=44230 16230 16231 * WebCoreSupport/WebInspectorClient.h: 16232 * WebCoreSupport/WebInspectorClient.mm: 16233 (WebInspectorFrontendClient::closeWindow): 16234 (WebInspectorFrontendClient::disconnectFromBackend): 16235 (-[WebInspectorWindowController windowShouldClose:]): 16236 (-[WebInspectorWindowController destroyInspectorView:]): 16237 162382010-08-24 Eric Seidel <eric@webkit.org> 16239 16240 Reviewed by Adam Barth. 16241 16242 Remove HTML5 parser testing infrastructure now that we don't need it 16243 https://bugs.webkit.org/show_bug.cgi?id=44581 16244 16245 * WebView/WebPreferenceKeysPrivate.h: 16246 * WebView/WebPreferences.mm: 16247 (+[WebPreferences initialize]): 16248 * WebView/WebPreferencesPrivate.h: 16249 * WebView/WebView.mm: 16250 (-[WebView _preferencesChangedNotification:]): 16251 162522010-08-24 Sam Weinig <sam@webkit.org> 16253 16254 Reviewed by Oliver Hunt. 16255 16256 Paste event fires twice for mac WebKit 16257 <rdar://problem/8094611> 16258 https://bugs.webkit.org/show_bug.cgi?id=44535 16259 16260 The mac implementation of paste in WebKit was accidentally calling 16261 Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once 16262 in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]). 16263 Use the new pasteAsPlainTextBypassingDHTML function to bypass the 16264 second call. 16265 16266 * WebView/WebHTMLView.mm: 16267 (-[WebHTMLView paste:]): 16268 162692010-08-24 Daniel Cheng <dcheng@chromium.org> 16270 16271 Reviewed by Eric Seidel. 16272 16273 [chromium] Generate drag images for HTML elements and selections. 16274 https://bugs.webkit.org/show_bug.cgi?id=43449 16275 16276 Fix up calls to Frame::nodeImage, which has a new signature. 16277 16278 * Plugins/WebBaseNetscapePluginView.mm: 16279 (-[WebBaseNetscapePluginView halt]): 16280 162812010-08-23 Mike Thole <mthole@apple.com> 16282 16283 Reviewed by Dan Bernstein. 16284 16285 WebPDFView should remove itself as the delegate of its PDFView before being dealloced 16286 https://bugs.webkit.org/show_bug.cgi?id=44441 16287 16288 * WebView/WebPDFView.mm: 16289 (-[WebPDFView dealloc]): Set the PDFView's delegate to nil. 16290 162912010-08-22 Daniel Bates <dbates@rim.com> 16292 16293 Reviewed by Eric Seidel. 16294 16295 Encapsulate document marker management into DocumentMarkerController 16296 https://bugs.webkit.org/show_bug.cgi?id=44383 16297 16298 Modify call sites in the Apple Mac port to use DocumentMarkerController. 16299 16300 No functionality was changed, so no new tests. 16301 16302 * WebView/WebFrame.mm: 16303 (-[WebFrame _unmarkAllBadGrammar]): 16304 (-[WebFrame _unmarkAllMisspellings]): 16305 * WebView/WebHTMLView.mm: 16306 (-[WebHTMLView unmarkAllTextMatches]): 16307 (-[WebHTMLView rectsForTextMatches]): 16308 163092010-08-19 David Kilzer <ddkilzer@apple.com> 16310 16311 <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled 16312 16313 Reviewed by Joseph Pecoraro. 16314 16315 * Plugins/Hosted/HostedNetscapePluginStream.mm: Changed 16316 USE(PLUGIN_HOST_PROCESS) to 16317 USE(PLUGIN_HOST_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API). 16318 * Plugins/Hosted/NetscapePluginHostManager.mm: Ditto. 16319 * Plugins/Hosted/NetscapePluginHostProxy.mm: Ditto. 16320 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Ditto. 16321 * Plugins/Hosted/ProxyInstance.mm: Ditto. 16322 * Plugins/Hosted/WebHostedNetscapePluginView.mm: Ditto. 16323 * WebCoreSupport/WebChromeClient.mm: Ditto. 16324 (WebChromeClient::createWindow): 16325 * WebCoreSupport/WebFrameLoaderClient.mm: Ditto. 16326 (WebFrameLoaderClient::dispatchCreatePage): 16327 * WebView/WebHTMLView.mm: 16328 (needsCursorRectsSupportAtPoint): Added #if 16329 ENABLE(NETSCAPE_PLUGIN_API) and #endif macros as needed. 16330 * WebView/WebView.mm: 16331 (+[WebView _isNodeHaltedPlugin:]): Ditto. 16332 (+[WebView _hasPluginForNodeBeenHalted:]): Ditto. 16333 (+[WebView _restartHaltedPluginForNode:]): Ditto. 16334 163352010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 16336 16337 Reviewed by Darin Adler. 16338 16339 Add NetworkingContext to avoid layer violations 16340 https://bugs.webkit.org/show_bug.cgi?id=42292 16341 16342 Preparation: Just add the files to the build system. 16343 16344 * WebCoreSupport/WebFrameNetworkingContext.h: Added. 16345 Placeholder with tentative code that might be changed when landing 16346 the rest of it. 16347 * WebCoreSupport/WebFrameNetworkingContext.mm: Added. 16348 Empty placeholder for now. 16349 163502010-08-17 Brady Eidson <beidson@apple.com> 16351 16352 Reviewed by Sam Weinig. 16353 16354 Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed. 16355 <rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131 16356 16357 * WebView/WebView.mm: 16358 (-[WebView canGoBack]): Return false if loads are deferred. 16359 (-[WebView canGoForward]): Ditto. 16360 163612010-08-14 Joseph Pecoraro <joepeck@webkit.org> 16362 16363 Reviewed by Pavel Feldman. 16364 16365 Web Inspector: -[WebInspector attach] and detach should work 16366 https://bugs.webkit.org/show_bug.cgi?id=43924 16367 16368 For actions that relate only to the Web Inspector's Frontend 16369 window (actions on the InspectorFrontendClient) the new Obj-C 16370 wrapper class WebInspectorFrontend can be used. For now, this 16371 is just attach and detach. 16372 16373 * WebCoreSupport/WebInspectorClient.mm: 16374 (WebInspectorClient::openInspectorFrontend): setup and attach the WebInspectorFrontend to the WebInspector. 16375 * WebInspector/WebInspector.h: 16376 * WebInspector/WebInspector.mm: 16377 (-[WebInspector dealloc]): 16378 (-[WebInspector attach:]): delegate to the frontend. 16379 (-[WebInspector detach:]): delegate to the frontend. 16380 (-[WebInspector setFrontend:]): 16381 * WebInspector/WebInspectorFrontend.h: Added. 16382 * WebInspector/WebInspectorFrontend.mm: Added. 16383 (-[WebInspectorFrontend initWithFrontendClient:]): 16384 (-[WebInspectorFrontend attach]): 16385 (-[WebInspectorFrontend detach]): 16386 * WebInspector/WebInspectorPrivate.h: 16387 163882010-08-13 Gavin Barraclough <barraclough@apple.com> 16389 16390 Rubber stamped by Sam Weinig. 16391 Switch String::/UString::ascii() to return a CString. 16392 16393 * Plugins/Hosted/ProxyInstance.mm: 16394 (WebKit::ProxyInstance::methodsNamed): 16395 (WebKit::ProxyInstance::fieldNamed): 16396 163972010-08-13 Gavin Barraclough <barraclough@apple.com> 16398 16399 Reviewed by Sam Weinig 16400 16401 Unify UString::UTF8String() & String::utf8() methods, 16402 remove UString::cost() & make atArrayIndex a free function. 16403 16404 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 16405 (WebKit::NetscapePluginInstanceProxy::enumerate): 16406 164072010-08-12 Sheriff Bot <webkit.review.bot@gmail.com> 16408 16409 Unreviewed, rolling out r65295. 16410 http://trac.webkit.org/changeset/65295 16411 https://bugs.webkit.org/show_bug.cgi?id=43950 16412 16413 It broke 4 sputnik tests (Requested by Ossy on #webkit). 16414 16415 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 16416 (WebKit::NetscapePluginInstanceProxy::enumerate): 16417 164182010-08-12 Gavin Barraclough <barraclough@apple.com> 16419 16420 Reviewed by Sam Weinig 16421 16422 Unify UString::UTF8String() & String::utf8() methods, 16423 remove UString::cost() & make atArrayIndex a free function. 16424 16425 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 16426 (WebKit::NetscapePluginInstanceProxy::enumerate): 16427 164282010-08-12 Jeremy Orlow <jorlow@chromium.org> 16429 16430 Revert for now 16431 https://bugs.webkit.org/show_bug.cgi?id=43794 16432 16433 * WebView/WebView.mm: 16434 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 16435 (-[WebView _preferencesChangedNotification:]): 16436 164372010-08-10 Jeremy Orlow <jorlow@chromium.org> 16438 16439 Reviewed by Adam Barth. 16440 16441 Some settings are linked to the PageGroup not the Page. Create a new class for those. 16442 https://bugs.webkit.org/show_bug.cgi?id=43794 16443 16444 Change WebView to use the new GroupSettings class rather than Settings for the 16445 settings that moved. This is sub-optimal since the settings aren't really 16446 per-view, but we can't really change the API at this point. 16447 16448 * WebView/WebView.mm: 16449 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 16450 (-[WebView _preferencesChangedNotification:]): 16451 164522010-08-11 Gavin Barraclough <barraclough@apple.com> 16453 16454 Rubber stamps by Darin Adler & Sam Weinig. 16455 16456 Bug 43867 - Some UString cleanup 16457 16458 Change JSC::UString data(), size(), and from(), to characters(), length(), and number() to match WTF::String. 16459 Move string concatenation methods to a new header to simplify down UString.h. Remove is8Bit(). 16460 16461 * WebView/WebScriptDebugger.mm: 16462 (toNSString): 16463 164642010-08-10 David Hyatt <hyatt@apple.com> 16465 16466 Reviewed by Dan Bernstein. 16467 16468 https://bugs.webkit.org/show_bug.cgi?id=43806, add ability to paginate screen content. 16469 16470 Add SPI for entering and exiting screen pagination mode. This is similar to printing mode but it can be done for on-screen 16471 content. 16472 16473 * WebView/WebHTMLView.mm: 16474 (-[WebHTMLView _web_setPrintingModeRecursive]): 16475 (-[WebHTMLView _web_clearPrintingModeRecursive]): 16476 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): 16477 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): 16478 (-[WebHTMLView _endPrintMode]): 16479 (-[WebHTMLView _isInScreenPaginationMode]): 16480 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): 16481 (-[WebHTMLView _endScreenPaginationMode]): 16482 (-[WebHTMLView reapplyStyles]): 16483 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): 16484 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): 16485 (-[WebHTMLView setPageWidthForPrinting:]): 16486 * WebView/WebHTMLViewPrivate.h: 16487 164882010-08-10 Gavin Barraclough <barraclough@apple.com> 16489 16490 Build fix (update more includes) 16491 16492 * Plugins/Hosted/NetscapePluginHostManager.h: 16493 164942010-08-10 Chris Marrin <cmarrin@apple.com> 16495 16496 Reviewed by Oliver Hunt. 16497 16498 Add suspendAnimations/resumeAnimation API to DRT 16499 https://bugs.webkit.org/show_bug.cgi?id=43733 16500 16501 Mac specific API. Plumbs suspendAnimations/resumeAnimations down to WebCore. 16502 16503 * WebView/WebFrame.mm: 16504 (-[WebFrame _suspendAnimations]): 16505 (-[WebFrame _resumeAnimations]): 16506 * WebView/WebFramePrivate.h: 16507 165082010-08-10 Gavin Barraclough <barraclough@apple.com> 16509 16510 Rubber stamped by Sam Weinig 16511 16512 Bug 43817 - Remove UString::Rep 16513 UString::Rep has for a long time been replaced by UStringImpl (Rep 16514 remaining as a typedef). UStringImpl has since been removed too 16515 (unified with StringImpl). Remove Rep, rename rep() to impl() and 16516 m_rep to m_impl. Also add impl() method to Identifier, and rename 16517 its UString member from _ustring to m_string. 16518 16519 * Plugins/Hosted/ProxyInstance.mm: 16520 (WebKit::ProxyInstance::methodsNamed): 16521 (WebKit::ProxyInstance::fieldNamed): 16522 165232010-08-06 Gavin Barraclough <barraclough@apple.com> 16524 16525 Rubber stamped by Sam Weinig 16526 16527 Bug 43594 - Add string forwards to Forward.h 16528 This allows us to remove forward declarations for these classes from 16529 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::). 16530 16531 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 16532 * Plugins/WebBaseNetscapePluginView.h: 16533 * WebCoreSupport/WebFrameLoaderClient.h: 16534 * WebCoreSupport/WebIconDatabaseClient.h: 16535 * WebCoreSupport/WebPluginHalterClient.h: 16536 * WebView/WebViewInternal.h: 16537 165382010-08-04 MORITA Hajime <morrita@google.com> 16539 16540 Reviewed by Tony Chang. 16541 16542 Pasting should fire textInput event. 16543 https://bugs.webkit.org/show_bug.cgi?id=42958 16544 16545 On paste, invoke Editor instead of direct command invocation, 16546 which allows dispatching events before actual paste. 16547 16548 * WebView/WebHTMLView.mm: 16549 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): 16550 165512010-08-06 Yongjun Zhang <yongjun_zhang@apple.com> 16552 16553 Reviewed by Eric Seidel. 16554 16555 add "const" to WebChromeClient::webView(). 16556 https://bugs.webkit.org/show_bug.cgi?id=43631 16557 16558 Change WebChromeClient::webView() to be const because ChromeClient::didReceiveViewportArguments 16559 is const method now, and calling webView() inside port-specific didReceiveViewportArguments 16560 implementation fails compiling if webView() is not const. 16561 16562 * WebCoreSupport/WebChromeClient.h: 16563 (WebChromeClient::webView): 16564 165652010-08-06 Jessie Berlin <jberlin@apple.com> 16566 16567 Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build. 16568 Unreviewed. 16569 16570 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 16571 * Plugins/WebBaseNetscapePluginView.h: 16572 * WebCoreSupport/WebFrameLoaderClient.h: 16573 * WebCoreSupport/WebIconDatabaseClient.h: 16574 * WebCoreSupport/WebPluginHalterClient.h: 16575 * WebView/WebViewInternal.h: 16576 165772010-08-05 Joseph Pecoraro <joepeck@webkit.org> 16578 16579 Reviewed by David Kilzer. 16580 16581 Remove Invalid Asserts for Application Cache Quotas 16582 https://bugs.webkit.org/show_bug.cgi?id=43585 16583 16584 Removed Invalid ASSERTs that would always happen for quotas 16585 that were not noQuota(). 16586 16587 * WebView/WebPreferences.mm: 16588 (-[WebPreferences applicationCacheTotalQuota]): 16589 (-[WebPreferences applicationCacheDefaultOriginQuota]): 16590 165912010-08-05 Gavin Barraclough <barraclough@apple.com> 16592 16593 Rubber stamped by Sam Weinig 16594 16595 Bug 43594 - Add string forwards to Forward.h 16596 This allows us to remove forward declarations for these classes from 16597 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::). 16598 16599 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 16600 * Plugins/WebBaseNetscapePluginView.h: 16601 * WebCoreSupport/WebFrameLoaderClient.h: 16602 * WebCoreSupport/WebIconDatabaseClient.h: 16603 * WebCoreSupport/WebPluginHalterClient.h: 16604 * WebView/WebViewInternal.h: 16605 166062010-08-05 Jian Li <jianli@chromium.org> 16607 16608 Reviewed by David Levin. 16609 16610 Unify blob related feature defines to ENABLE(BLOB). 16611 https://bugs.webkit.org/show_bug.cgi?id=43081 16612 16613 * Configurations/FeatureDefines.xcconfig: 16614 166152010-08-03 Joseph Pecoraro <joepeck@webkit.org> 16616 16617 Reviewed by David Kilzer. 16618 16619 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) 16620 https://bugs.webkit.org/show_bug.cgi?id=40627 16621 16622 Part 6 - LayoutTest and Cleanup 16623 16624 * WebCoreSupport/WebApplicationCache.h: 16625 * WebCoreSupport/WebApplicationCache.mm: 16626 (+[WebApplicationCache setMaximumSize:]): refactor out deleting the application caches. 16627 (+[WebApplicationCache deleteAllApplicationCaches]): delete application caches. 16628 166292010-08-03 Joseph Pecoraro <joepeck@webkit.org> 16630 16631 Reviewed by David Kilzer. 16632 16633 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) 16634 https://bugs.webkit.org/show_bug.cgi?id=40627 16635 16636 Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers 16637 16638 Per-Origin quotas exist for Databases and Application Caches. Clients 16639 given a WebSecurityOrigin have the ability to set the quota for any 16640 per-origin quota type. This puts quota management into an interface 16641 and WebSecurityOrigin allows access to quota managers for the 16642 different types of quotas. 16643 16644 This also deprecates the old methods on WebSecurityOrigin. They are 16645 left in for now to prevent breaking older clients. 16646 16647 The WebQuotaManager interface allows querying and modifying a 16648 per-origin quota. This is implemented for both Databases and 16649 Application Caches. 16650 16651 * Misc/WebQuotaManager.h: Added. Interface for quota management (usage, quota, setQuota). 16652 * Storage/WebDatabaseQuotaManager.h: Added. 16653 * Storage/WebDatabaseQuotaManager.mm: Added. 16654 (-[WebDatabaseQuotaManager origin]): 16655 (-[WebDatabaseQuotaManager usage]): 16656 (-[WebDatabaseQuotaManager quota]): 16657 (-[WebDatabaseQuotaManager setQuota:]): 16658 * Storage/WebDatabaseSecurityOrigin.h: Removed. 16659 * Storage/WebDatabaseSecurityOrigin.mm: Removed. 16660 * WebCoreSupport/WebApplicationCacheQuotaManager.h: Added. 16661 * WebCoreSupport/WebApplicationCacheQuotaManager.mm: Added. 16662 (-[WebApplicationCacheQuotaManager origin]): 16663 (-[WebApplicationCacheQuotaManager usage]): 16664 (-[WebApplicationCacheQuotaManager quota]): 16665 (-[WebApplicationCacheQuotaManager setQuota:]): 16666 * WebCoreSupport/WebSecurityOriginPrivate.h: Added a category to access managers. Deprecated old methods. 16667 16668 Remove the WebSecurityOrigin sub-classes. Managers are better. 16669 16670 * WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Removed. 16671 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Removed. 16672 16673 Create the managers lazily. Change old style calls to make use 16674 of the managers. 16675 16676 * WebCoreSupport/WebChromeClient.mm: 16677 (WebChromeClient::exceededDatabaseQuota): 16678 (WebChromeClient::reachedApplicationCacheOriginQuota): 16679 * WebCoreSupport/WebSecurityOrigin.mm: 16680 (-[WebSecurityOrigin applicationCacheQuotaManager]): 16681 (-[WebSecurityOrigin databaseQuotaManager]): 16682 (-[WebSecurityOrigin dealloc]): release the managers if they exist. 16683 166842010-08-03 Alex Milowski <alex@milowski.com> 16685 16686 Reviewed by Beth Dakin. 16687 16688 Changed the ENABLE_MATHML value to enable MathML by default. 16689 16690 * Configurations/FeatureDefines.xcconfig: 16691 166922010-08-02 Brady Eidson <beidson@apple.com> 16693 16694 Reviewed by Anders Carlsson. 16695 16696 Add VisitedLinkStrategy for each platform to implement 16697 https://bugs.webkit.org/show_bug.cgi?id=43393 16698 16699 * WebCoreSupport/WebPlatformStrategies.h: 16700 * WebCoreSupport/WebPlatformStrategies.mm: 16701 (WebPlatformStrategies::createVisitedLinkStrategy): 16702 (WebPlatformStrategies::isLinkVisited): Call back into PageGroup's visited links. 16703 (WebPlatformStrategies::addVisitedLink): Ditto. 16704 167052010-07-27 Luiz Agostini <luiz.agostini@openbossa.org> 16706 16707 Reviewed by Darin Fisher. 16708 16709 PopupMenu refactoring in preparation to WebKit2 16710 https://bugs.webkit.org/show_bug.cgi?id=42592 16711 16712 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu 16713 instances, concrete classes that inherit from ChromeClient needed to be changed to 16714 implement the new methods. 16715 16716 * WebCoreSupport/WebChromeClient.h: 16717 * WebCoreSupport/WebChromeClient.mm: 16718 (WebChromeClient::selectItemWritingDirectionIsNatural): 16719 (WebChromeClient::createPopupMenu): 16720 (WebChromeClient::createSearchPopupMenu): 16721 167222010-08-02 Jeremy Orlow <jorlow@chromium.org> 16723 16724 Speculative revert of 64425 due to Chromium instability 16725 https://bugs.webkit.org/show_bug.cgi?id=43347 16726 16727 * WebCoreSupport/WebChromeClient.h: 16728 * WebCoreSupport/WebChromeClient.mm: 16729 167302010-07-27 Luiz Agostini <luiz.agostini@openbossa.org> 16731 16732 Reviewed by Darin Fisher. 16733 16734 PopupMenu refactoring in preparation to WebKit2 16735 https://bugs.webkit.org/show_bug.cgi?id=42592 16736 16737 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu 16738 instances, concrete classes that inherit from ChromeClient needed to be changed to 16739 implement the new methods. 16740 16741 * WebCoreSupport/WebChromeClient.h: 16742 * WebCoreSupport/WebChromeClient.mm: 16743 (WebChromeClient::selectItemWritingDirectionIsNatural): 16744 (WebChromeClient::createPopupMenu): 16745 (WebChromeClient::createSearchPopupMenu): 16746 167472010-07-31 Sheriff Bot <webkit.review.bot@gmail.com> 16748 16749 Unreviewed, rolling out r64422. 16750 http://trac.webkit.org/changeset/64422 16751 https://bugs.webkit.org/show_bug.cgi?id=43304 16752 16753 Build fixes are needed for Snow Leopard and Windows. 16754 (Requested by lca on #webkit). 16755 16756 * WebCoreSupport/WebChromeClient.h: 16757 * WebCoreSupport/WebChromeClient.mm: 16758 167592010-07-27 Luiz Agostini <luiz.agostini@openbossa.org> 16760 16761 Reviewed by Darin Fisher. 16762 16763 PopupMenu refactoring in preparation to WebKit2 16764 https://bugs.webkit.org/show_bug.cgi?id=42592 16765 16766 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu 16767 instances, concrete classes that inherit from ChromeClient needed to be changed to 16768 implement the new methods. 16769 16770 * WebCoreSupport/WebChromeClient.h: 16771 * WebCoreSupport/WebChromeClient.mm: 16772 (WebChromeClient::selectItemWritingDirectionIsNatural): 16773 (WebChromeClient::createPopupMenu): 16774 (WebChromeClient::createSearchPopupMenu): 16775 167762010-07-31 David Kilzer <ddkilzer@apple.com> 16777 16778 <http://webkit.org/b/43300> Simplify variables in *.xcconfig files after adding iOS support 16779 16780 Reviewed by Darin Adler. 16781 16782 * Configurations/WebKit.xcconfig: Extracted 16783 PRODUCTION_FRAMEWORKS_DIR and PRODUCTION_ROOT variables. 16784 167852010-07-30 Dan Bernstein <mitz@apple.com> 16786 16787 Reviewed by Darin Adler. 16788 16789 <rdar://problem/8257783> Short documents may print a second blank page 16790 https://bugs.webkit.org/show_bug.cgi?id=43271 16791 16792 * WebView/WebHTMLView.mm: 16793 (-[WebHTMLView _web_setPrintingModeRecursive]): Updated for additional height parameter 16794 to _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:. 16795 (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto. 16796 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto. 16797 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Added height parameter, 16798 which is scaled and passed on to _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:. 16799 (-[WebHTMLView _endPrintMode]): Updated for additional height parameter to 16800 _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:. 16801 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]): Added 16802 height parameter, which is passed on to FrameView::forceLayoutForPagination(). 16803 (-[WebHTMLView layout]): Updated for additional height parameter. 16804 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:]): Added height 16805 parameter, which is passed on to -layoutToMinimumPageWidth:height:maximumPageWidth:adjustViewSize:. 16806 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Updated for additional height 16807 parameter. 16808 (-[WebHTMLView setPageWidthForPrinting:]): Ditto. 16809 (-[WebHTMLView knowsPageRange:]): Pass the available height on the page on to 16810 _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize. 16811 * WebView/WebHTMLViewPrivate.h: 16812 168132010-07-30 Joseph Pecoraro <joepeck@webkit.org> 16814 16815 Fix for tests that broke after r64400. Tracking a more 16816 ideal solution in https://bugs.webkit.org/show_bug.cgi?id=40627 16817 16818 Switch the interface back to (unsigned long long), and move 16819 the WebDatabaseSecurityOrigin implementation up into WebSecurityOrigin. 16820 The subclasses' implementations were not getting called. 16821 16822 * Storage/WebDatabaseSecurityOrigin.mm: 16823 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: 16824 (-[WebApplicationCacheSecurityOrigin quota]): 16825 (-[WebApplicationCacheSecurityOrigin setQuota:]): 16826 * WebCoreSupport/WebSecurityOrigin.mm: 16827 (-[WebSecurityOrigin usage]): 16828 (-[WebSecurityOrigin quota]): 16829 (-[WebSecurityOrigin setQuota:]): 16830 * WebCoreSupport/WebSecurityOriginPrivate.h: 16831 168322010-07-30 Joseph Pecoraro <joepeck@webkit.org> 16833 16834 Reviewed by David Kilzer. 16835 16836 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) 16837 https://bugs.webkit.org/show_bug.cgi?id=40627 16838 16839 Part 4 - Client Notification when the Quota is Reached 16840 16841 Notify the WebKit client when the per-origin quota is reached 16842 via a delegate method reachedApplicationCacheOriginQuota. 16843 16844 Refactor the WebSecurityOrigin class to be generic enough to 16845 allow quota management of both Databases or Application Caches 16846 via subclasses. 16847 16848 * Storage/WebDatabaseSecurityOrigin.h: Added. 16849 * Storage/WebDatabaseSecurityOrigin.mm: Added. 16850 (-[WebDatabaseSecurityOrigin quota]): 16851 (-[WebDatabaseSecurityOrigin setQuota:]): 16852 * WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Added. 16853 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Added. 16854 (-[WebApplicationCacheSecurityOrigin quota]): 16855 (-[WebApplicationCacheSecurityOrigin setQuota:]): 16856 * Storage/WebSecurityOrigin.mm: Removed. (Moved to WebCoreSupport) 16857 * Storage/WebSecurityOriginPrivate.h: Removed. (Moved to WebCoreSupport) 16858 * WebCoreSupport/WebSecurityOrigin.mm: Added. 16859 (-[WebSecurityOrigin usage]): to be implemented by subclasses. 16860 (-[WebSecurityOrigin quota]): to be implemented by subclasses. 16861 (-[WebSecurityOrigin setQuota:]): to be implemented by subclasses. 16862 * WebCoreSupport/WebSecurityOriginInternal.h: Renamed from WebKit/mac/Storage/WebSecurityOriginInternal.h. 16863 * WebCoreSupport/WebSecurityOriginPrivate.h: Added. 16864 16865 Turn the notification into a WebUI Delegate to call. Following 16866 the example of Databases. 16867 16868 * DefaultDelegates/WebDefaultUIDelegate.m: 16869 (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): 16870 * WebCoreSupport/WebChromeClient.h: 16871 * WebCoreSupport/WebChromeClient.mm: 16872 (WebChromeClient::exceededDatabaseQuota): use the Databases Security Origin subclass. 16873 (WebChromeClient::reachedApplicationCacheOriginQuota): use the Application Cache Security Origin subclass. 16874 * WebView/WebUIDelegatePrivate.h: 16875 168762010-07-30 Joseph Pecoraro <joepeck@webkit.org> 16877 16878 Reviewed by David Kilzer. 16879 16880 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) 16881 https://bugs.webkit.org/show_bug.cgi?id=40627 16882 16883 Part 1 - Add Total and Per-Origin Quota Preferences. 16884 16885 Allow the application cache total size to be a preference, and 16886 add a new preference for the default per-origin quota. 16887 16888 Storage quotas were int64_t (long long). Boilerplate for 16889 these types added for consistency. 16890 16891 * Misc/WebNSDictionaryExtras.h: 16892 * Misc/WebNSDictionaryExtras.m: 16893 (-[NSMutableDictionary _webkit_setLongLong:forKey:]): 16894 * WebCoreSupport/WebApplicationCache.h: setters and accessors for WebCore's cacheStorage. 16895 * WebCoreSupport/WebApplicationCache.mm: 16896 (+[WebApplicationCache maximumSize:]): 16897 (+[WebApplicationCache setMaximumSize:]): 16898 (+[WebApplicationCache defaultOriginQuota]): 16899 (+[WebApplicationCache setDefaultOriginQuota:]): 16900 * WebView/WebPreferenceKeysPrivate.h: 16901 * WebView/WebPreferences.mm: 16902 (+[WebPreferences initialize]): defaults to noQuota for both preferences. 16903 (-[WebPreferences _longLongValueForKey:]): 16904 (-[WebPreferences _setLongLongValue:forKey:]): 16905 (-[WebPreferences applicationCacheTotalQuota]): 16906 (-[WebPreferences setApplicationCacheTotalQuota:]): 16907 (-[WebPreferences applicationCacheDefaultOriginQuota]): 16908 (-[WebPreferences setApplicationCacheDefaultOriginQuota:]): 16909 * WebView/WebPreferencesPrivate.h: 16910 * WebView/WebView.mm: 16911 (-[WebView _preferencesChangedNotification:]): respect updates to the preferences. 16912 169132010-07-30 Andy Estes <aestes@apple.com> 16914 16915 Reviewed by David Kilzer. 16916 16917 Add Xcode support for compiling WebKit against iOS SDKs. 16918 https://bugs.webkit.org/show_bug.cgi?id=42796 16919 16920 * Configurations/Base.xcconfig: 16921 * Configurations/DebugRelease.xcconfig: 16922 * Configurations/FeatureDefines.xcconfig: 16923 * Configurations/Version.xcconfig: 16924 * Configurations/WebKit.xcconfig: 16925 169262010-07-26 Steve Block <steveblock@google.com> 16927 16928 Reviewed by Jeremy Orlow. 16929 16930 Page clients should be passed to Page constructor via structure of pointers 16931 https://bugs.webkit.org/show_bug.cgi?id=42834 16932 16933 * WebView/WebView.mm: 16934 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 16935 169362010-07-27 Kinuko Yasuda <kinuko@chromium.org> 16937 16938 Reviewed by Ojan Vafai. 16939 16940 Add FILE_SYSTEM build flag for FileSystem API 16941 https://bugs.webkit.org/show_bug.cgi?id=42915 16942 16943 * Configurations/FeatureDefines.xcconfig: 16944 169452010-07-27 Steve Block <steveblock@google.com> 16946 16947 Reviewed by Jeremy Orlow. 16948 16949 Client-based Geolocation does not pass enableHighAccuracy option to controller and client 16950 https://bugs.webkit.org/show_bug.cgi?id=40374 16951 16952 Stub out setEnableHighAccuracy method for the Mac port. 16953 16954 * WebCoreSupport/WebGeolocationControllerClient.h: 16955 (WebGeolocationControllerClient::setEnableHighAccuracy): 16956 169572010-07-22 Sam Weinig <sam@webkit.org> 16958 16959 Reviewed by Maciej Stachowiak. 16960 16961 Fix for <rdar://problem/8222626> 16962 Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input. 16963 16964 The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we 16965 should migrate to a new function name eventually 16966 16967 * WebCoreSupport/WebEditorClient.mm: 16968 (WebEditorClient::textDidChangeInTextField): 16969 169702010-07-22 Sam Weinig <sam@webkit.org> 16971 16972 Reviewed by Anders Carlsson. 16973 16974 Patch for https://bugs.webkit.org/show_bug.cgi?id=42836 16975 Add localized strings stubs for WebKit2. 16976 16977 - Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory 16978 for localized strings. 16979 16980 Gets us below 200 tests failing in WebKitTestRunner. 16981 16982 * WebCoreSupport/WebContextMenuClient.mm: 16983 (fixMenusReceivedFromOldClients): Use LocalizedStrings rather than the factory. 16984 * WebCoreSupport/WebPlatformStrategies.h: 16985 * WebCoreSupport/WebPlatformStrategies.mm: 16986 * WebCoreSupport/WebViewFactory.mm: 16987 169882010-07-21 Brady Eidson <beidson@apple.com> 16989 16990 Reviewed by Geoffrey Garen. 16991 16992 Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry 16993 https://bugs.webkit.org/show_bug.cgi?id=42783 16994 16995 * WebView/WebView.mm: 16996 (+[WebView _registerURLSchemeAsSecure:]): 16997 (+[WebView registerURLSchemeAsLocal:]): 16998 169992010-07-21 Simon Fraser <simon.fraser@apple.com> 17000 17001 Reviewed by Anders Carlsson. 17002 17003 Composited layers don't scroll in WebKit2 17004 https://bugs.webkit.org/show_bug.cgi?id=42771 17005 17006 Prep work: FrameView::scrollPositionChanged() sounds like a generic "did scroll" bottleneck, 17007 but this is deceiving. It's only every called on one platform (Mac) when the NSScrollView gets 17008 scrolled, so rename it to FrameView::scrollPositionChangedViaPlatformWidget(). 17009 17010 * WebView/WebHTMLView.mm: 17011 (-[WebHTMLView _frameOrBoundsChanged]): 17012 170132010-07-21 Eric Carlson <eric.carlson@apple.com> 17014 17015 Reviewed by Simon Fraser. 17016 17017 Update plug-in proxy backed <video> and <audio> elements. 17018 https://bugs.webkit.org/show_bug.cgi?id=42770 17019 <rdar://problem/7963467> 17020 17021 * Plugins/WebPluginController.h: 17022 * Plugins/WebPluginController.mm: 17023 (-[WebPluginController dealloc]): Release _viewsNotInDocument. 17024 (-[WebPluginController stopAllPlugins]): Stop plug-ins not in the document. 17025 (-[WebPluginController pluginViewCreated:]): New, add a View (plug-in) to _viewsNotInDocument. 17026 (+[WebPluginController pluginViewHidden:]): New, remove the view (plug-in) from pluginViews. 17027 (-[WebPluginController addPlugin:]): Remove the new plug-in from _viewsNotInDocument. 17028 17029 * WebCoreSupport/WebFrameLoaderClient.h: 17030 * WebCoreSupport/WebFrameLoaderClient.mm: 17031 (WebFrameLoaderClient::createPlugin): Remove PLUGIN_PROXY_FOR_VIDEO code, the media 17032 player proxy plug-in should never be allocated by this method. 17033 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): New, allocate a media player proxy. 17034 17035 * WebView/WebView.mm: 17036 (-[WebView _videoProxyPluginForMIMEType:]): New. Identical to _pluginForMIMEType except it doesn't 17037 consider the arePlugInsEnabled preference. 17038 * WebView/WebViewInternal.h: 17039 17040 170412010-07-19 Chris Marrin <cmarrin@apple.com> 17042 17043 Reviewed by Darin Adler. 17044 17045 https://bugs.webkit.org/show_bug.cgi?id=42118 17046 Disable WebGL on Leopard for now. 17047 17048 LayoutTests fail on some graphics hardware on Leopard because one of the features we use, 17049 GL_ARB_framebuffer_object, is not universally available in Leopard like it is in 17050 SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a 17051 software OpenGL driver on machines without this support. 17052 17053 * Configurations/FeatureDefines.xcconfig: 17054 170552010-07-18 Anders Carlsson <andersca@apple.com> 17056 17057 Reviewed by Sam Weinig. 17058 17059 Move PluginWidget to WebKit 17060 https://bugs.webkit.org/show_bug.cgi?id=42530 17061 17062 * Plugins/WebBaseNetscapePluginView.h: 17063 * Plugins/WebBaseNetscapePluginView.mm: 17064 (-[WebBaseNetscapePluginView pluginLayer]): 17065 Add default pluginLayer implementation. 17066 17067 * WebCoreSupport/WebFrameLoaderClient.mm: 17068 (PluginWidget::PluginWidget): 17069 (PluginWidget::invalidateRect): 17070 Move the guts of PluginWidget here from WebCore. 17071 17072 (NetscapePluginWidget::platformLayer): 17073 Get the layer from the plug-in view. 17074 170752010-07-18 David Kilzer <ddkilzer@apple.com> 17076 17077 <http://webkit.org/b/42522> Add missing (id) return type to Obj-C methods 17078 17079 Reviewed by Dan Bernstein. 17080 17081 * Carbon/CarbonWindowAdapter.mm: 17082 (-[NSWindow(HIWebFrameView) _initContent:styleMask:backing:defer:contentView:]): 17083 (-[CarbonWindowAdapter _destroyRealWindow:]): 17084 (-[CarbonWindowAdapter _clearModalWindowLevel]): 17085 * Misc/WebIconDatabase.mm: 17086 (-[WebIconDatabase init]): 17087 * Misc/WebNSPasteboardExtras.mm: 17088 (-[NSFilePromiseDragSource initWithSource:]): 17089 * WebView/WebHTMLRepresentation.mm: 17090 (-[WebHTMLRepresentation init]): 17091 * WebView/WebPreferences.mm: 17092 (-[WebPreferences init]): 17093 * WebView/WebView.mm: 17094 (-[WebView UIDelegate]): 17095 (-[WebView resourceLoadDelegate]): 17096 (-[WebView downloadDelegate]): 17097 (-[WebView policyDelegate]): 17098 (-[WebView frameLoadDelegate]): 17099 171002010-07-16 Zhe Su <suzhe@chromium.org> 17101 17102 Reviewed by Darin Adler. 17103 17104 REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms 17105 https://bugs.webkit.org/show_bug.cgi?id=42253 17106 17107 Dummy implementation of EditorClient::willSetInputMethodState. 17108 17109 * WebCoreSupport/WebEditorClient.h: 17110 * WebCoreSupport/WebEditorClient.mm: 17111 (WebEditorClient::willSetInputMethodState): 17112 171132010-07-16 Dan Bernstein <mitz@apple.com> 17114 17115 Reviewed by Sam Weinig. 17116 17117 Part of <rdar://problem/7233974> Deprecate +[WebView _setShouldUseFontSmoothing:] 17118 https://bugs.webkit.org/show_bug.cgi?id=29355 17119 17120 * Misc/WebKitNSStringExtras.h: 17121 * Misc/WebKitNSStringExtras.mm: 17122 (-[NSString _web_drawAtPoint:font:textColor:]): Now calls through to 17123 -_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing YES for the last 17124 parameter. 17125 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Added 17126 allowingFontSmoothing:. If font smoothing is not allowed, sets the font smoothing 17127 mode to antialiased. Otherwise, sets it to auto. 17128 (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Instead of 17129 changing the font smoothing setting in the graphics context, call 17130 -_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing NO for the last 17131 parameter. 17132 171332010-07-16 Anders Carlsson <andersca@apple.com> 17134 17135 Reviewed by Sam Weinig. 17136 17137 Remove semicolons from Objective-C method declarations. 17138 17139 * WebView/WebRenderLayer.mm: 17140 (+[WebRenderLayer nameForLayer:]): 17141 (+[WebRenderLayer compositingInfoForLayer:]): 17142 171432010-07-16 Mikhail Naganov <mnaganov@chromium.org> 17144 17145 Reviewed by Pavel Feldman. 17146 17147 Make JS memory stats available via 'Performance' object (Web Timing). 17148 This statistics is populated only if 'WebKitMemoryInfoEnabled' 17149 preference is set. 17150 17151 'console.memory' is kept until Web Timing object becomes visible by 17152 default (currently it is hidden under compile-time flag). These stats 17153 are guarded with the same preference. 17154 17155 https://bugs.webkit.org/show_bug.cgi?id=41617 17156 17157 * WebKit.order: 17158 * WebView/WebPreferenceKeysPrivate.h: 17159 * WebView/WebPreferences.mm: 17160 (+[WebPreferences initialize]): 17161 (-[WebPreferences memoryInfoEnabled]): 17162 (-[WebPreferences setMemoryInfoEnabled:]): 17163 * WebView/WebPreferencesPrivate.h: 17164 * WebView/WebView.mm: 17165 (-[WebView _preferencesChangedNotification:]): 17166 171672010-07-15 Shinichiro Hamaji <hamaji@chromium.org> 17168 17169 Reviewed by Darin Adler. 17170 17171 Printing test results differ between machines, we should use ImageDiff instead 17172 https://bugs.webkit.org/show_bug.cgi?id=20011 17173 17174 * Misc/WebCoreStatistics.h: 17175 * Misc/WebCoreStatistics.mm: 17176 (-[WebFrame printToCGContext:cgContext:pageWidthInPixels:]): 17177 171782010-07-15 Daniel Bates <dbates@rim.com> 17179 17180 Reviewed by Darin Adler. 17181 17182 [Mac] Implement LayoutTestController::markerTextForListItem() 17183 https://bugs.webkit.org/show_bug.cgi?id=37929 17184 17185 Implements support for markerTextForListItem in the Mac port. 17186 17187 * DOM/WebDOMOperations.mm: 17188 (+[DOMElement _DOMElementFromJSContext]): Added. 17189 (-[DOMElement _markerTextForListItem]): Added. 17190 * DOM/WebDOMOperationsPrivate.h: 17191 171922010-07-14 Simon Fraser <simon.fraser@apple.com> 17193 17194 Fix non-ACCELERATED_COMPOSITING build. 17195 17196 * WebView/WebRenderLayer.mm: 17197 (+[WebRenderLayer compositingInfoForLayer:]): 17198 171992010-07-14 Simon Fraser <simon.fraser@apple.com> 17200 17201 Reviewed by John Sullivan. 17202 17203 <rdar://problem/8186963> Expose information about compositing layers. 17204 17205 Use RenderLayerBacking::compositingLayerType() to add more information about compositing to 17206 WebRenderLayer, via a compositingInfo property. Also show element classnames. 17207 17208 Also add separator items between the various z-order lists. 17209 17210 * WebView/WebRenderLayer.h: 17211 * WebView/WebRenderLayer.mm: 17212 (+[WebRenderLayer nameForLayer:]): 17213 (+[WebRenderLayer compositingInfoForLayer:]): 17214 (-[WebRenderLayer initWithRenderLayer:]): 17215 (-[WebRenderLayer initWithName:]): 17216 (-[WebRenderLayer initWithWebFrame:]): 17217 (-[WebRenderLayer dealloc]): 17218 (-[WebRenderLayer buildDescendantLayers:]): 17219 (-[WebRenderLayer compositingInfo]): 17220 (-[WebRenderLayer isComposited]): 17221 (-[WebRenderLayer isSeparator]): 17222 172232010-07-14 Darin Adler <darin@apple.com> 17224 17225 Another try at fixing the Tiger build. 17226 17227 Avoid non-ASCII in source files to keep Tiger compiler happy. 17228 17229 * WebView/WebRenderLayer.mm: 17230 (+[WebRenderLayer nameForLayer:]): Use %C for the non-ASCII characters. 17231 172322010-07-14 Sam Weinig <sam@webkit.org> 17233 17234 Reviewed by Darin Adler. 17235 17236 Patch for https://bugs.webkit.org/show_bug.cgi?id=42232 17237 Make changing Cursors work in WebKit2. 17238 17239 * WebCoreSupport/WebChromeClient.h: 17240 * WebCoreSupport/WebChromeClient.mm: 17241 (WebChromeClient::setCursor): 17242 * WebView/WebView.mm: 17243 Implement cursor changing at the WebKit level for the sake of WebKit2. 17244 This functionality is being moved from WidgetMac.mm. 17245 (+[WebView _pointingHandCursor]): 17246 Update to use platformCursor() instead of impl(). 17247 172482010-07-13 Simon Fraser <simon.fraser@apple.com> 17249 17250 Fix Tiger build. 17251 17252 Avoid non-ASCII in souce files to keep Tiger compiler happy. 17253 17254 * WebView/WebRenderLayer.mm: 17255 (+[WebRenderLayer nameForLayer:]): 17256 172572010-07-13 Simon Fraser <simon.fraser@apple.com> 17258 17259 Reviewed by Dan Bernstein. 17260 17261 <rdar://problem/8186963> Expose RenderLayer hierarchy via Obj-C for debugging. 17262 17263 Add a WebRenderLayer class that reflects the RenderLayer tree into a hierarchy 17264 of Objective-C objects suitable for display in an outline view. 17265 17266 * WebKit.exp: Export the WebRenderLayer Objective-C class. 17267 * WebView/WebRenderLayer.h: Added. 17268 * WebView/WebRenderLayer.mm: Added. 17269 172702010-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 17271 17272 Reviewed by Darin Adler. 17273 17274 Prevent assertion/duplicate loads for non-deferred subtitute-data loads 17275 17276 https://bugs.webkit.org/show_bug.cgi?id=30879 17277 17278 MainResourceLoader uses the member m_initialRequest to store requests for future 17279 deferred loads. When doing the actual load in handleDataLoadNow(), we therefore 17280 have to clear this request so that subsequent entries into the loader will not 17281 start yet another load. 17282 17283 This can happen as a result of a PageGroupLoadDeferrer going out of scope when 17284 returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false), 17285 but only in the case of using both substitute-data and non-deferred main resource 17286 load together. That's why two new DRT functions were added: 17287 17288 * queueLoadHTMLString() 17289 * setDeferMainResourceLoad() 17290 17291 The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac 17292 and Win the hook uses new SPI in WebDataSource. For Qt a new static member was 17293 added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt. 17294 17295 * WebView/WebDataSource.mm: 17296 (-[WebDataSource _setDeferMainResourceDataLoad:]): 17297 * WebView/WebDataSourcePrivate.h: 17298 172992010-07-13 Philippe Normand <pnormand@igalia.com> 17300 17301 Rubber-stamped by Xan Lopez. 17302 17303 Updated the copyright headers of the files modified in r62476. 17304 17305 * WebView/WebView.mm: 17306 * WebView/WebViewData.h: 17307 * WebView/WebViewInternal.h: 17308 173092010-07-09 Alexey Proskuryakov <ap@apple.com> 17310 17311 Reviewed by Darin Adler. 17312 17313 https://bugs.webkit.org/show_bug.cgi?id=13075 17314 XMLHttpRequest with failed authentication should set status to 401 17315 17316 https://bugs.webkit.org/show_bug.cgi?id=6871 17317 <rdar://problem/3363403> 401 error page is never shown 17318 17319 * Panels/WebPanelAuthenticationHandler.m: 17320 (-[WebPanelAuthenticationHandler startAuthentication:window:]): Updated a comment - this 17321 code cancels loading, not authentication (canceling authentication means telling to 17322 continue without credentials). 17323 (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]): If there were 17324 no credentials provided, tell to continue without any. There may be alternative content 17325 returned with 401. 17326 173272010-07-09 Leon Clarke <leonclarke@google.com> 17328 17329 Reviewed by Adam Barth. 17330 17331 add support for link prefetching 17332 https://bugs.webkit.org/show_bug.cgi?id=3652 17333 17334 * Configurations/FeatureDefines.xcconfig: 17335 173362010-07-08 Aaron Boodman <aa@chromium.org> 17337 17338 Reviewed by Timothy Hatcher. 17339 17340 Add the ability for user scripts and user styles to affect just the top frame. 17341 17342 https://bugs.webkit.org/show_bug.cgi?id=41529 17343 17344 * WebView/WebView.mm: 17345 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:]): 17346 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]): 17347 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:]): 17348 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]): 17349 * WebView/WebViewPrivate.h: 17350 173512010-07-08 Adele Peterson <adele@apple.com> 17352 17353 Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler. 17354 17355 Fix for https://bugs.webkit.org/show_bug.cgi?id=41721 17356 <rdar://problem/8158561> Missing plug-in indicator should have a pressed state 17357 17358 Implement shouldMissingPluginMessageBeButton. 17359 17360 * WebCoreSupport/WebChromeClient.h: 17361 * WebCoreSupport/WebChromeClient.mm: 17362 (WebChromeClient::shouldMissingPluginMessageBeButton): 17363 173642010-07-08 Brady Eidson <beidson@apple.com> 17365 17366 Reviewed by Tim Hatcher. 17367 17368 <rdar://problem/8136327> - Crash in Entourage calling WebCache method from background thread 17369 17370 * Misc/WebCache.mm: 17371 (+[WebCache setDisabled:]): Forward the call to the main thread if called from a background thread. 17372 17373 * Misc/WebNSObjectExtras.h: 17374 * Misc/WebNSObjectExtras.mm: 17375 (+[NSObject _webkit_invokeOnMainThread]): Add a class version of the main thread invoker. 17376 173772010-07-08 Mike Thole <mthole@apple.com> 17378 17379 Reviewed by Darin Adler. 17380 17381 Patch for https://bugs.webkit.org/show_bug.cgi?id=41896 17382 Crash under allScriptsInPDFDocument() in WebPDFDocumentExtras.mm for certain PDFs 17383 17384 * WebView/WebPDFDocumentExtras.mm: 17385 (allScriptsInPDFDocument): Null-check 'data', as CGPDFStreamCopyData() may have returned 0. 17386 173872010-07-08 Sam Weinig <sam@webkit.org> 17388 17389 Reviewed by Anders Carlsson. 17390 17391 Patch for https://bugs.webkit.org/show_bug.cgi?id=41826 17392 Convert BackForwardList to an abstract base class and add BackForwardListImpl 17393 as the concrete implementation of it. 17394 17395 * History/WebBackForwardList.mm: 17396 (-[WebBackForwardList init]): 17397 (-[WebBackForwardList setPageCacheSize:]): 17398 (-[WebBackForwardList pageCacheSize]): 17399 174002010-07-07 Sam Weinig <sam@webkit.org> 17401 17402 Reviewed by Anders Carlsson. 17403 17404 Patch for https://bugs.webkit.org/show_bug.cgi?id=41772 17405 Add basic piping for BackForwardControllerClient. 17406 17407 * WebView/WebView.mm: 17408 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 17409 174102010-07-07 Anders Carlsson <andersca@apple.com> 17411 17412 Reviewed by Sam Weinig. 17413 17414 Change requestURL to a KURL. 17415 https://bugs.webkit.org/show_bug.cgi?id=41775 17416 17417 * Plugins/WebNetscapePluginStream.h: 17418 (WebNetscapePluginStream::setRequestURL): 17419 * Plugins/WebNetscapePluginStream.mm: 17420 (WebNetscapePluginStream::pluginCancelledConnectionError): 17421 (WebNetscapePluginStream::errorForReason): 17422 (WebNetscapePluginStream::startStream): 17423 (WebNetscapePluginStream::didReceiveResponse): 17424 (WebNetscapePluginStream::destroyStream): 17425 174262010-07-07 Anders Carlsson <andersca@apple.com> 17427 17428 Reviewed by Sam Weinig. 17429 17430 Rename the WebBaseNetscapePluginStream.cpp and .h files to WebNetscapePluginStream.cpp and .h to match the class name. 17431 17432 * Plugins/WebNetscapePluginStream.h: Renamed from WebKit/mac/Plugins/WebBaseNetscapePluginStream.h. 17433 * Plugins/WebNetscapePluginStream.mm: Renamed from WebKit/mac/Plugins/WebBaseNetscapePluginStream.mm. 17434 174352010-07-06 Steve Falkenburg <sfalken@apple.com> 17436 17437 Reviewed by Simon Fraser. 17438 17439 Expose URL matching from WebUserContentURLPattern 17440 https://bugs.webkit.org/show_bug.cgi?id=41726 17441 <rdar://problem/7910144> 17442 17443 We previously had a way to construct WebUserContentURLPattern 17444 instances via WebKit, but no way for callers to perform matching. 17445 This patch adds the matchesURL functionality to allow for this. 17446 17447 * Misc/WebUserContentURLPattern.h: Added matchesURL. 17448 * Misc/WebUserContentURLPattern.mm: 17449 (-[WebUserContentURLPattern matchesURL:]): Added. Calls through to WebCore::UserContentURLPattern::matches. 17450 174512010-06-23 Philippe Normand <pnormand@igalia.com> 17452 17453 Reviewed by Eric Carlson. 17454 17455 [GStreamer] on Mac OS use a runloop observer to process the glib context iterations 17456 https://bugs.webkit.org/show_bug.cgi?id=35747 17457 17458 If VIDEO and GSTREAMER are enabled, make the WebView start a 17459 runloop observer that will trigger the glib main context 17460 iterations. Those are needed by the GStreamer player only at the 17461 moment but could later be used for other GLib-dependant components 17462 if required. 17463 17464 * WebView/WebView.mm: 17465 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 17466 (-[WebView _close]): 17467 (-[WebView _clearGlibLoopObserver]): 17468 (glibContextIterationCallback): 17469 (-[WebView _scheduleGlibContextIterations]): 17470 * WebView/WebViewData.h: 17471 * WebView/WebViewInternal.h: 17472 174732010-07-03 Jon Honeycutt <jhoneycutt@apple.com> 17474 17475 The missing plug-in indicator should be clickable 17476 17477 https://bugs.webkit.org/show_bug.cgi?id=41550 17478 <rdar://problem/8132162> 17479 17480 From an original patch by Kevin Decker. 17481 17482 Reviewed by Darin Adler. 17483 17484 * WebCoreSupport/WebChromeClient.h: 17485 Declare an override of missingPluginButtonClicked(). 17486 17487 * WebCoreSupport/WebChromeClient.mm: 17488 (WebChromeClient::missingPluginButtonClicked): 17489 Call the UIDelegate's method. 17490 17491 * WebView/WebUIDelegatePrivate.h: 17492 Declare didPressMissingPluginButton. 17493 174942010-07-01 Timothy Hatcher <timothy@apple.com> 17495 17496 Provide a WebView preference to disable DNS prefetching. 17497 17498 https://bugs.webkit.org/show_bug.cgi?id=28825 17499 rdar://problem/7181249 17500 17501 Reviewed by Darin Adler. 17502 17503 * WebView/WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey. 17504 * WebView/WebPreferences.mm: 17505 (+[WebPreferences initialize]): Set WebKitDNSPrefetchingEnabledPreferenceKey to YES. 17506 (-[WebPreferences isDNSPrefetchingEnabled]): Added. Return WebKitDNSPrefetchingEnabledPreferenceKey's value. 17507 (-[WebPreferences setDNSPrefetchingEnabled:]): Added. Set WebKitDNSPrefetchingEnabledPreferenceKey's value. 17508 * WebView/WebPreferencesPrivate.h: Added isDNSPrefetchingEnabled and setDNSPrefetchingEnabled:. 17509 * WebView/WebView.mm: 17510 (-[WebView _preferencesChangedNotification:]): Call WebCore::Settings::setDNSPrefetchingEnabled. 17511 175122010-07-01 Alexey Proskuryakov <ap@apple.com> 17513 17514 Reviewed by Anders Carlsson. 17515 17516 <rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431> 17517 REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction 17518 17519 Strengthen m_inDestroy "swipe under the carpet" fix. 17520 17521 * Plugins/Hosted/NetscapePluginInstanceProxy.h: Added a long comment about m_inDestroy, and 17522 changed it to static. 17523 17524 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 17525 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): m_inDestroy is now 17526 static, so we don't initialize it in constructor. 17527 (WebKit::NetscapePluginInstanceProxy::destroy): Assert that we aren't already destroying 17528 some plug-in. 17529 (WebKit::NetscapePluginInstanceProxy::evaluate): This function accidentally lacked an 17530 m_inDestroy check in r42789. 17531 175322010-06-29 Zoltan Herczeg <zherczeg@webkit.org> 17533 17534 Reviewed by Nikolas Zimmermann. 17535 17536 Add ConvolveMatrixElement to MigrateHeaders.make 17537 https://bugs.webkit.org/show_bug.cgi?id=5861 17538 17539 * MigrateHeaders.make: 17540 175412010-06-23 John Gregg <johnnyg@google.com> 17542 17543 Reviewed by Kent Tamura. 17544 17545 add ENABLE_DIRECTORY_UPLOAD build support 17546 https://bugs.webkit.org/show_bug.cgi?id=41100 17547 17548 * Configurations/FeatureDefines.xcconfig: 17549 175502010-06-28 Eric Seidel <eric@webkit.org> 17551 17552 Reviewed by Adam Barth. 17553 17554 Make it possible to test the new HTML5 TreeBuilder 17555 https://bugs.webkit.org/show_bug.cgi?id=41276 17556 17557 Adam was concerned that someone might make their port 17558 depend on this setting (I guess we had some trouble with that 17559 with the HTML5Parser setting), so I littered the code with warnings. 17560 17561 test-html5-parser now tests this code path. 17562 17563 * WebView/WebPreferenceKeysPrivate.h: 17564 * WebView/WebPreferences.mm: 17565 (+[WebPreferences initialize]): 17566 (-[WebPreferences html5TreeBuilderEnabled]): 17567 (-[WebPreferences setHTML5TreeBuilderEnabled:]): 17568 * WebView/WebPreferencesPrivate.h: 17569 * WebView/WebView.mm: 17570 (-[WebView _preferencesChangedNotification:]): 17571 175722010-06-25 Yuzo Fujishima <yuzo@google.com> 17573 17574 Reviewed by Shinichiro Hamaji. 17575 17576 Improve default value handling for page format properties. 17577 https://bugs.webkit.org/show_bug.cgi?id=41150 17578 17579 * Misc/WebCoreStatistics.h: 17580 * Misc/WebCoreStatistics.mm: 17581 (-[WebFrame pageSizeAndMarginsInPixels:pageNumber:width:height:marginTop:marginRight:marginBottom:]): 17582 175832010-06-26 Tony Gentilcore <tonyg@chromium.org> 17584 17585 Reviewed by Dimitri Glazkov. 17586 17587 Add an ENABLE_WEB_TIMING option for enabling Web Timing support. 17588 https://bugs.webkit.org/show_bug.cgi?id=38924 17589 17590 * Configurations/FeatureDefines.xcconfig: 17591 175922010-06-24 Jer Noble <jer.noble@apple.com> 17593 17594 Reviewed by Eric Carlson. 17595 17596 Full-screened content doesn't keep the display on: Safari not grabbing a power assertion? 17597 https://bugs.webkit.org/show_bug.cgi?id=40939 17598 rdar://problem/7996172 17599 17600 Take a IOKit power assertion when playing video in fullscreen mode. Release the 17601 assertion when paused in fullscreen mode, and when exiting fullscreen mode. 17602 17603 * WebView/WebVideoFullscreenController.h: 17604 * WebView/WebVideoFullscreenController.mm: 17605 (-[WebVideoFullscreenController windowDidExitFullscreen]): Call updatePowerAssertions. 17606 (-[WebVideoFullscreenController windowDidEnterFullscreen]): Call updatePowerAssertions. 17607 (-[WebVideoFullscreenController _disableIdleDisplaySleep]): 17608 (-[WebVideoFullscreenController _enableIdleDisplaySleep]): 17609 (-[WebVideoFullscreenController _disableIdleSystemSleep]): 17610 (-[WebVideoFullscreenController _enableIdleSystemSleep]): 17611 (-[WebVideoFullscreenController updatePowerAssertions]): Call _(enable|disable)Idle(System|Display)sleep depending on current playback rate and fullscreen status. 17612 (-[WebVideoFullscreenController rateChanged:]): Call updatePowerAssertions. 17613 176142010-06-24 Jer Noble <jer.noble@apple.com> 17615 17616 Reviewed by Darin Adler. 17617 17618 Playing movie full screen on second monitor hides menu bar and title bar on main monitor 17619 https://bugs.webkit.org/show_bug.cgi?id=40933 17620 rdar://problem/7858452 17621 17622 Remove all references to GetSystemUIMode and SetSystemUIMode. Replace these calls with 17623 [NSApplication setPresentationOptions:]. Do not auto-hide the menu bar if the fullscreen 17624 screen is does not contain the menu-bar. Do not auto-hide the dock if the fullscreen screen 17625 is both not the menu-bar screen and not the dock screen. 17626 17627 * WebView/WebVideoFullscreenController.mm: 17628 (-[WebVideoFullscreenController windowDidLoad]): Register the applicationDidChangeScreenParameters: listener. 17629 (-[WebVideoFullscreenController windowDidExitFullscreen]): Calls updateMenuAndDockForFullscreen. 17630 (-[WebVideoFullscreenController windowDidEnterFullscreen]): Calls updateMenuAndDockForFullscreen. 17631 (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]): New notification handler; catches NSApplicationDidChangeScreenParameters. 17632 (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]): Hide/show the menu-bar and dock according to the fullscreen window's screen. 17633 176342010-06-24 Jer Noble <jer.noble@apple.com> 17635 17636 Reviewed by Eric Carlson. 17637 17638 Full screen video in Safari exits full-screen if you switch to another app 17639 https://bugs.webkit.org/show_bug.cgi?id=40635 17640 rdar://problem/7885101 17641 17642 Implement the following rules for exiting full screen when switching apps: 17643 1. If the system has a single screen, switching apps will cause Safari to exit full-screen. 17644 2. Otherwise, if the full-screen screen is the "main screen" (the one with the title bar), 17645 switching apps will cause Safari to exit full-screen. 17646 3. Overriding rules 1 & 2, if the full-screen screen is not on the "current space", 17647 switching apps will NOT cause Safari to exit full-screen. 17648 17649 * WebView/WebVideoFullscreenController.mm: 17650 (-[WebVideoFullscreenController windowDidLoad]): 17651 (-[WebVideoFullscreenController applicationDidResignActive:]): 17652 176532010-06-24 Adele Peterson <adele@apple.com> 17654 17655 Reviewed by Sam Weinig. 17656 17657 Updated fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events 17658 https://bugs.webkit.org/show_bug.cgi?id=41085 17659 17660 * WebView/WebHTMLView.mm: Use the WebCore command system for the pasteAsPlainText selector. 17661 Also remove internal methods that no one is using. 17662 176632010-06-24 Damian Kaleta <dkaleta@apple.com> 17664 17665 Reviewed by Sam Weinig. 17666 17667 Added an ObjC wrapper to Node::renderRect(bool&). 17668 17669 * DOM/WebDOMOperations.mm: 17670 (-[DOMNode _renderRect:]): 17671 * DOM/WebDOMOperationsPrivate.h: 17672 176732010-06-24 Adele Peterson <adele@apple.com> 17674 17675 Reviewed by Eric Carlson. 17676 17677 Fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events 17678 https://bugs.webkit.org/show_bug.cgi?id=41085 17679 17680 * WebView/WebHTMLView.mm: (-[WebHTMLView pasteAsPlainText:]): Reuse code in WebCore 17681 which does everything done here and also fires paste events. 17682 176832010-06-23 Yuzo Fujishima <yuzo@google.com> 17684 17685 Reviewed by Shinichiro Hamaji. 17686 17687 Implement page format data programming interface. 17688 Add methods for testing. 17689 https://bugs.webkit.org/show_bug.cgi?id=37538 17690 17691 * Misc/WebCoreStatistics.h: 17692 * Misc/WebCoreStatistics.mm: 17693 (-[WebFrame isPageBoxVisible:]): 17694 (-[WebFrame pageAreaRectInPixels:]): 17695 (-[WebFrame preferredPageSizeInPixels:]): 17696 176972010-06-22 Anders Carlsson <andersca@apple.com> 17698 17699 Reviewed by Sam Weinig. 17700 17701 Get rid of more USE_LIBDISPATCH code. 17702 17703 * Plugins/Hosted/NetscapePluginHostProxy.h: 17704 177052010-06-22 Anders Carlsson <andersca@apple.com> 17706 17707 Reviewed by Sam Weinig. 17708 17709 Get rid of the USE_LIBDISPATCH code. 17710 17711 * Plugins/Hosted/NetscapePluginHostProxy.mm: 17712 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): 17713 (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): 17714 177152010-06-22 Anders Carlsson <andersca@apple.com> 17716 17717 Reviewed by Sam Weinig. 17718 17719 Wean NetscapePluginHostManager of any knowledge about WebNetscapePluginPackage 17720 https://bugs.webkit.org/show_bug.cgi?id=41006 17721 17722 * Plugins/Hosted/NetscapePluginHostManager.h: 17723 * Plugins/Hosted/NetscapePluginHostManager.mm: 17724 (WebKit::NetscapePluginHostManager::hostForPlugin): 17725 (WebKit::NetscapePluginHostManager::spawnPluginHost): 17726 (WebKit::NetscapePluginHostManager::instantiatePlugin): 17727 (WebKit::NetscapePluginHostManager::createPropertyListFile): 17728 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 17729 (-[WebHostedNetscapePluginView createPlugin]): 17730 * Plugins/WebNetscapePluginPackage.mm: 17731 (-[WebNetscapePluginPackage createPropertyListFile]): 17732 177332010-06-21 Anders Carlsson <andersca@apple.com> 17734 17735 Reviewed by Sam Weinig. 17736 17737 Fix an off-by-one bug I introduced. 17738 17739 * Plugins/WebNetscapePluginPackage.mm: 17740 (-[WebNetscapePluginPackage getPluginInfoFromResources]): 17741 177422010-06-21 Nate Chapin <japhet@chromium.org> 17743 17744 Reviewed by Adam Barth. 17745 17746 FrameLoader cleanup: Split high level subframe and plugin 17747 loading functions into a separate class. 17748 https://bugs.webkit.org/show_bug.cgi?id=40453 17749 17750 * WebView/WebFrame.mm: 17751 (-[WebFrame _cacheabilityDictionary]): 17752 177532010-06-21 Anders Carlsson <andersca@apple.com> 17754 17755 Another Tiger build fix. 17756 17757 * Plugins/WebNetscapePluginPackage.mm: 17758 (-[WebNetscapePluginPackage _tryLoad]): 17759 177602010-06-21 Anders Carlsson <andersca@apple.com> 17761 17762 Reviewed by Sam Weinig. 17763 17764 More WebBasePluginPackage cleanup 17765 https://bugs.webkit.org/show_bug.cgi?id=40944 17766 17767 * Plugins/Hosted/HostedNetscapePluginStream.mm: 17768 (WebKit::HostedNetscapePluginStream::pluginCancelledConnectionError): 17769 * Plugins/Hosted/NetscapePluginHostManager.mm: 17770 (WebKit::NetscapePluginHostManager::spawnPluginHost): 17771 * Plugins/WebBaseNetscapePluginStream.mm: 17772 (WebNetscapePluginStream::pluginCancelledConnectionError): 17773 * Plugins/WebBaseNetscapePluginView.mm: 17774 (WebHaltablePlugin::pluginName): 17775 * Plugins/WebBasePluginPackage.h: 17776 * Plugins/WebBasePluginPackage.mm: 17777 (-[WebBasePluginPackage initWithPath:]): 17778 (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): 17779 (-[WebBasePluginPackage getPluginInfoFromPLists]): 17780 (-[WebBasePluginPackage load]): 17781 (-[WebBasePluginPackage dealloc]): 17782 (-[WebBasePluginPackage finalize]): 17783 (-[WebBasePluginPackage pluginInfo]): 17784 (-[WebBasePluginPackage supportsExtension:]): 17785 (-[WebBasePluginPackage supportsMIMEType:WebCore::]): 17786 (-[WebBasePluginPackage MIMETypeForExtension:]): 17787 (-[WebBasePluginPackage isJavaPlugIn]): 17788 (-[WebBasePluginPackage versionNumber]): 17789 (-[WebBasePluginPackage WebCore::]): 17790 * Plugins/WebNetscapePluginPackage.mm: 17791 (-[WebNetscapePluginPackage openResourceFile]): 17792 (-[WebNetscapePluginPackage closeResourceFile:]): 17793 (-[WebNetscapePluginPackage getPluginInfoFromResources]): 17794 (-[WebNetscapePluginPackage _initWithPath:]): 17795 (-[WebNetscapePluginPackage _applyDjVuWorkaround]): 17796 (-[WebNetscapePluginPackage _tryLoad]): 17797 (-[WebNetscapePluginPackage supportsSnapshotting]): 17798 (-[WebNetscapePluginPackage _unloadWithShutdown:]): 17799 * Plugins/WebPluginDatabase.mm: 17800 (-[WebPluginDatabase refresh]): 17801 (-[WebPluginDatabase _removePlugin:]): 17802 * Plugins/WebPluginPackage.mm: 17803 (-[WebPluginPackage initWithPath:]): 17804 (-[WebPluginPackage load]): 17805 * WebCoreSupport/WebFrameLoaderClient.mm: 17806 (WebFrameLoaderClient::createPlugin): 17807 * WebCoreSupport/WebPlatformStrategies.mm: 17808 (WebPlatformStrategies::getPluginInfo): 17809 178102010-06-21 Anders Carlsson <andersca@apple.com> 17811 17812 Another PowerPC build fix. 17813 17814 * Plugins/WebNetscapePluginPackage.mm: 17815 (-[WebNetscapePluginPackage openResourceFile]): 17816 (-[WebNetscapePluginPackage _tryLoad]): 17817 178182010-06-21 Anders Carlsson <andersca@apple.com> 17819 17820 Try to fix the PowerPC build. 17821 17822 * Plugins/WebNetscapePluginPackage.mm: 17823 (-[WebNetscapePluginPackage _tryLoad]): 17824 178252010-06-21 Nate Chapin <japhet@chromium.org> 17826 17827 Reviewed by Adam Barth. 17828 17829 Update relevant calls into FrameLoader to make use of 17830 FrameLoaderStateMachine. 17831 https://bugs.webkit.org/show_bug.cgi?id=39695 17832 17833 * WebCoreSupport/WebFrameLoaderClient.mm: 17834 (WebFrameLoaderClient::transitionToCommittedForNewPage): 17835 * WebView/WebFrame.mm: 17836 (-[WebFrame _firstLayoutDone]): 17837 178382010-06-21 Dimitri Glazkov <dglazkov@chromium.org> 17839 17840 Reviewed by Dan Bernstein. 17841 17842 Chromium/Mac build fix. 17843 17844 * WebCoreSupport/WebSystemInterface.mm: Change the order of wtf/Platform.h include to let other 17845 headers smell it. 17846 178472010-06-21 Anders Carlsson <andersca@apple.com> 17848 17849 Reviewed by Dan Bernstein. 17850 17851 Make all of WebKit build with clang++ 17852 17853 * DefaultDelegates/WebDefaultPolicyDelegate.m: 17854 (-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]): 17855 * Plugins/Hosted/NetscapePluginHostManager.mm: 17856 * Plugins/WebBaseNetscapePluginView.mm: 17857 (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]): 17858 * WebView/WebDynamicScrollBarsView.mm: 17859 (-[WebDynamicScrollBarsView setSuppressLayout:]): 17860 * WebView/WebHTMLRepresentation.mm: 17861 * WebView/WebNavigationData.mm: 17862 (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]): 17863 * WebView/WebPDFRepresentation.mm: 17864 (-[WebPDFRepresentation setDataSource:]): 17865 (-[WebPDFRepresentation receivedData:withDataSource:]): 17866 (-[WebPDFRepresentation receivedError:withDataSource:]): 17867 * WebView/WebResource.mm: 17868 (-[WebResource description]): 17869 * WebView/WebSerializedJSValue.mm: 17870 (-[WebSerializedJSValue initWithValue:context:exception:]): 17871 * WebView/WebVideoFullscreenController.mm: 17872 (-[WebVideoFullscreenController WebCore::]): 17873 (-[WebVideoFullscreenController setMediaElement:WebCore::]): 17874 (-[WebVideoFullscreenController setDelegate:]): 17875 (-[WebVideoFullscreenController enterFullscreen:]): 17876 * WebView/WebView.mm: 17877 (-[WebView _openFrameInNewWindowFromMenu:]): 17878 (-[WebView _geolocationDidChangePosition:]): 17879 178802010-06-21 Anders Carlsson <andersca@apple.com> 17881 17882 Reviewed by Sam Weinig. 17883 17884 Remove unused dictionary ivars from WebBasePluginPackage 17885 https://bugs.webkit.org/show_bug.cgi?id=40928 17886 17887 * Plugins/WebBasePluginPackage.h: 17888 * Plugins/WebBasePluginPackage.mm: 17889 (-[WebBasePluginPackage getPluginInfoFromPLists]): 17890 (-[WebBasePluginPackage dealloc]): 17891 * Plugins/WebNetscapePluginPackage.mm: 17892 (-[WebNetscapePluginPackage getPluginInfoFromResources]): 17893 178942010-06-21 Dan Bernstein <mitz@apple.com> 17895 17896 Build fix 17897 17898 * WebCoreSupport/WebSystemInterface.mm: 17899 (InitWebCoreSystemInterface): 17900 179012010-06-21 Dan Bernstein <mitz@apple.com> 17902 17903 Reviewed by Darin Adler. 17904 17905 WebKit part of implementing the 'hyphens' and 'hyphenate-character' properties 17906 https://bugs.webkit.org/show_bug.cgi?id=10228 17907 17908 * WebCoreSupport/WebSystemInterface.mm: 17909 (InitWebCoreSystemInterface): Initialize wkGetHyphenationLocationBeforeIndex. 17910 179112010-06-21 Satish Sampath <satish@chromium.org> 17912 17913 Reviewed by Steve Block. 17914 17915 Speech Input Patch 0: Added compilation argument to conditionally compile pending patches. 17916 https://bugs.webkit.org/show_bug.cgi?id=40878 17917 17918 * Configurations/FeatureDefines.xcconfig: 17919 179202010-06-20 Anders Carlsson <andersca@apple.com> 17921 17922 Fix Tiger build. 17923 17924 * Plugins/WebNetscapePluginPackage.mm: 17925 179262010-06-20 Anders Carlsson <andersca@apple.com> 17927 17928 Reviewed by Dan Bernstein. 17929 17930 Get rid of the old MIMETypes getter method 17931 https://bugs.webkit.org/show_bug.cgi?id=40898 17932 17933 * Plugins/WebBasePluginPackage.h: 17934 * Plugins/WebBasePluginPackage.mm: 17935 (-[WebBasePluginPackage supportsExtension:]): 17936 (-[WebBasePluginPackage supportsMIMEType:WebCore::]): 17937 (-[WebBasePluginPackage MIMETypeForExtension:]): 17938 * Plugins/WebPluginDatabase.mm: 17939 (-[WebPluginDatabase refresh]): 17940 (-[WebPluginDatabase _removePlugin:]): 17941 179422010-06-20 Anders Carlsson <andersca@apple.com> 17943 17944 Reviewed by Dan Bernstein. 17945 17946 Remove bogus const qualifiers. 17947 17948 * WebCoreSupport/WebPasteboardHelper.h: 17949 * WebCoreSupport/WebPasteboardHelper.mm: 17950 (WebPasteboardHelper::urlFromPasteboard): 17951 (WebPasteboardHelper::plainTextFromPasteboard): 17952 (WebPasteboardHelper::fragmentFromPasteboard): 17953 179542010-06-20 Anders Carlsson <andersca@apple.com> 17955 17956 Reviewed by Dan Bernstein. 17957 17958 Get rid of the extensionToMIME mapping in WebBasePluginPackage 17959 https://bugs.webkit.org/show_bug.cgi?id=40897 17960 17961 Instead of using the extensionToMIME mutable dictionary, use the MIME types vector. 17962 While this makes lookup of MIME types based on extensions linear instead of constant, 17963 the number of extensions per plug-in is too small for it to matter. 17964 17965 * Plugins/WebBasePluginPackage.h: 17966 * Plugins/WebBasePluginPackage.mm: 17967 (-[WebBasePluginPackage initWithPath:]): 17968 (-[WebBasePluginPackage dealloc]): 17969 (-[WebBasePluginPackage supportsExtension:]): 17970 (-[WebBasePluginPackage MIMETypeForExtension:]): 17971 (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]): 17972 179732010-06-20 Anders Carlsson <andersca@apple.com> 17974 17975 Reviewed by Dan Bernstein. 17976 17977 Add a MimeClassInfo Vector to WebBasePluginPackage 17978 https://bugs.webkit.org/show_bug.cgi?id=40896 17979 17980 * Plugins/WebBasePluginPackage.h: 17981 * Plugins/WebBasePluginPackage.mm: 17982 (-[WebBasePluginPackage getPluginInfoFromPLists]): 17983 (-[WebBasePluginPackage WebCore::]): 17984 * Plugins/WebNetscapePluginPackage.mm: 17985 (-[WebNetscapePluginPackage getPluginInfoFromResources]): 17986 * WebCoreSupport/WebPlatformStrategies.mm: 17987 (WebPlatformStrategies::getPluginInfo): 17988 179892010-06-20 Anders Carlsson <andersca@apple.com> 17990 17991 Reviewed by Dan Bernstein. 17992 17993 Move the NSBundle ivar to WebPluginPackage 17994 https://bugs.webkit.org/show_bug.cgi?id=40894 17995 17996 * Plugins/WebBasePluginPackage.h: 17997 * Plugins/WebBasePluginPackage.mm: 17998 (-[WebBasePluginPackage initWithPath:]): 17999 (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): 18000 (-[WebBasePluginPackage getPluginInfoFromPLists]): 18001 (-[WebBasePluginPackage load]): 18002 (-[WebBasePluginPackage dealloc]): 18003 * Plugins/WebNetscapePluginPackage.mm: 18004 (-[WebNetscapePluginPackage _initWithPath:]): 18005 * Plugins/WebPluginPackage.h: 18006 * Plugins/WebPluginPackage.mm: 18007 (-[WebPluginPackage initWithPath:]): 18008 (-[WebPluginPackage dealloc]): 18009 (-[WebPluginPackage viewFactory]): 18010 (-[WebPluginPackage load]): 18011 180122010-06-20 Anders Carlsson <andersca@apple.com> 18013 18014 Reviewed by Sam Weinig. 18015 18016 Remove -[WebBasePluginPackage bundle] 18017 https://bugs.webkit.org/show_bug.cgi?id=40892 18018 18019 Add -[WebBasePluginPackage bundleIdentifier] and switch clients over to it. 18020 18021 Move the supportsSnapshotting method over to the plug-in package. 18022 18023 * Plugins/Hosted/NetscapePluginHostManager.mm: 18024 (WebKit::NetscapePluginHostManager::hostForPackage): 18025 * Plugins/WebBaseNetscapePluginView.mm: 18026 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): 18027 (-[WebBaseNetscapePluginView supportsSnapshotting]): 18028 * Plugins/WebBasePluginPackage.h: 18029 * Plugins/WebBasePluginPackage.mm: 18030 (-[WebBasePluginPackage isQuickTimePlugIn]): 18031 (-[WebBasePluginPackage isJavaPlugIn]): 18032 (-[WebBasePluginPackage WebCore::]): 18033 Call bundleIdentifier directly instead of asking the bundle 18034 * Plugins/WebNetscapePluginPackage.h: 18035 * Plugins/WebNetscapePluginPackage.mm: 18036 (-[WebNetscapePluginPackage supportsSnapshotting]): 18037 * Plugins/WebNetscapePluginView.mm: 18038 (-[WebNetscapePluginView setAttributeKeys:andValues:]): 18039 (-[WebNetscapePluginView _createPlugin]): 18040 * Plugins/WebPluginDatabase.mm: 18041 (checkCandidate): 18042 180432010-06-20 Anders Carlsson <andersca@apple.com> 18044 18045 Reviewed by Dan Bernstein. 18046 18047 Change some WebPluginDabase ivars to use WebCore::String instead of NSString. 18048 https://bugs.webkit.org/show_bug.cgi?id=40869 18049 18050 Re-land r61459, with extra null-checks in WebFrameLoaderClient. 18051 18052 * Plugins/Hosted/NetscapePluginHostManager.mm: 18053 (WebKit::NetscapePluginHostManager::spawnPluginHost): 18054 * Plugins/WebBasePluginPackage.h: 18055 * Plugins/WebBasePluginPackage.mm: 18056 (-[WebBasePluginPackage initWithPath:]): 18057 (-[WebBasePluginPackage getPluginInfoFromPLists]): 18058 (-[WebBasePluginPackage dealloc]): 18059 (-[WebBasePluginPackage name]): 18060 (-[WebBasePluginPackage path]): 18061 (-[WebBasePluginPackage filename]): 18062 (-[WebBasePluginPackage pluginDescription]): 18063 (-[WebBasePluginPackage description]): 18064 (-[WebBasePluginPackage isJavaPlugIn]): 18065 * Plugins/WebNetscapePluginPackage.mm: 18066 (-[WebNetscapePluginPackage getPluginInfoFromResources]): 18067 (-[WebNetscapePluginPackage _tryLoad]): 18068 (-[WebNetscapePluginPackage _unloadWithShutdown:]): 18069 * Plugins/WebPluginPackage.mm: 18070 (-[WebPluginPackage load]): 18071 * WebCoreSupport/WebFrameLoaderClient.mm: 18072 (WebFrameLoaderClient::createPlugin): 18073 180742010-06-18 Adam Barth <abarth@webkit.org> 18075 18076 Unreviewed, rolling out r61459. 18077 http://trac.webkit.org/changeset/61459 18078 https://bugs.webkit.org/show_bug.cgi?id=40869 18079 18080 Seems to have broken two tests on the Tiger buildbot: 18081 18082 dom/html/level2/html/AppletsCollection.html 18083 plugins/qt-qwidget-plugin.html 18084 18085 Anders wasn't on #webkit... 18086 18087 * Plugins/Hosted/NetscapePluginHostManager.mm: 18088 (WebKit::NetscapePluginHostManager::spawnPluginHost): 18089 * Plugins/WebBasePluginPackage.h: 18090 * Plugins/WebBasePluginPackage.mm: 18091 (-[WebBasePluginPackage initWithPath:]): 18092 (-[WebBasePluginPackage getPluginInfoFromPLists]): 18093 (-[WebBasePluginPackage dealloc]): 18094 (-[WebBasePluginPackage name]): 18095 (-[WebBasePluginPackage path]): 18096 (-[WebBasePluginPackage filename]): 18097 (-[WebBasePluginPackage pluginDescription]): 18098 (-[WebBasePluginPackage setName:]): 18099 (-[WebBasePluginPackage setPath:]): 18100 (-[WebBasePluginPackage setPluginDescription:]): 18101 (-[WebBasePluginPackage description]): 18102 (-[WebBasePluginPackage isJavaPlugIn]): 18103 * Plugins/WebNetscapePluginPackage.mm: 18104 (-[WebNetscapePluginPackage getPluginInfoFromResources]): 18105 (-[WebNetscapePluginPackage _tryLoad]): 18106 (-[WebNetscapePluginPackage _unloadWithShutdown:]): 18107 * Plugins/WebPluginPackage.mm: 18108 (-[WebPluginPackage load]): 18109 181102010-06-18 Anders Carlsson <andersca@apple.com> 18111 18112 Fix Tiger build. 18113 18114 * Plugins/WebBasePluginPackage.mm: 18115 (-[WebBasePluginPackage isJavaPlugIn]): 18116 181172010-06-18 Anders Carlsson <andersca@apple.com> 18118 18119 Reviewed by Sam Weinig. 18120 18121 Change some WebPluginDabase ivars to use WebCore::String instead of NSString. 18122 https://bugs.webkit.org/show_bug.cgi?id=40869 18123 18124 * Plugins/Hosted/NetscapePluginHostManager.mm: 18125 (WebKit::NetscapePluginHostManager::spawnPluginHost): 18126 * Plugins/WebBasePluginPackage.h: 18127 * Plugins/WebBasePluginPackage.mm: 18128 (-[WebBasePluginPackage initWithPath:]): 18129 (-[WebBasePluginPackage getPluginInfoFromPLists]): 18130 (-[WebBasePluginPackage dealloc]): 18131 (-[WebBasePluginPackage name]): 18132 (-[WebBasePluginPackage path]): 18133 (-[WebBasePluginPackage filename]): 18134 (-[WebBasePluginPackage pluginDescription]): 18135 (-[WebBasePluginPackage description]): 18136 (-[WebBasePluginPackage isJavaPlugIn]): 18137 * Plugins/WebNetscapePluginPackage.mm: 18138 (-[WebNetscapePluginPackage getPluginInfoFromResources]): 18139 (-[WebNetscapePluginPackage _tryLoad]): 18140 (-[WebNetscapePluginPackage _unloadWithShutdown:]): 18141 * Plugins/WebPluginPackage.mm: 18142 (-[WebPluginPackage load]): 18143 181442010-06-18 Anders Carlsson <andersca@apple.com> 18145 18146 Reviewed by Sam Weinig. 18147 18148 Rename WebPluginPackage.m to make it an Objective-C++ file. 18149 18150 * Plugins/WebPluginPackage.m: Removed. 18151 * Plugins/WebPluginPackage.mm: Copied from Plugins/WebPluginPackage.m. 18152 181532010-06-18 Anders Carlsson <andersca@apple.com> 18154 18155 Reviewed by Sam Weinig. 18156 18157 Get rid of the NSEnumerators from WebBasePluginPackage 18158 https://bugs.webkit.org/show_bug.cgi?id=40868 18159 18160 * Plugins/WebBasePluginPackage.h: 18161 * Plugins/WebBasePluginPackage.mm: 18162 (-[WebBasePluginPackage MIMETypes]): 18163 (-[WebBasePluginPackage supportsExtension:]): 18164 (-[WebBasePluginPackage supportsMIMEType:]): 18165 * Plugins/WebPluginDatabase.mm: 18166 (-[WebPluginDatabase pluginForMIMEType:]): 18167 (-[WebPluginDatabase pluginForExtension:]): 18168 (-[WebPluginDatabase refresh]): 18169 (-[WebPluginDatabase _removePlugin:]): 18170 * WebCoreSupport/WebPlatformStrategies.mm: 18171 (WebPlatformStrategies::getPluginInfo): 18172 181732010-06-18 Anders Carlsson <andersca@apple.com> 18174 18175 Reviewed by Sam Weinig. 18176 18177 Make WebCoreSystemInterface.h a C++ only header 18178 https://bugs.webkit.org/show_bug.cgi?id=40867 18179 18180 * WebCoreSupport/WebSystemInterface.h: 18181 * WebCoreSupport/WebSystemInterface.m: Removed. 18182 * WebCoreSupport/WebSystemInterface.mm: Copied from WebKit/mac/WebCoreSupport/WebSystemInterface.m. 18183 181842010-06-18 Anders Carlsson <andersca@apple.com> 18185 18186 Reviewed by Sam Weinig. 18187 18188 Clean up WebPluginDatabase.mm 18189 https://bugs.webkit.org/show_bug.cgi?id=40866 18190 18191 * Plugins/WebBasePluginPackage.h: 18192 * Plugins/WebBasePluginPackage.mm: 18193 (pathByResolvingSymlinksAndAliases): 18194 (-[WebBasePluginPackage initWithPath:]): 18195 Change an instance method into a static function. 18196 18197 * Plugins/WebPluginDatabase.mm: 18198 (PluginPackageCandidates::PluginPackageCandidates): 18199 (PluginPackageCandidates::update): 18200 (PluginPackageCandidates::bestCandidate): 18201 Add a new PluginPackageCandidates class. 18202 18203 (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): 18204 Use PluginPackageCandidates here. 18205 182062010-06-18 Anders Carlsson <andersca@apple.com> 18207 18208 Fix Tiger build. 18209 18210 * WebCoreSupport/WebPlatformStrategies.mm: 18211 182122010-06-18 Anders Carlsson <andersca@apple.com> 18213 18214 Reviewed by Darin Adler. 18215 18216 Get rid of PluginDataMac.mm and use the plug-in strategy instead 18217 https://bugs.webkit.org/show_bug.cgi?id=40860 18218 18219 * Plugins/WebBasePluginPackage.h: 18220 * WebCoreSupport/WebPlatformStrategies.h: 18221 * WebCoreSupport/WebPlatformStrategies.mm: 18222 (WebPlatformStrategies::createPluginStrategy): 18223 (WebPlatformStrategies::refreshPlugins): 18224 (WebPlatformStrategies::getPluginInfo): 18225 * WebCoreSupport/WebViewFactory.mm: 18226 182272010-06-18 Anders Carlsson <andersca@apple.com> 18228 18229 Reviewed by Dan Bernstein. 18230 18231 Add stubbed out WebPlatformStrategies class to WebKit. 18232 https://bugs.webkit.org/show_bug.cgi?id=40851 18233 18234 * WebCoreSupport/WebPlatformStrategies.h: Added. 18235 * WebCoreSupport/WebPlatformStrategies.mm: Added. 18236 (WebPlatformStrategies::initialize): 18237 (WebPlatformStrategies::WebPlatformStrategies): 18238 (WebPlatformStrategies::createPluginStrategy): 18239 * WebView/WebView.mm: 18240 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 18241 182422010-06-15 Dumitru Daniliuc <dumi@chromium.org> 18243 18244 Reviewed by Adam Barth. 18245 18246 Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase. 18247 https://bugs.webkit.org/show_bug.cgi?id=39041 18248 18249 * WebView/WebView.mm: 18250 (-[WebView _preferencesChangedNotification:]): 18251 182522010-06-17 Darin Adler <darin@apple.com> 18253 18254 Reviewed by Sam Weinig. 18255 18256 Use adoptRef and create functions in more code paths 18257 https://bugs.webkit.org/show_bug.cgi?id=40760 18258 18259 * Plugins/Hosted/NetscapePluginInstanceProxy.h: Made create no longer 18260 be an inline function. 18261 18262 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 18263 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): 18264 Moved the call to addPluginInstance out of here. 18265 (WebKit::NetscapePluginInstanceProxy::create): Move it in here. 18266 This makes sure we call adoptRef on the new proxy before any caller 18267 calls ref on it. 18268 182692010-06-16 Eric Seidel <eric@webkit.org> 18270 18271 Reviewed by Adam Barth. 18272 18273 Enable HTML5 Parser in Safari on Mac 18274 https://bugs.webkit.org/show_bug.cgi?id=40739 18275 18276 The HTML5 parser is probably off on all webkit ports. 18277 We should either flip the meaning of the default so that 18278 "false" means HTML5 on all ports, or we'll have to write 18279 more code like this for all the other ports. 18280 18281 * WebView/WebPreferences.mm: 18282 (+[WebPreferences initialize]): 18283 182842010-06-15 Mark Rowe <mrowe@apple.com> 18285 18286 Reviewed by Sam Weinig. 18287 18288 Don't leak WebGeolocationPositionInternal and GeolocationPosition instances for every WebGeolocationPosition created. 18289 18290 * WebView/WebGeolocationPosition.mm: 18291 (-[WebGeolocationPosition dealloc]): Implement -dealloc and release our WebGeolocationPositionInternal instance. 18292 182932010-06-10 Yuzo Fujishima <yuzo@google.com> 18294 18295 Reviewed by Shinichiro Hamaji. 18296 18297 Implement render style selection for pages to support CSS3 Paged Media. 18298 https://bugs.webkit.org/show_bug.cgi?id=35961 18299 18300 * Misc/WebCoreStatistics.h: 18301 * Misc/WebCoreStatistics.mm: 18302 (-[WebFrame pageProperty:propertyName:]): 18303 183042010-06-15 Darin Adler <darin@apple.com> 18305 18306 Reviewed by Adam Barth. 18307 18308 Move functions out of Frame class that were marked "move to Chrome" 18309 https://bugs.webkit.org/show_bug.cgi?id=39636 18310 18311 * WebView/WebView.mm: 18312 (-[WebView shouldClose]): Call shouldClose on FrameLoader instead of 18313 going through Frame. 18314 183152010-06-15 Anders Carlsson <andersca@apple.com> 18316 18317 Reviewed by Dan Bernstein. 18318 18319 Remove getPluginInfoFromBundleAndMIMEDictionary: 18320 18321 * Plugins/WebBasePluginPackage.mm: 18322 183232010-06-15 Anders Carlsson <andersca@apple.com> 18324 18325 Reviewed by Dan Bernstein. 18326 18327 Fold getPluginInfoFromBundleAndMIMEDictionary: into its sole caller. 18328 18329 * Plugins/WebBasePluginPackage.mm: 18330 (-[WebBasePluginPackage getPluginInfoFromPLists]): 18331 183322010-06-11 Simon Fraser <simon.fraser@apple.com> 18333 18334 Reviewed by Darin Adler. 18335 18336 <rdar://problem/8084721> Pages using accelerated compositing fail to update correctly in Carbon apps 18337 18338 The run loop observer used to commit compositing layer changes does not do 18339 updates if [window viewsNeedDisplay] is true, because this indicates that a delayed window 18340 update is pending (added in r58623). 18341 18342 However, Carbon apps don't use the NSWindow updating mechanism, so [window viewsNeedDisplay] always returns YES. 18343 This caused us to never sync compositing layers. 18344 18345 So detect if the current window is wrapping a carbon window, and in that case consult the root 18346 HIView to detect if display is pending. 18347 18348 * WebView/WebView.mm: 18349 (layerSyncRunLoopObserverCallBack): 18350 183512010-06-15 Dan Bernstein <mitz@apple.com> 18352 18353 Reviewed by John Sullivan. 18354 18355 <rdar://problem/8077032> REGRESSION (r50796): Black background on AppleScript generated email 18356 18357 Test: platform/mac/editing/input/NSBackgroundColor-transparent.html 18358 18359 r50796 changed the initial background color from invalid to transparent. As a result, 18360 NSAttributedStrings returned from +_web_attributedStringFromRange started including the 18361 NSBackgroundColor attribute, with a transparent color as the value. This caused problems for 18362 components in the system that ignore the alpha component, turning the color into opaque black. 18363 18364 * Misc/WebNSAttributedStringExtras.mm: 18365 (+[NSAttributedString _web_attributedStringFromRange:]): Change to not include the background 18366 and foreground color attributes if the color are transparent. 18367 183682010-06-14 Ilya Tikhonovsky <loislo@chromium.org> 18369 18370 Reviewed by Pavel Feldman. 18371 18372 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc 18373 data from inspected page to WebInspector as JSON string via http. The native 18374 serialization to JSON string is supported by InspectorValue's classes. This patch 18375 has the implementation of sendMessageToFrontend function. WebKit version of it still 18376 uses ScriptFunctionCall and will be switched to another transport a little bit later. 18377 https://bugs.webkit.org/show_bug.cgi?id=40134 18378 18379 * WebCoreSupport/WebInspectorClient.h: 18380 * WebCoreSupport/WebInspectorClient.mm: 18381 (WebInspectorClient::WebInspectorClient): 18382 (WebInspectorClient::openInspectorFrontend): 18383 183842010-06-10 David Hyatt <hyatt@apple.com> 18385 18386 Reviewed by John Sullivan. 18387 18388 https://bugs.webkit.org/show_bug.cgi?id=40441, back out the original fix for 29601, since it has broken continuous 18389 wheel delta values. 18390 18391 * WebView/WebDynamicScrollBarsView.mm: 18392 (-[WebDynamicScrollBarsView scrollWheel:]): 18393 183942010-06-09 Sheriff Bot <webkit.review.bot@gmail.com> 18395 18396 Unreviewed, rolling out r60889. 18397 http://trac.webkit.org/changeset/60889 18398 https://bugs.webkit.org/show_bug.cgi?id=40365 18399 18400 gtk bot has some kind of memory corruption (Requested by 18401 loislo on #webkit). 18402 18403 * WebCoreSupport/WebInspectorClient.h: 18404 * WebCoreSupport/WebInspectorClient.mm: 18405 (WebInspectorClient::WebInspectorClient): 18406 (WebInspectorClient::openInspectorFrontend): 18407 (-[WebInspectorWindowController destroyInspectorView]): 18408 184092010-06-07 Ilya Tikhonovsky <loislo@chromium.org> 18410 18411 Reviewed by Pavel Feldman. 18412 18413 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc 18414 data from inspected page to WebInspector as JSON string via http. The native 18415 serialization to JSON string is supported by InspectorValue's classes. This patch 18416 has the implementation of sendMessageToFrontend function. WebKit version of it still 18417 uses ScriptFunctionCall and will be switched to another transport a little bit later. 18418 https://bugs.webkit.org/show_bug.cgi?id=40134 18419 18420 * WebCoreSupport/WebInspectorClient.h: 18421 * WebCoreSupport/WebInspectorClient.mm: 18422 (WebInspectorClient::WebInspectorClient): 18423 (WebInspectorClient::openInspectorFrontend): 18424 184252010-06-08 Mark Rowe <mrowe@apple.com> 18426 18427 Reviewed by Adele Peterson. 18428 18429 <rdar://problem/8072136> REGRESSION (r56051): Inspect Element context menu does nothing in applications linked against 10.4 SDK 18430 18431 * WebCoreSupport/WebContextMenuClient.mm: 18432 (fixMenusReceivedFromOldClients): Fix up the tag on the Inspect Element menu item. This ensures that even if the 18433 context menu layout doesn't match our expectations that the menu item will continue to trigger the web inspector. 18434 184352010-06-08 Antonio Gomes <tonikitoo@webkit.org> 18436 18437 Reviewed by Ojan Vafai and Darin Adler. 18438 18439 Refactor platform dependent editing behavior code out of Settings 18440 https://bugs.webkit.org/show_bug.cgi?id=39854 18441 18442 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to 18443 EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly. 18444 18445 * WebView/WebFrame.mm: 18446 (core): 18447 * WebView/WebFrameInternal.h: 18448 * WebView/WebView.mm: 18449 (-[WebView _preferencesChangedNotification:]): 18450 184512010-06-06 MORITA Hajime <morrita@google.com> 18452 18453 Unreviewd, follow up to r60820 18454 18455 https://bugs.webkit.org/show_bug.cgi?id=40219 18456 [Mac] ENABLE_METER_TAG should be enabled 18457 18458 Added ENABLE_METER_TAG. 18459 18460 * Configurations/FeatureDefines.xcconfig: 18461 184622010-06-06 Gavin Barraclough <barraclough@apple.com> 18463 18464 Reviewed by Sam Weinig. 18465 18466 Bug 40214 - Clean up error construction / throwing in JSC. 18467 18468 The one egregious insanity here is that creating an error requires 18469 a VM-entry-esqe-host call (the string argument is wrapped as a JS 18470 object & pushed on the RegisterFile, then unwrapped back to a 18471 UString). Changing this also means you only require a global 18472 object, not an ExecState, to create an error. 18473 18474 The methods to create error objects are also parameterized 18475 requiring a switch on the type, which can be made cleaner and 18476 faster by moving to a separate method per error type. Code to add 18477 divot information to error had been duplicated, and is coalesced 18478 back into a single function. 18479 18480 Convenience methods added to create & throw type & syntax error 18481 with a default error message, since this is a common case. 18482 18483 Also, errors are currently thrown either using 18484 "throwError(exec, error)" or "exec->setException(error)" - unify 18485 on the former, since this is more commonly used. Add 18486 "throwVMError(exec, error)" equivalents, as a convenience for 18487 cases where the result was being wrapped in "JSValue::encode(...)". 18488 18489 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 18490 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState): 18491 * Plugins/Hosted/ProxyInstance.mm: 18492 (WebKit::ProxyInstance::invokeMethod): 18493 184942010-06-02 Gavin Barraclough <barraclough@apple.com> 18495 18496 Reviewed by Oliver Hunt. 18497 18498 Bug 40094 - The return type of NativeFunction should be EncodedJSValue 18499 On Windows & Linux, using JSVALUE32_64, EncodedJSValue is returned in registers, but JSValue is not. 18500 18501 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 18502 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 18503 (WebKit::NetscapePluginInstanceProxy::invoke): 18504 185052010-06-02 Sterling Swigart <sswigart@google.com> 18506 18507 Reviewed by David Levin. 18508 18509 Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches. 18510 https://bugs.webkit.org/show_bug.cgi?id=39906 18511 18512 * Configurations/FeatureDefines.xcconfig: 18513 185142010-06-01 David Hyatt <hyatt@apple.com> 18515 18516 Reviewed by Anders Carlsson. 18517 18518 Add a preference for paginating during layout (the new model for computing page breaks). 18519 18520 * WebView/WebPreferenceKeysPrivate.h: 18521 * WebView/WebPreferences.mm: 18522 (-[WebPreferences paginateDuringLayoutEnabled]): 18523 (-[WebPreferences setPaginateDuringLayoutEnabled:]): 18524 * WebView/WebPreferencesPrivate.h: 18525 * WebView/WebView.mm: 18526 (-[WebView _preferencesChangedNotification:]): 18527 185282010-06-01 Kevin Decker <kdecker@apple.com> 18529 18530 Reviewed by Simon Fraser. 18531 18532 https://bugs.webkit.org/show_bug.cgi?id=40025 18533 <rdar://problem/8046273> All Flash content crashes after installing CS5 Design Premium. 18534 18535 * Plugins/WebBaseNetscapePluginView.mm: 18536 (-[WebBaseNetscapePluginView supportsSnapshotting]): Do not support snapshotting Flash 10.1 if 18537 the version is less than 10.1.53.60. 18538 185392010-06-01 Alexey Proskuryakov <ap@apple.com> 18540 18541 Reviewed by Sam Weinig. 18542 18543 https://bugs.webkit.org/show_bug.cgi?id=39434 18544 REGRESSION (r59811): Geolocation callbacks cannot be created 18545 18546 Removing unused WebGeolocationMock. 18547 18548 * WebCoreSupport/WebGeolocationMock.mm: Removed. 18549 * WebCoreSupport/WebGeolocationMockPrivate.h: Removed. 18550 * WebKit.exp: 18551 185522010-05-30 Darin Adler <darin@apple.com> 18553 18554 Reviewed by Sam Weinig. 18555 18556 Make more HTML DOM members private, especially constructors, third and final batch 18557 https://bugs.webkit.org/show_bug.cgi?id=39916 18558 18559 * WebView/WebHTMLRepresentation.mm: 18560 (-[WebHTMLRepresentation elementWithName:inForm:]): Use the new HTMLFormElement 18561 function, associatedElements, rather than getting directly at a data member 18562 named formElements. 18563 (-[WebHTMLRepresentation controlsInForm:]): Ditto. 18564 185652010-05-28 Geoffrey Garen <ggaren@apple.com> 18566 18567 Reviewed by Sam Weinig, Gavin Barraclough, Oliver Hunt. 18568 18569 Simplified the host calling convention. 18570 18571 PART ONE: Functional code changes. 18572 18573 [ None in WebKit ] 18574 18575 PART TWO: Global search and replace. 18576 18577 In the areas below, I used global search-and-replace to change 18578 (ExecState*, JSObject*, JSValue, const ArgList&) => (ExecState*) 18579 args.size() => exec->argumentCount() 18580 args.at(i) => exec->argument(i) 18581 18582 * Plugins/Hosted/ProxyInstance.h: 18583 * Plugins/Hosted/ProxyInstance.mm: 18584 (WebKit::ProxyInstance::invoke): 18585 (WebKit::ProxyInstance::invokeMethod): 18586 (WebKit::ProxyInstance::invokeDefaultMethod): 18587 185882010-05-27 Beth Dakin <bdakin@apple.com> 18589 18590 Reviewed by Simon Fraser. 18591 18592 Change z-component to 1. 18593 18594 * WebView/WebHTMLView.mm: 18595 (-[WebHTMLView viewDidMoveToWindow]): 18596 (-[WebHTMLView attachRootLayer:]): 18597 185982010-05-26 Simon Fraser <simon.fraser@apple.com> 18599 18600 Reviewed by Beth Dakin and Darin Adler. 18601 18602 Fix for <rdar://problem/7464703> HiDPI: [Layers] Compositing layers 18603 do not scale properly when running with a resolution independent 18604 scale 18605 18606 Apply the userSpaceScaleFactor as a scale on the layerHostingView. 18607 18608 * WebView/WebHTMLView.mm: 18609 (-[WebHTMLView viewDidMoveToWindow]): 18610 (-[WebHTMLView attachRootLayer:]): 18611 186122010-05-25 Alexey Proskuryakov <ap@apple.com> 18613 18614 Reviewed by Darin Adler. 18615 18616 https://bugs.webkit.org/show_bug.cgi?id=39621 18617 <rdar://problem/8009738> Extreme memory growth on DOM Hanoi test 18618 18619 Removed formStateDidChange support, which is not needed by any client. 18620 18621 * WebCoreSupport/WebChromeClient.h: 18622 (WebChromeClient::formStateDidChange): 18623 * WebCoreSupport/WebChromeClient.mm: 18624 * WebView/WebUIDelegatePrivate.h: 18625 186262010-05-25 Brady Eidson <beidson@apple.com> 18627 18628 Reviewed by Darin Adler. 18629 18630 Database origins aren't populated at launch (missing db in prefs sheet, possible other symptoms) 18631 <rdar://problem/8013233> and https://bugs.webkit.org/show_bug.cgi?id=39486 18632 18633 * Storage/WebDatabaseManager.mm: 18634 (WebKitInitializeDatabasesIfNecessary): Call initializeTracker() instead of trying to set the path on 18635 an already created tracker that already has its origins populated. 18636 186372010-05-24 Darin Adler <darin@apple.com> 18638 18639 Reviewed by Eric Seidel. 18640 18641 Move view-related functions from Frame to FrameView 18642 https://bugs.webkit.org/show_bug.cgi?id=39366 18643 18644 * WebView/WebView.mm: 18645 (-[WebView _setZoomMultiplier:isTextOnly:]): Call function on FrameView. 18646 (-[WebView setEditable:]): Get rid of call to empty function, 18647 removeEditingStyleFromBodyElement. 18648 186492010-05-21 David Hyatt <hyatt@apple.com> 18650 18651 Reviewed by Dan Bernstein. 18652 18653 https://bugs.webkit.org/show_bug.cgi?id=39420 18654 18655 Make sure everyone who needs to is using visitedDependentColor rather than accessing styles 18656 directly. 18657 18658 * Misc/WebNSAttributedStringExtras.mm: 18659 (+[NSAttributedString _web_attributedStringFromRange:]): 18660 * WebView/WebFrame.mm: 18661 (-[WebFrame _bodyBackgroundColor]): 18662 186632010-05-21 Oliver Hunt <oliver@apple.com> 18664 18665 Reviewed by Geoffrey Garen. 18666 18667 All callable objects should have a global object reference 18668 https://bugs.webkit.org/show_bug.cgi?id=39495 18669 18670 Update the plugin proxy to handle the need for global object. 18671 18672 * Plugins/Hosted/ProxyInstance.mm: 18673 (WebKit::ProxyInstance::newRuntimeObject): 18674 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod): 18675 (WebKit::ProxyInstance::getMethod): 18676 * Plugins/Hosted/ProxyRuntimeObject.h: 18677 * Plugins/Hosted/ProxyRuntimeObject.mm: 18678 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject): 18679 186802010-05-21 Steve Block <steveblock@google.com> 18681 18682 Reviewed by Jeremy Orlow. 18683 18684 Add DeviceOrientation and DeviceOrientationClient 18685 https://bugs.webkit.org/show_bug.cgi?id=39479 18686 18687 * WebView/WebView.mm: 18688 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 18689 186902010-05-20 Mike Thole <mthole@apple.com> 18691 18692 Reviewed by Dave Hyatt. 18693 18694 When using a scale factor > 1, scrollbars sometimes appear when not necessary 18695 https://bugs.webkit.org/show_bug.cgi?id=39458 18696 18697 * WebView/WebDynamicScrollBarsView.mm: 18698 (-[WebDynamicScrollBarsView updateScrollers]): Round up non-integral sizes from AppKit 18699 so that they can be compared against the integral document size. 18700 187012010-05-20 Kevin Decker <kdecker@apple.com> 18702 18703 Reviewed by Anders Carlsson. 18704 18705 https://bugs.webkit.org/show_bug.cgi?id=39441 18706 <rdar://problem/7985715> Flash context menu is both horizontally and vertically offset from point of click 18707 <rdar://problem/7986109> Youtube video controller UI entirely missing 18708 <rdar://problem/7986154> Flash content paints at horizontally and vertically shifted locations (within the plug-in region) 18709 18710 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 18711 (-[WebHostedNetscapePluginView updateAndSetWindow]): The base coordinates of a window and 18712 it's contentView happen to be the equal at a userSpaceScaleFactor of 1. For non-1.0 scale 18713 factors this assumption is false. Accordingly we now convert to the window contentView 18714 coordinate system when computing bounds in "window" and the visible rect. 18715 * Plugins/WebNetscapePluginView.mm: 18716 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): Ditto. 18717 187182010-05-20 Steve Block <steveblock@google.com> 18719 18720 Reviewed by Jeremy Orlow. 18721 18722 Provide bindings for DeviceOrientation 18723 https://bugs.webkit.org/show_bug.cgi?id=39210 18724 18725 Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled. 18726 18727 * Configurations/FeatureDefines.xcconfig: 18728 187292010-05-20 Martin Robinson <mrobinson@webkit.org> 18730 18731 Reviewed by Ojan Vafai. 18732 18733 Expose the editing behavior setting in DRT to test all editing code paths 18734 https://bugs.webkit.org/show_bug.cgi?id=38603 18735 18736 * WebView/WebFrame.mm: 18737 (core): 18738 * WebView/WebFrameInternal.h: Added a conversion method from the API enum to the WebCore enum. 18739 * WebView/WebPreferenceKeysPrivate.h: Added a preference key for the new setting. 18740 * WebView/WebPreferences.mm: 18741 (+[WebPreferences initialize]): Initialize the EditingBehavior to Mac style. 18742 (-[WebPreferences editingBehavior]): Added. 18743 (-[WebPreferences setEditingBehavior:]): Added. 18744 * WebView/WebPreferencesPrivate.h: Added the new API points to the private API. 18745 * WebView/WebView.mm: 18746 (-[WebView _preferencesChangedNotification:]): Set the editing behavior via the WebPreferences setting. 18747 187482010-05-19 Anders Carlsson <andersca@apple.com> 18749 18750 Reviewed by Kevin Decker and Simon Fraser. 18751 18752 <rdar://problem/8004528> 18753 REGRESSION: Coordinate system for Core Animation NPAPI plug-ins is flipped with accelerated compositing turned on 18754 18755 When needed, create a new CALayer and set it's geometry to be flipped. Add the plug-in layer as a sublayer and then return 18756 the newly created layer. 18757 18758 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 18759 (-[WebHostedNetscapePluginView createPlugin]): 18760 * Plugins/WebNetscapePluginView.mm: 18761 (-[WebNetscapePluginView createPlugin]): 18762 187632010-05-18 Tony Chang <tony@chromium.org> 18764 18765 Reviewed by Darin Adler. 18766 18767 https://bugs.webkit.org/show_bug.cgi?id=24943 18768 Command-B and Command-I do not generate keydown events in contentEditable regions. 18769 18770 Manual test because performKeyEquivalent is not called by DRT. 18771 18772 Test: manual-tests/style-keypress-events.html 18773 18774 * WebView/WebHTMLView.mm: 18775 (-[WebHTMLView performKeyEquivalent:]): Move style key handling until after webcore gets a chance to handle the event 18776 187772010-05-18 Daniel Cheng <dcheng@chromium.org> 18778 18779 Reviewed by Darin Adler, Jian Li. 18780 18781 DragData::asURL() shouldn't do file validity checks 18782 https://bugs.webkit.org/show_bug.cgi?id=38711 18783 18784 Change [NSPasteboard _web_bestURL] to still return a file URL for paths 18785 that don't exist. Callers who care about the existence of the file or 18786 whether or not it is a directory should check themselves when they 18787 want to use the file. The directory check has been left in for now, 18788 since the Mac implementation of ResourceHandle, which uses this function 18789 indirectly via DragController::performDrag) handles directories somewhat 18790 non-intuitively: it opens the parent directory in the Finder, rather 18791 than opening the directory itself. 18792 18793 * Misc/WebNSPasteboardExtras.mm: 18794 (-[NSPasteboard _web_bestURL]): 18795 187962010-05-18 Eric Seidel <eric@webkit.org> 18797 18798 Reviewed by Adam Barth (and Maciej Stachowiak). 18799 18800 Make it possible to enable the new HTML5Tokenizer for testing 18801 https://bugs.webkit.org/show_bug.cgi?id=39275 18802 18803 Expose the WebCore::Settings::html5ParserEnabled as a private WebKit setting. 18804 18805 * WebView/WebPreferenceKeysPrivate.h: 18806 * WebView/WebPreferences.mm: 18807 (-[WebPreferences html5ParserEnabled]): 18808 (-[WebPreferences setHTML5ParserEnabled:]): 18809 * WebView/WebPreferencesPrivate.h: 18810 * WebView/WebView.mm: 18811 (-[WebView _preferencesChangedNotification:]): 18812 188132010-05-17 Sheriff Bot <webkit.review.bot@gmail.com> 18814 18815 Unreviewed, rolling out r59652. 18816 http://trac.webkit.org/changeset/59652 18817 https://bugs.webkit.org/show_bug.cgi?id=39268 18818 18819 file-input-files-access test is broken on Mac (Requested by 18820 dcheng on #webkit). 18821 18822 * Misc/WebNSPasteboardExtras.mm: 18823 (-[NSPasteboard _web_bestURL]): 18824 188252010-05-17 Daniel Cheng <dcheng@chromium.org> 18826 18827 Reviewed by Darin Adler. 18828 18829 DragData::asURL() shouldn't do file validity checks 18830 https://bugs.webkit.org/show_bug.cgi?id=38711 18831 18832 Change [NSPasteboard _web_bestURL] to still return a file URL for paths 18833 that don't exist. Callers who care about the existence of the file or 18834 whether or not it is a directory should check themselves when they 18835 want to use the file. The directory check has been left in for now, 18836 since the Mac implementation of ResourceHandle, which uses this function 18837 indirectly via DragController::performDrag) handles directories somewhat 18838 non-intuitively: it opens the parent directory in the Finder, rather 18839 than opening the directory itself. 18840 18841 * Misc/WebNSPasteboardExtras.mm: 18842 (-[NSPasteboard _web_bestURL]): 18843 188442010-05-14 Stephanie Lewis <slewis@apple.com> 18845 18846 Rubber-stamped by Mark Rowe. 18847 18848 Update order files. 18849 18850 * WebKit.order: 18851 188522010-05-13 Timothy Hatcher <timothy@apple.com> 18853 18854 Allow reporting exceptions that occur when using JavaScriptCore APIs 18855 to the Web Inspector. 18856 18857 <rdar://problem/7975410> 18858 18859 Reviewed by Sam Weinig. 18860 18861 * WebView/WebView.mm: 18862 (+[WebView _reportException:inContext:]): Call WebCore::reportException after checking 18863 that the global object is a DOMWindow. 18864 * WebView/WebViewPrivate.h: Added _reportException:inContext:. 18865 188662010-05-13 Alexey Proskuryakov <ap@apple.com> 18867 18868 Reviewed by Darin Adler. 18869 18870 https://bugs.webkit.org/show_bug.cgi?id=39089 18871 <rdar://problem/7974044> Domain names in Russian '.рф' domain are displayed as punycode 18872 18873 Add a custom check for this domain. Currently, this is the only non-ASCII TLD, we'll 18874 investigate a more extensible solution when there are more, and we know what the 18875 typical restictions are. 18876 18877 * Misc/WebNSURLExtras.mm: 18878 (allCharactersAllowedByTLDRules): 18879 (-[NSString _web_mapHostNameWithRange:encode:makeString:]): 18880 188812010-05-12 Simon Fraser <simon.fraser@apple.com> 18882 18883 Reviewed by David Hyatt. 18884 18885 Composited plug-ins can cause missed painting 18886 https://bugs.webkit.org/show_bug.cgi?id=39033 18887 <rdar://problem/7972478> 18888 18889 Eagerly enable compositing mode via the enclosing FrameView when the plug-in tells us it wants 18890 to do compositing. 18891 18892 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 18893 (-[WebHostedNetscapePluginView createPlugin]): 18894 * Plugins/WebNetscapePluginView.mm: 18895 (-[WebNetscapePluginView createPlugin]): 18896 188972010-05-12 Jer Noble <jer.noble@apple.com> 18898 18899 Reviewed by Darin Adler. 18900 18901 Bug 38689: #34005 will break fullscreen video playback 18902 https://bugs.webkit.org/show_bug.cgi?id=38689 18903 18904 Use the new definition of PlatformMedia to check the actual type 18905 returned by MediaPlayer. 18906 18907 * WebView/WebVideoFullscreenController.mm: 18908 (-[WebVideoFullscreenController windowDidLoad]): 18909 189102010-05-11 Mark Rowe <mrowe@apple.com> 18911 18912 Fix the world. 18913 18914 In r59162 a change was made to WebCore's FeatureDefines.xcconfig that enabled FILE_READER and FILE_WRITER. 18915 The author and reviewer of that patch ignored the carefully-worded warning at the top of that file asking 18916 that changes to the file be kept in sync across JavaScriptCore, WebCore and WebKit, as well as being kept 18917 in sync with build-webkit. This led to WebCore and WebKit having different views of Document's vtable 18918 and results in crashes in Safari shortly after launch when virtual function calls resulted in the wrong 18919 function in WebCore being called. 18920 18921 We fix this by bringing the FeatureDefines.xcconfig files in to sync. Based on the ChangeLog message and 18922 other changes in r59162 it appears that enabling FILE_WRITER was unintentional so that particular change 18923 has been reverted. 18924 18925 * Configurations/FeatureDefines.xcconfig: 18926 189272010-05-10 Simon Fraser <simon.fraser@apple.com> 18928 18929 Reviewed by Anders Carlsson. 18930 18931 Allow compositing layers to be connected across iframe boundaries on Mac 18932 https://bugs.webkit.org/show_bug.cgi?id=38856 18933 18934 When painting an iframe into a compositing layer, the "PaintBehaviorFlattenCompositingLayers" 18935 flag was mistakenly set, because we'd detect that we were drawing into a bitmap. This caused 18936 content to show up in both compositing layers, and the painted background inside the iframe. 18937 18938 Fix by taking the flattening state from the parent frame, if there is one. For the root 18939 frame, we continue to look to see if we're painting into a bitmap. 18940 18941 * WebView/WebFrame.mm: 18942 (-[WebFrame _drawRect:contentsOnly:]): 18943 189442010-05-10 Timothy Hatcher <timothy@apple.com> 18945 18946 Fix a crash when closing a WebView while the Web Inspector is open. 18947 18948 <rdar://problem/7966830> 18949 18950 Reviewed by Mark Rowe. 18951 18952 * WebCoreSupport/WebInspectorClient.mm: 18953 (-[WebInspectorWindowController destroyInspectorView]): Null check Page since it can be null. 18954 * WebView/WebView.mm: 18955 (-[WebView _close]): Null out _private->page before deleting the page, so code called 18956 during destruction don't access a half deleted Page object. 18957 189582010-05-10 Anders Carlsson <andersca@apple.com> 18959 18960 Unbreak the world. (Fix Mac builds). 18961 18962 * Plugins/Hosted/WebKitPluginHostTypes.h: 18963 189642010-05-10 Anders Carlsson <andersca@apple.com> 18965 18966 Reviewed by Simon Fraser. 18967 18968 Change the order of the RendererType enum values, so that old versions of WebKitPluginHost will 18969 use accelerated compositing and not layer backed views. 18970 18971 * Plugins/Hosted/WebKitPluginHostTypes.h: 18972 189732010-05-07 Anders Carlsson <andersca@apple.com> 18974 18975 Reviewed by Sam Weinig and Simon Fraser. 18976 18977 <rdar://problem/7947356> 18978 QT Plug-in in hardware-accelerated WebKit is missing the controller 18979 18980 Replace the useSoftwareRenderer boolean with an enum that lets the plug-in host opt into using a layer 18981 backed NSView instead of inserting the layer into the WebCore layer hierarchy. 18982 18983 * Plugins/Hosted/NetscapePluginHostManager.mm: 18984 (WebKit::NetscapePluginHostManager::instantiatePlugin): 18985 * Plugins/Hosted/NetscapePluginHostProxy.mm: 18986 (WKPCInstantiatePluginReply): 18987 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 18988 (WebKit::NetscapePluginInstanceProxy::rendererType): 18989 (WebKit::NetscapePluginInstanceProxy::setRendererType): 18990 (WebKit::NetscapePluginInstanceProxy::InstantiatePluginReply::InstantiatePluginReply): 18991 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 18992 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): 18993 Replace the useSoftwareRenderer boolean everywhere with the RendererType enum. 18994 18995 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 18996 (-[WebHostedNetscapePluginView createPlugin]): 18997 Only go into full compositing mode when the renderer type returned is UseAcceleratedCompositing. 18998 Otherwise, use a layer backed NSView. 18999 19000 * Plugins/Hosted/WebKitPluginHostTypes.h: 19001 Add a RendererType enum. 19002 190032010-05-06 Anders Carlsson <andersca@apple.com> 19004 19005 Reviewed by Darin Adler and Dan Bernstein.. 19006 19007 REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters 19008 https://bugs.webkit.org/show_bug.cgi?id=38698 19009 <rdar://problem/7942075> 19010 19011 When the plug-in database is initialized, we will register all the MIME types it supports with the global 19012 WebView dictionary. When plug-ins are disabled for a single web view, the MIME types still need to be 19013 in the global mapping (because other web views might still have plug-ins enabled). 19014 19015 Prior to r51617 we would always look at the plug-in database to determine that the MIME type belongs to a 19016 plug-in, but now we won't even touch the plug-in database when plug-ins are disabled. 19017 19018 In order to fix this, a new set of registered MIME types that are known to be plug-ins is added. When 19019 +[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:] is called and allowingPlugins is FALSE 19020 we check if the MIME type is a known plug-in MIME type and return false in that case. 19021 19022 * Plugins/WebPluginDatabase.mm: 19023 (-[WebPluginDatabase refresh]): 19024 (-[WebPluginDatabase _removePlugin:]): 19025 * WebView/WebView.mm: 19026 (knownPluginMIMETypes): 19027 (+[WebView _registerPluginMIMEType:]): 19028 (+[WebView _unregisterPluginMIMEType:]): 19029 (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]): 19030 * WebView/WebViewInternal.h: 19031 190322010-05-06 Dan Bernstein <mitz@apple.com> 19033 19034 Reviewed by Simon Fraser. 19035 19036 <rdar://problem/7951285> REGRESSION (r58847): Composited iframe content obscures Safari's application chrome 19037 19038 Fixed this other regression from r58847. The regression was caused by overriding -visibleRect to 19039 return the WebClipView’s full bounds. AppKit uses -visibleRect to determine the geometry 19040 of the surface for the child WebFrameView. The fix is to restrict the special behavior of 19041 -[WebClipView visibleRect] to when AppKit is consulting it for the purpose of invalidating 19042 areas while scrolling. 19043 19044 * WebView/WebClipView.h: 19045 * WebView/WebClipView.mm: 19046 (-[WebClipView visibleRect]): If the WebClipView is not scrolling, always return 19047 [super visibleRect]. 19048 (-[WebClipView _immediateScrollToPoint:]): Override this internal NSClipView method 19049 to set a flag telling -visibleRect that the view is scrolling. 19050 * WebView/WebView.mm: 19051 (layerSyncRunLoopObserverCallBack): Ensure that screen updates, disabled by AppKit 19052 when it thinks an upcoming window flush will re-enable them, are enabled here in 19053 case the -setNeedsDisplayInRect: override has prevented the window from needing to be 19054 flushed. 19055 190562010-05-06 Steve Block <steveblock@google.com> 19057 19058 Reviewed by Eric Seidel. 19059 19060 MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE 19061 https://bugs.webkit.org/show_bug.cgi?id=38544 19062 19063 * WebCoreSupport/WebFrameLoaderClient.h: 19064 * WebCoreSupport/WebFrameLoaderClient.mm: 19065 190662010-05-05 Dan Bernstein <mitz@apple.com> 19067 19068 Reviewed by Mark Rowe. 19069 19070 Fixed a crash when closing Top Sites after r58847. 19071 19072 * WebView/WebFrameView.mm: 19073 (-[WebFrameView webFrame]): Null-check _private. 19074 190752010-05-05 Dan Bernstein <mitz@apple.com> 19076 19077 Rubber-stamped by Mark Rowe. 19078 19079 Fixed test crashes after r58847. 19080 19081 * WebView/WebHTMLView.mm: 19082 (setNeedsDisplayInRect): Null-check the frame. 19083 190842010-05-05 Dan Bernstein <mitz@apple.com> 19085 19086 Reviewed by Simon Fraser. 19087 19088 <rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affects Yahoo! Mail with Flash Player 10.1) 19089 https://bugs.webkit.org/show_bug.cgi?id=38427 19090 19091 * WebView/WebClipView.m: Renamed to WebClipView.mm. 19092 * WebView/WebClipView.mm: 19093 (-[WebClipView visibleRect]): Added this override, which for instances used for WebFrameViews in 19094 composited layers, returns the clip view’s entire bounds. This prevents drawing from being clipped to 19095 AppKit’s idea of what part of the view would be visible if it was drawn as part of the view hierarchy. 19096 Since it is drawn into a compositing layer, that’s irrelevant, and we should not be clipping. 19097 * WebView/WebHTMLView.mm: 19098 (setCursor): Style tweak. 19099 (setNeedsDisplayInRect): Added. Replaces the default implementation of -[NSView setNeedsDisplayInRect:], 19100 so that if the receiver is a descendant of a WebFrameView that draws into a composited layer, the invalidation 19101 is routed back through the WebCore FrameView, which propagates it to the layer. 19102 (+[WebHTMLViewPrivate initialize]): Swizzle the setNeedsDisplayInRect: override in. 19103 (-[WebHTMLView visibleRect]): Removed whitespace. 19104 * WebView/WebView.mm: 19105 (layerSyncRunLoopObserverCallBack): If we bailed out on syncing, due to pending layout, do an eager layout 19106 in preparation for the displaying of compositing layers. 19107 191082010-05-05 John Sullivan <sullivan@apple.com> 19109 19110 <rdar://problem/7942606> Output appears in Console when exiting Safari with multiple windows opened 19111 19112 Reviewed by Mark Rowe. 19113 19114 * WebView/WebView.mm: 19115 (+[WebView closeAllWebViews]): 19116 Make copy of allWebViewsSet to avoid mutating it while iterating through it. 19117 191182010-05-04 Simon Fraser <simon.fraser@apple.com> 19119 19120 Reviewed by Dan Bernstein. 19121 19122 Improve check for drawing into the window that was added in r58623 19123 https://bugs.webkit.org/show_bug.cgi?id=38562 19124 19125 Rather than assuming that any non-bitmap context is the window's context, 19126 compare the current graphics context with -[NSWindow graphicsContext] to 19127 determine that we're drawing into the window. 19128 19129 * WebView/WebHTMLView.mm: 19130 (-[WebHTMLView drawRect:]): 19131 191322010-05-04 Ada Chan <adachan@apple.com> 19133 19134 Reviewed by David Kilzer. 19135 19136 https://bugs.webkit.org/show_bug.cgi?id=38555 19137 19138 Small code refactoring: move the logic to figure out the path to the 19139 databases directory to another method. 19140 19141 * Storage/WebDatabaseManager.mm: 19142 (databasesDirectoryPath): 19143 (WebKitInitializeDatabasesIfNecessary): 19144 191452010-05-04 Beth Dakin <bdakin@apple.com> 19146 19147 Reviewed by Mike Thole. 19148 19149 Fix for <rdar://problem/7818509> Crash occurs when exiting Safari 19150 19151 We can avoid this crash if we call [self _removeFromAllWebViewsSet] 19152 even in the case when we are doing a fastDocumentTeardown. This is 19153 a much safer approach. 19154 * WebView/WebView.mm: 19155 (-[WebView _close]): 19156 191572010-05-03 Abhishek Arya <inferno@chromium.org> 19158 19159 Reviewed by Adam Barth. 19160 19161 Add support for controlling clipboard access from javascript. 19162 Clipboard access from javascript is disabled by default. 19163 https://bugs.webkit.org/show_bug.cgi?id=27751 19164 19165 * WebView/WebPreferenceKeysPrivate.h: 19166 * WebView/WebPreferences.mm: 19167 (+[WebPreferences initialize]): 19168 (-[WebPreferences javaScriptCanAccessClipboard]): 19169 (-[WebPreferences setJavaScriptCanAccessClipboard:]): 19170 * WebView/WebPreferencesPrivate.h: 19171 * WebView/WebView.mm: 19172 (-[WebView _preferencesChangedNotification:]): 19173 191742010-05-03 Jens Alfke <snej@chromium.org> 19175 19176 Reviewed by Darin Fisher. 19177 19178 [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient 19179 https://bugs.webkit.org/show_bug.cgi?id=38397 19180 19181 No tests (functionality is exposed only through native WebKit API.) 19182 19183 * WebCoreSupport/WebFrameLoaderClient.h: 19184 (WebFrameLoaderClient::dispatchWillSendSubmitEvent): 19185 191862010-04-30 Simon Fraser <simon.fraser@apple.com> 19187 19188 Reviewed by Dan Bernstein. 19189 19190 <rdar://problem/7477071> REGRESSION: Bad flicker when wheel-scrolling Google Maps, iPad gallery and other sites 19191 19192 Sites that frequently toggle content in and out of compositing layers (like http://www.tumblr.com/boothed) 19193 can cause flickering because of unsychronized compositing layer and view-based updates. There were two 19194 underlying issues: 19195 19196 1. On SnowLeopard, AppKit can throttle window updates, thus breaking an assumption that 19197 NSView drawing will happen on the runloop cycle after a repaint. This provided a window 19198 for the layerSyncRunLoopObserver to fire and commit layer changes too early. 19199 19200 Fix this by having the layerSyncRunLoopObserver in WebView check to see if a display is pending, 19201 and not commit layer changes in that case. We'll commit layer changes later when we 19202 finally draw. 19203 19204 2. The change in r49269 was wrong; it was attempting to fix an issue that was actually caused 19205 by -drawRects: coming in for page snapshots. The correct approach is to avoid hitting the 19206 synchronization and update disabling code in WebHTMLView for draws that are not to the screen. 19207 19208 * WebView/WebHTMLView.mm: 19209 (-[WebHTMLView drawRect:]): 19210 * WebView/WebView.mm: 19211 (layerSyncRunLoopObserverCallBack): 19212 (-[WebView _scheduleCompositingLayerSync]): 19213 192142010-04-30 Anders Carlsson <andersca@apple.com> 19215 19216 Part of the previous part (forgot to save). 19217 19218 * Plugins/WebNetscapePluginView.mm: 19219 (-[WebNetscapePluginView stopTimers]): 19220 (-[WebNetscapePluginView startTimers]): 19221 (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]): 19222 (-[WebNetscapePluginView _containerCheckResult:contextInfo:]): 19223 (-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]): 19224 (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): 19225 (-[WebNetscapePluginView unscheduleTimer:]): 19226 (-[WebNetscapePluginView getVariable:forURL:value:length:]): 19227 (-[WebNetscapePluginView setVariable:forURL:value:length:]): 19228 192292010-04-30 Anders Carlsson <andersca@apple.com> 19230 19231 Reviewed by Darin Adler. 19232 19233 Use C99 integer types in more places. 19234 19235 * Plugins/WebNetscapePluginView.mm: 19236 (getNPRect): 19237 192382010-04-30 Anders Carlsson <andersca@apple.com> 19239 19240 Fix Tiger build. 19241 19242 * Plugins/WebBaseNetscapePluginStream.h: 19243 * Plugins/WebBaseNetscapePluginStream.mm: 19244 (WebNetscapePluginStream::startStream): 19245 192462010-04-30 Anders Carlsson <andersca@apple.com> 19247 19248 Another 32-bit build fix. 19249 19250 * Plugins/WebNetscapePluginView.mm: 19251 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): 19252 192532010-04-30 Anders Carlsson <andersca@apple.com> 19254 19255 Fix 32-bit build (again). 19256 19257 * Plugins/WebNetscapeContainerCheckContextInfo.h: 19258 * Plugins/WebNetscapeContainerCheckContextInfo.mm: 19259 (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]): 19260 (-[WebNetscapeContainerCheckContextInfo checkRequestID]): 19261 (-[WebNetscapeContainerCheckContextInfo callback]): 19262 * Plugins/WebNetscapePluginPackage.h: 19263 192642010-04-30 Anders Carlsson <andersca@apple.com> 19265 19266 Fix 32-bit build. 19267 19268 * Plugins/WebNetscapeContainerCheckContextInfo.h: 19269 * Plugins/WebNetscapeContainerCheckContextInfo.mm: 19270 (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]): 19271 * Plugins/WebNetscapeContainerCheckPrivate.h: 19272 * Plugins/WebNetscapePluginPackage.mm: 19273 (functionPointerForTVector): 19274 * Plugins/WebNetscapePluginView.mm: 19275 (PluginTimer::PluginTimer): 19276 (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]): 19277 (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): 19278 192792010-04-30 Anders Carlsson <andersca@apple.com> 19280 19281 Reviewed by Timothy Hatcher. 19282 19283 Next step towards fixing 19284 19285 https://bugs.webkit.org/show_bug.cgi?id=20784 19286 move npapi.h to C99 integer types 19287 19288 Use the C99 types everywhere. The "old" types are still around but will be removed 19289 in a subsequent commit. 19290 19291 * Plugins/WebBaseNetscapePluginStream.h: 19292 * Plugins/WebBaseNetscapePluginStream.mm: 19293 (WebNetscapePluginStream::deliverData): 19294 * Plugins/WebNetscapePluginView.h: 19295 * Plugins/WebNetscapePluginView.mm: 19296 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): 19297 (-[WebNetscapePluginView getAuthenticationInfoWithProtocol:host:port:scheme:realm:username:usernameLength:password:passwordLength:]): 19298 * Plugins/npapi.mm: 19299 (NPN_MemAlloc): 19300 (NPN_MemFlush): 19301 (NPN_PostURLNotify): 19302 (NPN_PostURL): 19303 (NPN_Write): 19304 (NPN_ScheduleTimer): 19305 (NPN_UnscheduleTimer): 19306 (NPN_GetValueForURL): 19307 (NPN_SetValueForURL): 19308 (NPN_GetAuthenticationInfo): 19309 (WKN_CheckIfAllowedToLoadURL): 19310 (WKN_CancelCheckIfAllowedToLoadURL): 19311 193122010-04-29 Anders Carlsson <andersca@apple.com> 19313 19314 Reviewed by Dan Bernstein. 19315 19316 First part of 19317 https://bugs.webkit.org/show_bug.cgi?id=20784 19318 move npapi.h to C99 integer types. 19319 19320 * MigrateHeaders.make: 19321 193222010-04-28 Mike Thole <mthole@apple.com> 19323 19324 Reviewed by David Kilzer. 19325 19326 Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space 19327 can be inspected before attempting to authenticate against it 19328 https://bugs.webkit.org/show_bug.cgi?id=38271 19329 19330 * WebCoreSupport/WebFrameLoaderClient.h: 19331 * WebCoreSupport/WebFrameLoaderClient.mm: 19332 (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace): 19333 Added. If the resource load delegate implements the callback, use its answer. If it does 19334 not, then only send authentication challenges for pre-10.6 protection spaces, which matches 19335 CFNetwork's default behavior. 19336 * WebView/WebDelegateImplementationCaching.h: 19337 * WebView/WebDelegateImplementationCaching.mm: 19338 (CallResourceLoadDelegateReturningBoolean): Added case for passing three objects. 19339 * WebView/WebResourceLoadDelegatePrivate.h: 19340 Added private SPI definition: webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource: 19341 * WebView/WebView.mm: 19342 (-[WebView _cacheResourceLoadDelegateImplementations]): 19343 193442010-04-28 Simon Fraser <simon.fraser@apple.com> 19345 19346 Reviewed by Sam Weinig. 19347 19348 <rdar://problem/7918719> ASSERT(isMainThread()) from Font::setShouldUseSmoothing() 19349 19350 Ensure that the WebView +initialize method initializes threading, so that things are correctly 19351 initialized when the first call into the WebKit framework is via a WebView class method. 19352 19353 * WebView/WebView.mm: 19354 (+[WebView initialize]): 19355 193562010-04-28 Darin Adler <darin@apple.com> 19357 19358 Reviewed by Adele Peterson. 19359 19360 REGRESSION: Autoscroll does not work in Mail messages 19361 https://bugs.webkit.org/show_bug.cgi?id=38267 19362 rdar://problem/7559799 19363 19364 The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another 19365 view had gotten broken in multiple ways. For some reason, a combination of bugs made it 19366 partly work until around r48064. This brings it back. 19367 19368 * WebCoreSupport/WebChromeClient.mm: 19369 (WebChromeClient::scrollRectIntoView): When converting coordinates, use the document view 19370 rather than the WebView itself. This logic may not be correct for the case where 19371 usesDocumentViews is NO, but that is currently an experimental mode and can be fixed later. 19372 193732010-04-27 Shinichiro Hamaji <hamaji@chromium.org> 19374 19375 Reviewed by Darin Adler and Eric Seidel. 19376 19377 Add layoutTestController.setPrinting() 19378 https://bugs.webkit.org/show_bug.cgi?id=37203 19379 19380 * Misc/WebCoreStatistics.h: 19381 * Misc/WebCoreStatistics.mm: 19382 (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]): 19383 193842010-04-25 Sam Weinig <sam@webkit.org> 19385 19386 Reviewed by Maciej Stachowiak. 19387 19388 Fix for https://bugs.webkit.org/show_bug.cgi?id=38097 19389 Disentangle initializing the main thread from initializing threading 19390 19391 Calls initializeMainThreadToProcessMainThread since there is no way to ensure 19392 that the initialize method will be called on the main thread. 19393 19394 * Carbon/CarbonWindowAdapter.mm: 19395 (+[CarbonWindowAdapter initialize]): Add call to initializeMainThreadToProcessMainThread. 19396 * History/WebBackForwardList.mm: 19397 (+[WebBackForwardList initialize]): Ditto. 19398 * History/WebHistoryItem.mm: 19399 (+[WebHistoryItem initialize]): Ditto. 19400 * Misc/WebElementDictionary.mm: 19401 (+[WebElementDictionary initialize]): Ditto. 19402 * Misc/WebIconDatabase.mm: 19403 (+[WebIconDatabase initialize]): Ditto. 19404 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 19405 (+[WebHostedNetscapePluginView initialize]): Ditto. 19406 * Plugins/WebBaseNetscapePluginView.mm: 19407 (+[WebBaseNetscapePluginView initialize]): Ditto. 19408 * Plugins/WebBasePluginPackage.mm: 19409 (+[WebBasePluginPackage initialize]): Ditto. 19410 * Plugins/WebNetscapePluginView.mm: 19411 (+[WebNetscapePluginView initialize]): Ditto. 19412 * WebCoreSupport/WebEditorClient.mm: 19413 (+[WebEditCommand initialize]): Ditto. 19414 * WebCoreSupport/WebFrameLoaderClient.mm: 19415 (+[WebFramePolicyListener initialize]): Ditto. 19416 * WebView/WebArchive.mm: 19417 (+[WebArchivePrivate initialize]): Ditto. 19418 * WebView/WebDataSource.mm: 19419 (+[WebDataSourcePrivate initialize]): Ditto. 19420 * WebView/WebHTMLView.mm: 19421 (+[WebHTMLViewPrivate initialize]): Ditto. 19422 (+[WebHTMLView initialize]): Ditto. 19423 * WebView/WebResource.mm: 19424 (+[WebResourcePrivate initialize]): Ditto. 19425 * WebView/WebTextIterator.mm: 19426 (+[WebTextIteratorPrivate initialize]): Ditto. 19427 * WebView/WebView.mm: 19428 * WebView/WebViewData.mm: Ditto. 19429 (+[WebViewPrivate initialize]): Ditto. 19430 194312010-04-24 Dan Bernstein <mitz@apple.com> 19432 19433 Reviewed by Darin Adler. 19434 19435 <rdar://problem/7903728> REGRESSION (r51617): WebView fails to load plug-in MIME types 19436 https://bugs.webkit.org/show_bug.cgi?id=38085 19437 19438 WebView was calling -_webView in a few places where it should have just used itself. It never 19439 makes sense for WebView to call -_webView on itself, and these calls look like they were copied 19440 from similar code in WebHTMLView, WebFrameView and WebDataSource, where -_webView has a different, 19441 useful meaning. 19442 19443 * WebView/WebView.mm: 19444 (-[WebView drawSingleRect:]): Replaced [self _webView] with self. 19445 (-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Replaced [[self _webView] preferences] 19446 with _private->preferences. 19447 (-[WebView _canShowMIMEType:]): Ditto. 19448 194492010-04-23 Simon Fraser <simon.fraser@apple.com> 19450 19451 Reviewed by Anders Carlsson. 19452 19453 <rdar://problem/7894489> When printing Flash, send a drawRect event, rather than NPPrint 19454 19455 When printing Flash plug-ins in 32-bit, send a drawRect event with a CGContextRef, rather than calling 19456 NPPrint with a GWorldPtr, since Flash prefers the CGContext path. 19457 19458 * Plugins/WebNetscapePluginView.mm: 19459 (-[WebNetscapePluginView drawRect:]): 19460 194612010-04-22 David Kilzer <ddkilzer@apple.com> 19462 19463 <http://webkit.org/b/38029> +[WebTextIteratorPrivate initialize] is missing call to JSC::initializeThreading() 19464 19465 Reviewed by Timothy Hatcher. 19466 19467 Every other Objective-C class that calls 19468 WebCoreObjCFinalizeOnMainThread(self) in +initialize also calls 19469 JSC::initializeThreading(). The WebTextIteratorPrivate class 19470 was the only one missing this call. 19471 19472 * WebView/WebTextIterator.mm: 19473 (+[WebTextIteratorPrivate initialize]): Added call to 19474 JSC::initializeThreading(). 19475 194762010-04-22 Alexey Proskuryakov <ap@apple.com> 19477 19478 Rubber-stamped by Mark Rowe. 19479 19480 <rdar://problem/7805969> REGRESSION: iTunes unable to play trailers 19481 19482 Undo the changes made for https://bugs.webkit.org/show_bug.cgi?id=35215 (<rdar://problem/7673157>) 19483 for now. Clients rely on the old behavior, so a fix that changes it will need to account for 19484 those. 19485 19486 * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Pass pluginURL 19487 instead of baseURL again. 19488 194892010-04-22 Dave Moore <davemoore@chromium.org> 19490 19491 Reviewed by Dimitri Glazkov. 19492 19493 Added notification when the favicons for a page are changed 19494 from a script. 19495 The Document object will notify the frame loader, which will 19496 notify the client. Implementations of FrameLoaderClient will 19497 have to add one method; dispatchDidChangeIcons(). 19498 19499 https://bugs.webkit.org/show_bug.cgi?id=33812 19500 19501 * WebCoreSupport/WebFrameLoaderClient.h: 19502 * WebCoreSupport/WebFrameLoaderClient.mm: 19503 (WebFrameLoaderClient::dispatchDidChangeIcons): 19504 195052010-04-22 Adam Barth <abarth@webkit.org> 19506 19507 Unreviewed, rolling out r58069. 19508 http://trac.webkit.org/changeset/58069 19509 https://bugs.webkit.org/show_bug.cgi?id=27751 19510 19511 Broke compile on Windows. 19512 19513 * WebView/WebPreferenceKeysPrivate.h: 19514 * WebView/WebPreferences.mm: 19515 (+[WebPreferences initialize]): 19516 * WebView/WebPreferencesPrivate.h: 19517 * WebView/WebView.mm: 19518 (-[WebView _preferencesChangedNotification:]): 19519 195202010-04-22 Abhishek Arya <inferno@chromium.org> 19521 19522 Reviewed by Adam Barth. 19523 19524 Add support for controlling clipboard access from javascript. 19525 Clipboard access from javascript is disabled by default. 19526 https://bugs.webkit.org/show_bug.cgi?id=27751 19527 19528 * WebView/WebPreferenceKeysPrivate.h: 19529 * WebView/WebPreferences.mm: 19530 (+[WebPreferences initialize]): 19531 (-[WebPreferences javaScriptCanAccessClipboard]): 19532 (-[WebPreferences setJavaScriptCanAccessClipboard:]): 19533 * WebView/WebPreferencesPrivate.h: 19534 * WebView/WebView.mm: 19535 (-[WebView _preferencesChangedNotification:]): 19536 195372010-04-21 Alexey Proskuryakov <ap@apple.com> 19538 19539 Reviewed by Shinichiro Hamaji. 19540 19541 https://bugs.webkit.org/show_bug.cgi?id=37964 19542 Fix a typo in comments - Korean encoding name is windows-949, not windows-939 19543 19544 * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): 19545 195462010-04-21 Mark Rowe <mrowe@apple.com> 19547 19548 Tiger build fix. 19549 19550 * Plugins/WebPluginController.mm: Add an #import that is necessary on Tiger. 19551 195522010-04-21 Mark Rowe <mrowe@apple.com> 19553 19554 Reviewed by Eric Carlson. 19555 19556 <rdar://problem/7313430> Many crashes in Safari inside Flip4Mac below -[NSAlert didEndAlert:returnCode:contextInfo:] 19557 19558 Existing versions of the Flip4Mac WebKit plug-in have an object lifetime bug related to an NSAlert that is 19559 used to notify the user about updates to the plug-in. This bug can result in Safari crashing if the page 19560 containing the plug-in navigates while the alert is displayed (<rdar://problem/7313430>). 19561 19562 The gist of the bug is thus: Flip4Mac sets an instance of the TSUpdateCheck class as the modal delegate of the 19563 NSAlert instance. This TSUpdateCheck instance itself has a delegate. The delegate is set to the WmvPlugin 19564 instance which is the NSView subclass that is exposed to WebKit as the plug-in view. Since this relationship 19565 is that of delegates the TSUpdateCheck does not retain the WmvPlugin. This leads to a bug if the WmvPlugin 19566 instance is destroyed before the TSUpdateCheck instance as the TSUpdateCheck instance will be left with a 19567 pointer to a stale object. This will happen if a page containing the Flip4Mac plug-in triggers a navigation 19568 while the update sheet is visible as the WmvPlugin instance is removed from the view hierarchy and there are 19569 no other references to keep the object alive. 19570 19571 We work around this bug by patching the following two messages: 19572 19573 1) -[NSAlert beginSheetModalForWindow:modalDelegate:didEndSelector:contextInfo:] 19574 2) -[TSUpdateCheck alertDidEnd:returnCode:contextInfo:] 19575 19576 Our override of 1) detects whether it is Flip4Mac's update sheet triggering the alert by checking whether the 19577 modal delegate is an instance of TSUpdateCheck. If it is, it retains the modal delegate's delegate. 19578 19579 Our override of 2) then autoreleases the delegate, balancing the retain we added in 1). 19580 19581 These two overrides have the effect of ensuring that the WmvPlugin instance will always outlive the TSUpdateCheck 19582 instance, preventing the TSUpdateCheck instance from accessing a stale delegate pointer and crashing the application. 19583 19584 * Plugins/WebPluginController.mm: 19585 (-[WebPluginController addPlugin:]): Check whether the plug-in being instantiated is the Flip4Mac plug-in and 19586 install our workaround if it is. 19587 (isKindOfClass): Helper function that checks whether the given object is an instance of the named class. 19588 (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_): Autorelease the delegate. 19589 (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_): Retain the modal delegate's 19590 delegate if this NSAlert belongs to the Flip4Mac plug-in. 19591 (installFlip4MacPlugInWorkaroundIfNecessary): Swizzle the necessary methods. We swizzle the TSUpdateCheck methods 19592 first since it is possible that in some versions of Flip4Mac the TSUpdateCheck class may not exist or may not have 19593 the method we're interested in. In that case we want to bail out before patching any methods. 19594 195952010-04-20 Mark Rowe <mrowe@apple.com> 19596 19597 Reviewed by Maciej Stachowiak. 19598 19599 <rdar://problem/7856151> REGRESSION: NPP_Destroy is not called when page navigates when plug-in is displaying modal dialog 19600 19601 An interaction between the plug-in host and WebKit was resulting in WKPCSetModal being called while 19602 NetscapePluginInstanceProxy was waiting on a reply to the GetScriptableNPObject message. This resulted 19603 in calls to stop the plug-in being deferred due to the presence of plug-in code up the stack. This 19604 could lead to crashes as it was possible for the plug-in view to be deallocated during the modal runloop. 19605 19606 * Plugins/Hosted/NetscapePluginHostProxy.mm: 19607 (WKPCInvalidateRect): 19608 (WKPCSetModal): Defer the handling of setModal until the next runloop iteration if the host proxy 19609 is already processing requests. This ensures that there will be no plug-in code on the stack when 19610 the modal runloop is entered, which allows the plug-in to be stopped when the page is navigated while 19611 a modal dialog is displayed. 19612 196132010-04-20 Adam Barth <abarth@webkit.org> 19614 19615 Reviewed by Eric Seidel. 19616 19617 Factor DocumentWriter out of FrameLoader 19618 https://bugs.webkit.org/show_bug.cgi?id=37175 19619 19620 Update these callsites because the method moved to DocumentWriter. 19621 19622 * WebView/WebFrame.mm: 19623 (-[WebFrame _canProvideDocumentSource]): 19624 (-[WebFrame _receivedData:textEncodingName:]): 19625 196262010-04-20 Kent Tamura <tkent@chromium.org> 19627 19628 Reviewed by Darin Adler. 19629 19630 Change a parameter type of chooseIconForFiles() 19631 https://bugs.webkit.org/show_bug.cgi?id=37504 19632 19633 * WebCoreSupport/WebChromeClient.h: 19634 * WebCoreSupport/WebChromeClient.mm: 19635 (WebChromeClient::chooseIconForFiles): 19636 196372010-04-20 Sheriff Bot <webkit.review.bot@gmail.com> 19638 19639 Unreviewed, rolling out r57892. 19640 http://trac.webkit.org/changeset/57892 19641 https://bugs.webkit.org/show_bug.cgi?id=37864 19642 19643 Caused an assertion in Mac builds (Requested by smfr on 19644 #webkit). 19645 19646 * WebView/WebFrame.mm: 19647 (-[WebFrame _getVisibleRect:]): 19648 * WebView/WebFrameView.mm: 19649 (-[WebFrameView _install]): 19650 196512010-04-20 Simon Fraser <simon.fraser@apple.com> 19652 19653 Reviewed by Dan Bernstein. 19654 19655 Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject 19656 https://bugs.webkit.org/show_bug.cgi?id=37741 19657 19658 Make Frame::ownerRenderer() return a RenderFrameBase* rather than a 19659 RenderPart*, and add the necessary toRenderFrameBase() and isRenderFrameBase(). 19660 19661 * WebView/WebFrame.mm: 19662 (-[WebFrame _getVisibleRect:]): 19663 * WebView/WebFrameView.mm: 19664 (-[WebFrameView _install]): 19665 196662010-04-19 Dan Bernstein <mitz@apple.com> 19667 19668 Reviewed by Sam Weinig. 19669 19670 Finish exposing extremal shrink factors WebHTMLView uses when shrinking pages to fit in the 19671 printing width as SPI. 19672 19673 * WebKit.exp: Export _WebHTMLViewPrintingMinimumShrinkFactor and _WebHTMLViewPrintingMaximumShrinkFactor. 19674 196752010-04-15 Gavin Barraclough <barraclough@apple.com> 19676 19677 Reviewed by Sam Weinig & Oliver Hunt. 19678 19679 https://bugs.webkit.org/show_bug.cgi?id=37675 19680 Remove casts/constructors to/from JSC::UString type from WebCore::String 19681 19682 WebCore's strings should not know about JSC::UString, this should be abstracted 19683 away in the bindings. Add explicit conversion methods rather than relying on 19684 overloaded cast operators / constructors being implicitly called. 19685 19686 This patch only changes the class String, once this has landed StringImpl, and 19687 hopefully AtomicString too, should follow suit. 19688 19689 * Plugins/Hosted/NetscapePluginHostProxy.mm: 19690 (identifierFromIdentifierRep): 19691 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 19692 (WebKit::NetscapePluginInstanceProxy::addValueToArray): 19693 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState): 19694 * Plugins/Hosted/ProxyInstance.mm: 19695 (WebKit::ProxyInstance::getPropertyNames): 19696 * WebView/WebFrame.mm: 19697 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): 19698 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): 19699 * WebView/WebScriptDebugDelegate.mm: 19700 (-[WebScriptCallFrame evaluateWebScript:]): 19701 * WebView/WebScriptDebugger.mm: 19702 (toNSURL): 19703 * WebView/WebView.mm: 19704 (aeDescFromJSValue): 19705 197062010-04-16 Dan Bernstein <mitz@apple.com> 19707 19708 Reviewed by John Sullivan. 19709 19710 Expose the extremal shrink factors WebHTMLView uses when shrinking pages to fit in the 19711 printing width as SPI. 19712 19713 * WebView/WebHTMLView.mm: 19714 Replaced two macros with constants. 19715 (-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Changed to use the constants. 19716 (-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto. 19717 * WebView/WebHTMLViewPrivate.h: Declared _WebHTMLViewPrintingMinimumShrinkFactor and 19718 _WebHTMLViewPrintingMaximumShrinkFactor. 19719 197202010-04-15 Mark Rowe <mrowe@apple.com> 19721 19722 Reviewed by Sam Weinig. 19723 19724 <rdar://problem/7870651> WebDynamicScrollBarsView.h generates compile errors when included in plain Objective-C files. 19725 19726 * WebView/WebDynamicScrollBarsView.h: 19727 197282010-04-15 Adam Roben <aroben@apple.com> 19729 19730 Export WebUserContentURLPattern from WebKit 19731 19732 Rubber-stamped by Mark Rowe. 19733 19734 * WebKit.exp: 19735 197362010-04-15 Dan Bernstein <mitz@apple.com> 19737 19738 Reviewed by Simon Fraser. 19739 19740 Made consecutive calls to -[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:] work 19741 without intermediate calls -[WebHTMLView _endPrintMode]. 19742 19743 * WebView/WebHTMLView.mm: 19744 (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): 19745 197462010-04-15 Adam Roben <aroben@apple.com> 19747 19748 Expose UserContentURLPattern as WebKit SPI 19749 19750 Fixes <http://webkit.org/b/37354>. 19751 19752 Reviewed by Tim Hatcher. 19753 19754 * Misc/WebUserContentURLPattern.h: Added. 19755 19756 * Misc/WebUserContentURLPattern.mm: Added. 19757 (-[WebUserContentURLPattern initWithPatternString:]): Initialize 19758 _private and then parse the passed-in string into a 19759 UserContentURLPattern. 19760 (-[WebUserContentURLPattern dealloc]): Release _private. 19761 19762 (-[WebUserContentURLPattern isValid]): 19763 (-[WebUserContentURLPattern scheme]): 19764 (-[WebUserContentURLPattern host]): 19765 (-[WebUserContentURLPattern matchesSubdomains]): 19766 Call through to UserContentURLPattern. 19767 197682010-04-13 Geoffrey Garen <ggaren@apple.com> 19769 19770 Reviewed by Oliver Hunt. 19771 19772 Separated a DOMWrapperWorld's behavior of keeping wrappers alive from 19773 its own lifetime, so a DOMWrapperWorld's controller can throw away 19774 its wrappers even before its refcount reaches 0. 19775 19776 * WebView/WebScriptWorld.h: 19777 * WebView/WebScriptWorld.mm: 19778 (-[WebScriptWorld unregisterWorld]): Exported this function through WebKit. 19779 197802010-04-12 Timothy Hatcher <timothy@apple.com> 19781 19782 SecurityOrigin needs a way to remove individual OriginAccessEntries 19783 https://bugs.webkit.org/show_bug.cgi?id=37449 19784 19785 Reviewed by Dave Hyatt. 19786 19787 * WebView/WebView.mm: 19788 (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]): 19789 Call SecurityOrigin::removeOriginAccessWhitelistEntry. 19790 * WebView/WebViewPrivate.h: Added _removeOriginAccessWhitelistEntryWithSourceOrigin. 19791 197922010-04-13 Timothy Hatcher <timothy@apple.com> 19793 19794 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry. 19795 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists. 19796 19797 SecurityOrigin needs a way to remove individual OriginAccessEntries 19798 https://bugs.webkit.org/show_bug.cgi?id=37449 19799 19800 Reviewed by Dave Hyatt. 19801 19802 * WebView/WebView.mm: 19803 (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]): 19804 (+[WebView _resetOriginAccessWhitelists]): 19805 * WebView/WebViewPrivate.h: 19806 198072010-04-11 Sheriff Bot <webkit.review.bot@gmail.com> 19808 19809 Unreviewed, rolling out r57468. 19810 http://trac.webkit.org/changeset/57468 19811 https://bugs.webkit.org/show_bug.cgi?id=37433 19812 19813 Broke the world... Must have applied the patch wrong 19814 (Requested by abarth on #webkit). 19815 19816 * WebView/WebFrame.mm: 19817 (-[WebFrame _canProvideDocumentSource]): 19818 (-[WebFrame _receivedData:textEncodingName:]): 19819 198202010-04-11 Adam Barth <abarth@webkit.org> 19821 19822 Reviewed by Eric Seidel. 19823 19824 Factor DocumentWriter out of FrameLoader 19825 https://bugs.webkit.org/show_bug.cgi?id=37175 19826 19827 Update these callsites because the method moved to DocumentWriter. 19828 19829 * WebView/WebFrame.mm: 19830 (-[WebFrame _canProvideDocumentSource]): 19831 (-[WebFrame _receivedData:textEncodingName:]): 19832 198332010-04-10 Mark Rowe <mrowe@apple.com> 19834 19835 Reviewed by Dan Bernstein. 19836 19837 <rdar://problem/7845305> Further adoption of formal protocols for delegates. 19838 19839 Move EmptyProtocolDefinitions.h down in to WebCore, and add the new protocols. Adopt the protocols in the appropriate places. 19840 19841 * Misc/EmptyProtocolDefinitions.h: Removed. 19842 * Misc/WebDownload.mm: 19843 * WebKitPrefix.h: 19844 198452010-04-09 Jer Noble <jer.noble@apple.com> 19846 19847 Reviewed by Darin Adler. 19848 19849 Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead. 19850 https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993> 19851 19852 * WebView/WebVideoFullscreenController.mm: 19853 (-[WebVideoFullscreenController windowDidLoad]): 19854 (-[WebVideoFullscreenController setMediaElement:WebCore::]): 19855 198562010-04-09 Alexey Proskuryakov <ap@apple.com> 19857 19858 Reviewed by Maciej Stachowiak. 19859 19860 https://bugs.webkit.org/show_bug.cgi?id=24572 19861 XMLHttpRequest.statusText returns always "OK" on Mac 19862 19863 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): 19864 198652010-04-09 Eric Seidel <eric@webkit.org> 19866 19867 Unreviewed, rolling out r57343. 19868 http://trac.webkit.org/changeset/57343 19869 https://bugs.webkit.org/show_bug.cgi?id=37311 19870 19871 Broke Tiger compile. 19872 19873 * WebView/WebVideoFullscreenController.mm: 19874 (-[WebVideoFullscreenController windowDidLoad]): 19875 (-[WebVideoFullscreenController setMediaElement:WebCore::]): 19876 198772010-04-09 Dan Bernstein <mitz@apple.com> 19878 19879 Reviewed by Darin Adler. 19880 19881 <rdar://problem/7846015> REGRESSION (r57332) - Crash in [WebDynamicScrollBarsView(WebInternal) reflectScrolledClipView:] when opening the Downloads window 19882 19883 * WebView/WebDynamicScrollBarsView.mm: 19884 (-[WebDynamicScrollBarsView initWithCoder:]): Added. Calls super and then initializes _private. 19885 198862010-04-09 Jer Noble <jer.noble@apple.com> 19887 19888 Reviewed by Darin Adler. 19889 19890 Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead. 19891 https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993> 19892 19893 * WebView/WebVideoFullscreenController.mm: 19894 (-[WebVideoFullscreenController windowDidLoad]): 19895 (-[WebVideoFullscreenController setMediaElement:WebCore::]): 19896 198972010-04-08 Mark Rowe <mrowe@apple.com> 19898 19899 Reviewed by John Sullivan. 19900 19901 <rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc] 19902 19903 In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size. 19904 This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the 19905 size and layout of their subclasses is baked in at compile time. This results in instances 19906 being allocated that are smaller than the new code expects, and may result in the new instance 19907 variables sharing the same memory space as any instance variables that the subclass defines. 19908 19909 We can avoid this problem by having the class contain only a single member that acts as a pointer 19910 to a heap-allocated structure that acts as storage for the real instance variables. This makes 19911 us free to add instance variables in the future without risk of changing the size of the class. 19912 To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header 19913 are able to run against older versions of WebKit we pad the class out to its previous size. This 19914 results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible 19915 with both versions of the code. 19916 19917 This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses 19918 instance variables of its superclass. However, this is a private header and no known subclasses 19919 of WebDynamicScrollBarsView access superclass instance variables in this fashion. 19920 19921 * WebView/WebDynamicScrollBarsView.h: 19922 * WebView/WebDynamicScrollBarsView.mm: 19923 (-[WebDynamicScrollBarsView initWithFrame:]): 19924 (-[WebDynamicScrollBarsView dealloc]): 19925 (-[WebDynamicScrollBarsView finalize]): 19926 (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): 19927 (-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]): 19928 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]): 19929 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]): 19930 (-[WebDynamicScrollBarsView horizontalScrollingAllowed]): 19931 (-[WebDynamicScrollBarsView verticalScrollingAllowed]): 19932 (-[WebDynamicScrollBarsView contentViewFrame]): 19933 (-[WebDynamicScrollBarsView tile]): 19934 (-[WebDynamicScrollBarsView setSuppressLayout:]): 19935 (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]): 19936 (-[WebDynamicScrollBarsView updateScrollers]): 19937 (-[WebDynamicScrollBarsView reflectScrolledClipView:]): 19938 (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): 19939 (-[WebDynamicScrollBarsView allowsVerticalScrolling]): 19940 (-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]): 19941 (-[WebDynamicScrollBarsView horizontalScrollingMode]): 19942 (-[WebDynamicScrollBarsView verticalScrollingMode]): 19943 (-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]): 19944 (-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]): 19945 (-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]): 19946 (-[WebDynamicScrollBarsView setScrollingModesLocked:]): 19947 (-[WebDynamicScrollBarsView horizontalScrollingModeLocked]): 19948 (-[WebDynamicScrollBarsView verticalScrollingModeLocked]): 19949 (-[WebDynamicScrollBarsView scrollWheel:]): 19950 199512010-04-07 David Hyatt <hyatt@apple.com> 19952 19953 Reviewed by Oliver Hunt. 19954 19955 https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS 19956 19957 Add SPI so that layout tests can access computed style including :visited information. 19958 19959 * WebView/WebRenderNode.mm: 19960 (copyRenderNode): 19961 * WebView/WebView.mm: 19962 (-[WebView _computedStyleIncludingVisitedInfo:forElement:]): 19963 * WebView/WebViewInternal.h: 19964 * WebView/WebViewPrivate.h: 19965 199662010-04-07 Dan Bernstein <mitz@apple.com> 19967 19968 Reviewed by Adele Peterson. 19969 19970 Refactor WebHTMLView printing code and add private methods to enter and exit printing mode. 19971 https://bugs.webkit.org/show_bug.cgi?id=37246 19972 19973 * Misc/WebNSPrintOperationExtras.h: Declared -_web_availablePaperWidth and -_web_availablePaperHeight. 19974 * Misc/WebNSPrintOperationExtras.m: 19975 (-[NSPrintOperation _web_availablePaperWidth]): Turned -[WebHTMLView _availablePaperWidthForPrintOperation:] 19976 into this method. 19977 (-[NSPrintOperation _web_availablePaperHeight]): Turned -[WebHTMLView _calculatePrintHeight] into this 19978 method. 19979 * WebView/WebHTMLView.mm: 19980 (-[WebHTMLView _isInPrintMode]): Added this accessor. 19981 (-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Added. Moved the code from -knowsPageRange: that 19982 computes the layout widths and enters printing mode into this private method. 19983 (-[WebHTMLView _endPrintMode]): New private method (the old -_endPrintMode has been renamed). 19984 (-[WebHTMLView _scaleFactorForPrintOperation:]): Use -[NSPrintOperation _web_availablePaperWidth]. 19985 (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Renamed -_endPrintMode to this, changed it to call 19986 _endPrintMode. 19987 (-[WebHTMLView _delayedEndPrintMode:]): Updated for rename. 19988 (-[WebHTMLView knowsPageRange:]): Use -_beginPrintModeWithPageWidth:shrintToFit:, 19989 -[NSPrintOperation _web_availablePaperWidth], and -[NSPrintOperation _web_availablePaperHeight]. Updated for 19990 rename. 19991 (-[WebHTMLView beginDocument]): Updated for rename. 19992 (-[WebHTMLView endDocument]): Ditto. 19993 * WebView/WebHTMLViewPrivate.h: Declared new private methods -_isInPrintMode, 19994 -_beginPrintModeWithPageWidth:shrinkToFit: and -_endPrintMode. 19995 199962010-04-07 Andrey Kosyakov <caseq@chromium.org> 19997 19998 Reviewed by Yury Semikhatsky. 19999 20000 Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest() 20001 https://bugs.webkit.org/show_bug.cgi?id=36949 20002 20003 * WebCoreSupport/WebFrameLoaderClient.h: 20004 * WebCoreSupport/WebFrameLoaderClient.mm: 20005 200062010-04-06 Dan Bernstein <mitz@apple.com> 20007 20008 Tiger build fix after r57184. 20009 20010 * WebView/WebHTMLViewPrivate.h: 20011 200122010-04-06 Dan Bernstein <mitz@apple.com> 20013 20014 Tiger build fix after r57184. 20015 20016 * WebView/WebHTMLViewPrivate.h: 20017 200182010-04-06 Adam Barth <abarth@webkit.org> 20019 20020 Unreviewed. 20021 20022 Speculative build fix for Tiger. 20023 20024 * WebView/WebHTMLViewPrivate.h: 20025 200262010-04-06 Dan Bernstein <mitz@apple.com> 20027 20028 Reviewed by Sam Weinig and Anders Carlsson. 20029 20030 Expose WebHTMLView’s page breaking logic as SPI. 20031 20032 * WebView/WebHTMLView.mm: 20033 (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): Factored out of -adjustPageHeightNew:top:bottom:limit: 20034 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Call -_adjustedBottomOfPageWithTop:bottom:limit: 20035 * WebView/WebHTMLViewPrivate.h: Declared -_adjustedBottomOfPageWithTop:bottom:limit: 20036 200372010-04-06 Mark Rowe <mrowe@apple.com> 20038 20039 Add an #if in order to make Tiger happy. 20040 20041 * WebView/WebViewData.mm: 20042 (-[WebViewPrivate init]): 20043 200442010-04-06 Mark Rowe <mrowe@apple.com> 20045 20046 Build fix. 20047 20048 * WebView/WebViewData.mm: 20049 (-[WebViewPrivate init]): Use objc_collectingEnabled like we do elsewhere in WebKit. 20050 200512010-04-05 Mark Rowe <mrowe@apple.com> 20052 20053 Reviewed by Adele Peterson. 20054 20055 Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>. 20056 REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI 20057 20058 * WebView/WebHTMLView.mm: 20059 (-[WebHTMLView _updateFontPanel]): Ask the window whether it is the key window rather than doing the comparison 20060 manually. This allows DumpRenderTree's override of isKeyWindow to force this code path to be taken during tests. 20061 200622010-04-05 Alexey Proskuryakov <ap@apple.com> 20063 20064 Reviewed by Darin Adler. 20065 20066 https://bugs.webkit.org/show_bug.cgi?id=37111 20067 <rdar://problem/7790327> Draw replacement text when plug-in host crashes 20068 20069 * Plugins/Hosted/WebHostedNetscapePluginView.h: Removed _pluginDied - it was only used 20070 for drawing replacement icon, and this information is now in WebCore. 20071 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 20072 (-[WebHostedNetscapePluginView pluginHostDied]): Tell RenderEmbeddedObject that the plug-in 20073 has crashed. 20074 (-[WebHostedNetscapePluginView drawRect:]): Removed the case for crashed plug-in host. It is 20075 handled by WebCore now. 20076 20077 * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory crashedPluginText]): Added a string 20078 for plug-in failure. 20079 200802010-04-03 yael aharon <yael.aharon@nokia.com> 20081 20082 Reviewed by Darin Adler. 20083 20084 Enable HTMLProgressElement for Safari on OSX 20085 https://bugs.webkit.org/show_bug.cgi?id=36961 20086 20087 * Configurations/FeatureDefines.xcconfig: 20088 200892010-04-02 Jer Noble <jer.noble@apple.com> 20090 20091 Reviewed by Eric Carlson. 20092 20093 https://bugs.webkit.org/show_bug.cgi?id=36624 20094 Add an INIT macro for the WebKitSystemInterface function wkQTMovieSelectPreferredAlternates. 20095 20096 * WebCoreSupport/WebSystemInterface.m: 20097 (InitWebCoreSystemInterface): 20098 200992010-04-02 Alexey Proskuryakov <ap@apple.com> 20100 20101 Reviewed by Darin Adler. 20102 20103 https://bugs.webkit.org/show_bug.cgi?id=37043 20104 Java regression tests spam stderr about being unable to set status message 20105 20106 With this change, there is still spam about "Attempt to access JavaScript from destroyed 20107 applet, type 9." I haven't investigated if that indicates a problem or not. 20108 20109 * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]): 20110 Removed check for _documentView. We don't seem to care. 20111 201122010-04-01 Kinuko Yasuda <kinuko@chromium.org> 20113 20114 Reviewed by Dmitry Titov. 20115 20116 Add FileThread for async file operation support in FileReader and FileWriter 20117 https://bugs.webkit.org/show_bug.cgi?id=36896 20118 20119 Add FILE_READER or FILE_WRITER feature defines. 20120 20121 * Configurations/FeatureDefines.xcconfig: 20122 201232010-04-01 Ada Chan <adachan@apple.com> 20124 20125 Reviewed by Darin Adler. 20126 20127 Change WebDatabaseManager::deleteOrigin() to return true if there are no errors in deleting the origin. 20128 Ditto for WebDatabaseManager::deleteDatabase(). 20129 20130 https://bugs.webkit.org/show_bug.cgi?id=36988 20131 20132 * Storage/WebDatabaseManager.mm: 20133 (-[WebDatabaseManager deleteOrigin:]): 20134 (-[WebDatabaseManager deleteDatabase:withOrigin:]): 20135 * Storage/WebDatabaseManagerPrivate.h: 20136 201372010-04-01 Alexey Proskuryakov <ap@apple.com> 20138 20139 Reviewed by Darin Adler. 20140 20141 https://bugs.webkit.org/show_bug.cgi?id=36976 20142 <rdar://problem/7817498> 20143 REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled 20144 20145 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 20146 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): The HashTable assertions aren't 20147 there to catch potential future attempts to store empty/deleted values before these happen - 20148 it's actually wrong to try to look up these values. Added an early return. 20149 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Ditto. 20150 201512010-04-01 Chris Marrin <cmarrin@apple.com> 20152 20153 Reviewed by Simon Fraser. 20154 20155 Added layerTreeAsText function to DRT (for Mac) 20156 https://bugs.webkit.org/show_bug.cgi?id=36782 20157 20158 This is the WebKit side for Mac. It plumbs the 20159 call from WebCore to DRT. 20160 20161 * WebView/WebFrame.mm:WebKit (Mac) side of plumbing 20162 (-[WebFrame _layerTreeAsText]): 20163 * WebView/WebFramePrivate.h: 20164 201652010-04-01 Alexey Proskuryakov <ap@apple.com> 20166 20167 Reviewed by Oliver Hunt. 20168 20169 https://bugs.webkit.org/show_bug.cgi?id=36976 20170 <rdar://problem/7817498> 20171 REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled 20172 20173 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 20174 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Use find() instead of get(), 20175 because the latter fails with an assertion when looking up 0 or -1. 20176 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Be prepared for unexpected 20177 object IDs coming from plug-in host. 20178 201792010-03-31 Chris Fleizach <cfleizach@apple.com> 20180 20181 Reviewed by Darin Adler. 20182 20183 Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit 20184 https://bugs.webkit.org/show_bug.cgi?id=36845 20185 20186 Provide a way through WebKit to set an accessible label that describes the web area. 20187 20188 * WebView/WebFrame.mm: 20189 (-[WebFrame setAccessibleName:]): 20190 * WebView/WebFramePrivate.h: 20191 201922010-03-31 Marcus Bulach <bulach@chromium.org> 20193 20194 Reviewed by Jeremy Orlow. 20195 20196 Adds Geolocation param for cancelGeolocationPermissionRequestForFrame. 20197 https://bugs.webkit.org/show_bug.cgi?id=35031 20198 20199 * WebCoreSupport/WebChromeClient.h: 20200 (WebChromeClient::cancelGeolocationPermissionRequestForFrame): 20201 202022010-03-30 Gavin Barraclough <barraclough@apple.com> 20203 20204 Rubber stamped by Sam Weinig. 20205 20206 https://bugs.webkit.org/show_bug.cgi?id=36866 20207 Move CString to WTF 20208 20209 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 20210 (WebKit::NetscapePluginInstanceProxy::getCookies): 20211 (WebKit::NetscapePluginInstanceProxy::getProxy): 20212 (WebKit::NetscapePluginInstanceProxy::getAuthenticationInfo): 20213 (WebKit::NetscapePluginInstanceProxy::resolveURL): 20214 * Plugins/WebBaseNetscapePluginView.h: 20215 * Plugins/WebBaseNetscapePluginView.mm: 20216 * Plugins/WebNetscapePluginView.mm: 20217 (-[WebNetscapePluginView resolveURL:forTarget:]): 20218 202192010-03-30 John Sullivan <sullivan@apple.com> 20220 20221 Reviewed by Dan Bernstein. 20222 20223 https://bugs.webkit.org/show_bug.cgi?id=36848 20224 <rdar://problem/7362913> 20225 Menu items appropriate only for rich-content editing can appear in plain-text contexts 20226 20227 * WebView/WebHTMLView.mm: 20228 (-[WebHTMLView validRequestorForSendType:returnType:]): 20229 Don't return self for non-string content if _canEditRichly is false. 20230 202312010-03-29 Alexey Proskuryakov <ap@apple.com> 20232 20233 Reviewed by Darin Adler. 20234 20235 https://bugs.webkit.org/show_bug.cgi?id=36791 20236 Add assertions for instance proxy validity 20237 20238 Add some assertions that the instance proxy hasn't been deleted. We sometimes keep a raw 20239 pointer to one across complicated function calls, relying on the caller to protect the 20240 reference. 20241 20242 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 20243 (WebKit::NetscapePluginInstanceProxy::renderContextID): 20244 (WebKit::NetscapePluginInstanceProxy::pluginView): 20245 (WebKit::NetscapePluginInstanceProxy::hostProxy): 20246 202472010-03-30 Laszlo Gombos <laszlo.1.gombos@nokia.com> 20248 20249 Reviewed by David Kilzer. 20250 20251 Explicit guards for ENABLE_GEOLOCATION 20252 https://bugs.webkit.org/show_bug.cgi?id=25756 20253 20254 * WebCoreSupport/WebGeolocationMock.mm: 20255 (-[WebGeolocationMock setError:code:]): Make the body conditional on 20256 ENABLE(GEOLOCATION) 20257 (-[WebGeolocationMock setPosition:]): Ditto. 20258 202592010-03-26 Kenneth Rohde Christiansen <kenneth@webkit.org> 20260 20261 Reviewed by Antti Koivisto. 20262 20263 Change method name due to it dealing with both flattening 20264 of frame sets and inner frames. 20265 20266 * WebView/WebPreferenceKeysPrivate.h: 20267 * WebView/WebPreferences.mm: 20268 (+[WebPreferences initialize]): 20269 (-[WebPreferences isFrameFlatteningEnabled]): 20270 (-[WebPreferences setFrameFlatteningEnabled:]): 20271 * WebView/WebPreferencesPrivate.h: 20272 * WebView/WebView.mm: 20273 (-[WebView _preferencesChangedNotification:]): 20274 202752010-03-27 Darin Adler <darin@apple.com> 20276 20277 * Misc/WebNSFileManagerExtras.m: 20278 (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): 20279 Removed stray "!". How did that get in there? 20280 202812010-03-27 Darin Adler <darin@apple.com> 20282 20283 Reviewed by Mark Rowe. 20284 20285 WebKit NSFileManager methods don't handle broken symlinks correctly. 20286 Part of <rdar://problem/7574046>. 20287 20288 * Misc/WebNSFileManagerExtras.h: Removed unused defines and methods. 20289 * Misc/WebNSFileManagerExtras.m: Removed unused methods. 20290 (fileExists): Added. For use instead of fileExistsAtPath: for cases where we'd like 20291 to treat a broken symlink as a file that does indeed exist. 20292 (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use fileExists. 20293 202942010-03-25 Alexey Proskuryakov <ap@apple.com> 20295 20296 Reviewed by Mark Rowe. 20297 20298 * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): Re-fetch host proxy in 20299 a way that works in a function that doesn't have a pluginID argument for some reason. 20300 203012010-03-25 Simon Fraser <simon.fraser@apple.com> 20302 20303 Build fix: no review. 20304 20305 Another c_str() -> data(). 20306 20307 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 20308 (WebKit::NetscapePluginInstanceProxy::enumerate): 20309 203102010-03-25 Alexey Proskuryakov <ap@apple.com> 20311 20312 Reviewed by Mark Rowe. 20313 20314 Correctness fix after r56493. 20315 20316 * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): We still need to update 20317 our hostProxy reference, even though we didn't use to have instanceProxy. Nothing guarantees 20318 that the host proxy won't go away while the open panel is up. 20319 203202010-03-24 Mark Rowe <mrowe@apple.com> 20321 20322 Build fix after r56474. 20323 20324 * Plugins/Hosted/NetscapePluginHostProxy.mm: 20325 (WKPCRunSyncOpenPanel): 20326 203272010-03-24 Alexey Proskuryakov <ap@apple.com> 20328 20329 Reviewed by Anders Carlsson. 20330 20331 https://bugs.webkit.org/show_bug.cgi?id=36563 20332 A plug-in makes Safari crash on http://www.itscodingtime.com/ 20333 20334 * Plugins/Hosted/NetscapePluginHostProxy.h: 20335 (WebKit::NetscapePluginHostProxy::port): Assert that the object is still alive. This isn't 20336 beautifully systemic, but helped catch a bug, and may help catch more. 20337 (WebKit::NetscapePluginHostProxy::clientPort): Ditto. 20338 (WebKit::NetscapePluginHostProxy::isProcessingRequests): Changed m_processingRequests to a 20339 static. This doesn't change behavior much, but helps avoid writing into deallocated memory. 20340 20341 * Plugins/Hosted/NetscapePluginHostProxy.mm: 20342 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Changed m_processingRequests 20343 to a static. 20344 (WebKit::NetscapePluginHostProxy::processRequests): Ditto. Changing m_processingRequests 20345 after destroying the object in pluginHostDied() was wrong, but reasonably harmless, as there 20346 wasn't much time for some other object to be allocated at this address. 20347 (WKPCEvaluate): Refetch host proxy, as it may have been destroyed. 20348 (WKPCInvoke): Ditto. 20349 (WKPCInvokeDefault): Ditto. 20350 (WKPCGetProperty): Ditto. 20351 (WKPCSetProperty): Ditto. 20352 (WKPCRemoveProperty): Ditto. 20353 (WKPCHasProperty): Ditto. 20354 (WKPCHasMethod): Ditto. 20355 (WKPCEnumerate): Ditto. 20356 (WKPCRunSyncOpenPanel): Ditto. 20357 20358 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 20359 (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Bail out of the 20360 "event loop" if host proxy went away while processing a request. 20361 203622010-03-24 Hayato Ito <hayato@chromium.org> 20363 20364 Reviewed by Shinichiro Hamaji. 20365 20366 Refactor computePageRects so that Mac can make use of it. 20367 https://bugs.webkit.org/show_bug.cgi?id=36159 20368 20369 Refactoring only, so no new tests. 20370 20371 * WebView/WebFrame.mm: 20372 (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): 20373 203742010-03-24 Kent Tamura <tkent@chromium.org> 20375 20376 Reviewed by Darin Adler. 20377 20378 Make Icon::createIconForFiles() optional. 20379 https://bugs.webkit.org/show_bug.cgi?id=35072 20380 20381 - Rename iconForFiles() to chooseIconForFiles(). 20382 - Call Icon::createIconForFiles() from chooseIconForFiles(). 20383 20384 * WebCoreSupport/WebChromeClient.h: 20385 * WebCoreSupport/WebChromeClient.mm: 20386 (WebChromeClient::chooseIconForFiles): 20387 203882010-03-23 Dan Bernstein <mitz@apple.com> 20389 20390 Reverted accidental change from r56429. 20391 20392 * WebCoreSupport/WebContextMenuClient.mm: 20393 (WebContextMenuClient::getCustomMenuFromDefaultItems): 20394 203952010-03-23 Dan Bernstein <mitz@apple.com> 20396 20397 Reviewed by John Sullivan. 20398 20399 WebKit part of 20400 <rdar://problem/7197736> Plug-in clip rect does not update when overflow 20401 clip changes 20402 https://bugs.webkit.org/show_bug.cgi?id=36479. 20403 20404 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 20405 (-[WebHostedNetscapePluginView visibleRectDidChange]): Added. Calls 20406 WKSyncSurfaceToView(). 20407 * Plugins/WebBaseNetscapePluginView.h: 20408 * Plugins/WebBaseNetscapePluginView.mm: 20409 (-[WebBaseNetscapePluginView _windowClipRect]): Changed to use Widget::windowClipRect(). 20410 (-[WebBaseNetscapePluginView visibleRectDidChange]): Added. Invokes -renewGState. 20411 204122010-03-22 Kevin Decker <kdecker@apple.com> 20413 20414 Reviewed by Simon Fraser. 20415 20416 https://bugs.webkit.org/show_bug.cgi?id=36328 20417 20418 This patch entirely WebNullPluginView. 20419 20420 * Plugins/WebNetscapePluginView.mm: 20421 * Plugins/WebNullPluginView.h: Removed. 20422 * Plugins/WebNullPluginView.mm: Removed. 20423 * Resources/nullplugin.tiff: Removed. 20424 * WebCoreSupport/WebFrameLoaderClient.mm: 20425 (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load. 20426 204272010-03-22 Alexey Proskuryakov <ap@apple.com> 20428 20429 Reviewed by John Sullivan. 20430 20431 https://bugs.webkit.org/show_bug.cgi?id=36455 20432 Make WebKit more resistant against plug-in crashes 20433 20434 No tests, because crashing on build bots isn't good, even if it's only helper processes 20435 that crash. 20436 20437 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 20438 (WebKit::NetscapePluginInstanceProxy::waitForReply): Protect "this", because this function 20439 needs it after waiting for reply. Some callers used to do this, but not all, and we really 20440 shouldn't depend on callers here. 20441 20442 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 20443 (WebKit::NetscapePluginInstanceProxy::wheelEvent): Don't protect the plug-in instance proxy, 20444 because this function doesn't use it after waiting for reply. 20445 (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Ditto. 20446 20447 * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Added an m_instanceProxy 20448 null check for another code path. 20449 204502010-03-22 Kevin Decker <kdecker@apple.com> 20451 20452 Reviewed by John Sullivan. 20453 20454 https://bugs.webkit.org/show_bug.cgi?id=36328 20455 20456 * WebCoreSupport/WebViewFactory.mm: 20457 (-[WebViewFactory missingPluginText]): Added. 20458 204592010-03-18 Alexey Proskuryakov <ap@apple.com> 20460 20461 Reviewed by Darin Adler. 20462 20463 https://bugs.webkit.org/show_bug.cgi?id=36337 20464 Log an error when an OOP plug-in sends an unknown object id 20465 20466 Making these LOG_ERROR and not ASSERTs, because I don't want early returns to look 20467 temporary or redundant. 20468 20469 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 20470 (WebKit::NetscapePluginInstanceProxy::evaluate): 20471 (WebKit::NetscapePluginInstanceProxy::invoke): 20472 (WebKit::NetscapePluginInstanceProxy::invokeDefault): 20473 (WebKit::NetscapePluginInstanceProxy::construct): 20474 (WebKit::NetscapePluginInstanceProxy::getProperty): 20475 (WebKit::NetscapePluginInstanceProxy::setProperty): 20476 (WebKit::NetscapePluginInstanceProxy::removeProperty): 20477 (WebKit::NetscapePluginInstanceProxy::hasProperty): 20478 (WebKit::NetscapePluginInstanceProxy::hasMethod): 20479 (WebKit::NetscapePluginInstanceProxy::enumerate): 20480 204812010-03-16 Alexey Proskuryakov <ap@apple.com> 20482 20483 Reviewed by Darin Adler. 20484 20485 https://bugs.webkit.org/show_bug.cgi?id=36184 20486 YouTube video resizing doesn't work with OOP plug-ins 20487 20488 Test: plugins/resize-from-plugin.html 20489 20490 We were calling _WKPHResizePluginInstance synchronously or asynchronously, depending on 20491 whether the size has changed. But sync and async messages are not necessarily delivered in 20492 order - plug-in host listens only to the former while waiting for a response to a message it 20493 sent (a call to invoke() in this case). 20494 20495 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 20496 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 20497 (WebKit::NetscapePluginInstanceProxy::resize): 20498 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 20499 (-[WebHostedNetscapePluginView updateAndSetWindow]): 20500 205012010-03-16 Yury Semikhatsky <yurys@chromium.org> 20502 20503 Reviewed by Pavel Feldman. 20504 20505 Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost. 20506 20507 Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder 20508 https://bugs.webkit.org/show_bug.cgi?id=35036 20509 20510 * WebCoreSupport/WebInspectorClient.h: 20511 * WebCoreSupport/WebInspectorClient.mm: 20512 (WebInspectorClient::WebInspectorClient): 20513 (WebInspectorClient::inspectorDestroyed): 20514 (WebInspectorClient::openInspectorFrontend): 20515 (WebInspectorClient::highlight): 20516 (WebInspectorClient::hideHighlight): 20517 (WebInspectorFrontendClient::WebInspectorFrontendClient): 20518 (WebInspectorFrontendClient::frontendLoaded): 20519 (WebInspectorFrontendClient::localizedStringsURL): 20520 (WebInspectorFrontendClient::hiddenPanels): 20521 (WebInspectorFrontendClient::bringToFront): 20522 (WebInspectorFrontendClient::closeWindow): 20523 (WebInspectorFrontendClient::attachWindow): 20524 (WebInspectorFrontendClient::detachWindow): 20525 (WebInspectorFrontendClient::setAttachedWindowHeight): 20526 (WebInspectorFrontendClient::inspectedURLChanged): 20527 (WebInspectorFrontendClient::updateWindowTitle): 20528 (-[WebInspectorWindowController dealloc]): 20529 (-[WebInspectorWindowController windowShouldClose:]): 20530 (-[WebInspectorWindowController close]): 20531 (-[WebInspectorWindowController showWindow:]): 20532 (-[WebInspectorWindowController attach]): 20533 (-[WebInspectorWindowController detach]): 20534 (-[WebInspectorWindowController attached]): 20535 (-[WebInspectorWindowController setFrontendClient:]): 20536 (-[WebInspectorWindowController destroyInspectorView]): 20537 (-[WebNodeHighlighter initWithInspectedWebView:]): 20538 (-[WebNodeHighlighter dealloc]): 20539 (-[WebNodeHighlighter highlightNode:]): 20540 (-[WebNodeHighlighter hideHighlight]): 20541 (-[WebNodeHighlighter didAttachWebNodeHighlight:]): 20542 (-[WebNodeHighlighter willDetachWebNodeHighlight:]): 20543 * WebInspector/WebInspector.mm: 20544 (-[WebInspector attach:]): 20545 (-[WebInspector detach:]): 20546 205472010-03-15 Andy Estes <aestes@apple.com> 20548 20549 Reviewed by John Sullivan. 20550 20551 Updated call to WKGetWheelEventDeltas() to match new method signature. 20552 20553 https://bugs.webkit.org/show_bug.cgi?id=29601 20554 <rdar://problem/7453254> 20555 20556 * WebView/WebDynamicScrollBarsView.mm: 20557 (-[WebDynamicScrollBarsView scrollWheel:]): 20558 205592010-03-15 John Sullivan <sullivan@apple.com> 20560 20561 Reviewed by Adam Roben. 20562 20563 -[WebFrame setAlwaysHideHorizontal/VerticalScroller:] prevents keyboard scrolling 20564 <https://bugs.webkit.org/show_bug.cgi?id=36125> 20565 20566 * WebView/WebDynamicScrollBarsView.h: 20567 Added instance variables horizontalScrollingAllowedButScrollerHidden and 20568 verticalScrollingAllowedButScrollerHidden. Renamed instance variables 20569 hideHorizontal/VerticalScroller to alwaysHideHorizontal/VerticalScroller for clarity. 20570 Declared methods -horizontalScrollingAllowed and -verticalScrollingAllowed. 20571 Added comments. 20572 20573 * WebView/WebDynamicScrollBarsView.mm: 20574 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]): 20575 Updated for instance variable renaming. 20576 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]): 20577 Ditto. 20578 (-[WebDynamicScrollBarsView horizontalScrollingAllowed]): 20579 New method, returns YES if the scroller is showing or the only reason that the scroller 20580 is not showing is that setAlwaysHideHorizontalScrolling has been called. 20581 (-[WebDynamicScrollBarsView verticalScrollingAllowed]): 20582 New method, returns YES if the scroller is showing or the only reason that the scroller 20583 is not showing is that setAlwaysHideVerticalScrolling has been called. 20584 (-[WebDynamicScrollBarsView updateScrollers]): 20585 Updated for instance variable renamings. Now updates horizontalScrollingAllowedButScrollerHidden 20586 and verticalScrollingAllowedButScrollerHidden. Now takes the always-hidden state into account 20587 in the early-return code path, to avoid taking it into account twice in the regular code path. 20588 20589 * WebView/WebFrameView.mm: 20590 (-[WebFrameView _scrollToBeginningOfDocument]): 20591 Use _isScrollable instead of _hasScrollBars. 20592 (-[WebFrameView _scrollToEndOfDocument]): 20593 Ditto. 20594 (-[WebFrameView scrollToBeginningOfDocument:]): 20595 Use _largestScrollableChild instead of _largestChildWithScrollBars. 20596 (-[WebFrameView scrollToEndOfDocument:]): 20597 Ditto. 20598 (-[WebFrameView _pageVertically:]): 20599 Use _isScrollable and _largestScrollableChild instead of _hasScrollBars 20600 and _largestChildWithScrollBars. 20601 (-[WebFrameView _pageHorizontally:]): 20602 Ditto. 20603 (-[WebFrameView _scrollLineVertically:]): 20604 Ditto. 20605 (-[WebFrameView _scrollLineHorizontally:]): 20606 Ditto. 20607 (-[WebFrameView keyDown:]): 20608 Use _largestScrollableChild instead of _largestChildWithScrollBars. 20609 (-[WebFrameView _isScrollable]): 20610 New method, calls -[WebDynamicScrollBarsView horizontalScrollingAllowed] and 20611 -[WebDynamicScrollBarsView verticalScrollingAllowed] 20612 (-[WebFrameView _largestScrollableChild]): 20613 New method, like _largestChildWithScrollBars but uses _isScrollable. 20614 (-[WebFrameView _hasScrollBars]): 20615 Added a comment that this is no longer used by Safari, and can thus probably be 20616 deleted once we no longer want to support it for nightly build compatibility with 20617 old versions of Safari. 20618 (-[WebFrameView _largestChildWithScrollBars]): 20619 Ditto. 20620 20621 * WebView/WebFrameViewPrivate.h: 20622 Declared -_isScrollable and -_largestScrollableChild. Added comments to 20623 _hasScrollBars and _largestChildWithScrollBars saying that they are no longer 20624 used by Safari, and can thus probably be deleted once we no longer want to 20625 support them for nightly build compatibility with old versions of Safari. 20626 206272010-03-15 John Sullivan <sullivan@apple.com> 20628 20629 Method name and parameter name mistakes from recent SPI addition 20630 <https://bugs.webkit.org/show_bug.cgi?id=36119> 20631 20632 Reviewed by Dan Bernstein. 20633 20634 * WebView/WebDynamicScrollBarsView.h: 20635 Renamed instance variable and method name from "setAllowXXX" to "setAllowsXXX". 20636 20637 * WebView/WebDynamicScrollBarsView.mm: 20638 (-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]): 20639 Updated for renamed instance variable and method. 20640 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]): 20641 Changed parameter name from shouldBeVisible to shouldBeHidden. 20642 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]): 20643 Ditto. 20644 (-[WebDynamicScrollBarsView contentViewFrame]): 20645 Updated for renamed instance variable. 20646 (-[WebDynamicScrollBarsView tile]): 20647 Ditto. 20648 (-[WebDynamicScrollBarsView reflectScrolledClipView:]): 20649 Ditto. 20650 20651 * WebView/WebFrame.mm: 20652 (-[WebFrame setAllowsScrollersToOverlapContent:]): 20653 Renamed method from setAllowXXX, and updated for same change in WebDynamicScrollBarsView. 20654 20655 * WebView/WebFramePrivate.h: 20656 Renamed method name from "setAllowXXX" to "setAllowsXXX". 20657 206582010-03-14 Darin Adler <darin@apple.com> 20659 20660 Reviewed by Mark Rowe. 20661 20662 Remove unneeded dependency on non-string identifier for an NSTableColumn 20663 https://bugs.webkit.org/show_bug.cgi?id=36106 20664 20665 * WebView/WebTextCompletionController.mm: 20666 (-[WebTextCompletionController _buildUI]): Use init instead of initWithIdentifier: 20667 because the table has only one column and that column does not need an identifier. 20668 206692010-03-12 Beth Dakin <bdakin@apple.com> 20670 20671 Reviewed by Simon Fraser. 20672 20673 Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen 20674 API naming is inconsistent 20675 -and corresponding- 20676 <rdar://problem/7729165> 20677 20678 This patch changes all occurrences of "fullScreen" to the more 20679 popular "fullscreen." 20680 20681 * Plugins/Hosted/NetscapePluginHostProxy.h: 20682 (WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing): 20683 * Plugins/Hosted/NetscapePluginHostProxy.mm: 20684 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): 20685 (WebKit::NetscapePluginHostProxy::didEnterFullscreen): 20686 (WebKit::NetscapePluginHostProxy::didExitFullscreen): 20687 (WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing): 20688 (WKPCSetFullscreenWindowIsShowing): 20689 * Plugins/Hosted/WebKitPluginClient.defs: 20690 * Plugins/WebNetscapePluginView.mm: 20691 (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): 20692 (-[WebNetscapePluginView _createPlugin]): 20693 (-[WebNetscapePluginView _destroyPlugin]): 20694 * WebView/WebVideoFullscreenHUDWindowController.mm: 20695 (-[WebVideoFullscreenHUDWindowController windowDidLoad]): 20696 206972010-03-12 Andy Estes <aestes@apple.com> 20698 20699 Reviewed by Brady Eidson. 20700 20701 Expose WebPDFView's underlying PDFDocument. 20702 20703 https://bugs.webkit.org/show_bug.cgi?id=36045 20704 20705 * WebView/WebDocumentPrivate.h: Create a new protocol called 20706 WebDocumentPDF. 20707 * WebView/WebPDFView.h: Have WebPDFView implement said protocol. 20708 * WebView/WebPDFView.mm: 20709 (-[WebPDFView PDFDocument]): Expose WebPDFView's underlying 20710 PDFDocument by implementing -(PDFDocument*)PDFDocument from 20711 WebDocumentPDF. 20712 207132010-03-12 Andy Estes <aestes@apple.com> 20714 20715 Reviewed by Brady Eidson. 20716 20717 Remove an unused method. 20718 20719 https://bugs.webkit.org/show_bug.cgi?id=35940 20720 20721 * Plugins/WebPluginController.mm: 20722 removed - (void)showURL:(NSURL *) inFrame:(NSString *) 20723 207242010-03-11 Mark Rowe <mrowe@apple.com> 20725 20726 Reviewed by David Kilzer. 20727 20728 <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version 20729 20730 Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version. 20731 20732 * Configurations/Base.xcconfig: 20733 207342010-03-11 Mark Rowe <mrowe@apple.com> 20735 20736 Reviewed by Tim Hatcher. 20737 20738 <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version 20739 20740 Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the 20741 current Mac OS X version unless otherwise specified. 20742 20743 Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR. 20744 20745 Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice 20746 may not be usable when targetting a different Mac OS X version. 20747 20748 Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off 20749 MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used. 20750 20751 * Configurations/Base.xcconfig: 20752 * Configurations/DebugRelease.xcconfig: 20753 * Configurations/FeatureDefines.xcconfig: 20754 * Configurations/Version.xcconfig: 20755 207562010-03-11 Anders Carlsson <andersca@apple.com> 20757 20758 Reviewed by David Hyatt. 20759 20760 Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents. 20761 20762 * WebCoreSupport/WebChromeClient.h: 20763 * WebCoreSupport/WebChromeClient.mm: 20764 207652010-03-11 Alexey Proskuryakov <ap@apple.com> 20766 20767 Reviewed by Geoff Garen. 20768 20769 https://bugs.webkit.org/show_bug.cgi?id=35965 20770 <rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in 20771 20772 Test: plugins/round-trip-npobject.html 20773 20774 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 20775 (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Corrected the check - there is 20776 now a separate ProxyRuntimeObject class for proxy pbjects. 20777 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto. 20778 20779 * Plugins/Hosted/ProxyInstance.mm: 20780 (WebKit::ProxyInstance::invoke): Check if m_instanceProxy is still non-zero. The plug-in 20781 could have crashed while we were waiting for response. 20782 (WebKit::ProxyInstance::setFieldValue): Ditto. 20783 207842010-03-10 Simon Fraser <simon.fraser@apple.com> 20785 20786 Reviewed by Darin Adler. 20787 20788 https://bugs.webkit.org/show_bug.cgi?id=35975 20789 <rdar://problem/7739922> Flash 10.1b crashes when generating snapshots 20790 20791 Do a version check before sending a drawRect event to a Flash plugin, 20792 since 10.1.d51 has a bug that crashes when called this way. 20793 20794 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 20795 (-[WebHostedNetscapePluginView drawRect:]): 20796 * Plugins/WebBaseNetscapePluginView.h: 20797 * Plugins/WebBaseNetscapePluginView.mm: 20798 (-[WebBaseNetscapePluginView supportsSnapshotting]): 20799 * Plugins/WebNetscapePluginView.mm: 20800 (-[WebNetscapePluginView drawRect:]): 20801 208022010-03-10 John Sullivan <sullivan@apple.com> 20803 20804 Reviewed by Tim Hatcher. 20805 20806 <rdar://problem/7735387> input type other than text won't work with autofill 20807 <https://bugs.webkit.org/show_bug.cgi?id=35963> 20808 20809 * WebView/WebHTMLRepresentation.mm: 20810 (-[WebHTMLRepresentation elementDoesAutoComplete:]): 20811 Return true for any text field that's not a password, rather than only 20812 for TEXT type. 20813 208142010-03-09 Brady Eidson <beidson@apple.com> 20815 20816 Reviewed by Tim Hatcher. 20817 20818 REGRESSION: WebInspector docking busted on Windows 20819 <rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953 20820 20821 * WebCoreSupport/WebInspectorClient.mm: 20822 (-[WebInspectorWindowController showWindow:]): Use the InspectorController:: copy of the should attach settings key. 20823 (-[WebInspectorWindowController attach]): Ditto. 20824 (-[WebInspectorWindowController detach]): Ditto. 20825 208262010-03-09 Geoffrey Garen <ggaren@apple.com> 20827 20828 Reviewed by Darin Adler. 20829 20830 Updated for FastMalloc reporting changes. 20831 20832 * Misc/WebCoreStatistics.mm: 20833 (+[WebCoreStatistics memoryStatistics]): 20834 208352010-03-08 Simon Fraser <simon.fraser@apple.com> 20836 20837 Reviewed by Mark Rowe. 20838 20839 Move the new method to the end of the MIG definitions file, to avoid breaking 20840 compatibility between WebKit and older versions of WebKitPluginHost. 20841 20842 * Plugins/Hosted/WebKitPluginHost.defs: 20843 208442010-03-08 Simon Fraser <simon.fraser@apple.com> 20845 20846 Reviewed by Kevin Decker. 20847 20848 <rdar://problem/7714340> Need to grab image snapshot of Core Animation plugins 20849 20850 Allow plug-ins using the Core Animation drawing model to be captured when doing a flattening paint, 20851 by sending them a drawRect event as if they were software-painting. 20852 20853 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 20854 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 20855 (WebKit::NetscapePluginInstanceProxy::snapshot): 20856 New snapshot() method that calls over to the plugin host, and then draws the image that comes back. 20857 20858 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 20859 (-[WebHostedNetscapePluginView drawRect:]): If we don't have a software renderer, but we're doing 20860 a flattening paint, then call the snapshot method. 20861 20862 * Plugins/Hosted/WebKitPluginHost.defs: Added snapshot method. 20863 20864 * Plugins/WebBaseNetscapePluginView.h: 20865 * Plugins/WebBaseNetscapePluginView.mm: 20866 (-[WebBaseNetscapePluginView inFlatteningPaint]): 20867 New utility method that asks the FrameView whether the current paint behavior is 20868 flattening. 20869 20870 * Plugins/WebNetscapePluginView.mm: 20871 (-[WebNetscapePluginView drawRect:]): If the plug-in is using CA but this is a flattening 20872 paint, go ahead and send a drawRect event to the plug-in. 20873 208742010-03-08 Darin Adler <darin@apple.com> 20875 20876 Reviewed by Dan Bernstein. 20877 20878 Fix crash when you quit inside an unload handler. 20879 rdar://problem/6958347 20880 20881 Test: manual-tests/quit-inside-unload.html 20882 20883 * WebView/WebView.mm: 20884 (-[WebView _closeWithFastTeardown]): Removed code to set 20885 _private->closed since _close now does this earlier, before 20886 calling this method. 20887 (-[WebView _close]): Moved code to set _private->closed to the 20888 top of this method. 20889 (-[WebView setHostWindow:]): Rewrote the code that forbade 20890 setting the host window after closing so that it only forbids 20891 non-nil host windows. That way, the code to clear away the host 20892 window can run safely after setting _private->closed, yet client 20893 code cannot set a new host window after closing. 20894 208952010-03-08 Darin Adler <darin@apple.com> 20896 20897 Roll out a file I checked in by accident. 20898 20899 * WebView/WebView.mm: Back to previous version. 20900 209012010-03-08 Chris Marrin <cmarrin@apple.com> 20902 20903 Reviewed by Darin Adler. 20904 20905 Turn on HW accel on Leopard even if coreVideoHas7228836Fix() is false, when WebGL is enabled 20906 https://bugs.webkit.org/show_bug.cgi?id=35759 20907 20908 This allows WebGL to work on Leopard without the fix. It exposes these users to the crash 20909 that happens because of the CoreVideo bug, but it limits the exposure to those who have 20910 chosen to enable WebGL. 20911 20912 * WebView/WebView.mm: 20913 (-[WebView _preferencesChangedNotification:]): 20914 209152010-03-02 Adam Treat <atreat@rim.com> 20916 20917 Reviewed by Dave Hyatt. 20918 20919 Adapt the mac port to the refactoring of repaint methods. 20920 20921 https://bugs.webkit.org/show_bug.cgi?id=34214 20922 20923 * WebCoreSupport/WebChromeClient.h: 20924 * WebCoreSupport/WebChromeClient.mm: 20925 (WebChromeClient::invalidateContents): 20926 (WebChromeClient::invalidateWindow): 20927 (WebChromeClient::invalidateContentsAndWindow): 20928 (WebChromeClient::invalidateContentsForSlowScroll): 20929 209302010-03-08 Jian Li <jianli@chromium.org> 20931 20932 Reviewed by Dmitry Titov. 20933 20934 Blob.slice support. 20935 https://bugs.webkit.org/show_bug.cgi?id=32993 20936 20937 Add ENABLE_BLOB_SLICE feature define. 20938 20939 * Configurations/FeatureDefines.xcconfig: 20940 209412010-03-08 Eric Uhrhane <ericu@chromium.org> 20942 20943 Reviewed by David Levin. 20944 20945 Remove the now-redundant Settings fields for the Database 20946 https://bugs.webkit.org/show_bug.cgi?id=35763 20947 20948 No new tests; this code isn't called. 20949 20950 * WebView/WebView.mm: Remove the call into Settings. 20951 (-[WebView _preferencesChangedNotification:]): 20952 209532010-03-07 Mark Rowe <mrowe@apple.com> 20954 20955 Rubber-stamped by Cameron Zwarich. 20956 20957 Remove unnecessary includes from header files, adding them to the handful of implementation files that need them. 20958 20959 * Misc/WebIconDatabase.mm: 20960 209612010-03-07 Mark Rowe <mrowe@apple.com> 20962 20963 Rubber-stamped by Cameron Zwarich. 20964 20965 Remove unnecessary includes from header files, adding them to the handful of implementation files that need them. 20966 20967 * Misc/WebNSPasteboardExtras.mm: 20968 209692010-03-04 Mark Rowe <mrowe@apple.com> 20970 20971 Reviewed by Sam Weinig. 20972 20973 <rdar://problem/7717249> DOMSVG.h includes a non-existent DOMSVGFEMorphologyElement.h 20974 20975 * MigrateHeaders.make: Migrate DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h. 20976 209772010-03-04 Mark Rowe <mrowe@apple.com> 20978 20979 Reviewed by Sam Weinig. 20980 20981 Use a framework-style include to pull in WebInspector.h for consistency 20982 with other parts of WebKit. 20983 20984 * WebInspector/WebInspectorPrivate.h: 20985 209862010-03-04 Brady Eidson <beidson@apple.com> 20987 20988 Reviewed by Geoff Garen. 20989 20990 REGRESSION (31281): -[WebArchive initWithCoder:] leaks 20991 <rdar://problem/7702420> and https://bugs.webkit.org/show_bug.cgi?id=35534 20992 20993 * WebView/WebArchive.mm: 20994 (-[WebArchive initWithCoder:]): Don't retain objects we don't own. 20995 209962010-03-03 Alexey Proskuryakov <ap@apple.com> 20997 20998 Reviewed by Timothy Hatcher. 20999 21000 https://bugs.webkit.org/show_bug.cgi?id=35692 21001 <rdar://problem/7703622> Crash when calling abort() on an XHR while in a windowless WebView 21002 21003 * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): 21004 Retain the challenge, just like it's done for sheet. 21005 210062010-03-02 Eric Uhrhane <ericu@chromium.org> 21007 21008 Reviewed by David Levin. 21009 21010 Move database enable bit fully out of settings 21011 This is stage one of a three-stage commit [webkit, then chromium, then 21012 webkit again]. In this change I'm adding calls to 21013 Database::setIsAvailable inside Settings::setDatabaseEnabled and 21014 anywhere else that called it, and switching webkit fully over to using 21015 that flag [added in a previous checkin]. Phase two will remove 21016 Chromium's use of Settings for the Database, and phase three will remove 21017 the Setting for the Database enable entirely, leaving only 21018 Database::isAvailable/setIsAvailable. 21019 21020 No new tests; tested by existing storage tests. 21021 21022 https://bugs.webkit.org/show_bug.cgi?id=35310 21023 21024 * WebView/WebView.mm: Added a call to Database::setIsAvailable. 21025 (-[WebView _preferencesChangedNotification:]): 21026 210272010-03-02 Adam Roben <aroben@apple.com> 21028 21029 Add -[WebView _registerURLSchemeAsSecure:] 21030 21031 Fixes <http://webkit.org/b/35580> <rdar://problem/7706407> Expose 21032 SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI 21033 21034 Reviewed by Tim Hatcher. 21035 21036 * WebView/WebView.mm: 21037 (+[WebView _registerURLSchemeAsSecure:]): 21038 * WebView/WebViewPrivate.h: 21039 Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure. 21040 210412010-03-01 Jakob Petsovits <jpetsovits@rim.com> 21042 21043 Reviewed by Adam Barth. 21044 21045 Adapt to the new ZoomMode enum. 21046 https://bugs.webkit.org/show_bug.cgi?id=35347 21047 21048 * WebView/WebView.mm: 21049 (-[WebView _preferencesChangedNotification:]): 21050 (-[WebView _setZoomMultiplier:isTextOnly:]): 21051 (-[WebView _realZoomMultiplierIsTextOnly]): 21052 210532010-02-27 Jing Jin <jjin@apple.com> 21054 21055 Reviewed by Timothy Hatcher. 21056 21057 Move implementation of Bug 35449 into WebFramePrivate. 21058 21059 * WebView/WebFrame.h: 21060 * WebView/WebFrame.mm: 21061 (-[WebFrame setAllowScrollersToOverlapContent:]): 21062 (-[WebFrame setAlwaysHideHorizontalScroller:]): 21063 (-[WebFrame setAlwaysHideVerticalScroller:]): 21064 * WebView/WebFramePrivate.h: 21065 210662010-02-26 Jing Jin <jjin@apple.com> 21067 21068 Reviewed by Timothy Hatcher. 21069 21070 https://bugs.webkit.org/show_bug.cgi?id=35449 21071 Add ability to hide WebFrame scrollbars and to allow scrollbars to overlap with content. 21072 21073 * WebView/WebDynamicScrollBarsView.h: 21074 * WebView/WebDynamicScrollBarsView.mm: 21075 (-[WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]): Allows scrollbars to 21076 overlap with the document and re-layouts the document. 21077 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]): Hides the horizontal scrollbar. 21078 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]): Hides the vertical scrollbar. 21079 (-[WebDynamicScrollBarsView contentViewFrame]): Calculates the appropriate frame based 21080 on allowScrollersToOverlapContent. 21081 (-[WebDynamicScrollBarsView tile]): If allowScrollersToOverlapContent is YES, set the 21082 contentView's frame so it overlaps with the scrollbar. 21083 (-[WebDynamicScrollBarsView updateScrollers]): Take into account hideHorizontalScroller 21084 and hideVerticalScroller. 21085 (-[WebDynamicScrollBarsView reflectScrolledClipView:]): set drawsBackground to NO when 21086 scrollbars are overlapping with content, so we don't get trails during scrollbar draw updates. 21087 * WebView/WebDynamicScrollBarsViewInternal.h: 21088 * WebView/WebFrame.h: 21089 * WebView/WebFrame.mm: 21090 (-[WebFrame setAllowScrollersToOverlapContent:]): Hook for [WebDynamicScrollBarsView setAllowScrollersToOverlapContent:] 21091 (-[WebFrame setAlwaysHideHorizontalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:] 21092 (-[WebFrame setAlwaysHideVerticalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideVerticalScroller:] 21093 210942010-02-26 Gavin Barraclough <barraclough@apple.com> 21095 21096 Reviewed by Alexey Proskuryakov. 21097 21098 Bug 35401 - Fix handling of errors in handling calls over bridge, 21099 where base object bridge-type does not match method bridge-type. 21100 21101 The code assumes users will only attempt to invoke a Java method 21102 on a Java base object, etc. 21103 Add language specific subclasses of RuntimeMethod, and pass the 21104 RuntimeMethod into invokeMethod, so we can typecheck before 21105 casting. Throw an exception on type mismatch. 21106 21107 * Plugins/Hosted/ProxyInstance.h: 21108 * Plugins/Hosted/ProxyInstance.mm: 21109 (WebKit::PluginRuntimeMethod::PluginRuntimeMethod): new class to distinguish this type of RuntimeMethod. 21110 (WebKit::ProxyInstance::getMethod): create an appropriate sublclass of RuntimeMethod. 21111 (WebKit::ProxyInstance::invokeMethod): dynamically check the type of the RuntimeMethod. 21112 211132010-02-25 Alexey Proskuryakov <ap@apple.com> 21114 21115 Reviewed by Geoffrey Garen. 21116 21117 https://bugs.webkit.org/show_bug.cgi?id=35394 21118 <rdar://problem/7685262> Make passing objects between Java and plug-ins work 21119 21120 Added a ProxyInstance implementation of RuntimeObject. 21121 21122 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 21123 (WebKit::NetscapePluginInstanceProxy::addValueToArray): 21124 * Plugins/Hosted/ProxyInstance.h: 21125 * Plugins/Hosted/ProxyInstance.mm: 21126 (WebKit::ProxyInstance::newRuntimeObject): 21127 (WebKit::ProxyInstance::getClass): 21128 * Plugins/Hosted/ProxyRuntimeObject.h: Added. 21129 (WebKit::ProxyRuntimeObject::classInfo): 21130 * Plugins/Hosted/ProxyRuntimeObject.mm: Added. 21131 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject): 21132 (WebKit::ProxyRuntimeObject::~ProxyRuntimeObject): 21133 (WebKit::ProxyRuntimeObject::getInternalProxyInstance): 21134 211352010-02-24 Adam Barth <abarth@webkit.org> 21136 21137 Reviewed by Darin Fisher. 21138 21139 [Chromium API] Disambiguate allowJavaScript from didNotAllowScript 21140 https://bugs.webkit.org/show_bug.cgi?id=35205 21141 21142 Make these two callsites explicit about not running script immediately. 21143 21144 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 21145 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): 21146 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): 21147 211482010-02-23 Brady Eidson <beidson@apple.com> 21149 21150 Reviewed by Tim Hatcher and Pavel Feldman. 21151 21152 Regression (r55107) - WebInspector docking is busted. 21153 https://bugs.webkit.org/show_bug.cgi?id=35274 21154 21155 * WebCoreSupport/WebInspectorClient.mm: 21156 (-[WebInspectorWindowController showWindow:]): Swap the order of the "should attach?" check 21157 to get the expected behavior. 21158 211592010-02-23 Dan Bernstein <mitz@apple.com> 21160 21161 Reviewed by Simon Fraser. 21162 21163 <rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling 21164 https://bugs.webkit.org/show_bug.cgi?id=34381 21165 21166 Test: fast/repaint/repaint-during-scroll.html 21167 21168 NSClipView offsets any rects marked as needing display during scrolling 21169 by the scroll offset. Compensate for this when -setNeedsDisplay: is called 21170 during scrolling. 21171 21172 * WebView/WebHTMLView.mm: 21173 (-[WebHTMLView _frameOrBoundsChanged]): Set inScrollPositionChanged to YES 21174 around to call to FrameView::scrollPositionChanged(). 21175 (-[WebHTMLView setNeedsDisplayInRect:]): When called beneath 21176 scrollPositionChanged(), adjust the rect by the inverse of the scroll offset. 21177 211782010-02-23 Steve Block <steveblock@google.com> 21179 21180 Reviewed by Darin Adler. 21181 21182 Adds ChromeClient::cancelGeolocationPermissionRequestForFrame 21183 https://bugs.webkit.org/show_bug.cgi?id=34962 21184 21185 This method is required so that a Geolocation object can cancel an 21186 asynchronous permission request. This allows the chrome client to cancel 21187 any UI it is showing for the permission request. 21188 21189 * WebCoreSupport/WebChromeClient.h: 21190 (WebChromeClient::cancelGeolocationPermissionRequestForFrame): 21191 211922010-02-22 Alexey Proskuryakov <ap@apple.com> 21193 21194 Rubber-stamped by Geoff Garen. 21195 21196 Rename RuntimeObjectImp to RuntimeObject. 21197 21198 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 21199 (WebKit::NetscapePluginInstanceProxy::addValueToArray): 21200 (WebKit::NetscapePluginInstanceProxy::retainLocalObject): 21201 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): 21202 212032010-02-22 Brady Eidson <beidson@apple.com> 21204 21205 Reviewed by Tim Hatcher. 21206 21207 Disable WebView docking to views that are too small. 21208 <rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254 21209 21210 * WebCoreSupport/WebInspectorClient.mm: 21211 (-[WebInspectorWindowController showWindow:]): No matter the preference, don't open the inspector 21212 window attached if WebCore says it shouldn't be attached. 21213 212142010-02-22 Simon Fraser <simon.fraser@apple.com> 21215 21216 Reviewed by John Sullivan. 21217 21218 <rdar://problem/7285392> 21219 On Leopard, we have to disable hardware acceleration if we detect that the 21220 installed Core Video framework has bug <rdar://problem/7228836>. 21221 21222 * WebView/WebView.mm: 21223 (coreVideoHas7228836Fix): 21224 (-[WebView _preferencesChangedNotification:]): 21225 212262010-02-21 Dan Bernstein <mitz@apple.com> 21227 21228 Reviewed by Darin Adler. 21229 21230 False warnings about needing layout in 21231 -[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] 21232 https://bugs.webkit.org/show_bug.cgi?id=35218 21233 21234 * WebView/WebHTMLView.mm: 21235 (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): 21236 Suppress the warning and the forced layout if the view is not being drawn 21237 in this display operation. 21238 212392010-02-21 Kevin Decker <kdecker@apple.com> 21240 21241 Reviewed by Sam Weinig. 21242 21243 plugInViewWithArguments: API sends wrong parameter for WebPlugInBaseURLKey 21244 https://bugs.webkit.org/show_bug.cgi?id=35215 21245 <rdar://problem/7673157> 21246 21247 The plugInViewWithArguments: API passes a dictionary of plugin arguments. One of the parameters 21248 is WebPlugInBaseURLKey, which is a key that represents the base URL of the document containing 21249 the plug-in's view. Instead of sending the base URL, code in WebFrameLoaderClient::createPlugin 21250 would incorrectly pass the source URL of the plug-in resource. 21251 21252 * WebCoreSupport/WebFrameLoaderClient.mm: 21253 (WebFrameLoaderClient::createPlugin): When building the plug-in arguments dictionary, pass the 21254 real base URL for the WebPlugInBaseURLKey key. 21255 212562010-02-19 Maciej Stachowiak <mjs@apple.com> 21257 21258 Reviewed by David Levin. 21259 21260 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases 21261 https://bugs.webkit.org/show_bug.cgi?id=35147 21262 21263 * Configurations/FeatureDefines.xcconfig: 21264 212652010-02-19 Alexey Proskuryakov <ap@apple.com> 21266 21267 Reviewed by Maciej Stachowiak. 21268 21269 https://bugs.webkit.org/show_bug.cgi?id=35132 21270 <rdar://problem/7664353> Mouse cursor sometimes flickers over Flash content (35132) 21271 21272 * Plugins/WebNetscapePluginEventHandlerCarbon.mm: 21273 (WebNetscapePluginEventHandlerCarbon::mouseMoved): Send adjustCursor events on every mouse 21274 move. This matches Firefox, and is actually required for plug-ins to manipulate cursor wihout 21275 resorting to techniques such as fast firing timers. 21276 21277 * Plugins/WebNetscapePluginView.mm: 21278 (-[WebNetscapePluginView handleMouseEntered:]): Some plug-ins handle mouse cursor internally, 21279 but those that don't just need to get an arrow cursor (matching Firefox). This means that 21280 e.g. a plugin inside <A> won't get a finger mouse pointer. 21281 21282 * Plugins/WebHostedNetscapePluginView.mm: 21283 (-[WebNetscapePluginView handleMouseEntered:]): 21284 (-[WebNetscapePluginView handleMouseExited:]): 21285 Implement this behavior here, too. Also, out of process code didn't reset mouse pointer on 21286 mouse exit, which it needed to do. 21287 21288 * WebView/WebHTMLView.mm: 21289 (needsCursorRectsSupportAtPoint): 21290 (setCursor): 21291 (resetCursorRects): 21292 Make sure that the same workaround we have for Web content also applies to Netscape plug-ins, 21293 as AppKit would reset the mouse pointer to arrow if given a chance. 21294 (+[WebHTMLViewPrivate initialize]): Renamed setCursorIMP on Leopard and higher to prevent 21295 confusion - the method we override is completely different. 21296 (-[WebHTMLView hitTest:]): Added a FIXME about a likely bug. 21297 212982010-02-19 Simon Fraser <simon.fraser@apple.com> 21299 21300 Reviewed by Dan Bernstein. 21301 21302 <rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article 21303 21304 Followup to avoid capturing compositing layers twice in snapshots. Add private 21305 methods to WebView to specify whether drawing the WebView into an image will 21306 include flattened compositing layers (the default behavior) or not. 21307 21308 * WebView/WebFrame.mm: 21309 (-[WebFrame _drawRect:contentsOnly:]): Consult the WebView flag to see if we 21310 want flattening. 21311 21312 * WebView/WebViewPrivate.h: New methods. 21313 * WebView/WebView.mm: Ditto. 21314 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 21315 (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): 21316 (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): 21317 21318 * WebView/WebViewData.h: New member variable. 21319 213202010-02-19 Alexey Proskuryakov <ap@apple.com> 21321 21322 Reviewed by Dan Bernstein. 21323 21324 https://bugs.webkit.org/show_bug.cgi?id=35165 21325 plugins/set-status.html fails on Windows bot 21326 21327 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 21328 (WebKit::NetscapePluginInstanceProxy::status): 21329 * Plugins/WebNetscapePluginView.mm: 21330 (-[WebNetscapePluginView status:]): 21331 Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as 21332 empty ones to chrome. 21333 213342010-02-18 Simon Fraser <simon.fraser@apple.com> 21335 21336 Reviewed by Dan Bernstein. 21337 21338 <rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article 21339 21340 Add logic to determine when painting via the software rendering path will give an equivalent 21341 result to the accelerated compositing presentation. This tests for the presence of 3D transforms. 21342 21343 Also have -[WebFrame _drawRect:contentsOnly:] set the PaintBehaviorFlattenCompositingLayers 21344 paint behavior when painting into a bitmap context, so that snapshots contain composited layers. 21345 21346 * WebView/WebFrame.mm: 21347 (-[WebFrame _drawRect:contentsOnly:]): Set the PaintBehaviorFlattenCompositingLayers flag 21348 when painting into a bitmap context. 21349 * WebView/WebView.mm: 21350 (-[WebView _isSoftwareRenderable]): Returns YES if all frames can be software-rendered. 21351 * WebView/WebViewPrivate.h: New _isSoftwareRenderable method. 21352 213532010-02-18 Alexey Proskuryakov <ap@apple.com> 21354 21355 Reviewed by Dan Bernstein. 21356 21357 https://bugs.webkit.org/show_bug.cgi?id=35134 21358 <rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0) 21359 21360 Test: plugins/set-status.html 21361 21362 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 21363 (WebKit::NetscapePluginInstanceProxy::status): 21364 (WebKit::NetscapePluginInstanceProxy::loadURL): 21365 Added null checks for CFStringCreateWithCString arguments. 21366 213672010-02-17 Dmitry Titov <dimich@chromium.org> 21368 21369 Reviewed by David Levin, Darin Fisher, Simon Hausmann. 21370 21371 When a live iframe element is moved between pages, it still depends on the old page. 21372 https://bugs.webkit.org/show_bug.cgi?id=34382 21373 21374 * WebCoreSupport/WebFrameLoaderClient.h: 21375 * WebCoreSupport/WebFrameLoaderClient.mm: 21376 Added empty implementation of a new virtual method. 21377 21378 (WebFrameLoaderClient::didTransferChildFrameToNewDocument): 21379 213802010-02-17 Kent Tamura <tkent@chromium.org> 21381 21382 Reviewed by Eric Seidel. 21383 21384 Introduces new Icon loading interface in order to support 21385 asynchronous loading. 21386 https://bugs.webkit.org/show_bug.cgi?id=32054 21387 21388 Add an empty implementation of ChromeClient::iconForFiles(). 21389 21390 * WebCoreSupport/WebChromeClient.h: 21391 * WebCoreSupport/WebChromeClient.mm: 21392 (WebChromeClient::iconForFiles): 21393 213942010-02-17 Timothy Hatcher <timothy@apple.com> 21395 21396 Add a way for WebView and its dependancies to be selectively included 21397 in WebKitStatistics leak tracking. By default WebView is not included and 21398 you need to subclass WebView and implement +isIncludedInWebKitStatistics 21399 to be included. 21400 21401 rdar://problem/7567677&7572900 21402 https://webkit.org/b/35045 21403 21404 Reviewed by Adam Roben. 21405 21406 * WebView/WebDataSource.mm: 21407 (-[WebDataSource _initWithDocumentLoader:]): Increment WebDataSourceCount if the WebFrame is included in statistics. 21408 (-[WebDataSource dealloc]): Only --WebDataSourceCount if _private->includedInWebKitStatistics is YES. 21409 (-[WebDataSource finalize]): Ditto. 21410 * WebView/WebFrame.mm: 21411 (-[WebFrame _isIncludedInWebKitStatistics]): Return _private->includedInWebKitStatistics. 21412 (-[WebFrame _initWithWebFrameView:webView:]): Increment WebFrameCount if the WebView's class is included in statistics. 21413 (-[WebFrame dealloc]): Only --WebFrameCount if _private->includedInWebKitStatistics is YES. 21414 (-[WebFrame finalize]): Ditto. 21415 * WebView/WebFrameInternal.h: 21416 * WebView/WebFrameView.mm: 21417 (-[WebFrameView _setWebFrame:]): Increment WebFrameViewCount if the WebFrame is included in statistics. 21418 (-[WebFrameView initWithFrame:]): Move ++WebFrameViewCount from here since we don't 21419 know what WebFrame we belong to yet. 21420 (-[WebFrameView dealloc]): Only --WebFrameViewCount if _private->includedInWebKitStatistics is YES. 21421 (-[WebFrameView finalize]): Ditto. 21422 * WebView/WebHTMLRepresentation.mm: 21423 (-[WebHTMLRepresentation init]): Move ++WebHTMLRepresentationCount from here since we don't 21424 know what WebFrame we belong to yet. 21425 (-[WebHTMLRepresentation dealloc]): Only --WebHTMLRepresentationCount if _private->includedInWebKitStatistics is YES. 21426 (-[WebHTMLRepresentation finalize]): Ditto. 21427 (-[WebHTMLRepresentation setDataSource:]): Increment WebHTMLRepresentationCount if the WebFrame of the dataSource is 21428 included in statistics. 21429 * WebView/WebView.mm: 21430 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 21431 (-[WebView dealloc]): 21432 (+[WebView shouldIncludeInWebKitStatistics]): Return NO, so any WebView wont be included. 21433 Subclasses that care can return YES to be included. 21434 * WebView/WebViewInternal.h: 21435 214362010-02-16 Darin Adler <darin@apple.com> 21437 21438 Reviewed by Sam Weinig. 21439 21440 Generalize delayed plug-in start for background tabs for use for other media 21441 https://bugs.webkit.org/show_bug.cgi?id=34981 21442 21443 * WebView/WebHTMLView.mm: 21444 (-[WebHTMLView viewWillMoveToWindow:]): Added comment. 21445 (-[WebHTMLView viewDidMoveToWindow]): Ditto. 21446 21447 * WebView/WebView.mm: 21448 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 21449 Call setCanStartMedia right away so that if this view is not in a window, it 21450 will not start any media. 21451 (-[WebView viewWillMoveToWindow:]): Call setCanStartMedia(false) when moving 21452 to a window of nil. 21453 (-[WebView viewDidMoveToWindow]): Call setCanStartMedia(true) when moved to 21454 a window that is non-nil. 21455 214562010-02-16 Eric Carlson <eric.carlson@apple.com> 21457 21458 Reviewed by Simon Fraser. 21459 21460 https://bugs.webkit.org/show_bug.cgi?id=34988 21461 WebHTMLView.mm has two -willRemoveSubview: methods 21462 21463 * WebView/WebHTMLView.mm: 21464 (-[WebHTMLView willRemoveSubview:]): Consolidate the two copies of this method. 21465 214662010-02-16 Alexey Proskuryakov <ap@apple.com> 21467 21468 Reviewed by Geoffrey Garen and Kevin Decker. 21469 21470 https://bugs.webkit.org/show_bug.cgi?id=34989 21471 <rdar://problem/7417965> Cursor disappears on scroll bars that are over plugin content 21472 21473 This fixes event dispatch for both Cocoa and Carbon event models (mouseEntered/mouseExited 21474 in the former case, and adjustCursor in the latter). 21475 21476 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 21477 (-[WebHostedNetscapePluginView handleMouseEntered:]): 21478 (-[WebHostedNetscapePluginView handleMouseExited:]): 21479 * Plugins/WebBaseNetscapePluginView.h: 21480 * Plugins/WebBaseNetscapePluginView.mm: 21481 (-[WebBaseNetscapePluginView handleMouseEntered:]): 21482 (-[WebBaseNetscapePluginView handleMouseExited:]): 21483 * Plugins/WebNetscapePluginView.h: 21484 * Plugins/WebNetscapePluginView.mm: 21485 (-[WebNetscapePluginView handleMouseEntered:]): 21486 (-[WebNetscapePluginView handleMouseExited:]): 21487 AppKit cannot reliably dispatch events for overlapping views. We are now asking WebCore to 21488 notify plug-in views of mouse entered/exited as part of DOM event dispatch. 21489 21490 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Besides 21491 mouse moved, dispatch plugin mouse entered/exit events in HTMLPlugInElement default event 21492 handler. Other mouse events are passed down by EventHandler. 21493 214942010-02-15 Alexey Proskuryakov <ap@apple.com> 21495 21496 More build fixing (for what is actually a 64-bit failure, as 32-bit apparently includes 21497 headers that aren't included in 64-bit). 21498 21499 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 21500 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 21501 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::contains): 21502 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): 21503 Move inline functions to .cpp; also made the class Noncopyable. 21504 215052010-02-15 Alexey Proskuryakov <ap@apple.com> 21506 21507 Mac release build fix attempt. 21508 21509 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 21510 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 21511 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::~LocalObjectMap): 21512 Implement destructor in .cpp file, where necessary headers are already included. 21513 215142010-02-12 Alexey Proskuryakov <ap@apple.com> 21515 21516 Reviewed by Kevin Decker. 21517 21518 <rdar://problem/7130641> Browser objects identity is not preserved by Safari 21519 21520 Out of process part. 21521 21522 To avoid excessive IPC, plugin process doesn't send each NPObject release/retain call to 21523 Safari. It only sends one when the last one is removed, and it can destroy the proxy 21524 NPObject. 21525 21526 However, the browser may be sending the same object out to plug-in as a function call 21527 argument at the same time - neither side can know what the other one is up to. The solution 21528 is to make the "destroying object" call return a boolean result, making it possible for 21529 the browser to make plugin host keep the proxy with zero refcount for a little longer. 21530 21531 * Plugins/Hosted/NetscapePluginHostProxy.mm: 21532 (WKPCForgetBrowserObject): This function (that used to be named ReleaseObject) is only 21533 called when plug-in releases all of its references, so renamed it. Its boolean result 21534 is returned as call success or failure. 21535 21536 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 21537 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap): Made the numeric ID to JSObject map 21538 two-way. 21539 21540 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 21541 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): This method is tricky 21542 in that it creates objects with refcount of 1, but doesn't increase refcount when returning 21543 found objects. This extra count accounts for the "reference" kept by plugin process. 21544 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain): Only retaining for the 21545 duration of calls out to plug-in, which means that refcount is almost always equal to 1. 21546 Note that we can't use "++" here, due to how std::pair works! 21547 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release): Ditto. 21548 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::clear): Clear all references when 21549 stopping plug-in. 21550 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Like release(), but only 21551 functional when recount is 1 (meaning that the object is not being sent out to plug-in at 21552 the moment). 21553 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Updated for other changes. 21554 (WebKit::NetscapePluginInstanceProxy::cleanup): Ditto. 21555 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): Ditto. 21556 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject): Ditto. 21557 (WebKit::NetscapePluginInstanceProxy::forgetBrowserObjectID): Ditto. 21558 (WebKit::NetscapePluginInstanceProxy::evaluate): Ditto. 21559 (WebKit::NetscapePluginInstanceProxy::invoke): Ditto. 21560 (WebKit::NetscapePluginInstanceProxy::invokeDefault): Ditto. 21561 (WebKit::NetscapePluginInstanceProxy::construct): Ditto. 21562 (WebKit::NetscapePluginInstanceProxy::getProperty): Ditto. 21563 (WebKit::NetscapePluginInstanceProxy::setProperty): Ditto. 21564 (WebKit::NetscapePluginInstanceProxy::removeProperty): Ditto. 21565 (WebKit::NetscapePluginInstanceProxy::hasProperty): Ditto. 21566 (WebKit::NetscapePluginInstanceProxy::hasMethod): Ditto. 21567 (WebKit::NetscapePluginInstanceProxy::enumerate): Ditto. 21568 (WebKit::NetscapePluginInstanceProxy::addValueToArray): Ditto. 21569 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto. 21570 (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Helper for calling retain when 21571 making calls out to plug-in. No-op for objects that aren't wrapped to be sent (i.e. for 21572 objects wrapping ProxyInstance wrappers for plug-in objects being sent bak). 21573 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto. 21574 21575 * Plugins/Hosted/ProxyInstance.mm: 21576 (WebKit::ProxyInstance::invoke): Retain/release arguments during call. 21577 (WebKit::ProxyInstance::setFieldValue): Ditto. 21578 21579 * Plugins/Hosted/WebKitPluginClient.defs: Renamed PCReleaseObject to PCForgetBrowserObject. 21580 215812010-02-12 Darin Adler <darin@apple.com> 21582 21583 Reviewed by Sam Weinig. 21584 21585 Removed unneeded custom implementation of isDescendantOf. 21586 21587 * Plugins/WebBaseNetscapePluginView.mm: 21588 (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Use the 21589 -[NSView isDescendantOf:] method instead of our own method 21590 named superviewsHaveSuperviews. 21591 215922010-02-12 Dan Bernstein <mitz@apple.com> 21593 21594 Reviewed by Darin Adler. 21595 21596 <rdar://problem/7615234> REGRESSION (r48586): Loading an HTML page causes 21597 PDFKit to be loaded 21598 21599 * WebView/WebPDFDocumentExtras.h: Removed the category declaration and 21600 addWebPDFDocumentExtras(). Declare allScriptsInPDFDocument(). 21601 * WebView/WebPDFDocumentExtras.mm: 21602 (allScriptsInPDFDocument): Changed the -_web_allScripts method into this function. 21603 * WebView/WebPDFRepresentation.mm: Removed +initialize. 21604 (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use 21605 allScriptsInPDFDocument() instead of -_web_allScripts. 21606 216072010-02-10 Geoffrey Garen <ggaren@apple.com> 21608 21609 Reviewed by Oliver Hunt. 21610 21611 Exported some new JavaScript heap introspection. 21612 21613 * Misc/WebCoreStatistics.h: 21614 * Misc/WebCoreStatistics.mm: 21615 (+[WebCoreStatistics javaScriptObjectTypeCounts]): Just like 21616 javaScriptProtectedObjectTypeCounts, except this function enumerates all 21617 live objects, not just protected objects. 21618 216192010-02-08 Maciej Stachowiak <mjs@apple.com> 21620 21621 Reviewed by Cameron Zwarich. 21622 21623 Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose. 21624 https://bugs.webkit.org/show_bug.cgi?id=34698 21625 21626 * Configurations/FeatureDefines.xcconfig: 21627 216282010-02-09 Alexey Proskuryakov <ap@apple.com> 21629 21630 Reviewed by Geoffrey Garen. 21631 21632 https://bugs.webkit.org/show_bug.cgi?id=34490 21633 WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain conditions 21634 21635 * ForwardingHeaders/wtf/ValueCheck.h: Added. 21636 216372010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 21638 21639 Reviewed by Kenneth Rohde Christiansen. 21640 21641 Support frameset flattening 21642 https://bugs.webkit.org/show_bug.cgi?id=32717 21643 21644 Add support for enabling/disabling FrameSet Flattening on the Mac port. 21645 21646 * WebView/WebPreferenceKeysPrivate.h: 21647 * WebView/WebPreferences.mm: 21648 (+[WebPreferences initialize]): 21649 (-[WebPreferences isFrameSetFlatteningEnabled]): 21650 (-[WebPreferences setFrameSetFlatteningEnabled:]): 21651 * WebView/WebPreferencesPrivate.h: 21652 * WebView/WebView.mm: 21653 (-[WebView _preferencesChangedNotification:]): 21654 216552010-02-09 Alexey Proskuryakov <ap@apple.com> 21656 21657 Reviewed by Anders Carlsson. 21658 21659 https://bugs.webkit.org/show_bug.cgi?id=34771 21660 A stray mouse moved event is sent to plug-ins after mouse exit 21661 21662 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): A mouseout 21663 DOM event is dispatched while handling NSMouseMoved - but we shouldn't be sending a 21664 mouse moved event to plug-ins at this point. 21665 216662010-02-09 Shinichiro Hamaji <hamaji@chromium.org> 21667 21668 Reviewed by Darin Adler. 21669 21670 Provide a way to get total number of pages to be printed 21671 https://bugs.webkit.org/show_bug.cgi?id=34699 21672 21673 * Misc/WebCoreStatistics.h: 21674 * Misc/WebCoreStatistics.mm: 21675 (-[WebFrame numberOfPages:pageWidthInPixels:]): 21676 216772010-02-08 Alexey Proskuryakov <ap@apple.com> 21678 21679 Reviewed by Darin Adler. 21680 21681 https://bugs.webkit.org/show_bug.cgi?id=34727 21682 Assertion crashes and freezes when plug-in property access results in an exception 21683 21684 * Plugins/Hosted/WebKitPluginClient.defs: Made PCSetProperty and PCRemoveProperty async. 21685 A plug-in can call back whil processing this call (e.g. for NPN_SetException), so we need 21686 to listen for messages while waiting for reply. 21687 21688 * Plugins/Hosted/NetscapePluginHostProxy.mm: 21689 (WKPCEvaluate): If there is no instance proxy, return KERN_FAILURE. This improves consistency 21690 between method implementations, and leaves us with one less IPC call to make in failure case 21691 (returning false with KERN_SUCCESS and returning KERN_FAILURE looks the same from plugin 21692 host code). 21693 (WKPCInvoke): Ditto. 21694 (WKPCInvokeDefault): Ditto. 21695 (WKPCGetProperty): Ditto. 21696 (WKPCSetProperty): Send a reply once done. 21697 (WKPCRemoveProperty): Ditto. 21698 (WKPCHasProperty): If there is no instance proxy, return KERN_FAILURE. 21699 (WKPCHasMethod): Ditto. 21700 (WKPCEnumerate): Ditto. 21701 217022010-02-08 Alexey Proskuryakov <ap@apple.com> 21703 21704 Reviewed by Anders Carlsson. 21705 21706 <rdar://problem/6530010> OOP: Support NPN_SetException 21707 21708 Tested by plugins/netscape-throw-exception.html (removed it from skipped list). 21709 21710 * Plugins/Hosted/NetscapePluginHostProxy.mm: 21711 (WKPCSetException): 21712 * Plugins/Hosted/NetscapePluginInstanceProxy.h: 21713 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 21714 (WebKit::globalExceptionString): 21715 (WebKit::NetscapePluginInstanceProxy::setGlobalException): 21716 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState): 21717 * Plugins/Hosted/ProxyInstance.mm: 21718 (WebKit::ProxyInstance::invoke): 21719 (WebKit::ProxyInstance::getPropertyNames): 21720 (WebKit::ProxyInstance::fieldValue): 21721 (WebKit::ProxyInstance::setFieldValue): 21722 * Plugins/Hosted/WebKitPluginClient.defs: 21723 Route exception string to a global that's checked after calling into plug-in (just like in 21724 in-process case). 21725 217262010-02-05 Kevin Decker <kdecker@apple.com> 21727 21728 Reviewed by Mark Rowe. 21729 21730 https://bugs.webkit.org/show_bug.cgi?id=34661 21731 <rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden 21732 21733 * Plugins/Hosted/WebHostedNetscapePluginView.mm: 21734 (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect. 21735 * Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class. 21736 * Plugins/WebBaseNetscapePluginView.mm: 21737 (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView. 21738 (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView. 21739 * Plugins/WebNetscapePluginView.mm: 21740 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect. 21741 217422010-02-04 Mark Rowe <mrowe@apple.com> 21743 21744 Rubber-stamped by Dan Bernstein. 21745 21746 Fix the ability to #include <WebKit/DOMFile.h>. 21747 21748 * MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it. 21749 217502010-02-04 John Sullivan <sullivan@apple.com> 21751 21752 https://bugs.webkit.org/show_bug.cgi?id=34611 21753 WebLocalizedString() could use an assertion that it is being called on the main thread 21754 21755 Reviewed by Tim Hatcher. 21756 21757 * Misc/WebLocalizableStrings.m: Removed. 21758 * Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m. 21759 Renamed to use .mm extension so it can include a C++ header. 21760 (WebLocalizedString): 21761 Added an assertion that this is being called on the main thread. 21762 217632010-02-04 Dan Bernstein <mitz@apple.com> 21764 21765 Reviewed by Simon Fraser. 21766 21767 REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big 21768 https://bugs.webkit.org/show_bug.cgi?id=34371 21769 21770 * WebView/WebFrameView.mm: 21771 (-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of 21772 constants, and cap the scroll distance. 21773 (-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of 21774 cScrollbarPixelsPerLineStep. 21775 (-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of 21776 constants, and cap the scroll distance. 21777 217782010-02-01 Shinichiro Hamaji <hamaji@chromium.org> 21779 21780 Reviewed by Eric Seidel. 21781 21782 Provide a way to get page number with layoutTestController 21783 https://bugs.webkit.org/show_bug.cgi?id=33840 21784 21785 * Misc/WebCoreStatistics.h: 21786 * Misc/WebCoreStatistics.mm: 21787 (-[WebFrame pageNumberForElement:element:pageWidth:]): 21788 217892010-01-29 Gavin Barraclough <barraclough@apple.com> 21790 21791 Reviewed by Sam Weinig + Oliver Hunt. 21792 21793 Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds 21794 21795 Pass processeing user gensture flag to media play/pause methods. 21796 21797 * WebView/WebVideoFullscreenHUDWindowController.mm: 21798 (-[WebVideoFullscreenHUDWindowController setPlaying:]): 21799 218002010-02-01 Dan Bernstein <mitz@apple.com> 21801 21802 Reviewed by Anders Carlsson. 21803 21804 <rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse() 21805 21806 The crash was caused by having two streams with a streamID of 1. 21807 21808 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: 21809 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now 21810 correctly increments m_currentURLRequestID to account for the manual stream. 21811 (WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream, 21812 null it out instead of trying to remove it from the map. Added an assertion. 21813 (WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion. 21814 21815== Rolled over to ChangeLog-2010-01-29 == 21816