History log of /seL4-camkes-master/projects/musllibc/src/ipc/semctl.c
Revision Date Author Comments
# 2b47a7af 13-Mar-2014 rofl0r <retnyg@gmx.net>

semctl: fix UB causing crashes on powerpc

it's UB to fetch variadic args when none are passed, and this caused
real crashes on ppc due to its calling convention, which defines that
for variadic functions aggregate types be passed as pointers.
the assignment caused that pointer to get dereferenced, resulting in
a crash.


# 8e776e3e 08-Jan-2014 Rich Felker <dalias@aerifal.cx>

fix inadvertent use of struct in place of union for semun


# 28929422 08-Jan-2014 Rich Felker <dalias@aerifal.cx>

fix type of semctl variadic argument

per POSIX, the variadic argument has type union semun, which may
contain a pointer or int; the type read depends on the command being
issued. this allows the userspace part of the implementation to be
type-correct without requiring special-casing for different commands.
the kernel always expects to receive the argument interpreted as
unsigned long (or equivalently, a pointer), and does its own handling
of extracting the int portion from the representation, as needed.

this change fixes two possible issues: most immediately, reading the
argument as a (signed) long and passing it to the syscall would
perform incorrect sign-extension of pointers on the upcoming x32
target. the other possible issue is that some archs may use different
(user-space) argument-passing convention for unions, preventing va_arg
from correctly obtaining the argument when the type long (or even
unsigned long or void *) is passed to it.


# cccc1322 22-Sep-2012 Rich Felker <dalias@aerifal.cx>

fix IPC_64 in msgctl too


# fce46bf9 22-Sep-2012 Rich Felker <dalias@aerifal.cx>

fix broken semctl on systems that don't use IPC_64 flag

not tested on mips and arm; they may still be broken. x86_64 should be
ok now.


# 07e865cc 13-Apr-2011 Rich Felker <dalias@aerifal.cx>

numerous fixes to sysv ipc

some of these definitions were just plain wrong, others based on
outdated ancient "non-64" versions of the kernel interface.

as much as possible has now been moved out of bits/*

these changes break abi (the old abi for these functions was wrong),
but since they were not working anyway it can hardly matter.


# c2cd25bf 06-Apr-2011 Rich Felker <dalias@aerifal.cx>

consistency: change all remaining syscalls to use SYS_ rather than __NR_ prefix


# aa398f56 19-Mar-2011 Rich Felker <dalias@aerifal.cx>

global cleanup to use the new syscall interface


# 0b44a031 11-Feb-2011 Rich Felker <dalias@aerifal.cx>

initial check-in, version 0.5.0