fix implicit cast warnings in IAR and others

See bug #54190

Signed-off-by: Simon Goldschmidt <goldsimon@gmx.de>

Fix annotation in function documentation

clang failed to build:

../../../../lwip/src/include/lwip/tcp.h:180:11: error: parameter 'ERR_OK' not found in the function declaration [-Werror,-Wdocumentation]
* @param ERR_OK if OK, any error if connection should be dropped
^~~~~~

tcp: introduce ext_args per pcb

This introduces the concept of ext (external/extended) arguments per
tcp_pcb (also for listening pcbs) to store more data than just one
"void *arg" per pcb. The "arg" is for use to applications, whereas
the ext_args may be used by frameworks and leave "arg" untouched.

In addition to a void pointer, callbacks are added to help frameworks
migrate arguments from listen pcb to connection pcb and to free args
when the pcb is freed.

Signed-off-by: goldsimon <goldsimon@gmx.de>

-Wconversion (still far from finished) and other minor compilation fixes...

Fixed LWIP_TCP_SACK_VALID and its usage

Cleaned up a bit after merging SACK_OUT support (mostly coding style)

Partial SACK (RFC 2018) support

Adds partial support for selective acknowledgements (RFC 2018).
This change makes lwIP negotiate SACK support, and include SACK
data in outgoing empty ACK packets. It does not include it
in outgoing packets with data payload.
It also does not add support for handling incoming SACKs.

Signed-off-by: goldsimon <goldsimon@gmx.de>

work on -Wconversion...

tcp: switch tcpflags_t to u16_t for all cases (bug #51326)

This changes tcpflags_t to be a u16_t for all cases. The TCP Appropriate
Byte Count support added a new flag that used a bit past 8 and since this
flag is now required, tcpflags_t can no longer be a u8_t

This does not increase the size of struct tcp_pcb due to padding that
already existed (see bug #51326 for details)

Signed-off-by: goldsimon <goldsimon@gmx.de>

Fix unused arg from last patch the *real* lwIP way ;-)

Fix unused arg from last patch the lwIP way

Silence some unsed variable warnings.

tcp: fix cwnd rollover introduced by ABC

Changes for TCP Appropriate Byte Counting introduce a potential cwnd
rollover by not taking into account integer promotion on tcpwnd_size_t
during inequality comparisions

This fixes the issue by introducing a macro TCP_WND_INC which detects
the rollover correctly and now holds the tcpwnd_size_t at the maximum
value rather than not incrementing the window. This provides a slight
performance improvement by allowing full use of the tcpwnd_size_t number
space for the congestion window

bug #50837: add zero-window probe timeout

This commit adds a timeout to the zero-window probing (persist timer)
mechanism. LwIP has not historically had a timeout for the persist
timer, leading to unbounded blocking if connection drops during the
zero-window condition

This commit also adds two units test, one to check the RTO timeout
and a second to check the zero-window probe timeout

Start working task #14494: Implement SO_BINDTODEVICE
Implement binding TCP, UDP and RAW PCBs to a netif

tcp: task #14128 - Appropriate Byte Counting support

This commit adds TCP Appropriate Byte Counting (ABC) support based on
RFC 3465

ABC replaces the previous congestion window growth mechanism and has been
configured with limit of 2 SMSS. See task #14128 for discussion on
defaults, but the goal is to mitigate the performance impact of delayed
ACKs on congestion window growth

This commit also introduces a mechanism to track when the stack is
undergoing a period following an RTO where data is being retransmitted.

Lastly, this adds a unit test to verify RTO period tracking and some
basic ABC cwnd checking

Improve TCP documentation a bit

altcp: added 'addrinfo' and 'tcp_state' functions

tcp: move some higher level definitions from tcp.h to new file tcpbase.h (in preparation for altcp API)

Fixed bug #47485 (tcp_close() should not fail on memory error) by retrying to send FIN from tcp_fasttmr

added function tcp_listen_with_backlog_and_err() to get the error reason when listening fails (bug #49861)

Improve LWIP_EVENT_API compilation

Add some more TCP RAW API functions to documentation

Some more RAW API documentation updates
Improve structure of documentation: PPP is now a module, too

Add some of the .txt files in /doc subdir to doxygen documentation

change tcp_pcb->acked to be a global variable: used in one call stack only (idea by Ambroz Bizjak)

doxygen updates - include IPv6 in documentation. Exclude include/netif/ppp/polarssl.
Convert TODO -> @todo

Include all lwIP files in doxygen documentation

Fixed possible problems with tcp_backlog_delayed/tcp_backlog_accepted

... and another compiler error: tcp_nagle_enable() must stay at tcpflags_t, not using u16_t

fixed wrong commit: compatibility-define tcp_accepted() was accidentally commented-out

tcp: changed accept handling to be done internally: the application does not have to call tcp_accepted() any more. Instead, when delaying accept (e.g. sockets do), call tcp_backlog_delayed()/tcp_backlog_accepted() (fixes bug #46696)

define tcp_backlog_set() as dummy-define when backlog feature is disable

Add compatibility macro for tcp_new_ip6()

TCP: Implement dual stack support using new IP_ANY_TYPE introduced at UDP

Allow backlog to be updated

This commit adds support to the sockets and netconn layer to update the
backlog by calling listen when the netconn is already in the listen state.
When backlog is not enabled, the call returns successfully

This commit also introduces a macro for setting the backlog value that
prevents a 0 sized (invalid) backlog

Update snd_queuelen comment documentation

This commit updates the snd_queuelen comment documentation to reflect
that snd_queuelen tracks the number of pbufs currently in the send
buffer (unsent + unacked queues) rather than the number of pbufs
available in the buffer (which was what previous comment implied)

minor/coding style: removed spaces before line ending (from file header)

minor/coding style: removed spaces before line ending

fixed bug #45559: Window scaling casts u32_t to u16_t without checks

Fixed compiler warning when window scaling is enabled (tcp_sndbuf() should still return u16_t since that value can directly be passed to tcp_write())

... and one more change to those nasty ~ operator warnings :-(

Fixed ~ warnings in a different way

Fixed warnings about NULL check not required (ip_addr_isany) and implicit conversion (~)

task #12722 (improve IPv4/v6 address handling): renamed ip_addr_t to ip4_addr_t, renamed ipX_addr_t to ip_addr_t and added IP version;
ip_addr_t is used for all generic IP addresses for the API, ip(4/6)_addr_t are only used internally or when initializing netifs or when calling version-related functions

(api break) qualify ip_addr_t as const where feasible

this changes the callback signatures of the ip_output and the
{udp,raw}_recv functions.

changes were made by going through all header files, searching for
occurrences of ip_addr_t, qualifying them as const and if required
modifying the corresponding c files, looking for other uses of ip_addr_t
that would be required.

the following header files were not treated as i'm not using them and
wouldn't see them compiled: api.h api_msg.h dhcp.h dns.h igmp.h
netifapi.h pppapi.h snmp.h snmp_msg.h snmp_structs.h ppp.h pppol2tp.h
test/*

no modifications were done on ip6_addr_t.

Parts of patch #8397 Typos corrected in comments and text outputs

Fix warning for compilers propagating ~'ed u8_t to int...

bug #35874 reserved identifier violation, 2nd part

Fixed bug #35874 reserved identifier violation (removed leading underscores from header include guards)

TCP window scaling: change tcp_pcb::acked to u32_t when window scaling is enabled to prevent an overflow when more than 64 Kbytes are ACKed

patch #6537/#7858: TCP window scaling support (OOS queueing still needs special handling)

fixed bug #38701 (wrong comment on tcp_pcb::snd_queuelen

partly fixed bug #25882: TCP hangs on MSS > pcb->snd_wnd (by not creating segments bigger than half the window)

tcp pcb: persist_cnt can be u8_t instead of u32_t (since it is compared against u8_t only)

fixed bug #31177: tcp timers can corrupt tcp_active_pcbs in some cases

Fixed tcp_accepted define (need brackets around the parameter)

Slightly reorderd fields of struct tcp_pcb to plug holes introduced by member alignment (to reduce RAM usage)

Cleaned up usage of sys.h a bit

Minor edits for for IPv6 compilation

Combined IPv4 and IPv6 code where possible, added defines to access IPv4/IPv6 in non-IP code so that the code is more readable.

... and finally, we got a first working version of a dual-stack lwIP runnin IPv4 and IPv6 in parallel - big thanks to Ivan Delamer! (this is work in progress, so please beware, test a lot and report problems!)

Added missing U/UL modifiers to fix 16-bit-arch portability.

Fix calculation of tcp_mss(): when timestamps are on, this is pcb->mss - 12 or else NOCOPY-apps might generate unperformant PBUF_REF chains

tcp_accepted(): check pcb state to verify it isn't called on a connection-pcb

task #7040 (Work on tcp_enqueue): Don't waste memory when chaining segments, added option TCP_OVERSIZE to prevent creating many small pbufs when calling tcp_write with many small blocks of data. Instead, pbufs are allocated larger than needed and the space is used for later calls to tcp_write.

Moved stack-internal parts of tcp.h to tcp_impl.h, tcp.h now only contains the actual application programmer's API

Task #10088: Correctly implement close() vs. shutdown(). Now the application does not get any more recv callbacks after calling tcp_close(). Added tcp_shutdown().

Fixed pcb leak when accept-callback is NULL and asserts are disabled

Restructured TCP_PCB_COMMON for a smaller size (u16_t at the end)

tcp_seg(s)_free: remove return value, noone uses it

patch #6865: use so_options SOF_REUSEADDR instead of flags TF_REUSEADDR (which has ben removed again)

patch #6865 (SO_REUSEADDR for TCP): if tcp_pcb.flags has TF_REUSEADDR set, allow binding to endpoint in TIME_WAIT

Replaced struct ip_addr by typedef ip_addr_t to make changing the actual implementation behind the typedef easier.

Added TCP_SNDQUEUELOWAT corresponding to TCP_SNDLOWAT and added tcp_sndqueuelen() - this fixes bug #28605

Fixed bug #27871: Calling tcp_abort() in recv callback can lead to accessing unallocated memory. As a consequence, ERR_ABRT means the application has called tcp_abort()!

Using typedefs for function prototypes and -pointers throughout the stack for clarity

bug #28127: remove call to tcp_output() from tcp_ack(_now)()

Call tcp_timer_needed() with NO_SYS==1, too

Remove warning for TCP_LISTEN_BACKLOG==0

Fixed bug #28106: dup ack for fast retransmit could have non-zero length

Fixed bug #28098: Nagle can prevent fast retransmit from sending segment by basing the nagle-decision on TF_INFR also

Got the tcp_nagle_*() defines wrong (inverted) :-(

Fixed bug #28099 (API required to disable Nagle algorithm at PCB level): added tcp_nagele_*() function-like macros

Fixed bug #27851 (TCP_EVENT_RECV(pcb, NULL,...) results in unreachable code warning) by calling tcp_recv_null if pcb->recv is null.

re-work the fast retransmission code to follow algorithm from TCP/IP
Illustrated

bug-fix in the TCP_EVENT_RECV macro (has to call tcp_recved if pcb->recv is NULL to keep rcv_wnd correct)

patch #6930: [PATCH trivial] TCP_RMV remove unnecessary check - removed two checks for NULL which are not necessary.

Make tcp_debug_state_str() always available, not only in DEBUG mode

patch #6843: tcp.h macro optimization patch (for little endian)

Added function tcp_debug_state_str() to convert a tcp state to a human-readable string.

BUG26879: set ret value in TCP_EVENT_ macros when function is not set

BUG26301 and BUG26267: correct simultaneous close behaviour, and make
snd_nxt have the same meaning as in the RFCs.

Fixed bug #26349: Nagle algorithm doesn't send although segment is full (and unsent->next == NULL)

Patch#6802 Add do-while-clauses to those function like macros in tcp.h

BUG20515: rework way TCP window updates are calculated and sent

TASK9218: add support for TCP timestamp options

BUG25622: handle return code of tcp_enqueue in tcp_listen_input()

fixed bug #24440: TCP connection close problem on 64-bit host by moving accept callback function pointer to TCP_PCB_COMMON

patch #6699: fixed some warnings on platform where sizeof(int) == 2

Fix incorrect units in comment for TCP_MSL. Allow override.

tcp.c, tcp_in.c, tcp.h, opt.h: Rename LWIP_CALCULATE_EFF_SEND_MSS in TCP_CALCULATE_EFF_SEND_MSS to have coherent TCP options names.

rawapi.txt, api_msg.c, tcp.c, tcp_in.c, tcp.h: changes for task #7675 "Enable to refuse data on a TCP_EVENT_RECV call". Important, behavior changes for the tcp_recv callback (see rawapi.txt).

rawapi.txt, api.h, api_lib.c, api_msg.h, api_msg.c, sockets.c, tcp.h, tcp.c, tcp_in.c, init.c, opt.h: rename backlog options with TCP_ prefix, limit the "backlog" parameter in an u8_t, 0 is interpreted as "smallest queue", add documentation in the rawapi.txt file.

Add persist timer

tcp.h, opt.h, api.h, api_msg.h, tcp.c, tcp_in.c, api_lib.c, api_msg.c, sockets.c, init.c: task #7252: Implement TCP listen backlog: Warning: raw API applications have to call 'tcp_accepted(pcb)' in their accept callback to keep accepting new connections.

2007-12-20 Kieran Mansley (based on patch from Per-Henrik Lundbolm)
* tcp.c, tcp_in.c, tcp_out.c, tcp.h: fix bug #20199 (better handling
of silly window avoidance and prevent lwIP from shrinking the window)

Implemented calculating the effective send-mss based on the MTU of the netif used to send. Enabled by default. Disable by setting LWIP_CALCULATE_EFF_SEND_MSS to 0. This fixes bug #21535.

Fixed bug #20287: tcp_output_nagle sends too early. This fixes the nagle algorithm; nagle now also works for all raw API applications and has to be explicitly disabled with 'tcp_pcb->flags |= TF_NODELAY'

Minor change, add comment for "apiflags" parameters.

sockets.h, sockets.c, api.h, api_lib.c, api_msg.h, api_msg.c, tcp.h, tcp_out.c: Integrate "patch #6250 : MSG_MORE flag for send". MSG_MORE is used at socket api layer, NETCONN_MORE at netconn api layer, and TCP_WRITE_FLAG_MORE at raw api layer. This option enable to delayed TCP PUSH flag on multiple "write" calls. Note that previous "copy" parameter for "write" APIs is now called "apiflags".

Fixed bug #21491: The MSS option sent (with SYN) is now based on TCP_MSS instead of pcb->mss (on passive open now effectively sending our configured TCP_MSS instead of the one received).

Changed initialization: many init functions are not needed any more since we now rely on the compiler initializing global and static variables to zero!

Indentation fix

sockets.c, ip.h, api.h, tcp.h: declare a "struct ip_pcb" which only contains IP_PCB. Add in the netconn's "pcb" union a "struct ip_pcb *ip;" (no size change). Use this new field to access to common pcb fields (ttl, tos, so_options, etc...). Enable to access to these fields with LWIP_TCP=0.

Minor changes (but in lot of files): add #if/#endif for options where they could miss. #if LWIP_xxx if always put after #include "lwip/opt.h" (note this one indirectly include cc.h). Move others includes inside #if/#endif block.

Last sanity checking centralization for "task #7142 : Sanity check user-configurable values".

Added some ASSERTS and casts to prevent warnings when assigning to smaller types.

Changed tcp_pcb->snd_queuelen from u8_t to u16_t to prevent overflowing when sending many small packets with big send buffer, added assertions and oveflow checks for snd_queuelen.

Fixed bug #20287: Fixed nagle algorithm (sending was done too early if a segment contained chained pbufs)

Moved the nagle algorithm from netconn_write/do_write into a define (tcp_output_nagle) in tcp.h to provide it to raw api users, too.

Added comments for the callback functions included in struct tcp_listen_pcb

Added comments for the callback functions included in structs tcp_pcb, udp_pcb and raw_pcb.

Fixed a cast warning by including the type to TCP_PCB_COMMON: (Moved members common to structures tcp_pcp and tcp_listen_pcb into define TCP_PCB_COMMON (like IP_PCB) to keep (possible) code changes consistent.)

Moved members common to structures tcp_pcp and tcp_listen_pcb into define TCP_PCB_COMMON (like IP_PCB) to keep (possible) code changes consistent.

Added comments whether fields are host or network byte order (task #1568)

Fixed bug from patch #5865 by moving the defines for socket options (lwip_set/-getsockopt) used with level IPPROTO_TCP from tcp.h to sockets.h.

Included patch #5448: include '#ifdef __cplusplus \ extern "C" {' in all header files. Now you can write your application using the lwIP stack in C++ and simply #include the core files. Note I have left out the netif/ppp/*h header files for now, since I don't know which files are included by applications and which are for internal use only.

* tcp.c, tcp_in.c, tcp_out.c, tcp.h: Modify way the retransmission
timer is reset to fix bug#19434, with help from Oleg Tyshev.

Apply patch #5745: Fix "Constant is long" warnings with 16bit
compilers. Contributed by avatar@mmlab.cse.yzu.edu.tw

Keepalive values can be configured at run time with LWIP_TCP_KEEPALIVE, but don't change this unless you know what you're doing (default are RFC1122 compliant). Note that TCP_KEEPIDLE and TCP_KEEPINTVL have to be set in seconds.

Old TCP_KEEPALIVE can always be used, and its only difference with TCP_KEEPIDLE is this last use seconds and not milliseconds with setsockopt.

Some documentation (not perfect, but...):

http://publib.boulder.ibm.com/infocenter/pseries/v5r3/index.jsp?topic=/com.ibm.aix.commtechref/doc/commtrf2/setsockopt.htm

Keepalive values can be configured at compile time, but don't change this unless you know what you're doing (default are RFC1122 compliant).

Replaced tabs with space.

Partially accepted patch #5449 for ANSI C compatibility / build fixes. Fixed bug #17574 corrected UDP-Lite protocol identifier.

Introduced cc.h formatters and removed SO_REUSE from transport layers.

Added inline source documentation.

Kieran Mansley - kjm25@cam.ac.uk - 24th Nov 2004
* Changed pcb->rttest from u16_t to u32_t - comparisons with tcp_ticks (which is u32_t) were failing after 9 hours of operation

Reverted back the TCP_BETWEEN macro. It does not work on all archs.

Kieran Mansley - kjm25@cam.ac.uk - 12th September 2004

Applied patch from Sam Jansen as detailed in
http://lists.gnu.org/archive/html/lwip-users/2004-07/msg00106.html
to correctly handle retransmission after a retransmission timeout

Add TCP_SEQ_BETWEEN macro for comparing a range of sequence numbers

Do no longer try to free pbuf when TCP_EVENT_RECV() is called without a callback handler, and without packet.
The standard HTTP server failed on this (as reported by three users).

Re-instantiated the pack directives. Nested structs do break individual field natural alignment on arm-gcc.

Removed all structure packing directives. Protocol header fields are naturally aligned by design.
(Earlier, the 14-byte ethernet header screwed this up, this had already been fixed by adding two pad bytes.)
Assumption is that compilers do not align with larger-than-sizeof(type) boundaries.
Pre-tag PRE_PACK_REMOVE. Post-tag POST_TAG_REMOVE.

only include sys.h once. Noted by Tom Barker

Updated some copyright notices to include 2004 (a few were forgotten earlier).

Applied alias.diff by Ian Wienand on lwip-devel on February 4th 2004.
Using union to make explicit either tcp_listen_pcb or tcp_pcb.

Merged from DEVEL into main tree.

Changed DEBUGF to LWIP_DEBUGF

Replaced all tabs with two spaces (regardless of indentation is correct).

patches 1492, 1493 and 1494 from Marc

Fixed tabs into spaces. Fixed other stylos.

add tcpip_callback patch from Marc

byte-order handling functions are in inet.c now and the uperrcase counterparts are gone. opt.h has all the
configurable items debug does not need to be directly included.

Allow minimal unix target to build in cygwin (but not necessarily run).

Applied a patch from Marc Boucher which has the following changes:

1) Fixed sys_arch.txt documentation to have new return type from
sys_thread_new.

2) Removed unnecessary casts on calling sys_timeout() in certain files.

3) Removed some unnecessary break statements after return statements.

4) Changed sys_timeout_remove() to sys_untimeout().

5) Added some forgotten #ifndef SYS_LIGHTWEIGHT_PROT to memp.c

6) Changed LWIP_DIAG and LWIP_PLATFORM_ASSERT to have do while().

tcp_timer_needed should be a noop when using the raw API.Fix link error bug #2489

Add the following features and bugfixes:

Added select() functionality to sockets library.
Support for errno in sockets library.
Byte ordering fixes.
basic lwip_ioctl(), FIONREAD, get/setsockopt() etc. support

- added additional argument to netif_add to pass state pointer so that the
if_init function has access to context information before
the interface is added, without accessing globals.

- added netif_remove()

- to conserve cpu load the tcpip_tcp_timer should only be active
when tcbs that need it exist.

- pass length of available data to callbacks for NETCONN_EVT_RCV events

- added tcpip_link_input(), a hack to allow processing of PPP
packets in tcpip_thread() context. This saves threads and context
switches.

- renamed incompatible ASSERT() macro to LWIP_ASSERT() to avoid name
collision.

- changed a bunch of %d's to %u's in format strings for unsigned values.

- added ip_frag to lwip_stats.

- changed IP_REASS_MAXAGE and IP_REASS_TMO defaults to more realistic
values.

- added sys_timeout_remove() function to cancel timeouts (needed by PPP
amongst other things).

- tolerate NULL returns from sys_arch_timeouts() since some threads might
not need to use or have timeouts.

- added sys_sem_wait_timeout()

- moved mem_malloc() function to end of mem.c to work around tasking
compiler bug.

- automatically bind to local tcp port if 0.

- allow customization of port ranges for automatic local bindings.

- corrected various typos, spelling errors, etc..

Thanks to Marc Boucher for many of these changes.

put a state field in listen PCBs to since they are often treated as normal pcbs. patch #922, bug #2114

Free incoming pbuf's in the TCP event macro if the recv callback is NULL. Fixes bug #2156.

make rtime field u16_t like rto otherwise it won't catch rto if that goes beyond 255.When that happens there's trouble already since 255 ticks is over 2 minutes but still...

Merged patch #927 which fixes "needs modifiable lvalue" compile error in TCP_REG.

Updated lwIP module copyright years to include 2003. Committers must check theirs.

Make tmr in tcp_pcb u32_t to ensure it wraps at the same time as tcp_ticks (Bug #1838)

Surrounded all #include's for packed structs with #ifdef's.

Added includeds for bpstruct and epstruct.
Ports should update from using PACK_STRUCT_BEGIN and PACK_STRUCT_END to use these includes.
Maybe there should be an PACK_STRUCT_USE_INCLUDES ifdef around these, for ports for which PACK_STRUCT_BEGIN and PACK_STRUCT_END works nicely.

added ifndef around the TCP_TMR defines so that the user can define these values in the lwipopts.h file if needed; this change will not be seen outside the stack unless the user wants to change the default values.

Initial revision