Fix bug #54327: V2.1.0rc1 pbuf.c misses stdint.h include

... without reformatting the document (clang-format)

Revert "Fix bug #54327: V2.1.0rc1 pbuf.c misses stdint.h include"

This reverts commit 4e74421dac26f2646200b96d5f493982da522ef1.

Fix bug #54327: V2.1.0rc1 pbuf.c misses stdint.h include

pbuf.c: fix that pbuf_skip_const() was not prototyped for some configurations

Trivial typo fix

s/chekc/check/g

Signed-off-by: Axel Lin <axel.lin@ingics.com>

pbuf: Simplify pbuf_get_contiguous implementation

Use pbuf_skip_const() to simplify the implementation.

Signed-off-by: Axel Lin <axel.lin@ingics.com>

pbuf: Make pbuf_add_header/pbuf_remove_header return error if invalid parameters

It does not make sense to return success in p == NULL or
invalid header_size_increment/header_size_decrement cases. Fix it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>

Related to patch #9471: pbuf: Drop casting to u8_t for increment the reference count
Cast to correct type: Needed to avoid warnings about integer cast (-Wconversion)
SYS_ARCH_SET cannot be used here

Fix compiler warnings seen with clang 8.1.0 on MacOS

This fixes the following warnings:

test_tcp.c:266:5: error: code will never be executed [-Werror,-Wunreachable-code]
    pbuf_free(p);
    ^~~~~~~~~
- The check API 'fail' aborts the test, thus pbuf_free(p) will never be executed

pbuf.c:783:111: error: format specifies type 'unsigned short' but the argument has type 'u8_t' (aka 'unsigned char') [-Werror,-Wformat]
      LWIP_DEBUGF( PBUF_DEBUG | LWIP_DBG_TRACE, ("pbuf_free: %p has ref %"U16_F", ending here.\n", (void *)p, ref));
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
- LWIP_PBUF_REF_T is u8_t by default and doesn't match U16_F, so cast to u16_t. The cast and formatter will need to be changed
if ref is larger than 16 bits

ethernet.c:105:16: error: format specifies type 'unsigned char' but the argument has type 'unsigned int' [-Werror,-Wformat]
               (unsigned)ethhdr->dest.addr[0], (unsigned)ethhdr->dest.addr[1], (unsigned)ethhdr->dest.addr[2],
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- addr[] is type u8_t, formatter is X8_F which should be 8 bits. 'unsigned' is an int, so cast to unsighed char instead

Reformat core code using astylerc

Simplify pbuf_remove_header() a bit

fix pbuf_split_64k() for zero-length pbufs

Even more pbuf_header -> pbuf_add/remove_header replacements (also in strings)

More pbuf_header -> pbuf_add/remove_header replacements

Rework pbuf_add_header_impl to only modify the pbuf after all checks passed

Fix bug #51686: pbuf_remove_header: silence unused variable warning
but in another way than the provided patch

Wconversion-related cleanup: split pbuf_header(s16_t) into pbuf_add_header(size_t) and pbuf_remove_header(size_t)

The new functions both take size_t as increment/decrement argument instead of s16_t (which needed to be range-checked before conversion everywhere) - in most places, the direction (increment or decrement) is known anyway, so no need to encode it in a sign bit

Fix my last commit - break is missing

Avoid return in case statement, makes function control flow equal to other case statement paths

Add "fall through" statement to Axel's patch

pbuf: Simplify pbuf_alloc a bit

No need to have additional if statement for PBUF_REF/PBUF_ROM.
It can be merged to the existing swtich(type) cases.

Signed-off-by: Axel Lin <axel.lin@ingics.com>

work on -Wconversion...

Ensure SACKs are deleted when pbuf_free_ooseq() frees ooseq pbufs (because of memory shortage)

pbuf.c: work on -Wconversion...

Replace usages of tcpip_callback_with_block(foo, bar, 0) with tcpip_try_callback()

Slightly optimize pbuf_alloc: encode 'header offset' in 'enum pbuf_layer' instead of switch/case (which was duplicated in pbuf_alloc and pbuf_alloced_custom)

pbuf_alloced_custom(): less code duplication, please :-)

Fix compile of Axel Lin's patch

pbuf: Allow pass flags to pbuf_init_alloced_pbuf()

Then we can reuse pbuf_init_alloced_pbuf() in pbuf_alloced_custom().

Signed-off-by: Axel Lin <axel.lin@ingics.com>

pbuf: Init pbuf if_idx to NETIF_NO_INDEX in pbuf_alloced_custom

Otherwise the p->pbuf.if_idx is uninitialized.

Signed-off-by: Axel Lin <axel.lin@ingics.com>

pbuf: Make pbuf_init_alloced_pbuf take pbuf_type instead of u8_t for type parameter

All callers pass pbuf_type to pbuf_init_alloced_pbuf(), so make it take
pbuf_type instead of u8_t.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>

Work on bug #3031/task #7896: change pbuf->type/enum pbuf_type to be more generic (see UPGRADING)

fixed compiling pbuf.c with LWIP_TCP==0

pbuf_coalesce: Replace pbuf_alloc+pbuf_copy with pbuf_clone

Avoid duplicate the same implementation.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>

Add custom pbuf usage example to pbuf_alloced_custom() docs

Some documentation updates and fixes
Dedicated Zero-copy RX page
Fix doxygen warnings

pbuf: Fix allocate zero length pbuf

Current code fails to allocate zero length pbuf (e.g. for PBUF_RAW PBUF_POOL),
fix it.

Fixes: eb269e61b5d3 ("First step to clean up pbuf implementation: add pbuf_alloc_reference() to allocate pbufs referencing external payload; move member initialization to common function; simplify PBUF_POOL chain allocator")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>

First step to clean up pbuf implementation: add pbuf_alloc_reference() to allocate pbufs referencing external payload; move member initialization to common function; simplify PBUF_POOL chain allocator

pbuf_alloc_copy -> pbuf_clone

Added 'pbuf_alloc_copy' e.g. as a single function for use with non scatter-gather drivers

pbuf_copy_partial: remove double-check of 'buf' and 'dataptr'

pbuf: added new function pbuf_free_header() to gradually hide bytes and free pbufs from the front of a pbuf chain

Add pbuf_get_contiguous() to doxygen docs

Fix documentation on pbuf_get_contiguous()

Added pbuf_get_contiguous() to get data in one piece (either zero copy from pbuf or memcpied into a supplied buffer)

pbuf_ref: assert-check for 'ref' overflow

pbuf_free: Use correct type LWIP_PBUF_REF_T for local variable

Revert "Improve pbuf refcount underflow check by checking the local variable on the stack that was assigned in a protected region"

This reverts commit 62c44138da19a8cd9b100b3050c9697a80d8866f.

Didn't notice due to local changes the ASSERTION was already inside the locks...

Improve pbuf refcount underflow check by checking the local variable on the stack that was assigned in a protected region
The old code was vulnerable to race conditions since it checked ref to be >0 without locks

Preparation for task #14369: Define ways to work with a netif having multiple ports
Add if_idx member to struct pbuf

udp/raw: prevent packet length overflows

Previously, on netifs with unrestricted MTUs (typically loopback
interfaces), it was possible to give a packet to the UDP/RAW API
calls that is so large that when prepending headers, the pbuf's
tot_len field would overflow. This could easily result in
undesirable behavior at lower layers, e.g. a crash when copying
the packet for later delivery.

This patch models such overflows as memory allocation errors, thus
resulting in clean failures. Checks have to be added in multiple
places to cover (hopefully) all cases.

Fix bug #50040: pbuf_alloc(..., 65534, PBUF_RAM) succeeds
Check for integer overflow when calculating memory allocation size

Fix warning about bad cast in pbuf_skip()

Fix a few -Wconversion warnings (there are many more to do)

Fix compile with LWIP_NOASSERT
Pointed out by Nirav Desai

Fix bug #49827: wrong cast to size_t on 16-bit x86 architecture
I hope I caught all of them.
TODO: Same for casts to get rid of alignment warnings, these are also casts via size_t

Minor documentation update

pbuf_copy: try to fix GCC const warning

Make some pbuf functions take const pbuf pointers

Minor: comment in pbuf.c

Fix bug #49218: pbuf_clen() overflow as a result of tcp_write concatenation
Let pbuf_clen() return u16_t

Update comment in MDNS and pbuf.c

Improve my last docs

Documentation: Add example for zero-copy RX using custom PBUF

Implement a more readable fix for pbuf_memcmp than my last fix

Fix pbuf_memcmp() implementation by using pbuf_try_get_at() instead of pbuf_get_at(). Payload out-of-bounds access was not handled correctly.

added pbuf_try_get_at() (much like pbuf_get_at() but can return out-of-pbuf error)

Minor coding style fix in pbuf.c

pbuf: Use SYS_ARCH_INC in pbuf_ref()

Use SYS_ARCH_INC to simplify the code.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: goldsimon <goldsimon@gmx.de>

Documentation review with Simon, minor changes

Document apps in doxygen module style, create more top-level categories to structure documentation

Document netconn API in doxygen module style

Document DNS, memory pools and PBUFs as modules

Fixed invalid DEBUGF level SERIOUS when pbuf_header fails (it returns '1': this is not serious!)

Fix several doxygen errors all over the code

pbuf: Make pbuf_skip function public, so it can be used in SNMP code

Use SYS_ARCH_SET macro at appropriate places

Use SYS_ARCH_SET to simplify the code a bit.

Signed-off-by: Axel Lin <axel.lin@ingics.com>

started to move "private" header files containing implementation details to "lwip/priv/" include directory to seperate the API from the implementation.

minor: fixed coding style (lwip style)

minor: coding style

minor/coding style: removed spaces before line ending (from file header)

minor/coding style: removed spaces before line ending

pbuf_take: make it comply with API specifications

LWIP_ERROR macro exited the function early with the return code
indicating a SUCCESS. Fix the error codes. Return the specified
error code for cases when the pbuf is too short.

Fix that pbuf_realloc() called mem_trim() for "custom" PBUF_RAM

Fix edge case in pbuf_take_at()

Writes to offsets pointing to the start of a pbuf in the chain
did nothing and just returned ERR_OK.

Added unit tests to verify the fix, and also
that pbuf_get_at()/pbuf_put_at() handles this case.

Many const fixes throughout the stack (although these are not all, yet)

Fixed PBUF_LINK_ENCAPSULATION_HLEN support

PBUF_LINK_ENCAPSULATION_HLEN support was introduced by 6ef7563f and
missed the fact that header size calculation/reservation using
computation like PBUF_LINK_HLEN + PBUF_IP_HLEN + ... are used all over
the source code. Hopefully fixed all of them.

task #12722 (improve IPv4/v6 address handling): renamed ip_addr_t to ip4_addr_t, renamed ipX_addr_t to ip_addr_t and added IP version;
ip_addr_t is used for all generic IP addresses for the API, ip(4/6)_addr_t are only used internally or when initializing netifs or when calling version-related functions

Added the option PBUF_LINK_ENCAPSULATION_HLEN to allocate additional header space for TX on netifs requiring additional headers

patch #8423 "arch/perf.h" should be made an optional item

CORE: fixed missing prototype for pbuf_header_impl() function

lwip/src/core/pbuf.c:502:1: warning: no previous prototype for ‘pbuf_header_impl’ [-Wmissing-prototypes]

task #11472 Support PBUF_REF for RX (IPv6 and IPv4/v6 reassembly might not work yet)

Parts of patch #8397 Typos corrected in comments and text outputs

added pbuf_take_at() and pbuf_put_at() (in preparation for dns.c changes)

fixed bug #39356 Wrong increment in pbuf_memfind()

Remove newlines in LWIP_ERROR calls

Another fix to window scaling: support queueing more than 64 KByte in ooseq data

Fixed my last chagne to pbuf_copy

pbuf_copy(): moved the check for "p_to != NULL" to a better place.

fixed bug #35291: NULL pointer in pbuf_copy

removed the need to disable ARP_QUEUEING when LWIP_ARP is disabled an TCP_QUEUE_OOSEQ when LWIP_TCP is disabled

fixed bug #34534: Error in sending fragmented IP if MEM_ALIGNMENT > 4

fixed bug #34112 Odd check in pbuf_alloced_custom (typo)

Prevent non-static function that is not declared in header file

Fixed some C compiler warnings

freeing ooseq pbufs when the pbuf pool is empty implemented for NO_SYS==1: when not using sys_check_timeouts(), call PBUF_CHECK_FREE_OOSEQ() at regular intervals from main level.

Combined IPv4 and IPv6 code where possible, added defines to access IPv4/IPv6 in non-IP code so that the code is more readable.

Added some helper functions to find strings in chained pbufs

Fixed bug #29361 (ip_frag has problems with zero-copy DMA MACs) by adding custom pbufs and implementing custom pbufs that reference other (original) pbufs. Additionally set IP_FRAG_USES_STATIC_BUF=0 as default to be on the safe side.

task #6849: added udp_send(_to/_if) functions that take a precalculated checksum, added pbuf_fill_chksum() to copy data into a pbuf and at the same time calculating the checksum for that data

Fixed compiling with different options disabled (TCP/UDP), triggered by bug #29345; don't allocate acceptmbox if LWIP_TCP is disabled

minor: fixed coding style

Moved stack-internal parts of tcp.h to tcp_impl.h, tcp.h now only contains the actual application programmer's API

Renamed mem_realloc() to mem_trim() to prevent confusion with realloc()

Fixed compiler warnings when MEM_SIZE < 64000

bug #28659: Missing casts

Fixed bug #28064: pbuf_alloc(PBUF_POOL) is not thread-safe by queueing a call into tcpip_thread to free ooseq-bufs if the pool is empty

Fixed usage of logging levels (bug #27948: Incorrect logging levels used in various places)

Fixed bug #27034: "Invalid ASSERT in pbuf_alloc()" to prevent breaking PPP (for now).

task #7013: Added option LWIP_NETIF_TX_SINGLE_PBUF to try to create transmit packets from only one pbuf to help MACs that don't support scatter-gather DMA.

Added check: PBUF_POOL_BUFSIZE must be greater than MEM_ALIGNMENT or else the offset of a pbuf may take the full first pbuf in a chain (resulting in the first pbuf having len==0)

* pbuf.c: reclaim pbufs from TCP out-of-sequence segments if we run
out of pool pbufs.

* pbuf.c (pbuf_copy_partial): Improve function description comment. Thanks to Luca Ceresoli

Added 2 asserts in pbuf_realloc to prevent dereferencing a null pointer in invalid pbuf queues

Fixed comments for pbuf_copy() and find_entry() as proposed by Luca Ceresoli on lwip-users

* pbuf.c, ppp.c: Fix warnings on some systems with mem_malloc.

Minor changes in lwip folder: fix some warnings.

Fix some warnings discovered by compiling the unixsim under cygwin (gcc pedantic)

Minor change (doxygen tags)

Make pbuf_alloc a bit easier to read (change parameter name from "l" to "layer" and use LWIP_MIN instead of ternary operatory)

Minor changes (but in lot of files): add #if/#endif for options where they could miss. #if LWIP_xxx if always put after #include "lwip/opt.h" (note this one indirectly include cc.h). Move others includes inside #if/#endif block.

Rename pbuf's "flgs" in "flags" (see in [lwip-devel] Last changes by Marc)

Use enum pbuf_flag as pbuf_type.
Renumber PBUF_FLAG_*.

Split pbuf flags in pbuf type and flgs.
Improved lwip_recvfrom(). TCP push now propagated.

Make pbuf_init() call be an empty macro for now

Fixed bug #20429: use the new pbuf_copy_partial instead of the old copy_from_pbuf, which illegally modified the given pbuf; Introduced pbuf_copy_partial, making netbuf_copy_partial use this function.

Removed old debug variables from pbuf_copy()

Minor fix (indent)

Added assertions where PBUF_RAM pbufs are used and an assumption is made that this pbuf is in one piece (i.e. not chained). These assumptions clash with the possibility of converting to fully pool-based pbuf implementations, where PBUF_RAM pbufs might be chained.

Sorry, checked in some of my local changes with the LWIP_ERROR modification!

Changed the expression of LWIP_ERROR to the same as for LWIP_ASSERT

Minor changes: fix some comments for Doygen documentation

Ooops, checked in a wrong (test-) version before!

Done some work on task #6933: converted some LWIP_ASSERTs to LWIP_ERROR to give back an error return value for LWIP_NOASSERT=1

Always align PBUF_POOL_BUFSIZE, pbuf_init is not needed any more, minor changes to meet coding style requirements

pbuf_copy(): removed copy & paste error which did not copy pbuf chains correctly

pbuf_copy: chained pbufs were not copied correctly because of wrong packet-queue-check

opt.h, mem.h, mem.c, memp.c, pbuf.c, ip_frag.c, vj.c: Fix bug #20162. Rename MEM_ALIGN in LWIP_MEM_ALIGN and MEM_ALIGN_SIZE in LWIP_MEM_ALIGN_SIZE to avoid some macro names collision with some OS macros.

pbuf_copy(): Corrected a wrong comment & try to behave correctly if LWIP_NOASSERT is defined

Needed for patch to bug #19937: pbuf_copy is always compiled, not only if ARP_QUEUEING is enabled

Removed LWIP_DEBUG_ASSERT

Corrected check of PBUF_POOL overflow

pbuf_alloc(PBUF_POOL): Added asserts to make sure payload+len is still in bound of the pbuf (also to make sure bug #15659 is fixed).

task #6831: removed the option PBUF_POOL_USES_MEMP and removed the old pbuf pool code, pbuf pool now always allocates from a memp pool

(see task #6831): Included new option PBUF_POOL_USES_MEMP to use a memp pool for PBUF_POOL pbufs instead of the old pool implementation in pbuf.c to remove redundant code.

Modified struct pbuf size determination so that sizeof(struct pbuf) does not necessarily be a multiple of MEM_ALIGNMENT

Included patch #5920: Create define to override C-library memcpy. 2 Defines are created: MEMCPY() for normal memcpy, SMEMCPY() for situations where some compilers might inline the copy and save a function call. Also replaced all calls to memcpy() with calls to (S)MEMCPY().

Further update to ARP queueing: Changed pbuf_copy() implementation so that it can be reused (don't allocate the target pbuf inside pbuf_copy()).

Remove forgotten printf in pbuf_init().

Checked in patch #5453: removed mutex/other locking stuff if SYS_LIGHTWEIGHT_PROT=0, moved some pbuf pool logic to static functions

pbuf_alloc() / pbuf_realloc(): added LWIP_DEBUG_ASSERT() and cast operator when assigning s32_t to u16_t to get rid of compiler warnings

Changed the comment to pbuf_realloc() that it can't grow (only shrink) chains to reflect the fact that we decided not to change this.

* pbuf.c: Use s32_t in pbuf_realloc(), as an s16_t can't reliably hold
the difference between two u16_t's.

3rd fix for bug #11400 (arp-queuing): More pbufs than previously thought need to be copied (everything but PBUF_ROM!). Cleaned up pbuf.c: removed functions no needed any more (by etharp).

most of files: prefix all debug.h define with "LWIP_" to avoid any conflict with others environment defines (these were too "generic").

* Fix all uses of pbuf_header to check the return value. In some
cases just assert if it fails as I'm not sure how to fix them, but
this is no worse than before when they would carry on regardless
of the failure.

checked in patch #5796: pbuf_alloc: len field claculation caused memory corruption.

Reverted pbuf_alloc() to REV 1.82

Corrected patch to bug #19168

Fixed buf #19168 based on patch by Dmitry Potapov

* pbuf.c: Fix BUG#17645 - ensure pbuf payload pointer is not moved
outside the region of the pbuf by pbuf_header()

Ensure the size of each pbuf in the pool meets alignment constraints

Pbuf flag test size and speed optimalisation (helping a dumb compiler).

2006-02-27 Merged patch by Curt McDowell
pbuf.c: Fix alignment; pbuf_init() would not work unless pbuf_pool_memory[] is properly aligned.

Introduced cc.h formatters and removed SO_REUSE from transport layers.

Added some missing string.h includes.

Fixed missing semicolon in LWIP_DEBUG statement.

Added inline source documentation.

Replaced erronous LWIP_ERRORF with LWIP_DEBUGF

Kieran Mansley - kjm25@cam.ac.uk - 24th Nov 2004
* Increased argument checking at start of pbuf_queue() and made resulting errors more verbose

Stop compiler complaining of empty if statement when LWIP_DEBUGF() empty.
Close an unclosed comment.

Made some comments more explicit.

Small corrections to some debugging statements, to pacify compiler.

Kieran Mansley - kjm25@cam.ac.uk - 30th May 2004

* Fixed bug #9160 after discussion on mailing list
- alters use of MEM_ALIGN_SIZE in pbuf_alloc when calling mem_malloc for a PBUF_RAM pbuf

Changed PAD_ETH_SIZE into ETH_PAD_SIZE for consistency with de-facto lwIP naming convention.

Remember head of queue in pbuf_queue() iff PBUF_DEBUG to generate senseful debug report.

Adpated comments to match Doxygen/JavaDoc style.

Applied cleaner new patch for bug #8708.
Implemented multiple packets on the outgoing queue in etharp.c.
Removed etharp.c specific queueing functions.
Fixed generic pbuf.c queueing functions.

Applied Ian Wienand's patches (4-2-2004). Was partly applied earlier.

Merged from DEVEL, except for the API change in etharp.c.

Applied mem.diff by Ian Wienand on lwip-devel on February 4th 2004.
Stops some warnings.

Merged from DEVEL. etharp prepared for queueing feature. DHCP fix.

Merged from DEVEL into main tree.

Merged from DEVEL.

merged from DEVEL.

Fixes wrongly cast LWIP_DEBUGF arguments (patch #1596 and more).

Changed DEBUGF to LWIP_DEBUGF

Additional documentation on the subtle difference of a 'pbuf chain' and a 'packet queue'.

Increased number of debug messages to see pbuf chain actions.

Fixed a memory leak when only a part of a PBUF_POOL chain could be allocated.

pbuf_alloc() forgot to set tot_len field for PBUF_POOL pbufs.

Applied patches posted by Marc Boucher on lwip-users May 18th 2003.

C++ comments cleanup

Major stylo search/replace for "One space between keyword and opening bracket."

Implemented packet (de)queueing. Unused, etharp.c must be adapted next.

Re-added code for checking tail-parameter for NULL in
pbuf_chain() to provide for better backward compatibility.

Fixed tabs into spaces. Fixed other stylos.

Debug message shows requested pbuf type (of ROM/REF) upon memory allocation failure.

Disabled pbuf_dechain() as it not currently in use. Fixed comment position.

Got rid of pbuf_pool_alloc_cache and pbuf_pool_free_cache. Also got rid of
pbuf_refresh(). This has sped up pbuf pool operations.

Fixed debug message for PBUF_REF/ROM allocation failure.

Fixed stylo.

In pbuf_take(): Got rid of variable 'f'. Fixed stylo (typo in style). Renamed 'top' to 'head'.

Fixed last change to pbuf_take. There were two calls to pbuf_free in a row.

Fixed another assert. Removed another redundant assignment.

Lots of comments added. Removed redundant assignment. Moved assertion.

Reverted back to David Haas' patch of pbuf_chain() from 1.34.

Replaced pbuf.c 1.34 pbuf_take() change by simpler alternative.

Fixed issue in pbuf_take(): old pbuf of type PBUF_REF was being referenced
after being freed. Also, it was not being freed if it had been the first
buffer in chain. It still needs to be freed then.

Fix pbuf_chain() to update tot_len of last buffer in first chain properly.
Previous code skipped it.

Made comments in pbuf_header() more general (header can be increased or
decreased).

pbuf_header() now only moves payload pointer upwards for PBUF_ROM/REF.

Fixed pbuf_dechain() assertion. Removed old documentation from pbuf.h.

Documentation changes. Added missing trailing newlines to debug messages.

Fixed missing variable.

Corrected more pbuf.c functions to comply with pbuf->ref and ->tot_len invariant.

Fixed minor compile issues.

Fixed bugs #2968 (ref count) and #2670 (total length).
Name of pbuf_unref() falsely suggests to undo pbuf_ref(), renamed to pbuf_take().

pbuf_realloc() did not update ->tot_len in a chain. Fixed dealloc of REF/ROMs.

Fixing bug #1903 with a new pbuf_realloc() that respects mixed-type chains.

Added documentation and comments.

Lots of clearing up comments and use of new debugging features.

Retry with PBUF_RAM if PBUF_POOL allocation failed.

Added tracing debug messages.

Added debug levels for some serious errors (out of memory).

Fixed memory leak caused by my last pbuf_ref change.

Fixed up and made work a PBUF_REF type. Most of the code uses this now
instead of PBUF_ROM. This addition allows support of copy-on-demand where the
lower layers can call pbuf_unref() which tests for any PBUF_REF buffers and
replaces them with PBUF_POOL buffers. This is now used
everywhere. pbuf_unref() is called in ARP queueing and in the coldfire
driver, which puts frames on a DMA queue and frees them later.

Along with this change pbuf_free() now goes through the entire chain of
buffers and tests all the ref counters, not just the first one. Generally now
pbuf_ref_chain() should be called and not pbuf_ref(). This change was made
because it is possible for the head of the pbuf chain to have a different
count than the payload pbuf which might have been passed by the application.

cleaned up opt.h a bit, added more option defaults ad changed SYS_LIGHTWEIGHT_PROT to be a 0/1 define.The same for COMPAT_SOCKET

byte-order handling functions are in inet.c now and the uperrcase counterparts are gone. opt.h has all the
configurable items debug does not need to be directly included.

By request: moved lightweight protection to macros.

Add the following features and bugfixes:

Added select() functionality to sockets library.
Support for errno in sockets library.
Byte ordering fixes.
basic lwip_ioctl(), FIONREAD, get/setsockopt() etc. support

- added additional argument to netif_add to pass state pointer so that the
if_init function has access to context information before
the interface is added, without accessing globals.

- added netif_remove()

- to conserve cpu load the tcpip_tcp_timer should only be active
when tcbs that need it exist.

- pass length of available data to callbacks for NETCONN_EVT_RCV events

- added tcpip_link_input(), a hack to allow processing of PPP
packets in tcpip_thread() context. This saves threads and context
switches.

- renamed incompatible ASSERT() macro to LWIP_ASSERT() to avoid name
collision.

- changed a bunch of %d's to %u's in format strings for unsigned values.

- added ip_frag to lwip_stats.

- changed IP_REASS_MAXAGE and IP_REASS_TMO defaults to more realistic
values.

- added sys_timeout_remove() function to cancel timeouts (needed by PPP
amongst other things).

- tolerate NULL returns from sys_arch_timeouts() since some threads might
not need to use or have timeouts.

- added sys_sem_wait_timeout()

- moved mem_malloc() function to end of mem.c to work around tasking
compiler bug.

- automatically bind to local tcp port if 0.

- allow customization of port ranges for automatic local bindings.

- corrected various typos, spelling errors, etc..

Thanks to Marc Boucher for many of these changes.

Added lightweight protection. In coldfire this is implemented by disabling
interrupts. In unixsim this is implemented by using a mutex. Uses #define
SYS_LIGHTWEIGHT_PROT to enable. It is enabled in coldfire by default, but
disabled in unixsim.

Fixes bug 2005 if you enable SYS_LIGHTWEIGHT_PROT. So the bug is closed.

Added commented about the signedness of pbuf_header() argument.

Updated lwIP module copyright years to include 2003. Committers must check theirs.

sizeof(u8_t) is 1 at temperatures > 0 K

renamed (hopefully everywhere) stats to lwip_stats.closes bug #1901

Use C style comments.In debug stataments cast various struct pointers to void* to
avoid printf warnings.misc warnings in etharp.

Fixed compiler warning - DEBUGF statement with too many arguments

fix pbuf_alloc for layer PBUF_LINK

Added PBUF_REF (payload external, copied on queueing).

typo fixes.The unterminated comment already got two bugreports so it was time.

Added pbuf_ref_chain() which increases ref count of all pbufs in a chain.

Initial revision