userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Replace usage of WSMUX_{ADD,REMOVE}_DEVICE compat macros.

ok deraadt@, mpi@

Switch from 4-clause to 2-clause BSD license.

Matthias Drochner rescinded the third and fourth clauses of wsconscfg(8)
and wsfontload(8) licenses in 2008 in NetBSD.

https://mail-index.netbsd.org/source-changes/2008/05/26/msg206199.html

OK deraadt@

clean up flags++ instances around getopt()
ok florian

documentation tweaks.

ok (some time ago) jmc@

include sys/time.h to get struct timeval

ansi cleanup; khalek@linuxgamers.net

smarten this page up a bit. usage() too.

ansi

add missing includes
ok tedu@

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Wall cleanup

missing space in usage(); ok mickey

allow listing and soon deleting fonts; aaron@ ok

Change /dev/ttyE* to /dev/ttyC* to reflect reality in OpenBSD.

Some format string problems that were missed during initial audit; deraadt@ and
millert@ ok

wscons vt config tool; initial import from netbsd tree

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Replace usage of WSMUX_{ADD,REMOVE}_DEVICE compat macros.

ok deraadt@, mpi@

Switch from 4-clause to 2-clause BSD license.

Matthias Drochner rescinded the third and fourth clauses of wsconscfg(8)
and wsfontload(8) licenses in 2008 in NetBSD.

https://mail-index.netbsd.org/source-changes/2008/05/26/msg206199.html

OK deraadt@

clean up flags++ instances around getopt()
ok florian

documentation tweaks.

ok (some time ago) jmc@

include sys/time.h to get struct timeval

ansi cleanup; khalek@linuxgamers.net

smarten this page up a bit. usage() too.

ansi

add missing includes
ok tedu@

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Wall cleanup

missing space in usage(); ok mickey

allow listing and soon deleting fonts; aaron@ ok

Change /dev/ttyE* to /dev/ttyC* to reflect reality in OpenBSD.

Some format string problems that were missed during initial audit; deraadt@ and
millert@ ok

wscons vt config tool; initial import from netbsd tree

Replace usage of WSMUX_{ADD,REMOVE}_DEVICE compat macros.

ok deraadt@, mpi@

Switch from 4-clause to 2-clause BSD license.

Matthias Drochner rescinded the third and fourth clauses of wsconscfg(8)
and wsfontload(8) licenses in 2008 in NetBSD.

https://mail-index.netbsd.org/source-changes/2008/05/26/msg206199.html

OK deraadt@

clean up flags++ instances around getopt()
ok florian

documentation tweaks.

ok (some time ago) jmc@

include sys/time.h to get struct timeval

ansi cleanup; khalek@linuxgamers.net

smarten this page up a bit. usage() too.

ansi

add missing includes
ok tedu@

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Wall cleanup

missing space in usage(); ok mickey

allow listing and soon deleting fonts; aaron@ ok

Change /dev/ttyE* to /dev/ttyC* to reflect reality in OpenBSD.

Some format string problems that were missed during initial audit; deraadt@ and
millert@ ok

wscons vt config tool; initial import from netbsd tree