- (void)printf() -> printf(); the cast adds clutter for little value.
- fprintf(stdout, ...) -> printf()
- fputs(x, stdout) -> printf(); for consistency.
fputs is twice as fast on atom x5-Z8300@1.44GHz but Amdahl sees a pure printf
tcpdump only 2% slower than a pure fputs (for constant strings) tcpdump
to /dev/null across a 20MB/~170k packet pcap file.

ok dlg@ for fputs and ok tedu@ krw@ deraadt@ a2k19 for the rest

Rework UDP parsing, particularly around IP addresses.

This originally started as trying to put a consistent space between
the UDP header information and the payload parsing, but while doing
that I noticed inconsistent IPv4 vs IPv6 handling.

Apart from the default "srcip.srcport > dstip.dstpor" output, all
the other places that IP addresses were printed assumed IPv4. It
looks like it is possible that udp_print() can be called without
an IP header, which made these blind IPv4 prints turn into NULL
derefs.

This fixes the problem above by only having a single place that
prints the addresses out, and makes sure to get the difference
between IPv4, IPv6 and no IP correct.

This changes how the checksum is calculated. It incrementally builds
the UDP checksum by feeding the IPv4 and v6 addresses in separately,
then using common code for the rest of the pseudo header and actual
payload.

Lastly, this does make printing the space between the UDP header
and its payload consistent. The UDP code is now responsible for
adding a space after itself so the payload parsers don't have to.
They got it wrong in some cases anyway, so this should be a lot
more uniform.

help and ok sthen@

Remove remaining instances of the register keyword.

ok deraadt@

Most packets generate one line in tcpdump. For AH and RIP there
was an extra line without benefit. Remove the new-line in printf
to make parsing easier.
OK lteo@ mikeb@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

No use for <netinet/in_systm.h> nor <netinet/tcpip.h>.

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

trash $Header goo which is just annoying; 5595

fix RIPv0 (RFC 1058) printing; <james@squish.net>

fix build on alpha with -Werror; David Leonard <david.leonard@csee.uq.edu.au>

Compile with -Wall. Add $OpenBSD$. (jakob@ ok)

Improve RIP support; PR#1266, James Ponder <james@oaktree.co.uk>

* Fixes the way version numbers are handled so that it is compliant
with RFC 1058 in the order that you should look at things.

* Adds support for the authentication attribute with cleartext passwords.

* Improves readability in output.

* Handles version 0 of RIP and unknown conditions a lot better

INET6
DHCP/BOOTP
tcp & udp checksum detection
numerous bugfixes

*** empty log message ***

it is 3.2 now.

sync to latest

Updating to the latest LBL release.
Sun's SKIP support added.

branches: 1.1.1;
Initial revision

Rework UDP parsing, particularly around IP addresses.

This originally started as trying to put a consistent space between
the UDP header information and the payload parsing, but while doing
that I noticed inconsistent IPv4 vs IPv6 handling.

Apart from the default "srcip.srcport > dstip.dstpor" output, all
the other places that IP addresses were printed assumed IPv4. It
looks like it is possible that udp_print() can be called without
an IP header, which made these blind IPv4 prints turn into NULL
derefs.

This fixes the problem above by only having a single place that
prints the addresses out, and makes sure to get the difference
between IPv4, IPv6 and no IP correct.

This changes how the checksum is calculated. It incrementally builds
the UDP checksum by feeding the IPv4 and v6 addresses in separately,
then using common code for the rest of the pseudo header and actual
payload.

Lastly, this does make printing the space between the UDP header
and its payload consistent. The UDP code is now responsible for
adding a space after itself so the payload parsers don't have to.
They got it wrong in some cases anyway, so this should be a lot
more uniform.

help and ok sthen@

Remove remaining instances of the register keyword.

ok deraadt@

Most packets generate one line in tcpdump. For AH and RIP there
was an extra line without benefit. Remove the new-line in printf
to make parsing easier.
OK lteo@ mikeb@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

No use for <netinet/in_systm.h> nor <netinet/tcpip.h>.

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

trash $Header goo which is just annoying; 5595

fix RIPv0 (RFC 1058) printing; <james@squish.net>

fix build on alpha with -Werror; David Leonard <david.leonard@csee.uq.edu.au>

Compile with -Wall. Add $OpenBSD$. (jakob@ ok)

Improve RIP support; PR#1266, James Ponder <james@oaktree.co.uk>

* Fixes the way version numbers are handled so that it is compliant
with RFC 1058 in the order that you should look at things.

* Adds support for the authentication attribute with cleartext passwords.

* Improves readability in output.

* Handles version 0 of RIP and unknown conditions a lot better

INET6
DHCP/BOOTP
tcp & udp checksum detection
numerous bugfixes

*** empty log message ***

it is 3.2 now.

sync to latest

Updating to the latest LBL release.
Sun's SKIP support added.

branches: 1.1.1;
Initial revision

Remove remaining instances of the register keyword.

ok deraadt@

Most packets generate one line in tcpdump. For AH and RIP there
was an extra line without benefit. Remove the new-line in printf
to make parsing easier.
OK lteo@ mikeb@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

No use for <netinet/in_systm.h> nor <netinet/tcpip.h>.

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

trash $Header goo which is just annoying; 5595

fix RIPv0 (RFC 1058) printing; <james@squish.net>

fix build on alpha with -Werror; David Leonard <david.leonard@csee.uq.edu.au>

Compile with -Wall. Add $OpenBSD$. (jakob@ ok)

Improve RIP support; PR#1266, James Ponder <james@oaktree.co.uk>

* Fixes the way version numbers are handled so that it is compliant
with RFC 1058 in the order that you should look at things.

* Adds support for the authentication attribute with cleartext passwords.

* Improves readability in output.

* Handles version 0 of RIP and unknown conditions a lot better

INET6
DHCP/BOOTP
tcp & udp checksum detection
numerous bugfixes

*** empty log message ***

it is 3.2 now.

sync to latest

Updating to the latest LBL release.
Sun's SKIP support added.

branches: 1.1.1;
Initial revision