we do not need 'struct mbuf; struct rtentry;' to satisfy some ancient unix
variant that made a header file mistake.
ok jsg

- (void)printf() -> printf(); the cast adds clutter for little value.
- fprintf(stdout, ...) -> printf()
- fputs(x, stdout) -> printf(); for consistency.
fputs is twice as fast on atom x5-Z8300@1.44GHz but Amdahl sees a pure printf
tcpdump only 2% slower than a pure fputs (for constant strings) tcpdump
to /dev/null across a 20MB/~170k packet pcap file.

ok dlg@ for fputs and ok tedu@ krw@ deraadt@ a2k19 for the rest

Rework UDP parsing, particularly around IP addresses.

This originally started as trying to put a consistent space between
the UDP header information and the payload parsing, but while doing
that I noticed inconsistent IPv4 vs IPv6 handling.

Apart from the default "srcip.srcport > dstip.dstpor" output, all
the other places that IP addresses were printed assumed IPv4. It
looks like it is possible that udp_print() can be called without
an IP header, which made these blind IPv4 prints turn into NULL
derefs.

This fixes the problem above by only having a single place that
prints the addresses out, and makes sure to get the difference
between IPv4, IPv6 and no IP correct.

This changes how the checksum is calculated. It incrementally builds
the UDP checksum by feeding the IPv4 and v6 addresses in separately,
then using common code for the rest of the pseudo header and actual
payload.

Lastly, this does make printing the space between the UDP header
and its payload consistent. The UDP code is now responsible for
adding a space after itself so the payload parsers don't have to.
They got it wrong in some cases anyway, so this should be a lot
more uniform.

help and ok sthen@

assign pointers to NULL rather than 0

Remove memory.h includes.

ok deraadt@

Remove more register keywords.

ok daniel@, discussed on hackers@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

trash $Header goo which is just annoying; 5595

c should be u_char for printing option numbers. fix parameter request
list option numbers >127 being negative. ok krw@

Fix size checks for bootp packets. Problem found and initial patch
from pedro@. ok moritz@

fix byteorder for "s" and "l" formats; ok henning@ krw@

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Add $OpenBSD$. (jakob@ ok)

INET6
DHCP/BOOTP
tcp & udp checksum detection
numerous bugfixes

bring more inline with tcpdump 3.4

- Merge some changes from tcpdump 3.4
-a flag; attempt to convert network and broadcast addresses to names
Improved signal handling
Miscellaneous fixes and typos
OSPF MD5 authentication support

- -X flag; emacs-hexl print (including ascii)

- Add ECN bits to TCP and IP headers

- IKE & IPsec (ESP & AH) support

OK deraadt@

length check bp_file; cgd

#if __STDC__ --> #ifdef __STDC__

*** empty log message ***

it is 3.2 now.

sync to latest

Updating to the latest LBL release.
Sun's SKIP support added.

branches: 1.1.1;
Initial revision

- (void)printf() -> printf(); the cast adds clutter for little value.
- fprintf(stdout, ...) -> printf()
- fputs(x, stdout) -> printf(); for consistency.
fputs is twice as fast on atom x5-Z8300@1.44GHz but Amdahl sees a pure printf
tcpdump only 2% slower than a pure fputs (for constant strings) tcpdump
to /dev/null across a 20MB/~170k packet pcap file.

ok dlg@ for fputs and ok tedu@ krw@ deraadt@ a2k19 for the rest

Rework UDP parsing, particularly around IP addresses.

This originally started as trying to put a consistent space between
the UDP header information and the payload parsing, but while doing
that I noticed inconsistent IPv4 vs IPv6 handling.

Apart from the default "srcip.srcport > dstip.dstpor" output, all
the other places that IP addresses were printed assumed IPv4. It
looks like it is possible that udp_print() can be called without
an IP header, which made these blind IPv4 prints turn into NULL
derefs.

This fixes the problem above by only having a single place that
prints the addresses out, and makes sure to get the difference
between IPv4, IPv6 and no IP correct.

This changes how the checksum is calculated. It incrementally builds
the UDP checksum by feeding the IPv4 and v6 addresses in separately,
then using common code for the rest of the pseudo header and actual
payload.

Lastly, this does make printing the space between the UDP header
and its payload consistent. The UDP code is now responsible for
adding a space after itself so the payload parsers don't have to.
They got it wrong in some cases anyway, so this should be a lot
more uniform.

help and ok sthen@

assign pointers to NULL rather than 0

Remove memory.h includes.

ok deraadt@

Remove more register keywords.

ok daniel@, discussed on hackers@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

trash $Header goo which is just annoying; 5595

c should be u_char for printing option numbers. fix parameter request
list option numbers >127 being negative. ok krw@

Fix size checks for bootp packets. Problem found and initial patch
from pedro@. ok moritz@

fix byteorder for "s" and "l" formats; ok henning@ krw@

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Add $OpenBSD$. (jakob@ ok)

INET6
DHCP/BOOTP
tcp & udp checksum detection
numerous bugfixes

bring more inline with tcpdump 3.4

- Merge some changes from tcpdump 3.4
-a flag; attempt to convert network and broadcast addresses to names
Improved signal handling
Miscellaneous fixes and typos
OSPF MD5 authentication support

- -X flag; emacs-hexl print (including ascii)

- Add ECN bits to TCP and IP headers

- IKE & IPsec (ESP & AH) support

OK deraadt@

length check bp_file; cgd

#if __STDC__ --> #ifdef __STDC__

*** empty log message ***

it is 3.2 now.

sync to latest

Updating to the latest LBL release.
Sun's SKIP support added.

branches: 1.1.1;
Initial revision

Rework UDP parsing, particularly around IP addresses.

This originally started as trying to put a consistent space between
the UDP header information and the payload parsing, but while doing
that I noticed inconsistent IPv4 vs IPv6 handling.

Apart from the default "srcip.srcport > dstip.dstpor" output, all
the other places that IP addresses were printed assumed IPv4. It
looks like it is possible that udp_print() can be called without
an IP header, which made these blind IPv4 prints turn into NULL
derefs.

This fixes the problem above by only having a single place that
prints the addresses out, and makes sure to get the difference
between IPv4, IPv6 and no IP correct.

This changes how the checksum is calculated. It incrementally builds
the UDP checksum by feeding the IPv4 and v6 addresses in separately,
then using common code for the rest of the pseudo header and actual
payload.

Lastly, this does make printing the space between the UDP header
and its payload consistent. The UDP code is now responsible for
adding a space after itself so the payload parsers don't have to.
They got it wrong in some cases anyway, so this should be a lot
more uniform.

help and ok sthen@

assign pointers to NULL rather than 0

Remove memory.h includes.

ok deraadt@

Remove more register keywords.

ok daniel@, discussed on hackers@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

trash $Header goo which is just annoying; 5595

c should be u_char for printing option numbers. fix parameter request
list option numbers >127 being negative. ok krw@

Fix size checks for bootp packets. Problem found and initial patch
from pedro@. ok moritz@

fix byteorder for "s" and "l" formats; ok henning@ krw@

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Add $OpenBSD$. (jakob@ ok)

INET6
DHCP/BOOTP
tcp & udp checksum detection
numerous bugfixes

bring more inline with tcpdump 3.4

- Merge some changes from tcpdump 3.4
-a flag; attempt to convert network and broadcast addresses to names
Improved signal handling
Miscellaneous fixes and typos
OSPF MD5 authentication support

- -X flag; emacs-hexl print (including ascii)

- Add ECN bits to TCP and IP headers

- IKE & IPsec (ESP & AH) support

OK deraadt@

length check bp_file; cgd

#if __STDC__ --> #ifdef __STDC__

*** empty log message ***

it is 3.2 now.

sync to latest

Updating to the latest LBL release.
Sun's SKIP support added.

branches: 1.1.1;
Initial revision

assign pointers to NULL rather than 0

Remove memory.h includes.

ok deraadt@

Remove more register keywords.

ok daniel@, discussed on hackers@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

trash $Header goo which is just annoying; 5595

c should be u_char for printing option numbers. fix parameter request
list option numbers >127 being negative. ok krw@

Fix size checks for bootp packets. Problem found and initial patch
from pedro@. ok moritz@

fix byteorder for "s" and "l" formats; ok henning@ krw@

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Add $OpenBSD$. (jakob@ ok)

INET6
DHCP/BOOTP
tcp & udp checksum detection
numerous bugfixes

bring more inline with tcpdump 3.4

- Merge some changes from tcpdump 3.4
-a flag; attempt to convert network and broadcast addresses to names
Improved signal handling
Miscellaneous fixes and typos
OSPF MD5 authentication support

- -X flag; emacs-hexl print (including ascii)

- Add ECN bits to TCP and IP headers

- IKE & IPsec (ESP & AH) support

OK deraadt@

length check bp_file; cgd

#if __STDC__ --> #ifdef __STDC__

*** empty log message ***

it is 3.2 now.

sync to latest

Updating to the latest LBL release.
Sun's SKIP support added.

branches: 1.1.1;
Initial revision