use C99 syntax for filling the table_backend structs; ok gilles@

unify smtpd and makemap table parser

These are supposed to parse the same file format but have subtle
difference in the handling of comments, continuation lines and escaping.

Converge both to the simpler smtpd parser which doesn't handle
continuation lines nor escaping, and support comments only at the start
of the line.

improvements and ok millert@

add required headers for smtpd.h and remove unnecessary ones in other files.

ok jung@

type static tables on the fly when the first element is added

ok gilles@

fix logging of list entries

use private data structure for managing static table content

ok gilles@

table_fetch() always expect a valid dst pointer.

ok gilles@

introduce dump() and add() table methods, only implemented for static tables.

ok gilles@

pass the table pointer to the lookup()/fecth() methods

ok gilles@

change the close() method to take the table pointer

ok gilles

Make the backend open method return an int to report success.
The implementation is responsible for setting the handle pointer
as needed.

ok gilles@

reorder parameters for consistency

get rid of the unused dict argument in table lookup and fetch api.

ok gilles@

move the table backend name in the backend struct.
remove unused function.

ok gilles@

Simplify the table backend interface: lookup results are returned
as strings, and parsing is handled by the upper layer.

ok gilles@

introduce K_REGEX table type and table_regex_match(), unused for now

ok eric@

rework the table API so that it takes a struct smtpd * context in parameter
of functions creating, looking up or destroying tables.

this is a first step in cleaning up parse.y so it doesn't have side effects
outside of parse_config(), bringing nothing but making code cleaner.

ok millert@

switch smtpd to new grammar

ok eric@

Change the table parser logic. If the table is untyped, determine
its type by examining the first entry: if it contains a separator, type
is "mapping", otherwise type is "list". All entries are then parsed
according to the table type. The "list" type can also be forced by using
the "@list" directive in a comment. This allows to define list of entries
containing a separator.

Also, log parse errors.

ok gilles@

remove useless indirection for reading the file content

ok gilles@

add a log_warn() so that when smtpd fails to start due to a problem reading
the configuration file of a table, user actually understands what happens

diff by Alexis Vachette, ok jung@

remove spaces after '!'

no binary change

ok millert

Wrap long lines.

Ok gilles@ jung@

teach table_db and table_static about mailaddr maps (unused yet)

ok sunil@, ok jung@

Convert some fgetln to getline.

Ok gilles@, giovanni@, millert@

use <limits.h> comprehensively. For now try to push <> includes to
each .c file, and out of the .h files. To avoid overinclude.
ok gilles, in principle. If this has been done right, -portable should
become easier to maintain.

Update the table API: lookup functions can take an optional parameters
dictionnary (currently not set). While there, add a helper for forking
external backends, and remove unused table functions.

ok gilles@

unsigned char casts for ctype
ok gilles@

change dict_poproot() prototype: do not take key placeholder parameter as
it can't work that way.

alias files may be empty

sync with OpenSMTPD 5.3.2

ok gilles@

replace MAX_LINE_SIZE and SMTP_LINE_MAX with SMTPD_MAXLINESIZE for
consistency and clarity. Remove useless and confusing extra byte in
a few arrays based on this define.

ok gilles@

- when declaring a static table for userinfo, do not make username part of
the value as it confuses users
{ gilles => gilles:10:100:/home } becomes { gilles => 10:100:/home }

ok eric, we'll discuss changes under the hood post-release

unbreak broken smtpctl table update

fix by eric and I, ok eric@

Sync with our smtpd repo:

* first bricks of ldap and sqlite support (not finished but both working)
* new table API to replace map API, all lookups are done through tables
* improved handling of temporary errors throughout the daemon
* improved scheduler and mta logic: connection reuse, optimizes batches
* improved queue: more tolerant to admin errors, new layout, less disk-IO
* improved memory usage under high load
* SSL certs/keys isolated to lookup process to avoid facing network
* VIRTUAL support improved, fully virtual setups possible now
* runtime tracing of processes through smtpctl trace
* ssl_privsep.c sync-ed with relayd
* ssl.c no longer contains smtpd specific interfaces
* smtpd-specific ssl bits moved to ssl_smtpd.c
* update mail address in copyright

FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE.

smtpd.conf(5) simplified, it will require adaptations

ok eric@

unify smtpd and makemap table parser

These are supposed to parse the same file format but have subtle
difference in the handling of comments, continuation lines and escaping.

Converge both to the simpler smtpd parser which doesn't handle
continuation lines nor escaping, and support comments only at the start
of the line.

improvements and ok millert@

add required headers for smtpd.h and remove unnecessary ones in other files.

ok jung@

type static tables on the fly when the first element is added

ok gilles@

fix logging of list entries

use private data structure for managing static table content

ok gilles@

table_fetch() always expect a valid dst pointer.

ok gilles@

introduce dump() and add() table methods, only implemented for static tables.

ok gilles@

pass the table pointer to the lookup()/fecth() methods

ok gilles@

change the close() method to take the table pointer

ok gilles

Make the backend open method return an int to report success.
The implementation is responsible for setting the handle pointer
as needed.

ok gilles@

reorder parameters for consistency

get rid of the unused dict argument in table lookup and fetch api.

ok gilles@

move the table backend name in the backend struct.
remove unused function.

ok gilles@

Simplify the table backend interface: lookup results are returned
as strings, and parsing is handled by the upper layer.

ok gilles@

introduce K_REGEX table type and table_regex_match(), unused for now

ok eric@

rework the table API so that it takes a struct smtpd * context in parameter
of functions creating, looking up or destroying tables.

this is a first step in cleaning up parse.y so it doesn't have side effects
outside of parse_config(), bringing nothing but making code cleaner.

ok millert@

switch smtpd to new grammar

ok eric@

Change the table parser logic. If the table is untyped, determine
its type by examining the first entry: if it contains a separator, type
is "mapping", otherwise type is "list". All entries are then parsed
according to the table type. The "list" type can also be forced by using
the "@list" directive in a comment. This allows to define list of entries
containing a separator.

Also, log parse errors.

ok gilles@

remove useless indirection for reading the file content

ok gilles@

add a log_warn() so that when smtpd fails to start due to a problem reading
the configuration file of a table, user actually understands what happens

diff by Alexis Vachette, ok jung@

remove spaces after '!'

no binary change

ok millert

Wrap long lines.

Ok gilles@ jung@

teach table_db and table_static about mailaddr maps (unused yet)

ok sunil@, ok jung@

Convert some fgetln to getline.

Ok gilles@, giovanni@, millert@

use <limits.h> comprehensively. For now try to push <> includes to
each .c file, and out of the .h files. To avoid overinclude.
ok gilles, in principle. If this has been done right, -portable should
become easier to maintain.

Update the table API: lookup functions can take an optional parameters
dictionnary (currently not set). While there, add a helper for forking
external backends, and remove unused table functions.

ok gilles@

unsigned char casts for ctype
ok gilles@

change dict_poproot() prototype: do not take key placeholder parameter as
it can't work that way.

alias files may be empty

sync with OpenSMTPD 5.3.2

ok gilles@

replace MAX_LINE_SIZE and SMTP_LINE_MAX with SMTPD_MAXLINESIZE for
consistency and clarity. Remove useless and confusing extra byte in
a few arrays based on this define.

ok gilles@

- when declaring a static table for userinfo, do not make username part of
the value as it confuses users
{ gilles => gilles:10:100:/home } becomes { gilles => 10:100:/home }

ok eric, we'll discuss changes under the hood post-release

unbreak broken smtpctl table update

fix by eric and I, ok eric@

Sync with our smtpd repo:

* first bricks of ldap and sqlite support (not finished but both working)
* new table API to replace map API, all lookups are done through tables
* improved handling of temporary errors throughout the daemon
* improved scheduler and mta logic: connection reuse, optimizes batches
* improved queue: more tolerant to admin errors, new layout, less disk-IO
* improved memory usage under high load
* SSL certs/keys isolated to lookup process to avoid facing network
* VIRTUAL support improved, fully virtual setups possible now
* runtime tracing of processes through smtpctl trace
* ssl_privsep.c sync-ed with relayd
* ssl.c no longer contains smtpd specific interfaces
* smtpd-specific ssl bits moved to ssl_smtpd.c
* update mail address in copyright

FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE.

smtpd.conf(5) simplified, it will require adaptations

ok eric@

add required headers for smtpd.h and remove unnecessary ones in other files.

ok jung@

type static tables on the fly when the first element is added

ok gilles@

fix logging of list entries

use private data structure for managing static table content

ok gilles@

table_fetch() always expect a valid dst pointer.

ok gilles@

introduce dump() and add() table methods, only implemented for static tables.

ok gilles@

pass the table pointer to the lookup()/fecth() methods

ok gilles@

change the close() method to take the table pointer

ok gilles

Make the backend open method return an int to report success.
The implementation is responsible for setting the handle pointer
as needed.

ok gilles@

reorder parameters for consistency

get rid of the unused dict argument in table lookup and fetch api.

ok gilles@

move the table backend name in the backend struct.
remove unused function.

ok gilles@

Simplify the table backend interface: lookup results are returned
as strings, and parsing is handled by the upper layer.

ok gilles@

introduce K_REGEX table type and table_regex_match(), unused for now

ok eric@

rework the table API so that it takes a struct smtpd * context in parameter
of functions creating, looking up or destroying tables.

this is a first step in cleaning up parse.y so it doesn't have side effects
outside of parse_config(), bringing nothing but making code cleaner.

ok millert@

switch smtpd to new grammar

ok eric@

Change the table parser logic. If the table is untyped, determine
its type by examining the first entry: if it contains a separator, type
is "mapping", otherwise type is "list". All entries are then parsed
according to the table type. The "list" type can also be forced by using
the "@list" directive in a comment. This allows to define list of entries
containing a separator.

Also, log parse errors.

ok gilles@

remove useless indirection for reading the file content

ok gilles@

add a log_warn() so that when smtpd fails to start due to a problem reading
the configuration file of a table, user actually understands what happens

diff by Alexis Vachette, ok jung@

remove spaces after '!'

no binary change

ok millert

Wrap long lines.

Ok gilles@ jung@

teach table_db and table_static about mailaddr maps (unused yet)

ok sunil@, ok jung@

Convert some fgetln to getline.

Ok gilles@, giovanni@, millert@

use <limits.h> comprehensively. For now try to push <> includes to
each .c file, and out of the .h files. To avoid overinclude.
ok gilles, in principle. If this has been done right, -portable should
become easier to maintain.

Update the table API: lookup functions can take an optional parameters
dictionnary (currently not set). While there, add a helper for forking
external backends, and remove unused table functions.

ok gilles@

unsigned char casts for ctype
ok gilles@

change dict_poproot() prototype: do not take key placeholder parameter as
it can't work that way.

alias files may be empty

sync with OpenSMTPD 5.3.2

ok gilles@

replace MAX_LINE_SIZE and SMTP_LINE_MAX with SMTPD_MAXLINESIZE for
consistency and clarity. Remove useless and confusing extra byte in
a few arrays based on this define.

ok gilles@

- when declaring a static table for userinfo, do not make username part of
the value as it confuses users
{ gilles => gilles:10:100:/home } becomes { gilles => 10:100:/home }

ok eric, we'll discuss changes under the hood post-release

unbreak broken smtpctl table update

fix by eric and I, ok eric@

Sync with our smtpd repo:

* first bricks of ldap and sqlite support (not finished but both working)
* new table API to replace map API, all lookups are done through tables
* improved handling of temporary errors throughout the daemon
* improved scheduler and mta logic: connection reuse, optimizes batches
* improved queue: more tolerant to admin errors, new layout, less disk-IO
* improved memory usage under high load
* SSL certs/keys isolated to lookup process to avoid facing network
* VIRTUAL support improved, fully virtual setups possible now
* runtime tracing of processes through smtpctl trace
* ssl_privsep.c sync-ed with relayd
* ssl.c no longer contains smtpd specific interfaces
* smtpd-specific ssl bits moved to ssl_smtpd.c
* update mail address in copyright

FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE.

smtpd.conf(5) simplified, it will require adaptations

ok eric@

type static tables on the fly when the first element is added

ok gilles@

fix logging of list entries

use private data structure for managing static table content

ok gilles@

table_fetch() always expect a valid dst pointer.

ok gilles@

introduce dump() and add() table methods, only implemented for static tables.

ok gilles@

pass the table pointer to the lookup()/fecth() methods

ok gilles@

change the close() method to take the table pointer

ok gilles

Make the backend open method return an int to report success.
The implementation is responsible for setting the handle pointer
as needed.

ok gilles@

reorder parameters for consistency

get rid of the unused dict argument in table lookup and fetch api.

ok gilles@

move the table backend name in the backend struct.
remove unused function.

ok gilles@

Simplify the table backend interface: lookup results are returned
as strings, and parsing is handled by the upper layer.

ok gilles@

introduce K_REGEX table type and table_regex_match(), unused for now

ok eric@

rework the table API so that it takes a struct smtpd * context in parameter
of functions creating, looking up or destroying tables.

this is a first step in cleaning up parse.y so it doesn't have side effects
outside of parse_config(), bringing nothing but making code cleaner.

ok millert@

switch smtpd to new grammar

ok eric@

Change the table parser logic. If the table is untyped, determine
its type by examining the first entry: if it contains a separator, type
is "mapping", otherwise type is "list". All entries are then parsed
according to the table type. The "list" type can also be forced by using
the "@list" directive in a comment. This allows to define list of entries
containing a separator.

Also, log parse errors.

ok gilles@

remove useless indirection for reading the file content

ok gilles@

add a log_warn() so that when smtpd fails to start due to a problem reading
the configuration file of a table, user actually understands what happens

diff by Alexis Vachette, ok jung@

remove spaces after '!'

no binary change

ok millert

Wrap long lines.

Ok gilles@ jung@

teach table_db and table_static about mailaddr maps (unused yet)

ok sunil@, ok jung@

Convert some fgetln to getline.

Ok gilles@, giovanni@, millert@

use <limits.h> comprehensively. For now try to push <> includes to
each .c file, and out of the .h files. To avoid overinclude.
ok gilles, in principle. If this has been done right, -portable should
become easier to maintain.

Update the table API: lookup functions can take an optional parameters
dictionnary (currently not set). While there, add a helper for forking
external backends, and remove unused table functions.

ok gilles@

unsigned char casts for ctype
ok gilles@

change dict_poproot() prototype: do not take key placeholder parameter as
it can't work that way.

alias files may be empty

sync with OpenSMTPD 5.3.2

ok gilles@

replace MAX_LINE_SIZE and SMTP_LINE_MAX with SMTPD_MAXLINESIZE for
consistency and clarity. Remove useless and confusing extra byte in
a few arrays based on this define.

ok gilles@

- when declaring a static table for userinfo, do not make username part of
the value as it confuses users
{ gilles => gilles:10:100:/home } becomes { gilles => 10:100:/home }

ok eric, we'll discuss changes under the hood post-release

unbreak broken smtpctl table update

fix by eric and I, ok eric@

Sync with our smtpd repo:

* first bricks of ldap and sqlite support (not finished but both working)
* new table API to replace map API, all lookups are done through tables
* improved handling of temporary errors throughout the daemon
* improved scheduler and mta logic: connection reuse, optimizes batches
* improved queue: more tolerant to admin errors, new layout, less disk-IO
* improved memory usage under high load
* SSL certs/keys isolated to lookup process to avoid facing network
* VIRTUAL support improved, fully virtual setups possible now
* runtime tracing of processes through smtpctl trace
* ssl_privsep.c sync-ed with relayd
* ssl.c no longer contains smtpd specific interfaces
* smtpd-specific ssl bits moved to ssl_smtpd.c
* update mail address in copyright

FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE.

smtpd.conf(5) simplified, it will require adaptations

ok eric@

get rid of the unused dict argument in table lookup and fetch api.

ok gilles@

move the table backend name in the backend struct.
remove unused function.

ok gilles@

Simplify the table backend interface: lookup results are returned
as strings, and parsing is handled by the upper layer.

ok gilles@

introduce K_REGEX table type and table_regex_match(), unused for now

ok eric@

rework the table API so that it takes a struct smtpd * context in parameter
of functions creating, looking up or destroying tables.

this is a first step in cleaning up parse.y so it doesn't have side effects
outside of parse_config(), bringing nothing but making code cleaner.

ok millert@

switch smtpd to new grammar

ok eric@

Change the table parser logic. If the table is untyped, determine
its type by examining the first entry: if it contains a separator, type
is "mapping", otherwise type is "list". All entries are then parsed
according to the table type. The "list" type can also be forced by using
the "@list" directive in a comment. This allows to define list of entries
containing a separator.

Also, log parse errors.

ok gilles@

remove useless indirection for reading the file content

ok gilles@

add a log_warn() so that when smtpd fails to start due to a problem reading
the configuration file of a table, user actually understands what happens

diff by Alexis Vachette, ok jung@

remove spaces after '!'

no binary change

ok millert

Wrap long lines.

Ok gilles@ jung@

teach table_db and table_static about mailaddr maps (unused yet)

ok sunil@, ok jung@

Convert some fgetln to getline.

Ok gilles@, giovanni@, millert@

use <limits.h> comprehensively. For now try to push <> includes to
each .c file, and out of the .h files. To avoid overinclude.
ok gilles, in principle. If this has been done right, -portable should
become easier to maintain.

Update the table API: lookup functions can take an optional parameters
dictionnary (currently not set). While there, add a helper for forking
external backends, and remove unused table functions.

ok gilles@

unsigned char casts for ctype
ok gilles@

change dict_poproot() prototype: do not take key placeholder parameter as
it can't work that way.

alias files may be empty

sync with OpenSMTPD 5.3.2

ok gilles@

replace MAX_LINE_SIZE and SMTP_LINE_MAX with SMTPD_MAXLINESIZE for
consistency and clarity. Remove useless and confusing extra byte in
a few arrays based on this define.

ok gilles@

- when declaring a static table for userinfo, do not make username part of
the value as it confuses users
{ gilles => gilles:10:100:/home } becomes { gilles => 10:100:/home }

ok eric, we'll discuss changes under the hood post-release

unbreak broken smtpctl table update

fix by eric and I, ok eric@

Sync with our smtpd repo:

* first bricks of ldap and sqlite support (not finished but both working)
* new table API to replace map API, all lookups are done through tables
* improved handling of temporary errors throughout the daemon
* improved scheduler and mta logic: connection reuse, optimizes batches
* improved queue: more tolerant to admin errors, new layout, less disk-IO
* improved memory usage under high load
* SSL certs/keys isolated to lookup process to avoid facing network
* VIRTUAL support improved, fully virtual setups possible now
* runtime tracing of processes through smtpctl trace
* ssl_privsep.c sync-ed with relayd
* ssl.c no longer contains smtpd specific interfaces
* smtpd-specific ssl bits moved to ssl_smtpd.c
* update mail address in copyright

FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE.

smtpd.conf(5) simplified, it will require adaptations

ok eric@

Simplify the table backend interface: lookup results are returned
as strings, and parsing is handled by the upper layer.

ok gilles@

introduce K_REGEX table type and table_regex_match(), unused for now

ok eric@

rework the table API so that it takes a struct smtpd * context in parameter
of functions creating, looking up or destroying tables.

this is a first step in cleaning up parse.y so it doesn't have side effects
outside of parse_config(), bringing nothing but making code cleaner.

ok millert@

switch smtpd to new grammar

ok eric@

Change the table parser logic. If the table is untyped, determine
its type by examining the first entry: if it contains a separator, type
is "mapping", otherwise type is "list". All entries are then parsed
according to the table type. The "list" type can also be forced by using
the "@list" directive in a comment. This allows to define list of entries
containing a separator.

Also, log parse errors.

ok gilles@

remove useless indirection for reading the file content

ok gilles@

add a log_warn() so that when smtpd fails to start due to a problem reading
the configuration file of a table, user actually understands what happens

diff by Alexis Vachette, ok jung@

remove spaces after '!'

no binary change

ok millert

Wrap long lines.

Ok gilles@ jung@

teach table_db and table_static about mailaddr maps (unused yet)

ok sunil@, ok jung@

Convert some fgetln to getline.

Ok gilles@, giovanni@, millert@

use <limits.h> comprehensively. For now try to push <> includes to
each .c file, and out of the .h files. To avoid overinclude.
ok gilles, in principle. If this has been done right, -portable should
become easier to maintain.

Update the table API: lookup functions can take an optional parameters
dictionnary (currently not set). While there, add a helper for forking
external backends, and remove unused table functions.

ok gilles@

unsigned char casts for ctype
ok gilles@

change dict_poproot() prototype: do not take key placeholder parameter as
it can't work that way.

alias files may be empty

sync with OpenSMTPD 5.3.2

ok gilles@

replace MAX_LINE_SIZE and SMTP_LINE_MAX with SMTPD_MAXLINESIZE for
consistency and clarity. Remove useless and confusing extra byte in
a few arrays based on this define.

ok gilles@

- when declaring a static table for userinfo, do not make username part of
the value as it confuses users
{ gilles => gilles:10:100:/home } becomes { gilles => 10:100:/home }

ok eric, we'll discuss changes under the hood post-release

unbreak broken smtpctl table update

fix by eric and I, ok eric@

Sync with our smtpd repo:

* first bricks of ldap and sqlite support (not finished but both working)
* new table API to replace map API, all lookups are done through tables
* improved handling of temporary errors throughout the daemon
* improved scheduler and mta logic: connection reuse, optimizes batches
* improved queue: more tolerant to admin errors, new layout, less disk-IO
* improved memory usage under high load
* SSL certs/keys isolated to lookup process to avoid facing network
* VIRTUAL support improved, fully virtual setups possible now
* runtime tracing of processes through smtpctl trace
* ssl_privsep.c sync-ed with relayd
* ssl.c no longer contains smtpd specific interfaces
* smtpd-specific ssl bits moved to ssl_smtpd.c
* update mail address in copyright

FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE.

smtpd.conf(5) simplified, it will require adaptations

ok eric@

introduce K_REGEX table type and table_regex_match(), unused for now

ok eric@

rework the table API so that it takes a struct smtpd * context in parameter
of functions creating, looking up or destroying tables.

this is a first step in cleaning up parse.y so it doesn't have side effects
outside of parse_config(), bringing nothing but making code cleaner.

ok millert@

switch smtpd to new grammar

ok eric@

Change the table parser logic. If the table is untyped, determine
its type by examining the first entry: if it contains a separator, type
is "mapping", otherwise type is "list". All entries are then parsed
according to the table type. The "list" type can also be forced by using
the "@list" directive in a comment. This allows to define list of entries
containing a separator.

Also, log parse errors.

ok gilles@

remove useless indirection for reading the file content

ok gilles@

add a log_warn() so that when smtpd fails to start due to a problem reading
the configuration file of a table, user actually understands what happens

diff by Alexis Vachette, ok jung@

remove spaces after '!'

no binary change

ok millert

Wrap long lines.

Ok gilles@ jung@

teach table_db and table_static about mailaddr maps (unused yet)

ok sunil@, ok jung@

Convert some fgetln to getline.

Ok gilles@, giovanni@, millert@

use <limits.h> comprehensively. For now try to push <> includes to
each .c file, and out of the .h files. To avoid overinclude.
ok gilles, in principle. If this has been done right, -portable should
become easier to maintain.

Update the table API: lookup functions can take an optional parameters
dictionnary (currently not set). While there, add a helper for forking
external backends, and remove unused table functions.

ok gilles@

unsigned char casts for ctype
ok gilles@

change dict_poproot() prototype: do not take key placeholder parameter as
it can't work that way.

alias files may be empty

sync with OpenSMTPD 5.3.2

ok gilles@

replace MAX_LINE_SIZE and SMTP_LINE_MAX with SMTPD_MAXLINESIZE for
consistency and clarity. Remove useless and confusing extra byte in
a few arrays based on this define.

ok gilles@

- when declaring a static table for userinfo, do not make username part of
the value as it confuses users
{ gilles => gilles:10:100:/home } becomes { gilles => 10:100:/home }

ok eric, we'll discuss changes under the hood post-release

unbreak broken smtpctl table update

fix by eric and I, ok eric@

Sync with our smtpd repo:

* first bricks of ldap and sqlite support (not finished but both working)
* new table API to replace map API, all lookups are done through tables
* improved handling of temporary errors throughout the daemon
* improved scheduler and mta logic: connection reuse, optimizes batches
* improved queue: more tolerant to admin errors, new layout, less disk-IO
* improved memory usage under high load
* SSL certs/keys isolated to lookup process to avoid facing network
* VIRTUAL support improved, fully virtual setups possible now
* runtime tracing of processes through smtpctl trace
* ssl_privsep.c sync-ed with relayd
* ssl.c no longer contains smtpd specific interfaces
* smtpd-specific ssl bits moved to ssl_smtpd.c
* update mail address in copyright

FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE.

smtpd.conf(5) simplified, it will require adaptations

ok eric@

rework the table API so that it takes a struct smtpd * context in parameter
of functions creating, looking up or destroying tables.

this is a first step in cleaning up parse.y so it doesn't have side effects
outside of parse_config(), bringing nothing but making code cleaner.

ok millert@

switch smtpd to new grammar

ok eric@

Change the table parser logic. If the table is untyped, determine
its type by examining the first entry: if it contains a separator, type
is "mapping", otherwise type is "list". All entries are then parsed
according to the table type. The "list" type can also be forced by using
the "@list" directive in a comment. This allows to define list of entries
containing a separator.

Also, log parse errors.

ok gilles@

remove useless indirection for reading the file content

ok gilles@

add a log_warn() so that when smtpd fails to start due to a problem reading
the configuration file of a table, user actually understands what happens

diff by Alexis Vachette, ok jung@

remove spaces after '!'

no binary change

ok millert

Wrap long lines.

Ok gilles@ jung@

teach table_db and table_static about mailaddr maps (unused yet)

ok sunil@, ok jung@

Convert some fgetln to getline.

Ok gilles@, giovanni@, millert@

use <limits.h> comprehensively. For now try to push <> includes to
each .c file, and out of the .h files. To avoid overinclude.
ok gilles, in principle. If this has been done right, -portable should
become easier to maintain.

Update the table API: lookup functions can take an optional parameters
dictionnary (currently not set). While there, add a helper for forking
external backends, and remove unused table functions.

ok gilles@

unsigned char casts for ctype
ok gilles@

change dict_poproot() prototype: do not take key placeholder parameter as
it can't work that way.

alias files may be empty

sync with OpenSMTPD 5.3.2

ok gilles@

replace MAX_LINE_SIZE and SMTP_LINE_MAX with SMTPD_MAXLINESIZE for
consistency and clarity. Remove useless and confusing extra byte in
a few arrays based on this define.

ok gilles@

- when declaring a static table for userinfo, do not make username part of
the value as it confuses users
{ gilles => gilles:10:100:/home } becomes { gilles => 10:100:/home }

ok eric, we'll discuss changes under the hood post-release

unbreak broken smtpctl table update

fix by eric and I, ok eric@

Sync with our smtpd repo:

* first bricks of ldap and sqlite support (not finished but both working)
* new table API to replace map API, all lookups are done through tables
* improved handling of temporary errors throughout the daemon
* improved scheduler and mta logic: connection reuse, optimizes batches
* improved queue: more tolerant to admin errors, new layout, less disk-IO
* improved memory usage under high load
* SSL certs/keys isolated to lookup process to avoid facing network
* VIRTUAL support improved, fully virtual setups possible now
* runtime tracing of processes through smtpctl trace
* ssl_privsep.c sync-ed with relayd
* ssl.c no longer contains smtpd specific interfaces
* smtpd-specific ssl bits moved to ssl_smtpd.c
* update mail address in copyright

FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE.

smtpd.conf(5) simplified, it will require adaptations

ok eric@

Change the table parser logic. If the table is untyped, determine
its type by examining the first entry: if it contains a separator, type
is "mapping", otherwise type is "list". All entries are then parsed
according to the table type. The "list" type can also be forced by using
the "@list" directive in a comment. This allows to define list of entries
containing a separator.

Also, log parse errors.

ok gilles@

remove useless indirection for reading the file content

ok gilles@

add a log_warn() so that when smtpd fails to start due to a problem reading
the configuration file of a table, user actually understands what happens

diff by Alexis Vachette, ok jung@

remove spaces after '!'

no binary change

ok millert

Wrap long lines.

Ok gilles@ jung@

teach table_db and table_static about mailaddr maps (unused yet)

ok sunil@, ok jung@

Convert some fgetln to getline.

Ok gilles@, giovanni@, millert@

use <limits.h> comprehensively. For now try to push <> includes to
each .c file, and out of the .h files. To avoid overinclude.
ok gilles, in principle. If this has been done right, -portable should
become easier to maintain.

Update the table API: lookup functions can take an optional parameters
dictionnary (currently not set). While there, add a helper for forking
external backends, and remove unused table functions.

ok gilles@

unsigned char casts for ctype
ok gilles@

change dict_poproot() prototype: do not take key placeholder parameter as
it can't work that way.

alias files may be empty

sync with OpenSMTPD 5.3.2

ok gilles@

replace MAX_LINE_SIZE and SMTP_LINE_MAX with SMTPD_MAXLINESIZE for
consistency and clarity. Remove useless and confusing extra byte in
a few arrays based on this define.

ok gilles@

- when declaring a static table for userinfo, do not make username part of
the value as it confuses users
{ gilles => gilles:10:100:/home } becomes { gilles => 10:100:/home }

ok eric, we'll discuss changes under the hood post-release

unbreak broken smtpctl table update

fix by eric and I, ok eric@

Sync with our smtpd repo:

* first bricks of ldap and sqlite support (not finished but both working)
* new table API to replace map API, all lookups are done through tables
* improved handling of temporary errors throughout the daemon
* improved scheduler and mta logic: connection reuse, optimizes batches
* improved queue: more tolerant to admin errors, new layout, less disk-IO
* improved memory usage under high load
* SSL certs/keys isolated to lookup process to avoid facing network
* VIRTUAL support improved, fully virtual setups possible now
* runtime tracing of processes through smtpctl trace
* ssl_privsep.c sync-ed with relayd
* ssl.c no longer contains smtpd specific interfaces
* smtpd-specific ssl bits moved to ssl_smtpd.c
* update mail address in copyright

FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE. FLUSH YOUR QUEUE.

smtpd.conf(5) simplified, it will require adaptations

ok eric@