When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Switch base tools from /dev/bpf0 to /dev/bpf. Now that /dev/bpf has been
around for two releases, it should be safe to do so.

ok bluhm deraadt sthen tb yasuoka

Replace the /dev/bpf* open loop with a plain open("/dev/bpf0", ...).
ok deraadt jca

Replace bcopy() from struct bpf_timeval to struct timeval; those
structures are not exchangeable. This should unbreak connection timeouts
in rbootd, although I can't verify due to lack of rboot-able hardware.
ok guenther millert

stdlib.h is in scope; do not cast malloc/calloc/realloc*
ok millert krw

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

remove bogus comment

unsigned char for ctype
ok okan krw

Use offsetof() instead of rolling our own; gets rid of truncation warnings
when building on 64-bit hosts.
"looks good" deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

write filter and lock bpf descriptor before dropping privileges,
with help from otto@, tested by mickey@ and jolan@, ok deraadt@

priv revoking; tested by millert

one missing freeifaddrs

rewrite SIOCGIFCONF into getifaddrs. deraadt ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi & knf

more strlcat and strlcpy

more sprintf

unsigned to unsigned int

kill more registers.

millert@ ok

Fix the signal races in rbootd.
Credit to millert@ and deraadt@ for pointing out some of my braindamage.

OpenBSD-ify.

according to the strlcpy man page the order of arguments
is: destination, source, size.
it seems in the commit of version 1.3 a couple of maxwell daemons
of the second kind exchanged second and third arguments in every
call to the stlcpy, thanks gcc.
at this late hour we hope they are up to their eternity-spanning
poker game for hot molecules and the diff will finally get in untampered.

buf oflow safe

repair byte order botches; from scottr@plexus.com via netbsd

branches: 1.1.1;
Initial revision

Switch base tools from /dev/bpf0 to /dev/bpf. Now that /dev/bpf has been
around for two releases, it should be safe to do so.

ok bluhm deraadt sthen tb yasuoka

Replace the /dev/bpf* open loop with a plain open("/dev/bpf0", ...).
ok deraadt jca

Replace bcopy() from struct bpf_timeval to struct timeval; those
structures are not exchangeable. This should unbreak connection timeouts
in rbootd, although I can't verify due to lack of rboot-able hardware.
ok guenther millert

stdlib.h is in scope; do not cast malloc/calloc/realloc*
ok millert krw

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

remove bogus comment

unsigned char for ctype
ok okan krw

Use offsetof() instead of rolling our own; gets rid of truncation warnings
when building on 64-bit hosts.
"looks good" deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

write filter and lock bpf descriptor before dropping privileges,
with help from otto@, tested by mickey@ and jolan@, ok deraadt@

priv revoking; tested by millert

one missing freeifaddrs

rewrite SIOCGIFCONF into getifaddrs. deraadt ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi & knf

more strlcat and strlcpy

more sprintf

unsigned to unsigned int

kill more registers.

millert@ ok

Fix the signal races in rbootd.
Credit to millert@ and deraadt@ for pointing out some of my braindamage.

OpenBSD-ify.

according to the strlcpy man page the order of arguments
is: destination, source, size.
it seems in the commit of version 1.3 a couple of maxwell daemons
of the second kind exchanged second and third arguments in every
call to the stlcpy, thanks gcc.
at this late hour we hope they are up to their eternity-spanning
poker game for hot molecules and the diff will finally get in untampered.

buf oflow safe

repair byte order botches; from scottr@plexus.com via netbsd

branches: 1.1.1;
Initial revision