Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.

Use (char *)NULL consistently instead of scattering a few (char *)0
and (void *)NULL into the mix.

Prompted by and probably ok deraadt@ millert@ kettenis@

Definitely ok mestre@ ratchov@

Use __progname instead of manually handling argv[0].

ok deraadt, mmcc, tedu

stop saving a pidfile; ok jung zhuk

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

easy obvious use of reallocarray(); ok doug

Remove some unused code, from Michael W Bombardieri. ok yasuoka

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

bye bye ipx

setres[ug]id; ok millert@

Remove unused %r (recursive) format option. ok millert@

amd64 needs the same hack as powerpc; but this code really needs to be
deleted/replaced. anyone want to step up?

comment cleanup

obvious spring cleanup

strlcpy and snprintf; various people ok

Replace an instance of chmod() with fchmod()

license update of CMU parts. due to communication with wcw+@andrew.cmu.edu,
pushed for by tygs@netcologne.de. Apparently we also now known how to talk
to the lawyers there, if we were so mad. Note that a few other copyright
issues in pppd still remain, so this does not close this story.

pid_t cleanup

be even more clear

do not install a SIGSEGV handler

branches: 1.34.2;
We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

some syslog_r uses in signal handlers

branches: 1.31.2;
the signal handlers can many illegal functions. try to at least be cautious.
parts from mickey, parts from me.

exit(-#) is wrong

check return value for setenv(3) for failure, and deal appropriately

handle direct lines correctly; rees

uid_t and gid_t, and use %u

drop packets silently while the link is down, which is a better approximation
to the real networks, ie simulating an open wire w/ tokens falling down
angelos@ ok

Implement demand_drop() for demand mode pppd; try to avoid mbuf
exhaustion while setting up a connection.

do not syslog() with "\n"; skipped smtpd/named/ipmon; 12 minutes of dabbling

hostnames are MAXHOSTNAMELEN, not MAXNAMELEN

pppd 2.3.5

ppp-2.3.3 + some -Wall

clear CLOCAL if modem is set but modem_chat is not.

Set CLOCAL for chat script by default. Add new option "modem_chat"
to override the default for people using cua devices who want chat
to detect loss of carrier.

ppp 2.3.1

save errno in sigchld handlers

#if __STDC__ --> #ifdef __STDC__

Changed definition of 'a' in vfmtmsg from void * to va_list.
Possible fix for PR#130.

Pedantic removal of extra spaces

pppd 2.3b3 import. some minor buf oflow fixes and so.
try it out ppl, but i've got it running talking to cisco w/ all the AFs
enabled in kernel.

Deal with _POSIX_SAVED_IDS when relinquishing privileges

exit 1 for failure if -detach; netbsd pr#2705; jbernard@tater.Mines.EDU

pass a minimal environment ($PATH)

Update pppd to 2.3a4:
Add redo option error-reporting, add PAM, add microsoft compatibility
kludges, bzero stuff at important places, add one or two options
other generic enhancements. From: Paul.Mackerras@cs.anu.edu.au

parse args before tty options file; netbsd pr#2554; from Davyd.Norris@fcollins.com.au

check before unlinking pidfile

sync to netbsd 960418

From NetBSD: merge of 960317

sleep() call not needed (from NetBSD).

pass a useful environment to ip-up/ip-down scripts; this is not a
security problem
different fix than from banshee@gabriella.resort.com; netbsd pr#1866

Leave DTR down for one second on exit so modem may catch the DTR to false
transition. (from hannken@eis.cs.tu-bs.de)

branches: 1.1.1;
Initial revision

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.

Use (char *)NULL consistently instead of scattering a few (char *)0
and (void *)NULL into the mix.

Prompted by and probably ok deraadt@ millert@ kettenis@

Definitely ok mestre@ ratchov@

Use __progname instead of manually handling argv[0].

ok deraadt, mmcc, tedu

stop saving a pidfile; ok jung zhuk

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

easy obvious use of reallocarray(); ok doug

Remove some unused code, from Michael W Bombardieri. ok yasuoka

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

bye bye ipx

setres[ug]id; ok millert@

Remove unused %r (recursive) format option. ok millert@

amd64 needs the same hack as powerpc; but this code really needs to be
deleted/replaced. anyone want to step up?

comment cleanup

obvious spring cleanup

strlcpy and snprintf; various people ok

Replace an instance of chmod() with fchmod()

license update of CMU parts. due to communication with wcw+@andrew.cmu.edu,
pushed for by tygs@netcologne.de. Apparently we also now known how to talk
to the lawyers there, if we were so mad. Note that a few other copyright
issues in pppd still remain, so this does not close this story.

pid_t cleanup

be even more clear

do not install a SIGSEGV handler

branches: 1.34.2;
We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

some syslog_r uses in signal handlers

branches: 1.31.2;
the signal handlers can many illegal functions. try to at least be cautious.
parts from mickey, parts from me.

exit(-#) is wrong

check return value for setenv(3) for failure, and deal appropriately

handle direct lines correctly; rees

uid_t and gid_t, and use %u

drop packets silently while the link is down, which is a better approximation
to the real networks, ie simulating an open wire w/ tokens falling down
angelos@ ok

Implement demand_drop() for demand mode pppd; try to avoid mbuf
exhaustion while setting up a connection.

do not syslog() with "\n"; skipped smtpd/named/ipmon; 12 minutes of dabbling

hostnames are MAXHOSTNAMELEN, not MAXNAMELEN

pppd 2.3.5

ppp-2.3.3 + some -Wall

clear CLOCAL if modem is set but modem_chat is not.

Set CLOCAL for chat script by default. Add new option "modem_chat"
to override the default for people using cua devices who want chat
to detect loss of carrier.

ppp 2.3.1

save errno in sigchld handlers

#if __STDC__ --> #ifdef __STDC__

Changed definition of 'a' in vfmtmsg from void * to va_list.
Possible fix for PR#130.

Pedantic removal of extra spaces

pppd 2.3b3 import. some minor buf oflow fixes and so.
try it out ppl, but i've got it running talking to cisco w/ all the AFs
enabled in kernel.

Deal with _POSIX_SAVED_IDS when relinquishing privileges

exit 1 for failure if -detach; netbsd pr#2705; jbernard@tater.Mines.EDU

pass a minimal environment ($PATH)

Update pppd to 2.3a4:
Add redo option error-reporting, add PAM, add microsoft compatibility
kludges, bzero stuff at important places, add one or two options
other generic enhancements. From: Paul.Mackerras@cs.anu.edu.au

parse args before tty options file; netbsd pr#2554; from Davyd.Norris@fcollins.com.au

check before unlinking pidfile

sync to netbsd 960418

From NetBSD: merge of 960317

sleep() call not needed (from NetBSD).

pass a useful environment to ip-up/ip-down scripts; this is not a
security problem
different fix than from banshee@gabriella.resort.com; netbsd pr#1866

Leave DTR down for one second on exit so modem may catch the DTR to false
transition. (from hannken@eis.cs.tu-bs.de)

branches: 1.1.1;
Initial revision

Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.

Use (char *)NULL consistently instead of scattering a few (char *)0
and (void *)NULL into the mix.

Prompted by and probably ok deraadt@ millert@ kettenis@

Definitely ok mestre@ ratchov@

Use __progname instead of manually handling argv[0].

ok deraadt, mmcc, tedu

stop saving a pidfile; ok jung zhuk

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

easy obvious use of reallocarray(); ok doug

Remove some unused code, from Michael W Bombardieri. ok yasuoka

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

bye bye ipx

setres[ug]id; ok millert@

Remove unused %r (recursive) format option. ok millert@

amd64 needs the same hack as powerpc; but this code really needs to be
deleted/replaced. anyone want to step up?

comment cleanup

obvious spring cleanup

strlcpy and snprintf; various people ok

Replace an instance of chmod() with fchmod()

license update of CMU parts. due to communication with wcw+@andrew.cmu.edu,
pushed for by tygs@netcologne.de. Apparently we also now known how to talk
to the lawyers there, if we were so mad. Note that a few other copyright
issues in pppd still remain, so this does not close this story.

pid_t cleanup

be even more clear

do not install a SIGSEGV handler

branches: 1.34.2;
We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

some syslog_r uses in signal handlers

branches: 1.31.2;
the signal handlers can many illegal functions. try to at least be cautious.
parts from mickey, parts from me.

exit(-#) is wrong

check return value for setenv(3) for failure, and deal appropriately

handle direct lines correctly; rees

uid_t and gid_t, and use %u

drop packets silently while the link is down, which is a better approximation
to the real networks, ie simulating an open wire w/ tokens falling down
angelos@ ok

Implement demand_drop() for demand mode pppd; try to avoid mbuf
exhaustion while setting up a connection.

do not syslog() with "\n"; skipped smtpd/named/ipmon; 12 minutes of dabbling

hostnames are MAXHOSTNAMELEN, not MAXNAMELEN

pppd 2.3.5

ppp-2.3.3 + some -Wall

clear CLOCAL if modem is set but modem_chat is not.

Set CLOCAL for chat script by default. Add new option "modem_chat"
to override the default for people using cua devices who want chat
to detect loss of carrier.

ppp 2.3.1

save errno in sigchld handlers

#if __STDC__ --> #ifdef __STDC__

Changed definition of 'a' in vfmtmsg from void * to va_list.
Possible fix for PR#130.

Pedantic removal of extra spaces

pppd 2.3b3 import. some minor buf oflow fixes and so.
try it out ppl, but i've got it running talking to cisco w/ all the AFs
enabled in kernel.

Deal with _POSIX_SAVED_IDS when relinquishing privileges

exit 1 for failure if -detach; netbsd pr#2705; jbernard@tater.Mines.EDU

pass a minimal environment ($PATH)

Update pppd to 2.3a4:
Add redo option error-reporting, add PAM, add microsoft compatibility
kludges, bzero stuff at important places, add one or two options
other generic enhancements. From: Paul.Mackerras@cs.anu.edu.au

parse args before tty options file; netbsd pr#2554; from Davyd.Norris@fcollins.com.au

check before unlinking pidfile

sync to netbsd 960418

From NetBSD: merge of 960317

sleep() call not needed (from NetBSD).

pass a useful environment to ip-up/ip-down scripts; this is not a
security problem
different fix than from banshee@gabriella.resort.com; netbsd pr#1866

Leave DTR down for one second on exit so modem may catch the DTR to false
transition. (from hannken@eis.cs.tu-bs.de)

branches: 1.1.1;
Initial revision