style(9), no functionnal change.

Externalise the output aspect of ospfctl.

It is the first step towards implementing json output support.

Diff by Richard Chivers <r.chivers () zengenti . com>, based on
Claudio's work. Thanks !

OK claudio@

Correctly group initialization of AF_UNIX socket.
spotted by deraadt in new code, sweep by me.
OK deraadt

Change the control socket to ospfd.sock.<rdomain>.

ok friehm@ jca@

Also print the mtu when showing interface details

ok sthen@ benno@

Another imsg_read EAGAIN check. OK benno@

There is still a bit of an issue with connected routes in the RIB. Print
what ospfd thinks is connected by adding a 'C' to the nexthop output.

can use pledge "stdio"; ok benno

As done for bgpd recently, rename if_mediatype to if_type in ospfd/ospf6d.
And some ifmedia64 fixes.
"move forward" deraadt@

match a few if_media uint64_t conversions; ok miod

handle msgbuf_write() returning EAGAIN, looks right to deraadt

do not store a time_t or the result of a time_t division in an int

prompted by deraadt@, ok claudio@ chl@ guenther@

ospfctl bits for opaque LSA support.
tested and OK sthen@

Print the checksum sum as a simple fingerprint of the LSDB.
OK dlg@

Print 'Number of Routers' in show database network.
ok claudio@

implement ospfctl fib reload.

this tells the daemon to resync the kernels list of interfaces and routes
with the daemons list. this is very useful if the routing socket overflows
and you want to sync things up again.

lots and lots of help from claudio@
ok claudio@

implement support for fast hello packets.

if route-dead-time is set to "minimal" (rather than a number of
seconds), the dead time is set to 1 second and hellos are sent at
the interval specified by fast-hello-interval in msecs. this is non
standard wrt to the ospf rfc, but it does interoperate with at least
one other router vendor.

this allows much better responsiveness to l3 topology changes than
the standard intervals allow. if i yank a cable to one of my
upstreams, the routes adjust in a second rather than the default
of 40 i was running with before. the users dont even notice something
changed.

developed while working with joshua atterbury.
ok claudio@ as part of a larger diff.
dedicated to zan rowe who thinks she is a bigger nerd than me.

allow spf-delay and spf-holdtime to be specified in msec so ospfd can
better respond to rapid topology changes.

developed while working with joshua atterbury
ok claudio@ as part of a larger diff.

Implement "log verbose" and "log brief" to enable or disable verbose debug
logging. henning, sthen, michele like the idea

Switch the various link state printing codes to use the new if_media
independent LINK_STATE_DESCRIPTIONS. Code is now more or less a one to
one copy of get_linkstate() in route/route.c.
OK henning, michele, sthen, deraadt

sync ospfctl/ospfd with the common imsg code, making it lib ready as well.

"looks ok" claudio@

forgot to commit the ospfctl bits, this unbreaks the tree.
noticed by michele@

allow to specify an alternate control socket instead of /var/run/ospfd.sock.
this is required to run multiple instances of ospfd.

ok claudio@

Add missing free.

OK claudio@

In show interface only print the hello_timer value if valid.

ospfd knows now priorities so let ospfctl know and print them as well.

the ellipsis allows more than one argument being specified.

discussed with gilles@

ok jmc@

specifying int instead of just unsigned is better style

please lint

Cleanup the way we display timers.

It does not make sense to display timer = 0 as "Stopped". When a timer is
0 it usually means that it is getting reset very soon. Display the string
"00:00:00" instead.

ok claudio@

Baudrate is 64bit so use %llu in printf(). Reminded by chl@

yuck, no cookie for me

add additional link states to report the half duplex / full duplex
state, if known by the driver. this is required to check the full
duplex state without depending on the ifmedia ioctl which can't be
called in the kernel without process context.

ok henning@, brad@

Add a comment about the empty imsg_event_add() function to make it clear
why it is needed.

Track the uptime of the ospfd daemon itself.
It is possible to read the uptime of the daemon with the "ospfctl show"
command.

ok claudio@

Add IFT_PPP to the iftype to ifmedia type conversion function. Now P2P links
will show the correct link state. While there do some cleanup and shorten the
output if the media or link state is unknown.

Show the neighbor uptime in "show nei detail".

ok claudio@

Show the link status of interfaces for real, I guess most users don't know
what it means that an interface is in state 2.

ok claudio@

List interfaces they way we list neighbors etc.
This makes it much easier to grep in the output.
The original format of "show interface" can be seen with
"show interface detail".

help and ok claudio@

ospfd has the framework to couple and decouple the FIB. Add the needed
functionality to ospfctl for it.
NOTE: decoupling the FIB one a router may totaly fuck up the complete network.
Use it with care!
OK norby@

Track interface uptime.

ok claudio@

Start using *_name function that are now shared between ospfd and ospfctl.
OK norby@

Last kroute.c commit changed the meaning of the flags so check them correctly.
OK norby@

Keep track of the uptime of the entries in the RIB.
It is now possible to see the uptime of the individual entries in the RIB.
The uptime can be displayed with "ospfctl show rib"

ok claudio@

Keep track of the duration of our relationships with neighbors.
Displayed in "ospfctl show neighbor".

ok claudio@

imsg API changed so adapt to it.

indicate passive interface in 'show interface'; ok claudio@

use err() vs. fatal(); ok claudio@

remove duplicate function declaration; ok claudio@

missing break caused erroneous auth-type crypt enabled in 'sh int'
when simple enabled; ok claudio@

- add auth_type and auth_keyid to struct ctl_iface
- have ospfctl tell us when we are using authentication with 'show interface'

ok claudio@ norby@

Small formatting bits in show neighbor detail.

ok claudio@

Fix multi area display bug.

ok claudio@

Add missing bits to ospfctl show rib detail.

ok claudio@

Add "show database asbr/external/network/router/self-originate/summary"
to ospfctl.

Show detailed information about the LSAs in the Link State Database.

ok claudio@

Fix a display bug in 'show database', when ospfd is member of more
than one area.

Input from claudio.

ok claudio@

Static routes are flagged with F_STATIC and not with F_KERNEL.

The RFC never mentions anything about transfer, this should be transmit.

From Jason Ackley (thanks).

ok claudio@

ospfctl bits for the "ospfctl show fib interface" part. This will print
the interface status as seen from the parent kroute perspective.
OK henning@ norby@

Sync mask2prefixlen() with the kroute.c version of ospfd because they share
the same prototype definition comming from ospfd.h.
OK norby@

bgpctl parts for "show fib".
OK norby@ deraadt@

Add "show summary" to ospfctl.

ok claudio@ henning@

Add "show rib" and "show rib detail" to ospfctl.

ok henning@

Small K&F.

ok henning@

KNF

usage() is __dead
pt out by Alexander v Gernler

Change my email address to the OpenBSD one since Ericsson has nothing to
do with this software, just happend to be my only valid email address at
the time.

Control program like bgpctl but this time for ospfd.
Currently only basic show commands work.

Not yet connected to the builds.
OK henning@

Externalise the output aspect of ospfctl.

It is the first step towards implementing json output support.

Diff by Richard Chivers <r.chivers () zengenti . com>, based on
Claudio's work. Thanks !

OK claudio@

Correctly group initialization of AF_UNIX socket.
spotted by deraadt in new code, sweep by me.
OK deraadt

Change the control socket to ospfd.sock.<rdomain>.

ok friehm@ jca@

Also print the mtu when showing interface details

ok sthen@ benno@

Another imsg_read EAGAIN check. OK benno@

There is still a bit of an issue with connected routes in the RIB. Print
what ospfd thinks is connected by adding a 'C' to the nexthop output.

can use pledge "stdio"; ok benno

As done for bgpd recently, rename if_mediatype to if_type in ospfd/ospf6d.
And some ifmedia64 fixes.
"move forward" deraadt@

match a few if_media uint64_t conversions; ok miod

handle msgbuf_write() returning EAGAIN, looks right to deraadt

do not store a time_t or the result of a time_t division in an int

prompted by deraadt@, ok claudio@ chl@ guenther@

ospfctl bits for opaque LSA support.
tested and OK sthen@

Print the checksum sum as a simple fingerprint of the LSDB.
OK dlg@

Print 'Number of Routers' in show database network.
ok claudio@

implement ospfctl fib reload.

this tells the daemon to resync the kernels list of interfaces and routes
with the daemons list. this is very useful if the routing socket overflows
and you want to sync things up again.

lots and lots of help from claudio@
ok claudio@

implement support for fast hello packets.

if route-dead-time is set to "minimal" (rather than a number of
seconds), the dead time is set to 1 second and hellos are sent at
the interval specified by fast-hello-interval in msecs. this is non
standard wrt to the ospf rfc, but it does interoperate with at least
one other router vendor.

this allows much better responsiveness to l3 topology changes than
the standard intervals allow. if i yank a cable to one of my
upstreams, the routes adjust in a second rather than the default
of 40 i was running with before. the users dont even notice something
changed.

developed while working with joshua atterbury.
ok claudio@ as part of a larger diff.
dedicated to zan rowe who thinks she is a bigger nerd than me.

allow spf-delay and spf-holdtime to be specified in msec so ospfd can
better respond to rapid topology changes.

developed while working with joshua atterbury
ok claudio@ as part of a larger diff.

Implement "log verbose" and "log brief" to enable or disable verbose debug
logging. henning, sthen, michele like the idea

Switch the various link state printing codes to use the new if_media
independent LINK_STATE_DESCRIPTIONS. Code is now more or less a one to
one copy of get_linkstate() in route/route.c.
OK henning, michele, sthen, deraadt

sync ospfctl/ospfd with the common imsg code, making it lib ready as well.

"looks ok" claudio@

forgot to commit the ospfctl bits, this unbreaks the tree.
noticed by michele@

allow to specify an alternate control socket instead of /var/run/ospfd.sock.
this is required to run multiple instances of ospfd.

ok claudio@

Add missing free.

OK claudio@

In show interface only print the hello_timer value if valid.

ospfd knows now priorities so let ospfctl know and print them as well.

the ellipsis allows more than one argument being specified.

discussed with gilles@

ok jmc@

specifying int instead of just unsigned is better style

please lint

Cleanup the way we display timers.

It does not make sense to display timer = 0 as "Stopped". When a timer is
0 it usually means that it is getting reset very soon. Display the string
"00:00:00" instead.

ok claudio@

Baudrate is 64bit so use %llu in printf(). Reminded by chl@

yuck, no cookie for me

add additional link states to report the half duplex / full duplex
state, if known by the driver. this is required to check the full
duplex state without depending on the ifmedia ioctl which can't be
called in the kernel without process context.

ok henning@, brad@

Add a comment about the empty imsg_event_add() function to make it clear
why it is needed.

Track the uptime of the ospfd daemon itself.
It is possible to read the uptime of the daemon with the "ospfctl show"
command.

ok claudio@

Add IFT_PPP to the iftype to ifmedia type conversion function. Now P2P links
will show the correct link state. While there do some cleanup and shorten the
output if the media or link state is unknown.

Show the neighbor uptime in "show nei detail".

ok claudio@

Show the link status of interfaces for real, I guess most users don't know
what it means that an interface is in state 2.

ok claudio@

List interfaces they way we list neighbors etc.
This makes it much easier to grep in the output.
The original format of "show interface" can be seen with
"show interface detail".

help and ok claudio@

ospfd has the framework to couple and decouple the FIB. Add the needed
functionality to ospfctl for it.
NOTE: decoupling the FIB one a router may totaly fuck up the complete network.
Use it with care!
OK norby@

Track interface uptime.

ok claudio@

Start using *_name function that are now shared between ospfd and ospfctl.
OK norby@

Last kroute.c commit changed the meaning of the flags so check them correctly.
OK norby@

Keep track of the uptime of the entries in the RIB.
It is now possible to see the uptime of the individual entries in the RIB.
The uptime can be displayed with "ospfctl show rib"

ok claudio@

Keep track of the duration of our relationships with neighbors.
Displayed in "ospfctl show neighbor".

ok claudio@

imsg API changed so adapt to it.

indicate passive interface in 'show interface'; ok claudio@

use err() vs. fatal(); ok claudio@

remove duplicate function declaration; ok claudio@

missing break caused erroneous auth-type crypt enabled in 'sh int'
when simple enabled; ok claudio@

- add auth_type and auth_keyid to struct ctl_iface
- have ospfctl tell us when we are using authentication with 'show interface'

ok claudio@ norby@

Small formatting bits in show neighbor detail.

ok claudio@

Fix multi area display bug.

ok claudio@

Add missing bits to ospfctl show rib detail.

ok claudio@

Add "show database asbr/external/network/router/self-originate/summary"
to ospfctl.

Show detailed information about the LSAs in the Link State Database.

ok claudio@

Fix a display bug in 'show database', when ospfd is member of more
than one area.

Input from claudio.

ok claudio@

Static routes are flagged with F_STATIC and not with F_KERNEL.

The RFC never mentions anything about transfer, this should be transmit.

From Jason Ackley (thanks).

ok claudio@

ospfctl bits for the "ospfctl show fib interface" part. This will print
the interface status as seen from the parent kroute perspective.
OK henning@ norby@

Sync mask2prefixlen() with the kroute.c version of ospfd because they share
the same prototype definition comming from ospfd.h.
OK norby@

bgpctl parts for "show fib".
OK norby@ deraadt@

Add "show summary" to ospfctl.

ok claudio@ henning@

Add "show rib" and "show rib detail" to ospfctl.

ok henning@

Small K&F.

ok henning@

KNF

usage() is __dead
pt out by Alexander v Gernler

Change my email address to the OpenBSD one since Ericsson has nothing to
do with this software, just happend to be my only valid email address at
the time.

Control program like bgpctl but this time for ospfd.
Currently only basic show commands work.

Not yet connected to the builds.
OK henning@

Correctly group initialization of AF_UNIX socket.
spotted by deraadt in new code, sweep by me.
OK deraadt

Change the control socket to ospfd.sock.<rdomain>.

ok friehm@ jca@

Also print the mtu when showing interface details

ok sthen@ benno@

Another imsg_read EAGAIN check. OK benno@

There is still a bit of an issue with connected routes in the RIB. Print
what ospfd thinks is connected by adding a 'C' to the nexthop output.

can use pledge "stdio"; ok benno

As done for bgpd recently, rename if_mediatype to if_type in ospfd/ospf6d.
And some ifmedia64 fixes.
"move forward" deraadt@

match a few if_media uint64_t conversions; ok miod

handle msgbuf_write() returning EAGAIN, looks right to deraadt

do not store a time_t or the result of a time_t division in an int

prompted by deraadt@, ok claudio@ chl@ guenther@

ospfctl bits for opaque LSA support.
tested and OK sthen@

Print the checksum sum as a simple fingerprint of the LSDB.
OK dlg@

Print 'Number of Routers' in show database network.
ok claudio@

implement ospfctl fib reload.

this tells the daemon to resync the kernels list of interfaces and routes
with the daemons list. this is very useful if the routing socket overflows
and you want to sync things up again.

lots and lots of help from claudio@
ok claudio@

implement support for fast hello packets.

if route-dead-time is set to "minimal" (rather than a number of
seconds), the dead time is set to 1 second and hellos are sent at
the interval specified by fast-hello-interval in msecs. this is non
standard wrt to the ospf rfc, but it does interoperate with at least
one other router vendor.

this allows much better responsiveness to l3 topology changes than
the standard intervals allow. if i yank a cable to one of my
upstreams, the routes adjust in a second rather than the default
of 40 i was running with before. the users dont even notice something
changed.

developed while working with joshua atterbury.
ok claudio@ as part of a larger diff.
dedicated to zan rowe who thinks she is a bigger nerd than me.

allow spf-delay and spf-holdtime to be specified in msec so ospfd can
better respond to rapid topology changes.

developed while working with joshua atterbury
ok claudio@ as part of a larger diff.

Implement "log verbose" and "log brief" to enable or disable verbose debug
logging. henning, sthen, michele like the idea

Switch the various link state printing codes to use the new if_media
independent LINK_STATE_DESCRIPTIONS. Code is now more or less a one to
one copy of get_linkstate() in route/route.c.
OK henning, michele, sthen, deraadt

sync ospfctl/ospfd with the common imsg code, making it lib ready as well.

"looks ok" claudio@

forgot to commit the ospfctl bits, this unbreaks the tree.
noticed by michele@

allow to specify an alternate control socket instead of /var/run/ospfd.sock.
this is required to run multiple instances of ospfd.

ok claudio@

Add missing free.

OK claudio@

In show interface only print the hello_timer value if valid.

ospfd knows now priorities so let ospfctl know and print them as well.

the ellipsis allows more than one argument being specified.

discussed with gilles@

ok jmc@

specifying int instead of just unsigned is better style

please lint

Cleanup the way we display timers.

It does not make sense to display timer = 0 as "Stopped". When a timer is
0 it usually means that it is getting reset very soon. Display the string
"00:00:00" instead.

ok claudio@

Baudrate is 64bit so use %llu in printf(). Reminded by chl@

yuck, no cookie for me

add additional link states to report the half duplex / full duplex
state, if known by the driver. this is required to check the full
duplex state without depending on the ifmedia ioctl which can't be
called in the kernel without process context.

ok henning@, brad@

Add a comment about the empty imsg_event_add() function to make it clear
why it is needed.

Track the uptime of the ospfd daemon itself.
It is possible to read the uptime of the daemon with the "ospfctl show"
command.

ok claudio@

Add IFT_PPP to the iftype to ifmedia type conversion function. Now P2P links
will show the correct link state. While there do some cleanup and shorten the
output if the media or link state is unknown.

Show the neighbor uptime in "show nei detail".

ok claudio@

Show the link status of interfaces for real, I guess most users don't know
what it means that an interface is in state 2.

ok claudio@

List interfaces they way we list neighbors etc.
This makes it much easier to grep in the output.
The original format of "show interface" can be seen with
"show interface detail".

help and ok claudio@

ospfd has the framework to couple and decouple the FIB. Add the needed
functionality to ospfctl for it.
NOTE: decoupling the FIB one a router may totaly fuck up the complete network.
Use it with care!
OK norby@

Track interface uptime.

ok claudio@

Start using *_name function that are now shared between ospfd and ospfctl.
OK norby@

Last kroute.c commit changed the meaning of the flags so check them correctly.
OK norby@

Keep track of the uptime of the entries in the RIB.
It is now possible to see the uptime of the individual entries in the RIB.
The uptime can be displayed with "ospfctl show rib"

ok claudio@

Keep track of the duration of our relationships with neighbors.
Displayed in "ospfctl show neighbor".

ok claudio@

imsg API changed so adapt to it.

indicate passive interface in 'show interface'; ok claudio@

use err() vs. fatal(); ok claudio@

remove duplicate function declaration; ok claudio@

missing break caused erroneous auth-type crypt enabled in 'sh int'
when simple enabled; ok claudio@

- add auth_type and auth_keyid to struct ctl_iface
- have ospfctl tell us when we are using authentication with 'show interface'

ok claudio@ norby@

Small formatting bits in show neighbor detail.

ok claudio@

Fix multi area display bug.

ok claudio@

Add missing bits to ospfctl show rib detail.

ok claudio@

Add "show database asbr/external/network/router/self-originate/summary"
to ospfctl.

Show detailed information about the LSAs in the Link State Database.

ok claudio@

Fix a display bug in 'show database', when ospfd is member of more
than one area.

Input from claudio.

ok claudio@

Static routes are flagged with F_STATIC and not with F_KERNEL.

The RFC never mentions anything about transfer, this should be transmit.

From Jason Ackley (thanks).

ok claudio@

ospfctl bits for the "ospfctl show fib interface" part. This will print
the interface status as seen from the parent kroute perspective.
OK henning@ norby@

Sync mask2prefixlen() with the kroute.c version of ospfd because they share
the same prototype definition comming from ospfd.h.
OK norby@

bgpctl parts for "show fib".
OK norby@ deraadt@

Add "show summary" to ospfctl.

ok claudio@ henning@

Add "show rib" and "show rib detail" to ospfctl.

ok henning@

Small K&F.

ok henning@

KNF

usage() is __dead
pt out by Alexander v Gernler

Change my email address to the OpenBSD one since Ericsson has nothing to
do with this software, just happend to be my only valid email address at
the time.

Control program like bgpctl but this time for ospfd.
Currently only basic show commands work.

Not yet connected to the builds.
OK henning@

Change the control socket to ospfd.sock.<rdomain>.

ok friehm@ jca@

Also print the mtu when showing interface details

ok sthen@ benno@

Another imsg_read EAGAIN check. OK benno@

There is still a bit of an issue with connected routes in the RIB. Print
what ospfd thinks is connected by adding a 'C' to the nexthop output.

can use pledge "stdio"; ok benno

As done for bgpd recently, rename if_mediatype to if_type in ospfd/ospf6d.
And some ifmedia64 fixes.
"move forward" deraadt@

match a few if_media uint64_t conversions; ok miod

handle msgbuf_write() returning EAGAIN, looks right to deraadt

do not store a time_t or the result of a time_t division in an int

prompted by deraadt@, ok claudio@ chl@ guenther@

ospfctl bits for opaque LSA support.
tested and OK sthen@

Print the checksum sum as a simple fingerprint of the LSDB.
OK dlg@

Print 'Number of Routers' in show database network.
ok claudio@

implement ospfctl fib reload.

this tells the daemon to resync the kernels list of interfaces and routes
with the daemons list. this is very useful if the routing socket overflows
and you want to sync things up again.

lots and lots of help from claudio@
ok claudio@

implement support for fast hello packets.

if route-dead-time is set to "minimal" (rather than a number of
seconds), the dead time is set to 1 second and hellos are sent at
the interval specified by fast-hello-interval in msecs. this is non
standard wrt to the ospf rfc, but it does interoperate with at least
one other router vendor.

this allows much better responsiveness to l3 topology changes than
the standard intervals allow. if i yank a cable to one of my
upstreams, the routes adjust in a second rather than the default
of 40 i was running with before. the users dont even notice something
changed.

developed while working with joshua atterbury.
ok claudio@ as part of a larger diff.
dedicated to zan rowe who thinks she is a bigger nerd than me.

allow spf-delay and spf-holdtime to be specified in msec so ospfd can
better respond to rapid topology changes.

developed while working with joshua atterbury
ok claudio@ as part of a larger diff.

Implement "log verbose" and "log brief" to enable or disable verbose debug
logging. henning, sthen, michele like the idea

Switch the various link state printing codes to use the new if_media
independent LINK_STATE_DESCRIPTIONS. Code is now more or less a one to
one copy of get_linkstate() in route/route.c.
OK henning, michele, sthen, deraadt

sync ospfctl/ospfd with the common imsg code, making it lib ready as well.

"looks ok" claudio@

forgot to commit the ospfctl bits, this unbreaks the tree.
noticed by michele@

allow to specify an alternate control socket instead of /var/run/ospfd.sock.
this is required to run multiple instances of ospfd.

ok claudio@

Add missing free.

OK claudio@

In show interface only print the hello_timer value if valid.

ospfd knows now priorities so let ospfctl know and print them as well.

the ellipsis allows more than one argument being specified.

discussed with gilles@

ok jmc@

specifying int instead of just unsigned is better style

please lint

Cleanup the way we display timers.

It does not make sense to display timer = 0 as "Stopped". When a timer is
0 it usually means that it is getting reset very soon. Display the string
"00:00:00" instead.

ok claudio@

Baudrate is 64bit so use %llu in printf(). Reminded by chl@

yuck, no cookie for me

add additional link states to report the half duplex / full duplex
state, if known by the driver. this is required to check the full
duplex state without depending on the ifmedia ioctl which can't be
called in the kernel without process context.

ok henning@, brad@

Add a comment about the empty imsg_event_add() function to make it clear
why it is needed.

Track the uptime of the ospfd daemon itself.
It is possible to read the uptime of the daemon with the "ospfctl show"
command.

ok claudio@

Add IFT_PPP to the iftype to ifmedia type conversion function. Now P2P links
will show the correct link state. While there do some cleanup and shorten the
output if the media or link state is unknown.

Show the neighbor uptime in "show nei detail".

ok claudio@

Show the link status of interfaces for real, I guess most users don't know
what it means that an interface is in state 2.

ok claudio@

List interfaces they way we list neighbors etc.
This makes it much easier to grep in the output.
The original format of "show interface" can be seen with
"show interface detail".

help and ok claudio@

ospfd has the framework to couple and decouple the FIB. Add the needed
functionality to ospfctl for it.
NOTE: decoupling the FIB one a router may totaly fuck up the complete network.
Use it with care!
OK norby@

Track interface uptime.

ok claudio@

Start using *_name function that are now shared between ospfd and ospfctl.
OK norby@

Last kroute.c commit changed the meaning of the flags so check them correctly.
OK norby@

Keep track of the uptime of the entries in the RIB.
It is now possible to see the uptime of the individual entries in the RIB.
The uptime can be displayed with "ospfctl show rib"

ok claudio@

Keep track of the duration of our relationships with neighbors.
Displayed in "ospfctl show neighbor".

ok claudio@

imsg API changed so adapt to it.

indicate passive interface in 'show interface'; ok claudio@

use err() vs. fatal(); ok claudio@

remove duplicate function declaration; ok claudio@

missing break caused erroneous auth-type crypt enabled in 'sh int'
when simple enabled; ok claudio@

- add auth_type and auth_keyid to struct ctl_iface
- have ospfctl tell us when we are using authentication with 'show interface'

ok claudio@ norby@

Small formatting bits in show neighbor detail.

ok claudio@

Fix multi area display bug.

ok claudio@

Add missing bits to ospfctl show rib detail.

ok claudio@

Add "show database asbr/external/network/router/self-originate/summary"
to ospfctl.

Show detailed information about the LSAs in the Link State Database.

ok claudio@

Fix a display bug in 'show database', when ospfd is member of more
than one area.

Input from claudio.

ok claudio@

Static routes are flagged with F_STATIC and not with F_KERNEL.

The RFC never mentions anything about transfer, this should be transmit.

From Jason Ackley (thanks).

ok claudio@

ospfctl bits for the "ospfctl show fib interface" part. This will print
the interface status as seen from the parent kroute perspective.
OK henning@ norby@

Sync mask2prefixlen() with the kroute.c version of ospfd because they share
the same prototype definition comming from ospfd.h.
OK norby@

bgpctl parts for "show fib".
OK norby@ deraadt@

Add "show summary" to ospfctl.

ok claudio@ henning@

Add "show rib" and "show rib detail" to ospfctl.

ok henning@

Small K&F.

ok henning@

KNF

usage() is __dead
pt out by Alexander v Gernler

Change my email address to the OpenBSD one since Ericsson has nothing to
do with this software, just happend to be my only valid email address at
the time.

Control program like bgpctl but this time for ospfd.
Currently only basic show commands work.

Not yet connected to the builds.
OK henning@

Also print the mtu when showing interface details

ok sthen@ benno@

Another imsg_read EAGAIN check. OK benno@

There is still a bit of an issue with connected routes in the RIB. Print
what ospfd thinks is connected by adding a 'C' to the nexthop output.

can use pledge "stdio"; ok benno

As done for bgpd recently, rename if_mediatype to if_type in ospfd/ospf6d.
And some ifmedia64 fixes.
"move forward" deraadt@

match a few if_media uint64_t conversions; ok miod

handle msgbuf_write() returning EAGAIN, looks right to deraadt

do not store a time_t or the result of a time_t division in an int

prompted by deraadt@, ok claudio@ chl@ guenther@

ospfctl bits for opaque LSA support.
tested and OK sthen@

Print the checksum sum as a simple fingerprint of the LSDB.
OK dlg@

Print 'Number of Routers' in show database network.
ok claudio@

implement ospfctl fib reload.

this tells the daemon to resync the kernels list of interfaces and routes
with the daemons list. this is very useful if the routing socket overflows
and you want to sync things up again.

lots and lots of help from claudio@
ok claudio@

implement support for fast hello packets.

if route-dead-time is set to "minimal" (rather than a number of
seconds), the dead time is set to 1 second and hellos are sent at
the interval specified by fast-hello-interval in msecs. this is non
standard wrt to the ospf rfc, but it does interoperate with at least
one other router vendor.

this allows much better responsiveness to l3 topology changes than
the standard intervals allow. if i yank a cable to one of my
upstreams, the routes adjust in a second rather than the default
of 40 i was running with before. the users dont even notice something
changed.

developed while working with joshua atterbury.
ok claudio@ as part of a larger diff.
dedicated to zan rowe who thinks she is a bigger nerd than me.

allow spf-delay and spf-holdtime to be specified in msec so ospfd can
better respond to rapid topology changes.

developed while working with joshua atterbury
ok claudio@ as part of a larger diff.

Implement "log verbose" and "log brief" to enable or disable verbose debug
logging. henning, sthen, michele like the idea

Switch the various link state printing codes to use the new if_media
independent LINK_STATE_DESCRIPTIONS. Code is now more or less a one to
one copy of get_linkstate() in route/route.c.
OK henning, michele, sthen, deraadt

sync ospfctl/ospfd with the common imsg code, making it lib ready as well.

"looks ok" claudio@

forgot to commit the ospfctl bits, this unbreaks the tree.
noticed by michele@

allow to specify an alternate control socket instead of /var/run/ospfd.sock.
this is required to run multiple instances of ospfd.

ok claudio@

Add missing free.

OK claudio@

In show interface only print the hello_timer value if valid.

ospfd knows now priorities so let ospfctl know and print them as well.

the ellipsis allows more than one argument being specified.

discussed with gilles@

ok jmc@

specifying int instead of just unsigned is better style

please lint

Cleanup the way we display timers.

It does not make sense to display timer = 0 as "Stopped". When a timer is
0 it usually means that it is getting reset very soon. Display the string
"00:00:00" instead.

ok claudio@

Baudrate is 64bit so use %llu in printf(). Reminded by chl@

yuck, no cookie for me

add additional link states to report the half duplex / full duplex
state, if known by the driver. this is required to check the full
duplex state without depending on the ifmedia ioctl which can't be
called in the kernel without process context.

ok henning@, brad@

Add a comment about the empty imsg_event_add() function to make it clear
why it is needed.

Track the uptime of the ospfd daemon itself.
It is possible to read the uptime of the daemon with the "ospfctl show"
command.

ok claudio@

Add IFT_PPP to the iftype to ifmedia type conversion function. Now P2P links
will show the correct link state. While there do some cleanup and shorten the
output if the media or link state is unknown.

Show the neighbor uptime in "show nei detail".

ok claudio@

Show the link status of interfaces for real, I guess most users don't know
what it means that an interface is in state 2.

ok claudio@

List interfaces they way we list neighbors etc.
This makes it much easier to grep in the output.
The original format of "show interface" can be seen with
"show interface detail".

help and ok claudio@

ospfd has the framework to couple and decouple the FIB. Add the needed
functionality to ospfctl for it.
NOTE: decoupling the FIB one a router may totaly fuck up the complete network.
Use it with care!
OK norby@

Track interface uptime.

ok claudio@

Start using *_name function that are now shared between ospfd and ospfctl.
OK norby@

Last kroute.c commit changed the meaning of the flags so check them correctly.
OK norby@

Keep track of the uptime of the entries in the RIB.
It is now possible to see the uptime of the individual entries in the RIB.
The uptime can be displayed with "ospfctl show rib"

ok claudio@

Keep track of the duration of our relationships with neighbors.
Displayed in "ospfctl show neighbor".

ok claudio@

imsg API changed so adapt to it.

indicate passive interface in 'show interface'; ok claudio@

use err() vs. fatal(); ok claudio@

remove duplicate function declaration; ok claudio@

missing break caused erroneous auth-type crypt enabled in 'sh int'
when simple enabled; ok claudio@

- add auth_type and auth_keyid to struct ctl_iface
- have ospfctl tell us when we are using authentication with 'show interface'

ok claudio@ norby@

Small formatting bits in show neighbor detail.

ok claudio@

Fix multi area display bug.

ok claudio@

Add missing bits to ospfctl show rib detail.

ok claudio@

Add "show database asbr/external/network/router/self-originate/summary"
to ospfctl.

Show detailed information about the LSAs in the Link State Database.

ok claudio@

Fix a display bug in 'show database', when ospfd is member of more
than one area.

Input from claudio.

ok claudio@

Static routes are flagged with F_STATIC and not with F_KERNEL.

The RFC never mentions anything about transfer, this should be transmit.

From Jason Ackley (thanks).

ok claudio@

ospfctl bits for the "ospfctl show fib interface" part. This will print
the interface status as seen from the parent kroute perspective.
OK henning@ norby@

Sync mask2prefixlen() with the kroute.c version of ospfd because they share
the same prototype definition comming from ospfd.h.
OK norby@

bgpctl parts for "show fib".
OK norby@ deraadt@

Add "show summary" to ospfctl.

ok claudio@ henning@

Add "show rib" and "show rib detail" to ospfctl.

ok henning@

Small K&F.

ok henning@

KNF

usage() is __dead
pt out by Alexander v Gernler

Change my email address to the OpenBSD one since Ericsson has nothing to
do with this software, just happend to be my only valid email address at
the time.

Control program like bgpctl but this time for ospfd.
Currently only basic show commands work.

Not yet connected to the builds.
OK henning@