Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

ospf6d: fix -Wunused-but-set-variable warnings

ospf6d.c: sync a missing bit of (disabled) code with ospfd
rde.c: ifdef out some more incomplete code

ok denis@ claudio@

Make the struct imsgev static. With this ospf6d compiles with -fno-common

When IMSG_IFADD is removed, IMSG_IFDELETE becomes useless

OK remi@

IMSG_IFADD is never used, wipe it

OK remi@

Handle connected routes as ospfd(8) does.

OK remi@

Rework of rde_asext_get()/rde_asext_put().
Also change get_net_link() and get_rtr_link() to work like ospfd(8)
couterpart.

OK remi@

Bring ospf6d closer to ospfd

- update debug messages to be more precise
- simplify call to lsa_self()
- drop lsa_find_lsid() redondant parameters

OK remi@

No need to pass peerid to lsa_snap()

OK remi@

Rename orig_rtr_lsa_area() to orig_rtr_lsa()

Now that area is part of iface, original orig_rtr_lsa() is useless. Also
verifying that area != NULL is not needed in some cases (these are
leftovers of the previous diff).

OK remi@

Area is now part of struct iface

OK remi@

Introduce conf_clear_redist_list() (from ospfd) and use it in all 3 procs.

ok benno@

Add support for rdomains.

small quirk from tb@
ok phessler@

With the "depend on" option routes are sent out with a metric of 65535 if
the referenced interface is down or in state backup. This is especially
useful on a carp cluster to ensure all traffic goes to the carp master.

ok friehm@ jca@

pledge(2)

Looks great! deraadt@
OK florian
OK remi@

Send LSAs with MAX_METRIC for carp interfaces in state backup.
This is similar to what ospfd does.

ok jca@

Fix resending intra area prefix LSAs on link state or if flag change.

ok jca@

memory leak spotted by claudio@

go ahead jca@
OK claudio@

The value for metric of intra area prefix LSAs should be set to:
- 0 when referencing Network LSAs
- 0 for loopback interfaces
- interface output cost for other cases

go ahead jca@
OK claudio@

bring ospf6d's log.c in sync with ospfd and bgpd
ok florian@ claudio@

Import route priority support from ospfd to ospf6d.
Also remove the RTF_UP flag from hdr.rtm_flags in send_rtmsg() since
ospfd and bgpd don't set the flag.

OK bluhm@ claudio@

Adding multipath route support to ospf6d. Almost copied from ospfd.

OK bluhm@

Replace struct rroute with struct kroute, as done in ospfd

ok claudio@

Simplify shutdown process.

On shutdown, there's no need to use kill(2) to kill the child
processes. Just closing the IPC sockets will make the children receive
an EOF, break out from the event loop and then exit.

Tha advantages of this "pipe teardown" are:
* simpler code;
* no need to pledge "proc" in the parent process;
* removal of a (hard to trigger) PID reuse race condition.

ok benno@ claudio@

work on making log.c similar in all daemons:

move daemon-local functions into new logmsg.c, and reduce
the (mostly whitespace) differences so that log.c's can be diffed easily.

ok claudio@, feedback from henning@, deraadt@, reyk@

add format attributes to the proper functions and then fix the
warning in rde.c

EAGAIN handling for imsg_read. OK henning@ benno@

As done for bgpd recently, rename if_mediatype to if_type in ospfd/ospf6d.
And some ifmedia64 fixes.
"move forward" deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Close connections when msgbuf_write() returns 0.

ok claudio@

handle msgbuf_write() returning EAGAIN,
taken from claudios previous fix to ospfd.

"do it" deraadt@

Fix trailing whitespaces.

Add a #include that's currently picked up via another header that's
violating namespace rules

ok claudio@

Rework the distribution of link state and iface FSM state changes.
Link state changes are sent from the parent to both childs and
iface FSM state changes are sent from the ospfe to the rde.

Just use if_find() to find an interface by ifindex.

correct/change some debug and fatal messages.

Kill nh_reachable. Link state checking is so easy now that it does not
matter anymore to cache this value for ospf6d.

LINK_STATE_IS_UP() cleanup userland part. There is no need to special
case carp(4) interfaces anymore. LINK_STATE_IS_UP() almost always does
the right job.
OK deraadt@ henning@

This needs a -current kernel or link state may be not reported correctly.

Make sure that passive interfaces (like carp) are added to the
intra-area rtr LSA. Diff initialy made by Patrick Coleman but
simplified by myself. Tested and OK dlg@

KNF

Don't include sys/param.h and reformat some lines.

When removing an announced prefix, inherit the metric and ext_tag
from the LSA that is currently in the tree. Based on claudio@'s
diff and his fix for ospfd. Additionally originate an LSA with
external route tag correctly by writing the AS-external-LSA's bit
T into the correct field.
ok claudio@

Do not try to originate an intra-area-prefix-lsa if an interface
address changes that does not belong to any area. This fixes an
ospf6d crash. To not search for the area in orig_intra_lsa_net(),
just pass the area as function parameter.
ok claudio@

Update the interfaces changes from kroute to rde via imsg. This
is needed to orginate correct intra-area-prefix-lsas.
ok claudio@ stsp@

Use the static variable narea only where needed for config reload.
The other imessages use the stack variables area and iface.
ok claudio@

During network intra-area-prefix-lsa origination, the designated
router's prefixes were ignored if all other routers on that link
had no prefixes. Advertise a intra-area-prefix-lsa with all prefixes
for the network if there are any adjacent neighbors on link.
ok stsp@

Fix memory leak by adding a missing free(lsa).
ok claudio@

Fix all white space bugs in ospf6d at once. No binary change.
ok claudio@

The prefixes of interface addresses of an ospf link have to be
advertised as link-lsa and intra-area-prefix-lsa when they change
dynamically. Handle RTM_NEWADDR and RTM_DELADDR in kroute by sending
an imsg to ospfe. Upon this event, originate a new link-lsa in
ospfe. In rde a new intra-area-prefix-lsa is generated when a
link-lsa appears or goes away.
ok claudio@; ok and test stsp@

Store the ifindex into the kroute change imsg. This way we can use
the interface index for writing routes into the kernel.
ok claudio@

Fix an obvious use after free. From ospfd.
ok claudio@

Add NULL pointer check after calloc.
ok claudio@ stsp@

Fix error message.
ok claudio@ stsp@

Move a function to a place that is a bit more logical. No functional change.

Support for redistributing AS-ext LSA (redistribute static/connected).
Appart from multi-area support this is the last big missing piece in
ospf6d. ospf6d should now work correctly in single area setups.
So please test.
"it's always nice to see those #if 0 being killed" stsp@

In orig_intra_lsa_rtr(), don't allocate and free a temporary buffer
which easily fits on the stack.

OK claudio@

Add interface index aka. scope id to struct kroute so that the rde can pass
this information to kroute and kroute can use that information to fill in
the various sin6_scope_id fields.

Add IMSG_CTL_LOG_VERBOSE similar to ospfd it allows to toggle debug logging.
henning, sthen, michele like the idea

More fallout from the r1.31 commit. This time PID and the fd got swapped.
Again from stsp@

Running 'ospf6ctl show' twice caused ospf6d to fatal. Cause was a missing -
when passing -1 as fd to the imsg call. No frogs for eric@ and pyr@
From stsp@

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Remove redundant imsg_event_add calls; ok claudio@

libevent handler fix to allow EV_READ and EV_WRITE to be set at the same
time in the callback. Same diff that went into ospfd applied with some
fuzz.

Fix a naming inconsistency in struct lsa_intra_prefix (lsid -> ls_id).

"consistency is a good thing" jsing@, ok claudio@

As a first step towards SPF tree calculation, prepare for proper
next-hop calculation.

In OSPFv3, next-hop IP addresses are always link-local.
The kernel will want to know which interface the link-local
address belongs to, so we need an ifindex in struct v_nexthop
in addition to the IP address.

Because we cannot determine a link-local next hop IP address
for transit networks, only the outgoing interface will be recorded.

Update calc_nexthop_add() according to the above.

Also add new helpers calc_nexthop_lladdr() and calc_nexthop_transit_nbr(),
to figure out link-local addresses of nexthop neighbours.

ok claudio@

lsa_self() did too many things at once, and had too much logic
buried inside of it that its caller relied on.

So split it up as follows:
lsa_self() Check whether an LSA is self-originated.
lsa_flush() Flush an LSA from the LSDB.
lsa_reflood() Prepare an LSA for reflooding (actual reflooding currently
requires sending an imsg which must be done by the caller).

ok claudio@

Add lsa_find_tree() to allow searching for LSAs in a specific LSA tree.
We had code marked XXX searching an LSA tree manually using RB_FIND(),
switch it over to lsa_find_tree().
Make lsa_find() use the new function, too, to avoid code duplication.
ok claudio@

Use rde_router_id() instead of directly accessing rdeconf->rtr_id.s_addr.

"For sure!" claudio@

Enable origination of Intra-Area-Prefix LSAs in rde.

New Intra-Area-Prefix LSAs are originated when a neighbour
becomes adjacent, or when a neighbour loses adjacency,
or when an interface changes state.

ok claudio@

Virtually re-implement origination of Intra-Area-Prefix LSAs.
We now comply with RFC5340 and move prefixes between the two
ref-types of Intra-Area-Prefix LSAs (router and network).

In case an LSA ends up having all of its prefixes moved to another
one, the LSA is flushed from the LSDB by re-originating with MAX_AGE.
(This does not yet work reliably. We end up having LSAs with zero
prefixes in the LSDB in some cases. Should not affect SPF calculation,
so not much harm done, but will need to be fixed.)

This commit just adds the necessary code to do origination,
but it is not being called yet. This will be done in a separate
commit.

"Looks good." claudio@

Sync iface fsm state from ospfe to rde.

Also syncs other fields the ospfe is syncing to when getting
iface updates from parent process.
None of these fields are used by the rde yet, but state will be
important soon, for proper origination of Intra-Area-Prefix LSAs.

ok claudio@

Fix two obvious copy-paste errors in fatal error messages. We were
printing IFINFO while we are actually handling an IFDELETE imsg.

Formatting fixes.

Hard-code the Link State ID of Intra-Area-Prefix LSAs referencing Network
LSAs to zero. We were using the interface index, which is not quite right
for this type of LSA.

This is part of a greater scheme:
Intra-Area-Prefix LSAs referencing Router LSAs (not yet implemented)
will initially have their Link State ID hard-coded to one.
Then, as soon as we implement fragmentation of Intra-Area-Prefix LSAs,
Link State IDs for both types of Intra-Area-Prefix LSA will have to be
generated dynamically in a non-overlapping fashion.

discussed with claudio@

Improve debugging message in orig_intra_lsa_net().
Print not just the area, but also the interface to the link the LSA
is generated for.
ok claudio@

Teach ospf6d to originate Intra-Area-Prefix LSAs, which associate a list
of IPv6 prefixes with a Network LSA (there's another type of this LSA which
associates prefixes with a Router LSA -- this remains to be done).
Add what is necessary to allow ospf6ctl to read the new LSA type via IMSG.
ok claudio@

Again, no need to double check if neighbor exists.

ok stsp@

Since link LSAs live in iface->lsa_tree and not in area->lsa_tree,
we had better include LSAs from iface->lsa_tree when sending
DB summaries. Fixes initial flood of link LSAs.
ok claudio@

First try at originating Link (type-8) LSA. Code is wrong and the initial
LSA is lost in lsa_flood. Put this in because it goes in the right direction
and ospf6d is work in progress. Add necessary framework so that we can print
Link LSA in ospf6ctl.
Diff mostly from stsp@ ospf6ctl part by myself

No need to byteswap req_hdr.type as lsa_find() will do that for us.
From Stefan Sperling

Correct the output of several error and debug messages.

Monster commit of stuff I did mostly last month. What it does:
* removes kif and uses iface for everything interface related.
This removes unneeded data redundancy which makes the code more complex.
* adds the link local prefix to struct iface and attaches a list with
the other prefixes to the struct iface. This is needed to generate the
link LSA.
* disconnects struct iface from struct area (the backpointer is gone)
this will make the reload code a bit easier.
norby@ agrees with the direction we're heading with this

Make lsa_find() find link local LSA by passing the interface instead of the
area as lookup point. Additionally make lsa_dump or actually the code around
it pass all LSA to ospf6ctl. The rde_spf.c are not final.

Monster diff to bring us a bit on track again.
a) implement all (or at least most) lsa_check() cases.
b) classify the LSA scope correctly and add a per interface lsa_tree for
the link local stuff.
c) implement a function to parse a prefix.

There is still a lot missing currently link local LSA are added to the
interface tree but nothing can access them (lsa_find() and a few friends
need some changes).
OK norby@

lsa_snap() should work so enable it.

Enable the IMSG_DD related code. This code starts to work.

In OSPFv3 the LSA type is a 16 bit value, furthermore it uses different
values than the v2 counterpart.

Change to u_int16_t and define new LSA types.

ok claudio@

First step at making kroute IPv6 aware. This resulted in many additional
changes -- some are so hairy that I left them out for later by commenting out
larger blocks of code (just grep for XXX if you like to help).
Get it in early so that we can work on.
OK norby@

Disable some code that is currently far from working and results in frequent
session resets because of bad packets. With this it seems we survive the
hello and database exchange phases. A closer look at the DR and BDR calculation
is still needed.

From ospfd:
Bye bye global ospf options. OSPF options are per area (at least the one
flag that we set). So introduce a area_ospf_options() function that will
return the correct flags for each area. This makes stub area support a lot
easier.
Don't check for OSPF_OPTION_E in the parent. OSPF_OPTION_E is per area and
so the parent process has no way to know if it should redistribute or not.

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

ospf6d: fix -Wunused-but-set-variable warnings

ospf6d.c: sync a missing bit of (disabled) code with ospfd
rde.c: ifdef out some more incomplete code

ok denis@ claudio@

Make the struct imsgev static. With this ospf6d compiles with -fno-common

When IMSG_IFADD is removed, IMSG_IFDELETE becomes useless

OK remi@

IMSG_IFADD is never used, wipe it

OK remi@

Handle connected routes as ospfd(8) does.

OK remi@

Rework of rde_asext_get()/rde_asext_put().
Also change get_net_link() and get_rtr_link() to work like ospfd(8)
couterpart.

OK remi@

Bring ospf6d closer to ospfd

- update debug messages to be more precise
- simplify call to lsa_self()
- drop lsa_find_lsid() redondant parameters

OK remi@

No need to pass peerid to lsa_snap()

OK remi@

Rename orig_rtr_lsa_area() to orig_rtr_lsa()

Now that area is part of iface, original orig_rtr_lsa() is useless. Also
verifying that area != NULL is not needed in some cases (these are
leftovers of the previous diff).

OK remi@

Area is now part of struct iface

OK remi@

Introduce conf_clear_redist_list() (from ospfd) and use it in all 3 procs.

ok benno@

Add support for rdomains.

small quirk from tb@
ok phessler@

With the "depend on" option routes are sent out with a metric of 65535 if
the referenced interface is down or in state backup. This is especially
useful on a carp cluster to ensure all traffic goes to the carp master.

ok friehm@ jca@

pledge(2)

Looks great! deraadt@
OK florian
OK remi@

Send LSAs with MAX_METRIC for carp interfaces in state backup.
This is similar to what ospfd does.

ok jca@

Fix resending intra area prefix LSAs on link state or if flag change.

ok jca@

memory leak spotted by claudio@

go ahead jca@
OK claudio@

The value for metric of intra area prefix LSAs should be set to:
- 0 when referencing Network LSAs
- 0 for loopback interfaces
- interface output cost for other cases

go ahead jca@
OK claudio@

bring ospf6d's log.c in sync with ospfd and bgpd
ok florian@ claudio@

Import route priority support from ospfd to ospf6d.
Also remove the RTF_UP flag from hdr.rtm_flags in send_rtmsg() since
ospfd and bgpd don't set the flag.

OK bluhm@ claudio@

Adding multipath route support to ospf6d. Almost copied from ospfd.

OK bluhm@

Replace struct rroute with struct kroute, as done in ospfd

ok claudio@

Simplify shutdown process.

On shutdown, there's no need to use kill(2) to kill the child
processes. Just closing the IPC sockets will make the children receive
an EOF, break out from the event loop and then exit.

Tha advantages of this "pipe teardown" are:
* simpler code;
* no need to pledge "proc" in the parent process;
* removal of a (hard to trigger) PID reuse race condition.

ok benno@ claudio@

work on making log.c similar in all daemons:

move daemon-local functions into new logmsg.c, and reduce
the (mostly whitespace) differences so that log.c's can be diffed easily.

ok claudio@, feedback from henning@, deraadt@, reyk@

add format attributes to the proper functions and then fix the
warning in rde.c

EAGAIN handling for imsg_read. OK henning@ benno@

As done for bgpd recently, rename if_mediatype to if_type in ospfd/ospf6d.
And some ifmedia64 fixes.
"move forward" deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Close connections when msgbuf_write() returns 0.

ok claudio@

handle msgbuf_write() returning EAGAIN,
taken from claudios previous fix to ospfd.

"do it" deraadt@

Fix trailing whitespaces.

Add a #include that's currently picked up via another header that's
violating namespace rules

ok claudio@

Rework the distribution of link state and iface FSM state changes.
Link state changes are sent from the parent to both childs and
iface FSM state changes are sent from the ospfe to the rde.

Just use if_find() to find an interface by ifindex.

correct/change some debug and fatal messages.

Kill nh_reachable. Link state checking is so easy now that it does not
matter anymore to cache this value for ospf6d.

LINK_STATE_IS_UP() cleanup userland part. There is no need to special
case carp(4) interfaces anymore. LINK_STATE_IS_UP() almost always does
the right job.
OK deraadt@ henning@

This needs a -current kernel or link state may be not reported correctly.

Make sure that passive interfaces (like carp) are added to the
intra-area rtr LSA. Diff initialy made by Patrick Coleman but
simplified by myself. Tested and OK dlg@

KNF

Don't include sys/param.h and reformat some lines.

When removing an announced prefix, inherit the metric and ext_tag
from the LSA that is currently in the tree. Based on claudio@'s
diff and his fix for ospfd. Additionally originate an LSA with
external route tag correctly by writing the AS-external-LSA's bit
T into the correct field.
ok claudio@

Do not try to originate an intra-area-prefix-lsa if an interface
address changes that does not belong to any area. This fixes an
ospf6d crash. To not search for the area in orig_intra_lsa_net(),
just pass the area as function parameter.
ok claudio@

Update the interfaces changes from kroute to rde via imsg. This
is needed to orginate correct intra-area-prefix-lsas.
ok claudio@ stsp@

Use the static variable narea only where needed for config reload.
The other imessages use the stack variables area and iface.
ok claudio@

During network intra-area-prefix-lsa origination, the designated
router's prefixes were ignored if all other routers on that link
had no prefixes. Advertise a intra-area-prefix-lsa with all prefixes
for the network if there are any adjacent neighbors on link.
ok stsp@

Fix memory leak by adding a missing free(lsa).
ok claudio@

Fix all white space bugs in ospf6d at once. No binary change.
ok claudio@

The prefixes of interface addresses of an ospf link have to be
advertised as link-lsa and intra-area-prefix-lsa when they change
dynamically. Handle RTM_NEWADDR and RTM_DELADDR in kroute by sending
an imsg to ospfe. Upon this event, originate a new link-lsa in
ospfe. In rde a new intra-area-prefix-lsa is generated when a
link-lsa appears or goes away.
ok claudio@; ok and test stsp@

Store the ifindex into the kroute change imsg. This way we can use
the interface index for writing routes into the kernel.
ok claudio@

Fix an obvious use after free. From ospfd.
ok claudio@

Add NULL pointer check after calloc.
ok claudio@ stsp@

Fix error message.
ok claudio@ stsp@

Move a function to a place that is a bit more logical. No functional change.

Support for redistributing AS-ext LSA (redistribute static/connected).
Appart from multi-area support this is the last big missing piece in
ospf6d. ospf6d should now work correctly in single area setups.
So please test.
"it's always nice to see those #if 0 being killed" stsp@

In orig_intra_lsa_rtr(), don't allocate and free a temporary buffer
which easily fits on the stack.

OK claudio@

Add interface index aka. scope id to struct kroute so that the rde can pass
this information to kroute and kroute can use that information to fill in
the various sin6_scope_id fields.

Add IMSG_CTL_LOG_VERBOSE similar to ospfd it allows to toggle debug logging.
henning, sthen, michele like the idea

More fallout from the r1.31 commit. This time PID and the fd got swapped.
Again from stsp@

Running 'ospf6ctl show' twice caused ospf6d to fatal. Cause was a missing -
when passing -1 as fd to the imsg call. No frogs for eric@ and pyr@
From stsp@

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Remove redundant imsg_event_add calls; ok claudio@

libevent handler fix to allow EV_READ and EV_WRITE to be set at the same
time in the callback. Same diff that went into ospfd applied with some
fuzz.

Fix a naming inconsistency in struct lsa_intra_prefix (lsid -> ls_id).

"consistency is a good thing" jsing@, ok claudio@

As a first step towards SPF tree calculation, prepare for proper
next-hop calculation.

In OSPFv3, next-hop IP addresses are always link-local.
The kernel will want to know which interface the link-local
address belongs to, so we need an ifindex in struct v_nexthop
in addition to the IP address.

Because we cannot determine a link-local next hop IP address
for transit networks, only the outgoing interface will be recorded.

Update calc_nexthop_add() according to the above.

Also add new helpers calc_nexthop_lladdr() and calc_nexthop_transit_nbr(),
to figure out link-local addresses of nexthop neighbours.

ok claudio@

lsa_self() did too many things at once, and had too much logic
buried inside of it that its caller relied on.

So split it up as follows:
lsa_self() Check whether an LSA is self-originated.
lsa_flush() Flush an LSA from the LSDB.
lsa_reflood() Prepare an LSA for reflooding (actual reflooding currently
requires sending an imsg which must be done by the caller).

ok claudio@

Add lsa_find_tree() to allow searching for LSAs in a specific LSA tree.
We had code marked XXX searching an LSA tree manually using RB_FIND(),
switch it over to lsa_find_tree().
Make lsa_find() use the new function, too, to avoid code duplication.
ok claudio@

Use rde_router_id() instead of directly accessing rdeconf->rtr_id.s_addr.

"For sure!" claudio@

Enable origination of Intra-Area-Prefix LSAs in rde.

New Intra-Area-Prefix LSAs are originated when a neighbour
becomes adjacent, or when a neighbour loses adjacency,
or when an interface changes state.

ok claudio@

Virtually re-implement origination of Intra-Area-Prefix LSAs.
We now comply with RFC5340 and move prefixes between the two
ref-types of Intra-Area-Prefix LSAs (router and network).

In case an LSA ends up having all of its prefixes moved to another
one, the LSA is flushed from the LSDB by re-originating with MAX_AGE.
(This does not yet work reliably. We end up having LSAs with zero
prefixes in the LSDB in some cases. Should not affect SPF calculation,
so not much harm done, but will need to be fixed.)

This commit just adds the necessary code to do origination,
but it is not being called yet. This will be done in a separate
commit.

"Looks good." claudio@

Sync iface fsm state from ospfe to rde.

Also syncs other fields the ospfe is syncing to when getting
iface updates from parent process.
None of these fields are used by the rde yet, but state will be
important soon, for proper origination of Intra-Area-Prefix LSAs.

ok claudio@

Fix two obvious copy-paste errors in fatal error messages. We were
printing IFINFO while we are actually handling an IFDELETE imsg.

Formatting fixes.

Hard-code the Link State ID of Intra-Area-Prefix LSAs referencing Network
LSAs to zero. We were using the interface index, which is not quite right
for this type of LSA.

This is part of a greater scheme:
Intra-Area-Prefix LSAs referencing Router LSAs (not yet implemented)
will initially have their Link State ID hard-coded to one.
Then, as soon as we implement fragmentation of Intra-Area-Prefix LSAs,
Link State IDs for both types of Intra-Area-Prefix LSA will have to be
generated dynamically in a non-overlapping fashion.

discussed with claudio@

Improve debugging message in orig_intra_lsa_net().
Print not just the area, but also the interface to the link the LSA
is generated for.
ok claudio@

Teach ospf6d to originate Intra-Area-Prefix LSAs, which associate a list
of IPv6 prefixes with a Network LSA (there's another type of this LSA which
associates prefixes with a Router LSA -- this remains to be done).
Add what is necessary to allow ospf6ctl to read the new LSA type via IMSG.
ok claudio@

Again, no need to double check if neighbor exists.

ok stsp@

Since link LSAs live in iface->lsa_tree and not in area->lsa_tree,
we had better include LSAs from iface->lsa_tree when sending
DB summaries. Fixes initial flood of link LSAs.
ok claudio@

First try at originating Link (type-8) LSA. Code is wrong and the initial
LSA is lost in lsa_flood. Put this in because it goes in the right direction
and ospf6d is work in progress. Add necessary framework so that we can print
Link LSA in ospf6ctl.
Diff mostly from stsp@ ospf6ctl part by myself

No need to byteswap req_hdr.type as lsa_find() will do that for us.
From Stefan Sperling

Correct the output of several error and debug messages.

Monster commit of stuff I did mostly last month. What it does:
* removes kif and uses iface for everything interface related.
This removes unneeded data redundancy which makes the code more complex.
* adds the link local prefix to struct iface and attaches a list with
the other prefixes to the struct iface. This is needed to generate the
link LSA.
* disconnects struct iface from struct area (the backpointer is gone)
this will make the reload code a bit easier.
norby@ agrees with the direction we're heading with this

Make lsa_find() find link local LSA by passing the interface instead of the
area as lookup point. Additionally make lsa_dump or actually the code around
it pass all LSA to ospf6ctl. The rde_spf.c are not final.

Monster diff to bring us a bit on track again.
a) implement all (or at least most) lsa_check() cases.
b) classify the LSA scope correctly and add a per interface lsa_tree for
the link local stuff.
c) implement a function to parse a prefix.

There is still a lot missing currently link local LSA are added to the
interface tree but nothing can access them (lsa_find() and a few friends
need some changes).
OK norby@

lsa_snap() should work so enable it.

Enable the IMSG_DD related code. This code starts to work.

In OSPFv3 the LSA type is a 16 bit value, furthermore it uses different
values than the v2 counterpart.

Change to u_int16_t and define new LSA types.

ok claudio@

First step at making kroute IPv6 aware. This resulted in many additional
changes -- some are so hairy that I left them out for later by commenting out
larger blocks of code (just grep for XXX if you like to help).
Get it in early so that we can work on.
OK norby@

Disable some code that is currently far from working and results in frequent
session resets because of bad packets. With this it seems we survive the
hello and database exchange phases. A closer look at the DR and BDR calculation
is still needed.

From ospfd:
Bye bye global ospf options. OSPF options are per area (at least the one
flag that we set). So introduce a area_ospf_options() function that will
return the correct flags for each area. This makes stub area support a lot
easier.
Don't check for OSPF_OPTION_E in the parent. OSPF_OPTION_E is per area and
so the parent process has no way to know if it should redistribute or not.

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

Make the struct imsgev static. With this ospf6d compiles with -fno-common

When IMSG_IFADD is removed, IMSG_IFDELETE becomes useless

OK remi@

IMSG_IFADD is never used, wipe it

OK remi@

Handle connected routes as ospfd(8) does.

OK remi@

Rework of rde_asext_get()/rde_asext_put().
Also change get_net_link() and get_rtr_link() to work like ospfd(8)
couterpart.

OK remi@

Bring ospf6d closer to ospfd

- update debug messages to be more precise
- simplify call to lsa_self()
- drop lsa_find_lsid() redondant parameters

OK remi@

No need to pass peerid to lsa_snap()

OK remi@

Rename orig_rtr_lsa_area() to orig_rtr_lsa()

Now that area is part of iface, original orig_rtr_lsa() is useless. Also
verifying that area != NULL is not needed in some cases (these are
leftovers of the previous diff).

OK remi@

Area is now part of struct iface

OK remi@

Introduce conf_clear_redist_list() (from ospfd) and use it in all 3 procs.

ok benno@

Add support for rdomains.

small quirk from tb@
ok phessler@

With the "depend on" option routes are sent out with a metric of 65535 if
the referenced interface is down or in state backup. This is especially
useful on a carp cluster to ensure all traffic goes to the carp master.

ok friehm@ jca@

pledge(2)

Looks great! deraadt@
OK florian
OK remi@

Send LSAs with MAX_METRIC for carp interfaces in state backup.
This is similar to what ospfd does.

ok jca@

Fix resending intra area prefix LSAs on link state or if flag change.

ok jca@

memory leak spotted by claudio@

go ahead jca@
OK claudio@

The value for metric of intra area prefix LSAs should be set to:
- 0 when referencing Network LSAs
- 0 for loopback interfaces
- interface output cost for other cases

go ahead jca@
OK claudio@

bring ospf6d's log.c in sync with ospfd and bgpd
ok florian@ claudio@

Import route priority support from ospfd to ospf6d.
Also remove the RTF_UP flag from hdr.rtm_flags in send_rtmsg() since
ospfd and bgpd don't set the flag.

OK bluhm@ claudio@

Adding multipath route support to ospf6d. Almost copied from ospfd.

OK bluhm@

Replace struct rroute with struct kroute, as done in ospfd

ok claudio@

Simplify shutdown process.

On shutdown, there's no need to use kill(2) to kill the child
processes. Just closing the IPC sockets will make the children receive
an EOF, break out from the event loop and then exit.

Tha advantages of this "pipe teardown" are:
* simpler code;
* no need to pledge "proc" in the parent process;
* removal of a (hard to trigger) PID reuse race condition.

ok benno@ claudio@

work on making log.c similar in all daemons:

move daemon-local functions into new logmsg.c, and reduce
the (mostly whitespace) differences so that log.c's can be diffed easily.

ok claudio@, feedback from henning@, deraadt@, reyk@

add format attributes to the proper functions and then fix the
warning in rde.c

EAGAIN handling for imsg_read. OK henning@ benno@

As done for bgpd recently, rename if_mediatype to if_type in ospfd/ospf6d.
And some ifmedia64 fixes.
"move forward" deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Close connections when msgbuf_write() returns 0.

ok claudio@

handle msgbuf_write() returning EAGAIN,
taken from claudios previous fix to ospfd.

"do it" deraadt@

Fix trailing whitespaces.

Add a #include that's currently picked up via another header that's
violating namespace rules

ok claudio@

Rework the distribution of link state and iface FSM state changes.
Link state changes are sent from the parent to both childs and
iface FSM state changes are sent from the ospfe to the rde.

Just use if_find() to find an interface by ifindex.

correct/change some debug and fatal messages.

Kill nh_reachable. Link state checking is so easy now that it does not
matter anymore to cache this value for ospf6d.

LINK_STATE_IS_UP() cleanup userland part. There is no need to special
case carp(4) interfaces anymore. LINK_STATE_IS_UP() almost always does
the right job.
OK deraadt@ henning@

This needs a -current kernel or link state may be not reported correctly.

Make sure that passive interfaces (like carp) are added to the
intra-area rtr LSA. Diff initialy made by Patrick Coleman but
simplified by myself. Tested and OK dlg@

KNF

Don't include sys/param.h and reformat some lines.

When removing an announced prefix, inherit the metric and ext_tag
from the LSA that is currently in the tree. Based on claudio@'s
diff and his fix for ospfd. Additionally originate an LSA with
external route tag correctly by writing the AS-external-LSA's bit
T into the correct field.
ok claudio@

Do not try to originate an intra-area-prefix-lsa if an interface
address changes that does not belong to any area. This fixes an
ospf6d crash. To not search for the area in orig_intra_lsa_net(),
just pass the area as function parameter.
ok claudio@

Update the interfaces changes from kroute to rde via imsg. This
is needed to orginate correct intra-area-prefix-lsas.
ok claudio@ stsp@

Use the static variable narea only where needed for config reload.
The other imessages use the stack variables area and iface.
ok claudio@

During network intra-area-prefix-lsa origination, the designated
router's prefixes were ignored if all other routers on that link
had no prefixes. Advertise a intra-area-prefix-lsa with all prefixes
for the network if there are any adjacent neighbors on link.
ok stsp@

Fix memory leak by adding a missing free(lsa).
ok claudio@

Fix all white space bugs in ospf6d at once. No binary change.
ok claudio@

The prefixes of interface addresses of an ospf link have to be
advertised as link-lsa and intra-area-prefix-lsa when they change
dynamically. Handle RTM_NEWADDR and RTM_DELADDR in kroute by sending
an imsg to ospfe. Upon this event, originate a new link-lsa in
ospfe. In rde a new intra-area-prefix-lsa is generated when a
link-lsa appears or goes away.
ok claudio@; ok and test stsp@

Store the ifindex into the kroute change imsg. This way we can use
the interface index for writing routes into the kernel.
ok claudio@

Fix an obvious use after free. From ospfd.
ok claudio@

Add NULL pointer check after calloc.
ok claudio@ stsp@

Fix error message.
ok claudio@ stsp@

Move a function to a place that is a bit more logical. No functional change.

Support for redistributing AS-ext LSA (redistribute static/connected).
Appart from multi-area support this is the last big missing piece in
ospf6d. ospf6d should now work correctly in single area setups.
So please test.
"it's always nice to see those #if 0 being killed" stsp@

In orig_intra_lsa_rtr(), don't allocate and free a temporary buffer
which easily fits on the stack.

OK claudio@

Add interface index aka. scope id to struct kroute so that the rde can pass
this information to kroute and kroute can use that information to fill in
the various sin6_scope_id fields.

Add IMSG_CTL_LOG_VERBOSE similar to ospfd it allows to toggle debug logging.
henning, sthen, michele like the idea

More fallout from the r1.31 commit. This time PID and the fd got swapped.
Again from stsp@

Running 'ospf6ctl show' twice caused ospf6d to fatal. Cause was a missing -
when passing -1 as fd to the imsg call. No frogs for eric@ and pyr@
From stsp@

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Remove redundant imsg_event_add calls; ok claudio@

libevent handler fix to allow EV_READ and EV_WRITE to be set at the same
time in the callback. Same diff that went into ospfd applied with some
fuzz.

Fix a naming inconsistency in struct lsa_intra_prefix (lsid -> ls_id).

"consistency is a good thing" jsing@, ok claudio@

As a first step towards SPF tree calculation, prepare for proper
next-hop calculation.

In OSPFv3, next-hop IP addresses are always link-local.
The kernel will want to know which interface the link-local
address belongs to, so we need an ifindex in struct v_nexthop
in addition to the IP address.

Because we cannot determine a link-local next hop IP address
for transit networks, only the outgoing interface will be recorded.

Update calc_nexthop_add() according to the above.

Also add new helpers calc_nexthop_lladdr() and calc_nexthop_transit_nbr(),
to figure out link-local addresses of nexthop neighbours.

ok claudio@

lsa_self() did too many things at once, and had too much logic
buried inside of it that its caller relied on.

So split it up as follows:
lsa_self() Check whether an LSA is self-originated.
lsa_flush() Flush an LSA from the LSDB.
lsa_reflood() Prepare an LSA for reflooding (actual reflooding currently
requires sending an imsg which must be done by the caller).

ok claudio@

Add lsa_find_tree() to allow searching for LSAs in a specific LSA tree.
We had code marked XXX searching an LSA tree manually using RB_FIND(),
switch it over to lsa_find_tree().
Make lsa_find() use the new function, too, to avoid code duplication.
ok claudio@

Use rde_router_id() instead of directly accessing rdeconf->rtr_id.s_addr.

"For sure!" claudio@

Enable origination of Intra-Area-Prefix LSAs in rde.

New Intra-Area-Prefix LSAs are originated when a neighbour
becomes adjacent, or when a neighbour loses adjacency,
or when an interface changes state.

ok claudio@

Virtually re-implement origination of Intra-Area-Prefix LSAs.
We now comply with RFC5340 and move prefixes between the two
ref-types of Intra-Area-Prefix LSAs (router and network).

In case an LSA ends up having all of its prefixes moved to another
one, the LSA is flushed from the LSDB by re-originating with MAX_AGE.
(This does not yet work reliably. We end up having LSAs with zero
prefixes in the LSDB in some cases. Should not affect SPF calculation,
so not much harm done, but will need to be fixed.)

This commit just adds the necessary code to do origination,
but it is not being called yet. This will be done in a separate
commit.

"Looks good." claudio@

Sync iface fsm state from ospfe to rde.

Also syncs other fields the ospfe is syncing to when getting
iface updates from parent process.
None of these fields are used by the rde yet, but state will be
important soon, for proper origination of Intra-Area-Prefix LSAs.

ok claudio@

Fix two obvious copy-paste errors in fatal error messages. We were
printing IFINFO while we are actually handling an IFDELETE imsg.

Formatting fixes.

Hard-code the Link State ID of Intra-Area-Prefix LSAs referencing Network
LSAs to zero. We were using the interface index, which is not quite right
for this type of LSA.

This is part of a greater scheme:
Intra-Area-Prefix LSAs referencing Router LSAs (not yet implemented)
will initially have their Link State ID hard-coded to one.
Then, as soon as we implement fragmentation of Intra-Area-Prefix LSAs,
Link State IDs for both types of Intra-Area-Prefix LSA will have to be
generated dynamically in a non-overlapping fashion.

discussed with claudio@

Improve debugging message in orig_intra_lsa_net().
Print not just the area, but also the interface to the link the LSA
is generated for.
ok claudio@

Teach ospf6d to originate Intra-Area-Prefix LSAs, which associate a list
of IPv6 prefixes with a Network LSA (there's another type of this LSA which
associates prefixes with a Router LSA -- this remains to be done).
Add what is necessary to allow ospf6ctl to read the new LSA type via IMSG.
ok claudio@

Again, no need to double check if neighbor exists.

ok stsp@

Since link LSAs live in iface->lsa_tree and not in area->lsa_tree,
we had better include LSAs from iface->lsa_tree when sending
DB summaries. Fixes initial flood of link LSAs.
ok claudio@

First try at originating Link (type-8) LSA. Code is wrong and the initial
LSA is lost in lsa_flood. Put this in because it goes in the right direction
and ospf6d is work in progress. Add necessary framework so that we can print
Link LSA in ospf6ctl.
Diff mostly from stsp@ ospf6ctl part by myself

No need to byteswap req_hdr.type as lsa_find() will do that for us.
From Stefan Sperling

Correct the output of several error and debug messages.

Monster commit of stuff I did mostly last month. What it does:
* removes kif and uses iface for everything interface related.
This removes unneeded data redundancy which makes the code more complex.
* adds the link local prefix to struct iface and attaches a list with
the other prefixes to the struct iface. This is needed to generate the
link LSA.
* disconnects struct iface from struct area (the backpointer is gone)
this will make the reload code a bit easier.
norby@ agrees with the direction we're heading with this

Make lsa_find() find link local LSA by passing the interface instead of the
area as lookup point. Additionally make lsa_dump or actually the code around
it pass all LSA to ospf6ctl. The rde_spf.c are not final.

Monster diff to bring us a bit on track again.
a) implement all (or at least most) lsa_check() cases.
b) classify the LSA scope correctly and add a per interface lsa_tree for
the link local stuff.
c) implement a function to parse a prefix.

There is still a lot missing currently link local LSA are added to the
interface tree but nothing can access them (lsa_find() and a few friends
need some changes).
OK norby@

lsa_snap() should work so enable it.

Enable the IMSG_DD related code. This code starts to work.

In OSPFv3 the LSA type is a 16 bit value, furthermore it uses different
values than the v2 counterpart.

Change to u_int16_t and define new LSA types.

ok claudio@

First step at making kroute IPv6 aware. This resulted in many additional
changes -- some are so hairy that I left them out for later by commenting out
larger blocks of code (just grep for XXX if you like to help).
Get it in early so that we can work on.
OK norby@

Disable some code that is currently far from working and results in frequent
session resets because of bad packets. With this it seems we survive the
hello and database exchange phases. A closer look at the DR and BDR calculation
is still needed.

From ospfd:
Bye bye global ospf options. OSPF options are per area (at least the one
flag that we set). So introduce a area_ospf_options() function that will
return the correct flags for each area. This makes stub area support a lot
easier.
Don't check for OSPF_OPTION_E in the parent. OSPF_OPTION_E is per area and
so the parent process has no way to know if it should redistribute or not.

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

When IMSG_IFADD is removed, IMSG_IFDELETE becomes useless

OK remi@

IMSG_IFADD is never used, wipe it

OK remi@

Handle connected routes as ospfd(8) does.

OK remi@

Rework of rde_asext_get()/rde_asext_put().
Also change get_net_link() and get_rtr_link() to work like ospfd(8)
couterpart.

OK remi@

Bring ospf6d closer to ospfd

- update debug messages to be more precise
- simplify call to lsa_self()
- drop lsa_find_lsid() redondant parameters

OK remi@

No need to pass peerid to lsa_snap()

OK remi@

Rename orig_rtr_lsa_area() to orig_rtr_lsa()

Now that area is part of iface, original orig_rtr_lsa() is useless. Also
verifying that area != NULL is not needed in some cases (these are
leftovers of the previous diff).

OK remi@

Area is now part of struct iface

OK remi@

Introduce conf_clear_redist_list() (from ospfd) and use it in all 3 procs.

ok benno@

Add support for rdomains.

small quirk from tb@
ok phessler@

With the "depend on" option routes are sent out with a metric of 65535 if
the referenced interface is down or in state backup. This is especially
useful on a carp cluster to ensure all traffic goes to the carp master.

ok friehm@ jca@

pledge(2)

Looks great! deraadt@
OK florian
OK remi@

Send LSAs with MAX_METRIC for carp interfaces in state backup.
This is similar to what ospfd does.

ok jca@

Fix resending intra area prefix LSAs on link state or if flag change.

ok jca@

memory leak spotted by claudio@

go ahead jca@
OK claudio@

The value for metric of intra area prefix LSAs should be set to:
- 0 when referencing Network LSAs
- 0 for loopback interfaces
- interface output cost for other cases

go ahead jca@
OK claudio@

bring ospf6d's log.c in sync with ospfd and bgpd
ok florian@ claudio@

Import route priority support from ospfd to ospf6d.
Also remove the RTF_UP flag from hdr.rtm_flags in send_rtmsg() since
ospfd and bgpd don't set the flag.

OK bluhm@ claudio@

Adding multipath route support to ospf6d. Almost copied from ospfd.

OK bluhm@

Replace struct rroute with struct kroute, as done in ospfd

ok claudio@

Simplify shutdown process.

On shutdown, there's no need to use kill(2) to kill the child
processes. Just closing the IPC sockets will make the children receive
an EOF, break out from the event loop and then exit.

Tha advantages of this "pipe teardown" are:
* simpler code;
* no need to pledge "proc" in the parent process;
* removal of a (hard to trigger) PID reuse race condition.

ok benno@ claudio@

work on making log.c similar in all daemons:

move daemon-local functions into new logmsg.c, and reduce
the (mostly whitespace) differences so that log.c's can be diffed easily.

ok claudio@, feedback from henning@, deraadt@, reyk@

add format attributes to the proper functions and then fix the
warning in rde.c

EAGAIN handling for imsg_read. OK henning@ benno@

As done for bgpd recently, rename if_mediatype to if_type in ospfd/ospf6d.
And some ifmedia64 fixes.
"move forward" deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Close connections when msgbuf_write() returns 0.

ok claudio@

handle msgbuf_write() returning EAGAIN,
taken from claudios previous fix to ospfd.

"do it" deraadt@

Fix trailing whitespaces.

Add a #include that's currently picked up via another header that's
violating namespace rules

ok claudio@

Rework the distribution of link state and iface FSM state changes.
Link state changes are sent from the parent to both childs and
iface FSM state changes are sent from the ospfe to the rde.

Just use if_find() to find an interface by ifindex.

correct/change some debug and fatal messages.

Kill nh_reachable. Link state checking is so easy now that it does not
matter anymore to cache this value for ospf6d.

LINK_STATE_IS_UP() cleanup userland part. There is no need to special
case carp(4) interfaces anymore. LINK_STATE_IS_UP() almost always does
the right job.
OK deraadt@ henning@

This needs a -current kernel or link state may be not reported correctly.

Make sure that passive interfaces (like carp) are added to the
intra-area rtr LSA. Diff initialy made by Patrick Coleman but
simplified by myself. Tested and OK dlg@

KNF

Don't include sys/param.h and reformat some lines.

When removing an announced prefix, inherit the metric and ext_tag
from the LSA that is currently in the tree. Based on claudio@'s
diff and his fix for ospfd. Additionally originate an LSA with
external route tag correctly by writing the AS-external-LSA's bit
T into the correct field.
ok claudio@

Do not try to originate an intra-area-prefix-lsa if an interface
address changes that does not belong to any area. This fixes an
ospf6d crash. To not search for the area in orig_intra_lsa_net(),
just pass the area as function parameter.
ok claudio@

Update the interfaces changes from kroute to rde via imsg. This
is needed to orginate correct intra-area-prefix-lsas.
ok claudio@ stsp@

Use the static variable narea only where needed for config reload.
The other imessages use the stack variables area and iface.
ok claudio@

During network intra-area-prefix-lsa origination, the designated
router's prefixes were ignored if all other routers on that link
had no prefixes. Advertise a intra-area-prefix-lsa with all prefixes
for the network if there are any adjacent neighbors on link.
ok stsp@

Fix memory leak by adding a missing free(lsa).
ok claudio@

Fix all white space bugs in ospf6d at once. No binary change.
ok claudio@

The prefixes of interface addresses of an ospf link have to be
advertised as link-lsa and intra-area-prefix-lsa when they change
dynamically. Handle RTM_NEWADDR and RTM_DELADDR in kroute by sending
an imsg to ospfe. Upon this event, originate a new link-lsa in
ospfe. In rde a new intra-area-prefix-lsa is generated when a
link-lsa appears or goes away.
ok claudio@; ok and test stsp@

Store the ifindex into the kroute change imsg. This way we can use
the interface index for writing routes into the kernel.
ok claudio@

Fix an obvious use after free. From ospfd.
ok claudio@

Add NULL pointer check after calloc.
ok claudio@ stsp@

Fix error message.
ok claudio@ stsp@

Move a function to a place that is a bit more logical. No functional change.

Support for redistributing AS-ext LSA (redistribute static/connected).
Appart from multi-area support this is the last big missing piece in
ospf6d. ospf6d should now work correctly in single area setups.
So please test.
"it's always nice to see those #if 0 being killed" stsp@

In orig_intra_lsa_rtr(), don't allocate and free a temporary buffer
which easily fits on the stack.

OK claudio@

Add interface index aka. scope id to struct kroute so that the rde can pass
this information to kroute and kroute can use that information to fill in
the various sin6_scope_id fields.

Add IMSG_CTL_LOG_VERBOSE similar to ospfd it allows to toggle debug logging.
henning, sthen, michele like the idea

More fallout from the r1.31 commit. This time PID and the fd got swapped.
Again from stsp@

Running 'ospf6ctl show' twice caused ospf6d to fatal. Cause was a missing -
when passing -1 as fd to the imsg call. No frogs for eric@ and pyr@
From stsp@

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Remove redundant imsg_event_add calls; ok claudio@

libevent handler fix to allow EV_READ and EV_WRITE to be set at the same
time in the callback. Same diff that went into ospfd applied with some
fuzz.

Fix a naming inconsistency in struct lsa_intra_prefix (lsid -> ls_id).

"consistency is a good thing" jsing@, ok claudio@

As a first step towards SPF tree calculation, prepare for proper
next-hop calculation.

In OSPFv3, next-hop IP addresses are always link-local.
The kernel will want to know which interface the link-local
address belongs to, so we need an ifindex in struct v_nexthop
in addition to the IP address.

Because we cannot determine a link-local next hop IP address
for transit networks, only the outgoing interface will be recorded.

Update calc_nexthop_add() according to the above.

Also add new helpers calc_nexthop_lladdr() and calc_nexthop_transit_nbr(),
to figure out link-local addresses of nexthop neighbours.

ok claudio@

lsa_self() did too many things at once, and had too much logic
buried inside of it that its caller relied on.

So split it up as follows:
lsa_self() Check whether an LSA is self-originated.
lsa_flush() Flush an LSA from the LSDB.
lsa_reflood() Prepare an LSA for reflooding (actual reflooding currently
requires sending an imsg which must be done by the caller).

ok claudio@

Add lsa_find_tree() to allow searching for LSAs in a specific LSA tree.
We had code marked XXX searching an LSA tree manually using RB_FIND(),
switch it over to lsa_find_tree().
Make lsa_find() use the new function, too, to avoid code duplication.
ok claudio@

Use rde_router_id() instead of directly accessing rdeconf->rtr_id.s_addr.

"For sure!" claudio@

Enable origination of Intra-Area-Prefix LSAs in rde.

New Intra-Area-Prefix LSAs are originated when a neighbour
becomes adjacent, or when a neighbour loses adjacency,
or when an interface changes state.

ok claudio@

Virtually re-implement origination of Intra-Area-Prefix LSAs.
We now comply with RFC5340 and move prefixes between the two
ref-types of Intra-Area-Prefix LSAs (router and network).

In case an LSA ends up having all of its prefixes moved to another
one, the LSA is flushed from the LSDB by re-originating with MAX_AGE.
(This does not yet work reliably. We end up having LSAs with zero
prefixes in the LSDB in some cases. Should not affect SPF calculation,
so not much harm done, but will need to be fixed.)

This commit just adds the necessary code to do origination,
but it is not being called yet. This will be done in a separate
commit.

"Looks good." claudio@

Sync iface fsm state from ospfe to rde.

Also syncs other fields the ospfe is syncing to when getting
iface updates from parent process.
None of these fields are used by the rde yet, but state will be
important soon, for proper origination of Intra-Area-Prefix LSAs.

ok claudio@

Fix two obvious copy-paste errors in fatal error messages. We were
printing IFINFO while we are actually handling an IFDELETE imsg.

Formatting fixes.

Hard-code the Link State ID of Intra-Area-Prefix LSAs referencing Network
LSAs to zero. We were using the interface index, which is not quite right
for this type of LSA.

This is part of a greater scheme:
Intra-Area-Prefix LSAs referencing Router LSAs (not yet implemented)
will initially have their Link State ID hard-coded to one.
Then, as soon as we implement fragmentation of Intra-Area-Prefix LSAs,
Link State IDs for both types of Intra-Area-Prefix LSA will have to be
generated dynamically in a non-overlapping fashion.

discussed with claudio@

Improve debugging message in orig_intra_lsa_net().
Print not just the area, but also the interface to the link the LSA
is generated for.
ok claudio@

Teach ospf6d to originate Intra-Area-Prefix LSAs, which associate a list
of IPv6 prefixes with a Network LSA (there's another type of this LSA which
associates prefixes with a Router LSA -- this remains to be done).
Add what is necessary to allow ospf6ctl to read the new LSA type via IMSG.
ok claudio@

Again, no need to double check if neighbor exists.

ok stsp@

Since link LSAs live in iface->lsa_tree and not in area->lsa_tree,
we had better include LSAs from iface->lsa_tree when sending
DB summaries. Fixes initial flood of link LSAs.
ok claudio@

First try at originating Link (type-8) LSA. Code is wrong and the initial
LSA is lost in lsa_flood. Put this in because it goes in the right direction
and ospf6d is work in progress. Add necessary framework so that we can print
Link LSA in ospf6ctl.
Diff mostly from stsp@ ospf6ctl part by myself

No need to byteswap req_hdr.type as lsa_find() will do that for us.
From Stefan Sperling

Correct the output of several error and debug messages.

Monster commit of stuff I did mostly last month. What it does:
* removes kif and uses iface for everything interface related.
This removes unneeded data redundancy which makes the code more complex.
* adds the link local prefix to struct iface and attaches a list with
the other prefixes to the struct iface. This is needed to generate the
link LSA.
* disconnects struct iface from struct area (the backpointer is gone)
this will make the reload code a bit easier.
norby@ agrees with the direction we're heading with this

Make lsa_find() find link local LSA by passing the interface instead of the
area as lookup point. Additionally make lsa_dump or actually the code around
it pass all LSA to ospf6ctl. The rde_spf.c are not final.

Monster diff to bring us a bit on track again.
a) implement all (or at least most) lsa_check() cases.
b) classify the LSA scope correctly and add a per interface lsa_tree for
the link local stuff.
c) implement a function to parse a prefix.

There is still a lot missing currently link local LSA are added to the
interface tree but nothing can access them (lsa_find() and a few friends
need some changes).
OK norby@

lsa_snap() should work so enable it.

Enable the IMSG_DD related code. This code starts to work.

In OSPFv3 the LSA type is a 16 bit value, furthermore it uses different
values than the v2 counterpart.

Change to u_int16_t and define new LSA types.

ok claudio@

First step at making kroute IPv6 aware. This resulted in many additional
changes -- some are so hairy that I left them out for later by commenting out
larger blocks of code (just grep for XXX if you like to help).
Get it in early so that we can work on.
OK norby@

Disable some code that is currently far from working and results in frequent
session resets because of bad packets. With this it seems we survive the
hello and database exchange phases. A closer look at the DR and BDR calculation
is still needed.

From ospfd:
Bye bye global ospf options. OSPF options are per area (at least the one
flag that we set). So introduce a area_ospf_options() function that will
return the correct flags for each area. This makes stub area support a lot
easier.
Don't check for OSPF_OPTION_E in the parent. OSPF_OPTION_E is per area and
so the parent process has no way to know if it should redistribute or not.

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

Handle connected routes as ospfd(8) does.

OK remi@

Rework of rde_asext_get()/rde_asext_put().
Also change get_net_link() and get_rtr_link() to work like ospfd(8)
couterpart.

OK remi@

Bring ospf6d closer to ospfd

- update debug messages to be more precise
- simplify call to lsa_self()
- drop lsa_find_lsid() redondant parameters

OK remi@

No need to pass peerid to lsa_snap()

OK remi@

Rename orig_rtr_lsa_area() to orig_rtr_lsa()

Now that area is part of iface, original orig_rtr_lsa() is useless. Also
verifying that area != NULL is not needed in some cases (these are
leftovers of the previous diff).

OK remi@

Area is now part of struct iface

OK remi@

Introduce conf_clear_redist_list() (from ospfd) and use it in all 3 procs.

ok benno@

Add support for rdomains.

small quirk from tb@
ok phessler@

With the "depend on" option routes are sent out with a metric of 65535 if
the referenced interface is down or in state backup. This is especially
useful on a carp cluster to ensure all traffic goes to the carp master.

ok friehm@ jca@

pledge(2)

Looks great! deraadt@
OK florian
OK remi@

Send LSAs with MAX_METRIC for carp interfaces in state backup.
This is similar to what ospfd does.

ok jca@

Fix resending intra area prefix LSAs on link state or if flag change.

ok jca@

memory leak spotted by claudio@

go ahead jca@
OK claudio@

The value for metric of intra area prefix LSAs should be set to:
- 0 when referencing Network LSAs
- 0 for loopback interfaces
- interface output cost for other cases

go ahead jca@
OK claudio@

bring ospf6d's log.c in sync with ospfd and bgpd
ok florian@ claudio@

Import route priority support from ospfd to ospf6d.
Also remove the RTF_UP flag from hdr.rtm_flags in send_rtmsg() since
ospfd and bgpd don't set the flag.

OK bluhm@ claudio@

Adding multipath route support to ospf6d. Almost copied from ospfd.

OK bluhm@

Replace struct rroute with struct kroute, as done in ospfd

ok claudio@

Simplify shutdown process.

On shutdown, there's no need to use kill(2) to kill the child
processes. Just closing the IPC sockets will make the children receive
an EOF, break out from the event loop and then exit.

Tha advantages of this "pipe teardown" are:
* simpler code;
* no need to pledge "proc" in the parent process;
* removal of a (hard to trigger) PID reuse race condition.

ok benno@ claudio@

work on making log.c similar in all daemons:

move daemon-local functions into new logmsg.c, and reduce
the (mostly whitespace) differences so that log.c's can be diffed easily.

ok claudio@, feedback from henning@, deraadt@, reyk@

add format attributes to the proper functions and then fix the
warning in rde.c

EAGAIN handling for imsg_read. OK henning@ benno@

As done for bgpd recently, rename if_mediatype to if_type in ospfd/ospf6d.
And some ifmedia64 fixes.
"move forward" deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Close connections when msgbuf_write() returns 0.

ok claudio@

handle msgbuf_write() returning EAGAIN,
taken from claudios previous fix to ospfd.

"do it" deraadt@

Fix trailing whitespaces.

Add a #include that's currently picked up via another header that's
violating namespace rules

ok claudio@

Rework the distribution of link state and iface FSM state changes.
Link state changes are sent from the parent to both childs and
iface FSM state changes are sent from the ospfe to the rde.

Just use if_find() to find an interface by ifindex.

correct/change some debug and fatal messages.

Kill nh_reachable. Link state checking is so easy now that it does not
matter anymore to cache this value for ospf6d.

LINK_STATE_IS_UP() cleanup userland part. There is no need to special
case carp(4) interfaces anymore. LINK_STATE_IS_UP() almost always does
the right job.
OK deraadt@ henning@

This needs a -current kernel or link state may be not reported correctly.

Make sure that passive interfaces (like carp) are added to the
intra-area rtr LSA. Diff initialy made by Patrick Coleman but
simplified by myself. Tested and OK dlg@

KNF

Don't include sys/param.h and reformat some lines.

When removing an announced prefix, inherit the metric and ext_tag
from the LSA that is currently in the tree. Based on claudio@'s
diff and his fix for ospfd. Additionally originate an LSA with
external route tag correctly by writing the AS-external-LSA's bit
T into the correct field.
ok claudio@

Do not try to originate an intra-area-prefix-lsa if an interface
address changes that does not belong to any area. This fixes an
ospf6d crash. To not search for the area in orig_intra_lsa_net(),
just pass the area as function parameter.
ok claudio@

Update the interfaces changes from kroute to rde via imsg. This
is needed to orginate correct intra-area-prefix-lsas.
ok claudio@ stsp@

Use the static variable narea only where needed for config reload.
The other imessages use the stack variables area and iface.
ok claudio@

During network intra-area-prefix-lsa origination, the designated
router's prefixes were ignored if all other routers on that link
had no prefixes. Advertise a intra-area-prefix-lsa with all prefixes
for the network if there are any adjacent neighbors on link.
ok stsp@

Fix memory leak by adding a missing free(lsa).
ok claudio@

Fix all white space bugs in ospf6d at once. No binary change.
ok claudio@

The prefixes of interface addresses of an ospf link have to be
advertised as link-lsa and intra-area-prefix-lsa when they change
dynamically. Handle RTM_NEWADDR and RTM_DELADDR in kroute by sending
an imsg to ospfe. Upon this event, originate a new link-lsa in
ospfe. In rde a new intra-area-prefix-lsa is generated when a
link-lsa appears or goes away.
ok claudio@; ok and test stsp@

Store the ifindex into the kroute change imsg. This way we can use
the interface index for writing routes into the kernel.
ok claudio@

Fix an obvious use after free. From ospfd.
ok claudio@

Add NULL pointer check after calloc.
ok claudio@ stsp@

Fix error message.
ok claudio@ stsp@

Move a function to a place that is a bit more logical. No functional change.

Support for redistributing AS-ext LSA (redistribute static/connected).
Appart from multi-area support this is the last big missing piece in
ospf6d. ospf6d should now work correctly in single area setups.
So please test.
"it's always nice to see those #if 0 being killed" stsp@

In orig_intra_lsa_rtr(), don't allocate and free a temporary buffer
which easily fits on the stack.

OK claudio@

Add interface index aka. scope id to struct kroute so that the rde can pass
this information to kroute and kroute can use that information to fill in
the various sin6_scope_id fields.

Add IMSG_CTL_LOG_VERBOSE similar to ospfd it allows to toggle debug logging.
henning, sthen, michele like the idea

More fallout from the r1.31 commit. This time PID and the fd got swapped.
Again from stsp@

Running 'ospf6ctl show' twice caused ospf6d to fatal. Cause was a missing -
when passing -1 as fd to the imsg call. No frogs for eric@ and pyr@
From stsp@

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@