Use ibuf_data() instead of direct access to ibuf->buf,
use ibuf_size() instead of direct access to ibuf->wpos,
use ibuf_left() in places where the code checks if there is enough
space left in the ibuf.
OK tb@

Update ospf6d to use new ibuf api.

This mostly moves away from memcpy(ibuf_seek(buf, off, size), data, size) to
ibuf_set(buf, off, data, size). Also ibuf_reserve() is replaced with
ibuf_add_zero().

OK tb@

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

log the interface along with the neighbour ID in various ospfd/ospf6d
messages. ok remi@ benno@

if a neighbour is reachable over multiple network links, some problems
may be related to the link itself rather than the neighbour, so knowing
the interface can be important when trying to locate the source of a
problem.

Use ospfe_imsg_compose_rde() instead of exporting iev_rde and using
imsg_compose_event() directly. This is needed to make the imsg event
structures static in ospfe.c, rde.c and ospf6d.c.

Send lsupdate messages to the correct neighbor address on P2P interfaces.
iface->dst is not initalized so instead use nbr->addr (like it is done in
ospfd).
OK benno@

Remove unused variables

Same fix for ospfd lsupdate.c applies in ospf6d as well.
Do not use the pointer returned by ibuf_reserve() after calling another
ibuf function. After the call the internal buffer may have moved by realloc()
and so the pointer is invalid. Instead use ibuf_size() to get the current
offset in the buffer and use ibuf_seek() later on to write back the updated
lsa age into the buffer at the right spot.
This fixes an issue seen by Richard Chivers on routers with many passive
interfaces.
OK stsp@ denis@ deraadt@ also tested by sthen@

Partially reverse a commit from 2019/12/28

A large number of redistributed routes make ospf6d crash.

OK remi@, sthen@

Refactor link state ack/req.

OK remi@

Convert sendto() to sendmsg().

This makes code similar to ospfd(8).

OK claudio@ deraadt@

When comparing the LSA with the Ack, also check the age field. This
ensures that a LSA withdrawal is not acked by a previous update.
From Florian Riehm; OK claudio@

remove a stupid -Wstrict-prototype warning by making the hash function
static. noticed by florian riehm

simple to use siphash here. ok deraadt

sync w/ospfd: improve snapshot handling; ok claudio, sthen

sync w/ ospfd:
for point-to-point interfaces we need to send lsupdates to the
interface address, since there is no DR and multicast messages to
the DR will be ignored. ok claudio@, then@

Calculate size of update packet with IPv6 header and reserve space
for IPsec. Avoid IPv6 fragments where possible. If a single LSA
is too big, put it into a separate packet with up to IPV6_MAXPACKET
bytes. This packet may get fragmented by the kernel.
ok stsp@

The is no md5 authentication in OSPFv3. Remove some leftovers from
the ospf6d packet lenght calculation.
ok claudio@ stsp@

With IPv6 OSPF a single LSA can get larger than the MTU. As a
workaround it is better to drop this LSA with a log entry instead
of sending emtpy update packets in a burst. As link LSAs cannot
be split, the propper solution might be IPv6 fragments. See also
RFC5340 Section 4.4.3.8 and Appendix A.1.
ok stsp@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Correct the output of several error and debug messages.

send_packet() now takes a struct in6_addr as destination instead of a
struct sockaddr_in6 and builds the struct sockaddr_in6 internaly adding scope
if necessary. While there switch to sendto() we don't need any of the sendmsg()
features here.
OK norby@

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

Update ospf6d to use new ibuf api.

This mostly moves away from memcpy(ibuf_seek(buf, off, size), data, size) to
ibuf_set(buf, off, data, size). Also ibuf_reserve() is replaced with
ibuf_add_zero().

OK tb@

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

log the interface along with the neighbour ID in various ospfd/ospf6d
messages. ok remi@ benno@

if a neighbour is reachable over multiple network links, some problems
may be related to the link itself rather than the neighbour, so knowing
the interface can be important when trying to locate the source of a
problem.

Use ospfe_imsg_compose_rde() instead of exporting iev_rde and using
imsg_compose_event() directly. This is needed to make the imsg event
structures static in ospfe.c, rde.c and ospf6d.c.

Send lsupdate messages to the correct neighbor address on P2P interfaces.
iface->dst is not initalized so instead use nbr->addr (like it is done in
ospfd).
OK benno@

Remove unused variables

Same fix for ospfd lsupdate.c applies in ospf6d as well.
Do not use the pointer returned by ibuf_reserve() after calling another
ibuf function. After the call the internal buffer may have moved by realloc()
and so the pointer is invalid. Instead use ibuf_size() to get the current
offset in the buffer and use ibuf_seek() later on to write back the updated
lsa age into the buffer at the right spot.
This fixes an issue seen by Richard Chivers on routers with many passive
interfaces.
OK stsp@ denis@ deraadt@ also tested by sthen@

Partially reverse a commit from 2019/12/28

A large number of redistributed routes make ospf6d crash.

OK remi@, sthen@

Refactor link state ack/req.

OK remi@

Convert sendto() to sendmsg().

This makes code similar to ospfd(8).

OK claudio@ deraadt@

When comparing the LSA with the Ack, also check the age field. This
ensures that a LSA withdrawal is not acked by a previous update.
From Florian Riehm; OK claudio@

remove a stupid -Wstrict-prototype warning by making the hash function
static. noticed by florian riehm

simple to use siphash here. ok deraadt

sync w/ospfd: improve snapshot handling; ok claudio, sthen

sync w/ ospfd:
for point-to-point interfaces we need to send lsupdates to the
interface address, since there is no DR and multicast messages to
the DR will be ignored. ok claudio@, then@

Calculate size of update packet with IPv6 header and reserve space
for IPsec. Avoid IPv6 fragments where possible. If a single LSA
is too big, put it into a separate packet with up to IPV6_MAXPACKET
bytes. This packet may get fragmented by the kernel.
ok stsp@

The is no md5 authentication in OSPFv3. Remove some leftovers from
the ospf6d packet lenght calculation.
ok claudio@ stsp@

With IPv6 OSPF a single LSA can get larger than the MTU. As a
workaround it is better to drop this LSA with a log entry instead
of sending emtpy update packets in a burst. As link LSAs cannot
be split, the propper solution might be IPv6 fragments. See also
RFC5340 Section 4.4.3.8 and Appendix A.1.
ok stsp@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Correct the output of several error and debug messages.

send_packet() now takes a struct in6_addr as destination instead of a
struct sockaddr_in6 and builds the struct sockaddr_in6 internaly adding scope
if necessary. While there switch to sendto() we don't need any of the sendmsg()
features here.
OK norby@

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

log the interface along with the neighbour ID in various ospfd/ospf6d
messages. ok remi@ benno@

if a neighbour is reachable over multiple network links, some problems
may be related to the link itself rather than the neighbour, so knowing
the interface can be important when trying to locate the source of a
problem.

Use ospfe_imsg_compose_rde() instead of exporting iev_rde and using
imsg_compose_event() directly. This is needed to make the imsg event
structures static in ospfe.c, rde.c and ospf6d.c.

Send lsupdate messages to the correct neighbor address on P2P interfaces.
iface->dst is not initalized so instead use nbr->addr (like it is done in
ospfd).
OK benno@

Remove unused variables

Same fix for ospfd lsupdate.c applies in ospf6d as well.
Do not use the pointer returned by ibuf_reserve() after calling another
ibuf function. After the call the internal buffer may have moved by realloc()
and so the pointer is invalid. Instead use ibuf_size() to get the current
offset in the buffer and use ibuf_seek() later on to write back the updated
lsa age into the buffer at the right spot.
This fixes an issue seen by Richard Chivers on routers with many passive
interfaces.
OK stsp@ denis@ deraadt@ also tested by sthen@

Partially reverse a commit from 2019/12/28

A large number of redistributed routes make ospf6d crash.

OK remi@, sthen@

Refactor link state ack/req.

OK remi@

Convert sendto() to sendmsg().

This makes code similar to ospfd(8).

OK claudio@ deraadt@

When comparing the LSA with the Ack, also check the age field. This
ensures that a LSA withdrawal is not acked by a previous update.
From Florian Riehm; OK claudio@

remove a stupid -Wstrict-prototype warning by making the hash function
static. noticed by florian riehm

simple to use siphash here. ok deraadt

sync w/ospfd: improve snapshot handling; ok claudio, sthen

sync w/ ospfd:
for point-to-point interfaces we need to send lsupdates to the
interface address, since there is no DR and multicast messages to
the DR will be ignored. ok claudio@, then@

Calculate size of update packet with IPv6 header and reserve space
for IPsec. Avoid IPv6 fragments where possible. If a single LSA
is too big, put it into a separate packet with up to IPV6_MAXPACKET
bytes. This packet may get fragmented by the kernel.
ok stsp@

The is no md5 authentication in OSPFv3. Remove some leftovers from
the ospf6d packet lenght calculation.
ok claudio@ stsp@

With IPv6 OSPF a single LSA can get larger than the MTU. As a
workaround it is better to drop this LSA with a log entry instead
of sending emtpy update packets in a burst. As link LSAs cannot
be split, the propper solution might be IPv6 fragments. See also
RFC5340 Section 4.4.3.8 and Appendix A.1.
ok stsp@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Correct the output of several error and debug messages.

send_packet() now takes a struct in6_addr as destination instead of a
struct sockaddr_in6 and builds the struct sockaddr_in6 internaly adding scope
if necessary. While there switch to sendto() we don't need any of the sendmsg()
features here.
OK norby@

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

log the interface along with the neighbour ID in various ospfd/ospf6d
messages. ok remi@ benno@

if a neighbour is reachable over multiple network links, some problems
may be related to the link itself rather than the neighbour, so knowing
the interface can be important when trying to locate the source of a
problem.

Use ospfe_imsg_compose_rde() instead of exporting iev_rde and using
imsg_compose_event() directly. This is needed to make the imsg event
structures static in ospfe.c, rde.c and ospf6d.c.

Send lsupdate messages to the correct neighbor address on P2P interfaces.
iface->dst is not initalized so instead use nbr->addr (like it is done in
ospfd).
OK benno@

Remove unused variables

Same fix for ospfd lsupdate.c applies in ospf6d as well.
Do not use the pointer returned by ibuf_reserve() after calling another
ibuf function. After the call the internal buffer may have moved by realloc()
and so the pointer is invalid. Instead use ibuf_size() to get the current
offset in the buffer and use ibuf_seek() later on to write back the updated
lsa age into the buffer at the right spot.
This fixes an issue seen by Richard Chivers on routers with many passive
interfaces.
OK stsp@ denis@ deraadt@ also tested by sthen@

Partially reverse a commit from 2019/12/28

A large number of redistributed routes make ospf6d crash.

OK remi@, sthen@

Refactor link state ack/req.

OK remi@

Convert sendto() to sendmsg().

This makes code similar to ospfd(8).

OK claudio@ deraadt@

When comparing the LSA with the Ack, also check the age field. This
ensures that a LSA withdrawal is not acked by a previous update.
From Florian Riehm; OK claudio@

remove a stupid -Wstrict-prototype warning by making the hash function
static. noticed by florian riehm

simple to use siphash here. ok deraadt

sync w/ospfd: improve snapshot handling; ok claudio, sthen

sync w/ ospfd:
for point-to-point interfaces we need to send lsupdates to the
interface address, since there is no DR and multicast messages to
the DR will be ignored. ok claudio@, then@

Calculate size of update packet with IPv6 header and reserve space
for IPsec. Avoid IPv6 fragments where possible. If a single LSA
is too big, put it into a separate packet with up to IPV6_MAXPACKET
bytes. This packet may get fragmented by the kernel.
ok stsp@

The is no md5 authentication in OSPFv3. Remove some leftovers from
the ospf6d packet lenght calculation.
ok claudio@ stsp@

With IPv6 OSPF a single LSA can get larger than the MTU. As a
workaround it is better to drop this LSA with a log entry instead
of sending emtpy update packets in a burst. As link LSAs cannot
be split, the propper solution might be IPv6 fragments. See also
RFC5340 Section 4.4.3.8 and Appendix A.1.
ok stsp@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Correct the output of several error and debug messages.

send_packet() now takes a struct in6_addr as destination instead of a
struct sockaddr_in6 and builds the struct sockaddr_in6 internaly adding scope
if necessary. While there switch to sendto() we don't need any of the sendmsg()
features here.
OK norby@

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

Use ospfe_imsg_compose_rde() instead of exporting iev_rde and using
imsg_compose_event() directly. This is needed to make the imsg event
structures static in ospfe.c, rde.c and ospf6d.c.

Send lsupdate messages to the correct neighbor address on P2P interfaces.
iface->dst is not initalized so instead use nbr->addr (like it is done in
ospfd).
OK benno@

Remove unused variables

Same fix for ospfd lsupdate.c applies in ospf6d as well.
Do not use the pointer returned by ibuf_reserve() after calling another
ibuf function. After the call the internal buffer may have moved by realloc()
and so the pointer is invalid. Instead use ibuf_size() to get the current
offset in the buffer and use ibuf_seek() later on to write back the updated
lsa age into the buffer at the right spot.
This fixes an issue seen by Richard Chivers on routers with many passive
interfaces.
OK stsp@ denis@ deraadt@ also tested by sthen@

Partially reverse a commit from 2019/12/28

A large number of redistributed routes make ospf6d crash.

OK remi@, sthen@

Refactor link state ack/req.

OK remi@

Convert sendto() to sendmsg().

This makes code similar to ospfd(8).

OK claudio@ deraadt@

When comparing the LSA with the Ack, also check the age field. This
ensures that a LSA withdrawal is not acked by a previous update.
From Florian Riehm; OK claudio@

remove a stupid -Wstrict-prototype warning by making the hash function
static. noticed by florian riehm

simple to use siphash here. ok deraadt

sync w/ospfd: improve snapshot handling; ok claudio, sthen

sync w/ ospfd:
for point-to-point interfaces we need to send lsupdates to the
interface address, since there is no DR and multicast messages to
the DR will be ignored. ok claudio@, then@

Calculate size of update packet with IPv6 header and reserve space
for IPsec. Avoid IPv6 fragments where possible. If a single LSA
is too big, put it into a separate packet with up to IPV6_MAXPACKET
bytes. This packet may get fragmented by the kernel.
ok stsp@

The is no md5 authentication in OSPFv3. Remove some leftovers from
the ospf6d packet lenght calculation.
ok claudio@ stsp@

With IPv6 OSPF a single LSA can get larger than the MTU. As a
workaround it is better to drop this LSA with a log entry instead
of sending emtpy update packets in a burst. As link LSAs cannot
be split, the propper solution might be IPv6 fragments. See also
RFC5340 Section 4.4.3.8 and Appendix A.1.
ok stsp@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Correct the output of several error and debug messages.

send_packet() now takes a struct in6_addr as destination instead of a
struct sockaddr_in6 and builds the struct sockaddr_in6 internaly adding scope
if necessary. While there switch to sendto() we don't need any of the sendmsg()
features here.
OK norby@

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

Send lsupdate messages to the correct neighbor address on P2P interfaces.
iface->dst is not initalized so instead use nbr->addr (like it is done in
ospfd).
OK benno@

Remove unused variables

Same fix for ospfd lsupdate.c applies in ospf6d as well.
Do not use the pointer returned by ibuf_reserve() after calling another
ibuf function. After the call the internal buffer may have moved by realloc()
and so the pointer is invalid. Instead use ibuf_size() to get the current
offset in the buffer and use ibuf_seek() later on to write back the updated
lsa age into the buffer at the right spot.
This fixes an issue seen by Richard Chivers on routers with many passive
interfaces.
OK stsp@ denis@ deraadt@ also tested by sthen@

Partially reverse a commit from 2019/12/28

A large number of redistributed routes make ospf6d crash.

OK remi@, sthen@

Refactor link state ack/req.

OK remi@

Convert sendto() to sendmsg().

This makes code similar to ospfd(8).

OK claudio@ deraadt@

When comparing the LSA with the Ack, also check the age field. This
ensures that a LSA withdrawal is not acked by a previous update.
From Florian Riehm; OK claudio@

remove a stupid -Wstrict-prototype warning by making the hash function
static. noticed by florian riehm

simple to use siphash here. ok deraadt

sync w/ospfd: improve snapshot handling; ok claudio, sthen

sync w/ ospfd:
for point-to-point interfaces we need to send lsupdates to the
interface address, since there is no DR and multicast messages to
the DR will be ignored. ok claudio@, then@

Calculate size of update packet with IPv6 header and reserve space
for IPsec. Avoid IPv6 fragments where possible. If a single LSA
is too big, put it into a separate packet with up to IPV6_MAXPACKET
bytes. This packet may get fragmented by the kernel.
ok stsp@

The is no md5 authentication in OSPFv3. Remove some leftovers from
the ospf6d packet lenght calculation.
ok claudio@ stsp@

With IPv6 OSPF a single LSA can get larger than the MTU. As a
workaround it is better to drop this LSA with a log entry instead
of sending emtpy update packets in a burst. As link LSAs cannot
be split, the propper solution might be IPv6 fragments. See also
RFC5340 Section 4.4.3.8 and Appendix A.1.
ok stsp@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Correct the output of several error and debug messages.

send_packet() now takes a struct in6_addr as destination instead of a
struct sockaddr_in6 and builds the struct sockaddr_in6 internaly adding scope
if necessary. While there switch to sendto() we don't need any of the sendmsg()
features here.
OK norby@

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

Remove unused variables

Same fix for ospfd lsupdate.c applies in ospf6d as well.
Do not use the pointer returned by ibuf_reserve() after calling another
ibuf function. After the call the internal buffer may have moved by realloc()
and so the pointer is invalid. Instead use ibuf_size() to get the current
offset in the buffer and use ibuf_seek() later on to write back the updated
lsa age into the buffer at the right spot.
This fixes an issue seen by Richard Chivers on routers with many passive
interfaces.
OK stsp@ denis@ deraadt@ also tested by sthen@

Partially reverse a commit from 2019/12/28

A large number of redistributed routes make ospf6d crash.

OK remi@, sthen@

Refactor link state ack/req.

OK remi@

Convert sendto() to sendmsg().

This makes code similar to ospfd(8).

OK claudio@ deraadt@

When comparing the LSA with the Ack, also check the age field. This
ensures that a LSA withdrawal is not acked by a previous update.
From Florian Riehm; OK claudio@

remove a stupid -Wstrict-prototype warning by making the hash function
static. noticed by florian riehm

simple to use siphash here. ok deraadt

sync w/ospfd: improve snapshot handling; ok claudio, sthen

sync w/ ospfd:
for point-to-point interfaces we need to send lsupdates to the
interface address, since there is no DR and multicast messages to
the DR will be ignored. ok claudio@, then@

Calculate size of update packet with IPv6 header and reserve space
for IPsec. Avoid IPv6 fragments where possible. If a single LSA
is too big, put it into a separate packet with up to IPV6_MAXPACKET
bytes. This packet may get fragmented by the kernel.
ok stsp@

The is no md5 authentication in OSPFv3. Remove some leftovers from
the ospf6d packet lenght calculation.
ok claudio@ stsp@

With IPv6 OSPF a single LSA can get larger than the MTU. As a
workaround it is better to drop this LSA with a log entry instead
of sending emtpy update packets in a burst. As link LSAs cannot
be split, the propper solution might be IPv6 fragments. See also
RFC5340 Section 4.4.3.8 and Appendix A.1.
ok stsp@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Correct the output of several error and debug messages.

send_packet() now takes a struct in6_addr as destination instead of a
struct sockaddr_in6 and builds the struct sockaddr_in6 internaly adding scope
if necessary. While there switch to sendto() we don't need any of the sendmsg()
features here.
OK norby@

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

Same fix for ospfd lsupdate.c applies in ospf6d as well.
Do not use the pointer returned by ibuf_reserve() after calling another
ibuf function. After the call the internal buffer may have moved by realloc()
and so the pointer is invalid. Instead use ibuf_size() to get the current
offset in the buffer and use ibuf_seek() later on to write back the updated
lsa age into the buffer at the right spot.
This fixes an issue seen by Richard Chivers on routers with many passive
interfaces.
OK stsp@ denis@ deraadt@ also tested by sthen@

Partially reverse a commit from 2019/12/28

A large number of redistributed routes make ospf6d crash.

OK remi@, sthen@

Refactor link state ack/req.

OK remi@

Convert sendto() to sendmsg().

This makes code similar to ospfd(8).

OK claudio@ deraadt@

When comparing the LSA with the Ack, also check the age field. This
ensures that a LSA withdrawal is not acked by a previous update.
From Florian Riehm; OK claudio@

remove a stupid -Wstrict-prototype warning by making the hash function
static. noticed by florian riehm

simple to use siphash here. ok deraadt

sync w/ospfd: improve snapshot handling; ok claudio, sthen

sync w/ ospfd:
for point-to-point interfaces we need to send lsupdates to the
interface address, since there is no DR and multicast messages to
the DR will be ignored. ok claudio@, then@

Calculate size of update packet with IPv6 header and reserve space
for IPsec. Avoid IPv6 fragments where possible. If a single LSA
is too big, put it into a separate packet with up to IPV6_MAXPACKET
bytes. This packet may get fragmented by the kernel.
ok stsp@

The is no md5 authentication in OSPFv3. Remove some leftovers from
the ospf6d packet lenght calculation.
ok claudio@ stsp@

With IPv6 OSPF a single LSA can get larger than the MTU. As a
workaround it is better to drop this LSA with a log entry instead
of sending emtpy update packets in a burst. As link LSAs cannot
be split, the propper solution might be IPv6 fragments. See also
RFC5340 Section 4.4.3.8 and Appendix A.1.
ok stsp@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Correct the output of several error and debug messages.

send_packet() now takes a struct in6_addr as destination instead of a
struct sockaddr_in6 and builds the struct sockaddr_in6 internaly adding scope
if necessary. While there switch to sendto() we don't need any of the sendmsg()
features here.
OK norby@

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

Partially reverse a commit from 2019/12/28

A large number of redistributed routes make ospf6d crash.

OK remi@, sthen@

Refactor link state ack/req.

OK remi@

Convert sendto() to sendmsg().

This makes code similar to ospfd(8).

OK claudio@ deraadt@

When comparing the LSA with the Ack, also check the age field. This
ensures that a LSA withdrawal is not acked by a previous update.
From Florian Riehm; OK claudio@

remove a stupid -Wstrict-prototype warning by making the hash function
static. noticed by florian riehm

simple to use siphash here. ok deraadt

sync w/ospfd: improve snapshot handling; ok claudio, sthen

sync w/ ospfd:
for point-to-point interfaces we need to send lsupdates to the
interface address, since there is no DR and multicast messages to
the DR will be ignored. ok claudio@, then@

Calculate size of update packet with IPv6 header and reserve space
for IPsec. Avoid IPv6 fragments where possible. If a single LSA
is too big, put it into a separate packet with up to IPV6_MAXPACKET
bytes. This packet may get fragmented by the kernel.
ok stsp@

The is no md5 authentication in OSPFv3. Remove some leftovers from
the ospf6d packet lenght calculation.
ok claudio@ stsp@

With IPv6 OSPF a single LSA can get larger than the MTU. As a
workaround it is better to drop this LSA with a log entry instead
of sending emtpy update packets in a burst. As link LSAs cannot
be split, the propper solution might be IPv6 fragments. See also
RFC5340 Section 4.4.3.8 and Appendix A.1.
ok stsp@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Correct the output of several error and debug messages.

send_packet() now takes a struct in6_addr as destination instead of a
struct sockaddr_in6 and builds the struct sockaddr_in6 internaly adding scope
if necessary. While there switch to sendto() we don't need any of the sendmsg()
features here.
OK norby@

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

Refactor link state ack/req.

OK remi@

Convert sendto() to sendmsg().

This makes code similar to ospfd(8).

OK claudio@ deraadt@

When comparing the LSA with the Ack, also check the age field. This
ensures that a LSA withdrawal is not acked by a previous update.
From Florian Riehm; OK claudio@

remove a stupid -Wstrict-prototype warning by making the hash function
static. noticed by florian riehm

simple to use siphash here. ok deraadt

sync w/ospfd: improve snapshot handling; ok claudio, sthen

sync w/ ospfd:
for point-to-point interfaces we need to send lsupdates to the
interface address, since there is no DR and multicast messages to
the DR will be ignored. ok claudio@, then@

Calculate size of update packet with IPv6 header and reserve space
for IPsec. Avoid IPv6 fragments where possible. If a single LSA
is too big, put it into a separate packet with up to IPV6_MAXPACKET
bytes. This packet may get fragmented by the kernel.
ok stsp@

The is no md5 authentication in OSPFv3. Remove some leftovers from
the ospf6d packet lenght calculation.
ok claudio@ stsp@

With IPv6 OSPF a single LSA can get larger than the MTU. As a
workaround it is better to drop this LSA with a log entry instead
of sending emtpy update packets in a burst. As link LSAs cannot
be split, the propper solution might be IPv6 fragments. See also
RFC5340 Section 4.4.3.8 and Appendix A.1.
ok stsp@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Correct the output of several error and debug messages.

send_packet() now takes a struct in6_addr as destination instead of a
struct sockaddr_in6 and builds the struct sockaddr_in6 internaly adding scope
if necessary. While there switch to sendto() we don't need any of the sendmsg()
features here.
OK norby@

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

Convert sendto() to sendmsg().

This makes code similar to ospfd(8).

OK claudio@ deraadt@

When comparing the LSA with the Ack, also check the age field. This
ensures that a LSA withdrawal is not acked by a previous update.
From Florian Riehm; OK claudio@

remove a stupid -Wstrict-prototype warning by making the hash function
static. noticed by florian riehm

simple to use siphash here. ok deraadt

sync w/ospfd: improve snapshot handling; ok claudio, sthen

sync w/ ospfd:
for point-to-point interfaces we need to send lsupdates to the
interface address, since there is no DR and multicast messages to
the DR will be ignored. ok claudio@, then@

Calculate size of update packet with IPv6 header and reserve space
for IPsec. Avoid IPv6 fragments where possible. If a single LSA
is too big, put it into a separate packet with up to IPV6_MAXPACKET
bytes. This packet may get fragmented by the kernel.
ok stsp@

The is no md5 authentication in OSPFv3. Remove some leftovers from
the ospf6d packet lenght calculation.
ok claudio@ stsp@

With IPv6 OSPF a single LSA can get larger than the MTU. As a
workaround it is better to drop this LSA with a log entry instead
of sending emtpy update packets in a burst. As link LSAs cannot
be split, the propper solution might be IPv6 fragments. See also
RFC5340 Section 4.4.3.8 and Appendix A.1.
ok stsp@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Correct the output of several error and debug messages.

send_packet() now takes a struct in6_addr as destination instead of a
struct sockaddr_in6 and builds the struct sockaddr_in6 internaly adding scope
if necessary. While there switch to sendto() we don't need any of the sendmsg()
features here.
OK norby@

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

When comparing the LSA with the Ack, also check the age field. This
ensures that a LSA withdrawal is not acked by a previous update.
From Florian Riehm; OK claudio@

remove a stupid -Wstrict-prototype warning by making the hash function
static. noticed by florian riehm

simple to use siphash here. ok deraadt

sync w/ospfd: improve snapshot handling; ok claudio, sthen

sync w/ ospfd:
for point-to-point interfaces we need to send lsupdates to the
interface address, since there is no DR and multicast messages to
the DR will be ignored. ok claudio@, then@

Calculate size of update packet with IPv6 header and reserve space
for IPsec. Avoid IPv6 fragments where possible. If a single LSA
is too big, put it into a separate packet with up to IPV6_MAXPACKET
bytes. This packet may get fragmented by the kernel.
ok stsp@

The is no md5 authentication in OSPFv3. Remove some leftovers from
the ospf6d packet lenght calculation.
ok claudio@ stsp@

With IPv6 OSPF a single LSA can get larger than the MTU. As a
workaround it is better to drop this LSA with a log entry instead
of sending emtpy update packets in a burst. As link LSAs cannot
be split, the propper solution might be IPv6 fragments. See also
RFC5340 Section 4.4.3.8 and Appendix A.1.
ok stsp@

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Correct the output of several error and debug messages.

send_packet() now takes a struct in6_addr as destination instead of a
struct sockaddr_in6 and builds the struct sockaddr_in6 internaly adding scope
if necessary. While there switch to sendto() we don't need any of the sendmsg()
features here.
OK norby@

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@