userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

No need to declare optind, optarg or opterr; unistd.h does this for us.
From Jan Stary. OK deraadt@

Add missing includes for setpassent() and setgroupent().

Use user_from_uid(3), group_from_gid(3), uid_from_user(3) and
gid_from_group(3) to avoid repeatedly looking up the same user/group.
Also keep the passwd and group files open to avoid opening and
closing them all the time. OK tb@

need to include err.h for err().
ok deraadt@

Add pledge(2). It is not currently possible to pledge -u and -U
because of chown(2) and chmod(2).

If -u and -U aren't specified, the basic pledge is "stdio rpath getpw".
"getpw" is used to resolve uid and gid to names and vice versa.
The -r flag makes use of rmdir(2) and unlink(2), so we need "cpath"
The -t flag uses utimes(2), so we need "fattr"

ok deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

remove erroneous char cast to switch expression processing getopt(3);
not used in any cases.

ok deraadt@, guenther@, millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

documentation tweaks.

ok (some time ago) jmc@

Add missing "break" in -s case and make usage() explicitly take void.
From Andrey Matveev.

strict proto cleanups

Bitwise AND was used where logical AND was intended; from mpech@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

add -l flag - do loose permissions checks, in which more stringent permissions
will match less stringent ones. ok millert@, deraadt@.

pass -Wall

getcwd() does not stuff an error string in buf on error, call strerror()
instead.

-q was not in usage()

use getcwd(3)

add -q flag to silent messages of the type:
missing: some-file-name (not created: File exists)
which occurred of some-file-name was a path that contained a symbolic link

err() -> error() so we don't conflict with err(3).

Add rmd160 support. Sheesh, you'd think this was tripwire.

getopt(3) returns -1 when out of args, not EOF, whee!

From NetBSD:
Add a `-t' (touch) option to update time stamps.
Only record size for regular files.

merge freebsd mtree diffs, plus -Wall cleanup

64-bit clean + RCS tags

branches: 1.1.1;
Initial revision

No need to declare optind, optarg or opterr; unistd.h does this for us.
From Jan Stary. OK deraadt@

Add missing includes for setpassent() and setgroupent().

Use user_from_uid(3), group_from_gid(3), uid_from_user(3) and
gid_from_group(3) to avoid repeatedly looking up the same user/group.
Also keep the passwd and group files open to avoid opening and
closing them all the time. OK tb@

need to include err.h for err().
ok deraadt@

Add pledge(2). It is not currently possible to pledge -u and -U
because of chown(2) and chmod(2).

If -u and -U aren't specified, the basic pledge is "stdio rpath getpw".
"getpw" is used to resolve uid and gid to names and vice versa.
The -r flag makes use of rmdir(2) and unlink(2), so we need "cpath"
The -t flag uses utimes(2), so we need "fattr"

ok deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

remove erroneous char cast to switch expression processing getopt(3);
not used in any cases.

ok deraadt@, guenther@, millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

documentation tweaks.

ok (some time ago) jmc@

Add missing "break" in -s case and make usage() explicitly take void.
From Andrey Matveev.

strict proto cleanups

Bitwise AND was used where logical AND was intended; from mpech@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

add -l flag - do loose permissions checks, in which more stringent permissions
will match less stringent ones. ok millert@, deraadt@.

pass -Wall

getcwd() does not stuff an error string in buf on error, call strerror()
instead.

-q was not in usage()

use getcwd(3)

add -q flag to silent messages of the type:
missing: some-file-name (not created: File exists)
which occurred of some-file-name was a path that contained a symbolic link

err() -> error() so we don't conflict with err(3).

Add rmd160 support. Sheesh, you'd think this was tripwire.

getopt(3) returns -1 when out of args, not EOF, whee!

From NetBSD:
Add a `-t' (touch) option to update time stamps.
Only record size for regular files.

merge freebsd mtree diffs, plus -Wall cleanup

64-bit clean + RCS tags

branches: 1.1.1;
Initial revision

Add missing includes for setpassent() and setgroupent().

Use user_from_uid(3), group_from_gid(3), uid_from_user(3) and
gid_from_group(3) to avoid repeatedly looking up the same user/group.
Also keep the passwd and group files open to avoid opening and
closing them all the time. OK tb@

need to include err.h for err().
ok deraadt@

Add pledge(2). It is not currently possible to pledge -u and -U
because of chown(2) and chmod(2).

If -u and -U aren't specified, the basic pledge is "stdio rpath getpw".
"getpw" is used to resolve uid and gid to names and vice versa.
The -r flag makes use of rmdir(2) and unlink(2), so we need "cpath"
The -t flag uses utimes(2), so we need "fattr"

ok deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

remove erroneous char cast to switch expression processing getopt(3);
not used in any cases.

ok deraadt@, guenther@, millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

documentation tweaks.

ok (some time ago) jmc@

Add missing "break" in -s case and make usage() explicitly take void.
From Andrey Matveev.

strict proto cleanups

Bitwise AND was used where logical AND was intended; from mpech@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

add -l flag - do loose permissions checks, in which more stringent permissions
will match less stringent ones. ok millert@, deraadt@.

pass -Wall

getcwd() does not stuff an error string in buf on error, call strerror()
instead.

-q was not in usage()

use getcwd(3)

add -q flag to silent messages of the type:
missing: some-file-name (not created: File exists)
which occurred of some-file-name was a path that contained a symbolic link

err() -> error() so we don't conflict with err(3).

Add rmd160 support. Sheesh, you'd think this was tripwire.

getopt(3) returns -1 when out of args, not EOF, whee!

From NetBSD:
Add a `-t' (touch) option to update time stamps.
Only record size for regular files.

merge freebsd mtree diffs, plus -Wall cleanup

64-bit clean + RCS tags

branches: 1.1.1;
Initial revision

need to include err.h for err().
ok deraadt@

Add pledge(2). It is not currently possible to pledge -u and -U
because of chown(2) and chmod(2).

If -u and -U aren't specified, the basic pledge is "stdio rpath getpw".
"getpw" is used to resolve uid and gid to names and vice versa.
The -r flag makes use of rmdir(2) and unlink(2), so we need "cpath"
The -t flag uses utimes(2), so we need "fattr"

ok deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

remove erroneous char cast to switch expression processing getopt(3);
not used in any cases.

ok deraadt@, guenther@, millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

documentation tweaks.

ok (some time ago) jmc@

Add missing "break" in -s case and make usage() explicitly take void.
From Andrey Matveev.

strict proto cleanups

Bitwise AND was used where logical AND was intended; from mpech@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

add -l flag - do loose permissions checks, in which more stringent permissions
will match less stringent ones. ok millert@, deraadt@.

pass -Wall

getcwd() does not stuff an error string in buf on error, call strerror()
instead.

-q was not in usage()

use getcwd(3)

add -q flag to silent messages of the type:
missing: some-file-name (not created: File exists)
which occurred of some-file-name was a path that contained a symbolic link

err() -> error() so we don't conflict with err(3).

Add rmd160 support. Sheesh, you'd think this was tripwire.

getopt(3) returns -1 when out of args, not EOF, whee!

From NetBSD:
Add a `-t' (touch) option to update time stamps.
Only record size for regular files.

merge freebsd mtree diffs, plus -Wall cleanup

64-bit clean + RCS tags

branches: 1.1.1;
Initial revision