getifaddrs() can return entries where ifa_addr is NULL. Check for this
before accessing anything in ifa_addr.
ok claudio@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

assorted warning fixes; ok millert@

Nuke whitespace foolish enough to expose itself during the great
"warning:" rectification.

Apply a warning fix from lukem@NetBSD circa 1997 (more '()'), and
one from he@NetBSD circa 1998 (more '{}').

Makes gcc happier.

Apply fix from David Binderman via NetBSD. "Use all 3 of b, p, n
to determine if route changed".

Spotted by the Echelon team with AppChecker static analyzer.

NetBSD fix pointed out by millert@

(type *)0 -> NULL

ok sha256@

Remove memory.h include.

ok deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

fairly obvious ctype cleanup dealing with argv
ok jca

kill srandom(); ok claudio

remove one of the last stupid (unsigned) casts in the tree

fix missing err.h includes

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

fix a few more typos found by spell(1); rectify a double "with" pointed out
by jmc@ while looking at this diff.

ok jmc@, reyk@ (for the hostapd part)

tidy up synopsis and usage; from Igor Sobrado

setresuid; ok deraadt@

ansi cleanup; khalek@linuxgamers.net

errno is not specified to be int, but something from errno.h. ok millert@

fix datalen, from Esben Norby. ok deraadt itojun

Replace log() with logit() since ISO C reserves log() for the math
library and gcc 3.x will complain. Replacement name taken from NetBSD.
espie@ OK.

ignore address families other than AF_INET in get_netmask().
ok cedric@

rewrite SIOCGIFCONF into getifaddrs. deraadt ok

convert to poll; ok dhartmei

strict proto cleanups

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

avoid dynamically-generated string to printf. die if fd_set overruns.
from xs@kittenz.org

spelling; from Brian Poole <raj@cerias.purdue.edu>

missing sockaddr inits; ok itojun

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

follow post-2.1 ip_off & ip_len byte orders

make sure that va_start() has matching va_end()

Wall cleanup

Pavlin Ivanov Radoslavov <pavlin@catarina.usc.edu> writes:
> I received an email that the USC's General Counsel's Office
> has approved that the software license to pimd can be changed to the
> 3-clause BSD-like license!
> [...]
This is various other bits of software that is also covered by this.

exit(-#) is wrong

more careful euid killing

revoke privs at start; tested by fenner@parc.xerox.com

from netbsd; update to mrouted 3.8

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

assorted warning fixes; ok millert@

Nuke whitespace foolish enough to expose itself during the great
"warning:" rectification.

Apply a warning fix from lukem@NetBSD circa 1997 (more '()'), and
one from he@NetBSD circa 1998 (more '{}').

Makes gcc happier.

Apply fix from David Binderman via NetBSD. "Use all 3 of b, p, n
to determine if route changed".

Spotted by the Echelon team with AppChecker static analyzer.

NetBSD fix pointed out by millert@

(type *)0 -> NULL

ok sha256@

Remove memory.h include.

ok deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

fairly obvious ctype cleanup dealing with argv
ok jca

kill srandom(); ok claudio

remove one of the last stupid (unsigned) casts in the tree

fix missing err.h includes

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

fix a few more typos found by spell(1); rectify a double "with" pointed out
by jmc@ while looking at this diff.

ok jmc@, reyk@ (for the hostapd part)

tidy up synopsis and usage; from Igor Sobrado

setresuid; ok deraadt@

ansi cleanup; khalek@linuxgamers.net

errno is not specified to be int, but something from errno.h. ok millert@

fix datalen, from Esben Norby. ok deraadt itojun

Replace log() with logit() since ISO C reserves log() for the math
library and gcc 3.x will complain. Replacement name taken from NetBSD.
espie@ OK.

ignore address families other than AF_INET in get_netmask().
ok cedric@

rewrite SIOCGIFCONF into getifaddrs. deraadt ok

convert to poll; ok dhartmei

strict proto cleanups

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

avoid dynamically-generated string to printf. die if fd_set overruns.
from xs@kittenz.org

spelling; from Brian Poole <raj@cerias.purdue.edu>

missing sockaddr inits; ok itojun

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

follow post-2.1 ip_off & ip_len byte orders

make sure that va_start() has matching va_end()

Wall cleanup

Pavlin Ivanov Radoslavov <pavlin@catarina.usc.edu> writes:
> I received an email that the USC's General Counsel's Office
> has approved that the software license to pimd can be changed to the
> 3-clause BSD-like license!
> [...]
This is various other bits of software that is also covered by this.

exit(-#) is wrong

more careful euid killing

revoke privs at start; tested by fenner@parc.xerox.com

from netbsd; update to mrouted 3.8

branches: 1.1.1;
Initial revision

assorted warning fixes; ok millert@

Nuke whitespace foolish enough to expose itself during the great
"warning:" rectification.

Apply a warning fix from lukem@NetBSD circa 1997 (more '()'), and
one from he@NetBSD circa 1998 (more '{}').

Makes gcc happier.

Apply fix from David Binderman via NetBSD. "Use all 3 of b, p, n
to determine if route changed".

Spotted by the Echelon team with AppChecker static analyzer.

NetBSD fix pointed out by millert@

(type *)0 -> NULL

ok sha256@

Remove memory.h include.

ok deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

fairly obvious ctype cleanup dealing with argv
ok jca

kill srandom(); ok claudio

remove one of the last stupid (unsigned) casts in the tree

fix missing err.h includes

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

fix a few more typos found by spell(1); rectify a double "with" pointed out
by jmc@ while looking at this diff.

ok jmc@, reyk@ (for the hostapd part)

tidy up synopsis and usage; from Igor Sobrado

setresuid; ok deraadt@

ansi cleanup; khalek@linuxgamers.net

errno is not specified to be int, but something from errno.h. ok millert@

fix datalen, from Esben Norby. ok deraadt itojun

Replace log() with logit() since ISO C reserves log() for the math
library and gcc 3.x will complain. Replacement name taken from NetBSD.
espie@ OK.

ignore address families other than AF_INET in get_netmask().
ok cedric@

rewrite SIOCGIFCONF into getifaddrs. deraadt ok

convert to poll; ok dhartmei

strict proto cleanups

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

avoid dynamically-generated string to printf. die if fd_set overruns.
from xs@kittenz.org

spelling; from Brian Poole <raj@cerias.purdue.edu>

missing sockaddr inits; ok itojun

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

follow post-2.1 ip_off & ip_len byte orders

make sure that va_start() has matching va_end()

Wall cleanup

Pavlin Ivanov Radoslavov <pavlin@catarina.usc.edu> writes:
> I received an email that the USC's General Counsel's Office
> has approved that the software license to pimd can be changed to the
> 3-clause BSD-like license!
> [...]
This is various other bits of software that is also covered by this.

exit(-#) is wrong

more careful euid killing

revoke privs at start; tested by fenner@parc.xerox.com

from netbsd; update to mrouted 3.8

branches: 1.1.1;
Initial revision