correct indentation; no functional change
ok tb@

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

Switch (non-curses, non-ksh) programs that use COLUMNS to a single idiom.

Previously behaviors were all over the map. This changes them to
use COLUMNS first, and either terminal width or a hardcoded value
(typically 80) as appropriate.

ok deraadt@; man bits ok jmc@

Move prototypes of local functions from lp.h to the .c files and make
functions static if possible. Move delay() to lpd/printjob.c and fix
an annoying typo.

ok deraadt@

stdlib.h is in scope; do not cast malloc/calloc/realloc*

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

stat(2) on the spool file needs privileges. Fixes file size reported by
lpq -l.

ok millert@

more ctype cleanups
checked by jca

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

In preparation for getline and getdelim additions to libc, rename getline()
occurrences to get_line().
Based on a diff from Jan Klemkow <j-dot-klemkow-at-wemelug-dot-de> to tech.

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

spaces

I have an HP LaserJet (P2015dn) whose LPR implementation may not end
the send queue state command stream with '\n'; check for this case
and print '\n' if needed. Without this you may see something like:

$ lpq
queue empty$

ok millert@

trailing "\n" not needed in fatal(); ok millert@

Plug memory leak when nitems == 0.

From NetBSD from Coverity CID 1752.

OK jaredy@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Don't reformat output beyond a minimum terminal width (60).
millert@ ok

Do vis()-cleaning when displaying the print queue.
ok deraadt@, ian@

trivial strlcat, tedu@ ok

Better fix for correct queue printing when things have been moved around.

Don't print jobs in transit to a remote queue as being "active"

o Kill "garbage" global (unused)
o Kill "rank" global (doesn't need to be global)
o Make inform() static (local to displayq.c)
o Pass in rank to inform() based on index within sorted mtime array
o Simplify compar()

o Replace some hard-coded octal constants w/ S_I*
o Remove some unneeded casts to char * when calling free()

Remove setuid root from lp*. lpr needs to be setuid daemon so the
files it creates are not owned by the user spooling them but the
others (lpc, lpq, lprm) can get away with setgid daemon. lpd runs
as user daemon for most things, only changing its uid to 0 for
things that must be done as root.

For the time being, don't require connections to come from a reserved
port since lpq/lpr/lprm can't acquire that w/o setuid root. In the
near future we will have a mechanism for select non-root processes
to grab reserved ports.

The upshot of this is that spool directories must be writable by
group daemon and the files within the spool dirs must be owned by
daemon.

Remove useless sigaddset()

Pull in useful bits from NetBSD and make our lp* easier to diff and
do some minor cleanup of my own:

o IPv6 support
o ANSI function headers
o use getopt()
o synce usage() with man pages
o passes -Wall on both 32bit and 64bit platforms
o add an option to set the max number of children lpd will fork off
o add an lpd option to bind to specific addresses instead of INADDR_ANY.
o allow user to specify how long to wait for a connection to remote servers
o more strlcpy() and snprintf() usage
o Use FOO_FILENO constants instead of hard-coding 0-2
o Add some keeps to man the page SYNOPSIS to avoid options being split

displayq to honor the terminal width; millert@ ok

o kill register
o add const to rcsid and copyright strings
o placate -Wall

Use NAME_MAX, not MAXPATHLEN for buffer sizes since they are not
full paths (cannot contain a slash). From discussion with drosih@rpi.edu

Fix buffer oflow reading from queue file. While we are at it, crank
the size of buffers that can hold filenames to MAXPATHLEN.

use strlcpy vs strncpy+a[len-1]='\0'

branches: 1.10.10; 1.10.12;
Fix snprintf return value usage.

be more paranoid.
By the way, the lp* tools are in need of a full test sometime in the
next two weeks. I want to hear from someone who is running all of them
that they work 100% fine. I do not own a printer, so I'm going to rely
on someone out there to take care of this..

1 byte oflows; millert

Wall

Possible buf oflow.

proactive bounds checking; help from millert

Integrated 4.4Lite2 source
Fixed potential problem pointed out by bitblt

from netbsd; {} mania

lprm failed to delete all files; from thomas@cevis.uni-Bremen.de; netbsd pr#1756

branches: 1.1.1;
Initial revision

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

Switch (non-curses, non-ksh) programs that use COLUMNS to a single idiom.

Previously behaviors were all over the map. This changes them to
use COLUMNS first, and either terminal width or a hardcoded value
(typically 80) as appropriate.

ok deraadt@; man bits ok jmc@

Move prototypes of local functions from lp.h to the .c files and make
functions static if possible. Move delay() to lpd/printjob.c and fix
an annoying typo.

ok deraadt@

stdlib.h is in scope; do not cast malloc/calloc/realloc*

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

stat(2) on the spool file needs privileges. Fixes file size reported by
lpq -l.

ok millert@

more ctype cleanups
checked by jca

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

In preparation for getline and getdelim additions to libc, rename getline()
occurrences to get_line().
Based on a diff from Jan Klemkow <j-dot-klemkow-at-wemelug-dot-de> to tech.

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

spaces

I have an HP LaserJet (P2015dn) whose LPR implementation may not end
the send queue state command stream with '\n'; check for this case
and print '\n' if needed. Without this you may see something like:

$ lpq
queue empty$

ok millert@

trailing "\n" not needed in fatal(); ok millert@

Plug memory leak when nitems == 0.

From NetBSD from Coverity CID 1752.

OK jaredy@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Don't reformat output beyond a minimum terminal width (60).
millert@ ok

Do vis()-cleaning when displaying the print queue.
ok deraadt@, ian@

trivial strlcat, tedu@ ok

Better fix for correct queue printing when things have been moved around.

Don't print jobs in transit to a remote queue as being "active"

o Kill "garbage" global (unused)
o Kill "rank" global (doesn't need to be global)
o Make inform() static (local to displayq.c)
o Pass in rank to inform() based on index within sorted mtime array
o Simplify compar()

o Replace some hard-coded octal constants w/ S_I*
o Remove some unneeded casts to char * when calling free()

Remove setuid root from lp*. lpr needs to be setuid daemon so the
files it creates are not owned by the user spooling them but the
others (lpc, lpq, lprm) can get away with setgid daemon. lpd runs
as user daemon for most things, only changing its uid to 0 for
things that must be done as root.

For the time being, don't require connections to come from a reserved
port since lpq/lpr/lprm can't acquire that w/o setuid root. In the
near future we will have a mechanism for select non-root processes
to grab reserved ports.

The upshot of this is that spool directories must be writable by
group daemon and the files within the spool dirs must be owned by
daemon.

Remove useless sigaddset()

Pull in useful bits from NetBSD and make our lp* easier to diff and
do some minor cleanup of my own:

o IPv6 support
o ANSI function headers
o use getopt()
o synce usage() with man pages
o passes -Wall on both 32bit and 64bit platforms
o add an option to set the max number of children lpd will fork off
o add an lpd option to bind to specific addresses instead of INADDR_ANY.
o allow user to specify how long to wait for a connection to remote servers
o more strlcpy() and snprintf() usage
o Use FOO_FILENO constants instead of hard-coding 0-2
o Add some keeps to man the page SYNOPSIS to avoid options being split

displayq to honor the terminal width; millert@ ok

o kill register
o add const to rcsid and copyright strings
o placate -Wall

Use NAME_MAX, not MAXPATHLEN for buffer sizes since they are not
full paths (cannot contain a slash). From discussion with drosih@rpi.edu

Fix buffer oflow reading from queue file. While we are at it, crank
the size of buffers that can hold filenames to MAXPATHLEN.

use strlcpy vs strncpy+a[len-1]='\0'

branches: 1.10.10; 1.10.12;
Fix snprintf return value usage.

be more paranoid.
By the way, the lp* tools are in need of a full test sometime in the
next two weeks. I want to hear from someone who is running all of them
that they work 100% fine. I do not own a printer, so I'm going to rely
on someone out there to take care of this..

1 byte oflows; millert

Wall

Possible buf oflow.

proactive bounds checking; help from millert

Integrated 4.4Lite2 source
Fixed potential problem pointed out by bitblt

from netbsd; {} mania

lprm failed to delete all files; from thomas@cevis.uni-Bremen.de; netbsd pr#1756

branches: 1.1.1;
Initial revision

Switch (non-curses, non-ksh) programs that use COLUMNS to a single idiom.

Previously behaviors were all over the map. This changes them to
use COLUMNS first, and either terminal width or a hardcoded value
(typically 80) as appropriate.

ok deraadt@; man bits ok jmc@

Move prototypes of local functions from lp.h to the .c files and make
functions static if possible. Move delay() to lpd/printjob.c and fix
an annoying typo.

ok deraadt@

stdlib.h is in scope; do not cast malloc/calloc/realloc*

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

stat(2) on the spool file needs privileges. Fixes file size reported by
lpq -l.

ok millert@

more ctype cleanups
checked by jca

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

In preparation for getline and getdelim additions to libc, rename getline()
occurrences to get_line().
Based on a diff from Jan Klemkow <j-dot-klemkow-at-wemelug-dot-de> to tech.

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

spaces

I have an HP LaserJet (P2015dn) whose LPR implementation may not end
the send queue state command stream with '\n'; check for this case
and print '\n' if needed. Without this you may see something like:

$ lpq
queue empty$

ok millert@

trailing "\n" not needed in fatal(); ok millert@

Plug memory leak when nitems == 0.

From NetBSD from Coverity CID 1752.

OK jaredy@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Don't reformat output beyond a minimum terminal width (60).
millert@ ok

Do vis()-cleaning when displaying the print queue.
ok deraadt@, ian@

trivial strlcat, tedu@ ok

Better fix for correct queue printing when things have been moved around.

Don't print jobs in transit to a remote queue as being "active"

o Kill "garbage" global (unused)
o Kill "rank" global (doesn't need to be global)
o Make inform() static (local to displayq.c)
o Pass in rank to inform() based on index within sorted mtime array
o Simplify compar()

o Replace some hard-coded octal constants w/ S_I*
o Remove some unneeded casts to char * when calling free()

Remove setuid root from lp*. lpr needs to be setuid daemon so the
files it creates are not owned by the user spooling them but the
others (lpc, lpq, lprm) can get away with setgid daemon. lpd runs
as user daemon for most things, only changing its uid to 0 for
things that must be done as root.

For the time being, don't require connections to come from a reserved
port since lpq/lpr/lprm can't acquire that w/o setuid root. In the
near future we will have a mechanism for select non-root processes
to grab reserved ports.

The upshot of this is that spool directories must be writable by
group daemon and the files within the spool dirs must be owned by
daemon.

Remove useless sigaddset()

Pull in useful bits from NetBSD and make our lp* easier to diff and
do some minor cleanup of my own:

o IPv6 support
o ANSI function headers
o use getopt()
o synce usage() with man pages
o passes -Wall on both 32bit and 64bit platforms
o add an option to set the max number of children lpd will fork off
o add an lpd option to bind to specific addresses instead of INADDR_ANY.
o allow user to specify how long to wait for a connection to remote servers
o more strlcpy() and snprintf() usage
o Use FOO_FILENO constants instead of hard-coding 0-2
o Add some keeps to man the page SYNOPSIS to avoid options being split

displayq to honor the terminal width; millert@ ok

o kill register
o add const to rcsid and copyright strings
o placate -Wall

Use NAME_MAX, not MAXPATHLEN for buffer sizes since they are not
full paths (cannot contain a slash). From discussion with drosih@rpi.edu

Fix buffer oflow reading from queue file. While we are at it, crank
the size of buffers that can hold filenames to MAXPATHLEN.

use strlcpy vs strncpy+a[len-1]='\0'

branches: 1.10.10; 1.10.12;
Fix snprintf return value usage.

be more paranoid.
By the way, the lp* tools are in need of a full test sometime in the
next two weeks. I want to hear from someone who is running all of them
that they work 100% fine. I do not own a printer, so I'm going to rely
on someone out there to take care of this..

1 byte oflows; millert

Wall

Possible buf oflow.

proactive bounds checking; help from millert

Integrated 4.4Lite2 source
Fixed potential problem pointed out by bitblt

from netbsd; {} mania

lprm failed to delete all files; from thomas@cevis.uni-Bremen.de; netbsd pr#1756

branches: 1.1.1;
Initial revision