When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Use uid_from_user(3) and gid_from_group(3) in utilities that
do repeated lookups. OK tb@

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

stdlib.h is in scope; do not cast malloc/calloc/realloc*
ok millert krw

clean up flags++ instances around getopt()
ok florian

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

When reading time intervals, start with a long long and convert from there.
Similarly, print them by casting to long long and using %lld.

ok otto@

Make sure the correct errno is reported by warn* or err* and not
the errno of an intervening cleanup operation like close/unlink/etc.

Diff from Doug Hogan (doug (at) acyclic.org)

replace some (type *)0 to NULL

ok krw@ millert@

yet more unsigned char casts for ctype
checked by jca

Unbreak edquota by fixing the temporary file name template. Whilst here,
fold pathnames.h into edquota.c - we do not really need a header file for
a single define.

ok deraadt@ guenther@ millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

- Be more careful about pre-existing SIGCHLD handlers (or SIG_IGN) by
temporarily restoring default behaviour. This is not 100% ideal.
But this fixes editor handling in mail... bah, it is really unfortunate
that got broken
- refactor the restoration code as well, to make it simpler
ok ray

Copy editit() from sendbug, synchronizing editor calling code.

OK otto, millert, beck, mbalmer, deraadt.

the ellipsis is not an optional argument; while here, sync the usage
and synopsis of commands

lots of good ideas by jmc@

ok jmc@

do not name FILE * variables "fd" since it is confusing

use SEEK_* for lseek()

more asprintf; ok dhill@mindcry.org

these commands said "blocks" when they meant "KBytes" (they even calculated
it so). pointed out by janc@cyberspace.org, pr 3956

type, Marek Blaszkowski

strict proto cleanups

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

replace an unbounded %s in a sscanf with a bounded one
ok millert@

strlcpy; millert ok

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

cope with INITQFNAMES without a ;

no ; after INITQFNAMES

spelling; raj@cerias.purdue.edu

more snprintf

pid_t cleanup

kill more registers.

millert@ ok

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Replace the deprecated BSD sigsetmask/sigblock/sigpause functions with their POSIX counterparts.

Revert previous patch (I should stop believing Theo, esp. when he's
intoxicated). Thanks to Paul Janzen for pointing this out.

Handle quotas over 4G, PR 1534 (bob@prophecy.lu)

Deal with quotas over 4G correctly; also, tidy a bit and be a touch more
paranoid with some buffers.

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.23.4;
change getentry() args to solve problem

Check return value of getentry() for -1, not < 0 since it returns
an unsigned value; jon@oaktree.co.uk

fix overflow; bde

ftpd: sleep for an indeterminate amount for non-existant logins
to simulate a crypt, like login does.
Use SEEK_* not L_* and kill some 0L's used in lseek while we're there.

MAXPATHLEN not MAXPATHLEN+1

Don't assume all-numeric names are id's, look up as a name in
passwd first. Noted by Solar Designer <solar@FALSE.COM>

Some KNF and use warn/err.

Wall. uid & gid are not perfect .. but that is OK

repair quotactl() types

r?index -> strr?chr

_PATH_TMP -> _PATH_TMPFILE

fix warnings

type fixes

do not use system() to start $EDITOR, but fake system() ourselves

do not forget to unlink tmpfil

system() $EDITOR safely

use system, so that $EDITOR expansion works

permit quotas to work on mfs; problem reported by rdante@pnet.net

sync to netbsd 960418

accept either ffs or ufs for filesystem name

Complete change from ufs -> ffs; (From Tatoku Ogaito; PR #1679)

ufs -> ffs

branches: 1.1.1;
Initial revision

Use uid_from_user(3) and gid_from_group(3) in utilities that
do repeated lookups. OK tb@

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

stdlib.h is in scope; do not cast malloc/calloc/realloc*
ok millert krw

clean up flags++ instances around getopt()
ok florian

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

When reading time intervals, start with a long long and convert from there.
Similarly, print them by casting to long long and using %lld.

ok otto@

Make sure the correct errno is reported by warn* or err* and not
the errno of an intervening cleanup operation like close/unlink/etc.

Diff from Doug Hogan (doug (at) acyclic.org)

replace some (type *)0 to NULL

ok krw@ millert@

yet more unsigned char casts for ctype
checked by jca

Unbreak edquota by fixing the temporary file name template. Whilst here,
fold pathnames.h into edquota.c - we do not really need a header file for
a single define.

ok deraadt@ guenther@ millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

- Be more careful about pre-existing SIGCHLD handlers (or SIG_IGN) by
temporarily restoring default behaviour. This is not 100% ideal.
But this fixes editor handling in mail... bah, it is really unfortunate
that got broken
- refactor the restoration code as well, to make it simpler
ok ray

Copy editit() from sendbug, synchronizing editor calling code.

OK otto, millert, beck, mbalmer, deraadt.

the ellipsis is not an optional argument; while here, sync the usage
and synopsis of commands

lots of good ideas by jmc@

ok jmc@

do not name FILE * variables "fd" since it is confusing

use SEEK_* for lseek()

more asprintf; ok dhill@mindcry.org

these commands said "blocks" when they meant "KBytes" (they even calculated
it so). pointed out by janc@cyberspace.org, pr 3956

type, Marek Blaszkowski

strict proto cleanups

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

replace an unbounded %s in a sscanf with a bounded one
ok millert@

strlcpy; millert ok

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

cope with INITQFNAMES without a ;

no ; after INITQFNAMES

spelling; raj@cerias.purdue.edu

more snprintf

pid_t cleanup

kill more registers.

millert@ ok

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Replace the deprecated BSD sigsetmask/sigblock/sigpause functions with their POSIX counterparts.

Revert previous patch (I should stop believing Theo, esp. when he's
intoxicated). Thanks to Paul Janzen for pointing this out.

Handle quotas over 4G, PR 1534 (bob@prophecy.lu)

Deal with quotas over 4G correctly; also, tidy a bit and be a touch more
paranoid with some buffers.

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.23.4;
change getentry() args to solve problem

Check return value of getentry() for -1, not < 0 since it returns
an unsigned value; jon@oaktree.co.uk

fix overflow; bde

ftpd: sleep for an indeterminate amount for non-existant logins
to simulate a crypt, like login does.
Use SEEK_* not L_* and kill some 0L's used in lseek while we're there.

MAXPATHLEN not MAXPATHLEN+1

Don't assume all-numeric names are id's, look up as a name in
passwd first. Noted by Solar Designer <solar@FALSE.COM>

Some KNF and use warn/err.

Wall. uid & gid are not perfect .. but that is OK

repair quotactl() types

r?index -> strr?chr

_PATH_TMP -> _PATH_TMPFILE

fix warnings

type fixes

do not use system() to start $EDITOR, but fake system() ourselves

do not forget to unlink tmpfil

system() $EDITOR safely

use system, so that $EDITOR expansion works

permit quotas to work on mfs; problem reported by rdante@pnet.net

sync to netbsd 960418

accept either ffs or ufs for filesystem name

Complete change from ufs -> ffs; (From Tatoku Ogaito; PR #1679)

ufs -> ffs

branches: 1.1.1;
Initial revision

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

stdlib.h is in scope; do not cast malloc/calloc/realloc*
ok millert krw

clean up flags++ instances around getopt()
ok florian

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

When reading time intervals, start with a long long and convert from there.
Similarly, print them by casting to long long and using %lld.

ok otto@

Make sure the correct errno is reported by warn* or err* and not
the errno of an intervening cleanup operation like close/unlink/etc.

Diff from Doug Hogan (doug (at) acyclic.org)

replace some (type *)0 to NULL

ok krw@ millert@

yet more unsigned char casts for ctype
checked by jca

Unbreak edquota by fixing the temporary file name template. Whilst here,
fold pathnames.h into edquota.c - we do not really need a header file for
a single define.

ok deraadt@ guenther@ millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

- Be more careful about pre-existing SIGCHLD handlers (or SIG_IGN) by
temporarily restoring default behaviour. This is not 100% ideal.
But this fixes editor handling in mail... bah, it is really unfortunate
that got broken
- refactor the restoration code as well, to make it simpler
ok ray

Copy editit() from sendbug, synchronizing editor calling code.

OK otto, millert, beck, mbalmer, deraadt.

the ellipsis is not an optional argument; while here, sync the usage
and synopsis of commands

lots of good ideas by jmc@

ok jmc@

do not name FILE * variables "fd" since it is confusing

use SEEK_* for lseek()

more asprintf; ok dhill@mindcry.org

these commands said "blocks" when they meant "KBytes" (they even calculated
it so). pointed out by janc@cyberspace.org, pr 3956

type, Marek Blaszkowski

strict proto cleanups

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

replace an unbounded %s in a sscanf with a bounded one
ok millert@

strlcpy; millert ok

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

cope with INITQFNAMES without a ;

no ; after INITQFNAMES

spelling; raj@cerias.purdue.edu

more snprintf

pid_t cleanup

kill more registers.

millert@ ok

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Replace the deprecated BSD sigsetmask/sigblock/sigpause functions with their POSIX counterparts.

Revert previous patch (I should stop believing Theo, esp. when he's
intoxicated). Thanks to Paul Janzen for pointing this out.

Handle quotas over 4G, PR 1534 (bob@prophecy.lu)

Deal with quotas over 4G correctly; also, tidy a bit and be a touch more
paranoid with some buffers.

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.23.4;
change getentry() args to solve problem

Check return value of getentry() for -1, not < 0 since it returns
an unsigned value; jon@oaktree.co.uk

fix overflow; bde

ftpd: sleep for an indeterminate amount for non-existant logins
to simulate a crypt, like login does.
Use SEEK_* not L_* and kill some 0L's used in lseek while we're there.

MAXPATHLEN not MAXPATHLEN+1

Don't assume all-numeric names are id's, look up as a name in
passwd first. Noted by Solar Designer <solar@FALSE.COM>

Some KNF and use warn/err.

Wall. uid & gid are not perfect .. but that is OK

repair quotactl() types

r?index -> strr?chr

_PATH_TMP -> _PATH_TMPFILE

fix warnings

type fixes

do not use system() to start $EDITOR, but fake system() ourselves

do not forget to unlink tmpfil

system() $EDITOR safely

use system, so that $EDITOR expansion works

permit quotas to work on mfs; problem reported by rdante@pnet.net

sync to netbsd 960418

accept either ffs or ufs for filesystem name

Complete change from ufs -> ffs; (From Tatoku Ogaito; PR #1679)

ufs -> ffs

branches: 1.1.1;
Initial revision

stdlib.h is in scope; do not cast malloc/calloc/realloc*
ok millert krw

clean up flags++ instances around getopt()
ok florian

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

When reading time intervals, start with a long long and convert from there.
Similarly, print them by casting to long long and using %lld.

ok otto@

Make sure the correct errno is reported by warn* or err* and not
the errno of an intervening cleanup operation like close/unlink/etc.

Diff from Doug Hogan (doug (at) acyclic.org)

replace some (type *)0 to NULL

ok krw@ millert@

yet more unsigned char casts for ctype
checked by jca

Unbreak edquota by fixing the temporary file name template. Whilst here,
fold pathnames.h into edquota.c - we do not really need a header file for
a single define.

ok deraadt@ guenther@ millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

- Be more careful about pre-existing SIGCHLD handlers (or SIG_IGN) by
temporarily restoring default behaviour. This is not 100% ideal.
But this fixes editor handling in mail... bah, it is really unfortunate
that got broken
- refactor the restoration code as well, to make it simpler
ok ray

Copy editit() from sendbug, synchronizing editor calling code.

OK otto, millert, beck, mbalmer, deraadt.

the ellipsis is not an optional argument; while here, sync the usage
and synopsis of commands

lots of good ideas by jmc@

ok jmc@

do not name FILE * variables "fd" since it is confusing

use SEEK_* for lseek()

more asprintf; ok dhill@mindcry.org

these commands said "blocks" when they meant "KBytes" (they even calculated
it so). pointed out by janc@cyberspace.org, pr 3956

type, Marek Blaszkowski

strict proto cleanups

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

replace an unbounded %s in a sscanf with a bounded one
ok millert@

strlcpy; millert ok

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

cope with INITQFNAMES without a ;

no ; after INITQFNAMES

spelling; raj@cerias.purdue.edu

more snprintf

pid_t cleanup

kill more registers.

millert@ ok

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Replace the deprecated BSD sigsetmask/sigblock/sigpause functions with their POSIX counterparts.

Revert previous patch (I should stop believing Theo, esp. when he's
intoxicated). Thanks to Paul Janzen for pointing this out.

Handle quotas over 4G, PR 1534 (bob@prophecy.lu)

Deal with quotas over 4G correctly; also, tidy a bit and be a touch more
paranoid with some buffers.

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.23.4;
change getentry() args to solve problem

Check return value of getentry() for -1, not < 0 since it returns
an unsigned value; jon@oaktree.co.uk

fix overflow; bde

ftpd: sleep for an indeterminate amount for non-existant logins
to simulate a crypt, like login does.
Use SEEK_* not L_* and kill some 0L's used in lseek while we're there.

MAXPATHLEN not MAXPATHLEN+1

Don't assume all-numeric names are id's, look up as a name in
passwd first. Noted by Solar Designer <solar@FALSE.COM>

Some KNF and use warn/err.

Wall. uid & gid are not perfect .. but that is OK

repair quotactl() types

r?index -> strr?chr

_PATH_TMP -> _PATH_TMPFILE

fix warnings

type fixes

do not use system() to start $EDITOR, but fake system() ourselves

do not forget to unlink tmpfil

system() $EDITOR safely

use system, so that $EDITOR expansion works

permit quotas to work on mfs; problem reported by rdante@pnet.net

sync to netbsd 960418

accept either ffs or ufs for filesystem name

Complete change from ufs -> ffs; (From Tatoku Ogaito; PR #1679)

ufs -> ffs

branches: 1.1.1;
Initial revision