Properly initalize the ICMP message to zero to avoid leaking 4-byte
of uninitialised memory in the sent icmp echorequest.
Reported by Adarsh Dinesh (adarsh.dinesh at gmail com)
OK florian@ deraadt@

branches: 1.18.8; 1.18.10;
Eliminate pointless'%m' (a.k.a. hand rolled strerror()) by using fatal() and
log_warn(). Zap a couple of explicit 'syslog()' calls.

Adjust some long lines.

Switch from old errwarn.c logging to shiny new log.[ch].

ok benno@

Replace bzero(3) with memset(3)

"Looks good" to deraadt@

Eliminate #include inside *.h files and include only needed headers in
each *.c file.

Inspired by mention of header silliness by Edgar Pettijohn and mmcc@
on tech@.

Remove unnecessary netinet/in_systm.h include.

ok millert@

back out the previous ICMP simplifying diff, it caused livelocks.

reported by Mikolaj Kucharski, thanks!
ok krw

Don't call the ICMP handler indirectly + clean up a bit.

ok krw

When checking if a syscall like open(), ioctl() or writev() failed compare
directly against -1 and do not use a < 0 test. OK henning@

avoid aliasing with libc functions; ok henning

instead of using some lower 16 bits of some address on the stack that
even requires knowledge about wether the machine is 32 or 64 bit, use getpid()
for the icmp id. that is not optimal, but matches what ping does and the
way to go for now.

cleaning; Ryan ok

$OpenBSD$

various knf; henning ok

ansi

spaces

more crap bites the dust

may the whacking begin

Eliminate pointless'%m' (a.k.a. hand rolled strerror()) by using fatal() and
log_warn(). Zap a couple of explicit 'syslog()' calls.

Adjust some long lines.

Switch from old errwarn.c logging to shiny new log.[ch].

ok benno@

Replace bzero(3) with memset(3)

"Looks good" to deraadt@

Eliminate #include inside *.h files and include only needed headers in
each *.c file.

Inspired by mention of header silliness by Edgar Pettijohn and mmcc@
on tech@.

Remove unnecessary netinet/in_systm.h include.

ok millert@

back out the previous ICMP simplifying diff, it caused livelocks.

reported by Mikolaj Kucharski, thanks!
ok krw

Don't call the ICMP handler indirectly + clean up a bit.

ok krw

When checking if a syscall like open(), ioctl() or writev() failed compare
directly against -1 and do not use a < 0 test. OK henning@

avoid aliasing with libc functions; ok henning

instead of using some lower 16 bits of some address on the stack that
even requires knowledge about wether the machine is 32 or 64 bit, use getpid()
for the icmp id. that is not optimal, but matches what ping does and the
way to go for now.

cleaning; Ryan ok

$OpenBSD$

various knf; henning ok

ansi

spaces

more crap bites the dust

may the whacking begin