repair a few more backwards compares that create headaches
ok millert

When it's the possessive of 'it', it's spelled "its", without the
apostrophe.

Add a mechanism to prevent cron jobs from running concurrently.
This adds a new "-s" flag to the command field which indicates that
only a single instance of the job should run concurrenty.
OK beck@ job@ deraadt@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

zap a stray ';' and make a comment less ugly

Add crontab entry option -n for "No mail when run successful"

OK jmc@ millert@

Close cron sockets in child processes.

ok jca@

Check pipe(2) return value; noticed by deraadt@

Clean up the remaining uses of stderr and perror() and use warn/err
and/or syslog depending on whether stderr is hooked up at the time.
Also remove closelog() which is not needed since we are headed for exec.
OK guenther@

Remove log_it() and call syslog(3) directly using the same format:
"(username) WHAT (details)". Logs due to normal operation (e.g.
crontab operations or running commands) are logged at LOG_INFO like
before. Actual errors are logged at LOG_ERR, less important things
are logged at LOG_WARNING OR LOG_NOTICE. Also ignore SIGHUP now
that there is no log file to reopen.

Remove unused xpid argument to log_it().

Change cron from including all headers in every file to only including
what each .c file needs. I have not removed cron.h since it will
be used in a future clean up of the cron's .h files. OK nicm@

Use stravis(3) instead of a homegrown vis-like function.
OK nicm@

Remove cron.pid support. We still want to avoid multiple crons
running so verify that if the cron socket exists nothing is listening
on it. OK tedu@

remove some more ifdef maziness

There is no need to keep a global array of sysconf(_SC_OPEN_MAX) elements
just to keep track of a single pid. Return it to the caller and make it
their problem.
ok deraadt millert

unifdef some features we will always have. ok benno zhuk

correct copyright, upon approval from paul vixie via todd miller. the
head copyright assertion was seperated from the remaining ones.

braces to open a function go on their own line like god intended

Remove the OK and ERR macros. They obfuscate the code and don't
help legibility. (unix system calls use 0 for ok, but hundreds of
other projects use 1 to indicate success.) Despite the name, many
system calls (e.g., open) also return not OK values for success.
It also cleans up some weird code like int crontab_fd = OK - 1;
This diff is mechanical in nature. Later I will fix the bugs it reveals.
ok deraadt

minor debug removal cleanup

remove debug code.
I think the level of debug code in cron is excessive for a program
that has reached feature complete. If cron needs to provide more
information to the user about its operational status, I think syslog
would be more appropriate. (The debug flags also disable forking
into the background, so they aren't even that useful for debugging a
live system.)
ok deraadt millert

Replace MAXHOSTNAMELEN with HOST_NAME_MAX+1 and MAXNAMLEN with NAME_MAX
and use limits.h instead of sys/param.h.

Use HAVE_FOO for BSD-specific features instead of relying on the
BSD macro from sys/param.h.

Use standard types for wait, readdir, signals and pids.

obvious unsigned char cast for ctype
ok jca

Allow a '+' in the MAILTO email adress; from Constantine A. Murenin

Use standard EXIT_SUCCESS/EXIT_FAILURE and STD{IN,OUT,ERR}_FILENO
defines instead of using custom macros. OK deraadt@ gilles@

Reset the SIGPIPE signal handler immediately before executing a command.
We ignore it by default so cron doesn't die if sendmail is missing
or exits prematurely but the actual command being run should have the
default handler installed.

Use _exit() not exit() after forking. OK deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Check fdopen() return value.
Ignore SIG_PIPE when writing to sendmail. This allows cron to still
run jobs when sendmail is missing or broken (a warning will be logged).
Move mailto variable to the same scope as mail and use the mail
variable, not mailto, to test whether we have an open pipe to the mailer.

privledges -> privileges

Add Auto-Submitted header in generated mail as per RFC 3834.
OK henning@, ckuethe@, krw@, ian@. From Tamas TEVESZ.

UUpdate ISC copyright year to 2004
Remove unused macros Skip_Line and MkLower
Remove trailing whitespace

Fix typo in last commit for non-compiled code. Dmitry V. Levin

More changes from Dmitry V. Levin:

Check return values for setgid, initgroups and setuid in code we don't compile.
Print the correct filename for the at job in mail sent.
Add some #if DEBUGGING in cron.c's usage().
Set sunlen each time before using it in accept().
Don't send mail at all if MAILTO is set but empty.

isalnum() does not match '_' so check it explicitly. This allows cron
to send mail to usernames with a '_' in them. From David Gwynne.

Use (char *)NULL instead of (char *)0 in execl and execle; Andrey Matveev

Use setproctitle() instead of the CAPITALIZE_FOR_PS hack. Inspired
by similar changes in FreeBSD and NetBSD. For at jobs, include the
job number in the proctitle.

Sync with ISC cron-current + my at(1) integration.
The at(1) code is now more tightly integrated into the cron codebase.

Move closelog() into log_close() function and call that instead
of calling closelog() (with #ifdefs) directly.

fix typo (pw vs. pwd) in unused code

Pass e->pwd to auth_setpwd() to avoid extra passwd lookup in BSD auth routines

Move atrun(8) functionality into cron(8) proper. This fixes the
long-standing annoyance that atrun's granularity is 10 minutes.
Most at jobs run with a 1 minute granularity. Jobs submitted via
"at now" or "batch" will run immediately. Includes a rewritten
cron(8) man page. at(1) will be integrated more closely into
cron at a future date.

Upgrading notes:
the atrun job in root's crontab should be removed.
the /var/at/spool directory is no longer used

Do not collapse \\ -> \ in a command, the shell will be unhappy with
bare backslashes.

Merge in some changes from Paul Vixie's tree; most are cosmetic
o ANSI function headers
o return (foo) not return foo
o add -oi to sendmail flags
o update email address in man pages
o make some strings const
o completely remove globbing cruft from popen.c
o whitespace changes
o add DOW_STAR to flags for "monthly", "weekly", and "daily" cron entries

uid_t and gid_t are unsigned

Correctly close the writing end of the pipe when dup'ing the fd to
stdout. This was a pasto/thinko on my part. Problem found by
jean-philippe wan-hoi.

spelling; from Brian Poole <raj@cerias.purdue.edu>

Fix gethostname() usage.

deraadt@ ok

Kill volatile now that jongjmp is history.

When becoming a daemon, dup stdin, stdout, and stderr to /dev/null
Change an unsafe vfork() to fork()
Fix dup2() usage--must check for oldd == newd case and no need to close oldd
Fixes annoying messages from sendmail about stdout being closed.

Update to ISC cron 4.0b1 + our patches. This is now under a BSD license.
I also fixed the signal handlers while I was at it.

snprintf sprinkles; solar@false.com & I

Add calls to setusercontext() and login_get*(). We basically call
setusercontext() in most places where previously we did a setlogin().
Add default login.conf file and put root in the "daemon" login class.

Set SIGCHLD to SIG_DFL not SIG_IGN to prevent "perl -w" from
complaining "Can't ignore signal CHLD, forcing to default".

Setting SIGCHLD to SIG_IGN means "don't provide exit status for my
children" on some OSes which is not what we want--we just don't
want to catch SIGCHLD since our parent does that for us.

Run sendmail as the user corresponding to the crontab entry.
This keeps a user from abusing sendmail via the MAILTO var.
Had to drop -or0s from MAILARGS since that causes sendmail
to drop its privs (contrary to the sendmail docs).

when handling % line breaks, correctly handle escaped % which should be embedded; fenner@parc.xerox.com

Y2K fixes from Andreas.Gunnarsson@emw.ericsson.se; culled from various places

handle timing normally except when clock jumps between 1 and 3 hours. If it
jumps, attempt as best as possible to gaurantee that jobs DO run, but only
run ONCE; patch by thompson@.tgsoft.com

setlogin(username)

branches: 1.1.1;
Initial revision

When it's the possessive of 'it', it's spelled "its", without the
apostrophe.

Add a mechanism to prevent cron jobs from running concurrently.
This adds a new "-s" flag to the command field which indicates that
only a single instance of the job should run concurrenty.
OK beck@ job@ deraadt@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

zap a stray ';' and make a comment less ugly

Add crontab entry option -n for "No mail when run successful"

OK jmc@ millert@

Close cron sockets in child processes.

ok jca@

Check pipe(2) return value; noticed by deraadt@

Clean up the remaining uses of stderr and perror() and use warn/err
and/or syslog depending on whether stderr is hooked up at the time.
Also remove closelog() which is not needed since we are headed for exec.
OK guenther@

Remove log_it() and call syslog(3) directly using the same format:
"(username) WHAT (details)". Logs due to normal operation (e.g.
crontab operations or running commands) are logged at LOG_INFO like
before. Actual errors are logged at LOG_ERR, less important things
are logged at LOG_WARNING OR LOG_NOTICE. Also ignore SIGHUP now
that there is no log file to reopen.

Remove unused xpid argument to log_it().

Change cron from including all headers in every file to only including
what each .c file needs. I have not removed cron.h since it will
be used in a future clean up of the cron's .h files. OK nicm@

Use stravis(3) instead of a homegrown vis-like function.
OK nicm@

Remove cron.pid support. We still want to avoid multiple crons
running so verify that if the cron socket exists nothing is listening
on it. OK tedu@

remove some more ifdef maziness

There is no need to keep a global array of sysconf(_SC_OPEN_MAX) elements
just to keep track of a single pid. Return it to the caller and make it
their problem.
ok deraadt millert

unifdef some features we will always have. ok benno zhuk

correct copyright, upon approval from paul vixie via todd miller. the
head copyright assertion was seperated from the remaining ones.

braces to open a function go on their own line like god intended

Remove the OK and ERR macros. They obfuscate the code and don't
help legibility. (unix system calls use 0 for ok, but hundreds of
other projects use 1 to indicate success.) Despite the name, many
system calls (e.g., open) also return not OK values for success.
It also cleans up some weird code like int crontab_fd = OK - 1;
This diff is mechanical in nature. Later I will fix the bugs it reveals.
ok deraadt

minor debug removal cleanup

remove debug code.
I think the level of debug code in cron is excessive for a program
that has reached feature complete. If cron needs to provide more
information to the user about its operational status, I think syslog
would be more appropriate. (The debug flags also disable forking
into the background, so they aren't even that useful for debugging a
live system.)
ok deraadt millert

Replace MAXHOSTNAMELEN with HOST_NAME_MAX+1 and MAXNAMLEN with NAME_MAX
and use limits.h instead of sys/param.h.

Use HAVE_FOO for BSD-specific features instead of relying on the
BSD macro from sys/param.h.

Use standard types for wait, readdir, signals and pids.

obvious unsigned char cast for ctype
ok jca

Allow a '+' in the MAILTO email adress; from Constantine A. Murenin

Use standard EXIT_SUCCESS/EXIT_FAILURE and STD{IN,OUT,ERR}_FILENO
defines instead of using custom macros. OK deraadt@ gilles@

Reset the SIGPIPE signal handler immediately before executing a command.
We ignore it by default so cron doesn't die if sendmail is missing
or exits prematurely but the actual command being run should have the
default handler installed.

Use _exit() not exit() after forking. OK deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Check fdopen() return value.
Ignore SIG_PIPE when writing to sendmail. This allows cron to still
run jobs when sendmail is missing or broken (a warning will be logged).
Move mailto variable to the same scope as mail and use the mail
variable, not mailto, to test whether we have an open pipe to the mailer.

privledges -> privileges

Add Auto-Submitted header in generated mail as per RFC 3834.
OK henning@, ckuethe@, krw@, ian@. From Tamas TEVESZ.

UUpdate ISC copyright year to 2004
Remove unused macros Skip_Line and MkLower
Remove trailing whitespace

Fix typo in last commit for non-compiled code. Dmitry V. Levin

More changes from Dmitry V. Levin:

Check return values for setgid, initgroups and setuid in code we don't compile.
Print the correct filename for the at job in mail sent.
Add some #if DEBUGGING in cron.c's usage().
Set sunlen each time before using it in accept().
Don't send mail at all if MAILTO is set but empty.

isalnum() does not match '_' so check it explicitly. This allows cron
to send mail to usernames with a '_' in them. From David Gwynne.

Use (char *)NULL instead of (char *)0 in execl and execle; Andrey Matveev

Use setproctitle() instead of the CAPITALIZE_FOR_PS hack. Inspired
by similar changes in FreeBSD and NetBSD. For at jobs, include the
job number in the proctitle.

Sync with ISC cron-current + my at(1) integration.
The at(1) code is now more tightly integrated into the cron codebase.

Move closelog() into log_close() function and call that instead
of calling closelog() (with #ifdefs) directly.

fix typo (pw vs. pwd) in unused code

Pass e->pwd to auth_setpwd() to avoid extra passwd lookup in BSD auth routines

Move atrun(8) functionality into cron(8) proper. This fixes the
long-standing annoyance that atrun's granularity is 10 minutes.
Most at jobs run with a 1 minute granularity. Jobs submitted via
"at now" or "batch" will run immediately. Includes a rewritten
cron(8) man page. at(1) will be integrated more closely into
cron at a future date.

Upgrading notes:
the atrun job in root's crontab should be removed.
the /var/at/spool directory is no longer used

Do not collapse \\ -> \ in a command, the shell will be unhappy with
bare backslashes.

Merge in some changes from Paul Vixie's tree; most are cosmetic
o ANSI function headers
o return (foo) not return foo
o add -oi to sendmail flags
o update email address in man pages
o make some strings const
o completely remove globbing cruft from popen.c
o whitespace changes
o add DOW_STAR to flags for "monthly", "weekly", and "daily" cron entries

uid_t and gid_t are unsigned

Correctly close the writing end of the pipe when dup'ing the fd to
stdout. This was a pasto/thinko on my part. Problem found by
jean-philippe wan-hoi.

spelling; from Brian Poole <raj@cerias.purdue.edu>

Fix gethostname() usage.

deraadt@ ok

Kill volatile now that jongjmp is history.

When becoming a daemon, dup stdin, stdout, and stderr to /dev/null
Change an unsafe vfork() to fork()
Fix dup2() usage--must check for oldd == newd case and no need to close oldd
Fixes annoying messages from sendmail about stdout being closed.

Update to ISC cron 4.0b1 + our patches. This is now under a BSD license.
I also fixed the signal handlers while I was at it.

snprintf sprinkles; solar@false.com & I

Add calls to setusercontext() and login_get*(). We basically call
setusercontext() in most places where previously we did a setlogin().
Add default login.conf file and put root in the "daemon" login class.

Set SIGCHLD to SIG_DFL not SIG_IGN to prevent "perl -w" from
complaining "Can't ignore signal CHLD, forcing to default".

Setting SIGCHLD to SIG_IGN means "don't provide exit status for my
children" on some OSes which is not what we want--we just don't
want to catch SIGCHLD since our parent does that for us.

Run sendmail as the user corresponding to the crontab entry.
This keeps a user from abusing sendmail via the MAILTO var.
Had to drop -or0s from MAILARGS since that causes sendmail
to drop its privs (contrary to the sendmail docs).

when handling % line breaks, correctly handle escaped % which should be embedded; fenner@parc.xerox.com

Y2K fixes from Andreas.Gunnarsson@emw.ericsson.se; culled from various places

handle timing normally except when clock jumps between 1 and 3 hours. If it
jumps, attempt as best as possible to gaurantee that jobs DO run, but only
run ONCE; patch by thompson@.tgsoft.com

setlogin(username)

branches: 1.1.1;
Initial revision

Add a mechanism to prevent cron jobs from running concurrently.
This adds a new "-s" flag to the command field which indicates that
only a single instance of the job should run concurrenty.
OK beck@ job@ deraadt@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

zap a stray ';' and make a comment less ugly

Add crontab entry option -n for "No mail when run successful"

OK jmc@ millert@

Close cron sockets in child processes.

ok jca@

Check pipe(2) return value; noticed by deraadt@

Clean up the remaining uses of stderr and perror() and use warn/err
and/or syslog depending on whether stderr is hooked up at the time.
Also remove closelog() which is not needed since we are headed for exec.
OK guenther@

Remove log_it() and call syslog(3) directly using the same format:
"(username) WHAT (details)". Logs due to normal operation (e.g.
crontab operations or running commands) are logged at LOG_INFO like
before. Actual errors are logged at LOG_ERR, less important things
are logged at LOG_WARNING OR LOG_NOTICE. Also ignore SIGHUP now
that there is no log file to reopen.

Remove unused xpid argument to log_it().

Change cron from including all headers in every file to only including
what each .c file needs. I have not removed cron.h since it will
be used in a future clean up of the cron's .h files. OK nicm@

Use stravis(3) instead of a homegrown vis-like function.
OK nicm@

Remove cron.pid support. We still want to avoid multiple crons
running so verify that if the cron socket exists nothing is listening
on it. OK tedu@

remove some more ifdef maziness

There is no need to keep a global array of sysconf(_SC_OPEN_MAX) elements
just to keep track of a single pid. Return it to the caller and make it
their problem.
ok deraadt millert

unifdef some features we will always have. ok benno zhuk

correct copyright, upon approval from paul vixie via todd miller. the
head copyright assertion was seperated from the remaining ones.

braces to open a function go on their own line like god intended

Remove the OK and ERR macros. They obfuscate the code and don't
help legibility. (unix system calls use 0 for ok, but hundreds of
other projects use 1 to indicate success.) Despite the name, many
system calls (e.g., open) also return not OK values for success.
It also cleans up some weird code like int crontab_fd = OK - 1;
This diff is mechanical in nature. Later I will fix the bugs it reveals.
ok deraadt

minor debug removal cleanup

remove debug code.
I think the level of debug code in cron is excessive for a program
that has reached feature complete. If cron needs to provide more
information to the user about its operational status, I think syslog
would be more appropriate. (The debug flags also disable forking
into the background, so they aren't even that useful for debugging a
live system.)
ok deraadt millert

Replace MAXHOSTNAMELEN with HOST_NAME_MAX+1 and MAXNAMLEN with NAME_MAX
and use limits.h instead of sys/param.h.

Use HAVE_FOO for BSD-specific features instead of relying on the
BSD macro from sys/param.h.

Use standard types for wait, readdir, signals and pids.

obvious unsigned char cast for ctype
ok jca

Allow a '+' in the MAILTO email adress; from Constantine A. Murenin

Use standard EXIT_SUCCESS/EXIT_FAILURE and STD{IN,OUT,ERR}_FILENO
defines instead of using custom macros. OK deraadt@ gilles@

Reset the SIGPIPE signal handler immediately before executing a command.
We ignore it by default so cron doesn't die if sendmail is missing
or exits prematurely but the actual command being run should have the
default handler installed.

Use _exit() not exit() after forking. OK deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Check fdopen() return value.
Ignore SIG_PIPE when writing to sendmail. This allows cron to still
run jobs when sendmail is missing or broken (a warning will be logged).
Move mailto variable to the same scope as mail and use the mail
variable, not mailto, to test whether we have an open pipe to the mailer.

privledges -> privileges

Add Auto-Submitted header in generated mail as per RFC 3834.
OK henning@, ckuethe@, krw@, ian@. From Tamas TEVESZ.

UUpdate ISC copyright year to 2004
Remove unused macros Skip_Line and MkLower
Remove trailing whitespace

Fix typo in last commit for non-compiled code. Dmitry V. Levin

More changes from Dmitry V. Levin:

Check return values for setgid, initgroups and setuid in code we don't compile.
Print the correct filename for the at job in mail sent.
Add some #if DEBUGGING in cron.c's usage().
Set sunlen each time before using it in accept().
Don't send mail at all if MAILTO is set but empty.

isalnum() does not match '_' so check it explicitly. This allows cron
to send mail to usernames with a '_' in them. From David Gwynne.

Use (char *)NULL instead of (char *)0 in execl and execle; Andrey Matveev

Use setproctitle() instead of the CAPITALIZE_FOR_PS hack. Inspired
by similar changes in FreeBSD and NetBSD. For at jobs, include the
job number in the proctitle.

Sync with ISC cron-current + my at(1) integration.
The at(1) code is now more tightly integrated into the cron codebase.

Move closelog() into log_close() function and call that instead
of calling closelog() (with #ifdefs) directly.

fix typo (pw vs. pwd) in unused code

Pass e->pwd to auth_setpwd() to avoid extra passwd lookup in BSD auth routines

Move atrun(8) functionality into cron(8) proper. This fixes the
long-standing annoyance that atrun's granularity is 10 minutes.
Most at jobs run with a 1 minute granularity. Jobs submitted via
"at now" or "batch" will run immediately. Includes a rewritten
cron(8) man page. at(1) will be integrated more closely into
cron at a future date.

Upgrading notes:
the atrun job in root's crontab should be removed.
the /var/at/spool directory is no longer used

Do not collapse \\ -> \ in a command, the shell will be unhappy with
bare backslashes.

Merge in some changes from Paul Vixie's tree; most are cosmetic
o ANSI function headers
o return (foo) not return foo
o add -oi to sendmail flags
o update email address in man pages
o make some strings const
o completely remove globbing cruft from popen.c
o whitespace changes
o add DOW_STAR to flags for "monthly", "weekly", and "daily" cron entries

uid_t and gid_t are unsigned

Correctly close the writing end of the pipe when dup'ing the fd to
stdout. This was a pasto/thinko on my part. Problem found by
jean-philippe wan-hoi.

spelling; from Brian Poole <raj@cerias.purdue.edu>

Fix gethostname() usage.

deraadt@ ok

Kill volatile now that jongjmp is history.

When becoming a daemon, dup stdin, stdout, and stderr to /dev/null
Change an unsafe vfork() to fork()
Fix dup2() usage--must check for oldd == newd case and no need to close oldd
Fixes annoying messages from sendmail about stdout being closed.

Update to ISC cron 4.0b1 + our patches. This is now under a BSD license.
I also fixed the signal handlers while I was at it.

snprintf sprinkles; solar@false.com & I

Add calls to setusercontext() and login_get*(). We basically call
setusercontext() in most places where previously we did a setlogin().
Add default login.conf file and put root in the "daemon" login class.

Set SIGCHLD to SIG_DFL not SIG_IGN to prevent "perl -w" from
complaining "Can't ignore signal CHLD, forcing to default".

Setting SIGCHLD to SIG_IGN means "don't provide exit status for my
children" on some OSes which is not what we want--we just don't
want to catch SIGCHLD since our parent does that for us.

Run sendmail as the user corresponding to the crontab entry.
This keeps a user from abusing sendmail via the MAILTO var.
Had to drop -or0s from MAILARGS since that causes sendmail
to drop its privs (contrary to the sendmail docs).

when handling % line breaks, correctly handle escaped % which should be embedded; fenner@parc.xerox.com

Y2K fixes from Andreas.Gunnarsson@emw.ericsson.se; culled from various places

handle timing normally except when clock jumps between 1 and 3 hours. If it
jumps, attempt as best as possible to gaurantee that jobs DO run, but only
run ONCE; patch by thompson@.tgsoft.com

setlogin(username)

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

zap a stray ';' and make a comment less ugly

Add crontab entry option -n for "No mail when run successful"

OK jmc@ millert@

Close cron sockets in child processes.

ok jca@

Check pipe(2) return value; noticed by deraadt@

Clean up the remaining uses of stderr and perror() and use warn/err
and/or syslog depending on whether stderr is hooked up at the time.
Also remove closelog() which is not needed since we are headed for exec.
OK guenther@

Remove log_it() and call syslog(3) directly using the same format:
"(username) WHAT (details)". Logs due to normal operation (e.g.
crontab operations or running commands) are logged at LOG_INFO like
before. Actual errors are logged at LOG_ERR, less important things
are logged at LOG_WARNING OR LOG_NOTICE. Also ignore SIGHUP now
that there is no log file to reopen.

Remove unused xpid argument to log_it().

Change cron from including all headers in every file to only including
what each .c file needs. I have not removed cron.h since it will
be used in a future clean up of the cron's .h files. OK nicm@

Use stravis(3) instead of a homegrown vis-like function.
OK nicm@

Remove cron.pid support. We still want to avoid multiple crons
running so verify that if the cron socket exists nothing is listening
on it. OK tedu@

remove some more ifdef maziness

There is no need to keep a global array of sysconf(_SC_OPEN_MAX) elements
just to keep track of a single pid. Return it to the caller and make it
their problem.
ok deraadt millert

unifdef some features we will always have. ok benno zhuk

correct copyright, upon approval from paul vixie via todd miller. the
head copyright assertion was seperated from the remaining ones.

braces to open a function go on their own line like god intended

Remove the OK and ERR macros. They obfuscate the code and don't
help legibility. (unix system calls use 0 for ok, but hundreds of
other projects use 1 to indicate success.) Despite the name, many
system calls (e.g., open) also return not OK values for success.
It also cleans up some weird code like int crontab_fd = OK - 1;
This diff is mechanical in nature. Later I will fix the bugs it reveals.
ok deraadt

minor debug removal cleanup

remove debug code.
I think the level of debug code in cron is excessive for a program
that has reached feature complete. If cron needs to provide more
information to the user about its operational status, I think syslog
would be more appropriate. (The debug flags also disable forking
into the background, so they aren't even that useful for debugging a
live system.)
ok deraadt millert

Replace MAXHOSTNAMELEN with HOST_NAME_MAX+1 and MAXNAMLEN with NAME_MAX
and use limits.h instead of sys/param.h.

Use HAVE_FOO for BSD-specific features instead of relying on the
BSD macro from sys/param.h.

Use standard types for wait, readdir, signals and pids.

obvious unsigned char cast for ctype
ok jca

Allow a '+' in the MAILTO email adress; from Constantine A. Murenin

Use standard EXIT_SUCCESS/EXIT_FAILURE and STD{IN,OUT,ERR}_FILENO
defines instead of using custom macros. OK deraadt@ gilles@

Reset the SIGPIPE signal handler immediately before executing a command.
We ignore it by default so cron doesn't die if sendmail is missing
or exits prematurely but the actual command being run should have the
default handler installed.

Use _exit() not exit() after forking. OK deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Check fdopen() return value.
Ignore SIG_PIPE when writing to sendmail. This allows cron to still
run jobs when sendmail is missing or broken (a warning will be logged).
Move mailto variable to the same scope as mail and use the mail
variable, not mailto, to test whether we have an open pipe to the mailer.

privledges -> privileges

Add Auto-Submitted header in generated mail as per RFC 3834.
OK henning@, ckuethe@, krw@, ian@. From Tamas TEVESZ.

UUpdate ISC copyright year to 2004
Remove unused macros Skip_Line and MkLower
Remove trailing whitespace

Fix typo in last commit for non-compiled code. Dmitry V. Levin

More changes from Dmitry V. Levin:

Check return values for setgid, initgroups and setuid in code we don't compile.
Print the correct filename for the at job in mail sent.
Add some #if DEBUGGING in cron.c's usage().
Set sunlen each time before using it in accept().
Don't send mail at all if MAILTO is set but empty.

isalnum() does not match '_' so check it explicitly. This allows cron
to send mail to usernames with a '_' in them. From David Gwynne.

Use (char *)NULL instead of (char *)0 in execl and execle; Andrey Matveev

Use setproctitle() instead of the CAPITALIZE_FOR_PS hack. Inspired
by similar changes in FreeBSD and NetBSD. For at jobs, include the
job number in the proctitle.

Sync with ISC cron-current + my at(1) integration.
The at(1) code is now more tightly integrated into the cron codebase.

Move closelog() into log_close() function and call that instead
of calling closelog() (with #ifdefs) directly.

fix typo (pw vs. pwd) in unused code

Pass e->pwd to auth_setpwd() to avoid extra passwd lookup in BSD auth routines

Move atrun(8) functionality into cron(8) proper. This fixes the
long-standing annoyance that atrun's granularity is 10 minutes.
Most at jobs run with a 1 minute granularity. Jobs submitted via
"at now" or "batch" will run immediately. Includes a rewritten
cron(8) man page. at(1) will be integrated more closely into
cron at a future date.

Upgrading notes:
the atrun job in root's crontab should be removed.
the /var/at/spool directory is no longer used

Do not collapse \\ -> \ in a command, the shell will be unhappy with
bare backslashes.

Merge in some changes from Paul Vixie's tree; most are cosmetic
o ANSI function headers
o return (foo) not return foo
o add -oi to sendmail flags
o update email address in man pages
o make some strings const
o completely remove globbing cruft from popen.c
o whitespace changes
o add DOW_STAR to flags for "monthly", "weekly", and "daily" cron entries

uid_t and gid_t are unsigned

Correctly close the writing end of the pipe when dup'ing the fd to
stdout. This was a pasto/thinko on my part. Problem found by
jean-philippe wan-hoi.

spelling; from Brian Poole <raj@cerias.purdue.edu>

Fix gethostname() usage.

deraadt@ ok

Kill volatile now that jongjmp is history.

When becoming a daemon, dup stdin, stdout, and stderr to /dev/null
Change an unsafe vfork() to fork()
Fix dup2() usage--must check for oldd == newd case and no need to close oldd
Fixes annoying messages from sendmail about stdout being closed.

Update to ISC cron 4.0b1 + our patches. This is now under a BSD license.
I also fixed the signal handlers while I was at it.

snprintf sprinkles; solar@false.com & I

Add calls to setusercontext() and login_get*(). We basically call
setusercontext() in most places where previously we did a setlogin().
Add default login.conf file and put root in the "daemon" login class.

Set SIGCHLD to SIG_DFL not SIG_IGN to prevent "perl -w" from
complaining "Can't ignore signal CHLD, forcing to default".

Setting SIGCHLD to SIG_IGN means "don't provide exit status for my
children" on some OSes which is not what we want--we just don't
want to catch SIGCHLD since our parent does that for us.

Run sendmail as the user corresponding to the crontab entry.
This keeps a user from abusing sendmail via the MAILTO var.
Had to drop -or0s from MAILARGS since that causes sendmail
to drop its privs (contrary to the sendmail docs).

when handling % line breaks, correctly handle escaped % which should be embedded; fenner@parc.xerox.com

Y2K fixes from Andreas.Gunnarsson@emw.ericsson.se; culled from various places

handle timing normally except when clock jumps between 1 and 3 hours. If it
jumps, attempt as best as possible to gaurantee that jobs DO run, but only
run ONCE; patch by thompson@.tgsoft.com

setlogin(username)

branches: 1.1.1;
Initial revision

zap a stray ';' and make a comment less ugly

Add crontab entry option -n for "No mail when run successful"

OK jmc@ millert@

Close cron sockets in child processes.

ok jca@

Check pipe(2) return value; noticed by deraadt@

Clean up the remaining uses of stderr and perror() and use warn/err
and/or syslog depending on whether stderr is hooked up at the time.
Also remove closelog() which is not needed since we are headed for exec.
OK guenther@

Remove log_it() and call syslog(3) directly using the same format:
"(username) WHAT (details)". Logs due to normal operation (e.g.
crontab operations or running commands) are logged at LOG_INFO like
before. Actual errors are logged at LOG_ERR, less important things
are logged at LOG_WARNING OR LOG_NOTICE. Also ignore SIGHUP now
that there is no log file to reopen.

Remove unused xpid argument to log_it().

Change cron from including all headers in every file to only including
what each .c file needs. I have not removed cron.h since it will
be used in a future clean up of the cron's .h files. OK nicm@

Use stravis(3) instead of a homegrown vis-like function.
OK nicm@

Remove cron.pid support. We still want to avoid multiple crons
running so verify that if the cron socket exists nothing is listening
on it. OK tedu@

remove some more ifdef maziness

There is no need to keep a global array of sysconf(_SC_OPEN_MAX) elements
just to keep track of a single pid. Return it to the caller and make it
their problem.
ok deraadt millert

unifdef some features we will always have. ok benno zhuk

correct copyright, upon approval from paul vixie via todd miller. the
head copyright assertion was seperated from the remaining ones.

braces to open a function go on their own line like god intended

Remove the OK and ERR macros. They obfuscate the code and don't
help legibility. (unix system calls use 0 for ok, but hundreds of
other projects use 1 to indicate success.) Despite the name, many
system calls (e.g., open) also return not OK values for success.
It also cleans up some weird code like int crontab_fd = OK - 1;
This diff is mechanical in nature. Later I will fix the bugs it reveals.
ok deraadt

minor debug removal cleanup

remove debug code.
I think the level of debug code in cron is excessive for a program
that has reached feature complete. If cron needs to provide more
information to the user about its operational status, I think syslog
would be more appropriate. (The debug flags also disable forking
into the background, so they aren't even that useful for debugging a
live system.)
ok deraadt millert

Replace MAXHOSTNAMELEN with HOST_NAME_MAX+1 and MAXNAMLEN with NAME_MAX
and use limits.h instead of sys/param.h.

Use HAVE_FOO for BSD-specific features instead of relying on the
BSD macro from sys/param.h.

Use standard types for wait, readdir, signals and pids.

obvious unsigned char cast for ctype
ok jca

Allow a '+' in the MAILTO email adress; from Constantine A. Murenin

Use standard EXIT_SUCCESS/EXIT_FAILURE and STD{IN,OUT,ERR}_FILENO
defines instead of using custom macros. OK deraadt@ gilles@

Reset the SIGPIPE signal handler immediately before executing a command.
We ignore it by default so cron doesn't die if sendmail is missing
or exits prematurely but the actual command being run should have the
default handler installed.

Use _exit() not exit() after forking. OK deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Check fdopen() return value.
Ignore SIG_PIPE when writing to sendmail. This allows cron to still
run jobs when sendmail is missing or broken (a warning will be logged).
Move mailto variable to the same scope as mail and use the mail
variable, not mailto, to test whether we have an open pipe to the mailer.

privledges -> privileges

Add Auto-Submitted header in generated mail as per RFC 3834.
OK henning@, ckuethe@, krw@, ian@. From Tamas TEVESZ.

UUpdate ISC copyright year to 2004
Remove unused macros Skip_Line and MkLower
Remove trailing whitespace

Fix typo in last commit for non-compiled code. Dmitry V. Levin

More changes from Dmitry V. Levin:

Check return values for setgid, initgroups and setuid in code we don't compile.
Print the correct filename for the at job in mail sent.
Add some #if DEBUGGING in cron.c's usage().
Set sunlen each time before using it in accept().
Don't send mail at all if MAILTO is set but empty.

isalnum() does not match '_' so check it explicitly. This allows cron
to send mail to usernames with a '_' in them. From David Gwynne.

Use (char *)NULL instead of (char *)0 in execl and execle; Andrey Matveev

Use setproctitle() instead of the CAPITALIZE_FOR_PS hack. Inspired
by similar changes in FreeBSD and NetBSD. For at jobs, include the
job number in the proctitle.

Sync with ISC cron-current + my at(1) integration.
The at(1) code is now more tightly integrated into the cron codebase.

Move closelog() into log_close() function and call that instead
of calling closelog() (with #ifdefs) directly.

fix typo (pw vs. pwd) in unused code

Pass e->pwd to auth_setpwd() to avoid extra passwd lookup in BSD auth routines

Move atrun(8) functionality into cron(8) proper. This fixes the
long-standing annoyance that atrun's granularity is 10 minutes.
Most at jobs run with a 1 minute granularity. Jobs submitted via
"at now" or "batch" will run immediately. Includes a rewritten
cron(8) man page. at(1) will be integrated more closely into
cron at a future date.

Upgrading notes:
the atrun job in root's crontab should be removed.
the /var/at/spool directory is no longer used

Do not collapse \\ -> \ in a command, the shell will be unhappy with
bare backslashes.

Merge in some changes from Paul Vixie's tree; most are cosmetic
o ANSI function headers
o return (foo) not return foo
o add -oi to sendmail flags
o update email address in man pages
o make some strings const
o completely remove globbing cruft from popen.c
o whitespace changes
o add DOW_STAR to flags for "monthly", "weekly", and "daily" cron entries

uid_t and gid_t are unsigned

Correctly close the writing end of the pipe when dup'ing the fd to
stdout. This was a pasto/thinko on my part. Problem found by
jean-philippe wan-hoi.

spelling; from Brian Poole <raj@cerias.purdue.edu>

Fix gethostname() usage.

deraadt@ ok

Kill volatile now that jongjmp is history.

When becoming a daemon, dup stdin, stdout, and stderr to /dev/null
Change an unsafe vfork() to fork()
Fix dup2() usage--must check for oldd == newd case and no need to close oldd
Fixes annoying messages from sendmail about stdout being closed.

Update to ISC cron 4.0b1 + our patches. This is now under a BSD license.
I also fixed the signal handlers while I was at it.

snprintf sprinkles; solar@false.com & I

Add calls to setusercontext() and login_get*(). We basically call
setusercontext() in most places where previously we did a setlogin().
Add default login.conf file and put root in the "daemon" login class.

Set SIGCHLD to SIG_DFL not SIG_IGN to prevent "perl -w" from
complaining "Can't ignore signal CHLD, forcing to default".

Setting SIGCHLD to SIG_IGN means "don't provide exit status for my
children" on some OSes which is not what we want--we just don't
want to catch SIGCHLD since our parent does that for us.

Run sendmail as the user corresponding to the crontab entry.
This keeps a user from abusing sendmail via the MAILTO var.
Had to drop -or0s from MAILARGS since that causes sendmail
to drop its privs (contrary to the sendmail docs).

when handling % line breaks, correctly handle escaped % which should be embedded; fenner@parc.xerox.com

Y2K fixes from Andreas.Gunnarsson@emw.ericsson.se; culled from various places

handle timing normally except when clock jumps between 1 and 3 hours. If it
jumps, attempt as best as possible to gaurantee that jobs DO run, but only
run ONCE; patch by thompson@.tgsoft.com

setlogin(username)

branches: 1.1.1;
Initial revision

Close cron sockets in child processes.

ok jca@

Check pipe(2) return value; noticed by deraadt@

Clean up the remaining uses of stderr and perror() and use warn/err
and/or syslog depending on whether stderr is hooked up at the time.
Also remove closelog() which is not needed since we are headed for exec.
OK guenther@

Remove log_it() and call syslog(3) directly using the same format:
"(username) WHAT (details)". Logs due to normal operation (e.g.
crontab operations or running commands) are logged at LOG_INFO like
before. Actual errors are logged at LOG_ERR, less important things
are logged at LOG_WARNING OR LOG_NOTICE. Also ignore SIGHUP now
that there is no log file to reopen.

Remove unused xpid argument to log_it().

Change cron from including all headers in every file to only including
what each .c file needs. I have not removed cron.h since it will
be used in a future clean up of the cron's .h files. OK nicm@

Use stravis(3) instead of a homegrown vis-like function.
OK nicm@

Remove cron.pid support. We still want to avoid multiple crons
running so verify that if the cron socket exists nothing is listening
on it. OK tedu@

remove some more ifdef maziness

There is no need to keep a global array of sysconf(_SC_OPEN_MAX) elements
just to keep track of a single pid. Return it to the caller and make it
their problem.
ok deraadt millert

unifdef some features we will always have. ok benno zhuk

correct copyright, upon approval from paul vixie via todd miller. the
head copyright assertion was seperated from the remaining ones.

braces to open a function go on their own line like god intended

Remove the OK and ERR macros. They obfuscate the code and don't
help legibility. (unix system calls use 0 for ok, but hundreds of
other projects use 1 to indicate success.) Despite the name, many
system calls (e.g., open) also return not OK values for success.
It also cleans up some weird code like int crontab_fd = OK - 1;
This diff is mechanical in nature. Later I will fix the bugs it reveals.
ok deraadt

minor debug removal cleanup

remove debug code.
I think the level of debug code in cron is excessive for a program
that has reached feature complete. If cron needs to provide more
information to the user about its operational status, I think syslog
would be more appropriate. (The debug flags also disable forking
into the background, so they aren't even that useful for debugging a
live system.)
ok deraadt millert

Replace MAXHOSTNAMELEN with HOST_NAME_MAX+1 and MAXNAMLEN with NAME_MAX
and use limits.h instead of sys/param.h.

Use HAVE_FOO for BSD-specific features instead of relying on the
BSD macro from sys/param.h.

Use standard types for wait, readdir, signals and pids.

obvious unsigned char cast for ctype
ok jca

Allow a '+' in the MAILTO email adress; from Constantine A. Murenin

Use standard EXIT_SUCCESS/EXIT_FAILURE and STD{IN,OUT,ERR}_FILENO
defines instead of using custom macros. OK deraadt@ gilles@

Reset the SIGPIPE signal handler immediately before executing a command.
We ignore it by default so cron doesn't die if sendmail is missing
or exits prematurely but the actual command being run should have the
default handler installed.

Use _exit() not exit() after forking. OK deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Check fdopen() return value.
Ignore SIG_PIPE when writing to sendmail. This allows cron to still
run jobs when sendmail is missing or broken (a warning will be logged).
Move mailto variable to the same scope as mail and use the mail
variable, not mailto, to test whether we have an open pipe to the mailer.

privledges -> privileges

Add Auto-Submitted header in generated mail as per RFC 3834.
OK henning@, ckuethe@, krw@, ian@. From Tamas TEVESZ.

UUpdate ISC copyright year to 2004
Remove unused macros Skip_Line and MkLower
Remove trailing whitespace

Fix typo in last commit for non-compiled code. Dmitry V. Levin

More changes from Dmitry V. Levin:

Check return values for setgid, initgroups and setuid in code we don't compile.
Print the correct filename for the at job in mail sent.
Add some #if DEBUGGING in cron.c's usage().
Set sunlen each time before using it in accept().
Don't send mail at all if MAILTO is set but empty.

isalnum() does not match '_' so check it explicitly. This allows cron
to send mail to usernames with a '_' in them. From David Gwynne.

Use (char *)NULL instead of (char *)0 in execl and execle; Andrey Matveev

Use setproctitle() instead of the CAPITALIZE_FOR_PS hack. Inspired
by similar changes in FreeBSD and NetBSD. For at jobs, include the
job number in the proctitle.

Sync with ISC cron-current + my at(1) integration.
The at(1) code is now more tightly integrated into the cron codebase.

Move closelog() into log_close() function and call that instead
of calling closelog() (with #ifdefs) directly.

fix typo (pw vs. pwd) in unused code

Pass e->pwd to auth_setpwd() to avoid extra passwd lookup in BSD auth routines

Move atrun(8) functionality into cron(8) proper. This fixes the
long-standing annoyance that atrun's granularity is 10 minutes.
Most at jobs run with a 1 minute granularity. Jobs submitted via
"at now" or "batch" will run immediately. Includes a rewritten
cron(8) man page. at(1) will be integrated more closely into
cron at a future date.

Upgrading notes:
the atrun job in root's crontab should be removed.
the /var/at/spool directory is no longer used

Do not collapse \\ -> \ in a command, the shell will be unhappy with
bare backslashes.

Merge in some changes from Paul Vixie's tree; most are cosmetic
o ANSI function headers
o return (foo) not return foo
o add -oi to sendmail flags
o update email address in man pages
o make some strings const
o completely remove globbing cruft from popen.c
o whitespace changes
o add DOW_STAR to flags for "monthly", "weekly", and "daily" cron entries

uid_t and gid_t are unsigned

Correctly close the writing end of the pipe when dup'ing the fd to
stdout. This was a pasto/thinko on my part. Problem found by
jean-philippe wan-hoi.

spelling; from Brian Poole <raj@cerias.purdue.edu>

Fix gethostname() usage.

deraadt@ ok

Kill volatile now that jongjmp is history.

When becoming a daemon, dup stdin, stdout, and stderr to /dev/null
Change an unsafe vfork() to fork()
Fix dup2() usage--must check for oldd == newd case and no need to close oldd
Fixes annoying messages from sendmail about stdout being closed.

Update to ISC cron 4.0b1 + our patches. This is now under a BSD license.
I also fixed the signal handlers while I was at it.

snprintf sprinkles; solar@false.com & I

Add calls to setusercontext() and login_get*(). We basically call
setusercontext() in most places where previously we did a setlogin().
Add default login.conf file and put root in the "daemon" login class.

Set SIGCHLD to SIG_DFL not SIG_IGN to prevent "perl -w" from
complaining "Can't ignore signal CHLD, forcing to default".

Setting SIGCHLD to SIG_IGN means "don't provide exit status for my
children" on some OSes which is not what we want--we just don't
want to catch SIGCHLD since our parent does that for us.

Run sendmail as the user corresponding to the crontab entry.
This keeps a user from abusing sendmail via the MAILTO var.
Had to drop -or0s from MAILARGS since that causes sendmail
to drop its privs (contrary to the sendmail docs).

when handling % line breaks, correctly handle escaped % which should be embedded; fenner@parc.xerox.com

Y2K fixes from Andreas.Gunnarsson@emw.ericsson.se; culled from various places

handle timing normally except when clock jumps between 1 and 3 hours. If it
jumps, attempt as best as possible to gaurantee that jobs DO run, but only
run ONCE; patch by thompson@.tgsoft.com

setlogin(username)

branches: 1.1.1;
Initial revision