Let dnsproc pass multiple addresses to netproc

The loop was exited prematurely because of a stray break statement.
In case of a failure to connect to the first address returned by
getaddrinfo(3), acme-client can now try to connect using another address
or address family if available.

ok florian@

remove noisy and useless debug line

Give acme-client a chance to work on IPv6 only hosts by using the
AI_ADDRCONFIG flag for getaddrinfo to only return addresses for a
configured address family.

Implementing a loop over all IPs is left as an exercise to the reader.

Reported some time ago by kasimov.an AT gmail on bugs@, thanks!

oh boy deraadt@
OK benno@

Make returns consistent and remove parentheses per style(9).

Transformed with coccinelle.

Requested by and ok tb@

Complete jsing's coccinelle cleanup... by hand
ok jsing

Replace comparisons between a constant or enum and an expression, with
a comparison between the expression and the constant or enum. This
significantly improves readability.

Transformed with coccinelle.

Requested by deraadt@

A small amount more KNF to make this easier on our eyes. Not going further
than this.
ok florian

hoist local variable initialization directly into the definitions,
rather than doing it right afterwards.
ok florian

we don't have config.h

Collapse krazy abstractions for other sandbox models, using chroot and
pledge directly as needed.
ok florian

whitespace

Import Kristaps' letskencrypt and call it acme-client in tree.
OK to get it in deraadt@ (and probably beck@)

At least deraadt@, beck@ and otto@ are fine with the name and the
disagreements stopped.

remove noisy and useless debug line

Give acme-client a chance to work on IPv6 only hosts by using the
AI_ADDRCONFIG flag for getaddrinfo to only return addresses for a
configured address family.

Implementing a loop over all IPs is left as an exercise to the reader.

Reported some time ago by kasimov.an AT gmail on bugs@, thanks!

oh boy deraadt@
OK benno@

Make returns consistent and remove parentheses per style(9).

Transformed with coccinelle.

Requested by and ok tb@

Complete jsing's coccinelle cleanup... by hand
ok jsing

Replace comparisons between a constant or enum and an expression, with
a comparison between the expression and the constant or enum. This
significantly improves readability.

Transformed with coccinelle.

Requested by deraadt@

A small amount more KNF to make this easier on our eyes. Not going further
than this.
ok florian

hoist local variable initialization directly into the definitions,
rather than doing it right afterwards.
ok florian

we don't have config.h

Collapse krazy abstractions for other sandbox models, using chroot and
pledge directly as needed.
ok florian

whitespace

Import Kristaps' letskencrypt and call it acme-client in tree.
OK to get it in deraadt@ (and probably beck@)

At least deraadt@, beck@ and otto@ are fine with the name and the
disagreements stopped.

Give acme-client a chance to work on IPv6 only hosts by using the
AI_ADDRCONFIG flag for getaddrinfo to only return addresses for a
configured address family.

Implementing a loop over all IPs is left as an exercise to the reader.

Reported some time ago by kasimov.an AT gmail on bugs@, thanks!

oh boy deraadt@
OK benno@

Make returns consistent and remove parentheses per style(9).

Transformed with coccinelle.

Requested by and ok tb@

Complete jsing's coccinelle cleanup... by hand
ok jsing

Replace comparisons between a constant or enum and an expression, with
a comparison between the expression and the constant or enum. This
significantly improves readability.

Transformed with coccinelle.

Requested by deraadt@

A small amount more KNF to make this easier on our eyes. Not going further
than this.
ok florian

hoist local variable initialization directly into the definitions,
rather than doing it right afterwards.
ok florian

we don't have config.h

Collapse krazy abstractions for other sandbox models, using chroot and
pledge directly as needed.
ok florian

whitespace

Import Kristaps' letskencrypt and call it acme-client in tree.
OK to get it in deraadt@ (and probably beck@)

At least deraadt@, beck@ and otto@ are fine with the name and the
disagreements stopped.

Make returns consistent and remove parentheses per style(9).

Transformed with coccinelle.

Requested by and ok tb@

Complete jsing's coccinelle cleanup... by hand
ok jsing

Replace comparisons between a constant or enum and an expression, with
a comparison between the expression and the constant or enum. This
significantly improves readability.

Transformed with coccinelle.

Requested by deraadt@

A small amount more KNF to make this easier on our eyes. Not going further
than this.
ok florian

hoist local variable initialization directly into the definitions,
rather than doing it right afterwards.
ok florian

we don't have config.h

Collapse krazy abstractions for other sandbox models, using chroot and
pledge directly as needed.
ok florian

whitespace

Import Kristaps' letskencrypt and call it acme-client in tree.
OK to get it in deraadt@ (and probably beck@)

At least deraadt@, beck@ and otto@ are fine with the name and the
disagreements stopped.