I am retiring my old email address; replace it with my OpenBSD one.

Delete some useless setlocale(3) calls in /usr/bin, no functional change.
Patches from Jan Stary <hans at stare dot cz>, tweaked by me and tb@.
While here, apply some simple style improvements:
Sort headers, static void __dead usage(), return from main(),
zap case '?', drop /* NOTREACHED */, drop break after usage(), ...
OK tb@ millert@

Check the return value of snprintf() for potential overflow instead
of doing a manual check beforehand.

Avoid potential read of one byte before the start of a malloc()ed
buffer. From Max Fillinger.

Use _PATH_DEFPATH if no PATH in the environment when invoked as which.

fix exit status on pledge(2) failure.

OK tb@ jsg@

pledge "stdio rpath"
ok beck doug

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Use errc/warnc to simplify code.
Also, in 'ftp', always put the error message last, after the hostname/ipaddr.

ok jsing@ krw@ millert@

Get the standard path from _PATH_STDPATH instead of
sysctl({CTL_USER,USER_CS_PATH}). Expand that into the manpage
too.

_PATH_STDPATH suggested by miod@
Corrections from schwarze@ and jmc@
ok millert@ miod@ schwarze@ jmc@

The -a option shouldn't change the exit status
Patch from David Julio (david.a.julio at gmail.com)

stderr should be used for error messages; this diff makes which(1)
output not only more standard but also more predictable, as it now
matches the behavior of the csh(1)'s built-in command.

diff from Tobias Ulmer.

ok millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

the ellipsis is not an optional argument; document the "-a" flag in whereis(1)

help and feedback by jmc@ and otto@

ok deraadt@, jmc@ and otto@

save a copy of the pointer before strsep; fixes an abort on free.
ok by millert, otto & pedro.

Add missing free on error; Alison Winters
Also KNF the return statements and make usage() __dead while I am here.

Sync with share/misc/license.template and add missing DARPA credit
where applicable.

mostly ansi cleanup; pval ok

Use an ISC-tyle license for all my code; it is simpler and more permissive.

snprintf() is simpler than multiple strlcpy() and manual fiddling.
Also convert to C89 while I'm at it.

snprintf & strlcpy; tedu ok

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Remove the advertising clause in my old license, it impedes free use
of the code as a large number of similar clauses makes it impossible
to write an ad for a product using the code...

fix err() use

Add -a flag. Idea from bgrayson@ece.utexas.edu

which(1) and whereis(1) are now the same program (hard linked).

which(1) is now a binary that works in any shell since csh(1) has a
which built-in.

Delete some useless setlocale(3) calls in /usr/bin, no functional change.
Patches from Jan Stary <hans at stare dot cz>, tweaked by me and tb@.
While here, apply some simple style improvements:
Sort headers, static void __dead usage(), return from main(),
zap case '?', drop /* NOTREACHED */, drop break after usage(), ...
OK tb@ millert@

Check the return value of snprintf() for potential overflow instead
of doing a manual check beforehand.

Avoid potential read of one byte before the start of a malloc()ed
buffer. From Max Fillinger.

Use _PATH_DEFPATH if no PATH in the environment when invoked as which.

fix exit status on pledge(2) failure.

OK tb@ jsg@

pledge "stdio rpath"
ok beck doug

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Use errc/warnc to simplify code.
Also, in 'ftp', always put the error message last, after the hostname/ipaddr.

ok jsing@ krw@ millert@

Get the standard path from _PATH_STDPATH instead of
sysctl({CTL_USER,USER_CS_PATH}). Expand that into the manpage
too.

_PATH_STDPATH suggested by miod@
Corrections from schwarze@ and jmc@
ok millert@ miod@ schwarze@ jmc@

The -a option shouldn't change the exit status
Patch from David Julio (david.a.julio at gmail.com)

stderr should be used for error messages; this diff makes which(1)
output not only more standard but also more predictable, as it now
matches the behavior of the csh(1)'s built-in command.

diff from Tobias Ulmer.

ok millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

the ellipsis is not an optional argument; document the "-a" flag in whereis(1)

help and feedback by jmc@ and otto@

ok deraadt@, jmc@ and otto@

save a copy of the pointer before strsep; fixes an abort on free.
ok by millert, otto & pedro.

Add missing free on error; Alison Winters
Also KNF the return statements and make usage() __dead while I am here.

Sync with share/misc/license.template and add missing DARPA credit
where applicable.

mostly ansi cleanup; pval ok

Use an ISC-tyle license for all my code; it is simpler and more permissive.

snprintf() is simpler than multiple strlcpy() and manual fiddling.
Also convert to C89 while I'm at it.

snprintf & strlcpy; tedu ok

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Remove the advertising clause in my old license, it impedes free use
of the code as a large number of similar clauses makes it impossible
to write an ad for a product using the code...

fix err() use

Add -a flag. Idea from bgrayson@ece.utexas.edu

which(1) and whereis(1) are now the same program (hard linked).

which(1) is now a binary that works in any shell since csh(1) has a
which built-in.