spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

Make all signal handler functions async-signal-safe
by deleting the redundant "killersig" struct member
and using the existing sig_atomic_t cl_sigterm variable instead.
While here, garbage collect the h_hup() signal handler
which is essentially identical to h_term().
This also gets rid of the last #define & #undef in cl_main.c.

OK martijn@, and also tested by Tim <trondd at kagu hyphen tsuchi dot com>.

As a first step towards safe signal handling, improve the h_int()
and h_winch() signal handlers to make one single store to a
sig_atomic_t variable. Note that the h_hup() and h_term() signal
handlers are still unsafe after this commit because they also set
the "killersig" (how fitting!) field in a global struct.

Despite storing information in static global variables rather than
in structs passed around as arguments, this patch does not cause a
change in behaviour because there is always exactly one GS object,
initialized using gs_init() called from the top of main(), and
screen_init() stores a pointer to this one and only GS object in
the .gp member of each and every SCR object. Talk about useless
abstraction...

Problem pointed out by deraadt@.
Patch from Tim <trondd at kagu hyphen tsuchi dot com> on tech@.
OK deraadt@.

Revert CHAR_T removal. Some signedness flaws were introduced.
Found the hard way by jca@

Remove CHAR_T in favor of native types.

schwarze@ agrees with the direction.
Few tweaks and OK tb@

Remove SA_INTERRUPT, HISTORIC_PRACTICE, and HISTORICAL_PRACTICE using
unifdef. It seems clear that no one was using these (SA_INTERRUPT didn't
even build the other way). Tweak comments as appropriate.

ok brynet@

Remove more portability bits for older systems; from Martin Natano

Ansify vi.

ok bcallah@ millert@

Remove old curses support in vi.

ok nicm@ millert@ plus a comment tweak from nicm@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

ex(1), vi(1), and view(1) have different synopses; each nex/nvi utility
should manage the right set of options and return an appropriate usage
when required.

jsing@ has suggested preserving "-e" in ex(1) as an undocumented
compatibility flag to avoid breaking silly scripts that may use this
option with the line-oriented editor.

diff sent upstream to nex/nvi maintainers.

ok ("put it in!") jsing@

Removes unused variables and rename variables shadowing external
variables. No binary change.

Found by lint.

OK otto@ and jaredy@

Silence 39 warnings.

ok miod, otto

add missing includes
ok tedu@

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

$OpenBSD$

Don't call curses routines beep() or flash() if the screen has not been
setup yet (as they will try to us SP which is NULL at this point).

-D_USE_OLD_CURSE_ for -locurses and no more -ltermlib/termcap

Make building with ocurses/termcap and curses/termlib conditional on
USE_OCURSES being defined, and define it for now. This switches nvi back
to use BSD curses.

nvi 1.78:
+ Fix bugs when both the leftright scrolling and number edit options
were on.
+ Fix bug where splitting in the middle of the screen could repaint
incorrectly.
+ Fix first-nul in input bug, where random garbage was inserted.
+ Correct search and mark-as-motion-command bug, it's a line mode
action if the search starts at or before the first non<blank>.
+ Fix bug autoindent bug, where ^D could shift too far in the line.
+ Fix core dump where ! command called from the .exrc file.
+ Add the -S command-line option, which initializes vi to have the
secure edit option preset.

nvi 1.73

bring vi/ex up to 1.71

new vi

Make all signal handler functions async-signal-safe
by deleting the redundant "killersig" struct member
and using the existing sig_atomic_t cl_sigterm variable instead.
While here, garbage collect the h_hup() signal handler
which is essentially identical to h_term().
This also gets rid of the last #define & #undef in cl_main.c.

OK martijn@, and also tested by Tim <trondd at kagu hyphen tsuchi dot com>.

As a first step towards safe signal handling, improve the h_int()
and h_winch() signal handlers to make one single store to a
sig_atomic_t variable. Note that the h_hup() and h_term() signal
handlers are still unsafe after this commit because they also set
the "killersig" (how fitting!) field in a global struct.

Despite storing information in static global variables rather than
in structs passed around as arguments, this patch does not cause a
change in behaviour because there is always exactly one GS object,
initialized using gs_init() called from the top of main(), and
screen_init() stores a pointer to this one and only GS object in
the .gp member of each and every SCR object. Talk about useless
abstraction...

Problem pointed out by deraadt@.
Patch from Tim <trondd at kagu hyphen tsuchi dot com> on tech@.
OK deraadt@.

Revert CHAR_T removal. Some signedness flaws were introduced.
Found the hard way by jca@

Remove CHAR_T in favor of native types.

schwarze@ agrees with the direction.
Few tweaks and OK tb@

Remove SA_INTERRUPT, HISTORIC_PRACTICE, and HISTORICAL_PRACTICE using
unifdef. It seems clear that no one was using these (SA_INTERRUPT didn't
even build the other way). Tweak comments as appropriate.

ok brynet@

Remove more portability bits for older systems; from Martin Natano

Ansify vi.

ok bcallah@ millert@

Remove old curses support in vi.

ok nicm@ millert@ plus a comment tweak from nicm@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

ex(1), vi(1), and view(1) have different synopses; each nex/nvi utility
should manage the right set of options and return an appropriate usage
when required.

jsing@ has suggested preserving "-e" in ex(1) as an undocumented
compatibility flag to avoid breaking silly scripts that may use this
option with the line-oriented editor.

diff sent upstream to nex/nvi maintainers.

ok ("put it in!") jsing@

Removes unused variables and rename variables shadowing external
variables. No binary change.

Found by lint.

OK otto@ and jaredy@

Silence 39 warnings.

ok miod, otto

add missing includes
ok tedu@

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

$OpenBSD$

Don't call curses routines beep() or flash() if the screen has not been
setup yet (as they will try to us SP which is NULL at this point).

-D_USE_OLD_CURSE_ for -locurses and no more -ltermlib/termcap

Make building with ocurses/termcap and curses/termlib conditional on
USE_OCURSES being defined, and define it for now. This switches nvi back
to use BSD curses.

nvi 1.78:
+ Fix bugs when both the leftright scrolling and number edit options
were on.
+ Fix bug where splitting in the middle of the screen could repaint
incorrectly.
+ Fix first-nul in input bug, where random garbage was inserted.
+ Correct search and mark-as-motion-command bug, it's a line mode
action if the search starts at or before the first non<blank>.
+ Fix bug autoindent bug, where ^D could shift too far in the line.
+ Fix core dump where ! command called from the .exrc file.
+ Add the -S command-line option, which initializes vi to have the
secure edit option preset.

nvi 1.73

bring vi/ex up to 1.71

new vi

Revert CHAR_T removal. Some signedness flaws were introduced.
Found the hard way by jca@

Remove CHAR_T in favor of native types.

schwarze@ agrees with the direction.
Few tweaks and OK tb@

Remove SA_INTERRUPT, HISTORIC_PRACTICE, and HISTORICAL_PRACTICE using
unifdef. It seems clear that no one was using these (SA_INTERRUPT didn't
even build the other way). Tweak comments as appropriate.

ok brynet@

Remove more portability bits for older systems; from Martin Natano

Ansify vi.

ok bcallah@ millert@

Remove old curses support in vi.

ok nicm@ millert@ plus a comment tweak from nicm@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

ex(1), vi(1), and view(1) have different synopses; each nex/nvi utility
should manage the right set of options and return an appropriate usage
when required.

jsing@ has suggested preserving "-e" in ex(1) as an undocumented
compatibility flag to avoid breaking silly scripts that may use this
option with the line-oriented editor.

diff sent upstream to nex/nvi maintainers.

ok ("put it in!") jsing@

Removes unused variables and rename variables shadowing external
variables. No binary change.

Found by lint.

OK otto@ and jaredy@

Silence 39 warnings.

ok miod, otto

add missing includes
ok tedu@

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

$OpenBSD$

Don't call curses routines beep() or flash() if the screen has not been
setup yet (as they will try to us SP which is NULL at this point).

-D_USE_OLD_CURSE_ for -locurses and no more -ltermlib/termcap

Make building with ocurses/termcap and curses/termlib conditional on
USE_OCURSES being defined, and define it for now. This switches nvi back
to use BSD curses.

nvi 1.78:
+ Fix bugs when both the leftright scrolling and number edit options
were on.
+ Fix bug where splitting in the middle of the screen could repaint
incorrectly.
+ Fix first-nul in input bug, where random garbage was inserted.
+ Correct search and mark-as-motion-command bug, it's a line mode
action if the search starts at or before the first non<blank>.
+ Fix bug autoindent bug, where ^D could shift too far in the line.
+ Fix core dump where ! command called from the .exrc file.
+ Add the -S command-line option, which initializes vi to have the
secure edit option preset.

nvi 1.73

bring vi/ex up to 1.71

new vi