touch(1): don't leak file descriptor if futimens(2) fails

This conditional chain short-circuits if futimens(2) fails, leaving the
file descriptor open. We need to evaluate each system call in the chain
separately to ensure we attempt to close(2) the descriptor.

With input from guenther@ and millert@.

Thread: https://marc.info/?l=openbsd-tech&m=164332809900558&w=2

ok millert@, probably ok guenther@

Delete a useless call to setlocale(3): strptime(3) is only called
with %F and %T, neither of which is locale-dependent, and nothing
else in the code depends on the locale either, since most of the
parsing is done by hand and only supports numerical formats in the
first place.

While here, make usage() static and return from main rather than exit(3).

Patch from Jan Stary <hans at stare dot cz>.

tedu@ agrees.

Change all tame callers to namechange to pledge(2).

use tame "stdio rpath wpath cpath fattr". There is some timezone
database stuff here which goes further than most programs, but the
neccessary files are readable using "rpath".

Eliminate use of TM_YEAR_BASE. OK guenther@ deraadt@ miod@

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

use the same format/text, as far as possible, for date strings;
help/ok guenther millert

Make the code match the manpage and POSIX spec when the year is specified
but the century isn't: century is 1900 if year >= 69; else 2000

ok millert@

With gettimeofday() removed from the top of main(), need to call time()
for the defaulting of the year to work in the -t and arg1 forms that were
broken by previous change

ok millert@

Add nanosecond precision and support for -d option (new in POSIX 2008)

ok millert@, manpage fixes jmc@

the ellipsis is not an optional argument; while here, sync the usage
and synopsis of commands

lots of good ideas by jmc@

ok jmc@

Fix typo introduced in seconds parsing. From Tim van der Molen.

Sanity check time spec and if no century is specified, just use the
current one.

even betterer
From: Przemyslaw Nowaczyk <p_nowaczyk@o2.pl>

KNF & cleanup
mostly From: Przemyslaw Nowaczyk <p_nowaczyk@o2.pl>

spacing

Remove redundant rw() function, which is unsafe and, well, redundant.
ok tedu@ deraadt@

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

typo in comment; Jim Geovedi

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Missed one TM_YEAR_BASE in previous commit; pointed out by peters@telia.net
in PR 1445.

use TM_YEAR_BASE and set seconds to zero in obsolescent "compatibility" case;
from NetBSD.

Y2K fix for obsolescent time format: found by Camiel Dobbelaar.

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

Delete a useless call to setlocale(3): strptime(3) is only called
with %F and %T, neither of which is locale-dependent, and nothing
else in the code depends on the locale either, since most of the
parsing is done by hand and only supports numerical formats in the
first place.

While here, make usage() static and return from main rather than exit(3).

Patch from Jan Stary <hans at stare dot cz>.

tedu@ agrees.

Change all tame callers to namechange to pledge(2).

use tame "stdio rpath wpath cpath fattr". There is some timezone
database stuff here which goes further than most programs, but the
neccessary files are readable using "rpath".

Eliminate use of TM_YEAR_BASE. OK guenther@ deraadt@ miod@

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

use the same format/text, as far as possible, for date strings;
help/ok guenther millert

Make the code match the manpage and POSIX spec when the year is specified
but the century isn't: century is 1900 if year >= 69; else 2000

ok millert@

With gettimeofday() removed from the top of main(), need to call time()
for the defaulting of the year to work in the -t and arg1 forms that were
broken by previous change

ok millert@

Add nanosecond precision and support for -d option (new in POSIX 2008)

ok millert@, manpage fixes jmc@

the ellipsis is not an optional argument; while here, sync the usage
and synopsis of commands

lots of good ideas by jmc@

ok jmc@

Fix typo introduced in seconds parsing. From Tim van der Molen.

Sanity check time spec and if no century is specified, just use the
current one.

even betterer
From: Przemyslaw Nowaczyk <p_nowaczyk@o2.pl>

KNF & cleanup
mostly From: Przemyslaw Nowaczyk <p_nowaczyk@o2.pl>

spacing

Remove redundant rw() function, which is unsafe and, well, redundant.
ok tedu@ deraadt@

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

typo in comment; Jim Geovedi

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Missed one TM_YEAR_BASE in previous commit; pointed out by peters@telia.net
in PR 1445.

use TM_YEAR_BASE and set seconds to zero in obsolescent "compatibility" case;
from NetBSD.

Y2K fix for obsolescent time format: found by Camiel Dobbelaar.

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

Change all tame callers to namechange to pledge(2).

use tame "stdio rpath wpath cpath fattr". There is some timezone
database stuff here which goes further than most programs, but the
neccessary files are readable using "rpath".

Eliminate use of TM_YEAR_BASE. OK guenther@ deraadt@ miod@

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

use the same format/text, as far as possible, for date strings;
help/ok guenther millert

Make the code match the manpage and POSIX spec when the year is specified
but the century isn't: century is 1900 if year >= 69; else 2000

ok millert@

With gettimeofday() removed from the top of main(), need to call time()
for the defaulting of the year to work in the -t and arg1 forms that were
broken by previous change

ok millert@

Add nanosecond precision and support for -d option (new in POSIX 2008)

ok millert@, manpage fixes jmc@

the ellipsis is not an optional argument; while here, sync the usage
and synopsis of commands

lots of good ideas by jmc@

ok jmc@

Fix typo introduced in seconds parsing. From Tim van der Molen.

Sanity check time spec and if no century is specified, just use the
current one.

even betterer
From: Przemyslaw Nowaczyk <p_nowaczyk@o2.pl>

KNF & cleanup
mostly From: Przemyslaw Nowaczyk <p_nowaczyk@o2.pl>

spacing

Remove redundant rw() function, which is unsafe and, well, redundant.
ok tedu@ deraadt@

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

typo in comment; Jim Geovedi

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Missed one TM_YEAR_BASE in previous commit; pointed out by peters@telia.net
in PR 1445.

use TM_YEAR_BASE and set seconds to zero in obsolescent "compatibility" case;
from NetBSD.

Y2K fix for obsolescent time format: found by Camiel Dobbelaar.

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision