systat(1): vmstat: measure elapsed time with clock_gettime(2) instead of ticks

The vmstat view in systat(1) should not use statclock() ticks to count
elapsed time. First, ticks are low resolution. Second, the statclock
is sometimes randomized, so each tick is not necessarily of equal
length. Third, we're counting ticks from every CPU on the system, so
every rate in the view is divided by the number of CPUs. For example,
on an amd64 system with 8 CPUs you currently see:

200 clock

... when the true clock interrupt rate on that system is 1600.

Instead, measure elapsed time with clock_gettime(2). Use CLOCK_UPTIME
here so we exclude time when the system is suspended. With this
change we no longer need "stathz" or "hertz". We can also get rid of
the anachronistic secondary clock failure test.

Prompted by dlg@ and jmatthew@. deraadt@ says this has been in snaps
since 2022-11-21; no complaints.

Link: https://marc.info/?l=openbsd-tech&m=166898960831136&w=2

ok dlg@ deraadt@

Change the error reporting pattern throughout the tree when unveil
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.

Work done and verified by Ashton Fagg <ashton@fagg.id.au>

ok deraadt@ semarie@ claudio@

Use nanosleep() and setitimer() instead of usleep() and ualarm().
Both usleep() and ualarm() are obsolete and were removed from POSIX.
OK deraadt@

Make the hints at the bottom row sticky by turning the knobs toggles.
Specifically this effects ^G, help and order.

While here also document the 'h' character.

Initial inspiration and diff from Anindya Mukherjee (anindya49 <at> hotmail
<dot> com)

OK bluhm@

Fix delay parsing by stealing from strtonum and returning a proper error to
the user when an invalid value is entered instead of silently falling back
to the default 5s.

While here I also capped the upper limit to UINT32_MAX / 1000000 to prevent
useconds_t overflow. This hard limits us to 4294s, instead of the current
soft limit which just make systat go berserk if you go over it.

Reported and original diff by Nick Gasson nick <at> nickg <dot> me <dot> uk

OK cheloha@
Tweaks and OK bluhm@

Add support for human readable numbers where applicable.

OK stsp@ and bluhm@

pledge() won't work but we can use unveil() to reduce filesystem access
in these 3 related programs (they borrow parts of each other using .PATH)
Hopefully no regressions, ktrace checks by myself and mestre

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

use $OpenBSD markers
ok millert mpi

Add uvm view to show all values being collected in uvmexp.

Feedbacks, tweaks, ok bluhm@

Add the order keyword to systat global command interpreter.
This command shows the available orderings for the current view, which
ordering is active, their shortcuts, and if they're in reverse order.

manpage nits jmc@
OK tedu@

tweak previous; hostname is alredy available plus some better formatting
in case line numbers and/or PAUSED is shown; ok tedu@

add the hostname to the display. started by otto, then deraadt. ok deraadt

garbage collect unsused variable
found by evh -AT- riseup -DOT- net, ok florian@

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Switch the netstat view of systat to use the same kvm_getfiles()
function similar to netstat(1). The output still shows the same
info but may be a bit differently sorted. Also it will now show
connections that are not UDP or TCP. This was the last bit of
systat that needed kvm access and so now systat no longer needs
to be setgid kmem.
With this commit OpenBSD is officially setgid kmem free and an
almost 10 year journey finally comes to an end.
OK deraadt@

first batch of programs adapting to the namespace cleanup
(pfvar.h nameser.h proc.h ucred.h)
ok guenther millert, and some review from doug as well.

Add a new screen "cpu" that simply lists the usage of each CPU core.
Also add a new -B command line flag that works like -b but waits some
cycles before dumping anything to the console.

With much help from jmc@
OK jj@ lambert@ jmc@

Add support to display numbers with thousands separators
and to switch the ifstat view to Bits/s.
This allows us to see live network throughput in units
like MBit/s, which is more practical.
OK sthen@, manpage OK jmc@, "put it in" deraadt@

Make the top line of systat stop updating, along with the rest of the data
when 'p' is pressed.
ok nicm@

Make the terminal checking capability of systat better.
Checks taken from top(1) screen.c/init_termcap()
ok canacar@ sthen@ nicm@

Allow systat to print date and time when in rawmode.
ok canacar@ millert@

Allow systat(1) to resolve names by adding a new -N flag. (The default was
changed some time ago). Noticed by landry@, discussed with canacar@ and others.
ok deraadt@

the rule is not to use nitems() in userland yet

use the nitems() macro where appropriate

ok canacar@

- add two new views to systat, 'nfsserver' and 'nfsclient'.
output is similar to nfsstat(1), but it allows for better monitoring/debugging

tricked into by and "i love this" thib@
ok canacar@

Add malloc and buckets views that display kernel malloc statistics similar
to vmstat -m

Fix some function prototypes, remove unused variables and commented out code

spelling: ambigious -> ambiguous

Add a view that displays pool(9) information. Idea and ok deraadt@

Remove disabled help text code and -S command, both leftovers from pftop,
skip the correct number of bytes after the 'start' command.

Implement start and stop commands as documented,
explicitly pass the command buffer to the command functions.

make ^G display the current view and refresh interval as documented.

-S currently does nothing useful, so remove it from
SYNOPSIS and usage(); after some discussion with canacar

Small step towards fixing documentation:
- sync usage() with reality. Remove the -h option that does nothing.
- don't complain about kvm_openfiles() error in case of incorrect usage.
- add basic descriptions of the new options and views in the manual
page. More is needed...
with help from jmc@ and sobrado@. ok sobrado@.

Do not allow negative or zero delay values from the command line,
use the same check as the -s option. Noticed by johan@

Add ':q' as an alias to ':quit', to match old behaviour. Initial patch
from dlg@, this is a simpler version.

compile on older gcc; no decl after code

Set 'naptime' which is used by the interface page in differential mode.
Also remove a debugging message while there.
reported by claudio@

New display engine for systat, based on pftop. Adds new views for pf
(status, state, rule, queue). While all displays work, some keyboard
comands are not implemented yet. Other features include better handling
of display resize and scrolling for long views. Committing now to fix
the remaining issues in the tree.
Testing and comments by otto@ and harding@, ok deraadt@

fix -Wall warning about unused variable `errstr', which was introduced in the previous revision; ok deraadt, otto, tedu

support non-integral refresh intervals, possibly as low as 0.1s.
this makes it more useful for real time display of fast changing stats
ok art deraadt

use the 1 line load line from 'systat vm' on all the other displays, giving
them more room. much cleaner, and it is less code too; ok deanna

delay time of 0 should be invalid; evol@online.ptt.ru

Improve error message.

Found by Florin Iamandi <florin dot i at tiscali dot it>.

OK tedu@ and deraadt@

fairly simple cleanup, lots of testing done

make these use setres[ug]id for simple privilege dropping;
ok deraadt@ millert@ moritz@

add -n flag (do not reverse-lookup). pb and deraadt ok

wakeup after ^Z did not continue redraws and such. use own ^Z handler.
ok otto millert

- add -w to options description
- document default refresh interval
- sync usage() with SYNOPSIS

inspired by PR 3608;
ok deraadt@

remove old -M and -N; 3608

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

kvm gid revocation earlier

revoke privs after kvm_openfiles

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

move back. pvalchev -- the bug was quite obscure

back out latest changes which cause problems on alpha/sparc64 until
they are fixed

remove unused var

fix signal races. use sysctl() instead of kvm where possible, and then KNF
the hell out of it; checked by miod

kill more registers

millert@ ok

Replace the deprecated BSD sigsetmask/sigblock/sigpause functions with their POSIX counterparts.

handle kvm_nlist() failing, from pr#1798.
Patch similar to the one submitted by <peterw@documenta.com.au>

simple SIGWINCH handler; deals only with window size changes >= 80x24

when getting interrupt, clean up curses only if curses was active

#if __STDC__ --> #ifdef __STDC__

Cleanup by Theo and myself. CMDLINE changed to long to make
command line work on 64bit platforms. This is somewhat bogus
and is really just a temporary workaround (there may be a curses bug).

You can't store a double in an int and then do tests for the fractional part
miss thing! Also, make more sensitive to digital decay. Now "<<<" will
show up in load average display.

getopt(3) returns -1 when out of args, not EOF, whee!

Deal with _POSIX_SAVED_IDS when relinquishing privileges

Clarify usage printout

_POSIX2_LINE_MAX errbuf for kvm_openfiles()

avoid buf oflows

rcsid

libutil

sync to netbsd 960418

branches: 1.1.1;
Initial revision

Change the error reporting pattern throughout the tree when unveil
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.

Work done and verified by Ashton Fagg <ashton@fagg.id.au>

ok deraadt@ semarie@ claudio@

Use nanosleep() and setitimer() instead of usleep() and ualarm().
Both usleep() and ualarm() are obsolete and were removed from POSIX.
OK deraadt@

Make the hints at the bottom row sticky by turning the knobs toggles.
Specifically this effects ^G, help and order.

While here also document the 'h' character.

Initial inspiration and diff from Anindya Mukherjee (anindya49 <at> hotmail
<dot> com)

OK bluhm@

Fix delay parsing by stealing from strtonum and returning a proper error to
the user when an invalid value is entered instead of silently falling back
to the default 5s.

While here I also capped the upper limit to UINT32_MAX / 1000000 to prevent
useconds_t overflow. This hard limits us to 4294s, instead of the current
soft limit which just make systat go berserk if you go over it.

Reported and original diff by Nick Gasson nick <at> nickg <dot> me <dot> uk

OK cheloha@
Tweaks and OK bluhm@

Add support for human readable numbers where applicable.

OK stsp@ and bluhm@

pledge() won't work but we can use unveil() to reduce filesystem access
in these 3 related programs (they borrow parts of each other using .PATH)
Hopefully no regressions, ktrace checks by myself and mestre

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

use $OpenBSD markers
ok millert mpi

Add uvm view to show all values being collected in uvmexp.

Feedbacks, tweaks, ok bluhm@

Add the order keyword to systat global command interpreter.
This command shows the available orderings for the current view, which
ordering is active, their shortcuts, and if they're in reverse order.

manpage nits jmc@
OK tedu@

tweak previous; hostname is alredy available plus some better formatting
in case line numbers and/or PAUSED is shown; ok tedu@

add the hostname to the display. started by otto, then deraadt. ok deraadt

garbage collect unsused variable
found by evh -AT- riseup -DOT- net, ok florian@

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Switch the netstat view of systat to use the same kvm_getfiles()
function similar to netstat(1). The output still shows the same
info but may be a bit differently sorted. Also it will now show
connections that are not UDP or TCP. This was the last bit of
systat that needed kvm access and so now systat no longer needs
to be setgid kmem.
With this commit OpenBSD is officially setgid kmem free and an
almost 10 year journey finally comes to an end.
OK deraadt@

first batch of programs adapting to the namespace cleanup
(pfvar.h nameser.h proc.h ucred.h)
ok guenther millert, and some review from doug as well.

Add a new screen "cpu" that simply lists the usage of each CPU core.
Also add a new -B command line flag that works like -b but waits some
cycles before dumping anything to the console.

With much help from jmc@
OK jj@ lambert@ jmc@

Add support to display numbers with thousands separators
and to switch the ifstat view to Bits/s.
This allows us to see live network throughput in units
like MBit/s, which is more practical.
OK sthen@, manpage OK jmc@, "put it in" deraadt@

Make the top line of systat stop updating, along with the rest of the data
when 'p' is pressed.
ok nicm@

Make the terminal checking capability of systat better.
Checks taken from top(1) screen.c/init_termcap()
ok canacar@ sthen@ nicm@

Allow systat to print date and time when in rawmode.
ok canacar@ millert@

Allow systat(1) to resolve names by adding a new -N flag. (The default was
changed some time ago). Noticed by landry@, discussed with canacar@ and others.
ok deraadt@

the rule is not to use nitems() in userland yet

use the nitems() macro where appropriate

ok canacar@

- add two new views to systat, 'nfsserver' and 'nfsclient'.
output is similar to nfsstat(1), but it allows for better monitoring/debugging

tricked into by and "i love this" thib@
ok canacar@

Add malloc and buckets views that display kernel malloc statistics similar
to vmstat -m

Fix some function prototypes, remove unused variables and commented out code

spelling: ambigious -> ambiguous

Add a view that displays pool(9) information. Idea and ok deraadt@

Remove disabled help text code and -S command, both leftovers from pftop,
skip the correct number of bytes after the 'start' command.

Implement start and stop commands as documented,
explicitly pass the command buffer to the command functions.

make ^G display the current view and refresh interval as documented.

-S currently does nothing useful, so remove it from
SYNOPSIS and usage(); after some discussion with canacar

Small step towards fixing documentation:
- sync usage() with reality. Remove the -h option that does nothing.
- don't complain about kvm_openfiles() error in case of incorrect usage.
- add basic descriptions of the new options and views in the manual
page. More is needed...
with help from jmc@ and sobrado@. ok sobrado@.

Do not allow negative or zero delay values from the command line,
use the same check as the -s option. Noticed by johan@

Add ':q' as an alias to ':quit', to match old behaviour. Initial patch
from dlg@, this is a simpler version.

compile on older gcc; no decl after code

Set 'naptime' which is used by the interface page in differential mode.
Also remove a debugging message while there.
reported by claudio@

New display engine for systat, based on pftop. Adds new views for pf
(status, state, rule, queue). While all displays work, some keyboard
comands are not implemented yet. Other features include better handling
of display resize and scrolling for long views. Committing now to fix
the remaining issues in the tree.
Testing and comments by otto@ and harding@, ok deraadt@

fix -Wall warning about unused variable `errstr', which was introduced in the previous revision; ok deraadt, otto, tedu

support non-integral refresh intervals, possibly as low as 0.1s.
this makes it more useful for real time display of fast changing stats
ok art deraadt

use the 1 line load line from 'systat vm' on all the other displays, giving
them more room. much cleaner, and it is less code too; ok deanna

delay time of 0 should be invalid; evol@online.ptt.ru

Improve error message.

Found by Florin Iamandi <florin dot i at tiscali dot it>.

OK tedu@ and deraadt@

fairly simple cleanup, lots of testing done

make these use setres[ug]id for simple privilege dropping;
ok deraadt@ millert@ moritz@

add -n flag (do not reverse-lookup). pb and deraadt ok

wakeup after ^Z did not continue redraws and such. use own ^Z handler.
ok otto millert

- add -w to options description
- document default refresh interval
- sync usage() with SYNOPSIS

inspired by PR 3608;
ok deraadt@

remove old -M and -N; 3608

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

kvm gid revocation earlier

revoke privs after kvm_openfiles

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

move back. pvalchev -- the bug was quite obscure

back out latest changes which cause problems on alpha/sparc64 until
they are fixed

remove unused var

fix signal races. use sysctl() instead of kvm where possible, and then KNF
the hell out of it; checked by miod

kill more registers

millert@ ok

Replace the deprecated BSD sigsetmask/sigblock/sigpause functions with their POSIX counterparts.

handle kvm_nlist() failing, from pr#1798.
Patch similar to the one submitted by <peterw@documenta.com.au>

simple SIGWINCH handler; deals only with window size changes >= 80x24

when getting interrupt, clean up curses only if curses was active

#if __STDC__ --> #ifdef __STDC__

Cleanup by Theo and myself. CMDLINE changed to long to make
command line work on 64bit platforms. This is somewhat bogus
and is really just a temporary workaround (there may be a curses bug).

You can't store a double in an int and then do tests for the fractional part
miss thing! Also, make more sensitive to digital decay. Now "<<<" will
show up in load average display.

getopt(3) returns -1 when out of args, not EOF, whee!

Deal with _POSIX_SAVED_IDS when relinquishing privileges

Clarify usage printout

_POSIX2_LINE_MAX errbuf for kvm_openfiles()

avoid buf oflows

rcsid

libutil

sync to netbsd 960418

branches: 1.1.1;
Initial revision

Use nanosleep() and setitimer() instead of usleep() and ualarm().
Both usleep() and ualarm() are obsolete and were removed from POSIX.
OK deraadt@

Make the hints at the bottom row sticky by turning the knobs toggles.
Specifically this effects ^G, help and order.

While here also document the 'h' character.

Initial inspiration and diff from Anindya Mukherjee (anindya49 <at> hotmail
<dot> com)

OK bluhm@

Fix delay parsing by stealing from strtonum and returning a proper error to
the user when an invalid value is entered instead of silently falling back
to the default 5s.

While here I also capped the upper limit to UINT32_MAX / 1000000 to prevent
useconds_t overflow. This hard limits us to 4294s, instead of the current
soft limit which just make systat go berserk if you go over it.

Reported and original diff by Nick Gasson nick <at> nickg <dot> me <dot> uk

OK cheloha@
Tweaks and OK bluhm@

Add support for human readable numbers where applicable.

OK stsp@ and bluhm@

pledge() won't work but we can use unveil() to reduce filesystem access
in these 3 related programs (they borrow parts of each other using .PATH)
Hopefully no regressions, ktrace checks by myself and mestre

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

use $OpenBSD markers
ok millert mpi

Add uvm view to show all values being collected in uvmexp.

Feedbacks, tweaks, ok bluhm@

Add the order keyword to systat global command interpreter.
This command shows the available orderings for the current view, which
ordering is active, their shortcuts, and if they're in reverse order.

manpage nits jmc@
OK tedu@

tweak previous; hostname is alredy available plus some better formatting
in case line numbers and/or PAUSED is shown; ok tedu@

add the hostname to the display. started by otto, then deraadt. ok deraadt

garbage collect unsused variable
found by evh -AT- riseup -DOT- net, ok florian@

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Switch the netstat view of systat to use the same kvm_getfiles()
function similar to netstat(1). The output still shows the same
info but may be a bit differently sorted. Also it will now show
connections that are not UDP or TCP. This was the last bit of
systat that needed kvm access and so now systat no longer needs
to be setgid kmem.
With this commit OpenBSD is officially setgid kmem free and an
almost 10 year journey finally comes to an end.
OK deraadt@

first batch of programs adapting to the namespace cleanup
(pfvar.h nameser.h proc.h ucred.h)
ok guenther millert, and some review from doug as well.

Add a new screen "cpu" that simply lists the usage of each CPU core.
Also add a new -B command line flag that works like -b but waits some
cycles before dumping anything to the console.

With much help from jmc@
OK jj@ lambert@ jmc@

Add support to display numbers with thousands separators
and to switch the ifstat view to Bits/s.
This allows us to see live network throughput in units
like MBit/s, which is more practical.
OK sthen@, manpage OK jmc@, "put it in" deraadt@

Make the top line of systat stop updating, along with the rest of the data
when 'p' is pressed.
ok nicm@

Make the terminal checking capability of systat better.
Checks taken from top(1) screen.c/init_termcap()
ok canacar@ sthen@ nicm@

Allow systat to print date and time when in rawmode.
ok canacar@ millert@

Allow systat(1) to resolve names by adding a new -N flag. (The default was
changed some time ago). Noticed by landry@, discussed with canacar@ and others.
ok deraadt@

the rule is not to use nitems() in userland yet

use the nitems() macro where appropriate

ok canacar@

- add two new views to systat, 'nfsserver' and 'nfsclient'.
output is similar to nfsstat(1), but it allows for better monitoring/debugging

tricked into by and "i love this" thib@
ok canacar@

Add malloc and buckets views that display kernel malloc statistics similar
to vmstat -m

Fix some function prototypes, remove unused variables and commented out code

spelling: ambigious -> ambiguous

Add a view that displays pool(9) information. Idea and ok deraadt@

Remove disabled help text code and -S command, both leftovers from pftop,
skip the correct number of bytes after the 'start' command.

Implement start and stop commands as documented,
explicitly pass the command buffer to the command functions.

make ^G display the current view and refresh interval as documented.

-S currently does nothing useful, so remove it from
SYNOPSIS and usage(); after some discussion with canacar

Small step towards fixing documentation:
- sync usage() with reality. Remove the -h option that does nothing.
- don't complain about kvm_openfiles() error in case of incorrect usage.
- add basic descriptions of the new options and views in the manual
page. More is needed...
with help from jmc@ and sobrado@. ok sobrado@.

Do not allow negative or zero delay values from the command line,
use the same check as the -s option. Noticed by johan@

Add ':q' as an alias to ':quit', to match old behaviour. Initial patch
from dlg@, this is a simpler version.

compile on older gcc; no decl after code

Set 'naptime' which is used by the interface page in differential mode.
Also remove a debugging message while there.
reported by claudio@

New display engine for systat, based on pftop. Adds new views for pf
(status, state, rule, queue). While all displays work, some keyboard
comands are not implemented yet. Other features include better handling
of display resize and scrolling for long views. Committing now to fix
the remaining issues in the tree.
Testing and comments by otto@ and harding@, ok deraadt@

fix -Wall warning about unused variable `errstr', which was introduced in the previous revision; ok deraadt, otto, tedu

support non-integral refresh intervals, possibly as low as 0.1s.
this makes it more useful for real time display of fast changing stats
ok art deraadt

use the 1 line load line from 'systat vm' on all the other displays, giving
them more room. much cleaner, and it is less code too; ok deanna

delay time of 0 should be invalid; evol@online.ptt.ru

Improve error message.

Found by Florin Iamandi <florin dot i at tiscali dot it>.

OK tedu@ and deraadt@

fairly simple cleanup, lots of testing done

make these use setres[ug]id for simple privilege dropping;
ok deraadt@ millert@ moritz@

add -n flag (do not reverse-lookup). pb and deraadt ok

wakeup after ^Z did not continue redraws and such. use own ^Z handler.
ok otto millert

- add -w to options description
- document default refresh interval
- sync usage() with SYNOPSIS

inspired by PR 3608;
ok deraadt@

remove old -M and -N; 3608

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

kvm gid revocation earlier

revoke privs after kvm_openfiles

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

move back. pvalchev -- the bug was quite obscure

back out latest changes which cause problems on alpha/sparc64 until
they are fixed

remove unused var

fix signal races. use sysctl() instead of kvm where possible, and then KNF
the hell out of it; checked by miod

kill more registers

millert@ ok

Replace the deprecated BSD sigsetmask/sigblock/sigpause functions with their POSIX counterparts.

handle kvm_nlist() failing, from pr#1798.
Patch similar to the one submitted by <peterw@documenta.com.au>

simple SIGWINCH handler; deals only with window size changes >= 80x24

when getting interrupt, clean up curses only if curses was active

#if __STDC__ --> #ifdef __STDC__

Cleanup by Theo and myself. CMDLINE changed to long to make
command line work on 64bit platforms. This is somewhat bogus
and is really just a temporary workaround (there may be a curses bug).

You can't store a double in an int and then do tests for the fractional part
miss thing! Also, make more sensitive to digital decay. Now "<<<" will
show up in load average display.

getopt(3) returns -1 when out of args, not EOF, whee!

Deal with _POSIX_SAVED_IDS when relinquishing privileges

Clarify usage printout

_POSIX2_LINE_MAX errbuf for kvm_openfiles()

avoid buf oflows

rcsid

libutil

sync to netbsd 960418

branches: 1.1.1;
Initial revision

Make the hints at the bottom row sticky by turning the knobs toggles.
Specifically this effects ^G, help and order.

While here also document the 'h' character.

Initial inspiration and diff from Anindya Mukherjee (anindya49 <at> hotmail
<dot> com)

OK bluhm@

Fix delay parsing by stealing from strtonum and returning a proper error to
the user when an invalid value is entered instead of silently falling back
to the default 5s.

While here I also capped the upper limit to UINT32_MAX / 1000000 to prevent
useconds_t overflow. This hard limits us to 4294s, instead of the current
soft limit which just make systat go berserk if you go over it.

Reported and original diff by Nick Gasson nick <at> nickg <dot> me <dot> uk

OK cheloha@
Tweaks and OK bluhm@

Add support for human readable numbers where applicable.

OK stsp@ and bluhm@

pledge() won't work but we can use unveil() to reduce filesystem access
in these 3 related programs (they borrow parts of each other using .PATH)
Hopefully no regressions, ktrace checks by myself and mestre

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

use $OpenBSD markers
ok millert mpi

Add uvm view to show all values being collected in uvmexp.

Feedbacks, tweaks, ok bluhm@

Add the order keyword to systat global command interpreter.
This command shows the available orderings for the current view, which
ordering is active, their shortcuts, and if they're in reverse order.

manpage nits jmc@
OK tedu@

tweak previous; hostname is alredy available plus some better formatting
in case line numbers and/or PAUSED is shown; ok tedu@

add the hostname to the display. started by otto, then deraadt. ok deraadt

garbage collect unsused variable
found by evh -AT- riseup -DOT- net, ok florian@

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Switch the netstat view of systat to use the same kvm_getfiles()
function similar to netstat(1). The output still shows the same
info but may be a bit differently sorted. Also it will now show
connections that are not UDP or TCP. This was the last bit of
systat that needed kvm access and so now systat no longer needs
to be setgid kmem.
With this commit OpenBSD is officially setgid kmem free and an
almost 10 year journey finally comes to an end.
OK deraadt@

first batch of programs adapting to the namespace cleanup
(pfvar.h nameser.h proc.h ucred.h)
ok guenther millert, and some review from doug as well.

Add a new screen "cpu" that simply lists the usage of each CPU core.
Also add a new -B command line flag that works like -b but waits some
cycles before dumping anything to the console.

With much help from jmc@
OK jj@ lambert@ jmc@

Add support to display numbers with thousands separators
and to switch the ifstat view to Bits/s.
This allows us to see live network throughput in units
like MBit/s, which is more practical.
OK sthen@, manpage OK jmc@, "put it in" deraadt@

Make the top line of systat stop updating, along with the rest of the data
when 'p' is pressed.
ok nicm@

Make the terminal checking capability of systat better.
Checks taken from top(1) screen.c/init_termcap()
ok canacar@ sthen@ nicm@

Allow systat to print date and time when in rawmode.
ok canacar@ millert@

Allow systat(1) to resolve names by adding a new -N flag. (The default was
changed some time ago). Noticed by landry@, discussed with canacar@ and others.
ok deraadt@

the rule is not to use nitems() in userland yet

use the nitems() macro where appropriate

ok canacar@

- add two new views to systat, 'nfsserver' and 'nfsclient'.
output is similar to nfsstat(1), but it allows for better monitoring/debugging

tricked into by and "i love this" thib@
ok canacar@

Add malloc and buckets views that display kernel malloc statistics similar
to vmstat -m

Fix some function prototypes, remove unused variables and commented out code

spelling: ambigious -> ambiguous

Add a view that displays pool(9) information. Idea and ok deraadt@

Remove disabled help text code and -S command, both leftovers from pftop,
skip the correct number of bytes after the 'start' command.

Implement start and stop commands as documented,
explicitly pass the command buffer to the command functions.

make ^G display the current view and refresh interval as documented.

-S currently does nothing useful, so remove it from
SYNOPSIS and usage(); after some discussion with canacar

Small step towards fixing documentation:
- sync usage() with reality. Remove the -h option that does nothing.
- don't complain about kvm_openfiles() error in case of incorrect usage.
- add basic descriptions of the new options and views in the manual
page. More is needed...
with help from jmc@ and sobrado@. ok sobrado@.

Do not allow negative or zero delay values from the command line,
use the same check as the -s option. Noticed by johan@

Add ':q' as an alias to ':quit', to match old behaviour. Initial patch
from dlg@, this is a simpler version.

compile on older gcc; no decl after code

Set 'naptime' which is used by the interface page in differential mode.
Also remove a debugging message while there.
reported by claudio@

New display engine for systat, based on pftop. Adds new views for pf
(status, state, rule, queue). While all displays work, some keyboard
comands are not implemented yet. Other features include better handling
of display resize and scrolling for long views. Committing now to fix
the remaining issues in the tree.
Testing and comments by otto@ and harding@, ok deraadt@

fix -Wall warning about unused variable `errstr', which was introduced in the previous revision; ok deraadt, otto, tedu

support non-integral refresh intervals, possibly as low as 0.1s.
this makes it more useful for real time display of fast changing stats
ok art deraadt

use the 1 line load line from 'systat vm' on all the other displays, giving
them more room. much cleaner, and it is less code too; ok deanna

delay time of 0 should be invalid; evol@online.ptt.ru

Improve error message.

Found by Florin Iamandi <florin dot i at tiscali dot it>.

OK tedu@ and deraadt@

fairly simple cleanup, lots of testing done

make these use setres[ug]id for simple privilege dropping;
ok deraadt@ millert@ moritz@

add -n flag (do not reverse-lookup). pb and deraadt ok

wakeup after ^Z did not continue redraws and such. use own ^Z handler.
ok otto millert

- add -w to options description
- document default refresh interval
- sync usage() with SYNOPSIS

inspired by PR 3608;
ok deraadt@

remove old -M and -N; 3608

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

kvm gid revocation earlier

revoke privs after kvm_openfiles

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

move back. pvalchev -- the bug was quite obscure

back out latest changes which cause problems on alpha/sparc64 until
they are fixed

remove unused var

fix signal races. use sysctl() instead of kvm where possible, and then KNF
the hell out of it; checked by miod

kill more registers

millert@ ok

Replace the deprecated BSD sigsetmask/sigblock/sigpause functions with their POSIX counterparts.

handle kvm_nlist() failing, from pr#1798.
Patch similar to the one submitted by <peterw@documenta.com.au>

simple SIGWINCH handler; deals only with window size changes >= 80x24

when getting interrupt, clean up curses only if curses was active

#if __STDC__ --> #ifdef __STDC__

Cleanup by Theo and myself. CMDLINE changed to long to make
command line work on 64bit platforms. This is somewhat bogus
and is really just a temporary workaround (there may be a curses bug).

You can't store a double in an int and then do tests for the fractional part
miss thing! Also, make more sensitive to digital decay. Now "<<<" will
show up in load average display.

getopt(3) returns -1 when out of args, not EOF, whee!

Deal with _POSIX_SAVED_IDS when relinquishing privileges

Clarify usage printout

_POSIX2_LINE_MAX errbuf for kvm_openfiles()

avoid buf oflows

rcsid

libutil

sync to netbsd 960418

branches: 1.1.1;
Initial revision

Fix delay parsing by stealing from strtonum and returning a proper error to
the user when an invalid value is entered instead of silently falling back
to the default 5s.

While here I also capped the upper limit to UINT32_MAX / 1000000 to prevent
useconds_t overflow. This hard limits us to 4294s, instead of the current
soft limit which just make systat go berserk if you go over it.

Reported and original diff by Nick Gasson nick <at> nickg <dot> me <dot> uk

OK cheloha@
Tweaks and OK bluhm@

Add support for human readable numbers where applicable.

OK stsp@ and bluhm@

pledge() won't work but we can use unveil() to reduce filesystem access
in these 3 related programs (they borrow parts of each other using .PATH)
Hopefully no regressions, ktrace checks by myself and mestre

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

use $OpenBSD markers
ok millert mpi

Add uvm view to show all values being collected in uvmexp.

Feedbacks, tweaks, ok bluhm@

Add the order keyword to systat global command interpreter.
This command shows the available orderings for the current view, which
ordering is active, their shortcuts, and if they're in reverse order.

manpage nits jmc@
OK tedu@

tweak previous; hostname is alredy available plus some better formatting
in case line numbers and/or PAUSED is shown; ok tedu@

add the hostname to the display. started by otto, then deraadt. ok deraadt

garbage collect unsused variable
found by evh -AT- riseup -DOT- net, ok florian@

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Switch the netstat view of systat to use the same kvm_getfiles()
function similar to netstat(1). The output still shows the same
info but may be a bit differently sorted. Also it will now show
connections that are not UDP or TCP. This was the last bit of
systat that needed kvm access and so now systat no longer needs
to be setgid kmem.
With this commit OpenBSD is officially setgid kmem free and an
almost 10 year journey finally comes to an end.
OK deraadt@

first batch of programs adapting to the namespace cleanup
(pfvar.h nameser.h proc.h ucred.h)
ok guenther millert, and some review from doug as well.

Add a new screen "cpu" that simply lists the usage of each CPU core.
Also add a new -B command line flag that works like -b but waits some
cycles before dumping anything to the console.

With much help from jmc@
OK jj@ lambert@ jmc@

Add support to display numbers with thousands separators
and to switch the ifstat view to Bits/s.
This allows us to see live network throughput in units
like MBit/s, which is more practical.
OK sthen@, manpage OK jmc@, "put it in" deraadt@

Make the top line of systat stop updating, along with the rest of the data
when 'p' is pressed.
ok nicm@

Make the terminal checking capability of systat better.
Checks taken from top(1) screen.c/init_termcap()
ok canacar@ sthen@ nicm@

Allow systat to print date and time when in rawmode.
ok canacar@ millert@

Allow systat(1) to resolve names by adding a new -N flag. (The default was
changed some time ago). Noticed by landry@, discussed with canacar@ and others.
ok deraadt@

the rule is not to use nitems() in userland yet

use the nitems() macro where appropriate

ok canacar@

- add two new views to systat, 'nfsserver' and 'nfsclient'.
output is similar to nfsstat(1), but it allows for better monitoring/debugging

tricked into by and "i love this" thib@
ok canacar@

Add malloc and buckets views that display kernel malloc statistics similar
to vmstat -m

Fix some function prototypes, remove unused variables and commented out code

spelling: ambigious -> ambiguous

Add a view that displays pool(9) information. Idea and ok deraadt@

Remove disabled help text code and -S command, both leftovers from pftop,
skip the correct number of bytes after the 'start' command.

Implement start and stop commands as documented,
explicitly pass the command buffer to the command functions.

make ^G display the current view and refresh interval as documented.

-S currently does nothing useful, so remove it from
SYNOPSIS and usage(); after some discussion with canacar

Small step towards fixing documentation:
- sync usage() with reality. Remove the -h option that does nothing.
- don't complain about kvm_openfiles() error in case of incorrect usage.
- add basic descriptions of the new options and views in the manual
page. More is needed...
with help from jmc@ and sobrado@. ok sobrado@.

Do not allow negative or zero delay values from the command line,
use the same check as the -s option. Noticed by johan@

Add ':q' as an alias to ':quit', to match old behaviour. Initial patch
from dlg@, this is a simpler version.

compile on older gcc; no decl after code

Set 'naptime' which is used by the interface page in differential mode.
Also remove a debugging message while there.
reported by claudio@

New display engine for systat, based on pftop. Adds new views for pf
(status, state, rule, queue). While all displays work, some keyboard
comands are not implemented yet. Other features include better handling
of display resize and scrolling for long views. Committing now to fix
the remaining issues in the tree.
Testing and comments by otto@ and harding@, ok deraadt@

fix -Wall warning about unused variable `errstr', which was introduced in the previous revision; ok deraadt, otto, tedu

support non-integral refresh intervals, possibly as low as 0.1s.
this makes it more useful for real time display of fast changing stats
ok art deraadt

use the 1 line load line from 'systat vm' on all the other displays, giving
them more room. much cleaner, and it is less code too; ok deanna

delay time of 0 should be invalid; evol@online.ptt.ru

Improve error message.

Found by Florin Iamandi <florin dot i at tiscali dot it>.

OK tedu@ and deraadt@

fairly simple cleanup, lots of testing done

make these use setres[ug]id for simple privilege dropping;
ok deraadt@ millert@ moritz@

add -n flag (do not reverse-lookup). pb and deraadt ok

wakeup after ^Z did not continue redraws and such. use own ^Z handler.
ok otto millert

- add -w to options description
- document default refresh interval
- sync usage() with SYNOPSIS

inspired by PR 3608;
ok deraadt@

remove old -M and -N; 3608

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

kvm gid revocation earlier

revoke privs after kvm_openfiles

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

move back. pvalchev -- the bug was quite obscure

back out latest changes which cause problems on alpha/sparc64 until
they are fixed

remove unused var

fix signal races. use sysctl() instead of kvm where possible, and then KNF
the hell out of it; checked by miod

kill more registers

millert@ ok

Replace the deprecated BSD sigsetmask/sigblock/sigpause functions with their POSIX counterparts.

handle kvm_nlist() failing, from pr#1798.
Patch similar to the one submitted by <peterw@documenta.com.au>

simple SIGWINCH handler; deals only with window size changes >= 80x24

when getting interrupt, clean up curses only if curses was active

#if __STDC__ --> #ifdef __STDC__

Cleanup by Theo and myself. CMDLINE changed to long to make
command line work on 64bit platforms. This is somewhat bogus
and is really just a temporary workaround (there may be a curses bug).

You can't store a double in an int and then do tests for the fractional part
miss thing! Also, make more sensitive to digital decay. Now "<<<" will
show up in load average display.

getopt(3) returns -1 when out of args, not EOF, whee!

Deal with _POSIX_SAVED_IDS when relinquishing privileges

Clarify usage printout

_POSIX2_LINE_MAX errbuf for kvm_openfiles()

avoid buf oflows

rcsid

libutil

sync to netbsd 960418

branches: 1.1.1;
Initial revision

Add support for human readable numbers where applicable.

OK stsp@ and bluhm@

pledge() won't work but we can use unveil() to reduce filesystem access
in these 3 related programs (they borrow parts of each other using .PATH)
Hopefully no regressions, ktrace checks by myself and mestre

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

use $OpenBSD markers
ok millert mpi

Add uvm view to show all values being collected in uvmexp.

Feedbacks, tweaks, ok bluhm@

Add the order keyword to systat global command interpreter.
This command shows the available orderings for the current view, which
ordering is active, their shortcuts, and if they're in reverse order.

manpage nits jmc@
OK tedu@

tweak previous; hostname is alredy available plus some better formatting
in case line numbers and/or PAUSED is shown; ok tedu@

add the hostname to the display. started by otto, then deraadt. ok deraadt

garbage collect unsused variable
found by evh -AT- riseup -DOT- net, ok florian@

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Switch the netstat view of systat to use the same kvm_getfiles()
function similar to netstat(1). The output still shows the same
info but may be a bit differently sorted. Also it will now show
connections that are not UDP or TCP. This was the last bit of
systat that needed kvm access and so now systat no longer needs
to be setgid kmem.
With this commit OpenBSD is officially setgid kmem free and an
almost 10 year journey finally comes to an end.
OK deraadt@

first batch of programs adapting to the namespace cleanup
(pfvar.h nameser.h proc.h ucred.h)
ok guenther millert, and some review from doug as well.

Add a new screen "cpu" that simply lists the usage of each CPU core.
Also add a new -B command line flag that works like -b but waits some
cycles before dumping anything to the console.

With much help from jmc@
OK jj@ lambert@ jmc@

Add support to display numbers with thousands separators
and to switch the ifstat view to Bits/s.
This allows us to see live network throughput in units
like MBit/s, which is more practical.
OK sthen@, manpage OK jmc@, "put it in" deraadt@

Make the top line of systat stop updating, along with the rest of the data
when 'p' is pressed.
ok nicm@

Make the terminal checking capability of systat better.
Checks taken from top(1) screen.c/init_termcap()
ok canacar@ sthen@ nicm@

Allow systat to print date and time when in rawmode.
ok canacar@ millert@

Allow systat(1) to resolve names by adding a new -N flag. (The default was
changed some time ago). Noticed by landry@, discussed with canacar@ and others.
ok deraadt@

the rule is not to use nitems() in userland yet

use the nitems() macro where appropriate

ok canacar@

- add two new views to systat, 'nfsserver' and 'nfsclient'.
output is similar to nfsstat(1), but it allows for better monitoring/debugging

tricked into by and "i love this" thib@
ok canacar@

Add malloc and buckets views that display kernel malloc statistics similar
to vmstat -m

Fix some function prototypes, remove unused variables and commented out code

spelling: ambigious -> ambiguous

Add a view that displays pool(9) information. Idea and ok deraadt@

Remove disabled help text code and -S command, both leftovers from pftop,
skip the correct number of bytes after the 'start' command.

Implement start and stop commands as documented,
explicitly pass the command buffer to the command functions.

make ^G display the current view and refresh interval as documented.

-S currently does nothing useful, so remove it from
SYNOPSIS and usage(); after some discussion with canacar

Small step towards fixing documentation:
- sync usage() with reality. Remove the -h option that does nothing.
- don't complain about kvm_openfiles() error in case of incorrect usage.
- add basic descriptions of the new options and views in the manual
page. More is needed...
with help from jmc@ and sobrado@. ok sobrado@.

Do not allow negative or zero delay values from the command line,
use the same check as the -s option. Noticed by johan@

Add ':q' as an alias to ':quit', to match old behaviour. Initial patch
from dlg@, this is a simpler version.

compile on older gcc; no decl after code

Set 'naptime' which is used by the interface page in differential mode.
Also remove a debugging message while there.
reported by claudio@

New display engine for systat, based on pftop. Adds new views for pf
(status, state, rule, queue). While all displays work, some keyboard
comands are not implemented yet. Other features include better handling
of display resize and scrolling for long views. Committing now to fix
the remaining issues in the tree.
Testing and comments by otto@ and harding@, ok deraadt@

fix -Wall warning about unused variable `errstr', which was introduced in the previous revision; ok deraadt, otto, tedu

support non-integral refresh intervals, possibly as low as 0.1s.
this makes it more useful for real time display of fast changing stats
ok art deraadt

use the 1 line load line from 'systat vm' on all the other displays, giving
them more room. much cleaner, and it is less code too; ok deanna

delay time of 0 should be invalid; evol@online.ptt.ru

Improve error message.

Found by Florin Iamandi <florin dot i at tiscali dot it>.

OK tedu@ and deraadt@

fairly simple cleanup, lots of testing done

make these use setres[ug]id for simple privilege dropping;
ok deraadt@ millert@ moritz@

add -n flag (do not reverse-lookup). pb and deraadt ok

wakeup after ^Z did not continue redraws and such. use own ^Z handler.
ok otto millert

- add -w to options description
- document default refresh interval
- sync usage() with SYNOPSIS

inspired by PR 3608;
ok deraadt@

remove old -M and -N; 3608

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

kvm gid revocation earlier

revoke privs after kvm_openfiles

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

move back. pvalchev -- the bug was quite obscure

back out latest changes which cause problems on alpha/sparc64 until
they are fixed

remove unused var

fix signal races. use sysctl() instead of kvm where possible, and then KNF
the hell out of it; checked by miod

kill more registers

millert@ ok

Replace the deprecated BSD sigsetmask/sigblock/sigpause functions with their POSIX counterparts.

handle kvm_nlist() failing, from pr#1798.
Patch similar to the one submitted by <peterw@documenta.com.au>

simple SIGWINCH handler; deals only with window size changes >= 80x24

when getting interrupt, clean up curses only if curses was active