rename remote_glob() -> sftp_glob() to match other API

the sftp code was one of my first contributions to OpenSSH and it
shows - the function names are terrible.

Rename do_blah() to sftp_blah() to make them less so.

Completely mechanical except for sftp_stat() and sftp_lstat() which
change from returning a pointer to a static variable (error-prone) to
taking a pointer to a caller-provided receiver.

when scp(1) is using the SFTP protocol for transport (the default),
better match scp/rcp's handling of globs that don't match the globbed
characters but do match literally (e.g. trying to transfer "foo.[1]").

Previously scp(1) in SFTP mode would not match these pathnames but
legacy scp/rcp mode would.

Reported by Michael Yagliyan in bz3488; ok dtucker@

Remove the char * casts from arguments to do_lstat, do_readdir and
do_stat paths since the underlying functions now take a const char *.
Patch from vapier at gentoo.org.

stdarg.h required more broadly; ok djm

remove some duplicate #includes

update sftp client and server to new buffer API.
pretty much just mechanical changes; with & ok markus

Include stdlib.h for free() as per the man page.

use calloc for all structure allocations; from markus@

branches: 1.24.2;
bye, bye xfree(); ok markus@

branches: 1.23.6;
silence error spam for "ls */foo" in directory with files; bz#1683

almost entirely get rid of the culture of ".h files that include .h files"
ok djm, sort of ok stevesk
makes the pain stop in one easy step

move #include <string.h> out of includes.h

buffer.h only needed in sftp-common.h and remove some unneeded
user includes; ok djm@

Put $OpenBSD$ tags back (as comments) to replace the RCSID()s that
Theo nuked - our scripts to sync -portable need them in the files

RCSID() can die

branches: 1.17.2;
move #include <sys/stat.h> out of includes.h; ok markus@

move #include <dirent.h> out of includes.h; ok markus@

branches: 1.15.8;
Remove useless headers; ok deraadt@

switch to license.template for code written by me (belated, I know...)

branches: 1.13.4; 1.13.6;
support for short/long listings and globbing in "ls"; ok markus@

patch memory leaks; grendel@zeitbombe.org

minor KNF

branches: 1.10.2;
API cleanup and backwards compat for filexfer v.0 servers; ok markus@

basic KNF done while i was looking for something else

branches: 1.8.2;
delete spurious #includes; ok deraadt@ markus@

Directly cast to the right type. Ok markus@

more strict prototypes. raise warning level in Makefile.inc. markus ok'ed
TODO; cleanup headers

branches: 1.5.2;
some unused variable and typos; from tomh@po.crl.go.jp

fix whitespace: unexpand + trailing spaces.

free() -> xfree()

branches: 1.2.2; 1.2.4;
Revise globbing for get/put to be more shell-like. In particular,
"get/put file* directory/" now works. ok markus@

sftp client filename globbing for get, put, ch{mod,grp,own}. ok markus@

the sftp code was one of my first contributions to OpenSSH and it
shows - the function names are terrible.

Rename do_blah() to sftp_blah() to make them less so.

Completely mechanical except for sftp_stat() and sftp_lstat() which
change from returning a pointer to a static variable (error-prone) to
taking a pointer to a caller-provided receiver.

when scp(1) is using the SFTP protocol for transport (the default),
better match scp/rcp's handling of globs that don't match the globbed
characters but do match literally (e.g. trying to transfer "foo.[1]").

Previously scp(1) in SFTP mode would not match these pathnames but
legacy scp/rcp mode would.

Reported by Michael Yagliyan in bz3488; ok dtucker@

Remove the char * casts from arguments to do_lstat, do_readdir and
do_stat paths since the underlying functions now take a const char *.
Patch from vapier at gentoo.org.

stdarg.h required more broadly; ok djm

remove some duplicate #includes

update sftp client and server to new buffer API.
pretty much just mechanical changes; with & ok markus

Include stdlib.h for free() as per the man page.

use calloc for all structure allocations; from markus@

branches: 1.24.2;
bye, bye xfree(); ok markus@

branches: 1.23.6;
silence error spam for "ls */foo" in directory with files; bz#1683

almost entirely get rid of the culture of ".h files that include .h files"
ok djm, sort of ok stevesk
makes the pain stop in one easy step

move #include <string.h> out of includes.h

buffer.h only needed in sftp-common.h and remove some unneeded
user includes; ok djm@

Put $OpenBSD$ tags back (as comments) to replace the RCSID()s that
Theo nuked - our scripts to sync -portable need them in the files

RCSID() can die

branches: 1.17.2;
move #include <sys/stat.h> out of includes.h; ok markus@

move #include <dirent.h> out of includes.h; ok markus@

branches: 1.15.8;
Remove useless headers; ok deraadt@

switch to license.template for code written by me (belated, I know...)

branches: 1.13.4; 1.13.6;
support for short/long listings and globbing in "ls"; ok markus@

patch memory leaks; grendel@zeitbombe.org

minor KNF

branches: 1.10.2;
API cleanup and backwards compat for filexfer v.0 servers; ok markus@

basic KNF done while i was looking for something else

branches: 1.8.2;
delete spurious #includes; ok deraadt@ markus@

Directly cast to the right type. Ok markus@

more strict prototypes. raise warning level in Makefile.inc. markus ok'ed
TODO; cleanup headers

branches: 1.5.2;
some unused variable and typos; from tomh@po.crl.go.jp

fix whitespace: unexpand + trailing spaces.

free() -> xfree()

branches: 1.2.2; 1.2.4;
Revise globbing for get/put to be more shell-like. In particular,
"get/put file* directory/" now works. ok markus@

sftp client filename globbing for get, put, ch{mod,grp,own}. ok markus@

when scp(1) is using the SFTP protocol for transport (the default),
better match scp/rcp's handling of globs that don't match the globbed
characters but do match literally (e.g. trying to transfer "foo.[1]").

Previously scp(1) in SFTP mode would not match these pathnames but
legacy scp/rcp mode would.

Reported by Michael Yagliyan in bz3488; ok dtucker@

Remove the char * casts from arguments to do_lstat, do_readdir and
do_stat paths since the underlying functions now take a const char *.
Patch from vapier at gentoo.org.

stdarg.h required more broadly; ok djm

remove some duplicate #includes

update sftp client and server to new buffer API.
pretty much just mechanical changes; with & ok markus

Include stdlib.h for free() as per the man page.

use calloc for all structure allocations; from markus@

branches: 1.24.2;
bye, bye xfree(); ok markus@

branches: 1.23.6;
silence error spam for "ls */foo" in directory with files; bz#1683

almost entirely get rid of the culture of ".h files that include .h files"
ok djm, sort of ok stevesk
makes the pain stop in one easy step

move #include <string.h> out of includes.h

buffer.h only needed in sftp-common.h and remove some unneeded
user includes; ok djm@

Put $OpenBSD$ tags back (as comments) to replace the RCSID()s that
Theo nuked - our scripts to sync -portable need them in the files

RCSID() can die

branches: 1.17.2;
move #include <sys/stat.h> out of includes.h; ok markus@

move #include <dirent.h> out of includes.h; ok markus@

branches: 1.15.8;
Remove useless headers; ok deraadt@

switch to license.template for code written by me (belated, I know...)

branches: 1.13.4; 1.13.6;
support for short/long listings and globbing in "ls"; ok markus@

patch memory leaks; grendel@zeitbombe.org

minor KNF

branches: 1.10.2;
API cleanup and backwards compat for filexfer v.0 servers; ok markus@

basic KNF done while i was looking for something else

branches: 1.8.2;
delete spurious #includes; ok deraadt@ markus@

Directly cast to the right type. Ok markus@

more strict prototypes. raise warning level in Makefile.inc. markus ok'ed
TODO; cleanup headers

branches: 1.5.2;
some unused variable and typos; from tomh@po.crl.go.jp

fix whitespace: unexpand + trailing spaces.

free() -> xfree()

branches: 1.2.2; 1.2.4;
Revise globbing for get/put to be more shell-like. In particular,
"get/put file* directory/" now works. ok markus@

sftp client filename globbing for get, put, ch{mod,grp,own}. ok markus@

Remove the char * casts from arguments to do_lstat, do_readdir and
do_stat paths since the underlying functions now take a const char *.
Patch from vapier at gentoo.org.

stdarg.h required more broadly; ok djm

remove some duplicate #includes

update sftp client and server to new buffer API.
pretty much just mechanical changes; with & ok markus

Include stdlib.h for free() as per the man page.

use calloc for all structure allocations; from markus@

branches: 1.24.2;
bye, bye xfree(); ok markus@

branches: 1.23.6;
silence error spam for "ls */foo" in directory with files; bz#1683

almost entirely get rid of the culture of ".h files that include .h files"
ok djm, sort of ok stevesk
makes the pain stop in one easy step

move #include <string.h> out of includes.h

buffer.h only needed in sftp-common.h and remove some unneeded
user includes; ok djm@

Put $OpenBSD$ tags back (as comments) to replace the RCSID()s that
Theo nuked - our scripts to sync -portable need them in the files

RCSID() can die

branches: 1.17.2;
move #include <sys/stat.h> out of includes.h; ok markus@

move #include <dirent.h> out of includes.h; ok markus@

branches: 1.15.8;
Remove useless headers; ok deraadt@

switch to license.template for code written by me (belated, I know...)

branches: 1.13.4; 1.13.6;
support for short/long listings and globbing in "ls"; ok markus@

patch memory leaks; grendel@zeitbombe.org

minor KNF

branches: 1.10.2;
API cleanup and backwards compat for filexfer v.0 servers; ok markus@

basic KNF done while i was looking for something else

branches: 1.8.2;
delete spurious #includes; ok deraadt@ markus@

Directly cast to the right type. Ok markus@

more strict prototypes. raise warning level in Makefile.inc. markus ok'ed
TODO; cleanup headers

branches: 1.5.2;
some unused variable and typos; from tomh@po.crl.go.jp

fix whitespace: unexpand + trailing spaces.

free() -> xfree()

branches: 1.2.2; 1.2.4;
Revise globbing for get/put to be more shell-like. In particular,
"get/put file* directory/" now works. ok markus@

sftp client filename globbing for get, put, ch{mod,grp,own}. ok markus@

stdarg.h required more broadly; ok djm

remove some duplicate #includes

update sftp client and server to new buffer API.
pretty much just mechanical changes; with & ok markus

Include stdlib.h for free() as per the man page.

use calloc for all structure allocations; from markus@

branches: 1.24.2;
bye, bye xfree(); ok markus@

branches: 1.23.6;
silence error spam for "ls */foo" in directory with files; bz#1683

almost entirely get rid of the culture of ".h files that include .h files"
ok djm, sort of ok stevesk
makes the pain stop in one easy step

move #include <string.h> out of includes.h

buffer.h only needed in sftp-common.h and remove some unneeded
user includes; ok djm@

Put $OpenBSD$ tags back (as comments) to replace the RCSID()s that
Theo nuked - our scripts to sync -portable need them in the files

RCSID() can die

branches: 1.17.2;
move #include <sys/stat.h> out of includes.h; ok markus@

move #include <dirent.h> out of includes.h; ok markus@

branches: 1.15.8;
Remove useless headers; ok deraadt@

switch to license.template for code written by me (belated, I know...)

branches: 1.13.4; 1.13.6;
support for short/long listings and globbing in "ls"; ok markus@

patch memory leaks; grendel@zeitbombe.org

minor KNF

branches: 1.10.2;
API cleanup and backwards compat for filexfer v.0 servers; ok markus@

basic KNF done while i was looking for something else

branches: 1.8.2;
delete spurious #includes; ok deraadt@ markus@

Directly cast to the right type. Ok markus@

more strict prototypes. raise warning level in Makefile.inc. markus ok'ed
TODO; cleanup headers

branches: 1.5.2;
some unused variable and typos; from tomh@po.crl.go.jp

fix whitespace: unexpand + trailing spaces.

free() -> xfree()

branches: 1.2.2; 1.2.4;
Revise globbing for get/put to be more shell-like. In particular,
"get/put file* directory/" now works. ok markus@

sftp client filename globbing for get, put, ch{mod,grp,own}. ok markus@

remove some duplicate #includes

update sftp client and server to new buffer API.
pretty much just mechanical changes; with & ok markus

Include stdlib.h for free() as per the man page.

use calloc for all structure allocations; from markus@

branches: 1.24.2;
bye, bye xfree(); ok markus@

branches: 1.23.6;
silence error spam for "ls */foo" in directory with files; bz#1683

almost entirely get rid of the culture of ".h files that include .h files"
ok djm, sort of ok stevesk
makes the pain stop in one easy step

move #include <string.h> out of includes.h

buffer.h only needed in sftp-common.h and remove some unneeded
user includes; ok djm@

Put $OpenBSD$ tags back (as comments) to replace the RCSID()s that
Theo nuked - our scripts to sync -portable need them in the files

RCSID() can die

branches: 1.17.2;
move #include <sys/stat.h> out of includes.h; ok markus@

move #include <dirent.h> out of includes.h; ok markus@

branches: 1.15.8;
Remove useless headers; ok deraadt@

switch to license.template for code written by me (belated, I know...)

branches: 1.13.4; 1.13.6;
support for short/long listings and globbing in "ls"; ok markus@

patch memory leaks; grendel@zeitbombe.org

minor KNF

branches: 1.10.2;
API cleanup and backwards compat for filexfer v.0 servers; ok markus@

basic KNF done while i was looking for something else

branches: 1.8.2;
delete spurious #includes; ok deraadt@ markus@

Directly cast to the right type. Ok markus@

more strict prototypes. raise warning level in Makefile.inc. markus ok'ed
TODO; cleanup headers

branches: 1.5.2;
some unused variable and typos; from tomh@po.crl.go.jp

fix whitespace: unexpand + trailing spaces.

free() -> xfree()

branches: 1.2.2; 1.2.4;
Revise globbing for get/put to be more shell-like. In particular,
"get/put file* directory/" now works. ok markus@

sftp client filename globbing for get, put, ch{mod,grp,own}. ok markus@

update sftp client and server to new buffer API.
pretty much just mechanical changes; with & ok markus

Include stdlib.h for free() as per the man page.

use calloc for all structure allocations; from markus@

branches: 1.24.2;
bye, bye xfree(); ok markus@

branches: 1.23.6;
silence error spam for "ls */foo" in directory with files; bz#1683

almost entirely get rid of the culture of ".h files that include .h files"
ok djm, sort of ok stevesk
makes the pain stop in one easy step

move #include <string.h> out of includes.h

buffer.h only needed in sftp-common.h and remove some unneeded
user includes; ok djm@

Put $OpenBSD$ tags back (as comments) to replace the RCSID()s that
Theo nuked - our scripts to sync -portable need them in the files

RCSID() can die

branches: 1.17.2;
move #include <sys/stat.h> out of includes.h; ok markus@

move #include <dirent.h> out of includes.h; ok markus@

branches: 1.15.8;
Remove useless headers; ok deraadt@

switch to license.template for code written by me (belated, I know...)

branches: 1.13.4; 1.13.6;
support for short/long listings and globbing in "ls"; ok markus@

patch memory leaks; grendel@zeitbombe.org

minor KNF

branches: 1.10.2;
API cleanup and backwards compat for filexfer v.0 servers; ok markus@

basic KNF done while i was looking for something else

branches: 1.8.2;
delete spurious #includes; ok deraadt@ markus@

Directly cast to the right type. Ok markus@

more strict prototypes. raise warning level in Makefile.inc. markus ok'ed
TODO; cleanup headers

branches: 1.5.2;
some unused variable and typos; from tomh@po.crl.go.jp

fix whitespace: unexpand + trailing spaces.

free() -> xfree()

branches: 1.2.2; 1.2.4;
Revise globbing for get/put to be more shell-like. In particular,
"get/put file* directory/" now works. ok markus@

sftp client filename globbing for get, put, ch{mod,grp,own}. ok markus@