Stop using MAXBSIZE to eliminate sys/param.h including (which injects a
ton of namespace intrusion). Create local sizes, and refactor some code
along the way.
ok millert

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Remove use of sysexits.h.

Change all tame callers to namechange to pledge(2).

tame "stdio rpath wpath cpath" to support use of freopen() with "w"

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

an usage message should fit on a 80-column display

ok jmc@

handle empty strings returned by fgets

ok ray@

The rewritten newfile() algorithm introduced in rev 1.12 was
incorrect. This simpler version from Pete Honeyman passes all the
tests I thow at it. OK deraadt@ some time ago.

Check for int oflow w/ -b option and unit suffixes, make usage() __dead,
use ssize_t not long for read/write length. OK beck@

Add -a option as per single unix. Rewrote the code to generate
file names to be less blecherous, though it is still not pretty.
OK beck@, with man page help from jmc@

- indicate that -b, -l, and -p are mutually exclusive
- tidy up the text somewhat
- make it clear that the original file is not changed

mostly this is based on a freebsd pr (33852),
submitted by gary w. swearingen

split.1:
add the relevant arguments to the options synopsis for -b and -l;
tidy up the formatting of [-b byte_count[k|m]];
make SYNOPSIS arg for -l match its description;

split.c:
sync usage();

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

GNU semantics say that if optstring begins with '-' then
each non-option shall be treated as arguments to option '\1'.

BSD getopt match '-' in optstring with a '-' on the command line.
This is used to support deprecated options like "su -" that would
otherwise prevent the use of getopt().

Resolving this simply requires that the leading '-' be moved somewhere
else (I moved it to the end of optstring) since position within
optstring is not meaningful.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

oflow

From FreeBSD:
Add new option '-p pattern' for splitting files based on matching
lines in the file with a regular expression. Useful for e.g.
'cvs diff' output. Also compile cleanly with -Wall and use
defines from <sysexits.h>.

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Remove use of sysexits.h.

Change all tame callers to namechange to pledge(2).

tame "stdio rpath wpath cpath" to support use of freopen() with "w"

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

an usage message should fit on a 80-column display

ok jmc@

handle empty strings returned by fgets

ok ray@

The rewritten newfile() algorithm introduced in rev 1.12 was
incorrect. This simpler version from Pete Honeyman passes all the
tests I thow at it. OK deraadt@ some time ago.

Check for int oflow w/ -b option and unit suffixes, make usage() __dead,
use ssize_t not long for read/write length. OK beck@

Add -a option as per single unix. Rewrote the code to generate
file names to be less blecherous, though it is still not pretty.
OK beck@, with man page help from jmc@

- indicate that -b, -l, and -p are mutually exclusive
- tidy up the text somewhat
- make it clear that the original file is not changed

mostly this is based on a freebsd pr (33852),
submitted by gary w. swearingen

split.1:
add the relevant arguments to the options synopsis for -b and -l;
tidy up the formatting of [-b byte_count[k|m]];
make SYNOPSIS arg for -l match its description;

split.c:
sync usage();

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

GNU semantics say that if optstring begins with '-' then
each non-option shall be treated as arguments to option '\1'.

BSD getopt match '-' in optstring with a '-' on the command line.
This is used to support deprecated options like "su -" that would
otherwise prevent the use of getopt().

Resolving this simply requires that the leading '-' be moved somewhere
else (I moved it to the end of optstring) since position within
optstring is not meaningful.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

oflow

From FreeBSD:
Add new option '-p pattern' for splitting files based on matching
lines in the file with a regular expression. Useful for e.g.
'cvs diff' output. Also compile cleanly with -Wall and use
defines from <sysexits.h>.

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

Remove use of sysexits.h.

Change all tame callers to namechange to pledge(2).

tame "stdio rpath wpath cpath" to support use of freopen() with "w"

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

an usage message should fit on a 80-column display

ok jmc@

handle empty strings returned by fgets

ok ray@

The rewritten newfile() algorithm introduced in rev 1.12 was
incorrect. This simpler version from Pete Honeyman passes all the
tests I thow at it. OK deraadt@ some time ago.

Check for int oflow w/ -b option and unit suffixes, make usage() __dead,
use ssize_t not long for read/write length. OK beck@

Add -a option as per single unix. Rewrote the code to generate
file names to be less blecherous, though it is still not pretty.
OK beck@, with man page help from jmc@

- indicate that -b, -l, and -p are mutually exclusive
- tidy up the text somewhat
- make it clear that the original file is not changed

mostly this is based on a freebsd pr (33852),
submitted by gary w. swearingen

split.1:
add the relevant arguments to the options synopsis for -b and -l;
tidy up the formatting of [-b byte_count[k|m]];
make SYNOPSIS arg for -l match its description;

split.c:
sync usage();

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

GNU semantics say that if optstring begins with '-' then
each non-option shall be treated as arguments to option '\1'.

BSD getopt match '-' in optstring with a '-' on the command line.
This is used to support deprecated options like "su -" that would
otherwise prevent the use of getopt().

Resolving this simply requires that the leading '-' be moved somewhere
else (I moved it to the end of optstring) since position within
optstring is not meaningful.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

oflow

From FreeBSD:
Add new option '-p pattern' for splitting files based on matching
lines in the file with a regular expression. Useful for e.g.
'cvs diff' output. Also compile cleanly with -Wall and use
defines from <sysexits.h>.

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision