spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

When it's the possessive of 'it', it's spelled "its", without the
apostrophe.

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

mkstemp() returns -1 on failure

Use password/group cache functions and avoid stashing a pointer to
the return value of getgrgid(3) or getgrnam(3) which relies on
undefined behavior. The rdist server will now use getgroups(2) to
determine group membership of the invoking user. In addition, there
is now one implementation of tilde expansion instead of two.
OK tb@ tim@

Fix a crash in rdistd triggered by the recent getpw{ent,nam,uid}
changes. This stems from rdist stashing a pointer to the static
area used by getpw{ent,nam,uid} and using it to avoid repeating
passwd lookups when pw->pw_name matches the user to be looked up.

This relied on undefined behavior, and with the recent passwd
changes, is no longer possible as the old pointer will be invalidated.
A better approach is to use the upcoming uid_from_user(3) functions.
Found by and fix OK tim@

gid_t is unsigned, so < 0 test is always false, compare against (gid_t)-1
explicitly; ok millert@

Avoid compiler warning about zero-length printf format strings.
Allow a NULL format in message() and switch the two calls to
error() and message() with an empty format string to using NULL.
OK deraadt@

The change to make mkstemp(3) require at least 6 trailing Xs broke
rdistd for directories that do not exist on the destination. Calling
mkstemp(3) twice with the same format (filled in by the first
mkstemp(3) call) is bogus so call chkparent() *before* mkstemp(3)
instead of only on error. This costs an extra lstat(2) in the case
where the directory already exists but simplifies the code and
doesn't rely on undefined behavior (namely, the state of the template
when mkstemp fails). OK tim@

remove needless allocation casts

Remove a couple needless allocation casts. No binary change.

Switch to linkat() to support hardlinked symlinks
Simplify chown logic by using fchownat()
Cache whether we're root instead of calling getuid() before each chown

Assume NFS_CHECK and RO_CHECK are defined.
We only need the dev_t and not the entire struct stat in mntinfo.
Delete some superfluous casts.

Reduce opt_t from long to int.
Debug message consistency: format opts with %#x and modes with %#04o

Split out from rdist/defs.h the client-only and server-only bits into
rdist/client.h and rdistd/server.h
Only put #includes in .h files that are necessary for the .h to be used;
all other #includes go in the .c files
Move all extern variable declarations to the .h files, renaming local
variables to avoid shadowing
Replace me_type member of mntent_t with an "is NFS?" flag bit

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Rename 'link' parameter to eliminate shadow warnings

Yes, we have setproctitle(). Delete that and several unused HAVE_* #defines

Assume POSIX: S_IFSOCK and S_IFIFO
Kill some 'notyet' code that will never be enabled

Assume POSIX: lchown(), fchown(), fchmod(), fchmodat()
Assume we have rcmdsh()

Assume POSIX: uid_t and gid_t
Add parens to quiet gcc on previous commit

Assume POSIX: <dirent.h>, struct dirent

Oops, fix both locations using D_NAMLEN()

Stop using silly macro when checking for '.' and '..' directory entries

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

remove casts to time_t * which are not needed

Fix various format string issues. Stop assuming time_t is long or smaller.
Enable warnings.

ok krw@, ian@

Apply some tough type-love and give rdist a chance to handle files
larger than 2GB. Diff from Stephan R. Gerber via PR#6586, tweaks
by me.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

pathnames with space, tab, newline, etc are encoded before being sent.
But they were not reliably being decoded, resulting in wrong naming
on the target machine. diff from Tim van der Molen

Fix breakage introduced in rev 1.8 wrt rdisting symlinks. Push the
mkstemp() down into recvfile() and use mktemp() for recvlink().
OK okan@

Change a mktemp(3) to mkstemp(3), preventing a race condition.
Improve error checking.

OK okan@

double semicolon; from Daniel Matic in PR 4929

fix readlink() usage.

millert@ ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

o Sync w/ freerdist 0.92 minus the compress option
o KNF and ANSIfy the function headers

Sparse file support is currently a no-op since it didn't work.
Proper sparse file support will be added later.

strcpy/strcat/sprintf removal; krw@ OK

more POSIX chown

strings; ok miod ho krw

kill more registers

millert@ ok

occured->occurred

idea from deraadt@ via NetBSD
millert@ ok

p.s. Next commit will fix a typo in the sys/

Fix a serious memory consumption problem when running over directories
that contain many hard-linked files; johnh@isi.edu
Also add an xstrdup() that behaves like xmalloc() on failure.

rdist 6.1.4 + OpenBSD patches + some -Wall

readlink len-1

Updated to rdist 6.1.3. Used real snprintf() (instead of string length
in the format) since we have it.

rcsid

open O_EXCL instead of creat; for writable rdist directories... still small DOS

rdist 6.1.2

rdist 6.1.1

When it's the possessive of 'it', it's spelled "its", without the
apostrophe.

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

mkstemp() returns -1 on failure

Use password/group cache functions and avoid stashing a pointer to
the return value of getgrgid(3) or getgrnam(3) which relies on
undefined behavior. The rdist server will now use getgroups(2) to
determine group membership of the invoking user. In addition, there
is now one implementation of tilde expansion instead of two.
OK tb@ tim@

Fix a crash in rdistd triggered by the recent getpw{ent,nam,uid}
changes. This stems from rdist stashing a pointer to the static
area used by getpw{ent,nam,uid} and using it to avoid repeating
passwd lookups when pw->pw_name matches the user to be looked up.

This relied on undefined behavior, and with the recent passwd
changes, is no longer possible as the old pointer will be invalidated.
A better approach is to use the upcoming uid_from_user(3) functions.
Found by and fix OK tim@

gid_t is unsigned, so < 0 test is always false, compare against (gid_t)-1
explicitly; ok millert@

Avoid compiler warning about zero-length printf format strings.
Allow a NULL format in message() and switch the two calls to
error() and message() with an empty format string to using NULL.
OK deraadt@

The change to make mkstemp(3) require at least 6 trailing Xs broke
rdistd for directories that do not exist on the destination. Calling
mkstemp(3) twice with the same format (filled in by the first
mkstemp(3) call) is bogus so call chkparent() *before* mkstemp(3)
instead of only on error. This costs an extra lstat(2) in the case
where the directory already exists but simplifies the code and
doesn't rely on undefined behavior (namely, the state of the template
when mkstemp fails). OK tim@

remove needless allocation casts

Remove a couple needless allocation casts. No binary change.

Switch to linkat() to support hardlinked symlinks
Simplify chown logic by using fchownat()
Cache whether we're root instead of calling getuid() before each chown

Assume NFS_CHECK and RO_CHECK are defined.
We only need the dev_t and not the entire struct stat in mntinfo.
Delete some superfluous casts.

Reduce opt_t from long to int.
Debug message consistency: format opts with %#x and modes with %#04o

Split out from rdist/defs.h the client-only and server-only bits into
rdist/client.h and rdistd/server.h
Only put #includes in .h files that are necessary for the .h to be used;
all other #includes go in the .c files
Move all extern variable declarations to the .h files, renaming local
variables to avoid shadowing
Replace me_type member of mntent_t with an "is NFS?" flag bit

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Rename 'link' parameter to eliminate shadow warnings

Yes, we have setproctitle(). Delete that and several unused HAVE_* #defines

Assume POSIX: S_IFSOCK and S_IFIFO
Kill some 'notyet' code that will never be enabled

Assume POSIX: lchown(), fchown(), fchmod(), fchmodat()
Assume we have rcmdsh()

Assume POSIX: uid_t and gid_t
Add parens to quiet gcc on previous commit

Assume POSIX: <dirent.h>, struct dirent

Oops, fix both locations using D_NAMLEN()

Stop using silly macro when checking for '.' and '..' directory entries

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

remove casts to time_t * which are not needed

Fix various format string issues. Stop assuming time_t is long or smaller.
Enable warnings.

ok krw@, ian@

Apply some tough type-love and give rdist a chance to handle files
larger than 2GB. Diff from Stephan R. Gerber via PR#6586, tweaks
by me.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

pathnames with space, tab, newline, etc are encoded before being sent.
But they were not reliably being decoded, resulting in wrong naming
on the target machine. diff from Tim van der Molen

Fix breakage introduced in rev 1.8 wrt rdisting symlinks. Push the
mkstemp() down into recvfile() and use mktemp() for recvlink().
OK okan@

Change a mktemp(3) to mkstemp(3), preventing a race condition.
Improve error checking.

OK okan@

double semicolon; from Daniel Matic in PR 4929

fix readlink() usage.

millert@ ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

o Sync w/ freerdist 0.92 minus the compress option
o KNF and ANSIfy the function headers

Sparse file support is currently a no-op since it didn't work.
Proper sparse file support will be added later.

strcpy/strcat/sprintf removal; krw@ OK

more POSIX chown

strings; ok miod ho krw

kill more registers

millert@ ok

occured->occurred

idea from deraadt@ via NetBSD
millert@ ok

p.s. Next commit will fix a typo in the sys/

Fix a serious memory consumption problem when running over directories
that contain many hard-linked files; johnh@isi.edu
Also add an xstrdup() that behaves like xmalloc() on failure.

rdist 6.1.4 + OpenBSD patches + some -Wall

readlink len-1

Updated to rdist 6.1.3. Used real snprintf() (instead of string length
in the format) since we have it.

rcsid

open O_EXCL instead of creat; for writable rdist directories... still small DOS

rdist 6.1.2

rdist 6.1.1

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

mkstemp() returns -1 on failure

Use password/group cache functions and avoid stashing a pointer to
the return value of getgrgid(3) or getgrnam(3) which relies on
undefined behavior. The rdist server will now use getgroups(2) to
determine group membership of the invoking user. In addition, there
is now one implementation of tilde expansion instead of two.
OK tb@ tim@

Fix a crash in rdistd triggered by the recent getpw{ent,nam,uid}
changes. This stems from rdist stashing a pointer to the static
area used by getpw{ent,nam,uid} and using it to avoid repeating
passwd lookups when pw->pw_name matches the user to be looked up.

This relied on undefined behavior, and with the recent passwd
changes, is no longer possible as the old pointer will be invalidated.
A better approach is to use the upcoming uid_from_user(3) functions.
Found by and fix OK tim@

gid_t is unsigned, so < 0 test is always false, compare against (gid_t)-1
explicitly; ok millert@

Avoid compiler warning about zero-length printf format strings.
Allow a NULL format in message() and switch the two calls to
error() and message() with an empty format string to using NULL.
OK deraadt@

The change to make mkstemp(3) require at least 6 trailing Xs broke
rdistd for directories that do not exist on the destination. Calling
mkstemp(3) twice with the same format (filled in by the first
mkstemp(3) call) is bogus so call chkparent() *before* mkstemp(3)
instead of only on error. This costs an extra lstat(2) in the case
where the directory already exists but simplifies the code and
doesn't rely on undefined behavior (namely, the state of the template
when mkstemp fails). OK tim@

remove needless allocation casts

Remove a couple needless allocation casts. No binary change.

Switch to linkat() to support hardlinked symlinks
Simplify chown logic by using fchownat()
Cache whether we're root instead of calling getuid() before each chown

Assume NFS_CHECK and RO_CHECK are defined.
We only need the dev_t and not the entire struct stat in mntinfo.
Delete some superfluous casts.

Reduce opt_t from long to int.
Debug message consistency: format opts with %#x and modes with %#04o

Split out from rdist/defs.h the client-only and server-only bits into
rdist/client.h and rdistd/server.h
Only put #includes in .h files that are necessary for the .h to be used;
all other #includes go in the .c files
Move all extern variable declarations to the .h files, renaming local
variables to avoid shadowing
Replace me_type member of mntent_t with an "is NFS?" flag bit

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Rename 'link' parameter to eliminate shadow warnings

Yes, we have setproctitle(). Delete that and several unused HAVE_* #defines

Assume POSIX: S_IFSOCK and S_IFIFO
Kill some 'notyet' code that will never be enabled

Assume POSIX: lchown(), fchown(), fchmod(), fchmodat()
Assume we have rcmdsh()

Assume POSIX: uid_t and gid_t
Add parens to quiet gcc on previous commit

Assume POSIX: <dirent.h>, struct dirent

Oops, fix both locations using D_NAMLEN()

Stop using silly macro when checking for '.' and '..' directory entries

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

remove casts to time_t * which are not needed

Fix various format string issues. Stop assuming time_t is long or smaller.
Enable warnings.

ok krw@, ian@

Apply some tough type-love and give rdist a chance to handle files
larger than 2GB. Diff from Stephan R. Gerber via PR#6586, tweaks
by me.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

pathnames with space, tab, newline, etc are encoded before being sent.
But they were not reliably being decoded, resulting in wrong naming
on the target machine. diff from Tim van der Molen

Fix breakage introduced in rev 1.8 wrt rdisting symlinks. Push the
mkstemp() down into recvfile() and use mktemp() for recvlink().
OK okan@

Change a mktemp(3) to mkstemp(3), preventing a race condition.
Improve error checking.

OK okan@

double semicolon; from Daniel Matic in PR 4929

fix readlink() usage.

millert@ ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

o Sync w/ freerdist 0.92 minus the compress option
o KNF and ANSIfy the function headers

Sparse file support is currently a no-op since it didn't work.
Proper sparse file support will be added later.

strcpy/strcat/sprintf removal; krw@ OK

more POSIX chown

strings; ok miod ho krw

kill more registers

millert@ ok

occured->occurred

idea from deraadt@ via NetBSD
millert@ ok

p.s. Next commit will fix a typo in the sys/

Fix a serious memory consumption problem when running over directories
that contain many hard-linked files; johnh@isi.edu
Also add an xstrdup() that behaves like xmalloc() on failure.

rdist 6.1.4 + OpenBSD patches + some -Wall

readlink len-1

Updated to rdist 6.1.3. Used real snprintf() (instead of string length
in the format) since we have it.

rcsid

open O_EXCL instead of creat; for writable rdist directories... still small DOS

rdist 6.1.2

rdist 6.1.1

mkstemp() returns -1 on failure

Use password/group cache functions and avoid stashing a pointer to
the return value of getgrgid(3) or getgrnam(3) which relies on
undefined behavior. The rdist server will now use getgroups(2) to
determine group membership of the invoking user. In addition, there
is now one implementation of tilde expansion instead of two.
OK tb@ tim@

Fix a crash in rdistd triggered by the recent getpw{ent,nam,uid}
changes. This stems from rdist stashing a pointer to the static
area used by getpw{ent,nam,uid} and using it to avoid repeating
passwd lookups when pw->pw_name matches the user to be looked up.

This relied on undefined behavior, and with the recent passwd
changes, is no longer possible as the old pointer will be invalidated.
A better approach is to use the upcoming uid_from_user(3) functions.
Found by and fix OK tim@

gid_t is unsigned, so < 0 test is always false, compare against (gid_t)-1
explicitly; ok millert@

Avoid compiler warning about zero-length printf format strings.
Allow a NULL format in message() and switch the two calls to
error() and message() with an empty format string to using NULL.
OK deraadt@

The change to make mkstemp(3) require at least 6 trailing Xs broke
rdistd for directories that do not exist on the destination. Calling
mkstemp(3) twice with the same format (filled in by the first
mkstemp(3) call) is bogus so call chkparent() *before* mkstemp(3)
instead of only on error. This costs an extra lstat(2) in the case
where the directory already exists but simplifies the code and
doesn't rely on undefined behavior (namely, the state of the template
when mkstemp fails). OK tim@

remove needless allocation casts

Remove a couple needless allocation casts. No binary change.

Switch to linkat() to support hardlinked symlinks
Simplify chown logic by using fchownat()
Cache whether we're root instead of calling getuid() before each chown

Assume NFS_CHECK and RO_CHECK are defined.
We only need the dev_t and not the entire struct stat in mntinfo.
Delete some superfluous casts.

Reduce opt_t from long to int.
Debug message consistency: format opts with %#x and modes with %#04o

Split out from rdist/defs.h the client-only and server-only bits into
rdist/client.h and rdistd/server.h
Only put #includes in .h files that are necessary for the .h to be used;
all other #includes go in the .c files
Move all extern variable declarations to the .h files, renaming local
variables to avoid shadowing
Replace me_type member of mntent_t with an "is NFS?" flag bit

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Rename 'link' parameter to eliminate shadow warnings

Yes, we have setproctitle(). Delete that and several unused HAVE_* #defines

Assume POSIX: S_IFSOCK and S_IFIFO
Kill some 'notyet' code that will never be enabled

Assume POSIX: lchown(), fchown(), fchmod(), fchmodat()
Assume we have rcmdsh()

Assume POSIX: uid_t and gid_t
Add parens to quiet gcc on previous commit

Assume POSIX: <dirent.h>, struct dirent

Oops, fix both locations using D_NAMLEN()

Stop using silly macro when checking for '.' and '..' directory entries

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

remove casts to time_t * which are not needed

Fix various format string issues. Stop assuming time_t is long or smaller.
Enable warnings.

ok krw@, ian@

Apply some tough type-love and give rdist a chance to handle files
larger than 2GB. Diff from Stephan R. Gerber via PR#6586, tweaks
by me.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

pathnames with space, tab, newline, etc are encoded before being sent.
But they were not reliably being decoded, resulting in wrong naming
on the target machine. diff from Tim van der Molen

Fix breakage introduced in rev 1.8 wrt rdisting symlinks. Push the
mkstemp() down into recvfile() and use mktemp() for recvlink().
OK okan@

Change a mktemp(3) to mkstemp(3), preventing a race condition.
Improve error checking.

OK okan@

double semicolon; from Daniel Matic in PR 4929

fix readlink() usage.

millert@ ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

o Sync w/ freerdist 0.92 minus the compress option
o KNF and ANSIfy the function headers

Sparse file support is currently a no-op since it didn't work.
Proper sparse file support will be added later.

strcpy/strcat/sprintf removal; krw@ OK

more POSIX chown

strings; ok miod ho krw

kill more registers

millert@ ok

occured->occurred

idea from deraadt@ via NetBSD
millert@ ok

p.s. Next commit will fix a typo in the sys/

Fix a serious memory consumption problem when running over directories
that contain many hard-linked files; johnh@isi.edu
Also add an xstrdup() that behaves like xmalloc() on failure.

rdist 6.1.4 + OpenBSD patches + some -Wall

readlink len-1

Updated to rdist 6.1.3. Used real snprintf() (instead of string length
in the format) since we have it.

rcsid

open O_EXCL instead of creat; for writable rdist directories... still small DOS

rdist 6.1.2

rdist 6.1.1

Use password/group cache functions and avoid stashing a pointer to
the return value of getgrgid(3) or getgrnam(3) which relies on
undefined behavior. The rdist server will now use getgroups(2) to
determine group membership of the invoking user. In addition, there
is now one implementation of tilde expansion instead of two.
OK tb@ tim@

Fix a crash in rdistd triggered by the recent getpw{ent,nam,uid}
changes. This stems from rdist stashing a pointer to the static
area used by getpw{ent,nam,uid} and using it to avoid repeating
passwd lookups when pw->pw_name matches the user to be looked up.

This relied on undefined behavior, and with the recent passwd
changes, is no longer possible as the old pointer will be invalidated.
A better approach is to use the upcoming uid_from_user(3) functions.
Found by and fix OK tim@

gid_t is unsigned, so < 0 test is always false, compare against (gid_t)-1
explicitly; ok millert@

Avoid compiler warning about zero-length printf format strings.
Allow a NULL format in message() and switch the two calls to
error() and message() with an empty format string to using NULL.
OK deraadt@

The change to make mkstemp(3) require at least 6 trailing Xs broke
rdistd for directories that do not exist on the destination. Calling
mkstemp(3) twice with the same format (filled in by the first
mkstemp(3) call) is bogus so call chkparent() *before* mkstemp(3)
instead of only on error. This costs an extra lstat(2) in the case
where the directory already exists but simplifies the code and
doesn't rely on undefined behavior (namely, the state of the template
when mkstemp fails). OK tim@

remove needless allocation casts

Remove a couple needless allocation casts. No binary change.

Switch to linkat() to support hardlinked symlinks
Simplify chown logic by using fchownat()
Cache whether we're root instead of calling getuid() before each chown

Assume NFS_CHECK and RO_CHECK are defined.
We only need the dev_t and not the entire struct stat in mntinfo.
Delete some superfluous casts.

Reduce opt_t from long to int.
Debug message consistency: format opts with %#x and modes with %#04o

Split out from rdist/defs.h the client-only and server-only bits into
rdist/client.h and rdistd/server.h
Only put #includes in .h files that are necessary for the .h to be used;
all other #includes go in the .c files
Move all extern variable declarations to the .h files, renaming local
variables to avoid shadowing
Replace me_type member of mntent_t with an "is NFS?" flag bit

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Rename 'link' parameter to eliminate shadow warnings

Yes, we have setproctitle(). Delete that and several unused HAVE_* #defines

Assume POSIX: S_IFSOCK and S_IFIFO
Kill some 'notyet' code that will never be enabled

Assume POSIX: lchown(), fchown(), fchmod(), fchmodat()
Assume we have rcmdsh()

Assume POSIX: uid_t and gid_t
Add parens to quiet gcc on previous commit

Assume POSIX: <dirent.h>, struct dirent

Oops, fix both locations using D_NAMLEN()

Stop using silly macro when checking for '.' and '..' directory entries

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

remove casts to time_t * which are not needed

Fix various format string issues. Stop assuming time_t is long or smaller.
Enable warnings.

ok krw@, ian@

Apply some tough type-love and give rdist a chance to handle files
larger than 2GB. Diff from Stephan R. Gerber via PR#6586, tweaks
by me.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

pathnames with space, tab, newline, etc are encoded before being sent.
But they were not reliably being decoded, resulting in wrong naming
on the target machine. diff from Tim van der Molen

Fix breakage introduced in rev 1.8 wrt rdisting symlinks. Push the
mkstemp() down into recvfile() and use mktemp() for recvlink().
OK okan@

Change a mktemp(3) to mkstemp(3), preventing a race condition.
Improve error checking.

OK okan@

double semicolon; from Daniel Matic in PR 4929

fix readlink() usage.

millert@ ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

o Sync w/ freerdist 0.92 minus the compress option
o KNF and ANSIfy the function headers

Sparse file support is currently a no-op since it didn't work.
Proper sparse file support will be added later.

strcpy/strcat/sprintf removal; krw@ OK

more POSIX chown

strings; ok miod ho krw

kill more registers

millert@ ok

occured->occurred

idea from deraadt@ via NetBSD
millert@ ok

p.s. Next commit will fix a typo in the sys/

Fix a serious memory consumption problem when running over directories
that contain many hard-linked files; johnh@isi.edu
Also add an xstrdup() that behaves like xmalloc() on failure.

rdist 6.1.4 + OpenBSD patches + some -Wall

readlink len-1

Updated to rdist 6.1.3. Used real snprintf() (instead of string length
in the format) since we have it.

rcsid

open O_EXCL instead of creat; for writable rdist directories... still small DOS

rdist 6.1.2

rdist 6.1.1

gid_t is unsigned, so < 0 test is always false, compare against (gid_t)-1
explicitly; ok millert@

Avoid compiler warning about zero-length printf format strings.
Allow a NULL format in message() and switch the two calls to
error() and message() with an empty format string to using NULL.
OK deraadt@

The change to make mkstemp(3) require at least 6 trailing Xs broke
rdistd for directories that do not exist on the destination. Calling
mkstemp(3) twice with the same format (filled in by the first
mkstemp(3) call) is bogus so call chkparent() *before* mkstemp(3)
instead of only on error. This costs an extra lstat(2) in the case
where the directory already exists but simplifies the code and
doesn't rely on undefined behavior (namely, the state of the template
when mkstemp fails). OK tim@

remove needless allocation casts

Remove a couple needless allocation casts. No binary change.

Switch to linkat() to support hardlinked symlinks
Simplify chown logic by using fchownat()
Cache whether we're root instead of calling getuid() before each chown

Assume NFS_CHECK and RO_CHECK are defined.
We only need the dev_t and not the entire struct stat in mntinfo.
Delete some superfluous casts.

Reduce opt_t from long to int.
Debug message consistency: format opts with %#x and modes with %#04o

Split out from rdist/defs.h the client-only and server-only bits into
rdist/client.h and rdistd/server.h
Only put #includes in .h files that are necessary for the .h to be used;
all other #includes go in the .c files
Move all extern variable declarations to the .h files, renaming local
variables to avoid shadowing
Replace me_type member of mntent_t with an "is NFS?" flag bit

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Rename 'link' parameter to eliminate shadow warnings

Yes, we have setproctitle(). Delete that and several unused HAVE_* #defines

Assume POSIX: S_IFSOCK and S_IFIFO
Kill some 'notyet' code that will never be enabled

Assume POSIX: lchown(), fchown(), fchmod(), fchmodat()
Assume we have rcmdsh()

Assume POSIX: uid_t and gid_t
Add parens to quiet gcc on previous commit

Assume POSIX: <dirent.h>, struct dirent

Oops, fix both locations using D_NAMLEN()

Stop using silly macro when checking for '.' and '..' directory entries

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

remove casts to time_t * which are not needed

Fix various format string issues. Stop assuming time_t is long or smaller.
Enable warnings.

ok krw@, ian@

Apply some tough type-love and give rdist a chance to handle files
larger than 2GB. Diff from Stephan R. Gerber via PR#6586, tweaks
by me.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

pathnames with space, tab, newline, etc are encoded before being sent.
But they were not reliably being decoded, resulting in wrong naming
on the target machine. diff from Tim van der Molen

Fix breakage introduced in rev 1.8 wrt rdisting symlinks. Push the
mkstemp() down into recvfile() and use mktemp() for recvlink().
OK okan@

Change a mktemp(3) to mkstemp(3), preventing a race condition.
Improve error checking.

OK okan@

double semicolon; from Daniel Matic in PR 4929

fix readlink() usage.

millert@ ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

o Sync w/ freerdist 0.92 minus the compress option
o KNF and ANSIfy the function headers

Sparse file support is currently a no-op since it didn't work.
Proper sparse file support will be added later.

strcpy/strcat/sprintf removal; krw@ OK

more POSIX chown

strings; ok miod ho krw

kill more registers

millert@ ok

occured->occurred

idea from deraadt@ via NetBSD
millert@ ok

p.s. Next commit will fix a typo in the sys/

Fix a serious memory consumption problem when running over directories
that contain many hard-linked files; johnh@isi.edu
Also add an xstrdup() that behaves like xmalloc() on failure.

rdist 6.1.4 + OpenBSD patches + some -Wall

readlink len-1

Updated to rdist 6.1.3. Used real snprintf() (instead of string length
in the format) since we have it.

rcsid

open O_EXCL instead of creat; for writable rdist directories... still small DOS

rdist 6.1.2

rdist 6.1.1