Accommodate POSIX basename(3) that takes a non-const parameter and
may modify the string buffer.
ok martijn@ millert@

Quiet compiler warnings; as applied to usr.bin/cvs by millert@

ok millert@

rlog: add -E and -S options to configure revision separators, to
work around commits that might have the default strings in them

ok tom deraadt

Pull in <time.h> for struct tm, used in rcs.h

ok deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

consistency in calling usage, from Fritjof Bornebusch

Zap some stored values never read; From Fritjof Bornebusch; ok nicm@

exit in usage functions themselves; from Fritjof Bornebusch; ok nicm@

ctype cleanups; ok okan

properly handle commitid tokens found in rcs files

ok deraadt

spacing, no binary change.

Check date_parse return values.

OK xsa

Reduce variable/function name and whitespace differences between
cvs/rcs.

OK xsa zinovik

support rlog -d
prodded & tested by sthen@

Fix broken indentation introduced in last commit.
Spotted by Pierre Riteau.

From src/usr.bin/cvs:

> add changed lines support to log and rlog (the + and - stuff)
> from Pierre Riteau;

Have rlog exit 1 if any of the files could not be opened.
Don't mention -q flag, which is there for compatibility.

From Pierre Riteau.

OK joris for first part, OK niallo and jmc for second.

Sync revisions and time buffers size to be consistent with each others.
Simplifies further size tweaks if needed.
OK ray@.

As done in OpenCVS, general includes cleanup sweep. OK otto@.

- convert some warnx() to warn(), which fixes a few stupidly un-informative error messages (found by tom@)
- make rcs_choosefile() save wrt errno, input from ray@

ok joris@ xsa@

Remove rcs_statfile(). It was just a wrapper for rcs_choosefile(),
handling exceptions oddly.

OK joris@

Remove /* NOTREACHED */ comments, now that lint is smart about
__dead. I never should have put them there.

OK xsa@.

fix date format output if a timezone is specified (-z);

prevent file races by obtaining an fd for the RCS file and
do our operations on that, this is safe and guarantees we
can operate on the file until we close(2) it.

a fix is coming for the remaining races in our diff code.
okay niallo@ and ray@

fork our code we shared between openrcs/cvs into the openrcs dir.

this was starting to become inhuman to maintain without
ugly ugly hacks in the shared code, and it will be easier
to make specific changes for openrcs without touching the
soon-to-be-replaced opencvs code.

fatal() -> err()/errx() as we try to not depend on heavy cvs_log().
OK joriski.

move shared functions into rcsutil.[ch]; this makes rcsprog.c cleaner;
"the voices in my head say OK!" joris@.

remove overkill cvs_log() and rather use warn()/warnx().
OK ray@ and discussed with joris@.

switch -q handling to bitwise flags; OK ray@ niallo@.

dont stupidly duplicate code. make rlog use rcs_rev_select() and thus
nuke rlog_rev_select(). OK niallo@.

- don't append the extension if it's already there (PR 5076).
- show magic branches in rlog (thanks for that nicer hack niall).
- correct output in rcsdiff, so we perfectly match gnu's

all these bugs were found by sturm@ while he was using cvsweb
(which uses the RCS tools).

"it is in my view that you should put it in" niallo@

Remove global variable RCSFILE.

OK joris@

Remove extraneous argument from rlog_file().

OK joris@

Short-circuit rlog when the -l flag is specified but there are no locks.

OK joris@

excessive addition to brackets is a mental disease. you will go
blind, too. seek help. no binary change, ok joris

fix -z option for openrcs, this was broken by xsa
when he yanked the code out of rcs.c and placed it in rcstime.c.

struct tm ltb, *tb;
tb = &ltb;
return (tb);

isn't really the most perfect idiom to return a value to the caller, now is it?

as a bonus -z for rlog now works too.
okay niallo@

- zap some whitespace.

-z can take no argument.

small knf;

Add rlog -r[REV1][:][REV2] support

From Pierre-Yves Ritschard.

OK niallo@

match GNU's output when no revision are present.

Plug a memory leak for all cvs_strsplit call sites; ok xsa@

Allow the -x flag to be used without an extension.

``that makes sense'' xsa@

rlog_file() will never return non-zero; change its return type to void.

add missing xfree()'s after we are done with cvs_strsplit();
spotted by ray@, OK joris@.

rlog_strsplit() -> cvs_strsplit() and move it to util.c so it can be reused
by `cvs log' and some other RCS utilities. "Looks good" ray@.

Follow exit() with /* NOTREACHED*/ for lint.

``OK niallo@'' niallo@

fix usage();

missing break;

-z support for RCS;

update usage();

move compat flags into a STANDARDS section;

add support for `-l[lockers]'. Some (needed) cleanup will follow.
Test & OK niallo@.

print locker's name if revision is locked;

display usage if an unknown option is specified;

add support for `-sstates' and `-w[logins]' options; tested and OK niallo@.

cleanup, move log.h and rcs.h inclusion into rcsprog.h;

#include's cleanup; ok joris@ niallo@.

- rlog(1) needs RCS_PARSE_FULLY too.

split the printing part into a separate function, rlog_rev_print();
might be useful for future work needed in rlog(1);

sync usage() for `-xsuffixes';

enable `-xsuffixes' support as it has been added a few days ago
in rcs_statfile();
niallo ok

indent;

print RCS file info too;

add support for `-L'; niallo ok

print locker's name and rev number for locked revisions; ok joris niallo

correct -R behaviour;

-T is kept for compatibility with other RCS commands here too;

missed that in previous commit;

output tweaks;

To be fully compatibly with the GNU RCS tools we need to have the
same way of parsing commandline options. Since getopt(3) allows spaces
between arguments and GNU RCS tools does not we needed to roll out our
own way of option handling, and here it is.

ok niallo@

various usage cleanup; ok joris

basic `ci' support is here! more coming soon.

combined effort with joris.

ok joris@

sync rlog_usage() with reality.

support rlog command;

Quiet compiler warnings; as applied to usr.bin/cvs by millert@

ok millert@

rlog: add -E and -S options to configure revision separators, to
work around commits that might have the default strings in them

ok tom deraadt

Pull in <time.h> for struct tm, used in rcs.h

ok deraadt@

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

consistency in calling usage, from Fritjof Bornebusch

Zap some stored values never read; From Fritjof Bornebusch; ok nicm@

exit in usage functions themselves; from Fritjof Bornebusch; ok nicm@

ctype cleanups; ok okan

properly handle commitid tokens found in rcs files

ok deraadt

spacing, no binary change.

Check date_parse return values.

OK xsa

Reduce variable/function name and whitespace differences between
cvs/rcs.

OK xsa zinovik

support rlog -d
prodded & tested by sthen@

Fix broken indentation introduced in last commit.
Spotted by Pierre Riteau.

From src/usr.bin/cvs:

> add changed lines support to log and rlog (the + and - stuff)
> from Pierre Riteau;

Have rlog exit 1 if any of the files could not be opened.
Don't mention -q flag, which is there for compatibility.

From Pierre Riteau.

OK joris for first part, OK niallo and jmc for second.

Sync revisions and time buffers size to be consistent with each others.
Simplifies further size tweaks if needed.
OK ray@.

As done in OpenCVS, general includes cleanup sweep. OK otto@.

- convert some warnx() to warn(), which fixes a few stupidly un-informative error messages (found by tom@)
- make rcs_choosefile() save wrt errno, input from ray@

ok joris@ xsa@

Remove rcs_statfile(). It was just a wrapper for rcs_choosefile(),
handling exceptions oddly.

OK joris@

Remove /* NOTREACHED */ comments, now that lint is smart about
__dead. I never should have put them there.

OK xsa@.

fix date format output if a timezone is specified (-z);

prevent file races by obtaining an fd for the RCS file and
do our operations on that, this is safe and guarantees we
can operate on the file until we close(2) it.

a fix is coming for the remaining races in our diff code.
okay niallo@ and ray@

fork our code we shared between openrcs/cvs into the openrcs dir.

this was starting to become inhuman to maintain without
ugly ugly hacks in the shared code, and it will be easier
to make specific changes for openrcs without touching the
soon-to-be-replaced opencvs code.

fatal() -> err()/errx() as we try to not depend on heavy cvs_log().
OK joriski.

move shared functions into rcsutil.[ch]; this makes rcsprog.c cleaner;
"the voices in my head say OK!" joris@.

remove overkill cvs_log() and rather use warn()/warnx().
OK ray@ and discussed with joris@.

switch -q handling to bitwise flags; OK ray@ niallo@.

dont stupidly duplicate code. make rlog use rcs_rev_select() and thus
nuke rlog_rev_select(). OK niallo@.

- don't append the extension if it's already there (PR 5076).
- show magic branches in rlog (thanks for that nicer hack niall).
- correct output in rcsdiff, so we perfectly match gnu's

all these bugs were found by sturm@ while he was using cvsweb
(which uses the RCS tools).

"it is in my view that you should put it in" niallo@

Remove global variable RCSFILE.

OK joris@

Remove extraneous argument from rlog_file().

OK joris@

Short-circuit rlog when the -l flag is specified but there are no locks.

OK joris@

excessive addition to brackets is a mental disease. you will go
blind, too. seek help. no binary change, ok joris

fix -z option for openrcs, this was broken by xsa
when he yanked the code out of rcs.c and placed it in rcstime.c.

struct tm ltb, *tb;
tb = &ltb;
return (tb);

isn't really the most perfect idiom to return a value to the caller, now is it?

as a bonus -z for rlog now works too.
okay niallo@

- zap some whitespace.

-z can take no argument.

small knf;

Add rlog -r[REV1][:][REV2] support

From Pierre-Yves Ritschard.

OK niallo@

match GNU's output when no revision are present.

Plug a memory leak for all cvs_strsplit call sites; ok xsa@

Allow the -x flag to be used without an extension.

``that makes sense'' xsa@

rlog_file() will never return non-zero; change its return type to void.

add missing xfree()'s after we are done with cvs_strsplit();
spotted by ray@, OK joris@.

rlog_strsplit() -> cvs_strsplit() and move it to util.c so it can be reused
by `cvs log' and some other RCS utilities. "Looks good" ray@.

Follow exit() with /* NOTREACHED*/ for lint.

``OK niallo@'' niallo@

fix usage();

missing break;

-z support for RCS;

update usage();

move compat flags into a STANDARDS section;

add support for `-l[lockers]'. Some (needed) cleanup will follow.
Test & OK niallo@.

print locker's name if revision is locked;

display usage if an unknown option is specified;

add support for `-sstates' and `-w[logins]' options; tested and OK niallo@.

cleanup, move log.h and rcs.h inclusion into rcsprog.h;

#include's cleanup; ok joris@ niallo@.

- rlog(1) needs RCS_PARSE_FULLY too.

split the printing part into a separate function, rlog_rev_print();
might be useful for future work needed in rlog(1);

sync usage() for `-xsuffixes';

enable `-xsuffixes' support as it has been added a few days ago
in rcs_statfile();
niallo ok

indent;

print RCS file info too;

add support for `-L'; niallo ok

print locker's name and rev number for locked revisions; ok joris niallo

correct -R behaviour;

-T is kept for compatibility with other RCS commands here too;

missed that in previous commit;

output tweaks;

To be fully compatibly with the GNU RCS tools we need to have the
same way of parsing commandline options. Since getopt(3) allows spaces
between arguments and GNU RCS tools does not we needed to roll out our
own way of option handling, and here it is.

ok niallo@

various usage cleanup; ok joris

basic `ci' support is here! more coming soon.

combined effort with joris.

ok joris@

sync rlog_usage() with reality.

support rlog command;