Switch rcs_{get,set}_mtime() from returning and taking a time_t to
doing so with a struct timespec and then use tv_nsec = UTIME_OMIT
instead of a (time_t)-1 as a "do nothing" value. They can then
fully preserve the timestamp

ok millert@

typo in error message

kill const and string artithmetic related warnings; ok millert@

The -I flag is documented but not implemented. This fixes that and
also honors the -I flag from ci/co when prompting like GNU RCS.
OK jca@

Convert xfree to free. From Fritjof Bornebusch. ok deraadt

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

An internal function called xrealloc() is actually a fail-hard
reallocarray()... so rename it.

Zap some stored values never read; From Fritjof Bornebusch; ok nicm@

use calloc, from Benjamin Baier

remove wrong casts; ok millert

add missing header needed by futimes()

ok tobias@ xsa@ nicm@

Remove the need for rp_file in parser structure, instead keep only one
FILE pointer in RCSFILE. This fixes some ugliness in closing an
fdopen()ed FILE and its underlying file descriptor.

Notified by Joerg Sonnenberger <joerg at britannica dot bec to de>

discussed with and ok nicm

Set rcs_suffixes to default value on initialization.

ok ray zinovik

Make BUFs autoextend by default. This was already done in OpenCVS
a while ago.

OK zinovik nicm

Reduce variable/function name and whitespace differences between
cvs/rcs.

OK xsa zinovik

properly free suffixes.
OK tobias@

remove unused function

from tobias@

ok xsa@ tobias@

Sync with cvs:
> xcalloc is unneeded here since i is always 0 and we always use the
> memory after initializing it.
>
> Initial diff from Igor Zinovik.
>
> OK niallo and xsa.

Since xrealloc dies on failure it is safe to directly assign to the
original pointer. Theo agrees, and so does the rest of the tree
(ssh, etc. all do this already).

Saves a bunch of variables and assignments.

OK niallo@

As done in OpenCVS, general includes cleanup sweep. OK otto@.

If a ,suffix file is given as an arg to ci and co, strip it. Avoids
potential disasters. Initial diff from niallo@, ok niallo@ joris@

Fix const inconsistencies, void pointer artithmetic;
Based on diff from otto@ in OpenCVS. OK otto@.

remove some un-needed buffer NUL-termination. in openrcs, diff3 is already NUL-terminating its
buffers so we don't need to do it twice. this allows us to sync rcs_splitlines() with opencvs'
cvs_splitlines().

ok joris@

Clear EOF before prompting user for input.

Fixes PR 5342.

OK joris@ and xsa@.

- fix support for checking out binary files.

testing from xsa@ and Igor Sobrado <igor at string1.ciencias.uniovi.es>
ok xsa@

Simplify stripping of write bits from file mode.
Add support for reusing the checkin message for multiple files, ala GNU
Fix the message when you abort a checkout and the file was not writable.
OK joris@ niallo@

- convert some warnx() to warn(), which fixes a few stupidly un-informative error messages (found by tom@)
- make rcs_choosefile() save wrt errno, input from ray@

ok joris@ xsa@

Remove debugging printf accidentally committed.

OK joris@.

- handle deltatexts which don't end in a newline character. fixes PR #5241.

ok ray@

Use S_IS* macros insted of masking with S_IF* flags. The latter may
have multiple bits set, which lead to surprising results. Spotted by
Paul Stoeber, more to come. ok millert@ pedro@ jaredy@ djm@

Improve rcs_buf_load() by setting errno appropriately on failure and
never print errors or quit on error.

Fix usages of rcs_buf_load() and rcs_set_description.

Also plug an fd leak.

OK xsa@

rcs_splitlines() can never return NULL, so don't check for it.

OK joris@

- plug a memory leak

- correctly handle binary files; say bye bye to using c strings for deltatexts.

"slap it in" joris@

Remove a lot of xstrdup() calls in getopt() loops, which are usually
unnecessary. These xstrdup() calls don't call xfree() before anyway,
so if a flag is given multiple times memory leaks would have resulted.

OK joris@

Rename RCSFILE.fd to RCSFILE.rf_fd, plus minor spacing nits. No
binary change.

OK xsa@

Remove rcs_statfile(). It was just a wrapper for rcs_choosefile(),
handling exceptions oddly.

OK joris@

rcs_choosefile() no longer returns char *, it returns a file
descriptor; fix comment.

Improve spacing.

OK joris@

Remove unused variable leftover from race condition cleanup.

OK xsa@.

Use warnx() when errno is not set.

OK joris@.

Check return values for all strlcpy, and strlcat calls.

OK xsa@ and probably others.

zap util.[ch] and move the content into rcsutil.[ch].
discussed with joris@.

prevent file races by obtaining an fd for the RCS file and
do our operations on that, this is safe and guarantees we
can operate on the file until we close(2) it.

a fix is coming for the remaining races in our diff code.
okay niallo@ and ray@

fork our code we shared between openrcs/cvs into the openrcs dir.

this was starting to become inhuman to maintain without
ugly ugly hacks in the shared code, and it will be easier
to make specific changes for openrcs without touching the
soon-to-be-replaced opencvs code.

quote strings consistently.

fatal() -> err()/errx() as we try to not depend on heavy cvs_log().
OK joriski.

o Better match GNU behavior (a bare -t does NOT read from stdin,
unlike rcs).
o Share code with rcs by moving rcs_set_description() to rcsutil.c.
o Change description prompt from #define to const char *.

OK xsa@

move shared functions into rcsutil.[ch]; this makes rcsprog.c cleaner;
"the voices in my head say OK!" joris@.

typo in error message

kill const and string artithmetic related warnings; ok millert@

The -I flag is documented but not implemented. This fixes that and
also honors the -I flag from ci/co when prompting like GNU RCS.
OK jca@

Convert xfree to free. From Fritjof Bornebusch. ok deraadt

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

An internal function called xrealloc() is actually a fail-hard
reallocarray()... so rename it.

Zap some stored values never read; From Fritjof Bornebusch; ok nicm@

use calloc, from Benjamin Baier

remove wrong casts; ok millert

add missing header needed by futimes()

ok tobias@ xsa@ nicm@

Remove the need for rp_file in parser structure, instead keep only one
FILE pointer in RCSFILE. This fixes some ugliness in closing an
fdopen()ed FILE and its underlying file descriptor.

Notified by Joerg Sonnenberger <joerg at britannica dot bec to de>

discussed with and ok nicm

Set rcs_suffixes to default value on initialization.

ok ray zinovik

Make BUFs autoextend by default. This was already done in OpenCVS
a while ago.

OK zinovik nicm

Reduce variable/function name and whitespace differences between
cvs/rcs.

OK xsa zinovik

properly free suffixes.
OK tobias@

remove unused function

from tobias@

ok xsa@ tobias@

Sync with cvs:
> xcalloc is unneeded here since i is always 0 and we always use the
> memory after initializing it.
>
> Initial diff from Igor Zinovik.
>
> OK niallo and xsa.

Since xrealloc dies on failure it is safe to directly assign to the
original pointer. Theo agrees, and so does the rest of the tree
(ssh, etc. all do this already).

Saves a bunch of variables and assignments.

OK niallo@

As done in OpenCVS, general includes cleanup sweep. OK otto@.

If a ,suffix file is given as an arg to ci and co, strip it. Avoids
potential disasters. Initial diff from niallo@, ok niallo@ joris@

Fix const inconsistencies, void pointer artithmetic;
Based on diff from otto@ in OpenCVS. OK otto@.

remove some un-needed buffer NUL-termination. in openrcs, diff3 is already NUL-terminating its
buffers so we don't need to do it twice. this allows us to sync rcs_splitlines() with opencvs'
cvs_splitlines().

ok joris@

Clear EOF before prompting user for input.

Fixes PR 5342.

OK joris@ and xsa@.

- fix support for checking out binary files.

testing from xsa@ and Igor Sobrado <igor at string1.ciencias.uniovi.es>
ok xsa@

Simplify stripping of write bits from file mode.
Add support for reusing the checkin message for multiple files, ala GNU
Fix the message when you abort a checkout and the file was not writable.
OK joris@ niallo@

- convert some warnx() to warn(), which fixes a few stupidly un-informative error messages (found by tom@)
- make rcs_choosefile() save wrt errno, input from ray@

ok joris@ xsa@

Remove debugging printf accidentally committed.

OK joris@.

- handle deltatexts which don't end in a newline character. fixes PR #5241.

ok ray@

Use S_IS* macros insted of masking with S_IF* flags. The latter may
have multiple bits set, which lead to surprising results. Spotted by
Paul Stoeber, more to come. ok millert@ pedro@ jaredy@ djm@

Improve rcs_buf_load() by setting errno appropriately on failure and
never print errors or quit on error.

Fix usages of rcs_buf_load() and rcs_set_description.

Also plug an fd leak.

OK xsa@

rcs_splitlines() can never return NULL, so don't check for it.

OK joris@

- plug a memory leak

- correctly handle binary files; say bye bye to using c strings for deltatexts.

"slap it in" joris@

Remove a lot of xstrdup() calls in getopt() loops, which are usually
unnecessary. These xstrdup() calls don't call xfree() before anyway,
so if a flag is given multiple times memory leaks would have resulted.

OK joris@

Rename RCSFILE.fd to RCSFILE.rf_fd, plus minor spacing nits. No
binary change.

OK xsa@

Remove rcs_statfile(). It was just a wrapper for rcs_choosefile(),
handling exceptions oddly.

OK joris@

rcs_choosefile() no longer returns char *, it returns a file
descriptor; fix comment.

Improve spacing.

OK joris@

Remove unused variable leftover from race condition cleanup.

OK xsa@.

Use warnx() when errno is not set.

OK joris@.

Check return values for all strlcpy, and strlcat calls.

OK xsa@ and probably others.

zap util.[ch] and move the content into rcsutil.[ch].
discussed with joris@.

prevent file races by obtaining an fd for the RCS file and
do our operations on that, this is safe and guarantees we
can operate on the file until we close(2) it.

a fix is coming for the remaining races in our diff code.
okay niallo@ and ray@

fork our code we shared between openrcs/cvs into the openrcs dir.

this was starting to become inhuman to maintain without
ugly ugly hacks in the shared code, and it will be easier
to make specific changes for openrcs without touching the
soon-to-be-replaced opencvs code.

quote strings consistently.

fatal() -> err()/errx() as we try to not depend on heavy cvs_log().
OK joriski.

o Better match GNU behavior (a bare -t does NOT read from stdin,
unlike rcs).
o Share code with rcs by moving rcs_set_description() to rcsutil.c.
o Change description prompt from #define to const char *.

OK xsa@

move shared functions into rcsutil.[ch]; this makes rcsprog.c cleaner;
"the voices in my head say OK!" joris@.

kill const and string artithmetic related warnings; ok millert@

The -I flag is documented but not implemented. This fixes that and
also honors the -I flag from ci/co when prompting like GNU RCS.
OK jca@

Convert xfree to free. From Fritjof Bornebusch. ok deraadt

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

An internal function called xrealloc() is actually a fail-hard
reallocarray()... so rename it.

Zap some stored values never read; From Fritjof Bornebusch; ok nicm@

use calloc, from Benjamin Baier

remove wrong casts; ok millert

add missing header needed by futimes()

ok tobias@ xsa@ nicm@

Remove the need for rp_file in parser structure, instead keep only one
FILE pointer in RCSFILE. This fixes some ugliness in closing an
fdopen()ed FILE and its underlying file descriptor.

Notified by Joerg Sonnenberger <joerg at britannica dot bec to de>

discussed with and ok nicm

Set rcs_suffixes to default value on initialization.

ok ray zinovik

Make BUFs autoextend by default. This was already done in OpenCVS
a while ago.

OK zinovik nicm

Reduce variable/function name and whitespace differences between
cvs/rcs.

OK xsa zinovik

properly free suffixes.
OK tobias@

remove unused function

from tobias@

ok xsa@ tobias@

Sync with cvs:
> xcalloc is unneeded here since i is always 0 and we always use the
> memory after initializing it.
>
> Initial diff from Igor Zinovik.
>
> OK niallo and xsa.

Since xrealloc dies on failure it is safe to directly assign to the
original pointer. Theo agrees, and so does the rest of the tree
(ssh, etc. all do this already).

Saves a bunch of variables and assignments.

OK niallo@

As done in OpenCVS, general includes cleanup sweep. OK otto@.

If a ,suffix file is given as an arg to ci and co, strip it. Avoids
potential disasters. Initial diff from niallo@, ok niallo@ joris@

Fix const inconsistencies, void pointer artithmetic;
Based on diff from otto@ in OpenCVS. OK otto@.

remove some un-needed buffer NUL-termination. in openrcs, diff3 is already NUL-terminating its
buffers so we don't need to do it twice. this allows us to sync rcs_splitlines() with opencvs'
cvs_splitlines().

ok joris@

Clear EOF before prompting user for input.

Fixes PR 5342.

OK joris@ and xsa@.

- fix support for checking out binary files.

testing from xsa@ and Igor Sobrado <igor at string1.ciencias.uniovi.es>
ok xsa@

Simplify stripping of write bits from file mode.
Add support for reusing the checkin message for multiple files, ala GNU
Fix the message when you abort a checkout and the file was not writable.
OK joris@ niallo@

- convert some warnx() to warn(), which fixes a few stupidly un-informative error messages (found by tom@)
- make rcs_choosefile() save wrt errno, input from ray@

ok joris@ xsa@

Remove debugging printf accidentally committed.

OK joris@.

- handle deltatexts which don't end in a newline character. fixes PR #5241.

ok ray@

Use S_IS* macros insted of masking with S_IF* flags. The latter may
have multiple bits set, which lead to surprising results. Spotted by
Paul Stoeber, more to come. ok millert@ pedro@ jaredy@ djm@

Improve rcs_buf_load() by setting errno appropriately on failure and
never print errors or quit on error.

Fix usages of rcs_buf_load() and rcs_set_description.

Also plug an fd leak.

OK xsa@

rcs_splitlines() can never return NULL, so don't check for it.

OK joris@

- plug a memory leak

- correctly handle binary files; say bye bye to using c strings for deltatexts.

"slap it in" joris@

Remove a lot of xstrdup() calls in getopt() loops, which are usually
unnecessary. These xstrdup() calls don't call xfree() before anyway,
so if a flag is given multiple times memory leaks would have resulted.

OK joris@

Rename RCSFILE.fd to RCSFILE.rf_fd, plus minor spacing nits. No
binary change.

OK xsa@

Remove rcs_statfile(). It was just a wrapper for rcs_choosefile(),
handling exceptions oddly.

OK joris@

rcs_choosefile() no longer returns char *, it returns a file
descriptor; fix comment.

Improve spacing.

OK joris@

Remove unused variable leftover from race condition cleanup.

OK xsa@.

Use warnx() when errno is not set.

OK joris@.

Check return values for all strlcpy, and strlcat calls.

OK xsa@ and probably others.

zap util.[ch] and move the content into rcsutil.[ch].
discussed with joris@.

prevent file races by obtaining an fd for the RCS file and
do our operations on that, this is safe and guarantees we
can operate on the file until we close(2) it.

a fix is coming for the remaining races in our diff code.
okay niallo@ and ray@

fork our code we shared between openrcs/cvs into the openrcs dir.

this was starting to become inhuman to maintain without
ugly ugly hacks in the shared code, and it will be easier
to make specific changes for openrcs without touching the
soon-to-be-replaced opencvs code.

quote strings consistently.

fatal() -> err()/errx() as we try to not depend on heavy cvs_log().
OK joriski.

o Better match GNU behavior (a bare -t does NOT read from stdin,
unlike rcs).
o Share code with rcs by moving rcs_set_description() to rcsutil.c.
o Change description prompt from #define to const char *.

OK xsa@

move shared functions into rcsutil.[ch]; this makes rcsprog.c cleaner;
"the voices in my head say OK!" joris@.