support (ignore) universal ctags extended metadata in tagaddress

universal ctags "abuses" the tagaddress, which can be an arbitrary
vi command even if mg assumes it's just a search pattern, to store
metadata after a "vi comment".

While it could be worthwile to support the uctags annotations this
just ignores them so the search patterns work again.

The diff is from Joachim Wiberg "troglobit" mg.

ok tb@

plug leak of tagpos in poptag() if loadbuffer() fails

drop needless global tagsfn path

mg kept the path to the last loaded tag file in tagsfn which was used
for both the lazy loading (now removed) and as a flag to know if any
tags are currently loaded. It's redundant and complicates the code:
just check if the tree is empty instead.

ok tb@

change tagvisit (aka visit-tag-table) to immediately load the tag file

before it used to only record the path to the tag file which was loaded
on demand upon find-tag (M-.). tagvisit did to do a stat + access dance
to know if the path was pointing to a regular, readable file and
loadtags (called lazily by find-tag) trusted those checks...

Instead, just load the tags in tagvisit and drop the lazy mechanics.

ok tb@

mg: fix parsing of tag files with duplicate entries

Instead of erroring out ignore duplicates. Fixes using /var/db/libc.tags
again.

ok op

plug another leak in addctag; found + ok tb@

avoid memleak / crash in addctag

the l pointer is advanced, so if the line is malformed `goto cleanup'
will free(NULL) or a pointer inside l.

semplification and ok tb@

plug memleak in error path

based on a diff by lux (lx [at] shellcodes [dot] org), thanks!
Diff via, tweak and ok tb@

delete trailing whitespaces; no functional change

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

When it's the possessive of 'it', it's spelled "its", without the
apostrophe.

Present the default choice before the colon in prompts. Matches GNU Emacs
behavior.

From Scott Cheloha <scottcheloha@gmail.com>

ok florian@

fix -Wshadow warnings.
Found by bcallah, thanks!

Fix possible NULL pointer dereference.

Found by Coverity Scan. The tagsvisit() function calls eread(),
which may return NULL. This is then immediately passed to stat()
without a proper check. This patch adds that check.

From Joachim Nilsson <troglobit@gmail.com> via lum@. Ok lum@

Update my mail address.

Return FALSE on parse errors.

Found by and Ok lum@.

Clean up the includes in mg.
This does the following:
Moves all POSIX headers from sysdef.h into the individual .c files so that
each file now only includes what it needs. All headers are properly sorted.
Moves the remainder of sysdef.h to other files (mostly def.h) and deletes
sysdef.h now that it's no longer contains anything.
Tweak a comment that references sysdef.h so that it no longer does that.
ok florian@

ctype macros/functions expect unsigned char values. Note that the lgetc()
macro does the cast internally like getc() does, so its return should be
put an in int for the same reason.

based on a diff from Kamil Rytarowski (n54 (at) gmx.com)

If no default tag defined, still let user input a tag to find.
From Sunil Nimmagadda.

Add some missing dobeeps.
ok florian@

add missing stdio.h include for fparseln().

from Ulrich Mueller, via Han Boetes
ok florian@

- fix a potential double free

ok florian@

Maintain mg's Public Domain license heritage.

Sunil Nimmagadda agrees.

add missing rcs ids

Add some cscope support to mg. From Sunil Nimmagadda. Due to some
structural limitations in mg, mg doesn't behave exactly the same as
emacs cscope (see the README) but is still very usable.

man page bits reviewed by jmc@, otherwise tested and reviewed by
myself.

Use absolute filenames while pushing and popping off the stack.

This fixes a segv discovered by Olivier A and reported to Sunil
Nimmagadda, who provided the actual fix. Tested by myself and
Oliver A.

Add some ctags support to mg. From Sunil Nimmagadda.

Man page review and suggestions from jmc@

Revewied and tested by myself, and ok deraadt@

plug leak of tagpos in poptag() if loadbuffer() fails

drop needless global tagsfn path

mg kept the path to the last loaded tag file in tagsfn which was used
for both the lazy loading (now removed) and as a flag to know if any
tags are currently loaded. It's redundant and complicates the code:
just check if the tree is empty instead.

ok tb@

change tagvisit (aka visit-tag-table) to immediately load the tag file

before it used to only record the path to the tag file which was loaded
on demand upon find-tag (M-.). tagvisit did to do a stat + access dance
to know if the path was pointing to a regular, readable file and
loadtags (called lazily by find-tag) trusted those checks...

Instead, just load the tags in tagvisit and drop the lazy mechanics.

ok tb@

mg: fix parsing of tag files with duplicate entries

Instead of erroring out ignore duplicates. Fixes using /var/db/libc.tags
again.

ok op

plug another leak in addctag; found + ok tb@

avoid memleak / crash in addctag

the l pointer is advanced, so if the line is malformed `goto cleanup'
will free(NULL) or a pointer inside l.

semplification and ok tb@

plug memleak in error path

based on a diff by lux (lx [at] shellcodes [dot] org), thanks!
Diff via, tweak and ok tb@

delete trailing whitespaces; no functional change

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

When it's the possessive of 'it', it's spelled "its", without the
apostrophe.

Present the default choice before the colon in prompts. Matches GNU Emacs
behavior.

From Scott Cheloha <scottcheloha@gmail.com>

ok florian@

fix -Wshadow warnings.
Found by bcallah, thanks!

Fix possible NULL pointer dereference.

Found by Coverity Scan. The tagsvisit() function calls eread(),
which may return NULL. This is then immediately passed to stat()
without a proper check. This patch adds that check.

From Joachim Nilsson <troglobit@gmail.com> via lum@. Ok lum@

Update my mail address.

Return FALSE on parse errors.

Found by and Ok lum@.

Clean up the includes in mg.
This does the following:
Moves all POSIX headers from sysdef.h into the individual .c files so that
each file now only includes what it needs. All headers are properly sorted.
Moves the remainder of sysdef.h to other files (mostly def.h) and deletes
sysdef.h now that it's no longer contains anything.
Tweak a comment that references sysdef.h so that it no longer does that.
ok florian@

ctype macros/functions expect unsigned char values. Note that the lgetc()
macro does the cast internally like getc() does, so its return should be
put an in int for the same reason.

based on a diff from Kamil Rytarowski (n54 (at) gmx.com)

If no default tag defined, still let user input a tag to find.
From Sunil Nimmagadda.

Add some missing dobeeps.
ok florian@

add missing stdio.h include for fparseln().

from Ulrich Mueller, via Han Boetes
ok florian@

- fix a potential double free

ok florian@

Maintain mg's Public Domain license heritage.

Sunil Nimmagadda agrees.

add missing rcs ids

Add some cscope support to mg. From Sunil Nimmagadda. Due to some
structural limitations in mg, mg doesn't behave exactly the same as
emacs cscope (see the README) but is still very usable.

man page bits reviewed by jmc@, otherwise tested and reviewed by
myself.

Use absolute filenames while pushing and popping off the stack.

This fixes a segv discovered by Olivier A and reported to Sunil
Nimmagadda, who provided the actual fix. Tested by myself and
Oliver A.

Add some ctags support to mg. From Sunil Nimmagadda.

Man page review and suggestions from jmc@

Revewied and tested by myself, and ok deraadt@

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

When it's the possessive of 'it', it's spelled "its", without the
apostrophe.

Present the default choice before the colon in prompts. Matches GNU Emacs
behavior.

From Scott Cheloha <scottcheloha@gmail.com>

ok florian@

fix -Wshadow warnings.
Found by bcallah, thanks!

Fix possible NULL pointer dereference.

Found by Coverity Scan. The tagsvisit() function calls eread(),
which may return NULL. This is then immediately passed to stat()
without a proper check. This patch adds that check.

From Joachim Nilsson <troglobit@gmail.com> via lum@. Ok lum@

Update my mail address.

Return FALSE on parse errors.

Found by and Ok lum@.

Clean up the includes in mg.
This does the following:
Moves all POSIX headers from sysdef.h into the individual .c files so that
each file now only includes what it needs. All headers are properly sorted.
Moves the remainder of sysdef.h to other files (mostly def.h) and deletes
sysdef.h now that it's no longer contains anything.
Tweak a comment that references sysdef.h so that it no longer does that.
ok florian@

ctype macros/functions expect unsigned char values. Note that the lgetc()
macro does the cast internally like getc() does, so its return should be
put an in int for the same reason.

based on a diff from Kamil Rytarowski (n54 (at) gmx.com)

If no default tag defined, still let user input a tag to find.
From Sunil Nimmagadda.

Add some missing dobeeps.
ok florian@

add missing stdio.h include for fparseln().

from Ulrich Mueller, via Han Boetes
ok florian@

- fix a potential double free

ok florian@

Maintain mg's Public Domain license heritage.

Sunil Nimmagadda agrees.

add missing rcs ids

Add some cscope support to mg. From Sunil Nimmagadda. Due to some
structural limitations in mg, mg doesn't behave exactly the same as
emacs cscope (see the README) but is still very usable.

man page bits reviewed by jmc@, otherwise tested and reviewed by
myself.

Use absolute filenames while pushing and popping off the stack.

This fixes a segv discovered by Olivier A and reported to Sunil
Nimmagadda, who provided the actual fix. Tested by myself and
Oliver A.

Add some ctags support to mg. From Sunil Nimmagadda.

Man page review and suggestions from jmc@

Revewied and tested by myself, and ok deraadt@

spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

When it's the possessive of 'it', it's spelled "its", without the
apostrophe.

Present the default choice before the colon in prompts. Matches GNU Emacs
behavior.

From Scott Cheloha <scottcheloha@gmail.com>

ok florian@

fix -Wshadow warnings.
Found by bcallah, thanks!

Fix possible NULL pointer dereference.

Found by Coverity Scan. The tagsvisit() function calls eread(),
which may return NULL. This is then immediately passed to stat()
without a proper check. This patch adds that check.

From Joachim Nilsson <troglobit@gmail.com> via lum@. Ok lum@

Update my mail address.

Return FALSE on parse errors.

Found by and Ok lum@.

Clean up the includes in mg.
This does the following:
Moves all POSIX headers from sysdef.h into the individual .c files so that
each file now only includes what it needs. All headers are properly sorted.
Moves the remainder of sysdef.h to other files (mostly def.h) and deletes
sysdef.h now that it's no longer contains anything.
Tweak a comment that references sysdef.h so that it no longer does that.
ok florian@

ctype macros/functions expect unsigned char values. Note that the lgetc()
macro does the cast internally like getc() does, so its return should be
put an in int for the same reason.

based on a diff from Kamil Rytarowski (n54 (at) gmx.com)

If no default tag defined, still let user input a tag to find.
From Sunil Nimmagadda.

Add some missing dobeeps.
ok florian@

add missing stdio.h include for fparseln().

from Ulrich Mueller, via Han Boetes
ok florian@

- fix a potential double free

ok florian@

Maintain mg's Public Domain license heritage.

Sunil Nimmagadda agrees.

add missing rcs ids

Add some cscope support to mg. From Sunil Nimmagadda. Due to some
structural limitations in mg, mg doesn't behave exactly the same as
emacs cscope (see the README) but is still very usable.

man page bits reviewed by jmc@, otherwise tested and reviewed by
myself.

Use absolute filenames while pushing and popping off the stack.

This fixes a segv discovered by Olivier A and reported to Sunil
Nimmagadda, who provided the actual fix. Tested by myself and
Oliver A.

Add some ctags support to mg. From Sunil Nimmagadda.

Man page review and suggestions from jmc@

Revewied and tested by myself, and ok deraadt@

When it's the possessive of 'it', it's spelled "its", without the
apostrophe.

Present the default choice before the colon in prompts. Matches GNU Emacs
behavior.

From Scott Cheloha <scottcheloha@gmail.com>

ok florian@

fix -Wshadow warnings.
Found by bcallah, thanks!

Fix possible NULL pointer dereference.

Found by Coverity Scan. The tagsvisit() function calls eread(),
which may return NULL. This is then immediately passed to stat()
without a proper check. This patch adds that check.

From Joachim Nilsson <troglobit@gmail.com> via lum@. Ok lum@

Update my mail address.

Return FALSE on parse errors.

Found by and Ok lum@.

Clean up the includes in mg.
This does the following:
Moves all POSIX headers from sysdef.h into the individual .c files so that
each file now only includes what it needs. All headers are properly sorted.
Moves the remainder of sysdef.h to other files (mostly def.h) and deletes
sysdef.h now that it's no longer contains anything.
Tweak a comment that references sysdef.h so that it no longer does that.
ok florian@

ctype macros/functions expect unsigned char values. Note that the lgetc()
macro does the cast internally like getc() does, so its return should be
put an in int for the same reason.

based on a diff from Kamil Rytarowski (n54 (at) gmx.com)

If no default tag defined, still let user input a tag to find.
From Sunil Nimmagadda.

Add some missing dobeeps.
ok florian@

add missing stdio.h include for fparseln().

from Ulrich Mueller, via Han Boetes
ok florian@

- fix a potential double free

ok florian@

Maintain mg's Public Domain license heritage.

Sunil Nimmagadda agrees.

add missing rcs ids

Add some cscope support to mg. From Sunil Nimmagadda. Due to some
structural limitations in mg, mg doesn't behave exactly the same as
emacs cscope (see the README) but is still very usable.

man page bits reviewed by jmc@, otherwise tested and reviewed by
myself.

Use absolute filenames while pushing and popping off the stack.

This fixes a segv discovered by Olivier A and reported to Sunil
Nimmagadda, who provided the actual fix. Tested by myself and
Oliver A.

Add some ctags support to mg. From Sunil Nimmagadda.

Man page review and suggestions from jmc@

Revewied and tested by myself, and ok deraadt@

Present the default choice before the colon in prompts. Matches GNU Emacs
behavior.

From Scott Cheloha <scottcheloha@gmail.com>

ok florian@

fix -Wshadow warnings.
Found by bcallah, thanks!

Fix possible NULL pointer dereference.

Found by Coverity Scan. The tagsvisit() function calls eread(),
which may return NULL. This is then immediately passed to stat()
without a proper check. This patch adds that check.

From Joachim Nilsson <troglobit@gmail.com> via lum@. Ok lum@

Update my mail address.

Return FALSE on parse errors.

Found by and Ok lum@.

Clean up the includes in mg.
This does the following:
Moves all POSIX headers from sysdef.h into the individual .c files so that
each file now only includes what it needs. All headers are properly sorted.
Moves the remainder of sysdef.h to other files (mostly def.h) and deletes
sysdef.h now that it's no longer contains anything.
Tweak a comment that references sysdef.h so that it no longer does that.
ok florian@

ctype macros/functions expect unsigned char values. Note that the lgetc()
macro does the cast internally like getc() does, so its return should be
put an in int for the same reason.

based on a diff from Kamil Rytarowski (n54 (at) gmx.com)

If no default tag defined, still let user input a tag to find.
From Sunil Nimmagadda.

Add some missing dobeeps.
ok florian@

add missing stdio.h include for fparseln().

from Ulrich Mueller, via Han Boetes
ok florian@

- fix a potential double free

ok florian@

Maintain mg's Public Domain license heritage.

Sunil Nimmagadda agrees.

add missing rcs ids

Add some cscope support to mg. From Sunil Nimmagadda. Due to some
structural limitations in mg, mg doesn't behave exactly the same as
emacs cscope (see the README) but is still very usable.

man page bits reviewed by jmc@, otherwise tested and reviewed by
myself.

Use absolute filenames while pushing and popping off the stack.

This fixes a segv discovered by Olivier A and reported to Sunil
Nimmagadda, who provided the actual fix. Tested by myself and
Oliver A.

Add some ctags support to mg. From Sunil Nimmagadda.

Man page review and suggestions from jmc@

Revewied and tested by myself, and ok deraadt@