Check if a signal already has been received before entering a blocking
read as opposed of only doing it afterwards. Issue uncovered by the mail
regress tests.

With claudio@ and ok millert@

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Replace usage of TIOCSTI in mail while editing headers using a more common
IO-loop where ICANON is disabled and a single char of input is read at a time.
This requires the line editing capabilities provided when ICANON is enabled to
be implemented.

ok deraadt@

ctype and other sign extension fixes.

with deraadt and millert, ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Fix off-by-one bug in readtty() and don't assume BUFSIZ == 1024.
Based on a patch from Ulf Harnhammar.

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Fix typo; SIGTTIN where SIGINT meant and rename a variable for clarity.

o kill strcpy()
o check return values of malloc and friends
o use strdup() when sensible

o ANSIfy
o Style nits
o Use const to silent stupid -Wall warnings
o strnc{py,at} -> strlc{py,at}
o Use strpbrk() instead of homegrown anyof()
o Use NULL instead of #defines with 0 cast to a pointer
This still could use a proper audit

Major signal overhaul. We no longer longjmp all over the place.
Instead, routines responsible to gathering user input (or in some
cases outputting data) catch the signals and set flags as needed.
Because of this some handlers are install without the SA_RESTART
flag so syscalls are not restarted and we can check the flag. All
signal handlers are now safe.

This should make the flow of control a bit more grokable but the
code is still ugly.

Remove evil #ifdef __GNUC__ garbage to avoid longjmp clobbering and
use volatile instead.

NetBSD changes (mostly comsmetic):
replace panic() with calls to err()/errx()
use S_IS* instead of doing by hand with S_IF*.
Use TIMESPEC_TO_TIMEVAL() and gettimeofday instead of time(2)
Use _POSIX_VDISABLE, not 0
Kill register

Add back EXTPROC code now that tty_pty.c has the lite2 fix.

Remove TIOCEXT added in lite2 merge for now. Causes problems when
mail(1) is used over a telnet session.

Fix one possible oflow (not exploitable) and do a wee bit of KNF.
Much more remains to be done.

grabh() now returns SIGINT if it was interrupted (previously always
returned 0 and the return val was always ignored).
Add gethfromtty() to get a header (using grabh) from the tty and
quit on two ^C's.
Use gethfromtty() when getting Subject, Cc, and Bcc headers so
we can quit nicely. Closes PR #291.
Don't use longs where it doesn't make sense.

Convert remaining sigsetmask() -> sigprocmask() (POSIX style)
in collect.c and fix up some signal botches elsewhere.

NOSTR -> NULL
Use sigsetjmp/siglongjmp instead of sigjmp/longjmp for portability.

bcopy() -> memcpy() and fix some casts.

Merge in NetBSD and 4.4BSD-lite2 changes as well as some of my own.
- handle long lines safely (from NetBSD)
- use puts/fputs and putchar/putc when it makes sense
- use err/errx and warn/warnx when it makes sense
- make return() and sizeof() style consisten
- some more buffer safety

from christos;
- Fix PR/105: Implement dot locking protocol and check return value of flock.
- Fix PR/2247: Don't call unknown users "ubluit". Issue an error message.
- Fix/add prototypes.
- Fix warnings.
- Use POSIX signal mask calls.

branches: 1.1.1;
Initial revision

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Replace usage of TIOCSTI in mail while editing headers using a more common
IO-loop where ICANON is disabled and a single char of input is read at a time.
This requires the line editing capabilities provided when ICANON is enabled to
be implemented.

ok deraadt@

ctype and other sign extension fixes.

with deraadt and millert, ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Fix off-by-one bug in readtty() and don't assume BUFSIZ == 1024.
Based on a patch from Ulf Harnhammar.

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Fix typo; SIGTTIN where SIGINT meant and rename a variable for clarity.

o kill strcpy()
o check return values of malloc and friends
o use strdup() when sensible

o ANSIfy
o Style nits
o Use const to silent stupid -Wall warnings
o strnc{py,at} -> strlc{py,at}
o Use strpbrk() instead of homegrown anyof()
o Use NULL instead of #defines with 0 cast to a pointer
This still could use a proper audit

Major signal overhaul. We no longer longjmp all over the place.
Instead, routines responsible to gathering user input (or in some
cases outputting data) catch the signals and set flags as needed.
Because of this some handlers are install without the SA_RESTART
flag so syscalls are not restarted and we can check the flag. All
signal handlers are now safe.

This should make the flow of control a bit more grokable but the
code is still ugly.

Remove evil #ifdef __GNUC__ garbage to avoid longjmp clobbering and
use volatile instead.

NetBSD changes (mostly comsmetic):
replace panic() with calls to err()/errx()
use S_IS* instead of doing by hand with S_IF*.
Use TIMESPEC_TO_TIMEVAL() and gettimeofday instead of time(2)
Use _POSIX_VDISABLE, not 0
Kill register

Add back EXTPROC code now that tty_pty.c has the lite2 fix.

Remove TIOCEXT added in lite2 merge for now. Causes problems when
mail(1) is used over a telnet session.

Fix one possible oflow (not exploitable) and do a wee bit of KNF.
Much more remains to be done.

grabh() now returns SIGINT if it was interrupted (previously always
returned 0 and the return val was always ignored).
Add gethfromtty() to get a header (using grabh) from the tty and
quit on two ^C's.
Use gethfromtty() when getting Subject, Cc, and Bcc headers so
we can quit nicely. Closes PR #291.
Don't use longs where it doesn't make sense.

Convert remaining sigsetmask() -> sigprocmask() (POSIX style)
in collect.c and fix up some signal botches elsewhere.

NOSTR -> NULL
Use sigsetjmp/siglongjmp instead of sigjmp/longjmp for portability.

bcopy() -> memcpy() and fix some casts.

Merge in NetBSD and 4.4BSD-lite2 changes as well as some of my own.
- handle long lines safely (from NetBSD)
- use puts/fputs and putchar/putc when it makes sense
- use err/errx and warn/warnx when it makes sense
- make return() and sizeof() style consisten
- some more buffer safety

from christos;
- Fix PR/105: Implement dot locking protocol and check return value of flock.
- Fix PR/2247: Don't call unknown users "ubluit". Issue an error message.
- Fix/add prototypes.
- Fix warnings.
- Use POSIX signal mask calls.

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Replace usage of TIOCSTI in mail while editing headers using a more common
IO-loop where ICANON is disabled and a single char of input is read at a time.
This requires the line editing capabilities provided when ICANON is enabled to
be implemented.

ok deraadt@

ctype and other sign extension fixes.

with deraadt and millert, ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Fix off-by-one bug in readtty() and don't assume BUFSIZ == 1024.
Based on a patch from Ulf Harnhammar.

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Fix typo; SIGTTIN where SIGINT meant and rename a variable for clarity.

o kill strcpy()
o check return values of malloc and friends
o use strdup() when sensible

o ANSIfy
o Style nits
o Use const to silent stupid -Wall warnings
o strnc{py,at} -> strlc{py,at}
o Use strpbrk() instead of homegrown anyof()
o Use NULL instead of #defines with 0 cast to a pointer
This still could use a proper audit

Major signal overhaul. We no longer longjmp all over the place.
Instead, routines responsible to gathering user input (or in some
cases outputting data) catch the signals and set flags as needed.
Because of this some handlers are install without the SA_RESTART
flag so syscalls are not restarted and we can check the flag. All
signal handlers are now safe.

This should make the flow of control a bit more grokable but the
code is still ugly.

Remove evil #ifdef __GNUC__ garbage to avoid longjmp clobbering and
use volatile instead.

NetBSD changes (mostly comsmetic):
replace panic() with calls to err()/errx()
use S_IS* instead of doing by hand with S_IF*.
Use TIMESPEC_TO_TIMEVAL() and gettimeofday instead of time(2)
Use _POSIX_VDISABLE, not 0
Kill register

Add back EXTPROC code now that tty_pty.c has the lite2 fix.

Remove TIOCEXT added in lite2 merge for now. Causes problems when
mail(1) is used over a telnet session.

Fix one possible oflow (not exploitable) and do a wee bit of KNF.
Much more remains to be done.

grabh() now returns SIGINT if it was interrupted (previously always
returned 0 and the return val was always ignored).
Add gethfromtty() to get a header (using grabh) from the tty and
quit on two ^C's.
Use gethfromtty() when getting Subject, Cc, and Bcc headers so
we can quit nicely. Closes PR #291.
Don't use longs where it doesn't make sense.

Convert remaining sigsetmask() -> sigprocmask() (POSIX style)
in collect.c and fix up some signal botches elsewhere.

NOSTR -> NULL
Use sigsetjmp/siglongjmp instead of sigjmp/longjmp for portability.

bcopy() -> memcpy() and fix some casts.

Merge in NetBSD and 4.4BSD-lite2 changes as well as some of my own.
- handle long lines safely (from NetBSD)
- use puts/fputs and putchar/putc when it makes sense
- use err/errx and warn/warnx when it makes sense
- make return() and sizeof() style consisten
- some more buffer safety

from christos;
- Fix PR/105: Implement dot locking protocol and check return value of flock.
- Fix PR/2247: Don't call unknown users "ubluit". Issue an error message.
- Fix/add prototypes.
- Fix warnings.
- Use POSIX signal mask calls.

branches: 1.1.1;
Initial revision

Replace usage of TIOCSTI in mail while editing headers using a more common
IO-loop where ICANON is disabled and a single char of input is read at a time.
This requires the line editing capabilities provided when ICANON is enabled to
be implemented.

ok deraadt@

ctype and other sign extension fixes.

with deraadt and millert, ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Fix off-by-one bug in readtty() and don't assume BUFSIZ == 1024.
Based on a patch from Ulf Harnhammar.

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Fix typo; SIGTTIN where SIGINT meant and rename a variable for clarity.

o kill strcpy()
o check return values of malloc and friends
o use strdup() when sensible

o ANSIfy
o Style nits
o Use const to silent stupid -Wall warnings
o strnc{py,at} -> strlc{py,at}
o Use strpbrk() instead of homegrown anyof()
o Use NULL instead of #defines with 0 cast to a pointer
This still could use a proper audit

Major signal overhaul. We no longer longjmp all over the place.
Instead, routines responsible to gathering user input (or in some
cases outputting data) catch the signals and set flags as needed.
Because of this some handlers are install without the SA_RESTART
flag so syscalls are not restarted and we can check the flag. All
signal handlers are now safe.

This should make the flow of control a bit more grokable but the
code is still ugly.

Remove evil #ifdef __GNUC__ garbage to avoid longjmp clobbering and
use volatile instead.

NetBSD changes (mostly comsmetic):
replace panic() with calls to err()/errx()
use S_IS* instead of doing by hand with S_IF*.
Use TIMESPEC_TO_TIMEVAL() and gettimeofday instead of time(2)
Use _POSIX_VDISABLE, not 0
Kill register

Add back EXTPROC code now that tty_pty.c has the lite2 fix.

Remove TIOCEXT added in lite2 merge for now. Causes problems when
mail(1) is used over a telnet session.

Fix one possible oflow (not exploitable) and do a wee bit of KNF.
Much more remains to be done.

grabh() now returns SIGINT if it was interrupted (previously always
returned 0 and the return val was always ignored).
Add gethfromtty() to get a header (using grabh) from the tty and
quit on two ^C's.
Use gethfromtty() when getting Subject, Cc, and Bcc headers so
we can quit nicely. Closes PR #291.
Don't use longs where it doesn't make sense.

Convert remaining sigsetmask() -> sigprocmask() (POSIX style)
in collect.c and fix up some signal botches elsewhere.

NOSTR -> NULL
Use sigsetjmp/siglongjmp instead of sigjmp/longjmp for portability.

bcopy() -> memcpy() and fix some casts.

Merge in NetBSD and 4.4BSD-lite2 changes as well as some of my own.
- handle long lines safely (from NetBSD)
- use puts/fputs and putchar/putc when it makes sense
- use err/errx and warn/warnx when it makes sense
- make return() and sizeof() style consisten
- some more buffer safety

from christos;
- Fix PR/105: Implement dot locking protocol and check return value of flock.
- Fix PR/2247: Don't call unknown users "ubluit". Issue an error message.
- Fix/add prototypes.
- Fix warnings.
- Use POSIX signal mask calls.

branches: 1.1.1;
Initial revision