spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

Cast isspace() argument to unsigned char.

ok jca@

Modernize allocation by:

* removing unneeded casts of void* return values
* replacing varied and creative error messages with the allocation
function's name
* replacing errx() with err() so that the errno string is reported

ok beck@, jung@, millert@

Use glob() to expand filenames instead of passing it to the shell's
echo command for expansion which could result in arbitrary command
execution. CVE-2004-2771

ctype and other sign extension fixes.

with deraadt and millert, ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

- err with the pathbuf, if we know it
- use tmpdir instead of /tmp
ok millert@

check if it's really a newline before removing it

with the help of ray@ "Looks OK" millert@

Proper use of fseek/fseeko macros.

OK joris@, otto@

"interupt" -> "interrupt" in various comments. Mostly from Diego Casati.

Fix undefined behavior (var = --var).

From Alexey Dobriyan <adobriyan at gmail dot com>.

OK moritz@ and jaredy@.

use SEEK_* for lseek()

delint; millert ok

protos

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Remove \n from err/errx/warn/warnx().

millert@ ok

We need to adjust where "dot" points when we realloc(message).
Problem found by Mike Heffner of the FreeBSD project.

o ANSIfy
o Style nits
o Use const to silent stupid -Wall warnings
o strnc{py,at} -> strlc{py,at}
o Use strpbrk() instead of homegrown anyof()
o Use NULL instead of #defines with 0 cast to a pointer
This still could use a proper audit

Major signal overhaul. We no longer longjmp all over the place.
Instead, routines responsible to gathering user input (or in some
cases outputting data) catch the signals and set flags as needed.
Because of this some handlers are install without the SA_RESTART
flag so syscalls are not restarted and we can check the flag. All
signal handlers are now safe.

This should make the flow of control a bit more grokable but the
code is still ugly.

Changes from Don Beusee:
o escape From line with a leading '>' when needed
o only print To: address and Subject lines if actually present
o new variable 'allnet' to treat user@foo and user@bar as the same "user"
o folders command now takes an optional argument like ls.
o new "pipe" (|) command to pipe the message through an arbitrary command
o make header display format the same as SunOS 4.1.3 /usr/ucb/mail
o tilde commands work regardless of interactive mode.
o fix "read: Interrupted system call" error by retrying if EINTR
o expanded help file
Changes by me:
o read the help file via the PAGER as it is now more than 24 lines long

$HOME paranoia: never use getenv("HOME") w/o checking for NULL and non-zero

Don't call truncate() directly; have rm() do it if we get EPERM on unlink()
In popen.c, findchild() may return NULL so catch that case.

Don't segfault just because a line starts with NUL; ross

NetBSD changes (mostly comsmetic):
replace panic() with calls to err()/errx()
use S_IS* instead of doing by hand with S_IF*.
Use TIMESPEC_TO_TIMEVAL() and gettimeofday instead of time(2)
Use _POSIX_VDISABLE, not 0
Kill register

Deal with <CR><LF> pairs in mailboxes so we can work with eudora mail
spools mounted from DOS/Windoze. From Matt Thomas <matt@3am-software.com>.

Kill union wait.

Dynamically allocate space for addr header strings instead of using
BUFSIZ. We know that the end size will be <= to the start size
so it is simple to preallocate enough space. Fixes NetBSD PR#3028

tempnam(3) goes bye bye.

Replace 3 tempnam()'s with mkstemp. The two left look tricky.

NOSTR -> NULL
Use sigsetjmp/siglongjmp instead of sigjmp/longjmp for portability.

bcopy() -> memcpy() and fix some casts.

Merge in NetBSD and 4.4BSD-lite2 changes as well as some of my own.
- handle long lines safely (from NetBSD)
- use puts/fputs and putchar/putc when it makes sense
- use err/errx and warn/warnx when it makes sense
- make return() and sizeof() style consisten
- some more buffer safety

overflows abound

Use ``mail.local -H'' to do dot locking so we can have mode 755 mail
spool, change an occurrence of tempnam() to mkstemp(), change some
longs and shorts to ints. Mail is now usable again.

r?index -> strr?chr

from christos;
- Fix PR/105: Implement dot locking protocol and check return value of flock.
- Fix PR/2247: Don't call unknown users "ubluit". Issue an error message.
- Fix/add prototypes.
- Fix warnings.
- Use POSIX signal mask calls.

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

Cast isspace() argument to unsigned char.

ok jca@

Modernize allocation by:

* removing unneeded casts of void* return values
* replacing varied and creative error messages with the allocation
function's name
* replacing errx() with err() so that the errno string is reported

ok beck@, jung@, millert@

Use glob() to expand filenames instead of passing it to the shell's
echo command for expansion which could result in arbitrary command
execution. CVE-2004-2771

ctype and other sign extension fixes.

with deraadt and millert, ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

- err with the pathbuf, if we know it
- use tmpdir instead of /tmp
ok millert@

check if it's really a newline before removing it

with the help of ray@ "Looks OK" millert@

Proper use of fseek/fseeko macros.

OK joris@, otto@

"interupt" -> "interrupt" in various comments. Mostly from Diego Casati.

Fix undefined behavior (var = --var).

From Alexey Dobriyan <adobriyan at gmail dot com>.

OK moritz@ and jaredy@.

use SEEK_* for lseek()

delint; millert ok

protos

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Remove \n from err/errx/warn/warnx().

millert@ ok

We need to adjust where "dot" points when we realloc(message).
Problem found by Mike Heffner of the FreeBSD project.

o ANSIfy
o Style nits
o Use const to silent stupid -Wall warnings
o strnc{py,at} -> strlc{py,at}
o Use strpbrk() instead of homegrown anyof()
o Use NULL instead of #defines with 0 cast to a pointer
This still could use a proper audit

Major signal overhaul. We no longer longjmp all over the place.
Instead, routines responsible to gathering user input (or in some
cases outputting data) catch the signals and set flags as needed.
Because of this some handlers are install without the SA_RESTART
flag so syscalls are not restarted and we can check the flag. All
signal handlers are now safe.

This should make the flow of control a bit more grokable but the
code is still ugly.

Changes from Don Beusee:
o escape From line with a leading '>' when needed
o only print To: address and Subject lines if actually present
o new variable 'allnet' to treat user@foo and user@bar as the same "user"
o folders command now takes an optional argument like ls.
o new "pipe" (|) command to pipe the message through an arbitrary command
o make header display format the same as SunOS 4.1.3 /usr/ucb/mail
o tilde commands work regardless of interactive mode.
o fix "read: Interrupted system call" error by retrying if EINTR
o expanded help file
Changes by me:
o read the help file via the PAGER as it is now more than 24 lines long

$HOME paranoia: never use getenv("HOME") w/o checking for NULL and non-zero

Don't call truncate() directly; have rm() do it if we get EPERM on unlink()
In popen.c, findchild() may return NULL so catch that case.

Don't segfault just because a line starts with NUL; ross

NetBSD changes (mostly comsmetic):
replace panic() with calls to err()/errx()
use S_IS* instead of doing by hand with S_IF*.
Use TIMESPEC_TO_TIMEVAL() and gettimeofday instead of time(2)
Use _POSIX_VDISABLE, not 0
Kill register

Deal with <CR><LF> pairs in mailboxes so we can work with eudora mail
spools mounted from DOS/Windoze. From Matt Thomas <matt@3am-software.com>.

Kill union wait.

Dynamically allocate space for addr header strings instead of using
BUFSIZ. We know that the end size will be <= to the start size
so it is simple to preallocate enough space. Fixes NetBSD PR#3028

tempnam(3) goes bye bye.

Replace 3 tempnam()'s with mkstemp. The two left look tricky.

NOSTR -> NULL
Use sigsetjmp/siglongjmp instead of sigjmp/longjmp for portability.

bcopy() -> memcpy() and fix some casts.

Merge in NetBSD and 4.4BSD-lite2 changes as well as some of my own.
- handle long lines safely (from NetBSD)
- use puts/fputs and putchar/putc when it makes sense
- use err/errx and warn/warnx when it makes sense
- make return() and sizeof() style consisten
- some more buffer safety

overflows abound

Use ``mail.local -H'' to do dot locking so we can have mode 755 mail
spool, change an occurrence of tempnam() to mkstemp(), change some
longs and shorts to ints. Mail is now usable again.

r?index -> strr?chr

from christos;
- Fix PR/105: Implement dot locking protocol and check return value of flock.
- Fix PR/2247: Don't call unknown users "ubluit". Issue an error message.
- Fix/add prototypes.
- Fix warnings.
- Use POSIX signal mask calls.

branches: 1.1.1;
Initial revision

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

Cast isspace() argument to unsigned char.

ok jca@

Modernize allocation by:

* removing unneeded casts of void* return values
* replacing varied and creative error messages with the allocation
function's name
* replacing errx() with err() so that the errno string is reported

ok beck@, jung@, millert@

Use glob() to expand filenames instead of passing it to the shell's
echo command for expansion which could result in arbitrary command
execution. CVE-2004-2771

ctype and other sign extension fixes.

with deraadt and millert, ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

- err with the pathbuf, if we know it
- use tmpdir instead of /tmp
ok millert@

check if it's really a newline before removing it

with the help of ray@ "Looks OK" millert@

Proper use of fseek/fseeko macros.

OK joris@, otto@

"interupt" -> "interrupt" in various comments. Mostly from Diego Casati.

Fix undefined behavior (var = --var).

From Alexey Dobriyan <adobriyan at gmail dot com>.

OK moritz@ and jaredy@.

use SEEK_* for lseek()

delint; millert ok

protos

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Remove \n from err/errx/warn/warnx().

millert@ ok

We need to adjust where "dot" points when we realloc(message).
Problem found by Mike Heffner of the FreeBSD project.

o ANSIfy
o Style nits
o Use const to silent stupid -Wall warnings
o strnc{py,at} -> strlc{py,at}
o Use strpbrk() instead of homegrown anyof()
o Use NULL instead of #defines with 0 cast to a pointer
This still could use a proper audit

Major signal overhaul. We no longer longjmp all over the place.
Instead, routines responsible to gathering user input (or in some
cases outputting data) catch the signals and set flags as needed.
Because of this some handlers are install without the SA_RESTART
flag so syscalls are not restarted and we can check the flag. All
signal handlers are now safe.

This should make the flow of control a bit more grokable but the
code is still ugly.

Changes from Don Beusee:
o escape From line with a leading '>' when needed
o only print To: address and Subject lines if actually present
o new variable 'allnet' to treat user@foo and user@bar as the same "user"
o folders command now takes an optional argument like ls.
o new "pipe" (|) command to pipe the message through an arbitrary command
o make header display format the same as SunOS 4.1.3 /usr/ucb/mail
o tilde commands work regardless of interactive mode.
o fix "read: Interrupted system call" error by retrying if EINTR
o expanded help file
Changes by me:
o read the help file via the PAGER as it is now more than 24 lines long

$HOME paranoia: never use getenv("HOME") w/o checking for NULL and non-zero

Don't call truncate() directly; have rm() do it if we get EPERM on unlink()
In popen.c, findchild() may return NULL so catch that case.

Don't segfault just because a line starts with NUL; ross

NetBSD changes (mostly comsmetic):
replace panic() with calls to err()/errx()
use S_IS* instead of doing by hand with S_IF*.
Use TIMESPEC_TO_TIMEVAL() and gettimeofday instead of time(2)
Use _POSIX_VDISABLE, not 0
Kill register

Deal with <CR><LF> pairs in mailboxes so we can work with eudora mail
spools mounted from DOS/Windoze. From Matt Thomas <matt@3am-software.com>.

Kill union wait.

Dynamically allocate space for addr header strings instead of using
BUFSIZ. We know that the end size will be <= to the start size
so it is simple to preallocate enough space. Fixes NetBSD PR#3028

tempnam(3) goes bye bye.

Replace 3 tempnam()'s with mkstemp. The two left look tricky.

NOSTR -> NULL
Use sigsetjmp/siglongjmp instead of sigjmp/longjmp for portability.

bcopy() -> memcpy() and fix some casts.

Merge in NetBSD and 4.4BSD-lite2 changes as well as some of my own.
- handle long lines safely (from NetBSD)
- use puts/fputs and putchar/putc when it makes sense
- use err/errx and warn/warnx when it makes sense
- make return() and sizeof() style consisten
- some more buffer safety

overflows abound

Use ``mail.local -H'' to do dot locking so we can have mode 755 mail
spool, change an occurrence of tempnam() to mkstemp(), change some
longs and shorts to ints. Mail is now usable again.

r?index -> strr?chr

from christos;
- Fix PR/105: Implement dot locking protocol and check return value of flock.
- Fix PR/2247: Don't call unknown users "ubluit". Issue an error message.
- Fix/add prototypes.
- Fix warnings.
- Use POSIX signal mask calls.

branches: 1.1.1;
Initial revision

Cast isspace() argument to unsigned char.

ok jca@

Modernize allocation by:

* removing unneeded casts of void* return values
* replacing varied and creative error messages with the allocation
function's name
* replacing errx() with err() so that the errno string is reported

ok beck@, jung@, millert@

Use glob() to expand filenames instead of passing it to the shell's
echo command for expansion which could result in arbitrary command
execution. CVE-2004-2771

ctype and other sign extension fixes.

with deraadt and millert, ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

- err with the pathbuf, if we know it
- use tmpdir instead of /tmp
ok millert@

check if it's really a newline before removing it

with the help of ray@ "Looks OK" millert@

Proper use of fseek/fseeko macros.

OK joris@, otto@

"interupt" -> "interrupt" in various comments. Mostly from Diego Casati.

Fix undefined behavior (var = --var).

From Alexey Dobriyan <adobriyan at gmail dot com>.

OK moritz@ and jaredy@.

use SEEK_* for lseek()

delint; millert ok

protos

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Remove \n from err/errx/warn/warnx().

millert@ ok

We need to adjust where "dot" points when we realloc(message).
Problem found by Mike Heffner of the FreeBSD project.

o ANSIfy
o Style nits
o Use const to silent stupid -Wall warnings
o strnc{py,at} -> strlc{py,at}
o Use strpbrk() instead of homegrown anyof()
o Use NULL instead of #defines with 0 cast to a pointer
This still could use a proper audit

Major signal overhaul. We no longer longjmp all over the place.
Instead, routines responsible to gathering user input (or in some
cases outputting data) catch the signals and set flags as needed.
Because of this some handlers are install without the SA_RESTART
flag so syscalls are not restarted and we can check the flag. All
signal handlers are now safe.

This should make the flow of control a bit more grokable but the
code is still ugly.

Changes from Don Beusee:
o escape From line with a leading '>' when needed
o only print To: address and Subject lines if actually present
o new variable 'allnet' to treat user@foo and user@bar as the same "user"
o folders command now takes an optional argument like ls.
o new "pipe" (|) command to pipe the message through an arbitrary command
o make header display format the same as SunOS 4.1.3 /usr/ucb/mail
o tilde commands work regardless of interactive mode.
o fix "read: Interrupted system call" error by retrying if EINTR
o expanded help file
Changes by me:
o read the help file via the PAGER as it is now more than 24 lines long

$HOME paranoia: never use getenv("HOME") w/o checking for NULL and non-zero

Don't call truncate() directly; have rm() do it if we get EPERM on unlink()
In popen.c, findchild() may return NULL so catch that case.

Don't segfault just because a line starts with NUL; ross

NetBSD changes (mostly comsmetic):
replace panic() with calls to err()/errx()
use S_IS* instead of doing by hand with S_IF*.
Use TIMESPEC_TO_TIMEVAL() and gettimeofday instead of time(2)
Use _POSIX_VDISABLE, not 0
Kill register

Deal with <CR><LF> pairs in mailboxes so we can work with eudora mail
spools mounted from DOS/Windoze. From Matt Thomas <matt@3am-software.com>.

Kill union wait.

Dynamically allocate space for addr header strings instead of using
BUFSIZ. We know that the end size will be <= to the start size
so it is simple to preallocate enough space. Fixes NetBSD PR#3028

tempnam(3) goes bye bye.

Replace 3 tempnam()'s with mkstemp. The two left look tricky.

NOSTR -> NULL
Use sigsetjmp/siglongjmp instead of sigjmp/longjmp for portability.

bcopy() -> memcpy() and fix some casts.

Merge in NetBSD and 4.4BSD-lite2 changes as well as some of my own.
- handle long lines safely (from NetBSD)
- use puts/fputs and putchar/putc when it makes sense
- use err/errx and warn/warnx when it makes sense
- make return() and sizeof() style consisten
- some more buffer safety

overflows abound

Use ``mail.local -H'' to do dot locking so we can have mode 755 mail
spool, change an occurrence of tempnam() to mkstemp(), change some
longs and shorts to ints. Mail is now usable again.

r?index -> strr?chr

from christos;
- Fix PR/105: Implement dot locking protocol and check return value of flock.
- Fix PR/2247: Don't call unknown users "ubluit". Issue an error message.
- Fix/add prototypes.
- Fix warnings.
- Use POSIX signal mask calls.

branches: 1.1.1;
Initial revision