Delete support for the LESSOPEN and LESSCLOSE environment variables
aka the "Input Preprocessor": it's been a source for multiple
security bugs in the past as everything has to deal with handling
arbitrary filenames and generally resulted in multiple TOCTOU issues.
The base system never included a default LESSOPEN setting like some
Linux distributions did, but it's a suds-filled sink full of knives
to try to use safely.

ok tb@ deraadt@ millert@

Bugfix:
Delete ugly and incorrect workaround for a Linux kernel bug.
If a file is temporarily empty, that by no means implies
it might be permanently non-seekable.

Patch from seL4 at disroot dot org on tech@.
OK both Theos: tb@ and deraadt@

less uses a correct raceless signal method of indicating signal events in
a volatile sig_atomic_t variable, and then processing events in the mainloop.
But only one variable was used for 3 signals, with |= bit operations which
are signal interruptable! Rewrite the code to use 3 independent variables
and cleanup how the mainloop observes indications.
ok schwarze

Fix use after free that caused the creation of a spurious file.

As guenther@ said "fix whatever led to the \337 x 16 crap".

anton@ came up with the same diff. ok nicm@

little bit more KNF

style(9) includes

ok nicm@

Wrap a macro's args in parentheses. No binary change.

I'm discussing with deraadt@ whether it's a good idea to convert some of
these to functions. The one changed by this commit probably isn't
eligible because it defines only a for loop's condition, but many others
in less(1) should probably be converted.

ok millert@

Put macro arg in parentheses.

ok nicm@

use (off_t)-1 rather than a BAD_LSEEK wrapper

error() is not a stdarg function, so there is no reason for NULL_PARG
to be special. Simply use NULL.

Garrett D'Amore has agreed to moving his copyright line up above the
terms with the existing copyright, so it is clear it applies the same
terms.

deregister

Replace less with the cleaned-up fork of less 458 maintained by Garrett
D'Amore at https://github.com/gdamore/less-fork. This has significantly
less portability goop, has a tidied up code style, uses terminfo instead
of termcap, and is has stricter POSIX compliance.

Many of our local changes have been accepted upstream: substantial
remaining local changes are code to read help files from /usr/share
rather than compiling them in, man page and help improvements, and some
tweaks to the default options.

Review and testing by millert, ok deraadt

Merge Less 458 plus local patches

ok guenther@, ok jmc@ for man bits

Use volatile sig_atomic_t, not int, for the sigs variable. Also
move the call to bell() out of u_interrupt() (a signal handler).
OK and with help from deraadt@

Merge in less 444 plus local changes

ok nicm@

use SEEK_* for lseek()

Remove some double semicolons (hmm, do two semis equal a maxi?).
I've skipped the GNU stuff for now. From Patrick Latifi.

o go back to using a help file instead of embedding it in the binary
o deal with HELPFILE not being defined
o add a SMALL definition to make a smaller less for the boot floppies
This still needs to be pared down a bit for the SMALL case

Merge in less-381 w/ local changes and remove obsolete files.

kill more registers

millert@ ok

$OpenBSD$

branches: 1.1.1;
Initial revision

Bugfix:
Delete ugly and incorrect workaround for a Linux kernel bug.
If a file is temporarily empty, that by no means implies
it might be permanently non-seekable.

Patch from seL4 at disroot dot org on tech@.
OK both Theos: tb@ and deraadt@

less uses a correct raceless signal method of indicating signal events in
a volatile sig_atomic_t variable, and then processing events in the mainloop.
But only one variable was used for 3 signals, with |= bit operations which
are signal interruptable! Rewrite the code to use 3 independent variables
and cleanup how the mainloop observes indications.
ok schwarze

Fix use after free that caused the creation of a spurious file.

As guenther@ said "fix whatever led to the \337 x 16 crap".

anton@ came up with the same diff. ok nicm@

little bit more KNF

style(9) includes

ok nicm@

Wrap a macro's args in parentheses. No binary change.

I'm discussing with deraadt@ whether it's a good idea to convert some of
these to functions. The one changed by this commit probably isn't
eligible because it defines only a for loop's condition, but many others
in less(1) should probably be converted.

ok millert@

Put macro arg in parentheses.

ok nicm@

use (off_t)-1 rather than a BAD_LSEEK wrapper

error() is not a stdarg function, so there is no reason for NULL_PARG
to be special. Simply use NULL.

Garrett D'Amore has agreed to moving his copyright line up above the
terms with the existing copyright, so it is clear it applies the same
terms.

deregister

Replace less with the cleaned-up fork of less 458 maintained by Garrett
D'Amore at https://github.com/gdamore/less-fork. This has significantly
less portability goop, has a tidied up code style, uses terminfo instead
of termcap, and is has stricter POSIX compliance.

Many of our local changes have been accepted upstream: substantial
remaining local changes are code to read help files from /usr/share
rather than compiling them in, man page and help improvements, and some
tweaks to the default options.

Review and testing by millert, ok deraadt

Merge Less 458 plus local patches

ok guenther@, ok jmc@ for man bits

Use volatile sig_atomic_t, not int, for the sigs variable. Also
move the call to bell() out of u_interrupt() (a signal handler).
OK and with help from deraadt@

Merge in less 444 plus local changes

ok nicm@

use SEEK_* for lseek()

Remove some double semicolons (hmm, do two semis equal a maxi?).
I've skipped the GNU stuff for now. From Patrick Latifi.

o go back to using a help file instead of embedding it in the binary
o deal with HELPFILE not being defined
o add a SMALL definition to make a smaller less for the boot floppies
This still needs to be pared down a bit for the SMALL case

Merge in less-381 w/ local changes and remove obsolete files.

kill more registers

millert@ ok

$OpenBSD$

branches: 1.1.1;
Initial revision

less uses a correct raceless signal method of indicating signal events in
a volatile sig_atomic_t variable, and then processing events in the mainloop.
But only one variable was used for 3 signals, with |= bit operations which
are signal interruptable! Rewrite the code to use 3 independent variables
and cleanup how the mainloop observes indications.
ok schwarze

Fix use after free that caused the creation of a spurious file.

As guenther@ said "fix whatever led to the \337 x 16 crap".

anton@ came up with the same diff. ok nicm@

little bit more KNF

style(9) includes

ok nicm@

Wrap a macro's args in parentheses. No binary change.

I'm discussing with deraadt@ whether it's a good idea to convert some of
these to functions. The one changed by this commit probably isn't
eligible because it defines only a for loop's condition, but many others
in less(1) should probably be converted.

ok millert@

Put macro arg in parentheses.

ok nicm@

use (off_t)-1 rather than a BAD_LSEEK wrapper

error() is not a stdarg function, so there is no reason for NULL_PARG
to be special. Simply use NULL.

Garrett D'Amore has agreed to moving his copyright line up above the
terms with the existing copyright, so it is clear it applies the same
terms.

deregister

Replace less with the cleaned-up fork of less 458 maintained by Garrett
D'Amore at https://github.com/gdamore/less-fork. This has significantly
less portability goop, has a tidied up code style, uses terminfo instead
of termcap, and is has stricter POSIX compliance.

Many of our local changes have been accepted upstream: substantial
remaining local changes are code to read help files from /usr/share
rather than compiling them in, man page and help improvements, and some
tweaks to the default options.

Review and testing by millert, ok deraadt

Merge Less 458 plus local patches

ok guenther@, ok jmc@ for man bits

Use volatile sig_atomic_t, not int, for the sigs variable. Also
move the call to bell() out of u_interrupt() (a signal handler).
OK and with help from deraadt@

Merge in less 444 plus local changes

ok nicm@

use SEEK_* for lseek()

Remove some double semicolons (hmm, do two semis equal a maxi?).
I've skipped the GNU stuff for now. From Patrick Latifi.

o go back to using a help file instead of embedding it in the binary
o deal with HELPFILE not being defined
o add a SMALL definition to make a smaller less for the boot floppies
This still needs to be pared down a bit for the SMALL case

Merge in less-381 w/ local changes and remove obsolete files.

kill more registers

millert@ ok

$OpenBSD$

branches: 1.1.1;
Initial revision

Fix use after free that caused the creation of a spurious file.

As guenther@ said "fix whatever led to the \337 x 16 crap".

anton@ came up with the same diff. ok nicm@

little bit more KNF

style(9) includes

ok nicm@

Wrap a macro's args in parentheses. No binary change.

I'm discussing with deraadt@ whether it's a good idea to convert some of
these to functions. The one changed by this commit probably isn't
eligible because it defines only a for loop's condition, but many others
in less(1) should probably be converted.

ok millert@

Put macro arg in parentheses.

ok nicm@

use (off_t)-1 rather than a BAD_LSEEK wrapper

error() is not a stdarg function, so there is no reason for NULL_PARG
to be special. Simply use NULL.

Garrett D'Amore has agreed to moving his copyright line up above the
terms with the existing copyright, so it is clear it applies the same
terms.

deregister

Replace less with the cleaned-up fork of less 458 maintained by Garrett
D'Amore at https://github.com/gdamore/less-fork. This has significantly
less portability goop, has a tidied up code style, uses terminfo instead
of termcap, and is has stricter POSIX compliance.

Many of our local changes have been accepted upstream: substantial
remaining local changes are code to read help files from /usr/share
rather than compiling them in, man page and help improvements, and some
tweaks to the default options.

Review and testing by millert, ok deraadt

Merge Less 458 plus local patches

ok guenther@, ok jmc@ for man bits

Use volatile sig_atomic_t, not int, for the sigs variable. Also
move the call to bell() out of u_interrupt() (a signal handler).
OK and with help from deraadt@

Merge in less 444 plus local changes

ok nicm@

use SEEK_* for lseek()

Remove some double semicolons (hmm, do two semis equal a maxi?).
I've skipped the GNU stuff for now. From Patrick Latifi.

o go back to using a help file instead of embedding it in the binary
o deal with HELPFILE not being defined
o add a SMALL definition to make a smaller less for the boot floppies
This still needs to be pared down a bit for the SMALL case

Merge in less-381 w/ local changes and remove obsolete files.

kill more registers

millert@ ok

$OpenBSD$

branches: 1.1.1;
Initial revision

little bit more KNF

style(9) includes

ok nicm@

Wrap a macro's args in parentheses. No binary change.

I'm discussing with deraadt@ whether it's a good idea to convert some of
these to functions. The one changed by this commit probably isn't
eligible because it defines only a for loop's condition, but many others
in less(1) should probably be converted.

ok millert@

Put macro arg in parentheses.

ok nicm@

use (off_t)-1 rather than a BAD_LSEEK wrapper

error() is not a stdarg function, so there is no reason for NULL_PARG
to be special. Simply use NULL.

Garrett D'Amore has agreed to moving his copyright line up above the
terms with the existing copyright, so it is clear it applies the same
terms.

deregister

Replace less with the cleaned-up fork of less 458 maintained by Garrett
D'Amore at https://github.com/gdamore/less-fork. This has significantly
less portability goop, has a tidied up code style, uses terminfo instead
of termcap, and is has stricter POSIX compliance.

Many of our local changes have been accepted upstream: substantial
remaining local changes are code to read help files from /usr/share
rather than compiling them in, man page and help improvements, and some
tweaks to the default options.

Review and testing by millert, ok deraadt

Merge Less 458 plus local patches

ok guenther@, ok jmc@ for man bits

Use volatile sig_atomic_t, not int, for the sigs variable. Also
move the call to bell() out of u_interrupt() (a signal handler).
OK and with help from deraadt@

Merge in less 444 plus local changes

ok nicm@

use SEEK_* for lseek()

Remove some double semicolons (hmm, do two semis equal a maxi?).
I've skipped the GNU stuff for now. From Patrick Latifi.

o go back to using a help file instead of embedding it in the binary
o deal with HELPFILE not being defined
o add a SMALL definition to make a smaller less for the boot floppies
This still needs to be pared down a bit for the SMALL case

Merge in less-381 w/ local changes and remove obsolete files.

kill more registers

millert@ ok

$OpenBSD$

branches: 1.1.1;
Initial revision