For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Change the error reporting pattern throughout the tree when unveil
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.

Work done and verified by Ashton Fagg <ashton@fagg.id.au>

ok deraadt@ semarie@ claudio@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

pledge() a little later, after getopt operation, in case -f option changes
the filename. We can then unveil that file, pledge() as before, and proceed
to parsing.

pledge "stdio rpath".

Do not cast result of malloc/calloc/realloc* if stdlib.h is in scope
ok krw millert

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

use ctime_r to avoid a re-entrancy signal race
ok millert

in getopt() blocks, stop incrementing flag variable which are supposed
to just be 0/1
ok miod florian

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

init crmsg to something so it doesn't crash on invalid wtmp files.
from david higgs

Prefer setvbuf() to setlinebuf() for portability; ok deraadt@

Instead of special casing ftpd, uucpd and others that may have entries
in wtmp, go the other way and exclude entries we know ('console' and
'tty') from pid stripping, then strip the rest.

idea, feedback and ok millert@

remove special case for uucp entries.

ok guenther

Correct some time_t printing; factor out a grotty block while here

Based on a diff from Arto Jonsson (ajonsson (at) kapsi.fi)
ok deraadt@

Correct format string mismatches turned up by -Wformat=2

suggestions and ok millert@

Fix after last commit: add missing header.
sthen@ ok.

Reflect the -f option in last's output. Original diff from Jacob L. Leifman.
Other feedback from Callum Davies and sthen@
ok mpi@ ian@ kettenis@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

add missing header needed by isdigit()

ok otto@ millert@ gilles@

- simplify and sort synopsis
- sort options
- some minor text tweaks
- sync usage()

fix fd leak; then i got a bit carried away making the code prettier

Replace numeric argument handling (e.g. last -30) with something that
can deal with mixer number and normal arguments, adapted from my code
in diff(1). OK deraadt@

Add a new -n option that replaces the old -number option (which now
only exists for backwards compat).
Based on a diff from robert@; OK robert@ and deraadt@

Fix uninitialized variable. From Ilya Voronin <ivoronin at trancom dot ru>

Typos in comments from Jared Yanovich <jjy2+ at pitt dot edu>

make 9-char login names not stretch the line; millert ok

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

avoid more signal races

minor tweak to error message, from Eric in pr3235

fix time spec even better; emmf26@umr.edu

make usage exactly like in the man page; andrushock@korovino.net

simple snprintf and strlcpy; henning ok

Add missing includes, breaks and semicolons to appease gcc3; David Krause
deraadt@ OK

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

fix a typo; from Sam Smith <S@mSmith.net>

mark a zone of signal races

-Wall cleanup

first pass at a -Wall cleanup

Change host width to 24 so last produces one line per user; deraadt ok.

move utmp to large format, usernames to 32 chars; downsj

incorrect time specification; noted by sigh@kuzirabekon.econ.nagasaki-u.ac.jp

ftpd: sleep for an indeterminate amount for non-existant logins
to simulate a crypt, like login does.
Use SEEK_* not L_* and kill some 0L's used in lseek while we're there.

print year; mason@primenet.com.au

Add -c (for humans) and -s (for machines).

incorrect type for variable; enami@but-b.or.jp

correct [yy]yy stuff in manpages and usage

-T to display seconds, from jhawk netbsd-pr#1548

minor cleanup on the -d flag code

add -d flag for reporting active sessions at a specified point in time.

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

Change the error reporting pattern throughout the tree when unveil
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.

Work done and verified by Ashton Fagg <ashton@fagg.id.au>

ok deraadt@ semarie@ claudio@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

pledge() a little later, after getopt operation, in case -f option changes
the filename. We can then unveil that file, pledge() as before, and proceed
to parsing.

pledge "stdio rpath".

Do not cast result of malloc/calloc/realloc* if stdlib.h is in scope
ok krw millert

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

use ctime_r to avoid a re-entrancy signal race
ok millert

in getopt() blocks, stop incrementing flag variable which are supposed
to just be 0/1
ok miod florian

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

init crmsg to something so it doesn't crash on invalid wtmp files.
from david higgs

Prefer setvbuf() to setlinebuf() for portability; ok deraadt@

Instead of special casing ftpd, uucpd and others that may have entries
in wtmp, go the other way and exclude entries we know ('console' and
'tty') from pid stripping, then strip the rest.

idea, feedback and ok millert@

remove special case for uucp entries.

ok guenther

Correct some time_t printing; factor out a grotty block while here

Based on a diff from Arto Jonsson (ajonsson (at) kapsi.fi)
ok deraadt@

Correct format string mismatches turned up by -Wformat=2

suggestions and ok millert@

Fix after last commit: add missing header.
sthen@ ok.

Reflect the -f option in last's output. Original diff from Jacob L. Leifman.
Other feedback from Callum Davies and sthen@
ok mpi@ ian@ kettenis@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

add missing header needed by isdigit()

ok otto@ millert@ gilles@

- simplify and sort synopsis
- sort options
- some minor text tweaks
- sync usage()

fix fd leak; then i got a bit carried away making the code prettier

Replace numeric argument handling (e.g. last -30) with something that
can deal with mixer number and normal arguments, adapted from my code
in diff(1). OK deraadt@

Add a new -n option that replaces the old -number option (which now
only exists for backwards compat).
Based on a diff from robert@; OK robert@ and deraadt@

Fix uninitialized variable. From Ilya Voronin <ivoronin at trancom dot ru>

Typos in comments from Jared Yanovich <jjy2+ at pitt dot edu>

make 9-char login names not stretch the line; millert ok

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

avoid more signal races

minor tweak to error message, from Eric in pr3235

fix time spec even better; emmf26@umr.edu

make usage exactly like in the man page; andrushock@korovino.net

simple snprintf and strlcpy; henning ok

Add missing includes, breaks and semicolons to appease gcc3; David Krause
deraadt@ OK

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

fix a typo; from Sam Smith <S@mSmith.net>

mark a zone of signal races

-Wall cleanup

first pass at a -Wall cleanup

Change host width to 24 so last produces one line per user; deraadt ok.

move utmp to large format, usernames to 32 chars; downsj

incorrect time specification; noted by sigh@kuzirabekon.econ.nagasaki-u.ac.jp

ftpd: sleep for an indeterminate amount for non-existant logins
to simulate a crypt, like login does.
Use SEEK_* not L_* and kill some 0L's used in lseek while we're there.

print year; mason@primenet.com.au

Add -c (for humans) and -s (for machines).

incorrect type for variable; enami@but-b.or.jp

correct [yy]yy stuff in manpages and usage

-T to display seconds, from jhawk netbsd-pr#1548

minor cleanup on the -d flag code

add -d flag for reporting active sessions at a specified point in time.

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

pledge() a little later, after getopt operation, in case -f option changes
the filename. We can then unveil that file, pledge() as before, and proceed
to parsing.

pledge "stdio rpath".

Do not cast result of malloc/calloc/realloc* if stdlib.h is in scope
ok krw millert

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

use ctime_r to avoid a re-entrancy signal race
ok millert

in getopt() blocks, stop incrementing flag variable which are supposed
to just be 0/1
ok miod florian

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

init crmsg to something so it doesn't crash on invalid wtmp files.
from david higgs

Prefer setvbuf() to setlinebuf() for portability; ok deraadt@

Instead of special casing ftpd, uucpd and others that may have entries
in wtmp, go the other way and exclude entries we know ('console' and
'tty') from pid stripping, then strip the rest.

idea, feedback and ok millert@

remove special case for uucp entries.

ok guenther

Correct some time_t printing; factor out a grotty block while here

Based on a diff from Arto Jonsson (ajonsson (at) kapsi.fi)
ok deraadt@

Correct format string mismatches turned up by -Wformat=2

suggestions and ok millert@

Fix after last commit: add missing header.
sthen@ ok.

Reflect the -f option in last's output. Original diff from Jacob L. Leifman.
Other feedback from Callum Davies and sthen@
ok mpi@ ian@ kettenis@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

add missing header needed by isdigit()

ok otto@ millert@ gilles@

- simplify and sort synopsis
- sort options
- some minor text tweaks
- sync usage()

fix fd leak; then i got a bit carried away making the code prettier

Replace numeric argument handling (e.g. last -30) with something that
can deal with mixer number and normal arguments, adapted from my code
in diff(1). OK deraadt@

Add a new -n option that replaces the old -number option (which now
only exists for backwards compat).
Based on a diff from robert@; OK robert@ and deraadt@

Fix uninitialized variable. From Ilya Voronin <ivoronin at trancom dot ru>

Typos in comments from Jared Yanovich <jjy2+ at pitt dot edu>

make 9-char login names not stretch the line; millert ok

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

avoid more signal races

minor tweak to error message, from Eric in pr3235

fix time spec even better; emmf26@umr.edu

make usage exactly like in the man page; andrushock@korovino.net

simple snprintf and strlcpy; henning ok

Add missing includes, breaks and semicolons to appease gcc3; David Krause
deraadt@ OK

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

fix a typo; from Sam Smith <S@mSmith.net>

mark a zone of signal races

-Wall cleanup

first pass at a -Wall cleanup

Change host width to 24 so last produces one line per user; deraadt ok.

move utmp to large format, usernames to 32 chars; downsj

incorrect time specification; noted by sigh@kuzirabekon.econ.nagasaki-u.ac.jp

ftpd: sleep for an indeterminate amount for non-existant logins
to simulate a crypt, like login does.
Use SEEK_* not L_* and kill some 0L's used in lseek while we're there.

print year; mason@primenet.com.au

Add -c (for humans) and -s (for machines).

incorrect type for variable; enami@but-b.or.jp

correct [yy]yy stuff in manpages and usage

-T to display seconds, from jhawk netbsd-pr#1548

minor cleanup on the -d flag code

add -d flag for reporting active sessions at a specified point in time.

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

pledge() a little later, after getopt operation, in case -f option changes
the filename. We can then unveil that file, pledge() as before, and proceed
to parsing.

pledge "stdio rpath".

Do not cast result of malloc/calloc/realloc* if stdlib.h is in scope
ok krw millert

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

use ctime_r to avoid a re-entrancy signal race
ok millert

in getopt() blocks, stop incrementing flag variable which are supposed
to just be 0/1
ok miod florian

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

init crmsg to something so it doesn't crash on invalid wtmp files.
from david higgs

Prefer setvbuf() to setlinebuf() for portability; ok deraadt@

Instead of special casing ftpd, uucpd and others that may have entries
in wtmp, go the other way and exclude entries we know ('console' and
'tty') from pid stripping, then strip the rest.

idea, feedback and ok millert@

remove special case for uucp entries.

ok guenther

Correct some time_t printing; factor out a grotty block while here

Based on a diff from Arto Jonsson (ajonsson (at) kapsi.fi)
ok deraadt@

Correct format string mismatches turned up by -Wformat=2

suggestions and ok millert@

Fix after last commit: add missing header.
sthen@ ok.

Reflect the -f option in last's output. Original diff from Jacob L. Leifman.
Other feedback from Callum Davies and sthen@
ok mpi@ ian@ kettenis@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

add missing header needed by isdigit()

ok otto@ millert@ gilles@

- simplify and sort synopsis
- sort options
- some minor text tweaks
- sync usage()

fix fd leak; then i got a bit carried away making the code prettier

Replace numeric argument handling (e.g. last -30) with something that
can deal with mixer number and normal arguments, adapted from my code
in diff(1). OK deraadt@

Add a new -n option that replaces the old -number option (which now
only exists for backwards compat).
Based on a diff from robert@; OK robert@ and deraadt@

Fix uninitialized variable. From Ilya Voronin <ivoronin at trancom dot ru>

Typos in comments from Jared Yanovich <jjy2+ at pitt dot edu>

make 9-char login names not stretch the line; millert ok

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

avoid more signal races

minor tweak to error message, from Eric in pr3235

fix time spec even better; emmf26@umr.edu

make usage exactly like in the man page; andrushock@korovino.net

simple snprintf and strlcpy; henning ok

Add missing includes, breaks and semicolons to appease gcc3; David Krause
deraadt@ OK

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

fix a typo; from Sam Smith <S@mSmith.net>

mark a zone of signal races

-Wall cleanup

first pass at a -Wall cleanup

Change host width to 24 so last produces one line per user; deraadt ok.

move utmp to large format, usernames to 32 chars; downsj

incorrect time specification; noted by sigh@kuzirabekon.econ.nagasaki-u.ac.jp

ftpd: sleep for an indeterminate amount for non-existant logins
to simulate a crypt, like login does.
Use SEEK_* not L_* and kill some 0L's used in lseek while we're there.

print year; mason@primenet.com.au

Add -c (for humans) and -s (for machines).

incorrect type for variable; enami@but-b.or.jp

correct [yy]yy stuff in manpages and usage

-T to display seconds, from jhawk netbsd-pr#1548

minor cleanup on the -d flag code

add -d flag for reporting active sessions at a specified point in time.

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

pledge "stdio rpath".

Do not cast result of malloc/calloc/realloc* if stdlib.h is in scope
ok krw millert

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

use ctime_r to avoid a re-entrancy signal race
ok millert

in getopt() blocks, stop incrementing flag variable which are supposed
to just be 0/1
ok miod florian

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

init crmsg to something so it doesn't crash on invalid wtmp files.
from david higgs

Prefer setvbuf() to setlinebuf() for portability; ok deraadt@

Instead of special casing ftpd, uucpd and others that may have entries
in wtmp, go the other way and exclude entries we know ('console' and
'tty') from pid stripping, then strip the rest.

idea, feedback and ok millert@

remove special case for uucp entries.

ok guenther

Correct some time_t printing; factor out a grotty block while here

Based on a diff from Arto Jonsson (ajonsson (at) kapsi.fi)
ok deraadt@

Correct format string mismatches turned up by -Wformat=2

suggestions and ok millert@

Fix after last commit: add missing header.
sthen@ ok.

Reflect the -f option in last's output. Original diff from Jacob L. Leifman.
Other feedback from Callum Davies and sthen@
ok mpi@ ian@ kettenis@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

add missing header needed by isdigit()

ok otto@ millert@ gilles@

- simplify and sort synopsis
- sort options
- some minor text tweaks
- sync usage()

fix fd leak; then i got a bit carried away making the code prettier

Replace numeric argument handling (e.g. last -30) with something that
can deal with mixer number and normal arguments, adapted from my code
in diff(1). OK deraadt@

Add a new -n option that replaces the old -number option (which now
only exists for backwards compat).
Based on a diff from robert@; OK robert@ and deraadt@

Fix uninitialized variable. From Ilya Voronin <ivoronin at trancom dot ru>

Typos in comments from Jared Yanovich <jjy2+ at pitt dot edu>

make 9-char login names not stretch the line; millert ok

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

avoid more signal races

minor tweak to error message, from Eric in pr3235

fix time spec even better; emmf26@umr.edu

make usage exactly like in the man page; andrushock@korovino.net

simple snprintf and strlcpy; henning ok

Add missing includes, breaks and semicolons to appease gcc3; David Krause
deraadt@ OK

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

fix a typo; from Sam Smith <S@mSmith.net>

mark a zone of signal races

-Wall cleanup

first pass at a -Wall cleanup

Change host width to 24 so last produces one line per user; deraadt ok.

move utmp to large format, usernames to 32 chars; downsj

incorrect time specification; noted by sigh@kuzirabekon.econ.nagasaki-u.ac.jp

ftpd: sleep for an indeterminate amount for non-existant logins
to simulate a crypt, like login does.
Use SEEK_* not L_* and kill some 0L's used in lseek while we're there.

print year; mason@primenet.com.au

Add -c (for humans) and -s (for machines).

incorrect type for variable; enami@but-b.or.jp

correct [yy]yy stuff in manpages and usage

-T to display seconds, from jhawk netbsd-pr#1548

minor cleanup on the -d flag code

add -d flag for reporting active sessions at a specified point in time.

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision