Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

MAXCOMLEN is no longer needed in these programs, so remove the annotation
from sys/param.h include lines, or remove the include lines entirely if
it this was the least requirement.
ok millert

A couple commands don't need sys/param.h, but they do need sys/signal.h

add -T option to make time related system calls more prominent.
ok deraadt

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

set tracefile to null when clearing points.
ok kn

usr/bin/ktrace: replace snprintf(3)/write(2) with dprintf(3)

Brought to attention by BlackFrog on #openbsd-daily

OK deraadt@

Add 'p' trace point for KTRFAC_PLEDGE, as noted by
Michal Mazurek <akfaew@jasminek.net>

While here, fix handling of -t+ in ltrace.

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

when ktrace() return ESRCH, the error is regarding the pid, not the pathname
ok miod

add -t to usage() for ltrace;

Add the -t ktrace(1) option to ltrace(1), so that you can trigger both
library function call trace and other kernel events trace at the same time.

Suggested by kurt@ a long time ago, I have been sitting on this diff for no
good reason.

fix spacing in usage()

typo in usage, comand/command; Arto Jonsson

Introduce ltrace(1). This tool works with ld.so to inject utrace record for
each plt call, allowing to trace a binary linked against shared library at the
public function call level.

To do so, ltrace(1) sets up some environment variables to enable plt tracing
in ld.so, and invokes ktrace(2) for utrace events. ld.so will force lazy
binding and will send an utrace record in the plt resolver, without updating
the plt.

Minimal filtering capabilities are provided, inspired by Solaris' truss -u,
to limit tracing to libraries and/or symbol names. Non-traced libraries and
symbols will have the regular resolver processing, with the expected plt
update.

"Get it in" deraadt

add -B to usage();

Add -B option to pass down LD_BIND_NOW to suppress ld.so blather

ok pirofti@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

matthew haub pointed out that pid may be used uninitialized in some contexts
ok deraadt

let synopsis, options description, and usage() agree;
from Igor Sobrado, tweaked by myself

Userland programs should include <errno.h> not <sys/errno.h>
OK deraadt@

ARGSUSED before signal handler with unused signo

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

improve docs; raj@cerias.purdue.edu

bring in prototypes

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

get rid of signal race

Add lots of missing prototypes, constify a few things. Add explicit ints.
Makes gcc much happier, less warnings.

first pass at a -Wall cleanup

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.8.4;
More <sys/file.h> vs. <fcntl.h> and open() flags fixes.

fix usage; nathanw@MIT.EDU

Someone forgot to declare the "sb" variable...

unlink ktrace file more carefully; wosch/joerg

getopt(3) returns -1 when out of args, not EOF, whee!

gen ktrace.out with restrictive umask; from joerg@freebsd.org

rcsid

branches: 1.1.1;
Initial revision

MAXCOMLEN is no longer needed in these programs, so remove the annotation
from sys/param.h include lines, or remove the include lines entirely if
it this was the least requirement.
ok millert

A couple commands don't need sys/param.h, but they do need sys/signal.h

add -T option to make time related system calls more prominent.
ok deraadt

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

set tracefile to null when clearing points.
ok kn

usr/bin/ktrace: replace snprintf(3)/write(2) with dprintf(3)

Brought to attention by BlackFrog on #openbsd-daily

OK deraadt@

Add 'p' trace point for KTRFAC_PLEDGE, as noted by
Michal Mazurek <akfaew@jasminek.net>

While here, fix handling of -t+ in ltrace.

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

when ktrace() return ESRCH, the error is regarding the pid, not the pathname
ok miod

add -t to usage() for ltrace;

Add the -t ktrace(1) option to ltrace(1), so that you can trigger both
library function call trace and other kernel events trace at the same time.

Suggested by kurt@ a long time ago, I have been sitting on this diff for no
good reason.

fix spacing in usage()

typo in usage, comand/command; Arto Jonsson

Introduce ltrace(1). This tool works with ld.so to inject utrace record for
each plt call, allowing to trace a binary linked against shared library at the
public function call level.

To do so, ltrace(1) sets up some environment variables to enable plt tracing
in ld.so, and invokes ktrace(2) for utrace events. ld.so will force lazy
binding and will send an utrace record in the plt resolver, without updating
the plt.

Minimal filtering capabilities are provided, inspired by Solaris' truss -u,
to limit tracing to libraries and/or symbol names. Non-traced libraries and
symbols will have the regular resolver processing, with the expected plt
update.

"Get it in" deraadt

add -B to usage();

Add -B option to pass down LD_BIND_NOW to suppress ld.so blather

ok pirofti@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

matthew haub pointed out that pid may be used uninitialized in some contexts
ok deraadt

let synopsis, options description, and usage() agree;
from Igor Sobrado, tweaked by myself

Userland programs should include <errno.h> not <sys/errno.h>
OK deraadt@

ARGSUSED before signal handler with unused signo

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

improve docs; raj@cerias.purdue.edu

bring in prototypes

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

get rid of signal race

Add lots of missing prototypes, constify a few things. Add explicit ints.
Makes gcc much happier, less warnings.

first pass at a -Wall cleanup

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.8.4;
More <sys/file.h> vs. <fcntl.h> and open() flags fixes.

fix usage; nathanw@MIT.EDU

Someone forgot to declare the "sb" variable...

unlink ktrace file more carefully; wosch/joerg

getopt(3) returns -1 when out of args, not EOF, whee!

gen ktrace.out with restrictive umask; from joerg@freebsd.org

rcsid

branches: 1.1.1;
Initial revision

A couple commands don't need sys/param.h, but they do need sys/signal.h

add -T option to make time related system calls more prominent.
ok deraadt

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

set tracefile to null when clearing points.
ok kn

usr/bin/ktrace: replace snprintf(3)/write(2) with dprintf(3)

Brought to attention by BlackFrog on #openbsd-daily

OK deraadt@

Add 'p' trace point for KTRFAC_PLEDGE, as noted by
Michal Mazurek <akfaew@jasminek.net>

While here, fix handling of -t+ in ltrace.

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

when ktrace() return ESRCH, the error is regarding the pid, not the pathname
ok miod

add -t to usage() for ltrace;

Add the -t ktrace(1) option to ltrace(1), so that you can trigger both
library function call trace and other kernel events trace at the same time.

Suggested by kurt@ a long time ago, I have been sitting on this diff for no
good reason.

fix spacing in usage()

typo in usage, comand/command; Arto Jonsson

Introduce ltrace(1). This tool works with ld.so to inject utrace record for
each plt call, allowing to trace a binary linked against shared library at the
public function call level.

To do so, ltrace(1) sets up some environment variables to enable plt tracing
in ld.so, and invokes ktrace(2) for utrace events. ld.so will force lazy
binding and will send an utrace record in the plt resolver, without updating
the plt.

Minimal filtering capabilities are provided, inspired by Solaris' truss -u,
to limit tracing to libraries and/or symbol names. Non-traced libraries and
symbols will have the regular resolver processing, with the expected plt
update.

"Get it in" deraadt

add -B to usage();

Add -B option to pass down LD_BIND_NOW to suppress ld.so blather

ok pirofti@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

matthew haub pointed out that pid may be used uninitialized in some contexts
ok deraadt

let synopsis, options description, and usage() agree;
from Igor Sobrado, tweaked by myself

Userland programs should include <errno.h> not <sys/errno.h>
OK deraadt@

ARGSUSED before signal handler with unused signo

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

improve docs; raj@cerias.purdue.edu

bring in prototypes

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

get rid of signal race

Add lots of missing prototypes, constify a few things. Add explicit ints.
Makes gcc much happier, less warnings.

first pass at a -Wall cleanup

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.8.4;
More <sys/file.h> vs. <fcntl.h> and open() flags fixes.

fix usage; nathanw@MIT.EDU

Someone forgot to declare the "sb" variable...

unlink ktrace file more carefully; wosch/joerg

getopt(3) returns -1 when out of args, not EOF, whee!

gen ktrace.out with restrictive umask; from joerg@freebsd.org

rcsid

branches: 1.1.1;
Initial revision

add -T option to make time related system calls more prominent.
ok deraadt

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

set tracefile to null when clearing points.
ok kn

usr/bin/ktrace: replace snprintf(3)/write(2) with dprintf(3)

Brought to attention by BlackFrog on #openbsd-daily

OK deraadt@

Add 'p' trace point for KTRFAC_PLEDGE, as noted by
Michal Mazurek <akfaew@jasminek.net>

While here, fix handling of -t+ in ltrace.

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

when ktrace() return ESRCH, the error is regarding the pid, not the pathname
ok miod

add -t to usage() for ltrace;

Add the -t ktrace(1) option to ltrace(1), so that you can trigger both
library function call trace and other kernel events trace at the same time.

Suggested by kurt@ a long time ago, I have been sitting on this diff for no
good reason.

fix spacing in usage()

typo in usage, comand/command; Arto Jonsson

Introduce ltrace(1). This tool works with ld.so to inject utrace record for
each plt call, allowing to trace a binary linked against shared library at the
public function call level.

To do so, ltrace(1) sets up some environment variables to enable plt tracing
in ld.so, and invokes ktrace(2) for utrace events. ld.so will force lazy
binding and will send an utrace record in the plt resolver, without updating
the plt.

Minimal filtering capabilities are provided, inspired by Solaris' truss -u,
to limit tracing to libraries and/or symbol names. Non-traced libraries and
symbols will have the regular resolver processing, with the expected plt
update.

"Get it in" deraadt

add -B to usage();

Add -B option to pass down LD_BIND_NOW to suppress ld.so blather

ok pirofti@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

matthew haub pointed out that pid may be used uninitialized in some contexts
ok deraadt

let synopsis, options description, and usage() agree;
from Igor Sobrado, tweaked by myself

Userland programs should include <errno.h> not <sys/errno.h>
OK deraadt@

ARGSUSED before signal handler with unused signo

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

improve docs; raj@cerias.purdue.edu

bring in prototypes

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

get rid of signal race

Add lots of missing prototypes, constify a few things. Add explicit ints.
Makes gcc much happier, less warnings.

first pass at a -Wall cleanup

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.8.4;
More <sys/file.h> vs. <fcntl.h> and open() flags fixes.

fix usage; nathanw@MIT.EDU

Someone forgot to declare the "sb" variable...

unlink ktrace file more carefully; wosch/joerg

getopt(3) returns -1 when out of args, not EOF, whee!

gen ktrace.out with restrictive umask; from joerg@freebsd.org

rcsid

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

set tracefile to null when clearing points.
ok kn

usr/bin/ktrace: replace snprintf(3)/write(2) with dprintf(3)

Brought to attention by BlackFrog on #openbsd-daily

OK deraadt@

Add 'p' trace point for KTRFAC_PLEDGE, as noted by
Michal Mazurek <akfaew@jasminek.net>

While here, fix handling of -t+ in ltrace.

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

when ktrace() return ESRCH, the error is regarding the pid, not the pathname
ok miod

add -t to usage() for ltrace;

Add the -t ktrace(1) option to ltrace(1), so that you can trigger both
library function call trace and other kernel events trace at the same time.

Suggested by kurt@ a long time ago, I have been sitting on this diff for no
good reason.

fix spacing in usage()

typo in usage, comand/command; Arto Jonsson

Introduce ltrace(1). This tool works with ld.so to inject utrace record for
each plt call, allowing to trace a binary linked against shared library at the
public function call level.

To do so, ltrace(1) sets up some environment variables to enable plt tracing
in ld.so, and invokes ktrace(2) for utrace events. ld.so will force lazy
binding and will send an utrace record in the plt resolver, without updating
the plt.

Minimal filtering capabilities are provided, inspired by Solaris' truss -u,
to limit tracing to libraries and/or symbol names. Non-traced libraries and
symbols will have the regular resolver processing, with the expected plt
update.

"Get it in" deraadt

add -B to usage();

Add -B option to pass down LD_BIND_NOW to suppress ld.so blather

ok pirofti@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

matthew haub pointed out that pid may be used uninitialized in some contexts
ok deraadt

let synopsis, options description, and usage() agree;
from Igor Sobrado, tweaked by myself

Userland programs should include <errno.h> not <sys/errno.h>
OK deraadt@

ARGSUSED before signal handler with unused signo

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

improve docs; raj@cerias.purdue.edu

bring in prototypes

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

get rid of signal race

Add lots of missing prototypes, constify a few things. Add explicit ints.
Makes gcc much happier, less warnings.

first pass at a -Wall cleanup

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.8.4;
More <sys/file.h> vs. <fcntl.h> and open() flags fixes.

fix usage; nathanw@MIT.EDU

Someone forgot to declare the "sb" variable...

unlink ktrace file more carefully; wosch/joerg

getopt(3) returns -1 when out of args, not EOF, whee!

gen ktrace.out with restrictive umask; from joerg@freebsd.org

rcsid

branches: 1.1.1;
Initial revision

set tracefile to null when clearing points.
ok kn

usr/bin/ktrace: replace snprintf(3)/write(2) with dprintf(3)

Brought to attention by BlackFrog on #openbsd-daily

OK deraadt@

Add 'p' trace point for KTRFAC_PLEDGE, as noted by
Michal Mazurek <akfaew@jasminek.net>

While here, fix handling of -t+ in ltrace.

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

when ktrace() return ESRCH, the error is regarding the pid, not the pathname
ok miod

add -t to usage() for ltrace;

Add the -t ktrace(1) option to ltrace(1), so that you can trigger both
library function call trace and other kernel events trace at the same time.

Suggested by kurt@ a long time ago, I have been sitting on this diff for no
good reason.

fix spacing in usage()

typo in usage, comand/command; Arto Jonsson

Introduce ltrace(1). This tool works with ld.so to inject utrace record for
each plt call, allowing to trace a binary linked against shared library at the
public function call level.

To do so, ltrace(1) sets up some environment variables to enable plt tracing
in ld.so, and invokes ktrace(2) for utrace events. ld.so will force lazy
binding and will send an utrace record in the plt resolver, without updating
the plt.

Minimal filtering capabilities are provided, inspired by Solaris' truss -u,
to limit tracing to libraries and/or symbol names. Non-traced libraries and
symbols will have the regular resolver processing, with the expected plt
update.

"Get it in" deraadt

add -B to usage();

Add -B option to pass down LD_BIND_NOW to suppress ld.so blather

ok pirofti@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

matthew haub pointed out that pid may be used uninitialized in some contexts
ok deraadt

let synopsis, options description, and usage() agree;
from Igor Sobrado, tweaked by myself

Userland programs should include <errno.h> not <sys/errno.h>
OK deraadt@

ARGSUSED before signal handler with unused signo

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

improve docs; raj@cerias.purdue.edu

bring in prototypes

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

get rid of signal race

Add lots of missing prototypes, constify a few things. Add explicit ints.
Makes gcc much happier, less warnings.

first pass at a -Wall cleanup

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.8.4;
More <sys/file.h> vs. <fcntl.h> and open() flags fixes.

fix usage; nathanw@MIT.EDU

Someone forgot to declare the "sb" variable...

unlink ktrace file more carefully; wosch/joerg

getopt(3) returns -1 when out of args, not EOF, whee!

gen ktrace.out with restrictive umask; from joerg@freebsd.org

rcsid

branches: 1.1.1;
Initial revision

usr/bin/ktrace: replace snprintf(3)/write(2) with dprintf(3)

Brought to attention by BlackFrog on #openbsd-daily

OK deraadt@

Add 'p' trace point for KTRFAC_PLEDGE, as noted by
Michal Mazurek <akfaew@jasminek.net>

While here, fix handling of -t+ in ltrace.

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

when ktrace() return ESRCH, the error is regarding the pid, not the pathname
ok miod

add -t to usage() for ltrace;

Add the -t ktrace(1) option to ltrace(1), so that you can trigger both
library function call trace and other kernel events trace at the same time.

Suggested by kurt@ a long time ago, I have been sitting on this diff for no
good reason.

fix spacing in usage()

typo in usage, comand/command; Arto Jonsson

Introduce ltrace(1). This tool works with ld.so to inject utrace record for
each plt call, allowing to trace a binary linked against shared library at the
public function call level.

To do so, ltrace(1) sets up some environment variables to enable plt tracing
in ld.so, and invokes ktrace(2) for utrace events. ld.so will force lazy
binding and will send an utrace record in the plt resolver, without updating
the plt.

Minimal filtering capabilities are provided, inspired by Solaris' truss -u,
to limit tracing to libraries and/or symbol names. Non-traced libraries and
symbols will have the regular resolver processing, with the expected plt
update.

"Get it in" deraadt

add -B to usage();

Add -B option to pass down LD_BIND_NOW to suppress ld.so blather

ok pirofti@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

matthew haub pointed out that pid may be used uninitialized in some contexts
ok deraadt

let synopsis, options description, and usage() agree;
from Igor Sobrado, tweaked by myself

Userland programs should include <errno.h> not <sys/errno.h>
OK deraadt@

ARGSUSED before signal handler with unused signo

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

improve docs; raj@cerias.purdue.edu

bring in prototypes

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

get rid of signal race

Add lots of missing prototypes, constify a few things. Add explicit ints.
Makes gcc much happier, less warnings.

first pass at a -Wall cleanup

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.8.4;
More <sys/file.h> vs. <fcntl.h> and open() flags fixes.

fix usage; nathanw@MIT.EDU

Someone forgot to declare the "sb" variable...

unlink ktrace file more carefully; wosch/joerg

getopt(3) returns -1 when out of args, not EOF, whee!

gen ktrace.out with restrictive umask; from joerg@freebsd.org

rcsid

branches: 1.1.1;
Initial revision