Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Remove now-unused connect_wait() function.

Use non-blocking connect() with ppoll() and timeout instead of alarm().
For hosts with multiple IP addrs this makes it possible to fall
over from an unresponsive IP to another. This also replaces the
other connect(2) + connect_wait() calls with timed_connect() so the
-w option now works for more that just http. OK sthen@ deraadt@

introduce support for sending the If-Modified-Since header while
fetching over http(s) and use the timestamps from the remote server's
Last-Modified header if available when saving local files
this makes it possible to mirror files better with ftp(1)

the new timestamp behaviour can be disabled with the new '-u' flag

ok sthen@, input from sthen@ and gnezdo@

Accommodate POSIX basename(3) that takes a non-const parameter and
may modify the string buffer.

improved and ok jca@

in 2014 I added this annotation: /* XXX floating point printf in signal handler */
our snprintf is reentrant safe except for floating point.
Break the double apart into integer.integer notation, to avoid that.
ok kettenis millert

various knf and whitespace; ok jca

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

mkstemp() returns -1 on failure

Revert suni'ls ftp rewrite for now.
We are juggling too many things at the moment and we can't deal with
the differences in behaviour right now.

add rcs ids

Move us from old ftp(1) to Sunil's new ftp(1). The necessary modifications
have been made to make it behave. Any new misbehaviors can be fixed in tree.

OK florian@ deraadt@ "Have you committed ftp yet?"

Use the monotonic clock for logging progress in cdio(1) and ftp(1).

Keeps the progress log from blipping or stalling if, e.g., the
system time is changed in the midst of a rip or a transfer.

ok tb@ jca@

Avoid a possible leak in progressmeter

From Scott Cheloha, ok bluhm@

Nuke whitespace foolish enough to expose itself during the great
"warning:" rectification.

#ifndef SMALL around a couple of non-SMALL labels.

ok deraadt@

Don't attempt to read .netrc when we already force anonymous FTP (-a).

Patch from Anton Lindqvist via tech@, thanks!

okay deraadt@

Use connect(2) + a connect_wait() function instead of connect_sync(),
similar to the example in connect(2). OK tedu@

Move connect_sync() to util.c and use it when connecting via http
too. OK sthen@ deraadt@

Convert remaining calls to strtoq/strtouq in base with strtoll/strtoull.
Fix a type mismatch in ftp's "page" command and could make transfers restart
at the wrong position.

ok and a ull->ll tweak from natano@, ok tedu@

these programs probably do not need to use TMPDIR. ok florian

More "(<blah> *)0" -> NULL, avoiding any stdarg functions.

Feedback millert@ kettenis@

Remove NULL-checks before free(). ok tb@

unrelated commit; not ready yet

First casualty of making pledge "dns" mandatory for dns users.
"dns" was missing, and this was relying on "inet" support..

A whole buncha unsigned char casts for ctype function arguments.

ok guenther@

Eliminate use of TM_YEAR_BASE. OK guenther@ deraadt@ miod@

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

remove the safeguard against porting to machines without 8 bit bytes.
allows removing sys/param.h include as well.

remove tenex transfer support. if you still have TOPS20 machines in
service, you'll need to stick with openbsd 5.6.
bonus: remove references to ebcdic.
ok deraadt

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

I found a number of interactive events which can cause signals, and go
down paths not previously marked as signal handled unsafe. Try to clean
up a few of them especially regarding errno, mark others as unsafe, and
repair a few by avoiding stdio. Glanced at by misc people in Slovenia,
but considered too risky before release..

Unbreak ftp progress meter after the introduction of the '-D' flag

ok tedu@

Add -D shorttitle support, so that the progress meter can show some sort
of reason why it is processing a certain file. This will be used by the
installer for that purpose.
ok krw rpe

do not walk off the prefix array, off by one; found by parfait
ok jsg millert

show which username login failed for; ok martynas

make it clean removing the ifdef SMALL maze. separate cmds and
small stuff. make it a fetcher. shrinks quite a bit
agreed by millert@, krw@
ok theo, sthen@

remove uploading and macros support from install media; to save
some space
discussed with theo, todd@, millert@
tested and looked over by sthen@

toast the rcsid strings which just get in the way

figure out titles automatically by using remote file name. remove
-T and just show titles by default for non-verbose transfers;
discussed with, ok theo, sthen@

make two similar text strings identical; improves consistency and shrinks
the text segment slightly (though due to padding it does not change the size
of the binary). ok martynas@

add a "-T title" option to ftp; this is is used in progress bar mode to
show which filename is being used. ok krw, mdoc repair from jmc

on some servers LIST defaults to LIST -a. ignore pseudo-directories
so that recursive transfers don't cause a loop. problem reported
and tested by Jesus Sanchez. string compare inlining and looks
good to millert@

default file transfer type is binary, not ascii;
commands which toggle settings can take an explicit on or off argument
to force the setting appropiately, show these arguments in usage;
synchronize synopsis and usage of commands; spacing; KNF;
other minor documentation tweaks.

written with help by jmc@

ok jmc@ (documentation), martynas@ (type usage and default file transfer type)

- add support for recursive transfers (but not for floppies), e.g.
'mget -cr 4.*' would recursively fetch (-r), and resume the previous
transfers (-c) of 4.X release directories
uses local matching (fnmatch), but only for recursive transfers.
current behavior is not changed in any way.
- while here, ifndef SMALL debugging stuff, this saves some space,
for floppies
- some debugging code was enabled for non-debugging mode, checks
assume debug is set to zero, but it's not initially set
- all "Confirm with" prompts are forced, remove redundant argument
- fix usage: -C and -c are not available for SMALL

discussed a year ago w/ pyr@
looks good to millert@
previous version looked good to pyr@
man page tweaks & ok jmc@

First pass at removing clauses 3 and 4 from NetBSD licenses.

Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code that NetBSD has claimed for itself without attributing to the
actual authors.

OK deraadt@

in resume mode, pass -c to mget when {dir,file}hasglob, so that i'm
able to continue multiple transfers with -C; ok millert@
while here fix some comments (!SMALL vs. SMALL stuff), and add
missing

- add 'q', which does the same as eof
- add '?', which will help
- make use of mflag, instead of special-case interactive
- change mflag++ to mflag = 1, because theoretically it can go out
of range
"i like it" millert@. man page help and ok jmc@

fix transfer interrupting when confirmrest mode is used. change
confirm() to have a 'force' argument, so that ointer/oconf dance
is not needed, and to prevent further bugs like this; ok millert@

make further prompts work after eof, don't spam with prompts in
m*() cases; ok millert@

Remove #if 0 code that has been unused for nearly a decade (and
probably doesn't compile, since the types for some variables have
changed from long to char *).

OK millert@

use strcspn to properly overwrite '\n' in fgets returned buffer

ok pyr@, ray@, millert@, moritz@, chl@

Remove the .netrc parser when compiling a SMALL binary.
there is no .netrc file on the install media and keeping the parser
shaves a good deal of bytes in the binary.
ok millert@, "go on" deraadt@, "makes sense" steven@

Pass full buffer size to fgets.

OK moritz@ and jaredy@.

Add checks for fgets and properly overwrite newline.

Initial patch from Charles Longeau <chl at tuxfamily dot org>.

OK moritz@ and jaredy@.

Remove shadowing variables and properly use /* FALLTHROUGH */
comments. No binary change.

Found by lint.

OK beck@, deraadt@

two strtol calls that were begging to be converted to strtonum

Fix mget directory traversal vulnerability. From NetBSD. CAN-2002-1345.
ok millert@ deraadt@, prodding by david@

knf; cloder ok

type corrections and other delinting

ansi; khalek@linuxgamers.net

for -DSMALL, do not include rcsid[]s

New libedit api changes.

Tested by djm@, mouring@, jmc@.

ok deraadt@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Some NetBSD changes were committed to this file w/o updating the
copyright. I have gone through the cvs logs and added the appropriate
NetBSD Foundation copyright corresponding to those changes.

string fixes; ok miod henning

Treat empty environment variables the same as NULL. henning@ OK

http redirect support; adapted from NetBSD.

malloc/strdup failure not handled; cloder@acm.org

stretch banners

Fix gethostname() usage.

deraadt@ ok

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

first pass at a -Wall cleanup

Change default transfer type from ascii to binary; closes PR 1626
Similar to patch from mpech@prosoft.org.lv

0-size files still deserve a progress meter; also, after file is finished
transfer, display a non-ETA line with an elapsed time.

Work-around for lame servers that return `19100' for a date.

Based on NetBSD patch, slightly trimmed since we don't use the fractional
part yet...

ftp(1) from KAME, should be good for testing.

if winsize.ws_col is 0, assume 80

make the progress meter run correctly in all cases if in -m mode

make signal handlers save/restore errno

recommended fix from tri@iki.fi...

Y2K fixes from Andreas.Gunnarsson@emw.ericsson.se; culled from various places

prompting error; pr#352, blair@nac.net

Don't error out if the remote server doesn't support the "MDTM"
command. Based on a patch from Martin Fredriksson <martin@netman.se>.

- Move `parsed_url' label such that the next statement after the label is
not an "else" (which some strict compilers reject).

- If getlogin() fails fall back on getpwuid(getuid()).

Updtaes from NetBSD (lukem)
bugs fixed:
* don't interpret '-' or '|' when a local filename is determined from
the remote name (i.e, in mget, and in get with only one argument).
This is implemented using an extra argument to recvrequest().
Fixes a major security hole.
* clean up memory leak when using globulize()
* clean up a couple of comments
* fix wording in TNF copyright

features added:
* support for TIS fwtk gate-ftp servers:
* read defaults from $FTPSERVER && $FTPSERVERPORT
* start in gate-ftp mode if invoked as 'gate-ftp'
* toggle or set with 'gate [host [port]]'

Other changes:
* use symbolic flags in access(2)
* Use USHRT_MAX, not 0xffff

dumb fix for dumb users-- ftp's mget now idiot-proofs input!

Updates from NetBSD (lukem) include -Wall cleanup.
More -W* cleanup and in_port_t usage by me.

Disable progress meter if started as a bg process. Also don't
print the progress meter if the ftp process is put in the bg
(but do print it when/if the process is foregrounded).
From Enami Tsugutomo <enami@ba2.so-net.or.jp> with tweaks by me.

Only retry login as "anonymous" if we are doing anonftp.
Found by grr@openbsd.org.

This fixes FTP so that it first tries with the username FTP, and then with
the username ANONYMOUS. It works, too :-)

allow "ftp -aV ftp://host/foo.tar.gz | tar xvfpz -" to work

Sync with NetBSD (lukem):
* differentiate between being connected, and being logged in
* cleanup some text messages
* support username & password ftp URLs (ftp://user:pass@host/) in non-proxy
situations; assume proxy supports it for proxy situations.
* cd to / before performing any autofetch transfers

Sync with NetBSD (lukem)
* support $ftp_proxy for ftp:// transfers [bin/3245]
* add "more" & "less" as synonyms for "page"
* move editline setup code into controlediting(), and call appropriately.
only setup setup terminal if going into interactive mode.

Sync with NetBSD and fix "get foo.txt /dev/tty" wrt progress meter
and setting times.

Include signal.h where reasonable and make signal handlers match
what signal(3)'s prototype says (and cast when not).
Also change MAXFOO+1 -> MAXFOO since MAXFOO includes the NULL.
Support $TMPDIR and use utime(3) not utimes(2) for portability's sake.
Don't spew "Passive mode enabled/disabled" unless verbose (this means
togglevar() needs to watch for a NULL 'message').

Add back ``-r'' option and fix strncpy() usage and other nits because
I'm anal. Closer to KNF now.

Sync with NetBSD

Remove now-unused connect_wait() function.

Use non-blocking connect() with ppoll() and timeout instead of alarm().
For hosts with multiple IP addrs this makes it possible to fall
over from an unresponsive IP to another. This also replaces the
other connect(2) + connect_wait() calls with timed_connect() so the
-w option now works for more that just http. OK sthen@ deraadt@

introduce support for sending the If-Modified-Since header while
fetching over http(s) and use the timestamps from the remote server's
Last-Modified header if available when saving local files
this makes it possible to mirror files better with ftp(1)

the new timestamp behaviour can be disabled with the new '-u' flag

ok sthen@, input from sthen@ and gnezdo@

Accommodate POSIX basename(3) that takes a non-const parameter and
may modify the string buffer.

improved and ok jca@

in 2014 I added this annotation: /* XXX floating point printf in signal handler */
our snprintf is reentrant safe except for floating point.
Break the double apart into integer.integer notation, to avoid that.
ok kettenis millert

various knf and whitespace; ok jca

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

mkstemp() returns -1 on failure

Revert suni'ls ftp rewrite for now.
We are juggling too many things at the moment and we can't deal with
the differences in behaviour right now.

add rcs ids

Move us from old ftp(1) to Sunil's new ftp(1). The necessary modifications
have been made to make it behave. Any new misbehaviors can be fixed in tree.

OK florian@ deraadt@ "Have you committed ftp yet?"

Use the monotonic clock for logging progress in cdio(1) and ftp(1).

Keeps the progress log from blipping or stalling if, e.g., the
system time is changed in the midst of a rip or a transfer.

ok tb@ jca@

Avoid a possible leak in progressmeter

From Scott Cheloha, ok bluhm@

Nuke whitespace foolish enough to expose itself during the great
"warning:" rectification.

#ifndef SMALL around a couple of non-SMALL labels.

ok deraadt@

Don't attempt to read .netrc when we already force anonymous FTP (-a).

Patch from Anton Lindqvist via tech@, thanks!

okay deraadt@

Use connect(2) + a connect_wait() function instead of connect_sync(),
similar to the example in connect(2). OK tedu@

Move connect_sync() to util.c and use it when connecting via http
too. OK sthen@ deraadt@

Convert remaining calls to strtoq/strtouq in base with strtoll/strtoull.
Fix a type mismatch in ftp's "page" command and could make transfers restart
at the wrong position.

ok and a ull->ll tweak from natano@, ok tedu@

these programs probably do not need to use TMPDIR. ok florian

More "(<blah> *)0" -> NULL, avoiding any stdarg functions.

Feedback millert@ kettenis@

Remove NULL-checks before free(). ok tb@

unrelated commit; not ready yet

First casualty of making pledge "dns" mandatory for dns users.
"dns" was missing, and this was relying on "inet" support..

A whole buncha unsigned char casts for ctype function arguments.

ok guenther@

Eliminate use of TM_YEAR_BASE. OK guenther@ deraadt@ miod@

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

remove the safeguard against porting to machines without 8 bit bytes.
allows removing sys/param.h include as well.

remove tenex transfer support. if you still have TOPS20 machines in
service, you'll need to stick with openbsd 5.6.
bonus: remove references to ebcdic.
ok deraadt

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

I found a number of interactive events which can cause signals, and go
down paths not previously marked as signal handled unsafe. Try to clean
up a few of them especially regarding errno, mark others as unsafe, and
repair a few by avoiding stdio. Glanced at by misc people in Slovenia,
but considered too risky before release..

Unbreak ftp progress meter after the introduction of the '-D' flag

ok tedu@

Add -D shorttitle support, so that the progress meter can show some sort
of reason why it is processing a certain file. This will be used by the
installer for that purpose.
ok krw rpe

do not walk off the prefix array, off by one; found by parfait
ok jsg millert

show which username login failed for; ok martynas

make it clean removing the ifdef SMALL maze. separate cmds and
small stuff. make it a fetcher. shrinks quite a bit
agreed by millert@, krw@
ok theo, sthen@

remove uploading and macros support from install media; to save
some space
discussed with theo, todd@, millert@
tested and looked over by sthen@

toast the rcsid strings which just get in the way

figure out titles automatically by using remote file name. remove
-T and just show titles by default for non-verbose transfers;
discussed with, ok theo, sthen@

make two similar text strings identical; improves consistency and shrinks
the text segment slightly (though due to padding it does not change the size
of the binary). ok martynas@

add a "-T title" option to ftp; this is is used in progress bar mode to
show which filename is being used. ok krw, mdoc repair from jmc

on some servers LIST defaults to LIST -a. ignore pseudo-directories
so that recursive transfers don't cause a loop. problem reported
and tested by Jesus Sanchez. string compare inlining and looks
good to millert@

default file transfer type is binary, not ascii;
commands which toggle settings can take an explicit on or off argument
to force the setting appropiately, show these arguments in usage;
synchronize synopsis and usage of commands; spacing; KNF;
other minor documentation tweaks.

written with help by jmc@

ok jmc@ (documentation), martynas@ (type usage and default file transfer type)

- add support for recursive transfers (but not for floppies), e.g.
'mget -cr 4.*' would recursively fetch (-r), and resume the previous
transfers (-c) of 4.X release directories
uses local matching (fnmatch), but only for recursive transfers.
current behavior is not changed in any way.
- while here, ifndef SMALL debugging stuff, this saves some space,
for floppies
- some debugging code was enabled for non-debugging mode, checks
assume debug is set to zero, but it's not initially set
- all "Confirm with" prompts are forced, remove redundant argument
- fix usage: -C and -c are not available for SMALL

discussed a year ago w/ pyr@
looks good to millert@
previous version looked good to pyr@
man page tweaks & ok jmc@

First pass at removing clauses 3 and 4 from NetBSD licenses.

Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code that NetBSD has claimed for itself without attributing to the
actual authors.

OK deraadt@

in resume mode, pass -c to mget when {dir,file}hasglob, so that i'm
able to continue multiple transfers with -C; ok millert@
while here fix some comments (!SMALL vs. SMALL stuff), and add
missing

- add 'q', which does the same as eof
- add '?', which will help
- make use of mflag, instead of special-case interactive
- change mflag++ to mflag = 1, because theoretically it can go out
of range
"i like it" millert@. man page help and ok jmc@

fix transfer interrupting when confirmrest mode is used. change
confirm() to have a 'force' argument, so that ointer/oconf dance
is not needed, and to prevent further bugs like this; ok millert@

make further prompts work after eof, don't spam with prompts in
m*() cases; ok millert@

Remove #if 0 code that has been unused for nearly a decade (and
probably doesn't compile, since the types for some variables have
changed from long to char *).

OK millert@

use strcspn to properly overwrite '\n' in fgets returned buffer

ok pyr@, ray@, millert@, moritz@, chl@

Remove the .netrc parser when compiling a SMALL binary.
there is no .netrc file on the install media and keeping the parser
shaves a good deal of bytes in the binary.
ok millert@, "go on" deraadt@, "makes sense" steven@

Pass full buffer size to fgets.

OK moritz@ and jaredy@.

Add checks for fgets and properly overwrite newline.

Initial patch from Charles Longeau <chl at tuxfamily dot org>.

OK moritz@ and jaredy@.

Remove shadowing variables and properly use /* FALLTHROUGH */
comments. No binary change.

Found by lint.

OK beck@, deraadt@

two strtol calls that were begging to be converted to strtonum

Fix mget directory traversal vulnerability. From NetBSD. CAN-2002-1345.
ok millert@ deraadt@, prodding by david@

knf; cloder ok

type corrections and other delinting

ansi; khalek@linuxgamers.net

for -DSMALL, do not include rcsid[]s

New libedit api changes.

Tested by djm@, mouring@, jmc@.

ok deraadt@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Some NetBSD changes were committed to this file w/o updating the
copyright. I have gone through the cvs logs and added the appropriate
NetBSD Foundation copyright corresponding to those changes.

string fixes; ok miod henning

Treat empty environment variables the same as NULL. henning@ OK

http redirect support; adapted from NetBSD.

malloc/strdup failure not handled; cloder@acm.org

stretch banners

Fix gethostname() usage.

deraadt@ ok

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

first pass at a -Wall cleanup

Change default transfer type from ascii to binary; closes PR 1626
Similar to patch from mpech@prosoft.org.lv

0-size files still deserve a progress meter; also, after file is finished
transfer, display a non-ETA line with an elapsed time.

Work-around for lame servers that return `19100' for a date.

Based on NetBSD patch, slightly trimmed since we don't use the fractional
part yet...

ftp(1) from KAME, should be good for testing.

if winsize.ws_col is 0, assume 80

make the progress meter run correctly in all cases if in -m mode

make signal handlers save/restore errno

recommended fix from tri@iki.fi...

Y2K fixes from Andreas.Gunnarsson@emw.ericsson.se; culled from various places

prompting error; pr#352, blair@nac.net

Don't error out if the remote server doesn't support the "MDTM"
command. Based on a patch from Martin Fredriksson <martin@netman.se>.

- Move `parsed_url' label such that the next statement after the label is
not an "else" (which some strict compilers reject).

- If getlogin() fails fall back on getpwuid(getuid()).

Updtaes from NetBSD (lukem)
bugs fixed:
* don't interpret '-' or '|' when a local filename is determined from
the remote name (i.e, in mget, and in get with only one argument).
This is implemented using an extra argument to recvrequest().
Fixes a major security hole.
* clean up memory leak when using globulize()
* clean up a couple of comments
* fix wording in TNF copyright

features added:
* support for TIS fwtk gate-ftp servers:
* read defaults from $FTPSERVER && $FTPSERVERPORT
* start in gate-ftp mode if invoked as 'gate-ftp'
* toggle or set with 'gate [host [port]]'

Other changes:
* use symbolic flags in access(2)
* Use USHRT_MAX, not 0xffff

dumb fix for dumb users-- ftp's mget now idiot-proofs input!

Updates from NetBSD (lukem) include -Wall cleanup.
More -W* cleanup and in_port_t usage by me.

Disable progress meter if started as a bg process. Also don't
print the progress meter if the ftp process is put in the bg
(but do print it when/if the process is foregrounded).
From Enami Tsugutomo <enami@ba2.so-net.or.jp> with tweaks by me.

Only retry login as "anonymous" if we are doing anonftp.
Found by grr@openbsd.org.

This fixes FTP so that it first tries with the username FTP, and then with
the username ANONYMOUS. It works, too :-)

allow "ftp -aV ftp://host/foo.tar.gz | tar xvfpz -" to work

Sync with NetBSD (lukem):
* differentiate between being connected, and being logged in
* cleanup some text messages
* support username & password ftp URLs (ftp://user:pass@host/) in non-proxy
situations; assume proxy supports it for proxy situations.
* cd to / before performing any autofetch transfers

Sync with NetBSD (lukem)
* support $ftp_proxy for ftp:// transfers [bin/3245]
* add "more" & "less" as synonyms for "page"
* move editline setup code into controlediting(), and call appropriately.
only setup setup terminal if going into interactive mode.

Sync with NetBSD and fix "get foo.txt /dev/tty" wrt progress meter
and setting times.

Include signal.h where reasonable and make signal handlers match
what signal(3)'s prototype says (and cast when not).
Also change MAXFOO+1 -> MAXFOO since MAXFOO includes the NULL.
Support $TMPDIR and use utime(3) not utimes(2) for portability's sake.
Don't spew "Passive mode enabled/disabled" unless verbose (this means
togglevar() needs to watch for a NULL 'message').

Add back ``-r'' option and fix strncpy() usage and other nits because
I'm anal. Closer to KNF now.

Sync with NetBSD

Use non-blocking connect() with ppoll() and timeout instead of alarm().
For hosts with multiple IP addrs this makes it possible to fall
over from an unresponsive IP to another. This also replaces the
other connect(2) + connect_wait() calls with timed_connect() so the
-w option now works for more that just http. OK sthen@ deraadt@

introduce support for sending the If-Modified-Since header while
fetching over http(s) and use the timestamps from the remote server's
Last-Modified header if available when saving local files
this makes it possible to mirror files better with ftp(1)

the new timestamp behaviour can be disabled with the new '-u' flag

ok sthen@, input from sthen@ and gnezdo@

Accommodate POSIX basename(3) that takes a non-const parameter and
may modify the string buffer.

improved and ok jca@

in 2014 I added this annotation: /* XXX floating point printf in signal handler */
our snprintf is reentrant safe except for floating point.
Break the double apart into integer.integer notation, to avoid that.
ok kettenis millert

various knf and whitespace; ok jca

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

mkstemp() returns -1 on failure

Revert suni'ls ftp rewrite for now.
We are juggling too many things at the moment and we can't deal with
the differences in behaviour right now.

add rcs ids

Move us from old ftp(1) to Sunil's new ftp(1). The necessary modifications
have been made to make it behave. Any new misbehaviors can be fixed in tree.

OK florian@ deraadt@ "Have you committed ftp yet?"

Use the monotonic clock for logging progress in cdio(1) and ftp(1).

Keeps the progress log from blipping or stalling if, e.g., the
system time is changed in the midst of a rip or a transfer.

ok tb@ jca@

Avoid a possible leak in progressmeter

From Scott Cheloha, ok bluhm@

Nuke whitespace foolish enough to expose itself during the great
"warning:" rectification.

#ifndef SMALL around a couple of non-SMALL labels.

ok deraadt@

Don't attempt to read .netrc when we already force anonymous FTP (-a).

Patch from Anton Lindqvist via tech@, thanks!

okay deraadt@

Use connect(2) + a connect_wait() function instead of connect_sync(),
similar to the example in connect(2). OK tedu@

Move connect_sync() to util.c and use it when connecting via http
too. OK sthen@ deraadt@

Convert remaining calls to strtoq/strtouq in base with strtoll/strtoull.
Fix a type mismatch in ftp's "page" command and could make transfers restart
at the wrong position.

ok and a ull->ll tweak from natano@, ok tedu@

these programs probably do not need to use TMPDIR. ok florian

More "(<blah> *)0" -> NULL, avoiding any stdarg functions.

Feedback millert@ kettenis@

Remove NULL-checks before free(). ok tb@

unrelated commit; not ready yet

First casualty of making pledge "dns" mandatory for dns users.
"dns" was missing, and this was relying on "inet" support..

A whole buncha unsigned char casts for ctype function arguments.

ok guenther@

Eliminate use of TM_YEAR_BASE. OK guenther@ deraadt@ miod@

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

remove the safeguard against porting to machines without 8 bit bytes.
allows removing sys/param.h include as well.

remove tenex transfer support. if you still have TOPS20 machines in
service, you'll need to stick with openbsd 5.6.
bonus: remove references to ebcdic.
ok deraadt

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

I found a number of interactive events which can cause signals, and go
down paths not previously marked as signal handled unsafe. Try to clean
up a few of them especially regarding errno, mark others as unsafe, and
repair a few by avoiding stdio. Glanced at by misc people in Slovenia,
but considered too risky before release..

Unbreak ftp progress meter after the introduction of the '-D' flag

ok tedu@

Add -D shorttitle support, so that the progress meter can show some sort
of reason why it is processing a certain file. This will be used by the
installer for that purpose.
ok krw rpe

do not walk off the prefix array, off by one; found by parfait
ok jsg millert

show which username login failed for; ok martynas

make it clean removing the ifdef SMALL maze. separate cmds and
small stuff. make it a fetcher. shrinks quite a bit
agreed by millert@, krw@
ok theo, sthen@

remove uploading and macros support from install media; to save
some space
discussed with theo, todd@, millert@
tested and looked over by sthen@

toast the rcsid strings which just get in the way

figure out titles automatically by using remote file name. remove
-T and just show titles by default for non-verbose transfers;
discussed with, ok theo, sthen@

make two similar text strings identical; improves consistency and shrinks
the text segment slightly (though due to padding it does not change the size
of the binary). ok martynas@

add a "-T title" option to ftp; this is is used in progress bar mode to
show which filename is being used. ok krw, mdoc repair from jmc

on some servers LIST defaults to LIST -a. ignore pseudo-directories
so that recursive transfers don't cause a loop. problem reported
and tested by Jesus Sanchez. string compare inlining and looks
good to millert@

default file transfer type is binary, not ascii;
commands which toggle settings can take an explicit on or off argument
to force the setting appropiately, show these arguments in usage;
synchronize synopsis and usage of commands; spacing; KNF;
other minor documentation tweaks.

written with help by jmc@

ok jmc@ (documentation), martynas@ (type usage and default file transfer type)

- add support for recursive transfers (but not for floppies), e.g.
'mget -cr 4.*' would recursively fetch (-r), and resume the previous
transfers (-c) of 4.X release directories
uses local matching (fnmatch), but only for recursive transfers.
current behavior is not changed in any way.
- while here, ifndef SMALL debugging stuff, this saves some space,
for floppies
- some debugging code was enabled for non-debugging mode, checks
assume debug is set to zero, but it's not initially set
- all "Confirm with" prompts are forced, remove redundant argument
- fix usage: -C and -c are not available for SMALL

discussed a year ago w/ pyr@
looks good to millert@
previous version looked good to pyr@
man page tweaks & ok jmc@

First pass at removing clauses 3 and 4 from NetBSD licenses.

Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code that NetBSD has claimed for itself without attributing to the
actual authors.

OK deraadt@

in resume mode, pass -c to mget when {dir,file}hasglob, so that i'm
able to continue multiple transfers with -C; ok millert@
while here fix some comments (!SMALL vs. SMALL stuff), and add
missing

- add 'q', which does the same as eof
- add '?', which will help
- make use of mflag, instead of special-case interactive
- change mflag++ to mflag = 1, because theoretically it can go out
of range
"i like it" millert@. man page help and ok jmc@

fix transfer interrupting when confirmrest mode is used. change
confirm() to have a 'force' argument, so that ointer/oconf dance
is not needed, and to prevent further bugs like this; ok millert@

make further prompts work after eof, don't spam with prompts in
m*() cases; ok millert@

Remove #if 0 code that has been unused for nearly a decade (and
probably doesn't compile, since the types for some variables have
changed from long to char *).

OK millert@

use strcspn to properly overwrite '\n' in fgets returned buffer

ok pyr@, ray@, millert@, moritz@, chl@

Remove the .netrc parser when compiling a SMALL binary.
there is no .netrc file on the install media and keeping the parser
shaves a good deal of bytes in the binary.
ok millert@, "go on" deraadt@, "makes sense" steven@

Pass full buffer size to fgets.

OK moritz@ and jaredy@.

Add checks for fgets and properly overwrite newline.

Initial patch from Charles Longeau <chl at tuxfamily dot org>.

OK moritz@ and jaredy@.

Remove shadowing variables and properly use /* FALLTHROUGH */
comments. No binary change.

Found by lint.

OK beck@, deraadt@

two strtol calls that were begging to be converted to strtonum

Fix mget directory traversal vulnerability. From NetBSD. CAN-2002-1345.
ok millert@ deraadt@, prodding by david@

knf; cloder ok

type corrections and other delinting

ansi; khalek@linuxgamers.net

for -DSMALL, do not include rcsid[]s

New libedit api changes.

Tested by djm@, mouring@, jmc@.

ok deraadt@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Some NetBSD changes were committed to this file w/o updating the
copyright. I have gone through the cvs logs and added the appropriate
NetBSD Foundation copyright corresponding to those changes.

string fixes; ok miod henning

Treat empty environment variables the same as NULL. henning@ OK

http redirect support; adapted from NetBSD.

malloc/strdup failure not handled; cloder@acm.org

stretch banners

Fix gethostname() usage.

deraadt@ ok

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

first pass at a -Wall cleanup

Change default transfer type from ascii to binary; closes PR 1626
Similar to patch from mpech@prosoft.org.lv

0-size files still deserve a progress meter; also, after file is finished
transfer, display a non-ETA line with an elapsed time.

Work-around for lame servers that return `19100' for a date.

Based on NetBSD patch, slightly trimmed since we don't use the fractional
part yet...

ftp(1) from KAME, should be good for testing.

if winsize.ws_col is 0, assume 80

make the progress meter run correctly in all cases if in -m mode

make signal handlers save/restore errno

recommended fix from tri@iki.fi...

Y2K fixes from Andreas.Gunnarsson@emw.ericsson.se; culled from various places

prompting error; pr#352, blair@nac.net

Don't error out if the remote server doesn't support the "MDTM"
command. Based on a patch from Martin Fredriksson <martin@netman.se>.

- Move `parsed_url' label such that the next statement after the label is
not an "else" (which some strict compilers reject).

- If getlogin() fails fall back on getpwuid(getuid()).

Updtaes from NetBSD (lukem)
bugs fixed:
* don't interpret '-' or '|' when a local filename is determined from
the remote name (i.e, in mget, and in get with only one argument).
This is implemented using an extra argument to recvrequest().
Fixes a major security hole.
* clean up memory leak when using globulize()
* clean up a couple of comments
* fix wording in TNF copyright

features added:
* support for TIS fwtk gate-ftp servers:
* read defaults from $FTPSERVER && $FTPSERVERPORT
* start in gate-ftp mode if invoked as 'gate-ftp'
* toggle or set with 'gate [host [port]]'

Other changes:
* use symbolic flags in access(2)
* Use USHRT_MAX, not 0xffff

dumb fix for dumb users-- ftp's mget now idiot-proofs input!

Updates from NetBSD (lukem) include -Wall cleanup.
More -W* cleanup and in_port_t usage by me.

Disable progress meter if started as a bg process. Also don't
print the progress meter if the ftp process is put in the bg
(but do print it when/if the process is foregrounded).
From Enami Tsugutomo <enami@ba2.so-net.or.jp> with tweaks by me.

Only retry login as "anonymous" if we are doing anonftp.
Found by grr@openbsd.org.

This fixes FTP so that it first tries with the username FTP, and then with
the username ANONYMOUS. It works, too :-)

allow "ftp -aV ftp://host/foo.tar.gz | tar xvfpz -" to work

Sync with NetBSD (lukem):
* differentiate between being connected, and being logged in
* cleanup some text messages
* support username & password ftp URLs (ftp://user:pass@host/) in non-proxy
situations; assume proxy supports it for proxy situations.
* cd to / before performing any autofetch transfers

Sync with NetBSD (lukem)
* support $ftp_proxy for ftp:// transfers [bin/3245]
* add "more" & "less" as synonyms for "page"
* move editline setup code into controlediting(), and call appropriately.
only setup setup terminal if going into interactive mode.

Sync with NetBSD and fix "get foo.txt /dev/tty" wrt progress meter
and setting times.

Include signal.h where reasonable and make signal handlers match
what signal(3)'s prototype says (and cast when not).
Also change MAXFOO+1 -> MAXFOO since MAXFOO includes the NULL.
Support $TMPDIR and use utime(3) not utimes(2) for portability's sake.
Don't spew "Passive mode enabled/disabled" unless verbose (this means
togglevar() needs to watch for a NULL 'message').

Add back ``-r'' option and fix strncpy() usage and other nits because
I'm anal. Closer to KNF now.

Sync with NetBSD

introduce support for sending the If-Modified-Since header while
fetching over http(s) and use the timestamps from the remote server's
Last-Modified header if available when saving local files
this makes it possible to mirror files better with ftp(1)

the new timestamp behaviour can be disabled with the new '-u' flag

ok sthen@, input from sthen@ and gnezdo@

Accommodate POSIX basename(3) that takes a non-const parameter and
may modify the string buffer.

improved and ok jca@

in 2014 I added this annotation: /* XXX floating point printf in signal handler */
our snprintf is reentrant safe except for floating point.
Break the double apart into integer.integer notation, to avoid that.
ok kettenis millert

various knf and whitespace; ok jca

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

mkstemp() returns -1 on failure

Revert suni'ls ftp rewrite for now.
We are juggling too many things at the moment and we can't deal with
the differences in behaviour right now.

add rcs ids

Move us from old ftp(1) to Sunil's new ftp(1). The necessary modifications
have been made to make it behave. Any new misbehaviors can be fixed in tree.

OK florian@ deraadt@ "Have you committed ftp yet?"

Use the monotonic clock for logging progress in cdio(1) and ftp(1).

Keeps the progress log from blipping or stalling if, e.g., the
system time is changed in the midst of a rip or a transfer.

ok tb@ jca@

Avoid a possible leak in progressmeter

From Scott Cheloha, ok bluhm@

Nuke whitespace foolish enough to expose itself during the great
"warning:" rectification.

#ifndef SMALL around a couple of non-SMALL labels.

ok deraadt@

Don't attempt to read .netrc when we already force anonymous FTP (-a).

Patch from Anton Lindqvist via tech@, thanks!

okay deraadt@

Use connect(2) + a connect_wait() function instead of connect_sync(),
similar to the example in connect(2). OK tedu@

Move connect_sync() to util.c and use it when connecting via http
too. OK sthen@ deraadt@

Convert remaining calls to strtoq/strtouq in base with strtoll/strtoull.
Fix a type mismatch in ftp's "page" command and could make transfers restart
at the wrong position.

ok and a ull->ll tweak from natano@, ok tedu@

these programs probably do not need to use TMPDIR. ok florian

More "(<blah> *)0" -> NULL, avoiding any stdarg functions.

Feedback millert@ kettenis@

Remove NULL-checks before free(). ok tb@

unrelated commit; not ready yet

First casualty of making pledge "dns" mandatory for dns users.
"dns" was missing, and this was relying on "inet" support..

A whole buncha unsigned char casts for ctype function arguments.

ok guenther@

Eliminate use of TM_YEAR_BASE. OK guenther@ deraadt@ miod@

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

remove the safeguard against porting to machines without 8 bit bytes.
allows removing sys/param.h include as well.

remove tenex transfer support. if you still have TOPS20 machines in
service, you'll need to stick with openbsd 5.6.
bonus: remove references to ebcdic.
ok deraadt

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

I found a number of interactive events which can cause signals, and go
down paths not previously marked as signal handled unsafe. Try to clean
up a few of them especially regarding errno, mark others as unsafe, and
repair a few by avoiding stdio. Glanced at by misc people in Slovenia,
but considered too risky before release..

Unbreak ftp progress meter after the introduction of the '-D' flag

ok tedu@

Add -D shorttitle support, so that the progress meter can show some sort
of reason why it is processing a certain file. This will be used by the
installer for that purpose.
ok krw rpe

do not walk off the prefix array, off by one; found by parfait
ok jsg millert

show which username login failed for; ok martynas

make it clean removing the ifdef SMALL maze. separate cmds and
small stuff. make it a fetcher. shrinks quite a bit
agreed by millert@, krw@
ok theo, sthen@

remove uploading and macros support from install media; to save
some space
discussed with theo, todd@, millert@
tested and looked over by sthen@

toast the rcsid strings which just get in the way

figure out titles automatically by using remote file name. remove
-T and just show titles by default for non-verbose transfers;
discussed with, ok theo, sthen@

make two similar text strings identical; improves consistency and shrinks
the text segment slightly (though due to padding it does not change the size
of the binary). ok martynas@

add a "-T title" option to ftp; this is is used in progress bar mode to
show which filename is being used. ok krw, mdoc repair from jmc

on some servers LIST defaults to LIST -a. ignore pseudo-directories
so that recursive transfers don't cause a loop. problem reported
and tested by Jesus Sanchez. string compare inlining and looks
good to millert@

default file transfer type is binary, not ascii;
commands which toggle settings can take an explicit on or off argument
to force the setting appropiately, show these arguments in usage;
synchronize synopsis and usage of commands; spacing; KNF;
other minor documentation tweaks.

written with help by jmc@

ok jmc@ (documentation), martynas@ (type usage and default file transfer type)

- add support for recursive transfers (but not for floppies), e.g.
'mget -cr 4.*' would recursively fetch (-r), and resume the previous
transfers (-c) of 4.X release directories
uses local matching (fnmatch), but only for recursive transfers.
current behavior is not changed in any way.
- while here, ifndef SMALL debugging stuff, this saves some space,
for floppies
- some debugging code was enabled for non-debugging mode, checks
assume debug is set to zero, but it's not initially set
- all "Confirm with" prompts are forced, remove redundant argument
- fix usage: -C and -c are not available for SMALL

discussed a year ago w/ pyr@
looks good to millert@
previous version looked good to pyr@
man page tweaks & ok jmc@

First pass at removing clauses 3 and 4 from NetBSD licenses.

Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code that NetBSD has claimed for itself without attributing to the
actual authors.

OK deraadt@

in resume mode, pass -c to mget when {dir,file}hasglob, so that i'm
able to continue multiple transfers with -C; ok millert@
while here fix some comments (!SMALL vs. SMALL stuff), and add
missing

- add 'q', which does the same as eof
- add '?', which will help
- make use of mflag, instead of special-case interactive
- change mflag++ to mflag = 1, because theoretically it can go out
of range
"i like it" millert@. man page help and ok jmc@

fix transfer interrupting when confirmrest mode is used. change
confirm() to have a 'force' argument, so that ointer/oconf dance
is not needed, and to prevent further bugs like this; ok millert@

make further prompts work after eof, don't spam with prompts in
m*() cases; ok millert@

Remove #if 0 code that has been unused for nearly a decade (and
probably doesn't compile, since the types for some variables have
changed from long to char *).

OK millert@

use strcspn to properly overwrite '\n' in fgets returned buffer

ok pyr@, ray@, millert@, moritz@, chl@

Remove the .netrc parser when compiling a SMALL binary.
there is no .netrc file on the install media and keeping the parser
shaves a good deal of bytes in the binary.
ok millert@, "go on" deraadt@, "makes sense" steven@

Pass full buffer size to fgets.

OK moritz@ and jaredy@.

Add checks for fgets and properly overwrite newline.

Initial patch from Charles Longeau <chl at tuxfamily dot org>.

OK moritz@ and jaredy@.

Remove shadowing variables and properly use /* FALLTHROUGH */
comments. No binary change.

Found by lint.

OK beck@, deraadt@

two strtol calls that were begging to be converted to strtonum

Fix mget directory traversal vulnerability. From NetBSD. CAN-2002-1345.
ok millert@ deraadt@, prodding by david@

knf; cloder ok

type corrections and other delinting

ansi; khalek@linuxgamers.net

for -DSMALL, do not include rcsid[]s

New libedit api changes.

Tested by djm@, mouring@, jmc@.

ok deraadt@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Some NetBSD changes were committed to this file w/o updating the
copyright. I have gone through the cvs logs and added the appropriate
NetBSD Foundation copyright corresponding to those changes.

string fixes; ok miod henning

Treat empty environment variables the same as NULL. henning@ OK

http redirect support; adapted from NetBSD.

malloc/strdup failure not handled; cloder@acm.org

stretch banners

Fix gethostname() usage.

deraadt@ ok

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

first pass at a -Wall cleanup

Change default transfer type from ascii to binary; closes PR 1626
Similar to patch from mpech@prosoft.org.lv

0-size files still deserve a progress meter; also, after file is finished
transfer, display a non-ETA line with an elapsed time.

Work-around for lame servers that return `19100' for a date.

Based on NetBSD patch, slightly trimmed since we don't use the fractional
part yet...

ftp(1) from KAME, should be good for testing.

if winsize.ws_col is 0, assume 80

make the progress meter run correctly in all cases if in -m mode

make signal handlers save/restore errno

recommended fix from tri@iki.fi...

Y2K fixes from Andreas.Gunnarsson@emw.ericsson.se; culled from various places

prompting error; pr#352, blair@nac.net

Don't error out if the remote server doesn't support the "MDTM"
command. Based on a patch from Martin Fredriksson <martin@netman.se>.

- Move `parsed_url' label such that the next statement after the label is
not an "else" (which some strict compilers reject).

- If getlogin() fails fall back on getpwuid(getuid()).

Updtaes from NetBSD (lukem)
bugs fixed:
* don't interpret '-' or '|' when a local filename is determined from
the remote name (i.e, in mget, and in get with only one argument).
This is implemented using an extra argument to recvrequest().
Fixes a major security hole.
* clean up memory leak when using globulize()
* clean up a couple of comments
* fix wording in TNF copyright

features added:
* support for TIS fwtk gate-ftp servers:
* read defaults from $FTPSERVER && $FTPSERVERPORT
* start in gate-ftp mode if invoked as 'gate-ftp'
* toggle or set with 'gate [host [port]]'

Other changes:
* use symbolic flags in access(2)
* Use USHRT_MAX, not 0xffff

dumb fix for dumb users-- ftp's mget now idiot-proofs input!

Updates from NetBSD (lukem) include -Wall cleanup.
More -W* cleanup and in_port_t usage by me.

Disable progress meter if started as a bg process. Also don't
print the progress meter if the ftp process is put in the bg
(but do print it when/if the process is foregrounded).
From Enami Tsugutomo <enami@ba2.so-net.or.jp> with tweaks by me.

Only retry login as "anonymous" if we are doing anonftp.
Found by grr@openbsd.org.

This fixes FTP so that it first tries with the username FTP, and then with
the username ANONYMOUS. It works, too :-)

allow "ftp -aV ftp://host/foo.tar.gz | tar xvfpz -" to work

Sync with NetBSD (lukem):
* differentiate between being connected, and being logged in
* cleanup some text messages
* support username & password ftp URLs (ftp://user:pass@host/) in non-proxy
situations; assume proxy supports it for proxy situations.
* cd to / before performing any autofetch transfers

Sync with NetBSD (lukem)
* support $ftp_proxy for ftp:// transfers [bin/3245]
* add "more" & "less" as synonyms for "page"
* move editline setup code into controlediting(), and call appropriately.
only setup setup terminal if going into interactive mode.

Sync with NetBSD and fix "get foo.txt /dev/tty" wrt progress meter
and setting times.

Include signal.h where reasonable and make signal handlers match
what signal(3)'s prototype says (and cast when not).
Also change MAXFOO+1 -> MAXFOO since MAXFOO includes the NULL.
Support $TMPDIR and use utime(3) not utimes(2) for portability's sake.
Don't spew "Passive mode enabled/disabled" unless verbose (this means
togglevar() needs to watch for a NULL 'message').

Add back ``-r'' option and fix strncpy() usage and other nits because
I'm anal. Closer to KNF now.

Sync with NetBSD

Accommodate POSIX basename(3) that takes a non-const parameter and
may modify the string buffer.

improved and ok jca@

in 2014 I added this annotation: /* XXX floating point printf in signal handler */
our snprintf is reentrant safe except for floating point.
Break the double apart into integer.integer notation, to avoid that.
ok kettenis millert

various knf and whitespace; ok jca

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

mkstemp() returns -1 on failure

Revert suni'ls ftp rewrite for now.
We are juggling too many things at the moment and we can't deal with
the differences in behaviour right now.

add rcs ids

Move us from old ftp(1) to Sunil's new ftp(1). The necessary modifications
have been made to make it behave. Any new misbehaviors can be fixed in tree.

OK florian@ deraadt@ "Have you committed ftp yet?"

Use the monotonic clock for logging progress in cdio(1) and ftp(1).

Keeps the progress log from blipping or stalling if, e.g., the
system time is changed in the midst of a rip or a transfer.

ok tb@ jca@

Avoid a possible leak in progressmeter

From Scott Cheloha, ok bluhm@

Nuke whitespace foolish enough to expose itself during the great
"warning:" rectification.

#ifndef SMALL around a couple of non-SMALL labels.

ok deraadt@

Don't attempt to read .netrc when we already force anonymous FTP (-a).

Patch from Anton Lindqvist via tech@, thanks!

okay deraadt@

Use connect(2) + a connect_wait() function instead of connect_sync(),
similar to the example in connect(2). OK tedu@

Move connect_sync() to util.c and use it when connecting via http
too. OK sthen@ deraadt@

Convert remaining calls to strtoq/strtouq in base with strtoll/strtoull.
Fix a type mismatch in ftp's "page" command and could make transfers restart
at the wrong position.

ok and a ull->ll tweak from natano@, ok tedu@

these programs probably do not need to use TMPDIR. ok florian

More "(<blah> *)0" -> NULL, avoiding any stdarg functions.

Feedback millert@ kettenis@

Remove NULL-checks before free(). ok tb@

unrelated commit; not ready yet

First casualty of making pledge "dns" mandatory for dns users.
"dns" was missing, and this was relying on "inet" support..

A whole buncha unsigned char casts for ctype function arguments.

ok guenther@

Eliminate use of TM_YEAR_BASE. OK guenther@ deraadt@ miod@

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@

remove the safeguard against porting to machines without 8 bit bytes.
allows removing sys/param.h include as well.

remove tenex transfer support. if you still have TOPS20 machines in
service, you'll need to stick with openbsd 5.6.
bonus: remove references to ebcdic.
ok deraadt

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

I found a number of interactive events which can cause signals, and go
down paths not previously marked as signal handled unsafe. Try to clean
up a few of them especially regarding errno, mark others as unsafe, and
repair a few by avoiding stdio. Glanced at by misc people in Slovenia,
but considered too risky before release..

Unbreak ftp progress meter after the introduction of the '-D' flag

ok tedu@

Add -D shorttitle support, so that the progress meter can show some sort
of reason why it is processing a certain file. This will be used by the
installer for that purpose.
ok krw rpe

do not walk off the prefix array, off by one; found by parfait
ok jsg millert

show which username login failed for; ok martynas

make it clean removing the ifdef SMALL maze. separate cmds and
small stuff. make it a fetcher. shrinks quite a bit
agreed by millert@, krw@
ok theo, sthen@

remove uploading and macros support from install media; to save
some space
discussed with theo, todd@, millert@
tested and looked over by sthen@

toast the rcsid strings which just get in the way

figure out titles automatically by using remote file name. remove
-T and just show titles by default for non-verbose transfers;
discussed with, ok theo, sthen@

make two similar text strings identical; improves consistency and shrinks
the text segment slightly (though due to padding it does not change the size
of the binary). ok martynas@

add a "-T title" option to ftp; this is is used in progress bar mode to
show which filename is being used. ok krw, mdoc repair from jmc

on some servers LIST defaults to LIST -a. ignore pseudo-directories
so that recursive transfers don't cause a loop. problem reported
and tested by Jesus Sanchez. string compare inlining and looks
good to millert@

default file transfer type is binary, not ascii;
commands which toggle settings can take an explicit on or off argument
to force the setting appropiately, show these arguments in usage;
synchronize synopsis and usage of commands; spacing; KNF;
other minor documentation tweaks.

written with help by jmc@

ok jmc@ (documentation), martynas@ (type usage and default file transfer type)