userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

add -delete option which can simplify the common case of wanting to delete
lots of files without the arcane -exec or error prone xargs.
code from freebsd.
ok millert

use reallocarray
okay chl@, tedu@

Include unistd.h as it is the standard location for getopt().

exit if there is an unknown option; from FreeBSD
ok millert@

find: return exit code 1 if any path could not be traversed
matches posix and the manual, ok millert

find -LH was -L, but must be -H according to POSIX;
patch from Daniel Dickman <didickman at gmail dot com> via tech@,
though i'm updating the manual in a different way;
ok millert@ "looks good" deraadt@

We only need to fchdir(dotfd) for the -exec and -ok primaries so
defer the check for dotfd != -1 until we know we will need it.
Based on a diff from schwarze@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

ftsopen -> fts_open; partly from Alexander Holupirek, documentation/5472
ok simon art

remove -W from synopsis; ok deraadt@ jmc@

no more whiteouts

sync and make usage __dead, from Michael Knudsen

remove unused variable

- remove double spaces in the examples
- `W' before `X'
- sync usage()

ok millert@

better realloc. ok deraadt@ henning@

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

The standard way to get info on symlinks is -L, not -h; Peter Werner

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

expression is optional

Since we're in pedant mode again, we might as well be thorough. It's
bad form to assume that the absence of an expression will default to
"-print", as one may still encounter versions of find where this is
not the case. The examples given are all careful to use an explicit
"-print", so follow their lead and mark the expression as a required
field even though find will run without one.

o Expression is an optional argument to find(1);
noticed by Brian Poole <raj@cerias.purdue.edu>
o File is not an optional argument
o The section name referenced in beginning of the manual page
is "operators" so don't confuse people by speaking about
"operands"
Ok aaron@

first pass at a -Wall cleanup

Add -W option so -type W gets a chance to work.

Back out last change. Allowing no path to mean "." causes problems
with getopts vs. predicates.

If no paths are specified, use "."

Don't trample argv[], we want ps et al to be able to see args.

getopt(3) returns -1 when out of args, not EOF, whee!

Respond to SIGINFO; from PR #42

rcsid

branches: 1.1.1;
Initial revision

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

add -delete option which can simplify the common case of wanting to delete
lots of files without the arcane -exec or error prone xargs.
code from freebsd.
ok millert

use reallocarray
okay chl@, tedu@

Include unistd.h as it is the standard location for getopt().

exit if there is an unknown option; from FreeBSD
ok millert@

find: return exit code 1 if any path could not be traversed
matches posix and the manual, ok millert

find -LH was -L, but must be -H according to POSIX;
patch from Daniel Dickman <didickman at gmail dot com> via tech@,
though i'm updating the manual in a different way;
ok millert@ "looks good" deraadt@

We only need to fchdir(dotfd) for the -exec and -ok primaries so
defer the check for dotfd != -1 until we know we will need it.
Based on a diff from schwarze@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

ftsopen -> fts_open; partly from Alexander Holupirek, documentation/5472
ok simon art

remove -W from synopsis; ok deraadt@ jmc@

no more whiteouts

sync and make usage __dead, from Michael Knudsen

remove unused variable

- remove double spaces in the examples
- `W' before `X'
- sync usage()

ok millert@

better realloc. ok deraadt@ henning@

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

The standard way to get info on symlinks is -L, not -h; Peter Werner

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

expression is optional

Since we're in pedant mode again, we might as well be thorough. It's
bad form to assume that the absence of an expression will default to
"-print", as one may still encounter versions of find where this is
not the case. The examples given are all careful to use an explicit
"-print", so follow their lead and mark the expression as a required
field even though find will run without one.

o Expression is an optional argument to find(1);
noticed by Brian Poole <raj@cerias.purdue.edu>
o File is not an optional argument
o The section name referenced in beginning of the manual page
is "operators" so don't confuse people by speaking about
"operands"
Ok aaron@

first pass at a -Wall cleanup

Add -W option so -type W gets a chance to work.

Back out last change. Allowing no path to mean "." causes problems
with getopts vs. predicates.

If no paths are specified, use "."

Don't trample argv[], we want ps et al to be able to see args.

getopt(3) returns -1 when out of args, not EOF, whee!

Respond to SIGINFO; from PR #42

rcsid

branches: 1.1.1;
Initial revision

add -delete option which can simplify the common case of wanting to delete
lots of files without the arcane -exec or error prone xargs.
code from freebsd.
ok millert

use reallocarray
okay chl@, tedu@

Include unistd.h as it is the standard location for getopt().

exit if there is an unknown option; from FreeBSD
ok millert@

find: return exit code 1 if any path could not be traversed
matches posix and the manual, ok millert

find -LH was -L, but must be -H according to POSIX;
patch from Daniel Dickman <didickman at gmail dot com> via tech@,
though i'm updating the manual in a different way;
ok millert@ "looks good" deraadt@

We only need to fchdir(dotfd) for the -exec and -ok primaries so
defer the check for dotfd != -1 until we know we will need it.
Based on a diff from schwarze@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

ftsopen -> fts_open; partly from Alexander Holupirek, documentation/5472
ok simon art

remove -W from synopsis; ok deraadt@ jmc@

no more whiteouts

sync and make usage __dead, from Michael Knudsen

remove unused variable

- remove double spaces in the examples
- `W' before `X'
- sync usage()

ok millert@

better realloc. ok deraadt@ henning@

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

The standard way to get info on symlinks is -L, not -h; Peter Werner

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

expression is optional

Since we're in pedant mode again, we might as well be thorough. It's
bad form to assume that the absence of an expression will default to
"-print", as one may still encounter versions of find where this is
not the case. The examples given are all careful to use an explicit
"-print", so follow their lead and mark the expression as a required
field even though find will run without one.

o Expression is an optional argument to find(1);
noticed by Brian Poole <raj@cerias.purdue.edu>
o File is not an optional argument
o The section name referenced in beginning of the manual page
is "operators" so don't confuse people by speaking about
"operands"
Ok aaron@

first pass at a -Wall cleanup

Add -W option so -type W gets a chance to work.

Back out last change. Allowing no path to mean "." causes problems
with getopts vs. predicates.

If no paths are specified, use "."

Don't trample argv[], we want ps et al to be able to see args.

getopt(3) returns -1 when out of args, not EOF, whee!

Respond to SIGINFO; from PR #42

rcsid

branches: 1.1.1;
Initial revision