We have sockaddr_storage these days, get rid of isc_sockaddr_t.
OK beck, "beautiful" deraadt

Mechanically replace isc_boolean_t with int.
OK deraadt

Get rid of isc_parse_uint32() and replace it with strtonum.
While here use the standard strtonum error messages.

input & OK beck, OK kn

Rather than attempting to lookup the keyword "set" as a hostname,
issue a usage message. This matches both historical behaviour, and
the operation upon other keywords.
ok florian

traditional nslookup would not fatal if the server name was undiscoverable.
change lower level code to return an error, and bump the fatal for host(1)
upwards, then tweak nslookup to work nicely

Stop generating rdatastruct.h and put the dns_rdata_* structs for
cname, ns, soa, and tsig directly into rdata.h

We only need to create cname, ns, soa and tsig structs.
OK jsg

We only need to free cname, ns, soa and tsig structs.
OK jsg

simplify signal setup and remove block/unblock/is_running/reload

with input from florian

ok millert florian

Get rid of ISC_MAGIC and ISC_MAGIC_VALID macros.
While pulling on that it turns out we can / need git rid of a isc_task
-> isc__task, isc_taskmgr -> isc__taskmgr, isc_timer -> isc__timer and
isc_socket -> isc__socket indirection.
OK millert

+trace has the RD bit cleared however it asks the nameserver from
/etc/resolv.conf for a list of root name servers.
Arguably corectly configured recursive nameservers should REFUSE to
answer this question to prevent cache snooping.
Upstream fixed this after the license change by sending the first
query with RD set.
We go a different route, built in a list of root name servers and ask
them. Otherwise known as a priming query. This way +trace does not depend
on any localy configured nameserver in /etc/resolv.conf

"I have no other quibbles" deraadt@
input & OK sthen

remove uneeded #include lines

ok florian@

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

Mechanically replace isc_boolean_t with int.
OK deraadt

Get rid of isc_parse_uint32() and replace it with strtonum.
While here use the standard strtonum error messages.

input & OK beck, OK kn

Rather than attempting to lookup the keyword "set" as a hostname,
issue a usage message. This matches both historical behaviour, and
the operation upon other keywords.
ok florian

traditional nslookup would not fatal if the server name was undiscoverable.
change lower level code to return an error, and bump the fatal for host(1)
upwards, then tweak nslookup to work nicely

Stop generating rdatastruct.h and put the dns_rdata_* structs for
cname, ns, soa, and tsig directly into rdata.h

We only need to create cname, ns, soa and tsig structs.
OK jsg

We only need to free cname, ns, soa and tsig structs.
OK jsg

simplify signal setup and remove block/unblock/is_running/reload

with input from florian

ok millert florian

Get rid of ISC_MAGIC and ISC_MAGIC_VALID macros.
While pulling on that it turns out we can / need git rid of a isc_task
-> isc__task, isc_taskmgr -> isc__taskmgr, isc_timer -> isc__timer and
isc_socket -> isc__socket indirection.
OK millert

+trace has the RD bit cleared however it asks the nameserver from
/etc/resolv.conf for a list of root name servers.
Arguably corectly configured recursive nameservers should REFUSE to
answer this question to prevent cache snooping.
Upstream fixed this after the license change by sending the first
query with RD set.
We go a different route, built in a list of root name servers and ask
them. Otherwise known as a priming query. This way +trace does not depend
on any localy configured nameserver in /etc/resolv.conf

"I have no other quibbles" deraadt@
input & OK sthen

remove uneeded #include lines

ok florian@

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

Get rid of isc_parse_uint32() and replace it with strtonum.
While here use the standard strtonum error messages.

input & OK beck, OK kn

Rather than attempting to lookup the keyword "set" as a hostname,
issue a usage message. This matches both historical behaviour, and
the operation upon other keywords.
ok florian

traditional nslookup would not fatal if the server name was undiscoverable.
change lower level code to return an error, and bump the fatal for host(1)
upwards, then tweak nslookup to work nicely

Stop generating rdatastruct.h and put the dns_rdata_* structs for
cname, ns, soa, and tsig directly into rdata.h

We only need to create cname, ns, soa and tsig structs.
OK jsg

We only need to free cname, ns, soa and tsig structs.
OK jsg

simplify signal setup and remove block/unblock/is_running/reload

with input from florian

ok millert florian

Get rid of ISC_MAGIC and ISC_MAGIC_VALID macros.
While pulling on that it turns out we can / need git rid of a isc_task
-> isc__task, isc_taskmgr -> isc__taskmgr, isc_timer -> isc__timer and
isc_socket -> isc__socket indirection.
OK millert

+trace has the RD bit cleared however it asks the nameserver from
/etc/resolv.conf for a list of root name servers.
Arguably corectly configured recursive nameservers should REFUSE to
answer this question to prevent cache snooping.
Upstream fixed this after the license change by sending the first
query with RD set.
We go a different route, built in a list of root name servers and ask
them. Otherwise known as a priming query. This way +trace does not depend
on any localy configured nameserver in /etc/resolv.conf

"I have no other quibbles" deraadt@
input & OK sthen

remove uneeded #include lines

ok florian@

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

Rather than attempting to lookup the keyword "set" as a hostname,
issue a usage message. This matches both historical behaviour, and
the operation upon other keywords.
ok florian

traditional nslookup would not fatal if the server name was undiscoverable.
change lower level code to return an error, and bump the fatal for host(1)
upwards, then tweak nslookup to work nicely

Stop generating rdatastruct.h and put the dns_rdata_* structs for
cname, ns, soa, and tsig directly into rdata.h

We only need to create cname, ns, soa and tsig structs.
OK jsg

We only need to free cname, ns, soa and tsig structs.
OK jsg

simplify signal setup and remove block/unblock/is_running/reload

with input from florian

ok millert florian

Get rid of ISC_MAGIC and ISC_MAGIC_VALID macros.
While pulling on that it turns out we can / need git rid of a isc_task
-> isc__task, isc_taskmgr -> isc__taskmgr, isc_timer -> isc__timer and
isc_socket -> isc__socket indirection.
OK millert

+trace has the RD bit cleared however it asks the nameserver from
/etc/resolv.conf for a list of root name servers.
Arguably corectly configured recursive nameservers should REFUSE to
answer this question to prevent cache snooping.
Upstream fixed this after the license change by sending the first
query with RD set.
We go a different route, built in a list of root name servers and ask
them. Otherwise known as a priming query. This way +trace does not depend
on any localy configured nameserver in /etc/resolv.conf

"I have no other quibbles" deraadt@
input & OK sthen

remove uneeded #include lines

ok florian@

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

traditional nslookup would not fatal if the server name was undiscoverable.
change lower level code to return an error, and bump the fatal for host(1)
upwards, then tweak nslookup to work nicely

Stop generating rdatastruct.h and put the dns_rdata_* structs for
cname, ns, soa, and tsig directly into rdata.h

We only need to create cname, ns, soa and tsig structs.
OK jsg

We only need to free cname, ns, soa and tsig structs.
OK jsg

simplify signal setup and remove block/unblock/is_running/reload

with input from florian

ok millert florian

Get rid of ISC_MAGIC and ISC_MAGIC_VALID macros.
While pulling on that it turns out we can / need git rid of a isc_task
-> isc__task, isc_taskmgr -> isc__taskmgr, isc_timer -> isc__timer and
isc_socket -> isc__socket indirection.
OK millert

+trace has the RD bit cleared however it asks the nameserver from
/etc/resolv.conf for a list of root name servers.
Arguably corectly configured recursive nameservers should REFUSE to
answer this question to prevent cache snooping.
Upstream fixed this after the license change by sending the first
query with RD set.
We go a different route, built in a list of root name servers and ask
them. Otherwise known as a priming query. This way +trace does not depend
on any localy configured nameserver in /etc/resolv.conf

"I have no other quibbles" deraadt@
input & OK sthen

remove uneeded #include lines

ok florian@

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

Stop generating rdatastruct.h and put the dns_rdata_* structs for
cname, ns, soa, and tsig directly into rdata.h

We only need to create cname, ns, soa and tsig structs.
OK jsg

We only need to free cname, ns, soa and tsig structs.
OK jsg

simplify signal setup and remove block/unblock/is_running/reload

with input from florian

ok millert florian

Get rid of ISC_MAGIC and ISC_MAGIC_VALID macros.
While pulling on that it turns out we can / need git rid of a isc_task
-> isc__task, isc_taskmgr -> isc__taskmgr, isc_timer -> isc__timer and
isc_socket -> isc__socket indirection.
OK millert

+trace has the RD bit cleared however it asks the nameserver from
/etc/resolv.conf for a list of root name servers.
Arguably corectly configured recursive nameservers should REFUSE to
answer this question to prevent cache snooping.
Upstream fixed this after the license change by sending the first
query with RD set.
We go a different route, built in a list of root name servers and ask
them. Otherwise known as a priming query. This way +trace does not depend
on any localy configured nameserver in /etc/resolv.conf

"I have no other quibbles" deraadt@
input & OK sthen

remove uneeded #include lines

ok florian@

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

simplify signal setup and remove block/unblock/is_running/reload

with input from florian

ok millert florian

Get rid of ISC_MAGIC and ISC_MAGIC_VALID macros.
While pulling on that it turns out we can / need git rid of a isc_task
-> isc__task, isc_taskmgr -> isc__taskmgr, isc_timer -> isc__timer and
isc_socket -> isc__socket indirection.
OK millert

+trace has the RD bit cleared however it asks the nameserver from
/etc/resolv.conf for a list of root name servers.
Arguably corectly configured recursive nameservers should REFUSE to
answer this question to prevent cache snooping.
Upstream fixed this after the license change by sending the first
query with RD set.
We go a different route, built in a list of root name servers and ask
them. Otherwise known as a priming query. This way +trace does not depend
on any localy configured nameserver in /etc/resolv.conf

"I have no other quibbles" deraadt@
input & OK sthen

remove uneeded #include lines

ok florian@

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

Get rid of ISC_MAGIC and ISC_MAGIC_VALID macros.
While pulling on that it turns out we can / need git rid of a isc_task
-> isc__task, isc_taskmgr -> isc__taskmgr, isc_timer -> isc__timer and
isc_socket -> isc__socket indirection.
OK millert

+trace has the RD bit cleared however it asks the nameserver from
/etc/resolv.conf for a list of root name servers.
Arguably corectly configured recursive nameservers should REFUSE to
answer this question to prevent cache snooping.
Upstream fixed this after the license change by sending the first
query with RD set.
We go a different route, built in a list of root name servers and ask
them. Otherwise known as a priming query. This way +trace does not depend
on any localy configured nameserver in /etc/resolv.conf

"I have no other quibbles" deraadt@
input & OK sthen

remove uneeded #include lines

ok florian@

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

+trace has the RD bit cleared however it asks the nameserver from
/etc/resolv.conf for a list of root name servers.
Arguably corectly configured recursive nameservers should REFUSE to
answer this question to prevent cache snooping.
Upstream fixed this after the license change by sending the first
query with RD set.
We go a different route, built in a list of root name servers and ask
them. Otherwise known as a priming query. This way +trace does not depend
on any localy configured nameserver in /etc/resolv.conf

"I have no other quibbles" deraadt@
input & OK sthen

remove uneeded #include lines

ok florian@

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

remove uneeded #include lines

ok florian@

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen