dig: fix -Wunused-but-set-variable warnings

with and ok florian@

Rewrite parse_netprefix to no longer use isc_sockaddr_fromin{,6}.
Since this was the last user of those functions we can delete them.
OK otto

Use IN_MULTICAST correctly, so it checks the IP address rather than the
pointer to it.

ok florian@

We have sockaddr_storage these days, get rid of isc_sockaddr_t.
OK beck, "beautiful" deraadt

The various sockaddr structures have length fields these days.
OK beck

we no longer need isc_netaddr_t
OK beck, deraadt (who also OK'ed the previous two diffs)

move islinklocal, ismulticast, issitelocal from netaddr to sockaddr
OK beck

Mechanically replace isc_boolean_t with int.
OK deraadt

Bunch of dead stores and otherwise unused stuff lets us get rid of
unix/net.{c.h}. We need to sprinkle in a few #includes that net.h
dragged in.
OK deraadt

reduce multiple newlines

While we do have AF_UNIX support, dig doesn't use it.

remove more uneeded include statements and files

remove some unreferenced functions

ok florian@

remove uneeded #include lines

ok florian@

unifdef feature checks; we have all these things.
OK millert

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

Rewrite parse_netprefix to no longer use isc_sockaddr_fromin{,6}.
Since this was the last user of those functions we can delete them.
OK otto

Use IN_MULTICAST correctly, so it checks the IP address rather than the
pointer to it.

ok florian@

We have sockaddr_storage these days, get rid of isc_sockaddr_t.
OK beck, "beautiful" deraadt

The various sockaddr structures have length fields these days.
OK beck

we no longer need isc_netaddr_t
OK beck, deraadt (who also OK'ed the previous two diffs)

move islinklocal, ismulticast, issitelocal from netaddr to sockaddr
OK beck

Mechanically replace isc_boolean_t with int.
OK deraadt

Bunch of dead stores and otherwise unused stuff lets us get rid of
unix/net.{c.h}. We need to sprinkle in a few #includes that net.h
dragged in.
OK deraadt

reduce multiple newlines

While we do have AF_UNIX support, dig doesn't use it.

remove more uneeded include statements and files

remove some unreferenced functions

ok florian@

remove uneeded #include lines

ok florian@

unifdef feature checks; we have all these things.
OK millert

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

Use IN_MULTICAST correctly, so it checks the IP address rather than the
pointer to it.

ok florian@

We have sockaddr_storage these days, get rid of isc_sockaddr_t.
OK beck, "beautiful" deraadt

The various sockaddr structures have length fields these days.
OK beck

we no longer need isc_netaddr_t
OK beck, deraadt (who also OK'ed the previous two diffs)

move islinklocal, ismulticast, issitelocal from netaddr to sockaddr
OK beck

Mechanically replace isc_boolean_t with int.
OK deraadt

Bunch of dead stores and otherwise unused stuff lets us get rid of
unix/net.{c.h}. We need to sprinkle in a few #includes that net.h
dragged in.
OK deraadt

reduce multiple newlines

While we do have AF_UNIX support, dig doesn't use it.

remove more uneeded include statements and files

remove some unreferenced functions

ok florian@

remove uneeded #include lines

ok florian@

unifdef feature checks; we have all these things.
OK millert

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

We have sockaddr_storage these days, get rid of isc_sockaddr_t.
OK beck, "beautiful" deraadt

The various sockaddr structures have length fields these days.
OK beck

we no longer need isc_netaddr_t
OK beck, deraadt (who also OK'ed the previous two diffs)

move islinklocal, ismulticast, issitelocal from netaddr to sockaddr
OK beck

Mechanically replace isc_boolean_t with int.
OK deraadt

Bunch of dead stores and otherwise unused stuff lets us get rid of
unix/net.{c.h}. We need to sprinkle in a few #includes that net.h
dragged in.
OK deraadt

reduce multiple newlines

While we do have AF_UNIX support, dig doesn't use it.

remove more uneeded include statements and files

remove some unreferenced functions

ok florian@

remove uneeded #include lines

ok florian@

unifdef feature checks; we have all these things.
OK millert

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

We have sockaddr_storage these days, get rid of isc_sockaddr_t.
OK beck, "beautiful" deraadt

The various sockaddr structures have length fields these days.
OK beck

we no longer need isc_netaddr_t
OK beck, deraadt (who also OK'ed the previous two diffs)

move islinklocal, ismulticast, issitelocal from netaddr to sockaddr
OK beck

Mechanically replace isc_boolean_t with int.
OK deraadt

Bunch of dead stores and otherwise unused stuff lets us get rid of
unix/net.{c.h}. We need to sprinkle in a few #includes that net.h
dragged in.
OK deraadt

reduce multiple newlines

While we do have AF_UNIX support, dig doesn't use it.

remove more uneeded include statements and files

remove some unreferenced functions

ok florian@

remove uneeded #include lines

ok florian@

unifdef feature checks; we have all these things.
OK millert

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

Mechanically replace isc_boolean_t with int.
OK deraadt

Bunch of dead stores and otherwise unused stuff lets us get rid of
unix/net.{c.h}. We need to sprinkle in a few #includes that net.h
dragged in.
OK deraadt

reduce multiple newlines

While we do have AF_UNIX support, dig doesn't use it.

remove more uneeded include statements and files

remove some unreferenced functions

ok florian@

remove uneeded #include lines

ok florian@

unifdef feature checks; we have all these things.
OK millert

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

reduce multiple newlines

While we do have AF_UNIX support, dig doesn't use it.

remove more uneeded include statements and files

remove some unreferenced functions

ok florian@

remove uneeded #include lines

ok florian@

unifdef feature checks; we have all these things.
OK millert

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

While we do have AF_UNIX support, dig doesn't use it.

remove more uneeded include statements and files

remove some unreferenced functions

ok florian@

remove uneeded #include lines

ok florian@

unifdef feature checks; we have all these things.
OK millert

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

remove some unreferenced functions

ok florian@

remove uneeded #include lines

ok florian@

unifdef feature checks; we have all these things.
OK millert

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen

remove uneeded #include lines

ok florian@

unifdef feature checks; we have all these things.
OK millert

Move dig(1) and needed DNS libraries into it's own source directory in
usr.bin/dig.

From the beginning when we started to remove unneeded nameserver code,
it was our goal to extract dig functionality from the bind sources,
for everyone's benefit as this is easier to reason about.

In total we removed about 2/3 or over 300.000 lines of code.

We kept the lib/ subdirectory layout but moved the content of bin/ to
the top from the old bind source directory.

Previous sources and history can be found in the src/usr.sbin/bind
Attic.

With & OK deraadt
Proposed directory layout sounds good to sthen