userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

Change all tame callers to namechange to pledge(2).

col can be locked down with tame "stdio", in case it is fed nasty input,
or if it has bugs. The previous commits by schwarze indicate the latter
case was very true until recently...
ok doug

For half and reverse line feeds, recognize SUSv2-style escape-digit
sequences in the input stream in addition to traditional BSD-style
escape-control-char sequences because traditional tools, for example
Heirloom roff, produce SUSv2-style sequences. Switch the encoding
of forward half line feeds in the output of -f back to SUSv2 style
because that's likely to work with more tools than the non-standard
traditional BSD-style sequence. Fully document these choices.

Issues originally reported by bapt at FreeBSD.
OK millert@ jmc@, and bapt@ also more or less agrees with the direction.

Avoid scattering octal escapes all over the place,
use the definitions given at the top of the file.
No functional change.
From bapt at FreeBSD.

Fix about ten integer overflows and underflows and a handful of logic
errors in line number handling. Detailed explanations were sent to tech@
on October 18, 2014.
OK doug@, and bapt at FreeBSD says he likes the direction

Correctly encode half line feed in the output stream for -f;
this patch only changes two bits, note that '\011' != '9' == '\071'.
Bug introduced by the original author, Michael Rendell, and
committed by Keith Bostic on May 22, 1990 (CSRG SCCS rev. 5.1).

The following operating systems are affected: 4.3BSD Reno, BSD Net/2,
4.4BSD, 4.4BSD Lite1, 4.4BSD Lite2, and all versions of 386BSD,
NetBSD, OpenBSD, FreeBSD, DragonFly, Debian GNU/Linux (package
bsdmainutils) and probably many others.

"that's a fun one" millert@, "nice find" deraadt@

1) Fix a segfault triggered by an input line containing two consecutive
backspace characters beyond column MAX_SHRT, overflowing c_column.
2) Fix imcomplete initialization of the final element of the *count
array by adding a missing pair of parentheses.
3) For code clarity and extra safety, change all variables dealing
with column numbers from int to size_t such that they cannot overflow.
Found while reviewing the patch from deraadt@'s reallocarray() rampage.
Feedback and OK millert@.

use the reallocarray idiom; ok ingo

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

use strtonum; ok millert@

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Sync usage() output with man page; mpech@prosoft.org.lv

use err(3)

(foo *)NULL -> NULL + err msg for realloc failure

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

Change all tame callers to namechange to pledge(2).

col can be locked down with tame "stdio", in case it is fed nasty input,
or if it has bugs. The previous commits by schwarze indicate the latter
case was very true until recently...
ok doug

For half and reverse line feeds, recognize SUSv2-style escape-digit
sequences in the input stream in addition to traditional BSD-style
escape-control-char sequences because traditional tools, for example
Heirloom roff, produce SUSv2-style sequences. Switch the encoding
of forward half line feeds in the output of -f back to SUSv2 style
because that's likely to work with more tools than the non-standard
traditional BSD-style sequence. Fully document these choices.

Issues originally reported by bapt at FreeBSD.
OK millert@ jmc@, and bapt@ also more or less agrees with the direction.

Avoid scattering octal escapes all over the place,
use the definitions given at the top of the file.
No functional change.
From bapt at FreeBSD.

Fix about ten integer overflows and underflows and a handful of logic
errors in line number handling. Detailed explanations were sent to tech@
on October 18, 2014.
OK doug@, and bapt at FreeBSD says he likes the direction

Correctly encode half line feed in the output stream for -f;
this patch only changes two bits, note that '\011' != '9' == '\071'.
Bug introduced by the original author, Michael Rendell, and
committed by Keith Bostic on May 22, 1990 (CSRG SCCS rev. 5.1).

The following operating systems are affected: 4.3BSD Reno, BSD Net/2,
4.4BSD, 4.4BSD Lite1, 4.4BSD Lite2, and all versions of 386BSD,
NetBSD, OpenBSD, FreeBSD, DragonFly, Debian GNU/Linux (package
bsdmainutils) and probably many others.

"that's a fun one" millert@, "nice find" deraadt@

1) Fix a segfault triggered by an input line containing two consecutive
backspace characters beyond column MAX_SHRT, overflowing c_column.
2) Fix imcomplete initialization of the final element of the *count
array by adding a missing pair of parentheses.
3) For code clarity and extra safety, change all variables dealing
with column numbers from int to size_t such that they cannot overflow.
Found while reviewing the patch from deraadt@'s reallocarray() rampage.
Feedback and OK millert@.

use the reallocarray idiom; ok ingo

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

use strtonum; ok millert@

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Sync usage() output with man page; mpech@prosoft.org.lv

use err(3)

(foo *)NULL -> NULL + err msg for realloc failure

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision